laforge has uploaded this change for review.

View Change

log_taget_find() should use enum log_target_type, not int

This has shown up in -Wsign-compare

Change-Id: I2f5ba81aa0328db7db29f49f26de4cea3f522789
---
M include/osmocom/core/logging.h
M src/logging.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/26812/1

diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h
index 7907734..4a34c7d 100644
--- a/include/osmocom/core/logging.h
+++ b/include/osmocom/core/logging.h
@@ -431,7 +431,7 @@
 void log_add_target(struct log_target *target);
 void log_del_target(struct log_target *target);
 
-struct log_target *log_target_find(int type, const char *fname);
+struct log_target *log_target_find(enum log_target_type type, const char *fname);
 
 void log_enable_multithread(void);
 
diff --git a/src/logging.c b/src/logging.c
index 7f6dbb5..9d2a065 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -1259,7 +1259,7 @@
  *  \returns Log target (if found), NULL otherwise
  *  Must be called with mutex osmo_log_tgt_mutex held, see log_tgt_mutex_lock.
  */
-struct log_target *log_target_find(int type, const char *fname)
+struct log_target *log_target_find(enum log_target_type type, const char *fname)
 {
 	struct log_target *tgt;
 

To view, visit change 26812. To unsubscribe, or for help writing mail filters, visit settings.