Attention is currently required from: clufn, laforge.

View Change

3 comments:

• File src/conv.erl:

  • Patch Set #5, Line 69: remove_prefix(<<A:8, Rest/binary>>) when is_binary(Rest) ->

    can we have a more descriptive name for this one?

  • Patch Set #5, Line 72: add_prefix(<<A:8, B:8, C:8, D:8, E:8, F:8, G:8, H:8, I:8, J:8, K:8, L:8, M:8, N:8, O:8, P:8>>) ->

    I'm not seeing this one used anywhere?

  • Patch Set #5, Line 136: ipv6 = remove_prefix(Addr)};

    Ah now I see, so you are doing 2 things in this comit:
    1- Fixing IPv6
    2- Adding IPv4v6 support.

    I'd welcome if you submitted 2 patches instead of one. Also, please, on the 1st commit explain what the fix is about, because I only see here you are removing some prefix from the address but it's not really clear why.

To view, visit change 40255. To unsubscribe, or for help writing mail filters, visit settings.