laforge submitted this change.

View Change


Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved
pcu_sock: move variable declaration of imsi[4] into related scope

The variable imsi[4] may be moved into the scope of case PCU_IF_SAPI_PCH

Related: OS#5927
Change-Id: I62aed4f1c600ce2a80d2df928a60b6a2e0ae1889
---
M src/common/pcu_sock.c
1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 811cea4..16048e2 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -667,7 +667,6 @@
struct gsm_bts_trx_ts *ts;
struct msgb *msg;
int rc = 0;
- char imsi[4];

LOGP(DPCU, LOGL_DEBUG, "Data request received: sapi=%s arfcn=%d "
"block=%d data=%s\n", sapi_string[data_req->sapi],
@@ -679,6 +678,7 @@
{
const struct gsm48_imm_ass *gsm48_imm_ass;
bool confirm;
+ char imsi[4];
OSMO_STRLCPY_ARRAY(imsi, (char *)data_req->data);
if (data_req->len-3 != GSM_MACBLOCK_LEN) {
LOGP(DPCU, LOGL_ERROR, "MAC block with invalid length %d (expecting GSM_MACBLOCK_LEN = %d)\n",

To view, visit change 33215. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I62aed4f1c600ce2a80d2df928a60b6a2e0ae1889
Gerrit-Change-Number: 33215
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged