Attention is currently required from: laforge, neels, osmith.
10 comments:
Patchset:
some optional nitpicks..
Done
File include/osmocom/msc/ran_peer.h:
Patch Set #3, Line 94: struct ran_peer *ran_peer_find_by_addr(const struct sccp_ran_inst *sri, const struct osmo_sccp_addr *peer_addr);
please consider placing orthogonal cosmetic fixes of prior code in a separate patch, because you sho […]
Done
File src/libmsc/ran_peer.c:
Patch Set #3, Line 131: /* N-PCSTATE.ind informs us the peer went down and is no longer reachable: */
in this comment i expect to read what the *function* does
Done
File src/libmsc/sccp_ran.c:
typo
Done
Patch Set #3, Line 63: address
you mean PC? PC is a subset of possible SCCP addresses
It doesn't really matter, since the SSN is known/hardcoded in this case.
Patch Set #3, Line 64: get_ran_
below you call function ran_peer_find_by_addr(). […]
Done
Patch Set #3, Line 74: LOGP(DMSC, LOGL_DEBUG, "No ran_peer found under remote address: %s\n", osmo_sccp_addr_name(cs7, &rem_addr));
(if this function becomes public API: error logging should be done at the caller, because these help […]
Done
Patch Set #3, Line 85: LOGP(DMSC, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u=%s sp_status=%s remote_sccp_status=%s\n",
(not sure if we should log *all* N-PCSTATE events)
It's in debug, so sure we should.
Patch Set #3, Line 95: /* See if this marks the point code to have become available, or to have been lost.
hehe i know this comment from somewhere =) high five
Yeah I'm reusing stuff from osmo-bsc which had better support already,
(... this logic exists also in osmo-bsc. […]
No, I believe this is really logic of apps should take care of, specially since we'll be improving it at different pace in different apps in the future.
To view, visit change 40630. To unsubscribe, or for help writing mail filters, visit settings.