pespin submitted this change.

View Change

Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved
pcu: Fix wrong BSN uint size

3GPP TS 44.060 9.1.4.2, BSN is 11 bit long.

Change-Id: Id1ef8b58dc61ab91de2c781a2fd1e8da5eba83a7
---
M pcu/GPRS_Components.ttcn
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 849a251..cf8ef5f 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -1316,7 +1316,7 @@
/* This function does what could probably be done with templates */
function f_rlcmac_dl_block_verify_data_egprs(in RlcmacDlEgprsDataBlock data_block,
template (present) octetstring data := ?,
- template (present) uint14_t exp_bsn := ?,
+ template (present) uint11_t exp_bsn := ?,
template (present) CodingScheme exp_cs := ?)
runs on MS_BTS_IFACE_CT {
if (not match(data_block.mac_hdr.bsn1, exp_bsn)) {
@@ -1343,9 +1343,9 @@

/* High level (task specific) helper for matching GPRS/EGPRS data blocks */
function f_rlcmac_dl_block_exp_data(in RlcmacDlBlock dl_block,
- template (present) octetstring data := ?,
- template (present) uint7_t exp_bsn := ?,
- template (present) CodingScheme exp_cs := ?)
+ template (present) octetstring data := ?,
+ template (present) uint11_t exp_bsn := ?,
+ template (present) CodingScheme exp_cs := ?)
runs on MS_BTS_IFACE_CT {
/* Make sure it's either GPRS or EGPRS data block */
if (not match(dl_block, tr_RLCMAC_DATA)) {
@@ -1367,7 +1367,7 @@
/* High level (task specific) helper for receiving and matching GPRS/EGPRS data blocks */
function f_rx_rlcmac_dl_block_exp_data(out RlcmacDlBlock dl_block, out uint32_t dl_fn,
template (present) octetstring data := ?,
- template (present) uint7_t exp_bsn := ?,
+ template (present) uint11_t exp_bsn := ?,
template (present) CodingScheme exp_cs := ?,
template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)
runs on MS_BTS_IFACE_CT {

To view, visit change 39498. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id1ef8b58dc61ab91de2c781a2fd1e8da5eba83a7
Gerrit-Change-Number: 39498
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>