Attention is currently required from: pespin, fixeria, msuraev.

View Change

1 comment:

• File src/sccp_scoc.c:

  • Patch Set #15, Line 606: } else

    "Do not unnecessarily use braces where a single statement will do. […]

    not critical, but IMHO there should be curly braces. The linux kernel coding style should state that whenever a single statement is broken into several lines, the block uses braces. It should also state that if either of the two 'else' clauses use braces, both get them. Just quoting from memory here.

To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.