Attention is currently required from: osmith, fixeria.

View Change

1 comment:

• File src/osmo-bsc-nat/bsc_nat.c:

  • Patch Set #2, Line 31: struct osmo_tdef g_bsc_nat_tdefs[] = {

    Done

    @fixeria it cannot be static const since it is initialized. In the case where there are several instances of this tdef it indeed makes sense to have one const and then duplicate it in memory for each instance (we do that in several places), but in here there's no use in doing that since anyway there's only 1 instance, so it's fine resetting/changing values in it directly.

To view, visit change 28249. To unsubscribe, or for help writing mail filters, visit settings.