Attention is currently required from: fixeria, laforge, neels.

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #3, Line 862: LOGP(DLPFCP, LOGL_NOTICE, "cfg: pfcp netinst %s %s\n", access_or_core, *str);

    looks like a debugging leftover

    Ack

• File src/osmo-hnbgw/ps_rab_fsm.c:

  • Patch Set #3, Line 202: #define set_netinst(NETINST_MEMBER, STRING) do { \

    imho another example of something which need not be a define macro, and which would definetly be better of directly in code or as a static inline.

To view, visit change 35645. To unsubscribe, or for help writing mail filters, visit settings.