Attention is currently required from: laforge, daniel.

View Change

2 comments:

• File src/core/osmo_io.c:

  • Patch Set #3, Line 249: } else if (pending_len < 0) {

    Then I'd have to use -pending_len down in the memcpy which I like much less. […]

    Ok I see the root of the confusion now I think, "pending_len" as positive is not really the pending_len, but rather "extra_len" to be stored in the next message.

    So probably changing the name of the variable to "extra_len" or alike should make all this code much understandable imho. What do you think?

• File src/core/osmo_io.c:

  • Patch Set #4, Line 256: memcpy(msgb_data(msg_pending), msgb_data(msg) + len, pending_len);

    see, "pending_len" is not really the "pending length to be filled for next message" here.

To view, visit change 32758. To unsubscribe, or for help writing mail filters, visit settings.