Attention is currently required from: dexter, fixeria.
5 comments:
Patchset:
I'm not really understanding this patch tbh. if TXT_IND is sent once after socket gets connected, then it just means it's a global message and the bts_nr is simply not used, so it can be ignored...
File include/osmo-bts/pcuif_proto.h:
Patch Set #1, Line 262: #define PCU_IF_BTS_NR_BCAST 0xff
we are jsut increasing the bts_nr in osmo-bsc to 16bit, so this doesn't look like a good idea.
File src/common/pcu_sock.c:
Patch Set #1, Line 868: /* we use the reception of the PCU_VERSION as a trigger to make the PCU available for
This is really only osmo-bts inside a bts SM, never really going to be differnet bts (it's osmo-bts code), so if at all we should start by differentiating between cell and bts in PCUIF.
I see no clear use in this right now.
Patch Set #1, Line 954: #define ENSURE_BTS_OBJECT() \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Please fix.
Patch Set #1, Line 968: ENSURE_BTS_OBJECT();
This can probably be done once above the switch?
To view, visit change 38090. To unsubscribe, or for help writing mail filters, visit settings.