Attention is currently required from: osmith, laforge, fixeria.

View Change

1 comment:

• File src/host/trxcon/src/l1ctl.c:

  • Patch Set #3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually applied.

    Oh, good idea. […]

    See for instance:
    struct msgb *ms_nacc_create_rlcmac_msg(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf, uint32_t fn, uint8_t ts)
    {
    	int rc;
    	struct nacc_ev_create_rlcmac_msg_ctx data_ctx;

    	data_ctx = (struct nacc_ev_create_rlcmac_msg_ctx) {
    			.tbf = tbf,
    			.fn = fn,
    			.ts = ts,
    			.msg = NULL,
    	};

    	rc = osmo_fsm_inst_dispatch(ms->nacc->fi, NACC_EV_CREATE_RLCMAC_MSG, &data_ctx);
    	if (rc != 0 || !data_ctx.msg)
    		return NULL;
    	return data_ctx.msg;
    }

To view, visit change 28809. To unsubscribe, or for help writing mail filters, visit settings.