Attention is currently required from: pespin, fixeria, dexter.

View Change

4 comments:

• Commit Message:

  • Patch Set #8, Line 10: "direct TLLI" method, the TLLI (and the paging group) is premended to

    this needs updating. We are sending the IMSI now. […]

    probably "prepended"

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #8, Line 579: pch_dt->tlli, pch_dt->imsi, pag_grp);

    wrong indentation

    you keep saying that, but single-tab indent is a perfectly fine alternative to indenting lined up with the opening brace, and I keep saying that.

  • Patch Set #8, Line 581: msg = msgb_alloc(sizeof(pch_dt->data), "pcu_pch");

    why creating a new msg and copying the contents? Can you simply remove the header from the existing […]

    this is just moving code from a previous patch, but in fact this msgb is leaked! It should have been freed in all code paths, rc or !rc.

    (There seems to be no existing msgb to remove the header of, pch_dt is not a msgb)

    But since you don't pass msg as arg anywhere, but only pass its data and len, might as well just pass the pch_dt->data and its size to rsl_ericsson_imm_assign_cmd() below. That skips the unnecessary msgb allocation and hence there can be no msgb leak.

    And since this problem exists before this patch, rather submit one separate patch before this, to fix the msgb thing on its own, so that this patch only shows the intended functional change.

  • Patch Set #8, Line 595: msg->len, msg->data

    ...here just pass the pch_dt->data

To view, visit change 31578. To unsubscribe, or for help writing mail filters, visit settings.