laforge submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified
ASCI: Add missing transaction ID to SET PARAMETER message

Change-Id: I1b692cee894826a306885253a53a351f952d52dc
Related: OS#4854
---
M src/libmsc/msc_vgcs.c
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c
index e713ba5..f3867fe 100644
--- a/src/libmsc/msc_vgcs.c
+++ b/src/libmsc/msc_vgcs.c
@@ -890,7 +890,8 @@
uint8_t pdisc = (trans->type == TRANS_GCC) ? GSM48_PDISC_GROUP_CC : GSM48_PDISC_BCAST_CC;
int rc;

- rc = gsm44068_tx_set_parameter(trans, pdisc, !trans->gcc.mute_talker, 1, 1, trans->gcc.uplink_originator);
+ rc = gsm44068_tx_set_parameter(trans, pdisc | (trans->transaction_id << 4),
+ !trans->gcc.mute_talker, 1, 1, trans->gcc.uplink_originator);
if (rc < 0)
LOG_GCC(trans, LOGL_ERROR, "Failed to send SET PARAMETER towards MS.\n");
return rc;

To view, visit change 33966. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1b692cee894826a306885253a53a351f952d52dc
Gerrit-Change-Number: 33966
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged