Attention is currently required from: jolly.

View Change

2 comments:

• File bsc/BSC_Tests_ASCI.ttcn:

  • Patch Set #3, Line 46: type component RSL_DchanHdlr

    This component type is already defined in `library/RSL_Emulation.ttcn`, which is imported by this module. Why duplicating it here?

  • Patch Set #3, Line 59: integer cr, integer sf, integer af, integer prio, integer ci

    Why not defining template parameters as `BITn`?

    ```
    template (value) DescriptiveGroupOrBroadcastCallReference_V
    ts_BSSMAP_IE_GroupCallRef(integer cr,
                              BIT1 sf := '1'B,
                              BIT1 af := '0'B,
                              BIT3 prio := '000'B,
                              BIT4 ci := '0000'B) := { ... }
    ```

    I understand the problem with `cr`: there is no `BIT27` and passing long bitstrings might be inconvenient, but other params can be `BITn` and have default values assigned.

To view, visit change 33150. To unsubscribe, or for help writing mail filters, visit settings.