Hi Everyone,

When i tried to install the osmocombb for the first time which was a couple of days back i encountered with a problem and did some minor modification in the code.

>gsm411_sms.c: In function ‘gsm411_tx_sms_submit’:
>gsm411_sms.c:657: warning: passing argument 4 of ‘gsm411_smc_init’ from incompatible pointer type
>/usr/local/include/osmocom/gsm/gsm0411_smc.h:46: note: expected ‘int (*)(struct gsm411_smc_inst *, int,  struct msgb *, int)’ but argument is of type ‘int (*)(struct gsm411_smc_inst *, int,  struct msgb *)’
>gsm411_sms.c:657: error: too many arguments to function ‘gsm411_smc_init’
>gsm411_sms.c:659: error: too many arguments to function ‘gsm411_smr_init’
>gsm411_sms.c: In function ‘gsm411_rcv_sms’:
>gsm411_sms.c:911: warning: passing argument 4 of ‘gsm411_smc_init’ from incompatible pointer type
>/usr/local/include/osmocom/gsm/gsm0411_smc.h:46: note: expected ‘int (*)(struct gsm411_smc_inst *, int,  struct msgb *, int)’ but argument is of type ‘int (*)(struct gsm411_smc_inst *, int,  struct msgb *)’

by seeing this error i opened the respective file(gsm411_sms.c) in my local pc and i observed that the lines which was mentioned as error  and find the below .

gsm411_smc_init(&trans->sms.smc_inst, transaction_id, 0,
gsm411_mn_recv, gsm411_mm_send);

but in the header file (gsm0411_smc.h) only four arguments are defined 

void gsm411_smc_init(struct gsm411_smc_inst *inst, int network,
        int (*mn_recv) (struct gsm411_smc_inst *inst, int msg_type,
                        struct msgb *msg),

so i removed the extra argument transaction_id in the function(gsm411_smc_init) and also did the same with the respective lines where i was getting an error (from the file gsm411_sms.c).

i have done a change like the below by assuming thatevery msg is a mobile originated mesage 

gsm411_smc_init(&trans->sms.smc_inst, transaction_id, 0,
gsm411_mn_recv, gsm411_mm_send);

Kindly assist me if i was doing wrong.

Thanks in advance and Apologies if my observation was wrong. 

Regards,
Bharath