Hi Harald, and thanks for your answer.

Strictly following coding style is the best way to keep code clean. But running indent/lindent against osmocom code reveals that in many parts it differs from "pure kernel" style. My question (maybe merely phylosofical) is: what should you do? Keep existing code, allowing those exception to lie there, hoping someone will clean them up manually, or run indent against the code, hoping it doesn't dirt the code?

On Wed, Apr 10, 2013 at 12:00 PM, Harald Welte <laforge@gnumonks.org> wrote:

The easiest way is to always respect the coding style of the respective
FOSS project while you make the modifications. Rationale: There is no
guarantee that running the file through automatic tools 'lindent' will
not create whitespace-changes outside your actual changes.

I would not be worried about indent. Running it against a bunch of code could mess things up. But running on small pieces would be safe, under human control.

Just to clarify: I don't think you _need_ to run it. I'm just trying to understand an important point of view like yours.

Dario.