[PATCH] lower_mac/viterbi: Fix uninitialized memory reads in libosmocore

Josef Gajdusek atx at atx.name
Thu Dec 14 23:06:26 UTC 2017


Set term mode to CONV_TERM_TRUNCATION, which prevents libosmocore from
performing uninitialized memory reads leading to non-deterministic
decoding results.
---
 src/lower_mac/viterbi_cch.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lower_mac/viterbi_cch.c b/src/lower_mac/viterbi_cch.c
index 18fe0e5..250e179 100644
--- a/src/lower_mac/viterbi_cch.c
+++ b/src/lower_mac/viterbi_cch.c
@@ -52,6 +52,7 @@ static const struct osmo_conv_code conv_cch = {
 	.K = 5,
 	.next_output = conv_cch_next_output,
 	.next_state  = conv_cch_next_state,
+	.term = CONV_TERM_TRUNCATION,
 };
 
 
-- 
2.15.1



More information about the tetra mailing list