[PATCH 4/5] dfu: Use {} for possible empty if statement (in case debug is off)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/simtrace@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Wed Nov 9 22:24:15 UTC 2011


From: Holger Hans Peter Freyther <zecke at selfish.org>

src/dfu/dfu.c:853:23: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
---
 firmware/src/dfu/dfu.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/firmware/src/dfu/dfu.c b/firmware/src/dfu/dfu.c
index 682ce5e..f31b9f8 100644
--- a/firmware/src/dfu/dfu.c
+++ b/firmware/src/dfu/dfu.c
@@ -847,8 +847,10 @@ static __dfufunc void dfu_udp_ep0_handler(void)
 		break;
 	case STD_SET_CONFIGURATION:
 		DEBUGE("SET_CONFIG ");
-		if (wValue)
+		if (wValue) {
 			DEBUGE("VALUE!=0 ");
+		}
+	
 		cur_config = wValue;
 		udp_ep0_send_zlp();
 		pUDP->UDP_GLBSTATE =
-- 
1.7.7.2





More information about the simtrace mailing list