[PATCH] Fix inline functions to use 'static inline'

David Woodhouse dwmw2 at infradead.org
Fri Jun 29 09:11:52 UTC 2018


On Fri, 2018-06-29 at 08:25 +0000, Müller, Marcus (CEL) wrote:
> Hi David, Pinky, Steve and all,
> 
> I'd agree with "uh, I need to know where this goes wrong please, I'm
> scared".

GCC just fails to emit the offending functions and then the link fails:
 
[ 36%] Linking C executable rtl_power
CMakeFiles/rtl_power.dir/rtl_power.c.o: In function `fix_fft':
rtl_power.c:(.text+0x41a): undefined reference to `FIX_MPY'
rtl_power.c:(.text+0x445): undefined reference to `FIX_MPY'
rtl_power.c:(.text+0x476): undefined reference to `FIX_MPY'
rtl_power.c:(.text+0x49d): undefined reference to `FIX_MPY'
collect2: error: ld returned 1 exit status

You should be able to reproduce this really easily by building with
-O0.

Admittedly it's fairly bloody stupid to use -O0 for rtl-sdr but for the
MIPS target this was even happening with -Os, which is slightly saner.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5213 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20180629/feec169d/attachment.bin>


More information about the osmocom-sdr mailing list