[PATCH] Fix encoding of padding bits to start with 0 bit
msuraev at sysmocom.de
Thu Mar 10 09:52:19 UTC 2016
Thank you for patch.
Out of curiosity, have you tried to look in wireshark at gsmtap traces
I wonder if it interprets things properly - do we need to patch it as well?
On 03/10/2016 09:45 AM, Saurabh Sharan wrote:
> This patch is for fixing encoding of padding bits according to the
> 3gpp spec 44.060 section 11, wherein it shall always start with 0
> bit followed with spare padding bits.
> During introduction of basic EGPRS feature new hex dump messages
> from a different working network log were used in Unit test. These
> exposed the issue of incorrect handling of padding bits encoding
> in osmo-pcu.
> Corrections in the existing test vector of rlcmac is also updated.
> In testsuite tbf appropriate corrections for the Tbftest.err is
> also done.
> src/csn1.cpp | 7 ++++++-
> tests/rlcmac/RLCMACTest.cpp | 6 +++---
> tests/rlcmac/RLCMACTest.ok | 18 +++++++++---------
> tests/tbf/TbfTest.err | 18 +++++++++---------
> 4 files changed, 27 insertions(+), 22 deletions(-)
Max Suraev <msuraev at sysmocom.de> http://www.sysmocom.de/
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte
More information about the osmocom-net-gprs