Fwd: New Defects reported by Coverity Scan for Osmocom

Holger Freyther holger at freyther.de
Mon Feb 29 17:44:43 UTC 2016


Hi guys,

FYI after adding the do{} while and the log_check_level call coverity has found some dead code. The found_partial is a funny case of dead code. :)

holger



> Begin forwarded message:
> 
> From: scan-admin at coverity.com
> Subject: New Defects reported by Coverity Scan for Osmocom
> Date: 29 February 2016 at 17:47:54 GMT+1
> To: holger at freyther.de
> 
> 
> Hi,
> 
> Please find the latest report on new defect(s) introduced to Osmocom found with Coverity Scan.
> 
> 3 new defect(s) introduced to Osmocom found with Coverity Scan.
> 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
> 
> New defect(s) Reported-by: Coverity Scan
> Showing 3 of 3 defect(s)
> 
> 
> ** CID 70677:  Control flow issues  (DEADCODE)
> /source-iuh/osmo-pcu/src/gprs_rlcmac_ts_alloc.cpp: 907 in alloc_algorithm_b()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 70677:  Control flow issues  (DEADCODE)
> /source-iuh/osmo-pcu/src/gprs_rlcmac_ts_alloc.cpp: 907 in alloc_algorithm_b()
> 901     					dl_slots, 'D'),
> 902     			single ? ", single" : "");
> 903     
> 904     		/* assign downlink */
> 905     		if (dl_slots == 0) {
> 906     			LOGP(DRLCMAC, LOGL_NOTICE, "No downlink slots "
>>>>    CID 70677:  Control flow issues  (DEADCODE)
>>>>    Execution cannot reach this statement "do  {
>  if (log_check_level...".
> 907     				"available\n");
> 908     			return -EINVAL;
> 909     		}
> 910     		slotcount = pcu_bitcount(dl_slots);
> 911     		first_ts = ffs(dl_slots) - 1;
> 912     		avail_count = pcu_bitcount(reserved_dl_slots);
> 
> ** CID 70676:  Control flow issues  (DEADCODE)
> /source-iuh/libosmo-netif/src/rtp.c: 124 in osmo_rtp_get_payload()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 70676:  Control flow issues  (DEADCODE)
> /source-iuh/libosmo-netif/src/rtp.c: 124 in osmo_rtp_get_payload()
> 118     			return NULL;
> 119     		}
> 120     	}
> 121     	if (rtph->padding) {
> 122     		if (payload_len < 0) {
> 123     			DEBUGPC(DLMUX, "received RTP frame too short for "
>>>>    CID 70676:  Control flow issues  (DEADCODE)
>>>>    Execution cannot reach this statement "do  {
>  if (log_check_level...".
> 124     				"padding length\n");
> 125     			return NULL;
> 126     		}
> 127     		payload_len -= payload[payload_len - 1];
> 128     		if (payload_len < 0) {
> 129     			DEBUGPC(DLMUX, "received RTP frame with padding "
> 
> ** CID 70675:  Control flow issues  (DEADCODE)
> /source-iuh/libosmo-netif/src/channel.c: 57 in osmo_chan_create()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 70675:  Control flow issues  (DEADCODE)
> /source-iuh/libosmo-netif/src/channel.c: 57 in osmo_chan_create()
> 51     		LOGP(DLINP, LOGL_ERROR, "unsupported channel type `%s'\n",
> 52     			cur->name);
> 53     		return NULL;
> 54     	}
> 55     	if (found_partial) {
> 56     		LOGP(DLINP, LOGL_ERROR, "Sorry, channel type `%s' does not "
>>>>    CID 70675:  Control flow issues  (DEADCODE)
>>>>    Execution cannot reach this statement "do  {
>  if (log_check_level...".
> 57     			"support subtype `%u'\n", cur->name, subtype_id);
> 58     		return NULL;
> 59     	}
> 60     
> 61     	c = talloc_zero_size(osmo_chan_ctx,
> 62     			     sizeof(struct osmo_chan) + cur->datasiz);
> 
> 
> ________________________________________________________________________________________________________
> To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/osmocom?tab=overview
> 
> To manage Coverity Scan email notifications for "holger at freyther.de", click https://scan.coverity.com/subscriptions/edit?email=holger%40freyther.de&token=90b620c1f1eaf964c8f6d3882b84a613
> 




More information about the osmocom-net-gprs mailing list