[PATCH] Explicitly initialize m_v_n and m_v_b

Max msuraev at sysmocom.de
Thu Feb 25 17:21:36 UTC 2016


I'm not familiar enough with c++ to claim that the constructor will 
always be called so I've left it just in case.

On 02/25/2016 05:58 PM, Holger Freyther wrote:
>> On 25 Feb 2016, at 17:28, msuraev at sysmocom.de wrote:
>>
>>
>> +inline gprs_rlc_v_b::gprs_rlc_v_b()
>> +{
>> +	reset();
>> +}
>> +
>> +inline gprs_rlc_v_n::gprs_rlc_v_n()
>> +{
>> +	reset();
>> +}
>> +
>> inline gprs_rlc_ul_window::gprs_rlc_ul_window()
>> 	: m_v_r(0)
>> 	, m_v_q(0)
>> {
>> +	m_v_n.reset();
> why this? You have just added a ctor of the _v_n::.._v_n()?
>
>
>
>

-- 
Max Suraev <msuraev at sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte




More information about the osmocom-net-gprs mailing list