[PATCH] fix for encoding of padding bits

Saurabh Sharan Saurabh.Sharan at radisys.com
Wed Feb 24 06:52:58 UTC 2016


Hello Harald,
We had tried the option of sending one patch through git send-email. 
This was our first attempt so wanted to confirm whether we followed the process correctly. Please note that I am unable to see this patch(mail below) in Archive maintained at 
http://lists.osmocom.org/pipermail/osmocom-net-gprs/

Regards
Saurabh

-----Original Message-----
From: Saurabh Sharan [mailto:saurabh.sharan at radisys.com] 
Sent: Tuesday, February 23, 2016 4:29 PM
To: osmocom-net-gprs at lists.osmocom.org
Cc: Saurabh Sharan <Saurabh.Sharan at radisys.com>
Subject: [PATCH] fix for encoding of padding bits

---
 src/csn1.cpp |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/csn1.cpp b/src/csn1.cpp index 54cc411..9262c81 100644
--- a/src/csn1.cpp
+++ b/src/csn1.cpp
@@ -2400,7 +2400,12 @@ gint16 csnStreamEncoder(csnStream_t* ar, const CSN_DESCR* pDescr, bitvec *vector
             guint8 bits_to_handle = remaining_bits_len%8;
             if (bits_to_handle > 0)
             {
-              guint8 fl = filler&(0xff>>(8-bits_to_handle));
+	      /*section 11 of 44.060
+               *The padding bits may be the 'null' string. Otherwise, the
+	       *padding bits starts with bit '0', followed by 'spare padding'.
+	       *< padding bits > ::= { null | 0 < spare padding > ! < Ignore : 1 bit** = < no string > > } ;   
+	      */	 
+              guint8 fl = filler&(0xff>>(8-bits_to_handle + 1));
               bitvec_write_field(vector, writeIndex, fl, bits_to_handle);
               LOGPC(DCSN1, LOGL_NOTICE, "%u|", fl);
               remaining_bits_len -= bits_to_handle;
--
1.7.9.5





More information about the osmocom-net-gprs mailing list