[PATCH 1/1] Set csnStream direction *after* csnStreamInit

Daniel Willmann dwillmann at sysmocom.de
Wed Jan 15 09:05:26 UTC 2014


Fixes a bug introduced in commit 402cdc. That commit sets direction to
zero so setting it to 1 should be done after the call to
csnStreamInit().

This issue was discovered by the rlcmac test.
---
 src/csn1.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/csn1.cpp b/src/csn1.cpp
index 7f64823..258f7c9 100644
--- a/src/csn1.cpp
+++ b/src/csn1.cpp
@@ -544,11 +544,11 @@ csnStreamDecoder(csnStream_t* ar, const CSN_DESCR* pDescr, bitvec *vector, unsig
         guint8 length = bitvec_read_field(vector, readIndex, length_len);
 
         LOGPC(DCSN1, LOGL_NOTICE, "%s length = %d | ", pDescr->sz , (int)length);
-        arT.direction = 1;
         bit_offset += length_len;
         remaining_bits_len -= length_len;
 
         csnStreamInit(&arT, bit_offset, length);
+        arT.direction = 1;
         Status = serialize(&arT, vector, readIndex, pvDATA(data, pDescr->offset));
 
         if (Status >= 0)
-- 
1.8.4.2





More information about the osmocom-net-gprs mailing list