TBF differences for Uplink and Downlink

Holger Hans Peter Freyther hfreyther at sysmocom.de
Thu Oct 17 09:33:32 UTC 2013


Hi,

in my refactorings (creating a TBF class and moving code that modifes
the internals into the TBF) I am trying to make gprs_rlcmac_ul_tbfs
and gprs_rlcmac_dl_tbfs private and I notice code like:


        if (dir == GPRS_RLCMAC_UL_TBF) {
                llist_for_each_entry(tbf, &gprs_rlcmac_ul_tbfs, list) {
                        if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
                         && tbf->tlli == tlli && tbf->tlli_valid)
                                return tbf;
                }
        } else {
                llist_for_each_entry(tbf, &gprs_rlcmac_dl_tbfs, list) {
                        if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
                         && tbf->tlli == tlli)
                                return tbf;
                }
        }

        llist_for_each_entry(tbf, &gprs_rlcmac_ul_tbfs, list) {
                if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
                 && tbf->poll_state == GPRS_RLCMAC_POLL_SCHED
                 && tbf->poll_fn == fn && tbf->trx_no == trx
                 && tbf->control_ts == ts)
                        return tbf;
        }
        llist_for_each_entry(tbf, &gprs_rlcmac_dl_tbfs, list) {
                if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
                 && tbf->poll_state == GPRS_RLCMAC_POLL_SCHED
                 && tbf->poll_fn == fn && tbf->trx_no == trx
                 && tbf->control_ts == ts)
                        return tbf;
        }


In the first code. Why is tlli_valid only checked for the UL TBF
and not the downlink one?

holger


-- 
- Holger Freyther <hfreyther at sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Schivelbeiner Str. 5
* 10439 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte





More information about the osmocom-net-gprs mailing list