libosmocore.git branch master updated. 0.10.2-228-gec0f334e

gitosis at gitosis at
Mon Mar 26 13:03:39 UTC 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  ec0f334e995a72aab78cb0fc839b67c7b961b336 (commit)
       via  536534a62f253b61e3c1c253fe95e33fda3101f1 (commit)
       via  75ee4e8aa957d4f04e107130fe69d61e6b215763 (commit)
       via  fcf79926e5e5d296efc4d53b1c50849e4fff7908 (commit)
       via  bb22df3db915f2141ce3c2477e7417781c5961f4 (commit)
       via  46145e80ec64f4941469debb8310be37fba69ded (commit)
       via  167f808d7641f2a23f247cb1f66ec93d026ca366 (commit)
      from  21946e8f5dbc0c7128ac82991017ec6d4c99d0d1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit ec0f334e995a72aab78cb0fc839b67c7b961b336
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 04:17:35 2018 +0200

    contrib/fsm-to-dot: less false positives on event parsing
    Do some more mad hacking to only detect event triggers if event names actually
    appear in if() or case: statements. Also combine events in consecutive 'case'
    When will this madness stop?
    Change-Id: Iabaaab57f0d1687607eaaa4e09c7c2439fbd7a25

commit 536534a62f253b61e3c1c253fe95e33fda3101f1
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 04:15:37 2018 +0200

    contrib/fsm-to-dot: mark arrows that feed events
    Most arrows draw state transitions, but some want to show that an event is
    delivered to a state. Mark those with a "halfopen" arrow head.
    Change-Id: Ib07380894a6d513896c9135f175ecbf653a23eec

commit 75ee4e8aa957d4f04e107130fe69d61e6b215763
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 03:08:28 2018 +0200

    contrib/fsm-to-dot: add default edge label '-'
    When some edges have no label, it is sometimes hard to interpret which label
    belongs to which edge. Adding a '-' default label clarifies the edge labeling.
    Change-Id: I3a10b615288107e8fc12ffdbbe0099cf51abe94f

commit fcf79926e5e5d296efc4d53b1c50849e4fff7908
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 01:03:26 2018 +0100

    contrib/fsm-to-dot: warn and draw unallowed state transitions
    Hacked as it is, fsm-to-dot is capable of detecting action functions
    transitioning to states that are not allowed according to the FSM definition
    Draw those in red and output a warning.
    Found these osmo-bsc gscon errors with this patch:
    ERROR: gscon_fsm_active() triggers a transition to ST_WAIT_HO_COMPL, but this is not allowed by the FSM definition
    ERROR: gscon_fsm_wait_ho_compl() triggers a transition to ST_WAIT_MDCX_BTS_HO, but this is not allowed by the FSM definition
    Related: OS#3109
    Change-Id: Ic6319a958b3c7247510c1930bac8b02b95f9dcf2

commit bb22df3db915f2141ce3c2477e7417781c5961f4
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 01:03:26 2018 +0100

    contrib/fsm-to-dot: don't match on event names in comments
    Strip comments from function bodies before matching on event names.
    In osmo-bsc's gscon FSM, there often are event names in comments. The naive
    parsing of mistakes these as events causing state transitions,
    but the comments are just explaining how states interact.
    Makes me reconsider parsing the C with clang instead, but I got away with a
    dirty hack once more.
    Change-Id: I56d70ae14d363f7ca655dced16d93d795b3f940d

commit 46145e80ec64f4941469debb8310be37fba69ded
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 01:02:35 2018 +0100

    contrib/fsm-to-dot: allow transition from and to the same state
    In osmo-bsc's new gscon FSM, there is an osmo_fsm_inst_state_chg() from
    ST_ACTIVE to ST_ACTIVE. Avoid an exception triggering on this simple fact.
    Change-Id: I420c7be84e3af555cc5e8bddbff7261013348375

commit 167f808d7641f2a23f247cb1f66ec93d026ca366
Author: Neels Hofmeyr <neels at>
Date:   Sun Mar 25 01:01:32 2018 +0100

    contrib/fsm-to-dot: add -h option to print basic instructions
    Change-Id: I196033e44d50ebb73cf9b44cbdc94a2b8b4f98ce


Summary of changes:
 contrib/ | 88 ++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 69 insertions(+), 19 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list