osmo-bts.git branch master updated. 0.7.0-165-g5f17e61

gitosis at osmocom.org gitosis at osmocom.org
Thu Mar 22 07:07:56 UTC 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".

The branch, master has been updated
       via  5f17e6138ebbac8d2a504429ae464d078c702b52 (commit)
      from  f397993340a5a158930e3687b697d95a82257a6d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=5f17e6138ebbac8d2a504429ae464d078c702b52

commit 5f17e6138ebbac8d2a504429ae464d078c702b52
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Wed Mar 21 19:51:46 2018 +0100

    l1sap: Avoid assumption that l1sap is at head of msgb
    
    This assumption used while sending the rx data to gsmtap in l1sap_up was
    making osmo-bts-virtual crash, since that bts model is allocating the
    l1sap in the stack rather than inside the msgb.
    Instead, let's use the assumption that l2h is set correctly in msgb by
    the bts model lower layer.
    
    crash report:
    Program received signal SIGSEGV, Segmentation fault.
    0x00007ffff6234ec3 in __memmove_sse2_unaligned_erms () from /usr/lib/libc.so.6
    (gdb) bt
    0  0x00007ffff6234ec3 in __memmove_sse2_unaligned_erms () from /usr/lib/libc.so.6
    1  0x00007ffff6dbf4c8 in gsmtap_makemsg_ex (type=<optimized out>, arfcn=arfcn at entry=17255, ts=ts at entry=6 '\006',
        chan_type=<optimized out>, ss=ss at entry=0 '\000', fn=fn at entry=11249, signal_dbm=0 '\000', snr=0 '\000',
        data=0x5555557d5b50 "", len=4294967263) at libosmocore/src/gsmtap_util.c:179
    2  0x00007ffff6dbf6d8 in gsmtap_send_ex (gti=0x555555877f10, type=type at entry=1 '\001', arfcn=arfcn at entry=17255,
        ts=ts at entry=6 '\006', chan_type=<optimized out>, ss=<optimized out>, fn=11249, signal_dbm=0 '\000', snr=0 '\000',
        data=0x5555557d5b50 "", len=4294967263) at libosmocore/src/gsmtap_util.c:311
    3  0x00007ffff6dbf765 in gsmtap_send (gti=<optimized out>, arfcn=arfcn at entry=17255, ts=ts at entry=6 '\006',
        chan_type=<optimized out>, ss=<optimized out>, fn=fn at entry=11249, signal_dbm=0 '\000', snr=0 '\000',
        data=0x5555557d5b50 "", len=4294967263) at libosmocore/src/gsmtap_util.c:330
    4  0x0000555555573571 in to_gsmtap (trx=0x7ffff7ef8070, l1sap=0x7fffffffde80)
        at osmo-bts/src/common/l1sap.c:397
    5  0x0000555555573b9c in l1sap_up (trx=0x7ffff7ef8070, l1sap=l1sap at entry=0x7fffffffde80)
        at osmo-bts/src/common/l1sap.c:1285
    6  0x000055555555ec06 in virt_um_rcv_cb (vui=<optimized out>, msg=<optimized out>)
        at osmo-bts/src/osmo-bts-virtual/l1_if.c:170
    7  0x000055555555f5c6 in virt_um_fd_cb (ofd=0x55555587cc30, what=<optimized out>)
        at osmo-bts/src/osmo-bts-virtual/virtual_um.c:50
    8  0x00007ffff6db6991 in osmo_fd_disp_fds (_eset=0x7fffffffe090, _wset=0x7fffffffe010, _rset=0x7fffffffdf90)
        at libosmocore/src/select.c:216
    9  osmo_select_main (polling=polling at entry=0) at libosmocore/src/select.c:256
    10 0x0000555555576fbc in bts_main (argc=5, argv=0x7fffffffe288)
        at osmo-bts/src/common/main.c:364
    11 0x00007ffff61b5f4a in __libc_start_main () from /usr/lib/libc.so.6
    12 0x000055555555c4ca in _start ()
    
    In the old code when the sizeof(osmo_phsap_prim) was being substracted
    it resulted on a negative len which later was casted to unsigned int and
    became a really big number.
    
    Fixes: OS#3092
    
    Change-Id: I51a880328497673a06d153bfb76c428265b8cbb8

-----------------------------------------------------------------------

Summary of changes:
 src/common/l1sap.c | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
Osmocom BTS-side code (Abis, scheduling, ...)


More information about the osmocom-commitlog mailing list