osmo-trx.git branch master updated. 0.2.0-69-gc0c6d70

gitosis at osmocom.org gitosis at osmocom.org
Wed Mar 14 21:12:51 UTC 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".

The branch, master has been updated
       via  c0c6d70fe9d4122e6142b0a9785a44a7f3d0cf0d (commit)
       via  8c6c5d2bcd3f37e132b73a12e6a83cf07e15260f (commit)
       via  a62fcf786a0484e55e98861d52e31a83353373d6 (commit)
       via  4d9b59c3efb269a6e2c9046ae3653f1c8fbdb3f6 (commit)
       via  bd0efb0bea27b63a7dd9003dc36e4388978499b6 (commit)
      from  8fbbd656c76eecff1a99432f6f54272c3884bc84 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-trx/commit/?id=c0c6d70fe9d4122e6142b0a9785a44a7f3d0cf0d

commit c0c6d70fe9d4122e6142b0a9785a44a7f3d0cf0d
Author: Vadim Yanitskiy <axilirator at gmail.com>
Date:   Fri Mar 9 05:08:23 2018 +0700

    Transceiver.cpp: prevent out-of-range array access
    
    There was no a simple range check for both (NO)HANDOVER commands,
    so an out-of-range access was possible. For example, a command:
    
      CMD HANDOVER 0 -3
    
    might enable EDGE at run-time, because:
    
      a[i] == *(a + i)
    
    Let's fix this.
    
    Change-Id: I24a5f70e8e8097f218d7cbdef8cb10df2c35416f

http://cgit.osmocom.org/osmo-trx/commit/?id=8c6c5d2bcd3f37e132b73a12e6a83cf07e15260f

commit 8c6c5d2bcd3f37e132b73a12e6a83cf07e15260f
Author: Vadim Yanitskiy <axilirator at gmail.com>
Date:   Fri Mar 9 05:01:21 2018 +0700

    Transceiver.cpp: fix incorrect format string for SETTSC
    
    Change-Id: If69a478121a31aa7df945548cc17271c476d6a6b

http://cgit.osmocom.org/osmo-trx/commit/?id=a62fcf786a0484e55e98861d52e31a83353373d6

commit a62fcf786a0484e55e98861d52e31a83353373d6
Author: Vadim Yanitskiy <axilirator at gmail.com>
Date:   Fri Mar 9 03:24:08 2018 +0700

    Transceiver.cpp: use pointer arithmetics for CMD parsing
    
    It looks like the author of control command parsing code was not
    familar with simple pointer arithmetics, so excessive amount of
    memory and useless memcopying was used to parse a single command.
    
    Let's introduce two pointers, one of which will point to the
    beginning of a command, another to the beginning of its arguments.
    Also, let's simplify the command matching by using a separate
    function called 'MATCH_CMD'.
    
    Change-Id: I226ca0771e63228cf5e04ef9766057d4107fdd11

http://cgit.osmocom.org/osmo-trx/commit/?id=4d9b59c3efb269a6e2c9046ae3653f1c8fbdb3f6

commit 4d9b59c3efb269a6e2c9046ae3653f1c8fbdb3f6
Author: Vadim Yanitskiy <axilirator at gmail.com>
Date:   Fri Mar 9 02:54:45 2018 +0700

    Transceiver.cpp: properly zero-terminate received commands
    
    Previously it was assumed that a sender should zero-terminate
    each command being sent. Otherwise, this could cause to printing
    garbage. Let's do this manually, using the length of received
    data as a position for '\0'.
    
    Change-Id: I69f413f33156c38a853efc5a8cdc66fbfb0ca6af

http://cgit.osmocom.org/osmo-trx/commit/?id=bd0efb0bea27b63a7dd9003dc36e4388978499b6

commit bd0efb0bea27b63a7dd9003dc36e4388978499b6
Author: Vadim Yanitskiy <axilirator at gmail.com>
Date:   Fri Mar 9 02:45:07 2018 +0700

    Transceiver.cpp: use a define for the MAX_PACKET_LENGTH
    
    No need to keep this value on stack.
    
    Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7

-----------------------------------------------------------------------

Summary of changes:
 Transceiver52M/Transceiver.cpp | 151 +++++++++++++++++++++++------------------
 1 file changed, 86 insertions(+), 65 deletions(-)


hooks/post-receive
-- 
OpenBTS' transceiver retro-fit


More information about the osmocom-commitlog mailing list