openbsc.git branch master updated. 1.0.0-17-g55d172617

gitosis at osmocom.org gitosis at osmocom.org
Mon Mar 12 12:30:34 UTC 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  55d172617c2b6df3abdd430bf5751ddbd4420551 (commit)
      from  14cd21417f8774a92900cb707064d650ea769615 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=55d172617c2b6df3abdd430bf5751ddbd4420551

commit 55d172617c2b6df3abdd430bf5751ddbd4420551
Author: Harald Welte <laforge at gnumonks.org>
Date:   Mon Mar 12 00:24:22 2018 +0100

    sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6
    
    Fixes a regression in the code generating SI5* and SI6 on SACCH,
    where the L2 pseudo-length is not part of the 'struct' definition
    we have in gsm_04_08.h and hence has to be encoded manually into
    the first byte of the SI buffer.
    
    We were doing this correctly until April 2017, when the following
    patch was merged:
    
    > commit 6f0e50c8337355eb59033903ede9ab6528890835
    > Author: Max <msuraev at sysmocom.de>
    > Date:   Wed Apr 12 15:30:54 2017 +0200
    >
    >     Prepare for extended SI2quater support
    
    This patch cacidentially overwrote the l2_plen that was just enoded,
    as the 'struct' was no longer pointing to 'output' (si_buf+1), but
    now directly to the start of the si_buf.
    
    NOTE: The Wireshark RSL dissector (and more recently also LAPDm)
    contain a similar bug, so the SACCH will not be decoded correctly
    after applying this patch. Nevertheless, it's correct.
    
    back-port of OsmoBSC Change-Id: Ie8c907b1317566670aeb68f933ceefd552c17565
    Closes: #3059
    Related: #2963
    Change-Id: Iaf5feefc1bb3194dd491955fee418795c61787f7

-----------------------------------------------------------------------

Summary of changes:
 openbsc/src/libbsc/system_information.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)


More information about the osmocom-commitlog mailing list