libosmocore.git branch master updated. 0.10.2-127-gbd33a956

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Mon Jan 22 10:36:09 UTC 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  bd33a9568e0d8e7fca6f4cbbaa224277ed1c3fef (commit)
      from  3da793857d78142e3594c67f4405ad19b57e9cd1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=bd33a9568e0d8e7fca6f4cbbaa224277ed1c3fef

commit bd33a9568e0d8e7fca6f4cbbaa224277ed1c3fef
Author: Vadim Yanitskiy <axilirator at gmail.com>
Date:   Sat Jan 20 04:52:43 2018 +0600

    tests/ussd: prevent uninitialized memory access
    
    Previously an incorrect length value was passed to both
    gsm_7bit_decode_n_ussd() and gsm_7bit_encode_n_ussd()
    functions during test_7bit_ussd() execution, due to:
    
       octets_written = strlen(decoded);
    
    The problem is that a 7-bit encoded string takes less memory
    than its 8-bit equivalent. So, here strlen() returns one-byte
    bigger value, that octets_written is. This then causes the
    uninitialized memory access.
    
    Found using Valgrind:
    
    Conditional jump or move depends on uninitialised value(s)
       at 0x506DCCC: gsm_7bit_decode_n_ussd (gsm_utils.c:248)
       by 0x40134B: test_7bit_ussd (ussd_test.c:104)
       by 0x400F5D: main (ussd_test.c:161)
    
    Conditional jump or move depends on uninitialised value(s)
       at 0x506DBB7: gsm_7bit_decode_n_hdr (gsm_utils.c:220)
       by 0x506DC9E: gsm_7bit_decode_n_ussd (gsm_utils.c:246)
       by 0x40134B: test_7bit_ussd (ussd_test.c:104)
       by 0x400F5D: main (ussd_test.c:161)
    
    Conditional jump or move depends on uninitialised value(s)
       at 0x506DBCB: gsm_septet_lookup (gsm_utils.c:153)
       by 0x506DBCB: gsm_7bit_decode_n_hdr (gsm_utils.c:224)
       by 0x506DC9E: gsm_7bit_decode_n_ussd (gsm_utils.c:246)
       by 0x40134B: test_7bit_ussd (ussd_test.c:104)
       by 0x400F5D: main (ussd_test.c:161)
    
    Change-Id: Ic31805b6a5a917dfc6284edba6ffdd21246ac20c

-----------------------------------------------------------------------

Summary of changes:
 tests/ussd/ussd_test.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


hooks/post-receive
-- 
An utility library for Open Source Mobile Communications



More information about the osmocom-commitlog mailing list