osmo-bts.git branch master updated. 0.7.0-100-g815ff00

gitosis at osmocom.org gitosis at osmocom.org
Fri Feb 23 20:00:02 UTC 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".

The branch, master has been updated
       via  815ff00d239b5b20bb077e210b533c7ff32cb102 (commit)
       via  aa9ce821a09ebbe95364926a54aed6871d59d026 (commit)
       via  1effad1004d203c755b475ea6ef26586d45153f0 (commit)
       via  2de8f6c7ec3d7a2fd1520c09a5b4ba2a4a5b9248 (commit)
      from  b82b81b256b7e98872065600fc4e0daf6c0d430a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 815ff00d239b5b20bb077e210b533c7ff32cb102
Author: Harald Welte <laforge at gnumonks.org>
Date:   Fri Feb 23 18:39:29 2018 +0100

    osmo-bts-trx: Add missing frame number to l1if_process_meas_res()
    Change-Id: I7f1322b025ce733f78ae2b958c7a2bb38b6aa6f5


commit aa9ce821a09ebbe95364926a54aed6871d59d026
Author: Harald Welte <laforge at gnumonks.org>
Date:   Fri Feb 23 13:53:33 2018 +0100

    l1sap: Pass is_sub from L1 primitive into the Uplink Measurement
    info_meas_ind on the L1SAP always allowed the lower layers to pass
    in whether a given measurement is part of the "SUB", or not.
    However, the existing l1sap code before this patch simply drops this
    information, despite the measurement.c code also having "is_sub" state.
    Let's make sure this state is passed from L1SAP into measurement
    processing as intended.
    Fact is, none of our current lower-layers actually set this is_sub flag
    for their primitives passed up in L1SAP, but at least now *if* they
    would set that flag, the measurement code would process it as intended.
    Related: OS#2978
    Change-Id: Ibed2e8d7563b471c6b5dd2214ac4765caf31ed2a


commit 1effad1004d203c755b475ea6ef26586d45153f0
Author: Harald Welte <laforge at gnumonks.org>
Date:   Fri Feb 23 13:52:44 2018 +0100

    measurement.c: Hand Frame Number into measurement computation
    This is currently only used for logging, but will be needed for proper
    RX{LEV,QUAL}-SUB reporting in upcoming patches.
    Related: OS#2978
    Change-Id: I07fd06e8a379cab7c0c2eb111c3f5600037d3c9e


commit 2de8f6c7ec3d7a2fd1520c09a5b4ba2a4a5b9248
Author: Harald Welte <laforge at gnumonks.org>
Date:   Fri Feb 23 19:53:16 2018 +0100

    Revert "measurement: fix measurement computation"
    This reverts commit d5fdcfe6d95f52fb76c4f4201969347a062fc9fd, which
    introduces a new function lchan_meas_update_ordered_TA whose
    functionality I still haven't yet managed to fully understand. It
    appears to be adjusting the requested timing advance (lchan->rqd_ta) but
    outside osmo-bts-trx/loops.c code. This is odd, as rqd_ta is a state
    variable of that loops.c code.
    So for one part, it is a failure of encapsulation. The TA loop code
    should be self-contained, particularly as it is only used for
    omso-bts-trx, and not for the other BTS models. The new
    lchan_meas_update_ordered_TA() function is used from common code,
    applicable to all BTS models.
    The resulting interaction between loops.c code and this new (now
    reverted) function cause the TA value to only ever grow, despite the MS
    never moving at all.
    Change-Id: I5a5adac6f18f94a5b51758a5ace8ef6ddfd23e80
    Related: OS#2989


Summary of changes:
 include/osmo-bts/measurement.h |  2 +-
 src/common/l1sap.c             |  3 ++-
 src/common/measurement.c       | 55 +++---------------------------------------
 src/common/rsl.c               |  3 +--
 src/osmo-bts-trx/l1_if.c       |  2 +-
 5 files changed, 9 insertions(+), 56 deletions(-)

Osmocom BTS-side code (Abis, scheduling, ...)

More information about the osmocom-commitlog mailing list