libosmocore.git branch neels/mnc3 updated. 0.10.2-180-g3d8879bf

gitosis at gitosis at
Thu Feb 22 05:10:50 UTC 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, neels/mnc3 has been updated
  discards  ab26997fa3b8a999b18a4c4977fc049044a180a7 (commit)
  discards  a1fa6488ad0c02753a4d7026e90f23f3e31edd4f (commit)
  discards  a689ce7ff408b621809b0a96f3a722bcf7853b81 (commit)
  discards  c328958e74dee88b550b085f5a074be13fbc26fa (commit)
  discards  67d34280264c954a18b12dc7861d7f27c277c577 (commit)
  discards  5aa8115fa87b860a9920b5b709eb5bb7fb50d117 (commit)
  discards  1e4a480d5b2d545ab191e66d5ca3d54f4cf247fe (commit)
  discards  9b0f7c1d66c48bfec919b951c97357709ab1d029 (commit)
  discards  901b5f9e6c6e256bb48cf0f8bb446a0a5683d100 (commit)
       via  3d8879bfbcc3ff16ef955876a1a989d26fb692ba (commit)
       via  e08e9c479a3360b74c6fb947b706a43840acd639 (commit)
       via  2aa1badcd17eafc7648ac6ada81d4fbfc724c00a (commit)
       via  91892abac66e9bbf538f4453f452e67a54f876ee (commit)
       via  b7199612d6e2cce676cb099ac41c96a738494ba6 (commit)
       via  be4fbeaf8c61ddc2f496bb2ad520118b53c6f645 (commit)
       via  d5a577b043aab7d27608601ed751e8e17ec5457f (commit)
       via  b9fd7eba1558328802ae9dff79f708bd6ba7b10b (commit)
       via  c38b32dde94ae5547a11c4d59adb3510576300b0 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (ab26997fa3b8a999b18a4c4977fc049044a180a7)
             N -- N -- N (3d8879bfbcc3ff16ef955876a1a989d26fb692ba)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 3d8879bfbcc3ff16ef955876a1a989d26fb692ba
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 15:14:14 2018 +0100

    Change-Id: Ieee7add0bd6d94cf84743a49794bbcd38561b72f

commit e08e9c479a3360b74c6fb947b706a43840acd639
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 21:38:00 2018 +0100

    gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
    gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
    VTY config parsing.
    gsm48_mnc_cmp() will be used by osmo-sgsn.git

commit 2aa1badcd17eafc7648ac6ada81d4fbfc724c00a
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 22:20:42 2018 +0100

    gsm0408_test: add test cases for MNC with leading zeros
    Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c

commit 91892abac66e9bbf538f4453f452e67a54f876ee
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 22:19:56 2018 +0100

    gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
    Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b

commit b7199612d6e2cce676cb099ac41c96a738494ba6
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 15:12:23 2018 +0100

    gsm0408_test: check for new mnc_3_digits flag
    Note that on the input side, the 3-digits flag may be left false when the MNC
    is >99 anyway. On the decoded side, the flag is set accurately.
    Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c

commit be4fbeaf8c61ddc2f496bb2ad520118b53c6f645
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 13:47:08 2018 +0100

    implement support for 3-digit MNC with leading zeros
    Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
    actually different; so far we treated both as 23. Re-encode an incoming BCD or
    string of 023 as it were, i.e. not dropping the leading zero as 23.
    Break ABI compatibility by changing the size and ordering of struct gprs_ra_id.
    Ordering is changed because the canonical oder is {Mobile Country Code, Mobile
    Network Code}, so have the mcc member first. Change size (and ordering) by
    inserting a flag to indicate a three-digit MNC after the mnc member. ABI
    compatibility cannot be maintained, since struct gprs_ra_id is a direct member
    of structs bssgp_bvc_ctx and bssgp_paging_info, and even just adding a flag to
    the end would cause ABI changes of those structs.
    Add new API to set and read this additional flag to preserve leading zeros:
    - gsm48_mcc_mnc_to_bcd2(), gsm48_mcc_mnc_from_bcd2() after
      gsm48_mcc_mnc_to_bcd() and gsm48_mcc_mnc_from_bcd().
    - gsm0808_create_layer3_aoip2() after gsm0808_create_layer3_aoip().
    - gsm48_decode_lai2(), gsm48_generate_lai2() after
      gsm48_decode_lai(), gsm48_generate_lai().
    - The equivalent of gsm0808_create_layer3() for preserving leading zeros is
      gsm0808_create_layer3_aoip2() with the scl argument passed as NULL; instead
      of introducing a new shim function like gsm0808_create_layer3_2(), indicate
      such in the API docs, only.
    - gsm48_mnc_from_str() to encode leading zeros from string, useful for VTY
      config parsing.
    - gsm48_mnc_cmp() to compare MNC values including leading zeros.
    In various log output, include the leading MNC zeros.
    Mark one TODO in card_fs_sim.c, I am not sure how to communicate a leading zero
    to/from a SIM card FS. The focus here is on the core network / BSS.
    To indicate ABI incompatibility, bump libosmogsm and libosmogb LIBVERSIONs;
    adjust debian files accordingly.
    Implementation choices:
    - The default behavior upon zero-initialization will be the mnc_3_digits flag
      set to false, which yields exactly the previous behavior.
    - I decided against packing the mnc with the mnc_3_digits field into a
      sub-struct because it would enlarge this patch; plus, with a separate flag,
      current code can decide when to start heeding leading zeros.
    Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221

commit d5a577b043aab7d27608601ed751e8e17ec5457f
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 21:48:07 2018 +0100

    gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai()
    Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9

commit b9fd7eba1558328802ae9dff79f708bd6ba7b10b
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 15:14:03 2018 +0100

    gsm0408_test: RA test: include min/max value cases
    (Preparation for adding 3-digit MNC)
    Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086

commit c38b32dde94ae5547a11c4d59adb3510576300b0
Author: Neels Hofmeyr <neels at>
Date:   Tue Feb 20 15:13:18 2018 +0100

    gsm0408_test: include BCD and leading zeros in test output
    (Preparation for adding 3-digit MNC)
    Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45


Summary of changes:
 include/osmocom/gsm/gsm23003.h |   1 +
 include/osmocom/gsm/gsm48.h    |  10 +++-
 src/gb/gprs_bssgp.c            |   6 +-
 src/gb/gprs_bssgp_vty.c        |   9 +--
 src/gsm/gsm48.c                |  79 ++++++++++++++++++++++++
 src/gsm/         |   7 +++
 tests/gsm0408/gsm0408_test.c   |  45 +++++++-------
 tests/gsm0408/gsm0408_test.ok  | 132 ++++++++++++++++++++---------------------
 8 files changed, 186 insertions(+), 103 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list