libsmpp34.git branch master updated. 1.12-7-gc63971f

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Sun Sep 17 14:59:59 UTC 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom fork of the Open SMPP 3.4 library".

The branch, master has been updated
       via  c63971fab0d67bc52d7fd455529b844009aa8565 (commit)
       via  cbdde82aca1103db1ed69f29a666f29fdc6b79ba (commit)
       via  43dc9992bcc5335a5aea99ffde5bd634e96714bb (commit)
       via  cad0cc552f9956af3fa90d12de443dabe5c7c320 (commit)
       via  fe9f88add068fa08831abe535ee013cbd63adb3a (commit)
       via  a11a464552736f813656ca17c30c355543cfa573 (commit)
      from  823e711018f053b3878071fe84e929b0623ca08b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libsmpp34/commit/?id=c63971fab0d67bc52d7fd455529b844009aa8565

commit c63971fab0d67bc52d7fd455529b844009aa8565
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Fri Sep 15 20:09:19 2017 +0200

    Fix Out of bounds compilation warning in OCTET8
    
    The code in OCTET8 implementation assumes the len is placed inside the
    byte preceding the memory buffer, which is true for the defined cases.
    However, it creates a compilation warning. Better pass the value
    directly from the struct field rather than playing addr games. this way
    we also assert we require to explicitly pass the len.
    
    Fixes lots of warning like the one below:
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_u
    npack’:
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:147:14: warning: array
     subscript is above array bounds [-Warray-bounds]
         lenval = *((inst par) - 1);\
                  ^~~~~~~~~~~~~~~~~
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/def_frame/submit_sm.frame:18:2: note: in e
    xpansion of macro ‘OCTET8’
      OCTET8( instancia, short_message, 254 );
      ^~~~~~
    
    Change-Id: Id110f4e977c3becdb44cf5492c372e530ea51551

http://cgit.osmocom.org/libsmpp34/commit/?id=cbdde82aca1103db1ed69f29a666f29fdc6b79ba

commit cbdde82aca1103db1ed69f29a666f29fdc6b79ba
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Fri Sep 15 19:25:52 2017 +0200

    bind_receiver_resp_test.c: Fix compilation warning
    
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c: In function ‘main’:
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c:55:58: warning: ‘snprintf’ output
     truncated before the last format character [-Wformat-truncation=]
         snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "1234567890123456");
                                                              ^
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c:55:5: note: ‘snprintf’ output 17
    bytes into a destination of size 16
         snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "1234567890123456");
    
    Change-Id: I4ec682a5e2ee4d02008a9c86a0a5507792667d0e

http://cgit.osmocom.org/libsmpp34/commit/?id=43dc9992bcc5335a5aea99ffde5bd634e96714bb

commit 43dc9992bcc5335a5aea99ffde5bd634e96714bb
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Fri Sep 15 19:17:10 2017 +0200

    smpp34_unpack.c: remove unused variable
    
    Fixes compilation warning below:
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_unpack’:
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:232:18: warning: variable ‘l’ set but not used [
    -Wunused-but-set-variable]
             uint32_t l;
    
    Change-Id: I75baa65b575deec1cc040490f2e76ebb54e46ca7

http://cgit.osmocom.org/libsmpp34/commit/?id=cad0cc552f9956af3fa90d12de443dabe5c7c320

commit cad0cc552f9956af3fa90d12de443dabe5c7c320
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Fri Sep 15 19:15:05 2017 +0200

    smpp34_structs.h: Fix truncated output in str_tlv_id
    
    Fixes compilation warning below:
    
    %s’ directive output may be truncated writing between 8 and 33 bytes into a regio
    n of size 30 [-Wformat-truncation=]
         snprintf(buff, SMALL_BUFF, "%s",
                                     ^~
    /home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_params.c:136:5: note: ‘
    snprintf’ output between 9 and 34 bytes into a destination of size 30
         snprintf(buff, SMALL_BUFF, "%s",
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     #define OPERACION( p_tlv_id ) (tlv_id == p_tlv_id)?#p_tlv_id:
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     #include "def_list/tlv_id.list"
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 "Reserved"
                 ~~~~~~~~~~
     #undef OPERACION
     ~~~~~~~~~~~~~~~~
               );
    
    Change-Id: Ie2ba6182eb0cdd98cadb8317aef49141244aa92d

http://cgit.osmocom.org/libsmpp34/commit/?id=fe9f88add068fa08831abe535ee013cbd63adb3a

commit fe9f88add068fa08831abe535ee013cbd63adb3a
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Fri Sep 15 19:14:19 2017 +0200

    smpp34_structs.h: Fix trailing whitespace
    
    Change-Id: I5838e216fe16b4789bb1a0ce40ce496f46a3c328

http://cgit.osmocom.org/libsmpp34/commit/?id=a11a464552736f813656ca17c30c355543cfa573

commit a11a464552736f813656ca17c30c355543cfa573
Author: Pau Espin Pedrol <pespin at sysmocom.de>
Date:   Fri Sep 15 18:58:47 2017 +0200

    smpp34_dumpBuf.c: remove unused variable
    
    Fixes compilation warning below:
    smpp34_dumpBuf.c:52:9: warning: variable ‘lefterror’ set but not used [-Wunused-but-set-variable]
         int lefterror = 0;
    
    Change-Id: Iea8ff80d3e4d16aaca6e37d64593b50fa27c8cfb

-----------------------------------------------------------------------

Summary of changes:
 def_frame/deliver_sm.frame         |  2 +-
 def_frame/replace_sm.frame         |  2 +-
 def_frame/submit_multi.frame       |  2 +-
 def_frame/submit_sm.frame          |  2 +-
 src/smpp34_dumpBuf.c               |  2 -
 src/smpp34_dumpPdu.c               |  3 +-
 src/smpp34_pack.c                  |  3 +-
 src/smpp34_structs.h               | 82 +++++++++++++++++++-------------------
 src/smpp34_unpack.c                |  5 +--
 test_pdu/bind_receiver_resp_test.c |  2 +-
 10 files changed, 49 insertions(+), 56 deletions(-)


hooks/post-receive
-- 
Osmocom fork of the Open SMPP 3.4 library



More information about the osmocom-commitlog mailing list