osmo-hlr.git branch neels/db_tool created. 0.0.1-112-gc0d4c63

gitosis at osmocom.org gitosis at osmocom.org
Tue Oct 24 23:16:18 UTC 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, neels/db_tool has been created
        at  c0d4c63863d47684986f5f2283acca2e23ddfbde (commit)

- Log -----------------------------------------------------------------

commit c0d4c63863d47684986f5f2283acca2e23ddfbde
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Oct 24 23:26:53 2017 +0200

    add osmo-hlr-db-tool
    Change-Id: I0dfa6ec033dd93161c1adc2ce1637195fe5b7a63


commit 8f063796e9862d9ff1e93015562c401db49d0f9a
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Wed Oct 25 00:26:29 2017 +0200

    cosmetic: sql/hlr.sql: move comments
    By moving the comments inside the table row definitions, they are dumped back
    during 'sqlite3 hlr.db .dump'. When they are between SQL statements, the
    comments are lost.
    Tweak wording.
    Change-Id: I280c2e2d3e9b7f1dc632722724d9e1c54d041820


commit 10df27f168e08f0790fa6e3a01096f82c83c0c60
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Oct 24 23:26:27 2017 +0200

    automatically create db tables on osmo-hlr invocation
    If a database file is missing, osmo-hlr creates it, as is the default sqlite3
    API behavior. Actually also create initial tables in it.
    Note: it might be desirable to bail if the desired database file does not
    exist. That is however a different semantic from this patch; this is not
    changing the fact that a db file is created, this just creates a usable one.
    Note: I am about to add osmo-hlr-db-tool to do database migration from
    osmo-nitb, and possibly also CSV import. For that, it is also desirable to
    bootstrap a usable database, which is the core reason for this patch.
    Create db_bootstrap.h as a BUILT_SOURCE from reading in sql/hlr.sql and
    mangling via sed to a list of SQL statement strings. On each db_open(), run
    this bootstrap sequence.
    In sql/hlr.sql:
    * Add 'IF NOT EXISTS' to 'CREATE TABLE', so that the bootstrap
      sequence can be run on an already bootstrapped db. This is the same as
      osmo-nitb does it.
    * Drop the final comment at the bottom, which ended up being an empty SQL
      statement and causing sqlite3 API errors, seemed to have no purpose anyway.
    Note: by composing the statement strings as multiline and including the SQL
    comments, sqlite3 actually retains the comments contained in table definitions
    and prints them back during 'sqlite3 hlr.db .dump'.
    Change-Id: If77dbbfe1af3e66aaec91cb6295b687f37678636


commit 1d13fe167302e68aac79c9c20bd5b18476ef5cb9
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Wed Oct 25 01:13:09 2017 +0200

    db_test: fix *FLAGS
    Change-Id: Ie57a04b7efc7a1e16cf0e3625d8ad2f0ef0089b0



More information about the osmocom-commitlog mailing list