libosmocore.git branch master updated. 0.9.6-461-g04c88120

gitosis at gitosis at
Tue Oct 24 16:01:04 UTC 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  04c881207f903f48bd5863bc851b8384a06578de (commit)
       via  a7a5065385be71239d49bb60a690402d3153eb34 (commit)
       via  ae510dc4a743e981b40fc5e1fdb4c109f2425e27 (commit)
       via  8c4f5457aa185bc9d74b6962aaafdd263ea6af56 (commit)
       via  febe83c4243520ccc64544026d5f496ef945a9aa (commit)
      from  c8ef736370483df6feb761b49fccaa6790b6f8c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 04c881207f903f48bd5863bc851b8384a06578de
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 18:34:48 2017 +0800

    stats_test: Extend check to include test for counter group name mangling
    In Change-Id Ifc6ac824f5dae9a848bb4a5d067c64a69eb40b56 we introduce
    name mangling to replace any '.' in counter (group) names to be
    converted to ':'. Let's test for this functionality explicitly as part
    of the stats_test.
    Change-Id: Ie35682aa79526e2ffeab6995cd640b7847d855bf

commit a7a5065385be71239d49bb60a690402d3153eb34
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 17:49:21 2017 +0800

    Convert lib-internal rate_ctr from '.' separator to ':' separator
    The rate_ctr.c code would do this mangling automatically, but let's
    avoid using this from new versions of our code for
    Change-Id: I24a556f447cfac25efb6e83cac2d0c2972d98fe3

commit ae510dc4a743e981b40fc5e1fdb4c109f2425e27
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 17:46:14 2017 +0800

    rate_ctr: Enforce counter (and ctr_group) names are valid identifiers
    As rate counters are automatically exposed on the CTRL interface,
    we need to make sure they don't contain special characters such as '.'
    which are not permitted/supported by CTRL.
    In order to be able to run old versions of osmocom programs with
    libosmocore versions after this commit, we introduce some special
    name mangling:  Any '.' in the names are replaced with ':' during
    counter group registration, if valid identifiers can be obtained
    this way.
    Change-Id: Ifc6ac824f5dae9a848bb4a5d067c64a69eb40b56

commit 8c4f5457aa185bc9d74b6962aaafdd263ea6af56
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 17:44:03 2017 +0800

    fsm: Enforce FSM and FSM instance names are valid osmocom identifiers
    Let's enforce that the names of FSMs and their instances are valid
    osmocom identifiers.  This is important as the FSMs are automatically
    exported via those names on the CTRL inteface, and we have to make sure
    CTRL syntax actually permits them.
    Change-Id: I9ef59432f43a3cdb94e4cbb0c44ac3f9b2aac0f2

commit febe83c4243520ccc64544026d5f496ef945a9aa
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 17:41:59 2017 +0800

    Introduce osmo_identifier_valid() function to check validity of identifier
    We define the notion of an 'osmocom identifier' which is basically a
    7-bit US-ASCII without any special characters beyond "-_:@".  We
    introduce a function to verify if an identifier consists only of the
    permitted characters.
    Change-Id: I96a8d345c5a69238a12d040f39b70c485a5c421c


Summary of changes:
 include/osmocom/core/rate_ctr.h |   2 +-
 include/osmocom/core/utils.h    |   3 +
 src/fsm.c                       |  13 ++++-
 src/gb/gprs_bssgp.c             |  10 ++--
 src/gb/gprs_ns.c                |  14 ++---
 src/rate_ctr.c                  | 118 +++++++++++++++++++++++++++++++++++++++-
 src/utils.c                     |  28 ++++++++++
 tests/gb/gprs_ns_test.c         |   2 +-
 tests/stats/stats_test.c        |  43 ++++++++++-----
 tests/stats/stats_test.ok       | 108 ++++++++++++++++++++++--------------
 10 files changed, 270 insertions(+), 71 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list