libosmocore.git branch laforge/ctr-ctrl updated. 0.9.6-405-gdc8091e3

gitosis at gitosis at
Tue Oct 3 10:41:45 UTC 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, laforge/ctr-ctrl has been updated
  discards  27c9d1e14398ad8533a7988ccd6ef1683e98d949 (commit)
  discards  7666ff00a9c4f5c59cbb5c7da3779a97cece492c (commit)
       via  dc8091e37e195f3f78d6af4bd356d887e3cb4999 (commit)
       via  437cf1ad131bf5185282e58fca110ad1c510aaca (commit)
       via  882fb3e07923d2eb1505808ddf100b823f5506cd (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (27c9d1e14398ad8533a7988ccd6ef1683e98d949)
             N -- N -- N (dc8091e37e195f3f78d6af4bd356d887e3cb4999)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit dc8091e37e195f3f78d6af4bd356d887e3cb4999
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 18:34:48 2017 +0800

    stats_test: Extend check to include test for counter group name mangling
    In Change-Id Ifc6ac824f5dae9a848bb4a5d067c64a69eb40b56 we introduce
    name mangling to replace any '.' in counter (group) names to be
    converted to ':'. Let's test for this functionality explicitly as part
    of the stats_test.
    Change-Id: Ie35682aa79526e2ffeab6995cd640b7847d855bf

commit 437cf1ad131bf5185282e58fca110ad1c510aaca
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 17:49:21 2017 +0800

    Convert lib-internal rate_ctr from '.' separator to ':' separator
    The rate_ctr.c code would do this mangling automatically, but let's
    avoid using this from new versions of our code for
    Change-Id: I24a556f447cfac25efb6e83cac2d0c2972d98fe3

commit 882fb3e07923d2eb1505808ddf100b823f5506cd
Author: Harald Welte <laforge at>
Date:   Tue Oct 3 17:46:14 2017 +0800

    rate_ctr: Enforce counter (and ctr_group) names are valid identifiers
    As rate counters are automatically exposed on the CTRL interface,
    we need to make sure they don't contain special characters such as '.'
    which are not permitted/supported by CTRL.
    In order to be able to run old versions of osmocom programs with
    libosmocore versions after this commit, we introduce some special
    name mangling:  Any '.' in the names are replaced with ':' during
    counter group registration, if valid identifiers can be obtained
    this way.
    Change-Id: Ifc6ac824f5dae9a848bb4a5d067c64a69eb40b56


Summary of changes:
 tests/stats/stats_test.c  | 37 +++++++++++++++++++++++++++----------
 tests/stats/stats_test.ok | 24 ++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 10 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list