osmo-pcu.git branch master updated. 0.2-892-g5dd8d1b

gitosis at osmocom.org gitosis at osmocom.org
Mon Mar 13 11:25:30 UTC 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, master has been updated
       via  5dd8d1bbd89cfaa10d8194502778deb96fe82184 (commit)
      from  727295f20611bbc2d2bc5cd7341f73e0536ec46a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 5dd8d1bbd89cfaa10d8194502778deb96fe82184
Author: Max <msuraev at sysmocom.de>
Date:   Wed Mar 8 12:06:42 2017 +0100

    bts.cpp: Fix overloading ambiguity
    Fix error introduced in 1275a3f91a744e011b0dba82b09124d249c7abb5 by
    using signed 32 bit integer which is enough for Frame Number in
    GSM. Also, mark parameter constraints more explicitly:
    - add assert for expected FN values
    - don't perform computation for non-relative FN
    The error was:
    bts.cpp: In member function ‘uint32_t BTS::rfn_to_fn(uint32_t)’:
    bts.cpp:554:25: error: call of overloaded ‘abs(uint32_t)’ is ambiguous
      if (abs(rfn - m_cur_rfn) > RFN_THRESHOLD) {
    In file included from /usr/include/c++/6/cstdlib:75:0,
                     from /usr/include/c++/6/stdlib.h:36,
                     from /usr/include/osmocom/core/linuxrbtree.h:97,
                     from /usr/include/osmocom/core/timer.h:35,
                     from ./bts.h:29,
                     from bts.cpp:21:
    /usr/include/stdlib.h:735:12: note: candidate: int abs(int)
     extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
    In file included from /usr/include/c++/6/stdlib.h:36:0,
                     from /usr/include/osmocom/core/linuxrbtree.h:97,
                     from /usr/include/osmocom/core/timer.h:35,
                     from ./bts.h:29,
                     from bts.cpp:21:
    /usr/include/c++/6/cstdlib:185:3: note: candidate: __int128 std::abs(__int128)
       abs(__GLIBCXX_TYPE_INT_N_0 __x) { return __x >= 0 ? __x : -__x; }
    /usr/include/c++/6/cstdlib:180:3: note: candidate: long long int std::abs(long long int)
       abs(long long __x) { return __builtin_llabs (__x); }
    /usr/include/c++/6/cstdlib:172:3: note: candidate: long int std::abs(long int)
       abs(long __i) { return __builtin_labs(__i); }
    Change-Id: Ib6d895a97aa35414f245ea4406c6e78f1b4fb5b8


Summary of changes:
 src/bts.cpp | 15 ++++++++++-----
 src/bts.h   |  2 +-
 2 files changed, 11 insertions(+), 6 deletions(-)


More information about the osmocom-commitlog mailing list