From gitosis at osmocom.org Fri Dec 1 01:57:48 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 01:57:48 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1869-gd27d4354 Message-ID: <201712010157.vB11vmwn095168@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via d27d4354c37fbce910869465e60bc226efc6e6f3 (commit) via 517bda18b21b5127edb92ef79119c885c3b2cd67 (commit) from 89009751ea7ceda542c254633f4ceef23b3f8f90 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=d27d4354c37fbce910869465e60bc226efc6e6f3 commit d27d4354c37fbce910869465e60bc226efc6e6f3 Author: Holger Hans Peter Freyther Date: Wed Nov 29 19:38:01 2017 +0800 mobile: ms->shutdown was not converted properly to enum ms->shutdown is ms->shutdown != 0 which should have been converted to ms->shutdown != MS_SHUTDOWN_NONE. This is fixing sending SMS. This was introduced in Iee1140e4848923c7270495c381bf87b7e3fddee1. Change-Id: Ia74374dd9c0dd0ba9cf5725d66f4d2f2a2cfe9ef http://cgit.osmocom.org/osmocom-bb/commit/?id=517bda18b21b5127edb92ef79119c885c3b2cd67 commit 517bda18b21b5127edb92ef79119c885c3b2cd67 Author: Holger Hans Peter Freyther Date: Thu Nov 30 16:51:58 2017 +0800 mobile: Speculative crash fix of the SI pointer The SIs are kept per ARFCN and for the current cell the cs->si alias will be assigned[1]. On mobile_exit all SIs will be freed but the alias will not be set to NULL. This is a speculative fix but it doesn't seem to make things worse. Related: OS#2690 [1] cs->si = cs->list[cs->arfci].sysinfo; Change-Id: Icf20f9aa03dd26d4bee78772b7f3da034bb34b99 ----------------------------------------------------------------------- Summary of changes: src/host/layer23/src/mobile/gsm322.c | 1 + src/host/layer23/src/mobile/gsm411_sms.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Fri Dec 1 11:54:18 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 11:54:18 GMT Subject: libosmocore.git branch master updated. 0.10.2-38-g33dbecbb Message-ID: <201712011154.vB1BsIeM071169@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 33dbecbbeb2368f8f05fff181383f1c3279f0cd3 (commit) from 458a6f59e38f6cc691c72b89cdc9988ba9cf23b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=33dbecbbeb2368f8f05fff181383f1c3279f0cd3 commit 33dbecbbeb2368f8f05fff181383f1c3279f0cd3 Author: Max Date: Tue Nov 28 19:49:05 2017 +0100 coding test: use OSMO_ASSERT Change-Id: I896d6aaae3c36b87243b7dc270267090dcb44afe ----------------------------------------------------------------------- Summary of changes: tests/coding/coding_test.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Fri Dec 1 12:01:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 12:01:06 GMT Subject: osmo-gsm-manuals.git branch master updated. 8b368b11bed5bc8fabf97a6a1494755ee288c2f8 Message-ID: <201712011201.vB1C16Av074504@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via 8b368b11bed5bc8fabf97a6a1494755ee288c2f8 (commit) via 42ccd6f4353cca297730e2350f364e21b0d84f1f (commit) via ae30379a2ccda2522fd32cec4b03388a626ee4bb (commit) from aaeee90f0b36b573bcba94b75f1d076271ecbbff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=8b368b11bed5bc8fabf97a6a1494755ee288c2f8 commit 8b368b11bed5bc8fabf97a6a1494755ee288c2f8 Author: Pau Espin Pedrol Date: Fri Dec 1 12:22:00 2017 +0100 OsmoSGSN: configuration: Document CDR CTRL interface Change-Id: Ib729e2fc4898c20d27e95fc0f13abe9c0656dda5 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=42ccd6f4353cca297730e2350f364e21b0d84f1f commit 42ccd6f4353cca297730e2350f364e21b0d84f1f Author: Pau Espin Pedrol Date: Fri Dec 1 12:21:23 2017 +0100 OsmoSGSN: configuration: Add missing pdp-periodic event Change-Id: I2d8b11496e75abd23a42efab8eabba2b5b0912e9 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=ae30379a2ccda2522fd32cec4b03388a626ee4bb commit ae30379a2ccda2522fd32cec4b03388a626ee4bb Author: Pau Espin Pedrol Date: Fri Dec 1 11:56:54 2017 +0100 OsmoSGSN: configuration: Move pdp ctx specific CDR fields to its own table Change-Id: I056f278b64ab426b9455b6a667abf2fe7fc94022 ----------------------------------------------------------------------- Summary of changes: OsmoSGSN/chapters/configuration.adoc | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Fri Dec 1 12:01:43 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 12:01:43 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-30-g1d85bea Message-ID: <201712011201.vB1C1hpr074730@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 1d85bea152506b4c812eafaccb0d390678f17ca9 (commit) from f1e44c5493eec4f43006747e98ed8bddbf468c4c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=1d85bea152506b4c812eafaccb0d390678f17ca9 commit 1d85bea152506b4c812eafaccb0d390678f17ca9 Author: Neels Hofmeyr Date: Sat Nov 18 18:29:49 2017 +0100 sanitize build: ensure uint16/32 alignment in gtpie_test and in46a_test Fixes sanitize build failures: Testing gtpie_tlv() ../../../../src/osmo-ggsn/tests/gtp/gtpie_test.c:30:2: runtime error: load of misaligned address 0x55c0a0830f21 for type 'uint16_t', which requires 2 byte alignment 0x55c0a0830f21: note: pointer points here 00 00 00 17 00 06 01 02 03 04 05 06 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ Testing gtpie_tv0() Testing gtpie_tv1() Testing gtpie_tv2() ../../../../src/osmo-ggsn/tests/gtp/gtpie_test.c:76:2: runtime error: load of misaligned address 0x55c0a0830f21 for type 'uint16_t', which requires 2 byte alignment 0x55c0a0830f21: note: pointer points here 00 00 00 2a ab cd 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ Testing gtpie_tv4() ../../../../src/osmo-ggsn/tests/gtp/gtpie_test.c:90:2: runtime error: load of misaligned address 0x55c0a0830f21 for type 'uint32_t', which requires 4 byte alignment 0x55c0a0830f21: note: pointer points here 00 00 00 2a ab cd 01 23 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ Testing gtpie_tv8() ../../../../src/osmo-ggsn/tests/gtp/gtpie_test.c:104:2: runtime error: load of misaligned address 0x55c0a0830f21 for type 'uint32_t', which requires 4 byte alignment 0x55c0a0830f21: note: pointer points here 00 00 00 2a 00 01 02 03 04 05 06 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ ../../../../src/osmo-ggsn/tests/gtp/gtpie_test.c:105:2: runtime error: load of misaligned address 0x55c0a0830f25 for type 'uint32_t', which requires 4 byte alignment 0x55c0a0830f25: note: pointer points here 00 01 02 03 04 05 06 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ Change-Id: I9eb16450af942d6464211e190f6a4d5a1d814842 ----------------------------------------------------------------------- Summary of changes: tests/gtp/gtpie_test.c | 11 ++++++----- tests/lib/in46a_test.c | 3 ++- 2 files changed, 8 insertions(+), 6 deletions(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Fri Dec 1 12:01:53 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 12:01:53 GMT Subject: libosmocore.git branch master updated. 0.10.2-39-g37a83405 Message-ID: <201712011201.vB1C1rgo074816@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 37a83405a5ebbaebc02b7ce8fb9c8bf597cd678c (commit) from 33dbecbbeb2368f8f05fff181383f1c3279f0cd3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=37a83405a5ebbaebc02b7ce8fb9c8bf597cd678c commit 37a83405a5ebbaebc02b7ce8fb9c8bf597cd678c Author: Holger Hans Peter Freyther Date: Wed Nov 29 11:46:39 2017 +0800 logging: Extend the LOGPSRC macro to put cont in it as well For the lua console printing I need to print several values with continuation but also specify the filename. Add a "C" for continue and forward arguments. Change-Id: I1d6dcb2567b9ed2c8767f661737b979bc3d1377e ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/logging.h | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Fri Dec 1 12:06:08 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 12:06:08 GMT Subject: osmo-hlr.git branch master updated. 0.1.0-19-g43bd606 Message-ID: <201712011206.vB1C68LN077211@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 43bd6069e83ff034dcaff4780891d0468e899b07 (commit) from 2dee60ef443343a297ffc1bfdb9321c6f7e07a3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=43bd6069e83ff034dcaff4780891d0468e899b07 commit 43bd6069e83ff034dcaff4780891d0468e899b07 Author: Max Date: Thu Nov 23 16:55:17 2017 +0100 Remove unused ipa.py Change-Id: I0a6c22f38480ae75ae9efb452e4eeacb39ae4f42 ----------------------------------------------------------------------- Summary of changes: contrib/ipa.py | 278 --------------------------------------------------------- 1 file changed, 278 deletions(-) delete mode 100755 contrib/ipa.py hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Fri Dec 1 12:50:45 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 12:50:45 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1870-gff43e1a1 Message-ID: <201712011250.vB1CojjK098529@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via ff43e1a1b306ea63f7b375bf0ab2773df7d144ba (commit) from d27d4354c37fbce910869465e60bc226efc6e6f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=ff43e1a1b306ea63f7b375bf0ab2773df7d144ba commit ff43e1a1b306ea63f7b375bf0ab2773df7d144ba Author: Holger Hans Peter Freyther Date: Wed Nov 29 16:29:08 2017 +0800 mobile: Re-introduce msg_ref in struct gsm_sms In I4bac5f06921b5fd85a98d97770d42d4858ca1c42 I have removed the msg_ref field. But in case we delete a transaction with a pending SMS we need to get the msg_ref from somewhere. This is a partial revert but for RX SMS it makes sure that msg_ref will be set (it wasn't set before). Change-Id: I9b0f90f875de5f072565878861d38b0bb3bfbded ----------------------------------------------------------------------- Summary of changes: src/host/layer23/include/osmocom/bb/mobile/gsm411_sms.h | 1 + src/host/layer23/src/mobile/gsm411_sms.c | 16 +++++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Fri Dec 1 12:51:01 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 12:51:01 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1871-g271cdad4 Message-ID: <201712011251.vB1Cp12C098706@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via 271cdad401de897fed49c19897bf89359044457e (commit) from ff43e1a1b306ea63f7b375bf0ab2773df7d144ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=271cdad401de897fed49c19897bf89359044457e commit 271cdad401de897fed49c19897bf89359044457e Author: Holger Hans Peter Freyther Date: Wed Nov 29 11:50:54 2017 +0800 mobile: Use enum and not magic value in the VTY Change-Id: I8a1d975997e592344327e6b0783bd0c5d2534b02 ----------------------------------------------------------------------- Summary of changes: src/host/layer23/src/mobile/vty_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Fri Dec 1 14:44:31 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 14:44:31 GMT Subject: osmo-ggsn.git branch pespin/split-ipv6 created. 1.1.0-33-gfad9ed4 Message-ID: <201712011444.vB1EiVmb045467@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, pespin/split-ipv6 has been created at fad9ed431b545a8b314e952f50e7fefc49477553 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=fad9ed431b545a8b314e952f50e7fefc49477553 commit fad9ed431b545a8b314e952f50e7fefc49477553 Author: Pau Espin Pedrol Date: Fri Dec 1 15:29:30 2017 +0100 Split implementation of tun_setaddr6 into a separate module Some systems containing specific versions of libc and linux kernel can produce compilation errors due to conflicting definition of structures in different include files. This can be the case when including and . See for more information: https://sourceware.org/glibc/wiki/Synchronizing_Headers I hit this compilation error on the system I'm compiling osmo-ggsn with: arm-poky-linux-gnueabi-gcc ... -c in46_addr.c In file included from /usr/include/linux/ipv6.h:5:0, from tun.c:75: /usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr' struct in6_addr { ^ In file included from tun.c:24:0: /usr/include/netinet/in.h:196:8: note: originally defined here struct in6_addr ^ To fix the issue, this patch moves tun_setaddr6 to its own file which then includes (which in turn includes in6.h). Change-Id: Ie161f376edda605e5cd87176169553176235fafd http://cgit.osmocom.org/osmo-ggsn/commit/?id=b9ace14717a220edb380d21d849e95ae0c30784e commit b9ace14717a220edb380d21d849e95ae0c30784e Author: Pau Espin Pedrol Date: Fri Dec 1 14:45:31 2017 +0100 cosmetic: Reorder tun_addaddr to get rid of decl of tun_setaddr4 In any case, if we add support for ipv6 in tun_addaddr we will need tun_setaddr (and also change the API of tun_addaddr to use in46_addr). Change-Id: Iadf51379455174a642b477040ec96f28022c24c7 http://cgit.osmocom.org/osmo-ggsn/commit/?id=d9fff0c543e48ac49f97fd2b2fffdcb05115dc1e commit d9fff0c543e48ac49f97fd2b2fffdcb05115dc1e Author: Pau Espin Pedrol Date: Fri Dec 1 15:39:28 2017 +0100 tun_setaddr6: Fix log typo Change-Id: Id7f7d33a33730d57c5ecf7ebf5612f4744cf5163 ----------------------------------------------------------------------- hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Fri Dec 1 16:08:50 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 16:08:50 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-32-gb9ace14 Message-ID: <201712011608.vB1G8oH9079369@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via b9ace14717a220edb380d21d849e95ae0c30784e (commit) via d9fff0c543e48ac49f97fd2b2fffdcb05115dc1e (commit) from 1d85bea152506b4c812eafaccb0d390678f17ca9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: lib/tun.c | 343 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 170 insertions(+), 173 deletions(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Fri Dec 1 16:55:04 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 16:55:04 GMT Subject: osmo-ggsn.git branch pespin/disable-ipv6 created. 1.1.0-33-g31e9f03 Message-ID: <201712011655.vB1Gt4Hc099768@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, pespin/disable-ipv6 has been created at 31e9f03dbf9dee2d5e4a97ea96d7a9b5a63414ca (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=31e9f03dbf9dee2d5e4a97ea96d7a9b5a63414ca commit 31e9f03dbf9dee2d5e4a97ea96d7a9b5a63414ca Author: Pau Espin Pedrol Date: Fri Dec 1 17:54:32 2017 +0100 Add configure flag to disable ipv6 support Change-Id: I651a12d63d025bde61dcbc3c6b949cd0fed43580 ----------------------------------------------------------------------- hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Fri Dec 1 17:41:51 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 17:41:51 GMT Subject: libosmocore.git branch laforge/prbs-tool created. 0.10.2-31-gbe345969 Message-ID: <201712011741.vB1HfpbV016704@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/prbs-tool has been created at be3459697264cda28e5f471e5bd5cbb0888a7e64 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=be3459697264cda28e5f471e5bd5cbb0888a7e64 commit be3459697264cda28e5f471e5bd5cbb0888a7e64 Author: Harald Welte Date: Fri Dec 1 18:41:11 2017 +0100 WIP: PRBS tool sending PRBS sequence to TRX Change-Id: I2300f909bbfda10a7053320edfd1deaea763759a http://cgit.osmocom.org/libosmocore/commit/?id=b55e1dc5dd01cbefa29b8a66a29a740730887f43 commit b55e1dc5dd01cbefa29b8a66a29a740730887f43 Author: Harald Welte Date: Mon Nov 20 20:22:22 2017 +0100 timer: fixup whitespace issues Change-Id: Ic0c8fc407a45ff4b0d3da1d3e4fdf8885b5bca9b ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Fri Dec 1 17:44:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 17:44:06 GMT Subject: libosmocore.git branch laforge/prbs-tool updated. 0.10.2-31-g285c6fbe Message-ID: <201712011744.vB1Hi6eO017629@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/prbs-tool has been updated discards be3459697264cda28e5f471e5bd5cbb0888a7e64 (commit) via 285c6fbe5252f12cd256365343dd427dc65c676f (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (be3459697264cda28e5f471e5bd5cbb0888a7e64) \ N -- N -- N (285c6fbe5252f12cd256365343dd427dc65c676f) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=285c6fbe5252f12cd256365343dd427dc65c676f commit 285c6fbe5252f12cd256365343dd427dc65c676f Author: Harald Welte Date: Fri Dec 1 18:41:11 2017 +0100 WIP: PRBS tool sending PRBS sequence to TRX Change-Id: I2300f909bbfda10a7053320edfd1deaea763759a ----------------------------------------------------------------------- Summary of changes: utils/prbs-tool.c | 322 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 322 insertions(+) create mode 100644 utils/prbs-tool.c hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Fri Dec 1 20:41:55 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 1 Dec 2017 20:41:55 GMT Subject: libosmocore.git branch laforge/prbs-tool updated. 0.10.2-31-gd4053eb3 Message-ID: <201712012041.vB1Kftob006885@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/prbs-tool has been updated discards 285c6fbe5252f12cd256365343dd427dc65c676f (commit) via d4053eb39ab6ad38c1802e97febfec1b5f78baed (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (285c6fbe5252f12cd256365343dd427dc65c676f) \ N -- N -- N (d4053eb39ab6ad38c1802e97febfec1b5f78baed) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d4053eb39ab6ad38c1802e97febfec1b5f78baed commit d4053eb39ab6ad38c1802e97febfec1b5f78baed Author: Harald Welte Date: Fri Dec 1 18:41:11 2017 +0100 WIP: PRBS tool sending PRBS sequence to TRX Change-Id: I2300f909bbfda10a7053320edfd1deaea763759a ----------------------------------------------------------------------- Summary of changes: utils/prbs-tool.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sat Dec 2 18:59:49 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 2 Dec 2017 18:59:49 GMT Subject: osmo-ir77.git branch master updated. ee7d85297fb53d475899754b2ed47c0d4c9186aa Message-ID: <201712021859.vB2IxnLZ083299@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Collection of Iridium tools". The branch, master has been updated via ee7d85297fb53d475899754b2ed47c0d4c9186aa (commit) via 6f7b0702a6cddad9d2d00fec91b3b919c7e05a73 (commit) via 982cba9029d0c1252bdc50ba2efea463a92804a1 (commit) from 39141a86bbaf43ccc7543e0bdf46107d59f539c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ir77/commit/?id=ee7d85297fb53d475899754b2ed47c0d4c9186aa commit ee7d85297fb53d475899754b2ed47c0d4c9186aa Author: Sylvain Munaut Date: Sat Dec 2 19:42:03 2017 +0100 Import a basic .gitignore Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/osmo-ir77/commit/?id=6f7b0702a6cddad9d2d00fec91b3b919c7e05a73 commit 6f7b0702a6cddad9d2d00fec91b3b919c7e05a73 Author: Sylvain Munaut Date: Sat Dec 2 19:40:58 2017 +0100 codec: Allow building without libosmocore Signed-off-by: Sylvain Munaut http://cgit.osmocom.org/osmo-ir77/commit/?id=982cba9029d0c1252bdc50ba2efea463a92804a1 commit 982cba9029d0c1252bdc50ba2efea463a92804a1 Author: Sylvain Munaut Date: Sat Dec 2 19:23:42 2017 +0100 codec: Make ir77_ambe_decode return an error if less than 50% are valid Thanks to schneider for the original patch. Signed-off-by: Sylvain Munaut ----------------------------------------------------------------------- Summary of changes: .gitignore | 2 ++ codec/Makefile | 10 ++++++++-- codec/ambe.c | 10 ++++++---- codec/compat_bits.h | 24 ++++++++++++++++++++++++ codec/ecc.c | 4 ++++ codec/frame.c | 2 -- codec/ir77_ambe_decode.c | 13 +++++++++++-- codec/private.h | 4 ++++ 8 files changed, 59 insertions(+), 10 deletions(-) create mode 100644 .gitignore create mode 100644 codec/compat_bits.h hooks/post-receive -- Collection of Iridium tools From gitosis at osmocom.org Sat Dec 2 21:06:14 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 2 Dec 2017 21:06:14 GMT Subject: osmo-bts.git branch master updated. 0.7.0-16-g6b264c5 Message-ID: <201712022106.vB2L6EKd037654@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 6b264c5344d9f6daccef09bf5d793ac9d66a6c36 (commit) via cbcd3c5034084a0b214d32942dfe64362c44c79b (commit) via 62a6a2680f758730e9bd7ad333cf61c993ff0dd2 (commit) via 41d471351fed3b2179af99bebacd4c68cb1ef7df (commit) via 478f2f7696d9646e274e62cc7da5b454ee711dc9 (commit) from 536ebeed0841cf3a76ee7730b2f41dea5c153b85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=6b264c5344d9f6daccef09bf5d793ac9d66a6c36 commit 6b264c5344d9f6daccef09bf5d793ac9d66a6c36 Author: Harald Welte Date: Sat Dec 2 17:31:45 2017 +0100 l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C for MPH Change-Id: Icc0325f41a1d80535d33e123083e220ee47df129 http://cgit.osmocom.org/osmo-bts/commit/?id=cbcd3c5034084a0b214d32942dfe64362c44c79b commit cbcd3c5034084a0b214d32942dfe64362c44c79b Author: Harald Welte Date: Sat Dec 2 16:56:45 2017 +0100 scheduler_trx: L1P is for PH (data), L1M for MPH (control) Almost all log statements in scheduler_trx.c were using the wrong logging subsystem. Let's fix this. Also, make it more obvious from the log subsystem help text Change-Id: I4312f8ab0414eb38db0d62f05c95ab961f500c14 http://cgit.osmocom.org/osmo-bts/commit/?id=62a6a2680f758730e9bd7ad333cf61c993ff0dd2 commit 62a6a2680f758730e9bd7ad333cf61c993ff0dd2 Author: Harald Welte Date: Sat Dec 2 16:29:15 2017 +0100 scheduler: Harmonize log line format; Always print TS name + decoded FN Change-Id: I5703b46c8a59fe00a3cdc063bcf72872980ec5e5 http://cgit.osmocom.org/osmo-bts/commit/?id=41d471351fed3b2179af99bebacd4c68cb1ef7df commit 41d471351fed3b2179af99bebacd4c68cb1ef7df Author: Harald Welte Date: Thu Nov 16 20:45:04 2017 +0100 Comments on individual members of struct gsm_abis_mo Change-Id: I8e005410080201746906b8a60e9f7957031d2e58 http://cgit.osmocom.org/osmo-bts/commit/?id=478f2f7696d9646e274e62cc7da5b454ee711dc9 commit 478f2f7696d9646e274e62cc7da5b454ee711dc9 Author: Harald Welte Date: Sat Dec 2 20:59:51 2017 +0100 measurement.c: Fix various typos in comments Change-Id: Ief208045664769406cd60a92a12c4b44988a98b4 ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/gsm_data_shared.h | 7 ++ include/osmo-bts/scheduler_backend.h | 6 ++ src/common/l1sap.c | 22 ++-- src/common/logging.c | 4 +- src/common/measurement.c | 16 +-- src/common/scheduler.c | 51 ++++----- src/osmo-bts-trx/scheduler_trx.c | 180 ++++++++++++------------------- src/osmo-bts-virtual/scheduler_virtbts.c | 4 +- 8 files changed, 123 insertions(+), 167 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sat Dec 2 22:03:23 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 2 Dec 2017 22:03:23 GMT Subject: libosmocore.git branch laforge/prbs-tool updated. 0.10.2-32-ge2178772 Message-ID: <201712022203.vB2M3N3D062038@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/prbs-tool has been updated via e21787725fe2345bd360b5dd3682dc9d5d0bd7f2 (commit) from d4053eb39ab6ad38c1802e97febfec1b5f78baed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=e21787725fe2345bd360b5dd3682dc9d5d0bd7f2 commit e21787725fe2345bd360b5dd3682dc9d5d0bd7f2 Author: Harald Welte Date: Sat Dec 2 23:01:29 2017 +0100 prbs-tool: Add error simulation capabilities The tool can now simulate: * lost bursts on the TRX->BTS interface * zeroed/overwritten bursts on the TRX->BTS interface * errors in the TCH codec frames before passing them to the encoder Change-Id: I0b52c2af6d973669ac233bf9868400e497496460 TODO: Ability to introduce errors in certain classes of the bits only. ----------------------------------------------------------------------- Summary of changes: utils/prbs-tool.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 79 insertions(+), 12 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 3 08:58:12 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 08:58:12 GMT Subject: osmo-bts.git branch master updated. 0.7.0-17-g57ce53d Message-ID: <201712030858.vB38wC9u034288@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 57ce53d8aac6dbd4ac10585b7b812c6021a19095 (commit) from 6b264c5344d9f6daccef09bf5d793ac9d66a6c36 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=57ce53d8aac6dbd4ac10585b7b812c6021a19095 commit 57ce53d8aac6dbd4ac10585b7b812c6021a19095 Author: Harald Welte Date: Sat Dec 2 22:00:40 2017 +0100 measurment.c: Introduce INFO category for DMEAS logging There's no point in either having full verbosity in DEBUG level and not logging any measurement related information in INFO. Let's at least print the results at the end of each measurement period in INFO level. Change-Id: I2c870531478c05ce31cc1015597a068a4a76cf99 ----------------------------------------------------------------------- Summary of changes: src/common/measurement.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Dec 3 13:07:44 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 13:07:44 GMT Subject: osmo-ci.git branch master updated. 40c52cf1d361156ab756144ed938f92cba61c8d4 Message-ID: <201712031307.vB3D7in5039258@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 40c52cf1d361156ab756144ed938f92cba61c8d4 (commit) via 80d0d8cd9b28f12fa83b6ad07093663edce1d3a0 (commit) via 43a1c96075acfc13524bf049a7f4f67a5ba5e522 (commit) via d2bd8f5095f0f6111c8dbd9699b38905b9b66271 (commit) via 30e4b60a13be133459d96ae9b293300ea47570c3 (commit) via 7535f0cd16d7390c7efedbc50794dcbeec0d54d6 (commit) from b3fda807bd69c44db604d549c52ecf1e5b3a0ab8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=40c52cf1d361156ab756144ed938f92cba61c8d4 commit 40c52cf1d361156ab756144ed938f92cba61c8d4 Author: Neels Hofmeyr Date: Sat Dec 2 23:12:14 2017 +0100 jobs: master-builds: libosmo-sigtran should trigger bsc and iuh osmo-iuh in turn triggers osmo-msc and osmo-sgsn, no explicit triggers needed here. Change-Id: Ifd950660cdc3417e82b0a8f4ce2b1efde880cb7a http://cgit.osmocom.org/osmo-ci/commit/?id=80d0d8cd9b28f12fa83b6ad07093663edce1d3a0 commit 80d0d8cd9b28f12fa83b6ad07093663edce1d3a0 Author: Neels Hofmeyr Date: Sat Dec 2 23:13:20 2017 +0100 jobs: master-branches: trigger sgsn from iuh osmo-sgsn uses libosmo-ranap and hence should be triggered from osmo-iuh. This naturally "includes" a trigger for libosmo-sigtran. Change-Id: Ia356dc2a8d5120f9d6262bf8eb25c32fe71e76c9 http://cgit.osmocom.org/osmo-ci/commit/?id=43a1c96075acfc13524bf049a7f4f67a5ba5e522 commit 43a1c96075acfc13524bf049a7f4f67a5ba5e522 Author: Neels Hofmeyr Date: Sat Dec 2 23:09:22 2017 +0100 jobs: master-builds: osmo-bsc is now also a downstream of osmo-mgw Change-Id: I03c63108bd845ee723d565c3dddd4e930bb68bef http://cgit.osmocom.org/osmo-ci/commit/?id=d2bd8f5095f0f6111c8dbd9699b38905b9b66271 commit d2bd8f5095f0f6111c8dbd9699b38905b9b66271 Author: Neels Hofmeyr Date: Sat Dec 2 23:01:32 2017 +0100 jobs: master-builds: apply various initial fixes libosmo-sccp, osmo-ggsn: The osmo-gsm-tester builds are downstream builds, yes, but we configured that with the osmo-gsm-tester builds: instead of telling libosmo-sccp to build osmo-gsm-tester_build-osmo-stp when done, we configure the osmo-gsm-tester_osmo-stp to build after libosmo-sccp. So that the master branch builds don't need to have any knowledge of osmo-gsm-tester. osmo-msc build triggers should rather be post-build triggers of osmo-iuh and osmo-mgw, like the others. Then we can also drop the pollscm here, and use the pollscm that is common to all other builds. Call these jobs 'master-*'. It more accurately says what they build, and also we can install the jobs from this file next to the current, old ones, without overwriting them and thus we'll have an easy rollback path. The new ones can co-exist with the old ones until the new ones are verified to work, at which point we can drop the old ones. Line 313: IIUC the safest git branch is 'refs/remotes/origin/master'. This is still untested! Change-Id: If2ad9c90a0986d1304cd53383d3df5b375f23ac8 http://cgit.osmocom.org/osmo-ci/commit/?id=30e4b60a13be133459d96ae9b293300ea47570c3 commit 30e4b60a13be133459d96ae9b293300ea47570c3 Author: Neels Hofmeyr Date: Sat Dec 2 23:00:30 2017 +0100 jobs: rename normal-builds.yml to master-builds.yml Also apply the rename in the job names Change-Id: If623e573e49d4f1a409139c112afbc34e4cc450e http://cgit.osmocom.org/osmo-ci/commit/?id=7535f0cd16d7390c7efedbc50794dcbeec0d54d6 commit 7535f0cd16d7390c7efedbc50794dcbeec0d54d6 Author: Harald Welte Date: Tue Nov 14 14:41:10 2017 +0900 Describe our normal (non-gerrit) build jobs in jenkins-job-builder after the recent successful conversion from manual job definitions to jenkins-job-buildre of the gerrit jobs, this is an attempt to convert also the non-gerrit jobs for the common osmocom projects. WARNING: this file has not been tested yet, it's a WIP. Change-Id: Ib04707393264a845876659d7bee0cdc9f8b897b6 ----------------------------------------------------------------------- Summary of changes: ...{gerrit-verifications.yml => master-builds.yml} | 144 +++++++++++++++------ 1 file changed, 104 insertions(+), 40 deletions(-) copy jobs/{gerrit-verifications.yml => master-builds.yml} (74%) hooks/post-receive -- CI scripts From gitosis at osmocom.org Sun Dec 3 13:09:34 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 13:09:34 GMT Subject: osmo-bts.git branch master updated. 0.7.0-18-ga7bfb6c Message-ID: <201712031309.vB3D9YrJ040154@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via a7bfb6c8dabcba6fb3534c4733d88fb9e466ae15 (commit) from 57ce53d8aac6dbd4ac10585b7b812c6021a19095 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=a7bfb6c8dabcba6fb3534c4733d88fb9e466ae15 commit a7bfb6c8dabcba6fb3534c4733d88fb9e466ae15 Author: Harald Welte Date: Sun Dec 3 10:54:02 2017 +0100 osmo-bts-octphy: Remove bogus warning about BS_AG_BLKS_RES Contrary to osmo-bts-sysmo, the OCTPHY-2G does not have different L1 SAPI for AGCH and PCH. It uses cOCTVC1_GSM_SAPI_ENUM_PCH_AGCH for both, and we convert that to the cbits=0x12 (Downlink CCCH) on the L1SAP. The code above L1SAP can hence freely decide if it wants to respond with an AGCH or PCH message, based on its knowledge of BS_AG_BLKS_RES, without the OCTPHY specific code having to do anything about it. Hence, there's nothing to do, and the warning can be removed Change-Id: Ic1038b8dc57bdaf05493cd8479355b960275ea41 Related: OS#1575 ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-octphy/l1_if.c | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Dec 3 17:35:54 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 17:35:54 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1873-gd2cdf93b Message-ID: <201712031735.vB3HZsQ8046291@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via d2cdf93b53ce3eb4714c3c97a5467e3dc455112b (commit) via 229ea1ca5bce63cb52194dec1a932ba351f7aa64 (commit) from 271cdad401de897fed49c19897bf89359044457e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=d2cdf93b53ce3eb4714c3c97a5467e3dc455112b commit d2cdf93b53ce3eb4714c3c97a5467e3dc455112b Author: Holger Hans Peter Freyther Date: Thu Nov 16 17:11:28 2017 +0100 mobile: Declare struct osmocom/vty to be self includeable In file included from settings.c:27:0: ../../include/osmocom/bb/mobile/app_mobile.h:10:42: warning: ???struct osmocom_ms??? declared inside parameter list will not be visible outside of this definition or declaration int l23_app_init(int (*mncc_recv)(struct osmocom_ms *ms, int, void *), ^~~~~~~~~~ ../../include/osmocom/bb/mobile/app_mobile.h:14:26: warning: ???struct osmocom_ms??? declared inside parameter list will not be visible outside of this definition or declaration int mobile_delete(struct osmocom_ms *ms, int force); Change-Id: I9348b3ed71a8490c03edda954402ab954f645b7c http://cgit.osmocom.org/osmocom-bb/commit/?id=229ea1ca5bce63cb52194dec1a932ba351f7aa64 commit 229ea1ca5bce63cb52194dec1a932ba351f7aa64 Author: Holger Hans Peter Freyther Date: Sun Dec 3 12:57:07 2017 +0000 mobile: Fix compiler warning on printing ptrdiff_t The "msg->tail - msg->l4h" subtract two unsigned char* pointers and should result in a ptrdiff_t. Fix the compiler warning by using "%ti" in the printf. Fixes: gsm411_sms.c: In function ???gsm411_rx_rp_ud???: gsm411_sms.c:382:25: warning: format ???%li??? expects argument of type ???long int???, but argument 7 has type ???int??? [-Wformat=] LOGP(DLSMS, LOGL_INFO, "TPDU(%li,%s)\n", msg->tail-msg->l4h, ^ /home/ich/install/openbsc/include/osmocom/core/logging.h:93:54: note: in definition of macro ???LOGPSRCC??? logp2(ss, level, caller_file, caller_line, cont, fmt, ##args); \ ^~~ /home/ich/install/openbsc/include/osmocom/core/logging.h:47:2: note: in expansion of macro ???LOGPSRC??? LOGPSRC(ss, level, NULL, 0, fmt, ## args) ^~~~~~~ gsm411_sms.c:382:2: note: in expansion of macro ???LOGP??? LOGP(DLSMS, LOGL_INFO, "TPDU(%li,%s)\n", msg->tail-msg->l4h, ^~~~ gsm411_sms.c:382:25: warning: format ???%li??? expects argument of type ???long int???, but argument 7 has type ???int??? [-Wformat=] LOGP(DLSMS, LOGL_INFO, "TPDU(%li,%s)\n", msg->tail-msg->l4h, ^ /home/ich/install/openbsc/include/osmocom/core/logging.h:95:53: note: in definition of macro ???LOGPSRCC??? logp2(ss, level, __BASE_FILE__, __LINE__, cont, fmt, ##args); \ ^~~ /home/ich/install/openbsc/include/osmocom/core/logging.h:47:2: note: in expansion of macro ???LOGPSRC??? LOGPSRC(ss, level, NULL, 0, fmt, ## args) ^~~~~~~ gsm411_sms.c:382:2: note: in expansion of macro ???LOGP??? LOGP(DLSMS, LOGL_INFO, "TPDU(%li,%s)\n", msg->tail-msg->l4h, Change-Id: Ia574fc7849bd00a94cf6651eb0d26fdc91ef1443 ----------------------------------------------------------------------- Summary of changes: src/host/layer23/include/osmocom/bb/mobile/app_mobile.h | 2 ++ src/host/layer23/src/mobile/gsm411_sms.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sun Dec 3 18:09:57 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 18:09:57 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1884-gedb65f91 Message-ID: <201712031809.vB3I9vND059045@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via edb65f915f24fbd6611a343c99aba83ac3867b89 (commit) via 50869b91469122a82554c34dc7a83025c7a2d1dd (commit) via 44c19326f38e9001b55723eb41f61de9e29e4175 (commit) via 4080e622b7661c0f2305c3d4d84021a456a76ceb (commit) via 32dec4236e5bf3753bd84715d5e099272ea5d481 (commit) via 63100e308c71517311559e501a7a18179c9ff2d8 (commit) via f976ad9dc41ae14919c9923fc82ba747b1dd181c (commit) via 714cb53282c89d50055a17b67047d50b03d69521 (commit) via 88060f462cde2e3e6f4fc3cbf9c3708083e27dac (commit) via a8726d977a67459e7bf314b4b69283f65e45cbf0 (commit) via 04754e88899c58051ef1a0b0602261f033609dce (commit) from d2cdf93b53ce3eb4714c3c97a5467e3dc455112b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=edb65f915f24fbd6611a343c99aba83ac3867b89 commit edb65f915f24fbd6611a343c99aba83ac3867b89 Author: Holger Hans Peter Freyther Date: Wed Nov 29 11:51:27 2017 +0800 mobile: Use new LOGPSRCC macro to print multiple values We need continuation to avoid printing the logging category again. E.g. when print(one, two, three) is called. Change-Id: Id8491fa949768f170a8c74ab554cb1166afda1b7 http://cgit.osmocom.org/osmocom-bb/commit/?id=50869b91469122a82554c34dc7a83025c7a2d1dd commit 50869b91469122a82554c34dc7a83025c7a2d1dd Author: Holger Hans Peter Freyther Date: Mon Nov 13 10:36:18 2017 +0100 mobile: Create "ms" singleton for struct osmocom_ms Make the MS the script is associated with accessible to lua. Provide access to IMSI and IMEI. The IMSI might not be available at the given time and just return an empty string. Example lua usage: print(osmo.ms():imsi()); print(osmo.ms():imei()); print(osmo.ms():shutdown_state()) print(osmo.ms():started()) function ms_started_cb(started) print("MS started", started) end function ms_shutdown_cb(old_state, new_state) print("MS shutdown", old_state, "->", new_state) end function sms_cb(sms, cause, valid) print("SMS data cb", sms, cause, valid) for i, v in pairs(sms) do print(i, v) end end function mm_cb(new_state, new_substate, old_substate) if new_state == 19 and new_substate == 1 then osmo.ms():sms_send_simple("1234", "21321324", "fooooooo", 23) end end local cbs = { Started=ms_started_cb, Shutdown=ms_shutdown_cb, Sms=sms_cb, Mm=mm_cb } timer = osmo.timeout(20, function() print("Timeout occurred after 20s") end) osmo.ms():register(cbs) # Can fail. Best to wait for state changes... print(osmo.ms().start()) print(osmo.ms().stop(true)) Change-Id: Ia3ace33d6ba4e904b1ff8e271a02d67777334a58 http://cgit.osmocom.org/osmocom-bb/commit/?id=44c19326f38e9001b55723eb41f61de9e29e4175 commit 44c19326f38e9001b55723eb41f61de9e29e4175 Author: Holger Hans Peter Freyther Date: Wed Nov 15 12:20:04 2017 +0800 mobile: Add osmo.timeout for lua code to have timeouts Allow to callback into lua code after a user configured timeout. Make it only work on seconds (truncate double to int). Change-Id: I355d2f8d15aeaa13abb1c5e4a8e0c958e5faf7f3 http://cgit.osmocom.org/osmocom-bb/commit/?id=4080e622b7661c0f2305c3d4d84021a456a76ceb commit 4080e622b7661c0f2305c3d4d84021a456a76ceb Author: Holger Hans Peter Freyther Date: Wed Nov 8 14:59:06 2017 +0100 mobile: Add initial support for scripting support Right now the script will be executed once it is loaded. Make sure to write it into the config file last. Expose various log commands for logging. Jump through some hoops and get the filename and line number from lua. Change-Id: I456f6b6b5e1a14ed6c8cb0dcc5140093d3c61ef6 http://cgit.osmocom.org/osmocom-bb/commit/?id=32dec4236e5bf3753bd84715d5e099272ea5d481 commit 32dec4236e5bf3753bd84715d5e099272ea5d481 Author: Holger Hans Peter Freyther Date: Wed Nov 8 14:40:36 2017 +0100 mobile: Add LUA as debug category to the applications Change-Id: Id2d266c48d30c06dfdc3b8c84d875038b43f2ad8 http://cgit.osmocom.org/osmocom-bb/commit/?id=63100e308c71517311559e501a7a18179c9ff2d8 commit 63100e308c71517311559e501a7a18179c9ff2d8 Author: Holger Hans Peter Freyther Date: Wed Nov 8 08:32:18 2017 +0100 mobile: Search for lua5.3 and link to it I will be adding a high-level async scripting interface to the mobile application. The initial implementation will use Lua 5.3. This version was released in January 2015 and is the latest version at the time the commit was made. Lua as extension and extensible language seems well suited for scripting. The plan is to attach a script to a ms and be able to trigger high level operations (send SMS, attach to network, detach). Change-Id: Ic649e49a22c878585a6c20b5b80108909f2374eb http://cgit.osmocom.org/osmocom-bb/commit/?id=f976ad9dc41ae14919c9923fc82ba747b1dd181c commit f976ad9dc41ae14919c9923fc82ba747b1dd181c Author: Holger Hans Peter Freyther Date: Wed Nov 29 17:43:22 2017 +0800 mobile: Notify MM status changes and generate primitive op ind Notify once the mm state has been changed. Unfortunaley one state transition can immediately trigger more transitions (recursively). In the mid-term it might be best to force all primitives to be async to avoid unpredictable behavior (e.g. make a shutdown while being a recursion down?) Change-Id: I8e9dcf7fd9116985aa060ba027ba74107a19223a http://cgit.osmocom.org/osmocom-bb/commit/?id=714cb53282c89d50055a17b67047d50b03d69521 commit 714cb53282c89d50055a17b67047d50b03d69521 Author: Holger Hans Peter Freyther Date: Fri Nov 17 15:45:12 2017 +0100 mobile: Inform the primitive layer about status and new sms Inform the layer about new SMS and inform about the cause of it. In both cases pass the SMS. Change-Id: Ib7ab34b1b85b62ef0e8fff347adccbc5dc414161 http://cgit.osmocom.org/osmocom-bb/commit/?id=88060f462cde2e3e6f4fc3cbf9c3708083e27dac commit 88060f462cde2e3e6f4fc3cbf9c3708083e27dac Author: Holger Hans Peter Freyther Date: Thu Nov 16 08:17:34 2017 +0100 mobile: Directly inform the primitive layer about an event Forward started/shutdown changes to the primitive layer which will turn them into indications. The other option might be to use the signals but it seems primitives are a superset of the signals. The notify will be done per MS and then the right primitive instance will be searched and the indication be sent. The approach will be applied to other systems as well. The signal framework might be seen as a subset of the primitives A signal mostly being a different form of an indication. Change-Id: I5df20a4ab79c06b515780675b6df2929aa976f0d http://cgit.osmocom.org/osmocom-bb/commit/?id=a8726d977a67459e7bf314b4b69283f65e45cbf0 commit a8726d977a67459e7bf314b4b69283f65e45cbf0 Author: Holger Hans Peter Freyther Date: Thu Nov 9 09:15:37 2017 +0100 mobile: Begin with a primitive interface on top of the code We want the script interface to interface through a primitive interface. This will allow to move it to a different thread or a process in the future. The script interface will just use the primitives. It is not clear how "sap" will be used here. I am keeping it at 0 right now. The first primitive is starting a timer with a request and then getting an indication as a response. Change-Id: Id2456b7fae35546553c4805f12a40c0812d9255c http://cgit.osmocom.org/osmocom-bb/commit/?id=04754e88899c58051ef1a0b0602261f033609dce commit 04754e88899c58051ef1a0b0602261f033609dce Author: Holger Hans Peter Freyther Date: Wed Nov 29 14:35:40 2017 +0800 mobile: Move starting/stopping a MS into a separate function Move the check if within the mobile app there is no other active MS using the same L1 socket. This way we can call this function from the primitive code as well. Change-Id: Ib4aa5ff212fa6bead8f620abaecc6a0b51a99fec ----------------------------------------------------------------------- Summary of changes: src/host/layer23/configure.ac | 7 + .../layer23/include/osmocom/bb/common/logging.h | 2 + .../include/osmocom/bb/common/osmocom_data.h | 4 + .../layer23/include/osmocom/bb/mobile/Makefile.am | 2 +- .../layer23/include/osmocom/bb/mobile/app_mobile.h | 11 +- .../layer23/include/osmocom/bb/mobile/gsm411_sms.h | 6 + .../layer23/include/osmocom/bb/mobile/primitives.h | 100 ++++ src/host/layer23/src/common/logging.c | 12 + src/host/layer23/src/mobile/Makefile.am | 14 +- src/host/layer23/src/mobile/app_mobile.c | 53 +- src/host/layer23/src/mobile/gsm411_sms.c | 4 + src/host/layer23/src/mobile/gsm48_mm.c | 2 + src/host/layer23/src/mobile/main.c | 2 +- src/host/layer23/src/mobile/primitives.c | 194 ++++++++ src/host/layer23/src/mobile/script_lua.c | 542 +++++++++++++++++++++ .../layer23/src/mobile/script_nolua.c} | 24 +- src/host/layer23/src/mobile/settings.c | 3 + src/host/layer23/src/mobile/vty_interface.c | 79 +-- 18 files changed, 1009 insertions(+), 52 deletions(-) create mode 100644 src/host/layer23/include/osmocom/bb/mobile/primitives.h create mode 100644 src/host/layer23/src/mobile/primitives.c create mode 100644 src/host/layer23/src/mobile/script_lua.c copy src/{target/firmware/include/calypso/du.h => host/layer23/src/mobile/script_nolua.c} (66%) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sun Dec 3 21:13:39 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 21:13:39 GMT Subject: osmo-bts.git branch master updated. 0.7.0-19-g5112c45 Message-ID: <201712032113.vB3LDd8g033037@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 5112c45d224f99d0bc65e52f6cb5269feb7315dc (commit) from a7bfb6c8dabcba6fb3534c4733d88fb9e466ae15 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=5112c45d224f99d0bc65e52f6cb5269feb7315dc commit 5112c45d224f99d0bc65e52f6cb5269feb7315dc Author: Harald Welte Date: Sun Dec 3 10:06:22 2017 +0100 rsl.c: Log RTP socket related errors as DRTP, not DRSL The respective errors/events occur as a result of calling osmo_rtp_* API, and are clearly more fitting into the DRTP category than the DRSL, even though the respective actions are triggered by RSL. Change-Id: I52e6f9865492a2f757a37860eb92a3dc49e174ef ----------------------------------------------------------------------- Summary of changes: src/common/rsl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Dec 3 21:21:04 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 21:21:04 GMT Subject: gapk.git branch laforge/benchmark created. 12caf496aa2649559c364753c15a027251c95e0d Message-ID: <201712032121.vB3LL4Hb037027@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, laforge/benchmark has been created at 12caf496aa2649559c364753c15a027251c95e0d (commit) - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Sun Dec 3 21:21:19 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 21:21:19 GMT Subject: gapk.git branch laforge/rtp created. v0.3-26-g67e9266 Message-ID: <201712032121.vB3LLJfw037150@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, laforge/rtp has been created at 67e92663f9160c04702d149871a7d5b52bbe6ac5 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gapk/commit/?id=67e92663f9160c04702d149871a7d5b52bbe6ac5 commit 67e92663f9160c04702d149871a7d5b52bbe6ac5 Author: Harald Welte Date: Sun May 28 13:46:21 2017 +0200 EFR ("fmt_amr") fixup ----------------------------------------------------------------------- hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Sun Dec 3 21:22:34 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 21:22:34 GMT Subject: libosmo-abis.git branch master updated. 0.4.0-10-gd1dd22c Message-ID: <201712032122.vB3LMYTC037807@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via d1dd22c38e86f123c8f9a93c2789deafdfcb9265 (commit) from 2d4888dd08f5f340019ace5050a64a85dec57400 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=d1dd22c38e86f123c8f9a93c2789deafdfcb9265 commit d1dd22c38e86f123c8f9a93c2789deafdfcb9265 Author: Harald Welte Date: Sun Dec 3 10:00:16 2017 +0100 Add a new osmo_rtp_set_source_desc() function to set the RTCP SDES items This allows the users of libosmotrau to set the content of the SDES items to something more useful than their compile-time defaults. Change-Id: Ice794f9e0c6caeea1c67520c12efbfa375d1fb82 Related: OS#2701 ----------------------------------------------------------------------- Summary of changes: TODO-RELEASE | 1 + include/osmocom/trau/osmo_ortp.h | 3 +++ src/trau/osmo_ortp.c | 7 +++++++ 3 files changed, 11 insertions(+) hooks/post-receive -- Osmocom A-bis protcol interface library From gitosis at osmocom.org Sun Dec 3 22:12:37 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 3 Dec 2017 22:12:37 GMT Subject: osmo-bts.git branch master updated. 0.7.0-20-gbe4a208 Message-ID: <201712032212.vB3MCbcH058892@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via be4a2088098a7b4fbfc1a5046e4c2ceb21ce1b1d (commit) from 5112c45d224f99d0bc65e52f6cb5269feb7315dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=be4a2088098a7b4fbfc1a5046e4c2ceb21ce1b1d commit be4a2088098a7b4fbfc1a5046e4c2ceb21ce1b1d Author: Harald Welte Date: Sun Dec 3 10:29:13 2017 +0100 Put useful information in RTCP SDES. The RTCP Sender Description is supposed to contain useful information to identify the source of the RTP stream. So far, it only contained compile-time default data of libortp. Let's put the BTS UnitID, the lchan number and the OsmoBTS version in there. This change requires libosmo-abis Change-Id Ice794f9e0c6caeea1c67520c12efbfa375d1fb82 Change-Id: Id6ce7188354d3a0517661c9648854ec829ef1cac Related: OS#2701 ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/gsm_data_shared.h | 1 + src/common/gsm_data_shared.c | 9 +++++++++ src/common/rsl.c | 9 +++++++++ 3 files changed, 19 insertions(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Mon Dec 4 09:09:55 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 09:09:55 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1886-g238df986 Message-ID: <201712040909.vB499tVI036438@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via 238df986b9c705392898f74271c3258c16ffe927 (commit) via a0fc36f859fcfd089c0490648a92d66c0928ecca (commit) from edb65f915f24fbd6611a343c99aba83ac3867b89 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=238df986b9c705392898f74271c3258c16ffe927 commit 238df986b9c705392898f74271c3258c16ffe927 Author: Holger Hans Peter Freyther Date: Sun Dec 3 22:01:50 2017 +0000 mobile: Return the name of the configured "MS" In lua osmo.ms():name() will print the name/number of the MS. This can be used by scripting code to use in events and then be analyzed. Change-Id: I881d3e87daa19f4e6f4f5bd30fe95906129e60ef http://cgit.osmocom.org/osmocom-bb/commit/?id=a0fc36f859fcfd089c0490648a92d66c0928ecca commit a0fc36f859fcfd089c0490648a92d66c0928ecca Author: Holger Hans Peter Freyther Date: Sun Dec 3 18:36:19 2017 +0000 mobile: Simplify code and check the cb ref in load_cb Change parameters and check if the cb_ref is valid or not. Change-Id: I74fbcd7e853e24b1225ecc4c19304134b8467c9b ----------------------------------------------------------------------- Summary of changes: src/host/layer23/src/mobile/script_lua.c | 42 ++++++++++++++++---------------- 1 file changed, 21 insertions(+), 21 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Mon Dec 4 09:40:52 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 09:40:52 GMT Subject: libosmocore.git branch master updated. 0.10.2-41-gad1797e3 Message-ID: <201712040940.vB49eqvE049252@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via ad1797e359f95b3a9ff57bfc92217d4f4f96fc95 (commit) via 38b17235339c8d0223f00d3b3a54626c32184f9d (commit) from 37a83405a5ebbaebc02b7ce8fb9c8bf597cd678c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=ad1797e359f95b3a9ff57bfc92217d4f4f96fc95 commit ad1797e359f95b3a9ff57bfc92217d4f4f96fc95 Author: Max Date: Fri Dec 1 19:39:23 2017 +0100 embedded: fix tests In case of embedded build some tests are failing to link properly. Fix it: * do not run fsm_test unless CTRL is enabled * do not run fr_test unless GB is enabled * do not link loggingrb_test with libosmovty Change-Id: Icedad5ba3ed311ccdb97fa3ccd3002f5fda8be68 http://cgit.osmocom.org/libosmocore/commit/?id=38b17235339c8d0223f00d3b3a54626c32184f9d commit 38b17235339c8d0223f00d3b3a54626c32184f9d Author: Max Date: Fri Dec 1 19:06:21 2017 +0100 Fix embedded build Do not attempt to load auth plugins - this does not make sense on embedded target anyway. Change-Id: Ie92d2eea21e19e499b3f3bb4d5a82e31fbbea3f0 ----------------------------------------------------------------------- Summary of changes: src/gsm/auth_core.c | 6 ++++++ src/gsm/gprs_cipher_core.c | 4 ++++ tests/Makefile.am | 10 +++++----- 3 files changed, 15 insertions(+), 5 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Mon Dec 4 09:41:35 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 09:41:35 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-8-g701afa4 Message-ID: <201712040941.vB49fZmx049555@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 701afa4b3a5ae3e93b92bd9a4fa013fadbe69774 (commit) from a5eb67d91c88514036b6926b845229eb279827b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=701afa4b3a5ae3e93b92bd9a4fa013fadbe69774 commit 701afa4b3a5ae3e93b92bd9a4fa013fadbe69774 Author: Max Date: Fri Dec 1 17:13:22 2017 +0100 Fix compiler warning Move function declarations which use gprs_rlcmac_ul_tbf into tbf.h to avoid compiler warning: In file included from pcu_vty.c:15:0: bts.h:166:27: warning: ???struct gprs_rlcmac_ul_tbf??? declared inside parameter list will not be visible outside of this definition or declaration void update_tbf_ta(struct gprs_rlcmac_ul_tbf *tbf, int8_t ta_delta); ^~~~~~~~~~~~~~~~~~ bts.h:167:24: warning: ???struct gprs_rlcmac_ul_tbf??? declared inside parameter list will not be visible outside of this definition or declaration void set_tbf_ta(struct gprs_rlcmac_ul_tbf *tbf, uint8_t ta); ^~~~~~~~~~~~~~~~~~ Change-Id: Ic34c72c8bff6d7c775f56bb6026fec5425f7dcb4 ----------------------------------------------------------------------- Summary of changes: src/bts.h | 2 -- src/tbf.h | 9 +++++++++ 2 files changed, 9 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 4 09:49:22 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 09:49:22 GMT Subject: osmo-bts.git branch laforge/fsm-name created. 0.7.0-21-g7536823 Message-ID: <201712040949.vB49nMgq053337@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, laforge/fsm-name has been created at 7536823ea41a2cb7fc26b8c9a524b2b48a39dfee (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=7536823ea41a2cb7fc26b8c9a524b2b48a39dfee commit 7536823ea41a2cb7fc26b8c9a524b2b48a39dfee Author: Harald Welte Date: Tue Oct 31 15:29:35 2017 -0400 DTX: avoid illegal character contained in DTX FSM allocation which causes BTS crash Problem: lchan->tch.dtx.dl_amr_fsm struct failed to allocate in l1sap_chan_act routine in l1sap.c due to illegal characters contained in lchan->name which are passed to osmo_fsm_inst_alloc routine. As a result, lchan->tch.dtx.dl_amr_fsm is NULL causing BTS crashed (SEG FAULT) when trying to access this struct. Below is snapshot of crash log obtained by GDB: ... Fri Nov 24 18:13:55 2017 <0000> rsl.c:1653 payload type: 98 Fri Nov 24 18:13:55 2017 <0000> rsl.c:1463 (bts=0,trx=0,ts=2,ss=0) RSL Tx IPAC_MDCX_ACK (local 127.0.0.1:11538, remote 127.0.0.1:30012) Program received signal SIGSEGV, Segmentation fault. 0x00031930 in dtx_dl_amr_fsm_step (lchan=lchan at entry=0xb69592a8, rtp_pl=rtp_pl at entry=0x87ae8 " \024\351Y\363_\337\345\351f\177\373\300\210\201\200\210", rtp_pl_len=17, fn=1728481, l1_payload=0x10dd25 "", marker=marker at entry=true, len=len at entry=0x10ddc4 "\024", ft_out=0xbefff7d7 "\002", ft_out at entry=0xbefff7cf "\276\341_\032") at msg_utils.c:233 233 msg_utils.c: No such file or directory. ... Fix: * Use different formatting for lchan name passed to osmo_fsm_inst_alloc routine * Refuse channel activation if FSM could not be generated (as opposed to crash) Related: OS#2606 Reported-by: Minh-Quang Nguyen Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Mon Dec 4 09:56:43 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 09:56:43 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-9-g59f50c2 Message-ID: <201712040956.vB49uhhg057226@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 59f50c2718ba30479449ed31ed2202f7a797ca1d (commit) from 701afa4b3a5ae3e93b92bd9a4fa013fadbe69774 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=59f50c2718ba30479449ed31ed2202f7a797ca1d commit 59f50c2718ba30479449ed31ed2202f7a797ca1d Author: Max Date: Thu Nov 30 12:36:11 2017 +0100 TBF: log timer override Currently TBF support only single Txxxx timer so scheduling another timer will cancel out the one which is already running. Until the proper fix is in place, let's at least log this situation as error. Note: cosmetic adjustement to test output is required - we do not report restart of the same timer twice because "restarting" assumes it anyway. Change-Id: I462464a1e6df937b72cad65d19cd48e95dc4db45 Related: OS#2407 ----------------------------------------------------------------------- Summary of changes: src/tbf.cpp | 14 +- tests/tbf/TbfTest.err | 422 +++++++++++++++++++++++++------------------------- 2 files changed, 218 insertions(+), 218 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 4 13:18:27 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 13:18:27 GMT Subject: osmo-trx.git branch master updated. 0.2.0-3-gaa60dda Message-ID: <201712041318.vB4DIRBt040923@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via aa60dda99a22f6a60d5c6f9b08d50febe49757ef (commit) from 1468a5c3dc4c193422d0ccbe5e09e423395bbec5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=aa60dda99a22f6a60d5c6f9b08d50febe49757ef commit aa60dda99a22f6a60d5c6f9b08d50febe49757ef Author: Piotr Krysik Date: Mon Dec 4 00:29:16 2017 +0700 UHDDevice.cpp: add USRP B205mini support The B205mini is similar to the B200mini and runs OsmoTRX just fine, so let's make OsmoTRX recogonize and support it too. Change-Id: Iee575121248ea541f7abc49055e49ec2d30904c0 ----------------------------------------------------------------------- Summary of changes: Transceiver52M/UHDDevice.cpp | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- OpenBTS' transceiver retro-fit From gitosis at osmocom.org Mon Dec 4 13:25:50 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 13:25:50 GMT Subject: osmo-bts.git branch master updated. 0.7.0-21-g70c4dc8 Message-ID: <201712041325.vB4DPoBF044257@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 70c4dc8d706973c65e6bf088156f5862f4e036b4 (commit) from be4a2088098a7b4fbfc1a5046e4c2ceb21ce1b1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=70c4dc8d706973c65e6bf088156f5862f4e036b4 commit 70c4dc8d706973c65e6bf088156f5862f4e036b4 Author: Harald Welte Date: Sat Dec 2 21:34:33 2017 +0100 osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS The upper layers (L1SAP, the common part of L1) *always* require frame numbers in the uplink direction to be reported as the frame number of the *first* burst, not the last burst of a given block. This is particularly important in the case of passing up measurement information, as we use this frame number to detect if the measurement interval for that specific timeslot has just ended (and hence we must process the measurements and send an uplink measurement report to the BSC. Before this patch, the measurement results were reported with the *last* frame number, which caused the common/measurement.c code never detect the end of a measurement window. On TS2, tons of the following log messages were observed: <0004> measurement.c:199 (bts=0,trx=0,ts=2,ss=0) no space for uplink measurement, num_ul_meas=104 With this patch, it behves as expected: the measurements of 25 blocks (= 100 bursts) are aggregated, after which point the report is computed and sent. Subsequently, num_ul_meas is reset to 0 and the cycle restarts. Related: OS#2329 Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-trx/scheduler_trx.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Mon Dec 4 15:02:30 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 15:02:30 GMT Subject: meta-telephony.git branch pespin/201705 created. 92af4ee4cf90277a6920aad981aaee40e049a251 Message-ID: <201712041502.vB4F2UrZ088587@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, pespin/201705 has been created at 92af4ee4cf90277a6920aad981aaee40e049a251 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=92af4ee4cf90277a6920aad981aaee40e049a251 commit 92af4ee4cf90277a6920aad981aaee40e049a251 Author: Pau Espin Pedrol Date: Mon Dec 4 16:01:38 2017 +0100 libosmo-abis: Split libosmo-trau into its own package Change-Id: Ica8b6c39aed9f3370aeab84e821c8de871d2f0be http://cgit.osmocom.org/meta-telephony/commit/?id=9a3c3d32f55f4522772904f1eea0a01e822fcd48 commit 9a3c3d32f55f4522772904f1eea0a01e822fcd48 Author: Pau Espin Pedrol Date: Mon Dec 4 15:36:46 2017 +0100 libosmo-abis: Remove unused patch The patch was applied upstream in 37fcd93a508b52f6f33bf47191bba41cb7367b0d, and removed from libosmo-abis recipe in meta-telephony d91abc18f1a1d0003fe946c5dce173f1946b9712. Change-Id: I7cf50808f0b826e82614ecd5844ab082ac017873 ----------------------------------------------------------------------- hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Mon Dec 4 16:51:54 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 16:51:54 GMT Subject: meta-telephony.git branch laforge/nightly updated. 7ac5c4b0a469b0d73889294355a4b0168ef653fc Message-ID: <201712041651.vB4GpsB3035294@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, laforge/nightly has been updated via 7ac5c4b0a469b0d73889294355a4b0168ef653fc (commit) from 4aa6d87359a2d0edaaa103115874e7a3fce21ee8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=7ac5c4b0a469b0d73889294355a4b0168ef653fc commit 7ac5c4b0a469b0d73889294355a4b0168ef653fc Author: Pau Espin Pedrol Date: Mon Dec 4 17:50:11 2017 +0100 osmo-sgsn: libosmo-sccp dep is only needed if building with iu support Change-Id: I97e4e37219f584f0b9d42e21ff9464e2d7143e13 ----------------------------------------------------------------------- Summary of changes: recipes-osmocom/osmo-sgsn/osmo-sgsn.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Mon Dec 4 16:52:24 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 4 Dec 2017 16:52:24 GMT Subject: meta-telephony.git branch pespin/201705 deleted. 92af4ee4cf90277a6920aad981aaee40e049a251 Message-ID: <201712041652.vB4GqOOf035596@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, pespin/201705 has been deleted was 92af4ee4cf90277a6920aad981aaee40e049a251 ----------------------------------------------------------------------- 92af4ee4cf90277a6920aad981aaee40e049a251 libosmo-abis: Split libosmo-trau into its own package ----------------------------------------------------------------------- hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 5 10:20:08 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 10:20:08 GMT Subject: meta-telephony.git branch 201705 updated. 9a3c3d32f55f4522772904f1eea0a01e822fcd48 Message-ID: <201712051020.vB5AK8pI069320@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, 201705 has been updated via 9a3c3d32f55f4522772904f1eea0a01e822fcd48 (commit) from 42740773ddc30928564d3ea5049636f6eb0a4d4b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=9a3c3d32f55f4522772904f1eea0a01e822fcd48 commit 9a3c3d32f55f4522772904f1eea0a01e822fcd48 Author: Pau Espin Pedrol Date: Mon Dec 4 15:36:46 2017 +0100 libosmo-abis: Remove unused patch The patch was applied upstream in 37fcd93a508b52f6f33bf47191bba41cb7367b0d, and removed from libosmo-abis recipe in meta-telephony d91abc18f1a1d0003fe946c5dce173f1946b9712. Change-Id: I7cf50808f0b826e82614ecd5844ab082ac017873 ----------------------------------------------------------------------- Summary of changes: .../libosmo-abis/files/fix-rsl-connect.patch | 21 --------------------- 1 file changed, 21 deletions(-) delete mode 100644 recipes-osmocom/libosmo-abis/files/fix-rsl-connect.patch hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 5 14:11:26 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 14:11:26 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-35-g9c0f4f4 Message-ID: <201712051411.vB5EBQpF064227@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 9c0f4f49e9b15b55cd9baa42c1ba191903664397 (commit) via ac51c7e68e64740568c6843499cb3a352e3e549e (commit) via 55d639f0fbc00bec2ef01940d30e569ebb66515f (commit) from b9ace14717a220edb380d21d849e95ae0c30784e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=9c0f4f49e9b15b55cd9baa42c1ba191903664397 commit 9c0f4f49e9b15b55cd9baa42c1ba191903664397 Author: Pau Espin Pedrol Date: Mon Dec 4 12:52:23 2017 +0100 tests: Split ipv6 specific tests into a new test group This way they can be easily disabled later on when IPv6 support is made optional. Change-Id: I3906dbf55ccf1650083398e08ac870add0bbdcef http://cgit.osmocom.org/osmo-ggsn/commit/?id=ac51c7e68e64740568c6843499cb3a352e3e549e commit ac51c7e68e64740568c6843499cb3a352e3e549e Author: Pau Espin Pedrol Date: Mon Dec 4 10:59:52 2017 +0100 Remove unused empty src/Makefile.in Change-Id: I207362e055dbfafc42fad2cfdd0cf1da9dcad88b http://cgit.osmocom.org/osmo-ggsn/commit/?id=55d639f0fbc00bec2ef01940d30e569ebb66515f commit 55d639f0fbc00bec2ef01940d30e569ebb66515f Author: Pau Espin Pedrol Date: Mon Dec 4 13:17:07 2017 +0100 ggsn.c: Print version of unhandled ip packet Change-Id: I7e226a12b074c96c572f90e3aaf62716d0cd47c5 ----------------------------------------------------------------------- Summary of changes: ggsn/ggsn.c | 2 +- src/Makefile.in | 0 tests/lib/Makefile.am | 8 +- tests/lib/in46a_test.c | 214 ++++++++++++++++++++++------------- tests/lib/in46a_test.ok | 16 ++- tests/lib/in46a_v6_test.ok | 8 ++ tests/lib/ippool_test.c | 15 ++- tests/lib/ippool_test.err | 2 - tests/lib/ippool_test.ok | 257 ------------------------------------------- tests/lib/ippool_v6_test.err | 2 + tests/lib/ippool_v6_test.ok | 257 +++++++++++++++++++++++++++++++++++++++++++ tests/testsuite.at | 13 +++ 12 files changed, 441 insertions(+), 353 deletions(-) delete mode 100644 src/Makefile.in create mode 100644 tests/lib/in46a_v6_test.ok create mode 100644 tests/lib/ippool_v6_test.err create mode 100644 tests/lib/ippool_v6_test.ok hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Tue Dec 5 14:55:15 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 14:55:15 GMT Subject: osmo-bts.git branch master updated. 0.7.0-22-g5b70bb6 Message-ID: <201712051455.vB5EtFsG081884@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 5b70bb673d5857cc2208712d3bbab29fd650cb09 (commit) from 70c4dc8d706973c65e6bf088156f5862f4e036b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=5b70bb673d5857cc2208712d3bbab29fd650cb09 commit 5b70bb673d5857cc2208712d3bbab29fd650cb09 Author: Harald Welte Date: Tue Oct 31 15:29:35 2017 -0400 DTX: avoid illegal character contained in DTX FSM allocation which causes BTS crash Problem: lchan->tch.dtx.dl_amr_fsm struct failed to allocate in l1sap_chan_act routine in l1sap.c due to illegal characters contained in lchan->name which are passed to osmo_fsm_inst_alloc routine. As a result, lchan->tch.dtx.dl_amr_fsm is NULL causing BTS crashed (SEG FAULT) when trying to access this struct. Below is snapshot of crash log obtained by GDB: ... Fri Nov 24 18:13:55 2017 <0000> rsl.c:1653 payload type: 98 Fri Nov 24 18:13:55 2017 <0000> rsl.c:1463 (bts=0,trx=0,ts=2,ss=0) RSL Tx IPAC_MDCX_ACK (local 127.0.0.1:11538, remote 127.0.0.1:30012) Program received signal SIGSEGV, Segmentation fault. 0x00031930 in dtx_dl_amr_fsm_step (lchan=lchan at entry=0xb69592a8, rtp_pl=rtp_pl at entry=0x87ae8 " \024\351Y\363_\337\345\351f\177\373\300\210\201\200\210", rtp_pl_len=17, fn=1728481, l1_payload=0x10dd25 "", marker=marker at entry=true, len=len at entry=0x10ddc4 "\024", ft_out=0xbefff7d7 "\002", ft_out at entry=0xbefff7cf "\276\341_\032") at msg_utils.c:233 233 msg_utils.c: No such file or directory. ... Fix: * Use different formatting for lchan name passed to osmo_fsm_inst_alloc routine * Refuse channel activation if FSM could not be generated (as opposed to crash) Related: OS#2606 Reported-by: Minh-Quang Nguyen Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c ----------------------------------------------------------------------- Summary of changes: src/common/l1sap.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Tue Dec 5 16:05:46 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 16:05:46 GMT Subject: libosmocore.git branch master updated. 0.10.2-43-g06dbdf59 Message-ID: <201712051605.vB5G5kTJ011256@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 06dbdf59ebc87f32048748b822d8caa27dbee4a2 (commit) via 18ba26cfab4a07b8f45aeb7f28b4f8faabc6a2e7 (commit) from ad1797e359f95b3a9ff57bfc92217d4f4f96fc95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=06dbdf59ebc87f32048748b822d8caa27dbee4a2 commit 06dbdf59ebc87f32048748b822d8caa27dbee4a2 Author: Alexander Couzens Date: Tue Dec 5 16:12:14 2017 +0100 vty: show asciidoc counters: don't create an empty table for osmo_counters When creating asciidocs for osmo_counter an empty is not useful. If there aren't any counter, output a hidden comment Change-Id: Ie2768100e69dcd7d8d77533688585dd9b43c4a5e http://cgit.osmocom.org/libosmocore/commit/?id=18ba26cfab4a07b8f45aeb7f28b4f8faabc6a2e7 commit 18ba26cfab4a07b8f45aeb7f28b4f8faabc6a2e7 Author: Alexander Couzens Date: Tue Dec 5 16:06:27 2017 +0100 counters: add osmo_counters_count() returns the amount of counters Change-Id: I9068231d71876e06d27ee67a688d7fb611ac3a1b ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/counter.h | 2 ++ src/counter.c | 7 +++++++ src/vty/stats_vty.c | 7 +++++++ 3 files changed, 16 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Tue Dec 5 16:40:52 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 16:40:52 GMT Subject: osmo-bts.git branch master updated. 0.7.0-23-g6f9d76e Message-ID: <201712051640.vB5GeqQa025420@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 6f9d76e66c5b5c9ea2e850b524f8811289290d8b (commit) from 5b70bb673d5857cc2208712d3bbab29fd650cb09 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=6f9d76e66c5b5c9ea2e850b524f8811289290d8b commit 6f9d76e66c5b5c9ea2e850b524f8811289290d8b Author: Max Date: Tue Dec 5 13:55:51 2017 +0100 Log filenames on L1 errors Change-Id: I7e73374f3f1da662ebed52548d29b6b76443c81b ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-sysmo/l1_transp_hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Tue Dec 5 17:29:26 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 17:29:26 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-38-g4f03432 Message-ID: <201712051729.vB5HTQup045897@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 4f0343233b83337afa1e1dfb4bcf9d076ecd4be2 (commit) via bcab7fb4afcd5c9015f05ce1cce02f9a76928217 (commit) via 427699e6ebcf2f9e3f05198fb1f5afbd408d389e (commit) from 9c0f4f49e9b15b55cd9baa42c1ba191903664397 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=4f0343233b83337afa1e1dfb4bcf9d076ecd4be2 commit 4f0343233b83337afa1e1dfb4bcf9d076ecd4be2 Author: Harald Welte Date: Mon Dec 4 17:33:07 2017 +0100 ggsn: Ignore PCO with length 0, don't abort processing The existing code would abort iterating over the list of PCO TLVs if a TLV of length zero was encountered. However, there's nothing in the spec that would make a zero-length PCO invalid, so we should continue to iterate over any PCO TLVs after the zero-length one. This issue was discovered while writing test cases in osmo-ttcn3-hacks.git Change-Id: I36660566a8ee2ca80ae6ee99c86e167e7c208df2 http://cgit.osmocom.org/osmo-ggsn/commit/?id=bcab7fb4afcd5c9015f05ce1cce02f9a76928217 commit bcab7fb4afcd5c9015f05ce1cce02f9a76928217 Author: Harald Welte Date: Sun Dec 3 21:43:50 2017 +0100 ggsn.c: Fix byte order of IPCP IPv4 DNS servers ... this probably didn't show up as 8.8.8.8 is dual-endian. doh! The address was already in network byte order, but msgb_put_u32 "of course" expects host byte order, ending up the wrong way in the actual packets :/ Change-Id: Ia4bcac5fcebfc24760432eb66be258a01d78f65f Closes: OS#2685 http://cgit.osmocom.org/osmo-ggsn/commit/?id=427699e6ebcf2f9e3f05198fb1f5afbd408d389e commit 427699e6ebcf2f9e3f05198fb1f5afbd408d389e Author: Max Date: Tue Dec 5 16:30:37 2017 +0100 Log APN and tun names for packets Change-Id: I6f7ce33f6585b2b78e2b8a5c0f7111f0316d6ddd ----------------------------------------------------------------------- Summary of changes: ggsn/ggsn.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Tue Dec 5 17:39:59 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 17:39:59 GMT Subject: osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-1974-g8ed6f427 Message-ID: <201712051739.vB5HdxTp050311@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via 8ed6f42772f3002bfa1b8ef8772b138e8cddd443 (commit) via 0d9680e88ae4aabe54fea89e21f2a5fc14f6d8d6 (commit) via c5d9507b5ddd04d4ac14dc009b6df20c3098e2cc (commit) from cd9b850ee4ac4c0a876102924d7456b327a1b250 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=8ed6f42772f3002bfa1b8ef8772b138e8cddd443 commit 8ed6f42772f3002bfa1b8ef8772b138e8cddd443 Author: Vadim Yanitskiy Date: Mon Dec 4 23:49:29 2017 +0700 host/trxcon: forward Timing Advance value to transceiver The time at which the phone is allowed to transmit a burst of traffic within a timeslot must be adjusted accordingly to prevent collisions with adjacent users. Timing Advance (TA) is the variable controlling this adjustment. The TA value is normally between 0 and 63, with each step representing an advance of one bit period (approximately 3.69 microseconds). As trxcon doesn't perform actual burst transmission, this value needs to be forwarded to the transceiver, which will take care about the timings. Change-Id: Ia8c0848827ab2b4cd7cf1efe128b28d5c06ec84e http://cgit.osmocom.org/osmocom-bb/commit/?id=0d9680e88ae4aabe54fea89e21f2a5fc14f6d8d6 commit 0d9680e88ae4aabe54fea89e21f2a5fc14f6d8d6 Author: Vadim Yanitskiy Date: Mon Dec 4 20:58:22 2017 +0700 host/trxcon/trx_if.c: get rid of useless commands The 'SETMAXDLY' command is used on the BTS side to limit maximal Time of Arrival for access bursts. As we don't receive RACH bursts on the MS side, the command is useless. The 'SETRXGAIN' command is used on the BTS side to set initial receive gain value for TRX. On the MS side it's possible to set that parameter via command-line options of TRX. Change-Id: I3e61b4b48193004cdcb241cefabb44c12db93120 http://cgit.osmocom.org/osmocom-bb/commit/?id=c5d9507b5ddd04d4ac14dc009b6df20c3098e2cc commit c5d9507b5ddd04d4ac14dc009b6df20c3098e2cc Author: Vadim Yanitskiy Date: Mon Dec 4 00:18:54 2017 +0700 host/trxcon/trx_ic.c: use osmo_ubit2sbit() from libosmocore No need to reimplement the existing functions... Change-Id: Ic9b232c8561609d42dac10e6249a3e1c58c4edc1 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/l1ctl.c | 5 ++++- src/host/trxcon/trx_if.c | 45 ++++++++++++++++++++++++++++----------------- src/host/trxcon/trx_if.h | 3 +-- 3 files changed, 33 insertions(+), 20 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Tue Dec 5 17:47:24 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 17:47:24 GMT Subject: meta-telephony.git branch 201705 updated. 127bed3ceb41015d8fd36779689ab6d799f773f6 Message-ID: <201712051747.vB5HlOuu056367@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, 201705 has been updated via 127bed3ceb41015d8fd36779689ab6d799f773f6 (commit) from 9a3c3d32f55f4522772904f1eea0a01e822fcd48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=127bed3ceb41015d8fd36779689ab6d799f773f6 commit 127bed3ceb41015d8fd36779689ab6d799f773f6 Author: Pau Espin Pedrol Date: Mon Dec 4 16:01:38 2017 +0100 libosmo-abis: Split libosmotrau into its own package Change-Id: Ica8b6c39aed9f3370aeab84e821c8de871d2f0be ----------------------------------------------------------------------- Summary of changes: recipes-osmocom/libosmo-abis/libosmo-abis.inc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 5 17:47:46 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 17:47:46 GMT Subject: meta-telephony.git branch 201705 updated. 71ac7c0017548daceeb511c8ae231a63a46018f9 Message-ID: <201712051747.vB5HlkGO056527@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, 201705 has been updated via 71ac7c0017548daceeb511c8ae231a63a46018f9 (commit) via cbac8369db1767aa3527a75daf859ca9b26d51f7 (commit) from 127bed3ceb41015d8fd36779689ab6d799f773f6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=71ac7c0017548daceeb511c8ae231a63a46018f9 commit 71ac7c0017548daceeb511c8ae231a63a46018f9 Author: Pau Espin Pedrol Date: Mon Dec 4 18:37:22 2017 +0100 osmocom: Use CONFFILES for cfg files Change-Id: I4a4c7d4a5e3e58c413c82b75f442ae9321d64998 http://cgit.osmocom.org/meta-telephony/commit/?id=cbac8369db1767aa3527a75daf859ca9b26d51f7 commit cbac8369db1767aa3527a75daf859ca9b26d51f7 Author: Pau Espin Pedrol Date: Mon Dec 4 18:29:50 2017 +0100 osmo-sgsn: Install example osmo-gtphub config file Change-Id: Ie8ee1e4b1e0d0a7ca00764a1906b1ff26b7bea4d ----------------------------------------------------------------------- Summary of changes: recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb | 3 ++- recipes-osmocom/osmo-bsc/osmo-bsc.inc | 5 ++++- recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb | 4 +++- recipes-osmocom/osmo-hlr/osmo-hlr.inc | 6 +++++- recipes-osmocom/osmo-iuh/osmo-iuh.inc | 3 ++- recipes-osmocom/osmo-mgw/osmo-mgw.inc | 3 ++- recipes-osmocom/osmo-msc/osmo-msc.inc | 3 ++- recipes-osmocom/osmo-sgsn/osmo-sgsn.inc | 7 ++++++- 8 files changed, 26 insertions(+), 8 deletions(-) hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 5 17:48:23 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 17:48:23 GMT Subject: meta-telephony.git branch 201705 updated. 2e57eb7866433f5cdfb4458ef23d47e03539d0bf Message-ID: <201712051748.vB5HmNUA056868@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, 201705 has been updated via 2e57eb7866433f5cdfb4458ef23d47e03539d0bf (commit) from 71ac7c0017548daceeb511c8ae231a63a46018f9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=2e57eb7866433f5cdfb4458ef23d47e03539d0bf commit 2e57eb7866433f5cdfb4458ef23d47e03539d0bf Author: Pau Espin Pedrol Date: Mon Dec 4 16:53:07 2017 +0100 ortp: Remove unused old ortp 0.16.5 A new version 0.25.0 was added around 3 years ago and has been used since then, because osmocom stack requires at least 0.22.0. This 0.16.5 version has been unused since then, so we can drop it. Change-Id: Ica158e8ddabf5a8ce2a2254ca4fabdc35e7db668 ----------------------------------------------------------------------- Summary of changes: .../ortp/files/0001-fix-unused-variables.patch | 75 ---------------------- .../ortp/files/compile-fixes-newer-gcc.diff | 13 ---- recipes-misc/ortp/ortp_0.16.5.bb | 9 --- 3 files changed, 97 deletions(-) delete mode 100644 recipes-misc/ortp/files/0001-fix-unused-variables.patch delete mode 100644 recipes-misc/ortp/files/compile-fixes-newer-gcc.diff delete mode 100644 recipes-misc/ortp/ortp_0.16.5.bb hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 5 17:53:38 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 17:53:38 GMT Subject: meta-telephony.git branch 201705 updated. 95f1531408a8f5521cf4eb1a60dfd29a5fac0fdb Message-ID: <201712051753.vB5Hrcoa059076@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, 201705 has been updated via 95f1531408a8f5521cf4eb1a60dfd29a5fac0fdb (commit) from 2e57eb7866433f5cdfb4458ef23d47e03539d0bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=95f1531408a8f5521cf4eb1a60dfd29a5fac0fdb commit 95f1531408a8f5521cf4eb1a60dfd29a5fac0fdb Author: Pau Espin Pedrol Date: Mon Dec 4 16:55:05 2017 +0100 ortp: Move DEPENDS to inc file and fix whitespace Change-Id: Idf1c060d8fdbe0a309366ed7bd1e79f40625405c ----------------------------------------------------------------------- Summary of changes: recipes-misc/ortp/ortp.inc | 4 ++-- recipes-misc/ortp/ortp_0.25.0.bb | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 5 18:41:42 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 18:41:42 GMT Subject: osmo-gsm-manuals.git branch master updated. cdbaabae35cb522244c0d194f2437f6c83634480 Message-ID: <201712051841.vB5IfgmX079768@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via cdbaabae35cb522244c0d194f2437f6c83634480 (commit) via ad01ad90a4ca2da72f9ce762b7680de3bfd6f61a (commit) via 2871b885bb897dda6529a32a4b652890875da71f (commit) via 0ac1d98ed268a4ae410581f5978e5f9031f535b1 (commit) from 8b368b11bed5bc8fabf97a6a1494755ee288c2f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=cdbaabae35cb522244c0d194f2437f6c83634480 commit cdbaabae35cb522244c0d194f2437f6c83634480 Author: Alexander Couzens Date: Tue Dec 5 15:16:46 2017 +0000 OsmoSGSN: add rate counter documentation Change-Id: I4c5d5744f961a92bc7c8888ca739d1e8a8a0be9c http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=ad01ad90a4ca2da72f9ce762b7680de3bfd6f61a commit ad01ad90a4ca2da72f9ce762b7680de3bfd6f61a Author: Alexander Couzens Date: Tue Dec 5 14:54:05 2017 +0000 OsmoPCU: add rate counter documentation Change-Id: Ieb4e1dab415a70ded5c65c21752dca497856e96f http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=2871b885bb897dda6529a32a4b652890875da71f commit 2871b885bb897dda6529a32a4b652890875da71f Author: Alexander Couzens Date: Tue Dec 5 14:50:43 2017 +0000 OsmoMSC: add rate counter documentation Change-Id: Idc105fd16511c6ea4f5069a57b217ea3319bdbec http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=0ac1d98ed268a4ae410581f5978e5f9031f535b1 commit 0ac1d98ed268a4ae410581f5978e5f9031f535b1 Author: Alexander Couzens Date: Tue Dec 5 15:22:05 2017 +0100 OsmoBSC: add rate counter documentation Change-Id: Ia8711dd4bc9db36a7121552dc067c7afb1051b0a ----------------------------------------------------------------------- Summary of changes: OsmoBSC/chapters/counters.adoc | 4 + OsmoBSC/chapters/counters_generated.adoc | 76 +++++++++++++ OsmoBSC/osmobsc-usermanual.adoc | 2 + OsmoMSC/chapters/counters.adoc | 4 + OsmoMSC/chapters/counters_generated.adoc | 40 +++++++ OsmoMSC/osmomsc-usermanual.adoc | 2 + OsmoPCU/chapters/counters.adoc | 4 + OsmoPCU/chapters/counters_generated.adoc | 178 ++++++++++++++++++++++++++++++ OsmoPCU/osmopcu-usermanual.adoc | 2 + OsmoSGSN/chapters/counters.adoc | 4 + OsmoSGSN/chapters/counters_generated.adoc | 121 ++++++++++++++++++++ OsmoSGSN/osmosgsn-usermanual.adoc | 2 + 12 files changed, 439 insertions(+) create mode 100644 OsmoBSC/chapters/counters.adoc create mode 100644 OsmoBSC/chapters/counters_generated.adoc create mode 100644 OsmoMSC/chapters/counters.adoc create mode 100644 OsmoMSC/chapters/counters_generated.adoc create mode 100644 OsmoPCU/chapters/counters.adoc create mode 100644 OsmoPCU/chapters/counters_generated.adoc create mode 100644 OsmoSGSN/chapters/counters.adoc create mode 100644 OsmoSGSN/chapters/counters_generated.adoc hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Tue Dec 5 18:42:13 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 18:42:13 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-10-gda0a194 Message-ID: <201712051842.vB5IgDKG080081@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via da0a194b577df4088de1cc41da19363d014ab94c (commit) from 59f50c2718ba30479449ed31ed2202f7a797ca1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=da0a194b577df4088de1cc41da19363d014ab94c commit da0a194b577df4088de1cc41da19363d014ab94c Author: Pau Espin Pedrol Date: Tue Dec 5 17:35:22 2017 +0100 Print error cause of pcu socket connect failure This log is useful to quickly debug scenarions in which pcu never connects to bts. For instance, if bts is started as root and pcu is not, pcu will fail to connect to the socket and will fail with "Permission Denied". Change-Id: I6fd5736b5916cbad72b96f064929bb667ff97ded ----------------------------------------------------------------------- Summary of changes: src/osmobts_sock.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Tue Dec 5 18:43:31 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 18:43:31 GMT Subject: libosmocore.git branch master updated. 0.10.2-44-ga6a40dcb Message-ID: <201712051843.vB5IhVVi080590@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via a6a40dcbfd36d40ab71322e75f8b08ea4933594f (commit) from 06dbdf59ebc87f32048748b822d8caa27dbee4a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a6a40dcbfd36d40ab71322e75f8b08ea4933594f commit a6a40dcbfd36d40ab71322e75f8b08ea4933594f Author: Max Date: Mon Dec 4 13:21:07 2017 +0100 Embedded: fix sercomm test The external sercomm_drv_[un]lock() functions are defined as stubs in case of non-embedded build only which causes linking issue with sercomm_test. Let's define the same stubs in sercomm_test unconditionally - the implementation details of the locking are irrelevant for the test anyway. Related: OS#2708 Change-Id: I3dab4f3348871b66b5d6c9fd10b2e448c61f9e73 ----------------------------------------------------------------------- Summary of changes: tests/sercomm/sercomm_test.c | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Tue Dec 5 18:47:37 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 5 Dec 2017 18:47:37 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-12-gcea806e Message-ID: <201712051847.vB5Ilb19082471@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via cea806e5b9bf7f6c4bdd15520c5914f320fe92f0 (commit) via b4d368b5769e2808cddd15917ef3f06583e920df (commit) from da0a194b577df4088de1cc41da19363d014ab94c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=cea806e5b9bf7f6c4bdd15520c5914f320fe92f0 commit cea806e5b9bf7f6c4bdd15520c5914f320fe92f0 Author: Max Date: Fri Dec 1 17:40:20 2017 +0100 TBF: expand timer logging * log timer values * log start/stop cause * update test output as necessary This simplifies debugging issues with TBF timers. Related: OS#2407 Change-Id: Ib8e537416af9bec5d447356286f44e9e8bbf1b7a http://cgit.osmocom.org/osmo-pcu/commit/?id=b4d368b5769e2808cddd15917ef3f06583e920df commit b4d368b5769e2808cddd15917ef3f06583e920df Author: Max Date: Fri Dec 1 17:54:39 2017 +0100 TBF: fix compiler warning in test tbf/TbfTest.cpp: In function ???void egprs_spb_to_normal_validation(BTS*, unsigned int, unsigned int)???: tbf/TbfTest.cpp:2788:26: warning: ???<bsn1_hi << 9) || (egprs2->bsn1_mid << 1) ~~~~~~~~~~~~~~~~~^~~~~ tbf/TbfTest.cpp:2788:53: warning: ???<bsn1_hi << 9) || (egprs2->bsn1_mid << 1) ~~~~~~~~~~~~~~~~~~^~~~~ tbf/TbfTest.cpp:2825:26: warning: ???<bsn1_hi << 9) || (egprs3->bsn1_mid << 1) || ~~~~~~~~~~~~~~~~~^~~~~ tbf/TbfTest.cpp:2825:53: warning: ???<bsn1_hi << 9) || (egprs3->bsn1_mid << 1) || ~~~~~~~~~~~~~~~~~~^~~~~ tbf/TbfTest.cpp:2844:26: warning: ???<bsn1_hi << 9) || (egprs2->bsn1_mid << 1) || ~~~~~~~~~~~~~~~~~^~~~~ tbf/TbfTest.cpp:2844:53: warning: ???<bsn1_hi << 9) || (egprs2->bsn1_mid << 1) || ~~~~~~~~~~~~~~~~~~^~~~~ Change-Id: Idf9e5f15faa7810411ed9d68ed43cf907eea2545 ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 6 +- src/tbf.cpp | 33 +-- src/tbf.h | 4 +- src/tbf_dl.cpp | 8 +- src/tbf_ul.cpp | 2 +- tests/tbf/TbfTest.cpp | 9 +- tests/tbf/TbfTest.err | 630 +++++++++++++++++++++++++------------------------- 7 files changed, 345 insertions(+), 347 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 6 01:13:12 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 6 Dec 2017 01:13:12 GMT Subject: op25.git branch max updated. ce129911bc0218a700d1f31434c59d7b764e4fe8 Message-ID: <201712060113.vB61DC2Y058829@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via ce129911bc0218a700d1f31434c59d7b764e4fe8 (commit) via d6615c84fe8653179eeaa61d85a02ec0d613f1a0 (commit) from 5b280ae2ef4944a7831b52620c0dd126fc4fab32 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=ce129911bc0218a700d1f31434c59d7b764e4fe8 commit ce129911bc0218a700d1f31434c59d7b764e4fe8 Author: Max Date: Tue Dec 5 20:11:46 2017 -0500 use 480K multi_tx IF rate http://cgit.osmocom.org/op25/commit/?id=d6615c84fe8653179eeaa61d85a02ec0d613f1a0 commit d6615c84fe8653179eeaa61d85a02ec0d613f1a0 Author: Max Date: Tue Dec 5 20:11:02 2017 -0500 dv_tx QRO ----------------------------------------------------------------------- Summary of changes: op25/gr-op25_repeater/apps/tx/dv_tx.py | 3 +-- op25/gr-op25_repeater/apps/tx/multi_tx.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- Software-defined analyzer for APCO P25 From gitosis at osmocom.org Wed Dec 6 14:39:00 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 6 Dec 2017 14:39:00 GMT Subject: osmo-ci.git branch master updated. 8bcebb535060cb8a02d399c24c01fd6841ab0093 Message-ID: <201712061439.vB6Ed0AA028337@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 8bcebb535060cb8a02d399c24c01fd6841ab0093 (commit) from 40c52cf1d361156ab756144ed938f92cba61c8d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=8bcebb535060cb8a02d399c24c01fd6841ab0093 commit 8bcebb535060cb8a02d399c24c01fd6841ab0093 Author: Alexander Couzens Date: Tue Dec 5 12:12:27 2017 +0100 osmocom-nightly/latest: document which debian packages are required Change-Id: If127d0e852ea8e321461d6aa709621167a0a8ecb ----------------------------------------------------------------------- Summary of changes: scripts/osmocom-latest-packages.sh | 3 +++ scripts/osmocom-nightly-packages.sh | 3 +++ 2 files changed, 6 insertions(+) hooks/post-receive -- CI scripts From gitosis at osmocom.org Thu Dec 7 12:59:45 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 7 Dec 2017 12:59:45 GMT Subject: osmo-bts.git branch master updated. 0.7.0-24-g28cb32a Message-ID: <201712071259.vB7Cxjem001965@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 28cb32a74bee69f992f8b19babcae50a571de089 (commit) from 6f9d76e66c5b5c9ea2e850b524f8811289290d8b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=28cb32a74bee69f992f8b19babcae50a571de089 commit 28cb32a74bee69f992f8b19babcae50a571de089 Author: Philipp Maier Date: Wed Dec 6 14:35:11 2017 +0100 cosmetic: meas_test: fix section comment Change-Id: Id228620ccf5a40c8089ae1914d59b19e808ea151 ----------------------------------------------------------------------- Summary of changes: tests/meas/meas_test.c | 2 +- tests/meas/meas_test.ok | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Thu Dec 7 16:10:30 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 7 Dec 2017 16:10:30 GMT Subject: osmo-gsm-manuals.git branch master updated. cef03ec36d8a44442e153703a497ce150462d44f Message-ID: <201712071610.vB7GAUrn084576@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via cef03ec36d8a44442e153703a497ce150462d44f (commit) via 3d2f7ffe40c83b3af5e0bea1e6da100fb8682486 (commit) from cdbaabae35cb522244c0d194f2437f6c83634480 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=cef03ec36d8a44442e153703a497ce150462d44f commit cef03ec36d8a44442e153703a497ce150462d44f Author: Max Date: Thu Dec 7 16:48:37 2017 +0100 CTRL: add rate counter dumper to examples This describe rate counter dumper added to osmo-python-tests in I12b369434e4ee9b38f92872f297e1f3d4f0698c2 Change-Id: I52d735f373f2e7aa1f12941fc450c0e9740ccdeb Related: OS#2550 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=3d2f7ffe40c83b3af5e0bea1e6da100fb8682486 commit 3d2f7ffe40c83b3af5e0bea1e6da100fb8682486 Author: Max Date: Thu Dec 7 15:56:25 2017 +0100 Update CTRL example Use proper script new and repository location. Change-Id: I3c16f38ade6fcfadffd8d2573f71828119da055c ----------------------------------------------------------------------- Summary of changes: common/chapters/control_if.adoc | 50 ++++++++++++++++++++++++++++++++--------- 1 file changed, 40 insertions(+), 10 deletions(-) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Thu Dec 7 18:41:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 7 Dec 2017 18:41:06 GMT Subject: osmo-gsm-manuals.git branch neels/osmo-bsc created. 04044575742492403a34cf322b9fdab5cd930b6a Message-ID: <201712071841.vB7If6K7049751@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, neels/osmo-bsc has been created at 04044575742492403a34cf322b9fdab5cd930b6a (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=04044575742492403a34cf322b9fdab5cd930b6a commit 04044575742492403a34cf322b9fdab5cd930b6a Author: Neels Hofmeyr Date: Thu Dec 7 19:40:25 2017 +0100 common: bts: add blank line to separate a code block Change-Id: I6072253a9293e5000465039d7dcd0c6e2b9966a3 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=f00493e8bb585b394b1dfeaa04795ed1a349476b commit f00493e8bb585b394b1dfeaa04795ed1a349476b Author: Neels Hofmeyr Date: Thu Dec 7 19:39:51 2017 +0100 common: bts: dyn ts: example: mention both osmo-bsc and osmo-nitb Change-Id: Ie3218fd1449493a252a54f0b5356e8647df619e1 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=de14286595419c69446fc9cab82141757eecb61f commit de14286595419c69446fc9cab82141757eecb61f Author: Neels Hofmeyr Date: Thu Dec 7 19:39:18 2017 +0100 common: bts: dyn ts: explain dyn_ts_allow_tch_f from OsmoBSC viewpoint Change-Id: If9425b16216f353515890a7b2de8590bdfa1ff38 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=f28a722cc8704f30e8b735fb372a09f59e7b6281 commit f28a722cc8704f30e8b735fb372a09f59e7b6281 Author: Neels Hofmeyr Date: Thu Dec 7 19:36:53 2017 +0100 common: bts: dyn ts: mark octasic as supported Supported since osmo-bts 69ec4a419edee4f00a104c59a78b530eaf85382a / Ia109d4bfade7bc28442127581f4bb0289146ea71 Change-Id: Iab21573ab308b1e243bd6b56c9e3b1977a7f69fe http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=09c2b165ccf6dca9c6d67fdbd564462dff2e22e4 commit 09c2b165ccf6dca9c6d67fdbd564462dff2e22e4 Author: Neels Hofmeyr Date: Thu Dec 7 19:36:37 2017 +0100 common: bts: dyn ts: drop special meaning for OsmoBSC vs OsmoNITB Change-Id: I70da58bee08e531babfe78852cc82a1177f9b7b2 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=b65097e94677a52deb90872112185444283261d8 commit b65097e94677a52deb90872112185444283261d8 Author: Neels Hofmeyr Date: Thu Dec 7 19:34:45 2017 +0100 common: bts: tweak BTS config example to show config, not telnet VTY Change-Id: I9dda76cee8dfef6fc91099bcb3f90bed6c00b794 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=fe76d58e06b9844a3a4b2c8bded589a38e5e4a2a commit fe76d58e06b9844a3a4b2c8bded589a38e5e4a2a Author: Neels Hofmeyr Date: Thu Dec 7 19:34:05 2017 +0100 common: bts: show 'OsmoBSC>' vty prompt by default, not OpenBSC Change-Id: I3b19ea58fc843852c5317502941c2b6c6d3cd743 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=c8e0cf628232d9a749d47b962b37719eae012e01 commit c8e0cf628232d9a749d47b962b37719eae012e01 Author: Neels Hofmeyr Date: Thu Dec 7 19:32:39 2017 +0100 drop alink Change-Id: Ib21418aa86228a1afbdf15205406ae39556f3018 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=aa29df546a9187f72a6294934c587b4867d2e54e commit aa29df546a9187f72a6294934c587b4867d2e54e Author: Neels Hofmeyr Date: Thu Dec 7 19:31:50 2017 +0100 move bts examples to OsmoBSC Change-Id: I85280e787ef53a7ab582f579565252b8426200c3 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=652f2a888657e0580168003b2afa8af19c4f5b79 commit 652f2a888657e0580168003b2afa8af19c4f5b79 Author: Neels Hofmeyr Date: Thu Dec 7 19:30:38 2017 +0100 OsmoBSC: update overview to explain both SCCPlite and SCCP/M3UA Change-Id: I1f105b3febd4f99f4491e217ff1b1d0b28912980 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=40b3f7ae5f9e0a341c72489a12173aa1b10cd931 commit 40b3f7ae5f9e0a341c72489a12173aa1b10cd931 Author: Neels Hofmeyr Date: Thu Dec 7 17:32:07 2017 +0100 OsmoHLR: update section 'Bootstrap the Database' Change-Id: I1b7b99cc77d8cd8cce42e7cf93f5e2cd3c2344db http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=3a36416179049060cb3d318935aa99a214e4ac8c commit 3a36416179049060cb3d318935aa99a214e4ac8c Author: Neels Hofmeyr Date: Thu Dec 7 17:01:29 2017 +0100 common: preface: spectrum license: also mention UMTS Change-Id: I496f56c05f873a7d9d1cdf2bc95231c7957cf51b http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=017b669861a2e585c42044219a1925a6d4c8eca6 commit 017b669861a2e585c42044219a1925a6d4c8eca6 Author: Neels Hofmeyr Date: Thu Dec 7 17:01:10 2017 +0100 common: preface: minor tweaks Change-Id: Icfc3dee5fa5e6cc0f6a6e80b122206deeceff102 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=05e840440fd8b68a9cfcd0b66b2cf9cdbb027f68 commit 05e840440fd8b68a9cfcd0b66b2cf9cdbb027f68 Author: Neels Hofmeyr Date: Thu Dec 7 17:00:45 2017 +0100 common: adjust preface to mention the current state of the Osmocom art Change-Id: I5690e7b5f0bd1483b5451f284a758b4b09c80d95 ----------------------------------------------------------------------- hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Thu Dec 7 22:30:58 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 7 Dec 2017 22:30:58 GMT Subject: osmo-gsm-manuals.git branch master updated. dcfbc8e249dd910024f89a20fe58fff38d5cb222 Message-ID: <201712072230.vB7MUwAW041514@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via dcfbc8e249dd910024f89a20fe58fff38d5cb222 (commit) via 96c8351fdcaf8b116670279fc4d43497479ea27e (commit) via 5b02f9a09296047d72eb8fc4465c6e2fdce5869b (commit) via 7b06baccd60b0f02e4d7f8be29f8a24fc1764a06 (commit) via da63831ef9eca0afc32aa90e72001793ba3488e0 (commit) via 2f9403f727cd0ae8488f56f41f9326b04af30d3e (commit) via ea209f2a8ef10952382400331e7cc4715f9dfb55 (commit) via 02abf0c761c228d2a30450cc419fc9a5ce42ad36 (commit) from cef03ec36d8a44442e153703a497ce150462d44f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=dcfbc8e249dd910024f89a20fe58fff38d5cb222 commit dcfbc8e249dd910024f89a20fe58fff38d5cb222 Author: Neels Hofmeyr Date: Thu Dec 7 19:34:45 2017 +0100 common: bts: tweak BTS config example to show config, not telnet VTY Change-Id: I9dda76cee8dfef6fc91099bcb3f90bed6c00b794 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=96c8351fdcaf8b116670279fc4d43497479ea27e commit 96c8351fdcaf8b116670279fc4d43497479ea27e Author: Neels Hofmeyr Date: Thu Dec 7 19:40:25 2017 +0100 common: bts: add blank line to separate a code block Change-Id: I6072253a9293e5000465039d7dcd0c6e2b9966a3 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=5b02f9a09296047d72eb8fc4465c6e2fdce5869b commit 5b02f9a09296047d72eb8fc4465c6e2fdce5869b Author: Neels Hofmeyr Date: Thu Dec 7 19:39:51 2017 +0100 common: bts: dyn ts: example: mention both osmo-bsc and osmo-nitb Change-Id: Ie3218fd1449493a252a54f0b5356e8647df619e1 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=7b06baccd60b0f02e4d7f8be29f8a24fc1764a06 commit 7b06baccd60b0f02e4d7f8be29f8a24fc1764a06 Author: Neels Hofmeyr Date: Thu Dec 7 19:39:18 2017 +0100 common: bts: dyn ts: explain dyn_ts_allow_tch_f from OsmoBSC viewpoint Change-Id: If9425b16216f353515890a7b2de8590bdfa1ff38 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=da63831ef9eca0afc32aa90e72001793ba3488e0 commit da63831ef9eca0afc32aa90e72001793ba3488e0 Author: Neels Hofmeyr Date: Thu Dec 7 19:36:53 2017 +0100 common: bts: dyn ts: mark octasic as supported Supported since osmo-bts 69ec4a419edee4f00a104c59a78b530eaf85382a / Ia109d4bfade7bc28442127581f4bb0289146ea71 Change-Id: Iab21573ab308b1e243bd6b56c9e3b1977a7f69fe http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=2f9403f727cd0ae8488f56f41f9326b04af30d3e commit 2f9403f727cd0ae8488f56f41f9326b04af30d3e Author: Neels Hofmeyr Date: Thu Dec 7 19:36:37 2017 +0100 common: bts: dyn ts: drop special meaning for OsmoBSC vs OsmoNITB Change-Id: I70da58bee08e531babfe78852cc82a1177f9b7b2 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=ea209f2a8ef10952382400331e7cc4715f9dfb55 commit ea209f2a8ef10952382400331e7cc4715f9dfb55 Author: Neels Hofmeyr Date: Thu Dec 7 19:41:54 2017 +0100 common / OsmoBSC: drop unused alink.adoc Change-Id: Ia3219359be891c161d20eccb7bbcb65af35ef42b http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=02abf0c761c228d2a30450cc419fc9a5ce42ad36 commit 02abf0c761c228d2a30450cc419fc9a5ce42ad36 Author: Neels Hofmeyr Date: Thu Dec 7 19:30:38 2017 +0100 OsmoBSC: update overview to explain both SCCPlite and SCCP/M3UA Change-Id: I1f105b3febd4f99f4491e217ff1b1d0b28912980 ----------------------------------------------------------------------- Summary of changes: OsmoBSC/chapters/alink.adoc | 15 ---- OsmoBSC/chapters/overview.adoc | 168 ++++++++++++++++++++++------------------ OsmoBSC/osmobsc-usermanual.adoc | 2 - common/chapters/bts.adoc | 101 +++++++++++++----------- 4 files changed, 147 insertions(+), 139 deletions(-) delete mode 100644 OsmoBSC/chapters/alink.adoc hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Thu Dec 7 22:32:30 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 7 Dec 2017 22:32:30 GMT Subject: osmo-gsm-manuals.git branch master updated. fd14387de56220daf180b60e3ce6033eabcb51d2 Message-ID: <201712072232.vB7MWUVg042160@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via fd14387de56220daf180b60e3ce6033eabcb51d2 (commit) via 596c49fc3955c14dd4b719b527c8e32313fb406d (commit) via ac3414cc8aa383be4d713766d4c468765657b059 (commit) via a0ca649d40090e57c31bc8d42e6f36de935e6da7 (commit) from dcfbc8e249dd910024f89a20fe58fff38d5cb222 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=fd14387de56220daf180b60e3ce6033eabcb51d2 commit fd14387de56220daf180b60e3ce6033eabcb51d2 Author: Neels Hofmeyr Date: Thu Dec 7 17:32:07 2017 +0100 OsmoHLR: update section 'Bootstrap the Database' Change-Id: I1b7b99cc77d8cd8cce42e7cf93f5e2cd3c2344db http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=596c49fc3955c14dd4b719b527c8e32313fb406d commit 596c49fc3955c14dd4b719b527c8e32313fb406d Author: Neels Hofmeyr Date: Thu Dec 7 17:01:29 2017 +0100 common: preface: spectrum license: also mention UMTS Change-Id: I496f56c05f873a7d9d1cdf2bc95231c7957cf51b http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=ac3414cc8aa383be4d713766d4c468765657b059 commit ac3414cc8aa383be4d713766d4c468765657b059 Author: Neels Hofmeyr Date: Thu Dec 7 17:01:10 2017 +0100 common: preface: minor tweaks Change-Id: Icfc3dee5fa5e6cc0f6a6e80b122206deeceff102 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=a0ca649d40090e57c31bc8d42e6f36de935e6da7 commit a0ca649d40090e57c31bc8d42e6f36de935e6da7 Author: Neels Hofmeyr Date: Thu Dec 7 17:00:45 2017 +0100 common: adjust preface to mention the current state of the Osmocom art Change-Id: I5690e7b5f0bd1483b5451f284a758b4b09c80d95 ----------------------------------------------------------------------- Summary of changes: OsmoHLR/chapters/running.adoc | 22 ++++++---------------- common/chapters/preface.adoc | 34 +++++++++++++++++++++------------- 2 files changed, 27 insertions(+), 29 deletions(-) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Thu Dec 7 22:35:50 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 7 Dec 2017 22:35:50 GMT Subject: osmo-ci.git branch master updated. 6655542cec3a2195d228e66ce065a61b496d4324 Message-ID: <201712072235.vB7MZoNb043549@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 6655542cec3a2195d228e66ce065a61b496d4324 (commit) from 8bcebb535060cb8a02d399c24c01fd6841ab0093 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=6655542cec3a2195d228e66ce065a61b496d4324 commit 6655542cec3a2195d228e66ce065a61b496d4324 Author: Alexander Couzens Date: Tue Dec 5 12:05:09 2017 +0100 osmocom-nightly/latest: check if osc is installed Change-Id: I10ce91eab415c19bb811fbb2fd617d5ce2b58d41 ----------------------------------------------------------------------- Summary of changes: scripts/osmocom-latest-packages.sh | 5 +++++ scripts/osmocom-nightly-packages.sh | 5 +++++ 2 files changed, 10 insertions(+) hooks/post-receive -- CI scripts From gitosis at osmocom.org Fri Dec 8 20:13:36 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 8 Dec 2017 20:13:36 GMT Subject: osmocom-bb.git branch fixeria/trx_tch created. osmocon_v0.0.0-1952-g097d19a0 Message-ID: <201712082013.vB8KDanE086421@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx_tch has been created at 097d19a062ffffebed98430d9170e4087efde84b (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=097d19a062ffffebed98430d9170e4087efde84b commit 097d19a062ffffebed98430d9170e4087efde84b Author: Vadim Yanitskiy Date: Sun Aug 13 01:35:22 2017 +0600 host/trxcon/l1ctl.c: handle L1CTL_TRAFFIC_REQ Change-Id: Ibdf2d4f6aa464250a4c6951af86c06eb3fd3b98b http://cgit.osmocom.org/osmocom-bb/commit/?id=64e08c45abae6e07c765fbc39a424b1a863c1d35 commit 64e08c45abae6e07c765fbc39a424b1a863c1d35 Author: Vadim Yanitskiy Date: Sun Aug 13 01:30:18 2017 +0600 host/trxcon/scheduler: add TCH/H channel support Change-Id: Ie5ee49bfc5dc6cfb1348f02d6c71c701e1c55aa3 http://cgit.osmocom.org/osmocom-bb/commit/?id=ede8789c57ac4977dcce5fbe4af2ad119fa7e3d1 commit ede8789c57ac4977dcce5fbe4af2ad119fa7e3d1 Author: Vadim Yanitskiy Date: Mon Aug 7 14:24:18 2017 +0600 host/trxcon/scheduler: add TCH/F channel support Change-Id: If6b0eaede2b484484d2a824e7219ff04483266a1 http://cgit.osmocom.org/osmocom-bb/commit/?id=fb06462d3c9c93f730c4234f9f062fd18b0bf5f2 commit fb06462d3c9c93f730c4234f9f062fd18b0bf5f2 Author: Vadim Yanitskiy Date: Sun Nov 19 15:41:19 2017 +0700 host/trxcon: fix: use valid names for FSM instances Since 8c4f5457 in libosmocore there are some limitations on FSM and FSM instance names. This change adjusts the names of both l1ctl_fsm and trx_fsm instances. Change-Id: Icaaac3f51bdcfe4f7723060179b8730c3a06529b http://cgit.osmocom.org/osmocom-bb/commit/?id=d7afb9f8d71b89474b2c37095c4b938efbbcf3fc commit d7afb9f8d71b89474b2c37095c4b938efbbcf3fc Author: Vadim Yanitskiy Date: Sat Aug 19 12:38:24 2017 +0600 host/trxcon/scheduler: separate logging of data messages Change-Id: I3a33687a688db2a183b546425f71c7a0a7030594 http://cgit.osmocom.org/osmocom-bb/commit/?id=dedf3e42d3dd6e239a0586778996816f9f0b0fd9 commit dedf3e42d3dd6e239a0586778996816f9f0b0fd9 Author: Vadim Yanitskiy Date: Sat Aug 19 12:28:39 2017 +0600 host/trxcon/trx_if.c: separate logging of data messages Change-Id: I74ebe0441aeb41c324eafb6b586b2edd9ef4fd1a http://cgit.osmocom.org/osmocom-bb/commit/?id=71c7b4622ff844e0cf9eddc16472e18f06c92a26 commit 71c7b4622ff844e0cf9eddc16472e18f06c92a26 Author: Vadim Yanitskiy Date: Sat Aug 19 12:15:15 2017 +0600 host/trxcon: use LOGP instead of fprintf There is no (performance) reason to use fprintf instead of LOGP. Second one provides more useful information, such as a file name and a line number. Change-Id: I86dda5b3d746c7802442e4226578a06c04941721 http://cgit.osmocom.org/osmocom-bb/commit/?id=cd6196c7d4cc69a5f7072bf778d5a76c3406051e commit cd6196c7d4cc69a5f7072bf778d5a76c3406051e Author: Vadim Yanitskiy Date: Sat Aug 19 11:59:03 2017 +0600 host/trxcon/trx_if.c: fix wrong logging category Change-Id: I0df0205e160fd9ea5811852077db7c49cddc7e8a http://cgit.osmocom.org/osmocom-bb/commit/?id=9c310fd803865f38396daabc0582856910b721d9 commit 9c310fd803865f38396daabc0582856910b721d9 Author: Vadim Yanitskiy Date: Wed Aug 16 14:05:24 2017 +0600 host/trxcon/scheduler: fix prim queue flushing function For some reasons, the function, which is used to flush a queue of transmit primitives, was intended to flush a list of msgb instances instead of trx_ts_prim, so memory was being cleaned incorrectly. Moreover, the items weren't actually removed from queue. Change-Id: Ia84b57350a5c2eee0afebc65f62e30eaddb141d4 http://cgit.osmocom.org/osmocom-bb/commit/?id=da83ccf9f7013289ca37931cf1ec3a8b6aaf4753 commit da83ccf9f7013289ca37931cf1ec3a8b6aaf4753 Author: Vadim Yanitskiy Date: Wed Aug 16 13:36:20 2017 +0600 host/trxcon/scheduler: share common declarations of lchan handlers The training sequences, data / traffic indication and confirmation helpers are used by several lchan handlers, like xCCC and TCH. It would be better to have them all declared within a shared header. Change-Id: I71980f09a0c0e023370e1a651afc24fff2491552 http://cgit.osmocom.org/osmocom-bb/commit/?id=41de73575289b0272a20a7b17ad04218e1816808 commit 41de73575289b0272a20a7b17ad04218e1816808 Author: Vadim Yanitskiy Date: Thu Aug 3 20:18:05 2017 +0600 host/trxcon/l1ctl.c: handle L1CTL_TCH_MODE_REQ Change-Id: Ib2332e1610fa873755cdfa745153c7b7d4a72a62 http://cgit.osmocom.org/osmocom-bb/commit/?id=41b0b3f33363327a090f66bd06a84f83a9af1baa commit 41b0b3f33363327a090f66bd06a84f83a9af1baa Author: Vadim Yanitskiy Date: Tue Aug 15 16:03:02 2017 +0600 host/trxcon/l1ctl.c: include DL frame info in L1CTL_DATA_CONF The l1ctl_info_dl header is expected to be a part of a L1CTL_DATA_CONF message, but was missing previously. Change-Id: Ia8dfaed924fd84395ba9ae539164eaa94f52d30b http://cgit.osmocom.org/osmocom-bb/commit/?id=842a5b2edc1c3588e9439b7adca812c7dd5facf1 commit 842a5b2edc1c3588e9439b7adca812c7dd5facf1 Author: Vadim Yanitskiy Date: Tue Aug 15 14:30:19 2017 +0600 host/trxcon/l1ctl.c: use primitive management API for RACH Change-Id: I956ddfc4d1b47575715375c08f46c55953ec5fb6 http://cgit.osmocom.org/osmocom-bb/commit/?id=eba1c26068d0acad2f11eb5715312dd774512d59 commit eba1c26068d0acad2f11eb5715312dd774512d59 Author: Vadim Yanitskiy Date: Sun Aug 13 00:16:24 2017 +0600 host/trxcon/l1ctl.c: share primitive management code This change introduces shared primitive management functions, exposed from the l1ctl_rx_data_req() implementation: - sched_trx_init_prim() - allocates memory for a new primitive and its payload. Initializes primitive's header, setting the logical channel type and the payload length. After initialization, the talloc context of a primitive is a trx instance, which passed as the first argument. - sched_trx_push_prim() - decodes the timeslot index from chan_nr and pushes a primitive to its transimt queue. The talloc context of primitive is changed to the parent trx_ts instance after queuing. Both functions will be used for handling both L1CTL_TRAFFIC_REQ and L1CTL_RACH_REQ. Change-Id: I8169a1ef4ef54d91b50f3e213e4842f54af8b499 http://cgit.osmocom.org/osmocom-bb/commit/?id=d562255653f2002ac7555f260c9042691d690e40 commit d562255653f2002ac7555f260c9042691d690e40 Author: Vadim Yanitskiy Date: Sun Aug 13 01:20:19 2017 +0600 host/trxcon/l1ctl.c: don't fill l1ctl_info_ul into a primitive The UL frame header isn't used by lchan handlers. Change-Id: Ia1c63b6f17c3802b29f54299da1151a39edf3a03 http://cgit.osmocom.org/osmocom-bb/commit/?id=665e1e2baad0aed753d4dc59f27f985414d77b50 commit 665e1e2baad0aed753d4dc59f27f985414d77b50 Author: Vadim Yanitskiy Date: Mon Aug 7 13:18:59 2017 +0600 host/trxcon/l1ctl.c: retune TRX only if current ARFCN differs Change-Id: I797dc284bd92d07ad4859f851a44d048407db86d http://cgit.osmocom.org/osmocom-bb/commit/?id=1baca021272f031b9ce4d08c830a174d2740c821 commit 1baca021272f031b9ce4d08c830a174d2740c821 Author: Vadim Yanitskiy Date: Sat Aug 5 02:22:12 2017 +0600 host/trxcon/scheduler: send stored tx_power to transceiver Previously a fixed fake value (10) was used. Change-Id: I8ba70bbda6c8c9249f8eb4294aeb41ab8769a19a http://cgit.osmocom.org/osmocom-bb/commit/?id=6df90ae42e01d475ae07cd02ca5ae9d460bd1a76 commit 6df90ae42e01d475ae07cd02ca5ae9d460bd1a76 Author: Vadim Yanitskiy Date: Fri Aug 4 16:37:45 2017 +0600 host/trxcon/l1ctl.c: fix wrong log level Change-Id: I0ac65d94b0ae3dd370675318a26a65d11c49cbbe http://cgit.osmocom.org/osmocom-bb/commit/?id=f6b1fc2470b119ef749fb771a79a751d9cfc2347 commit f6b1fc2470b119ef749fb771a79a751d9cfc2347 Author: Vadim Yanitskiy Date: Fri Aug 4 16:31:04 2017 +0600 host/trxcon: separate logging of L1 Control and L1 Data L1 Data is quite verbose, while Control is typically limited. And if you would need to debug some Control message handling, the Data messages wont overflow your terminal anymore. This change introduces a new logging category named 'DL1D'. Change-Id: Id830c8bf913f7a8ddc87c47f70a337ee4623abd8 http://cgit.osmocom.org/osmocom-bb/commit/?id=8daa2c5c96d76a4b52c9827d28b5c030fb57c204 commit 8daa2c5c96d76a4b52c9827d28b5c030fb57c204 Author: Vadim Yanitskiy Date: Fri Aug 4 13:05:09 2017 +0600 host/trxcon/l1ctl.c: do nothing if CCCH mode matches When the L1CTL_CCCH_MODE_REQ is received, we don't need to reconfigure anything if the current mode matches requested. Change-Id: Ib8a511e4edd7210b1806f47e83f316be00a8cbb1 http://cgit.osmocom.org/osmocom-bb/commit/?id=8bac0863cdf0212e7fa1fd56ca40899f694cc1bf commit 8bac0863cdf0212e7fa1fd56ca40899f694cc1bf Author: Vadim Yanitskiy Date: Thu Aug 3 20:00:12 2017 +0600 fake_trx: whitespace fix Change-Id: Iad2be36777e4a2454e181c856c7902574a4ab20c http://cgit.osmocom.org/osmocom-bb/commit/?id=405dd5f51552f11c5387c4241b9bedbcb0974a1e commit 405dd5f51552f11c5387c4241b9bedbcb0974a1e Author: Vadim Yanitskiy Date: Thu Aug 3 19:51:57 2017 +0600 fake_trx: separate DataInterface from burst_gen.py Change-Id: I325cf2ae59ef8834c2ddfb67206eede44d1e0acf http://cgit.osmocom.org/osmocom-bb/commit/?id=18c1d3c093edea8559d8733b9b42555e6f142118 commit 18c1d3c093edea8559d8733b9b42555e6f142118 Author: Vadim Yanitskiy Date: Thu Aug 3 19:34:39 2017 +0600 fake_trx: add options to specify fn, tn and pwr Change-Id: Ifd4f4864707596a69fece11218a4800b98551c31 http://cgit.osmocom.org/osmocom-bb/commit/?id=6bb0d1b7f13afaa1785d90b0d724314fe09834db commit 6bb0d1b7f13afaa1785d90b0d724314fe09834db Author: Vadim Yanitskiy Date: Mon Jul 31 20:06:36 2017 +0600 host/trxcon/scheduler: clean up some includes Change-Id: I47e3b953b80f4f822d563579d15498181009ca80 http://cgit.osmocom.org/osmocom-bb/commit/?id=abd867c4195b95b8b44fdabfc86b97c94c5902b1 commit abd867c4195b95b8b44fdabfc86b97c94c5902b1 Author: Vadim Yanitskiy Date: Mon Jul 31 17:24:27 2017 +0600 host/trxcon/scheduler: share common code for lchan handlers The training sequences array is currently used by xCCH handlers, but will be also used for handling both TCH/F and TCH/H bursts. Moreover the code that forwards decoded L2 payloads to L1CTL protocol handlers was separated into a new shared function. Change-Id: I34c3de351362ebd9a070f49bb78d7bd976784b04 http://cgit.osmocom.org/osmocom-bb/commit/?id=962fa7d345dc9cbeaff5488665a49f6c44bde77d commit 962fa7d345dc9cbeaff5488665a49f6c44bde77d Author: Vadim Yanitskiy Date: Mon Jul 31 15:00:15 2017 +0600 host/trxcon/l1ctl.c: make l1ctl_tx_data_ind flexible Now this function can send both DATA and TRAFFIC indications. Change-Id: I945c10c317155917b6e6ce9d663d9cb46f2e085c http://cgit.osmocom.org/osmocom-bb/commit/?id=d6ff1aafc2ed44269fa8f11126d0548dd2401d34 commit d6ff1aafc2ed44269fa8f11126d0548dd2401d34 Author: Vadim Yanitskiy Date: Mon Jul 31 14:03:51 2017 +0600 host/trxcon/scheduler: get rid of useless nbits argument Change-Id: I8508676e2cb347396c6ca6b394f13113f3e63084 http://cgit.osmocom.org/osmocom-bb/commit/?id=8cab4406da7bd6406b788fe7b7a53bd9e61e5669 commit 8cab4406da7bd6406b788fe7b7a53bd9e61e5669 Author: Vadim Yanitskiy Date: Mon Jul 31 13:27:30 2017 +0600 host/trxcon/scheduler: pass trx_lchan_state to lchan handlers It's better to pass a trx_lchan_state instance directly from caller to lchan handler instead of passing trx_lchan_type. This way a handler wouldn't need to find lchan itself. Change-Id: I47a40542b03ab31da12b0abb1c263c83662ff018 http://cgit.osmocom.org/osmocom-bb/commit/?id=49708647b2821e96f3bd50a4953b34e26e99d111 commit 49708647b2821e96f3bd50a4953b34e26e99d111 Author: Vadim Yanitskiy Date: Sat Jul 29 23:43:52 2017 +0600 host/trxcon/scheduler: fix chan_nr parsing Previously, the chan_nr, received from L2, was parsed in a wrong way, so in some cases only one logical channel was activated or some messages (such as Measurement Requests) were sent on incorrect channel (e.g. on SDCCH instead of SACCH). This change reimplements the sched_trx_chan_nr2lchan_type(), and introduces a new function sched_trx_set_lchans(), whics will parse chan_nr and (de)activate required channels. Change-Id: I480311c65ef93bbc1644ec708dd2a68fd33091e0 http://cgit.osmocom.org/osmocom-bb/commit/?id=0067c2cde269081ee8951e607a6c6025e7fc6c42 commit 0067c2cde269081ee8951e607a6c6025e7fc6c42 Author: Vadim Yanitskiy Date: Fri Jul 28 16:03:05 2017 +0600 host/trxcon/scheduler: ignore incomplete sets of bursts To be able to decode one xCCH message, it's required to have all set of bursts collected (4/4). Otherwise we should not even try to decode an incomplete set. Change-Id: Iaa63462efe19b8e96102fc8c8d8c968a2df2c70e http://cgit.osmocom.org/osmocom-bb/commit/?id=b743b60d7613c224d509725d2096aaea5aad74ef commit b743b60d7613c224d509725d2096aaea5aad74ef Author: Vadim Yanitskiy Date: Fri Jul 28 15:53:59 2017 +0600 host/trxcon/scheduler: drop a meaningless FIXME label Change-Id: If5497f4fdce22e986f46725cc1575a1e809ccdab http://cgit.osmocom.org/osmocom-bb/commit/?id=32c49df6591a9c3d792082e54eea31dc4db51075 commit 32c49df6591a9c3d792082e54eea31dc4db51075 Author: Vadim Yanitskiy Date: Fri Jul 28 15:36:44 2017 +0600 host/trxcon/scheduler: use 'tn' instead of 'ts_num' The new timeslot index designation is more generic for Osmocom projects, so let's use one. Change-Id: I8c0118aad439816148490e57938d7e32b6e20877 http://cgit.osmocom.org/osmocom-bb/commit/?id=e21e8f4141b89c97bed0a58c390d2cf80209a63f commit e21e8f4141b89c97bed0a58c390d2cf80209a63f Author: Vadim Yanitskiy Date: Fri Jul 28 15:15:05 2017 +0600 host/trxcon/scheduler: git rid of sched_trx_find_ts() After simplification of timeslot management API this function does not make sense. Change-Id: I2fc0c68d784c8f01e1452bc46f8e1eaac2917656 http://cgit.osmocom.org/osmocom-bb/commit/?id=d18a914aa71d9e65b45ee5878636554c9da922bc commit d18a914aa71d9e65b45ee5878636554c9da922bc Author: Vadim Yanitskiy Date: Fri Jul 28 15:00:40 2017 +0600 host/trxcon/scheduler: fix possible NULL deference We should make sure that required timeslot is not only allocated, but also configured, i.e. has a correct multiframe layout. Change-Id: I1d0b870c389802b51c709d089b80ac3fb3565fa8 http://cgit.osmocom.org/osmocom-bb/commit/?id=49bf1fde69bacd3c78178cbeb0cc25baae14144c commit 49bf1fde69bacd3c78178cbeb0cc25baae14144c Author: Vadim Yanitskiy Date: Fri Jul 28 14:47:41 2017 +0600 host/trxcon/scheduler: simplify timeslot management As we know the count of timeslots per GSM TDMA frame, it would be better to have an array of pointers to trx_ts instances instead of linux list, which is more usable for lists with unknown length. Change-Id: I9510a5cddde22950ceb8422e0990d59f05ed4d60 http://cgit.osmocom.org/osmocom-bb/commit/?id=f94c3217978cb33ea4cb6bbf1ade05c7656d5c58 commit f94c3217978cb33ea4cb6bbf1ade05c7656d5c58 Author: Vadim Yanitskiy Date: Fri Jul 28 13:56:09 2017 +0600 fake_trx: add a new tool for burst generation This change introduces a new tool named 'burst_gen.py'. One can be used for sending GSM bursts either to L1 (OsmoBTS or OsmocomBB) or to TRX (OsmoTRX and GR-GSM TRX). Currently it is only possible to send random bursts of different types: NB, FB, SB, AB. Change-Id: Ie14281222d29536b8690517e57af2a1007fcbc91 http://cgit.osmocom.org/osmocom-bb/commit/?id=63a0797dfc9d50c361580e29dbca554eb668fb69 commit 63a0797dfc9d50c361580e29dbca554eb668fb69 Author: Vadim Yanitskiy Date: Fri Jul 28 13:43:35 2017 +0600 fake_trx: add copyright message to clck_gen.py and ctrl_cmd.py Change-Id: Ia79279dd9e85d131d66d790f1f3fd64fb1914f58 http://cgit.osmocom.org/osmocom-bb/commit/?id=8e2db3bbc83fe6037d02fb6135f98454a715023e commit 8e2db3bbc83fe6037d02fb6135f98454a715023e Author: Vadim Yanitskiy Date: Wed Jul 26 20:28:01 2017 +0600 host/trxcon: adjust default verbosity level Change-Id: I91258091b59e5cdd30b767364fb48c3d67980eb7 http://cgit.osmocom.org/osmocom-bb/commit/?id=1515045c816a999b9470651acb2eb6e30148e02c commit 1515045c816a999b9470651acb2eb6e30148e02c Author: Vadim Yanitskiy Date: Thu Jul 27 16:53:09 2017 +0600 host/trxcon/scheduler: optionally reset clock counter Change-Id: I4565620fc0c5f64133c2674d2c972fc34245cf32 http://cgit.osmocom.org/osmocom-bb/commit/?id=205d500008411e356e8e56a7f9ff20f0a62efd5f commit 205d500008411e356e8e56a7f9ff20f0a62efd5f Author: Vadim Yanitskiy Date: Thu Jul 27 16:33:38 2017 +0600 host/trxcon/scheduler: implement sched_clck_reset() It's better to have the clock management API inside a single file. Change-Id: I92772f3db404e70fdffd530779613196afec61c9 http://cgit.osmocom.org/osmocom-bb/commit/?id=e466974627f9483434f1314eff3e6f210f8389dd commit e466974627f9483434f1314eff3e6f210f8389dd Author: Vadim Yanitskiy Date: Thu Jul 27 09:21:11 2017 +0600 host/trxcon: get rid of useless TRX_EVENT_RESET_IND Change-Id: I2aa4c000b37f64c351a806711b2d19bf27ef82bd http://cgit.osmocom.org/osmocom-bb/commit/?id=d8f55d3d602342c5476dcde3cdb27d8f9c27e7ed commit d8f55d3d602342c5476dcde3cdb27d8f9c27e7ed Author: Vadim Yanitskiy Date: Thu Jul 27 09:14:20 2017 +0600 host/trxcon: don't flush trx control messages on reset Change-Id: I0851f168adeb012a933c796c4180ef507b1c57ec http://cgit.osmocom.org/osmocom-bb/commit/?id=08cea11b8efe34f45bbebfa3aef2e027450a230f commit 08cea11b8efe34f45bbebfa3aef2e027450a230f Author: Vadim Yanitskiy Date: Thu Jul 27 08:57:13 2017 +0600 host/trxcon: get rid of useless trxcon fsm events Both SCH_EVENT_CLCK_IND and SCH_EVENT_CLCK_LOSS were not handled, moreover there is no purpose to keep them. Change-Id: I8efac459a40f4287e3325890809991d5ef46e9b1 http://cgit.osmocom.org/osmocom-bb/commit/?id=af4acb0d6b6f86353d7769e1cbae846fd5eeb7f0 commit af4acb0d6b6f86353d7769e1cbae846fd5eeb7f0 Author: Vadim Yanitskiy Date: Thu Jul 27 08:53:38 2017 +0600 host/trxcon/l1ctl.c: reset FBSB expire timer on shutdown Change-Id: If3c8a34f0c1105c6acbfe4f9233482a31f6558de http://cgit.osmocom.org/osmocom-bb/commit/?id=5657fb2f69e18f929d5aecaf46eaa64e7c3961fa commit 5657fb2f69e18f929d5aecaf46eaa64e7c3961fa Author: Vadim Yanitskiy Date: Wed Jul 26 20:28:53 2017 +0600 host/trxcon/l1ctl.c: handle L1CTL_PARAM_REQ Change-Id: I5c23520dc0f19147b41ad2e13681bf0a62e9facd http://cgit.osmocom.org/osmocom-bb/commit/?id=8b8ebf6d79e53ae247d8dfaca94e1c2f7710d355 commit 8b8ebf6d79e53ae247d8dfaca94e1c2f7710d355 Author: Vadim Yanitskiy Date: Wed Jul 26 19:46:47 2017 +0600 fake_trx: don't send clock indications to mobile stations Clock indications are only required for BTS, while MS can obtain current frame number from messages on DATA interface. Change-Id: Id2993847a3581cac0d355850ad09ceabc6116d3f http://cgit.osmocom.org/osmocom-bb/commit/?id=324a3aa395ec155689027388d6f4492979244513 commit 324a3aa395ec155689027388d6f4492979244513 Author: Vadim Yanitskiy Date: Wed Jul 26 19:51:44 2017 +0600 host/trxcon/trx_if.c: get rid of CLCK interface Local clock counter can be corrected using frame number values, obtained from burst header on DATA interface. Change-Id: I5a813e3dc1b960831343b8ecb80718291f20e80d http://cgit.osmocom.org/osmocom-bb/commit/?id=b39de2242bb923baa36f2f33e8d48d78c8040df0 commit b39de2242bb923baa36f2f33e8d48d78c8040df0 Author: Vadim Yanitskiy Date: Wed Jul 26 14:30:35 2017 +0600 host/trxcon: split sched_lchan_handlers.c It would be better to have xCCH, SCH and RACH burst handlers in separate files, because as much code we add to a single file, as harder it becomes to read and understand one. Change-Id: I456a60e68b32b792e63dd03ae97159dc101fd4bf http://cgit.osmocom.org/osmocom-bb/commit/?id=139b4d0d330193c0709ae8ad6dc6b5761838c9d4 commit 139b4d0d330193c0709ae8ad6dc6b5761838c9d4 Author: Vadim Yanitskiy Date: Wed Jul 26 13:50:40 2017 +0600 host/trxcon: share trxcon fsm and talloc ctx via trxcon.h Change-Id: I9ef558f84a6dc1c9b8fc394c48e108676fa169f8 http://cgit.osmocom.org/osmocom-bb/commit/?id=d961073b09e2ce6122c7b09166fef9413c62f2af commit d961073b09e2ce6122c7b09166fef9413c62f2af Author: Vadim Yanitskiy Date: Sun Jul 16 17:15:56 2017 +0700 host/trxcon/scheduler: add a reference to GSM 05.02 Change-Id: I067af9c114bcbc5bd74515d5008e21a07fd0167e http://cgit.osmocom.org/osmocom-bb/commit/?id=f1a93f730f8872dfaf24435e830604f0400891ff commit f1a93f730f8872dfaf24435e830604f0400891ff Author: Vadim Yanitskiy Date: Sun Jul 16 17:13:34 2017 +0700 host/trxcon/scheduler: confirm xCCH data sending Change-Id: I40994e7046c25306a0a323910a65e195d2d8fbd0 http://cgit.osmocom.org/osmocom-bb/commit/?id=5e4011dfa7a217efb350b6e8e9ce1b0345ba19f4 commit 5e4011dfa7a217efb350b6e8e9ce1b0345ba19f4 Author: Vadim Yanitskiy Date: Sun Jul 16 16:52:57 2017 +0700 host/trxcon/scheduler: implement TSC selection Change-Id: I004cc71aafe0a26e5141a4b2ffa90063e961be31 http://cgit.osmocom.org/osmocom-bb/commit/?id=00a448c5e8c83efc8d3d7794bf6b15f03d5f9f8a commit 00a448c5e8c83efc8d3d7794bf6b15f03d5f9f8a Author: Vadim Yanitskiy Date: Sun Jul 16 00:30:54 2017 +0700 fake_trx: fix compatibility with Python 3 Change-Id: Idce0c631aa3fcd20092a3773558570e442b2fec8 http://cgit.osmocom.org/osmocom-bb/commit/?id=5ba6e8c21b2eeafc1c9a93f4430fd8c87a068b7e commit 5ba6e8c21b2eeafc1c9a93f4430fd8c87a068b7e Author: Vadim Yanitskiy Date: Sat Jul 15 22:51:12 2017 +0700 host/trxcon/l1ctl.c: handle L1CTL_DATA_REQ Change-Id: Ia72fd3d55c86697ff144446bbae94f76839eb5a1 http://cgit.osmocom.org/osmocom-bb/commit/?id=209b6b3d339eb8758e57d2297adfaea0e811fd9b commit 209b6b3d339eb8758e57d2297adfaea0e811fd9b Author: Vadim Yanitskiy Date: Sat Jul 15 22:46:54 2017 +0700 host/trxcon/scheduler: implement xCCH TX capability Change-Id: I4da4816dcecc55eb9b4d2d6c631967026a5e4f68 http://cgit.osmocom.org/osmocom-bb/commit/?id=55040a29a8eef6adde1a9f6ea5f977672b513814 commit 55040a29a8eef6adde1a9f6ea5f977672b513814 Author: Vadim Yanitskiy Date: Sat Jul 15 15:20:35 2017 +0700 host/trxcon/l1ctl.c: handle L1CTL_DM_{EST,REL}_REQ Change-Id: Ifdf229a6dd3c73ede313d2bfe384032e3887cc3a http://cgit.osmocom.org/osmocom-bb/commit/?id=f7da2a39bb2f86e1de052cd2f6b6ae8e748a93f6 commit f7da2a39bb2f86e1de052cd2f6b6ae8e748a93f6 Author: Vadim Yanitskiy Date: Fri Jul 14 18:33:48 2017 +0700 host/trxcon/scheduler: fix TS index in sched_trx_configure_ts() TS index was not assigned after allocation of a new one. Change-Id: I1b62218f863acf27fb1d1f46b273b345b97d33d8 http://cgit.osmocom.org/osmocom-bb/commit/?id=1720f547d9019b1e33ef4d57c393c3b92e58d214 commit 1720f547d9019b1e33ef4d57c393c3b92e58d214 Author: Vadim Yanitskiy Date: Fri Jul 14 10:46:23 2017 +0700 host/trxcon/l1ctl.c: implement FBSB expire timer Change-Id: I27f96cbe951de164fcecaf19f8305db5e5b20229 http://cgit.osmocom.org/osmocom-bb/commit/?id=9d2055ca9aadf3b92189a5095c38fc176dd6dacb commit 9d2055ca9aadf3b92189a5095c38fc176dd6dacb Author: Vadim Yanitskiy Date: Fri Jul 14 19:15:41 2017 +0700 host/trxcon/l1ctl.c: fix L1CTL_RACH_{REQ,CONF} handling Previously, L1CTL_RACH_REQ / L1CTL_RACH_CONF messages were handled without l1ctl_info_ul / l1ctl_info_dl header, what caused incorrect data parsing. Change-Id: I145d137f2cc7de234965e4fe64d9367ed6ccb999 http://cgit.osmocom.org/osmocom-bb/commit/?id=785d9d24247c82cfd06745fb311c93039e2b0f23 commit 785d9d24247c82cfd06745fb311c93039e2b0f23 Author: Vadim Yanitskiy Date: Fri Jul 14 10:28:26 2017 +0700 host/trxcon/l1ctl.c: fix incomplete msg in l1ctl_tx_fbsb_conf() Previously, all L1CTL_FBSB_CONF messages were sent without required l1ctl_info_dl header, what caused unpredictable behavior on higher layers (L2 & L3). Let's fix it. Change-Id: I8dae597bb4c09df36f80944434ce3624569f2cf8 http://cgit.osmocom.org/osmocom-bb/commit/?id=f2cedcf6972aef4b7231ac78aec2b98111870fb9 commit f2cedcf6972aef4b7231ac78aec2b98111870fb9 Author: Vadim Yanitskiy Date: Fri Jul 14 09:19:22 2017 +0700 fake_trx: implement simple freq. filter Change-Id: Ifbeaebeaf68a88c07a05b672502f503ab7b890f2 http://cgit.osmocom.org/osmocom-bb/commit/?id=b8138c7408caf0a305d6fa4019bf20e7cbfbdc1c commit b8138c7408caf0a305d6fa4019bf20e7cbfbdc1c Author: Vadim Yanitskiy Date: Fri Jul 14 09:18:03 2017 +0700 host/trxcon/scheduler: notify transceiver about TS state Change-Id: I5783066e7c1b01e4ebb28d10b03f3290ff8a0f37 http://cgit.osmocom.org/osmocom-bb/commit/?id=c8c62c18e39faec573d8aaf5525965392a162548 commit c8c62c18e39faec573d8aaf5525965392a162548 Author: Vadim Yanitskiy Date: Fri Jul 14 09:01:30 2017 +0700 fake_trx: handle SETSLOT command from BB Change-Id: I152486377ecd6777dbae7024e5d12cfdbcb17628 http://cgit.osmocom.org/osmocom-bb/commit/?id=03f13c610947333d46ec0206ff45c8d85508f759 commit 03f13c610947333d46ec0206ff45c8d85508f759 Author: Vadim Yanitskiy Date: Fri Jul 14 08:26:24 2017 +0700 host/trxcon/l1ctl.c: handle L1CTL_PM_REQ correctly Change-Id: Ib5a2198f21e747b6169ef141817ef22b241ef9fa http://cgit.osmocom.org/osmocom-bb/commit/?id=32ae64226f90eb5d9c6968185df9e33c612d90d7 commit 32ae64226f90eb5d9c6968185df9e33c612d90d7 Author: Vadim Yanitskiy Date: Fri Jul 14 08:06:07 2017 +0700 fake_trx: implement power measurement emulation This change introduces a new class named FakePM, which is intended to generate pseudo-random power levels for base stations and noise levels inactive frequencies. Also, there is a new command in BB CTRL, which instructs transceiver to perform a power measurement on requested frequency. As we work in virtual Um-interface, a FakePM instance is used to provide some fake power levels. Change-Id: If48c12fd0b1ba10e1cf76559b359e17a1256617d http://cgit.osmocom.org/osmocom-bb/commit/?id=611f222172b33c9c33c428dcbda379c83c7bad03 commit 611f222172b33c9c33c428dcbda379c83c7bad03 Author: Vadim Yanitskiy Date: Fri Jul 14 05:49:48 2017 +0700 fake_trx/ctrl_if.py: allow adding custom params to response Change-Id: I551bb425c25a5c978801d9e1e033b4ba352e259f http://cgit.osmocom.org/osmocom-bb/commit/?id=a11815672dd95176204eb5fff1babc1bd56258ff commit a11815672dd95176204eb5fff1babc1bd56258ff Author: Vadim Yanitskiy Date: Fri Jul 14 06:25:37 2017 +0700 fake_trx/ctrl_cmd.py: print response to stdout Change-Id: Icdbb1802b81eddf42786fafcf96200a60db3cc24 http://cgit.osmocom.org/osmocom-bb/commit/?id=1736fb8f2306e2d911409e3fc5f7d94a9f5d2d69 commit 1736fb8f2306e2d911409e3fc5f7d94a9f5d2d69 Author: Vadim Yanitskiy Date: Fri Jul 14 05:32:19 2017 +0700 fake_trx: fix copy-paste error Change-Id: I9a6b294ad3501aa26d92667a995d08ca3be03da4 http://cgit.osmocom.org/osmocom-bb/commit/?id=acdac2e7889344df3bca582898819148c3d1d50f commit acdac2e7889344df3bca582898819148c3d1d50f Author: Vadim Yanitskiy Date: Fri Jul 14 04:10:41 2017 +0700 host/trxcon/trx_if.c: add power measurement command Change-Id: Ib947b60248cafad4edeb7e49c2bd3a1f81696239 http://cgit.osmocom.org/osmocom-bb/commit/?id=02b2297015add7fe4bdf881dd7b38c763c846afe commit 02b2297015add7fe4bdf881dd7b38c763c846afe Author: Vadim Yanitskiy Date: Fri Jul 14 03:19:13 2017 +0700 host/trxcon/trx_if.c: simplify response matching Previously, we had both length and string matching of request and response. To be able to implement commands with additional params in the future, this change drops the length matching part. Change-Id: Id4c50115f5f1b1da450ff8b8dcfd6ccf572d23f5 http://cgit.osmocom.org/osmocom-bb/commit/?id=cdc084e0a7042819c68f11590cd4ee5f0a300d53 commit cdc084e0a7042819c68f11590cd4ee5f0a300d53 Author: Vadim Yanitskiy Date: Fri Jul 14 01:47:40 2017 +0700 host/trxcon/scheduler: confirm successful RACH requests Change-Id: I079ecebbeeb3843288118fbb55fa520af22859bb http://cgit.osmocom.org/osmocom-bb/commit/?id=13bff3875802ffd20981675ef13ffa099fc4d321 commit 13bff3875802ffd20981675ef13ffa099fc4d321 Author: Vadim Yanitskiy Date: Wed Jul 12 18:46:56 2017 +0700 host/trxcon/l1ctl.c: handle L1CTL_RACH_REQ Change-Id: I4c06bcf987120c6271b6e2ad94454fa69689a03e http://cgit.osmocom.org/osmocom-bb/commit/?id=1d0b3c9f7e31ce1faf3044def61390a516fa3e56 commit 1d0b3c9f7e31ce1faf3044def61390a516fa3e56 Author: Vadim Yanitskiy Date: Fri Jul 14 01:38:48 2017 +0700 host/trxcon/scheduler: implement RACH handler Change-Id: I496dd682549570e37e63e7edcfc83a064c13a57f http://cgit.osmocom.org/osmocom-bb/commit/?id=a2be625b4f90b3d85a97abdf1b93a72bf868716b commit a2be625b4f90b3d85a97abdf1b93a72bf868716b Author: Vadim Yanitskiy Date: Wed Jul 12 18:48:18 2017 +0700 host/trxcon/scheduler: implement TX queue handling Change-Id: I2b7bae53901156524134c4904ea1179268d85601 http://cgit.osmocom.org/osmocom-bb/commit/?id=99b1fcf066b28b71613331a39c88dab5a74f59c2 commit 99b1fcf066b28b71613331a39c88dab5a74f59c2 Author: Vadim Yanitskiy Date: Wed Jul 12 17:54:09 2017 +0700 host/trxcon/scheduler: store BSIC in trx_instance We need to know BSIC value, before sending RACH requests. So, let's store it in trx_instance and update as soon as the first SCH burst is received after L1CTL_FBSB_REQ. Change-Id: I49574c3661f79f3b4941db6c651baebab2665c1b http://cgit.osmocom.org/osmocom-bb/commit/?id=ba829de44980945cc54be387dbfff4ff13604708 commit ba829de44980945cc54be387dbfff4ff13604708 Author: Vadim Yanitskiy Date: Wed Jul 12 17:58:31 2017 +0700 host/trxcon/scheduler: modify trx_lchan_tx_func definition Initially, it was assumed that TX lchan handler will only compose a burst and return a pointer to the buffer. A burst itself could be sent somewhere outside, e.g. by caller. It would be better to send bursts exactly from handler, because in this case it isn't required to have an external buffer. Change-Id: Ic9dcdd366e68cec38c5840ed8f8cdda8236d67c7 http://cgit.osmocom.org/osmocom-bb/commit/?id=d7e489b52c9c487efabf7f8dc0b38f286079453d commit d7e489b52c9c487efabf7f8dc0b38f286079453d Author: Vadim Yanitskiy Date: Wed Jul 12 17:49:43 2017 +0700 host/trxcon/trx_if.c: expose the trx_if_tx_burst() Change-Id: Iebd644879e2e9067a94cb638b4ec5b75f806923f http://cgit.osmocom.org/osmocom-bb/commit/?id=ddfe487727536dbdd74c8cf6a6145a3f30877e4d commit ddfe487727536dbdd74c8cf6a6145a3f30877e4d Author: Vadim Yanitskiy Date: Wed Jul 12 17:48:01 2017 +0700 host/trxcon/trx_if.c: use proper names for burst handlers Change-Id: I3d36e6d80fcf6353379aa308415c306e1a256a7d http://cgit.osmocom.org/osmocom-bb/commit/?id=0cbded72d971d67aea931d0266658d518417b815 commit 0cbded72d971d67aea931d0266658d518417b815 Author: Vadim Yanitskiy Date: Wed Jul 12 17:40:22 2017 +0700 host/trxcon/trx_if.c: fix compatibility with OsmoTRX For some reasons, OsmoTRX sends 158-byte long sequences on DATA interface, where the latest two bytes aren't used. Change-Id: Ie9295e9b0d8956d9e87e2ced8cca9d5e68040f88 http://cgit.osmocom.org/osmocom-bb/commit/?id=07b4268239937a8e90560983cd67d7250d8fac54 commit 07b4268239937a8e90560983cd67d7250d8fac54 Author: Vadim Yanitskiy Date: Wed Jul 12 17:24:16 2017 +0700 fake_trx/burst_fwd.py: append two unused bytes at the end Change-Id: I1d7ed076d93b37699520ee2a31c42c177f966865 http://cgit.osmocom.org/osmocom-bb/commit/?id=663dce62608205c56d2bca4717fd9640753c0dc3 commit 663dce62608205c56d2bca4717fd9640753c0dc3 Author: Vadim Yanitskiy Date: Mon Jul 10 19:39:06 2017 +0700 target/fake_trx: initial release of virtual transceiver This is a set of tools for creating a virtual Um-interface between OsmocomBB and OsmoBTS. It may be extremely useful for testing and development of GSM stack, including both sides (MS and BTS). This software implements OsmoTRX (Osmocom's fork of OpenBTS transceiver) style clock (CLCK), control (CTRL) and data interfaces. So, OsmoBTS source code doesn't require any modifications, while for OsmocomBB you will need to use a new application - trxcon, which can be found in the 'fixeria/sdr_phy' branch until one is merged to master. Brief description of available applications: - fake_trx.py - main application, that allows to connect both OsmocomBB and OsmoBTS without actual RF hardware. Currently only a single MS may work with a single BTS. - clck_gen.py - a peripheral tool aimed to emulate TDMA frame clock generator. Could be used for testing and clock synchronization of multiple applications. It should be noted, that one relays on generic system timer (via Python), so a random clock jitter takes place. - ctrl_cmd.py - another peripheral tool, which could be used for sending CTRL commands directly in manual mode, and also for application fuzzing. Change-Id: Ib1fb80682002ac85a72fa6abef459a4c44f4ab97 http://cgit.osmocom.org/osmocom-bb/commit/?id=63c86222b55bbbc06ecefbd5c73abda2251eca9e commit 63c86222b55bbbc06ecefbd5c73abda2251eca9e Author: Vadim Yanitskiy Date: Mon Jul 10 16:56:43 2017 +0700 host/trxcon: reset scheduler when L1CTL is lost Change-Id: I1fd8a610085c8591a820e784b7122de7b3032d15 http://cgit.osmocom.org/osmocom-bb/commit/?id=89edd506d5a70887c2ae6db191321eda25b82429 commit 89edd506d5a70887c2ae6db191321eda25b82429 Author: Vadim Yanitskiy Date: Sat Jul 8 21:03:22 2017 +0700 host/trxcon/scheduler: drop resolved FIXME label Change-Id: I5e6b30300a457422b2deb10ff4c051c86beb7cd2 http://cgit.osmocom.org/osmocom-bb/commit/?id=1f76070dd0e6941e17bb23977d38621a730ec965 commit 1f76070dd0e6941e17bb23977d38621a730ec965 Author: Vadim Yanitskiy Date: Sat Jul 8 20:53:10 2017 +0700 host/trxcon/l1ctl.c: implement L1CTL_CCCH_MODE_{REQ/CONF} Change-Id: I72f36a99aebcbafd657ceb475fd1c50cc79e2094 http://cgit.osmocom.org/osmocom-bb/commit/?id=30620e720c46cc83d737466aa8bd78a1a45f4116 commit 30620e720c46cc83d737466aa8bd78a1a45f4116 Author: Vadim Yanitskiy Date: Sat Jul 8 20:28:09 2017 +0700 host/trxcon/l1ctl.c: implement L1CTL_FBSB_CONF Change-Id: I33e4702d590a8d67285410fc8f1241bb9d4c50fc http://cgit.osmocom.org/osmocom-bb/commit/?id=fce2e66fbb0098997812bbd76d89737ccbb257eb commit fce2e66fbb0098997812bbd76d89737ccbb257eb Author: Vadim Yanitskiy Date: Sat Jul 8 19:39:14 2017 +0700 host/trxcon/scheduler: fix channel deactivation Change-Id: I7c99b7bd99619084727af290b388f7492ba58531 http://cgit.osmocom.org/osmocom-bb/commit/?id=dd5c09faf65e11a46326407b56e3bf0f9b380e3f commit dd5c09faf65e11a46326407b56e3bf0f9b380e3f Author: Vadim Yanitskiy Date: Sat Jul 8 18:58:51 2017 +0700 host/trxcon: send L1CTL_DATA_IND directly from lchan handler Change-Id: Idfc86a59469c7a0bba1c16177502844e59ed8887 http://cgit.osmocom.org/osmocom-bb/commit/?id=cb1b60a7c1fbdbdf7fb204ecde57dd95e04b26a5 commit cb1b60a7c1fbdbdf7fb204ecde57dd95e04b26a5 Author: Vadim Yanitskiy Date: Sat Jul 8 18:50:14 2017 +0700 host/trxcon: handle L1CTL_RESET_REQ inside l1ctl.c Change-Id: Ie5930dec800885784fb38ce6188c9c969cd2ad4e http://cgit.osmocom.org/osmocom-bb/commit/?id=059d165cd69491a9c03d6ac3f9109f4bf4f10cdc commit 059d165cd69491a9c03d6ac3f9109f4bf4f10cdc Author: Vadim Yanitskiy Date: Sat Jul 8 18:30:56 2017 +0700 host/trxcon: handle L1CTL_FBSB_REQ inside l1ctl.c Change-Id: I5bcf39a20f1c6d3a2472e5e95725c6bb1c77bf5d http://cgit.osmocom.org/osmocom-bb/commit/?id=d102624d2660777f6911fcc4712ba33900726cc2 commit d102624d2660777f6911fcc4712ba33900726cc2 Author: Vadim Yanitskiy Date: Sat Jul 8 18:16:42 2017 +0700 host/trxcon: bind L1CTL link with TRX and vice versa Change-Id: I575f8699bf06fd5e86f7935c6ab3216db5a26ec5 http://cgit.osmocom.org/osmocom-bb/commit/?id=52fd453181ce320cd426fe113b21e16e6b8b9cba commit 52fd453181ce320cd426fe113b21e16e6b8b9cba Author: Vadim Yanitskiy Date: Fri Jul 7 07:11:26 2017 +0700 host/trxcon/scheduler: implement SCH decoding Change-Id: Ic5e7416271d647752cd1aaf90de51fa48286798e http://cgit.osmocom.org/osmocom-bb/commit/?id=6bf0111d387dabe70955a153efbd307fd4e68753 commit 6bf0111d387dabe70955a153efbd307fd4e68753 Author: Vadim Yanitskiy Date: Thu Jul 6 13:17:24 2017 +0700 host/trxcon/scheduler: implement xCCH decoding Change-Id: Ieb71e3727b525e85d161855973f63042366ccb05 http://cgit.osmocom.org/osmocom-bb/commit/?id=b3395a9c0c752184ea538a5750063505a229cbb3 commit b3395a9c0c752184ea538a5750063505a229cbb3 Author: Vadim Yanitskiy Date: Thu Jul 6 11:34:15 2017 +0700 host/trxcon: link trxcon against libosmocoding Change-Id: I9bb45428e6617bd6936d24340e688aef4aeafc8f http://cgit.osmocom.org/osmocom-bb/commit/?id=160a88174786ced00a4e7930dd957782f7fc89c3 commit 160a88174786ced00a4e7930dd957782f7fc89c3 Author: Vadim Yanitskiy Date: Thu Jul 6 13:05:27 2017 +0700 host/trxcon: handle ccch_mode from L1CTL_FBSB_REQ Previously, the content of L1CTL_FBSB_REQ message was only used to obtain a new ARFCN and retune transceiver. Now, since we have working TDMA scheduler, some other params (like ccch_mode) may be used too. Change-Id: Iccabba376d67e091b55a604a2ae87f2aa86362e5 http://cgit.osmocom.org/osmocom-bb/commit/?id=44fa340a66415b1cbc54a40d553ebe72b1d4685e commit 44fa340a66415b1cbc54a40d553ebe72b1d4685e Author: Vadim Yanitskiy Date: Thu Jul 6 11:50:34 2017 +0700 host/trxcon: store arfcn and band in trx_instance Change-Id: I95414ff1033d77f11e231178b7721b70bc45e6df http://cgit.osmocom.org/osmocom-bb/commit/?id=40375003b7e6eeeb34fe047306a5b907af6c1ba6 commit 40375003b7e6eeeb34fe047306a5b907af6c1ba6 Author: Vadim Yanitskiy Date: Tue Jul 4 21:12:25 2017 +0700 host/trxcon/scheduler: handle bursts from TRX interface Change-Id: Iff15daf897f30cb98d4ec4c88b9fc259cb44ea4e http://cgit.osmocom.org/osmocom-bb/commit/?id=8e1553470b79c4571c12efdee4e8816f40d33272 commit 8e1553470b79c4571c12efdee4e8816f40d33272 Author: Vadim Yanitskiy Date: Tue Jul 4 20:55:12 2017 +0700 host/trxcon/scheduler: implement management functions This change introduces some new functions to configure TDMA scheduler. They can be grouped as follows: - Scheduler management functions - sched_trx_init() - sched_trx_reset() - sched_trx_shutdown() - Timeslot management functions - sched_trx_add_ts() - sched_trx_find_ts() - sched_trx_del_ts() - sched_trx_reset_ts() - sched_trx_configure_ts() - Logical channel management functions - sched_trx_activate_lchan() - sched_trx_deactivate_lchan() - sched_trx_find_lchan() Change-Id: I6d0f437a68f0eb4e22bf635bf899b08673571085 http://cgit.osmocom.org/osmocom-bb/commit/?id=ac1531cd92b49353ca5850609d45233c32d139ea commit ac1531cd92b49353ca5850609d45233c32d139ea Author: Vadim Yanitskiy Date: Tue Jul 4 19:38:50 2017 +0700 host/trxcon/scheduler: add basic GSM PHY definitions Change-Id: I9f4faa15d5ca61af3e3fdbb95952ab4e4e0b7a4b http://cgit.osmocom.org/osmocom-bb/commit/?id=2637b084011859c034d6447c789871ac08d2ba34 commit 2637b084011859c034d6447c789871ac08d2ba34 Author: Vadim Yanitskiy Date: Fri Jun 9 20:53:20 2017 +0700 host/trxcon/trx_if.c: handle clock indications Change-Id: I333c1c44578eb62c52d2d059b798dd5feae3e444 http://cgit.osmocom.org/osmocom-bb/commit/?id=a08d66fbaaf983c5fc70af8b47d36bc1e26e938f commit a08d66fbaaf983c5fc70af8b47d36bc1e26e938f Author: Vadim Yanitskiy Date: Fri Jun 9 01:10:05 2017 +0700 host/trxcon/scheduler: add basic clock counter The core of scheduler is a simple clock counter, which relays on system time for now. One was a bit simplified and migrated from OsmoBTS. Due to system time is not an ideal clock source, the counter should be periodically corrected by clock indications from BTS. Change-Id: I27d85bd3e2c8bca3f876f73517027b9fe43c9825 http://cgit.osmocom.org/osmocom-bb/commit/?id=e067050ab0762c053b41b63ecb9be73e185b62c1 commit e067050ab0762c053b41b63ecb9be73e185b62c1 Author: Vadim Yanitskiy Date: Mon Jul 25 00:20:37 2016 +0600 host/trxcon: initial release of L1CTL handlers Now it's possible to handle the following requests from layer23 apps: - L1CTL_FBSB_REQ - L1CTL_PM_REQ - L1CTL_RESET_REQ - L1CTL_ECHO_REQ It should be noted, that the L1CTL_PM_REQ isn't handled correctly yet, due to required task isn't implemented on the TRX side yet. Instead of this, temporary we are sending some fake responses. Change-Id: I343eca3e20922ddd83e06231811200b26da442f3 http://cgit.osmocom.org/osmocom-bb/commit/?id=3b72dbe0ff1255cc1197715ceabeaf5f5afb0f1e commit 3b72dbe0ff1255cc1197715ceabeaf5f5afb0f1e Author: Vadim Yanitskiy Date: Wed May 31 09:28:40 2017 +0700 host/trxcon: integrate osmo-fsm framework This change introduces the following state machines: - trxcon_app_fsm - main application state machine. This state machine handles different events, raised from program modules (such as trx_if.c or l1ctl.c). - l1ctl_link_fsm - L1CTL server state machine. - trx_interface_fsm - TRX interface state machine. The program modules (such as trx_if.c or l1ctl.c) should be as much independent from each other as possible. In other words, one module should not call methods from another, e.g. L1CTL handlers are not able to send any command to transceiver directly. Instead of that, they should use shared event set to notify the main state machine about something. Depending on current state and received event, main state machine 'decides' what to do. This approach would allow to easily reuse the source code almost 'as is' anywhere outside the project. Change-Id: I7ee6fc891abe5f775f5b7ebbf093181a97950dea http://cgit.osmocom.org/osmocom-bb/commit/?id=cb0625cea9bd2a3d775083f0a505347baf913771 commit cb0625cea9bd2a3d775083f0a505347baf913771 Author: Vadim Yanitskiy Date: Sat Jun 3 19:02:20 2017 +0700 host/trxcon/trx_if.c: add ECHO command This command should be used to check transceiver availability. Change-Id: I6af2d5e413ff7ab751cb34e1659742b0f59b6cca http://cgit.osmocom.org/osmocom-bb/commit/?id=a1e379842c09d3b9effe80ad84e4d1d5ddcae92b commit a1e379842c09d3b9effe80ad84e4d1d5ddcae92b Author: Vadim Yanitskiy Date: Thu Jun 8 15:46:44 2017 +0700 host/trxcon: fix NULL-pointer deference Change-Id: Idc036d4ea32b4aa3f4841d39144ef1733414728e http://cgit.osmocom.org/osmocom-bb/commit/?id=1d53baccfafb96a0430c275efd2a9400f87e298a commit 1d53baccfafb96a0430c275efd2a9400f87e298a Author: Vadim Yanitskiy Date: Sun Jul 24 01:40:41 2016 +0600 host/trxcon: initial release of transceiver interface This is the second side of the 'OsmocomBB <-> SDR' bridge. Most of source code taken from the OsmoBTS project. Change-Id: I96fa3ada05d010f31af419a4950fd8ae2b62ef34 http://cgit.osmocom.org/osmocom-bb/commit/?id=e2ddfadc5fec6d4c28c2acfe70cebc25fc15fa5e commit e2ddfadc5fec6d4c28c2acfe70cebc25fc15fa5e Author: Vadim Yanitskiy Date: Fri Jul 22 22:57:50 2016 +0600 host/trxcon: initial release of L1CTL interface There are two sides of the 'OsmocomBB <-> SDR' bridge. One of them is the L1CTL interface, which is used by existing layer23 applications to drive GSM L1. Exactly this interface is provided by the osmocon application, but instead of forwarding messages between both host software and firmware we need to handle incoming messages from layer23 applications, perform some GSM L1 specific conversations (coding, mapping, interleaving, etc.), then finally forward them to transceiver through the scheduler. And vice versa. This code is just a basic implementation of UNIX socket handlers, so currently we can only accept and drop connections from layer23 applications. Change-Id: I58d069bcc7742b42c0bf95e52063933bf2c352ff http://cgit.osmocom.org/osmocom-bb/commit/?id=03265a13ef5110a00e3a8be8a74aeee9d76a9832 commit 03265a13ef5110a00e3a8be8a74aeee9d76a9832 Author: Vadim Yanitskiy Date: Thu Jun 30 00:41:58 2016 +0600 host/trxcon: introduce a new 'trxcon' application This app is similar to the osmocon, but designed to connect L2 & L3 apps with SDR transceiver insted of obsolete Calypso based hardware. Change-Id: Ie3c17f19aad9c26f3c49966a7c96b65911f62369 ----------------------------------------------------------------------- hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sat Dec 9 00:15:01 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 9 Dec 2017 00:15:01 GMT Subject: osmo-ci.git branch master updated. 28564a6977cd60085d67b48b8a08d8ba3848fd6a Message-ID: <201712090015.vB90F1eF087119@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 28564a6977cd60085d67b48b8a08d8ba3848fd6a (commit) from 6655542cec3a2195d228e66ce065a61b496d4324 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=28564a6977cd60085d67b48b8a08d8ba3848fd6a commit 28564a6977cd60085d67b48b8a08d8ba3848fd6a Author: Neels Hofmeyr Date: Sat Dec 9 01:11:01 2017 +0100 jobs: gerrit, master, update-osmo-ci: fix build-discarder section The build-discarder section was silently not working. It needs to be nested below a 'properties' node. Also the names need to be dashed and not camelCased. Change-Id: I9503200a8873e616f9195d4bb1d6163c464b305e ----------------------------------------------------------------------- Summary of changes: jobs/gerrit-verifications.yml | 11 ++++++----- jobs/master-builds.yml | 11 ++++++----- jobs/update-osmo-ci-on-slaves.yml | 7 ++++--- 3 files changed, 16 insertions(+), 13 deletions(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Sat Dec 9 01:26:17 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 9 Dec 2017 01:26:17 GMT Subject: osmo-ci.git branch master updated. 55ea22ede3ae881bfe90dc35120dcabe68c81dfa Message-ID: <201712090126.vB91QHcn020084@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 55ea22ede3ae881bfe90dc35120dcabe68c81dfa (commit) via 3e69d3d7d4ac948e71e7d237ce207a4e671e06b2 (commit) from 28564a6977cd60085d67b48b8a08d8ba3848fd6a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=55ea22ede3ae881bfe90dc35120dcabe68c81dfa commit 55ea22ede3ae881bfe90dc35120dcabe68c81dfa Author: Neels Hofmeyr Date: Sat Dec 9 02:15:15 2017 +0100 jobs: master: drop unused axis a4 Change-Id: I4b9db4077eacca649c679333e24b2eb7338a96e6 http://cgit.osmocom.org/osmo-ci/commit/?id=3e69d3d7d4ac948e71e7d237ce207a4e671e06b2 commit 3e69d3d7d4ac948e71e7d237ce207a4e671e06b2 Author: Neels Hofmeyr Date: Sat Dec 9 02:16:15 2017 +0100 jobs: master: fix post-build trigger of downstream jobs Firstly, we don't have the downstream-ext plugin installed on our jenkins. We want to use the 'trigger' publisher instead. Secondly, since the jobs created here are called master-*, we also want to trigger master-*. master-libosmocore also triggers SIMtrace and xgoldmon, which aren't covered by this jobs config, hence they don't get a master- prefix. Change-Id: If9e8c4b02fce34fddceb4f07bf024210600f6270 ----------------------------------------------------------------------- Summary of changes: jobs/master-builds.yml | 73 ++++++++++---------------------------------------- 1 file changed, 14 insertions(+), 59 deletions(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Sat Dec 9 01:59:20 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 9 Dec 2017 01:59:20 GMT Subject: osmo-ci.git branch master updated. 787a51f51f4b08e7908162178647846219c03e62 Message-ID: <201712090159.vB91xKFK035821@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 787a51f51f4b08e7908162178647846219c03e62 (commit) via 50201fc9e3ce7af715ec2fc521b772de17d66801 (commit) from 55ea22ede3ae881bfe90dc35120dcabe68c81dfa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=787a51f51f4b08e7908162178647846219c03e62 commit 787a51f51f4b08e7908162178647846219c03e62 Author: Pau Espin Pedrol Date: Mon Dec 4 13:42:05 2017 +0100 jobs: Fix osmo-ggsn GTP build option As far as I understand, the variable is populated using the name field. In openggsn build it matches, but it doesn't in osmo-ggsn. Change-Id: Ifb1a630b77a8c2f442e26dbef8e608882e8f9a71 http://cgit.osmocom.org/osmo-ci/commit/?id=50201fc9e3ce7af715ec2fc521b772de17d66801 commit 50201fc9e3ce7af715ec2fc521b772de17d66801 Author: Neels Hofmeyr Date: Sat Dec 9 02:45:04 2017 +0100 jobs: master: drop legacy openggsn (now is osmo-ggsn, also present) Change-Id: I219a988f94b465ac8bb77319735aedbe49707c16 ----------------------------------------------------------------------- Summary of changes: jobs/gerrit-verifications.yml | 2 +- jobs/master-builds.yml | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Sat Dec 9 05:00:58 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 9 Dec 2017 05:00:58 GMT Subject: libosmocore.git branch neels/vty updated. 0.10.2-53-g1f907733 Message-ID: <201712090500.vB950w8E022602@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/vty has been updated discards 2f5da1de44f3bc54bd6267edb00634fd8ea7481e (commit) discards 5e8c555b5f08f13fb2a3fc2180600aef465d73aa (commit) discards cb67201a62e7848538132d38020adab3acfdd1eb (commit) via 1f907733f4b716c6cdc875cb937c19a0227239a9 (commit) via 9ed1f0dad651f75ddb4b3bba45579f8570f851c2 (commit) via 2e8d2147845d2f82a9a36ca2fc1e30f4b68e4def (commit) via 091107cfbc01904a4b080ee04a7a0ca58cc4c680 (commit) via 2093fe9a3d5bcc3b9c787b45d46db7a1b2cca475 (commit) via 03865c92cf747d9212109a89c9712eed7e2f32ca (commit) via 5398d66442700708a20edc2679608f1d14851806 (commit) via 07c6a36c6e4dcf6721bec378797130a083738bd7 (commit) via 3f57ea1d3adb5a1b23a829efd02c1e28636fa10f (commit) via a6a40dcbfd36d40ab71322e75f8b08ea4933594f (commit) via 06dbdf59ebc87f32048748b822d8caa27dbee4a2 (commit) via 18ba26cfab4a07b8f45aeb7f28b4f8faabc6a2e7 (commit) via ad1797e359f95b3a9ff57bfc92217d4f4f96fc95 (commit) via 38b17235339c8d0223f00d3b3a54626c32184f9d (commit) via 37a83405a5ebbaebc02b7ce8fb9c8bf597cd678c (commit) via 33dbecbbeb2368f8f05fff181383f1c3279f0cd3 (commit) via 458a6f59e38f6cc691c72b89cdc9988ba9cf23b3 (commit) via 0176b4a9789dd8cb13313ab8b8664441acd100bf (commit) via 29d489f0818262f94bd253b39e4438bdcba01fc3 (commit) via 7dc8e88d64716831a1553d402571fb7b1ade3d30 (commit) via 19ec7b948322bbc9457a2b22219c93558a6f931e (commit) via b4718fd233a00a950cef1965d13afccd6c6c0e77 (commit) via b214af5360439ebd36f5ae3439acacdaf3055433 (commit) via 52a38ddfde38afcbfa0fd57d1286aaf238dfffcd (commit) via f9b1e5556a43738322b8a566beec7bc93d120fdd (commit) via ebd3cddb4c75b284b0d3345ab81980f8f4b44b62 (commit) via fe1ed39846c6537ebfe19d22500ee2e38587c143 (commit) via e750980d6c89cf7052daa62745366a743badd384 (commit) via 85f5a2cd9c46ffd165f9244b4e219bfc03aa5e0e (commit) via cd325efae564384c74b4af6163303ddc81c7a3c1 (commit) via 0128c78ffe25196f53fbbc0884a9c4587f493224 (commit) via 9541a683780d23b260c5c0f6b9a9572a7ac16a66 (commit) via 568f8e20175a21da4e4537a2f5a4f7fedec8c6d6 (commit) via 10ee73a7b39b2867fde2a827b199f6264149c75c (commit) via 3fad5d782acbd97be1124ccab874741261913429 (commit) via abcd0e37b77529dadfc296cda7aacfe31858d74d (commit) via 9a938ae882a4d21f132291136c92d5311b84d7e2 (commit) via d8e79c7fff7f1b004551589a0eb32026e5cba812 (commit) via dd2456043348cbfb9fb81fd88e33c6864d718cee (commit) via 39720acb069a33dfef77f07044efe89d0327d963 (commit) via 00393e1a042df7d8d5fc59d6443502b6bd82c520 (commit) via b93f60f7cd4bebbe6c26a456ea0b394fcafc731f (commit) via d0682108964fe7928e75e24c450637a62331ad9f (commit) via c30a76b2d49265ba6b7ab9e1d684b507b3bfc5f4 (commit) via e2640ef763e1335d0eec590ceaeaa390428cfd51 (commit) via e08da9757099af3d275c122c9379d46a037eb309 (commit) via 0f7bcb5f17f18682f7f9dc41e2d0fc73c4c08318 (commit) via c0fc7940df40de07320c9b2cdd5525659d16805a (commit) via 4a73d5e84383cf3fe02d730a7b21d393024054e4 (commit) via 858cfecf9d142c5577b755ebc84d3f88375eb726 (commit) via c526dbc24f3ec95771085967b9e300c9f9d4fc1f (commit) via 834e2ac0ead4544c207ed365151c8c898b5a949c (commit) via ed029dfab959bca74bd43d86922727c2047eeb4d (commit) via 69b61fe510dd9357040ad0a9f3a1449d913067a7 (commit) via 74aa0258269296f078e685e21fb08b115567e814 (commit) via 38a49f62760a832dcc15c7a47e1c678402ea02da (commit) via ba1059c173ac8f4845464c4f91d1890898f729a0 (commit) via d9abb0a70869bdf4546d9cd0de39461773a1638f (commit) via 16f989ef91a89a79bfd5a1512e98f3f56f93ad6c (commit) via 229fa070c49cb78c10dfda9e813b3702d9bf6e47 (commit) via faee5dead683b87102240e8a4ff1f1a053869aeb (commit) via 504caac641c299d806b27b815029092fa6ca9b7e (commit) via fa8983d2dd2041aea528cf966bc9f39d791df3f0 (commit) via bcf9f23456b58e4c959d84bb42d325589c3669ee (commit) via b48e82ca9eee93ccd821cd179951837bf7a22d6a (commit) via cbf5cdfe7eb10e6efee16cbd6b5e7b910f8c47a7 (commit) via 296511befc8d5050dc5fe0d8497b4a7acb7ce8c5 (commit) via 04c881207f903f48bd5863bc851b8384a06578de (commit) via a7a5065385be71239d49bb60a690402d3153eb34 (commit) via ae510dc4a743e981b40fc5e1fdb4c109f2425e27 (commit) via 8c4f5457aa185bc9d74b6962aaafdd263ea6af56 (commit) via febe83c4243520ccc64544026d5f496ef945a9aa (commit) via c8ef736370483df6feb761b49fccaa6790b6f8c2 (commit) via 754e6877cccddd0a279659c32fa594b23369dc61 (commit) via a568af25d2a8382265b44c9b2b3a72ca504d2443 (commit) via 37f465e275bea35d36b0763bfaef759792a9031f (commit) via 95308596540b0733a43d9db5dc6ab0c4f5e2d08f (commit) via c513c0f562b193a8e710b904b980bfa9b3d08b56 (commit) via 4ce24c45b9286c3946135f97d6ca6f2d4074526e (commit) via abdd7a28ede091f06325b3e5b8a77fc9130e6ee3 (commit) via e9e9e427b78271941a25a63567fc2ec2bb9e4433 (commit) via 224a6dda02a2fcf11f70ac25abe9c780167649bf (commit) via f0e392ac2dbb44eb42a242353f392d570b5de8e8 (commit) via 0b3db5039d25fca3d15ec3375ede77161257db4a (commit) via 9818664315a514b187719792d77723ad9e18dcdf (commit) via ea66852a62319901dc198ea1dc8cbfbf77217347 (commit) via 1fa8dfbaf42a4341255b3bbef3c8a3c574e8c477 (commit) via 4b45669761234ff23769c4d376b04b3003d4bea9 (commit) via 2d2490ed4eead00f23cc4a34b6a0fb17751f6a8f (commit) via a19c126e7693c3f98cc8f5cd0f010d4fa23d922f (commit) via c5b47cc03200c983981ac4b8de20fb0e26d4f873 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (2f5da1de44f3bc54bd6267edb00634fd8ea7481e) \ N -- N -- N (1f907733f4b716c6cdc875cb937c19a0227239a9) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=1f907733f4b716c6cdc875cb937c19a0227239a9 commit 1f907733f4b716c6cdc875cb937c19a0227239a9 Author: Neels Hofmeyr Date: Sat Dec 9 05:55:23 2017 +0100 logging vty: add 'logging set-log-mask' command to log node So far the set-log-mask is only published on the VIEW and ENABLE nodes. It appears to have been forgotten from the actual log target node where it could be quite useful in config files. The command is like logging set-log-mask mm,1:cc,3:rsl,3 There also is a deprecated alias 'set log mask' without dashes, do not add that one, since it makes no sense to add a deprecated alias to a node where it was never present. Change-Id: Iedd67750539b676271de0e0e9316d4e6f794406a http://cgit.osmocom.org/libosmocore/commit/?id=9ed1f0dad651f75ddb4b3bba45579f8570f851c2 commit 9ed1f0dad651f75ddb4b3bba45579f8570f851c2 Author: Neels Hofmeyr Date: Sat Dec 9 05:54:17 2017 +0100 logging vty: tweak general 'logging' command doc 'logging' is not only for terminals, also for stderr and other log targets. Change-Id: If1ee59c7d1073502259b7d60008206ac3d8e87a3 http://cgit.osmocom.org/libosmocore/commit/?id=2e8d2147845d2f82a9a36ca2fc1e30f4b68e4def commit 2e8d2147845d2f82a9a36ca2fc1e30f4b68e4def Author: Neels Hofmeyr Date: Sat Dec 9 05:53:18 2017 +0100 logging vty: describe 'logging set-log-mask' command, add OSMO_STRINGIFY_VAL() Change-Id: I73ac5873ede858da44e1486d8a5c81da1ed5b19f http://cgit.osmocom.org/libosmocore/commit/?id=091107cfbc01904a4b080ee04a7a0ca58cc4c680 commit 091107cfbc01904a4b080ee04a7a0ca58cc4c680 Author: Neels Hofmeyr Date: Sat Dec 9 05:51:42 2017 +0100 comment: utils: more accurately describe OSMO_STRINGIFY macro Change-Id: I7b057c026f9df90608b7cbd12481ab9e7a41d88c http://cgit.osmocom.org/libosmocore/commit/?id=2093fe9a3d5bcc3b9c787b45d46db7a1b2cca475 commit 2093fe9a3d5bcc3b9c787b45d46db7a1b2cca475 Author: Neels Hofmeyr Date: Sat Dec 9 05:48:43 2017 +0100 vty reference: merge_doc.xsl: do not omit description tag vty_additions.xml files provide s for tags, but for unknown reasons, merge_doc.xsl explicitly omits description tags. Do not omit s so that they show up in the merged document. This will take effect when next building the osmo-gsm-manuals using this file. Change-Id: I418e61705043d4df047d8038c5d61623ba64f2e0 http://cgit.osmocom.org/libosmocore/commit/?id=03865c92cf747d9212109a89c9712eed7e2f32ca commit 03865c92cf747d9212109a89c9712eed7e2f32ca Author: Neels Hofmeyr Date: Sat Dec 9 03:54:32 2017 +0100 vty: set name for VIEW+ENABLE nodes, for VTY reference Change-Id: Iefb8b78094208a1a4c5d70bd6c69a3deca8da54f http://cgit.osmocom.org/libosmocore/commit/?id=5398d66442700708a20edc2679608f1d14851806 commit 5398d66442700708a20edc2679608f1d14851806 Author: Neels Hofmeyr Date: Sun Oct 22 02:31:33 2017 +0200 VTY reference: use node names as section names In 'show online-help' output, add the node names (currently all derived from the prompt) as entry, so that in the osmo-gsm-manuals, each section of node commands gets a title. So far, each section of commands has no name at all, and it is entirely up for guessing which part of the VTY the commands are about. Node section names, e.g. for OsmoHLR, will be like 1 VTY reference 1.4 config 1.5 config-log 1.6 config-line 1.7 config-ctrl 1.8 config-hlr 1.9 config-hlr-gsup Before this patch, all but '1 VTY reference' were plain empty. A better solution would be to list the actual command name that enters the node, and to nest the commands identically to VTY node nesting, but since this information is currently hidden in node command implementations, it is impossible to derive it. So we should actually make the VTY reflect the node nesting structure in its data model, which would resolve both the accurate node name problem as well as produce well-structured output to generate the VTY references from. This patch is a workaround for lack of a more profound fix of the VTY data model. At least it makes the VTY references' sections even remotely useful. Change-Id: Iaf745b2ab3d9b02fc47025a0eba3beb711068bfe http://cgit.osmocom.org/libosmocore/commit/?id=07c6a36c6e4dcf6721bec378797130a083738bd7 commit 07c6a36c6e4dcf6721bec378797130a083738bd7 Author: Neels Hofmeyr Date: Sun Oct 22 02:31:33 2017 +0200 VTY reference: do not list empty nodes In 'show online-help' output, don't list nodes that have no commands (the 'Password' node). Change-Id: Iaf745b2ab3d9b02fc47025a0eba3beb711068bfe http://cgit.osmocom.org/libosmocore/commit/?id=3f57ea1d3adb5a1b23a829efd02c1e28636fa10f commit 3f57ea1d3adb5a1b23a829efd02c1e28636fa10f Author: Neels Hofmeyr Date: Thu Oct 19 02:44:57 2017 +0200 vty XML export: avoid repeating common node commands for each node We use 'show online-help' to generate VTY reference manuals. It is not helpful to include the common node commands on each and every node level, it clutters the actual useful help. Have a separate first section called 'Common Commands', but omit them elsewhere. Change-Id: Ie802eccad80887968b10269ff9c0e9797268e0d4 ----------------------------------------------------------------------- Summary of changes: TODO-RELEASE | 6 +- configure.ac | 19 +- contrib/fsm-to-dot.py | 53 +- contrib/jenkins-arm.sh | 21 +- contrib/jenkins.sh | 26 +- contrib/jenkins_common.sh | 23 +- debian/changelog | 20 + debian/control | 33 +- debian/copyright | 29 +- .../{libosmocore8.install => libosmocore9.install} | 0 .../{libosmoctrl0.install => libosmoctrl1.install} | 0 debian/{libosmogb4.install => libosmogb5.install} | 0 .../{libosmogsm7.install => libosmogsm8.install} | 0 .../{libosmovty3.install => libosmovty4.install} | 0 doc/vty/merge_doc.xsl | 4 +- include/osmocom/core/bitcomp.h | 6 +- include/osmocom/core/bitvec.h | 4 +- include/osmocom/core/counter.h | 2 + include/osmocom/core/gsmtap.h | 1 + include/osmocom/core/logging.h | 20 +- include/osmocom/core/msgb.h | 10 + include/osmocom/core/rate_ctr.h | 2 +- include/osmocom/core/socket.h | 2 + include/osmocom/core/stats.h | 2 +- include/osmocom/core/utils.h | 27 +- include/osmocom/ctrl/control_cmd.h | 3 + include/osmocom/ctrl/control_if.h | 8 + include/osmocom/gprs/gprs_ns.h | 10 +- include/osmocom/gsm/abis_nm.h | 7 + include/osmocom/gsm/gsm0808_utils.h | 12 +- include/osmocom/gsm/gsup.h | 4 +- include/osmocom/gsm/oap.h | 5 +- include/osmocom/gsm/tlv.h | 15 +- include/osmocom/vty/command.h | 4 +- include/osmocom/vty/logging.h | 2 +- include/osmocom/vty/ports.h | 1 + m4/ax_check_simd.m4 | 18 +- src/Makefile.am | 18 +- src/application.c | 8 + src/backtrace.c | 2 + src/bitcomp.c | 5 +- src/bits.c | 2 + src/bitvec.c | 55 +- src/codec/gsm610.c | 2 + src/codec/gsm620.c | 2 + src/codec/gsm660.c | 2 + src/codec/gsm690.c | 2 + src/coding/gsm0503_coding.c | 10 +- src/coding/gsm0503_interleaving.c | 2 + src/coding/gsm0503_mapping.c | 2 + src/coding/gsm0503_parity.c | 2 + src/coding/gsm0503_tables.c | 2 + src/conv.c | 2 + src/conv_acc.c | 26 +- src/conv_acc_generic.c | 2 + src/conv_acc_sse.c | 4 +- src/conv_acc_sse_avx.c | 4 +- src/conv_acc_sse_impl.h | 2 + src/counter.c | 9 + src/crc16.c | 2 + src/crcXXgen.c.tpl | 2 + src/ctrl/Makefile.am | 6 +- src/ctrl/control_cmd.c | 4 + src/ctrl/control_if.c | 149 +- src/ctrl/control_vty.c | 4 +- src/ctrl/fsm_ctrl_commands.c | 6 + src/fsm.c | 24 +- src/gb/Makefile.am | 6 +- src/gb/common_vty.c | 2 + src/gb/gprs_bssgp.c | 18 +- src/gb/gprs_bssgp_bss.c | 2 + src/gb/gprs_bssgp_util.c | 2 + src/gb/gprs_bssgp_vty.c | 2 + src/gb/gprs_ns.c | 117 +- src/gb/gprs_ns_frgre.c | 4 +- src/gb/gprs_ns_vty.c | 65 +- src/gsm/Makefile.am | 11 +- src/gsm/a5.c | 2 + src/gsm/abis_nm.c | 4 +- src/gsm/apn.c | 22 +- src/gsm/auth_comp128v1.c | 2 + src/gsm/auth_comp128v23.c | 2 + src/gsm/auth_core.c | 8 + src/gsm/auth_milenage.c | 2 + src/gsm/comp128.c | 2 + src/gsm/comp128v23.c | 2 + src/gsm/gan.c | 2 + src/gsm/gea.c | 4 +- src/gsm/gprs_cipher_core.c | 6 + src/gsm/gprs_gea.c | 6 +- src/gsm/gprs_rlc.c | 7 + src/gsm/gsm0341.c | 2 + src/gsm/gsm0411_smc.c | 2 + src/gsm/gsm0411_smr.c | 2 + src/gsm/gsm0411_utils.c | 2 + src/gsm/gsm0480.c | 2 + src/gsm/gsm0502.c | 2 + src/gsm/gsm0808.c | 2 + src/gsm/gsm0808_utils.c | 12 +- src/gsm/gsm23003.c | 5 +- src/gsm/gsm48.c | 2 + src/gsm/gsm48_ie.c | 2 + src/gsm/gsm_04_08_gprs.c | 4 +- src/gsm/gsm_utils.c | 23 +- src/gsm/gsup.c | 5 +- src/gsm/ipa.c | 2 + src/gsm/kasumi.c | 3 +- src/gsm/lapd_core.c | 2 + src/gsm/lapdm.c | 5 +- src/gsm/milenage/aes-encblock.c | 2 + src/gsm/milenage/aes-internal-enc.c | 2 + src/gsm/milenage/aes-internal.c | 2 + src/gsm/milenage/aes.h | 2 + src/gsm/milenage/aes_i.h | 2 + src/gsm/milenage/aes_wrap.h | 2 + src/gsm/milenage/milenage.c | 2 + src/gsm/milenage/milenage.h | 2 + src/gsm/oap.c | 5 +- src/gsm/rsl.c | 6 +- src/gsm/rxlev_stat.c | 2 + src/gsm/sysinfo.c | 2 + src/gsm/tlv_parser.c | 5 +- src/gsmtap_util.c | 2 + src/logging.c | 2 + src/logging_gsmtap.c | 2 + src/logging_syslog.c | 2 + src/loggingrb.c | 2 + src/macaddr.c | 2 + src/msgb.c | 50 + src/msgfile.c | 7 +- src/panic.c | 2 + src/plugin.c | 2 + src/prbs.c | 6 +- src/prim.c | 8 +- src/pseudotalloc/pseudotalloc.c | 21 +- src/pseudotalloc/talloc.h | 20 +- src/rate_ctr.c | 121 +- src/rbtree.c | 4 +- src/select.c | 3 + src/sercomm.c | 2 + src/serial.c | 2 + src/signal.c | 2 + src/sim/Makefile.am | 4 +- src/sim/card_fs_isim.c | 2 + src/sim/card_fs_sim.c | 2 + src/sim/card_fs_tetra.c | 2 + src/sim/card_fs_uicc.c | 2 + src/sim/class_tables.c | 2 + src/sim/core.c | 2 + src/sim/reader.c | 2 + src/sim/reader_pcsc.c | 2 + src/socket.c | 55 + src/stat_item.c | 4 +- src/stats.c | 6 +- src/stats_statsd.c | 6 +- src/strrb.c | 2 + src/timer.c | 2 + src/timer_gettimeofday.c | 13 +- src/utils.c | 44 +- src/vty/Makefile.am | 6 +- src/vty/buffer.c | 2 + src/vty/command.c | 12 +- src/vty/fsm_vty.c | 2 + src/vty/logging_vty.c | 16 +- src/vty/stats_vty.c | 11 +- src/vty/talloc_ctx_vty.c | 2 + src/vty/telnet_interface.c | 5 +- src/vty/utils.c | 3 + src/vty/vector.c | 2 + src/vty/vty.c | 3 +- src/write_queue.c | 2 + tests/Makefile.am | 97 +- tests/abis/abis_test.c | 4 +- tests/bits/bitfield_test.c | 164 + tests/bits/bitfield_test.ok | 36 + tests/codec/codec_test.c | 10 +- tests/coding/coding_test.c | 302 +- tests/coding/coding_test.ok | 4171 ++++++++++++++++++++ tests/gb/bssgp_fc_test.c | 43 +- tests/gb/bssgp_fc_tests.ok | 84 + tests/gb/gprs_bssgp_test.c | 4 +- tests/gb/gprs_ns_test.c | 13 +- tests/gb/gprs_ns_test.ok | 120 +- tests/gsm0408/gsm0408_test.c | 1 - tests/gsm0808/gsm0808_test.c | 2 + tests/gsm23003/gsm23003_test.c | 3 +- tests/lapd/lapd_test.c | 13 +- tests/msgb/msgb_test.c | 105 + tests/msgb/msgb_test.ok | 8 + tests/oap/oap_test.c | 4 +- tests/sercomm/sercomm_test.c | 5 + tests/stats/stats_test.c | 47 +- tests/stats/stats_test.ok | 108 +- tests/strrb/strrb_test.c | 2 + tests/testsuite.at | 6 + tests/utils/utils_test.c | 43 + tests/utils/utils_test.ok | 18 + tests/vty/vty_test.c | 8 +- utils/Makefile.am | 5 +- utils/osmo-auc-gen.c | 2 +- 200 files changed, 6319 insertions(+), 765 deletions(-) rename debian/{libosmocore8.install => libosmocore9.install} (100%) rename debian/{libosmoctrl0.install => libosmoctrl1.install} (100%) rename debian/{libosmogb4.install => libosmogb5.install} (100%) rename debian/{libosmogsm7.install => libosmogsm8.install} (100%) rename debian/{libosmovty3.install => libosmovty4.install} (100%) create mode 100644 tests/bits/bitfield_test.c create mode 100644 tests/bits/bitfield_test.ok hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 10 13:23:51 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 13:23:51 GMT Subject: libosmo-sccp.git branch master updated. 0.8.1-25-g9af7028 Message-ID: <201712101323.vBADNpZd037754@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 9af7028ebe72bb5bf47713f11b4e111ed83c0693 (commit) from 081ac9c0292298f7992916d8f1b64faf764d4174 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=9af7028ebe72bb5bf47713f11b4e111ed83c0693 commit 9af7028ebe72bb5bf47713f11b4e111ed83c0693 Author: Harald Welte Date: Sun Dec 10 14:13:33 2017 +0100 sccp_helpers: don't return msgb with l2h set It's a bad idea to use sccp_msgb_alloc() for SCCP User Primitive msgbs. The rationale is quite simple: The SCU msgb's are used for wrapping osmo_prim. The user payload data (e.g. BSSAP) in such primitives is found at msgb->l2h. However, user payload data is optional. So in a SCU primitive without user data, we must have msgb->l2h == NULL. The old behavior resulted in bogus data (actually the sccp_user_prim) to be contained in the DATA section of SCCP messages such as RLSD/RLC. Also, the old implementation of scu_msgb_alloc() discarded the 'name' argument and replaced it with a static "SCU" which was of course another bug. Change-Id: I19cb83302aaa404ab1a2d92e6f2aec43d0380426 Related: OS#2732 ----------------------------------------------------------------------- Summary of changes: src/sccp_helpers.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- SCCP Library From gitosis at osmocom.org Sun Dec 10 13:25:35 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 13:25:35 GMT Subject: libosmocore.git branch master updated. 0.10.2-45-g53aa0f51 Message-ID: <201712101325.vBADPZcc038602@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 53aa0f51b8fffbaaa994b048fd18b63473bf4a79 (commit) from a6a40dcbfd36d40ab71322e75f8b08ea4933594f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=53aa0f51b8fffbaaa994b048fd18b63473bf4a79 commit 53aa0f51b8fffbaaa994b048fd18b63473bf4a79 Author: Holger Hans Peter Freyther Date: Sat Dec 9 13:03:29 2017 +0000 license: Fix the license to GPL This was always intended to be GPL and not AGPL. "kat" did the development as part of an internship paid by me and we agreed to shared copyright. Change-Id: Ied2041ba20c5737bd967dfaa3017edf72a95b31c ----------------------------------------------------------------------- Summary of changes: debian/copyright | 16 +--------------- tests/fr/fr_test.c | 9 +++++---- tests/logging/logging_test.c | 9 +++++---- tests/loggingrb/loggingrb_test.c | 9 +++++---- 4 files changed, 16 insertions(+), 27 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 10 13:34:52 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 13:34:52 GMT Subject: libosmocore.git branch master updated. 0.10.2-51-gdc75b114 Message-ID: <201712101334.vBADYqZR042776@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via dc75b114b4caf2692b145b7b254e2f6cfa627831 (commit) via a73656501a21c42223abdecc4c5df7bbe62c802c (commit) via 3b6815715f119e7c12c710deda6bc57738d46e37 (commit) via 453e37e3c8322cd200a6f803579c55753e866c7f (commit) via f7162771d78efb2d9d81caae0b10801771a39645 (commit) via 69054e28adf4c76371b82a34588e07211d264966 (commit) from 53aa0f51b8fffbaaa994b048fd18b63473bf4a79 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=dc75b114b4caf2692b145b7b254e2f6cfa627831 commit dc75b114b4caf2692b145b7b254e2f6cfa627831 Author: Neels Hofmeyr Date: Sat Dec 9 05:51:42 2017 +0100 comment: utils: more accurately describe OSMO_STRINGIFY macro Change-Id: I7b057c026f9df90608b7cbd12481ab9e7a41d88c http://cgit.osmocom.org/libosmocore/commit/?id=a73656501a21c42223abdecc4c5df7bbe62c802c commit a73656501a21c42223abdecc4c5df7bbe62c802c Author: Neels Hofmeyr Date: Sat Dec 9 05:48:43 2017 +0100 vty reference: merge_doc.xsl: do not omit description tag vty_additions.xml files provide s for tags, but for unknown reasons, merge_doc.xsl explicitly omits description tags. Do not omit s so that they show up in the merged document. This will take effect when next building the osmo-gsm-manuals using this file. Change-Id: I418e61705043d4df047d8038c5d61623ba64f2e0 http://cgit.osmocom.org/libosmocore/commit/?id=3b6815715f119e7c12c710deda6bc57738d46e37 commit 3b6815715f119e7c12c710deda6bc57738d46e37 Author: Neels Hofmeyr Date: Sat Dec 9 03:54:32 2017 +0100 vty: set name for VIEW+ENABLE nodes, for VTY reference This leaves no unnamed chapters in future VTY reference documents. Change-Id: Iefb8b78094208a1a4c5d70bd6c69a3deca8da54f http://cgit.osmocom.org/libosmocore/commit/?id=453e37e3c8322cd200a6f803579c55753e866c7f commit 453e37e3c8322cd200a6f803579c55753e866c7f Author: Neels Hofmeyr Date: Sun Oct 22 02:31:33 2017 +0200 VTY reference: use node names as section names In 'show online-help' output, add the node names (currently all derived from the prompt) as entry, so that in the osmo-gsm-manuals, each section of node commands gets a title. So far, each section of commands has no name at all, and it is entirely up for guessing which part of the VTY the commands are about. Node section names, e.g. for OsmoHLR, will be like 1 VTY reference 1.4 config 1.5 config-log 1.6 config-line 1.7 config-ctrl 1.8 config-hlr 1.9 config-hlr-gsup Before this patch, all but '1 VTY reference' were plain empty. A better solution would be to list the actual command name that enters the node, and to nest the commands identically to VTY node nesting, but since this information is currently hidden in node command implementations, it is impossible to derive it. So we should actually make the VTY reflect the node nesting structure in its data model, which would resolve both the accurate node name problem as well as produce well-structured output to generate the VTY references from. This patch is a workaround for lack of a more profound fix of the VTY data model. At least it makes the VTY references' sections even remotely useful. Change-Id: Iaf745b2ab3d9b02fc47025a0eba3beb711068bfe http://cgit.osmocom.org/libosmocore/commit/?id=f7162771d78efb2d9d81caae0b10801771a39645 commit f7162771d78efb2d9d81caae0b10801771a39645 Author: Neels Hofmeyr Date: Sun Oct 22 02:31:33 2017 +0200 VTY reference: do not list empty nodes In 'show online-help' output, don't list nodes that have no commands (the 'Password' node). Change-Id: I3bd6883a87b8b893e560ceadfffbf41bc380109c http://cgit.osmocom.org/libosmocore/commit/?id=69054e28adf4c76371b82a34588e07211d264966 commit 69054e28adf4c76371b82a34588e07211d264966 Author: Neels Hofmeyr Date: Thu Oct 19 02:44:57 2017 +0200 vty XML export: avoid repeating common node commands for each node We use 'show online-help' to generate VTY reference manuals. It is not helpful to include the common node commands on each and every node level, it clutters the actual useful help. Have a separate first section called 'Common Commands', but omit them elsewhere. Change-Id: Ie802eccad80887968b10269ff9c0e9797268e0d4 ----------------------------------------------------------------------- Summary of changes: doc/vty/merge_doc.xsl | 4 +--- include/osmocom/core/utils.h | 4 +++- src/vty/command.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+), 4 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 10 13:36:18 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 13:36:18 GMT Subject: osmo-gsm-manuals.git branch master updated. 27e07351049725ce81400b2648a29c53ba7de966 Message-ID: <201712101336.vBADaILa043542@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via 27e07351049725ce81400b2648a29c53ba7de966 (commit) via 9c8a8ebb36bb15d2681ac9819509ffa745e496ee (commit) via 92c1a2763d952c7a6f6f420f30ebccfc99966b8c (commit) via 2b9b6e3ef039d7a38a0026b1782a7c5196be6825 (commit) from fd14387de56220daf180b60e3ce6033eabcb51d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=27e07351049725ce81400b2648a29c53ba7de966 commit 27e07351049725ce81400b2648a29c53ba7de966 Author: Neels Hofmeyr Date: Sat Dec 9 04:16:41 2017 +0100 common: vty_additions: use proper node IDs, tweak node descriptions Depends on the ENABLE and VIEW nodes to be named, as in a recent libosmocore patch. Depends: Iefb8b78094208a1a4c5d70bd6c69a3deca8da54f (libosmocore) Change-Id: Ic2f3b18cced72db6fa5bad02ae58c602bb2c0213 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=9c8a8ebb36bb15d2681ac9819509ffa745e496ee commit 9c8a8ebb36bb15d2681ac9819509ffa745e496ee Author: Neels Hofmeyr Date: Sat Dec 9 03:56:37 2017 +0100 OsmoGGSN: fix VTY additions' node IDs Change-Id: I8cd5eb64300151d0de8023ed019568cfdc4fe453 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=92c1a2763d952c7a6f6f420f30ebccfc99966b8c commit 92c1a2763d952c7a6f6f420f30ebccfc99966b8c Author: Neels Hofmeyr Date: Sat Dec 9 03:26:01 2017 +0100 OsmoGGSN vty: update VTY reference Apply VTY reference changes from libosmocore: change node IDs from index numbers to meaningful names from VTY node prompts. Introduce section with common commands, do not repeat the common commands on each child node. Populate section names (so far empty). Add apn / gpdu VTY reference. This is generated using the recent libosmocore vty doc patches that conclude in libosmocore change-id Iedd67750539b676271de0e0e9316d4e6f794406a. Change-Id: Ia269c4bda0aa0b905abcccc75338f5f808e01727 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=2b9b6e3ef039d7a38a0026b1782a7c5196be6825 commit 2b9b6e3ef039d7a38a0026b1782a7c5196be6825 Author: Neels Hofmeyr Date: Sat Dec 9 03:22:34 2017 +0100 OsmoGGSN VTY ref: prep: convert newlines to unix To omit whitespace changes in an upcoming patch that updates the VTY reference and will use '\n' line breaks, convert line breaks from '\r\n' to '\n' without any other changes. Change-Id: Id0d1a3a82c3d670cbb041884554b5d79fdfb0f28 ----------------------------------------------------------------------- Summary of changes: OsmoGGSN/vty/ggsn_vty_additions.xml | 16 +- OsmoGGSN/vty/ggsn_vty_reference.xml | 2685 ++++++++++++++++------------------- common/vty_additions.xml | 52 +- 3 files changed, 1244 insertions(+), 1509 deletions(-) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Sun Dec 10 14:05:52 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:05:52 GMT Subject: osmo-bts.git branch master updated. 0.7.0-25-g62b575d Message-ID: <201712101405.vBAE5qBN058718@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 62b575db671f2ae1856a058611f1b1304e5cad68 (commit) from 28cb32a74bee69f992f8b19babcae50a571de089 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=62b575db671f2ae1856a058611f1b1304e5cad68 commit 62b575db671f2ae1856a058611f1b1304e5cad68 Author: Pau Espin Pedrol Date: Fri Dec 8 18:32:32 2017 +0100 bts-trx: trx_ctrl_cmd: Simplify var assignment logic Change-Id: I9250e3003cff24035440bbba3e1171650dc83209 ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-trx/trx_if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Dec 10 14:08:10 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:08:10 GMT Subject: libosmocore.git branch master updated. 0.10.2-52-ga99e1101 Message-ID: <201712101408.vBAE8AAH059860@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via a99e110106cb1d2a7b25d74585e704c1bd73db76 (commit) from dc75b114b4caf2692b145b7b254e2f6cfa627831 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a99e110106cb1d2a7b25d74585e704c1bd73db76 commit a99e110106cb1d2a7b25d74585e704c1bd73db76 Author: Pau Espin Pedrol Date: Fri Dec 8 14:30:47 2017 +0100 cosmetic: Fix trailing whitespace Change-Id: I0c7a414789f8ce6516369327430f71164e2cbd94 ----------------------------------------------------------------------- Summary of changes: src/gsm/lapd_core.c | 12 ++++++------ src/gsm/lapdm.c | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 10 14:21:03 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:21:03 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1887-g2cac7e8c Message-ID: <201712101421.vBAEL3bW065965@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via 2cac7e8ceffc8e7d4667b2f9f7477364b80716d0 (commit) from 238df986b9c705392898f74271c3258c16ffe927 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=2cac7e8ceffc8e7d4667b2f9f7477364b80716d0 commit 2cac7e8ceffc8e7d4667b2f9f7477364b80716d0 Author: Craig Comstock Date: Thu Dec 7 08:44:19 2017 +0700 target/firmware: fix Mediatek firmware compilation The existing Makefile.mtk isn't compatible with the current Makefile scheme, so nothing would happen when it was called. This change updates the Makefile.mtk, so the Mediatek firmware can be successfully compiled again. Change-Id: Iecd619ed862f4d825095292ffde50544e647f6ff ----------------------------------------------------------------------- Summary of changes: src/target/firmware/Makefile.mtk | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sun Dec 10 14:21:45 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:21:45 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-13-g39eb95f Message-ID: <201712101421.vBAELjlT066234@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 39eb95f1307895cbd67d860f15931f66fd384aca (commit) from cea806e5b9bf7f6c4bdd15520c5914f320fe92f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=39eb95f1307895cbd67d860f15931f66fd384aca commit 39eb95f1307895cbd67d860f15931f66fd384aca Author: Max Date: Wed Dec 6 13:13:34 2017 +0100 vty: print class and TBFs for each MS It's handy for troubleshooting to get quick overview of per-MS TBF allocations and MS [EGPRS] classes. Change-Id: Ie79c20f86da6db4565654b0f5856f4fddd83ef96 ----------------------------------------------------------------------- Summary of changes: src/pcu_vty_functions.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Sun Dec 10 14:30:54 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:30:54 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-18-gaccb780 Message-ID: <201712101430.vBAEUsnE070325@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via accb78000b6161d5f76eae24e625c01533001b89 (commit) from b593969dd790722935949191ef06226141b9d9fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=accb78000b6161d5f76eae24e625c01533001b89 commit accb78000b6161d5f76eae24e625c01533001b89 Author: Neels Hofmeyr Date: Mon Dec 4 15:24:32 2017 +0100 osmo-hnbgw: don't configure specific local IP address for STP connection It's not necessary to set a local IP to connect to OsmoSTP with, 'any' is as good as any. Related: OS#2663 Change-Id: If5d0a1500de5e2c4b80acf025761d0264a8a51a0 ----------------------------------------------------------------------- Summary of changes: src/hnbgw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Sun Dec 10 14:31:28 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:31:28 GMT Subject: libosmocore.git branch master updated. 0.10.2-53-g893979cb Message-ID: <201712101431.vBAEVSiF070677@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 893979cb08848aed23cc542ca73db8ce268143aa (commit) from a99e110106cb1d2a7b25d74585e704c1bd73db76 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=893979cb08848aed23cc542ca73db8ce268143aa commit 893979cb08848aed23cc542ca73db8ce268143aa Author: Jean-Francois Dionne Date: Thu Mar 2 10:45:53 2017 -0500 Fix LAPD UA msgb memory leak. Change-Id: Ia4f0606810e00aa6f1779d11893e4acc01976f9a ----------------------------------------------------------------------- Summary of changes: src/gsm/lapd_core.c | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 10 14:42:44 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 14:42:44 GMT Subject: osmo-bts.git branch master updated. 0.7.0-26-g4b4c2ec Message-ID: <201712101442.vBAEgiIR075790@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 4b4c2ec4b324b94b0a4f6b4c36a68bfc60bfce3d (commit) from 62b575db671f2ae1856a058611f1b1304e5cad68 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=4b4c2ec4b324b94b0a4f6b4c36a68bfc60bfce3d commit 4b4c2ec4b324b94b0a4f6b4c36a68bfc60bfce3d Author: Pau Espin Pedrol Date: Fri Dec 8 18:34:52 2017 +0100 bts-trx: Avoid enqueueing consecutive duplicate messages to TRX While debugging other protocol/timing issues between osmobts-trx and osmo-trx, I found that sometimes two consecutives "POWER OFF" commands are enqueued and sent to osmo-trx. There's no point in doing so, as the write queue already maintains state and retries the command until a RSP is received, then goes for the next one. With this change we hence improve timing response as we don't need to wait for the second command to be processed, and on top we get cleaner logs and simplified states which are easier to debug. Change-Id: Ib6a5e7bfac8bc5e1b372da6a1f801c07a3d5ebb7 ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-trx/trx_if.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Dec 10 15:31:26 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 15:31:26 GMT Subject: libosmocore.git branch master updated. 0.10.2-54-g9dd3bf0c Message-ID: <201712101531.vBAFVQWt097286@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 9dd3bf0cb4e780b54772f4abe1e2966b09f99301 (commit) from 893979cb08848aed23cc542ca73db8ce268143aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=9dd3bf0cb4e780b54772f4abe1e2966b09f99301 commit 9dd3bf0cb4e780b54772f4abe1e2966b09f99301 Author: Pau Espin Pedrol Date: Mon Feb 29 08:49:22 2016 -0500 Fix malformed Abis/RSL messages with extra L3 Information field Some Abis/RSL messages such as "Release Indication" contained 3 extra bytes from an L3 Information header which should not be there according to specs in GSM 08.58 (section 8.3 "Radio link layer management messages"). Other RSL messages were affected by the same issue, except for "Establish Indication", which had already a workaround in send_rslms_dlsap. This commit fixes the issue in a generic way, removes the "Establish Indication" and fixes the test accounting for the bug, as it otherwise fails after applying the changes. Fixes: OS#1635, OS#2336 Change-Id: Ibb116214e8b1798d65a8b0917150496a3c14f344 ----------------------------------------------------------------------- Summary of changes: src/gsm/lapd_core.c | 4 +--- src/gsm/lapdm.c | 5 ----- tests/lapd/lapd_test.c | 8 +------- tests/lapd/lapd_test.ok | 2 +- 4 files changed, 3 insertions(+), 16 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 10 21:58:43 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 21:58:43 GMT Subject: libosmo-sccp.git branch master updated. 0.8.1-26-g6cd8d12 Message-ID: <201712102158.vBALwhWY064860@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 6cd8d1243711f4de2f1314c7b87b972572cdec4e (commit) from 9af7028ebe72bb5bf47713f11b4e111ed83c0693 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=6cd8d1243711f4de2f1314c7b87b972572cdec4e commit 6cd8d1243711f4de2f1314c7b87b972572cdec4e Author: Harald Welte Date: Sun Dec 10 22:35:08 2017 +0100 Allocate SCCP user primitives with headroom In I19cb83302aaa404ab1a2d92e6f2aec43d0380426 I set the headroom of msgb's for SCCP User primitives to zero, assuming that we wouldn't need any headroom in those primitives. According to pespin, osmo-msc however needs this headroom: DLSCCP <002e> sccp_user.c:156 Delivering N-CONNECT.indication to SCCP User 'OsmoMSC-A' msgb(0xadfba0): Not enough headroom msgb_push (0 < 264) So let's make sure the new SCCP User primitives are allocated with the same headroom, just like before I19cb83302aaa404ab1a2d92e6f2aec43d0380426. Change-Id: I92d7648f8ffd034341e2f12aa79dd3d16ec3a98d ----------------------------------------------------------------------- Summary of changes: src/sccp_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- SCCP Library From gitosis at osmocom.org Sun Dec 10 21:59:42 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 10 Dec 2017 21:59:42 GMT Subject: osmo-bts.git branch master updated. 0.7.0-27-g33942ed Message-ID: <201712102159.vBALxgvg065367@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 33942ed156413fc0cf69df0fbefccab95d08984d (commit) from 4b4c2ec4b324b94b0a4f6b4c36a68bfc60bfce3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=33942ed156413fc0cf69df0fbefccab95d08984d commit 33942ed156413fc0cf69df0fbefccab95d08984d Author: Philipp Maier Date: Wed Dec 6 14:37:33 2017 +0100 cosmetic: tests/Makefile.am: remove excess whitespace Change-Id: I7090d46ae72183014e6c74d6ddb240af8d66e0b4 ----------------------------------------------------------------------- Summary of changes: tests/Makefile.am | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Mon Dec 11 12:47:13 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 11 Dec 2017 12:47:13 GMT Subject: osmo-bts.git branch master updated. 0.7.0-28-g4848c2c Message-ID: <201712111247.vBBClD88064657@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 4848c2c4450e15360de5e4b27dc41c757ffc57ae (commit) from 33942ed156413fc0cf69df0fbefccab95d08984d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=4848c2c4450e15360de5e4b27dc41c757ffc57ae commit 4848c2c4450e15360de5e4b27dc41c757ffc57ae Author: Pau Espin Pedrol Date: Mon Dec 11 13:13:28 2017 +0100 Fix malformed Resource Indication packet Wireshark was showing a Malformed packet alert, and further ivnestigation showed that "Resource Information" TLV was missing in the packet. See GSM 08.58 sections 8.6.1 and 9.3.21 for more information. Indicating interference level is not yet implemented, but at least now we avoid sending a malformed packet. Patch has been validated against a running setup with wireshark in my local PC. Related: OS#2735 Change-Id: Ie97170811aaf8a089febfa20380ab48ea174056a ----------------------------------------------------------------------- Summary of changes: src/common/rsl.c | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Mon Dec 11 12:57:33 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 11 Dec 2017 12:57:33 GMT Subject: osmo-bts.git branch master updated. 0.7.0-30-g8f12047 Message-ID: <201712111257.vBBCvXbu069083@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 8f12047157b55fe3997f686efec26f2a54ea3242 (commit) via 4a43618332b2bc988f296adeb4470281c88aacc3 (commit) from 4848c2c4450e15360de5e4b27dc41c757ffc57ae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=8f12047157b55fe3997f686efec26f2a54ea3242 commit 8f12047157b55fe3997f686efec26f2a54ea3242 Author: Philipp Maier Date: Wed Dec 6 17:15:31 2017 +0100 cosmetic: tests/agch: remove unused var "static_ilv" remove unused const variable "static_ilv" from unit test "agch" Change-Id: Ie724e2e5875020aa835b4cd57ab96966aee283e1 http://cgit.osmocom.org/osmo-bts/commit/?id=4a43618332b2bc988f296adeb4470281c88aacc3 commit 4a43618332b2bc988f296adeb4470281c88aacc3 Author: Philipp Maier Date: Wed Dec 6 17:15:00 2017 +0100 cosmetic: tests/power: remove unused var "ret" remove unused variable "ret" in unit test "power" Change-Id: Ied484e3e2d3006eb0f03516ceaed3e0e802d51e4 ----------------------------------------------------------------------- Summary of changes: tests/agch/agch_test.c | 4 ---- tests/power/power_test.c | 1 - 2 files changed, 5 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Mon Dec 11 12:57:56 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 11 Dec 2017 12:57:56 GMT Subject: libosmocore.git branch master updated. 0.10.2-55-g32e5641d Message-ID: <201712111257.vBBCvums069232@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 32e5641dbbfd91b650a9ec8cf62d28fd22109e9e (commit) from 9dd3bf0cb4e780b54772f4abe1e2966b09f99301 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=32e5641dbbfd91b650a9ec8cf62d28fd22109e9e commit 32e5641dbbfd91b650a9ec8cf62d28fd22109e9e Author: Max Date: Mon Oct 16 14:58:00 2017 +0200 Add functions for extended RACH coding Add support for extended RACH (11 bit) according 3GPP TS 45.003 ??5.3.2: * convolutional code with puncturing * encoding/decoding routines * corresponding tests Change-Id: I85a34a82d5cd39a594ee89d91a2338226066ab5d Related: OS#1548 ----------------------------------------------------------------------- Summary of changes: TODO-RELEASE | 1 + include/osmocom/coding/gsm0503_coding.h | 7 +- src/coding/gsm0503_coding.c | 80 +- src/coding/libosmocoding.map | 2 + src/gsm/libosmogsm.map | 1 + tests/coding/coding_test.c | 41 +- tests/coding/coding_test.ok | 30720 ++++++++++++++++++++++++++++++ tests/conv/conv_gsm0503_test.ok | 8 + utils/conv_codes_gsm.py | 11 +- 9 files changed, 30850 insertions(+), 21 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Mon Dec 11 15:51:16 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 11 Dec 2017 15:51:16 GMT Subject: meta-telephony.git branch laforge/nightly updated. e89c42dc4261edcfacf7f12c498fdb285a5063ab Message-ID: <201712111551.vBBFpGG5047367@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, laforge/nightly has been updated discards 7ac5c4b0a469b0d73889294355a4b0168ef653fc (commit) discards 4aa6d87359a2d0edaaa103115874e7a3fce21ee8 (commit) discards 84ca86653d2586f6a60156127d8241db0c5256ee (commit) discards 147c488e013b75c6898229bbad639d1fe83e1a60 (commit) discards 5b72b0f3b34751fc8411f4363b9bb9924ba7de43 (commit) discards 1c588d0c856c88293a16dfbeda1e38860359c7fe (commit) discards a5e192406e7aa44101b64f9cfb6105b39b23abbd (commit) via e89c42dc4261edcfacf7f12c498fdb285a5063ab (commit) via 1dfd9cdad0798f478a4482bc2ab106a05648b4e8 (commit) via c93542b049089466e013c941dc3f1ad2f3b756ca (commit) via c0208ebe70115a0ae6597ea7397a01c4de77576c (commit) via 26dcbe02691cf4bfea7dc2d3c7e77b2633d3526a (commit) via 848f7f56a2eed842faa5d173dcbf1991bf2d16a3 (commit) via 1c92a0cf1ef922016c1b8c178f4d3a7554af8902 (commit) via 95f1531408a8f5521cf4eb1a60dfd29a5fac0fdb (commit) via 2e57eb7866433f5cdfb4458ef23d47e03539d0bf (commit) via 71ac7c0017548daceeb511c8ae231a63a46018f9 (commit) via cbac8369db1767aa3527a75daf859ca9b26d51f7 (commit) via 127bed3ceb41015d8fd36779689ab6d799f773f6 (commit) via 9a3c3d32f55f4522772904f1eea0a01e822fcd48 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (7ac5c4b0a469b0d73889294355a4b0168ef653fc) \ N -- N -- N (e89c42dc4261edcfacf7f12c498fdb285a5063ab) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=e89c42dc4261edcfacf7f12c498fdb285a5063ab commit e89c42dc4261edcfacf7f12c498fdb285a5063ab Author: Pau Espin Pedrol Date: Mon Dec 4 17:50:11 2017 +0100 osmo-sgsn: libosmo-sccp dep is only needed if building with iu support Change-Id: I97e4e37219f584f0b9d42e21ff9464e2d7143e13 http://cgit.osmocom.org/meta-telephony/commit/?id=1dfd9cdad0798f478a4482bc2ab106a05648b4e8 commit 1dfd9cdad0798f478a4482bc2ab106a05648b4e8 Author: Pau Espin Pedrol Date: Fri Nov 10 12:08:36 2017 +0100 osmo-mgw: Split packages and install osmo-mgw systemd service Change-Id: I1b902842cf8766af1e58de76e46786213d222389 http://cgit.osmocom.org/meta-telephony/commit/?id=c93542b049089466e013c941dc3f1ad2f3b756ca commit c93542b049089466e013c941dc3f1ad2f3b756ca Author: Harald Welte Date: Fri Nov 3 09:52:47 2017 +0100 libosmocore: depend on gnutls for compilation now Change-Id: Ic349f551261715fcc2e3e0b725fd94deaedaa682 http://cgit.osmocom.org/meta-telephony/commit/?id=c0208ebe70115a0ae6597ea7397a01c4de77576c commit c0208ebe70115a0ae6597ea7397a01c4de77576c Author: Pau Espin Pedrol Date: Wed Nov 1 14:50:28 2017 +0100 Remove libsmpp34_1.12.bb and use _git instead Same as we do for other osmocom recipes. Change-Id: I1dcebbb3170654e15d1bb9644d630b462fd22fbd http://cgit.osmocom.org/meta-telephony/commit/?id=26dcbe02691cf4bfea7dc2d3c7e77b2633d3526a commit 26dcbe02691cf4bfea7dc2d3c7e77b2633d3526a Author: Pau Espin Pedrol Date: Wed Nov 1 14:36:55 2017 +0100 Update PV for osmocom recipes Change-Id: I2d5933527d333825e92c9748004adfb3e4b3a078 http://cgit.osmocom.org/meta-telephony/commit/?id=848f7f56a2eed842faa5d173dcbf1991bf2d16a3 commit 848f7f56a2eed842faa5d173dcbf1991bf2d16a3 Author: Harald Welte Date: Fri Oct 27 00:09:56 2017 +0200 openbsc.git: Upstream binary now named osmo-bsc-sccplite In Change-Id If10d1599b62d010726336134091a4e855c380d93, upstream osmocom.git has renamed osmo-bsc (and related config files, etc) to osmo-bsc-sccplite, so we don't have to rename it in the recipe anymore. Change-Id: I7e3bf1d6186fb32f4d671cbf84cad195d2776190 http://cgit.osmocom.org/meta-telephony/commit/?id=1c92a0cf1ef922016c1b8c178f4d3a7554af8902 commit 1c92a0cf1ef922016c1b8c178f4d3a7554af8902 Author: Harald Welte Date: Thu Jun 23 08:51:51 2016 +0200 set up osmocom recipes with AUTOREV to track git master This is for the upcoming nightly builds, where all our osmo* recipes are going to track current master of their respective upstream git repository. Change-Id: Idda98bdfa07c16aee1955fa63373b358bb754c90 ----------------------------------------------------------------------- Summary of changes: .../ortp/files/0001-fix-unused-variables.patch | 75 ---------------------- .../ortp/files/compile-fixes-newer-gcc.diff | 13 ---- recipes-misc/ortp/ortp.inc | 4 +- recipes-misc/ortp/ortp_0.16.5.bb | 9 --- recipes-misc/ortp/ortp_0.25.0.bb | 1 - .../libosmo-abis/files/fix-rsl-connect.patch | 21 ------ recipes-osmocom/libosmo-abis/libosmo-abis.inc | 9 ++- recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb | 1 + recipes-osmocom/osmo-bsc/osmo-bsc.inc | 5 +- recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb | 2 + recipes-osmocom/osmo-hlr/osmo-hlr.inc | 6 +- recipes-osmocom/osmo-iuh/osmo-iuh.inc | 3 +- recipes-osmocom/osmo-mgw/osmo-mgw.inc | 3 + recipes-osmocom/osmo-msc/osmo-msc.inc | 3 +- recipes-osmocom/osmo-sgsn/osmo-sgsn.inc | 7 +- 15 files changed, 35 insertions(+), 127 deletions(-) delete mode 100644 recipes-misc/ortp/files/0001-fix-unused-variables.patch delete mode 100644 recipes-misc/ortp/files/compile-fixes-newer-gcc.diff delete mode 100644 recipes-misc/ortp/ortp_0.16.5.bb delete mode 100644 recipes-osmocom/libosmo-abis/files/fix-rsl-connect.patch hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 12 02:22:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 02:22:06 GMT Subject: libosmocore.git branch neels/vty updated. 0.10.2-57-g28f61d5c Message-ID: <201712120222.vBC2M6Ns020986@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/vty has been updated discards 1f907733f4b716c6cdc875cb937c19a0227239a9 (commit) discards 9ed1f0dad651f75ddb4b3bba45579f8570f851c2 (commit) discards 2e8d2147845d2f82a9a36ca2fc1e30f4b68e4def (commit) discards 091107cfbc01904a4b080ee04a7a0ca58cc4c680 (commit) discards 2093fe9a3d5bcc3b9c787b45d46db7a1b2cca475 (commit) discards 03865c92cf747d9212109a89c9712eed7e2f32ca (commit) discards 5398d66442700708a20edc2679608f1d14851806 (commit) discards 07c6a36c6e4dcf6721bec378797130a083738bd7 (commit) discards 3f57ea1d3adb5a1b23a829efd02c1e28636fa10f (commit) via 28f61d5c5fdd21b25fa2ec346852463c19fa34fe (commit) via 3026f917182b5715f0064c080a58fd3e20495b0f (commit) via 32e5641dbbfd91b650a9ec8cf62d28fd22109e9e (commit) via 9dd3bf0cb4e780b54772f4abe1e2966b09f99301 (commit) via 893979cb08848aed23cc542ca73db8ce268143aa (commit) via a99e110106cb1d2a7b25d74585e704c1bd73db76 (commit) via dc75b114b4caf2692b145b7b254e2f6cfa627831 (commit) via a73656501a21c42223abdecc4c5df7bbe62c802c (commit) via 3b6815715f119e7c12c710deda6bc57738d46e37 (commit) via 453e37e3c8322cd200a6f803579c55753e866c7f (commit) via f7162771d78efb2d9d81caae0b10801771a39645 (commit) via 69054e28adf4c76371b82a34588e07211d264966 (commit) via 53aa0f51b8fffbaaa994b048fd18b63473bf4a79 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (1f907733f4b716c6cdc875cb937c19a0227239a9) \ N -- N -- N (28f61d5c5fdd21b25fa2ec346852463c19fa34fe) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=28f61d5c5fdd21b25fa2ec346852463c19fa34fe commit 28f61d5c5fdd21b25fa2ec346852463c19fa34fe Author: Neels Hofmeyr Date: Sat Dec 9 05:54:17 2017 +0100 logging vty: tweak general 'logging' command doc 'logging' is not only for terminals, also for stderr and other log targets. Change-Id: If1ee59c7d1073502259b7d60008206ac3d8e87a3 http://cgit.osmocom.org/libosmocore/commit/?id=3026f917182b5715f0064c080a58fd3e20495b0f commit 3026f917182b5715f0064c080a58fd3e20495b0f Author: Neels Hofmeyr Date: Sat Dec 9 05:53:18 2017 +0100 logging vty: describe 'logging set-log-mask' command, add OSMO_STRINGIFY_VAL() Change-Id: I73ac5873ede858da44e1486d8a5c81da1ed5b19f ----------------------------------------------------------------------- Summary of changes: TODO-RELEASE | 1 + debian/copyright | 16 +- include/osmocom/coding/gsm0503_coding.h | 7 +- src/coding/gsm0503_coding.c | 80 +- src/coding/libosmocoding.map | 2 + src/gsm/lapd_core.c | 19 +- src/gsm/lapdm.c | 9 +- src/gsm/libosmogsm.map | 1 + src/vty/logging_vty.c | 1 - tests/coding/coding_test.c | 41 +- tests/coding/coding_test.ok | 30720 ++++++++++++++++++++++++++++++ tests/conv/conv_gsm0503_test.ok | 8 + tests/fr/fr_test.c | 9 +- tests/lapd/lapd_test.c | 8 +- tests/lapd/lapd_test.ok | 2 +- tests/logging/logging_test.c | 9 +- tests/loggingrb/loggingrb_test.c | 9 +- utils/conv_codes_gsm.py | 11 +- 18 files changed, 30880 insertions(+), 73 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Tue Dec 12 11:27:45 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 11:27:45 GMT Subject: meta-telephony.git branch laforge/nightly updated. 8172c8ed924e2e6e4c5e417d857b602e53038105 Message-ID: <201712121127.vBCBRjD3039357@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, laforge/nightly has been updated via 8172c8ed924e2e6e4c5e417d857b602e53038105 (commit) from e89c42dc4261edcfacf7f12c498fdb285a5063ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=8172c8ed924e2e6e4c5e417d857b602e53038105 commit 8172c8ed924e2e6e4c5e417d857b602e53038105 Author: Pau Espin Pedrol Date: Tue Dec 12 12:21:39 2017 +0100 sdk: Add missing libosmotrau-dev after split from libosmo-abis After splitting libosmotrau from libosmo-abis in 127bed3ceb41015d8fd36779689ab6d799f773f6, related libosmotrau dev were moved to its own package, which was not added to the include list for the SDK. As a result, somo-bts cannot be built anymore as it fails to find libosmotrau pkgconfig file, headers and shared object file. Change-Id: I42f3fa2ad82bfadb48f22167e42a08974fef16ab ----------------------------------------------------------------------- Summary of changes: .../packagegroup/packagegroup-core-standalone-osmo-sdk-target.bb | 2 +- recipes-osmocom/packagegroup/packagegroup-sdk-osmo.inc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 12 11:29:54 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 11:29:54 GMT Subject: osmo-python-tests.git branch master updated. 1aa0fb4910c7a06649a9dfb0bd839faeb6fe6808 Message-ID: <201712121129.vBCBTsC7041451@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 1aa0fb4910c7a06649a9dfb0bd839faeb6fe6808 (commit) from 48b951a7a6057f8072dbb17a5315a518d5d5112e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=1aa0fb4910c7a06649a9dfb0bd839faeb6fe6808 commit 1aa0fb4910c7a06649a9dfb0bd839faeb6fe6808 Author: Pau Espin Pedrol Date: Mon Dec 11 12:15:59 2017 +0100 osmo_ctrl.py: Set shebang to use python v2 Nowadays bin/python usually points to python3, and this script is written in python2, which means if run directly from terminal it will fail with some print syntax errors. Change-Id: I24a568fc2c3e69e7c9f7b9729bd023fe1f0691c7 ----------------------------------------------------------------------- Summary of changes: osmopy/osmo_ctrl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Tue Dec 12 11:30:04 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 11:30:04 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-39-g2d6a69e Message-ID: <201712121130.vBCBU4Mn042056@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 (commit) from 4f0343233b83337afa1e1dfb4bcf9d076ecd4be2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 commit 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 Author: Pau Espin Pedrol Date: Wed Dec 6 19:26:25 2017 +0100 Add support for IPv4v6 End User Addresses Before this commit, when an MS requested an ipv4v6 context osmo-ggsn returned an error stating the type was unknown, and this text was printed in the log: Processing create PDP context request for APN 'ims' Cannot decode EUA from MS/SGSN: f1 8d This patch has been tested with an MS running the 3 types of addresses: - IPv4 and IPv6: no regressions observed, the context is activated and packets are sent to the ggsn. - IPv4v6: Wireshark correctly parses request and reponse, and then ICMPv6 traffic from both sides. Finally I see the MS using the IPv4 and IPv6 DNS addresses advertised and TCP traffic over IPv4 (because probably my IPv6 network setup is not correct). I also checked I can disable/enable data (pdp ctx delete and activate) several times without any issue. Change-Id: Ic820759167fd3bdf329cb11d4b942e903fe50af5 ----------------------------------------------------------------------- Summary of changes: ggsn/ggsn.c | 95 ++++++++++++++++++++++----------------- ggsn/icmpv6.c | 7 ++- gtp/pdp.h | 3 +- lib/in46_addr.c | 109 ++++++++++++++++++++++++++++++++++----------- lib/in46_addr.h | 2 +- sgsnemu/sgsnemu.c | 2 +- tests/lib/in46a_test.c | 91 +++++++++++++++++++++++++++++++++---- tests/lib/in46a_v6_test.ok | 4 +- 8 files changed, 231 insertions(+), 82 deletions(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Tue Dec 12 12:31:25 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 12:31:25 GMT Subject: osmo-gsm-manuals.git branch neels/osmo-bsc updated. 826185e56a7e65a61831a21140f178f76c933823 Message-ID: <201712121231.vBCCVPvZ078197@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, neels/osmo-bsc has been updated discards 04044575742492403a34cf322b9fdab5cd930b6a (commit) discards f00493e8bb585b394b1dfeaa04795ed1a349476b (commit) discards de14286595419c69446fc9cab82141757eecb61f (commit) discards f28a722cc8704f30e8b735fb372a09f59e7b6281 (commit) discards 09c2b165ccf6dca9c6d67fdbd564462dff2e22e4 (commit) discards b65097e94677a52deb90872112185444283261d8 (commit) discards fe76d58e06b9844a3a4b2c8bded589a38e5e4a2a (commit) discards c8e0cf628232d9a749d47b962b37719eae012e01 (commit) discards aa29df546a9187f72a6294934c587b4867d2e54e (commit) discards 652f2a888657e0580168003b2afa8af19c4f5b79 (commit) discards 40b3f7ae5f9e0a341c72489a12173aa1b10cd931 (commit) discards 3a36416179049060cb3d318935aa99a214e4ac8c (commit) discards 017b669861a2e585c42044219a1925a6d4c8eca6 (commit) discards 05e840440fd8b68a9cfcd0b66b2cf9cdbb027f68 (commit) via 826185e56a7e65a61831a21140f178f76c933823 (commit) via 27e07351049725ce81400b2648a29c53ba7de966 (commit) via 9c8a8ebb36bb15d2681ac9819509ffa745e496ee (commit) via 92c1a2763d952c7a6f6f420f30ebccfc99966b8c (commit) via 2b9b6e3ef039d7a38a0026b1782a7c5196be6825 (commit) via fd14387de56220daf180b60e3ce6033eabcb51d2 (commit) via 596c49fc3955c14dd4b719b527c8e32313fb406d (commit) via ac3414cc8aa383be4d713766d4c468765657b059 (commit) via a0ca649d40090e57c31bc8d42e6f36de935e6da7 (commit) via dcfbc8e249dd910024f89a20fe58fff38d5cb222 (commit) via 96c8351fdcaf8b116670279fc4d43497479ea27e (commit) via 5b02f9a09296047d72eb8fc4465c6e2fdce5869b (commit) via 7b06baccd60b0f02e4d7f8be29f8a24fc1764a06 (commit) via da63831ef9eca0afc32aa90e72001793ba3488e0 (commit) via 2f9403f727cd0ae8488f56f41f9326b04af30d3e (commit) via ea209f2a8ef10952382400331e7cc4715f9dfb55 (commit) via 02abf0c761c228d2a30450cc419fc9a5ce42ad36 (commit) via cef03ec36d8a44442e153703a497ce150462d44f (commit) via 3d2f7ffe40c83b3af5e0bea1e6da100fb8682486 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (04044575742492403a34cf322b9fdab5cd930b6a) \ N -- N -- N (826185e56a7e65a61831a21140f178f76c933823) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=826185e56a7e65a61831a21140f178f76c933823 commit 826185e56a7e65a61831a21140f178f76c933823 Author: Neels Hofmeyr Date: Thu Dec 7 19:34:05 2017 +0100 common: bts: show 'OsmoBSC>' vty prompt by default, not OpenBSC Change-Id: I3b19ea58fc843852c5317502941c2b6c6d3cd743 ----------------------------------------------------------------------- Summary of changes: OsmoBSC/chapters/bts-examples.adoc | 281 ---- OsmoBSC/osmobsc-usermanual.adoc | 2 +- OsmoGGSN/vty/ggsn_vty_additions.xml | 16 +- OsmoGGSN/vty/ggsn_vty_reference.xml | 2685 ++++++++++++++++------------------- common/chapters/control_if.adoc | 50 +- common/vty_additions.xml | 52 +- 6 files changed, 1285 insertions(+), 1801 deletions(-) delete mode 100644 OsmoBSC/chapters/bts-examples.adoc hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Tue Dec 12 17:06:30 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 17:06:30 GMT Subject: meta-telephony.git branch 201705 updated. fdbb433446fc698370124fb9444fcbde31c84285 Message-ID: <201712121706.vBCH6U4s090594@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, 201705 has been updated via fdbb433446fc698370124fb9444fcbde31c84285 (commit) via 266820ad9e25d1a3bb27730e0ea070b7dc782766 (commit) via cb1bb2b0628ace82944f47e7e87563b63449a6ce (commit) via b4531911489c0a49e8e04b9107dc639d2b753288 (commit) via 3ad2ad5dc455b3e773f257808a2c8f5d74f59162 (commit) via 0979bed839b716e8a574517ed2a987f9117d0287 (commit) via a3d306e76095302944afc95131208924e0d3d424 (commit) via 146edc71f57820db204e80dd9bc508e2643c5f0a (commit) from 95f1531408a8f5521cf4eb1a60dfd29a5fac0fdb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: recipes-misc/libsmpp/libsmpp34_1.12.bb | 19 ----------- recipes-misc/libsmpp/libsmpp34_git.bb | 7 ++-- recipes-osmocom/libasn1c/libasn1c_git.bb | 2 +- recipes-osmocom/libosmo-abis/libosmo-abis_git.bb | 2 +- recipes-osmocom/libosmo-netif/libosmo-netif_git.bb | 6 ++-- recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb | 6 ++-- recipes-osmocom/libosmocore/libosmocore_git.bb | 8 ++--- recipes-osmocom/openbsc/openbsc.inc | 5 ++- recipes-osmocom/openbsc/openbsc_git.bb | 4 +-- recipes-osmocom/osmo-bsc/osmo-bsc_git.bb | 4 +-- recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb | 6 ++-- recipes-osmocom/osmo-hlr/osmo-hlr_git.bb | 4 +-- recipes-osmocom/osmo-iuh/osmo-iuh_git.bb | 4 +-- recipes-osmocom/osmo-mgw/osmo-mgw.inc | 38 ++++++++++++++++++++-- recipes-osmocom/osmo-mgw/osmo-mgw_git.bb | 4 +-- recipes-osmocom/osmo-msc/osmo-msc_git.bb | 4 +-- recipes-osmocom/osmo-sgsn/osmo-sgsn.inc | 4 +-- recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb | 4 +-- ...packagegroup-core-standalone-osmo-sdk-target.bb | 2 +- .../packagegroup/packagegroup-sdk-osmo.inc | 1 + 20 files changed, 74 insertions(+), 60 deletions(-) delete mode 100644 recipes-misc/libsmpp/libsmpp34_1.12.bb hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 12 17:06:32 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 17:06:32 GMT Subject: meta-telephony.git branch laforge/nightly updated. ea485e006d059f28e7fb7649d156e3677406ff59 Message-ID: <201712121706.vBCH6WrN090634@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom layer for OpenEmbedded". The branch, laforge/nightly has been updated discards 8172c8ed924e2e6e4c5e417d857b602e53038105 (commit) discards e89c42dc4261edcfacf7f12c498fdb285a5063ab (commit) discards 1dfd9cdad0798f478a4482bc2ab106a05648b4e8 (commit) discards c93542b049089466e013c941dc3f1ad2f3b756ca (commit) discards c0208ebe70115a0ae6597ea7397a01c4de77576c (commit) discards 26dcbe02691cf4bfea7dc2d3c7e77b2633d3526a (commit) discards 848f7f56a2eed842faa5d173dcbf1991bf2d16a3 (commit) discards 1c92a0cf1ef922016c1b8c178f4d3a7554af8902 (commit) via ea485e006d059f28e7fb7649d156e3677406ff59 (commit) via fdbb433446fc698370124fb9444fcbde31c84285 (commit) via 266820ad9e25d1a3bb27730e0ea070b7dc782766 (commit) via cb1bb2b0628ace82944f47e7e87563b63449a6ce (commit) via b4531911489c0a49e8e04b9107dc639d2b753288 (commit) via 3ad2ad5dc455b3e773f257808a2c8f5d74f59162 (commit) via 0979bed839b716e8a574517ed2a987f9117d0287 (commit) via a3d306e76095302944afc95131208924e0d3d424 (commit) via 146edc71f57820db204e80dd9bc508e2643c5f0a (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (8172c8ed924e2e6e4c5e417d857b602e53038105) \ N -- N -- N (ea485e006d059f28e7fb7649d156e3677406ff59) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/meta-telephony/commit/?id=ea485e006d059f28e7fb7649d156e3677406ff59 commit ea485e006d059f28e7fb7649d156e3677406ff59 Author: Harald Welte Date: Thu Jun 23 08:51:51 2016 +0200 set up osmocom recipes with AUTOREV to track git master This is for the upcoming nightly builds, where all our osmo* recipes are going to track current master of their respective upstream git repository. Change-Id: Idda98bdfa07c16aee1955fa63373b358bb754c90 ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- Osmocom layer for OpenEmbedded From gitosis at osmocom.org Tue Dec 12 19:35:33 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 19:35:33 GMT Subject: osmo-gsm-manuals.git branch master updated. 0d149fbcb87da328eec666c4d8e17597707ab699 Message-ID: <201712121935.vBCJZXRs048731@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via 0d149fbcb87da328eec666c4d8e17597707ab699 (commit) from 27e07351049725ce81400b2648a29c53ba7de966 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=0d149fbcb87da328eec666c4d8e17597707ab699 commit 0d149fbcb87da328eec666c4d8e17597707ab699 Author: Philipp Maier Date: Mon Dec 11 18:48:34 2017 +0100 osmo-mgw: Add vty reference manual add missing vty reference manual for osmo-mgw Change-Id: If9d8cdcbbbf14b23e48af5b9ae1c56c2a38219a2 ----------------------------------------------------------------------- Summary of changes: Makefile | 4 + {OsmoNAT => OsmoMGW}/Makefile | 2 +- .../osmomgw-vty-reference.xml | 6 +- .../vty/mgw_vty_additions.xml | 0 .../vty/mgw_vty_reference.xml | 640 ++++++++++++++++----- 5 files changed, 496 insertions(+), 156 deletions(-) copy {OsmoNAT => OsmoMGW}/Makefile (72%) copy OsmoHLR/osmohlr-vty-reference.xml => OsmoMGW/osmomgw-vty-reference.xml (86%) copy OsmoHLR/vty/hlr_vty_additions.xml => OsmoMGW/vty/mgw_vty_additions.xml (100%) copy OsmoMGCP/vty/mgcp_vty_reference.xml => OsmoMGW/vty/mgw_vty_reference.xml (68%) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Tue Dec 12 19:37:39 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 12 Dec 2017 19:37:39 GMT Subject: openbsc.git branch master updated. 1.0.0-8-g5825e5cfb Message-ID: <201712121937.vBCJbdjE049553@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 5825e5cfb245f32a409c7784e51fb1e774adf799 (commit) from 5d69fa52cf1e679e391519dd841da1579d640087 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=5825e5cfb245f32a409c7784e51fb1e774adf799 commit 5825e5cfb245f32a409c7784e51fb1e774adf799 Author: Neels Hofmeyr Date: Tue Dec 12 13:20:23 2017 +0100 sms.db: silence libdbi warnings on out-of-range index Apparently, since libdbi 0.9.0 aka 0.9.0-5 on debian-testing, osmo-msc barfs numerous libdbi warnings whenever a query rightfully returns no rows. Trivially query whether there are any rows first by adding an inline wrap function next_row(). Silenced: DDB <000d> ../../../../src/osmo-msc/src/libmsc/db.c:188 DBI: -6: An invalid or out-of-range index was passed to l DDB <000d> ../../../src/libosmocore/src/backtrace.c:47 backtrace() returned 11 addresses DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0xfb81) [0x555555563b81] DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/lib/x86_64-linux-gnu/libdbi.so.1(_error_handle DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/lib/x86_64-linux-gnu/libdbi.so.1(dbi_result_ne DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0x11172) [0x555555565172] DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0x1e6bc) [0x5555555726bc] DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0x1e7f6) [0x5555555727f6] DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0x1f1d2) [0x5555555731d2] DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0xbb86) [0x55555555fb86] DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0 DDB <000d> ../../../src/libosmocore/src/backtrace.c:57 /usr/local/bin/osmo-msc(+0xbfba) [0x55555555ffba] Related: OS#2737 OS#2667 Change-Id: I43cf4eed22425554826d59857eded5b4cc0d2c52 ----------------------------------------------------------------------- Summary of changes: openbsc/src/libmsc/db.c | 43 +++++++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 18 deletions(-) hooks/post-receive -- Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Dec 13 00:15:54 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 00:15:54 GMT Subject: osmocom-bb.git branch fixeria/audio created. osmocon_v0.0.0-1895-g0ed60f68 Message-ID: <201712130015.vBD0FsJX063594@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/audio has been created at 0ed60f68b86b47417e2ec587320e27c84737695b (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=0ed60f68b86b47417e2ec587320e27c84737695b commit 0ed60f68b86b47417e2ec587320e27c84737695b Author: Vadim Yanitskiy Date: Tue Dec 12 19:14:13 2017 +0700 mobile: integrate GAPK based audio I/O back-end This change introduces a new feature of mobile application - audio I/O support, which allows to speak right from PC running mobile through its ordinary mic and speakers. The audio I/O is based on GAPK library, which relays on ALSA sound framework. The API of GAPK implies to use the processing queues (chains), which basically consist of a source block, several processing blocks, and a sink block. So, there are two voice processing chains: - 'pq_audio_source' (voice capture -> frame encoding), - 'pq_audio_sink' (frame decoding -> voice playback). Both of them exchange frames from two dedicated buffers: - 'tch_fb_ul' - a buffer for to be played DL TCH frames, - 'tch_fb_dl' - a buffer for encoded UL TCH frames. In its turn, both buffers are served by a new gapk_io_dequeue() function, which is being called within the mobile_work() loop. Current limitations: - Both processing chains are being initialized on MS init mobile_init() and being destroyed on mobile_exit(). Thus, some part of memory is occupied during all MS work cycle, even when there is no an active call. Would be better to keep both chains in memory during a voice call only. - TCF/FR codec support only. Despite the both chains are codec independent, they are being initialized with FR. Should be resolved together with the first issue. - Missing ECU (Error Concealment Unit). If the BTS signal is weak and some TCH frames were lost, the voice playback may contain some unpleasant audio drops. This will be resolved as soon as ECU is implemented as a part of libosmocodec. Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 http://cgit.osmocom.org/osmocom-bb/commit/?id=be594d8afbf031ff03b73bee07d61ce1b5cc9bb8 commit be594d8afbf031ff03b73bee07d61ce1b5cc9bb8 Author: Vadim Yanitskiy Date: Tue Dec 12 19:08:17 2017 +0700 mobile/gsm48_rr.c: set audio mode according to configuration In the prevoius change a new configuration option was introduced as a part of new 'audio' node - 'io-target'. This change makes it to take an effect, instructing the L1 to use one of the following possible TCH frame I/O targets: - gapk - build-in (WIP) GAPK-based audio back-end (default); - hardware - L1 hardware (e.g. Calypso DSP); - socket - External MNCC application (e.g. LCR). Change-Id: I2a36d9c30da6746995dcea3a33cb13e0d2f6549a http://cgit.osmocom.org/osmocom-bb/commit/?id=b929c39eea0aba5e223deb1260d32c1b6df59ecc commit b929c39eea0aba5e223deb1260d32c1b6df59ecc Author: Vadim Yanitskiy Date: Tue Dec 12 03:49:43 2017 +0700 mobile/vty_interface.c: add new 'audio' section This change introduces a new node named 'AUDIO', which is intended to organize some audio related settings, such as: - io-target - TCH frame I/O back-end (e.g. gapk, hardware); - alsa-output-dev - ALSA playback (i.e. speakers) device name; - alsa-input-dev - ALSA recording (i.e. mic) device name. The last two are actual when 'io-target' is set to 'gapk'. For now, all introduced parameters don't affect anything. Change-Id: I62cd5ef22ca2290fcafe65c78537ddbcb39fb8c6 http://cgit.osmocom.org/osmocom-bb/commit/?id=ef167cdb6368bb721aacc4af1b9c7081678a6702 commit ef167cdb6368bb721aacc4af1b9c7081678a6702 Author: Vadim Yanitskiy Date: Fri Sep 8 15:54:39 2017 +0300 host/layer23: add a new logging category for GAPK Change-Id: I5c3e8553f9bca2ca2e1bf17ee5934e04bd12f605 http://cgit.osmocom.org/osmocom-bb/commit/?id=ab6eebadccb6400c30e4a10efb37aeca7d8436f9 commit ab6eebadccb6400c30e4a10efb37aeca7d8436f9 Author: Vadim Yanitskiy Date: Fri Sep 8 00:45:29 2017 +0300 mobile: link the binary against libosmogapk Since GAPK became a library - libosmogapk, one could be used for the audio capture / playback directly on the host side. This change adds the library as a dependency, and links the mobile against it. Change-Id: I47054f32fec6780bdbe6f73b82aa446c4c7c1df4 http://cgit.osmocom.org/osmocom-bb/commit/?id=6a3321363296d4671c8053668966c4ffa46bd608 commit 6a3321363296d4671c8053668966c4ffa46bd608 Author: Vadim Yanitskiy Date: Fri Sep 8 00:40:27 2017 +0300 mobile/Makefile.am: consistently format variables Change-Id: I309d94c4a381c21486e5b424c9504ea6d272af05 http://cgit.osmocom.org/osmocom-bb/commit/?id=bed3ac314145d4685fa1cc508121db05e350e731 commit bed3ac314145d4685fa1cc508121db05e350e731 Author: Vadim Yanitskiy Date: Mon Dec 11 04:26:12 2017 +0700 mobile: add MNCC handler selection to settings Since the mobile application is patentionally able to work with multiple MS instances, it's better to have a possibility to choose an MNCC (Call Control) handler per each MS separately. This change cleans up the code, removing a dedicated command-line option '-m' intended for enabling extarnal MNCC. Now it's possible to set an MNCC-handler for each MS via VTY interface and settings. The following MNCC-handlers are available: - mobile - build-in MNCC-handler (default); - socket - external MNCC-handler via UNIX-socket (e.g. LCR); - dummy - dummy handler without CC support. Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346 http://cgit.osmocom.org/osmocom-bb/commit/?id=4f5746ada980e3beb7deaee9d0ae0bbf7db45aa5 commit 4f5746ada980e3beb7deaee9d0ae0bbf7db45aa5 Author: Vadim Yanitskiy Date: Fri Sep 8 18:51:53 2017 +0300 mobile: add MNCC socket path to settings Previously the MNCC socket path was generated automatically, using concatenation of the '/tmp/ms_mncc_' prefix and MS name. Let's allow user to specify this manually, keeping a similar generation method for default value. Change-Id: I643356ac579bc5e765f668265ec803b22a73739c ----------------------------------------------------------------------- hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Wed Dec 13 02:28:37 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 02:28:37 GMT Subject: osmo-ci.git branch master updated. 53bb902b3f8be2d64714add52594a04d8150ee8c Message-ID: <201712130228.vBD2Sbk8018315@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 53bb902b3f8be2d64714add52594a04d8150ee8c (commit) via cb7c6ee40f3b97c4ec802e92ad423939e6852d98 (commit) from 787a51f51f4b08e7908162178647846219c03e62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=53bb902b3f8be2d64714add52594a04d8150ee8c commit 53bb902b3f8be2d64714add52594a04d8150ee8c Author: Neels Hofmeyr Date: Wed Dec 13 02:30:47 2017 +0100 jobs: master-builds: fix git master branch polling The 'refs/heads/origin/master' somehow caused that git polling would not trigger builds. 'origin/master' was succesful in a manual test, so set all jobs to that. Change-Id: Id033d1bfce6cc9e20fbbf9be462842b9e44bde83 http://cgit.osmocom.org/osmo-ci/commit/?id=cb7c6ee40f3b97c4ec802e92ad423939e6852d98 commit cb7c6ee40f3b97c4ec802e92ad423939e6852d98 Author: Harald Welte Date: Tue Dec 12 17:28:26 2017 +0100 Add gerrit JJB for osmo-ttcn3-hacks we simply call 'make compile' which will compile all of the projects from TTCN-3 to C++ Change-Id: I2bb94c08259c130558f82bb4c084484be5b81c40 ----------------------------------------------------------------------- Summary of changes: jobs/gerrit-verifications.yml | 9 +++++++++ jobs/master-builds.yml | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Wed Dec 13 02:28:42 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 02:28:42 GMT Subject: libosmocore.git branch master updated. 0.10.2-56-g84ea2e03 Message-ID: <201712130228.vBD2SgqT018392@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 84ea2e037490a9ad6c0a192cf237f88fd83cdd88 (commit) from 32e5641dbbfd91b650a9ec8cf62d28fd22109e9e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=84ea2e037490a9ad6c0a192cf237f88fd83cdd88 commit 84ea2e037490a9ad6c0a192cf237f88fd83cdd88 Author: Neels Hofmeyr Date: Sat Dec 9 05:53:18 2017 +0100 logging vty: describe 'logging set-log-mask' command, add OSMO_STRINGIFY_VAL() Change-Id: I73ac5873ede858da44e1486d8a5c81da1ed5b19f ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/utils.h | 2 ++ src/vty/logging_vty.c | 13 +++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 13 12:25:46 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 12:25:46 GMT Subject: osmo-ci.git branch master updated. 61038264edcf8248b8b487f4cfe9843ca5a738c8 Message-ID: <201712131225.vBDCPkGL070349@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 61038264edcf8248b8b487f4cfe9843ca5a738c8 (commit) from 53bb902b3f8be2d64714add52594a04d8150ee8c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=61038264edcf8248b8b487f4cfe9843ca5a738c8 commit 61038264edcf8248b8b487f4cfe9843ca5a738c8 Author: Alexander Couzens Date: Tue Dec 5 16:53:01 2017 +0100 rewrite osmocom-nightly-package based on the old osmocom-nightly-split.sh The split build script also initilize the repository if it's empty and doesn't need any state of the osc repository. It also downloads bumpversion and limesuite Change-Id: I3b55e14b5b4915a3aae23ee382d65bce4ef82774 ----------------------------------------------------------------------- Summary of changes: scripts/osmocom-nightly-packages.sh | 229 +++++++++++++++++++++++++----------- 1 file changed, 162 insertions(+), 67 deletions(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Wed Dec 13 12:25:51 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 12:25:51 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1889-g68bd1107 Message-ID: <201712131225.vBDCPpK7070443@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via 68bd1107178044207c07a3fd75219413e9a17c65 (commit) via 1a8a80aeae4c2e5c870ae5b032d9a6ae60b67ac8 (commit) from 2cac7e8ceffc8e7d4667b2f9f7477364b80716d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=68bd1107178044207c07a3fd75219413e9a17c65 commit 68bd1107178044207c07a3fd75219413e9a17c65 Author: Vadim Yanitskiy Date: Sat Dec 9 02:03:13 2017 +0700 mobile/gsm48_rr.c: cosmetic: drop wrong comment Nothing is actually being skipped in this function. Change-Id: I9d5a33cf3a1dd7a75f9769d3c5ba85c59594b8f4 http://cgit.osmocom.org/osmocom-bb/commit/?id=1a8a80aeae4c2e5c870ae5b032d9a6ae60b67ac8 commit 1a8a80aeae4c2e5c870ae5b032d9a6ae60b67ac8 Author: Vadim Yanitskiy Date: Wed Dec 6 03:36:48 2017 +0700 mobile/gsm48_rr.c: fix ACCH System Information parsing According to GSM 04.08, the System Information messages, such as SI5, SI5ter, SI5bis and SI6 (described in sections 9.1.37-40), have no the 'L2 Pseudo Length' (10.5.2.19) field, unlike others. So, previously the ACCH SI messages were ignored due to an implementation error - the gsm48_system_information_type_header struct isn't applicable here, because it assumes the 'l2_plen'. Since there is no (yet?) equivalent struct for the ACCH SI, this change replaces the wrong struct by the 'gsm48_hdr', which satisfies described requirements. Moreover, this change cleans up some gsm48_rr_rx_sysinfo* functions, getting rid of meaningless pionter shifting. Change-Id: I9166996f146af7973bf02a8a1c965581dc58a4a5 ----------------------------------------------------------------------- Summary of changes: src/host/layer23/src/mobile/gsm48_rr.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Wed Dec 13 16:49:42 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 16:49:42 GMT Subject: gapk.git branch laforge/mmx deleted. 12caf496aa2649559c364753c15a027251c95e0d Message-ID: <201712131649.vBDGngQE072585@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, laforge/mmx has been deleted was 12caf496aa2649559c364753c15a027251c95e0d ----------------------------------------------------------------------- 12caf496aa2649559c364753c15a027251c95e0d WIP: add laforge-mmx.diff to illustrate MMX related changes I tried ----------------------------------------------------------------------- hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Wed Dec 13 16:49:43 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 16:49:43 GMT Subject: gapk.git branch mmx deleted. v0.3-12-g1650667 Message-ID: <201712131649.vBDGnh15072609@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, mmx has been deleted was 16506674545b38ddd38325470d6d7756f4486ffc ----------------------------------------------------------------------- 16506674545b38ddd38325470d6d7756f4486ffc libgsmhr: Experimental MMX support by Harald ----------------------------------------------------------------------- hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Wed Dec 13 16:49:44 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 16:49:44 GMT Subject: gapk.git branch fixeria/lib deleted. v0.4-53-g3cf11d8 Message-ID: <201712131649.vBDGniI7072621@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, fixeria/lib has been deleted was 3cf11d824385e06a96b318766d7e6708e49b3215 ----------------------------------------------------------------------- 3cf11d824385e06a96b318766d7e6708e49b3215 tests: add format / codec transcoding tests ----------------------------------------------------------------------- hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Wed Dec 13 16:49:45 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 16:49:45 GMT Subject: libgtpnl.git annotated tag 1.0.1 deleted. a33989532023b607ece5f326045f52d5a9ad39e5 Message-ID: <201712131649.vBDGnj9H072669@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "netlink library for Linux kernel GTP code". The annotated tag, 1.0.1 has been deleted was a33989532023b607ece5f326045f52d5a9ad39e5 ----------------------------------------------------------------------- tag 1.0.1 tag v1.0.1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAV5pRyEoQeR9V5ESWAQKq+g//SLu+Oxkl7btk8wuE7sXRZcb9xW0jdzIP M+5oUouGbmDV+mdQCaPu6CqcWIbDfOBL53GVnUhNYlzLOOcyFo4hqaesL9OhCOOl dV+UJxFFJqs9d/INtjjtsXL52JmAcPHYG3gZooiu1HVxaPiAgRxVYD/6ivl7zjHU L7MZ2cXd6oRNX5VaPUQ8Rhen7DsrJ5tYS5s/DsmGVMyIFueQCmVTAEXlvXDUpAI0 NGJEfTGA8ldbOExHP7Y5N13idOg/KGdWBc1XgPLum+3+wmNep4It4+dsVePz0sOn GHh7in+9LIwGBCJ0SqdRIoOdFF5dBHPgefFZoCgaRArzlJi0qGmzpA1kdP9nLO81 A0UelVx+8j5G1y1HMscUzPCCveeL1fFOlBSdd4ypNcVUyCOdyRFq17ZGb4HOuB7x ItvUcxja6ebh9+2RGoivdG/T30LyaQYc6xPwbHgDUs2uPurP3g72SODFVSejvAX3 CjZILFEnDCS4Br2qtBsEzafi/SpGs9xItZmWkYS7SPiKTzUSvvQszedGkN5a1aKH aQsmNaPHvqMAXnKSwNWYVBwroXbs92n/kXRJC7d89cO7R3cdYh2R7J+hiKVqugjv NhbwnlOck45AlsE2CD1QOcfRHdyJ7wNmYDi+ZJA1LZEyFfhI5BuMAHBGIAcXWo6A 8Yl/SpOaOTQ= =1ok/ -----END PGP SIGNATURE----- 853753e7c67de81ab3bf5d8f4a2b9f015041a6ba mark as 1.0.1 after re-licensing and dist-check fix ----------------------------------------------------------------------- hooks/post-receive -- netlink library for Linux kernel GTP code From gitosis at osmocom.org Wed Dec 13 21:25:17 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 13 Dec 2017 21:25:17 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1890-gf02c04f4 Message-ID: <201712132125.vBDLPHdn086750@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via f02c04f4441ae0d05f46f5fdfd1aa8181ede57a8 (commit) from 68bd1107178044207c07a3fd75219413e9a17c65 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=f02c04f4441ae0d05f46f5fdfd1aa8181ede57a8 commit f02c04f4441ae0d05f46f5fdfd1aa8181ede57a8 Author: Vadim Yanitskiy Date: Wed Dec 13 23:05:59 2017 +0700 mobile/vty_interface.c: fix 'channel-capability' description Change-Id: I0c08e071ffaac9b8e7c4af6a7be2bd8125145842 ----------------------------------------------------------------------- Summary of changes: src/host/layer23/src/mobile/vty_interface.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Thu Dec 14 14:18:22 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 14:18:22 GMT Subject: osmo-ggsn.git branch pespin/link-local created. 1.1.0-44-g9b17053 Message-ID: <201712141418.vBEEIMMt093686@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, pespin/link-local has been created at 9b1705382577e3fc203ebf6c290999bfe6010dc2 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=9b1705382577e3fc203ebf6c290999bfe6010dc2 commit 9b1705382577e3fc203ebf6c290999bfe6010dc2 Author: Pau Espin Pedrol Date: Thu Dec 14 14:09:13 2017 +0100 ggsn: Add 'ipv6 link-local' vty cmd This vty cmd let's you set up a new link-local IP for a specific APN to be used during ICMPv6 Router Advertisement procedure. osmo-ggsn hence requires a link-local IPv6 address to be added to the tun interface, otherwise the apn will not be configured correctly and it won't be able to allocate addresses from the ipv6 pool later on. This feature is useful in case your OS doesn't support autoconfiguring link-local IPs when the interface is brought up (some linux versions are known to fail at this) or in case you configured your OS specifically to avoid automatic set up (sysctl net.ipv6.conf.*.autoconf). If "no ipv6 link-local" is provided (default), osmo-ggsn will rely on the OS or the ipup-script setting up the link-local IP for the tun interface at creation time, then fetching it after ipup-script time and using the first link-local ip found. On the other hand, if the "ipv6 link-local" cmd is provided, osmo-ggsn will add the link-local IP to the interface manually and use that one for later Router Advertisement procedures. Change-Id: I09ef27f54940d4c47150e5f9016d1cd4298c16b5 http://cgit.osmocom.org/osmo-ggsn/commit/?id=dd64f649f80e07b608fc6ea31af49eb9277c7277 commit dd64f649f80e07b608fc6ea31af49eb9277c7277 Author: Pau Espin Pedrol Date: Thu Dec 14 14:01:23 2017 +0100 Set tun_addaddr ipv agnostic and add support for ipv6 sgsnemu (the only user of this API so far) has been modified to use the new API with in46_addr. FreeBSD code for IPv6 has not been tested. Change-Id: Ie36afe6eaf393855a4a708000ef4ad0192bf4767 http://cgit.osmocom.org/osmo-ggsn/commit/?id=4d407a18ca46f93d206e7c15042891ee6968ebae commit 4d407a18ca46f93d206e7c15042891ee6968ebae Author: Pau Espin Pedrol Date: Thu Dec 14 13:48:12 2017 +0100 tun.c: tun_addaddr: Fix segfault and wrong usage of tun_nlattr First of all, dstaddr can be NULL, avoid copying it in that case. Second, we want to copy the addr data, not the pointer. I tested it and the IP was not added (not shown in ip addr) until I copied the content instead of the address. Change-Id: I8da637b155f0e913cab6c5b0dde355c9f33375b5 http://cgit.osmocom.org/osmo-ggsn/commit/?id=cb809ca72148da89ea8e9d826b33e98197f0bbe9 commit cb809ca72148da89ea8e9d826b33e98197f0bbe9 Author: Pau Espin Pedrol Date: Thu Dec 14 11:19:10 2017 +0100 ggsn.c: Improve logging info on link-local ipv6 addr not found Change-Id: I18fb952514712ff30d18c7626f84309055d3efa1 http://cgit.osmocom.org/osmo-ggsn/commit/?id=b00c7caf353ab3410614d9bffebff3f37d136cf9 commit b00c7caf353ab3410614d9bffebff3f37d136cf9 Author: Pau Espin Pedrol Date: Thu Dec 14 13:59:02 2017 +0100 cosmetic: sgsnemu.c: Fix trailing whitespace Change-Id: Ic392ed35946e076a39aa5f7bf80a8c2ffe73562c ----------------------------------------------------------------------- hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Thu Dec 14 14:18:26 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 14:18:26 GMT Subject: osmo-ci.git branch master updated. 795c27976e8c8b2a120126ac99c0e161885ae59c Message-ID: <201712141418.vBEEIQZO093745@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 795c27976e8c8b2a120126ac99c0e161885ae59c (commit) from 61038264edcf8248b8b487f4cfe9843ca5a738c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=795c27976e8c8b2a120126ac99c0e161885ae59c commit 795c27976e8c8b2a120126ac99c0e161885ae59c Author: Harald Welte Date: Thu Dec 14 14:53:02 2017 +0100 add libgtpnl also to 'latest', not just to 'nightly' Change-Id: Ifd9b3c6e98d890f135356648ef3f9a62c07dcf94 ----------------------------------------------------------------------- Summary of changes: scripts/osmocom-latest-packages.sh | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- CI scripts From gitosis at osmocom.org Thu Dec 14 16:43:20 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 16:43:20 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-44-gf5e40b7 Message-ID: <201712141643.vBEGhKrn049851@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via f5e40b7011ebc8f05104b9e44e5ff2402068fbc2 (commit) via 02e21af657abff93319bffe1c7c0272245a6c0d1 (commit) via bffc3f901275a8102c3f94735f48f0681458afc0 (commit) via 7c4de0776bafa744a2a10bbf244c8e4b03544bb3 (commit) via 077b903e11b2565673d56f51184bdbff58a1eeee (commit) from 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=f5e40b7011ebc8f05104b9e44e5ff2402068fbc2 commit f5e40b7011ebc8f05104b9e44e5ff2402068fbc2 Author: Pau Espin Pedrol Date: Thu Dec 14 14:01:23 2017 +0100 Set tun_addaddr ipv agnostic and add support for ipv6 sgsnemu (the only user of this API so far) has been modified to use the new API with in46_addr. FreeBSD code for IPv6 has not been tested. Change-Id: Ie36afe6eaf393855a4a708000ef4ad0192bf4767 http://cgit.osmocom.org/osmo-ggsn/commit/?id=02e21af657abff93319bffe1c7c0272245a6c0d1 commit 02e21af657abff93319bffe1c7c0272245a6c0d1 Author: Pau Espin Pedrol Date: Thu Dec 14 13:48:12 2017 +0100 tun.c: tun_addaddr: Fix segfault and wrong usage of tun_nlattr First of all, dstaddr can be NULL, avoid copying it in that case. Second, we want to copy the addr data, not the pointer. I tested it and the IP was not added (not shown in ip addr) until I copied the content instead of the address. Change-Id: I8da637b155f0e913cab6c5b0dde355c9f33375b5 http://cgit.osmocom.org/osmo-ggsn/commit/?id=bffc3f901275a8102c3f94735f48f0681458afc0 commit bffc3f901275a8102c3f94735f48f0681458afc0 Author: Pau Espin Pedrol Date: Thu Dec 14 11:19:10 2017 +0100 ggsn.c: Improve logging info on link-local ipv6 addr not found Change-Id: I18fb952514712ff30d18c7626f84309055d3efa1 http://cgit.osmocom.org/osmo-ggsn/commit/?id=7c4de0776bafa744a2a10bbf244c8e4b03544bb3 commit 7c4de0776bafa744a2a10bbf244c8e4b03544bb3 Author: Pau Espin Pedrol Date: Thu Dec 14 13:59:02 2017 +0100 cosmetic: sgsnemu.c: Fix trailing whitespace Change-Id: Ic392ed35946e076a39aa5f7bf80a8c2ffe73562c http://cgit.osmocom.org/osmo-ggsn/commit/?id=077b903e11b2565673d56f51184bdbff58a1eeee commit 077b903e11b2565673d56f51184bdbff58a1eeee Author: Pau Espin Pedrol Date: Thu Dec 14 15:26:57 2017 +0100 contrib: jenkins.sh: Build libgtpnl as dep when building with gtp kernel support Change-Id: I7ee741d4940e3c10a4944b676c9765d6808afba9 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 3 + ggsn/ggsn.c | 8 ++- lib/tun.c | 186 ++++++++++++++++++++++++++++++++++++++++++++++++++++- lib/tun.h | 4 +- sgsnemu/sgsnemu.c | 38 +++++------ 5 files changed, 210 insertions(+), 29 deletions(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Thu Dec 14 16:43:23 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 16:43:23 GMT Subject: osmo-ci.git branch master updated. 3e1ca6f866601a39cf13cf30c9d72d5f217a2281 Message-ID: <201712141643.vBEGhNlk049917@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 3e1ca6f866601a39cf13cf30c9d72d5f217a2281 (commit) from 795c27976e8c8b2a120126ac99c0e161885ae59c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=3e1ca6f866601a39cf13cf30c9d72d5f217a2281 commit 3e1ca6f866601a39cf13cf30c9d72d5f217a2281 Author: Max Date: Thu Dec 14 15:21:16 2017 +0100 Remove OpenBSC from Coverity submission The OpenBSC codebase only receive occasional backports hence none of the issues uncovered by Coverity would be fixed unless it's also fixed in corresponding Osmo* project. Let's not clutter output with the information about issues which won't be fixed anyway. Change-Id: Ief3dfc641684fa33407957bf7cfcb6ecf35b847a ----------------------------------------------------------------------- Summary of changes: coverity/build_Osmocom.sh | 9 --------- coverity/prepare_source_Osmcocom.sh | 2 -- 2 files changed, 11 deletions(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Thu Dec 14 16:43:24 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 16:43:24 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-15-g25a3ca4 Message-ID: <201712141643.vBEGhOb0049965@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 25a3ca4e59a0ea03067a04ff3fe459a9ba00efd1 (commit) via ead08aae35ba282ef0fab0b982fe7877fee361da (commit) from 39eb95f1307895cbd67d860f15931f66fd384aca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=25a3ca4e59a0ea03067a04ff3fe459a9ba00efd1 commit 25a3ca4e59a0ea03067a04ff3fe459a9ba00efd1 Author: Max Date: Wed Dec 13 18:47:52 2017 +0100 TBF: move EGPRS enablement into (U|D)L-TBF This is preparation patch for transition to separate UL/DL window variables instead of current shared generic window. The setting of window parameters is performed in functions specific to UL/DL TBFs but the general EGPRS flag remains the same and is set via the same function which is now marked as protected since it's only meant to be used by UL/DL subclasses. Related: OS#1759 Change-Id: I6056194b28a1eb9d69093d1dfdc65a11bc1fc579 http://cgit.osmocom.org/osmo-pcu/commit/?id=ead08aae35ba282ef0fab0b982fe7877fee361da commit ead08aae35ba282ef0fab0b982fe7877fee361da Author: Max Date: Wed Dec 13 18:25:36 2017 +0100 DL window: constify resend_needed() function It doesn't change any state so mark it as const. Change-Id: I5d672bfd654198aebb187772de464c52b3209435 ----------------------------------------------------------------------- Summary of changes: src/rlc.cpp | 2 +- src/rlc.h | 2 +- src/tbf.cpp | 2 -- src/tbf.h | 19 +++++++++++++++---- 4 files changed, 17 insertions(+), 8 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Thu Dec 14 21:03:46 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 21:03:46 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-45-g37c45e3 Message-ID: <201712142103.vBEL3kBY054214@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 37c45e3998fca240b5266abd3ac883d0a35bab50 (commit) from f5e40b7011ebc8f05104b9e44e5ff2402068fbc2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=37c45e3998fca240b5266abd3ac883d0a35bab50 commit 37c45e3998fca240b5266abd3ac883d0a35bab50 Author: Pau Espin Pedrol Date: Thu Dec 14 14:09:13 2017 +0100 ggsn: Add 'ipv6 link-local' vty cmd This vty cmd let's you set up a new link-local IP for a specific APN to be used during ICMPv6 Router Advertisement procedure. osmo-ggsn hence requires a link-local IPv6 address to be added to the tun interface, otherwise the apn will not be configured correctly and it won't be able to allocate addresses from the ipv6 pool later on. This feature is useful in case your OS doesn't support autoconfiguring link-local IPs when the interface is brought up (some linux versions are known to fail at this) or in case you configured your OS specifically to avoid automatic set up (sysctl net.ipv6.conf.*.autoconf). If "no ipv6 link-local" is provided (default), osmo-ggsn will rely on the OS or the ipup-script setting up the link-local IP for the tun interface at creation time, then fetching it after ipup-script time and using the first link-local ip found. On the other hand, if the "ipv6 link-local" cmd is provided, osmo-ggsn will add the link-local IP to the interface manually and use that one for later Router Advertisement procedures. Change-Id: I09ef27f54940d4c47150e5f9016d1cd4298c16b5 ----------------------------------------------------------------------- Summary of changes: ggsn/ggsn.c | 17 ++++++++++++++++- ggsn/ggsn.h | 1 + ggsn/ggsn_vty.c | 20 ++++++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Thu Dec 14 21:03:53 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 21:03:53 GMT Subject: osmo-bts.git branch master updated. 0.7.0-32-g3c96db2 Message-ID: <201712142103.vBEL3r0H054280@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 3c96db29fadbf1fb9519252462661f21da83e907 (commit) via 035fc9a13497ec8fce3ee1ae4928aa9dd82d2376 (commit) from 8f12047157b55fe3997f686efec26f2a54ea3242 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=3c96db29fadbf1fb9519252462661f21da83e907 commit 3c96db29fadbf1fb9519252462661f21da83e907 Author: Pau Espin Pedrol Date: Thu Dec 14 16:02:29 2017 +0100 jenkins.sh: Disable building doxygen for deps Change-Id: I2ed207a5febe8017a20a0e7de0ba575fd7966af6 http://cgit.osmocom.org/osmo-bts/commit/?id=035fc9a13497ec8fce3ee1ae4928aa9dd82d2376 commit 035fc9a13497ec8fce3ee1ae4928aa9dd82d2376 Author: Pau Espin Pedrol Date: Thu Dec 14 16:01:11 2017 +0100 debian/control: Remove uneeded dep libosmo-netif-dev I didn't see any related libosmo-netif code dependency in the project. Change-Id: I2da1935bcc3ce507cfb21419a1e340aa3361cd65 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins_bts_trx.sh | 2 +- contrib/jenkins_lc15.sh | 2 +- contrib/jenkins_oct.sh | 2 +- contrib/jenkins_oct_and_bts_trx.sh | 2 +- contrib/jenkins_sysmobts.sh | 2 +- debian/control | 1 - 6 files changed, 5 insertions(+), 6 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Thu Dec 14 21:03:55 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 14 Dec 2017 21:03:55 GMT Subject: libosmo-netif.git branch master updated. 0.1.1-10-g3173ca7 Message-ID: <201712142103.vBEL3tnL054329@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via 3173ca7ac7e9c6c9e2ff9bb80a9d27a3c10c7608 (commit) from c72be77aa330c968f9f1d624e38141b3c2e24323 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=3173ca7ac7e9c6c9e2ff9bb80a9d27a3c10c7608 commit 3173ca7ac7e9c6c9e2ff9bb80a9d27a3c10c7608 Author: Pau Espin Pedrol Date: Thu Dec 14 15:53:15 2017 +0100 contrib: jenkins.sh: Disable building doxygen for deps Change-Id: I456b539ebdb86a6a27af0bec1d44d68b407ad912 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom network interface library From gitosis at osmocom.org Fri Dec 15 03:52:23 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 03:52:23 GMT Subject: osmo-python-tests.git branch master updated. 738acb7b0231dab182b7f79525d00c7a613787a2 Message-ID: <201712150352.vBF3qNq6023644@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 738acb7b0231dab182b7f79525d00c7a613787a2 (commit) from 1aa0fb4910c7a06649a9dfb0bd839faeb6fe6808 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=738acb7b0231dab182b7f79525d00c7a613787a2 commit 738acb7b0231dab182b7f79525d00c7a613787a2 Author: Neels Hofmeyr Date: Fri Dec 15 04:35:07 2017 +0100 add contrib/jenkins.sh from current jenkins.osmocom.org job i.e. from https://jenkins.osmocom.org/jenkins/job/update-osmocom-python-on-slaves Change-Id: Iefa0261303982fc66d0845348b9c4a0ff6b94ab5 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 4 ++++ 1 file changed, 4 insertions(+) create mode 100755 contrib/jenkins.sh hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Fri Dec 15 08:24:47 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 08:24:47 GMT Subject: osmo-gsm-manuals.git branch master updated. ccb51225c51e08a87f75f2491efc1404b99ebc7e Message-ID: <201712150824.vBF8OlYM030678@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via ccb51225c51e08a87f75f2491efc1404b99ebc7e (commit) from 0d149fbcb87da328eec666c4d8e17597707ab699 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=ccb51225c51e08a87f75f2491efc1404b99ebc7e commit ccb51225c51e08a87f75f2491efc1404b99ebc7e Author: Neels Hofmeyr Date: Fri Dec 15 05:36:49 2017 +0100 jenkins.sh: incorporate publish step, for master build Change-Id: I3c14f4e0266a4eb2702ca9fa9cf05dd54fc5d853 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 8 ++++++++ 1 file changed, 8 insertions(+) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Fri Dec 15 15:34:27 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 15:34:27 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-16-g1a11d1d Message-ID: <201712151534.vBFFYRl9004814@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 1a11d1db09bd7a17ff1bf4bfd5cc31e6f4fbd06d (commit) from 25a3ca4e59a0ea03067a04ff3fe459a9ba00efd1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=1a11d1db09bd7a17ff1bf4bfd5cc31e6f4fbd06d commit 1a11d1db09bd7a17ff1bf4bfd5cc31e6f4fbd06d Author: Max Date: Thu Dec 7 11:46:29 2017 +0100 TBF-DL: fix misleading idle time check The dl_tbf_idle_msec is uint32_t so it cannot be < 0. Change-Id: Ic88cb4698bcb9be52a5179529f81b8728bf4f93f ----------------------------------------------------------------------- Summary of changes: src/tbf_dl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Fri Dec 15 15:43:37 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 15:43:37 GMT Subject: osmo-ci.git branch master updated. 1e857dcf1fb0799b39d7c04dcee3704f997b84e5 Message-ID: <201712151543.vBFFhbaQ008792@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 1e857dcf1fb0799b39d7c04dcee3704f997b84e5 (commit) from 3e1ca6f866601a39cf13cf30c9d72d5f217a2281 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=1e857dcf1fb0799b39d7c04dcee3704f997b84e5 commit 1e857dcf1fb0799b39d7c04dcee3704f997b84e5 Author: Max Date: Mon Dec 11 13:18:14 2017 +0100 Add osmo-python-tests to gerrit verification Change-Id: Ia5db32b8ffe62f9578a55c9049d0c13fc6da7e83 ----------------------------------------------------------------------- Summary of changes: jobs/gerrit-verifications.yml | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- CI scripts From gitosis at osmocom.org Fri Dec 15 18:20:18 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 18:20:18 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-17-g9121318 Message-ID: <201712151820.vBFIKIEx069584@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 912131803bfbc275e2d9f11fbb0e4413d7b44630 (commit) from 1a11d1db09bd7a17ff1bf4bfd5cc31e6f4fbd06d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=912131803bfbc275e2d9f11fbb0e4413d7b44630 commit 912131803bfbc275e2d9f11fbb0e4413d7b44630 Author: Max Date: Fri Dec 15 17:44:47 2017 +0100 TBF: remove unused variable The num_T_exp is write-only so it can be safely dropped. Change-Id: I94d83ca8c9b2f0732b53fdf42b17ba93cd7f1c15 ----------------------------------------------------------------------- Summary of changes: src/tbf.cpp | 4 ---- src/tbf.h | 1 - 2 files changed, 5 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Fri Dec 15 20:36:53 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 20:36:53 GMT Subject: osmo-ci.git branch master updated. 85f74b5c908fd5ede0709850b7dfbed11e947917 Message-ID: <201712152036.vBFKarMt020683@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 85f74b5c908fd5ede0709850b7dfbed11e947917 (commit) via 51f77030fb20fc76f98bd22c8d940059e94e3c5b (commit) via fd7b2aae89b4d940408f09f529541c726851a1ab (commit) via 27af5a2c6fdd261010856c1b62a9f63127abdda3 (commit) via 7e12155042f87ff24280c9e2258a648f76a82153 (commit) via 163eef27de017856aef3208122e1cf7f3e59313f (commit) via b62f264eaf4ad80434e6828a337b2cfa09084fc9 (commit) via 4711c925828f98190e0c447a0ddc6066087daa25 (commit) via 7fd10510d2535ca6b393edbae30bbeb8082784fb (commit) via 520c8a58d4b230f726a0d8df0af0010fcc48228c (commit) from 1e857dcf1fb0799b39d7c04dcee3704f997b84e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=85f74b5c908fd5ede0709850b7dfbed11e947917 commit 85f74b5c908fd5ede0709850b7dfbed11e947917 Author: Neels Hofmeyr Date: Fri Dec 15 20:29:31 2017 +0100 jobs: gerrit: fix osmo-python-tests: gerrit project name Change-Id: Idb4e93d88123f0a7e403af627345300dae86aca7 http://cgit.osmocom.org/osmo-ci/commit/?id=51f77030fb20fc76f98bd22c8d940059e94e3c5b commit 51f77030fb20fc76f98bd22c8d940059e94e3c5b Author: Neels Hofmeyr Date: Fri Dec 15 19:54:51 2017 +0100 jobs: gerrit: fix osmo-ttcn3-hacks scm and slave Change-Id: I252c103450ad0da59ab18c88d78f20c750b22c98 http://cgit.osmocom.org/osmo-ci/commit/?id=fd7b2aae89b4d940408f09f529541c726851a1ab commit fd7b2aae89b4d940408f09f529541c726851a1ab Author: Neels Hofmeyr Date: Fri Dec 15 19:55:35 2017 +0100 jobs: gerrit: fix URL for osmo-python-tests Change-Id: Icaa44207ebbdc03c3af1a32f7491d2b4c9fb982d http://cgit.osmocom.org/osmo-ci/commit/?id=27af5a2c6fdd261010856c1b62a9f63127abdda3 commit 27af5a2c6fdd261010856c1b62a9f63127abdda3 Author: Neels Hofmeyr Date: Fri Dec 15 19:54:29 2017 +0100 jobs: gerrit-verifications: make repos_url configurable Change-Id: I24aadc2aeeeda762df61e7c56e4159a730010c97 http://cgit.osmocom.org/osmo-ci/commit/?id=7e12155042f87ff24280c9e2258a648f76a82153 commit 7e12155042f87ff24280c9e2258a648f76a82153 Author: Neels Hofmeyr Date: Fri Dec 15 19:31:00 2017 +0100 jobs: master: osmo-gsm-manuals: use new jenkins.sh, only on OsmoBuild1 Change-Id: Ida1301a3f83caff400e80c8b46504f98cb0894ab http://cgit.osmocom.org/osmo-ci/commit/?id=163eef27de017856aef3208122e1cf7f3e59313f commit 163eef27de017856aef3208122e1cf7f3e59313f Author: Neels Hofmeyr Date: Fri Dec 15 19:30:30 2017 +0100 jobs: cosmetic: readability: docker one-arg-per-line Change-Id: I8b18a5bc54a879002b40b0fc51cd295e82beba4f http://cgit.osmocom.org/osmo-ci/commit/?id=b62f264eaf4ad80434e6828a337b2cfa09084fc9 commit b62f264eaf4ad80434e6828a337b2cfa09084fc9 Author: Neels Hofmeyr Date: Fri Dec 15 19:29:42 2017 +0100 jobs: master: adjust triggers to what was found on old jenkins jobs Change-Id: Ib59247978ed92b72949260a79628b28754a44484 http://cgit.osmocom.org/osmo-ci/commit/?id=4711c925828f98190e0c447a0ddc6066087daa25 commit 4711c925828f98190e0c447a0ddc6066087daa25 Author: Neels Hofmeyr Date: Fri Dec 15 04:38:03 2017 +0100 jobs: add update-osmo-python-on-slaves.yml Change-Id: Ib3982e1f18286cc45d5c7b849abfb91cad9e1b27 http://cgit.osmocom.org/osmo-ci/commit/?id=7fd10510d2535ca6b393edbae30bbeb8082784fb commit 7fd10510d2535ca6b393edbae30bbeb8082784fb Author: Neels Hofmeyr Date: Fri Dec 15 04:40:29 2017 +0100 jobs: fix poll-scm on update-osmo-ci-on-slaves poll-scm was missing by accident Change-Id: I027c5fa12c8be9434e3efec11976004c7924c472 http://cgit.osmocom.org/osmo-ci/commit/?id=520c8a58d4b230f726a0d8df0af0010fcc48228c commit 520c8a58d4b230f726a0d8df0af0010fcc48228c Author: Neels Hofmeyr Date: Fri Dec 15 04:37:46 2017 +0100 jobs: add build2-deb8build to update-osmo-ci-on-slaves job Change-Id: I48246067f05227efc18b46cb1b29d1c50f4eab84 ----------------------------------------------------------------------- Summary of changes: jobs/gerrit-verifications.yml | 16 +++--- jobs/master-builds.yml | 91 +++++++++++++++++++++++------------ jobs/update-osmo-ci-on-slaves.yml | 8 ++- jobs/update-osmo-python-on-slaves.yml | 37 ++++++++++++++ 4 files changed, 112 insertions(+), 40 deletions(-) create mode 100644 jobs/update-osmo-python-on-slaves.yml hooks/post-receive -- CI scripts From gitosis at osmocom.org Fri Dec 15 20:36:58 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 15 Dec 2017 20:36:58 GMT Subject: osmo-python-tests.git branch master updated. 7f7c4b441027ff64bddafe2a378e0d1a72f8b285 Message-ID: <201712152036.vBFKawkX020773@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 7f7c4b441027ff64bddafe2a378e0d1a72f8b285 (commit) from 738acb7b0231dab182b7f79525d00c7a613787a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=7f7c4b441027ff64bddafe2a378e0d1a72f8b285 commit 7f7c4b441027ff64bddafe2a378e0d1a72f8b285 Author: Max Date: Fri Dec 15 12:12:01 2017 +0100 Use setuptools for packaging According to https://docs.python.org/3/library/distutils.html the setuptools are used in place of distutils anyway. Using it directly allows us to make packaging more flexible: specify dependencies, automatically find package name etc. Change-Id: I39ee53f352001e47c6df055cbec52d638480253d ----------------------------------------------------------------------- Summary of changes: osmopy/__init__.py | 2 +- setup.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Sat Dec 16 03:58:03 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 16 Dec 2017 03:58:03 GMT Subject: libosmocore.git branch neels/ctrl_parsing created. 0.10.2-71-g8bf8e15a Message-ID: <201712160358.vBG3w30v017091@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/ctrl_parsing has been created at 8bf8e15a972395e34e4fc74d26717d9f7a6c3838 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=8bf8e15a972395e34e4fc74d26717d9f7a6c3838 commit 8bf8e15a972395e34e4fc74d26717d9f7a6c3838 Author: Neels Hofmeyr Date: Sat Dec 16 04:54:37 2017 +0100 fix osmo_identifier_valid(): only allow printable characters In particular disallow ASCII 0..31 (control characters) and 127 (DEL). Change-Id: I04469988495af03c881fe81d7786ca7f71636299 http://cgit.osmocom.org/libosmocore/commit/?id=c4806250b2ef32dd9a2f6282a406e054c479a134 commit c4806250b2ef32dd9a2f6282a406e054c479a134 Author: Neels Hofmeyr Date: Sat Dec 16 04:53:51 2017 +0100 tighten ctrl parsing fu Change-Id: Ide9578f659eba160aec3edcd435e1c67da41bdab http://cgit.osmocom.org/libosmocore/commit/?id=6c8a8cd177d67e53ee89bea75d67358b9ab20cb5 commit 6c8a8cd177d67e53ee89bea75d67358b9ab20cb5 Author: Neels Hofmeyr Date: Sat Dec 16 01:19:43 2017 +0100 ctrl_test Change-Id: I487b4e1e103f46cf757953c7791f5b02809f03aa http://cgit.osmocom.org/libosmocore/commit/?id=4cc07ab586063fd036c0f4f572b6d54bc47e89a7 commit 4cc07ab586063fd036c0f4f572b6d54bc47e89a7 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:53 2017 +0100 ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET REPLY' and 'TRAP' as appropriate. Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 http://cgit.osmocom.org/libosmocore/commit/?id=ff46f3773935ffa4109bd29fa2ea52982d40f6f1 commit ff46f3773935ffa4109bd29fa2ea52982d40f6f1 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:11 2017 +0100 ctrl: tighten CTRL input parsing Change-Id: I96a9b6b6a3a5e0b80513aa9eaa727ae8c9c7d7a1 http://cgit.osmocom.org/libosmocore/commit/?id=d47abac6085d5a1e46b4258da90e540c26f176c0 commit d47abac6085d5a1e46b4258da90e540c26f176c0 Author: Neels Hofmeyr Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=90b6bf485efea05f16d85c03c944c3a97ec0b0f7 commit 90b6bf485efea05f16d85c03c944c3a97ec0b0f7 Author: Neels Hofmeyr Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. Deprecate ctrl_cmd_parse(). Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=8998cf382e41c739f4cfcbf927ec0944661d75d9 commit 8998cf382e41c739f4cfcbf927ec0944661d75d9 Author: Neels Hofmeyr Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b http://cgit.osmocom.org/libosmocore/commit/?id=3d48ef50978a6df98c276f8c21931037c3b85156 commit 3d48ef50978a6df98c276f8c21931037c3b85156 Author: Neels Hofmeyr Date: Sat Dec 16 00:54:52 2017 +0100 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped() function, which will be replaced by osmo_escape_str() in a subsequent patch. control_cmd.c will use osmo_escape_str() to log invalid identifiers. Change-Id: Ic685eb63dead3967d01aaa4f1e9899e5461ca49a http://cgit.osmocom.org/libosmocore/commit/?id=8f03bb0593be60702bcd23a812e2dfbd38f7cb64 commit 8f03bb0593be60702bcd23a812e2dfbd38f7cb64 Author: Neels Hofmeyr Date: Sat Dec 16 00:46:50 2017 +0100 utils: add osmo_separated_identifiers_valid() For validating CTRL input, we want to verify that an input variable is a series of valid osmo_identifier_valid() separated by dots. Allow validating any additional chars with identifiers, for CTRL vars will be just ".". Change-Id: I13dfd02c8c870620f937d789873ad84c6b1c45de http://cgit.osmocom.org/libosmocore/commit/?id=251970eb69dd0d754dd7b97560381245f630d1b3 commit 251970eb69dd0d754dd7b97560381245f630d1b3 Author: Neels Hofmeyr Date: Tue Sep 26 14:21:44 2017 +0200 CTRL: GET parsing: add '\n' as token delimiter For GET commands, we expect the command to end after the GET variable name. However, the token parsing uses a single space as delimiter, potentially parsing along the line ending. Add line ending to token delimiters for GET parsing. Adjust test expectations accordingly. Change-Id: I33efb56f76cb7a41e94454666e218617e9b713ae http://cgit.osmocom.org/libosmocore/commit/?id=f5d35b977eeee03b66219ed7b83f94fa5f4fe111 commit f5d35b977eeee03b66219ed7b83f94fa5f4fe111 Author: Neels Hofmeyr Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=5bb1816f804aba4c731d6665239a2d35dfb355b0 commit 5bb1816f804aba4c731d6665239a2d35dfb355b0 Author: Neels Hofmeyr Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=304e6b4cbf949e688c2fb12e83095afba2f32e2c commit 304e6b4cbf949e688c2fb12e83095afba2f32e2c Author: Neels Hofmeyr Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=17a4116a495842e4e5ebafb00c6af996267def4b commit 17a4116a495842e4e5ebafb00c6af996267def4b Author: Neels Hofmeyr Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sat Dec 16 04:55:21 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 16 Dec 2017 04:55:21 GMT Subject: libosmocore.git branch neels/ctrl_parsing updated. 0.10.2-72-gcb192f62 Message-ID: <201712160455.vBG4tLsi046289@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/ctrl_parsing has been updated discards 8bf8e15a972395e34e4fc74d26717d9f7a6c3838 (commit) discards c4806250b2ef32dd9a2f6282a406e054c479a134 (commit) discards 6c8a8cd177d67e53ee89bea75d67358b9ab20cb5 (commit) discards 4cc07ab586063fd036c0f4f572b6d54bc47e89a7 (commit) discards ff46f3773935ffa4109bd29fa2ea52982d40f6f1 (commit) discards d47abac6085d5a1e46b4258da90e540c26f176c0 (commit) discards 90b6bf485efea05f16d85c03c944c3a97ec0b0f7 (commit) discards 8998cf382e41c739f4cfcbf927ec0944661d75d9 (commit) discards 3d48ef50978a6df98c276f8c21931037c3b85156 (commit) discards 8f03bb0593be60702bcd23a812e2dfbd38f7cb64 (commit) discards 251970eb69dd0d754dd7b97560381245f630d1b3 (commit) discards f5d35b977eeee03b66219ed7b83f94fa5f4fe111 (commit) discards 5bb1816f804aba4c731d6665239a2d35dfb355b0 (commit) discards 304e6b4cbf949e688c2fb12e83095afba2f32e2c (commit) discards 17a4116a495842e4e5ebafb00c6af996267def4b (commit) via cb192f629ff7e042a873dbbb9fcee68f8596a4c4 (commit) via fec5d8d593785095d403c6c205f5473c0bce930e (commit) via 25fa09e49812a96dafe570d20e7ffb07ccfd55c1 (commit) via f5609e3a811273c6b38c907453779ed76993a845 (commit) via 7f77a9039d2c5198d293b5ac0a076b7961dfe3ae (commit) via 0a8b5206e6615b88b47f5c17282c91a7a5c7af39 (commit) via 63a72a200c6e7809856920931661af43e4f14ddb (commit) via d1b021d979024ee42a51102ead6bf4e3a87a393e (commit) via 30fc3e039a0f8a767c2807ffc4b7c56704ee203c (commit) via b945e4f67a3bbc931056cd09c02ed4a585cbfe93 (commit) via 742447d68be6487e0c278096ab5df3b4136a4a40 (commit) via 310e5d697873461abdbed74e58c88841d013db09 (commit) via 004a7da23f9b1426a33b6793b994419d8ab766b7 (commit) via 7fe60fe3d0576adbbd82919f43cfbb431a8d0c6a (commit) via 65caf44d917c3bfa6c7fa2269aaa81d94981aad4 (commit) via 62cc9bfee0c1cf30647d7f97261cc02519c797e9 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (8bf8e15a972395e34e4fc74d26717d9f7a6c3838) \ N -- N -- N (cb192f629ff7e042a873dbbb9fcee68f8596a4c4) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=cb192f629ff7e042a873dbbb9fcee68f8596a4c4 commit cb192f629ff7e042a873dbbb9fcee68f8596a4c4 Author: Neels Hofmeyr Date: Sat Dec 16 04:53:51 2017 +0100 tighten ctrl parsing fu Change-Id: Ide9578f659eba160aec3edcd435e1c67da41bdab http://cgit.osmocom.org/libosmocore/commit/?id=fec5d8d593785095d403c6c205f5473c0bce930e commit fec5d8d593785095d403c6c205f5473c0bce930e Author: Neels Hofmeyr Date: Sat Dec 16 01:19:43 2017 +0100 ctrl_test Change-Id: I487b4e1e103f46cf757953c7791f5b02809f03aa http://cgit.osmocom.org/libosmocore/commit/?id=25fa09e49812a96dafe570d20e7ffb07ccfd55c1 commit 25fa09e49812a96dafe570d20e7ffb07ccfd55c1 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:53 2017 +0100 ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET REPLY' and 'TRAP' as appropriate. Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 http://cgit.osmocom.org/libosmocore/commit/?id=f5609e3a811273c6b38c907453779ed76993a845 commit f5609e3a811273c6b38c907453779ed76993a845 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:11 2017 +0100 ctrl: tighten CTRL input parsing Change-Id: I96a9b6b6a3a5e0b80513aa9eaa727ae8c9c7d7a1 http://cgit.osmocom.org/libosmocore/commit/?id=7f77a9039d2c5198d293b5ac0a076b7961dfe3ae commit 7f77a9039d2c5198d293b5ac0a076b7961dfe3ae Author: Neels Hofmeyr Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=0a8b5206e6615b88b47f5c17282c91a7a5c7af39 commit 0a8b5206e6615b88b47f5c17282c91a7a5c7af39 Author: Neels Hofmeyr Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. Deprecate ctrl_cmd_parse(). Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=63a72a200c6e7809856920931661af43e4f14ddb commit 63a72a200c6e7809856920931661af43e4f14ddb Author: Neels Hofmeyr Date: Tue Sep 26 14:21:44 2017 +0200 CTRL: GET parsing: add '\n' as token delimiter For GET commands, we expect the command to end after the GET variable name. However, the token parsing uses a single space as delimiter, potentially parsing along the line ending. Add line ending to token delimiters for GET parsing. Adjust test expectations accordingly. Change-Id: I33efb56f76cb7a41e94454666e218617e9b713ae http://cgit.osmocom.org/libosmocore/commit/?id=d1b021d979024ee42a51102ead6bf4e3a87a393e commit d1b021d979024ee42a51102ead6bf4e3a87a393e Author: Neels Hofmeyr Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 http://cgit.osmocom.org/libosmocore/commit/?id=30fc3e039a0f8a767c2807ffc4b7c56704ee203c commit 30fc3e039a0f8a767c2807ffc4b7c56704ee203c Author: Neels Hofmeyr Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=b945e4f67a3bbc931056cd09c02ed4a585cbfe93 commit b945e4f67a3bbc931056cd09c02ed4a585cbfe93 Author: Neels Hofmeyr Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=742447d68be6487e0c278096ab5df3b4136a4a40 commit 742447d68be6487e0c278096ab5df3b4136a4a40 Author: Neels Hofmeyr Date: Sat Dec 16 05:38:37 2017 +0100 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f http://cgit.osmocom.org/libosmocore/commit/?id=310e5d697873461abdbed74e58c88841d013db09 commit 310e5d697873461abdbed74e58c88841d013db09 Author: Neels Hofmeyr Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=004a7da23f9b1426a33b6793b994419d8ab766b7 commit 004a7da23f9b1426a33b6793b994419d8ab766b7 Author: Neels Hofmeyr Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b http://cgit.osmocom.org/libosmocore/commit/?id=7fe60fe3d0576adbbd82919f43cfbb431a8d0c6a commit 7fe60fe3d0576adbbd82919f43cfbb431a8d0c6a Author: Neels Hofmeyr Date: Sat Dec 16 00:54:52 2017 +0100 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped() function, which will be replaced by osmo_escape_str() in a subsequent patch. control_cmd.c will use osmo_escape_str() to log invalid identifiers. Change-Id: Ic685eb63dead3967d01aaa4f1e9899e5461ca49a http://cgit.osmocom.org/libosmocore/commit/?id=65caf44d917c3bfa6c7fa2269aaa81d94981aad4 commit 65caf44d917c3bfa6c7fa2269aaa81d94981aad4 Author: Neels Hofmeyr Date: Sat Dec 16 00:46:50 2017 +0100 utils: add osmo_separated_identifiers_valid() For validating CTRL input, we want to verify that an input variable is a series of valid osmo_identifier_valid() separated by dots. Allow validating any additional chars with identifiers, for CTRL vars will be just ".". Change-Id: I13dfd02c8c870620f937d789873ad84c6b1c45de http://cgit.osmocom.org/libosmocore/commit/?id=62cc9bfee0c1cf30647d7f97261cc02519c797e9 commit 62cc9bfee0c1cf30647d7f97261cc02519c797e9 Author: Neels Hofmeyr Date: Sat Dec 16 04:54:37 2017 +0100 fix osmo_identifier_valid(): only allow printable characters In particular disallow ASCII 0..31 (control characters) and 127 (DEL). Change-Id: I04469988495af03c881fe81d7786ca7f71636299 ----------------------------------------------------------------------- Summary of changes: tests/ctrl/ctrl_test.c | 186 ++++++++++++++++++++++++++----------------------- 1 file changed, 97 insertions(+), 89 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sat Dec 16 05:24:32 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 16 Dec 2017 05:24:32 GMT Subject: libosmocore.git branch neels/ctrl_parsing updated. 0.10.2-69-g179f3a01 Message-ID: <201712160524.vBG5OWIR061346@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/ctrl_parsing has been updated discards cb192f629ff7e042a873dbbb9fcee68f8596a4c4 (commit) discards fec5d8d593785095d403c6c205f5473c0bce930e (commit) discards 25fa09e49812a96dafe570d20e7ffb07ccfd55c1 (commit) discards f5609e3a811273c6b38c907453779ed76993a845 (commit) discards 7f77a9039d2c5198d293b5ac0a076b7961dfe3ae (commit) discards 0a8b5206e6615b88b47f5c17282c91a7a5c7af39 (commit) discards 63a72a200c6e7809856920931661af43e4f14ddb (commit) discards d1b021d979024ee42a51102ead6bf4e3a87a393e (commit) discards 30fc3e039a0f8a767c2807ffc4b7c56704ee203c (commit) discards b945e4f67a3bbc931056cd09c02ed4a585cbfe93 (commit) discards 742447d68be6487e0c278096ab5df3b4136a4a40 (commit) discards 310e5d697873461abdbed74e58c88841d013db09 (commit) discards 004a7da23f9b1426a33b6793b994419d8ab766b7 (commit) via 179f3a01446556d0d8eeb816c0c2b68034495180 (commit) via c16258365ea80c9d35558e38eaa7f482eb357f24 (commit) via e56600fa42e0a229a1a5bcf95fc8d3b9a4c053ac (commit) via b61510abaeec814dfdf6f33ff5534c6ac1d6020f (commit) via 4602cbff6231d7c106b880c5a4f45c2fca6e640f (commit) via 0e759be493086f13ad476e08e5ba4c70b5a2c689 (commit) via 4dbc6fca9a177941af2a3d3f8e3cabfb0825e80d (commit) via 62feb5389c06f9fec19d21ba623195c59a2864cd (commit) via 414901b2cd688783f56fced6311d5d7abfaaa98f (commit) via 976214df85b004310ab49708d9170a1f5d14a039 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (cb192f629ff7e042a873dbbb9fcee68f8596a4c4) \ N -- N -- N (179f3a01446556d0d8eeb816c0c2b68034495180) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=179f3a01446556d0d8eeb816c0c2b68034495180 commit 179f3a01446556d0d8eeb816c0c2b68034495180 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:53 2017 +0100 ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET REPLY' and 'TRAP' as appropriate. Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 http://cgit.osmocom.org/libosmocore/commit/?id=c16258365ea80c9d35558e38eaa7f482eb357f24 commit c16258365ea80c9d35558e38eaa7f482eb357f24 Author: Neels Hofmeyr Date: Tue Sep 26 14:21:44 2017 +0200 ctrl: tighten CTRL input parsing Validate that incoming CTRL commands... - have decimal IDs, - return error on trailing characters, - have invalid characters in variable identifiers, - send detailed error messages as reply to the requestor. Adjust ctrl_test.{c,ok}, which best show the change in behavior. Change-Id: I96a9b6b6a3a5e0b80513aa9eaa727ae8c9c7d7a1 http://cgit.osmocom.org/libosmocore/commit/?id=e56600fa42e0a229a1a5bcf95fc8d3b9a4c053ac commit e56600fa42e0a229a1a5bcf95fc8d3b9a4c053ac Author: Neels Hofmeyr Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=b61510abaeec814dfdf6f33ff5534c6ac1d6020f commit b61510abaeec814dfdf6f33ff5534c6ac1d6020f Author: Neels Hofmeyr Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. No need really to deprecate ctrl_cmd_parse() yet; especially as long as compiler warnings might break jenkins builds. Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=4602cbff6231d7c106b880c5a4f45c2fca6e640f commit 4602cbff6231d7c106b880c5a4f45c2fca6e640f Author: Neels Hofmeyr Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 http://cgit.osmocom.org/libosmocore/commit/?id=0e759be493086f13ad476e08e5ba4c70b5a2c689 commit 0e759be493086f13ad476e08e5ba4c70b5a2c689 Author: Neels Hofmeyr Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=4dbc6fca9a177941af2a3d3f8e3cabfb0825e80d commit 4dbc6fca9a177941af2a3d3f8e3cabfb0825e80d Author: Neels Hofmeyr Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=62feb5389c06f9fec19d21ba623195c59a2864cd commit 62feb5389c06f9fec19d21ba623195c59a2864cd Author: Neels Hofmeyr Date: Sat Dec 16 05:38:37 2017 +0100 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f http://cgit.osmocom.org/libosmocore/commit/?id=414901b2cd688783f56fced6311d5d7abfaaa98f commit 414901b2cd688783f56fced6311d5d7abfaaa98f Author: Neels Hofmeyr Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=976214df85b004310ab49708d9170a1f5d14a039 commit 976214df85b004310ab49708d9170a1f5d14a039 Author: Neels Hofmeyr Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b ----------------------------------------------------------------------- Summary of changes: include/osmocom/ctrl/control_cmd.h | 2 +- tests/ctrl/ctrl_test.c | 44 +++++---- tests/ctrl/ctrl_test.ok | 191 +++++++++++++++++++++++-------------- tests/testsuite.at | 2 +- 4 files changed, 147 insertions(+), 92 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sat Dec 16 08:46:59 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 16 Dec 2017 08:46:59 GMT Subject: osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-1984-g9b511668 Message-ID: <201712160846.vBG8kx5H051239@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via 9b511668a48b2c7ef7646278b1d2cbdc19441490 (commit) via 21049e5fc46223670c259fedb413bd179bb4ffb2 (commit) via 0b5231bdb4172adac64828bbcc57ac7b74411590 (commit) via d2c13e3d209565a4bd1c6776e3a5a86f7ea5d857 (commit) via 3d872d0eae76b42b0fdf235f2df196c8bc5abb7c (commit) via 2937cb4c16b6e5b9cf4fa139cfcaf678946f6cb2 (commit) via ab566a7aef67eeb2abd19fedc7ed8fc33e9de684 (commit) via af217395ccd058a8aeab6992c0bd0743a8e6895e (commit) via 26ecb9460e1871b26a5e3a3c72c2f7163ece2652 (commit) via 05ff6b06674dd3b9c310e3b27e5bad821cd6d41c (commit) from 8ed6f42772f3002bfa1b8ef8772b138e8cddd443 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=9b511668a48b2c7ef7646278b1d2cbdc19441490 commit 9b511668a48b2c7ef7646278b1d2cbdc19441490 Author: Vadim Yanitskiy Date: Mon Aug 7 14:24:18 2017 +0600 host/trxcon/scheduler: add initial TCH/F channel support This change implements basic TCH/F lchan handlers for both data reception and transmission. Only FACCH (signaling), FR and EFR payloads are supported at the moment. Change-Id: If6b0eaede2b484484d2a824e7219ff04483266a1 http://cgit.osmocom.org/osmocom-bb/commit/?id=21049e5fc46223670c259fedb413bd179bb4ffb2 commit 21049e5fc46223670c259fedb413bd179bb4ffb2 Author: Vadim Yanitskiy Date: Sun Aug 13 01:35:22 2017 +0600 host/trxcon/l1ctl.c: handle L1CTL_TRAFFIC_REQ Change-Id: Ibdf2d4f6aa464250a4c6951af86c06eb3fd3b98b http://cgit.osmocom.org/osmocom-bb/commit/?id=0b5231bdb4172adac64828bbcc57ac7b74411590 commit 0b5231bdb4172adac64828bbcc57ac7b74411590 Author: Vadim Yanitskiy Date: Thu Dec 14 04:03:59 2017 +0700 common/l1ctl.c move TCH bit-ordering to the firmware Previously, TCH frames coming from L1 were reordered to the RTP format. Moreover, the implementation had a few problems: - L1CTL is not the best place for such manipulations; - payloads with other than FR codec were corrupted. Let's use RTP-ordered payloads on the L1CTL interface, performing TCH frame reordering at the firmware. Please note, that actual FR reordering was moved to the firmware as is, without any codec determination. This could be fixed in a separate change. Change-Id: I235a9f535c39d8e57f5d2c6566daeaf883aeef9e http://cgit.osmocom.org/osmocom-bb/commit/?id=d2c13e3d209565a4bd1c6776e3a5a86f7ea5d857 commit d2c13e3d209565a4bd1c6776e3a5a86f7ea5d857 Author: Vadim Yanitskiy Date: Sat Dec 16 15:04:41 2017 +0700 host/trxcon/scheduler: use GSM_MACBLOCK_LEN definition Change-Id: Ie3b27ecb62d6f0e84f2e3ec0c1558e32bb213d33 http://cgit.osmocom.org/osmocom-bb/commit/?id=3d872d0eae76b42b0fdf235f2df196c8bc5abb7c commit 3d872d0eae76b42b0fdf235f2df196c8bc5abb7c Author: Vadim Yanitskiy Date: Sat Dec 16 14:58:04 2017 +0700 host/trxcon/scheduler: drop meaningless memset call Change-Id: I18a938cef350632673cfc820beed5e42f40d89e7 http://cgit.osmocom.org/osmocom-bb/commit/?id=2937cb4c16b6e5b9cf4fa139cfcaf678946f6cb2 commit 2937cb4c16b6e5b9cf4fa139cfcaf678946f6cb2 Author: Vadim Yanitskiy Date: Sat Dec 16 14:53:48 2017 +0700 host/trxcon/scheduler: clean up the trx_lchan_state There were some BTS specific variables, which are meaningless. This change cleans them up, and also groups some measurement, encryption, and AMR specific variables into sub-structures. Change-Id: Ie753a7e3e7fa2b433d8319b3a05b85b8583d7be2 http://cgit.osmocom.org/osmocom-bb/commit/?id=ab566a7aef67eeb2abd19fedc7ed8fc33e9de684 commit ab566a7aef67eeb2abd19fedc7ed8fc33e9de684 Author: Vadim Yanitskiy Date: Sat Dec 16 15:09:51 2017 +0700 host/trxcon/scheduler: use new libosmocoding API for RACH Since the 32e5641d, the gsm0503_rach_encode() is deprecated, and the library provides new API with extended (11-bit) RACH support. Change-Id: I1955fe46eebd173d6eddd1d47ee9f7318b9b4e2d http://cgit.osmocom.org/osmocom-bb/commit/?id=af217395ccd058a8aeab6992c0bd0743a8e6895e commit af217395ccd058a8aeab6992c0bd0743a8e6895e Author: Vadim Yanitskiy Date: Sat Dec 9 01:25:52 2017 +0700 fake_trx: don't sent clock indications until POWERON Change-Id: I86ccc9d26fc54e6511f74f858afdaebb2b284c19 http://cgit.osmocom.org/osmocom-bb/commit/?id=26ecb9460e1871b26a5e3a3c72c2f7163ece2652 commit 26ecb9460e1871b26a5e3a3c72c2f7163ece2652 Author: Vadim Yanitskiy Date: Sat Dec 9 01:24:05 2017 +0700 fake_trx/clck_gen.py: reset the clck_src when calling stop() Change-Id: I1043f71a2cbe856a0cb605db8a7feab9defa6afd http://cgit.osmocom.org/osmocom-bb/commit/?id=05ff6b06674dd3b9c310e3b27e5bad821cd6d41c commit 05ff6b06674dd3b9c310e3b27e5bad821cd6d41c Author: Vadim Yanitskiy Date: Sat Dec 9 01:22:24 2017 +0700 fake_trx/clck_gen.py: send the first indication immediately Change-Id: I0132dd939b02db357d248abf65c9116d6a1802d0 ----------------------------------------------------------------------- Summary of changes: src/host/layer23/src/common/l1ctl.c | 39 ----- src/host/trxcon/Makefile.am | 1 + src/host/trxcon/l1ctl.c | 40 +++++ src/host/trxcon/sched_lchan_common.c | 88 +++++++++- src/host/trxcon/sched_lchan_desc.c | 9 +- src/host/trxcon/sched_lchan_rach.c | 5 +- .../{sched_lchan_xcch.c => sched_lchan_tchf.c} | 182 ++++++++++++++------- src/host/trxcon/sched_lchan_xcch.c | 36 ++-- src/host/trxcon/sched_trx.h | 98 ++++++----- src/target/fake_trx/clck_gen.py | 19 ++- src/target/fake_trx/ctrl_if_bts.py | 9 + src/target/fake_trx/fake_trx.py | 2 +- src/target/firmware/Makefile | 3 +- src/target/firmware/layer1/prim_tch.c | 52 ++++++ 14 files changed, 399 insertions(+), 184 deletions(-) copy src/host/trxcon/{sched_lchan_xcch.c => sched_lchan_tchf.c} (52%) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sat Dec 16 09:38:21 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 16 Dec 2017 09:38:21 GMT Subject: osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-1986-g60ff6144 Message-ID: <201712160938.vBG9cLCH074741@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via 60ff614446fedc7b12767d9520abfc529a65fc7e (commit) via a9c2ef2638523d62f1f9eecb1c6c326f4c6519b6 (commit) from 9b511668a48b2c7ef7646278b1d2cbdc19441490 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=60ff614446fedc7b12767d9520abfc529a65fc7e commit 60ff614446fedc7b12767d9520abfc529a65fc7e Author: Vadim Yanitskiy Date: Sat Dec 16 16:33:17 2017 +0700 host/trxcon/scheduler: always print error messages Some error messages previously had incorrect logging level 'debug'. We aren't going to hide anything, right? Let's print them! Change-Id: I85fb37292046b667386bfe26b9bbb000600e1c6f http://cgit.osmocom.org/osmocom-bb/commit/?id=a9c2ef2638523d62f1f9eecb1c6c326f4c6519b6 commit a9c2ef2638523d62f1f9eecb1c6c326f4c6519b6 Author: Vadim Yanitskiy Date: Sat Dec 16 16:21:05 2017 +0700 host/trxcon/scheduler: inform L2&3 about decoding errors Previously, we used to drop a frame if decoding wasn't successful. This way, the higher layers didn't even know about that, so the local counters and Measurement Reports were incomplete. This change makes scheduler to forward L2 frames in any case, setting the num_biterr for each of them. In case of decoding error, a dummy (payload filled by 0x00) L2 frame will be sent. Change-Id: I31011d8f3ca8b9a12474cd0bc653faed18391033 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/sched_lchan_common.c | 16 +++++++++++----- src/host/trxcon/sched_lchan_sch.c | 2 +- src/host/trxcon/sched_lchan_tchf.c | 11 +++++++---- src/host/trxcon/sched_lchan_xcch.c | 8 ++++---- src/host/trxcon/sched_trx.h | 4 +++- 5 files changed, 26 insertions(+), 15 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sat Dec 16 13:20:21 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 16 Dec 2017 13:20:21 GMT Subject: osmo-hlr.git branch master updated. 0.1.0-21-gb5d7701 Message-ID: <201712161320.vBGDKLcP069755@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via b5d77012d1d74bbb28b07a374c436045ed3e43ea (commit) via fc96f688d4cfe339a6e5db14e4345270ce16ce11 (commit) from 43bd6069e83ff034dcaff4780891d0468e899b07 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=b5d77012d1d74bbb28b07a374c436045ed3e43ea commit b5d77012d1d74bbb28b07a374c436045ed3e43ea Author: Pau Espin Pedrol Date: Fri Dec 15 19:06:59 2017 +0100 contrib:jenkins.sh: Enable Werror Change-Id: I61688a4c9b50f6f3705bd18c96c00f8703ef5042 http://cgit.osmocom.org/osmo-hlr/commit/?id=fc96f688d4cfe339a6e5db14e4345270ce16ce11 commit fc96f688d4cfe339a6e5db14e4345270ce16ce11 Author: Pau Espin Pedrol Date: Fri Dec 15 19:05:08 2017 +0100 luop.c: Transform FIXME from warning to pragma message This way the issue is still visible but we can enable Werror to avoid introducing new warnings. Change-Id: I6c9b195bf0e3f853e202cdbdb72d35d83cd2a2ab ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- src/luop.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Sun Dec 17 12:38:51 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 17 Dec 2017 12:38:51 GMT Subject: osmo-bts.git branch laforge/omldummy created. 0.7.0-33-ge990d6d Message-ID: <201712171238.vBHCcpgb049601@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, laforge/omldummy has been created at e990d6d49a694f2dfad5135088e5de871217f0af (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=e990d6d49a694f2dfad5135088e5de871217f0af commit e990d6d49a694f2dfad5135088e5de871217f0af Author: Harald Welte Date: Sun Dec 17 13:35:52 2017 +0100 HACK: Add 'osmo-bts-omldummy' to bring up only OML without RSL This is used only in integration testing, where in the TTCN-3 testsuite we currently have no A-bis OML implementation, but only a RSL one. Change-Id: Id8e5f34091e6e32621d8c8673de7ea848dfd252f ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Sun Dec 17 19:59:09 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 17 Dec 2017 19:59:09 GMT Subject: libosmocore.git branch master updated. 0.10.2-57-g62e40855 Message-ID: <201712171959.vBHJx9so053103@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 62e40855c2b1b50627dba5b187be8869e2cb2054 (commit) from 84ea2e037490a9ad6c0a192cf237f88fd83cdd88 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=62e40855c2b1b50627dba5b187be8869e2cb2054 commit 62e40855c2b1b50627dba5b187be8869e2cb2054 Author: Harald Welte Date: Sun Dec 17 20:50:34 2017 +0100 gsm0808_create_cipher_reject: Fix encoding of Cause IE The Cause IE in the 08.08 CIPHER MODE REJECT is a normal TLV IE, and not just a value. Let's make sure we encode the cause value properly. Change-Id: I4f5b231edf6dcb0a9c2bbafb2a59f301f3b2402b Closes: OS#2766 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm0808.c | 3 ++- tests/gsm0808/gsm0808_test.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 17 20:12:50 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 17 Dec 2017 20:12:50 GMT Subject: libosmocore.git branch master updated. 0.10.2-58-g3ef14a24 Message-ID: <201712172012.vBHKCoxE061794@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 3ef14a241afc123560e9a50d17948b040481b299 (commit) from 62e40855c2b1b50627dba5b187be8869e2cb2054 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=3ef14a241afc123560e9a50d17948b040481b299 commit 3ef14a241afc123560e9a50d17948b040481b299 Author: Max Date: Fri Dec 15 20:19:10 2017 +0100 Do not allocate already existing counter group Check that no group with the given name and index already exist before allocating it. Add corresponding test case. Change-Id: I563764af1d28043e909234ebb048239125ce6ecd Related: OS#2757 ----------------------------------------------------------------------- Summary of changes: src/rate_ctr.c | 3 +++ tests/stats/stats_test.c | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 17 21:58:12 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 17 Dec 2017 21:58:12 GMT Subject: libosmocore.git branch master updated. 0.10.2-60-g937ddea6 Message-ID: <201712172158.vBHLwC8a012569@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 937ddea6cce45f3f6dcb8177ea86162f15ecb5f9 (commit) via e5a2bdbc5501b892605a6a1fe7e30fb2f1546d42 (commit) from 3ef14a241afc123560e9a50d17948b040481b299 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=937ddea6cce45f3f6dcb8177ea86162f15ecb5f9 commit 937ddea6cce45f3f6dcb8177ea86162f15ecb5f9 Author: Neels Hofmeyr Date: Sat Dec 16 00:46:50 2017 +0100 utils: add osmo_separated_identifiers_valid() For validating CTRL input, we want to verify that an input variable is a series of valid osmo_identifier_valid() separated by dots. Allow validating any additional chars with identifiers, for CTRL vars will be just ".". Change-Id: I13dfd02c8c870620f937d789873ad84c6b1c45de http://cgit.osmocom.org/libosmocore/commit/?id=e5a2bdbc5501b892605a6a1fe7e30fb2f1546d42 commit e5a2bdbc5501b892605a6a1fe7e30fb2f1546d42 Author: Neels Hofmeyr Date: Sat Dec 16 04:54:37 2017 +0100 fix osmo_identifier_valid(): only allow printable characters In particular disallow ASCII 0..31 (control characters) and 127 (DEL). Change-Id: I04469988495af03c881fe81d7786ca7f71636299 ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/utils.h | 1 + src/utils.c | 23 +++++++++++++++++++---- 2 files changed, 20 insertions(+), 4 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Sun Dec 17 23:29:18 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 17 Dec 2017 23:29:18 GMT Subject: osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-1993-gfeec102a Message-ID: <201712172329.vBHNTId7055789@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via feec102aea039c4091fa9cf6075d45fd23448bd3 (commit) via 44838f79a2408feca664980d4b42a5c86b17db07 (commit) via 255f25ef25c5ce1deefcfbe63844bc47d524c377 (commit) via 32c2a1d74c1bb3f1cfa9a56b2e15b93fa321f942 (commit) via a403215beab8f92f7bd90fe8f80535bd61841b30 (commit) via 15d512d301545e10f69ade0562d5ea86832066b4 (commit) via e17bb11c3b29919799b3637dece1c7c0273af304 (commit) from 60ff614446fedc7b12767d9520abfc529a65fc7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=feec102aea039c4091fa9cf6075d45fd23448bd3 commit feec102aea039c4091fa9cf6075d45fd23448bd3 Author: Vadim Yanitskiy Date: Mon Dec 18 05:47:28 2017 +0700 trxcon/scheduler: implement A5/X ciphering support This change implements the A5/X ciphering support transparently for the logical channel handlers. In other words, a DL burst is deciphered before being passed to a handler, and an UL burst is ciphered before being sent to transceiver. The implementation mostly relays on the libosmocore's A5 API. Change-Id: Ib53418d8c0f394fdece09cf5cc240887cb0bb5af http://cgit.osmocom.org/osmocom-bb/commit/?id=44838f79a2408feca664980d4b42a5c86b17db07 commit 44838f79a2408feca664980d4b42a5c86b17db07 Author: Vadim Yanitskiy Date: Mon Dec 18 05:45:27 2017 +0700 trxcon/scheduler: preprocess UL bursts before sending Having a possibility to preprocess UL burst before sending to transceiver is required for the further ciphering support integration and probably some other tasks. Change-Id: Ia6eead5d4f51d7c0bf277b9d5ebb0a74676df567 http://cgit.osmocom.org/osmocom-bb/commit/?id=255f25ef25c5ce1deefcfbe63844bc47d524c377 commit 255f25ef25c5ce1deefcfbe63844bc47d524c377 Author: Vadim Yanitskiy Date: Sat Dec 16 17:52:31 2017 +0700 L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info Previously, the L1CTL_CRYPTO_REQ message contained only a ciphering algorithm and actual Kc key to be used. The key length was calculated manually using the MSGB API. Let's avoid manual calculations here, as it may cause unexpected behavior if the message structure is changed. Also, let's fill the UL header with minimal information about a channel, which is going to be encrypted. Change-Id: I1813a188e755141241273479b17896415abcc3f1 http://cgit.osmocom.org/osmocom-bb/commit/?id=32c2a1d74c1bb3f1cfa9a56b2e15b93fa321f942 commit 32c2a1d74c1bb3f1cfa9a56b2e15b93fa321f942 Author: Vadim Yanitskiy Date: Mon Dec 18 04:39:27 2017 +0700 trxcon/scheduler: prioritize FACCH correctly Previously we used to compare two consecutive first primitives, taken from a transmit queue. This approach may cause some delay, which is critical for FACCH e.g. in case of handover. Let's walk through a whole transmit queue to find a pair of both FACCH frames, and only then decide what to do. Change-Id: I925cca77bfaa255dd095bc882c901d41c9bc4633 http://cgit.osmocom.org/osmocom-bb/commit/?id=a403215beab8f92f7bd90fe8f80535bd61841b30 commit a403215beab8f92f7bd90fe8f80535bd61841b30 Author: Vadim Yanitskiy Date: Mon Dec 18 03:47:23 2017 +0700 trxcon/scheduler: move prim management outside lchan handlers Previously, each lchan handler used to obtain and delete primitives from a timeslot's tranmit queue itself. This approach entails many potential problems and bugs: - The lchan handlers shall not do that by definition, they should encode and decode frames according to GSM 05.03. - In some cases (e.g. TCH), a single transmit queue may contain primitives of different types (e.g. TCH, FACCH and SACCH). At the same time, the lchan handlers don't care and don't even know about each other. So, this could cause an unexpected behaviour in some cases. This change separates all primitive management routines, providing a new API for obtaining and dropping them. "Write programs that do one thing and do it well." Change-Id: I29503ece51903784bc53541015285234471c8d15 http://cgit.osmocom.org/osmocom-bb/commit/?id=15d512d301545e10f69ade0562d5ea86832066b4 commit 15d512d301545e10f69ade0562d5ea86832066b4 Author: Vadim Yanitskiy Date: Mon Dec 18 02:13:41 2017 +0700 trxcon/scheduler: separate primitive management code It's good to write, keep and make the source code as much modular as possible. So, Tte primitive management code was separated to the 'sched_prim.c' and going to be extended in the near future. Change-Id: Ifec8c9e4f2c95c72b00772688bcb5dc9c11d6de7 http://cgit.osmocom.org/osmocom-bb/commit/?id=e17bb11c3b29919799b3637dece1c7c0273af304 commit e17bb11c3b29919799b3637dece1c7c0273af304 Author: Vadim Yanitskiy Date: Mon Dec 18 01:23:03 2017 +0700 trxcon/scheduler: BUGFIX: distinguish between SACCH and FACCH Both SACCH and FACCH messages have the same 23-byte length, both are being queued together within a single transimt queue. So, previously a SACCH frame could be picked by TCH burst handler, and then sent as a FACCH frame. Let's fix this. A FACCH primitive may have one of the TRXC_TCH* logical channel types, while SACCH primitives have one of the TRXC_SACCH*. Change-Id: Ia7090384f3ff74c9d94997265135acbceffa0ffe ----------------------------------------------------------------------- Summary of changes: include/l1ctl_proto.h | 1 + src/host/layer23/include/osmocom/bb/common/l1ctl.h | 4 +- src/host/layer23/src/common/l1ctl.c | 8 +- src/host/layer23/src/mobile/gsm48_rr.c | 12 +- src/host/trxcon/Makefile.am | 1 + src/host/trxcon/l1ctl.c | 58 ++++- src/host/trxcon/sched_lchan_common.c | 46 ---- src/host/trxcon/sched_lchan_rach.c | 25 +- src/host/trxcon/sched_lchan_sch.c | 1 - src/host/trxcon/sched_lchan_tchf.c | 58 ++--- src/host/trxcon/sched_lchan_xcch.c | 38 +--- src/host/trxcon/sched_prim.c | 251 +++++++++++++++++++++ src/host/trxcon/sched_trx.c | 206 +++++++++-------- src/host/trxcon/sched_trx.h | 18 +- src/target/firmware/layer1/l23_api.c | 5 +- 15 files changed, 500 insertions(+), 232 deletions(-) create mode 100644 src/host/trxcon/sched_prim.c hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sun Dec 17 23:30:41 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 17 Dec 2017 23:30:41 GMT Subject: osmocom-bb.git branch fixeria/trx_tch deleted. osmocon_v0.0.0-1952-g097d19a0 Message-ID: <201712172330.vBHNUfFp056600@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx_tch has been deleted was 097d19a062ffffebed98430d9170e4087efde84b ----------------------------------------------------------------------- 097d19a062ffffebed98430d9170e4087efde84b host/trxcon/l1ctl.c: handle L1CTL_TRAFFIC_REQ ----------------------------------------------------------------------- hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Mon Dec 18 04:28:41 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 04:28:41 GMT Subject: libosmocore.git branch neels/ctrl_parsing updated. 0.10.2-72-g41dcec81 Message-ID: <201712180428.vBI4SfHX099013@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/ctrl_parsing has been updated discards 179f3a01446556d0d8eeb816c0c2b68034495180 (commit) discards c16258365ea80c9d35558e38eaa7f482eb357f24 (commit) discards e56600fa42e0a229a1a5bcf95fc8d3b9a4c053ac (commit) discards b61510abaeec814dfdf6f33ff5534c6ac1d6020f (commit) discards 4602cbff6231d7c106b880c5a4f45c2fca6e640f (commit) discards 0e759be493086f13ad476e08e5ba4c70b5a2c689 (commit) discards 4dbc6fca9a177941af2a3d3f8e3cabfb0825e80d (commit) discards 62feb5389c06f9fec19d21ba623195c59a2864cd (commit) discards 414901b2cd688783f56fced6311d5d7abfaaa98f (commit) discards 976214df85b004310ab49708d9170a1f5d14a039 (commit) discards 7fe60fe3d0576adbbd82919f43cfbb431a8d0c6a (commit) discards 65caf44d917c3bfa6c7fa2269aaa81d94981aad4 (commit) discards 62cc9bfee0c1cf30647d7f97261cc02519c797e9 (commit) via 41dcec816eb56d69dc69120e6bac06365d783a0a (commit) via e554429d04bceaac626165d13b69948477482e06 (commit) via ff1713e115789f1fff7f6fdc7f34b321fab27064 (commit) via c4eaafd6a195491d93161b165ecd7af5456267d5 (commit) via 29ed24daee0351f5bd1947a74d0a7c40fdf96d7f (commit) via 41eec760c14a594042daab768e85e4a04d20dfc4 (commit) via 6115231b49382c6b21677c8ec985f61af93383c3 (commit) via 3ddb493599b61fcbe7dddb29ab6ed3a13914648c (commit) via 86f9b1902cb0294a2b3c096dce88a15439d1d661 (commit) via 32c8f8ac9999a0fa0791a7ef1bdd87210876e15f (commit) via d8ad45804a605d9c0f22725aecf9a38450a35e31 (commit) via 5674c182b620bd7cb2c5a175382f8e72cecea1cf (commit) via 937ddea6cce45f3f6dcb8177ea86162f15ecb5f9 (commit) via e5a2bdbc5501b892605a6a1fe7e30fb2f1546d42 (commit) via 3ef14a241afc123560e9a50d17948b040481b299 (commit) via 62e40855c2b1b50627dba5b187be8869e2cb2054 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (179f3a01446556d0d8eeb816c0c2b68034495180) \ N -- N -- N (41dcec816eb56d69dc69120e6bac06365d783a0a) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=41dcec816eb56d69dc69120e6bac06365d783a0a commit 41dcec816eb56d69dc69120e6bac06365d783a0a Author: Neels Hofmeyr Date: Mon Dec 18 03:12:01 2017 +0100 add osmo_auth_c3(): separate from gsm_milenage() To send a Ciphering Mode Command, we may need to derive a Kc from UMTS AKA tokens. gsm_milenage() derives Kc from 3G tokens, but also derives an SRES. For SRES, it requires an OPC, which may need to be derived from OP first. All we need is a Kc, so we could feed a zero OPC ... but to simplify the function call for cases where just a Kc is required, separate the c3 function out from gsm_milenage(), as osmo_auth_c3(). Obviously call osmo_auth_c3() from gsm_milenage() (meaning that osmo-hlr's 55.205 derived auc tests still cover exactly that implementation). Prepares: If04e405426c55a81341747a9b450a69188525d5c (osmo-msc) Related: OS#2745 Change-Id: I85a1d6ae95ad9e5ce9524ef7fc06414848afc2aa http://cgit.osmocom.org/libosmocore/commit/?id=e554429d04bceaac626165d13b69948477482e06 commit e554429d04bceaac626165d13b69948477482e06 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:53 2017 +0100 ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET REPLY' and 'TRAP' as appropriate. Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 http://cgit.osmocom.org/libosmocore/commit/?id=ff1713e115789f1fff7f6fdc7f34b321fab27064 commit ff1713e115789f1fff7f6fdc7f34b321fab27064 Author: Neels Hofmeyr Date: Tue Sep 26 14:21:44 2017 +0200 ctrl: tighten CTRL input parsing Validate that incoming CTRL commands... - have decimal IDs, - return error on trailing characters, - have invalid characters in variable identifiers, - send detailed error messages as reply to the requestor. Adjust ctrl_test.{c,ok}, which best show the change in behavior. Message handling causes log messages on stderr; previously, stderr was empty. Add '[ignore]' in testsuite.at so that the nonempty stderr doesn't cause test failures. Change-Id: I96a9b6b6a3a5e0b80513aa9eaa727ae8c9c7d7a1 http://cgit.osmocom.org/libosmocore/commit/?id=c4eaafd6a195491d93161b165ecd7af5456267d5 commit c4eaafd6a195491d93161b165ecd7af5456267d5 Author: Neels Hofmeyr Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=29ed24daee0351f5bd1947a74d0a7c40fdf96d7f commit 29ed24daee0351f5bd1947a74d0a7c40fdf96d7f Author: Neels Hofmeyr Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. No need really to deprecate ctrl_cmd_parse() yet; especially as long as compiler warnings might break jenkins builds. Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=41eec760c14a594042daab768e85e4a04d20dfc4 commit 41eec760c14a594042daab768e85e4a04d20dfc4 Author: Neels Hofmeyr Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 http://cgit.osmocom.org/libosmocore/commit/?id=6115231b49382c6b21677c8ec985f61af93383c3 commit 6115231b49382c6b21677c8ec985f61af93383c3 Author: Neels Hofmeyr Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=3ddb493599b61fcbe7dddb29ab6ed3a13914648c commit 3ddb493599b61fcbe7dddb29ab6ed3a13914648c Author: Neels Hofmeyr Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=86f9b1902cb0294a2b3c096dce88a15439d1d661 commit 86f9b1902cb0294a2b3c096dce88a15439d1d661 Author: Neels Hofmeyr Date: Sat Dec 16 05:38:37 2017 +0100 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f http://cgit.osmocom.org/libosmocore/commit/?id=32c8f8ac9999a0fa0791a7ef1bdd87210876e15f commit 32c8f8ac9999a0fa0791a7ef1bdd87210876e15f Author: Neels Hofmeyr Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=d8ad45804a605d9c0f22725aecf9a38450a35e31 commit d8ad45804a605d9c0f22725aecf9a38450a35e31 Author: Neels Hofmeyr Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b http://cgit.osmocom.org/libosmocore/commit/?id=5674c182b620bd7cb2c5a175382f8e72cecea1cf commit 5674c182b620bd7cb2c5a175382f8e72cecea1cf Author: Neels Hofmeyr Date: Sat Dec 16 00:54:52 2017 +0100 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped() function, which will be replaced by osmo_escape_str() in a subsequent patch. control_cmd.c will use osmo_escape_str() to log invalid identifiers. Change-Id: Ic685eb63dead3967d01aaa4f1e9899e5461ca49a ----------------------------------------------------------------------- Summary of changes: include/osmocom/crypt/auth.h | 2 ++ src/gsm/auth_core.c | 13 +++++++++++++ src/gsm/gsm0808.c | 3 ++- src/gsm/libosmogsm.map | 1 + src/gsm/milenage/milenage.c | 3 +-- src/rate_ctr.c | 3 +++ src/utils.c | 6 +++--- tests/ctrl/ctrl_test.c | 1 - tests/gsm0808/gsm0808_test.c | 2 +- tests/stats/stats_test.c | 7 ++++++- 10 files changed, 32 insertions(+), 9 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Mon Dec 18 04:34:17 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 04:34:17 GMT Subject: libosmocore.git branch neels/ctrl_parsing updated. 0.10.2-71-ge554429d Message-ID: <201712180434.vBI4YH5B001654@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/ctrl_parsing has been updated discards 41dcec816eb56d69dc69120e6bac06365d783a0a (commit) This update discarded existing revisions and left the branch pointing at a previous point in the repository history. * -- * -- N (e554429d04bceaac626165d13b69948477482e06) \ O -- O -- O (41dcec816eb56d69dc69120e6bac06365d783a0a) The removed revisions are not necessarilly gone - if another reference still refers to them they will stay in the repository. No new revisions were added by this update. Summary of changes: include/osmocom/crypt/auth.h | 2 -- src/gsm/auth_core.c | 13 ------------- src/gsm/libosmogsm.map | 1 - src/gsm/milenage/milenage.c | 3 ++- 4 files changed, 2 insertions(+), 17 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Mon Dec 18 12:10:08 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 12:10:08 GMT Subject: osmo-python-tests.git branch master updated. c35bb473e449ec8b0d6e6ab64196331e89efef95 Message-ID: <201712181210.vBICA8rI015948@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via c35bb473e449ec8b0d6e6ab64196331e89efef95 (commit) from 7f7c4b441027ff64bddafe2a378e0d1a72f8b285 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=c35bb473e449ec8b0d6e6ab64196331e89efef95 commit c35bb473e449ec8b0d6e6ab64196331e89efef95 Author: Max Date: Fri Dec 15 11:56:05 2017 +0100 Expand CI tests * make sure jenkins.sh fails on any errors similar to other jenkins jobs * always explicitly use python2 instead of generic python * add basic module import tests for python 2 and 3 * add comments Change-Id: I0f4639537d227c513859d4552533ce1e41df9deb ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 11 ++++++++++- tests/test_py2.py | 7 +++++++ tests/test_py3.py | 7 +++++++ 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 tests/test_py2.py create mode 100644 tests/test_py3.py hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 13:26:27 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 13:26:27 GMT Subject: osmo-python-tests.git branch user/max/for_laforge created. 1a5364696eaf66a382e6d451bc4255622d845a92 Message-ID: <201712181326.vBIDQR5X053568@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, user/max/for_laforge has been created at 1a5364696eaf66a382e6d451bc4255622d845a92 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=1a5364696eaf66a382e6d451bc4255622d845a92 commit 1a5364696eaf66a382e6d451bc4255622d845a92 Author: Max Date: Mon Dec 18 10:58:12 2017 +0100 Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure that it fails if any errorsis encountered bymanually call compilation step. Change-Id: I2235e3fff21b7c09d3fba00ecdccca7f4515e071 Related: OS#2770 http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=6ccd0785d849e7a32e69c0216488a03308d68bc9 commit 6ccd0785d849e7a32e69c0216488a03308d68bc9 Author: Max Date: Fri Dec 15 12:15:39 2017 +0100 Fix python3 compatibility Use print() function with proper import. Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=120075a6a5715337270cc964c2f154f9ae7b8471 commit 120075a6a5715337270cc964c2f154f9ae7b8471 Author: Max Date: Fri Dec 15 12:13:59 2017 +0100 Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed unconditionally regardless of version check in setup.py which makes it impossible to write separate tests for python 2 and 3. Fix this by moving the scripts into separate directory and adjusting init and setup files accordingly. This is necessary for implementing proper CI tests in follow-up patches. Change-Id: I30cdf0f85b2a60a235960911c9827f4129da40db ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 13:31:12 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 13:31:12 GMT Subject: osmo-python-tests.git branch master updated. 6ccd0785d849e7a32e69c0216488a03308d68bc9 Message-ID: <201712181331.vBIDVCfs055672@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 6ccd0785d849e7a32e69c0216488a03308d68bc9 (commit) via 120075a6a5715337270cc964c2f154f9ae7b8471 (commit) from c35bb473e449ec8b0d6e6ab64196331e89efef95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: osmopy/__init__.py | 14 ++------------ osmopy/obscvty.py | 17 +++++++++-------- osmopy/osmoutil.py | 13 +++++++------ {osmopy => scripts}/osmo_ctrl.py | 14 +++++++------- {osmopy => scripts}/osmo_interact_common.py | 0 {osmopy => scripts}/osmo_interact_ctrl.py | 0 {osmopy => scripts}/osmo_interact_vty.py | 0 {osmopy => scripts}/osmo_verify_transcript_ctrl.py | 0 {osmopy => scripts}/osmo_verify_transcript_vty.py | 0 {osmopy => scripts}/osmodumpdoc.py | 0 {osmopy => scripts}/osmotestconfig.py | 0 {osmopy => scripts}/osmotestvty.py | 0 {osmopy => scripts}/soap.py | 0 {osmopy => scripts}/twisted_ipa.py | 0 setup.py | 18 ++++++++---------- 15 files changed, 33 insertions(+), 43 deletions(-) rename {osmopy => scripts}/osmo_ctrl.py (91%) rename {osmopy => scripts}/osmo_interact_common.py (100%) rename {osmopy => scripts}/osmo_interact_ctrl.py (100%) rename {osmopy => scripts}/osmo_interact_vty.py (100%) rename {osmopy => scripts}/osmo_verify_transcript_ctrl.py (100%) rename {osmopy => scripts}/osmo_verify_transcript_vty.py (100%) rename {osmopy => scripts}/osmodumpdoc.py (100%) rename {osmopy => scripts}/osmotestconfig.py (100%) rename {osmopy => scripts}/osmotestvty.py (100%) rename {osmopy => scripts}/soap.py (100%) rename {osmopy => scripts}/twisted_ipa.py (100%) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 13:32:36 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 13:32:36 GMT Subject: osmo-python-tests.git branch master updated. 1a5364696eaf66a382e6d451bc4255622d845a92 Message-ID: <201712181332.vBIDWad9056295@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 1a5364696eaf66a382e6d451bc4255622d845a92 (commit) from 6ccd0785d849e7a32e69c0216488a03308d68bc9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=1a5364696eaf66a382e6d451bc4255622d845a92 commit 1a5364696eaf66a382e6d451bc4255622d845a92 Author: Max Date: Mon Dec 18 10:58:12 2017 +0100 Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure that it fails if any errorsis encountered bymanually call compilation step. Change-Id: I2235e3fff21b7c09d3fba00ecdccca7f4515e071 Related: OS#2770 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 13:32:36 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 13:32:36 GMT Subject: osmo-python-tests.git branch user/max/for_laforge deleted. 1a5364696eaf66a382e6d451bc4255622d845a92 Message-ID: <201712181332.vBIDWaue056320@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, user/max/for_laforge has been deleted was 1a5364696eaf66a382e6d451bc4255622d845a92 ----------------------------------------------------------------------- 1a5364696eaf66a382e6d451bc4255622d845a92 Explicitly check syntax in jenkins tests ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 16:19:14 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 16:19:14 GMT Subject: libosmocore.git branch master updated. 0.10.2-61-gd589f1dc Message-ID: <201712181619.vBIGJE3R039997@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via d589f1dcfddb672edddc84a06f0443569ac44bcc (commit) from 937ddea6cce45f3f6dcb8177ea86162f15ecb5f9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d589f1dcfddb672edddc84a06f0443569ac44bcc commit d589f1dcfddb672edddc84a06f0443569ac44bcc Author: Harald Welte Date: Mon Dec 18 17:13:38 2017 +0100 rate_ctr: print proper error message if rate_ctr already exists Change-Id: I86b7ccb0931f5a2a489bb8c7c6aee0894a126eb8 ----------------------------------------------------------------------- Summary of changes: src/rate_ctr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Mon Dec 18 22:05:38 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 22:05:38 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-18-gef784e4 Message-ID: <201712182205.vBIM5c0O003421@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 (commit) from 912131803bfbc275e2d9f11fbb0e4413d7b44630 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 commit ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 Author: Max Date: Fri Dec 15 15:19:28 2017 +0100 Remove unused includes and forward declarations Change-Id: I59da04edd1b8ff965bbfbe00ccae1f7c9b6e5301 ----------------------------------------------------------------------- Summary of changes: src/gprs_bssgp_pcu.cpp | 1 - src/gprs_debug.cpp | 9 --------- src/gprs_debug.h | 2 -- src/gprs_ms.h | 3 --- src/gprs_rlcmac.cpp | 1 - src/gprs_rlcmac.h | 1 - src/llc.cpp | 1 - src/llc.h | 1 - src/rlc.cpp | 1 - src/rlc.h | 1 - src/sba.h | 1 - src/tbf.h | 2 -- 12 files changed, 24 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 22:58:44 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 22:58:44 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-19-gea9968f Message-ID: <201712182258.vBIMwixH029165@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via ea9968f6854cbfe79506efedc43a953a7c38cdd6 (commit) from ef784e4e9e09e9bdcc81b6223f26ef22e88cc3c7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=ea9968f6854cbfe79506efedc43a953a7c38cdd6 commit ea9968f6854cbfe79506efedc43a953a7c38cdd6 Author: Max Date: Mon Dec 18 22:52:52 2017 +0100 Fix tests after rate_ctr change Recent change lin libosmocore disallow registering rate_ctr with the same name and indexing multiple times. To accommodate to this check if rate counters arealready allocated (by static allocator of BTS singleton for example) and register rate counter with different index. This fixes the tests for now but eventually we'll remove the BTS singleton which will allow us to remove this hack. Change-Id: I7c552ce653b44ec3a31049641728926adc07361d Related: OS#2757 ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Mon Dec 18 23:05:40 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 23:05:40 GMT Subject: libosmocore.git branch master updated. 0.10.2-62-gaa84b71f Message-ID: <201712182305.vBIN5eLL032703@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via aa84b71f0fe014156e90dde2f0c44694368dc034 (commit) from d589f1dcfddb672edddc84a06f0443569ac44bcc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=aa84b71f0fe014156e90dde2f0c44694368dc034 commit aa84b71f0fe014156e90dde2f0c44694368dc034 Author: Neels Hofmeyr Date: Mon Dec 18 03:12:01 2017 +0100 add osmo_auth_c3() (separate from gsm_milenage()) To send a Ciphering Mode Command, we may need to derive a Kc from UMTS AKA tokens. gsm_milenage() derives Kc from 3G tokens, but also derives an SRES. For SRES, it requires an OPC, which may need to be derived from OP first. All we need is a Kc, so we could feed a zero OPC ... but to simplify the function call for cases where just a Kc is required, separate the c3 function out from gsm_milenage(), as osmo_auth_c3(). Obviously call osmo_auth_c3() from gsm_milenage() (meaning that osmo-hlr's 55.205 derived auc tests still cover exactly that implementation). Prepares: If04e405426c55a81341747a9b450a69188525d5c (osmo-msc) Related: OS#2745 Change-Id: I85a1d6ae95ad9e5ce9524ef7fc06414848afc2aa ----------------------------------------------------------------------- Summary of changes: include/osmocom/crypt/auth.h | 2 ++ src/gsm/auth_core.c | 13 +++++++++++++ src/gsm/libosmogsm.map | 1 + src/gsm/milenage/milenage.c | 5 ++--- 4 files changed, 18 insertions(+), 3 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Mon Dec 18 23:06:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 18 Dec 2017 23:06:06 GMT Subject: libosmocore.git branch master updated. 0.10.2-71-gc0b0b623 Message-ID: <201712182306.vBIN66CR033063@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via c0b0b623053f16790d7d675812befe382ebdfd6e (commit) via f2e83ad40d231e87e2604ec4c97c810a8182e145 (commit) via 1b8b152e791df579035f7b7c8dd621938f7de3c0 (commit) via f2c10f108202c350a3c16f49156b11b0cd0dfa96 (commit) via 6769ad6e0aca58ccc037746885976ea4f85cb318 (commit) via 83aee83ec6a9d3d5e4f9251221c9639028d3da89 (commit) via d53d2169442fd43ed1538c3970c6e7cb6096f20a (commit) via 0ab6eca80a47706375c5d54d829c4dee6e1228fc (commit) via 9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 (commit) from aa84b71f0fe014156e90dde2f0c44694368dc034 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=c0b0b623053f16790d7d675812befe382ebdfd6e commit c0b0b623053f16790d7d675812befe382ebdfd6e Author: Neels Hofmeyr Date: Sat Dec 16 01:12:35 2017 +0100 ctrl: on parse errors, return a detailed message to sender The recently added ctrl_cmd_parse2() returns non-NULL cmd with error messages upon parsing errors. In handle_control_read(), use ctrl_cmd_parse2() and send those back to the CTRL command sender as reply. Retain the previous "Command parser error" reply only in case ctrl_cmd_parse2() should return NULL, which shouldn't actually happen at all. Change-Id: Ie35a02555b76913bb12734a76fc40fde7ffb244d http://cgit.osmocom.org/libosmocore/commit/?id=f2e83ad40d231e87e2604ec4c97c810a8182e145 commit f2e83ad40d231e87e2604ec4c97c810a8182e145 Author: Neels Hofmeyr Date: Sat Dec 16 01:05:25 2017 +0100 add ctrl_cmd_parse2() to return parsing errors If a control command fails to parse, we so far discard specific error messages and instead send just "Command parser error". In ctrl_cmd_parse() we actually compose detailed error replies, but in the end simply talloc_free() them and return NULL. A first step to report these errors to the ctrl command issuer is to not return NULL and instead return the cmd with type = CTRL_TYPE_ERROR. Add ctrl_cmd_parse2() to return such instead of NULL. To stay API compatible, provide ctrl_cmd_parse2() to return a cmd on errors. ctrl_cmd_parse() retains identical behavior but becomes just a simple wrapper around ctrl_cmd_parse2() which discards the cmd on error. No need really to deprecate ctrl_cmd_parse() yet; especially as long as compiler warnings might break jenkins builds. Change-Id: I5047c9f977d70b03eea77cbcfd2b96d43ea46880 http://cgit.osmocom.org/libosmocore/commit/?id=1b8b152e791df579035f7b7c8dd621938f7de3c0 commit 1b8b152e791df579035f7b7c8dd621938f7de3c0 Author: Neels Hofmeyr Date: Fri Dec 15 20:41:28 2017 +0100 ctrl_test: add two more current parsing bugs to prep for fix Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7 http://cgit.osmocom.org/libosmocore/commit/?id=f2c10f108202c350a3c16f49156b11b0cd0dfa96 commit f2c10f108202c350a3c16f49156b11b0cd0dfa96 Author: Neels Hofmeyr Date: Sat Dec 16 04:05:21 2017 +0100 ctrl: fix mem leak when handling GET_REPLY and SET_REPLY In ctrl_handle_msg() (code recently propagated from handle_control_read()), talloc_free() the parsed ctrl_cmd in all code paths. In particular, a free was missing in case ctrl_cmd_handle() returns CTRL_CMD_HANDLED. CTRL_CMD_HANDLED is triggered by GET_REPLY / SET_REPLY parsing, as show by ctrl_test.c. With the memleak fixed, adjust expected test output and make a detected mem leak abort the test immediately. Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 http://cgit.osmocom.org/libosmocore/commit/?id=6769ad6e0aca58ccc037746885976ea4f85cb318 commit 6769ad6e0aca58ccc037746885976ea4f85cb318 Author: Neels Hofmeyr Date: Sat Dec 16 04:01:54 2017 +0100 ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands The "memleak!" output shows messages that lack a talloc_free() of the parsed ctrl command buffer. The leak shall be fixed in a subsequent patch. Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042 http://cgit.osmocom.org/libosmocore/commit/?id=83aee83ec6a9d3d5e4f9251221c9639028d3da89 commit 83aee83ec6a9d3d5e4f9251221c9639028d3da89 Author: Neels Hofmeyr Date: Sat Dec 16 05:38:37 2017 +0100 ctrl_test: expand to test message handling and detect mem leaks Subsequent patches that tighten CTRL input validation will make the results more interesting. Change-Id: Idd4cc7d193db1a7d761f72ed33ed46eea450a78f http://cgit.osmocom.org/libosmocore/commit/?id=d53d2169442fd43ed1538c3970c6e7cb6096f20a commit d53d2169442fd43ed1538c3970c6e7cb6096f20a Author: Neels Hofmeyr Date: Sat Dec 16 03:57:56 2017 +0100 ctrl: prep test: separate new ctrl_handle_msg() from handle_control_read() In order to allow unit testing the ctrl iface msgb handling, have a separate msgb entry point function from the actual fd read function. An upcoming patch will prove a memory leak in CTRL msgb handling by a unit test that needs this separation. Change-Id: Ie09e39db668b866eeb80399b82e7b04b8f5ad7c3 http://cgit.osmocom.org/libosmocore/commit/?id=0ab6eca80a47706375c5d54d829c4dee6e1228fc commit 0ab6eca80a47706375c5d54d829c4dee6e1228fc Author: Neels Hofmeyr Date: Sat Dec 16 01:03:37 2017 +0100 ctrl_test.c: replace print_escaped() with new osmo_escape_str() Change-Id: I12d3828dcc925f97fde11c360f1d60f3bd8cad8b http://cgit.osmocom.org/libosmocore/commit/?id=9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 commit 9910bbc62d1c19a2cd75eeb1248c351b6a1e3f06 Author: Neels Hofmeyr Date: Sat Dec 16 00:54:52 2017 +0100 utils: add osmo_escape_str() To report invalid characters in identifiers, it is desirable to escape any weird characters. Otherwise we might print stray newlines or control characters in the log output. ctrl_test.c already uses a print_escaped() function, which will be replaced by osmo_escape_str() in a subsequent patch. control_cmd.c will use osmo_escape_str() to log invalid identifiers. Change-Id: Ic685eb63dead3967d01aaa4f1e9899e5461ca49a ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/utils.h | 3 + include/osmocom/ctrl/control_cmd.h | 1 + include/osmocom/ctrl/control_if.h | 2 + src/ctrl/control_cmd.c | 18 ++- src/ctrl/control_if.c | 74 +++++++----- src/utils.c | 87 +++++++++++++ tests/ctrl/ctrl_test.c | 242 +++++++++++++++++++++++++------------ tests/ctrl/ctrl_test.ok | 167 ++++++++++++++++++------- tests/utils/utils_test.c | 48 ++++++++ tests/utils/utils_test.ok | 29 +++++ 10 files changed, 526 insertions(+), 145 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Tue Dec 19 15:18:20 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 19 Dec 2017 15:18:20 GMT Subject: osmo-hlr.git branch master updated. 0.1.0-22-g63f68cc Message-ID: <201712191518.vBJFIKbi010125@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 63f68ccc4cdee6e8de2e4e63d456d4c340af5b51 (commit) from b5d77012d1d74bbb28b07a374c436045ed3e43ea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=63f68ccc4cdee6e8de2e4e63d456d4c340af5b51 commit 63f68ccc4cdee6e8de2e4e63d456d4c340af5b51 Author: Neels Hofmeyr Date: Tue Dec 19 15:50:54 2017 +0100 fix test_subscriber_errors.ctrl after libosmocore change libosmocore Ie35a02555b76913bb12734a76fc40fde7ffb244d "ctrl: on parse errors, return a detailed message to sender" the test_subscriber_errors.ctrl test fails. Adjust the expected error message. Change-Id: I3aee1507721cd073f72369150d0fb3cff0fdf66f ----------------------------------------------------------------------- Summary of changes: tests/test_subscriber_errors.ctrl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Tue Dec 19 22:25:07 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 19 Dec 2017 22:25:07 GMT Subject: wireshark.git branch master updated. 12e25c1a86d5a4b67213af89fa3b2d6a0bcaa634 Message-ID: <201712192225.vBJMP74t017757@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "wireshark with Osmocom specific dissectors". The branch, master has been updated via 12e25c1a86d5a4b67213af89fa3b2d6a0bcaa634 (commit) via 106e0b4ee0b5bac403a174aff7266d17c7b1b43e (commit) via c9b6887d8469251b15204dffcd7105490b574e27 (commit) via 5b596fa871b58948dacd18859dad61e692ab973e (commit) via 4db038aa28023867dcdae403d79b0a0b5506e991 (commit) via 0d6eb9631f26176d00d6bef69569d1d2911bd233 (commit) via 6e4a6364154f4e880f2bb6111d6759e51a686bb4 (commit) via 7cb6255f17b90863d863ad995d7bca5921b7c517 (commit) via 9f7b8713fa8286611e84a68f82adc2d494b21173 (commit) via 5ebc3277ed98c39b24d971470d1aea0efe042351 (commit) via 09ad8456906172c384a01df49a7eba5716ebfa8e (commit) via b37aedb47a61f6b16339ce2e4d75f57e16b6ea31 (commit) via 786a73b80d6cc7d59060de50fef3feba04684869 (commit) via 3c87991c28dda0ee2e64c73e3df6c671a19ab42c (commit) via 67a49eb2ece34494a0fe1efd76d36c9b4d46d11e (commit) via 9761e279392ee996137c0d1d34a68ba13f43ae02 (commit) via 50be2bde1a79a2a710a063cca23e51a67a95d63b (commit) via f6d5b5fc107b67b2094abe6b7c56425d92dd0f91 (commit) via c9f54aa1c3a71c330c30ebc7a178922d179f912e (commit) via 6159c2be18429e69096645946a2cbb507d49cbc5 (commit) via f3444ed0f9c1d6e48b4b383afdd2b9fca9a8966c (commit) via ee8ca2e1d793e039bdd7304ad3c2c0cb42a69624 (commit) via f37e759f41da97a2121934d17b0ec2d895c3af15 (commit) via 889aacae6e549c9cbbbd4ce3a371de0b042f7a37 (commit) via cd573915eafd49cd3cb41e40a0d59acab4f49583 (commit) via b1f558ae278cb1b90f6e06a9cc4031227b47fd31 (commit) via f4b2263a0b753984c3ce97f2709ed4e435afe9ff (commit) via 6a5e90f2d91892248f5f7defe1c610e00298d789 (commit) via 18c42e1dca9631b336dd2a8b813aad782569f69a (commit) via 0b88544b07075741e6f89666867f0926c45fa419 (commit) via 68668b785c73a1676ef4573290be7b50abb1c5a8 (commit) via 2b4322ceba7e8f8679ef955efb6a6ab3e12adab0 (commit) via b2e6d615c2817a25d74e1b25629e547586dbfa47 (commit) via 3d086e638dc0a1713328c23161671555dfa4faaf (commit) via 621077309506ec65cb99b4f3aeffb99bcba69393 (commit) via 03375e0c288dcad62b33fae2ce508d8dd906e169 (commit) via 28ba56667599c7a90c8492052b438f58aa963902 (commit) via 183b9119dc4caa491cf58bc673a3109a7ef8bcfd (commit) via 15a97b5986e9a5f23ebce233ecc84401a5495abc (commit) via 3071356d9e3d07d3c0132af88e4e8af785deb3ee (commit) via adde937ed74926323b084713caf6fbba871d8791 (commit) via cf5a58f72a58c36744878cd6eb640de669341a55 (commit) via 2acaf0a47a643ff929ecf9354d62a642794bbbd1 (commit) via 774a986ec07be46263e7acbbec4fbb69563a95a1 (commit) via bdb6baa7405d259fa2cd2f6f7d2fb21e13315885 (commit) via 0909580a7e98c134785a96829b58076534b477b6 (commit) via 1651371d17e56a9f77270aa2c6d6239a6506b16e (commit) via a51ac8d398aeedf9a678188147a89bf1ee035443 (commit) via a8a4436e97eaddca301e8b258f7a1ca9688af4f9 (commit) via 90102ad12ec601abcc2270e4779f8d2fc1c0c937 (commit) via afc6e773dc84ddcf57af59e0fd87ab1625204786 (commit) via db140dd500227c1a7c2223c1c868812e08253493 (commit) via cebb8ea20ec2d4c1c1c000304c6cc6e7e9ccb8ad (commit) via 629596ebefa34a2677c341ab899e51cecbe254f0 (commit) via db740987fffeb7e8122a6cd40e25f16244af5721 (commit) via 4cf7cd3ed20c57dc5977be5be37ced0bd1706d61 (commit) via fe4cf449c9787bcfd234db22674a0f49fee04ff0 (commit) via 0ffee1526be20b3791cececfbfa490ed2d22dece (commit) via 83b052562096830b024aff830469086b1ec933d1 (commit) via 11a948dd121f04448ff765ec36dafbf8e8415fb5 (commit) via 9401571a244366d74f4998ffb0b9acb7365cd57d (commit) via 995812c5f1add94df1c237596939130c1704b099 (commit) via a9821caab8a1f2c6e265bd5b63a060f1f241c704 (commit) via 862a0b6472529ef6676c8bc56dd8f0be5166fd7c (commit) via 11ccd830685e4037c3cce04a3dbfd2d05a5145f7 (commit) via a9f50164298d641be3d107261e8ec1166a6fcf2a (commit) via c662615ab4c0ecb48443412a27b769e73ed084d4 (commit) via 6af7b9a63ad8c7ce7b57e0d8adcb5e61d70a2123 (commit) via 7539469d79d80944ab2daa389aade7991302835d (commit) via 6d30df0cdd83b051e02b1e90a905b7e51031cd22 (commit) via c781bd41100fa2080c4062dc34b5bfb4e4175180 (commit) via cb748178feffd35146222fad14b898cb4604f7cb (commit) via 801ee01affeac724c063c8c643fde9459b4f0ceb (commit) via b0112e60ada68646b3e304f73f8321f5fb1ddc01 (commit) via f945b85391976bc59da4b542fe84cb58033bd22e (commit) via e4750105b23c2e19cfa4fbb79679b4a045ec0ebe (commit) via 2c36df54a34494015772d3342cc9819cad0669b1 (commit) via 158d9298840434f2770c96bd3b8d2f44792932d1 (commit) via 16e5d73ecc6630411153b4f46b0d137fb78c1240 (commit) via 326591ef6da8f5024a6c93721ea896cad0578f4c (commit) via 91f63908df560e0ed22cad12ba6cc43f81d60f9f (commit) via 621498f88e882dbe8cc3a2c8373bb342bb0dbe77 (commit) via 5aa50639acc774a65df9be99ed44d90e7615646a (commit) via 34b62c60bfad56275dca48242c7e477f33b691ef (commit) via 10e98462520b5dcfa1e5d7b80e53a95725d91d94 (commit) via 7617af1d8994289da23402b67ccea79e32881888 (commit) via 51300b3c834a3877d567fb57ae78ec74ec8ba80d (commit) via c9546dfceb778dcabe7a830272add62e6ae1403e (commit) via 84f905786ed2b2aabaec9a0c1045daeda66358ba (commit) via 397e2a2d74e9c6ea103d3b4c30794552041e39c2 (commit) via faa4a6a5f12b507e12232ceefb9cebdaf6b7ee24 (commit) via 5b4894b7959f44e077f36194c490cbf402e1e659 (commit) via 0d5ad701b494c29dd5ae5e44ecb5f9a42c423f5b (commit) via 5fc43fe63a07062587bc3d76256f4240221e8bc7 (commit) via 224e24884a8b37732105bd40a0ee85d5feaaeab1 (commit) via 7d383637865e2f1f0de7a8921261f406f42af4bf (commit) via 91548948bbe2bba844a65c62975dada05dd4c03e (commit) via d0d1eaadf0c92e37b6ed2883583f71b7b9ec3a7e (commit) via 3d673da88c5ff4e56cbb3cf713b8c49704e62923 (commit) via 8225159e336610c25fb4d4129b0be156ed487c49 (commit) via 22a7d8fa8d8b8c7171ede55e7f413d004cb7b099 (commit) via 8cb9a094bf1d08ffb100a384de03a9774f7183c0 (commit) via abd703c4b80e47d5097a74cbba4911e9ef83d2fb (commit) via c79fb9d0285fbf51d6cdc3770396a8add08321ec (commit) via 514e607dd911d8bc5eabcadb8840b34fd238b745 (commit) via d96ef7ed05a9f3219742699988faae3889334c85 (commit) via f8203771ec1580013e8de21e6286a33c330f08e3 (commit) via 157ea91f2eb583a1f5815b4fb076ce78498617b8 (commit) via 2cee4f432feddc5deb48154a97fcb63823b4e6b4 (commit) via 5d6315fefe6f2ffb1cafb3ad12522a57b43876ba (commit) via 8aa14236f8b0ea69901ea9ed87ebabd0d278e973 (commit) via f29b3deb6d867b16fb8bc4bd5f66a5b6326a6727 (commit) via 48e65c4af4e35c90d7cbc9fb789ecc6e740b300b (commit) via 797d2f6a87607b146a2ef62e1ff501031dce8212 (commit) via 0baa4458c5780b143ad4479d387202ddf4add06f (commit) via 847585f938a525fb32ee4a0227cc500316facc34 (commit) via 683087628b5ef63343f6e572289b8e90a3dd245b (commit) via 038aa2a616db5ba658bee25dee5e55a716d4984a (commit) via 8687fca8a821f95075e8c365c7422f157845787b (commit) via 42b191a65770dbad2d418dc62d0a58b9dd4e5f31 (commit) via be8a40005328d74815491b3536b85fe9e532243e (commit) via f8b19c6eecbf241ecede5b85811a772469cea0df (commit) via 024e7dc8afb1d84365eeaaeadf029b242eac827f (commit) via 244aab31ee83c72aa0cefae650abec40ff1fd753 (commit) via b59c39b271e1cb39e4faa54f1af4bfcc2a602807 (commit) via 038fe4c2d44da58ca626cc0fb63c482ced660f84 (commit) via 2a385334eafb4385c25845ab6114338cc160c27e (commit) via 27f7bbbec20966c671eeb094caad0399f54d8203 (commit) via 99ea13988da6a6e5234aa4f5f3614b9aacfe1c5b (commit) via abcb7ec8750a263d0307bc41d86b798e5ae02966 (commit) via 5eb07b35d430b68c6d816476190035e0774f18d2 (commit) via 9b7dd3ca2045ad1187311197abe003161c816b5c (commit) via a7603a1f684f0ae5a2084530d44e37f29ee9e41f (commit) via b3f0004af7e203df2d5d887a72fe7af7b9c217e2 (commit) via 48841d0b5b10382ac7064c0704c5e346100fb08f (commit) via 585a57ea1ec547a26a335a56db3c68c2789cdd11 (commit) via d747900bc88d2f40b434a7c5b5d8762e789087ea (commit) via 72c2256633e37b7bbec0ea72e90e27a0267bef8d (commit) via d3a3b0ba27fc46a48273f8f311e1b7fd751fcbc5 (commit) via 7a957952dc03cd0283a7e8a9fc8ff1daaf012713 (commit) via 3944f881f4fea1c7e94ed77d5723a41f495c880b (commit) via e5f884c8b0a1af4a84a7f4aeb0b22d033fd1c6fb (commit) via 5350fd741f0ceafdea69b3ec6b04565b47146822 (commit) via f411ab39886c5b372371b939311d9cab54a9a183 (commit) via ccc55bc80cb8965a73fae980d6e1babf6d8a8823 (commit) via 1834dca3654ccec238bae130715871be3d8fa344 (commit) via 02944c412b4d9d7661c0a2b3eb9df44d632878ee (commit) via 461c8a7b44a2853d2ad3ae3d0586b4f21b9feab8 (commit) via dc64ce86719ab634f7f05b785f9ebe154ec886d4 (commit) via 8ffc939b54cbfdda4698bafb60ebd0856a575853 (commit) via eb8ffb74e27523492855268abf5cb45927ffdb04 (commit) via 114c989fb37b25671d8886458b206f11471b3277 (commit) via 40fc796818ffa8476ff0868c39ecb2375a4e6ace (commit) via 0455040c0e26b9b76d10efa8c321099989dc7b7e (commit) via c4af29ceb2485a356f97ce7d3b1d1693c76588f6 (commit) via e77dac09f14623d41050a9652e6a79fd12bbb28a (commit) via 28b6616ea0d39cc699e4db9bccbb7948a55c7239 (commit) via 219c5463d121a2ed51820fdda60a48e3fa27c6ca (commit) via c9348e1a703949def837c3a07f4ecb019d87eba2 (commit) via 5320bdd00e8139a833e67dae228f444761c02391 (commit) via 290fd76af6d2bd1dbc07f4f0b20f71ee8d6e73b3 (commit) via 8606062cb38373f7e594bbaa812fb19719d7e6ef (commit) via 1683dd11e76f01760665ab15cd9204fa19923238 (commit) via a3a906d663cdda569ab09ce71742d0f470f26d74 (commit) via 48e68367d9d0de933648c93fba9996993848aa5f (commit) via a6d0ffca86662357893c2ba6986964cb341a73d1 (commit) via 6a00fa767fec78020203e1f53062c6a2e5a117c6 (commit) via bb4726abf220e5223a8eee8120bae14ef2f1a4a4 (commit) via 3d6da018e7969c23b172b37a9f556696783ca9b1 (commit) via f6521b295dbb1c5a53dd4d43743b8165010de34f (commit) via aeb864e685d608183b53113816a8aa1ba0409080 (commit) via ec0ffc043fac4792ccf3055ea18190894a520577 (commit) via 3ed5b4fb67edc6829ece7adf542f44e9a75185af (commit) via b59dc97dfef3bcce71cd393f4d2493e7ba1a8f82 (commit) via 52365a55e4e726176e884e510123fbbfe7801346 (commit) via 986a084de361d2d3844f9af8874b7e3a2a636b46 (commit) via d1a6742d9bcd76c0d4e52c7353d0740463e45bb0 (commit) via 140282cbf012fb3eac20d24c388d12e8a875501e (commit) via d7bab0b46e72eb30e50ad1b6a0b56275394406b4 (commit) via e1850de29442f4de75e43544dfadd855e36dd6b3 (commit) via 3c6cb2f85646b12562a596bd5dbd8f2b9e672606 (commit) via 952dc3ae323a5e39ffce19252784ace1f17d24ab (commit) via 9cd82c3753d9d0241b89801dc10f9baaa4dd5d4f (commit) via f10237f0a512139c44f840bf363353c755aa8818 (commit) via 67ffa3cf7da172df53a821d5cd4c1a6a849f4087 (commit) via 041e3e7c27c78308d0d515171f52a39f8260782b (commit) via e29378b030dc58948263abead03f7e1a49e3f415 (commit) via 18b240d7d2d8a138a1837dcbcd3b0706353a007f (commit) via d1a79a6cac7a4d5a3f3fd3f92330686047e34d2c (commit) via e74800d3479a937692114aa026522ff4768d9ad2 (commit) via ae65dc20eae7e21010b6e33b2cb11724d403acd9 (commit) via 2fdbeb0d785db8d63849f0205313aed4d085f3ec (commit) via 1e892a1db65ebfb7ea49bf7e605d2c2d9dfbe9c3 (commit) via e73135a9f1a275d940b8e97060b3c25d92176948 (commit) via 9c6d2af0aef5b13cb739794ccabc09d27241fde0 (commit) via da910203539afc7fa37caa17ccf41674d7953ab0 (commit) via 87a8877007471c0e3113c21c8675bfe5d81b1289 (commit) via 944a3c3a582864ca7cbe2bbb1af7291089ecda9c (commit) via d8658716277bbb2378819d25997ce0646b72c9c2 (commit) via d35ed012ce62fae4344e80a0df3742619a4eaa0f (commit) via 7eb2c7dbc7b0cddb18297268677e3dc9a073f320 (commit) via 78ed5f34f574d6400e63b7f8c4f358c7c69a24fa (commit) via c0514ac4330695c66d346067d99a429c2bb6abbe (commit) via 9b7ad9c20e3dd81b66251a058874a2c63e42b458 (commit) via 076fee6e636db2123744c1ecf004e9c6ff9b0a8c (commit) via 18657caf8d5c5388190b29c0cc1b4b94c997d5dc (commit) via fdeaaa362a84f49af176b1beb4753396dee8ea18 (commit) via 89ae2826d6158e62fe3db9c18d01721a2168e9cc (commit) via e1f3d9dcbee7dac3ad06d9a0ca2e63896e1f7305 (commit) via cf110add653b5c0ed531f306b8d429a41c860d0a (commit) via f23a6e193f90a02542c85cad07cb073abd6eb678 (commit) via d2a7a806ff811628eb75e415c8811600420b14d5 (commit) via 1ecad014202cff8f5f32bb91767240978a276ed0 (commit) via 1392b92d7cfd28a3491596a92ee38be73d1a5fcd (commit) via 0074855364047c362c6161ddd68cb206c221c893 (commit) via 9ac02f18c981c175be83b41bded7462aef128a3d (commit) via b99677dea95a8886429574713d5a78dde9181959 (commit) via 73c01d6d0562f138b3aad83b6b2dcf8d3f09dcee (commit) via 8fa4a440a8f85ff9078c7c28e3747decede0848e (commit) via e7b12d85502e2827aacde3efd0821298bd8284ce (commit) via cb80d6c97bbcfe6260ed64d3d747ca26047ce1b4 (commit) via cd6e56e03a6a26805f64140003f149732309966f (commit) via 76d7b7a519792fb51ad6694ddc11a506247aba40 (commit) via ea6204cab695d5a9d15fc5b26379a8eb8a8fc463 (commit) via ef17ead7723676ba4719a08af25dacb449f8695b (commit) via 6cc3abfc55ed4c7db7e423c4552c4f3c16749fa4 (commit) via 0780975703887f4fb21cfaa0c5869cb49daea482 (commit) via 121654beb22b6e16023da17fff54743fb555d37d (commit) via 3a80970f12e829a26aa558385c508c19c9374d24 (commit) via 80424d135f105d236438e89d9b60f30209574c87 (commit) via 243fa8c4416c00ff1958fe837c401028ef7ca901 (commit) via b6f5ee68f646715db094e55aa33b0810d0da1814 (commit) via db811a699d3238425a22f6b8b129c259e97262cf (commit) via fe76be0b5bcbb465d4b510135922ea3302c8c705 (commit) via d790c524b41907ebaa0f29afec19ee6913173129 (commit) via b4419eacce6d76f0e854280f8c20d4849ba2c067 (commit) via c369db08eaecfd1ad6b87d43b1b99be0224752f4 (commit) via 2add5e701f3d7e397ef46f144e206fe4c127e9cb (commit) via f5bc86df043d93bb76226f0bbb2c4ef5613f226e (commit) via a55a96a13ad60785f41f70a67cec2b321670b5de (commit) via 053b41dda37d45f4fad121a272ecdf7468696d03 (commit) via 5e17502d395f489b3a630f5538f7e78abde8e140 (commit) via 462048b2d337fd35175767762c2f67b0726c5ecd (commit) via bceae3cff2c8a635ef112b3ac11f36679d77ed20 (commit) via b993c6f05c3a9c3bd8748ffe57928a8d790371f7 (commit) via c58aed9b73d8989ef82145626e1701769b21e705 (commit) via 36372a2465c94784240ba8c38b53b4eedb234868 (commit) via 871f75ce85b7c3d0c58e05e90d34791042a8d5b8 (commit) via 2f2c2b06e2f43c2a18bf1033253ee07c4b2b427e (commit) via 8d5726dccc6851aa99707f4ff3cf9d11128cd822 (commit) via a501321cbbe2a23faa04031ba1567be3d305daee (commit) via 86919416eefb021630a869afa1da59bbb2cbb9c3 (commit) via 1ae41459943496528fc5d2d54a7f945ccf9e0f89 (commit) via 641e2fc573b98917916245bfdaf3461ea82c2565 (commit) via 454a7647f54743b0986b729c8956da84e436f5dc (commit) via 9a1a8f77e93601fa140b7d8305839455effccfff (commit) via 7540ac69381518661065b33096bd448d1b4100e5 (commit) via 4e63ec305bd7e8196561be58d12ee99f54eca371 (commit) via 2ad15073446ebaf59f1a9186bf1f6a5e55613d68 (commit) via 0b2ecccd863b577335c1c87a902783d3de158839 (commit) via 8cbde93146bfd72e98b942fe81d69300f9488dac (commit) via 4a125fb183a5944693854edb8cf07a7bd57b90df (commit) via 1470aeef4cd4b1660d68c2907dc7b58f9d16df58 (commit) via 3cf73671d10a9c8f6505c57397dd833c7e3efc4f (commit) via 4a08c63e88715656e1d6294a8978f9573e516286 (commit) via 90e236fd09d68bab09edb7b93227fc02de561a38 (commit) via 23b6028e1d729e67af5be1bb4bdbb5c88c284393 (commit) via dd562b503f2ff089968283b1593496c007f854a6 (commit) via 5968fc1cae5028002d4f974e0464608f73204b60 (commit) via fdc3023bece20993237f8e5ae959f23fff437d69 (commit) via 6917ec769e4d23fe2fa212bec69c9ce9b65c1671 (commit) via 4fbb2df3cd160aba589dc0a576b44c2a63b4a6fe (commit) via c26ad500ecf2cd04e9f0ba41402047fa1cbae678 (commit) via ed9d08552049d061a8951f2dee5bc7b73173c14d (commit) via 496797f0dc414ede3e0e6ac297ab7d7ed966d76a (commit) via 93e7bed24ef7ddbaeac915eedf820eb0b19a62e7 (commit) via fe0c2b04853226b64a1aa17fbef6257c856e3fd9 (commit) via 129cb60f56f42e58b9e589d79ac3ee317066d43e (commit) via d17633892c9c3d25f3398487ca63592fdc973bc4 (commit) via 5b5584878998ed602f560fffda326670ac1c9083 (commit) via 51ff1df443c02f03d93a68a989255aa90740acc6 (commit) via 262a84c384353b2a88a6e81cdc499ab94a8316c2 (commit) via 61bd626d5d10a7cd0e2dac667bbb262452fe906f (commit) via e9d8eba4163b515b58bfc0b8614a34876b2628a8 (commit) via d6b3fcfeabdec2fee8804e2e7a779606dba432bd (commit) via 1b79315aac6f42aaff8b286792af0b53a1b61a5a (commit) via bb47a68e0983fa4da5b607dd775e227528da1955 (commit) via 752d0ef753983b45142e76a71dcdf3ab3c082439 (commit) via ce8f8719004045497f95d1729f33053da43f69f8 (commit) via 1097e8020ab06bbcde3e3ce6f1e324535990547b (commit) via f902981b2d0f845b57aa939d8c160d3bc74499ef (commit) via 23234ac87218ac69acb8ac2509127af4c0ff088d (commit) via bab9abfb7d259e1daaf84776ed9d4d09e2469293 (commit) via adc1aff0a54bb54d313ea82cfeb3cb928d8f1974 (commit) via c42878bea8ea41954d3bae75ab749ac7881201c9 (commit) via 241008c8611dc9bdcfe26af4f9d4258126d9b261 (commit) via 7d4e0870708fc72df281214e3a6284c7a6aba282 (commit) via b695b3e2f72998d66ca4b7a6826d4ce1688060c8 (commit) via d8e2bee9ea84ec5123d2023f32c0f0d191834d32 (commit) via 925214a3e750eefb62630cf68e168c31b014fd72 (commit) via c2b9c90367e2182bc7eea4832e5a235c97b18133 (commit) via a398a9573d36285fc4c6c8ddf5e8d42a150e0fc8 (commit) via 18d49f467d21741394190c0b15f9430df14f4c19 (commit) via ed68e05014018672ba6675c8b970b4471fbb68c5 (commit) via 658578a5b935d12c86b4181f9949da54a4ba7e0f (commit) via 71cec74ccb626edd6255d5bbf7cf95c01c32430b (commit) via 584c478751db133ee416393a77edfc8c32b8101d (commit) via 7f327cc5800817b7c443616235c91ba2c82e7860 (commit) via 252ea22b97c0c0fe7a7ab1c712f275d52f1df2cd (commit) via 2114923ec1a133e44ebd9403f19a07e1a0e539d4 (commit) via 848cd4e291782ae9a59a3d4719d384870e2dddd8 (commit) via 00e217a732dc7d8c38ea5fac93dd81fcc0bc0ef2 (commit) via 83cf4feaa980fb9d49e42bb3363c21357dbed6a3 (commit) via 81b246c040ab9310bf4fd96953b8fa8717976c4e (commit) via bbeb5acb07132335fa7ccf89166429359cf1be37 (commit) via d9f8ddd78049eea607e052c562813e95475e8c44 (commit) via e2deb54414d4b54bf44f8369ccc9a0ad8fc7c172 (commit) via ac1d52aff5bdf74600ddc2f8f06ceccf9d2037a6 (commit) via 665eb78729c91b4056b3e58af4407f51df603f55 (commit) via 8ee4920c76fe690142482e22148f1e2f14cae01f (commit) via 9b93e7e5b2fb898fff1815345ac0a63087a74758 (commit) via 8d9fbdf8515b89f4739a4bddb80d944d2a53b459 (commit) via f4e958c2ea08e1552a05e69d2a409862077557d2 (commit) via ca8e9a84a905c51c1d426460c99beed6c833a9d0 (commit) via 256622cb710a3c8096d5d24b49cf45deb76e0772 (commit) via 129ffaf11b704141b9d1049b4bd293744493d4ad (commit) via 435a8fb79ce4a482ede1764ef77ccfe8eb7f931d (commit) via 21d96b04443a63e6e0b5fdffd19017ace057ee25 (commit) via 1810801a688eb5d15fb4a6bdaeb03a497abfdc47 (commit) via 88d8fa7440f923905849338ee1bd70d238e799cd (commit) via 5d1328c5285e1cd3f4e1620dd33babda47bafe92 (commit) via 27011d312343a0dac06736087d1a94ffd7ab763e (commit) via f2ee064bbbdc6f00466d0705401fbdaeaa965702 (commit) via b0b5bda7cb97ccf3ae5e0052b8d5c05b69f23f9f (commit) via c43c58c434cced3df2e208094d1891e8447e0cfc (commit) via b4fc532372f0add6bf1434a54aa1a3a457ab3a88 (commit) via 3006ffa615d02dabe7431394b07e8b2d9888ca41 (commit) via a595d7326b4a42f15a7b3109a6e81b4de02bbc14 (commit) via b1302f0f28e8af4f3b3f47bd0a6962e514af7b56 (commit) via 0bba9fb60f832dcc475b0de25e14537d61e11a0f (commit) via 65bab716bee4f537f6dd63ec9dba3b5df2393672 (commit) via 800b26edbe34e135cc9be1d4395db2c13ae1213f (commit) via 7c40580584eac67a23633e58810028dddc58781c (commit) via 58a44aef230c2d9ddcdca6c892d22e0bd836c9d5 (commit) via 7deb2b432b08a5bae7c138eae1a0b2a2a50a35b8 (commit) via 3105382bed06a17f993421e2889e66189f2551ca (commit) via b5a1145cf15b51dc6d6a5614c5304cbe74cbf556 (commit) via e38c89d3a7aef37c404a616c493ca31c10a5afbb (commit) via 5be009d48d4ae869347309b6713d1e3a206e0398 (commit) via 54e54c64bdfb11186e8930396be664796080ed6c (commit) via 66b5afa2168e6957dd5f4b55b00b65bde4a35693 (commit) via 2b03b41bd0a894576b59c2dc6bf1d581c970cf16 (commit) via d283939303f9ebad95ccd845930417f18851c6b9 (commit) via 3d77e1bbcdbc5064fc8b2c971a4cbfc4cd5e2f72 (commit) via e13e2df9a1278903c66292a4f7b823c707b30cb3 (commit) via 447291d84a63d3e707fd00111ba465e5c230c849 (commit) via 8e5436687a46de93ee40f4e8ab510cdc5768f9a5 (commit) via 98ca698a3705336a75020e03ba2ec5e6d80e34cc (commit) via e95623cd6b46552eb7dd97cfbbb47292ba002fde (commit) via 5bd8fb4131a92848614590fe5d7aa28fc000fdb2 (commit) via bd130e92733db5069331021f5be4cb4717603375 (commit) via 95d62171934dfcebc0df44ca15e894c6db0269ad (commit) via b032b338010830fd9994a5530f743dbd3112a3ae (commit) via fa6dc7b3fb60e38869f01c73fc240a07a7db1eda (commit) via 3f11c2f7c53ff07aa2d402eda013259706f257f8 (commit) via 499ae4ab573fbfefdb1c200e3177e18844e545b5 (commit) via 2092b66a0bbcef2764e3d708a44af2f378b39dba (commit) via 81805717dea0f1f2048748165e968147f0b9cd7a (commit) via fea67da276df03ed39fe552d6df2f3304a03e7c1 (commit) via 13581e6acaab7f0d98b530a1db1e0b80c7c6a938 (commit) via bb69464e4c5d88a175025a79c23636d7628576b0 (commit) via da24baf510df4e5273da57d3b867a4ffbc64bde1 (commit) via ac41b0a94153dd5b7c1ca946b74f2ee3f81ff932 (commit) via 29c32812b42a8983cb2210833cd9c3e0001d5d03 (commit) via 4ec8ebcebbbd67a54429d3d18982aaefb6118b91 (commit) via 92be91f57a162136523f40b6f9eefddacf7a3328 (commit) via 1cf6d365b2e4c0e97411698ba027d62de4437523 (commit) via fdc8845803d15bc55fe8673bec22290f77cceed1 (commit) via ff302a283d2654105143377823dc6fafb88885c3 (commit) via 73329d786ba6643784dc0c31cede88ad4da7db4a (commit) via eaee0678ce2566d3bef43d83acc7463c737f8ae3 (commit) via f35aa91c1a07e420b4d4a9c51342bddb8d3640c9 (commit) via d337f4c5b74a2824bc7de34161ac30b54a3b0e4e (commit) via bce5b50f734bfd63b29ce44bfce29cb2d0d094b9 (commit) via 7cbbbe0bde475786d661fe887ee2340a269f1063 (commit) via 0c382106f8504315039510e4adc67e0e5c2003cd (commit) via 6ef9538770e95bfcdda8422281013a517f92df3a (commit) via cb7e896a4a450294dde70f01dc7cc105a883ef44 (commit) via fd46a58581d0e5bacfb8bf5e57670adaacaf18ab (commit) via e935e902d6ca1ce3265edd944bfe045b05706ee1 (commit) via 19a46ba774b127ca0b6a96772310f149f2ff198a (commit) via 775bbbcded718ffe6d429bb68e1170b2ef3f7778 (commit) via 50b91d0b4dd057608e521d0a6e82bf08eacff812 (commit) via 784ad7297ecc603390797d4c4c5500610a9093e8 (commit) via 645dff11e1c59c3e6c5893127d74427dd633778a (commit) via 414a63f16099b37eac5f90f51bfbc64589a48170 (commit) via 3bc743a9fdae56ee6be71feec314864bec91f28e (commit) via 39967011836c1e23dff188ffaadb747d9dcda062 (commit) via 2ebc41050e43c508edbc8c0fa8cccb9797c463cf (commit) via e7e4dc5d98869f91af3e649324d726217b2a8861 (commit) via 74936320a43c18a2ad538c8235e410f4912f6e4c (commit) via dc269fcd6f1ebc41d4e164f14dbb2a078bbb6265 (commit) via f2727b571a4d413857c027867735d23fa1f28c62 (commit) via 43678551636f9845da4d52f48f8e82931f6b1c80 (commit) via afb252355bebee80673ea904c6b510aeaf10feb5 (commit) via 78665f5211fa9eeb3031dae2de8e551bcb2369ea (commit) via 82891e37e926040e89d4e761f93ec5c6cc0ca52a (commit) via c57ab694eca2e3d0bc6c7e8c01df8dce20c3631e (commit) via 25c5d830c95872630ca87d21a3d9e3a7e084e0db (commit) via 35a1907fe6a5f7d630223ba38adabc28eeeed971 (commit) via 1c25b71c7b4a6a993f5957c9adc1f598f51d4cd5 (commit) via 428b354f0d4262b47855ccace409ca21d92faab5 (commit) via 8a6ea0e454dddcc1d9c14ad1e02a43a53a4ef667 (commit) via 87431fef2836c8d77ea694844cd5dff0e8b801f8 (commit) via af285603ee82ae9644340c2f2871b293a8480c39 (commit) via 9f67e0a0d628209f6f979b6adf4a0f58e39afb77 (commit) via d5759b72e60418df09a99b627f13cae6c4baa70a (commit) via 36faf3203af3a5b77cbe19f232ee77b7ddd2cd50 (commit) via 8730b2037a6a999af28594607a4c27c3837f8f83 (commit) via 2125275c7cc261e101731162ac1eeba7626ce9e8 (commit) via 3f189bed2f343893a4b9df626875a930e03c91e1 (commit) via ca7bffbfc3341f6ff9b5dbd4efa15bccefcfd744 (commit) via 6565923eb30c9421992bea3a4cba28d0eddb6c2d (commit) via 1a3bd52e9107d37c004bc094b633d2ce4455d150 (commit) via 465f75b5292e4c57762200ca1b87cdb225dd6484 (commit) via 4a1f8f5f27e165aeba0b1441f7f1858a9c60fff7 (commit) via bf8d8ebfa43366bff4edd9f16eb1af078ce36985 (commit) via 76eab87c7de02a6586c3fedf913db820f4fc3cf2 (commit) via 9e7cfd32dde5f222d59e78b3acf1d3128d63a91e (commit) via 458f97b1ebced604ec9acf5690f3c9438169b5b0 (commit) via 96735846beb4d067eac220c48f5d8c18f178e4c1 (commit) via 4d6454e18027a7265138e16ef95b52000825aa47 (commit) via 371b5c526b439824ffd0eb2b11f76689436dc6c3 (commit) via f8a1878202f46dda8194fb56af7619c887cec806 (commit) via 0e85c0ad1e61e8bf9bebedbdd643c237391d5eb5 (commit) via b6d6eb90970993a6342834317cb70e2519cbeff1 (commit) via 0c1ea1cee1a3b5f3ad9e176591bbad58b2b01ad0 (commit) via 62e81c5846afab51757eb48826ac02522e9864f3 (commit) via dc0e6ccc9f9aaad7139c1edd3b723c4b939b15da (commit) via 5dd6a9cef95daf6ccee5007d766f10864f7dcc34 (commit) via 99a53b2b95b7a297134007f5a6ebc6114db32d15 (commit) via 3593f0953fc0cffbe1999fc7f4b03656cc36e761 (commit) via 1344e707b7e8aabc3b12ffd00e5595310e5508cb (commit) via d84d43372c3aee0ae5a1dd30edff8243acf41f14 (commit) via fa2649ac61755b462ec49ea0a2bbfb8569dd0bad (commit) via 19b2ddcce1cdfc947220acfceefd0e3b98401909 (commit) via e2179a2ac55829c59cb49a81934c1ccfa65110e7 (commit) via ea97b3364cba57cd041dde1f6348d029ae3851bf (commit) via 1e707e33fa88f720e09a5d0cc0ebee27d86582d8 (commit) via 4405c5d769d254ef6b28c0e3df53041ddfe1499c (commit) via 9705f653daa134cbf63098ff44d5cebb021bffb4 (commit) via 147e491025ff8ca590e28fb066a833fddda87291 (commit) via 0dfff8c4b4e4ea26b3a22ef6800213ba8a9f4f03 (commit) via 8b79187b6613b7b984ff85de85a225f8a1f33a5a (commit) via 156a0b62eb9dee2423b6d7d7f5aed1a5b6cb33ae (commit) via ba6dd97081c7490db0d6e98c9e8cd3b819b9dd6f (commit) via 93bda0b18d68d07f7601811687e44811d14e97f4 (commit) via 23afd28daf7a8ccbdba395e83fed79c0ca352f50 (commit) via 08bf89f4877b65a6a31c33023d8022bf9d94d1b6 (commit) via 10cc91f83db602878e9a811a20dde4ca66fe4140 (commit) via 2ef00337c4c95e15f8f75bdd0c7902271c7c8336 (commit) via dc18da434b04f8cf01f940bd4f13a37e19a96e8b (commit) via f891603a47cb99fd842fb06a6b0712fa92041fc8 (commit) via ff3bd8c7ce5197ec533c8115a96655a4829d9c82 (commit) via 72c2e53981a204d746737d8c01c4ad3738cd4880 (commit) via 62f705e8445336e73a81e1df10987e24529bf418 (commit) via 711f69c807a5566060bea94ac7042b43bf3cbeab (commit) via 68ead1d025bd63079ea5eebbb5d767f8d0f98459 (commit) via aed3e66672083940f94e0b33f5b2e9d25776a4d4 (commit) via 7e6f6562fa1cef1ad67c0839477767ba5c0e43ce (commit) via fc318e6a1f2da11e3429e58cd9d2893899f547af (commit) via 1741b6b23c39d1f38956d005d70cbef2ee5e5f79 (commit) via d11f5dff8ef9e615a8d5d01ee8b88241fea42f09 (commit) via 802517e91793fc69f834b40109f36b64c3fb4b7e (commit) via 834c65a1f885e630a4ac5b2a585b41f5715e09c1 (commit) via 0cd40887d4963cf20b1118eba4085670d5cf1b01 (commit) via b4856927eb2593795f114df8606f16136fb5048c (commit) via 002133c606b3ae9b4253614f69250dbf306f358b (commit) via b70429427f8264ca726d19910fef23b0ae77f347 (commit) via 3c2f2179403f3f0c983f251b45f0cd5fe1be9a13 (commit) via 9b82c6b21e02fb0a2af37ed5f0847de59b63f9d1 (commit) via c04c92fbf9986931d437371bdf2522f191d496ce (commit) via b3f4ca6077993450a2373e0ebb2c72e0f73d487b (commit) via 92dc84cff9dcbf1bcd6b9ebb3827f0f7a9c1d1a5 (commit) via 8894195a47e78c8f85744cc9f52b98a03e1da77b (commit) via b9c5601dd8f16a45b120c1f64994d1335a282b09 (commit) via 71389177e44d6335c891f6f7733e3df799dec8a3 (commit) via cd3948f99e02cb48af37785176cd9261ee01c2cd (commit) via 6f382fed37fec0a8ee40bd06da861ff3e94a33ae (commit) via b227943e66c7839dca713be60f6cdaf70ba9413e (commit) via e00162301b243aff8d0e2760367243edf222a150 (commit) via f6edbcd6439666319a875c5b4d4fd80b7834c57c (commit) via be625b9be781e469456d01053336b18cfba63ede (commit) via 5d9c8ecbc1fe53aa17eba0b29d7f5c397f86c514 (commit) via 78ee8c419fe7ef07a7ff90b5b763a96d406c215c (commit) via dd1f75a53ed113454fb7c6d1cfb3a9463da0ffb4 (commit) via c571e692085b4c119d9ebf5c526bd3be77135361 (commit) via dd4f8d08b2e1db8f12cb3deabf2b81ab5d86c4fb (commit) via 062ca10cff8203330dc8c56e99a52e0b8e4155ee (commit) via 93c358cb5d2a6620d997862ef39e1082e47e8329 (commit) via 66b441f3d63e21949530d672bf1406dea94ed254 (commit) via d518f28b395a7d1c8588c8f321ad5ade194fb423 (commit) via 7e4723a589bd266d50bff10cab34d2b6838f6412 (commit) via 50c337f40a55e5b27d3442899bda60edebe38691 (commit) via e8c7975b6f0a83826b13b407b84f941124767080 (commit) via 5bea387c2c7fd37dd0fe1784d6f84e400ad4ff09 (commit) via 649c81b83c295ef96460554e8e02c091bd6ae815 (commit) via 56a130a152db73ea37f91d39be7d72f814013236 (commit) via c5165f325b6742f407a951f9c7d959314f15a6b5 (commit) via ec43b0faa6d8106205073c7c8596ed7ae4c64abc (commit) via e14f1ad37ded19188e864b82ed236b1eb11eebf3 (commit) via 6d8661ceef654b7857caff35f27b71ec364f7f1d (commit) via 3a1f958cf87f15cac3b92738d019eb11046fc580 (commit) via d887d76f277be4aad9c0e86292d2f7b5b8537abc (commit) via 90867dd8e37c3e348ad2ecac9f30679666fb9fbe (commit) via d21eb05ebadd011083b3f9da3dfd320a55c7bc52 (commit) via 9a464fd9bd9b43bb4f7fbe8a9e5e0c6c34ffec50 (commit) via e4ac91091d874129737ec797e6a932962e6946cd (commit) via 0de8c6f4c70728f803de7a47bccd982ec48b691e (commit) via bbae1d25c2b950256671576482896561995ba42c (commit) via e73571117cc991bea4e485e201809a6a0ae07247 (commit) via 9008d7f867acbef624cc9522513d39521b3ce2b9 (commit) via d597b5d61ec941df2c1a3bd56c125dd70aa7d47c (commit) via 39ba9d4e7fb52ca8017bd4e934d6e6f8acba8d4c (commit) via dd1c18dd031038cbee7e219e322cbea1eafc87ca (commit) via 734c5b35a5491794dc9cb31ed07a8d0d5576d4f5 (commit) via 3630a447d9e73f3e04cfe37dd578d22a452fbbe6 (commit) via 62b870a72261f71f66ece9cb3b892d9999e805e3 (commit) via bebd79aae9ccaf5c96666d38665b69484f1f3eda (commit) via 63966ec5d5b65cde2297f1f7417d288f884a80b2 (commit) via 765a67b68af28a6dbbb5c79d350896efbaa7adf4 (commit) via 1e8e9a807fd18c070489988c03e4ae5b4701667a (commit) via abfb6441177961fbdfa9648fdd2c40ef0ef3cefd (commit) via 1bc6d4e96573f89ecdd719cb3cac92754b91f52c (commit) via fe8d897e2557f109b252ce83421d929c1ac039c6 (commit) via 7507b11ec4440b8183a10113f5b33f56e6202c0e (commit) via de1b26a3c6fa27b29157e86a6da03f354586badb (commit) via a25af02ef7c3dee6d83f5d61fdb62ec8ebec971c (commit) via 930f6345157659fca89d922612bfbb69d8a8b53e (commit) via 78f9a07f0a43cdd4dd9716c8599780609d00c390 (commit) via e1ef732c11da520262476b782bc73bfaf6e9ef1d (commit) via 83a4eadc070bcfda137b0f44e02712b46e5cb1d0 (commit) via ce25b358a94205c92e3b2612abf12119c50af1c4 (commit) via 0527747e23f85bb9d3cf4ca69364e615bd22e1e9 (commit) via 18237cfd1513e10bc02599c263fbd855551da628 (commit) via 7dbc520d57b8567738a15f617a11d9b5b70f40a7 (commit) via db3be9f850446c1a1c4894f5d08d67a370abf94a (commit) via 051dcd1086ad98d4c604740a6f95fd8eec9a75d3 (commit) via 7df5fcdc51cb2616dc7ec97187e73ab7ecccc7b3 (commit) via 23afd9a18453c23cfbbc6a63f52b2e6e64e0056c (commit) via 27c10ed72ea2451bfbb6c0eb50af4280e65a3fcf (commit) via 5907d17b9a36133a13a11e1aa437e178b6c12b72 (commit) via b0edc623b12a60ef6afdf9bdf9f762d61748df58 (commit) via 695d8fc3183898d9d63c017b0b82716126a461f9 (commit) via 2b615cf32250173e21b36960b48c290298b360ca (commit) via 985c0594a57317dbc612228f423fd38967c677bf (commit) via a1218446d9990fd2710c3f9fe565907c202393a9 (commit) via 7ddfee9aead225465cbcdd5a29d7af5332bdccb7 (commit) via 7c9ec1d13cdb29725c6d093b7cb21357fd43b5f9 (commit) via 89e40fad2975fe8d1fcec8f786b19e45057938a5 (commit) via c6c709490c5a38f7e45ef06843d30b0f8b40636a (commit) via ce181cbc87f8c9012d6df79b1e9280908a78ec51 (commit) via 087faa248845059203de152b6c1cc806f89a8599 (commit) via 86302a7622a1fe529abb042033a856bcf25602fe (commit) via 86cb152b2fa95adbac629a65398f4b9b9949c95f (commit) via 3a6552744f2e44954a9e378dd076c8758bb5f1bb (commit) via f24651493d04b974722b0b70179bcb6b9150a605 (commit) via 4c8dfe6f6ef54e9b413a31f5f4bc18703a6c114e (commit) via c59601eeeab2b6e8778a0f9f0afd03d9cbfbf3c4 (commit) via 398dc811273b54d14e6965bb1af9cfe1360650f0 (commit) via e2afd06e6514721d2b9142269bd2bf1eb97393c0 (commit) via 764431f8825ce628a01f14ca83a8bd29b094a8b1 (commit) via 42f5aa4566d4a933270cdd50138d34262e192ada (commit) via 33d28030b1721c847780ee7d563515cb661746ca (commit) via 395c54c4894dc7cc9d0dfb430e657c357075ab63 (commit) via bb7511bccf5427a25dc26b14ba7fe76d464e8e2f (commit) via 4ee492e9109c95171bd425b4ac327c613ce56f00 (commit) via 545f20022419affa1ad71824b434141551359cc3 (commit) via 0a033cdc653b0ce4ec921312b4a34c7a028039f8 (commit) via b085418501ee1222b75cd424e4a076c0ca99ec91 (commit) via 4330b268b22be9ccd54ef5e8a64469a39a6045bf (commit) via db41ccd009ab01179f8629ba962e76ba7a6fda61 (commit) via 42a9e893fb95f8f8612b52d4be00f7bbf6f7546b (commit) via 1ceab868cd0c86e1a64e0b80150163a5b87b51ea (commit) via 4e4f1debb75bece8f0a130d2f356f12bd5be0f00 (commit) via e82adfba74957948781c0518088bd16365740c18 (commit) via ed20250c132c5855dcb0df991c31ab4de6b47a61 (commit) via a0973d0f947df731e9e182c8b03d6e351591f457 (commit) via ea49c337c59ac9a8d0b868581f341092f4b61814 (commit) via 05b1d35586aee37dad7d84fa27531fc9794a41c9 (commit) via b4a6f4e2441153ffa8c6df7d790bc9cb66df0a9e (commit) via 6d092c134477ae1bd081a0ce8d79d964eb5f28eb (commit) via 985a8f297b5107bdd29df561fce1cfce5c541863 (commit) via 6ddee4aab22a96c444ace755fe33402f65e9f775 (commit) via fb160e53c8a9423ff78688bc9ef1ad5e1ec1edb1 (commit) via b7f7bee8cf6ecb04a4dec86b80ce2065d4192da7 (commit) via de6fcf2f21ee0a69b1d4d418f0c6d184b161a203 (commit) via ac804b59e242c57e225c390eb8d6bec359a7003f (commit) via 296a36698b9ff2ab1beb3c21dc8409c3a276001c (commit) via 3bafae200f5b08d386b5a3503023c0e3e2800947 (commit) via 52332e3f9a98c618f9300d8c88955ca9d11627b5 (commit) via 91ae90ba82709a534d160dd35392dc60274ad3c1 (commit) via b1147a60337ff7a6f24daacfbfabb681bf031fd5 (commit) via 458c3c026ed03d17ec7803c61981274ee4574f89 (commit) via 0a99d3ef31611db7020d062216c856923ed29fac (commit) via b331641f98a1e55f7bd325e1a6e55206ecfc8094 (commit) via f97befbaa57ff432958d014b007c909e04cd8ff9 (commit) via bfad9c56f9e65eafba00f97e5e649842782eb2e1 (commit) via 859405fd2dd7b76e00d650e1674db2378e05beff (commit) via e7abfc397bfa8981b3813c19a64c36cfb275f21d (commit) via f46d4d6e3b0c1802829785222e17e6f3ea081303 (commit) via 16309e41c8b61e20307af9de40ff9742bb19cc6d (commit) via 93fba33e95006e18d1e16e3e32cbfde3a2457a38 (commit) via eae216ef1db4b22e533231c8766cf4fad148eda6 (commit) via 4dc02b2fcfa97e953e1ffc2c1a13f35f4a132965 (commit) via 14080744dba2c170b6bc718aef1c89e1e175eefe (commit) via 6537c996a62ac0540fb21e4b0462119422dd6ad6 (commit) via 90644c83725f979f82e7990792faaf6e847f74ea (commit) via c5529dd7f1269e88b4c122fa3c755d5696b58a70 (commit) via 749447fc803770759600e14e9fb42e31bafa73f7 (commit) via 091607f8eb336ff51f875918574c12256382c49e (commit) via 0e7d2542b0fdc12ef4e0c223d5fe3ecf2b5d669c (commit) via 7318d8337aa0f9466e08c8667b14fa9473b41a6b (commit) via e1ef8e5f7555a1608d0cddde6c824c5a897f6e58 (commit) via 08a490328387eafb7f9d20293a2a5e97e6cf4268 (commit) via 15ce2db13afa087be8a0329e72411f7d1b2b77f6 (commit) via 14e687c1dd17e7a39a7cf3293e3397ac36117e49 (commit) via 12d63c428f973b1f7e04ad58d432d778e2035a9a (commit) via 6014bfe6fc06786cd074bd66cda210b9aafa7d36 (commit) via bc924b628365480f1b2dd5281b8657a3ad3d1eac (commit) via c7918da8a6b28fc515d273c16a9ffca2a4b9e119 (commit) via b74af851471687e258fa7624a498981b77ebdba6 (commit) via 6e3133c41ca760e9c3156f641236af54c7464c48 (commit) via 182d9deb08125f9c595bcb32dcb28f745989d615 (commit) via a16126fffbaa8ee854b32cc80f94d6233ee3ef4f (commit) via de066346a649906e7105b18d9f7a5f823ace43e2 (commit) via 89fe6629b73cea803d6bd803cd9131a9f39d8ccd (commit) via 535ac5832dd39055328b8c211aacf77d654d5282 (commit) via ce3ce9e70eb6a2b9400a56d592d75df23682a40b (commit) via b91089befc50b838853f1f2b7b0bdad51537aaf3 (commit) via b913bcc13a9a6213902691a8d73bba1427ab407b (commit) via aa04d2355effb1cf611831b0a260cf1aff199b9a (commit) via b0432442c607c7d71e40c55ffd0bf46f43ef3d1a (commit) via 61380f950428dc7166647e6b5973415b691e1b70 (commit) via 4e3114d01dd2ddbf4044bcd5c91812d3bd3f7fbd (commit) via 85820a835426059b31479107ddfb660ff5067807 (commit) via 0d9b8eaf088628255e64343462ac0e2e90c66c67 (commit) via b289699ace2075c934f7009dea307156f9296071 (commit) via 0f868cfeb0260fc30f8fe0710312102dac6972fd (commit) via 0088d010edb1dc9704efa1ad11e7d0975b6878ba (commit) via c23e3761a550ca5e44cb3878fa47d7c00f469424 (commit) via 0a6c51e4a0319ca62fb41664da4eac7482844227 (commit) via e6e8b7b662419466a264201a6d08af2dc9a737e9 (commit) via d64c300522ffa830e061adeb81e75255b3f955ac (commit) via 4273eced0c24442e5e713762e97cba5457b23284 (commit) via fd1d13567d07bb429f9209c4c11a97c7ba02dab8 (commit) via ea1476c4f03845fa054cf590089ec33dd3999f5d (commit) via 7aa5630d1eeb4b25d2467b9eb12f52c56df7c96d (commit) via c1807eec7800c7b6ab8f99a42b1edca741d5da0b (commit) via 0870f8586a1aef45d668127d0f3628a70bd0623d (commit) via 2323b20779d1af74057b3e3a52b3f42b39ef91c4 (commit) via 15c4382f1706512fc5f4695b7d30ec4a195f2ced (commit) via d291d1a4239ed744c65b64d62aebaae88ceed552 (commit) via 5fd13dac123f1a31ad2aad7e1c7338ba25527b11 (commit) via bc880f6c3e71c1e1ce4eb19f6cfa404ae4e6cda5 (commit) via 288973ff7485d910fbef60ed2875edfd387f1a4f (commit) via b580bbfdd275e6151e2d67d8a03da6c9dae0b36b (commit) via e5755a62130246e6f5e5163f766579084a58f2dc (commit) via d8fdc135c4a075dde57d18e696216b53e934fba1 (commit) via 2196fcb0088040f5ad48797fb234c41eb561b5af (commit) via 45fbb287b42c47d9fc84c1abc9158a7d24333c79 (commit) via c703ba52adc02c83245a5d428e6943d4a4a0f995 (commit) via 2575a2e9a8928025a28d6873094c22c867ad5ab5 (commit) via dfa893b1cfd8491a3563ad2c29a0dfaf44d960cf (commit) via b85b946a94e0c27ef22084bfc390798c8c205057 (commit) via 5a85f5a40b265a5bd9d4a015ccf1edcee44914af (commit) via bbb13097417ce268cfa25a920ed85b59515f283e (commit) via 1ac9db4ca67b47da79d55e0cf309f1a40ca084f5 (commit) via 070e561ed99aca1b5dcc4f47f246f3a761876422 (commit) via 96d6267e2d18a04decd7fe6998d20b94ea5fb56d (commit) via 7cfbd2b9ba356aa7a0de2eb2cf06ae37fd6ae55e (commit) via 55b0c251a0379a5a0a0d713c48717019acc965c6 (commit) via 1d238ec636ff051635a7ed194df5c49752788d69 (commit) via ca7f204576d43e36275dad02cbf6e414447df03d (commit) via f6915bef29bd3a2f452ace0a3b3f47255fd041b6 (commit) via a8a0d5ff98e008a11ea9851f4bb09bd3663e248b (commit) via 6f9630561f0a0ae2842d90043b4ccc595ef06f3e (commit) via f19a2c0b8c000d5d7ea6fd9d48cbad606f8fdfb6 (commit) via a3ba3ba94337007a458e2d4c40f3a36ad4b0e9c1 (commit) via 731434cbca7404d5e9f9ecd1cc6a32e6635fd684 (commit) via 560945336c8ad46eadde6439955abd67cb52e4e5 (commit) via 3d78077f7a3e72722407649768f1b677b4e63180 (commit) via b6ab30127583d38dcf0d49548e842c410ae2c69a (commit) via b5505fd4512456f85188a81e9b6478ecce65504b (commit) via 46f4664b29a685a43dd5dd4c18b60e8bc1a5c34f (commit) via 9cfb746e65c42fafb1a94009fcf5d8e2bdf7c00d (commit) via 4acce81d127d56bdf62c2c7e6f321c2a458643e1 (commit) via ba92b90f8b9a1f3331ab10c2c49883ac32f577c9 (commit) via 356d6b8db04bfc15a1d0a5fabbc79aad0e81d592 (commit) via 0a3cf5d5cf09c17afd06c64172780b4a02acdb62 (commit) via dbbaa41362647569c0087c212e908c2ac570cbb7 (commit) via 0d6c5a79eb75e10f1d13b160c18a32c0bf57a2d7 (commit) via 1a8143172c973fb74fa7b329a8b698cbb42ef865 (commit) via 5967621d19204947021932ea86f1e55fbe810124 (commit) via f7054dcf0569756ad4f0f1fe32d785b91c4c05a4 (commit) via d3f636ece0ab60e2b8edc8648fa05e83338b60c6 (commit) via 282b59a853f95c7bf463b617f8d40949b8f8b3ef (commit) via 2cb717ec78e3479943dfe235e0c29c085a19ebfc (commit) via 1dd0111f5e2426390d36626f07525470d8b9a9d9 (commit) via 21c030ca752cdc9eaf3c5da4a0ade533f24cf1c2 (commit) via 55e050383082907c3054f65063f7ba77f609ab2b (commit) via cb89fdd1f664d68dcf3ed5251a4d3d43fe9504e4 (commit) via 2663881c378913d5c9cd123c469e1bb29a5e39be (commit) via 6aba76666da060f12b379cf8786686e545007f2a (commit) via d0a4a614f9116d97cdb202607135e7f1b3b8e3cd (commit) via 52bcdda04ec658a307575460930c71777e7cf4df (commit) via 9764cd0a830e87c8acf13b4d494ea7fe4df72f85 (commit) via f89b8ccff4d2172a8c244d46d1c559018b5ce917 (commit) via 2563f9dd797e93f932ef66554b5bff9e5948a322 (commit) via 9d49e1316689ae05d31efc866f04ac12cd051085 (commit) via 37ccb77a1ab845075465c2d86eea9e8e21abc273 (commit) via 9ac61baa862e4008ef8fd5326c9d8602f52f8ae9 (commit) via f053b082cde9e6fdc8e2bf789ca80bcad779b136 (commit) via 79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db (commit) via 2ef359cdae0e816db112565899c1ca0f349b4c5a (commit) via 9d189c7e20de37f95b2ad70725ab65b9bf863227 (commit) via b5948a042a9925619a464cde7b0de245fab45594 (commit) via 5842fe4afe9b5feeeef8cd78a82fa32bcefc1a39 (commit) via d4b0fb5773c874e14be91f861eae24fa60237fa6 (commit) via 1dea7f3dc17de6ac189f8d185d2c4c4294fed950 (commit) via af09db8bd3f0defb319df00fa69cd82044ac1007 (commit) via ddf65262562052ae132b2a4c9cf89b69ed9f1d5f (commit) via c4fbd43adedd0dcb3d7252efd340391948196d54 (commit) via 2ecc51f28f42644c655d2d86790b90f7a5ba81c7 (commit) via c2f1ab1cbcc07af13935c037534148b132aec46b (commit) via 0943d6ee9da6d2691493600e82c6f4d938ddb3b2 (commit) via 9bba3866ffc0d382d511d298d2460c618bfa6c0d (commit) via 68ef8797118b6015ac47130c789cd93e73b03597 (commit) via 1e0dcf8dafafd2261c863471e191c65c768e02ea (commit) via 337f49243faeab6796c12e434928823606dda195 (commit) via 32d31e55ae7ed3b2b3e184e64fa82f1cda5604c4 (commit) via f3ba040479f35e8b6f630553159b1b799fbae665 (commit) via 99fd0cfb05a465d7846f1d1b65086fa5f35fa297 (commit) via 5ad0579bebcccfa3fce6549b1b7f986681e2bea2 (commit) via 2a8ab239bdcec408971b48b3c6ee08c68c8798e2 (commit) via da8dbd247157caea874320be6e182beb584e57bf (commit) via b363e46ad48a8a2b340dd6792fdce1800a8cee44 (commit) via 9551aca9a685e97a03d58eb63e4b791416ba4c63 (commit) via b2467fddb1d83a0667970968493a9dad1dfb0be1 (commit) via 95c50e3dd766e919953def30f65ba5496226a660 (commit) via 6ef693dec1fd189d0995d8ad6a06c29c05823ce8 (commit) via 8fbad3dd56b45874463f9d811b80006314413c0e (commit) via 3444d41fd0d425aca79c9eeaadff1a7f647e7b13 (commit) via 698aa24165d0a51b06117d6d9133c04839fbe40e (commit) via 6b466a9e4fccae694c2ae6607ad5c5b28dfff303 (commit) via d72a18faad55d6f47af47acfb9d9270015bad2e2 (commit) via 95ce7daf65beb1864cbcb7bd984952eabb0308da (commit) via e8dbf386d8a830d822ff5f2857c63338a7998abb (commit) via 3bfb9aabe0e525ad76251190289c1ea3417fb1aa (commit) via d8d60b4980882e37b73df3bfead8c2b09daba091 (commit) via c6a0e2a7916a689dfb642b004d07f6fc76fd04f3 (commit) via 1df866d99e99346bf61d0f7c49600000048fa393 (commit) via 14107eec716f5f438273018ec0ddad9638934bf7 (commit) via 6628fdf54b635a216fdd83eb7d4f392512073787 (commit) via ddb754243e6ba3290ed098d15834a0b9d2d65d50 (commit) via eb5b2a211d5065af21e9949c81d8d9ce6920ba12 (commit) via 750eb3637e360b8a8e0ec7665d8165b2ed4baa5d (commit) via 53706c80d61003d05dc0116d4a171d554e04dbe4 (commit) via 471736ece003e80bb47e9a9b29099d7ab6200d04 (commit) via 6172627534168bb31415fa31a7cecdb15bcca4ab (commit) via ae794fc5f24e893b20f4161ac3cfb20e018e9b96 (commit) via fa8fd247cf7e038ee3cfcac6ce13c97542bf3abc (commit) via 0a4c646cbc9df5d16a5041b7b4d94a98955e6fff (commit) via 155f8d5288b50badc560dc87a1010874cf84f57a (commit) via 82acd85bcca0a79cd04ddfab40eec1112e507486 (commit) via 561914bd20913407f6344e4081c2e483d3e53bc4 (commit) via 5a99830e211901e498e036b9adb00b0c33c7904d (commit) via 867e6f0e006ae633ab7928a20919e0011bc0c63f (commit) via 3c9f440ac60ba83f155a89a851f9a1d3cc947f8d (commit) via 7219f6467feb8ce767689aa456fe8ff2f711e22a (commit) via 8804ddbe2a35a9e8bc1340912e73479cb2f31390 (commit) via 1961297a55f0b7a2ff6acc1ab7909d50e4b80f70 (commit) via ea6e4b577f08f88e0d5cabb7cb38e17b236e513a (commit) via 70996dc669305da1c5f7a305d67b5976fde75073 (commit) via 0553cda6dab3f69ccd32adb6d60723e9baf56d4a (commit) via f61c381b5a019b3fc8756fd5c199894886eb2492 (commit) via 3cddb369d57e8ef7b310edea7ba5d7b2be19e777 (commit) via 064038bb1bf12d992e8083517f37ae2acfa782a8 (commit) via 5826a8532ed4e2a0387aa8a2857bca62b8d2371f (commit) via 2c89e6c448101de562844ac6ca0fa0890964321c (commit) via dcf7ca7abd57c231b02881a4a2b9cc223b8db99a (commit) via ec485f3f52f76814146b3f032b9b28549fe61c57 (commit) via 1d29691bb6e0290ae61df63004eb3389dfb3f637 (commit) via c09c6531ba7b434c4b0a7f1f9ee13ffc3ad4dc8d (commit) via 27c7aa38aa6d96aa9b3bfb889330cba107836c1f (commit) via 2777003e121a5d764b54c62590e7ceb46ae2c157 (commit) via d477ea35a946c2935974edb3fea45cf23513a03c (commit) via 5d672c469d2218a2f845e1eadccf2b581365a370 (commit) via e670f9c80be87e4b81f4cd4dafc3d3dd9ea183e9 (commit) via 83cb6ff625a403b6d505c3b2f0fc23cebbd479bd (commit) via 96c07c6471176082b8aff7ec6df650aebaaace0e (commit) via a6dec130a963753bd7431f71394b0f527147006d (commit) via ab01a1eab1c56e131171ece6624fec9797fb42d0 (commit) via 06548c905ee7346c4b00ded643e5bae2d849bdaa (commit) via 6a083c125631016302d8313488f9426710845f56 (commit) via e3ea990450aee7d9ef97fa8690773db196c0880b (commit) via 1f8e7c45e12b33619fb123aeee1bf9e238cf0304 (commit) via ed49b3dcfe51b8b18d8834f7fc8e0e8e3c49237f (commit) via f54d07b01977bacfde2a61d2fd5019b3a5a26537 (commit) via 4d563d8f107f388a61acde462f2ede72e6793a64 (commit) via 5c2a5dbdcdb21c259821a6aea70813813bb2cd21 (commit) via b7107bdf9d39fd267358e4d1c526112b8bc5b138 (commit) via 90d32f83139c7e9aa66a87c37726f317ac9fcbfd (commit) via 6e24d5f69059dd10fd7b5752a9050b79d936a1d4 (commit) via e155e9159988a96a85ad1f495a7ce24473e08456 (commit) via 9ab17810bcc334ca76e4b470f7302013dc0bd261 (commit) via d8903ce3975b57c3f4cbd24d58994a1db8c572c8 (commit) via be3b1291d4f3e1b2fbd6e075ffd42c60fbe4f739 (commit) via 797a9bf67dac1b35fa076a44ca81944875be6f1b (commit) via 23e2b1f948af100c93fb52e73be0a0602d7a0b4c (commit) via cf79a87705c3b22233b252705bb3570ce357bbd4 (commit) via bf580c066a52ce86226f40cfb32a48a819c160f8 (commit) via 73504255fb3a521fc207e960c9b34f23f898581e (commit) via 6106196232d9640b233ac4b6c6faf81d39e37e52 (commit) via 4ef7894862769bfea39ea74ec16d42a150bc2545 (commit) via d3e34586c5e75685f9792b9104363c684fc3e174 (commit) via fbcd64deb836e0ec21d3ca7671d6e6f8f37090eb (commit) via ec9e555456ef5217ace606bf31ded35d45bf55d3 (commit) via 0419deb63bdc8e5685f0bf4022ff4cf8f7acf1ff (commit) via 9cb1892f387a7cfdb8fd0aee64bbe7d6842fc40d (commit) via f0e12f0fd301476378719d8268f13d53b14aaf1b (commit) via 13184fbf3a1490e2ba7c27cf34e458a77bfcc337 (commit) via b30119471711b1aa47d2509a1bec73468990eb66 (commit) via cd90f732a1354f4615fa51c136255991f362b5bf (commit) via 3d661f2fe5851cb84fd6953774bb71ee5071c597 (commit) via 6ab87ad77d735b753c81f7ce4f82dd2de03474d8 (commit) via f83587549942332ed08b51f4e7d21e03ccdcf022 (commit) via dc527152a8d01eef5868c625d327f6291f3b09ad (commit) via 492da78a2c59a134597fc732109580f857d8d50d (commit) via c634f2b184f3160a879c72c79e1dd906d8ecc566 (commit) via 5ecfe0c565e106960c3a13a6e835bd09f0b3e244 (commit) via e8492934d6cf1f7d71b8d3cd10e5fd257f0d8fc0 (commit) via f48c2cb5d46884e13c472d75556793b185d9183a (commit) via 0e639797309c3bb62171d6c226c197e63b0cea59 (commit) via 9515fba1fa0d51a97abd02e0869f42bfc2201c2d (commit) via a1969dd6f608685e53c9e28992bc928f09a18849 (commit) via a269ae1b6a0a65d3e28a4c59487f7fd9b8a5685c (commit) via 221a2bcbd0bd9fc04eacbe223f9118cabecccac1 (commit) via cd6ca0da41ce2af151670486e724d47870705d44 (commit) via 85c0a7807333d379ca1e0d747b9a424daea2352e (commit) via a0eb34232f909207282396ce9612078627ed358b (commit) via e60319e54bcc487f9d5baded335f516cd77fa931 (commit) via f2404376f807712d55e339a075d02d6f9a454a0a (commit) via c5c05911c62f0524c3b88086cf20dedb3d6ef769 (commit) via b89726db6d0bbadd607e8d43c0528d3e6e053531 (commit) via 0b76a4957de610fc065c4956094ba068c27b2ef1 (commit) via f022a629f1a028c368758430a07091ff02a06342 (commit) via b45a7ba7df9d2583baba37cf941cab0f66885c8a (commit) via 5e2c08c5d0a1c49a9f03dd3e15085433e62d24a5 (commit) via 799f4f0e142675fab45fe1d00e5d0eba3c3ff8cd (commit) via a8a3903e55af23bdce550a95ffe14a398fd1204c (commit) via e2d43e7d4b352206bac6bdd42f2c8f04d1e126b2 (commit) via f3d9766cbc83316544aae7fdd0f0f854160eafa3 (commit) via a9b4f31d4a76cd3c3ffeb78581d0f5cf24b78e3b (commit) via 4efa11528ee924dbd910c20f001eb07c52ffec6d (commit) via 8615081a0910797a8dfab5ea60583f8f5da8d020 (commit) via 8b5b843fcbc3e03e0fc45f3caf8cf5fc477e8613 (commit) via 94af9724d140fd132896b650d10c4d060788e4f0 (commit) via 33c00a6741b7cd31e28b7034bf25fc2f4b2ad767 (commit) via f64906413067f59b7bce5d149fd86b22ec392952 (commit) via 625bab309d9dd21db2d8ae2aa3511810d32842a8 (commit) via 194d30badf547edd9f3f86f2de87322e13a0fa8a (commit) via dc011cc53ebb424ed4fd1383282d929f8688e8e1 (commit) via c1a5531b71208c8270f7d969f4aebdfbfb5ad12e (commit) via a98d1089166cc90ebf7c82b938ae0add478b921d (commit) via 141637d327c6c7529b44e43e8530b6304b5a12ee (commit) via 5ea8c70c05240009e2fe1f3f71636fddc0feb7eb (commit) via 097de92cfbb5dfa6baaee8c2122ca504ac09473b (commit) via 4861fbe121301a3e5b519f719f3447290001cb00 (commit) via 75f78cd49ad0ec63073764926407135732f677ce (commit) via 5bda9bd4cb07c8b754202ce5950f9917db293222 (commit) via fd81dea208b42a0aa174810e82f2d0fe24d0251e (commit) via 1dd1a13e9f2a6c3ebd51c883bac5a8c2e1eeb4d3 (commit) via 484d114b361162325405d5437be3fe6f1342932f (commit) via 0517a05b54b1ddbddca53291d873af39ff578d88 (commit) via 1373f619f9772d30d6aef104a0d7063f660195b1 (commit) via aff94cf8f52057b76ce57736e0f64d29e06ceecc (commit) via d7311431b2c0bc82f7fb4e5815379e482d3b7a48 (commit) via 1cbb04eaf15508df8b1aa5b38b5abb4613e827c1 (commit) via e3acb2e3ebfadddec77dd7c2cd72db83fe5de91c (commit) via 856ce750606cb85427d65e67905091998e4f5976 (commit) via da01add6622688a682cec5d89a99f58e90f8e5fc (commit) via 3183465351871c40176e361349fc634403e1fa06 (commit) via 07a21ba6f6957acf3aa2c9337367fac265f29934 (commit) via dc7a03486c888467502bdd2bd03ba4ae40348d8f (commit) via a19fdccf51383c6a34eaeba674cc961bd51f6794 (commit) via ad0417cb78f207b26fa6a2115e86be7a01656d73 (commit) via 7c56a5affbea32db0e2ee1ffd6b72acf462326de (commit) via 8fdcc9545630a4ea87313c078e99db12da2485c0 (commit) via 67522b613000dab600d4ceaca0edc172d5723a02 (commit) via d037bc66c11a6df6525287ce51e4e998a2478fbd (commit) via 7bb3df70b12efb697fdcec0eaabf879120db8dfa (commit) via 2558728ff9b22c42db7f82d4d8c82f3cec75aa64 (commit) via c73e940526f8d6724da236c51f84615bc55aeb3a (commit) via 18d258ac46d11d584901537ac1f5e9341eff379e (commit) via f6d956cf92366e47470b63d366eb03ae26aa034a (commit) via 9ab7b538f0ccd2b1cd35689cff4c280e18a97e7d (commit) via 181d9b1d26728a75a5e999571e7cec1e28ef1d34 (commit) via 1f3e36534175853a3c4849d60396bf67dd1f46ce (commit) via 15b67769922c32bddc66c90ca4480817e757b193 (commit) via 7517b73e74bd3a425406e08fa0ce667a655ee049 (commit) via a9963c45e79440094df221dfcb34b11ba94f0882 (commit) via bb9e8d109efb91c0af46f51846388d4487ca1690 (commit) via 21f6dca753c6e562eda6dae0dd754f7b96026383 (commit) via d7ec2cbc38dc12b27bae3d043ae93aafe94caf91 (commit) via 69bfcbc67ece916630d212a9cc094694182df4f6 (commit) via cf4abe137661c7bd6ac5d1fd194969f2debfcaac (commit) via dcf52a16954719906abcaf94d8a7391ba2cfeb43 (commit) via b44b7dee03a344822fbc38092b5e9dd6d84939bb (commit) via 26a8b576f41ea0e00834fc0f2281732f5817f388 (commit) via 12684c7e4eb78a0ed665e09c4a7f6d9c454a932d (commit) via e345d19b95adf0af37949c866636cd8381451095 (commit) via b13d5eac26db21d3b8682e861575bf5344740f99 (commit) via a065bb586e2334f5f1f1f4f0a247f309f7a04f46 (commit) via c0fc66c67095f10a4dd4a22f3c5aaadcb7b245c2 (commit) via c5403b6c1ec1c905ea0add21a25e617cd2e76a6e (commit) via fd4dc6f115868f18e787f4bffaf8f8c5ceccff82 (commit) via caa9b19107a097a64552e5fc071f4d7fd218b59e (commit) via e7cc0279ab9a11319de521dfdf25057d1ff7ab7f (commit) via 3c8750dfb3b9cef1af2e29159782b443dfcd32ff (commit) via ed967507848f09ea4320c3bde36cf9020731793d (commit) via b4fc86d2d5cd293c19b8c1e9db3d50e5fe0283ab (commit) via ed1ecfb39cf0f3344810fabb7a1b855d373aa0a8 (commit) via 5f667694d3bbd57f13c26d3588d5671dfd30d09a (commit) via 620d54b1e3a4fcad1994409013f6a5b2b76913b4 (commit) via bd28737d7f0e4cd30f68f16ee94dcc0dfcf33ea3 (commit) via 7ec31d06177d9c9c4356ad0403b04f4ea98db53f (commit) via 137a4456d9c7d4fba5b6aa99bf654232dbbb3d87 (commit) via ed158952210f79dab7365e325d3c180fea26631e (commit) via e2a2618d9bbad3be872b0f7b98647fc901bcf93d (commit) via a8a2a8776be41563b5c063a23e39d1e9aca052a0 (commit) via 6be572006e5618aae3c59cb1b9a56cdf6e1e49a1 (commit) via 25ba538bc50ff3a824185cca532f4e0feb4f8ec4 (commit) via f1501b82a7354de76a8d3833db2aa8fa8b9d62e0 (commit) via b1395ce1f70889b07075e6d6841fe3e91474084c (commit) via a5ed8266bf6c05544a1610923c3a857b3f12997e (commit) via fd0e0513f03514399bd4c3634778de9b3f8051ab (commit) via 1768cea96f233d36e3c5a2f539128f029139d872 (commit) via ee4c70b92cfa0b44eed3d0d07078f943ce34c56a (commit) via 72415b50661c639d0f1fb7e261241da73cd4867c (commit) via 6db17741e49b6b7d519f50449710658c54a58dbc (commit) via eefec698611d7a982ce55eb7343df5e8eb0343c9 (commit) via e27870eaa6efa1c2dac08aa41a67fe9f0839e6e0 (commit) via f9207b0f6c9d5aa5a1dfd7748365483795293a5d (commit) via ded1d1089adfa969f660d0ddbb94394b27fa4b0f (commit) via 4458d0b59f41382783820d90b99a5687ca0ccd33 (commit) via a17bbc184170cf2faf4752f63f4dce0bba9e0dd5 (commit) via 3ce30eb1fd395251696c4cbf42b52cfd5b150404 (commit) via 8f4692f6f94d06d3fa3926333d3ffd3354066f96 (commit) via b5759cafae8f1cf852f39fe68accd126d40955cb (commit) via 8db4ddd40c6858109369156f6ae7b14c40c3b8df (commit) via bbbec5552d44fde57e57f52946059182482ab987 (commit) via 70263eade4cadd157f0322d6df3dd79bfec26242 (commit) via 253fcfa22182e123d4adfb54c2610e579f54a6db (commit) via 0d869dae1e17804b79142565e1c938339446b81e (commit) via 4930772178a779d57d694b71b5786ff4ca792c3c (commit) via 941fac1be27fa81737446bed9de0dfba526752ac (commit) via dae91bcb9048711d788affea3a5fee02f24df275 (commit) via 1783a3b7df3b5fae62b40617eda6db8368b1085f (commit) via 8615e78630e8deace183d150e2c1e5fc60d561ba (commit) via dd5875c487dea7e75b3653485d153c0dab909699 (commit) via 8a25ac7306b9eef5c7d75ee1c610eb2b0a8144fe (commit) via 16fc1903037dead72d5f6ff1457552d23b4a423f (commit) via 6bc4de9a2674f86e70bb5fdff48e861f3f5e48c5 (commit) via f68185573703ad5457dfd8198b779bb25b8e5023 (commit) via 59fce46d01582e0d2ffd3a606fdd8b50c713f6a1 (commit) via 939ea8c8ed2b96b2959a1c9869ac5fe6237808f9 (commit) via 3cb95b0521222766890fdd77d3f6294c98644321 (commit) via adf170c23d179dcec29c86c22151ed19684f6209 (commit) via e79320f2a02169569998447a59c54a9d0ef38fcb (commit) via 96100963afbfb4ae1f6584eb47d0e9f64eb3e432 (commit) via b365a3e19ab7449579898a8563468a0f0301320f (commit) via c41bab1f667cfe51b09b80869497a2db68abecce (commit) via a593fce94cb7fd0fa3f5eef7fae9c0128cb6f7e3 (commit) via e1933093187a9e48eb51a536110ff2b313617f70 (commit) via 88b88a0e809029c7f74f97c22ae9ee449bf4f749 (commit) via 0a5205b412b6b7d2a8062b3f31e10f883bd8d9aa (commit) via 8240518f91fb0215c6e031bd8761e72dd755da5f (commit) via aa2b59cf5e9cc4a60e839652124376e65818b885 (commit) via ecb6c88c073798635b55195c2e2dd7e9cff60b20 (commit) via 40f737dabea1a973fc969cc1d6950c1ad2ff1ec3 (commit) via b40ad7c2ffb3776c7002ce7b3c4aade42de319c7 (commit) via 8dbb21dfde14221dab09b6b9c7719b9067c1f06e (commit) via e77d4dffff3eb189cd9e1cbb7ee9c7561f439999 (commit) via 17651065a57f912ebb11d731d50a2245cbeda494 (commit) via 66d39cc60b59b4e8cedd8c46deb32a0ec2a35d98 (commit) via 0bfafb3e7a41876805922d87a52307305e2bc8d0 (commit) via 9260461f4fcc78ed7d4ac9936508dcd57ed40e6b (commit) via 978f6b4e1a94c831fa90421b6127e14f6ec9de17 (commit) via e8e8b0d0b46941f79535c020f5464c372d0138a7 (commit) via 21d2158a0bf39c08af6c5a24ef9895f819cd3af3 (commit) via 6c4b9360e59eb94e3219c6c1bf9a72a1c35a674d (commit) via 51aaffb5f680ebea44b31b911dd71694a40254fe (commit) via a5c79b8ec8ff147c94e17eeb131947a57f461ec7 (commit) via 4b8504f39a07e19f40b9df1548f8400ef6ae61a8 (commit) via b93ef37da21699336273e846651dd4e7c499f4dc (commit) via be995cc12075e3ecbc3aeb2356835df8c75a220b (commit) via 27b074a61580fbf0e53debf58d49f2728cffe735 (commit) via ec1a412cbd72570d0a7cd34fc68154d4368d2509 (commit) via 800c179dfa4a3576e48141f9324b7abd47ef6d61 (commit) via 69250aa51eac68015e520f5680970ded2db1ee14 (commit) via 7d65b573f2734017be416f31852c4ede42bd987b (commit) via d992e85fe8e9192cb730abf8796336d3b6d6fd50 (commit) via c98a7363dafdb1a261068a3e7312e66dcdf2c329 (commit) via 060eaaee51f4beb4605e96e5b22f8af1abe8b292 (commit) via 2a89dff8f6f7930db3b9efb5d10b103ae6fa4e66 (commit) via 7cc677e561b9e40e87f9fbeb64b443ce5f1b52e4 (commit) via de1798aefc5233c6980ef45ec1eb027e2541a135 (commit) via ccc5b44deaa312bf2963994d9ed25a98087c67ef (commit) via 875a46d1b54da3b2dcf0deb586de7745cabfa51f (commit) via e84c2e03e47cac0682ba03323ee0d7f6ff7d7b10 (commit) via 3f8384d7797cb07f220cad998620aa2b1ee11960 (commit) via 8b11e37f81d567921faacc5302f4b87268912484 (commit) via 619c89dbd721c39a1bff81a82d27269d93aa4145 (commit) via 98d5174e1a82723bee99774294ff00e40154ad5e (commit) via 72355a081795a0a5d4a984ba04633da30debe9d9 (commit) via b96b145f5846c0f8e34aa6f77ab0803f73bb27c2 (commit) via 7c23f56a4d08f33becca50df67c51d1d5b6793e2 (commit) via 577671a160285b0252cb4ac85b195e902f85253c (commit) via e7ef19efc0e928b50644b37772ccbf176e74f766 (commit) via c52a702ae81b1ae7311a8b58e625f86fb211e7c5 (commit) via afb9ff7982971aba6e42472de0db4c1bedfc641b (commit) via f63fc333625480d241a1265992ab34b389dd9ed6 (commit) via f3cf2ffd3af2b9d6315c19473bc1091bfe71b89c (commit) via 9e905abe54bdc5a9409cd4b6f340909ae1bb3b91 (commit) via 1e26510a6a795402f77ba5cb94f102fe6d0000bd (commit) via 4f34f4296c9335ddc9bb3cc8fec69b6bb1b5a079 (commit) via 2b0e08378f6d2633e27645f5695cdae528eb23b7 (commit) via df85480630a21d840427d564e40c91b878606ba3 (commit) via bdf10a239fcf873e1fff955f0fb6d8fd41aefcf3 (commit) via ba957234735b9a65ff831cf9a6b0ed1a230c19ea (commit) via 84272725b441d49ea26f5c96e6b8b37b2831b5ea (commit) via dafb529a389c8c60b3cbd04aba42c7b65803134e (commit) via 75853200c6f6b4b16d661c9e9bd64d76ccbeafcc (commit) via a7621ca4891819c59b30c5402d390a6d52ddcf97 (commit) via b4d8b68d7c9c0e3280a204dcfca9b57e66bffddd (commit) via c2057c08f8ecd29faead6a99217228da421de91b (commit) via d141bc13c3dd3cc3dd48ff603b9f44223397b41b (commit) via 2b8bd222b07428c1442b38779425aad44aeb5fbb (commit) via 1f759e3b63c3d8ab5127c474cfb5a4e5ca095fc2 (commit) via 293df7cccbc3092a1cebf8ad9b7ed289f1a7decb (commit) via 8c74580773e52b3de1b97c42cb425131f041b9cc (commit) via adf8236da7c7ee69c474a942d6bcc2292e045082 (commit) via f5b7fcee5b89382c9fa12d6545a249bc95da80d5 (commit) via d6dff9bc96c59be8ad81d1659c2da2f0e4d33c2d (commit) via 83aabe5500fda8fda8a5eb09982361f0df860e6f (commit) via c4528780732825267d2eebac4827625f39e33e5d (commit) via 7c258eedea0786e2dfccfc4002e3de599bf29413 (commit) via 69f0cb0cef3e8cc6b49073768f76ff1046ded8b5 (commit) via e7aa63746ba630d88032394f4869fca2c87853a8 (commit) via 766a3a0332c1d7eec08eadb8bbcc8911bdea6421 (commit) via 09b3af8f91324c7e3f86884c791acdcffc505cf9 (commit) via 36018de81a83bad289e202c7847ae2e89fcb0259 (commit) via 9bc8307867939078583818a2af2f0fe341e8820c (commit) via 4a56c6a728f1452891498402564662e0ef239176 (commit) via 3689dc1db36037436b1616715f9a3f888fc9a0f6 (commit) via 1d3ca5ad41fc3a725442439464f9ead944b21779 (commit) via 845835b8dba71bb248238dcb8ae18d59e4e543f0 (commit) via 18de993b7c29ad2d3840ff4b1b02f132c23c4777 (commit) via 02b20a5a699a557ab0696ebb024b6a3b1d39c41e (commit) via 06584b7a43101dca05f5a3040dbb26898a6c812f (commit) via 38b40acb2dc2567d3ddda35f4ed7d6523a9a9bd0 (commit) via 55dcb6455872a40c0f36a6bb198428baf1d31afe (commit) via 5f5a898541a541f5230831fcef46751e330fec1a (commit) via 27865070e0244a8f5c3fa46341d449d7078d0d4e (commit) via e7ec9c5538d34fb3a732bdc2adc2f2311589e165 (commit) via 53c9d25694c2859061e46f3df97d9f89c8cca5c9 (commit) via 74436b5ace977279b659dc2420305ea5a423e9ee (commit) via 6bcf405338d498c76005223190a591048922f18d (commit) via 1a89b51e413f164d4a25d44d8c61beea8498a09a (commit) via 350676f2723e1898e689d3026b62a8ea26409f4f (commit) via 124cf779f0c0d3a856a9c1793cb165eb56512705 (commit) via 85d742ef26970e35d16f16a9bea04a12ff618e17 (commit) via 4a2923d78b69e11e09c5cc3943f23cf40588dc37 (commit) via d4df5b8ee5337061a039cb8856439c89776f6a08 (commit) via 81b4957f5a5219f4fe40e598620d2579907e603b (commit) via 2154cb12a91464e78b359cb235a8f8b9c3181b58 (commit) via f662b1dac904f51aefdcba5fddb1a6c72ff03c4b (commit) via 80351694c168795e08259a8f63e143c50c5a7bd4 (commit) via c6e3fe5957f6df20d17db9dd95cb4bde80304086 (commit) via 371436cf4d96687fd5d69ef6c146cd859fc4f832 (commit) via 0414dae7ec5fefadb89fc03bd140b6c9f3d6dbb2 (commit) via f2f281e90e5a4b9f8f249ae89d6364bd7dc48785 (commit) via b9746b6833e0dc7d0a7f9afd1b3a5b80252d76b6 (commit) via 26a5cd2d7837a08f5d5c2f1b5abec34b4b22a596 (commit) via 84ee66b9bc97bfa294f11b4083f8f09b115c17e0 (commit) via a24f366ceb8eccf2e3a0501a394653c9eb6bed83 (commit) via 64f53c90b7b81e252eef8c08d0aa01c5ff9796ef (commit) via 1c6f6c691f52bc3c0a660e6f82453844135acb30 (commit) via 585297b189ba7f39db34f66f57d25429c8daf570 (commit) via df21aa90250c29d7466d55d9e0eda2cddd0dfbd8 (commit) via 935c055c18c8e33021c4062d22d4b87fe5577662 (commit) via 6a67ba5677b28d8ce4e8b775ee93573297784e0a (commit) via 1c777ec044473c644135c2a96576ac575e5a704c (commit) via 62c9a8a865779299d5e06cb929680e4bba92d4e7 (commit) via 8dedebbf30253add7886d508850af7e53d6ae3de (commit) via 765fc1d53374a0c9177bc634f5b928371fb98110 (commit) via b4cd63921c7134ab27da71369b50e26109d485cd (commit) via db63f75eab219c16c450d4fcd57bfeae1bcb8cb6 (commit) via d38197bb676d8937f5d9acd534200195b2e541bc (commit) via b57010039bbbf01f7fa16c1a3a78907558eb9f97 (commit) via f091ed83f7e051f0618391dc791687235c4a0abd (commit) via 09a9d2265595ca317136c85975da318ef29f84c6 (commit) via 6c87b5fdaa4ee746caf883382b3c74f3faf952b5 (commit) via da01b0b5dca05571d08ad71302aad66ac7ee3181 (commit) via c4901ca31f484c88a7947a6c2354ae194694599a (commit) via 8b9dc8c00c5d598aad0c8eb2b9623d533a001835 (commit) via e728e28f6eb4ffaa661a0c8356215eac64b9ebfb (commit) via d9477abd754d80eb95d1bf0886ef1bda0b7ac1df (commit) via 40481a1e393fdca7198031177e75b21e97e612ce (commit) via ecc3828be56ba77757e40effacb6e4fed6a85b98 (commit) via ee258b61a4eb51ec70afa4a3ae57bd30b1957150 (commit) via c1ef4693de99e56e182f7e8406f08a734e2e43b5 (commit) via c6f99aea466319d02006808f35069da7f87a5c1b (commit) via 7b6296ac5affa85687e6af8f5000cd3ed18b7cd4 (commit) via d022091acfd4c9513a4f13973d7cdc7d7785c09e (commit) via 40869e6e50a1157314e75aa5be2ba2fd887318d3 (commit) via d0a91b27f26762e9c998cc5e6fe71767de5d32c7 (commit) via 143bc04ca7c11b4f5a0feef4c01627c9aee6bcd4 (commit) via 5672ab00d2c10322b0cc7d94f2537b5083b8c376 (commit) via 494ede2aca686aaf69fb7ea7bc776dce48612868 (commit) via e4084f7bcdb7f05ae954d909c6dafa7a26ff631c (commit) via 299bd4628a9aa8e6ea2c8772576e171f100da001 (commit) via 0dee5c1911337e1cb8d8836eb6aec8b8abd72fa0 (commit) via 970ed78492db50e7229c29530ba8aa658a0ae72a (commit) via 5c4a96b58b2f29c2ff4588b86fc443b4b6b0f820 (commit) via a6ad0a0191cd98f4c3f7c2a7bc655049109f01e1 (commit) via 0fb62a5fd0b7c1282c7d64c61b9d806f94cf3f07 (commit) via 2698324d2852157e0b45e4ccd0736989b74fb6e5 (commit) via 4275f3de77be054c143076bf5b6e78e0f983a70f (commit) via 1cee1c95cc8b0ff30419b08d477c8f512615cd99 (commit) via d4efbc410165a3cad9e587b09e336ba1226fd3aa (commit) via 8faa84d38ba8f83acf68653ef9800738dfd8bfbc (commit) via f7ff38bc782340b1e2540f59c0138f7fa56bc5dd (commit) via 83f727d73dfda95623b9094cb817cf8564cbe54e (commit) via 8bd04c8be3304731dc319a35d1e6974193bcd3c1 (commit) via a2b084f6c507d96fe6f0776154537268d60e9428 (commit) via 9f1c73edac06821987760e03f103c49bb9588d1f (commit) via 0393c108bcd548fecc9ad6e0d7f97caf09997876 (commit) via 2a9cab649e90f85cc7b40440ad211438c8bb212f (commit) via ab39fac52ea7448fd03ffe6d7d98947393b224c5 (commit) via ed75d67394d0641a5b1141cf4e35e86824230e92 (commit) via 78a14e4c577af3ef0ceb49b53cb495692820cbed (commit) via 209a78ea822cce413ba5dfd31469ddd2ff6c9d65 (commit) via a338f87f33559bb9c915a97b614987736d07ff8f (commit) via 8390744957984e074b270edb4e996de274ce3a07 (commit) via 1d157ebeef0d5eb82e30ff7d7e64b797be86a3ef (commit) via 20d0a90115fb650c852a5ff1a6c3e7cf488ad673 (commit) via 3a68f85f910ce427ab540554b4fe7ff5fcac2257 (commit) via 08c3681e7eba6f32283f0d1548f53586ae9b9354 (commit) via 0f233e24d8da9cbc96b997a242b6a61a47de475a (commit) via b5a54c341612eff3ca455b6da8095f737d421e44 (commit) via be42b2bdeac66256c66cec8da5dab1204e0c0b8b (commit) via 501f30ce5fb3f105519aedd4ddb8693c119a63c3 (commit) via 692b1175e4d0493fcda0fbe8dd71ca33c2773a89 (commit) via 2330ba1b3d6e62272dbaf0d5b3b5e8481040a45f (commit) via 6fb8aa9a81ac7fcda4733d48555b09ca27dfacad (commit) via a66a216820f877881217485388b86c73722b351d (commit) via 1ef38667197289f585c7315beacb87179c21b1b6 (commit) via e1a591fc746b6d32b68a48b5d80846677ca0fffb (commit) via 8f555e43351517f1eb51f04a960936c9fef9a02a (commit) via 4b6a26d9521ef9eb63706be5ca144037d1d009f2 (commit) via ed254720fe2dcc612b49a2ef25db2061f8cb85ff (commit) via 2d93c4c06fabf8b8e6c8a4c85c4cf818dfd4a5d2 (commit) via 6821e0ea6f2e069ef75be58dc8f7bff50c961a7a (commit) via f16f6a3ef28754408548ff4ae1669856aec172b4 (commit) via 5870352d8f388347750d8445a80be92e0fab6504 (commit) via b7a9c02a50cc6fe5562204d09cb66e556d2f6ce9 (commit) via b974952b4cdb954e9b7fe4dda56d8ffec584f323 (commit) via 05ad9c79b80e5ae39ff63efc9b782eb0b34b3edf (commit) via 74deaf895aa52ecd94ce1953bdde525fda09fdf7 (commit) via 45823736e8a8c050a9cbcd299fc512be940ed19c (commit) via f89cedcd434daab36fbc96db22a0963e313b7ec6 (commit) via e9b8a5839f026b4047895b8dc869e075da0bcf45 (commit) via 5f1f891e2a8cb6a5241854884fae2aa8d69f28e6 (commit) via 6f28f1a59e143fc94ea1bc4d46dc9818e0d16e14 (commit) via 588590c539b5660e71660645305cb639cb35dc92 (commit) via c199952f5c66c61d908c5052de9172fe11a3f260 (commit) via 51789050633fc4554413a6f79439c9162c1c8cfb (commit) via 63b66cc7c8a6ec4e28eabd0bea135a70ed707754 (commit) via 8d13f14f958b9ee00b59fd869bd1630f76e6fa65 (commit) via 541817f63ca3e57bc8b8302602c42d6b745d73ef (commit) via 63628636af9bf43291711d51e38dc6f5933291ef (commit) via 94ce35a9f9877d3e48db3d800f2493f9944e1b5e (commit) via 71697c5dab92e5be15180c6fb4420fd847e1e539 (commit) via 324658271690d7ce4482e039a205ddaca3e1d18c (commit) via 445c0bb74722d23cac9c61b3f01df6917e01a0be (commit) via b2a24177e94ba7302735db68cfc4aff50532a474 (commit) via 5830e890bc3612145fcc169fa28548848cea75e1 (commit) via f6b196546546a5c658fb2d8303147f6b7f77e9f6 (commit) via dc64d738005a42aba8d4ba21e9f95c154530de64 (commit) via b0f253e07c2a90e49166445d165432b4e4cfa17f (commit) via 52823805b29a44a83eacd0e5b415b11227ec313b (commit) via 32b27bf19d181e4b2b227d13450a9dee9582af2c (commit) via 1e0dc0637b33314c14897ea00e2eb32b146141ea (commit) via 8f3a3914fe3a01001fd1062ac693a5e41a466b59 (commit) via f05f4893fa57ceac0ecb6266b9e536266f93aa1b (commit) via ed6239d17ec995ab5eaa51319c1f13fac8ae3a06 (commit) via 37d06faed3bc3c4d8ff908993b5f9cfb91e3c1a4 (commit) via 64eea6bb03ec8b861c5e336815e5a6b8233aadcd (commit) via 91caa91adf42b21945345aee03b68c4e5d881a63 (commit) via 4402b67d7de47c52b0d54fcfc0a845609fecba17 (commit) via b9ec3e71f647422b0748c3417b511146ba5a688d (commit) via e608345e060d03d63491d40a8a4c3b2291ef0940 (commit) via 6d5fcb7378b89790ab2d3feac0a6579c59b97bef (commit) via fa8a6a3eee3a6ce938cec4c1d8cc0540b27c451a (commit) via 7a71ec887ce78a48933d02e55d3b6d2b3ac49cfb (commit) via c7290277311f5189e4341c7684e14118f9f21c8b (commit) via 1f9990b7657332daad0680107d5230e18437f1da (commit) via f8d0a7f003c2916f08092da01c737294f1944eb8 (commit) via a303bc1f2982e59885c9787d3f81e1ced4b5f342 (commit) via 6cd7d99cb98c17c593948753d2a3b2a65d4f6040 (commit) via b3f5700ed4f3d5913d94dd0920fbc9df57adb090 (commit) via c9d05548405c6cc5c58dbede2e531c46732e009a (commit) via 0f9935e9a145535a7bb996fbfd8b1d24c762210c (commit) via 26de091d1be961570fade436de18f8422b89358f (commit) via 464679f80f60173589b6f3476abc1e6177d1a43f (commit) via 287221e8d9591bf252392ec34959e24c49fcd275 (commit) via 879920a2ebaacf33e554ab47e340c34fe2e878d8 (commit) via 8646596829494dbe054a18958eac68682ba42721 (commit) via 752c48f8643935cd859a794e53e4a9f4fba73b03 (commit) via f763a7d15407d289ba8356ff7528a53c6f0ae6ce (commit) via 3b16cc8b219e087e6b8cc8898ed8e4d58263d326 (commit) via 81c48eacccbeb3466e607c0f708f38869da70491 (commit) via e26926432d163cd835b7f8f1ab51e084c04050b7 (commit) via 8873c7e494018637449a17a7f7ddaf88ad43f3c6 (commit) via 76c231bd683410bed4fa803bcbc91e613e201ab0 (commit) via 405a5335ef12e4f2e7b661e9a7b3d5b33ab99629 (commit) via 12c04e05294d86d7c036cb3e866ae62f50ac5ba9 (commit) via 74a79b28b0a8c43ff6e198fc1993a40032a3d907 (commit) via db04fef13fb57050f47994beaad3115dc174746e (commit) via 018f6bff18785a1c3971a1ccfe3b1b5243d4d154 (commit) via 7aeff4fb904e67ce8f81053f595b8a8b0340cb52 (commit) via 231f3ea77440714384b9b2b0291736e5334b7f0e (commit) via 1aaa904622245200c179d53d638bdf256cda71ab (commit) via d846a3e8b9908caa65d182b680efb82c56c8103f (commit) via ef3b7a3394d918a7abebbd410a3525fd3b212ba3 (commit) via 1dc62c573e0c0a90ce34b6cbf2735c929f970c31 (commit) via 837c42d264ace217d23ca3a67ad19bf819e0690b (commit) via 74d39b2aa6360f2a5313901c861b0faa098b4c48 (commit) via af66f17fb463ece6f7b5ef28bc99d98f413f12e7 (commit) via 8d42f0fd09ddd6039c6c9344157668cfd44c21cb (commit) via f3ba318e099f62aea51718b73e8e817482beab51 (commit) via 22252978a4ec46ce8a0186dc31761293932a8abc (commit) via 9bb96969bab1e3fcadd7ee74df69c5079bbe6235 (commit) via fb1acc778d6e71cbeb5f512a8f8fb179b4fdf46e (commit) via a08e998ca2e7a8229da7f8b292dad94734977f33 (commit) via 9cd114fbe5d622ef7345259d143b4e09f5c0e6eb (commit) via 50227b0f6efb9ef56ff8a7fa85a9d6011012a201 (commit) via 166d95e7cbe9b27b070ac03829f4d8add3a1945e (commit) via b1a041898333a8d38387dca4fa6d509881845072 (commit) via 9ae80aea082384605e647f55fbc4d2910811a929 (commit) via 659b95765cd0fd213ba301c2162ec525422f8ff3 (commit) via 29e92fef556c8abd2e94fc0cf552a651a4788163 (commit) via 1e2c0ed5ea08fa32b2f89ba34c9cf63fe07de281 (commit) via 4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3 (commit) via a101aa9d99849b2316c0f9a59ca265511a72185a (commit) via 2d1bb2b66195c9cae7599f2333755fd1bd0f9395 (commit) via cf6a3deae44c8ff8f5b6a21e590ab7956b24fd27 (commit) via b9307c1ac86019ae94e190f6b195b9f55129a4d8 (commit) via 155ffc993d61cc6cd9be09d07fc148dfff01c27c (commit) via 274bbd5fab970c5a2048f9d00bb4e441cd68d04a (commit) via e624445adff8aa10ca6663e653b13ecd5c7db8d2 (commit) via 9dbfa6a1ea5a12bbb899a2e1ada032e227289677 (commit) via af180cc7d050e821825f3f4a2e96607b67704a39 (commit) via f8ea11ff461c266e8f3746de12ba293932dcff0c (commit) via 41d94798a941f0df6ae1a647cee2671f4e03929d (commit) via dd83b24f222a2a935cad3b6a646fecaf6790afbd (commit) via 7e21263d0b86c221d27f17922f46322b08308268 (commit) via 45401950257ec58d01efefdbc53149739c7785e4 (commit) via 5574b78dae2f607d4ace66ab60d516d0c569357d (commit) via 5c27cb5f83cb2c89cf470a6203fe057d3fa7e322 (commit) via f61c45acf145d9d0782d3c1b2a729097983582aa (commit) via 257f738a0da4e03b97b7f58c9363d991c5537dab (commit) via b3f6e8cb78ed7c87cdb0e65a406f2d32f627a63c (commit) via 7b44ff084a49a09dcbe10872f4302f3a4232edc9 (commit) via be69761c78d0c285f88ea6b2da0399fcecf9d782 (commit) via a34445c1cf340a5e617464aec4042df447327de5 (commit) via aca55a29f7b982e7a0bd9911d1d176561c8d7a84 (commit) via 2845f6be8db0b1720e23db0877ec837f00967bdc (commit) via 9d27248cdfce6720639707170d59c5725033276d (commit) via c11ceb3a0da74711f8fd9fa6598d5d6fab5ff57b (commit) via a0b2a5989d80486916438a42364f50b46d1b0645 (commit) via fa390fa8f388efbc1859d22663e1694739ad77eb (commit) via 5939c7417d1f2e24b6e9b78160fe7588d634e7e1 (commit) via 4afbd656b48a6463736cc3aeb1056761b31e0fd9 (commit) via b66bdbd4268566f454d73fa92a46079c180d1e71 (commit) via 940903c6492b68d5d9aea247bfadb709ddaf20f5 (commit) via a26fb9072917d0c48a0dc9260018967eaf11c352 (commit) via a03e4ea191b0937fdfd5337cb9304392056723d0 (commit) via 61d45acfb580d9fe93ed1c6e66266cd0af485da7 (commit) via ad085e567e97a65ec8c4d402014374b3022e85f4 (commit) via edc63f5ef7d0655093bb01b0accb130fd4de8dd8 (commit) via 1a38472d047893bc91fb9fd82d1e641a7b1c03ad (commit) via 50510a670d1ba15973d6c895eccfc0754af2852d (commit) via 7a9b9fd136430287e583ed323c8c7f12292913ba (commit) via 0831becc1a650399b5cc417f65f5649a9cd76270 (commit) via 7981d4bf0edc69ceea28914ae78899b0ef3850be (commit) via 25631a44ac1524ad1dbed444a8fc44bdf08c1ea5 (commit) via 9e21f4b8ee27480cce4bc0e4dc3d0c5eefe24e1c (commit) via 4f76eb002d65d801d5c262f7b21594d1421de4fd (commit) via 96dd97f9ba37ae0e708d2917e78c1a61d385266b (commit) via 6020f0f93d4cce75b08d9a6ecb51de08975b197f (commit) via b8fb78c5ac719d9ec03cf1923d750d1a8b507aa9 (commit) via 581461bb3458c4c89ac8700bafb6669449f326ae (commit) via b1a6f11e4271265e4de9722c020158d2c075ff9d (commit) via b62eee0d7f150cdf840efff175888eacde993622 (commit) via e02ca799d966ed2054bbd78742fd0a61f8bd959e (commit) via b8c22283218b36853c70620037973ff271f0273a (commit) via 21672e51e43db1fbb39362346264815a5bba0f16 (commit) via f76e1c8c84eeaee504db9bb7510109247655e372 (commit) via 6726d9e0cd61634c6bae95857efb2e549ab8f7be (commit) via 5f52e655002de5fa4ff29d32869cfca2b7eda214 (commit) via e13a81c62a1312ab39f228c70a0c0479af8782ec (commit) via 6e6bcacb72db2db6baada7b00924c96ff05c5ca2 (commit) via 1e659474c93d48e07e3908814bd423c228d38f2f (commit) via f04cb33494a4b3009390cfc01e9a7247c8a132ae (commit) via 8625c1902d41735a34a3698f4cbbbac6cc21290a (commit) via d56de21d6a56b1897c420802294359b1678bc40a (commit) via fc6f7b9021abd604f0d8650881885a5443c2ecb2 (commit) via 4136bff2d0f2a805ea2b7f8b75f78ff48ec79da0 (commit) via 62d60108543bab32c4299e0aa90299975e435b64 (commit) via c4e957b9746407c07efbb937d21b7c31894d269e (commit) via 7df594c92efaa777598f23fe22e005c09103fd6f (commit) via e7284adcdfc5302c46587890c62a28eaac5aedd7 (commit) via 71dd3658b727489a75c068d7bc8170078c9582a6 (commit) via 4319b35e2bdf7aede32db3e81830b68ef37fa4b9 (commit) via 2f0bd7b1f1493c4805c172f2202598efc1f1c8c0 (commit) via ff5280906cd6de3cd86bd9c5c63fe2aaf372aa70 (commit) via 8c89de612feaf89e430798870cc0ff15b432ff74 (commit) via 88484ab05103cc51746c8c3d8d80f7304d5e5245 (commit) via f49ae745c1774213600bc054cb08d949286d9314 (commit) via 719adb4fdc61e5187efefdfeb25a41d60d40be7f (commit) via f4ca61220aa65e42d880c947ce9c01dfe5bc8d4b (commit) via bc9bf64f8dc7053ebe3ae75152472d7149e077ce (commit) via 35f9349396d4dfbcccdf977cf9d7f3096df5aa0e (commit) via 9f7f401f325d2e92016e99cc39992d9ee34f73bf (commit) via 01449b849e55e9cb599a9a9c5c3d0ef0db4181d3 (commit) via 7ff66471fa4a314021a6fbdb9f9f32989779fd93 (commit) via e347139d3fcac13ab84e8cc50242ad4b0d4a2f11 (commit) via 691bec3c09cb8c834dcec1f21aa700b5a342503d (commit) via 34d3ad990cdcebe9f1630e805e41b037bca3cb17 (commit) via 97e0eb3ec6f3ded3549a768897a86cd09cae3a2e (commit) via 2c58885e94c7052931bace093b680fba9cc19ddb (commit) via 3298a5294316c51d0a77e07dbfc187148a328485 (commit) via d6eda2a3a398b5747717b6dbc13337a6d5314416 (commit) via 3c0ff67a9ca7e9c71785fa9d97cc1c1c13908774 (commit) via 329cccfc7b3adabbcd961cc328609f23058e5a12 (commit) via 35a6a1396fa8b0a6fa094b39bccac7c1e81a7fd3 (commit) via f49cc4d95287859475d164890ab1e27847d57ccf (commit) via 292708ab32ec46279fefb045161606037ed89330 (commit) via 84b86bdfa2ef7186ede9c416a61d8682bf818bb7 (commit) via de3a563d6698de8e45708e9d056f948c8eab7c8c (commit) via f2a3a705e667b1c6858391a1139d08e41950e7d0 (commit) via e871a3ffb432095a92f11c11024b0e96e23b9f7c (commit) via aa2117a8f250b4b0ca08b133d847aa6768a3ce5a (commit) via 537b083e028c636b8f8afc4a847e186f4abca59f (commit) via dc2a2424b48086ac2f79abc322070a4498d01607 (commit) via 6bdd072803b4f9964416c89a36be66f8643fd4c7 (commit) via c09538e48c6fe241cec0af29294f4f7eaf4a3b83 (commit) via fd2777b13887a785bd2ce722b4795aab50752afa (commit) via 5a0aa773c1e5f1102c1a0124554794672eaca931 (commit) via ef24608db1e4b881667ca7a670a76842ae52853d (commit) via 108b9b869bfe7475be0218d5f9682818dd3f4e8b (commit) via 06ab7f5a4e0643c2baade6ed4c3babc2fd3e2ce0 (commit) via 55dd9b16d5c9f3641bcb236282fb06983df1a5dd (commit) via d619a4239e3d4bc5b1f7d4829aad87004db37c07 (commit) via 61eb3f0b7552b426951a99755bed5983593b6243 (commit) via 21cb715dbea71c7865107503fddf3ae24010fe85 (commit) via de2a738cbd4df919b8bdb3e6c824d55670869f36 (commit) via 8c72e01a318ae9946ea42211e16af5ce4772ffa9 (commit) via f4781f3655c083cc915cc626d2e397da64635d90 (commit) via b66b4a96e3a70264ca39775219cd7eb3e7f150e3 (commit) via 5580b3beb70ba51c5d4074e1bf691858ec09de0c (commit) via c6a23a4b72c57eb3e81b96563e6a8faa3a810aa5 (commit) via 4d798e62ec7740a45fa2b82ecdcb102ca02d154c (commit) via 591d7ec817162687bee8a278c066891d86448e31 (commit) via b6d080a04e3553caa08af276881863948472fc19 (commit) via b4320e6662be0594beab5d9ab075e9b42867b5c7 (commit) via 01f2e2b2012e09210104910646feee98128b458f (commit) via 3bcd0e142a3540ed8fa7a339728d0c10bacadcc8 (commit) via ae3fd56b20b1e1c0b2b9871827ed2f3529576717 (commit) via 6d8f3ddc7c0147f0a316b53ce3c5f852d5eb5921 (commit) via aae0f13b7e6223afe589e63e3fb77b8e95b00219 (commit) via a8b018b71cf2732254f4f2512f03719d2686f7b3 (commit) via 956ebf371940bd176ce31b8ce72445ad702a7ccf (commit) via 59e6c628931e041624607dfa67ae876376d23333 (commit) via 8d37cab5812780e7e4738e68ed7b8a5980a9e9b0 (commit) via 300be929de03281a31c0cf5e91302ad5baba1cd2 (commit) via 24f0e6fe8a1741d8d8267e8c47cc6dc79babecc7 (commit) via f5332121ef787684093ed46fd2e01c754c4ef946 (commit) via 1089bdb7d4911a5508f86a0eea59418b424b265c (commit) via e63db3ce0ec2e92d69b5e452f71f5c44cd205272 (commit) via c6963b1c2f87c5f7a9123aa9e8e843540c18ff41 (commit) via b44fb245f5cef586fae8a4d3d2492d50b0f90c93 (commit) via 44e117bf7340298584b449d0a313a2f7f388d1af (commit) via 2ca4c5d756b7f7f507b7949bc31682839cb3e2b8 (commit) via a0ee5d6e42a00d76ff8d98b8877867927896c165 (commit) via 5b3e3ee58748ac1fd9201d2d3facbed1b9b1e800 (commit) via f63b0241c9eeb1ef3dc1e915820c440119c30526 (commit) via 4053bde54b9c356bdee4f4e7548790ce5a06e9a5 (commit) via 82ef9377fe88c213c5e5a02279d2714f88add665 (commit) via 4855ae29508e8a659b3620fab93c4138fd7ed4f6 (commit) via 5d0cf59d06cbe62fc15c2256b7a86417fc0dff80 (commit) via d81f907aea269b12dc383911bfb469addfaffade (commit) via ff7a6305a7eaa3c3815e813acc78a1660ae82293 (commit) via 4dc835c9c6b7af68cd63ae9efa26ac23ee3d9365 (commit) via 98ff0410c83ae9868803bb81319a3476dfb2c8f1 (commit) via fde17d9ba0c2d12434b26f5f0cb158093acfbfcf (commit) via a511b7159123704c5c6e488b96c4ff3311498423 (commit) via 9c3899bbf45ec3bdbb78f5249a3f7ea05d793966 (commit) via cd7c47e6389d7641e65bef8215f2c101a9977465 (commit) via b0b874815d7c31057a13c062ea7e973e18bde9a7 (commit) via c09f3ed774a8a124eb1710cc332677627da04aff (commit) via 912542f7bec16dd3ca9aa47933b94a395b8f5868 (commit) via 839032dff87ae4ad5533fc275719f3ee72186cbc (commit) via f63b68f7078a482d31d6bc22569756c09a0a2202 (commit) via 1d457701c5d969f3912d763c3e912b913497b97c (commit) via 92adb99d00eca0ff23e9c791053d93d6310faa99 (commit) via c57da453bab14048f419eae6b9e9ff7a332a32f0 (commit) via 15c0c8db5e0aac50e44eb3e2cd6eb5c0b3585220 (commit) via 4b4ce9fb35a46447796252cbfd1af4ea6b889d55 (commit) via 7dbc022b373c26b48b2a68106fafa3dd25d9e7e3 (commit) via b9b7389e21010b19110c0591b6639d334d15f019 (commit) via cdeb6f122a80c8ae39418897346b20b2c26acc00 (commit) via 1cabeea9b8ab109c7a731c0f61c7b9788077ffea (commit) via a25d477fa7969f6311bc8df0ff4df8208e80fa6f (commit) via 8d09f2a3adc4ac3d394ca07e5a12607ed0368d60 (commit) via 97dcf87a868a51502e1ea6a90cd7a9ee3bbc59cf (commit) via dc69a8446ee47fd6d38d4fb4416db89ef5487696 (commit) via f155beb0946391ea633936647b4c68998ecf01bb (commit) via ce7b994383a8089e7c05b7c88132fe78de9a1be9 (commit) via 733c19a0720035c1aa19d79f765d72b085d58bdd (commit) via 936a8f1cf8c314993f7fca6f193764cb53652924 (commit) via e3d0bf0bb2aea5e6f18cce32ad0e75e14169c413 (commit) via f978465fb36cc8ea799ba5553f5c6722c7cf241a (commit) via 03f9bd4091ef42e7dc42ef8fb275bc26cd619d5a (commit) via e4a8c71da8f742e3b1cadf70069554cc0ef1f8c1 (commit) via f524eb4dc114cc297d68a42ed9ed57fcebcde4f0 (commit) via ddb373ecb0510a0e52c030fce4ff0485b1d0345b (commit) via 31dc0310e2303deb9eec4824632683313d0d8699 (commit) via 1da9d28edc9eae3414d4d04880add60a7e8e0c6d (commit) via 0147a74becb2020850d75a611c65294520bd6c64 (commit) via 2a17c33928eba4ee0e383ee838b5980748448730 (commit) via c5569cfa0b985b763608231fe4b2fc976422aa33 (commit) via 778117c502d9e702327f592784c8d7b94212302c (commit) via e23e28da225fc51493f1694f9f61bc23df1b9ad9 (commit) via 25b9d31526beb75fe8f96bd2db2a09affef17204 (commit) via 7c5ff646dc6328233da09d9fc9b68c25eec8a9ba (commit) via f24c1564bd9e71176bbff781e0e38cd0e29e9fa3 (commit) via fb052a637fe41ab87af98753593a8cd5a07735de (commit) via eeab5f48fe6da19f1519149a5ea57b1ab7466e0d (commit) via 81b8d014567c7957da86e820c2b61fe003aca3b3 (commit) via c79382e69b37b3ff854ab88999a3dc6df0baf8f5 (commit) via 6893f7a5c7d223e9e3ef9966ce9757588196c66a (commit) via 4e9085696b0a0354b4ece9aa32230952608b3fa4 (commit) via 6cff9c8da6a8190258f3b392312297ca2ac11e33 (commit) via 38b7660eeddbda98d406dd130f2a3bda08ca1977 (commit) via c9cb01adbb24c91b665c6c219573f8ee96e1986c (commit) via 4af5e1a5c3fef04bd6e8131cbfad6617238d5f91 (commit) via 4ad98cc3f53073d5d726619f6bb03e0679ff9bdc (commit) via fe29cb3bb0b291ef354996b2e32fa3bdb724b152 (commit) via c254f3a13bc21868dba0163584a89d31483ee647 (commit) via 990192872d30120e0e54cb6da7b150b7b883528b (commit) via 64b5a38bd9ac83bfc36062eb0c4f7f384930176c (commit) via 74210f07fd86b03bed5ca9db57ec46e63ac1185b (commit) via 7e03e6b4eae2cc5871dda97462d1d43ec4b975b5 (commit) via 33b95883aa4ef7391c05e563243992d35846a633 (commit) via 6f12bf215fb6cd86a0105c87c72076840ca7f5b6 (commit) via a1ce51dcb0b105765a0245a9c48d96ff1583b73e (commit) via 5d3d9656451ae86fd1a20b19a3ea21c0931d24c5 (commit) via 3e54cabf8193e6a8cd607b1671defb8b6800b53d (commit) via 32b446d5a8f146565b81324d1a18bcb053e07c5f (commit) via 28c874da179a520b1cb5113eb33e2e8b3cb8f48d (commit) via ff1bdfa0bcdb24326d0f12f41e256a57b2a03d36 (commit) via e3b46bc48a6808d52b492a43e96ded6eb31114c3 (commit) via c50945989daa47802e30851b543ab5c69005a343 (commit) via 76762d69b55065af69df075ca8bd3425b5b3ca84 (commit) via f461a3a743750421ec377357687f65c2c007a63a (commit) via 168065dad763121f9f9630cac9aed184098d53a4 (commit) via b16d487cbc70a441d26a1052b22d1bb0132b1cbc (commit) via 621ff8e6166f448d807ebabed582810adc42cd57 (commit) via 66fff5df49520ac6e43f24aba3308f1c3e0ad205 (commit) via 04748779e4d5c2aff7b59adba7034bc6cf56d254 (commit) via c348f19786fddc4464cef4b507cce18173ad8dbb (commit) via 5db3a263c3fe21ccea6af4d42b2a34d421ed76a7 (commit) via c23a42e6ae287e7c4e683cae245cebdd0fcf7e96 (commit) via ad0a3834a12aa038bcbf157304a84e6fd1f6f004 (commit) via 1c8ec368f03e78978cb13a6bbf6a413a264141cc (commit) via b8a33b25ac92d0ce0eb21d09dd3324f12eced7ef (commit) via 13bd996e8f41fefeb0dfe6a71083e44b8ab5eaaf (commit) via cf0870ad2102dd632a12f6093184f3faae9f6712 (commit) via a4788324cb8b8674062659310fe483543f5450e5 (commit) via 82e2ad37a05d4f6ec125ffadbd00295283b355a7 (commit) via 4aae9331bc735411fe931a49c6d7bdbcfa7a972f (commit) via 963707ab3c7ba57e52c28f0dd396d97b37446063 (commit) via f86f54eb9070effb6216861749523d3a32932d47 (commit) via ea233921b46b3eeda51865bb5306919b16202872 (commit) via 76a3a6797ceb93535a06ca4d17b3a454f5728cca (commit) via c3a91e51d06f4ad81969fcbde4bcacead321f357 (commit) via fbc4d83ae7b844aa0ea6ec60af4f0a238110858a (commit) via 02e80019f2dc8f01e51d8bdc62a1cabff69fd51e (commit) via ea998190cfe5a051224490172cfaedc69b777ff6 (commit) via ddfc1d37ccb5e2a6aeef5cce47479ddc36684f33 (commit) via 95930c2d1fa356d5301b7c5e53b20035876bb436 (commit) via 07d8fad852babaf9d1b02e7f13eb188f34ff58f5 (commit) via b376aa05eaa47bf679691a5031b00255712807f4 (commit) via f50d9fe1d6ebf7ac8ecf615e0e79476bc824f4c0 (commit) via efbefe2f4c46bf50c6df7e06a06476e3f91e1ba7 (commit) via 9c80c4d5a246b8f95dfbc28fbf14ca899531630f (commit) via a62c6d56b13390d216a8b6096a9c9e809b3c4e93 (commit) via 615685e852d7aa9b48b117b0335a337d542f847f (commit) via 7fadc161724cb5d3e1d3f8aa449c8078e5ffa9e1 (commit) via c6ed05ec73e1b1e22ea890fc95ec5e067726cbe8 (commit) via 17f72a0b2273e8c45296711d2454997e74e2734c (commit) via 1e584b8a13cd6514f2ec5d117d055f3270c944d5 (commit) via be502d221a416ad271e4d13231cd796f8da32ca4 (commit) via 690cb8ff65f3336cb8e72a55944f974d0fd40f05 (commit) via 7a4c9d267bd245f19796a5fea3b21b18ed57f870 (commit) via 877caf478bae1e7f64084a8f2a7d6fe61f63b5e9 (commit) via 8ee06279fff744a1d7f235df9b570e0c25a91b1f (commit) via f2ffcdf3aa5cf3b02d674411270df072f3a1eded (commit) via 68f295d6052d49200f9ad3e06909b1157e7a82be (commit) via 14d94e174a230e66d7d75c774435d77f3d8aa22e (commit) via 88fbc26175d8f32b01fac69828b7549a5ec53166 (commit) via daae7dbb1ff08b5f88953ddb77ef71454f3b1a3f (commit) via 40d158eee35c3d10858593587c6ddc999b9b9329 (commit) via 4107f6bca7b2bc58e6570501123f3d500ec3905b (commit) via 04ba4bc070466c302b994968d527da5dbe390287 (commit) via 6dfdb0160c0ad6b7b71edb3c5f41c1e8e5868667 (commit) via 921723d07585b41c96b295e30a74df43626224af (commit) via 8dd29939ef79acd5fdfdf90c08d53c83706a24d3 (commit) via 28dce11948523f80d6eb76ef6a1d95df78f9c870 (commit) via d22b54a00587d6a4a5227b93f0461ab4549ea94c (commit) via b8b9bbcbd3dc8e7bebd2f7c74996a80f7620d77e (commit) via 3e9b25623877afb9854b2f3cae84e47ffb52c9a8 (commit) via 9ea364c389fc92bcd8efc800c9b8e852958c169a (commit) via 725b7ef17598076911da9c68efbf8c0efd593191 (commit) via 7799b1ceabb9baf4c88f0013b9b2bcd3e60b1750 (commit) via d238160a22ed3e7c9d2235002e3051afe162e662 (commit) via 9e419f62bde6c86bc7dd35c71e0a29321f3cb3ea (commit) via ac0af07083727a958e468e6d6fca044c73de0a80 (commit) via 421085cc4c1834e6b27f3cb2432786aff657ab77 (commit) via fe8508b8b359689c927bb062ee37f79c52930b19 (commit) via 27c6b12626d6e7b8e4d7a11784c2c5e2bfb87fde (commit) via 420aab387f706610d17cb51b3574f03fd370719a (commit) via 55724db3db49e7ed5180305600733d6a9253c65d (commit) via 543c101d4b98c947b7bfc66cac6d49d177ed4fc0 (commit) via 3669a8cc8f64a1874a3d370abccfc6e815b46514 (commit) via ab0b3ecf867223d8aeeb9c405dfc7204114b0dbe (commit) via 9ab8133bf8959c80167f85ffb4c12c37f3b4c2ed (commit) via 558fe23226b69665dd66ee15bed2f7492653aa09 (commit) via 990ac64516223f1ffa9728b01b47d08b7954de2c (commit) via 3e37292c382d8f48554af5a0aa10e3ce2d16363f (commit) via f26778c9c6265fae59a35413d9a2d735190cff22 (commit) via 5473d2582cbc8943ead50550ef72936e0b99a945 (commit) via 79e801806aedbbb74f642fafd9f54c02e60677f5 (commit) via 07f27d8238021b6e485699369383a58f95984a4e (commit) via 3fa8776a68404d4bea8c2fa82957488c448b4e20 (commit) via 6fdf043e6ee8ce9766f0b41a1c65ef0996ce7db3 (commit) via ee7d2a6010a2c6745630a53e58a6e4601114b530 (commit) via 62d5476740a8afb90eb67177fd1aece74cd3f8ec (commit) via d0e8b26ee2695246a4e3baa37d4384e6c2e634d3 (commit) via abfa43aa270d92219f0784c725fe31cad1cdbc69 (commit) via da0ae7e19b0a3514756f6d0a762b480d744425ac (commit) via 0e0c9a1a7a3e4c9a6bb33d65dbc0918184b8fb30 (commit) via b92c8a2e56f0e4dba1627e86077e56c63457e85c (commit) via 279a2762dc9f11a68afa3cb84e6ccd9047ede1eb (commit) via e46bd2827f581f1c5b18c4e166c13741fa6a99a8 (commit) via aec147efa1f27518f6927ca5078e0547dd1a234d (commit) via 6d025eff1b41cb99a60b50c36de15803f6e8076f (commit) via 5fd255424fda27b1ca9ded48a83da31405ae1731 (commit) via e934fad6389da228ae33e5fb83c29807a315ee77 (commit) via 541b9a93871892b0ad1732406f59f2196ae76cf9 (commit) via 30f8ceebbad01f1040b492599d26e0f01e0824f1 (commit) via 74a2ae4abac3be78d140d9671fa79977de449ed1 (commit) via d35bb66516b25a4adf3f0471a1c6256680e4491a (commit) via 8dcb530de6372580fa08659f1b230a86ac53d553 (commit) via 47c9cf8925123bbfc68fd5819816016e488da165 (commit) via 2ca2cc16b1c4710726ba82908e735f5b27a95184 (commit) from dc9adf904b7e78af15edcd18b0ac00e93c093f9a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: .editorconfig | 2 +- .gitignore | 31 +- .gitlab-ci.yml | 125 +- .mailmap | 15 +- AUTHORS | 55 +- AUTHORS.src | 3 + CMakeLists.txt | 639 +- CMakeOptions.txt | 55 +- CPackConfig.txt | 129 - ConfigureChecks.cmake | 44 - INSTALL | 10 +- INSTALL.configure | 4 +- Makefile.am | 431 +- Makefile.am.inc | 10 - README | 236 - README.cmake | 217 - README.hpux | 51 +- README.linux | 14 +- README.macos | 96 +- README.md | 232 + README.vmware | 29 - acinclude.m4 | 300 +- capchild/CMakeLists.txt | 1 - capchild/Makefile.am | 9 +- capchild/capture_ifinfo.c | 37 +- capchild/capture_session.h | 6 +- capchild/capture_sync.c | 77 +- capinfos.c | 71 +- capture_info.c | 158 +- capture_info.h | 20 +- capture_opts.c | 373 +- capture_opts.h | 62 +- capture_stop_conditions.c | 15 +- capture_stop_conditions.h | 14 +- captype.c | 34 +- caputils/CMakeLists.txt | 1 - caputils/Makefile.am | 10 +- caputils/airpcap.h | 2 +- caputils/airpcap_loader.c | 20 +- caputils/capture-pcap-util-unix.c | 2 + caputils/capture-pcap-util.c | 73 +- caputils/capture_ifinfo.h | 9 + caputils/capture_wpcap_packet.c | 48 - caputils/iface_monitor.c | 1 + caputils/ws80211_utils.h | 2 + cfile.c | 60 +- cfile.h | 49 +- cmake/modules/CMakeInstallDirs.cmake | 93 - cmake/modules/FindASCIIDOC.cmake | 1 - cmake/modules/FindBCG729.cmake | 57 + cmake/modules/FindCARES.cmake | 12 +- cmake/modules/FindCygwin.cmake | 15 +- cmake/modules/FindGEOIP.cmake | 11 +- cmake/modules/FindGLIB2.cmake | 12 +- cmake/modules/FindGMODULE2.cmake | 22 +- cmake/modules/FindGNUTLS.cmake | 6 +- cmake/modules/FindGTHREAD2.cmake | 12 +- cmake/modules/FindGTK2.cmake | 6 +- cmake/modules/FindHTMLHelp.cmake | 7 + cmake/modules/FindKERBEROS.cmake | 6 +- cmake/modules/FindLUA.cmake | 10 +- cmake/modules/FindLZ4.cmake | 6 +- cmake/modules/FindNGHTTP2.cmake | 6 +- cmake/modules/FindPCAP.cmake | 22 +- cmake/modules/FindPOD.cmake | 5 +- cmake/modules/FindPORTAUDIO.cmake | 5 +- cmake/modules/FindPerl.cmake | 81 + cmake/modules/FindSNAPPY.cmake | 6 +- cmake/modules/FindSPANDSP.cmake | 6 +- cmake/modules/FindYAPP.cmake | 23 - cmake/modules/FindZLIB.cmake | 4 +- cmake/modules/UseMakeDissectorReg.cmake | 32 - cmake/modules/UseMakePluginReg.cmake | 18 + cmake/modules/UseMakeTapReg.cmake | 17 - cmake/modules/UseMakeTaps.cmake | 15 + cmake/modules/WiresharkPlugin.cmake | 57 +- cmakeconfig.h.in | 86 +- codecs/CMakeLists.txt | 26 +- codecs/G711a/G711adecode.c | 2 + codecs/G711u/G711udecode.c | 2 + codecs/G722/G722decode.c | 2 + codecs/G726/G726decode.c | 2 + codecs/G729/G729decode.c | 97 + codecs/G729/G729decode.h | 46 + codecs/Makefile.am | 21 +- codecs/codecs.c | 92 +- codecs/codecs.h | 16 +- codecs/speex/resample.c | 2 + conditions.c | 15 +- conditions.h | 14 +- configure.ac | 721 +- debian/control | 2 +- debian/copyright | 659 +- debian/libwireshark-dev.install | 2 +- debian/libwireshark0.install | 2 +- debian/libwireshark0.symbols | 78 +- debian/libwiretap0.symbols | 3 +- debian/libwscodecs0.symbols | 5 +- debian/libwsutil-dev.install | 4 +- debian/libwsutil0.symbols | 10 +- .../05_note-README-when-running-as-root.patch | 2 +- debian/patches/06_release-version.patch | 6 +- debian/patches/16_licence_about_location.patch | 4 +- debian/po/cs.po | 95 +- debian/po/da.po | 95 +- debian/po/de.po | 98 +- debian/po/es.po | 95 +- debian/po/eu.po | 95 +- debian/po/fi.po | 95 +- debian/po/fr.po | 95 +- debian/po/hu.po | 95 +- debian/po/id.po | 95 +- debian/po/it.po | 95 +- debian/po/ja.po | 93 +- debian/po/ko.po | 95 +- debian/po/nl.po | 95 +- debian/po/pt.po | 95 +- debian/po/pt_BR.po | 95 +- debian/po/ru.po | 98 +- debian/po/sk.po | 95 +- debian/po/sv.po | 96 +- debian/po/templates.pot | 94 +- debian/po/vi.po | 95 +- debian/rules | 4 +- debian/templates | 38 + debian/wireshark-common.postinst | 12 +- debian/wireshark-common.postrm | 8 +- debian/wireshark-dev.install | 2 +- dftest.c | 25 +- diameter/CiscoSystems.xml | 35 + diameter/Huawei.xml | 57 + diameter/TGPP.xml | 6 + diameter/dictionary.xml | 344 +- doc/CMakeLists.txt | 51 +- doc/Makefile.am | 51 +- doc/README.build-system | 21 + doc/README.developer | 21 +- doc/README.dissector | 58 +- doc/README.extcap | 2 +- doc/README.heuristic | 1 - doc/README.plugins | 98 +- doc/README.stats_tree | 20 +- doc/capinfos.pod | 3 +- doc/dfilter2pod.pl | 140 - doc/dumpcap.pod | 14 +- doc/extcap_example.py | 45 +- doc/make-authors-format.pl | 13 +- doc/make-authors-short.pl | 15 +- doc/packet-PROTOABBREV.c | 14 +- doc/perlnoutf.pl | 14 +- doc/plugins.example/Makefile.am | 34 + doc/plugins.example/README | 13 + doc/plugins.example/configure.ac | 38 + doc/plugins.example/hello.c | 62 + doc/tshark.pod | 57 +- doc/wireshark.pod.template | 11 + docbook/CMakeLists.txt | 122 +- docbook/Makefile.am | 45 +- docbook/README.txt | 29 +- docbook/asciidoc.conf | 2 +- docbook/asciidoctor-asciidoc.conf | 4 +- docbook/attributes.asciidoc | 1 + docbook/{ => common_src}/GPL_appendix.asciidoc | 0 .../common_src/typographic_conventions.asciidoc | 80 + docbook/developer-guide-docinfo.xml | 3 +- docbook/developer-guide.asciidoc | 6 +- docbook/dfilter2xml.pl | 181 - docbook/make-wsluarm.pl | 14 +- docbook/release-notes.asciidoc | 48 +- docbook/user-guide-docinfo.xml | 3 +- docbook/user-guide.asciidoc | 4 +- docbook/ws.css | 12 +- docbook/wsdg_src/WSDG_chapter_dissection.asciidoc | 4 +- docbook/wsdg_src/WSDG_chapter_quick_setup.asciidoc | 197 +- docbook/wsdg_src/WSDG_chapter_sources.asciidoc | 31 +- docbook/wsdg_src/WSDG_chapter_tools.asciidoc | 274 +- .../wsdg_src/WSDG_chapter_userinterface.asciidoc | 15 +- docbook/wsdg_src/WSDG_preface.asciidoc | 21 - docbook/wsug_src/WSUG_app_files.asciidoc | 441 +- docbook/wsug_src/WSUG_app_tools.asciidoc | 752 +- docbook/wsug_src/WSUG_chapter_advanced.asciidoc | 11 +- docbook/wsug_src/WSUG_chapter_capture.asciidoc | 34 +- docbook/wsug_src/WSUG_chapter_customize.asciidoc | 78 +- docbook/wsug_src/WSUG_chapter_io.asciidoc | 34 +- docbook/wsug_src/WSUG_chapter_statistics.asciidoc | 22 +- docbook/wsug_src/WSUG_chapter_use.asciidoc | 76 +- docbook/wsug_src/WSUG_chapter_work.asciidoc | 12 +- docbook/wsug_src/WSUG_preface.asciidoc | 20 - docbook/wsug_src/capinfos-h.txt | 61 + docbook/wsug_src/dumpcap-h.txt | 62 + docbook/wsug_src/editcap-F.txt | 38 + docbook/wsug_src/editcap-T.txt | 198 + docbook/wsug_src/editcap-h.txt | 91 + docbook/wsug_src/mergecap-h.txt | 19 + docbook/wsug_src/rawshark-h.txt | 31 + docbook/wsug_src/reordercap-h.txt | 9 + docbook/wsug_src/text2pcap-h.txt | 79 + docbook/wsug_src/tshark-h.txt | 119 + dumpcap.c | 1179 +- editcap.c | 72 +- enterprises.tsv | 942 +- epan/.editorconfig | 4 - epan/CMakeLists.txt | 191 +- epan/Makefile.am | 259 +- epan/addr_and_mask.c | 2 +- epan/addr_and_mask.h | 2 +- epan/addr_resolv.c | 507 +- epan/addr_resolv.h | 20 +- epan/address.h | 32 +- epan/address_types.c | 31 +- epan/asm_utils.c | 84 - epan/asm_utils.h | 36 - epan/asm_utils_win32_x86.asm | 184 - epan/circuit.c | 320 - epan/circuit.h | 114 - epan/color_filters.c | 15 +- epan/column.c | 37 +- epan/column.h | 4 + epan/compress/Makefile.am | 46 - epan/compress/lzxpress.c | 134 - epan/compress/lzxpress.h | 46 - epan/conversation.c | 348 +- epan/conversation.h | 97 +- epan/conversation_table.c | 44 +- epan/conversation_table.h | 31 +- epan/crypt/CMakeLists.txt | 1 - epan/crypt/Makefile.am | 10 - epan/crypt/airpdcap.c | 3 +- epan/crypt/airpdcap_ccmp.c | 3 +- epan/decode_as.c | 38 +- epan/decode_as.h | 11 +- epan/dfilter/CMakeLists.txt | 14 +- epan/dfilter/Makefile.am | 26 +- epan/dfilter/dfilter-macro.c | 4 +- epan/dfilter/drange.h | 1 + epan/dfilter/scanner.l | 4 + epan/dfilter/sttype-set.h | 2 + epan/diam_dict.l | 7 + epan/dissectors/.editorconfig | 8 + epan/dissectors/CMakeLists.txt | 3100 +- epan/dissectors/Makefile.am | 140 +- epan/dissectors/asn1/Makefile.am | 16 +- epan/dissectors/asn1/Makefile.inc | 3 - epan/dissectors/asn1/acse/acse.cnf | 6 +- epan/dissectors/asn1/acse/packet-acse-template.c | 15 +- .../asn1/ansi_map/packet-ansi_map-template.c | 12 +- .../asn1/ansi_tcap/packet-ansi_tcap-template.c | 11 +- epan/dissectors/asn1/camel/packet-camel-template.c | 8 +- epan/dissectors/asn1/cmp/packet-cmp-template.c | 25 +- epan/dissectors/asn1/gprscdr/gprscdr.cnf | 105 +- .../asn1/gprscdr/packet-gprscdr-template.c | 60 + epan/dissectors/asn1/gsm_map/gsm_map.cnf | 46 +- .../asn1/gsm_map/packet-gsm_map-template.c | 307 +- epan/dissectors/asn1/h225/h225.cnf | 4 +- epan/dissectors/asn1/h225/packet-h225-template.c | 8 +- epan/dissectors/asn1/h245/h245.cnf | 6 +- epan/dissectors/asn1/h245/packet-h245-template.h | 4 +- epan/dissectors/asn1/h248/packet-h248-template.c | 13 +- epan/dissectors/asn1/idmp/packet-idmp-template.c | 3 +- epan/dissectors/asn1/inap/packet-inap-template.c | 8 +- epan/dissectors/asn1/kerberos/CMakeLists.txt | 1 + epan/dissectors/asn1/kerberos/Makefile.am | 3 +- epan/dissectors/asn1/kerberos/RFC6113.asn | 124 + epan/dissectors/asn1/kerberos/k5.asn | 78 +- epan/dissectors/asn1/kerberos/kerberos.cnf | 56 +- .../asn1/kerberos/packet-kerberos-template.c | 37 +- epan/dissectors/asn1/lcsap/lcsap.cnf | 4 +- epan/dissectors/asn1/lcsap/packet-lcsap-template.c | 9 +- epan/dissectors/asn1/ldap/packet-ldap-template.c | 7 +- epan/dissectors/asn1/lpp/LPP.asn | 678 +- epan/dissectors/asn1/lpp/lpp.cnf | 187 +- epan/dissectors/asn1/lpp/packet-lpp-template.c | 90 +- epan/dissectors/asn1/lpp/packet-lpp-template.h | 4 +- epan/dissectors/asn1/lppa/packet-lppa-template.c | 8 +- .../asn1/lte-rrc/EUTRA-InterNodeDefinitions.asn | 28 +- .../asn1/lte-rrc/EUTRA-RRC-Definitions.asn | 2166 +- .../asn1/lte-rrc/EUTRA-Sidelink-Preconf.asn | 116 +- .../dissectors/asn1/lte-rrc/EUTRA-UE-Variables.asn | 16 +- .../asn1/lte-rrc/NBIOT-InterNodeDefinitions.asn | 2 +- .../asn1/lte-rrc/NBIOT-RRC-Definitions.asn | 509 +- .../dissectors/asn1/lte-rrc/NBIOT-UE-Variables.asn | 3 +- .../asn1/lte-rrc/PC5-RRC-Definitions.asn | 21 +- epan/dissectors/asn1/lte-rrc/lte-rrc.cnf | 133 +- .../asn1/lte-rrc/packet-lte-rrc-template.c | 196 +- epan/dissectors/asn1/m2ap/packet-m2ap-template.c | 10 +- epan/dissectors/asn1/m3ap/packet-m3ap-template.c | 10 +- epan/dissectors/asn1/nbap/nbap.cnf | 846 +- epan/dissectors/asn1/nbap/packet-nbap-template.c | 618 +- epan/dissectors/asn1/pres/packet-pres-template.c | 6 +- epan/dissectors/asn1/ranap/packet-ranap-template.c | 66 + epan/dissectors/asn1/ranap/ranap.cnf | 40 + epan/dissectors/asn1/rnsap/packet-rnsap-template.c | 2 + epan/dissectors/asn1/rnsap/rnsap.cnf | 12 + epan/dissectors/asn1/ros/packet-ros-template.c | 4 +- epan/dissectors/asn1/rrc/Class-definitions.asn | 2 +- epan/dissectors/asn1/rrc/Constant-definitions.asn | 2 +- epan/dissectors/asn1/rrc/InformationElements.asn | 1002 +- epan/dissectors/asn1/rrc/Internode-definitions.asn | 258 +- epan/dissectors/asn1/rrc/PDU-definitions.asn | 691 +- epan/dissectors/asn1/rrc/packet-rrc-template.c | 176 +- epan/dissectors/asn1/rrc/packet-rrc-template.h | 11 +- epan/dissectors/asn1/rrc/rrc.cnf | 317 +- epan/dissectors/asn1/rtse/packet-rtse-template.c | 4 +- epan/dissectors/asn1/s1ap/S1AP-CommonDataTypes.asn | 2 +- epan/dissectors/asn1/s1ap/S1AP-Constants.asn | 6 +- epan/dissectors/asn1/s1ap/S1AP-Containers.asn | 2 +- epan/dissectors/asn1/s1ap/S1AP-IEs.asn | 9 +- epan/dissectors/asn1/s1ap/S1AP-PDU-Contents.asn | 2 +- .../dissectors/asn1/s1ap/S1AP-PDU-Descriptions.asn | 2 +- epan/dissectors/asn1/s1ap/S1AP-SonTransfer-IEs.asn | 2 +- epan/dissectors/asn1/s1ap/packet-s1ap-template.c | 12 +- epan/dissectors/asn1/snmp/packet-snmp-template.c | 291 +- epan/dissectors/asn1/snmp/packet-snmp-template.h | 15 +- epan/dissectors/asn1/snmp/snmp.cnf | 6 +- .../asn1/spnego/packet-spnego-template.c | 4 +- epan/dissectors/asn1/t38/packet-t38-template.c | 10 +- epan/dissectors/asn1/tcap/packet-tcap-template.c | 41 +- epan/dissectors/asn1/tcap/packet-tcap-template.h | 3 +- epan/dissectors/asn1/tcap/tcap.cnf | 4 +- epan/dissectors/asn1/x2ap/X2AP-Constants.asn | 6 + epan/dissectors/asn1/x2ap/packet-x2ap-template.c | 12 +- epan/dissectors/asn1/x721/Makefile.am | 35 - epan/dissectors/dcerpc/CMakeLists.txt | 24 - epan/dissectors/dcerpc/Makefile.am | 3 - epan/dissectors/dissectors.h | 50 + epan/dissectors/file-elf.c | 46 +- epan/dissectors/file-pcapng.c | 21 +- epan/dissectors/make-dissectors.c | 212 + epan/dissectors/packet-6lowpan.c | 290 +- epan/dissectors/packet-6lowpan.h | 2 +- epan/dissectors/packet-acse.c | 27 +- epan/dissectors/packet-aeron.c | 21 +- epan/dissectors/packet-amqp.c | 121 +- epan/dissectors/packet-amr.c | 47 +- epan/dissectors/packet-ancp.c | 2 +- epan/dissectors/packet-ansi_a.c | 2 +- epan/dissectors/packet-ansi_map.c | 12 +- epan/dissectors/packet-ansi_tcap.c | 17 +- epan/dissectors/packet-artemis.c | 154 + epan/dissectors/packet-artnet.c | 8 +- epan/dissectors/packet-aruba-erm.c | 12 +- epan/dissectors/packet-asterix.c | 68 +- epan/dissectors/packet-atalk.c | 2 +- epan/dissectors/packet-bacapp.c | 6 - epan/dissectors/packet-ber.c | 9 +- epan/dissectors/packet-bgp.c | 129 +- epan/dissectors/packet-bluetooth.c | 262 +- epan/dissectors/packet-bootp.c | 29 +- epan/dissectors/packet-brcm-tag.c | 202 + epan/dissectors/packet-bssgp.c | 184 +- epan/dissectors/packet-btatt.c | 46 +- epan/dissectors/packet-btavrcp.c | 18 +- epan/dissectors/packet-bthci_acl.c | 1 + epan/dissectors/packet-bthci_acl.h | 1 + epan/dissectors/packet-bthci_cmd.c | 78 +- epan/dissectors/packet-bthci_evt.c | 22 +- epan/dissectors/packet-btl2cap.c | 11 +- epan/dissectors/packet-btle.c | 475 +- epan/dissectors/packet-btmesh.c | 1243 + epan/dissectors/packet-camel.c | 8 +- epan/dissectors/packet-cdp.c | 3 +- epan/dissectors/packet-ceph.c | 6 +- epan/dissectors/packet-cfm.c | 28 +- epan/dissectors/packet-cipsafety.c | 7 +- epan/dissectors/packet-cisco-marker.c | 3 +- epan/dissectors/packet-cmp.c | 31 +- epan/dissectors/packet-cms.c | 2 +- epan/dissectors/packet-coap.c | 6 +- epan/dissectors/packet-cops.c | 2 +- epan/dissectors/packet-corosync-totemnet.c | 5 +- epan/dissectors/packet-corosync-totemsrp.c | 8 +- epan/dissectors/packet-couchbase.c | 173 +- epan/dissectors/packet-cql.c | 7 +- epan/dissectors/packet-dccp.c | 2 +- epan/dissectors/packet-dcerpc.c | 26 +- epan/dissectors/packet-dcm.c | 137 +- epan/dissectors/packet-dcm.h | 38 - epan/dissectors/packet-dcom.c | 5 +- epan/dissectors/packet-devicenet.c | 2 +- epan/dissectors/packet-dhcpv6.c | 2 +- epan/dissectors/packet-diameter.c | 21 +- epan/dissectors/packet-diameter_3gpp.c | 608 +- epan/dissectors/packet-dis.c | 1009 +- epan/dissectors/packet-dmp.c | 26 +- epan/dissectors/packet-dns.c | 250 +- epan/dissectors/packet-dof.c | 114 +- epan/dissectors/packet-dpnet.c | 2 +- epan/dissectors/packet-dtls.c | 68 +- epan/dissectors/packet-dtn.c | 14 + epan/dissectors/packet-dtn.h | 1 + epan/dissectors/packet-dtpt.c | 10 +- epan/dissectors/packet-dvbci.c | 138 +- epan/dissectors/packet-e212.c | 53 +- epan/dissectors/packet-eap.c | 8 +- epan/dissectors/packet-ecp-oui.c | 14 +- epan/dissectors/packet-ecp.c | 4 +- epan/dissectors/packet-ehdlc.c | 13 +- epan/dissectors/packet-eigrp.c | 2 +- epan/dissectors/packet-enip.c | 164 +- epan/dissectors/packet-epl-profile-parser.c | 1 + epan/dissectors/packet-epl.c | 32 +- epan/dissectors/packet-epmd.c | 2 +- epan/dissectors/packet-ess.c | 2 +- epan/dissectors/packet-eth.c | 6 +- epan/dissectors/packet-ethertype.c | 2 + epan/dissectors/packet-exported_pdu.c | 87 +- epan/dissectors/packet-extreme.c | 2 +- epan/dissectors/packet-fc.c | 13 +- epan/dissectors/packet-fc00.c | 2 +- epan/dissectors/packet-fcdns.c | 6 +- epan/dissectors/packet-fcels.c | 10 +- epan/dissectors/packet-fcfcs.c | 6 +- epan/dissectors/packet-fcfzs.c | 6 +- epan/dissectors/packet-fcoib.c | 2 +- epan/dissectors/packet-fcp.c | 9 +- epan/dissectors/packet-fcsb3.c | 4 +- epan/dissectors/packet-fcswils.c | 6 +- epan/dissectors/packet-fddi.c | 6 +- epan/dissectors/packet-flexray.c | 8 +- epan/dissectors/packet-flip.c | 8 +- epan/dissectors/packet-fp_mux.c | 395 + epan/dissectors/packet-fr.c | 9 +- epan/dissectors/packet-frame.c | 56 +- epan/dissectors/packet-ftp.c | 616 +- epan/dissectors/packet-gadu-gadu.c | 2 +- epan/dissectors/packet-gmr1_rr.c | 1 - epan/dissectors/packet-gprs-llc.c | 13 + epan/dissectors/packet-gprscdr.c | 429 +- epan/dissectors/packet-grpc.c | 436 + epan/dissectors/packet-gsm_a_bssmap.c | 212 +- epan/dissectors/packet-gsm_a_common.c | 20 +- epan/dissectors/packet-gsm_a_common.h | 4 +- epan/dissectors/packet-gsm_a_dtap.c | 74 +- epan/dissectors/packet-gsm_a_gm.c | 120 +- epan/dissectors/packet-gsm_a_rr.c | 16 +- epan/dissectors/packet-gsm_bssmap_le.c | 118 +- epan/dissectors/packet-gsm_map.c | 406 +- epan/dissectors/packet-gsm_sim.c | 9 - epan/dissectors/packet-gsm_sms.c | 34 +- epan/dissectors/packet-gsmtap.c | 82 +- epan/dissectors/packet-gsmtap.h | 6 +- epan/dissectors/packet-gtp.c | 137 +- epan/dissectors/packet-gtp.h | 2 + epan/dissectors/packet-gtpv2.c | 358 +- epan/dissectors/packet-gtpv2.h | 1 + epan/dissectors/packet-gvcp.c | 311 +- epan/dissectors/packet-gvsp.c | 662 +- epan/dissectors/packet-h223.c | 144 +- epan/dissectors/packet-h225.c | 12 +- epan/dissectors/packet-h245.c | 14 +- epan/dissectors/packet-h245.h | 4 +- epan/dissectors/packet-h248.c | 19 +- epan/dissectors/packet-h264.c | 8 +- epan/dissectors/packet-hartip.c | 4 +- epan/dissectors/packet-http.c | 109 +- epan/dissectors/packet-http.h | 11 +- epan/dissectors/packet-http2.c | 263 +- epan/dissectors/packet-http2.h | 13 + epan/dissectors/packet-i2c.c | 8 +- epan/dissectors/packet-iapp.c | 3 +- epan/dissectors/packet-iax2.c | 42 +- epan/dissectors/packet-iax2.h | 3 +- epan/dissectors/packet-icmp.c | 88 +- epan/dissectors/packet-icmp.h | 2 - epan/dissectors/packet-icmpv6.c | 129 +- epan/dissectors/packet-idmp.c | 7 +- epan/dissectors/packet-ieee1905.c | 5700 ++ epan/dissectors/packet-ieee80211-radio.c | 51 +- epan/dissectors/packet-ieee80211-radiotap.c | 11 +- epan/dissectors/packet-ieee80211.c | 1249 +- epan/dissectors/packet-ieee80211.h | 31 +- epan/dissectors/packet-ieee802154.c | 1396 +- epan/dissectors/packet-ieee802154.h | 18 +- epan/dissectors/packet-ieee802a.c | 16 +- epan/dissectors/packet-imf.c | 12 + epan/dissectors/packet-imf.h | 9 - epan/dissectors/packet-inap.c | 10 +- epan/dissectors/packet-infiniband.c | 2062 +- epan/dissectors/packet-infiniband.h | 2 + epan/dissectors/packet-infiniband_sdp.c | 4 +- epan/dissectors/packet-ip.c | 146 +- epan/dissectors/packet-ip.h | 95 +- epan/dissectors/packet-ipdc.c | 2 +- epan/dissectors/packet-ipsec.c | 162 +- epan/dissectors/packet-ipv6.c | 539 +- epan/dissectors/packet-ipv6.h | 66 - epan/dissectors/packet-ipx.c | 95 +- epan/dissectors/packet-isakmp.c | 187 +- epan/dissectors/packet-iscsi.c | 2 +- epan/dissectors/packet-isdn.c | 26 +- epan/dissectors/packet-iser.c | 4 +- epan/dissectors/packet-isis-clv.c | 2 +- epan/dissectors/packet-isis-lsp.c | 2 +- epan/dissectors/packet-isns.c | 10 +- epan/dissectors/packet-iso14443.c | 178 +- epan/dissectors/packet-iso15765.c | 10 +- epan/dissectors/packet-isobus-vt.c | 3 + epan/dissectors/packet-isup.c | 25 +- epan/dissectors/packet-iuup.c | 9 +- epan/dissectors/packet-iwarp-mpa.c | 20 +- epan/dissectors/packet-json.c | 2 + epan/dissectors/packet-juniper.c | 115 +- epan/dissectors/packet-jxta.c | 532 +- epan/dissectors/packet-k12.c | 2 +- epan/dissectors/packet-kafka.c | 4 +- epan/dissectors/packet-kerberos.c | 530 +- epan/dissectors/packet-kerberos.h | 2 +- epan/dissectors/packet-kerberos4.c | 11 +- epan/dissectors/packet-knxnetip.c | 2 +- epan/dissectors/packet-l2tp.c | 22 +- epan/dissectors/packet-lapdm.c | 5 +- epan/dissectors/packet-lapsat.c | 3 +- epan/dissectors/packet-lbm.h | 39 +- epan/dissectors/packet-lbmc.c | 146 + epan/dissectors/packet-lbmpdmtcp.c | 4 +- epan/dissectors/packet-lbmr.c | 29 +- epan/dissectors/packet-lbtrm.c | 49 +- epan/dissectors/packet-lbtru.c | 12 +- epan/dissectors/packet-lbttcp.c | 18 +- epan/dissectors/packet-lcsap.c | 21 +- epan/dissectors/packet-ldap.c | 13 +- epan/dissectors/packet-ldp.c | 728 +- epan/dissectors/packet-ldss.c | 6 +- epan/dissectors/packet-llc.c | 14 +- epan/dissectors/packet-lldp.c | 174 +- epan/dissectors/packet-lorawan.c | 41 +- epan/dissectors/packet-lpp.c | 9150 ++- epan/dissectors/packet-lpp.h | 4 +- epan/dissectors/packet-lppa.c | 8 +- epan/dissectors/packet-lte-rrc.c | 63200 ++++++++++++------- epan/dissectors/packet-lwm.c | 11 + epan/dissectors/packet-m2ap.c | 10 +- epan/dissectors/packet-m3ap.c | 10 +- epan/dissectors/packet-mac-lte.c | 480 +- epan/dissectors/packet-mbim.c | 384 +- epan/dissectors/packet-mbtcp.c | 10 +- epan/dissectors/packet-megaco.c | 6 +- epan/dissectors/packet-messageanalyzer.c | 1767 + epan/dissectors/packet-metamako.c | 306 +- epan/dissectors/packet-mgcp.c | 16 +- epan/dissectors/packet-mip6.c | 21 +- epan/dissectors/packet-mka.c | 4 +- epan/dissectors/packet-moldudp.c | 6 +- epan/dissectors/packet-moldudp64.c | 9 +- epan/dissectors/packet-mongo.c | 401 +- epan/dissectors/packet-mpeg-descriptor.c | 14 + epan/dissectors/packet-mpls-mac.c | 259 + epan/dissectors/packet-mpls.c | 10 +- epan/dissectors/packet-mpls.h | 2 + epan/dissectors/packet-mq-base.c | 240 +- epan/dissectors/packet-mq.c | 24 +- epan/dissectors/packet-mq.h | 18 +- epan/dissectors/packet-mqtt.c | 1343 +- epan/dissectors/packet-mrcpv2.c | 6 +- epan/dissectors/packet-ms-mms.c | 18 +- epan/dissectors/packet-msdp.c | 276 +- epan/dissectors/packet-msproxy.c | 7 +- epan/dissectors/packet-msrp.c | 18 +- epan/dissectors/packet-mtp2.c | 2 +- epan/dissectors/packet-mysql.c | 12 +- epan/dissectors/packet-nas_eps.c | 42 +- epan/dissectors/packet-nbap.c | 1718 +- epan/dissectors/packet-nbd.c | 5 +- epan/dissectors/packet-ncp.c | 12 +- epan/dissectors/packet-ncp2222.inc | 24 +- epan/dissectors/packet-ndps.c | 10 +- epan/dissectors/packet-netbios.c | 3 +- epan/dissectors/packet-netflow.c | 77 +- epan/dissectors/packet-netlink-netfilter.c | 817 +- epan/dissectors/packet-netmon.c | 2927 + epan/dissectors/packet-netmon.h | 64 + epan/dissectors/packet-netsync.c | 38 +- epan/dissectors/packet-nfapi.c | 11733 ++++ epan/dissectors/packet-nfs.c | 621 +- epan/dissectors/packet-nfs.h | 21 +- epan/dissectors/packet-nhrp.c | 27 +- epan/dissectors/packet-nordic_ble.c | 139 +- epan/dissectors/packet-nsip.c | 2 +- epan/dissectors/packet-ntlmssp.c | 16 +- epan/dissectors/packet-ntp.c | 29 +- epan/dissectors/packet-null.c | 1 - epan/dissectors/packet-nvme-rdma.c | 10 +- epan/dissectors/packet-nvme.c | 2 +- epan/dissectors/packet-oampdu.c | 25 +- epan/dissectors/packet-obex.c | 4 +- epan/dissectors/packet-ocfs2.c | 2 +- epan/dissectors/packet-opa-fe.c | 8 +- epan/dissectors/packet-openflow_v1.c | 6 +- epan/dissectors/packet-opensafety.c | 135 +- epan/dissectors/packet-ositp.c | 4 +- epan/dissectors/packet-ospf.c | 1014 +- epan/dissectors/packet-ossp.c | 20 +- epan/dissectors/packet-p22.c | 10 +- epan/dissectors/packet-packetbb.c | 2 +- epan/dissectors/packet-packetlogger.c | 73 +- epan/dissectors/packet-parlay.c | 11 +- epan/dissectors/packet-pcli.c | 13 +- epan/dissectors/packet-pcp.c | 8 +- epan/dissectors/packet-pdcp-lte.c | 89 +- epan/dissectors/packet-peekremote.c | 46 +- epan/dissectors/packet-per.c | 2 +- epan/dissectors/packet-pfcp.c | 5230 ++ epan/dissectors/packet-pim.c | 2 +- epan/dissectors/packet-pkcs12.c | 4 +- epan/dissectors/packet-pkixac.c | 4 +- epan/dissectors/packet-pktap.c | 26 +- epan/dissectors/packet-portmap.c | 4 +- epan/dissectors/packet-ppi.c | 5 +- epan/dissectors/packet-ppp.c | 39 +- epan/dissectors/packet-pres.c | 12 +- epan/dissectors/packet-protobuf.c | 692 + epan/dissectors/packet-protobuf.h | 59 + epan/dissectors/packet-prp.c | 1 - epan/dissectors/packet-ptp.c | 2 +- epan/dissectors/packet-pw-common.c | 1 - epan/dissectors/packet-q2931.c | 2 +- epan/dissectors/packet-q931.c | 2 +- epan/dissectors/packet-quic.c | 1118 + epan/dissectors/packet-radius.c | 167 +- epan/dissectors/packet-ranap.c | 308 +- epan/dissectors/packet-rdm.c | 550 +- epan/dissectors/packet-rdt.c | 6 +- epan/dissectors/packet-reload-framing.c | 5 +- epan/dissectors/packet-reload.c | 9 +- epan/dissectors/packet-rfid-mifare.c | 1 - epan/dissectors/packet-rip.c | 6 +- epan/dissectors/packet-rlc-lte.c | 8 +- epan/dissectors/packet-rmt-fec.c | 1 - epan/dissectors/packet-rnsap.c | 30 +- epan/dissectors/packet-ros.c | 10 +- epan/dissectors/packet-rpc.c | 128 +- epan/dissectors/packet-rpcap.c | 6 +- epan/dissectors/packet-rpcrdma.c | 1 + epan/dissectors/packet-rpki-rtr.c | 2 +- epan/dissectors/packet-rrc.c | 19572 +++--- epan/dissectors/packet-rrc.h | 11 +- epan/dissectors/packet-rsl.c | 8 +- epan/dissectors/packet-rsvd.c | 1 - epan/dissectors/packet-rsvp.c | 1101 +- epan/dissectors/packet-rtacser.c | 10 +- epan/dissectors/packet-rtcp.c | 14 +- epan/dissectors/packet-rtls.c | 3 +- epan/dissectors/packet-rtmpt.c | 17 +- epan/dissectors/packet-rtp.c | 76 +- epan/dissectors/packet-rtpproxy.c | 11 +- epan/dissectors/packet-rtps.c | 735 +- epan/dissectors/packet-rtps.h | 56 +- epan/dissectors/packet-rtse.c | 8 +- epan/dissectors/packet-rtsp.c | 7 +- epan/dissectors/packet-rx.c | 5 +- epan/dissectors/packet-s1ap.c | 23 +- epan/dissectors/packet-s7comm.c | 722 +- epan/dissectors/packet-sap.c | 2 +- epan/dissectors/packet-sasp.c | 2 +- epan/dissectors/packet-scsi-ssc.c | 1 - epan/dissectors/packet-sctp.c | 22 +- epan/dissectors/packet-sdp.c | 2 +- epan/dissectors/packet-selfm.c | 2 +- epan/dissectors/packet-ses.c | 4 +- epan/dissectors/packet-shim6.c | 16 +- epan/dissectors/packet-sip.c | 104 +- epan/dissectors/packet-skinny.c | 546 +- epan/dissectors/packet-skinny.c.in | 10 +- epan/dissectors/packet-skinny.h | 4 +- epan/dissectors/packet-skinny.h.in | 4 +- epan/dissectors/packet-sll.c | 80 + epan/dissectors/packet-smb-browse.c | 1 - epan/dissectors/packet-smb.c | 3 +- epan/dissectors/packet-smb2.c | 72 +- epan/dissectors/packet-sml.c | 8 +- epan/dissectors/packet-smtp.c | 6 + epan/dissectors/packet-snmp.c | 309 +- epan/dissectors/packet-snmp.h | 15 +- epan/dissectors/packet-snort.c | 55 +- epan/dissectors/packet-socketcan.c | 13 +- epan/dissectors/packet-socks.c | 150 +- epan/dissectors/packet-solaredge.c | 1697 + epan/dissectors/packet-soupbintcp.c | 12 +- epan/dissectors/packet-spnego.c | 8 +- epan/dissectors/packet-sprt.c | 12 +- epan/dissectors/packet-ssl-utils.c | 652 +- epan/dissectors/packet-ssl-utils.h | 194 +- epan/dissectors/packet-ssl.c | 163 +- epan/dissectors/packet-stt.c | 6 +- epan/dissectors/packet-stun.c | 4 +- epan/dissectors/packet-synphasor.c | 6 +- epan/dissectors/packet-t124.c | 8 +- epan/dissectors/packet-t125.c | 20 +- epan/dissectors/packet-t30.c | 1 - epan/dissectors/packet-t38.c | 10 +- epan/dissectors/packet-tapa.c | 8 +- epan/dissectors/packet-tcap.c | 51 +- epan/dissectors/packet-tcap.h | 5 +- epan/dissectors/packet-tcp.c | 313 +- epan/dissectors/packet-tdmop.c | 19 +- epan/dissectors/packet-tds.c | 313 +- epan/dissectors/packet-tetra.c | 4 +- epan/dissectors/packet-tftp.c | 19 +- epan/dissectors/packet-tftp.h | 9 - epan/dissectors/packet-thread.c | 11 +- epan/dissectors/packet-tibia.c | 2764 + epan/dissectors/packet-tipc.c | 14 +- epan/dissectors/packet-tn3270.c | 8 +- epan/dissectors/packet-tn5250.c | 8 +- epan/dissectors/packet-tns.c | 31 +- epan/dissectors/packet-tr.c | 6 +- epan/dissectors/packet-twamp.c | 804 + epan/dissectors/packet-ua3g.c | 5 +- epan/dissectors/packet-udp-nm.c | 37 +- epan/dissectors/packet-udp.c | 25 +- epan/dissectors/packet-uds.c | 7 +- epan/dissectors/packet-udt.c | 163 +- epan/dissectors/packet-uftp4.c | 1 - epan/dissectors/packet-uma.c | 20 +- epan/dissectors/packet-umts_fp.c | 266 +- epan/dissectors/packet-umts_fp.h | 1 + epan/dissectors/packet-umts_mac.c | 41 +- epan/dissectors/packet-umts_rlc.c | 205 +- epan/dissectors/packet-umts_rlc.h | 3 - epan/dissectors/packet-usb-ccid.c | 9 +- epan/dissectors/packet-usb.c | 842 +- epan/dissectors/packet-vnc.c | 4 +- epan/dissectors/packet-vp8.c | 8 +- epan/dissectors/packet-vxi11.c | 35 +- epan/dissectors/packet-wccp.c | 157 +- epan/dissectors/packet-wcp.c | 34 +- epan/dissectors/packet-websocket.c | 294 +- epan/dissectors/packet-wifi-display.c | 21 +- epan/dissectors/packet-wifi-dpp.c | 466 + epan/dissectors/packet-wifi-p2p.c | 59 +- epan/dissectors/packet-windows-common.c | 44 +- epan/dissectors/packet-wisun.c | 1105 + epan/dissectors/packet-wps.c | 65 + epan/dissectors/packet-wsp.c | 14 +- epan/dissectors/packet-x25.c | 27 +- epan/dissectors/packet-x2ap.c | 18 +- epan/dissectors/packet-x509ce.c | 40 +- epan/dissectors/packet-x509if.c | 6 +- epan/dissectors/packet-xot.c | 2 +- epan/dissectors/packet-xyplex.c | 4 +- epan/dissectors/packet-zbee-aps.c | 28 +- epan/dissectors/packet-zbee-aps.h | 3 + epan/dissectors/packet-zbee-nwk-gp.c | 144 +- epan/dissectors/packet-zbee-nwk.c | 35 +- epan/dissectors/packet-zbee-nwk.h | 1 + epan/dissectors/packet-zbee-security.c | 55 +- epan/dissectors/packet-zbee-security.h | 3 + epan/dissectors/packet-zbee-zcl-general.c | 1044 +- epan/dissectors/packet-zbee-zcl-misc.c | 13 + epan/dissectors/packet-zbee-zcl-se.c | 11098 +++- epan/dissectors/packet-zbee-zcl.c | 95 +- epan/dissectors/packet-zbee-zcl.h | 3 + epan/dissectors/packet-zbee-zdp-binding.c | 242 +- epan/dissectors/packet-zbee-zdp-discovery.c | 419 +- epan/dissectors/packet-zbee-zdp-management.c | 186 +- epan/dissectors/packet-zbee-zdp.c | 115 +- epan/dissectors/packet-zbee-zdp.h | 3 +- epan/dissectors/packet-zbee.h | 47 +- epan/dissectors/packet-zebra.c | 2 +- epan/dissectors/packet-zep.c | 196 +- epan/dissectors/packet-zep.h | 49 - epan/dissectors/pidl/CMakeLists.txt | 12 +- epan/dissectors/snort-config.c | 19 +- epan/dissectors/snort-config.h | 10 + epan/dissectors/usb.c | 243 +- epan/dtd.h | 1 + epan/dtd_grammar.lemon | 7 +- epan/dtd_parse.l | 17 +- epan/dtd_preparse.l | 6 +- epan/dwarf.c | 83 - epan/dwarf.h | 44 - epan/epan-int.h | 37 - epan/epan.c | 148 +- epan/epan.h | 63 +- epan/etypes.h | 25 +- epan/except.h | 1 + epan/expert.c | 11 +- epan/expert.h | 2 +- epan/export_object.c | 35 +- epan/exported_pdu.c | 45 +- epan/exported_pdu.h | 29 +- epan/follow.h | 2 +- epan/frame_data.h | 3 +- epan/ftypes/CMakeLists.txt | 12 +- epan/ftypes/Makefile.am | 14 +- epan/ftypes/ftype-bytes.c | 16 +- epan/ftypes/ftype-integer.c | 17 +- epan/ftypes/ftype-ipv4.c | 85 +- epan/ftypes/ftype-ipv6.c | 2 +- epan/ftypes/ftypes.c | 16 +- epan/ftypes/ftypes.h | 34 +- epan/geoip_db.c | 16 +- epan/geoip_db.h | 2 +- epan/ipproto.c | 30 +- epan/ipproto.h | 1 - epan/ipv4.c | 167 - epan/ipv4.h | 42 +- epan/ipv6.h | 7 +- epan/oui.c | 105 - epan/oui.h | 11 +- epan/packet.c | 258 +- epan/packet.h | 28 +- epan/packet_info.h | 8 +- epan/plugin_if.c | 3 +- epan/plugin_if.h | 5 +- epan/prefs.c | 128 +- epan/prefs.h | 17 + epan/print.c | 540 +- epan/print.h | 1 + epan/proto.c | 1216 +- epan/proto.h | 60 +- epan/ptvcursor.h | 23 + epan/radius_dict.l | 7 +- epan/range.c | 4 +- epan/range.h | 6 +- epan/reassemble.c | 8 +- epan/register.c | 112 + epan/register.h | 85 + epan/sctpppids.h | 5 + epan/sequence_analysis.c | 621 + epan/sequence_analysis.h | 228 + epan/srt_table.c | 7 +- epan/stats_tree.c | 62 +- epan/stats_tree.h | 2 +- epan/tap.c | 76 +- epan/tap.h | 15 +- epan/tfs.c | 6 +- epan/tfs.h | 5 + epan/to_str.c | 41 +- epan/to_str.h | 9 +- epan/tpg.c | 69 - epan/tpg.h | 82 - epan/tvbparse.c | 2 +- epan/tvbuff.c | 22 +- epan/tvbuff.h | 16 +- epan/uat.c | 15 + epan/uat.h | 32 + epan/uat_load.l | 5 +- epan/unit_strings.c | 3 + epan/unit_strings.h | 3 + epan/wmem/CMakeLists.txt | 25 +- epan/wmem/Makefile.am | 42 +- epan/wmem/wmem_core.h | 1 + epan/wslua/CMakeLists.txt | 1 - epan/wslua/Makefile.am | 8 - epan/wslua/init_wslua.c | 82 +- epan/wslua/init_wslua.h | 2 +- epan/wslua/lrexlib_algo.h | 24 +- epan/wslua/lrexlib_glib.c | 9 +- epan/wslua/lua_bitop.c | 3 + epan/wslua/taps | 2 +- epan/wslua/wslua.h | 4 +- epan/wslua/wslua_address.c | 2 +- epan/wslua/wslua_capture_info.c | 8 +- epan/wslua/wslua_dir.c | 19 +- epan/wslua/wslua_dissector.c | 2 +- epan/wslua/wslua_dumper.c | 6 +- epan/wslua/wslua_field.c | 2 +- epan/wslua/wslua_file.c | 3 +- epan/wslua/wslua_file_common.c | 2 + epan/wslua/wslua_file_handler.c | 2 + epan/wslua/wslua_frame_info.c | 6 +- epan/wslua/wslua_gui.c | 2 + epan/wslua/wslua_internals.c | 6 +- epan/wslua/wslua_listener.c | 6 +- epan/wslua/wslua_pinfo.c | 5 - epan/wslua/wslua_proto.c | 3 - epan/wslua/wslua_proto_expert.c | 5 + epan/wslua/wslua_tree.c | 2 +- epan/wslua/wslua_util.c | 2 +- extcap.c | 264 +- extcap.h | 29 +- extcap/Makefile.am | 49 +- extcap/androiddump.c | 251 +- extcap/ciscodump.c | 26 +- extcap/extcap-base.c | 69 +- extcap/extcap-base.h | 24 +- extcap/randpktdump.c | 22 +- extcap/ssh-base.c | 18 +- extcap/ssh-base.h | 14 +- extcap/sshdump.c | 62 +- extcap/udpdump.c | 26 +- extcap_parser.c | 23 +- extcap_parser.h | 14 +- extcap_spawn.c | 147 +- extcap_spawn.h | 16 +- file.c | 421 +- file.h | 30 +- file_packet_provider.c | 90 + fileset.c | 28 +- fileset.h | 38 +- frame_tvbuff.c | 63 +- frame_tvbuff.h | 32 +- globals.h | 14 +- help/Makefile.am | 3 - image/README.image | 3 + image/arrow_down.png | Bin 0 -> 294 bytes image/arrow_down at 2x.png | Bin 0 -> 445 bytes image/arrow_up.png | Bin 0 -> 294 bytes image/arrow_up at 2x.png | Bin 0 -> 412 bytes image/delete_list.png | Bin 0 -> 378 bytes image/delete_list at 2x.png | Bin 0 -> 660 bytes image/file_dlg_win32.rc | 2 +- image/toolbar.qrc | 6 + image/wireshark.exe.manifest.in | 15 +- log.h | 14 +- m4/ax_compare_version.m4 | 177 + m4/libsmi.m4 | 125 - m4/ws_osx.m4 | 365 - macosx-setup.sh | 2917 - .../portaudio-pa_mac_core.c.patch | 11 - .../portaudio-pa_mac_core.h.patch | 11 - macosx-support-lib-patches/spandsp-configure-patch | 53 + make-version.pl | 29 +- manuf | 61954 +++++++++--------- manuf.tmpl | 1417 +- mergecap.c | 36 +- packaging/Makefile.am | 5 +- packaging/macosx/Makefile.am | 4 +- packaging/macosx/osx-app.sh | 637 - packaging/macosx/osx-app.sh.in | 534 + packaging/nsis/AdditionalTasksPage.ini | 2 +- packaging/nsis/CMakeLists.txt | 9 +- packaging/nsis/Makefile.am | 2 - packaging/nsis/common.nsh | 1 + packaging/nsis/config.nsh.in | 4 +- packaging/nsis/uninstall.nsi | 1 + packaging/nsis/wireshark.nsi | 50 +- packaging/portableapps/xcopy-deploy-exclude.txt | 2 + packaging/rpm/Makefile.am | 11 +- packaging/rpm/SPECS/Makefile.am | 2 - packaging/rpm/SPECS/wireshark.spec.in | 22 +- packaging/svr4/Makefile.am | 8 - packaging/svr4/checkinstall.in | 43 - packaging/svr4/mkpkg | 90 - packaging/svr4/pkginfo.in | 13 - packaging/wix/CMakeLists.txt | 14 +- packaging/wix/ComponentGroups.wxi | 52 +- packaging/wix/DirectoryStructure.wxi | 4 +- packaging/wix/Makefile.am | 2 - packaging/wix/Plugins.wxi | 38 +- packaging/wix/Prerequisites.wxi | 5 + packaging/wix/WiresharkOptionsDlg.wxs | 4 +- plugins/Custom.m4.example | 2 +- plugins/Custom.make.example | 3 - plugins/Makefile.am | 37 +- plugins/Makefile.am.inc | 32 +- plugins/docsis/CMakeLists.txt | 10 +- plugins/docsis/Makefile.am | 20 +- plugins/docsis/moduleinfo.h | 40 - plugins/docsis/packet-docsis.c | 14 + plugins/docsis/packet-macmgmt.c | 715 +- plugins/docsis/packet-tlv.c | 462 +- plugins/docsis/packet-tlv.h | 17 + plugins/docsis/packet-vendor.c | 619 +- plugins/docsis/plugin.rc.in | 34 - plugins/easy_codec/Makefile.am | 48 - plugins/easy_codec/ReadMe.txt | 13 - plugins/easy_codec/codec-g722.c | 103 - plugins/easy_codec/codec-g722.h | 39 - plugins/easy_codec/codec-g7231.c | 108 - plugins/easy_codec/codec-g7231.h | 39 - plugins/easy_codec/codec-g729a.c | 94 - plugins/easy_codec/codec-g729a.h | 39 - plugins/easy_codec/easy_codec_plugin.c | 47 - plugins/easy_codec/plugin.rc.in | 34 - plugins/ethercat/CMakeLists.txt | 10 +- plugins/ethercat/COPYING | 696 - plugins/ethercat/Makefile.am | 20 +- plugins/ethercat/moduleinfo.h | 45 - plugins/ethercat/plugin.rc.in | 34 - plugins/gryphon/CMakeLists.txt | 10 +- plugins/gryphon/COPYING | 340 - plugins/gryphon/Makefile.am | 20 +- plugins/gryphon/NEWS | 34 - plugins/gryphon/moduleinfo.h | 40 - plugins/gryphon/plugin.rc.in | 34 - plugins/irda/CMakeLists.txt | 10 +- plugins/irda/Makefile.am | 18 +- plugins/irda/moduleinfo.h | 40 - plugins/irda/packet-ircomm.c | 10 +- plugins/irda/packet-irda.c | 12 +- plugins/irda/plugin.rc.in | 34 - plugins/m2m/AUTHORS | 6 - plugins/m2m/CMakeLists.txt | 90 - plugins/m2m/COPYING | 340 - plugins/m2m/ChangeLog | 3 - plugins/m2m/Makefile.am | 63 - plugins/m2m/moduleinfo.h | 50 - plugins/m2m/packet-m2m.c | 821 - plugins/m2m/plugin.rc.in | 34 - plugins/m2m/wimax_tlv.c | 195 - plugins/mate/CMakeLists.txt | 12 +- plugins/mate/COPYING | 340 - plugins/mate/Makefile.am | 24 +- plugins/mate/mate.h | 5 - plugins/mate/mate_grammar.lemon | 2 +- plugins/mate/mate_parser.l | 4 + plugins/mate/moduleinfo.h | 39 - plugins/mate/plugin.rc.in | 34 - plugins/opcua/CMakeLists.txt | 10 +- plugins/opcua/COPYING | 340 - plugins/opcua/Makefile.am | 20 +- plugins/opcua/moduleinfo.h | 40 - plugins/opcua/plugin.rc.in | 34 - plugins/plugin.rc.in | 34 + plugins/pluginifdemo/CMakeLists.txt | 10 +- plugins/pluginifdemo/COPYING | 340 - plugins/pluginifdemo/Makefile.am | 20 +- plugins/pluginifdemo/NEWS | 1 - plugins/pluginifdemo/moduleinfo.h | 39 - plugins/pluginifdemo/plugin.rc.in | 34 - plugins/pluginifdemo/ui/pluginifdemo_about.cpp | 2 +- plugins/profinet/CMakeLists.txt | 10 +- plugins/profinet/COPYING | 340 - plugins/profinet/Makefile.am | 20 +- plugins/profinet/moduleinfo.h | 40 - plugins/profinet/packet-dcerpc-pn-io.c | 314 +- plugins/profinet/packet-pn-dcp.c | 26 +- plugins/profinet/packet-pn-rt.c | 6 +- plugins/profinet/packet-pn-rtc-one.c | 6 +- plugins/profinet/plugin.rc.in | 34 - plugins/stats_tree/CMakeLists.txt | 8 +- plugins/stats_tree/Makefile.am | 12 +- plugins/stats_tree/pinfo_stats_tree.h | 2 - plugins/stats_tree/plugin.rc.in | 34 - plugins/stats_tree/stats_tree_plugin.c | 14 +- plugins/tpg/CMakeLists.txt | 92 - plugins/tpg/Makefile.am | 70 - plugins/tpg/http.tpg | 194 - plugins/tpg/packet-http.c | 154 - plugins/transum/CMakeLists.txt | 12 +- plugins/transum/COPYING | 340 - plugins/transum/Makefile.am | 20 +- plugins/transum/NEWS | 2 - plugins/transum/decoders.c | 37 +- plugins/transum/moduleinfo.h | 39 - plugins/transum/packet-transum.c | 704 +- plugins/transum/packet-transum.h | 22 +- plugins/transum/plugin.rc.in | 34 - plugins/transum/preferences.h | 1 + plugins/unistim/CMakeLists.txt | 10 +- plugins/unistim/COPYING | 340 - plugins/unistim/Makefile.am | 20 +- plugins/unistim/moduleinfo.h | 39 - plugins/unistim/packet-unistim.c | 2 +- plugins/unistim/plugin.rc.in | 34 - plugins/wimax/CMakeLists.txt | 13 +- plugins/wimax/COPYING | 340 - plugins/wimax/ChangeLog | 2 - plugins/wimax/Makefile.am | 26 +- plugins/wimax/README.wimax | 4 +- plugins/wimax/mac_hd_generic_decoder.c | 4 +- plugins/wimax/mac_hd_type1_decoder.c | 5 +- plugins/wimax/mac_hd_type2_decoder.c | 5 +- plugins/wimax/moduleinfo.h | 48 - plugins/wimax/packet-m2m.c | 821 + plugins/wimax/packet-wmx.c | 19 + plugins/wimax/plugin.rc.in | 34 - plugins/wimax/wimax-int.h | 39 + plugins/wimax/wimax_cdma_code_decoder.c | 5 +- plugins/wimax/wimax_compact_dlmap_ie_decoder.c | 5 +- plugins/wimax/wimax_compact_ulmap_ie_decoder.c | 5 +- plugins/wimax/wimax_fch_decoder.c | 5 +- plugins/wimax/wimax_ffb_decoder.c | 5 +- plugins/wimax/wimax_hack_decoder.c | 5 +- plugins/wimax/wimax_harq_map_decoder.c | 5 +- plugins/wimax/wimax_pdu_decoder.c | 4 +- plugins/wimax/wimax_phy_attributes_decoder.c | 5 +- plugins/wimax/wimax_tlv.c | 8 - plugins/wimax/wimax_utils.c | 5 +- plugins/wimaxasncp/CMakeLists.txt | 10 +- plugins/wimaxasncp/COPYING | 340 - plugins/wimaxasncp/Makefile.am | 24 +- plugins/wimaxasncp/moduleinfo.h | 41 - plugins/wimaxasncp/packet-wimaxasncp.c | 99 +- plugins/wimaxasncp/plugin.rc.in | 34 - plugins/wimaxasncp/wimaxasncp_dict.l | 22 +- plugins/wimaxmacphy/CMakeLists.txt | 10 +- plugins/wimaxmacphy/COPYING | 340 - plugins/wimaxmacphy/Makefile.am | 20 +- plugins/wimaxmacphy/moduleinfo.h | 41 - plugins/wimaxmacphy/plugin.rc.in | 34 - randpkt.c | 35 +- randpkt_core/CMakeLists.txt | 1 - randpkt_core/Makefile.am | 7 - randpkt_core/randpkt_core.c | 6 +- rawshark.c | 78 +- register.h | 73 - reordercap.c | 51 +- ringbuffer.c | 14 +- ringbuffer.h | 14 +- services | 17682 ++---- sharkd.c | 191 +- sharkd.h | 22 +- sharkd_daemon.c | 45 +- sharkd_session.c | 434 +- summary.c | 36 +- summary.h | 14 +- sync_pipe.h | 14 +- sync_pipe_write.c | 14 +- test/lua/pinfo.lua | 5 - text2pcap-scanner.l | 2 + text2pcap.c | 53 +- text2pcap.h | 19 +- tfshark.c | 165 +- tools/Makefile.am | 24 +- tools/SkinnyProtocolOptimized.xml | 277 +- tools/asn2wrs.py | 5 +- tools/checkAPIs.pl | 45 + tools/extract_asn1_from_spec.pl | 2 +- tools/fuzz-test.sh | 16 +- tools/gen-bugnote | 3 +- tools/git-export-release.sh | 28 +- tools/json2pcap/json2pcap.py | 276 +- tools/lemon/CMakeLists.txt | 8 +- tools/lemon/Makefile.am | 6 - tools/lemon/lemon.c | 9 +- tools/licensecheck.pl | 16 +- tools/macos-setup-brew.sh | 7 - tools/macos-setup.sh | 3143 + tools/make-dissector-reg.py | 351 - tools/make-manuf | 33 +- tools/make-plugin-reg.py | 165 + tools/make-services.pl | 128 - tools/make-services.py | 123 +- tools/make-sminmpec.pl | 3 + tools/make-tap-reg.py | 191 - tools/msvc2015AdminDeployment.xml | 86 + tools/oss-fuzzshark/StandaloneFuzzTargetMain.c | 142 + tools/oss-fuzzshark/fuzzshark.c | 86 +- tools/parse_xml2skinny_dissector.py | 2 +- tools/pidl/lib/Parse/Pidl/NDR.pm | 25 +- tools/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm | 8 +- tools/pidl/lib/Parse/Pidl/Samba4/COM/Proxy.pm | 6 +- tools/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm | 56 +- tools/pidl/lib/Parse/Pidl/Samba4/NDR/Server.pm | 49 +- tools/pidl/lib/Parse/Pidl/Samba4/Python.pm | 942 +- tools/pidl/tests/wireshark-ndr.pl | 2 +- tools/pre-commit-ignore.conf | 4 +- tools/release-update-debian-soversions.sh | 35 + tools/setuid-root.pl.in | 78 - tools/test-common.sh | 9 +- tools/tpg/Makefile.am | 47 - tools/tpg/V2P.pm | 104 - tools/tpg/tpg.pl | 594 - tools/tpg/tpg.yp | 319 - tools/update-tx | 18 +- tools/win-setup.ps1 | 20 +- trigcap.c | 15 +- tshark.c | 468 +- ui/.editorconfig | 29 - ui/CMakeLists.txt | 17 +- ui/Makefile.am | 42 +- ui/capture.c | 1211 +- ui/capture.h | 41 +- ui/capture_ui_utils.c | 901 +- ui/capture_ui_utils.h | 20 +- ui/cli/Makefile.am | 57 +- ui/cli/tap-camelsrt.c | 2 +- ui/cli/tap-comparestat.c | 10 +- ui/cli/tap-endpoints.c | 2 +- ui/cli/tap-flow.c | 157 + ui/cli/tap-follow.c | 16 +- ui/cli/tap-funnel.c | 2 + ui/cli/tap-hosts.c | 3 - ui/cli/tap-httpstat.c | 29 +- ui/cli/tap-icmpstat.c | 6 +- ui/cli/tap-icmpv6stat.c | 6 +- ui/cli/tap-iostat.c | 3 +- ui/cli/tap-iousers.c | 4 +- ui/cli/tap-protohierstat.c | 7 +- ui/cli/tap-rtspstat.c | 6 +- ui/cli/tap-sipstat.c | 6 +- ui/cli/tap-wspstat.c | 7 +- ui/commandline.c | 32 +- ui/commandline.h | 1 + ui/console.c | 5 +- ui/decode_as_utils.c | 67 +- ui/export_pdu_ui_utils.c | 2 +- ui/filter_files.c | 2 +- ui/firewall_rules.c | 4 +- ui/gtk/CMakeLists.txt | 56 +- ui/gtk/Makefile.am | 38 +- ui/gtk/about_dlg.c | 50 +- ui/gtk/addr_resolution_dlg.c | 4 +- ui/gtk/airpcap_gui_utils.c | 13 +- ui/gtk/bytes_view.c | 3 - ui/gtk/capture_dlg.c | 37 +- ui/gtk/capture_dlg.h | 1 + ui/gtk/capture_file_dlg.c | 8 +- ui/gtk/capture_file_dlg.h | 2 + ui/gtk/capture_if_dlg.c | 33 +- ui/gtk/color_edit_dlg.c | 4 +- ui/gtk/compare_stat.c | 4 +- ui/gtk/conversation_hastables_dlg.c | 78 +- ui/gtk/conversations_table.c | 17 +- ui/gtk/dcerpc_stat.c | 3 +- ui/gtk/decode_as_dlg.c | 12 +- ui/gtk/dissector_tables_dlg.c | 2 + ui/gtk/drag_and_drop.c | 31 +- ui/gtk/edit_packet_comment_dlg.c | 3 +- ui/gtk/expert_comp_dlg.c | 2 + ui/gtk/expert_comp_table.c | 2 + ui/gtk/export_object_dlg.c | 4 +- ui/gtk/export_pdu_dlg.c | 1 - ui/gtk/export_sslkeys.c | 3 +- ui/gtk/extcap_gtk.c | 6 +- ui/gtk/file_import_dlg.c | 2 +- ui/gtk/fileset_dlg.c | 18 +- ui/gtk/filter_expression_save_dlg.c | 1 + ui/gtk/filter_expression_save_dlg.h | 1 - ui/gtk/filter_utils.c | 2 + ui/gtk/firewall_dlg.c | 2 + ui/gtk/flow_graph.c | 114 +- ui/gtk/follow_stream.c | 4 +- ui/gtk/funnel_stat.c | 4 +- ui/gtk/graph_analysis.c | 12 +- ui/gtk/graph_analysis.h | 2 +- ui/gtk/gui_utils.c | 4 +- ui/gtk/gui_utils.h | 2 +- ui/gtk/help_dlg.h | 1 + ui/gtk/hostlist_table.c | 8 +- ui/gtk/iax2_analysis.c | 5 +- ui/gtk/io_stat.c | 4 +- ui/gtk/lbm_uimflow_dlg.c | 431 - ui/gtk/lbm_uimflow_dlg.h | 45 - ui/gtk/mac_lte_stat_dlg.c | 9 +- ui/gtk/main.c | 124 +- ui/gtk/main.h | 2 +- ui/gtk/main_80211_toolbar.c | 2 +- ui/gtk/main_filter_toolbar.c | 9 +- ui/gtk/main_menubar.c | 139 +- ui/gtk/main_statusbar.c | 2 + ui/gtk/main_titlebar.c | 2 +- ui/gtk/main_toolbar.c | 10 +- ui/gtk/main_welcome.c | 53 +- ui/gtk/manual_addr_resolv.c | 2 + ui/gtk/packet_history.c | 3 +- ui/gtk/packet_list.c | 16 +- ui/gtk/packet_list_store.c | 6 +- ui/gtk/packet_panes.c | 3 +- ui/gtk/packet_win.c | 797 +- ui/gtk/prefs_capture.c | 8 +- ui/gtk/prefs_dlg.c | 2 + ui/gtk/prefs_filter_expressions.c | 2 +- ui/gtk/prefs_gui.c | 23 +- ui/gtk/print_dlg.c | 2 + ui/gtk/profile_dlg.c | 2 + ui/gtk/proto_dlg.c | 6 +- ui/gtk/response_time_delay_table.c | 2 + ui/gtk/rlc_lte_stat_dlg.c | 9 +- ui/gtk/rpc_stat.c | 2 + ui/gtk/rtp_analysis.c | 7 +- ui/gtk/sctp_assoc_analyse.c | 6 +- ui/gtk/sctp_byte_graph_dlg.c | 2 + ui/gtk/sctp_chunk_stat.c | 3 +- ui/gtk/sctp_chunk_stat_dlg.c | 3 +- ui/gtk/sctp_error_dlg.c | 2 + ui/gtk/sctp_graph_dlg.c | 2 + ui/gtk/sctp_stat_dlg.c | 2 + ui/gtk/service_response_time_table.c | 2 + ui/gtk/simple_stattable.c | 2 + ui/gtk/stats_tree_stat.c | 2 + ui/gtk/summary_dlg.c | 12 +- ui/gtk/supported_protos_dlg.c | 5 +- ui/gtk/uat_gui.c | 4 + ui/gtk/wlan_stat_dlg.c | 2 + ui/iface_lists.c | 102 +- ui/language.c | 3 +- ui/make-taps.c | 154 + ui/packet_list_utils.c | 1 - ui/packet_range.c | 10 +- ui/packet_range.h | 1 + ui/preference_utils.c | 162 +- ui/preference_utils.h | 22 +- ui/profile.c | 23 +- ui/proto_hier_stats.c | 618 +- ui/proto_hier_stats.h | 50 +- ui/qt/.gitignore | 3 - ui/qt/CMakeLists.txt | 290 +- ui/qt/Makefile.am | 207 +- ui/qt/about_dialog.cpp | 587 +- ui/qt/about_dialog.h | 90 +- ui/qt/about_dialog.ui | 251 +- ui/qt/address_editor_frame.cpp | 36 +- ui/qt/address_editor_frame.h | 5 +- ui/qt/bluetooth_att_server_attributes_dialog.cpp | 2 +- ui/qt/bluetooth_device_dialog.cpp | 4 +- ui/qt/bluetooth_devices_dialog.cpp | 4 +- ui/qt/bluetooth_hci_summary_dialog.cpp | 4 +- ui/qt/byte_view_tab.cpp | 455 +- ui/qt/byte_view_tab.h | 60 +- ui/qt/byte_view_text.cpp | 644 - ui/qt/byte_view_text.h | 155 - ui/qt/cache_proxy_model.cpp | 112 - ui/qt/capture_file.cpp | 4 +- ui/qt/capture_file.h | 3 +- ui/qt/capture_file_dialog.cpp | 2 +- ui/qt/capture_file_dialog.h | 4 +- ui/qt/capture_file_properties_dialog.cpp | 8 +- ui/qt/capture_filter_syntax_worker.cpp | 18 +- ui/qt/capture_interfaces_dialog.cpp | 37 +- ui/qt/capture_interfaces_dialog.h | 2 +- ui/qt/capture_preferences_frame.cpp | 18 +- ui/qt/color_utils.cpp | 168 - ui/qt/color_utils.h | 87 - ui/qt/coloring_rules_dialog.cpp | 16 +- ui/qt/coloring_rules_dialog.h | 5 + ui/qt/coloring_rules_dialog.ui | 26 +- ui/qt/column_editor_frame.cpp | 60 +- ui/qt/column_editor_frame.h | 6 + ui/qt/column_editor_frame.ui | 7 +- ui/qt/column_preferences_frame.cpp | 2 +- ui/qt/compiled_filter_output.cpp | 14 +- ui/qt/compiled_filter_output.h | 2 + ui/qt/conversation_colorize_action.cpp | 2 +- ui/qt/conversation_dialog.cpp | 22 +- ui/qt/conversation_hash_tables_dialog.cpp | 14 +- ui/qt/decode_as_dialog.cpp | 618 +- ui/qt/decode_as_dialog.h | 37 +- ui/qt/decode_as_dialog.ui | 47 +- ui/qt/display_filter_expression_dialog.cpp | 5 +- ui/qt/dissector_tables_dialog.cpp | 2 +- ui/qt/enabled_protocols_dialog.cpp | 247 +- ui/qt/enabled_protocols_dialog.h | 18 +- ui/qt/enabled_protocols_dialog.ui | 23 +- ui/qt/endpoint_dialog.cpp | 7 +- ui/qt/expert_info_dialog.cpp | 551 +- ui/qt/expert_info_dialog.h | 54 +- ui/qt/expert_info_dialog.ui | 54 +- ui/qt/export_dissection_dialog.cpp | 2 +- ui/qt/export_object_action.cpp | 2 +- ui/qt/export_object_dialog.cpp | 6 +- ui/qt/export_pdu_dialog.cpp | 1 - ui/qt/extcap_argument.cpp | 6 +- ui/qt/extcap_argument_file.cpp | 2 +- ui/qt/extcap_argument_multiselect.cpp | 2 +- ui/qt/extcap_options_dialog.cpp | 40 +- ui/qt/file_set_dialog.cpp | 172 +- ui/qt/file_set_dialog.h | 26 +- ui/qt/file_set_dialog.ui | 26 +- ui/qt/filter_expression_frame.cpp | 29 +- ui/qt/filter_expression_frame.h | 2 + ui/qt/filter_expression_frame.ui | 41 +- ui/qt/follow_stream_dialog.cpp | 35 +- ui/qt/follow_stream_dialog.h | 2 + ui/qt/font_color_preferences_frame.cpp | 4 +- ui/qt/funnel_statistics.cpp | 6 +- ui/qt/funnel_string_dialog.cpp | 2 +- ui/qt/funnel_text_dialog.cpp | 2 +- ui/qt/geometry_state_dialog.cpp | 4 +- ui/qt/gsm_map_summary_dialog.cpp | 3 +- ui/qt/iax2_analysis_dialog.cpp | 13 +- ui/qt/iax2_analysis_dialog.ui | 2 +- ui/qt/import_text_dialog.cpp | 2 +- ui/qt/interface_frame.cpp | 6 +- ui/qt/interface_frame.h | 8 +- ui/qt/interface_sort_filter_model.cpp | 396 - ui/qt/interface_sort_filter_model.h | 106 - ui/qt/interface_toolbar.cpp | 113 +- ui/qt/interface_toolbar.h | 6 +- ui/qt/interface_toolbar_reader.cpp | 166 +- ui/qt/interface_toolbar_reader.h | 26 +- ui/qt/interface_tree_cache_model.cpp | 619 - ui/qt/interface_tree_cache_model.h | 93 - ui/qt/interface_tree_model.cpp | 558 - ui/qt/io_graph_dialog.cpp | 1059 +- ui/qt/io_graph_dialog.h | 46 +- ui/qt/io_graph_dialog.ui | 44 +- ui/qt/layout_preferences_frame.cpp | 29 +- ui/qt/layout_preferences_frame.h | 5 +- ui/qt/layout_preferences_frame.ui | 46 +- ui/qt/lbm_lbtrm_transport_dialog.cpp | 2 +- ui/qt/lbm_lbtru_transport_dialog.cpp | 2 +- ui/qt/lbm_stream_dialog.cpp | 2 +- ui/qt/lbm_uimflow_dialog.cpp | 667 - ui/qt/lbm_uimflow_dialog.h | 119 - ui/qt/lbm_uimflow_dialog.ui | 329 - ui/qt/lte_mac_statistics_dialog.cpp | 17 +- ui/qt/lte_mac_statistics_dialog.h | 2 + ui/qt/lte_rlc_graph_dialog.cpp | 106 +- ui/qt/lte_rlc_graph_dialog.h | 13 +- ui/qt/lte_rlc_graph_dialog.ui | 23 +- ui/qt/lte_rlc_statistics_dialog.cpp | 35 +- ui/qt/lte_rlc_statistics_dialog.h | 2 + ui/qt/main_status_bar.cpp | 82 +- ui/qt/main_status_bar.h | 4 + ui/qt/main_welcome.cpp | 94 +- ui/qt/main_window.cpp | 333 +- ui/qt/main_window.h | 54 +- ui/qt/main_window.ui | 51 +- ui/qt/main_window_preferences_frame.cpp | 5 +- ui/qt/main_window_slots.cpp | 335 +- ui/qt/manage_interfaces_dialog.cpp | 83 +- ui/qt/manage_interfaces_dialog.h | 6 +- ui/qt/models/astringlist_list_model.cpp | 205 + ui/qt/models/astringlist_list_model.h | 103 + ui/qt/models/cache_proxy_model.cpp | 112 + ui/qt/{ => models}/cache_proxy_model.h | 0 ui/qt/models/decode_as_delegate.cpp | 408 + ui/qt/models/decode_as_delegate.h | 71 + ui/qt/models/decode_as_model.cpp | 727 + ui/qt/models/decode_as_model.h | 108 + ui/qt/models/enabled_protocols_model.cpp | 529 + ui/qt/models/enabled_protocols_model.h | 97 + ui/qt/models/expert_info_model.cpp | 417 + ui/qt/models/expert_info_model.h | 141 + ui/qt/models/expert_info_proxy_model.cpp | 278 + ui/qt/models/expert_info_proxy_model.h | 73 + ui/qt/models/fileset_entry_model.cpp | 175 + ui/qt/models/fileset_entry_model.h | 64 + ui/qt/models/html_text_delegate.cpp | 66 + ui/qt/models/html_text_delegate.h | 48 + ui/qt/models/interface_sort_filter_model.cpp | 396 + ui/qt/models/interface_sort_filter_model.h | 106 + ui/qt/models/interface_tree_cache_model.cpp | 618 + ui/qt/models/interface_tree_cache_model.h | 92 + ui/qt/models/interface_tree_model.cpp | 545 + ui/qt/{ => models}/interface_tree_model.h | 0 ui/qt/models/numeric_value_chooser_delegate.cpp | 117 + .../{ => models}/numeric_value_chooser_delegate.h | 0 ui/qt/models/packet_list_model.cpp | 753 + ui/qt/{ => models}/packet_list_model.h | 0 ui/qt/models/packet_list_record.cpp | 334 + ui/qt/{ => models}/packet_list_record.h | 0 ui/qt/models/path_chooser_delegate.cpp | 152 + ui/qt/{ => models}/path_chooser_delegate.h | 0 ui/qt/models/percent_bar_delegate.cpp | 116 + ui/qt/{ => models}/percent_bar_delegate.h | 0 ui/qt/models/proto_tree_model.cpp | 222 + ui/qt/models/proto_tree_model.h | 58 + ui/qt/models/related_packet_delegate.cpp | 308 + ui/qt/models/related_packet_delegate.h | 79 + ui/qt/models/sparkline_delegate.cpp | 124 + ui/qt/{ => models}/sparkline_delegate.h | 0 ui/qt/models/supported_protocols_model.cpp | 301 + ui/qt/models/supported_protocols_model.h | 119 + ui/qt/models/timeline_delegate.cpp | 102 + ui/qt/{ => models}/timeline_delegate.h | 0 ui/qt/models/uat_delegate.cpp | 274 + ui/qt/models/uat_delegate.h | 59 + ui/qt/models/uat_model.cpp | 465 + ui/qt/models/uat_model.h | 73 + ui/qt/models/url_link_delegate.cpp | 50 + ui/qt/models/url_link_delegate.h | 44 + ui/qt/models/voip_calls_info_model.cpp | 246 + ui/qt/models/voip_calls_info_model.h | 96 + ui/qt/module_preferences_scroll_area.cpp | 4 +- ui/qt/mtp3_summary_dialog.cpp | 3 +- ui/qt/multicast_statistics_dialog.cpp | 2 +- ui/qt/numeric_value_chooser_delegate.cpp | 117 - ui/qt/packet_comment_dialog.cpp | 8 +- ui/qt/packet_comment_dialog.h | 4 +- ui/qt/packet_dialog.cpp | 78 +- ui/qt/packet_dialog.h | 11 +- ui/qt/packet_list.cpp | 117 +- ui/qt/packet_list.h | 13 +- ui/qt/packet_list_model.cpp | 753 - ui/qt/packet_list_record.cpp | 333 - ui/qt/packet_range_group_box.cpp | 2 + ui/qt/packet_range_group_box.h | 2 +- ui/qt/path_chooser_delegate.cpp | 152 - ui/qt/percent_bar_delegate.cpp | 116 - ui/qt/preference_editor_frame.cpp | 28 +- ui/qt/preference_editor_frame.h | 5 + ui/qt/preferences_dialog.cpp | 12 +- ui/qt/preferences_dialog.h | 1 + ui/qt/profile_dialog.cpp | 6 +- ui/qt/progress_frame.cpp | 14 +- ui/qt/progress_frame.h | 4 +- ui/qt/progress_frame.ui | 2 +- ui/qt/proto_tree.cpp | 644 +- ui/qt/proto_tree.h | 57 +- ui/qt/protocol_hierarchy_dialog.cpp | 6 +- ui/qt/protocol_hierarchy_dialog.h | 2 +- ui/qt/protocol_preferences_menu.cpp | 39 +- ui/qt/protocol_preferences_menu.h | 16 +- ui/qt/qcustomplot.cpp | 23486 ------- ui/qt/qt_ui_utils.cpp | 273 - ui/qt/qt_ui_utils.h | 238 - ui/qt/recent_file_status.cpp | 25 +- ui/qt/recent_file_status.h | 23 +- ui/qt/related_packet_delegate.cpp | 273 - ui/qt/related_packet_delegate.h | 78 - ui/qt/remote_capture_dialog.cpp | 17 +- ui/qt/resolved_addresses_dialog.cpp | 4 +- ui/qt/response_time_delay_dialog.cpp | 2 +- ui/qt/rpc_service_response_time_dialog.cpp | 2 +- ui/qt/rtp_analysis_dialog.cpp | 13 +- ui/qt/rtp_analysis_dialog.ui | 2 +- ui/qt/rtp_audio_stream.cpp | 34 +- ui/qt/rtp_audio_stream.h | 1 + ui/qt/rtp_player_dialog.cpp | 42 +- ui/qt/rtp_player_dialog.h | 1 + ui/qt/rtp_player_dialog.ui | 2 +- ui/qt/rtp_stream_dialog.cpp | 6 +- ui/qt/sctp_all_assocs_dialog.cpp | 2 +- ui/qt/sctp_assoc_analyse_dialog.cpp | 2 +- ui/qt/sctp_graph_arwnd_dialog.cpp | 2 +- ui/qt/sctp_graph_arwnd_dialog.h | 9 +- ui/qt/sctp_graph_arwnd_dialog.ui | 2 +- ui/qt/sctp_graph_byte_dialog.cpp | 2 +- ui/qt/sctp_graph_byte_dialog.h | 9 +- ui/qt/sctp_graph_byte_dialog.ui | 2 +- ui/qt/sctp_graph_dialog.cpp | 4 +- ui/qt/sctp_graph_dialog.h | 9 +- ui/qt/sctp_graph_dialog.ui | 2 +- ui/qt/search_frame.cpp | 15 +- ui/qt/sequence_diagram.cpp | 17 +- ui/qt/sequence_diagram.h | 2 +- ui/qt/sequence_dialog.cpp | 100 +- ui/qt/sequence_dialog.h | 9 +- ui/qt/sequence_dialog.ui | 21 +- ui/qt/service_response_time_dialog.cpp | 41 +- ui/qt/service_response_time_dialog.h | 7 + ui/qt/show_packet_bytes_dialog.cpp | 5 +- ui/qt/simple_dialog.cpp | 161 +- ui/qt/simple_dialog.h | 26 +- ui/qt/simple_statistics_dialog.cpp | 14 + ui/qt/simple_statistics_dialog.h | 3 + ui/qt/sparkline_delegate.cpp | 120 - ui/qt/splash_overlay.cpp | 46 +- ui/qt/splash_overlay.h | 3 +- ui/qt/splash_overlay.ui | 133 +- ui/qt/stats_tree_dialog.cpp | 4 +- ui/qt/stock_icon.cpp | 166 - ui/qt/stock_icon_tool_button.cpp | 124 - ui/qt/supported_protocols_dialog.cpp | 123 +- ui/qt/supported_protocols_dialog.h | 19 +- ui/qt/supported_protocols_dialog.ui | 22 +- ui/qt/tap_parameter_dialog.cpp | 4 +- ui/qt/tcp_stream_dialog.cpp | 71 +- ui/qt/tcp_stream_dialog.h | 4 +- ui/qt/tcp_stream_dialog.ui | 15 +- ui/qt/time_shift_dialog.cpp | 2 +- ui/qt/timeline_delegate.cpp | 102 - ui/qt/traffic_table_dialog.cpp | 5 +- ui/qt/uat_delegate.cpp | 217 - ui/qt/uat_delegate.h | 57 - ui/qt/uat_dialog.cpp | 74 +- ui/qt/uat_dialog.h | 8 +- ui/qt/uat_dialog.ui | 48 +- ui/qt/uat_frame.cpp | 89 +- ui/qt/uat_frame.h | 9 +- ui/qt/uat_frame.ui | 50 +- ui/qt/uat_model.cpp | 417 - ui/qt/uat_model.h | 70 - ui/qt/utils/color_utils.cpp | 172 + ui/qt/utils/color_utils.h | 87 + ui/qt/utils/data_printer.cpp | 179 + ui/qt/utils/data_printer.h | 77 + ui/qt/utils/field_information.cpp | 206 + ui/qt/utils/field_information.h | 86 + ui/qt/utils/frame_information.cpp | 124 + ui/qt/utils/frame_information.h | 81 + ui/qt/utils/proto_node.cpp | 171 + ui/qt/utils/proto_node.h | 69 + ui/qt/utils/qt_ui_utils.cpp | 273 + ui/qt/utils/qt_ui_utils.h | 248 + ui/qt/utils/stock_icon.cpp | 166 + ui/qt/{ => utils}/stock_icon.h | 0 ui/qt/{ => utils}/tango_colors.h | 0 ui/qt/{ => utils}/variant_pointer.h | 0 ui/qt/utils/wireshark_mime_data.cpp | 84 + ui/qt/utils/wireshark_mime_data.h | 79 + ui/qt/voip_calls_dialog.cpp | 10 +- ui/qt/voip_calls_dialog.h | 10 +- ui/qt/voip_calls_info_model.cpp | 246 - ui/qt/voip_calls_info_model.h | 96 - ui/qt/widgets/additional_toolbar.cpp | 4 +- ui/qt/widgets/apply_line_edit.cpp | 2 +- ui/qt/widgets/apply_line_edit.h | 2 +- ui/qt/widgets/byte_view_text.cpp | 593 + ui/qt/widgets/byte_view_text.h | 146 + ui/qt/widgets/capture_filter_combo.cpp | 4 +- ui/qt/widgets/capture_filter_combo.h | 2 +- ui/qt/widgets/capture_filter_edit.cpp | 50 +- ui/qt/widgets/capture_filter_edit.h | 2 +- ui/qt/widgets/display_filter_combo.cpp | 6 +- ui/qt/widgets/display_filter_edit.cpp | 122 +- ui/qt/widgets/display_filter_edit.h | 6 + ui/qt/widgets/drag_drop_toolbar.cpp | 129 +- ui/qt/widgets/drag_drop_toolbar.h | 5 + ui/qt/widgets/drag_label.cpp | 53 + ui/qt/widgets/drag_label.h | 52 + ui/qt/widgets/editor_color_dialog.cpp | 57 + ui/qt/widgets/editor_color_dialog.h | 59 + ui/qt/widgets/editor_file_dialog.cpp | 55 + ui/qt/widgets/editor_file_dialog.h | 59 + ui/qt/widgets/elided_label.cpp | 2 +- ui/qt/widgets/expert_info_view.cpp | 55 + ui/qt/widgets/expert_info_view.h | 42 + ui/qt/widgets/field_filter_edit.cpp | 6 +- ui/qt/widgets/field_filter_edit.h | 2 +- ui/qt/widgets/find_line_edit.cpp | 4 +- ui/qt/widgets/follow_stream_text.cpp | 2 +- ui/qt/widgets/interface_toolbar_lineedit.cpp | 15 +- ui/qt/widgets/interface_toolbar_lineedit.h | 2 +- ui/qt/widgets/label_stack.cpp | 4 +- ui/qt/widgets/overlay_scroll_bar.cpp | 17 +- ui/qt/widgets/overlay_scroll_bar.h | 4 + ui/qt/widgets/qcustomplot.cpp | 23490 +++++++ ui/qt/{ => widgets}/qcustomplot.h | 0 ui/qt/widgets/stock_icon_tool_button.cpp | 124 + ui/qt/{ => widgets}/stock_icon_tool_button.h | 0 ui/qt/widgets/syntax_line_edit.cpp | 4 +- ui/qt/wireless_frame.cpp | 3 +- ui/qt/wireless_timeline.cpp | 73 +- ui/qt/wireless_timeline.h | 4 +- ui/qt/wireshark_application.cpp | 167 +- ui/qt/wireshark_application.h | 33 +- ui/qt/wireshark_de.ts | 4212 +- ui/qt/wireshark_dialog.cpp | 4 +- ui/qt/wireshark_en.ts | 4208 +- ui/qt/wireshark_fr.ts | 4189 +- ui/qt/wireshark_it.ts | 4204 +- ui/qt/wireshark_ja_JP.ts | 4190 +- ui/qt/wireshark_pl.ts | 4174 +- ui/qt/wireshark_zh_CN.ts | 4184 +- ui/qt/wlan_statistics_dialog.cpp | 4 +- ui/recent.c | 2194 +- ui/recent.h | 28 +- ui/software_update.c | 4 + ui/tap-iax2-analysis.c | 2 - ui/tap-rlc-graph.c | 19 +- ui/tap-rlc-graph.h | 8 +- ui/tap-rtp-common.c | 1171 +- ui/tap-rtp-common.h | 20 +- ui/tap-sctp-analysis.c | 2303 +- ui/tap-sctp-analysis.h | 28 +- ui/tap-sequence-analysis.c | 731 - ui/tap-sequence-analysis.h | 159 - ui/tap-tcp-stream.c | 4 +- ui/tap_export_pdu.c | 4 +- ui/taps.h | 46 + ui/text_import_scanner.l | 2 + ui/time_shift.c | 25 +- ui/traffic_table_ui.c | 2 +- ui/ui_util.h | 110 - ui/util.c | 2 +- ui/voip_calls.c | 50 +- ui/voip_calls.h | 3 +- ui/win32/.editorconfig | 8 - ui/win32/console_win32.c | 280 +- ui/win32/console_win32.h | 24 +- ui/win32/file_dlg_win32.c | 29 +- ui/win32/file_dlg_win32.h | 15 +- ui/win32/print_win32.c | 15 +- ui/win32/print_win32.h | 14 +- ui/win32/settings.ini | 1 + ui/ws_ui_util.h | 110 + version_info.c | 407 + version_info.h | 66 + wireshark-qt.cpp | 141 +- wireshark.pc.in | 1 + wiretap/CMakeLists.txt | 28 +- wiretap/Makefile.am | 67 +- wiretap/ascend_scanner.l | 2 + wiretap/catapult_dct2000.c | 4 +- wiretap/erf.c | 25 +- wiretap/file_access.c | 8 +- wiretap/k12text.l | 6 +- wiretap/libpcap.c | 12 + wiretap/libpcap.h | 8 + wiretap/netmon.c | 541 +- wiretap/nettrace_3gpp_32_423.c | 67 +- wiretap/ngsniffer.c | 9 +- wiretap/pcap-common.c | 5 + wiretap/pcapng.h | 6 + wiretap/pppdump.c | 3 +- wiretap/visual.c | 3 +- wiretap/vwr.c | 131 +- wiretap/wtap-int.h | 2 +- wiretap/wtap.c | 108 +- wiretap/wtap.h | 49 +- wiretap/wtap_opttypes.c | 6 +- wiretap/wtap_opttypes.h | 8 +- wka | 263 + wka.tmpl | 263 - writecap/CMakeLists.txt | 4 +- writecap/Makefile.am | 13 +- writecap/pcapio.c | 42 +- writecap/pcapio.h | 8 + ws_attributes.h | 76 + ws_compiler_tests.h | 138 + ws_diag_control.h | 96 +- ws_symbol_export.h | 94 +- ws_version_info.c | 397 - ws_version_info.h | 73 - wsutil/.editorconfig | 15 - wsutil/CMakeLists.txt | 89 +- wsutil/Makefile.am | 100 +- wsutil/adler32.c | 14 +- wsutil/adler32.h | 14 +- wsutil/base32.c | 14 +- wsutil/base32.h | 14 +- wsutil/base64.c | 14 +- wsutil/base64.h | 14 +- wsutil/bits_count_ones.h | 17 +- wsutil/bits_ctz.h | 14 +- wsutil/bitswap.c | 14 +- wsutil/bitswap.h | 14 +- wsutil/buffer.c | 15 +- wsutil/buffer.h | 15 +- wsutil/cfutils.c | 14 +- wsutil/cfutils.h | 14 +- wsutil/clopts_common.c | 14 +- wsutil/clopts_common.h | 14 +- wsutil/cmdarg_err.c | 14 +- wsutil/cmdarg_err.h | 14 +- wsutil/color.h | 20 +- wsutil/copyright_info.c | 14 +- wsutil/copyright_info.h | 14 +- wsutil/cpu_info.c | 14 +- wsutil/cpu_info.h | 14 +- wsutil/crash_info.c | 14 +- wsutil/crash_info.h | 15 +- wsutil/crc10.c | 14 +- wsutil/crc10.h | 15 +- wsutil/crc11.c | 14 +- wsutil/crc11.h | 14 +- wsutil/crc16-plain.c | 14 +- wsutil/crc16-plain.h | 14 +- wsutil/crc16.c | 14 +- wsutil/crc16.h | 14 +- wsutil/crc32.c | 14 +- wsutil/crc32.h | 14 +- wsutil/crc6.c | 15 +- wsutil/crc6.h | 14 +- wsutil/crc7.c | 14 +- wsutil/crc7.h | 14 +- wsutil/crc8.c | 14 +- wsutil/crc8.h | 14 +- wsutil/eax.c | 14 +- wsutil/eax.h | 14 +- wsutil/file_util.c | 40 +- wsutil/file_util.h | 14 +- wsutil/filesystem.c | 102 +- wsutil/filesystem.h | 38 +- wsutil/frequency-utils.c | 14 +- wsutil/frequency-utils.h | 14 +- wsutil/g711.h | 14 +- wsutil/glib-compat.c | 77 +- wsutil/glib-compat.h | 31 +- wsutil/inet_addr-int.h | 66 - wsutil/inet_addr.c | 94 +- wsutil/inet_addr.h | 78 +- wsutil/inet_aton.c | 155 - wsutil/inet_aton.h | 52 - wsutil/inet_ipv4.h | 38 + wsutil/inet_ipv6.h | 30 +- wsutil/inet_ntop.c | 209 - wsutil/inet_pton.c | 248 - wsutil/interface.c | 21 +- wsutil/interface.h | 20 +- wsutil/mpeg-audio.c | 14 +- wsutil/mpeg-audio.h | 14 +- wsutil/nstime.c | 15 +- wsutil/nstime.h | 14 +- wsutil/os_version_info.c | 14 +- wsutil/os_version_info.h | 14 +- wsutil/pint.h | 15 +- wsutil/plugins.c | 535 +- wsutil/plugins.h | 39 +- wsutil/popcount.c | 14 +- wsutil/popcount.h | 16 +- wsutil/privileges.c | 14 +- wsutil/privileges.h | 14 +- wsutil/processes.h | 14 +- wsutil/report_message.c | 14 +- wsutil/report_message.h | 14 +- wsutil/rsa.c | 114 +- wsutil/rsa.h | 14 +- wsutil/sign_ext.h | 14 +- wsutil/socket.h | 27 +- wsutil/str_util.c | 56 +- wsutil/str_util.h | 14 +- wsutil/strptime.h | 14 +- wsutil/strtoi.c | 14 +- wsutil/strtoi.h | 14 +- wsutil/tempfile.c | 19 +- wsutil/tempfile.h | 14 +- wsutil/time_util.c | 66 +- wsutil/time_util.h | 20 +- wsutil/type_util.c | 14 +- wsutil/type_util.h | 14 +- wsutil/unicode-utils.c | 14 +- wsutil/unicode-utils.h | 16 +- wsutil/utf8_entities.h | 14 +- wsutil/win32-utils.c | 14 +- wsutil/win32-utils.h | 16 +- wsutil/ws_cpuid.h | 16 +- wsutil/ws_mempbrk.c | 14 +- wsutil/ws_mempbrk.h | 14 +- wsutil/ws_mempbrk_int.h | 14 +- wsutil/ws_printf.h | 14 +- wsutil/wsgcrypt.c | 15 +- wsutil/wsgcrypt.h | 22 +- wsutil/wsjsmn.c | 117 +- wsutil/wsjsmn.h | 19 +- wsutil/wspcap.h | 14 +- wsutil/xtea.c | 15 +- wsutil/xtea.h | 15 +- 1804 files changed, 260392 insertions(+), 196076 deletions(-) delete mode 100644 CPackConfig.txt delete mode 100644 README delete mode 100644 README.cmake create mode 100644 README.md delete mode 100644 README.vmware delete mode 100644 cmake/modules/CMakeInstallDirs.cmake create mode 100644 cmake/modules/FindBCG729.cmake create mode 100644 cmake/modules/FindPerl.cmake delete mode 100644 cmake/modules/FindYAPP.cmake delete mode 100644 cmake/modules/UseMakeDissectorReg.cmake create mode 100644 cmake/modules/UseMakePluginReg.cmake delete mode 100644 cmake/modules/UseMakeTapReg.cmake create mode 100644 cmake/modules/UseMakeTaps.cmake create mode 100644 codecs/G729/G729decode.c create mode 100644 codecs/G729/G729decode.h create mode 100644 diameter/Huawei.xml create mode 100644 doc/README.build-system delete mode 100755 doc/dfilter2pod.pl create mode 100644 doc/plugins.example/Makefile.am create mode 100644 doc/plugins.example/README create mode 100644 doc/plugins.example/configure.ac create mode 100644 doc/plugins.example/hello.c rename docbook/{ => common_src}/GPL_appendix.asciidoc (100%) create mode 100644 docbook/common_src/typographic_conventions.asciidoc delete mode 100755 docbook/dfilter2xml.pl create mode 100644 docbook/wsug_src/capinfos-h.txt create mode 100644 docbook/wsug_src/dumpcap-h.txt create mode 100644 docbook/wsug_src/editcap-F.txt create mode 100644 docbook/wsug_src/editcap-T.txt create mode 100644 docbook/wsug_src/editcap-h.txt create mode 100644 docbook/wsug_src/mergecap-h.txt create mode 100644 docbook/wsug_src/rawshark-h.txt create mode 100644 docbook/wsug_src/reordercap-h.txt create mode 100644 docbook/wsug_src/text2pcap-h.txt create mode 100644 docbook/wsug_src/tshark-h.txt delete mode 100644 epan/asm_utils.c delete mode 100644 epan/asm_utils.h delete mode 100644 epan/asm_utils_win32_x86.asm delete mode 100644 epan/circuit.c delete mode 100644 epan/circuit.h delete mode 100644 epan/compress/Makefile.am delete mode 100644 epan/compress/lzxpress.c delete mode 100644 epan/compress/lzxpress.h create mode 100644 epan/dissectors/asn1/kerberos/RFC6113.asn delete mode 100644 epan/dissectors/asn1/x721/Makefile.am create mode 100644 epan/dissectors/dissectors.h create mode 100644 epan/dissectors/make-dissectors.c create mode 100644 epan/dissectors/packet-artemis.c create mode 100644 epan/dissectors/packet-brcm-tag.c create mode 100644 epan/dissectors/packet-btmesh.c delete mode 100644 epan/dissectors/packet-dcm.h create mode 100644 epan/dissectors/packet-fp_mux.c create mode 100644 epan/dissectors/packet-grpc.c create mode 100644 epan/dissectors/packet-ieee1905.c delete mode 100644 epan/dissectors/packet-ipv6.h create mode 100644 epan/dissectors/packet-messageanalyzer.c create mode 100644 epan/dissectors/packet-mpls-mac.c create mode 100644 epan/dissectors/packet-netmon.c create mode 100644 epan/dissectors/packet-netmon.h create mode 100644 epan/dissectors/packet-nfapi.c create mode 100644 epan/dissectors/packet-pfcp.c create mode 100644 epan/dissectors/packet-protobuf.c create mode 100644 epan/dissectors/packet-protobuf.h create mode 100644 epan/dissectors/packet-quic.c create mode 100644 epan/dissectors/packet-solaredge.c create mode 100644 epan/dissectors/packet-tibia.c create mode 100644 epan/dissectors/packet-twamp.c create mode 100644 epan/dissectors/packet-wifi-dpp.c create mode 100644 epan/dissectors/packet-wisun.c mode change 100644 => 100755 epan/dissectors/packet-zbee-zcl-se.c delete mode 100644 epan/dissectors/packet-zep.h delete mode 100644 epan/dwarf.c delete mode 100644 epan/dwarf.h delete mode 100644 epan/epan-int.h delete mode 100644 epan/ipv4.c delete mode 100644 epan/oui.c mode change 100644 => 100755 epan/print.c create mode 100644 epan/register.c create mode 100644 epan/register.h create mode 100644 epan/sequence_analysis.c create mode 100644 epan/sequence_analysis.h delete mode 100644 epan/tpg.c delete mode 100644 epan/tpg.h create mode 100644 file_packet_provider.c create mode 100644 image/arrow_down.png create mode 100644 image/arrow_down at 2x.png create mode 100644 image/arrow_up.png create mode 100644 image/arrow_up at 2x.png create mode 100644 image/delete_list.png create mode 100644 image/delete_list at 2x.png create mode 100644 m4/ax_compare_version.m4 delete mode 100644 m4/libsmi.m4 delete mode 100644 m4/ws_osx.m4 delete mode 100755 macosx-setup.sh delete mode 100644 macosx-support-lib-patches/portaudio-pa_mac_core.c.patch delete mode 100644 macosx-support-lib-patches/portaudio-pa_mac_core.h.patch create mode 100644 macosx-support-lib-patches/spandsp-configure-patch delete mode 100755 packaging/macosx/osx-app.sh create mode 100755 packaging/macosx/osx-app.sh.in delete mode 100644 packaging/svr4/Makefile.am delete mode 100755 packaging/svr4/checkinstall.in delete mode 100755 packaging/svr4/mkpkg delete mode 100644 packaging/svr4/pkginfo.in delete mode 100644 plugins/docsis/moduleinfo.h delete mode 100644 plugins/docsis/plugin.rc.in delete mode 100644 plugins/easy_codec/Makefile.am delete mode 100644 plugins/easy_codec/ReadMe.txt delete mode 100644 plugins/easy_codec/codec-g722.c delete mode 100644 plugins/easy_codec/codec-g722.h delete mode 100644 plugins/easy_codec/codec-g7231.c delete mode 100644 plugins/easy_codec/codec-g7231.h delete mode 100644 plugins/easy_codec/codec-g729a.c delete mode 100644 plugins/easy_codec/codec-g729a.h delete mode 100644 plugins/easy_codec/easy_codec_plugin.c delete mode 100644 plugins/easy_codec/plugin.rc.in delete mode 100644 plugins/ethercat/COPYING delete mode 100644 plugins/ethercat/moduleinfo.h delete mode 100644 plugins/ethercat/plugin.rc.in delete mode 100644 plugins/gryphon/COPYING delete mode 100644 plugins/gryphon/NEWS delete mode 100644 plugins/gryphon/moduleinfo.h delete mode 100644 plugins/gryphon/plugin.rc.in delete mode 100644 plugins/irda/moduleinfo.h delete mode 100644 plugins/irda/plugin.rc.in delete mode 100644 plugins/m2m/AUTHORS delete mode 100644 plugins/m2m/CMakeLists.txt delete mode 100644 plugins/m2m/COPYING delete mode 100644 plugins/m2m/ChangeLog delete mode 100644 plugins/m2m/Makefile.am delete mode 100644 plugins/m2m/moduleinfo.h delete mode 100644 plugins/m2m/packet-m2m.c delete mode 100644 plugins/m2m/plugin.rc.in delete mode 100644 plugins/m2m/wimax_tlv.c delete mode 100644 plugins/mate/COPYING delete mode 100644 plugins/mate/moduleinfo.h delete mode 100644 plugins/mate/plugin.rc.in delete mode 100644 plugins/opcua/COPYING delete mode 100644 plugins/opcua/moduleinfo.h delete mode 100644 plugins/opcua/plugin.rc.in create mode 100644 plugins/plugin.rc.in delete mode 100644 plugins/pluginifdemo/COPYING delete mode 100644 plugins/pluginifdemo/NEWS delete mode 100644 plugins/pluginifdemo/moduleinfo.h delete mode 100644 plugins/pluginifdemo/plugin.rc.in delete mode 100644 plugins/profinet/COPYING delete mode 100644 plugins/profinet/moduleinfo.h delete mode 100644 plugins/profinet/plugin.rc.in delete mode 100644 plugins/stats_tree/plugin.rc.in delete mode 100644 plugins/tpg/CMakeLists.txt delete mode 100644 plugins/tpg/Makefile.am delete mode 100644 plugins/tpg/http.tpg delete mode 100644 plugins/tpg/packet-http.c delete mode 100644 plugins/transum/COPYING delete mode 100644 plugins/transum/NEWS delete mode 100644 plugins/transum/moduleinfo.h delete mode 100644 plugins/transum/plugin.rc.in delete mode 100644 plugins/unistim/COPYING delete mode 100644 plugins/unistim/moduleinfo.h delete mode 100644 plugins/unistim/plugin.rc.in delete mode 100644 plugins/wimax/COPYING delete mode 100644 plugins/wimax/ChangeLog delete mode 100644 plugins/wimax/moduleinfo.h create mode 100644 plugins/wimax/packet-m2m.c delete mode 100644 plugins/wimax/plugin.rc.in create mode 100644 plugins/wimax/wimax-int.h delete mode 100644 plugins/wimaxasncp/COPYING delete mode 100644 plugins/wimaxasncp/moduleinfo.h delete mode 100644 plugins/wimaxasncp/plugin.rc.in delete mode 100644 plugins/wimaxmacphy/COPYING delete mode 100644 plugins/wimaxmacphy/moduleinfo.h delete mode 100644 plugins/wimaxmacphy/plugin.rc.in delete mode 100644 register.h create mode 100755 tools/macos-setup.sh delete mode 100755 tools/make-dissector-reg.py create mode 100755 tools/make-plugin-reg.py delete mode 100755 tools/make-services.pl delete mode 100755 tools/make-tap-reg.py create mode 100644 tools/msvc2015AdminDeployment.xml create mode 100644 tools/oss-fuzzshark/StandaloneFuzzTargetMain.c create mode 100755 tools/release-update-debian-soversions.sh delete mode 100644 tools/setuid-root.pl.in delete mode 100644 tools/tpg/Makefile.am delete mode 100644 tools/tpg/V2P.pm delete mode 100755 tools/tpg/tpg.pl delete mode 100644 tools/tpg/tpg.yp delete mode 100644 ui/.editorconfig create mode 100644 ui/cli/tap-flow.c delete mode 100644 ui/gtk/lbm_uimflow_dlg.c delete mode 100644 ui/gtk/lbm_uimflow_dlg.h create mode 100644 ui/make-taps.c delete mode 100644 ui/qt/.gitignore delete mode 100644 ui/qt/byte_view_text.cpp delete mode 100644 ui/qt/byte_view_text.h delete mode 100644 ui/qt/cache_proxy_model.cpp delete mode 100644 ui/qt/color_utils.cpp delete mode 100644 ui/qt/color_utils.h delete mode 100644 ui/qt/interface_sort_filter_model.cpp delete mode 100644 ui/qt/interface_sort_filter_model.h delete mode 100644 ui/qt/interface_tree_cache_model.cpp delete mode 100644 ui/qt/interface_tree_cache_model.h delete mode 100644 ui/qt/interface_tree_model.cpp delete mode 100644 ui/qt/lbm_uimflow_dialog.cpp delete mode 100644 ui/qt/lbm_uimflow_dialog.h delete mode 100644 ui/qt/lbm_uimflow_dialog.ui create mode 100644 ui/qt/models/astringlist_list_model.cpp create mode 100644 ui/qt/models/astringlist_list_model.h create mode 100644 ui/qt/models/cache_proxy_model.cpp rename ui/qt/{ => models}/cache_proxy_model.h (100%) create mode 100644 ui/qt/models/decode_as_delegate.cpp create mode 100644 ui/qt/models/decode_as_delegate.h create mode 100644 ui/qt/models/decode_as_model.cpp create mode 100644 ui/qt/models/decode_as_model.h create mode 100644 ui/qt/models/enabled_protocols_model.cpp create mode 100644 ui/qt/models/enabled_protocols_model.h create mode 100644 ui/qt/models/expert_info_model.cpp create mode 100644 ui/qt/models/expert_info_model.h create mode 100644 ui/qt/models/expert_info_proxy_model.cpp create mode 100644 ui/qt/models/expert_info_proxy_model.h create mode 100644 ui/qt/models/fileset_entry_model.cpp create mode 100644 ui/qt/models/fileset_entry_model.h create mode 100644 ui/qt/models/html_text_delegate.cpp create mode 100644 ui/qt/models/html_text_delegate.h create mode 100644 ui/qt/models/interface_sort_filter_model.cpp create mode 100644 ui/qt/models/interface_sort_filter_model.h create mode 100644 ui/qt/models/interface_tree_cache_model.cpp create mode 100644 ui/qt/models/interface_tree_cache_model.h create mode 100644 ui/qt/models/interface_tree_model.cpp rename ui/qt/{ => models}/interface_tree_model.h (100%) create mode 100644 ui/qt/models/numeric_value_chooser_delegate.cpp rename ui/qt/{ => models}/numeric_value_chooser_delegate.h (100%) create mode 100644 ui/qt/models/packet_list_model.cpp rename ui/qt/{ => models}/packet_list_model.h (100%) create mode 100644 ui/qt/models/packet_list_record.cpp rename ui/qt/{ => models}/packet_list_record.h (100%) create mode 100644 ui/qt/models/path_chooser_delegate.cpp rename ui/qt/{ => models}/path_chooser_delegate.h (100%) create mode 100644 ui/qt/models/percent_bar_delegate.cpp rename ui/qt/{ => models}/percent_bar_delegate.h (100%) create mode 100644 ui/qt/models/proto_tree_model.cpp create mode 100644 ui/qt/models/proto_tree_model.h create mode 100644 ui/qt/models/related_packet_delegate.cpp create mode 100644 ui/qt/models/related_packet_delegate.h create mode 100644 ui/qt/models/sparkline_delegate.cpp rename ui/qt/{ => models}/sparkline_delegate.h (100%) create mode 100644 ui/qt/models/supported_protocols_model.cpp create mode 100644 ui/qt/models/supported_protocols_model.h create mode 100644 ui/qt/models/timeline_delegate.cpp rename ui/qt/{ => models}/timeline_delegate.h (100%) create mode 100644 ui/qt/models/uat_delegate.cpp create mode 100644 ui/qt/models/uat_delegate.h create mode 100644 ui/qt/models/uat_model.cpp create mode 100644 ui/qt/models/uat_model.h create mode 100644 ui/qt/models/url_link_delegate.cpp create mode 100644 ui/qt/models/url_link_delegate.h create mode 100644 ui/qt/models/voip_calls_info_model.cpp create mode 100644 ui/qt/models/voip_calls_info_model.h delete mode 100644 ui/qt/numeric_value_chooser_delegate.cpp delete mode 100644 ui/qt/packet_list_model.cpp delete mode 100644 ui/qt/packet_list_record.cpp delete mode 100644 ui/qt/path_chooser_delegate.cpp delete mode 100644 ui/qt/percent_bar_delegate.cpp delete mode 100644 ui/qt/qcustomplot.cpp delete mode 100644 ui/qt/qt_ui_utils.cpp delete mode 100644 ui/qt/qt_ui_utils.h delete mode 100644 ui/qt/related_packet_delegate.cpp delete mode 100644 ui/qt/related_packet_delegate.h delete mode 100644 ui/qt/sparkline_delegate.cpp delete mode 100644 ui/qt/stock_icon.cpp delete mode 100644 ui/qt/stock_icon_tool_button.cpp delete mode 100644 ui/qt/timeline_delegate.cpp delete mode 100644 ui/qt/uat_delegate.cpp delete mode 100644 ui/qt/uat_delegate.h delete mode 100644 ui/qt/uat_model.cpp delete mode 100644 ui/qt/uat_model.h create mode 100644 ui/qt/utils/color_utils.cpp create mode 100644 ui/qt/utils/color_utils.h create mode 100644 ui/qt/utils/data_printer.cpp create mode 100644 ui/qt/utils/data_printer.h create mode 100644 ui/qt/utils/field_information.cpp create mode 100644 ui/qt/utils/field_information.h create mode 100644 ui/qt/utils/frame_information.cpp create mode 100644 ui/qt/utils/frame_information.h create mode 100644 ui/qt/utils/proto_node.cpp create mode 100644 ui/qt/utils/proto_node.h create mode 100644 ui/qt/utils/qt_ui_utils.cpp create mode 100644 ui/qt/utils/qt_ui_utils.h create mode 100644 ui/qt/utils/stock_icon.cpp rename ui/qt/{ => utils}/stock_icon.h (100%) rename ui/qt/{ => utils}/tango_colors.h (100%) rename ui/qt/{ => utils}/variant_pointer.h (100%) create mode 100644 ui/qt/utils/wireshark_mime_data.cpp create mode 100644 ui/qt/utils/wireshark_mime_data.h delete mode 100644 ui/qt/voip_calls_info_model.cpp delete mode 100644 ui/qt/voip_calls_info_model.h create mode 100644 ui/qt/widgets/byte_view_text.cpp create mode 100644 ui/qt/widgets/byte_view_text.h create mode 100644 ui/qt/widgets/drag_label.cpp create mode 100644 ui/qt/widgets/drag_label.h create mode 100644 ui/qt/widgets/editor_color_dialog.cpp create mode 100644 ui/qt/widgets/editor_color_dialog.h create mode 100644 ui/qt/widgets/editor_file_dialog.cpp create mode 100644 ui/qt/widgets/editor_file_dialog.h create mode 100644 ui/qt/widgets/expert_info_view.cpp create mode 100644 ui/qt/widgets/expert_info_view.h create mode 100644 ui/qt/widgets/qcustomplot.cpp rename ui/qt/{ => widgets}/qcustomplot.h (100%) create mode 100644 ui/qt/widgets/stock_icon_tool_button.cpp rename ui/qt/{ => widgets}/stock_icon_tool_button.h (100%) delete mode 100644 ui/tap-sequence-analysis.c delete mode 100644 ui/tap-sequence-analysis.h create mode 100644 ui/taps.h delete mode 100644 ui/ui_util.h delete mode 100644 ui/win32/.editorconfig create mode 100644 ui/ws_ui_util.h create mode 100644 version_info.c create mode 100644 version_info.h create mode 100644 wka delete mode 100644 wka.tmpl create mode 100644 ws_attributes.h create mode 100644 ws_compiler_tests.h delete mode 100644 ws_version_info.c delete mode 100644 ws_version_info.h delete mode 100644 wsutil/inet_addr-int.h delete mode 100644 wsutil/inet_aton.c delete mode 100644 wsutil/inet_aton.h create mode 100644 wsutil/inet_ipv4.h delete mode 100644 wsutil/inet_ntop.c delete mode 100644 wsutil/inet_pton.c hooks/post-receive -- wireshark with Osmocom specific dissectors From gitosis at osmocom.org Tue Dec 19 22:57:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 19 Dec 2017 22:57:06 GMT Subject: osmo-ci.git branch master updated. c528cc12d0d935b9b6d151478ccd478122a661fb Message-ID: <201712192257.vBJMv69V033776@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via c528cc12d0d935b9b6d151478ccd478122a661fb (commit) from 85f74b5c908fd5ede0709850b7dfbed11e947917 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=c528cc12d0d935b9b6d151478ccd478122a661fb commit c528cc12d0d935b9b6d151478ccd478122a661fb Author: Neels Hofmeyr Date: Tue Dec 19 23:49:28 2017 +0100 jobs: master: fix: libosmoabis should trigger osmo-hlr Change-Id: I9a122cee4fa98115140e4a34f623958697affed2 ----------------------------------------------------------------------- Summary of changes: jobs/master-builds.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CI scripts From gitosis at osmocom.org Wed Dec 20 10:53:03 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 10:53:03 GMT Subject: libosmocore.git branch master updated. 0.10.2-72-g554f7b8a Message-ID: <201712201053.vBKAr3Pt096457@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 554f7b8a773b3cffd74707c18172366ab45ea306 (commit) from c0b0b623053f16790d7d675812befe382ebdfd6e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=554f7b8a773b3cffd74707c18172366ab45ea306 commit 554f7b8a773b3cffd74707c18172366ab45ea306 Author: Neels Hofmeyr Date: Wed Dec 20 01:14:31 2017 +0100 rate_ctr: fix osmo-sgsn DoS: don't return NULL on already used index Recent patch I563764af1d28043e909234ebb048239125ce6ecd introduced returning NULL from rate_ctr_group_alloc() when the index passed already exists. Instead of returning NULL, find an unused group index and use that, adjust the error message. In stats_test.c, adjust, and also assert allocated counter group indexes everywhere. Rationale: The original patch causes osmo-sgsn to crash as soon as the second subscriber attempts to establish an MM context. Of course osmo-sgsn is wrong to a) fail to check a NULL return value and crash and b) to fail to allocate an MM context just because the rate counter group could not be allocated (it still rejects the MM context completely if rate_ctr_group_alloc() fails). Nevertheless, the price we pay for rate counter correctness is, at least in this instance, way too high: osmo-sgsn becomes completely unusable for more than one subscriber. Numerous other places exist where rate_ctr_group_alloc() is called with a constant index number; from a quick grep magic I found these possible breaking points: osmo-sgsn/src/gprs/gb_proxy.c:1431: cfg->ctrg = rate_ctr_group_alloc(tall_bsc_ctx, &global_ctrg_desc, 0); osmo-sgsn/src/gprs/gprs_sgsn.c:139: sgsn->rate_ctrs = rate_ctr_group_alloc(tall_bsc_ctx, &sgsn_ctrg_desc, 0); osmo-sgsn/src/gprs/gprs_sgsn.c:270: ctx->ctrg = rate_ctr_group_alloc(ctx, &mmctx_ctrg_desc, 0); osmo-sgsn/src/gprs/gtphub.c:888: b->counters_io = rate_ctr_group_alloc(osmo_gtphub_ctx, >phub_ctrg_io_desc, 0); osmo-bsc/src/libfilter/bsc_msg_acc.c:87: lst->stats = rate_ctr_group_alloc(lst, &bsc_cfg_acc_list_desc, 0); osmo-pcu/src/bts.cpp:228: m_ratectrs = rate_ctr_group_alloc(tall_pcu_ctx, &bts_ctrg_desc, 0); osmo-pcu/src/tbf.cpp:793: tbf->m_ctrs = rate_ctr_group_alloc(tbf, &tbf_ctrg_desc, 0); osmo-pcu/src/tbf.cpp:879: tbf->m_ul_egprs_ctrs = rate_ctr_group_alloc(tbf, &tbf_ul_egprs_ctrg_desc, 0); osmo-pcu/src/tbf.cpp:880: tbf->m_ul_gprs_ctrs = rate_ctr_group_alloc(tbf, &tbf_ul_gprs_ctrg_desc, 0); osmo-pcu/src/tbf.cpp:970: tbf->m_dl_egprs_ctrs = rate_ctr_group_alloc(tbf, &tbf_dl_egprs_ctrg_desc, 0); osmo-pcu/src/tbf.cpp:977: tbf->m_dl_gprs_ctrs = rate_ctr_group_alloc(tbf, &tbf_dl_gprs_ctrg_desc, 0); osmo-pcu/src/tbf.cpp:1475: ul_tbf->m_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ctrg_desc, 0); osmo-pcu/src/bts.cpp:226: m_ratectrs = rate_ctr_group_alloc(tall_pcu_ctx, &bts_ctrg_desc, 1); We can fix all of these callers and then reconsider returning NULL, but IMO even into the future, rate counter group indexes are not something worth failing to provide service for. For future bugs we should keep the automatic index picking in case of index collisions. We will get an error message barfed and can fix the issue in our own time, while the application remains completely usable, and even the rate counters can still be queried (at wrong indexes, but life is tough). Related: I49aa95b610f2faec52dede2e4816da47ca1dfb14 (osmo-sgsn's segfault) Change-Id: Iba6e41b8eeaea5ff6ed862bab3f34a62ab976914 ----------------------------------------------------------------------- Summary of changes: src/rate_ctr.c | 29 ++++++++++++++++++++++++++--- tests/stats/stats_test.c | 10 +++++----- 2 files changed, 31 insertions(+), 8 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 20 10:57:12 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 10:57:12 GMT Subject: osmo-gsm-manuals.git branch master updated. a13675c549c5b2077b54f3b384ed0304ad3b736e Message-ID: <201712201057.vBKAvCNO098694@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Manuals for Osmocom GSM components". The branch, master has been updated via a13675c549c5b2077b54f3b384ed0304ad3b736e (commit) via 74b55d74573a87432b0898add829fe83fce85895 (commit) from ccb51225c51e08a87f75f2491efc1404b99ebc7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=a13675c549c5b2077b54f3b384ed0304ad3b736e commit a13675c549c5b2077b54f3b384ed0304ad3b736e Author: Neels Hofmeyr Date: Wed Dec 20 02:29:12 2017 +0100 ports: add osmo-hnbgw as on port-numbers wiki page Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers Related: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore) Change-Id: I28bd7a97d24455f88fadc6724d45c3264ba2fce4 http://cgit.osmocom.org/osmo-gsm-manuals/commit/?id=74b55d74573a87432b0898add829fe83fce85895 commit 74b55d74573a87432b0898add829fe83fce85895 Author: Neels Hofmeyr Date: Wed Dec 20 02:28:41 2017 +0100 common: ports: tweak OpenGGSN to osmo-ggsn as on port-numbers wiki page Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers Change-Id: Ieaac06c9d914fc7481107ca8ebe6192b36b91bcd ----------------------------------------------------------------------- Summary of changes: common/chapters/port_numbers.adoc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- Manuals for Osmocom GSM components From gitosis at osmocom.org Wed Dec 20 10:57:35 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 10:57:35 GMT Subject: libosmocore.git branch master updated. 0.10.2-73-g58a5665e Message-ID: <201712201057.vBKAvZaN098892@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 58a5665ecb72b2b4e2a9e33dde83d12060c41b4a (commit) from 554f7b8a773b3cffd74707c18172366ab45ea306 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=58a5665ecb72b2b4e2a9e33dde83d12060c41b4a commit 58a5665ecb72b2b4e2a9e33dde83d12060c41b4a Author: Neels Hofmeyr Date: Wed Dec 20 02:26:44 2017 +0100 ports: define proper VTY and CTRL ports for OsmoHNBGW So far it uses 2323, a development default. Instead, assign new ports, appending to the common range of VTY and CTRL ports: 4261 and 4262. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers Related: I28bd7a97d24455f88fadc6724d45c3264ba2fce4 (osmo-gsm-manuals) Change-Id: Ife52a968a41cb286f640006587877971ff66c1a4 ----------------------------------------------------------------------- Summary of changes: include/osmocom/ctrl/ports.h | 1 + include/osmocom/vty/ports.h | 2 ++ 2 files changed, 3 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 20 10:58:47 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 10:58:47 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-19-g69888c8 Message-ID: <201712201058.vBKAwlbc099500@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 69888c86edfbdf83ee0092bed9bdcf44f3ba433d (commit) from accb78000b6161d5f76eae24e625c01533001b89 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=69888c86edfbdf83ee0092bed9bdcf44f3ba433d commit 69888c86edfbdf83ee0092bed9bdcf44f3ba433d Author: Neels Hofmeyr Date: Fri Dec 15 02:54:45 2017 +0100 iu client: store multiple LAC,RAC per RNC = fix paging for multiple RNC Introduce a list of LAC+RAC entries for each RNC, hence allow serving more than one LAC per OsmoHNBGW. iu_client is used by OsmoMSC and OsmoSGSN, both will be able to page successfully in a setup with multiple LACs (read: multiple hNodeB) connected to an OsmoHNBGW. Ensure that each LAC,RAC is registered with at most one RNC Id. If a LAC,RAC shows up on a different RNC Id than before, move it over to the new RNC Id. Future patches should probably add: * timeouts of RNC Id / LAC,RAC validity, to remove unused entries. * VTY/CTRL commands to introspect which RNCs and LAC,RACs are listed. * VTY/CTRL commands to remove RNC Id / LAC,RAC entries. Change-Id: I189f8e2663353276b1c615d2f78455dafe568045 ----------------------------------------------------------------------- Summary of changes: src/iu_client.c | 217 ++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 131 insertions(+), 86 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Wed Dec 20 11:11:31 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 11:11:31 GMT Subject: osmo-python-tests.git branch master updated. 56aa4785c028a72211913b6c1e11a0173abce062 Message-ID: <201712201111.vBKBBVM6005775@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 56aa4785c028a72211913b6c1e11a0173abce062 (commit) from 1a5364696eaf66a382e6d451bc4255622d845a92 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=56aa4785c028a72211913b6c1e11a0173abce062 commit 56aa4785c028a72211913b6c1e11a0173abce062 Author: Neels Hofmeyr Date: Tue Dec 19 14:12:16 2017 +0100 fix osmo_interact_* and osmo_verify_transcript_* after dir split After I30cdf0f85b2a60a235960911c9827f4129da40db, * the osmo_interact_{vty,ctrl}.py can no longer import osmo_interact_common, since it was moved to scripts/ in error. * the osmo_verify_{vty,ctrl} scripts can no longer import osmo_interact_{vty,ctrl}, since it is also in scripts/. Notably, the osmo_interact_{vty,ctrl}.py also served as scripts while being modules at the same time, which is not good. Fix these issues by adding a new osmopy/osmo_interact/ submodule with osmopy/osmo_interact/common.py, /vty.py and /ctrl.py as modules, and add in scripts thin wrappers that invoke the modules' main(). Change-Id: I40a37b212274cb70ebb1e1d9d1b3743eb2d64d05 ----------------------------------------------------------------------- Summary of changes: osmopy/__init__.py | 4 +- osmopy/osmo_interact/__init__.py | 2 + .../osmo_interact/common.py | 5 + .../osmo_interact/ctrl.py | 18 ++- .../osmo_interact/vty.py | 14 +- scripts/osmo_interact_ctrl.py | 79 +--------- scripts/osmo_interact_vty.py | 159 +-------------------- scripts/osmo_verify_transcript_ctrl.py | 37 +---- scripts/osmo_verify_transcript_vty.py | 46 +----- 9 files changed, 45 insertions(+), 319 deletions(-) create mode 100644 osmopy/osmo_interact/__init__.py rename scripts/osmo_interact_common.py => osmopy/osmo_interact/common.py (98%) copy scripts/osmo_interact_ctrl.py => osmopy/osmo_interact/ctrl.py (82%) copy scripts/osmo_interact_vty.py => osmopy/osmo_interact/vty.py (94%) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 13:58:10 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 13:58:10 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-20-g2c56f6d Message-ID: <201712201358.vBKDwAfS098758@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 2c56f6d4540cd5288ab24ef35f95764bb73d2c79 (commit) from 69888c86edfbdf83ee0092bed9bdcf44f3ba433d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=2c56f6d4540cd5288ab24ef35f95764bb73d2c79 commit 2c56f6d4540cd5288ab24ef35f95764bb73d2c79 Author: Neels Hofmeyr Date: Wed Dec 20 02:31:49 2017 +0100 hnbgw: use proper VTY port number defined in libosmocore (4261) We used to have hardcoded 2323 from early development, use the proper libosmocore definition instead. Depends: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore) Change-Id: Id67d89695ebdc6288f507338c15ad773b8adf6e4 ----------------------------------------------------------------------- Summary of changes: src/hnbgw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Wed Dec 20 13:59:41 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 13:59:41 GMT Subject: osmo-python-tests.git branch master updated. 150a6eac9be9eae13b9eb5fa287c925f0cf19ab2 Message-ID: <201712201359.vBKDxfSi099417@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 150a6eac9be9eae13b9eb5fa287c925f0cf19ab2 (commit) from 56aa4785c028a72211913b6c1e11a0173abce062 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=150a6eac9be9eae13b9eb5fa287c925f0cf19ab2 commit 150a6eac9be9eae13b9eb5fa287c925f0cf19ab2 Author: Neels Hofmeyr Date: Tue Dec 19 14:51:32 2017 +0100 scripts: add symlink to osmopy To allow running the scripts from within the scripts/ dir without having to install osmopy on the system first, place a symlink to the osmopy module dir. This allows testing modifications without having to run setup.py all the time. Change-Id: I880c8afa8d02ef112a80cb54f649ec71902bbd4c ----------------------------------------------------------------------- Summary of changes: scripts/osmopy | 1 + 1 file changed, 1 insertion(+) create mode 120000 scripts/osmopy hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 15:44:40 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:44:40 GMT Subject: osmo-bts.git branch master updated. 0.7.0-33-g0bac3ef Message-ID: <201712201544.vBKFieMV060029@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 0bac3efc176e49eb22e4e9a0ede55143efc0e64f (commit) from 3c96db29fadbf1fb9519252462661f21da83e907 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=0bac3efc176e49eb22e4e9a0ede55143efc0e64f commit 0bac3efc176e49eb22e4e9a0ede55143efc0e64f Author: Philipp Maier Date: Fri Dec 15 11:57:39 2017 +0100 octphy: l1_oml: check returncode of trx_by_l1h() The function trx_by_l1h() is used to fetch the pointer to a an osmo_bts_trx from a list. The ID that is used to reference the transceiver comes from the incoming message. If the firmware sends odd identifiers (firmware bugs, damaged packets) the transceiver can not be found in the list and a nullpointer is returned, which then leads into a nullpointer derefernece problem. Check the returncode, and depending on the situation either return with -EINVAL or exit osmo-bts immediately. Change-Id: I04ef3b4896e1322c2a6d29ea86a88994c7748bf7 ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-octphy/l1_oml.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Wed Dec 20 15:46:24 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:46:24 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-20-gc21f007 Message-ID: <201712201546.vBKFkOfW060991@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via c21f007277713b15d9a48d0bcc6f28aa51b4f908 (commit) from ea9968f6854cbfe79506efedc43a953a7c38cdd6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=c21f007277713b15d9a48d0bcc6f28aa51b4f908 commit c21f007277713b15d9a48d0bcc6f28aa51b4f908 Author: Max Date: Fri Dec 15 17:36:45 2017 +0100 Introduce LOGTBF* for consistent logging When troubleshooting complex issues with TBF lifecycle, it's much easier to follow the logs which are consistently formatted. Add LOGTBF*() macro similar to struct-specific log routines we use in other Osmocom project and use it to log TBF-related messages in a unified way. Tweak test output accordingly. Related: OS#2407 Change-Id: I388249afefc32d2f6e5cb5e5abc6daf4dbd284ea ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 80 +-- src/tbf.cpp | 111 ++-- src/tbf.h | 4 + src/tbf_dl.cpp | 42 +- src/tbf_ul.cpp | 8 +- tests/tbf/TbfTest.err | 1750 ++++++++++++++++++++++++------------------------- 6 files changed, 980 insertions(+), 1015 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 15:48:56 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:48:56 GMT Subject: libosmocore.git branch master updated. 0.10.2-75-g6cb9e7d8 Message-ID: <201712201548.vBKFmuwk062576@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 6cb9e7d8981e127161f14f22ad9271252c531aec (commit) via e094157e125a70b9a384ba3cec01261624f4eb59 (commit) from 58a5665ecb72b2b4e2a9e33dde83d12060c41b4a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=6cb9e7d8981e127161f14f22ad9271252c531aec commit 6cb9e7d8981e127161f14f22ad9271252c531aec Author: Philipp Maier Date: Fri Dec 15 09:35:21 2017 +0100 libosmocodec: add FR bit offset definitions This change defines the GSM FR bit positions as described in RFC 3551, which will be used by further ECU (Error Correction Unit) implementation. Change-Id: I1d0a198af0f8dd1f690b5a81f5c9eb92c43aefed http://cgit.osmocom.org/libosmocore/commit/?id=e094157e125a70b9a384ba3cec01261624f4eb59 commit e094157e125a70b9a384ba3cec01261624f4eb59 Author: Vadim Yanitskiy Date: Sat Dec 16 01:39:48 2017 +0700 libosmocodec: add FR/HR/EFR frame length definitions There are some projects, such as OsmoBTS and OsmocomBB, which are dealing with raw TCH payloads, so they need to have the FR/HR/EFR frame length defined. At the moment, each project defines them itself. Let's share these definitions. Change-Id: Ib19dd1bf81712d034157f9ce061008be0000ef38 ----------------------------------------------------------------------- Summary of changes: include/Makefile.am | 1 + include/osmocom/codec/codec.h | 7 + include/osmocom/codec/gsm610_bits.h | 272 ++++++++++++++++++++++++++++++++++++ 3 files changed, 280 insertions(+) create mode 100644 include/osmocom/codec/gsm610_bits.h hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 20 15:50:58 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:50:58 GMT Subject: libosmocore.git branch master updated. 0.10.2-77-ga5e2162c Message-ID: <201712201550.vBKFowgo063918@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via a5e2162cf16f2e9208b60431bc4799b4bcdd4b42 (commit) via 3da9aa6b6792407d57816ec4a4cdfd0b4b3434b8 (commit) from 6cb9e7d8981e127161f14f22ad9271252c531aec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a5e2162cf16f2e9208b60431bc4799b4bcdd4b42 commit a5e2162cf16f2e9208b60431bc4799b4bcdd4b42 Author: Neels Hofmeyr Date: Sat Dec 16 01:18:53 2017 +0100 ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET REPLY' and 'TRAP' as appropriate. Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 http://cgit.osmocom.org/libosmocore/commit/?id=3da9aa6b6792407d57816ec4a4cdfd0b4b3434b8 commit 3da9aa6b6792407d57816ec4a4cdfd0b4b3434b8 Author: Neels Hofmeyr Date: Tue Sep 26 14:21:44 2017 +0200 ctrl: tighten CTRL input parsing Validate that incoming CTRL commands... - have decimal IDs, - return error on trailing characters, - have invalid characters in variable identifiers, - send detailed error messages as reply to the requestor. Adjust ctrl_test.{c,ok}, which best show the change in behavior. Message handling causes log messages on stderr; previously, stderr was empty. Add '[ignore]' in testsuite.at so that the nonempty stderr doesn't cause test failures. Change-Id: I96a9b6b6a3a5e0b80513aa9eaa727ae8c9c7d7a1 ----------------------------------------------------------------------- Summary of changes: src/ctrl/control_cmd.c | 104 ++++++++++++++++++++++++++++++++++++--------- tests/ctrl/ctrl_test.c | 110 ++++++++++++++++++++---------------------------- tests/ctrl/ctrl_test.ok | 76 ++++++++++++--------------------- tests/testsuite.at | 2 +- 4 files changed, 159 insertions(+), 133 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 20 15:51:43 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:51:43 GMT Subject: openbsc.git branch master updated. 1.0.0-9-ge44a5687c Message-ID: <201712201551.vBKFphdX064371@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via e44a5687c4728a3ef1f730ec7349cef135cf174a (commit) from 5825e5cfb245f32a409c7784e51fb1e774adf799 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=e44a5687c4728a3ef1f730ec7349cef135cf174a commit e44a5687c4728a3ef1f730ec7349cef135cf174a Author: Max Date: Tue Dec 19 13:10:07 2017 +0100 Fix tests after rate_ctr change Recent change lin libosmocore disallow registering rate_ctr with the same name and indexing multiple times. To accommodate to this: * allocate network struct once and use it for all tests * free bts struct after each test This is a backport of 4ab7268a902af24fcd4870148b709fed4fbf900c from OsmoBSC. Change-Id: Ic5fab86bca617cabcd59484066975e17ab2320b6 Related: OS#2757 ----------------------------------------------------------------------- Summary of changes: openbsc/tests/channel/channel_test.c | 35 ++++++------- openbsc/tests/gsm0408/gsm0408_test.c | 99 ++++++++++++++++++----------------- openbsc/tests/gsm0408/gsm0408_test.ok | 6 +++ 3 files changed, 73 insertions(+), 67 deletions(-) hooks/post-receive -- Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN) From gitosis at osmocom.org Wed Dec 20 15:55:05 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:55:05 GMT Subject: libosmocore.git branch master updated. 0.10.2-78-g901c1978 Message-ID: <201712201555.vBKFt5mC066582@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 901c197881f5e0ab690f959b57abc755ab101e97 (commit) from a5e2162cf16f2e9208b60431bc4799b4bcdd4b42 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=901c197881f5e0ab690f959b57abc755ab101e97 commit 901c197881f5e0ab690f959b57abc755ab101e97 Author: Neels Hofmeyr Date: Fri Nov 17 01:17:47 2017 +0100 jenkins: add 'make V=1' for more verbose build logs In the logs, it is nice to see whether e.g. sanitize or -Werror args actually made it to the gcc command line. With V=1 we see the complete command invocations that would be hidden otherwise. Change-Id: Ie89b1c39489ba80fb47716f4c747f2c85960e32e ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 20 15:55:30 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:55:30 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-21-gf898d6b Message-ID: <201712201555.vBKFtUlX066908@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via f898d6bc106d7e9522888300484a0bc732999628 (commit) from 2c56f6d4540cd5288ab24ef35f95764bb73d2c79 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=f898d6bc106d7e9522888300484a0bc732999628 commit f898d6bc106d7e9522888300484a0bc732999628 Author: Neels Hofmeyr Date: Tue Dec 19 03:12:08 2017 +0100 fix 3 compiler warnings in ranap_common.c ranap_common.c:282 col 45: warning: format ???%u??? expects argument of type ???unsigned int???, but argument 4 has type ???RANAP_CauseNon_Standard_t {aka const long int}??? [-Wformat=] ranap_common.c:527 col 15: warning: implicit declaration of function ???asn1str_to_u16???; did you mean ???asn_strtol???? [-Wimplicit-function-declaration] ranap_common.c:546 col 11: warning: unused variable ???addr??? [-Wunused-variable] Change-Id: I0b399e78fa7b202a36e5e4be86f338c0ceb9823e ----------------------------------------------------------------------- Summary of changes: src/ranap_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Wed Dec 20 15:57:15 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 15:57:15 GMT Subject: osmo-hlr.git branch master updated. 0.1.0-23-g84c2f43 Message-ID: <201712201557.vBKFvFO2068145@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 84c2f43d00af200eb2b1a58a566e3ed69e767904 (commit) from 63f68ccc4cdee6e8de2e4e63d456d4c340af5b51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=84c2f43d00af200eb2b1a58a566e3ed69e767904 commit 84c2f43d00af200eb2b1a58a566e3ed69e767904 Author: Neels Hofmeyr Date: Thu Dec 14 20:58:54 2017 +0100 fix debug log: put 'deriving 2G from 3G' in proper place Don't log "deriving 2G from 3G" when we're actually calculating separately; log it when we're actually deriving from 3G. Add log "calculating 2G separately" in the right place. The test output changes show that each test said "separate 2G" at the top while logging "deriving 2G from 3G" further down, which was obviously wrong. Change-Id: I6679d7ef8fdcae39a0c2aff7ac638e63dddb10dc ----------------------------------------------------------------------- Summary of changes: src/auc.c | 3 ++- tests/auc/auc_test.err | 13 +++++++++++-- tests/auc/auc_ts_55_205_test_sets.err | 19 +++++++++++++++++++ 3 files changed, 32 insertions(+), 3 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 16:00:27 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:00:27 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-22-gade7e8b Message-ID: <201712201600.vBKG0RDq070597@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via ade7e8b19bf423e9090dca67c906bc4bf8242df2 (commit) from f898d6bc106d7e9522888300484a0bc732999628 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=ade7e8b19bf423e9090dca67c906bc4bf8242df2 commit ade7e8b19bf423e9090dca67c906bc4bf8242df2 Author: Neels Hofmeyr Date: Wed Dec 20 02:33:44 2017 +0100 hnbgw: use proper talloc ctx for vty telnet init Change-Id: I355c6e5489f24566612528cd679c5cab21eed008 ----------------------------------------------------------------------- Summary of changes: src/hnbgw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Wed Dec 20 16:01:15 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:01:15 GMT Subject: libosmocore.git branch master updated. 0.10.2-79-g074478dc Message-ID: <201712201601.vBKG1FP1071173@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 074478dc619a75dc29c78b9b148d960c4605d99c (commit) from 901c197881f5e0ab690f959b57abc755ab101e97 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=074478dc619a75dc29c78b9b148d960c4605d99c commit 074478dc619a75dc29c78b9b148d960c4605d99c Author: Neels Hofmeyr Date: Sat Dec 9 05:54:17 2017 +0100 logging vty: tweak general 'logging' command doc 'logging' is not only for terminals, also for stderr and other log targets. Change-Id: If1ee59c7d1073502259b7d60008206ac3d8e87a3 ----------------------------------------------------------------------- Summary of changes: include/osmocom/vty/logging.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Wed Dec 20 16:03:36 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:03:36 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-25-gaa8d48c Message-ID: <201712201603.vBKG3aHv072479@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via aa8d48cbe000f1adbed63775254fbc7ab470335b (commit) via 1eb19cf690b473307eda73ce0c2dbcb75019c166 (commit) via ee03876dd171375d827cbec6d3c24d8ad9128671 (commit) from ade7e8b19bf423e9090dca67c906bc4bf8242df2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=aa8d48cbe000f1adbed63775254fbc7ab470335b commit aa8d48cbe000f1adbed63775254fbc7ab470335b Author: Philipp Maier Date: Tue Dec 19 17:48:38 2017 +0100 ranap_msg_factory: remove unusued variable remove variable i in ranap_new_msg_sec_mod_compl() as it is not used (compiler warning) Change-Id: I93d9e95109fb78bc6cc161745b9e14de8b623d4f http://cgit.osmocom.org/osmo-iuh/commit/?id=1eb19cf690b473307eda73ce0c2dbcb75019c166 commit 1eb19cf690b473307eda73ce0c2dbcb75019c166 Author: Philipp Maier Date: Tue Dec 19 17:46:36 2017 +0100 ranap_msg_factory: check IE encoder return codes in many functions, the returncode (rc) from the IE encoder functions is not checked. Add a return code check and log error message (like it is already done in the functions which already check the return code) Change-Id: I592c0794a94c50fde5c574b1e9bc581eb28af4ae http://cgit.osmocom.org/osmo-iuh/commit/?id=ee03876dd171375d827cbec6d3c24d8ad9128671 commit ee03876dd171375d827cbec6d3c24d8ad9128671 Author: Philipp Maier Date: Tue Dec 19 17:42:36 2017 +0100 iu: iu_helpers: add functions to decode ip/port from rab-ass add ranap_transp_assoc_decode() to decode the port information from an RANAP_IuTransportAssociation_t field. add ranap_transp_layer_addr_decode() to decode the ip-address from an RANAP_TransportLayerAddress_t field. Change-Id: I3c1a0455c5f25cae41ee19229d6daf299e023062 ----------------------------------------------------------------------- Summary of changes: include/osmocom/ranap/iu_helpers.h | 6 +++++ src/iu_helpers.c | 53 +++++++++++++++++++++++++++++++++++++- src/ranap_msg_factory.c | 49 +++++++++++++++++++++++++++++------ 3 files changed, 99 insertions(+), 9 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Wed Dec 20 16:03:45 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:03:45 GMT Subject: osmo-python-tests.git branch master updated. e5731e03b6bc1af147203d35c1d4112c6a7e8e94 Message-ID: <201712201603.vBKG3jaV072642@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via e5731e03b6bc1af147203d35c1d4112c6a7e8e94 (commit) via be76f4d8a82440ab019caf237d1b734209f1aae3 (commit) from 150a6eac9be9eae13b9eb5fa287c925f0cf19ab2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=e5731e03b6bc1af147203d35c1d4112c6a7e8e94 commit e5731e03b6bc1af147203d35c1d4112c6a7e8e94 Author: Neels Hofmeyr Date: Tue Dec 19 14:48:29 2017 +0100 README: mention osmo_interact_* and osmo_verify_transcript_* Move the libs/scripts that they (possibly) replace below the new additions and mention that they are superseded. Change-Id: Ic50e15d6cb6e94b6e171d954d75b94e09b22d548 http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=be76f4d8a82440ab019caf237d1b734209f1aae3 commit be76f4d8a82440ab019caf237d1b734209f1aae3 Author: Neels Hofmeyr Date: Tue Dec 19 13:46:57 2017 +0100 add cmdline doc to osmo_interact_* and osmo_verify_* The tools are so far badly under-documented. Alleviate that by comprehensive description and examples shown by -h option output. Hint at that from the README. Change-Id: I94dcad257558b917cb54fc877122594cd164f496 ----------------------------------------------------------------------- Summary of changes: README | 11 +++++-- osmopy/osmo_interact/common.py | 9 +++--- osmopy/osmo_interact/ctrl.py | 64 +++++++++++++++++++++++++++++++++++-- osmopy/osmo_interact/vty.py | 72 ++++++++++++++++++++++++++++++++++++++++-- 4 files changed, 145 insertions(+), 11 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 16:04:05 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:04:05 GMT Subject: osmo-python-tests.git branch master updated. 4c283e4f4a071bdf42b6877d412775a3009e0ce4 Message-ID: <201712201604.vBKG45e5073032@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 4c283e4f4a071bdf42b6877d412775a3009e0ce4 (commit) from e5731e03b6bc1af147203d35c1d4112c6a7e8e94 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=4c283e4f4a071bdf42b6877d412775a3009e0ce4 commit 4c283e4f4a071bdf42b6877d412775a3009e0ce4 Author: Neels Hofmeyr Date: Tue Dec 19 14:49:13 2017 +0100 README: mention twisted_ipa.py in scripts section, not as lib Change-Id: Ie536d61c5af89a530533b22d8ecab1c804a38289 ----------------------------------------------------------------------- Summary of changes: README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 16:04:25 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:04:25 GMT Subject: libosmo-sccp.git branch master updated. 0.8.1-27-g10d4815 Message-ID: <201712201604.vBKG4PoF073248@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 10d4815bb1b4b548ec0bc97611b2e7ac45e0ebc5 (commit) from 6cd8d1243711f4de2f1314c7b87b972572cdec4e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=10d4815bb1b4b548ec0bc97611b2e7ac45e0ebc5 commit 10d4815bb1b4b548ec0bc97611b2e7ac45e0ebc5 Author: Pau Espin Pedrol Date: Fri Nov 17 12:57:25 2017 +0100 ss7: Re-bind xUA server socket after setting new IP In osmo-stp, cmd "local-ip" inside node "listen m3ua 2905" was actually not being applied, because the server was created + bound at "listen" command time using NULL as IP, and at "local-ip" time the IP was changed but the server was not re-bound using the new IP, so it kept listening at 0.0.0.0. With this patch, we defer binding the socket to "local-ip" cmd time, after the IP has been applied. As a result, if no "local-ip" command is provided, then the bind never happens, which means it is now mandatory that users of osmo_ss7_xua_server_create API not using osmo_ss7_xua_server_set_local_host call new provided API osmo_ss7_xua_server_bind. Another new API osmo_ss7_bind_all_instances is provided to easily make sure all servers are bound after configuration process. This is specially important for servers which doesn't contain the "local-ip" parameter. Users of osmo_sccp_simple_server API are not affected by this change, and they not requrie to call any new API. Furthermore, using osmo_ss7_xua_server_bind in VTY code ensures the xUA server is automatically bound to the new address if the operator changes the "local-ip" cmd at runtime. Related: OS#2647 Change-Id: I79738963d633bec70705ff159c5b2127cd498aa2 ----------------------------------------------------------------------- Summary of changes: include/osmocom/sigtran/osmo_ss7.h | 5 ++++ src/osmo_ss7.c | 59 ++++++++++++++++++++++++++++++++------ src/osmo_ss7_vty.c | 4 +++ src/sccp_user.c | 5 ++++ stp/stp_main.c | 2 ++ 5 files changed, 66 insertions(+), 9 deletions(-) hooks/post-receive -- SCCP Library From gitosis at osmocom.org Wed Dec 20 16:06:06 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:06:06 GMT Subject: osmo-python-tests.git branch master updated. 379fb9783b1cfa1563a49cdf5a65c7b317a5e967 Message-ID: <201712201606.vBKG66PW074645@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 379fb9783b1cfa1563a49cdf5a65c7b317a5e967 (commit) from 4c283e4f4a071bdf42b6877d412775a3009e0ce4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=379fb9783b1cfa1563a49cdf5a65c7b317a5e967 commit 379fb9783b1cfa1563a49cdf5a65c7b317a5e967 Author: Max Date: Mon Dec 18 15:06:39 2017 +0100 Ignore compilation byproducts Change-Id: Ic04a1b9411b851547ef7ce7a9b562cb290081ca9 ----------------------------------------------------------------------- Summary of changes: .gitignore | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Wed Dec 20 16:07:38 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 16:07:38 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-46-ge5a082d Message-ID: <201712201607.vBKG7cx8075429@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via e5a082d64a4abe43d3457be46ecc07df4cc5a144 (commit) from 37c45e3998fca240b5266abd3ac883d0a35bab50 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=e5a082d64a4abe43d3457be46ecc07df4cc5a144 commit e5a082d64a4abe43d3457be46ecc07df4cc5a144 Author: Pau Espin Pedrol Date: Fri Dec 15 15:55:04 2017 +0100 ggsn_vty.c: Print ipv6 link-local cmd when writing config to file Previous commit added the ipv6 link-local vty cmd but forgot to add code to print its value in config_write_apn. Fixes: 37c45e3998fca240b5266abd3ac883d0a35bab50 Change-Id: I08aeaa98d6dc318b7e9740d837ba4ac48cd7051c ----------------------------------------------------------------------- Summary of changes: ggsn/ggsn_vty.c | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Wed Dec 20 20:02:25 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Wed, 20 Dec 2017 20:02:25 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-22-g59e4a4f Message-ID: <201712202002.vBKK2PQB002825@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 59e4a4fee11a966d2c72209a0e23087e20d5103d (commit) via ee5be3a0095b4bae430032d35e3ad0716eff34ab (commit) from c21f007277713b15d9a48d0bcc6f28aa51b4f908 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=59e4a4fee11a966d2c72209a0e23087e20d5103d commit 59e4a4fee11a966d2c72209a0e23087e20d5103d Author: Max Date: Wed Dec 20 18:01:55 2017 +0100 TBF: add N3101 counter Properly reset the counter when receiving valid RLCMAC block and update it when no data is received as per 3GPP TS 44.060 ??8.1.1.1 Change-Id: I2f79c6153dc4073c9d293b2824979e6381576682 Fixes: OS#2407 http://cgit.osmocom.org/osmo-pcu/commit/?id=ee5be3a0095b4bae430032d35e3ad0716eff34ab commit ee5be3a0095b4bae430032d35e3ad0716eff34ab Author: Max Date: Wed Dec 20 17:31:13 2017 +0100 TBF: implement independent T31xx timers Previously TBF got single timer so the pending timer was automatically cancelled when new one was scheduled. Let's make it more robust by implementing independent T31 xx timers from 3GPP TS 44.060 ??13.2 with corresponding start/stop functions and counters. The semantics of the timers is preserved as before: pending timers are restarted unconditionally. It might be neecessary to change this later on after spec review. N. B. T0: used for assign/reject timeouts, have to be properly attributed and documented first. Change-Id: I0305873ca47534f53441247217881da59625e1f7 Related: OS#2407 ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 21 ++++- src/tbf.cpp | 220 +++++++++++++++++++++++++++++++++++--------------- src/tbf.h | 27 ++++++- src/tbf_dl.cpp | 14 ++-- src/tbf_ul.cpp | 2 +- tests/tbf/TbfTest.cpp | 4 +- 6 files changed, 209 insertions(+), 79 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Thu Dec 21 11:40:50 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 11:40:50 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-23-g1714aea Message-ID: <201712211140.vBLBeoVC093650@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 1714aeaa675e129736d53fecf8ff91f54c87446a (commit) from 59e4a4fee11a966d2c72209a0e23087e20d5103d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=1714aeaa675e129736d53fecf8ff91f54c87446a commit 1714aeaa675e129736d53fecf8ff91f54c87446a Author: Max Date: Thu Dec 21 11:19:39 2017 +0100 Fix warnings Fix warnings detected by compiler and coverity scan. Change-Id: If463c7f8769e18d3df74837f0cb0f545cca9b23e Fixes: CID181479 ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Thu Dec 21 11:49:57 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 11:49:57 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-26-g66d6d76 Message-ID: <201712211149.vBLBnvwU098037@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 66d6d760aab222c91bec5134c228ffc13f463235 (commit) from aa8d48cbe000f1adbed63775254fbc7ab470335b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=66d6d760aab222c91bec5134c228ffc13f463235 commit 66d6d760aab222c91bec5134c228ffc13f463235 Author: Neels Hofmeyr Date: Wed Dec 20 05:25:02 2017 +0100 hnbgw: hnb info: record MCC, MNC, show on 'show hnb' Before, MCC and MNC were always reported as zero, now the output of 'show hnb all' looks like: OsmoHNBGW> show hnb all HNB "000295-0000154153 at ap.ipaccess.com" MCC 901 MNC 70 LAC 11111 RAC 99 SAC 65535 CID 1048575 HNBAP ID 0 RUA ID 0 Change-Id: Iae094b36fa1cf18e07ed33914b9425368d7cd34b ----------------------------------------------------------------------- Summary of changes: src/Makefile.am | 2 +- src/hnbgw_hnbap.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Thu Dec 21 14:15:34 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 14:15:34 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-24-g327e121 Message-ID: <201712211415.vBLEFYGD067680@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 327e121a0f2b1e816cc59d1337e6f2034553f2b8 (commit) from 1714aeaa675e129736d53fecf8ff91f54c87446a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=327e121a0f2b1e816cc59d1337e6f2034553f2b8 commit 327e121a0f2b1e816cc59d1337e6f2034553f2b8 Author: Max Date: Tue Nov 21 13:01:19 2017 +0100 Add function to get max supported MS class It's useful for allocation tests. Change-Id: I31d503af700ec3364042ff7e661710953cacf9f8 Related: OS#2282 ----------------------------------------------------------------------- Summary of changes: src/mslot_class.c | 5 +++++ src/mslot_class.h | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Thu Dec 21 17:57:25 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:57:25 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-25-gb2f0b62 Message-ID: <201712211757.vBLHvPXe074084@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via b2f0b62cd4603b8aa12172423e9c32408e048560 (commit) from 327e121a0f2b1e816cc59d1337e6f2034553f2b8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=b2f0b62cd4603b8aa12172423e9c32408e048560 commit b2f0b62cd4603b8aa12172423e9c32408e048560 Author: Max Date: Thu Dec 21 17:27:34 2017 +0100 Add --enable-sanitize configure option Change-Id: Idb2c1d6057012ed2f032e7504387a0767d02d75b ----------------------------------------------------------------------- Summary of changes: configure.ac | 9 +++++++++ 1 file changed, 9 insertions(+) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Thu Dec 21 17:57:46 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:57:46 GMT Subject: osmo-bts.git branch master updated. 0.7.0-34-ga11d8e9 Message-ID: <201712211757.vBLHvkRN074262@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via a11d8e95ee62b3ab0918b6f28bca405a645d04ad (commit) from 0bac3efc176e49eb22e4e9a0ede55143efc0e64f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=a11d8e95ee62b3ab0918b6f28bca405a645d04ad commit a11d8e95ee62b3ab0918b6f28bca405a645d04ad Author: Max Date: Thu Dec 21 17:29:53 2017 +0100 Add --enable-sanitize configure option Change-Id: I4e31e20ef2361c8f251f3ab04a0ac86e23d2e8a1 ----------------------------------------------------------------------- Summary of changes: configure.ac | 9 +++++++++ 1 file changed, 9 insertions(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...) From gitosis at osmocom.org Thu Dec 21 17:57:58 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:57:58 GMT Subject: libosmo-netif.git branch master updated. 0.1.1-11-g3f93cae Message-ID: <201712211757.vBLHvw3u074439@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via 3f93caea6e404618f2da49410e2f06e40aaac83e (commit) from 3173ca7ac7e9c6c9e2ff9bb80a9d27a3c10c7608 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=3f93caea6e404618f2da49410e2f06e40aaac83e commit 3f93caea6e404618f2da49410e2f06e40aaac83e Author: Max Date: Thu Dec 21 17:03:46 2017 +0100 Enable sanitize for CI tests Change-Id: I3a888a415698db5a11d74422f7ccb2d94126f56e ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom network interface library From gitosis at osmocom.org Thu Dec 21 17:58:38 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:58:38 GMT Subject: osmo-ggsn.git branch master updated. 1.1.0-47-g1c8c626 Message-ID: <201712211758.vBLHwcaV075066@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 1c8c62667f8270cdd30d5a49d01ecab892b655e9 (commit) from e5a082d64a4abe43d3457be46ecc07df4cc5a144 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=1c8c62667f8270cdd30d5a49d01ecab892b655e9 commit 1c8c62667f8270cdd30d5a49d01ecab892b655e9 Author: Max Date: Thu Dec 21 17:12:46 2017 +0100 Enable sanitize for CI tests Change-Id: I7559807d54bec5da45ea5c41b10d396d992cb1b7 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- The OpenGGSN project From gitosis at osmocom.org Thu Dec 21 17:58:46 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:58:46 GMT Subject: libsmpp34.git branch master updated. 1.12.0-13-g4f3ee2a Message-ID: <201712211758.vBLHwkmg075164@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom fork of the Open SMPP 3.4 library". The branch, master has been updated via 4f3ee2add5f9fbd74358bb8d329f569db4e5aee7 (commit) from 7c2232e0ffd8751376d354fb95a86467d68d3bc8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libsmpp34/commit/?id=4f3ee2add5f9fbd74358bb8d329f569db4e5aee7 commit 4f3ee2add5f9fbd74358bb8d329f569db4e5aee7 Author: Max Date: Thu Dec 21 17:07:20 2017 +0100 Enable sanitize for CI tests Change-Id: Ibf070228e439ddb3be9c6570f963ac0db05d1c9c ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom fork of the Open SMPP 3.4 library From gitosis at osmocom.org Thu Dec 21 17:58:56 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:58:56 GMT Subject: libosmo-sccp.git branch master updated. 0.8.1-28-g1aa2a42 Message-ID: <201712211758.vBLHwumA075311@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 1aa2a42eae63eaf591306e5a5021fc5453de6da9 (commit) from 10d4815bb1b4b548ec0bc97611b2e7ac45e0ebc5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=1aa2a42eae63eaf591306e5a5021fc5453de6da9 commit 1aa2a42eae63eaf591306e5a5021fc5453de6da9 Author: Max Date: Thu Dec 21 17:05:35 2017 +0100 Enable sanitize for CI tests Change-Id: Ida8cfcd9a9f86e65273452afa051381bc0c16421 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- SCCP Library From gitosis at osmocom.org Thu Dec 21 17:59:09 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 21 Dec 2017 17:59:09 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-26-g406a1f0 Message-ID: <201712211759.vBLHx9cW075622@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 406a1f0acf63d88c197d1d29221294f9e27f774d (commit) from b2f0b62cd4603b8aa12172423e9c32408e048560 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=406a1f0acf63d88c197d1d29221294f9e27f774d commit 406a1f0acf63d88c197d1d29221294f9e27f774d Author: Max Date: Thu Dec 21 17:34:19 2017 +0100 Enable sanitize for CI test Change-Id: Ia33ffb9b25df587706367bc24925cf9cead3b9a0 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Fri Dec 22 16:30:19 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 22 Dec 2017 16:30:19 GMT Subject: libosmocore.git branch master updated. 0.10.2-81-gf360b42c Message-ID: <201712221630.vBMGUJr6013901@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via f360b42ca11bdad01036b95ca1983533ed35c542 (commit) via aafc27ce37337bdca4a8e9db4e186b808585070a (commit) from 074478dc619a75dc29c78b9b148d960c4605d99c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=f360b42ca11bdad01036b95ca1983533ed35c542 commit f360b42ca11bdad01036b95ca1983533ed35c542 Author: Harald Welte Date: Fri Dec 22 16:43:24 2017 +0100 control_if: Close control connection socket/fd on read/write == 0 When read() or write() system calls return '0' on a stream socket, it means that the connection has been closed ("EOF"). We must accordingly close this socket and remove all related state. Before this patch, every new CTRL connection would introduce a leak of both some memory/state, as well as a file descriptor :( Change-Id: I4fb70e5f123b37dece29f156c5f430c875e7cbaf http://cgit.osmocom.org/libosmocore/commit/?id=aafc27ce37337bdca4a8e9db4e186b808585070a commit aafc27ce37337bdca4a8e9db4e186b808585070a Author: Harald Welte Date: Mon Nov 20 20:22:22 2017 +0100 timer: fixup whitespace issues Change-Id: Ic0c8fc407a45ff4b0d3da1d3e4fdf8885b5bca9b ----------------------------------------------------------------------- Summary of changes: src/ctrl/control_if.c | 10 +++++++++- src/timer.c | 6 +++--- 2 files changed, 12 insertions(+), 4 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Fri Dec 22 18:13:39 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 22 Dec 2017 18:13:39 GMT Subject: libosmocore.git branch master updated. 0.10.2-83-g5995281f Message-ID: <201712221813.vBMIDdxw070648@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 5995281fd685eca0e7433b7467d37040febcbebc (commit) via 29e2798ec588c3503a0c1c2828fa371da529995a (commit) from f360b42ca11bdad01036b95ca1983533ed35c542 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=5995281fd685eca0e7433b7467d37040febcbebc commit 5995281fd685eca0e7433b7467d37040febcbebc Author: Harald Welte Date: Fri Dec 22 18:03:44 2017 +0100 CTRL: Ensure peer/connection info is always printed the same way Now that we use osmo_sock_get_name() to print connection information at disconnect, let's use the same also at accept() time. Furthermore, let's call it CTRL connection everywhere for consistency. Change-Id: I33ee7d0ed853c5b2a4ae4e8ef945f8f27753cdea http://cgit.osmocom.org/libosmocore/commit/?id=29e2798ec588c3503a0c1c2828fa371da529995a commit 29e2798ec588c3503a0c1c2828fa371da529995a Author: Harald Welte Date: Fri Dec 22 16:47:18 2017 +0100 control_if: Log the disconnect of a CTRL client We are logging new CTRL connections at LOGL_INFO, so we should also log disconnects for symmetry. Change-Id: Id30aa76a5a3dab32d6b4121ce6fdf56d71dfc2ba ----------------------------------------------------------------------- Summary of changes: src/ctrl/control_if.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications From gitosis at osmocom.org Fri Dec 22 18:14:32 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 22 Dec 2017 18:14:32 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-27-g20c7c46 Message-ID: <201712221814.vBMIEWPD071192@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 20c7c46bceac4969e420f2b0dd89448327914971 (commit) from 406a1f0acf63d88c197d1d29221294f9e27f774d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=20c7c46bceac4969e420f2b0dd89448327914971 commit 20c7c46bceac4969e420f2b0dd89448327914971 Author: Max Date: Fri Dec 22 14:20:05 2017 +0100 Add tests for pcu_lsb() This utility functions is used by TBF allocation routines and only tested indirectly through allocation test. Let's add proper exhaustive test which checks all uint8_t values. This also requires adding missing include to pcu_utils.h Change-Id: If08a7f0d31f0e5ad8a5efa5885880aed19c329ab ----------------------------------------------------------------------- Summary of changes: src/pcu_utils.h | 4 + tests/types/TypesTest.cpp | 18 ++++ tests/types/TypesTest.ok | 257 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 279 insertions(+) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Tue Dec 19 22:24:35 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 19 Dec 2017 22:24:35 GMT Subject: wireshark.git branch laforge/gsup created. 3bf54bd2874f0858ff3c2ff154873595df87772d Message-ID: <201712192224.vBJMOZZ3015811@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "wireshark with Osmocom specific dissectors". The branch, laforge/gsup has been created at 3bf54bd2874f0858ff3c2ff154873595df87772d (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/wireshark/commit/?id=3bf54bd2874f0858ff3c2ff154873595df87772d commit 3bf54bd2874f0858ff3c2ff154873595df87772d Author: Harald Welte Date: Tue Dec 19 23:22:23 2017 +0100 Dissector for the Osmocom GSUP Protocol The Osmocom GSUP protocol is a light-weight alternative to the classic GSM MAP protocol. It operatest between (MSC|SGSN) and HLR. Change-Id: I954c7e332dce3a8855f7f4ace0b878f66da6f02e http://cgit.osmocom.org/wireshark/commit/?id=12e25c1a86d5a4b67213af89fa3b2d6a0bcaa634 commit 12e25c1a86d5a4b67213af89fa3b2d6a0bcaa634 Author: Alexis La Goutte Date: Tue Dec 19 15:08:03 2017 +0000 plugin: fix extra ';' outside of a function [-Wextra-semi] Change-Id: I923e4a4f84e8786523333daf372fc5d7cc7ad729 Reviewed-on: https://code.wireshark.org/review/24897 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=106e0b4ee0b5bac403a174aff7266d17c7b1b43e commit 106e0b4ee0b5bac403a174aff7266d17c7b1b43e Author: Dario Lombardo Date: Tue Dec 19 10:31:44 2017 +0100 Qt: add initializers (CID: 1426703). Change-Id: Ib75685a099449672b55d63b647fd0f579ad1e5f6 Reviewed-on: https://code.wireshark.org/review/24893 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c9b6887d8469251b15204dffcd7105490b574e27 commit c9b6887d8469251b15204dffcd7105490b574e27 Author: Stig Bj??rlykke Date: Tue Dec 19 09:40:08 2017 +0100 wslua: Fix logger after g6a5e90f2 The Qt log output changes in g6a5e90f2 changed the Qt message handler to use g_log. Lua logging already used g_log. The Qt variant of funnel logger, which is used by Lua as g_log backend, is currently using qDebug and this gives recursive calls to g_log and thus an assert. Rewrite the lua logging to not use g_log. Change-Id: Icf4f0022a11cb32d2b4f413f76d946f2506e283d Reviewed-on: https://code.wireshark.org/review/24888 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5b596fa871b58948dacd18859dad61e692ab973e commit 5b596fa871b58948dacd18859dad61e692ab973e Author: AndersBroman Date: Tue Dec 19 09:47:21 2017 +0100 [SIP] Add dissection of oc-seq as time stamp. Change-Id: I0273f8bff7693a7dc7416932649c083c360bc098 Reviewed-on: https://code.wireshark.org/review/24890 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4db038aa28023867dcdae403d79b0a0b5506e991 commit 4db038aa28023867dcdae403d79b0a0b5506e991 Author: Roland Knall Date: Tue Dec 19 10:06:13 2017 +0100 Qt: Fix sorting of enabled protocols description Change-Id: Ifa7b6e61927615c342839b6c2e7d012198a5f939 Reviewed-on: https://code.wireshark.org/review/24892 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=0d6eb9631f26176d00d6bef69569d1d2911bd233 commit 0d6eb9631f26176d00d6bef69569d1d2911bd233 Author: Michael Mann Date: Sat Dec 16 21:51:33 2017 -0500 Convert Enabled protocols dialog to use model. Change-Id: I618df2f2608adcd1be5da02262c5296e4d86cfba Reviewed-on: https://code.wireshark.org/review/24866 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=6e4a6364154f4e880f2bb6111d6759e51a686bb4 commit 6e4a6364154f4e880f2bb6111d6759e51a686bb4 Author: Michael Mann Date: Mon Dec 18 16:42:12 2017 -0500 Bugfix capture_info_open() folded into ui/capture.c Id302e88bed4da8b9b457049fb78b0bc7d7ffabe3 forgot to add brackets around functionality Change-Id: I3aa2ed6e927a6daca93846650645d76b0d62043e Reviewed-on: https://code.wireshark.org/review/24885 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7cb6255f17b90863d863ad995d7bca5921b7c517 commit 7cb6255f17b90863d863ad995d7bca5921b7c517 Author: Stig Bj??rlykke Date: Mon Dec 18 21:02:52 2017 +0100 Qt: Resolve duplicate keyboard shortcuts Two Edit->Copy methods are using the same keyboard shortcut as other functionality: 1. Ctrl+Shift+D is used for "Copy this item's description" and "Ignore All Displayed packets" 2. Ctrl+Shift+F is used for "Copy this item's field name" and "Reload as File Format/Capture" Resolve this by changing the Copy methods to use Ctrl+Alt+Shift as modifier. Add a keyboard shortcut for "Copy all visible items" while here. Change-Id: I0d963501055e63963d93e211f592aa9e82801d3c Reviewed-on: https://code.wireshark.org/review/24884 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9f7b8713fa8286611e84a68f82adc2d494b21173 commit 9f7b8713fa8286611e84a68f82adc2d494b21173 Author: Stig Bj??rlykke Date: Mon Dec 18 10:25:03 2017 +0100 Qt: Add Collapse Subtrees This item is missing from the Qt port. Change-Id: Iacc18a7c2eb2368d6566622788a4e900868d446e Reviewed-on: https://code.wireshark.org/review/24879 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5ebc3277ed98c39b24d971470d1aea0efe042351 commit 5ebc3277ed98c39b24d971470d1aea0efe042351 Author: Florian Bezold Date: Thu Dec 7 09:00:13 2017 +0100 androiddump: Fix adb tcpdump PTY CR/LF handling Devices running Android >= 7 have a different adb shell handling than before: - Before Android 7, adb always runs shell commands in a PTY (pseudoterminal), which automatically converts all \n to \r\n - Since Android 7, adb no longer uses a PTY if a command is directly started (like 'tcpdump' in our case). The original androiddump code reversed the PTY \r\n handling as for older devices. Commit 66507b9 for bug 13510 removed that which supported newer devices while breaking all older devices. This fix tries to support both by first trying to use the new "shell,raw:" adb command syntax. If that succeeds, adb/device must support non-PTY shells and we don't reverse any \r\n. If that fails, it's most likely an older device, and we fall back to the original "shell:" command and enable \r\n reversal. (To prevent misleading error popups in Wireshark, the warning log in adb_send when the first attempt fails is changed to a debug log). Ping-Bug: 13510 Change-Id: I7e0a4f594ebe5dde682cceb667330459337a0c9c Reviewed-on: https://code.wireshark.org/review/24721 Reviewed-by: Mikael Kanstrup Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=09ad8456906172c384a01df49a7eba5716ebfa8e commit 09ad8456906172c384a01df49a7eba5716ebfa8e Author: AndersBroman Date: Mon Dec 18 10:18:05 2017 +0100 [SIP] Make a filter for Overload Control Value. Change-Id: I8ee552d331388a1fa748bff765afe5b53508f63f Reviewed-on: https://code.wireshark.org/review/24878 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b37aedb47a61f6b16339ce2e4d75f57e16b6ea31 commit b37aedb47a61f6b16339ce2e4d75f57e16b6ea31 Author: Marko Hrastovec Date: Fri Dec 8 12:12:38 2017 +0100 asterix: special processing for field item I021/150 There is a problem where one field decodes differently depending on another fields content. A code has been added to save information for 021_150_IM field. When the next field 021_150_ASPD is decoded, the stored information determines how it shall be scaled. This is a special case for I021/150 only. The same way as this change, other changes shall be done for fields that are dependent on other fields. Bug: 14076 Change-Id: I51f2c8f79bc6bde9efc0429e54fbea36818e9b36 Reviewed-on: https://code.wireshark.org/review/24734 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=786a73b80d6cc7d59060de50fef3feba04684869 commit 786a73b80d6cc7d59060de50fef3feba04684869 Author: Florian Bezold Date: Mon Dec 4 17:38:46 2017 +0100 Fix SOCKS5 state machine for authentication, two-pass dissection 1. SOCKSv5 dissection was broken if authentication was used since the used state machine states were initialized, but not saved correctly, and the first server state transition was wrong. I also fixed the GSSAPI variant analogously, but could not verify this since I have no traces of this. 2. SOCKSv5 actually has a different "subnegotiation field" for the authentication messages. This is added, and the original SOCKS version is added as a generated field (i.e. for filtering). 3. Info column setting is moved to the *_display_socks_* routines to fix two-pass dissection (as used by GUI Wireshark), since only here the correct per-packet state is used. The hash_info (as used by the *_state_machine_* functions) is already fully populated on second pass. Change-Id: Ib39434dafce08188cd2da347118d0509a7613915 Reviewed-on: https://code.wireshark.org/review/24712 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3c87991c28dda0ee2e64c73e3df6c671a19ab42c commit 3c87991c28dda0ee2e64c73e3df6c671a19ab42c Author: Gerald Combs Date: Fri Dec 15 13:40:34 2017 -0800 -1 is a valid tree_type value. Adjust tree_expanded and FieldInformation::treeType accordingly. Change-Id: I9b12c28550ba2639f636531a7ea1841df0638b5e Reviewed-on: https://code.wireshark.org/review/24844 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=67a49eb2ece34494a0fe1efd76d36c9b4d46d11e commit 67a49eb2ece34494a0fe1efd76d36c9b4d46d11e Author: Richard Sharpe Date: Sun Dec 17 16:05:51 2017 -0800 ieee80211: Remove notices about D3.1 of IEEE802.11ac. These items are now in 802.11 2016 so they are no longer draft items. Change-Id: I89b694f30700e08d9edc2e3707f36f8cf30dd0f2 Reviewed-on: https://code.wireshark.org/review/24877 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9761e279392ee996137c0d1d34a68ba13f43ae02 commit 9761e279392ee996137c0d1d34a68ba13f43ae02 Author: Gerald Combs Date: Sun Dec 17 14:40:06 2017 -0800 Qt: Process our event loop less often at startup. Add back info_update_freq_ and use it to skip event loop processing. Change-Id: Id36b4786c5ff1458abbf12f4e9ded13c56e14d57 Reviewed-on: https://code.wireshark.org/review/24876 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=50be2bde1a79a2a710a063cca23e51a67a95d63b commit 50be2bde1a79a2a710a063cca23e51a67a95d63b Author: Gerald Combs Date: Sun Dec 17 12:51:36 2017 -0800 Qt: Handle RecentFileStatus destruction manually. Restore the "deleteLater" behavior removed in 889aacae6e so that we don't trigger an assert in debug builds. Move the itemStatusFinished connection to RecentFileStatus while we're here. Bug: 14279 Change-Id: I79bc74d77fb3ad970c7c8a71037f680d55eac47c Reviewed-on: https://code.wireshark.org/review/24875 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f6d5b5fc107b67b2094abe6b7c56425d92dd0f91 commit f6d5b5fc107b67b2094abe6b7c56425d92dd0f91 Author: Uli Heilmeier Date: Sun Dec 17 10:47:30 2017 +0100 QT: Fix qUtf8Printable error macro qUtf8Printable() has been defined with QT 5.4 therefore we need qt_ui_utils.h included Change-Id: I6301d5eda124d2033033c6a91447b15736cdc8c2 Reviewed-on: https://code.wireshark.org/review/24870 Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser http://cgit.osmocom.org/wireshark/commit/?id=c9f54aa1c3a71c330c30ebc7a178922d179f912e commit c9f54aa1c3a71c330c30ebc7a178922d179f912e Author: Jo??o Valverde Date: Sun Dec 17 12:44:50 2017 +0000 autotools: Fixup plugins Custom.*.example plugin_ldadd was removed in 262a84c384353b2a88a6e81cdc499ab94a8316c2. Change-Id: I516aa1be3466433bf8db83ab3d1773bf88082e8c Reviewed-on: https://code.wireshark.org/review/24850 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=6159c2be18429e69096645946a2cbb507d49cbc5 commit 6159c2be18429e69096645946a2cbb507d49cbc5 Author: Jo??o Valverde Date: Sun Dec 17 12:26:26 2017 +0000 CMake: Replace generator expression with variable Should fix OSX buildbot. Change-Id: I52abdeab8c547079edc8aec6a0c6e12e928838c6 Reviewed-on: https://code.wireshark.org/review/24873 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f3444ed0f9c1d6e48b4b383afdd2b9fca9a8966c commit f3444ed0f9c1d6e48b4b383afdd2b9fca9a8966c Author: Jo??o Valverde Date: Fri Dec 15 00:49:31 2017 +0000 plugins: Remove moduleinfo.h Micro version bump for mate to homogenize it between CMake and autotools. The cmake macro doesn't handle the "a" suffix and it doesn't seem worth implementing. Change-Id: Ib022c6aa170623b83a9700e4fa098c60a9cddfab Reviewed-on: https://code.wireshark.org/review/24847 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=ee8ca2e1d793e039bdd7304ad3c2c0cb42a69624 commit ee8ca2e1d793e039bdd7304ad3c2c0cb42a69624 Author: Jo??o Valverde Date: Fri Dec 15 22:13:59 2017 +0000 plugin.rc.in: Cleanup some unnecessary code Also add comment noting that MSVC_VARIANT is not the same thing as CMAKE_GENERATOR. Change-Id: Icc0f4a491786e4045c650509957655ef41352b29 Reviewed-on: https://code.wireshark.org/review/24846 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f37e759f41da97a2121934d17b0ec2d895c3af15 commit f37e759f41da97a2121934d17b0ec2d895c3af15 Author: Gerald Combs Date: Sun Dec 17 08:16:56 2017 +0000 [Automatic update for 2017-12-17] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ideac9831381dbf6411af0e1d8bfa4fef6a1d7769 Reviewed-on: https://code.wireshark.org/review/24867 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=889aacae6e549c9cbbbd4ce3a371de0b042f7a37 commit 889aacae6e549c9cbbbd4ce3a371de0b042f7a37 Author: Gerald Combs Date: Sat Dec 16 14:24:24 2017 -0800 Qt: Update our recent status sooner at startup. Update our recent file status as soon as we read recent_common. Run recent stats updates in the global thread pool. Revert 15a97b5986 since it's no longer needed. Change-Id: If1b08ea640dfcad26affab5d20c80c90fbf133f2 Reviewed-on: https://code.wireshark.org/review/24862 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=cd573915eafd49cd3cb41e40a0d59acab4f49583 commit cd573915eafd49cd3cb41e40a0d59acab4f49583 Author: Martin Mathieson Date: Sat Dec 16 21:01:19 2017 +0000 LTE RLC graph: export graph as image, like TCP stream does Change-Id: I8709f7c09528a44a9729a06ea2ba4d6f99dbeccb Reviewed-on: https://code.wireshark.org/review/24864 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b1f558ae278cb1b90f6e06a9cc4031227b47fd31 commit b1f558ae278cb1b90f6e06a9cc4031227b47fd31 Author: Richard Sharpe Date: Sat Dec 16 09:52:01 2017 -0800 ieee80211: Bring VHT Capabilities IE into conformance with IEEE802.11-2016 IEEE802.11-2016 standardized those bits, so it's no longer a draft standard. I am slowly getting these things correct as I prepare for support for IEEE802.11ax D2.0. Change-Id: I3fc4497f2b85bae78043b9fd997379a44898f3db Reviewed-on: https://code.wireshark.org/review/24860 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f4b2263a0b753984c3ce97f2709ed4e435afe9ff commit f4b2263a0b753984c3ce97f2709ed4e435afe9ff Author: Martin Mathieson Date: Sat Dec 16 10:33:28 2017 +0000 Simple statistics export: fill in callback to get item data Bug: 13942 Change-Id: Ie7d13b1c17083d0a5b98282f04e6ac30319352a7 Reviewed-on: https://code.wireshark.org/review/24853 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6a5e90f2d91892248f5f7defe1c610e00298d789 commit 6a5e90f2d91892248f5f7defe1c610e00298d789 Author: Gerald Combs Date: Sat Dec 16 14:15:28 2017 -0800 Log output updates. Add a Qt message handler that calls g_log. Add milliseconds to the g_log_message_handler timestamp. Change-Id: I5b1c1d902b6b05cd8daa01741b19d6c2048dfb9a Reviewed-on: https://code.wireshark.org/review/24865 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=18c42e1dca9631b336dd2a8b813aad782569f69a commit 18c42e1dca9631b336dd2a8b813aad782569f69a Author: Uli Heilmeier Date: Sat Dec 16 21:55:18 2017 +0100 Kerberos: Update and fix KDCOptions and TicketFlags Fix and update KDCOptions and TicketFlags. Used references: * https://github.com/heimdal/heimdal/blob/master/lib/asn1/krb5.asn1#L330 * https://msdn.microsoft.com/en-us/library/cc246090.aspx * https://tools.ietf.org/html/rfc8062#section-3 Bug: 14261 Change-Id: I0e34425fc35e0eba14c700f82cbf2441365b139d Reviewed-on: https://code.wireshark.org/review/24863 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0b88544b07075741e6f89666867f0926c45fa419 commit 0b88544b07075741e6f89666867f0926c45fa419 Author: Michael Mann Date: Sat Dec 16 10:03:55 2017 -0500 Fix memory leaks in Expert Info dialog Models and children weren't deleted which leaked memory all over the place. Change-Id: I961016b2501ad8cc8c75cf5fa5b0c86756a29382 Reviewed-on: https://code.wireshark.org/review/24858 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=68668b785c73a1676ef4573290be7b50abb1c5a8 commit 68668b785c73a1676ef4573290be7b50abb1c5a8 Author: Michael Mann Date: Thu Dec 14 13:44:05 2017 -0500 Convert Supported Protocols dialog to use model Also have search file search name, filter and description columns Change-Id: Id519c5b1deb4a80e3b95437cf2e6d3e9510e4b11 Reviewed-on: https://code.wireshark.org/review/24857 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2b4322ceba7e8f8679ef955efb6a6ab3e12adab0 commit 2b4322ceba7e8f8679ef955efb6a6ab3e12adab0 Author: Uli Heilmeier Date: Thu Dec 14 21:45:56 2017 +0100 BGP: add Open message error/unsupported capability According to RFC 5492 [1], paragraph 5, Data field of BGP notification for Open message error/unsupported capability must list the set of unsupported capabilities Bug: 14274 Change-Id: Iacd33b5c83bc234652d2a5444f0029640d33e1c5 Reviewed-on: https://code.wireshark.org/review/24829 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b2e6d615c2817a25d74e1b25629e547586dbfa47 commit b2e6d615c2817a25d74e1b25629e547586dbfa47 Author: Martin Kaiser Date: Fri Dec 15 19:18:00 2017 +0100 qt: follow stream: prevent duplicate close 621498f88e882dbe8cc3a2c8373bb342bb0dbe77 fixed a crash that's caused by closing the follow stream dialogue multiple times. Another way to get a similar crash is to press the Back or "Filter out this stream" buttons again while we're already about to close. Ignore the two buttons in this case. Change-Id: Ia8d7b3ca500db2519a784b42c0744e2527b9d5f6 Reviewed-on: https://code.wireshark.org/review/24839 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3d086e638dc0a1713328c23161671555dfa4faaf commit 3d086e638dc0a1713328c23161671555dfa4faaf Author: Stig Bj??rlykke Date: Fri Dec 15 19:26:00 2017 +0100 wslua: Fix crash in Dir.open() Do not give an uninitialised error pointer to g_dir_open(), this will give a crash if g_dir_open() fails. Remove wslua_dir.dummy because it is not used by anyone. Change-Id: I044eee021393f2ea2aa022138bbf6fd099eb0908 Reviewed-on: https://code.wireshark.org/review/24840 Petri-Dish: Stig Bj??rlykke Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=621077309506ec65cb99b4f3aeffb99bcba69393 commit 621077309506ec65cb99b4f3aeffb99bcba69393 Author: Andrei Cipu Date: Fri Nov 17 17:00:01 2017 +0200 Rework address matching to work with string input. Currently, the function assumes the input is represented as a string representation of the hex string of the addresses. Instead, the parameters are sent as plain text IPs. We reactivate the helper functions that convert the addresses from the latter to th former representation and add support for handling masks in the input. Bug: 14229 Change-Id: I750a546b39404a1fbc86cee604a33e506f7240d8 Reviewed-on: https://code.wireshark.org/review/24469 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=03375e0c288dcad62b33fae2ce508d8dd906e169 commit 03375e0c288dcad62b33fae2ce508d8dd906e169 Author: Robert Grange Date: Fri Dec 15 08:13:04 2017 +0100 packet-mq: Improve some display by adding CONST values Change-Id: I66f9dc050735fd0a73b9938a9db0c5978cec40a4 Reviewed-on: https://code.wireshark.org/review/24834 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=28ba56667599c7a90c8492052b438f58aa963902 commit 28ba56667599c7a90c8492052b438f58aa963902 Author: Stig Bj??rlykke Date: Fri Dec 15 21:38:30 2017 +0100 wslua: Fix memory leakages Free some variables in error handling. Change-Id: I0d0653962b11f760c31872aa7e5b5f1d20c54dcb Reviewed-on: https://code.wireshark.org/review/24842 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=183b9119dc4caa491cf58bc673a3109a7ef8bcfd commit 183b9119dc4caa491cf58bc673a3109a7ef8bcfd Author: Pascal Quantin Date: Sat Dec 16 00:24:40 2017 +0100 6LowPAN: always build IPv6 address whatever the tree state Bug: 14277 Change-Id: I320def755076ef8c52d4e5e0dbedf06ea88f25a7 Reviewed-on: https://code.wireshark.org/review/24848 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=15a97b5986e9a5f23ebce233ecc84401a5495abc commit 15a97b5986e9a5f23ebce233ecc84401a5495abc Author: Gerald Combs Date: Fri Dec 15 15:35:29 2017 -0800 Qt: Show our recent files earlier. Show the recent file list before it's been scanned so that the welcome screen layout will be complete by the time we're done initializing. Change-Id: I09f0a68c6d36f30e7cdb2958f82af38f52444c34 Reviewed-on: https://code.wireshark.org/review/24849 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=3071356d9e3d07d3c0132af88e4e8af785deb3ee commit 3071356d9e3d07d3c0132af88e4e8af785deb3ee Author: Stig Bj??rlykke Date: Fri Dec 15 22:49:18 2017 +0100 Qt: A node without a child can not be expanded Change-Id: I28bb5797e8eab69c761e257b90a11c646d06cf68 Reviewed-on: https://code.wireshark.org/review/24845 Petri-Dish: Stig Bj??rlykke Reviewed-by: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=adde937ed74926323b084713caf6fbba871d8791 commit adde937ed74926323b084713caf6fbba871d8791 Author: Jo??o Valverde Date: Fri Dec 15 00:04:32 2017 +0000 plugins: Remove redundant plugin.rc.in files plugin.rc is Windows specific, also add condition to reflect that. Change-Id: Ibbb7dab77dd1f277e2302c8f931218ca433f8c72 Reviewed-on: https://code.wireshark.org/review/24833 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=cf5a58f72a58c36744878cd6eb640de669341a55 commit cf5a58f72a58c36744878cd6eb640de669341a55 Author: Gerald Combs Date: Fri Dec 15 10:59:11 2017 -0800 Qt: Initialize QFontDatabase in a worker thread. QFontDatabase uses an internal list of system fonts which might take a while to initialize depending on your platform and hardware. On my notebook here it takes about 45 to 50 ms. Create a worker thread for QFontDatabase initialization similar to QMimeDatabase. Change-Id: Ieff683b023537a6c104a80f2611ea1e966b65610 Reviewed-on: https://code.wireshark.org/review/24841 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=2acaf0a47a643ff929ecf9354d62a642794bbbd1 commit 2acaf0a47a643ff929ecf9354d62a642794bbbd1 Author: Matej Tkac Date: Wed Dec 13 16:47:19 2017 +0100 [ISAKMP] Added support for new Notify EMERGENCY_CALL_NUMBERS Payload In accordance with the latest 3GPP TS 24.302 (Section 8.2.9.8) 3GPP TS 24.008 (Section 10.5.3.13) Bug: 14273 Change-Id: Ib5a24fa33633764f6bfb034250c309c1f4af9914 Reviewed-on: https://code.wireshark.org/review/24793 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=774a986ec07be46263e7acbbec4fbb69563a95a1 commit 774a986ec07be46263e7acbbec4fbb69563a95a1 Author: Stig Bj??rlykke Date: Fri Dec 15 13:41:21 2017 +0100 epan: Add default type handling for custom column Add default type handling in proto_custom_set() to prevent crashes when trying to use FT_IPXNET, FT_AX25 or FT_VINES items as custom columns. This will also work as a safeguard when adding new types. Change-Id: Iaf3b48aec72f0e5c10332b0e6d5f7221b0196e15 Reviewed-on: https://code.wireshark.org/review/24836 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=bdb6baa7405d259fa2cd2f6f7d2fb21e13315885 commit bdb6baa7405d259fa2cd2f6f7d2fb21e13315885 Author: Gerald Combs Date: Thu Dec 7 08:15:30 2017 -0800 Qt: Switch ProtoTree to a treeview+model. Add a ProtoTreeModel and use it in ProtoTree. This should make the UI more responsive when we have lots of items in the tree. Change-Id: Id26e6bcff84663867a8da17fd9ae86ff639b633f Reviewed-on: https://code.wireshark.org/review/24774 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0909580a7e98c134785a96829b58076534b477b6 commit 0909580a7e98c134785a96829b58076534b477b6 Author: Richard Sharpe Date: Tue Dec 12 09:21:40 2017 -0800 ieee80211: Add handling of the ANQP Neighbor Report. Change-Id: I857cdcc3a15cd01c3b5cc7e31be043048ef5f1ed Reviewed-on: https://code.wireshark.org/review/24784 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1651371d17e56a9f77270aa2c6d6239a6506b16e commit 1651371d17e56a9f77270aa2c6d6239a6506b16e Author: Stig Bj??rlykke Date: Fri Dec 15 15:48:50 2017 +0100 epan: Whitespace fixes Change-Id: I859c7bf5cfaf23b46d2cda7ff9c7e1ddd164832a Reviewed-on: https://code.wireshark.org/review/24838 Petri-Dish: Stig Bj??rlykke Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a51ac8d398aeedf9a678188147a89bf1ee035443 commit a51ac8d398aeedf9a678188147a89bf1ee035443 Author: Stig Bj??rlykke Date: Fri Dec 15 14:35:44 2017 +0100 Qt: Fix translating some texts Change-Id: I8267bfd96efe9d9d086913ff418a74a68e63b8da Reviewed-on: https://code.wireshark.org/review/24837 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a8a4436e97eaddca301e8b258f7a1ca9688af4f9 commit a8a4436e97eaddca301e8b258f7a1ca9688af4f9 Author: Jo??o Valverde Date: Fri Dec 15 09:19:24 2017 +0000 debian/rules: Fix typo Change-Id: I3fea8e42af2f51700f283cbcdc45ac3420979cd9 Reviewed-on: https://code.wireshark.org/review/24835 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=90102ad12ec601abcc2270e4779f8d2fc1c0c937 commit 90102ad12ec601abcc2270e4779f8d2fc1c0c937 Author: Gerald Combs Date: Thu Dec 14 14:13:39 2017 -0800 Remove a plugin_if_gui_cb type conversion. We always pass a GHashTable * to plugin_if_gui_cb so don't cast it to a gconstpointer. This should fix the following and related warnings: main_window.cpp: In function ???void plugin_if_mainwindow_apply_filter(gconstpointer)???: main_window.cpp:121:44: warning: cast from type ???gconstpointer {aka const void*}??? to type ???GHashTable* {aka _GHashTable*}??? casts away qualifiers [-Wcast-qual] GHashTable * data_set = (GHashTable *) user_data; Fix another const warning while we're here. Change-Id: Ia9225188bfb913feb4fef4369f10fd5791fc8dc9 Reviewed-on: https://code.wireshark.org/review/24830 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=afc6e773dc84ddcf57af59e0fd87ab1625204786 commit afc6e773dc84ddcf57af59e0fd87ab1625204786 Author: Pascal Quantin Date: Thu Dec 14 23:58:00 2017 +0100 Fix registration of wiretap plugins Change-Id: I1277870cab348feda7e23cffb277410bd4b10a0e Reviewed-on: https://code.wireshark.org/review/24832 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=db140dd500227c1a7c2223c1c868812e08253493 commit db140dd500227c1a7c2223c1c868812e08253493 Author: Jo??o Valverde Date: Sun Aug 27 20:53:23 2017 +0100 Add new dissector callback signature with data pointer This is useful to implement language bindings (Lua, Python, etc) and good practice in general. Non-breaking change to the API. Change-Id: I8d16c14880e5aa53212af8418c468a6ec3aa8954 Reviewed-on: https://code.wireshark.org/review/24814 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=cebb8ea20ec2d4c1c1c000304c6cc6e7e9ccb8ad commit cebb8ea20ec2d4c1c1c000304c6cc6e7e9ccb8ad Author: Jo??o Valverde Date: Tue Aug 29 15:34:31 2017 +0100 Add new plugin type for libwireshark Allow epan itself to be extended by plugins. Adds the following new plugin interfaces: void plugin_epan_init() void plugin_epan_dissect_init(epan_dissect_t *) void plugin_epan_dissect_cleanup(epan_dissect_t *) void plugin_epan_cleanup() void plugin_epan_register_all_protocols(register_cb, gointer) [OPTIONAL] void plugin_epan_register_all_handoffs(register_cb, gointer) [OPTIONAL] Any one of these can be an empty function but the first four must be present. The motivation for the change is a better way to implement a language binding other than registering a fake protocol and stuffing everything into a single dissector call (and maybe require an extra packet_info field) but I expect there would be other interesting use cases. Change-Id: I215d50750ac7561fe25fdcdcfbc6a3f351984785 Reviewed-on: https://code.wireshark.org/review/24813 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=629596ebefa34a2677c341ab899e51cecbe254f0 commit 629596ebefa34a2677c341ab899e51cecbe254f0 Author: Gerald Combs Date: Thu Dec 14 16:53:59 2017 +0000 Qt: Constify a variable. Change-Id: Icb3ce93d24ffbdf4ac6d3b70e7baa1f991169ac3 Reviewed-on: https://code.wireshark.org/review/24823 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=db740987fffeb7e8122a6cd40e25f16244af5721 commit db740987fffeb7e8122a6cd40e25f16244af5721 Author: Gerald Combs Date: Thu Dec 14 10:29:48 2017 -0800 Qt: Add and use qUtf8Printable. Qt 5.4 introduced qUtf8Printable, a convenience macro for converting QString to a UTF-8 const char *. Add a compatibility definition and start using it. Change-Id: I3cf88611b1ed1a34082cb2ba82394954e2e6c461 Reviewed-on: https://code.wireshark.org/review/24828 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=4cf7cd3ed20c57dc5977be5be37ced0bd1706d61 commit 4cf7cd3ed20c57dc5977be5be37ced0bd1706d61 Author: Derick Rethans Date: Thu Dec 14 17:14:32 2017 +0000 Register the MongoDB dissector as SSL capable. Bug: 14275 Change-Id: Ia0d8d0b333f69e59ba54b0d788587484dfae950e Reviewed-on: https://code.wireshark.org/review/24827 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fe4cf449c9787bcfd234db22674a0f49fee04ff0 commit fe4cf449c9787bcfd234db22674a0f49fee04ff0 Author: Alexis La Goutte Date: Thu Dec 14 17:13:23 2017 +0000 fp_mux: fix 'data' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Ieac1b7a19d50c35d565421e1012dfb4001b6dd44 Reviewed-on: https://code.wireshark.org/review/24826 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0ffee1526be20b3791cececfbfa490ed2d22dece commit 0ffee1526be20b3791cececfbfa490ed2d22dece Author: Alexis La Goutte Date: Thu Dec 14 17:11:10 2017 +0000 ciscodump(extcap): fix 'packet' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I04a52c37404fe6a91740b766de1482376d7128fa Reviewed-on: https://code.wireshark.org/review/24825 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=83b052562096830b024aff830469086b1ec933d1 commit 83b052562096830b024aff830469086b1ec933d1 Author: Alexis La Goutte Date: Thu Dec 14 17:10:02 2017 +0000 firewall_rules(ui): fix 'ptype' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Iadc3717cdbdbde8d863ed822ef3ad29256e099f0 Reviewed-on: https://code.wireshark.org/review/24824 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=11a948dd121f04448ff765ec36dafbf8e8415fb5 commit 11a948dd121f04448ff765ec36dafbf8e8415fb5 Author: AndersBroman Date: Thu Dec 14 10:30:27 2017 +0100 [ISUP] Update value strings from specification amendment. Change-Id: Ib3dff9c438b9adbec4533f1a66f1bf07f51dbd07 Reviewed-on: https://code.wireshark.org/review/24821 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9401571a244366d74f4998ffb0b9acb7365cd57d commit 9401571a244366d74f4998ffb0b9acb7365cd57d Author: Roland Knall Date: Thu Dec 14 11:25:29 2017 +0100 Qt: Add QtCreator generated files to gitignore Change-Id: Id3ba4eede12de954bdc34d906abf2a84dc3e1cdd Reviewed-on: https://code.wireshark.org/review/24822 Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=995812c5f1add94df1c237596939130c1704b099 commit 995812c5f1add94df1c237596939130c1704b099 Author: Jo??o Valverde Date: Sun Oct 1 00:56:03 2017 +0100 Refactor plugin registration and loading Put different types of plugins (libwiretap, libwireshark) in different subdirectories, give libwiretap and libwireshark init routines that load the plugins, and have them scan the appropriate subdirectories so that we don't even *try* to, for example, load libwireshark plugins in programs that only use libwiretap. Compiled plugins are stored in subfolders of the plugin folders, with the subfolder name being the Wireshark minor version number (X.Y). There is another hierarchical level for each Wireshark library (libwireshark, libwscodecs and libwiretap). The folder names are respectively plugins/X.Y/{epan,codecs,wiretap}. Currently we only distribute "epan" (libwireshark) plugins. Change-Id: I3438787a6f45820d64ba4ca91cbe3c8864708acb Reviewed-on: https://code.wireshark.org/review/23983 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=a9821caab8a1f2c6e265bd5b63a060f1f241c704 commit a9821caab8a1f2c6e265bd5b63a060f1f241c704 Author: Pavel Moravec Date: Sat Nov 25 15:57:57 2017 +0100 Add dissector for ActiveMQ Artemis Core Protocol So far decode just packet headers Change-Id: I7a01f3c83b97882f4c669122ad94b2bdab0ab251 Signed-off-by: Pavel Moravec Reviewed-on: https://code.wireshark.org/review/24583 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=862a0b6472529ef6676c8bc56dd8f0be5166fd7c commit 862a0b6472529ef6676c8bc56dd8f0be5166fd7c Author: Stig Bj??rlykke Date: Wed Dec 13 11:36:37 2017 +0100 epan: Make expert info summary text mandatory This will make the code easier and removes the use of a generic "Expert Info" as name. Change-Id: I57ad2adb851726106ddc5009f3c6ca61721f647a Reviewed-on: https://code.wireshark.org/review/24792 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=11ccd830685e4037c3cce04a3dbfd2d05a5145f7 commit 11ccd830685e4037c3cce04a3dbfd2d05a5145f7 Author: Jeff Morriss Date: Sat Dec 2 17:42:16 2017 -0500 Fix detection of Lua when there's no pkgconfig file. Linking with liblua requires libdl on Linux; if the test link with liblua fails try including libdl. Fixes the problem reported in: https://www.wireshark.org/lists/wireshark-dev/201711/msg00102.html Change-Id: I8561f15f8d9adbab52d668d102811fb821b45034 Reviewed-on: https://code.wireshark.org/review/24678 Petri-Dish: Jeff Morriss Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a9f50164298d641be3d107261e8ec1166a6fcf2a commit a9f50164298d641be3d107261e8ec1166a6fcf2a Author: Richard Sharpe Date: Tue Dec 12 19:20:18 2017 -0800 ieee1905: Fix an incorrect flags dissection. Change-Id: Iebb434875eac08aeabab6b9179a882817149012c Reviewed-on: https://code.wireshark.org/review/24820 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c662615ab4c0ecb48443412a27b769e73ed084d4 commit c662615ab4c0ecb48443412a27b769e73ed084d4 Author: Richard Sharpe Date: Wed Dec 6 18:51:03 2017 -0800 ieee1905: Fix for a malformed packet with a Steering request. If the mode bit is zero, we have to do different things than if it is 1. Change-Id: I5ed8bec1d350c02b736818cad5ab864748145686 Reviewed-on: https://code.wireshark.org/review/24775 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=6af7b9a63ad8c7ce7b57e0d8adcb5e61d70a2123 commit 6af7b9a63ad8c7ce7b57e0d8adcb5e61d70a2123 Author: Guy Harris Date: Wed Dec 13 19:16:28 2017 -0800 Register the UDS dissector by name. See https://ask.wireshark.org/question/891/use-uds-dissector-inside-doip-dissector/ Change-Id: I608b4ffb90e65fd31e9f3e421f4c473f4e66bebd Reviewed-on: https://code.wireshark.org/review/24818 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7539469d79d80944ab2daa389aade7991302835d commit 7539469d79d80944ab2daa389aade7991302835d Author: Guy Harris Date: Wed Dec 13 18:44:17 2017 -0800 Fix types. ftell() returns a long; assign its value to a variable of that type. size_t is unsigned, so checking that it's >= 0 always succeeds. We can cast the variable's value to size_t once we've determined that it's non-negative; do so, to avoid other warnings. Change-Id: I0da6a220ce140ebf073df5f5bcd0c9526bf9c3c3 Reviewed-on: https://code.wireshark.org/review/24817 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=6d30df0cdd83b051e02b1e90a905b7e51031cd22 commit 6d30df0cdd83b051e02b1e90a905b7e51031cd22 Author: Guy Harris Date: Wed Dec 13 18:38:23 2017 -0800 Replace a comma with a semicolon, which it presumably was intended to be. Change-Id: I308752a50b465a2772172c3500f6417a3ae19f11 Reviewed-on: https://code.wireshark.org/review/24816 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=c781bd41100fa2080c4062dc34b5bfb4e4175180 commit c781bd41100fa2080c4062dc34b5bfb4e4175180 Author: Gerald Combs Date: Wed Dec 13 16:40:41 2017 -0800 Qt: Fix a cast. Just use a const_cast instead of messing with compiler settings. Change-Id: I35d3498ac4c2817d02cbf11497a70f72b60b58bb Reviewed-on: https://code.wireshark.org/review/24815 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=cb748178feffd35146222fad14b898cb4604f7cb commit cb748178feffd35146222fad14b898cb4604f7cb Author: Jo??o Valverde Date: Tue Dec 12 01:05:39 2017 +0000 Add doc/README.build-system with CMake and autotools information Currently more autotools than CMake. Change-Id: I167f0bdd49d70d72f6155a4d978975c034ce3b4a Reviewed-on: https://code.wireshark.org/review/24773 Reviewed-by: Alexis La Goutte Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=801ee01affeac724c063c8c643fde9459b4f0ceb commit 801ee01affeac724c063c8c643fde9459b4f0ceb Author: Roland Knall Date: Wed Dec 13 17:03:15 2017 +0100 Qt: Add ui, qrc and qm files to source Autogen had the resulting effect, that IDE's no longer see those files as part of the source tree, and therefore do not show them. This fixes it. Change-Id: Ia1f259743ba5b63f5bc47da79afca90a9fabc07b Reviewed-on: https://code.wireshark.org/review/24794 Petri-Dish: Roland Knall Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=b0112e60ada68646b3e304f73f8321f5fb1ddc01 commit b0112e60ada68646b3e304f73f8321f5fb1ddc01 Author: Michael Mann Date: Wed Jun 28 20:00:38 2017 -0400 Add a model to use for Expert Info dialog. With the model (and proxy), the following features were added/fixed. 1. Expert severities can be filtered by type 2. Search filter expanded to include summary, protocol and column info 3. Expert info starts with all items collapsed. 4. Context menus for collapse/expand all Bug: 11753 Bug: 13831 Bug: 13842 Change-Id: I8e89c7be441e1f08e18915ef8805609e5c5d0bd1 Reviewed-on: https://code.wireshark.org/review/22458 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=f945b85391976bc59da4b542fe84cb58033bd22e commit f945b85391976bc59da4b542fe84cb58033bd22e Author: Stig Bj??rlykke Date: Tue Dec 12 23:34:03 2017 +0100 epan: Use expert info summary text as field name Change the expert info registry to use summary text as field name instead of blurb to show the correct column header tooltip in custom columns. Preserve backward compability by not use empty summary text. Change-Id: Ibbaf142165be0d9f42d1e2476f39f8d251ea0593 Reviewed-on: https://code.wireshark.org/review/24788 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=e4750105b23c2e19cfa4fbb79679b4a045ec0ebe commit e4750105b23c2e19cfa4fbb79679b4a045ec0ebe Author: Stig Bj??rlykke Date: Tue Dec 12 23:29:24 2017 +0100 epan: Show a check mark in custom columns for FT_NONE types This is valuable when adding a expert info field as custom column, but will also make sense for other FT_NONE types. Change-Id: Ib1a14c59a5450f2e713f190aecf3484586d116c4 Reviewed-on: https://code.wireshark.org/review/24787 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=2c36df54a34494015772d3342cc9819cad0669b1 commit 2c36df54a34494015772d3342cc9819cad0669b1 Author: Jeff Morriss Date: Sat Dec 2 18:32:23 2017 -0500 Fix RPM build: include the User Guide. The User Guide has been installed by default since I9dd539c737cb3777dc1351707b9e45a3a6764aaa. Fixes problem reported in: https://www.wireshark.org/lists/wireshark-dev/201711/msg00162.html Change-Id: I462c7c18869e8df93785e1898364e248e897de50 Reviewed-on: https://code.wireshark.org/review/24679 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=158d9298840434f2770c96bd3b8d2f44792932d1 commit 158d9298840434f2770c96bd3b8d2f44792932d1 Author: Stig Bj??rlykke Date: Tue Dec 12 15:36:26 2017 +0100 epan: Use check mark in protocol custom column Change from the text "Yes" to a utf8 check mark to indicate the precense of a protocol in custom columns. Change-Id: I9510333fc12148bf1f61aa2ddea2c6d390a9491a Reviewed-on: https://code.wireshark.org/review/24783 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=16e5d73ecc6630411153b4f46b0d137fb78c1240 commit 16e5d73ecc6630411153b4f46b0d137fb78c1240 Author: Stig Bj??rlykke Date: Tue Dec 12 20:27:38 2017 +0100 nfapi: Add missing expert info summary Change-Id: Iba6330f9c7f27e82adfa967fe9b082920a5b0afa Reviewed-on: https://code.wireshark.org/review/24785 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=326591ef6da8f5024a6c93721ea896cad0578f4c commit 326591ef6da8f5024a6c93721ea896cad0578f4c Author: Dario Lombardo Date: Tue Dec 12 09:19:03 2017 +0100 fuzzer: add check for ftell return value (CID: 1426073). Change-Id: I9b619c79433f267d87f6680eeb78a25daa169f4d Reviewed-on: https://code.wireshark.org/review/24778 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=91f63908df560e0ed22cad12ba6cc43f81d60f9f commit 91f63908df560e0ed22cad12ba6cc43f81d60f9f Author: Stig Bj??rlykke Date: Tue Dec 12 09:18:57 2017 +0100 cmake: Remove -Wcomma for C++ when using Qt >= 5.10 The Qt team introduced a lot of "Possible misuse of comma operator here" warnings in qstring.h and qstringview.h in version 5.10. Now we need to fix the Qt source again. Change-Id: I948ba5a224d4dca1ebb6a758100c064d501c1d4a Reviewed-on: https://code.wireshark.org/review/24779 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=621498f88e882dbe8cc3a2c8373bb342bb0dbe77 commit 621498f88e882dbe8cc3a2c8373bb342bb0dbe77 Author: Martin Kaiser Date: Sat Dec 9 18:34:31 2017 +0100 qt: follow stream: fix crash during close The Follow Stream dialogue's button "Filter out this stream" filters out the stream's packets and then closes the Follow Stream dialogue. This may take a moment. If the user presses the Close button while the filtering is still running, the dialogue will be closed twice. This causes a crash which can be seen in ASAN builds. ==9485==ERROR: AddressSanitizer: SEGV on unknown address 0x60205e80001b (pc 0x7f923e672b8c sp 0x7fff73104600 bp 0x7fff73104600 T0) #0 0x7f923e672b8b in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2d9b8b) #1 0x7f924f46010b in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x13f10b) #2 0x7f924f4655ff in QApplication::notify(QObject*, QEvent*) (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x1445ff) #3 0x7f923e672dca in QCoreApplication::notifyInternal(QObject*, QEvent*) (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2d9dca) #4 0x7f924f49ae54 in QWidgetPrivate::close_helper(QWidgetPrivate::CloseMode) (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x179e54) #5 0x55f3e249582f in FollowStreamDialog::close() /media/sf_wireshark.git/ui/qt/follow_stream_dialog.cpp:327 #6 0x55f3e236e534 in FollowStreamDialog::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) ui/qt/moc_follow_stream_dialog.cpp:155 ... SUMMARY: AddressSanitizer: SEGV ??:0 QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ==9485==ABORTING Ignore the Close button if we know that we'll be closing the dialogue shortly. Change-Id: Ibf1684fd75937e6b24fcb9ea62ae6acb038260e6 Reviewed-on: https://code.wireshark.org/review/24777 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5aa50639acc774a65df9be99ed44d90e7615646a commit 5aa50639acc774a65df9be99ed44d90e7615646a Author: Richard Sharpe Date: Mon Dec 11 20:18:00 2017 -0800 ieee80211: Add additional ANQP IEs defined in IEEE802.11-2016. Dissect the Venue URL element. More to come. Change-Id: I64330b3f90f9f6222df0fb00d3ea277f59424e98 Reviewed-on: https://code.wireshark.org/review/24776 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=34b62c60bfad56275dca48242c7e477f33b691ef commit 34b62c60bfad56275dca48242c7e477f33b691ef Author: Gerald Combs Date: Mon Dec 11 14:41:58 2017 -0800 Revert "Move fill_in_local_interfaces to a thread." Calling scan_local_interfaces ends up calling fork via extcap. Doing so from a thread is ill-adivsed: https://rachelbythebay.com/w/2014/08/16/forkenv/ http://www.linuxprogrammingblog.com/threads-and-fork-think-twice-before-using-them This reverts commit 5b4894b7959f44e077f36194c490cbf402e1e659. Revert "fix compilation without pcap." as well. This reverts commit 51300b3c834a3877d567fb57ae78ec74ec8ba80d. Change-Id: Ic80582b52398c44af73c6d74dbb3216c4d1b37fc Reviewed-on: https://code.wireshark.org/review/24772 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=10e98462520b5dcfa1e5d7b80e53a95725d91d94 commit 10e98462520b5dcfa1e5d7b80e53a95725d91d94 Author: Martin Mathieson Date: Mon Dec 11 22:33:11 2017 +0000 SIP statistics: use flipped indices for tables when incrementing stats Change-Id: I22ed38b1c2d7849e8930149fb39ee14fa198a6e1 Reviewed-on: https://code.wireshark.org/review/24771 Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=7617af1d8994289da23402b67ccea79e32881888 commit 7617af1d8994289da23402b67ccea79e32881888 Author: Jo??o Valverde Date: Mon Dec 11 19:32:31 2017 +0000 Fix make distcheck Change-Id: I0c5a31d423d19071dc6ed0a42b064271e5f63fd2 Reviewed-on: https://code.wireshark.org/review/24769 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=51300b3c834a3877d567fb57ae78ec74ec8ba80d commit 51300b3c834a3877d567fb57ae78ec74ec8ba80d Author: Dario Lombardo Date: Mon Dec 11 11:29:07 2017 +0100 fix compilation without pcap. Fix a regression introduced by I09beab751c9c2917f017b6c082166d86ca693544. Change-Id: I57b971086470e836f4147500143c35494118e754 Reviewed-on: https://code.wireshark.org/review/24765 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c9546dfceb778dcabe7a830272add62e6ae1403e commit c9546dfceb778dcabe7a830272add62e6ae1403e Author: AndersBroman Date: Mon Dec 11 13:56:12 2017 +0100 [capture_info] Move capture_info_new_file() to capture.c Change-Id: I9137af6461921d7553a8968743f61f2265424061 Reviewed-on: https://code.wireshark.org/review/24767 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=84f905786ed2b2aabaec9a0c1045daeda66358ba commit 84f905786ed2b2aabaec9a0c1045daeda66358ba Author: AndersBroman Date: Mon Dec 11 13:10:30 2017 +0100 [capture_info] Fold the code of capture_info_open() into ui/capture.c Change-Id: Id302e88bed4da8b9b457049fb78b0bc7d7ffabe3 Reviewed-on: https://code.wireshark.org/review/24766 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=397e2a2d74e9c6ea103d3b4c30794552041e39c2 commit 397e2a2d74e9c6ea103d3b4c30794552041e39c2 Author: Dario Lombardo Date: Thu Dec 7 22:29:38 2017 +0100 gitlab-ci: restyle the gcc builds The gcc builds now take the package from the official gcc ppa and use the ubuntu 16.04 docker image. The gcc docker image was shipped with a old Qt version that caused some errors. Change-Id: Ieefbda99cd0931ff3043de6caa4cccd163589759 Reviewed-on: https://code.wireshark.org/review/24736 Reviewed-by: Alexis La Goutte Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=faa4a6a5f12b507e12232ceefb9cebdaf6b7ee24 commit faa4a6a5f12b507e12232ceefb9cebdaf6b7ee24 Author: Martin Mathieson Date: Sun Dec 10 23:06:40 2017 +0000 SIP statistics: fix problems with invalid items Change-Id: Ide21489cad66e4bebaafe5ef813a000db2956a2e Reviewed-on: https://code.wireshark.org/review/24759 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5b4894b7959f44e077f36194c490cbf402e1e659 commit 5b4894b7959f44e077f36194c490cbf402e1e659 Author: Gerald Combs Date: Sat Dec 9 17:52:08 2017 -0800 Move fill_in_local_interfaces to a thread. Move fill_in_local_interfaces to a worker thread and start it as early as possible. Add a mutex for global_capture_opts. Change-Id: I09beab751c9c2917f017b6c082166d86ca693544 Reviewed-on: https://code.wireshark.org/review/24757 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0d5ad701b494c29dd5ae5e44ecb5f9a42c423f5b commit 0d5ad701b494c29dd5ae5e44ecb5f9a42c423f5b Author: Jo??o Valverde Date: Mon Dec 11 03:37:44 2017 +0000 Fix make distcheck Change-Id: Ie0e6ef4595be4f981b919ed609cc62a0595c3320 Reviewed-on: https://code.wireshark.org/review/24764 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=5fc43fe63a07062587bc3d76256f4240221e8bc7 commit 5fc43fe63a07062587bc3d76256f4240221e8bc7 Author: Jo??o Valverde Date: Sun Dec 10 17:29:40 2017 +0000 Rewrite make-tap-reg.py in C Change-Id: Ief5b1fffecc9712c01ff10292c403b7c84a5908a Reviewed-on: https://code.wireshark.org/review/24756 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=224e24884a8b37732105bd40a0ee85d5feaaeab1 commit 224e24884a8b37732105bd40a0ee85d5feaaeab1 Author: Pascal Quantin Date: Sun Dec 10 23:09:54 2017 +0100 NTP: fix authenticator dissection when padding is used Bug: 14269 Change-Id: Ifdc9af7524a0566e33acbedff3757cff416ce8fb Reviewed-on: https://code.wireshark.org/review/24758 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7d383637865e2f1f0de7a8921261f406f42af4bf commit 7d383637865e2f1f0de7a8921261f406f42af4bf Author: Pascal Quantin Date: Sun Dec 10 22:17:04 2017 +0100 NTP: fix parsing of multiple comma separated identifiers Bug: 14268 Change-Id: Id1d6040052d34d3f8bdfe49d20f4f3f8efbe001b Reviewed-on: https://code.wireshark.org/review/24755 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=91548948bbe2bba844a65c62975dada05dd4c03e commit 91548948bbe2bba844a65c62975dada05dd4c03e Author: Gerald Combs Date: Sun Dec 10 08:16:48 2017 +0000 [Automatic update for 2017-12-10] Update manuf, services enterprise numbers, translations, and other items. Change-Id: If3becbd6b66f0a7a49a80c4ff2dc2a2a6015fa16 Reviewed-on: https://code.wireshark.org/review/24752 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=d0d1eaadf0c92e37b6ed2883583f71b7b9ec3a7e commit d0d1eaadf0c92e37b6ed2883583f71b7b9ec3a7e Author: Gerald Combs Date: Fri Dec 8 10:44:44 2017 -0800 Win32: Add checks for _WIN32_WINNT and NTDDI_VERSION. Check to see if we're the source of truth for _WIN32_WINNT and NTDDI_VERSION in config.h and emit a compiler error if we aren't. Rearrange the #includes in ui/qt/data_printer.cpp so that config.h is included first. This fixes the following: 136>C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\config.h(411): warning C4005: 'NTDDI_VERSION': macro redefinition (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp) [C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\ui\qt\qtui.vcxproj] C:\Program Files (x86)\Windows Kits\10\Include\10.0.15063.0\shared\sdkddkver.h(223): note: see previous definition of 'NTDDI_VERSION' (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp) 136>C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\config.h(412): warning C4005: '_WIN32_WINNT': macro redefinition (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp) [C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\ui\qt\qtui.vcxproj] C:\Program Files (x86)\Windows Kits\10\Include\10.0.15063.0\shared\sdkddkver.h(213): note: see previous definition of '_WIN32_WINNT' (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp) Change-Id: I90886cb9450463d768d6529ccd678ca11508cde2 Reviewed-on: https://code.wireshark.org/review/24744 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3d673da88c5ff4e56cbb3cf713b8c49704e62923 commit 3d673da88c5ff4e56cbb3cf713b8c49704e62923 Author: Michael Mann Date: Sat Dec 9 22:24:10 2017 -0500 Convert to using use SPDX identifier on wsutil directory Change-Id: Id73e641499e75bc1afc1dea29682418156f461fe Reviewed-on: https://code.wireshark.org/review/24751 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8225159e336610c25fb4d4129b0be156ed487c49 commit 8225159e336610c25fb4d4129b0be156ed487c49 Author: Derick Rethans Date: Mon Dec 4 18:31:03 2017 +0000 Add support for MongoDB OP_COMPRESSED packets Bug: 14259 Change-Id: Iab6b494bebaa913267f94d41b7950b67dd406cb6 Reviewed-on: https://code.wireshark.org/review/24705 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=22a7d8fa8d8b8c7171ede55e7f413d004cb7b099 commit 22a7d8fa8d8b8c7171ede55e7f413d004cb7b099 Author: Uli Heilmeier Date: Fri Dec 8 18:21:04 2017 +0100 SOCKS: Display right version in pseudo header Use the previous recorded version as version and set field as generated. Bug: 14262 Change-Id: I0872ed826ccd8a5a1b75b071d810404d08ddc7b3 Reviewed-on: https://code.wireshark.org/review/24741 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8cb9a094bf1d08ffb100a384de03a9774f7183c0 commit 8cb9a094bf1d08ffb100a384de03a9774f7183c0 Author: Marko Hrastovec Date: Fri Dec 8 20:41:16 2017 +0100 asterix: wrong presentation of fields I009/080 in CAT009. Fields I009/080 were wrongly represented for CAT009. 8 and 16 bit long fields were represented as 24 bit. Change-Id: I5bd1c1f006292f58d0290ced80dde22324cb4002 Reviewed-on: https://code.wireshark.org/review/24746 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=abd703c4b80e47d5097a74cbba4911e9ef83d2fb commit abd703c4b80e47d5097a74cbba4911e9ef83d2fb Author: Anton Glukhov Date: Fri Dec 8 12:37:25 2017 +0100 LLDP: Add 802.3 TLV Additional Ethernet Capabilities (Subtype 7) Bug: 14267 Change-Id: I23eb82a2f9bb2d57952f71870cc0fc8f12f036df Signed-off-by: Anton Glukhov Reviewed-on: https://code.wireshark.org/review/24735 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c79fb9d0285fbf51d6cdc3770396a8add08321ec commit c79fb9d0285fbf51d6cdc3770396a8add08321ec Author: Jo??o Valverde Date: Sat Dec 9 12:00:52 2017 +0000 make-dissectors: Indent and cleanup #include Change-Id: I395d0c168a6ba2fc8fad85598e6355493b897a7a Reviewed-on: https://code.wireshark.org/review/24748 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=514e607dd911d8bc5eabcadb8840b34fd238b745 commit 514e607dd911d8bc5eabcadb8840b34fd238b745 Author: Matej Tkac Date: Fri Dec 8 16:11:21 2017 +0100 [MIPv6] Fixed IPv4 Home Address Option Change-Id: I1c09ac390d5a40c92fc30cf114a3a13359b46eee Reviewed-on: https://code.wireshark.org/review/24738 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d96ef7ed05a9f3219742699988faae3889334c85 commit d96ef7ed05a9f3219742699988faae3889334c85 Author: Martin Mathieson Date: Sun Dec 3 13:49:36 2017 +0000 Allow switching direction in LTE RLC graph Change-Id: I1681089aebe7f00b2b84ece00c53a3bf8769d50b Reviewed-on: https://code.wireshark.org/review/24682 Petri-Dish: Martin Mathieson Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=f8203771ec1580013e8de21e6286a33c330f08e3 commit f8203771ec1580013e8de21e6286a33c330f08e3 Author: Marko Hrastovec Date: Fri Dec 8 20:36:10 2017 +0100 Typing error correction for CAT002 settings selection. Two settings had the same string "Select the CAT001 version". One should be CAT002. Change-Id: Iee6204a1064af786338d1b53c7b983763b985a0c Reviewed-on: https://code.wireshark.org/review/24745 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=157ea91f2eb583a1f5815b4fb076ce78498617b8 commit 157ea91f2eb583a1f5815b4fb076ce78498617b8 Author: Jakub Zawadzki Date: Fri Dec 8 18:52:34 2017 +0100 oss-fuzzshark: fix compilation. /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:268:58: error: too few arguments to function call, expected 2, have 1 fuzz_handle = get_dissector_handle(FUZZ_DISSECTOR_TARGET); ~~~~~~~~~~~~~~~~~~~~ ^ /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:133:1: note: 'get_dissector_handle' declared here Change-Id: I6c6e25017f0045b833d9249c9648145893fe0439 Reviewed-on: https://code.wireshark.org/review/24742 Petri-Dish: Jakub Zawadzki Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=2cee4f432feddc5deb48154a97fcb63823b4e6b4 commit 2cee4f432feddc5deb48154a97fcb63823b4e6b4 Author: Jakub Zawadzki Date: Fri Dec 8 19:29:33 2017 +0100 Try to fix win32 build, add ui/packet_range.h include. add ui/packet_range.h include to try to fix win32 build, compilation log: export_sslkeys.c 99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73): error C2143: syntax error: missing ')' before '*' (compiling source file C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c) [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj] 99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73): error C2081: 'packet_range_t': name in formal parameter list illegal (compiling source file C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c) [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj] 99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73): error C2143: syntax error: missing '{' before '*' (compiling source file C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c) [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj] 99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73): error C2059: syntax error: ')' (compiling source file C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c) [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj] Change-Id: I58c77fdcbe3fe2e738601c4ef97596c7774704ec Reviewed-on: https://code.wireshark.org/review/24743 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=5d6315fefe6f2ffb1cafb3ad12522a57b43876ba commit 5d6315fefe6f2ffb1cafb3ad12522a57b43876ba Author: AndersBroman Date: Fri Dec 8 16:01:33 2017 +0100 [SCTP] Export of reassembled PDU uses wrong tvb. Change-Id: I87ff6ef54dff5900a4a92406c87693fec6d9f692 Reviewed-on: https://code.wireshark.org/review/24737 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=8aa14236f8b0ea69901ea9ed87ebabd0d278e973 commit 8aa14236f8b0ea69901ea9ed87ebabd0d278e973 Author: Guy Harris Date: Fri Dec 8 00:30:55 2017 -0800 Have the frame_tvbuff.c routines not use the global cfile. Have the routines that create them take a pointer to a struct packet_provider_data, store that in the tvbuff data, and use it to get the wtap from which packets are being read. While we're at it, don't include globals.h in any header files, and include it in source files iff the source file actually uses cfile. Add whatever includes that requires. Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229 Reviewed-on: https://code.wireshark.org/review/24733 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=f29b3deb6d867b16fb8bc4bd5f66a5b6326a6727 commit f29b3deb6d867b16fb8bc4bd5f66a5b6326a6727 Author: Gizem Yurdag??l Date: Thu Dec 7 09:16:53 2017 +0300 PROFINET: AdjustMAUType-Extension and CheckMAUTypeExtension disections are added. According to specification, AdjustMAUTypeExtension is a subblock for adjusting MAUTypeExtension. CheckMAUTypeExtension is a subblock for checking MAUTypeExtension. Change-Id: Ia90f204887a2e9871bc71e24978ab0095cc0fe1f Reviewed-on: https://code.wireshark.org/review/24718 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Birol Capa Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=48e65c4af4e35c90d7cbc9fb789ecc6e740b300b commit 48e65c4af4e35c90d7cbc9fb789ecc6e740b300b Author: Guy Harris Date: Thu Dec 7 20:33:22 2017 -0800 Hand the packet provider functions to epan_new(). Have separate packet_provider_data structures and packet_provider_funcs structures; the latter holds a table of functions that libwireshark can call for information about packets, the latter holds the data that those functions use. This means we no longer need to expose the structure of an epan_t outside epan/epan.c; get rid of epan/epan-int.h. Change-Id: I381b88993aa19e55720ce02c42ad33738e3f51f4 Reviewed-on: https://code.wireshark.org/review/24732 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=797d2f6a87607b146a2ef62e1ff501031dce8212 commit 797d2f6a87607b146a2ef62e1ff501031dce8212 Author: Guy Harris Date: Thu Dec 7 19:31:43 2017 -0800 Move the frame_set stuff back into the capture_file structure. libwireshark now expects an epan_t to be created with a pointer to a "packet provider" structure; that structure is opaque within libwireshark, and a pointer to it is passed to the callbacks that provide interface names, interface, descriptions, user comments, and packet time stamps, and that set user comments. The code that calls epan_new() is expected to provide those callbacks, and to define the structure, which can be used by the providers. If none of the callbacks need that extra information, the "packet provider" structure can be null. Have a "file" packet provider for all the programs that provide packets from a file. Change-Id: I4b5709a3dd7b098ebd7d2a7d95bcdd7b5903c1a0 Reviewed-on: https://code.wireshark.org/review/24731 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0baa4458c5780b143ad4479d387202ddf4add06f commit 0baa4458c5780b143ad4479d387202ddf4add06f Author: Jakub Zawadzki Date: Thu Dec 7 21:56:11 2017 +0100 sharkd: add sharkd_get_frame() to get frame_data, optimize. Add sharkd_get_frame() wrapper to limit number of cfile usage. Don't get frame_data when not needed. Change-Id: I24b96b5b184196e9dbf632c0891b2954c8281eed Reviewed-on: https://code.wireshark.org/review/24728 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=847585f938a525fb32ee4a0227cc500316facc34 commit 847585f938a525fb32ee4a0227cc500316facc34 Author: Gerald Combs Date: Thu Dec 7 18:20:19 2017 -0800 More QVector fixes. Change-Id: I710f9c9d5391a8f1252cc02fdd263a8dfedb31f6 Reviewed-on: https://code.wireshark.org/review/24730 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=683087628b5ef63343f6e572289b8e90a3dd245b commit 683087628b5ef63343f6e572289b8e90a3dd245b Author: Gerald Combs Date: Thu Dec 7 14:52:34 2017 -0800 Qt: Fix ByteViewText compilation for Qt < 5.5. Older versions of Qt don't let you pass a QVector to QVector::append. Change-Id: I58d62c44aa915d4ffb8319e08db85eee069ecbb2 Reviewed-on: https://code.wireshark.org/review/24729 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=038aa2a616db5ba658bee25dee5e55a716d4984a commit 038aa2a616db5ba658bee25dee5e55a716d4984a Author: Jakub Zawadzki Date: Wed Dec 6 21:10:29 2017 +0100 Add fuzzshark to cmake/autotools. Add fuzzshark target to make sure that oss-fuzzshark always build. Change-Id: I802b679c18023daa1475a54bae722b5e90c72a59 Reviewed-on: https://code.wireshark.org/review/24716 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=8687fca8a821f95075e8c365c7422f157845787b commit 8687fca8a821f95075e8c365c7422f157845787b Author: Jakub Zawadzki Date: Thu Dec 7 20:37:54 2017 +0100 sharkd: fix coding style. Change-Id: I62ff3f358d1efa3065077b0a913ba614f67f3fd7 Reviewed-on: https://code.wireshark.org/review/24727 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=42b191a65770dbad2d418dc62d0a58b9dd4e5f31 commit 42b191a65770dbad2d418dc62d0a58b9dd4e5f31 Author: Dario Lombardo Date: Thu Dec 7 17:06:33 2017 +0100 wsjsmn: use SPDX identifier. Change-Id: Iefdfd06b3b063a0d497587142996f2cd986d413f Reviewed-on: https://code.wireshark.org/review/24724 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=be8a40005328d74815491b3536b85fe9e532243e commit be8a40005328d74815491b3536b85fe9e532243e Author: Gerald Combs Date: Fri Nov 25 12:50:46 2016 -0600 Qt: Use QTextLayout in ByteViewText. Use QTextLayout to draw each line in ByteViewText instead of drawing fragments ourselves. Build our pixel-to-byte-offset map when we draw our first line, which should hopefully make it more accurate. This should fix layout and hover issues on some systems. Start moving common code to DataPrinter. Mark prefs.gui_hex_dump_highlight_style GTK+ only. Bug: 11844 Change-Id: Ifda16ae7dc1a5ea22570c0bfd0eb20cee621bfc9 Reviewed-on: https://code.wireshark.org/review/24717 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=f8b19c6eecbf241ecede5b85811a772469cea0df commit f8b19c6eecbf241ecede5b85811a772469cea0df Author: Alexis La Goutte Date: Thu Dec 7 09:33:27 2017 +0000 transum(plugins): no previous prototype for function 'is_dcerpc_stream' [-Wmissing-prototypes] Change-Id: I3f60eae17b305e2d8982bba5f56d41121676555c Reviewed-on: https://code.wireshark.org/review/24723 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=024e7dc8afb1d84365eeaaeadf029b242eac827f commit 024e7dc8afb1d84365eeaaeadf029b242eac827f Author: Alexis La Goutte Date: Thu Dec 7 09:28:39 2017 +0000 mongo: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I60ee2a37ff166b80ce11cf1c12e9c575bba85529 Reviewed-on: https://code.wireshark.org/review/24722 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Derick Rethans Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=244aab31ee83c72aa0cefae650abec40ff1fd753 commit 244aab31ee83c72aa0cefae650abec40ff1fd753 Author: Dario Lombardo Date: Wed Dec 6 22:29:19 2017 +0100 profinet: removed unused var. Some compilers complain about it: - clang (all) - gcc 6 - gcc 7 ../plugins/profinet/packet-dcerpc-pn-io.c:2608:27: error: unused variable 'pn_io_mau_type_extension' [-Werror,-Wunused-const-variable] static const range_string pn_io_mau_type_extension[] = { Change-Id: Iaffdad31c4ecd7459d07a74e3e2665058c9ff9ba Reviewed-on: https://code.wireshark.org/review/24715 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b59c39b271e1cb39e4faa54f1af4bfcc2a602807 commit b59c39b271e1cb39e4faa54f1af4bfcc2a602807 Author: Jakub Zawadzki Date: Wed Dec 6 19:51:18 2017 +0100 frame user comments: move to epan, add support for user comments in sharkd. Change-Id: Id15edc60177b160fd09cae99de1c9e01e17d9421 Reviewed-on: https://code.wireshark.org/review/24714 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=038fe4c2d44da58ca626cc0fb63c482ced660f84 commit 038fe4c2d44da58ca626cc0fb63c482ced660f84 Author: Jakub Zawadzki Date: Wed Dec 6 19:06:34 2017 +0100 oss-fuzzshark: fix handler of epan->get_frame_ts to fix build. Fix oss-fuzzshark build after [1834dca3654ccec238bae130715871be3d8fa344]: Move the parts of a capture_file used by libwireshark to a new structure. I really need to integrate oss-fuzzshark with build system... Change-Id: I75595db392acfbdb7885975e458d8b434830cfec Reviewed-on: https://code.wireshark.org/review/24713 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=2a385334eafb4385c25845ab6114338cc160c27e commit 2a385334eafb4385c25845ab6114338cc160c27e Author: Kevin Cernekee Date: Sun Dec 3 16:09:17 2017 -0800 netlink-netfilter: Add NFQA_CT and NFEXP conntrack dissectors Add support for the netlink messages used by userspace conntrack helpers. Change-Id: I37d3829399834f578a0ab0f08eab99f119445ff5 Reviewed-on: https://code.wireshark.org/review/24695 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=27f7bbbec20966c671eeb094caad0399f54d8203 commit 27f7bbbec20966c671eeb094caad0399f54d8203 Author: gizem.yurdagul Date: Tue Dec 5 13:14:06 2017 +0300 PROFINET: AdjustPeerToPeerBoundary disection is added. According to specification, AdjustPeerToPeerBoundary is a subblock for adjusting the peer to peer boundary. Change-Id: I4036aa08509300e0b8533c94b991c9a21077f634 Reviewed-on: https://code.wireshark.org/review/24710 Reviewed-by: Birol Capa Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=99ea13988da6a6e5234aa4f5f3614b9aacfe1c5b commit 99ea13988da6a6e5234aa4f5f3614b9aacfe1c5b Author: Gerald Combs Date: Tue Dec 5 11:31:05 2017 -0800 Qt: Speed up the splash overlay. Instead of blurring the main welcome screen during startup, draw a dark band under the progress bar. This reduces the startup time a bit here. Port over a date check from the GTK+ UI. Change-Id: I997d0fd2e4320702fe85ee2aea02ce835a423df9 Reviewed-on: https://code.wireshark.org/review/24711 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=abcb7ec8750a263d0307bc41d86b798e5ae02966 commit abcb7ec8750a263d0307bc41d86b798e5ae02966 Author: Gerald Combs Date: Wed Nov 29 17:25:53 2017 -0800 Convert the file set dialog treewidget to a treeview+model. Add a FilesetEntryModel and use it in FileSetDialog. This should be faster than using a QTreeWidget. Move dialog updates and date calculations out of the "add file" loop. Bug: 11280 Bug: 14242 Change-Id: I702cef4fe91e739695fe805dc5e496bf3db411f1 Reviewed-on: https://code.wireshark.org/review/24708 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=5eb07b35d430b68c6d816476190035e0774f18d2 commit 5eb07b35d430b68c6d816476190035e0774f18d2 Author: AndersBroman Date: Tue Dec 5 09:28:16 2017 +0100 [profile.c] glist_fre_full() is 2.28, include glib-compat.h Change-Id: I4b4e39de55a30352aa965653bcdf2429efb9e146 Reviewed-on: https://code.wireshark.org/review/24709 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9b7dd3ca2045ad1187311197abe003161c816b5c commit 9b7dd3ca2045ad1187311197abe003161c816b5c Author: Pascal Quantin Date: Mon Dec 4 21:57:08 2017 +0100 dumpcap.c: cap_pipe_read() returns a ssize_t whatever the platform (CID 1424899) Change-Id: I9c157e1ed7264d787c26ca60bbbe32edfc99bff8 Reviewed-on: https://code.wireshark.org/review/24706 Petri-Dish: Pascal Quantin Reviewed-by: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a7603a1f684f0ae5a2084530d44e37f29ee9e41f commit a7603a1f684f0ae5a2084530d44e37f29ee9e41f Author: Guy Harris Date: Mon Dec 4 13:44:09 2017 -0800 Fix loop bounds check. Fix indentation while we're at it. Change-Id: If8acaa944fd4c1aae848faa3a99f7566e003e801 Reviewed-on: https://code.wireshark.org/review/24707 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b3f0004af7e203df2d5d887a72fe7af7b9c217e2 commit b3f0004af7e203df2d5d887a72fe7af7b9c217e2 Author: AndersBroman Date: Mon Dec 4 13:20:19 2017 +0100 Use g_list_prepend() it's faster. Change-Id: I950901c56df230826a6011a6dcf34195b11fa61a Reviewed-on: https://code.wireshark.org/review/24702 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=48841d0b5b10382ac7064c0704c5e346100fb08f commit 48841d0b5b10382ac7064c0704c5e346100fb08f Author: Bruno Verstuyft Date: Mon Dec 4 12:08:52 2017 +0100 DOCSIS: Fixing typos Change-Id: I25684534dee48158ea0cc1e960808e30cc1376d5 Reviewed-on: https://code.wireshark.org/review/24701 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=585a57ea1ec547a26a335a56db3c68c2789cdd11 commit 585a57ea1ec547a26a335a56db3c68c2789cdd11 Author: AndersBroman Date: Mon Dec 4 10:54:07 2017 +0100 [decode_as.c] Use g_list_prepend() insted of g_list_append, it's faster. Change-Id: I56c4a7948da48d02c81c5cf30187a6eeb973db77 Reviewed-on: https://code.wireshark.org/review/24700 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d747900bc88d2f40b434a7c5b5d8762e789087ea commit d747900bc88d2f40b434a7c5b5d8762e789087ea Author: AndersBroman Date: Mon Dec 4 10:37:32 2017 +0100 [tap-rtp-common.c] Change g_list_append() to g_list_prepend(). Change-Id: I6ecc6658f75056db55dc68497956019a52fad0e6 Reviewed-on: https://code.wireshark.org/review/24699 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=72c2256633e37b7bbec0ea72e90e27a0267bef8d commit 72c2256633e37b7bbec0ea72e90e27a0267bef8d Author: Jo??o Valverde Date: Mon Dec 4 07:28:49 2017 +0000 make-dissectors: Fix null pointer dereference for error condition Found by scan-build. Change-Id: I89b56bac951ccb7054d494592928306a860f9e5e Reviewed-on: https://code.wireshark.org/review/24697 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d3a3b0ba27fc46a48273f8f311e1b7fd751fcbc5 commit d3a3b0ba27fc46a48273f8f311e1b7fd751fcbc5 Author: Pavel Strnad Date: Sun Dec 3 10:28:35 2017 +0100 tshark: fix pdml export for LUA cases - bug fix for wrong level introduced in SHA-1:b8ead953 - fix indent for Close off fake wrapper protocol Change-Id: Iccb10af8f3ac1604fc5582d730f2fd39ffaeb1c0 Reviewed-on: https://code.wireshark.org/review/24681 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=7a957952dc03cd0283a7e8a9fc8ff1daaf012713 commit 7a957952dc03cd0283a7e8a9fc8ff1daaf012713 Author: Guy Harris Date: Sun Dec 3 22:12:23 2017 -0800 Let a "past the on-the-network length" exception terminate dissection. Don't make sure we have the full server entry before trying to dissect it; that way, a malformed frame that was really too short on the network (as opposed to being cut short by a snapshot length) will get reported as such. Change-Id: Ib7f0d909645a698162ebcd9b3fe8dd2d520983b7 Reviewed-on: https://code.wireshark.org/review/24696 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=3944f881f4fea1c7e94ed77d5723a41f495c880b commit 3944f881f4fea1c7e94ed77d5723a41f495c880b Author: Juanjo Martin Date: Fri Dec 1 12:56:47 2017 +0100 RTPS: Added new PIDs to Security Change-Id: I91ffb48ac5435d4eb45b60f8083762b2151de2c3 Reviewed-on: https://code.wireshark.org/review/24671 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e5f884c8b0a1af4a84a7f4aeb0b22d033fd1c6fb commit e5f884c8b0a1af4a84a7f4aeb0b22d033fd1c6fb Author: Martin Mathieson Date: Fri Dec 1 20:14:49 2017 +0000 Show retx prev and next framenum types as chevrons Change-Id: I1641c70130a7562db9ea099770d8b5a7fe6e5532 Reviewed-on: https://code.wireshark.org/review/24676 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5350fd741f0ceafdea69b3ec6b04565b47146822 commit 5350fd741f0ceafdea69b3ec6b04565b47146822 Author: Martin Mathieson Date: Sun Dec 3 20:26:05 2017 +0000 RLC LTE graph: add comments clarifying tracer limitation Change-Id: Ib6a79689ced9377b1ac00513810db2e86d26d83f Reviewed-on: https://code.wireshark.org/review/24690 Petri-Dish: Martin Mathieson Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f411ab39886c5b372371b939311d9cab54a9a183 commit f411ab39886c5b372371b939311d9cab54a9a183 Author: Guy Harris Date: Sun Dec 3 21:37:25 2017 -0800 Get rid of cfile-int.h. Change-Id: I6e2349a082e542e4020afafe4cf65b596259e868 Reviewed-on: https://code.wireshark.org/review/24694 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ccc55bc80cb8965a73fae980d6e1babf6d8a8823 commit ccc55bc80cb8965a73fae980d6e1babf6d8a8823 Author: Guy Harris Date: Sun Dec 3 21:33:59 2017 -0800 Put the structure of a capture_file back in cfile.h. The split isn't necessary now that epan no longer uses the capture_file structure. Change-Id: Ia232712a2fb5db511865805518e8d03509b2167f Reviewed-on: https://code.wireshark.org/review/24693 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1834dca3654ccec238bae130715871be3d8fa344 commit 1834dca3654ccec238bae130715871be3d8fa344 Author: Guy Harris Date: Sun Dec 3 21:01:18 2017 -0800 Move the parts of a capture_file used by libwireshark to a new structure. Embed one of those structures in a capture_file, and have a struct epan_session point to that structure rather than to a capture_file. Pass that structure to the routines that fetch data that libwireshark uses when dissecting. That separates the stuff that libwireshark expects from the stuff that it doesn't look at. Change-Id: Ia3cd28efb9622476437a2ce32204597fae720877 Reviewed-on: https://code.wireshark.org/review/24692 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=02944c412b4d9d7661c0a2b3eb9df44d632878ee commit 02944c412b4d9d7661c0a2b3eb9df44d632878ee Author: Guy Harris Date: Sun Dec 3 19:18:38 2017 -0800 Use cfile fields for some frame_data pointers. Those fields weren't being used in TShark/TFShark/rawshark/sharkd, so we can use them, instead of defining our own static variables. This makes the non-Wireshark code paths a bit more like the Wireshark code paths. Change-Id: I55da4cf525e37598f314efca22f20d3e80cb547c Reviewed-on: https://code.wireshark.org/review/24691 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=461c8a7b44a2853d2ad3ae3d0586b4f21b9feab8 commit 461c8a7b44a2853d2ad3ae3d0586b4f21b9feab8 Author: Guy Harris Date: Sun Dec 3 12:23:12 2017 -0800 This also looks inside a capture_file structure. Change-Id: I6c4de5212028643fa34c5d939608b592f554f2bd Reviewed-on: https://code.wireshark.org/review/24689 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=dc64ce86719ab634f7f05b785f9ebe154ec886d4 commit dc64ce86719ab634f7f05b785f9ebe154ec886d4 Author: Guy Harris Date: Sun Dec 3 12:19:23 2017 -0800 Clean up dissection of server entries in SAP responses. Have the top-level protocol tree item for a server entry cover the entire entry, rather than just the server name. Have the server name be just another entry under that top-level item. Change-Id: I8089f3e132a0f388c87ba04caa3d15f5146c2303 Reviewed-on: https://code.wireshark.org/review/24688 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=8ffc939b54cbfdda4698bafb60ebd0856a575853 commit 8ffc939b54cbfdda4698bafb60ebd0856a575853 Author: Guy Harris Date: Sun Dec 3 11:08:18 2017 -0800 Add cfile-int.h. Change-Id: I6132dc0322d3ac85e89ac853ab6139244d610dd5 Reviewed-on: https://code.wireshark.org/review/24687 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=eb8ffb74e27523492855268abf5cb45927ffdb04 commit eb8ffb74e27523492855268abf5cb45927ffdb04 Author: Guy Harris Date: Sun Dec 3 10:53:58 2017 -0800 Use cfile.h to define the capture_file type. Have cfile-int.h declare the structure, and use it in files that directly access the structure. Have cfile.h just incompletely declare the structure and include it rather than explicitly declaring it in source files or other header files. Never directly refer to struct _capture_file except when typedeffing capture_file. Add #includes as necessary, now that cfile.h doesn't drag in a ton of Change-Id: I7931c8039d75ff7c980b0f2a6e221f20e602a556 Reviewed-on: https://code.wireshark.org/review/24686 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=114c989fb37b25671d8886458b206f11471b3277 commit 114c989fb37b25671d8886458b206f11471b3277 Author: Gerald Combs Date: Sun Dec 3 16:56:44 2017 +0000 [Automatic update for 2017-12-03] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4a3a5f62e5024a4df19c12296ddd67012c9ff5c7 Reviewed-on: https://code.wireshark.org/review/24683 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=40fc796818ffa8476ff0868c39ecb2375a4e6ace commit 40fc796818ffa8476ff0868c39ecb2375a4e6ace Author: Guy Harris Date: Sat Dec 2 22:23:39 2017 -0800 Fix the configuration check for remote-capture support in libpcap. In autotools, if we find pcap_open(), define HAVE_PCAP_REMOTE, so we build the remote capture support. In both autotools and CMake, only check for pcap_setsampling() if we have pcap_open(), as the compile fails if we have pcap_setsampling() but don't have remote capture. Change-Id: I0e7b78a2d372ea658a19ed2f6493532928c36872 Reviewed-on: https://code.wireshark.org/review/24680 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0455040c0e26b9b76d10efa8c321099989dc7b7e commit 0455040c0e26b9b76d10efa8c321099989dc7b7e Author: Uli Heilmeier Date: Sat Dec 2 21:50:58 2017 +0100 LDP: Add support for MP2MP FEC As stated in https://tools.ietf.org/html/rfc6388#section-3.2 MP2MP uses the same structure as the P2MP FEC element. Bug: 13171 Change-Id: Ia619deac6075f5eb27dff2144edbbb60b440cc46 Reviewed-on: https://code.wireshark.org/review/24677 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c4af29ceb2485a356f97ce7d3b1d1693c76588f6 commit c4af29ceb2485a356f97ce7d3b1d1693c76588f6 Author: Alexis La Goutte Date: Thu Nov 23 22:38:34 2017 +0100 MPLS: Add Media Access Control (MAC) Address Withdrawal over Static Pseudowire (RFC 7769 Bug: 14208 Change-Id: I80beda971b3727566c107dba0efdee0291529c42 Reviewed-on: https://code.wireshark.org/review/24560 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Francesco Fondelli Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e77dac09f14623d41050a9652e6a79fd12bbb28a commit e77dac09f14623d41050a9652e6a79fd12bbb28a Author: gizem.yurdagul Date: Fri Dec 1 15:38:06 2017 +0300 PROFINET: AdjustDCPBoundary disection is added. According to specification, AdjustDCPBoundary is a sub block for adjusting the DCP boundary. Change-Id: I2515e2b3592ff0e5e67487b1785db41015964b21 Reviewed-on: https://code.wireshark.org/review/24673 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=28b6616ea0d39cc699e4db9bccbb7948a55c7239 commit 28b6616ea0d39cc699e4db9bccbb7948a55c7239 Author: Gerald Combs Date: Fri Dec 1 11:13:18 2017 -0800 Get rid of some void pointers. Explictly struct _capture_file * in epan_session and its callbacks. Change-Id: I63703015c661a08f3350a7448a7bcdaf98f119dc Reviewed-on: https://code.wireshark.org/review/24675 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=219c5463d121a2ed51820fdda60a48e3fa27c6ca commit 219c5463d121a2ed51820fdda60a48e3fa27c6ca Author: Craig Jackson Date: Thu Nov 30 00:33:10 2017 -0500 TDS: Improve TDS7 Prelogin request/response handling - Fix detection of TDS7 Prelogin responses to have fewer false positives. This was causing regular responses to be recognized as Prelogin responses if they happened to begin with a DONEINPROC token. - Define symbolic constents for the Prelogin options. - Apply the version_convert processing to the relevant prelogin options as well as to the loginack_progversion. - Correct the display of the program version in version_convert. - Factor out the setting of tds7_version so it can be called from the dissect_tds7_login as well as dissect_tds_login_ack_token. This is needed to correctly handle tokens which come before the loginack token in the login response. - Fix the wording of a comment in my last commit. Change-Id: I57615bbb1e780db37cda25d8d5d7f964f68b337e Reviewed-on: https://code.wireshark.org/review/24664 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=c9348e1a703949def837c3a07f4ecb019d87eba2 commit c9348e1a703949def837c3a07f4ecb019d87eba2 Author: Kenneth Soerensen Date: Fri Dec 1 15:54:22 2017 +0100 ZigBee: Correct Smart Energy Publish Block Thresholds and endianess Change-Id: I1007fdff01b370c06a8ccfb1145fd162ffde9a94 Reviewed-on: https://code.wireshark.org/review/24674 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5320bdd00e8139a833e67dae228f444761c02391 commit 5320bdd00e8139a833e67dae228f444761c02391 Author: Juanjo Martin Date: Fri Dec 1 13:30:32 2017 +0100 RTPS: Fixed a quick typo in a hf item Change-Id: I71315900a4fd5130ab051854bc70dbc4ba9afc2b Reviewed-on: https://code.wireshark.org/review/24672 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=290fd76af6d2bd1dbc07f4f0b20f71ee8d6e73b3 commit 290fd76af6d2bd1dbc07f4f0b20f71ee8d6e73b3 Author: AndersBroman Date: Fri Dec 1 12:34:27 2017 +0100 [glib-compat] #include "ws_attributes.h" needed to handle _U_ Change-Id: Ie7aa8ef0a2ec8e65947e214488809d0df0ee015b Reviewed-on: https://code.wireshark.org/review/24670 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8606062cb38373f7e594bbaa812fb19719d7e6ef commit 8606062cb38373f7e594bbaa812fb19719d7e6ef Author: James Ko Date: Wed Nov 22 11:05:48 2017 -0800 dumpcap: enable capture of pcapng from pipe Reads pcapng blocks from a pipe. Section header blocks are parsed for endianess. All other blocks only have the general block header parsed for type and length, and then endianess converted if necessary. Outputs all blocks using the original endianess format so none of the other block types or options require parsing. Change-Id: I2f4f0175013d8fc2cda42a63e7deacad537951e3 Bug: 11370 Reviewed-on: https://code.wireshark.org/review/24536 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1683dd11e76f01760665ab15cd9204fa19923238 commit 1683dd11e76f01760665ab15cd9204fa19923238 Author: Darien Spencer Date: Thu Nov 30 20:20:29 2017 +0200 RRC: Improve C-RNTI resolving Now also trying to resolve C-RNTIs in FACH from the global RNTIs map Change-Id: If9ce5b73d6855271c15001fd73d8acaaaf9d1864 Reviewed-on: https://code.wireshark.org/review/24665 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a3a906d663cdda569ab09ce71742d0f470f26d74 commit a3a906d663cdda569ab09ce71742d0f470f26d74 Author: Pau Espin Pedrol Date: Thu Nov 30 15:07:17 2017 +0100 packet-rsl.c: Use value-string in RXLEV and RXQUAL fields RXLEV and RXQUAL fields in RSL "Uplink Measurements" use same scale format (0-63, 0-7) as RXLEV and RXQUAL in RR. RXQUAL value-string is moved to packet-gsm_a_common.c in order to use it in both protocols. Change-Id: Idadd9505225353fec76b9605e2045a5222669475 Reviewed-on: https://code.wireshark.org/review/24663 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=48e68367d9d0de933648c93fba9996993848aa5f commit 48e68367d9d0de933648c93fba9996993848aa5f Author: Darien Spencer Date: Thu Nov 30 15:43:00 2017 +0200 rrc: Remove unused GTree Change-Id: I137ac55cd99e659db9d9a496cc82f4427300765d Reviewed-on: https://code.wireshark.org/review/24662 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=a6d0ffca86662357893c2ba6986964cb341a73d1 commit a6d0ffca86662357893c2ba6986964cb341a73d1 Author: Pascal Quantin Date: Thu Nov 30 09:31:43 2017 +0100 RRC: reset strbuf pointer after its use While we are at it, let's add a partial dissection of PLMN-IdentityWithOptionalMCC-r6 IE. Bug: 14248 Change-Id: I20b76bc74c248914db21629f8ce77799fccb1612 Reviewed-on: https://code.wireshark.org/review/24661 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6a00fa767fec78020203e1f53062c6a2e5a117c6 commit 6a00fa767fec78020203e1f53062c6a2e5a117c6 Author: Peter Wu Date: Thu Nov 30 03:39:14 2017 +0000 http2: select fields from Decompressed header tab when possible The "Decompressed header" tab contains some human-readable text, but no field was associated with it. Instead, the fields were attached to raw compressed headers which, all with the same offset and length. Ensure that each byte in the decompressed header tab is accounted for. The only fields that are still pointing to the raw compressed buffer is the http2.header field (covering a full raw header), the representation type (a few bits, at most 1 octet) and the index length (guessed length, an exact value is probably not worth the cpu cycles). Change-Id: Ic0118e9ed583841a2d353f8b8c28dcafea3401f2 Reviewed-on: https://code.wireshark.org/review/24660 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=bb4726abf220e5223a8eee8120bae14ef2f1a4a4 commit bb4726abf220e5223a8eee8120bae14ef2f1a4a4 Author: Peter Wu Date: Thu Nov 30 01:10:07 2017 +0000 Qt: fix crash when selecting field with composite data The HTTP2 decompressed headers tab is composed from multiple TVBs, these have a null "real_data" pointer. Do not access it directly but use an accessor which Does The Right Thing???. Change-Id: Ib974fed9782d60aa2b91e3e712ba737000b79b4b Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView") Reviewed-on: https://code.wireshark.org/review/24658 Petri-Dish: Peter Wu Reviewed-by: Alexander Gryanko Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=3d6da018e7969c23b172b37a9f556696783ca9b1 commit 3d6da018e7969c23b172b37a9f556696783ca9b1 Author: Michael Mann Date: Wed Nov 29 20:03:22 2017 -0500 CIP Safety: base packet length can be used Slight adjustment to I394fa91a5cfa1700fb12441d4884c0367b39df8b Change-Id: Id097a39265f49a79f3d39855ef6b5c95ffe8c4f1 Reviewed-on: https://code.wireshark.org/review/24654 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f6521b295dbb1c5a53dd4d43743b8165010de34f commit f6521b295dbb1c5a53dd4d43743b8165010de34f Author: Juanjo Martin Date: Wed Nov 29 10:06:30 2017 +0100 RTPS: Added link to the DCPSPublicationData frame number Added a link inside the Topic Information feature so users can quickly go to the discovery data associated with the writer sending this submessage. Change-Id: I3a89630a275e5d857e8bbf86dc5171c9f0921d5b Reviewed-on: https://code.wireshark.org/review/24646 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=aeb864e685d608183b53113816a8aa1ba0409080 commit aeb864e685d608183b53113816a8aa1ba0409080 Author: Juanjo Martin Date: Wed Nov 29 10:42:47 2017 +0100 RTPS: Added new endpoints for the Security spec Change-Id: Ia827c43b161a2b64804b0eac220b428eb853d255 Reviewed-on: https://code.wireshark.org/review/24647 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ec0ffc043fac4792ccf3055ea18190894a520577 commit ec0ffc043fac4792ccf3055ea18190894a520577 Author: Gerald Combs Date: Wed Nov 29 14:17:54 2017 -0800 RRC: Fixup wmem_strbuf usage. Instead of calling wmem_strbuf_finalize, which frees the strbuf structure and makes it unsuitable for reuse, call wmem_strdup + wmem_strbuf_truncate. This fixes a heap-use-after-free. Bug: 14248 Change-Id: I498e10ed9f9afa7fa72b607eb43f68c710de777e Reviewed-on: https://code.wireshark.org/review/24650 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3ed5b4fb67edc6829ece7adf542f44e9a75185af commit 3ed5b4fb67edc6829ece7adf542f44e9a75185af Author: Gerald Combs Date: Tue Nov 28 16:03:11 2017 -0800 Reformat some top-level ui files. Make sure each ui/*.[ch] file uses identical (4-space) indentation. Remove ui/.editorconfig. Fix up other formatting where needed. SPDX-abbreviate the license blurb in the files we modify. Change-Id: I5faa1c1eae9a4b6220422ad8e4ba7a341c7deb1f Reviewed-on: https://code.wireshark.org/review/24632 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b59dc97dfef3bcce71cd393f4d2493e7ba1a8f82 commit b59dc97dfef3bcce71cd393f4d2493e7ba1a8f82 Author: Gerald Combs Date: Wed Nov 29 14:46:10 2017 -0800 NetBIOS: Don't write past the beginning of a buffer. Make sure process_netbios_name doesn't write past the beginning of its buffer. Bug: 14249 Change-Id: Idb294ba2362e48b879bc4c0c0ddaf64fcf1b5d72 Reviewed-on: https://code.wireshark.org/review/24651 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=52365a55e4e726176e884e510123fbbfe7801346 commit 52365a55e4e726176e884e510123fbbfe7801346 Author: Martin Mathieson Date: Sun Nov 26 20:41:50 2017 +0000 LTE L2 protocols: add FT_FRAMENUM_TYPE for most FT_FRAMENUM fields. Missed out some that would probably result in too many links. Added FT_FRAMENUM_RETRANS_PREV and FT_FRAMENUM_RETRANS_NEXT to enum, these display as arrows like REQUEST and RESPONSE do. Change-Id: I6e8d222955f2ba59a713e8a389837b55a1c7f262 Reviewed-on: https://code.wireshark.org/review/24600 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=986a084de361d2d3844f9af8874b7e3a2a636b46 commit 986a084de361d2d3844f9af8874b7e3a2a636b46 Author: Jo??o Valverde Date: Sat Nov 18 15:19:01 2017 +0000 Update .gitignore Change-Id: I3b5f343f241a7d0571ddd7a0647c45c2bef28c73 Reviewed-on: https://code.wireshark.org/review/24648 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=d1a6742d9bcd76c0d4e52c7353d0740463e45bb0 commit d1a6742d9bcd76c0d4e52c7353d0740463e45bb0 Author: AndersBroman Date: Wed Nov 29 09:18:10 2017 +0100 [L2TP] Enhance info col layout. Change-Id: Ib16b71b47f97516db55412f1881d995706e723b1 Reviewed-on: https://code.wireshark.org/review/24645 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=140282cbf012fb3eac20d24c388d12e8a875501e commit 140282cbf012fb3eac20d24c388d12e8a875501e Author: Peter Wu Date: Wed Nov 29 02:55:32 2017 +0000 cmake: fix build with cmake 2.8.11.2 "file(GENERATE ...)" is only supported since 2.8.12, since the list of sources is fixed at cmake time, just use "file(WRITE ...)". Change-Id: If4a547803ab536cf8d131045692d3e58301b0cd2 Fixes: v2.5.0rc0-1763-gfe0c2b0485 ("Rewrite make-dissector-reg.py in C") Reviewed-on: https://code.wireshark.org/review/24638 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d7bab0b46e72eb30e50ad1b6a0b56275394406b4 commit d7bab0b46e72eb30e50ad1b6a0b56275394406b4 Author: AndersBroman Date: Wed Nov 29 09:14:32 2017 +0100 [packer-ehdlc.c] Mark some fields as generated, enhance info col. Change-Id: I10241389dbd3c463b36c5dfcd7a4fa929a1bbf6a Reviewed-on: https://code.wireshark.org/review/24644 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e1850de29442f4de75e43544dfadd855e36dd6b3 commit e1850de29442f4de75e43544dfadd855e36dd6b3 Author: Peter Wu Date: Wed Nov 29 02:54:47 2017 +0000 autotools: remove unnecessary include directory for epan Since v2.1.0rc0-2202-g6b54fbf3bf, wslua is also not necessary in the include path, so remove that too. Change-Id: Ib227b71b08da9fc397d6618b60100ab819570b86 Reviewed-on: https://code.wireshark.org/review/24640 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=3c6cb2f85646b12562a596bd5dbd8f2b9e672606 commit 3c6cb2f85646b12562a596bd5dbd8f2b9e672606 Author: Peter Wu Date: Wed Nov 8 02:49:38 2017 +0000 cmake: match include directories with autotools Match closer the behavior of autotools which does not include epan in its include paths by default. Change-Id: I885bc7942490a5674c6ac75f9a8ea221555e3784 Reviewed-on: https://code.wireshark.org/review/24639 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=952dc3ae323a5e39ffce19252784ace1f17d24ab commit 952dc3ae323a5e39ffce19252784ace1f17d24ab Author: Jo??o Valverde Date: Tue Nov 28 19:57:09 2017 +0000 make-dissectors: Use g_file_set_contents() Also add some more errors checks, we only pass valid files to make-dissectors. Change-Id: I9c068e47f35ee6c3da0112ee9ce905af35030475 Reviewed-on: https://code.wireshark.org/review/24625 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9cd82c3753d9d0241b89801dc10f9baaa4dd5d4f commit 9cd82c3753d9d0241b89801dc10f9baaa4dd5d4f Author: Juanjo Martin Date: Thu Nov 23 16:31:43 2017 +0100 RTPS: Added DataWriter QoS to topic information feature Change-Id: Ib8d9c4f75543ed05c1bf69589069ed2425e3394e Reviewed-on: https://code.wireshark.org/review/24555 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f10237f0a512139c44f840bf363353c755aa8818 commit f10237f0a512139c44f840bf363353c755aa8818 Author: Juanjo Martin Date: Mon Nov 27 15:40:52 2017 +0100 RTPS: Added locator and product version to Micro DDS Change-Id: Icfb1c505865f5a32152cc056173baae8f7d01f36 Reviewed-on: https://code.wireshark.org/review/24603 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=67ffa3cf7da172df53a821d5cd4c1a6a849f4087 commit 67ffa3cf7da172df53a821d5cd4c1a6a849f4087 Author: Gerald Combs Date: Tue Nov 28 11:04:16 2017 -0800 Threads: Set lifetimes and add a compatibility routine. Join the protocol registration threads so that they call g_thread_unref which in turn detaches/terminates the thread. This gets rid of many TSan and DRD errors here. The remaining ones appear to be false positives. Add g_thread_new to glib-compat (untested). Change-Id: I4beb6746ed08656715cf7870ac63ff80cf1ef871 Reviewed-on: https://code.wireshark.org/review/24619 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=041e3e7c27c78308d0d515171f52a39f8260782b commit 041e3e7c27c78308d0d515171f52a39f8260782b Author: Pascal Quantin Date: Tue Nov 28 22:08:18 2017 +0100 CIP Safety: check packet length before dissecting Otherwise we can call CRC functions with a negative value, leading to a segmentation fault. Bug: 14250 Change-Id: I394fa91a5cfa1700fb12441d4884c0367b39df8b Reviewed-on: https://code.wireshark.org/review/24621 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e29378b030dc58948263abead03f7e1a49e3f415 commit e29378b030dc58948263abead03f7e1a49e3f415 Author: Peter Wu Date: Wed Nov 29 03:00:34 2017 +0000 Qt: fix role check in AStringListListUrlProxyModel::data Change-Id: I7c683449155f7dcb63731e6575cf92c30be78934 Fixes: v2.5.0rc0-1841-gd865871627 ("Qt: About Dialog move to QTreeView and fix copy") Reviewed-on: https://code.wireshark.org/review/24637 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=18b240d7d2d8a138a1837dcbcd3b0706353a007f commit 18b240d7d2d8a138a1837dcbcd3b0706353a007f Author: Gerald Combs Date: Tue Nov 28 17:48:59 2017 -0800 Normalize ui/win32 indentation and switch to SPDX. Switch ui/win32/console_win32.[ch] to 4-space indentation to match the other files in that directory. Remove ui/.editorconfig. SPDX-abbreviate the license blurb in all files in that directory. Change-Id: I68aa5a3ae7ae184ea8d27d9dba06b968ac3d2472 Reviewed-on: https://code.wireshark.org/review/24636 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d1a79a6cac7a4d5a3f3fd3f92330686047e34d2c commit d1a79a6cac7a4d5a3f3fd3f92330686047e34d2c Author: Guy Harris Date: Tue Nov 28 17:39:54 2017 -0800 Get rid of --with-pcap-remote; always check for pcap_open. No need to make it an option; it's not an option in CMake. Change-Id: I43dd25b9b73e6f372bd6612aea6372b950b0ca74 Reviewed-on: https://code.wireshark.org/review/24635 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e74800d3479a937692114aa026522ff4768d9ad2 commit e74800d3479a937692114aa026522ff4768d9ad2 Author: Guy Harris Date: Tue Nov 28 17:28:55 2017 -0800 Use a separate Boolean to indicate whether we have a duration. Reserved values are a bit of a hack. (If this were Swift....) Change-Id: I243e8f497345f44d94af6106287556b8831fba92 Reviewed-on: https://code.wireshark.org/review/24633 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ae65dc20eae7e21010b6e33b2cb11724d403acd9 commit ae65dc20eae7e21010b6e33b2cb11724d403acd9 Author: Guy Harris Date: Tue Nov 28 15:06:13 2017 -0800 Report the actual *error* for CANT_GET_INTERFACE_LIST. CANT_GET_INTERFACE_LIST does *NOT* mean "No remote interfaces found.", as in "there are no remote interfaces"; a NULL return from get_remote_interface_list() and an err value of 0 means that. CANT_GET_INTERFACE_LIST means "something bad happened and the error string says what it is". Display that error string, so when people report problems: https://github.com/the-tcpdump-group/libpcap/issues/666 they'll give the actual error message, and I'll fix my breakage of the rpcap protocol negotiation: https://github.com/the-tcpdump-group/libpcap/commit/2972769d03dd60d4bce233a12d77a3464f0d9dc4 rather than just wondering what the problem was and asking the reporter of the problem for more information. Report anything other than "there are no remote interfaces" as an error, not a warning. Change-Id: Ia9381953d080e037254f21e47ee7ecc4619b7254 Reviewed-on: https://code.wireshark.org/review/24627 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=2fdbeb0d785db8d63849f0205313aed4d085f3ec commit 2fdbeb0d785db8d63849f0205313aed4d085f3ec Author: Gerald Combs Date: Tue Nov 28 14:37:46 2017 -0800 Gen-bugnote: Replace backslashes with {backslash}. Change-Id: I12b479fedf9ca54b600919a4586c4b4c43464589 Reviewed-on: https://code.wireshark.org/review/24626 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=1e892a1db65ebfb7ea49bf7e605d2c2d9dfbe9c3 commit 1e892a1db65ebfb7ea49bf7e605d2c2d9dfbe9c3 Author: Stig Bj??rlykke Date: Tue Nov 28 14:36:09 2017 +0100 Qt: Small layout improvement in preferences Make PacketList settings look like the StatusBar settings. Remove unneeded QVBoxLayout. Change-Id: Id1910b2cf4cc5d3ab52d2abd781045ad4033469a Reviewed-on: https://code.wireshark.org/review/24618 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=e73135a9f1a275d940b8e97060b3c25d92176948 commit e73135a9f1a275d940b8e97060b3c25d92176948 Author: Kenneth Soerensen Date: Tue Nov 28 10:42:57 2017 +0100 ZigBee: Add remaining attributes from Smart Energy Metering cluster Change-Id: I7ca67ceaf72a1e4cc1c7b3ccc8fed79fafefe575 Reviewed-on: https://code.wireshark.org/review/24614 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9c6d2af0aef5b13cb739794ccabc09d27241fde0 commit 9c6d2af0aef5b13cb739794ccabc09d27241fde0 Author: Michael Mann Date: Tue Jul 25 16:01:42 2017 -0400 Qt: Add support for DCE/RPC in Decode As DCE/RPC is a FT_GUID type, but has some special handling. "Regular" FT_GUID dissector tables still not supported. Bug: 13122 Change-Id: I328776ffe5bbe87ecfbe6719f04d18b1b237a583 Reviewed-on: https://code.wireshark.org/review/24602 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=da910203539afc7fa37caa17ccf41674d7953ab0 commit da910203539afc7fa37caa17ccf41674d7953ab0 Author: Stig Bj??rlykke Date: Tue Nov 28 12:52:27 2017 +0100 ui: Sort profile names Not all file systems returns a sorted list of filenames, so we need to sort the entries before using the list in the Profile popup and the Manage Profiles dialog. Change-Id: Ic1f2bfa77fb47fb8c406d891aee49b484876b4f7 Reviewed-on: https://code.wireshark.org/review/24615 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=87a8877007471c0e3113c21c8675bfe5d81b1289 commit 87a8877007471c0e3113c21c8675bfe5d81b1289 Author: Stig Bj??rlykke Date: Tue Nov 28 13:58:51 2017 +0100 gitignore: Add packaging/macosx/PkgInfo Change-Id: I630fa8ae0c3d5f078922b4d6cb2ee064c31bd35e Reviewed-on: https://code.wireshark.org/review/24616 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=944a3c3a582864ca7cbe2bbb1af7291089ecda9c commit 944a3c3a582864ca7cbe2bbb1af7291089ecda9c Author: Jo??o Valverde Date: Sun Nov 26 08:28:36 2017 +0000 make-plugin-reg: Update modification time to plugin.c Let the build system handle the dependencies. Make sure to update the file even if nothing has changed to avoid re-running the script every time. Change-Id: I2229c13578a6278a04152825c98d8b889081dcb7 Reviewed-on: https://code.wireshark.org/review/24597 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=d8658716277bbb2378819d25997ce0646b72c9c2 commit d8658716277bbb2378819d25997ce0646b72c9c2 Author: Roland Knall Date: Fri Nov 24 15:46:30 2017 +0100 Qt: About Dialog move to QTreeView and fix copy - Fix an issue, where the url was opened twice on Linux - Make the filter case insensitive if so wished for - Allow the copy to either copy the selected column (just Copy) or copy the complete row, with tab separation - Move to QTreeView instead to make it similar to the rest of the tables Change-Id: Ie6064f2ad2014e24546553c5febe63358e2f69ec Reviewed-on: https://code.wireshark.org/review/24570 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d35ed012ce62fae4344e80a0df3742619a4eaa0f commit d35ed012ce62fae4344e80a0df3742619a4eaa0f Author: Peter Wu Date: Sat Nov 11 04:29:15 2017 +0000 TLS13: update for draft -22 (Server Hello, HRR, CCS, NST) Draft -22 moved the server version to an extension and makes HRR look like a SH. SH is now interpreted as TLS 1.2. Detecting TLS 1.3/HRR requires scanning SH extensions before parsing the message, so do that. Changes: - Add draft 22 version identifier. - Recognize special Server Hello magic for HRR. - Dissect SupportedVersions for SH/HRR, rename the field to match spec. - Recognise new Server Hello format (including legacy fields). - Move version detection up to handshake message dissection to allow HRR (disguised as SH) to be detected as such. DTLS does not have HRR and fragmentation makes it harder, so use its version as usual. - Ignore ChangeCipherSpec again for draft 22 (do not add expert info). - Allow NST ticket_nonce to be empty. Change-Id: I9d5f7dba173e1b5c901bf9a6917c65520ee60a2f Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/24340 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7eb2c7dbc7b0cddb18297268677e3dc9a073f320 commit 7eb2c7dbc7b0cddb18297268677e3dc9a073f320 Author: Guy Harris Date: Sun Nov 26 01:31:56 2017 -0800 *Always* set pinfo->p2p_dir from the wtap_pkthdr. Don't just do it if we're actually creating protocol tree information for the "Frame" protocol; that information is used even when we're *not* creating protocol tree information for "Frame". Bug: 14245 Change-Id: Ie3754e15754fb6a73529e20d8fa68956e206a994 Reviewed-on: https://code.wireshark.org/review/24593 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=78ed5f34f574d6400e63b7f8c4f358c7c69a24fa commit 78ed5f34f574d6400e63b7f8c4f358c7c69a24fa Author: Peter Hamilton Date: Fri Nov 24 18:08:16 2017 +0200 NBAP: Always map NB-CC to CRNC-CC Now maps for all channels and not only E-DCH Change-Id: I51099e887830e5142b58fd624775d395e354b012 Reviewed-on: https://code.wireshark.org/review/24572 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c0514ac4330695c66d346067d99a429c2bb6abbe commit c0514ac4330695c66d346067d99a429c2bb6abbe Author: Michael Mann Date: Sat Nov 25 23:42:47 2017 -0500 Bugfix DCE/RPC Decode As for GTK. An attempt at optimization broke GTK DCE/RPC Decode As because DCE/RPC dissector tables aren't FT_UINT type. The "optimization" was trying to retrieve dissector handle from FT_UINT typed dissector table. Move retrieval of dissector handle to under FT_UINT check Change-Id: Id81cd79db60263155392aaac0c796a6484ef7504 Reviewed-on: https://code.wireshark.org/review/24589 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9b7ad9c20e3dd81b66251a058874a2c63e42b458 commit 9b7ad9c20e3dd81b66251a058874a2c63e42b458 Author: Gerald Combs Date: Sun Nov 26 08:16:15 2017 +0000 [Automatic update for 2017-11-26] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I2963633f86a87209eca574db52663ebbe732f9d9 Reviewed-on: https://code.wireshark.org/review/24590 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=076fee6e636db2123744c1ecf004e9c6ff9b0a8c commit 076fee6e636db2123744c1ecf004e9c6ff9b0a8c Author: Erwin Rol Date: Sat Nov 25 17:34:24 2017 +0100 artnet: Fix ArtPollReply spare/style field order In the ArtPollReply the field order of the style and 3 spare bytes was wrong, according artnet spec 1.4 page 25 the order should be spare, spare, spare, style. Change-Id: I5683e5a8e97643a7bb1962178178c175d485098c Signed-off-by: Erwin Rol Reviewed-on: https://code.wireshark.org/review/24584 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=18657caf8d5c5388190b29c0cc1b4b94c997d5dc commit 18657caf8d5c5388190b29c0cc1b4b94c997d5dc Author: Michael Mann Date: Sat Nov 25 14:18:06 2017 -0500 Add information about pre-commit script to Developer Guide. Bug: 9553 Change-Id: I19505c3c05585a05877e9f0db06400ebb8b33985 Reviewed-on: https://code.wireshark.org/review/24585 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fdeaaa362a84f49af176b1beb4753396dee8ea18 commit fdeaaa362a84f49af176b1beb4753396dee8ea18 Author: Martin Mathieson Date: Sat Nov 25 15:08:08 2017 +0000 LTE MAC stats: make display filter field work Change-Id: I76b97f4f67ba63f7479dffc1cf1267b39cefa4fa Reviewed-on: https://code.wireshark.org/review/24582 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=89ae2826d6158e62fe3db9c18d01721a2168e9cc commit 89ae2826d6158e62fe3db9c18d01721a2168e9cc Author: Stig Bj??rlykke Date: Fri Nov 24 19:17:55 2017 +0100 Qt: AccordionFrame users keyPressEvent() fixes - Declare keyPressEvent() virtual. - Give keyPressEvent() to parent when done. Change-Id: If1c05e86a5ab71dd239c025cdb2bcfb1ef484811 Reviewed-on: https://code.wireshark.org/review/24573 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e1f3d9dcbee7dac3ad06d9a0ca2e63896e1f7305 commit e1f3d9dcbee7dac3ad06d9a0ca2e63896e1f7305 Author: Martin Mathieson Date: Fri Nov 24 21:07:38 2017 +0000 LTE RLC Stats: make display filter field work. Change-Id: Ic3c9ebb176bcc7c3973aca382c270aacac7283af TODO: the same for LTE MAC Stats.. Reviewed-on: https://code.wireshark.org/review/24577 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=cf110add653b5c0ed531f306b8d429a41c860d0a commit cf110add653b5c0ed531f306b8d429a41c860d0a Author: Martin Mathieson Date: Fri Nov 24 19:24:32 2017 +0000 RLC LTE stats: show UE and channel bw properly Change-Id: I49edf405d61b15ba451f291c32b8fc3126a7e9d7 Reviewed-on: https://code.wireshark.org/review/24575 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f23a6e193f90a02542c85cad07cb073abd6eb678 commit f23a6e193f90a02542c85cad07cb073abd6eb678 Author: Michael Mann Date: Sat Nov 25 00:32:23 2017 -0500 packet-iwarp-mpa.c: Stop FPDU dissection if the ULPDU_LENGTH field does NOT contain what is expected Bug: 14236 Change-Id: I15f1bc70978d1e5ae3b4bba1ff87b590726cfaa1 Reviewed-on: https://code.wireshark.org/review/24578 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d2a7a806ff811628eb75e415c8811600420b14d5 commit d2a7a806ff811628eb75e415c8811600420b14d5 Author: Martin Heusse Date: Fri Nov 24 20:15:04 2017 +0100 Re-sync with osmocom version of the file with new types Change-Id: Iae231de172eabe135ca3acd7f82b1683eebaee38 Reviewed-on: https://code.wireshark.org/review/24574 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1ecad014202cff8f5f32bb91767240978a276ed0 commit 1ecad014202cff8f5f32bb91767240978a276ed0 Author: Roland Knall Date: Fri Nov 24 11:14:23 2017 +0100 Qt: About - implement copy&paste and urls Make the URLs clickable again, and allow the copy/paste of selected entries via context menu Change-Id: I619059ca77c54314df31364de8ee7fce9dbc3ed3 Reviewed-on: https://code.wireshark.org/review/24569 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=1392b92d7cfd28a3491596a92ee38be73d1a5fcd commit 1392b92d7cfd28a3491596a92ee38be73d1a5fcd Author: Craig Jackson Date: Fri Nov 17 14:05:57 2017 -0500 TDS: Fix packet reassembly for TDS 4.x/TDS5.x streams. The existing TDS "netlib" packet reassembly code only handles situations where the netlib header has a valid non-zero packet number. This does not always occur for older clients, in particular when TDS 7 is not in use. This has been tested with: DB-Library 4.6 talking to Sybase CT-Library 5.0 talking to Sybase jConnect 5.0 talking to Sybase .NET 4.5 talking to SQL Server with TLS login Freetds CT-Library talking to SQL Server with unencrypted login - I'm not sure of the version of this, in the protocol it appears as 8.0.341. Change-Id: I1690ba191ba3f4bd10569ab1a26dae82c5bbf260 Reviewed-on: https://code.wireshark.org/review/24470 Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0074855364047c362c6161ddd68cb206c221c893 commit 0074855364047c362c6161ddd68cb206c221c893 Author: Peter Wu Date: Fri Nov 24 00:03:53 2017 +0000 DTLS: fix decryption with EMS and client auth Similar to the TLS fix in v2.5.0rc0-1805-gd790c524b4, ensure that the correct master secret is calculated when extended_master_secret is enabled with client auth and a decrypted RSA premaster secret. Bug: 14243 Change-Id: I3d8cecef0f0cc3ec73537053489adc2d0d45c947 Reviewed-on: https://code.wireshark.org/review/24564 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9ac02f18c981c175be83b41bded7462aef128a3d commit 9ac02f18c981c175be83b41bded7462aef128a3d Author: Peter Wu Date: Fri Nov 24 00:05:05 2017 +0000 packet: ensure consistent layer number for heuristics dissector DTLS decryption works for single-pass dissection, but breaks in the second pass. Turns out that "curr_layer_num" has decremented in the second pass, resulting in a failure to lookup the decrypted data. This decryption issue was triggered by v2.3.0rc0-3740-ge1f84f985e ("Fix Decode As for protocols that may use tunneling."). The first time the UDP dissector invokes "dissector_try_heuristic", the second time "call_heur_dissector_direct". The first one increments "curr_layer_num", so do the same in the second case. Change-Id: I62679b817b02f42d073cfc07b88ec36d5bec5f04 Bug: 14243 Fixes: v1.11.4-rc1-468-g2cfda31ff0 ("Change the signature of dissector_try_heuristic() to return hdtbl_entry") Reviewed-on: https://code.wireshark.org/review/24565 Petri-Dish: Peter Wu Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b99677dea95a8886429574713d5a78dde9181959 commit b99677dea95a8886429574713d5a78dde9181959 Author: Stig Bj??rlykke Date: Thu Nov 23 13:18:37 2017 +0100 Qt: Add key event to reject changes in AddressEditorFrame Also give focus to the name field. Change-Id: I409d48e513c04b510f1e3d838c05e1518e6d2e9d Reviewed-on: https://code.wireshark.org/review/24547 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=73c01d6d0562f138b3aad83b6b2dcf8d3f09dcee commit 73c01d6d0562f138b3aad83b6b2dcf8d3f09dcee Author: Roland Knall Date: Wed Nov 22 16:54:32 2017 +0100 Qt: Rewrite the About dialog to use models Rewrite of the about dialog, to use QTableView and Models instead of HTML files. Everything is now model based, and the model is generic enough to support any variation which can be put into a QStringList row. Change-Id: Ie32bf66b2fe2a7754c0bf07205a7b068d46b0070 Reviewed-on: https://code.wireshark.org/review/24534 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8fa4a440a8f85ff9078c7c28e3747decede0848e commit 8fa4a440a8f85ff9078c7c28e3747decede0848e Author: Jo??o Valverde Date: Thu Nov 23 02:06:35 2017 +0000 GTK: Remove packet editor Removes limited experimental feature for deprecated UI. Change-Id: Ib3ccfae89dd2a674ebbde346a442fa1cf6587f26 Reviewed-on: https://code.wireshark.org/review/24563 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e7b12d85502e2827aacde3efd0821298bd8284ce commit e7b12d85502e2827aacde3efd0821298bd8284ce Author: Martin Mathieson Date: Thu Nov 23 21:44:01 2017 +0000 LTE RLC graph: 'r' should reset, not zoom out Change-Id: I34ad795b5c4f3f5d47b357d3af1de1f4b5fe481b Reviewed-on: https://code.wireshark.org/review/24561 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=cb80d6c97bbcfe6260ed64d3d747ca26047ce1b4 commit cb80d6c97bbcfe6260ed64d3d747ca26047ce1b4 Author: Jo??o Valverde Date: Thu Nov 23 22:12:44 2017 +0000 make-dissectors: Use more shell for build recipe Change-Id: Ib7b5c74c0cca5bd6b9036a36a2df85ed0d0dcabb Reviewed-on: https://code.wireshark.org/review/24562 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=cd6e56e03a6a26805f64140003f149732309966f commit cd6e56e03a6a26805f64140003f149732309966f Author: Ivan Ermakov Date: Thu Nov 16 19:22:24 2017 +0300 ZigBee ZCL Price Cluster dissector Added Price cluster payload dissectors. Change-Id: I4771221e1260e446a7708adb9c862cddb8755d59 Reviewed-on: https://code.wireshark.org/review/24549 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=76d7b7a519792fb51ad6694ddc11a506247aba40 commit 76d7b7a519792fb51ad6694ddc11a506247aba40 Author: Michael Mann Date: Thu Nov 23 14:22:45 2017 -0500 Qt: Add menu option to remove all packet comments Bug: 14186 Change-Id: I8793078ea50379b2f9697787e6b7a8ab2d9e3e0e Reviewed-on: https://code.wireshark.org/review/24558 Petri-Dish: Michael Mann Reviewed-by: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=ea6204cab695d5a9d15fc5b26379a8eb8a8fc463 commit ea6204cab695d5a9d15fc5b26379a8eb8a8fc463 Author: Alexis La Goutte Date: Sat Nov 11 16:11:55 2017 +0100 BGP: display ESI 10bytes value (and not a decoded value) Bug: 14200 Change-Id: I6d8ac6aae952db21e69fa323fb1e74782d95d1c4 Reviewed-on: https://code.wireshark.org/review/24362 Reviewed-by: Alexis La Goutte Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ef17ead7723676ba4719a08af25dacb449f8695b commit ef17ead7723676ba4719a08af25dacb449f8695b Author: Michael Mann Date: Thu Nov 23 10:04:20 2017 -0500 BGP: Add Path Identifier to IPv6 NLRI Bug: 14241 Change-Id: I5e66b034cf5cd14e2557e5b7bfa3045c2232d1ae Reviewed-on: https://code.wireshark.org/review/24553 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=6cc3abfc55ed4c7db7e423c4552c4f3c16749fa4 commit 6cc3abfc55ed4c7db7e423c4552c4f3c16749fa4 Author: AndersBroman Date: Thu Nov 23 17:31:38 2017 +0100 [make-dissectors] Need to link with wsutil Change-Id: I033352dfb1836d646db5a3db04b125d2058867c9 Reviewed-on: https://code.wireshark.org/review/24556 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=0780975703887f4fb21cfaa0c5869cb49daea482 commit 0780975703887f4fb21cfaa0c5869cb49daea482 Author: Jo??o Valverde Date: Mon Nov 20 11:31:18 2017 +0000 make-dissectors: Another attempt to use newlines instead of spaces Change-Id: I7ff5a0ea3eb3f7f56debc54aee6d5147815acc1b Reviewed-on: https://code.wireshark.org/review/24552 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=121654beb22b6e16023da17fff54743fb555d37d commit 121654beb22b6e16023da17fff54743fb555d37d Author: Jo??o Valverde Date: Thu Nov 23 13:08:17 2017 +0000 checkAPIs: Skip make-dissectors.c Change-Id: Ief976c2958b98dc2a5b637bc20dd5f7f993b7124 Reviewed-on: https://code.wireshark.org/review/24551 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=3a80970f12e829a26aa558385c508c19c9374d24 commit 3a80970f12e829a26aa558385c508c19c9374d24 Author: Jo??o Valverde Date: Thu Nov 23 12:13:55 2017 +0000 make-dissectors: Fallback to the newly introduced glib-compat replacement Change-Id: Ieb7ea23d8109a60dce7dd0c848438e93d671a3c9 Reviewed-on: https://code.wireshark.org/review/24546 Petri-Dish: Jo??o Valverde Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=80424d135f105d236438e89d9b60f30209574c87 commit 80424d135f105d236438e89d9b60f30209574c87 Author: Stig Bj??rlykke Date: Thu Nov 23 13:34:19 2017 +0100 Qt: Make InterfaceFrame use QFrame It's no need for InterfaceFrame to use AccordionFrame. Change-Id: Iccef1bcf919d7e5ec2bf818802ef68c1faf4e4a3 Reviewed-on: https://code.wireshark.org/review/24548 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=243fa8c4416c00ff1958fe837c401028ef7ca901 commit 243fa8c4416c00ff1958fe837c401028ef7ca901 Author: AndersBroman Date: Thu Nov 23 14:06:34 2017 +0100 [glib-compat] g_async_queue_timeout_pop() needed for older glibs (2.31.18) Change-Id: I727c8548c29b3409fab819dce072e86153232911 Reviewed-on: https://code.wireshark.org/review/24550 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b6f5ee68f646715db094e55aa33b0810d0da1814 commit b6f5ee68f646715db094e55aa33b0810d0da1814 Author: Jo??o Valverde Date: Thu Nov 23 02:42:05 2017 +0000 make-dissectors: Don't use stdout This will prevent the file from being created with shell redirection in case of error and allow printing informational messages to stdout instead of stderr. Also improve dissectorc.c Makefile recipe to abort on errors. Change-Id: I64722927721887b57a7dbe69fd2625c2e4648ad4 Reviewed-on: https://code.wireshark.org/review/24545 Petri-Dish: Jo??o Valverde Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=db811a699d3238425a22f6b8b129c259e97262cf commit db811a699d3238425a22f6b8b129c259e97262cf Author: AndersBroman Date: Thu Nov 23 10:51:53 2017 +0100 [glib-compat] Add g_ptr_array_new_full(). Change-Id: Ic0e054cbb28106cc02f229ad4f2476b39e544378 Reviewed-on: https://code.wireshark.org/review/24544 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fe76be0b5bcbb465d4b510135922ea3302c8c705 commit fe76be0b5bcbb465d4b510135922ea3302c8c705 Author: AndersBroman Date: Wed Nov 22 17:22:52 2017 +0100 [make-dissectors] g_ptr_array_new_full() is glib 2.30.0 which we do not require. Add alternate code to fix the build for our minimum required version. Change-Id: Ia0911c5a6be3af68330ac41a3336d7d47b87b7a9 Reviewed-on: https://code.wireshark.org/review/24535 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d790c524b41907ebaa0f29afec19ee6913173129 commit d790c524b41907ebaa0f29afec19ee6913173129 Author: Peter Wu Date: Thu Nov 23 01:55:27 2017 +0000 TLS: fix decryption with EMS and client auth When extended_master_secret is enabled with client authentication, decryption using an RSA private key file would fail because the wrong master secret is derived. This happens due to an excess CertificateVerify message in the handshake hash. Bug: 14243 Change-Id: I02f8302ac4a85422f7df52a234bdddfcb5fe3307 Reviewed-on: https://code.wireshark.org/review/24543 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b4419eacce6d76f0e854280f8c20d4849ba2c067 commit b4419eacce6d76f0e854280f8c20d4849ba2c067 Author: Michael Mann Date: Wed Nov 22 19:15:18 2017 -0500 zbee_parse_uint -> proto_tree_add_item[_ret_uint] We don't need to unnecessarily wrap proto_tree_* functions. Change-Id: Id2853cfb9059cd90af81e529bcec57eba10e6ab3 Reviewed-on: https://code.wireshark.org/review/24540 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c369db08eaecfd1ad6b87d43b1b99be0224752f4 commit c369db08eaecfd1ad6b87d43b1b99be0224752f4 Author: Jo??o Valverde Date: Thu Nov 23 01:05:34 2017 +0000 Add comment with motive for dissectors.c.in Change-Id: I825d4654aa76fee7288dc98eb7a92fe136d7542e Reviewed-on: https://code.wireshark.org/review/24542 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2add5e701f3d7e397ef46f144e206fe4c127e9cb commit 2add5e701f3d7e397ef46f144e206fe4c127e9cb Author: Jo??o Valverde Date: Wed Nov 22 19:34:28 2017 +0000 make-dissectors: Print the number of functions successfully parsed Change-Id: I7364571ddc9b86efd41dcade97f843037e09f0ac Reviewed-on: https://code.wireshark.org/review/24541 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f5bc86df043d93bb76226f0bbb2c4ef5613f226e commit f5bc86df043d93bb76226f0bbb2c4ef5613f226e Author: Juanjo Martin Date: Wed Nov 15 13:00:51 2017 +0100 RTPS: Topic Information feature now available for all the submessages Before, the topic information feature showed the topic information only for DATA submessages. Now it is working for all the submessages. Change-Id: Ic2fe0ac1de2377a1db627f6498ac6d5159c9cb13 Reviewed-on: https://code.wireshark.org/review/24442 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a55a96a13ad60785f41f70a67cec2b321670b5de commit a55a96a13ad60785f41f70a67cec2b321670b5de Author: Alexis La Goutte Date: Wed Nov 22 22:08:28 2017 +0100 ssl(-utils.h): fix parameter 'src' not found in the function declaration [-Wdocumentation] Change-Id: I922a1a12d2b562594354a18af5f92b21df3ce906 Reviewed-on: https://code.wireshark.org/review/24539 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=053b41dda37d45f4fad121a272ecdf7468696d03 commit 053b41dda37d45f4fad121a272ecdf7468696d03 Author: Alexis La Goutte Date: Wed Nov 22 22:17:14 2017 +0100 wisun: fix no previous prototype for function 'proto_register_wisun/proto_reg_handoff_wisun' [-Wmissing-prototypes] Change-Id: I44751363b2e1f16a2463d7e798bedb6f59995e13 Reviewed-on: https://code.wireshark.org/review/24538 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5e17502d395f489b3a630f5538f7e78abde8e140 commit 5e17502d395f489b3a630f5538f7e78abde8e140 Author: Alexis La Goutte Date: Wed Nov 22 22:12:29 2017 +0100 802154: fix no previous prototype for function 'ieee802154_create_psie_tree' [-Wmissing-prototypes] Change-Id: I7755753aab9737967c355f4969cefc7871406b9c Reviewed-on: https://code.wireshark.org/review/24537 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=462048b2d337fd35175767762c2f67b0726c5ecd commit 462048b2d337fd35175767762c2f67b0726c5ecd Author: Ivan Ermakov Date: Tue Nov 14 15:22:54 2017 +0300 ZigBee ZDP cluster display Added cluster names to binding requests and match descriptor. Cluster IDs now display in HEX. Change-Id: I1be4339e324ba4c98ce65016f5a2e60590235d71 Reviewed-on: https://code.wireshark.org/review/24437 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=bceae3cff2c8a635ef112b3ac11f36679d77ed20 commit bceae3cff2c8a635ef112b3ac11f36679d77ed20 Author: Ivan Ermakov Date: Tue Oct 31 17:13:58 2017 +0300 ZigBee ZCL Calendar Cluster dissector Added dissectors for payloads of Calendar cluster. Change-Id: I5c71078714521e25ad4db82b7ffe5166965d5280 Reviewed-on: https://code.wireshark.org/review/24201 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b993c6f05c3a9c3bd8748ffe57928a8d790371f7 commit b993c6f05c3a9c3bd8748ffe57928a8d790371f7 Author: Dario Lombardo Date: Wed Nov 22 10:20:44 2017 +0100 sshdump: remove extra option check. This looked a bit odd since the capture filter is variable length. Removing it makes sshdump work. Change-Id: I454c6263c04019d5e8ecbecd2490dd10185f5c67 Reviewed-on: https://code.wireshark.org/review/24531 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c58aed9b73d8989ef82145626e1701769b21e705 commit c58aed9b73d8989ef82145626e1701769b21e705 Author: Dario Lombardo Date: Wed Nov 22 10:18:25 2017 +0100 sshdump: add option to prevent promiscuous mode. Bug: 14237 Change-Id: I5cecca8ed638c3935c7c77e3a304e4b0527d7fa3 Reviewed-on: https://code.wireshark.org/review/24530 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=36372a2465c94784240ba8c38b53b4eedb234868 commit 36372a2465c94784240ba8c38b53b4eedb234868 Author: Paul Offord Date: Mon Nov 20 09:49:38 2017 +0000 TRANSUM: Fix DNS-related bug and improve performance These changes significantly improve the speed and accuracy of TRANSUM. I have removed the concept of rrpd status as it wasn't being used in any significant way and created unnecessary code. The find_latest_rrpd(...) function was becoming very complex which made it difficult to optimise performance for certain protocols. To overcome this, I have introduced an equivalent function for each protocol e.g. find_latest_rrpd_smb2(...). each of these new functions has a loop that steps through the rrpd_list. I could have placed this loop one level up in the nested call and so had one loop in the code that calls the new function. However, I have found that this area is the prime cause of delays in TRANSUM execution and so I want to avoid calling these new functions with each step through the rrpd_list. Finally, I have added code to improve the handling of retransmissions. Bug: 14210 Change-Id: I038097f22a45ee74173aad1ae5732347f769b9bd Reviewed-on: https://code.wireshark.org/review/24506 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=871f75ce85b7c3d0c58e05e90d34791042a8d5b8 commit 871f75ce85b7c3d0c58e05e90d34791042a8d5b8 Author: Jo??o Valverde Date: Wed Nov 22 09:45:03 2017 +0000 make-dissectors: Remove dependency on GNU Make >= 4.0 The $(file ...) function is only available since version 4.0. Until something breaks or someone complains use the shell to write dissectors.c.in. Change-Id: Icfe260004ca04d825c370bb642fcdc4b4be8516f Reviewed-on: https://code.wireshark.org/review/24532 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2f2c2b06e2f43c2a18bf1033253ee07c4b2b427e commit 2f2c2b06e2f43c2a18bf1033253ee07c4b2b427e Author: Michael Mann Date: Mon Nov 13 08:25:49 2017 -0500 Add Zigbee encoding, ENC_ZIGBEE Add the "special handling" of length = 0xFF for single byte or 0xFFFF for uint16 value means size of field to follow is 0. Ping-Bug: 14138 Change-Id: I0baa40f63152b9420a6569ca6cc5eba638fbc790 Reviewed-on: https://code.wireshark.org/review/24428 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8d5726dccc6851aa99707f4ff3cf9d11128cd822 commit 8d5726dccc6851aa99707f4ff3cf9d11128cd822 Author: Michael Mann Date: Tue Nov 21 14:47:21 2017 -0500 Add support to handle DNS retransmissions Add a preference to the DNS dissector to specify how many seconds can elapse before a DNS query is considered a retransmission because the transaction ID is shared with a previous request. If retransmission is found, add expert info and hf_ field linking to the original request. If a retransmission of a response is found, add expert info and hf_ field linking to the original response. Bug: 14178 Bug: 13313 Change-Id: Idd77ab7f7638f5056d5690633c787a4d52285aee Reviewed-on: https://code.wireshark.org/review/24525 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a501321cbbe2a23faa04031ba1567be3d305daee commit a501321cbbe2a23faa04031ba1567be3d305daee Author: Michael Mann Date: Tue Nov 21 18:08:05 2017 -0500 Enable TCP Calculate Conversation Timestamp by default It doesn't appear to be too expensive of a calculation, so have preference enable it by default. Bug: 14182 Change-Id: I330dc99d871424d17c60ab8cff59ba0828dd069a Reviewed-on: https://code.wireshark.org/review/24529 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=86919416eefb021630a869afa1da59bbb2cbb9c3 commit 86919416eefb021630a869afa1da59bbb2cbb9c3 Author: Ivan Ermakov Date: Wed Nov 15 14:35:02 2017 +0300 ZigBee ZCL DRLC Cluster dissector Added DRLC cluster dissector: cluster, attribute and command names. Change-Id: Ic678052aaecffce3a4b8fd99d4e2b1eb91051f11 Reviewed-on: https://code.wireshark.org/review/24440 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1ae41459943496528fc5d2d54a7f945ccf9e0f89 commit 1ae41459943496528fc5d2d54a7f945ccf9e0f89 Author: Ivan Ermakov Date: Wed Nov 15 15:21:55 2017 +0300 ZigBee ZCL Energy Management Cluster dissector Added Energy Management cluster dissector: cluster, attribute and command names. Change-Id: If6985ca59c314de4eb3d439999ea31fe167bb3e7 Reviewed-on: https://code.wireshark.org/review/24441 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=641e2fc573b98917916245bfdaf3461ea82c2565 commit 641e2fc573b98917916245bfdaf3461ea82c2565 Author: Derick Rethans Date: Thu Nov 16 14:58:51 2017 +0000 Add support for MongoDB 3.6's OP_MSG to dissector Bug: 14230 Change-Id: I008a0fb60c441c5f71788d695b398b73b76c0d69 Reviewed-on: https://code.wireshark.org/review/24450 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=454a7647f54743b0986b729c8956da84e436f5dc commit 454a7647f54743b0986b729c8956da84e436f5dc Author: Jo??o Valverde Date: Tue Nov 21 22:15:29 2017 +0000 CMake: Remove duplicate PIDL files from CMakeLists.txt Change-Id: I108a95aa4da80de6c96bf83d083b5ac4acd1a6ab Reviewed-on: https://code.wireshark.org/review/24528 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=9a1a8f77e93601fa140b7d8305839455effccfff commit 9a1a8f77e93601fa140b7d8305839455effccfff Author: Alexis La Goutte Date: Mon Nov 13 16:07:34 2017 +0100 BGP: enhance display Display LACP Port Key/root Bridge Priority in Dec and Hex mSTP => MSTP Change-Id: I7079250da134e4bb60d2d5373bfdf2f31235f07a Ping-Bug: 14200 Reviewed-on: https://code.wireshark.org/review/24401 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7540ac69381518661065b33096bd448d1b4100e5 commit 7540ac69381518661065b33096bd448d1b4100e5 Author: Jo??o Valverde Date: Tue Nov 21 18:38:44 2017 +0000 Move the protocol registration routines back into libwireshark Follow-up to b695b3e2f72998d66ca4b7a6826d4ce1688060c8. Change-Id: I7e36519f2c3806c1205d05437671325080974257 Reviewed-on: https://code.wireshark.org/review/24524 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=4e63ec305bd7e8196561be58d12ee99f54eca371 commit 4e63ec305bd7e8196561be58d12ee99f54eca371 Author: Jo??o Valverde Date: Tue Nov 21 19:56:27 2017 +0000 configure: Downgrade GNU Make message to a warning There might be compatible make versions installed or the program might have a non-standard name. Change-Id: Ie9304e07da71f1f55522a0dfc539fbe9f557731d Reviewed-on: https://code.wireshark.org/review/24526 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2ad15073446ebaf59f1a9186bf1f6a5e55613d68 commit 2ad15073446ebaf59f1a9186bf1f6a5e55613d68 Author: Jakub Zawadzki Date: Tue Nov 21 18:47:18 2017 +0100 oss-fuzzshark: fix linking issues due to register_all_protocols() removed from -lepan During compilation of oss-fuzzshark (https://github.com/google/oss-fuzz/issues/1003): Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to `register_all_protocols' Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to `register_all_protocol_handoffs' After cleanup of make-dissector-reg.py [b695b3e2f72998d66ca4b7a6826d4ce1688060c8] these functions are no longer part of epan library (I really wonder why...). oss-fuzzshark need to compile and link register.c on their own. Change-Id: I79adf5c1513a0934f140bbf501c181bf14d7619b Reviewed-on: https://code.wireshark.org/review/24523 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=0b2ecccd863b577335c1c87a902783d3de158839 commit 0b2ecccd863b577335c1c87a902783d3de158839 Author: Gerald Combs Date: Mon Nov 20 12:44:17 2017 -0800 Add ThreadSanitizer configure-time options. Add ENABLE_TSAN and enable-tsan options to CMake and Autotools respectively which enable ThreadSanitizer, similar to AddressSanitizer and UndefinedBehaviorSanitizer. Change-Id: I79adf5c1516b0938f140bbf501c181bf14d7619b Reviewed-on: https://code.wireshark.org/review/24515 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=8cbde93146bfd72e98b942fe81d69300f9488dac commit 8cbde93146bfd72e98b942fe81d69300f9488dac Author: Dario Lombardo Date: Sun Nov 19 17:00:35 2017 +0100 gitlab-ci: add clang 5 and 6 builds. Change-Id: I732cee0ced4c38298660716bf8d027f6b22be885 Reviewed-on: https://code.wireshark.org/review/24494 Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=4a125fb183a5944693854edb8cf07a7bd57b90df commit 4a125fb183a5944693854edb8cf07a7bd57b90df Author: Jo??o Valverde Date: Tue Nov 21 04:09:09 2017 +0000 configure: Check for minimum required GNU Make version Change-Id: Ifb76a8426f3233e277a129e1d4e4a5ac0c832503 Reviewed-on: https://code.wireshark.org/review/24518 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=1470aeef4cd4b1660d68c2907dc7b58f9d16df58 commit 1470aeef4cd4b1660d68c2907dc7b58f9d16df58 Author: Roland Knall Date: Tue Nov 21 10:46:26 2017 +0100 Qt: Remove merge issue from Drag Drop Remove a remissent merge artefact Change-Id: I4c53d4b2adef124712091c40efccc1cad3db3301 Reviewed-on: https://code.wireshark.org/review/24521 Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=3cf73671d10a9c8f6505c57397dd833c7e3efc4f commit 3cf73671d10a9c8f6505c57397dd833c7e3efc4f Author: Guy Harris Date: Tue Nov 21 00:30:07 2017 -0800 From looking at the OpenAFS source, the RX abort code is signed. Change-Id: I79f578ee5fe4e63d5bb6adc9d90f24fac5f82b02 Reviewed-on: https://code.wireshark.org/review/24520 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=4a08c63e88715656e1d6294a8978f9573e516286 commit 4a08c63e88715656e1d6294a8978f9573e516286 Author: Stig Bj??rlykke Date: Mon Nov 20 15:15:27 2017 +0100 mqtt: Add sanity checks for MQTT v5.0 Reason Codes Check if mqtt_msg_type is within boundaries of hf_rcode and gives a valid hfindex. Change-Id: Ib8ea710d7cd6c61ec493e218d64b50f6faa720c4 Reviewed-on: https://code.wireshark.org/review/24509 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=90e236fd09d68bab09edb7b93227fc02de561a38 commit 90e236fd09d68bab09edb7b93227fc02de561a38 Author: Stig Bj??rlykke Date: Mon Nov 20 21:13:21 2017 +0100 Qt: Main Welcome hover sparkline color fix. Use the default text color for sparkline in hovered items. This makes the selected item look the same as non-selected items when hovering. This is related to g1ed38dc2. Change-Id: I96ba349067cf7d398d11425cfa5ada5e5b4d587c Reviewed-on: https://code.wireshark.org/review/24516 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=23b6028e1d729e67af5be1bb4bdbb5c88c284393 commit 23b6028e1d729e67af5be1bb4bdbb5c88c284393 Author: Gerald Combs Date: Mon Nov 20 15:42:05 2017 -0800 Qt: Remove an unused variable. Change-Id: Iba1abe66cfa4d39e95cf85b9fc866789151127f9 Reviewed-on: https://code.wireshark.org/review/24517 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=dd562b503f2ff089968283b1593496c007f854a6 commit dd562b503f2ff089968283b1593496c007f854a6 Author: Gerald Combs Date: Mon Nov 20 09:18:59 2017 -0800 Qt: Move the MIME init thread to WiresharkApplication. The Qt 4.8 "Starting a Thread" document at http://doc.qt.io/qt-4.8/threads-starting.html says, "Note that you must create the QApplication (or QCoreApplication) object before you can create a QThread." It looks like this changed some time around Qt 5.5 or 5.6, e.g. https://codereview.qt-project.org/#/c/120793/, but just to be safe move the MIME database initialization thread to WiresharkApplication. We start reading the database later than I'd like, but it's still early enough to make a difference here. QMimeDatabase was added in Qt 5.0. Add version checks. Change-Id: Ic80ebb8692e93b1e4aea7a8670f4fcf45e385b29 Reviewed-on: https://code.wireshark.org/review/24512 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=5968fc1cae5028002d4f974e0464608f73204b60 commit 5968fc1cae5028002d4f974e0464608f73204b60 Author: Jo??o Valverde Date: Mon Nov 20 19:58:46 2017 +0000 Rename UseMakeDissectorReg.cmake Change-Id: I2723e7f0309dbe21f23b65818fbea3a7eadf13d4 Reviewed-on: https://code.wireshark.org/review/24514 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=fdc3023bece20993237f8e5ae959f23fff437d69 commit fdc3023bece20993237f8e5ae959f23fff437d69 Author: Guy Harris Date: Mon Nov 20 10:06:28 2017 -0800 OpenAFS always puts out 3 bytes of padding in an ack packet. Change-Id: Ia956ac7df43c307a8d5adac5c78c894017f7f7ec Reviewed-on: https://code.wireshark.org/review/24513 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=6917ec769e4d23fe2fa212bec69c9ce9b65c1671 commit 6917ec769e4d23fe2fa212bec69c9ce9b65c1671 Author: Roland Knall Date: Mon Nov 20 09:56:26 2017 +0100 Qt: Fix various smalles issues with drag-drop Cleanup adding a filter and implement some sanity checks in the drop code Change-Id: I1778be16abdea3f93ed11fc610962c4a23f10a2f Reviewed-on: https://code.wireshark.org/review/24505 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=4fbb2df3cd160aba589dc0a576b44c2a63b4a6fe commit 4fbb2df3cd160aba589dc0a576b44c2a63b4a6fe Author: Jo??o Valverde Date: Mon Nov 20 14:47:51 2017 +0000 Revert "make-dissectors: Be more resilient with whitespace" This reverts commit ed9d08552049d061a8951f2dee5bc7b73173c14d. It's causing a segfault on our Windows buildbots. Change-Id: I3cdd31955bdec7be3ad91cff4af8dc3efdc9e8b7 Reviewed-on: https://code.wireshark.org/review/24510 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c26ad500ecf2cd04e9f0ba41402047fa1cbae678 commit c26ad500ecf2cd04e9f0ba41402047fa1cbae678 Author: Flavio Santes Date: Mon Nov 13 13:58:32 2017 -0500 dissector/mqtt: Add the MQTT v5.0 Reason Codes RCs and their text descriptions are added by this patch. We use defines for the values and descriptions because they are shared by many Control Packets, so in this patch we parameterize them to avoid writing the descriptions multiple times. Change-Id: I0afc2cbe69e8cfffa4f65df0b72f09045bb9b3a1 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24263 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=ed9d08552049d061a8951f2dee5bc7b73173c14d commit ed9d08552049d061a8951f2dee5bc7b73173c14d Author: Jo??o Valverde Date: Mon Nov 20 11:31:18 2017 +0000 make-dissectors: Be more resilient with whitespace Preemptively try to be more resilient for files with spaces in them (for Windows). Use newlines to separate file list. Clean up duplicate PIDL file entries. Change-Id: Ib506cca785836e05e4665e911de0d45ab4da1165 Reviewed-on: https://code.wireshark.org/review/24507 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=496797f0dc414ede3e0e6ac297ab7d7ed966d76a commit 496797f0dc414ede3e0e6ac297ab7d7ed966d76a Author: Alexis La Goutte Date: Wed Nov 15 14:24:58 2017 +0100 ieee1905: fix typo bandwith => bandwidth found by lintian Change-Id: Id9b113eddae5bcbcfb0c9b3d1dfb6008aa3d7269 Reviewed-on: https://code.wireshark.org/review/24502 Reviewed-by: Jaap Keuter http://cgit.osmocom.org/wireshark/commit/?id=93e7bed24ef7ddbaeac915eedf820eb0b19a62e7 commit 93e7bed24ef7ddbaeac915eedf820eb0b19a62e7 Author: Alexis La Goutte Date: Wed Nov 15 14:23:21 2017 +0100 ieee1905: fix typo addres => address found by lintian Change-Id: Idb5ee47b709e10d53192ac966b638e160cec60ea Reviewed-on: https://code.wireshark.org/review/24501 Reviewed-by: Jaap Keuter http://cgit.osmocom.org/wireshark/commit/?id=fe0c2b04853226b64a1aa17fbef6257c856e3fd9 commit fe0c2b04853226b64a1aa17fbef6257c856e3fd9 Author: Jo??o Valverde Date: Sun Nov 19 00:20:20 2017 +0000 Rewrite make-dissector-reg.py in C The output compares equal to make-dissector-reg.py and the regex should be more robust (multiline, complete start of function definition). The primary motivation is to clean up the python script. This small binary results in much cleaner code. The python script is used only to generate plugin code, therefore it is renamed. Also in my casual measurements the C code is much faster (without cache) than the python script with the cache. Change-Id: Id4e8cac3c836d56775aba4819357a95ef19bcb85 Reviewed-on: https://code.wireshark.org/review/24497 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=129cb60f56f42e58b9e589d79ac3ee317066d43e commit 129cb60f56f42e58b9e589d79ac3ee317066d43e Author: Jo??o Valverde Date: Sun Nov 19 10:15:29 2017 +0000 Remove unused dissector registration prototypes, fix typo Change-Id: Ide5d7f2241db4ac87ed516f91f0bcaca347bb546 Reviewed-on: https://code.wireshark.org/review/24496 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d17633892c9c3d25f3398487ca63592fdc973bc4 commit d17633892c9c3d25f3398487ca63592fdc973bc4 Author: Michael Mann Date: Sun Nov 19 20:26:06 2017 -0500 packet-tds.c: Correct encoding for hf_tds_colmetadata_maxbytesize It's just a FT_UINT16, not need for 2 encodings. Change-Id: I502a61a2ff2a1fd05f1efa48912119f98d10e636 Reviewed-on: https://code.wireshark.org/review/24498 Reviewed-by: Craig Jackson Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5b5584878998ed602f560fffda326670ac1c9083 commit 5b5584878998ed602f560fffda326670ac1c9083 Author: Michael Mann Date: Sun Nov 19 20:26:50 2017 -0500 README.dissector: Add note to add 2 encodings for FT_UINT_BYTES in proto_tree_add_item Change-Id: I728091998c531c992aa1b741b03e653460a0e77f Reviewed-on: https://code.wireshark.org/review/24499 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=51ff1df443c02f03d93a68a989255aa90740acc6 commit 51ff1df443c02f03d93a68a989255aa90740acc6 Author: Dario Lombardo Date: Sun Nov 19 19:06:40 2017 +0100 file-elf: remove unuseful check (found by Clang 6). error: comparison 'guint32' (aka 'unsigned int') <= 4294967295 is always true [-Werror,-Wtautological-constant-compare] Change-Id: Id1f6a0a01dd897d263f7133a0d95aaecfba31e14 Reviewed-on: https://code.wireshark.org/review/24495 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=262a84c384353b2a88a6e81cdc499ab94a8316c2 commit 262a84c384353b2a88a6e81cdc499ab94a8316c2 Author: Jo??o Valverde Date: Wed Nov 1 20:22:32 2017 +0000 Fix (and chop) static build option This sets the scope of the static build option to Wireshark support libraries only. Before the patch: Static plugins don't work with CMake and autotools. autotools static build is broken, and most likely will always be, as building Wireshark all-static is difficult and time-consuming. After the patch: For CMake Wireshark will be built with static or shared libraries and dynamic plugins. Everything just works. CMake apparently doesn't want you building static and shared libraries at the same time. For autotools Wireshark will be built with shared libraries by default. --disable-shared and --enable-static options work as usual. Dlopened plugins are not built if --disable-shared is given to configure (to disable shared libraries). This is a limitations imposed by libtool. Tested on Linux. This removes broken support for building plugins statically. Change-Id: Ib8e8176976f136eea93a2ce8f9857b6cf9bec64c Reviewed-on: https://code.wireshark.org/review/24241 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=61bd626d5d10a7cd0e2dac667bbb262452fe906f commit 61bd626d5d10a7cd0e2dac667bbb262452fe906f Author: Roland Knall Date: Sun Nov 19 17:43:02 2017 +0100 Qt: Fix Activation of menus Fixes the bug, where submenu items are not properly activated Bug: 14232 Change-Id: I007010310dfa8a6c7eba3ba8cdf3eac74701b0ba Reviewed-on: https://code.wireshark.org/review/24493 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=e9d8eba4163b515b58bfc0b8614a34876b2628a8 commit e9d8eba4163b515b58bfc0b8614a34876b2628a8 Author: Michael Mann Date: Sun Nov 19 10:11:37 2017 -0500 packet-h223.c: Ensure conversation data exists There is more potential for conversation data than previous circuit data so ensure h223 conversation data exists in retrieved conversation. Bug: 14233 Change-Id: I7074b1c110d40b4727812d0ef4f5391b6d2c0c33 Reviewed-on: https://code.wireshark.org/review/24492 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d6b3fcfeabdec2fee8804e2e7a779606dba432bd commit d6b3fcfeabdec2fee8804e2e7a779606dba432bd Author: Graham Bloice Date: Sun Nov 19 12:17:17 2017 +0000 CMake: Fix error from bab9abfb7d259e1daaf84776ed9d4d09e2469293 Fix a cut and paste error Change-Id: I28fa3644d5b7969c8009f5722f270c8fa566dd34 Reviewed-on: https://code.wireshark.org/review/24491 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=1b79315aac6f42aaff8b286792af0b53a1b61a5a commit 1b79315aac6f42aaff8b286792af0b53a1b61a5a Author: Gerald Combs Date: Sun Nov 19 08:17:12 2017 +0000 [Automatic update for 2017-11-19] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I52c4830ef81733156fa4ce0de65330c8aacd8932 Reviewed-on: https://code.wireshark.org/review/24487 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=bb47a68e0983fa4da5b607dd775e227528da1955 commit bb47a68e0983fa4da5b607dd775e227528da1955 Author: Michael Mann Date: Sat Nov 18 22:31:45 2017 -0500 Move dissect_leb128 to file-elf.c This allows for the removal of epan/dwarf.[ch] Functionality could probably be handled by an encoding (like dissect_uleb128), but for now keep it in file-elf.c as that's the only functionality currently using it. Change-Id: I84cf6af02abb3d53ea7d9b774e3313d77a1ff497 Reviewed-on: https://code.wireshark.org/review/24486 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=752d0ef753983b45142e76a71dcdf3ab3c082439 commit 752d0ef753983b45142e76a71dcdf3ab3c082439 Author: Michael Mann Date: Wed Oct 11 21:55:55 2017 -0400 dissect_uleb128 -> tvb_get_varint/proto_tree_add_item_ret_length Also update ENC_VARINT_PROTOBUF documentation while we're at it Change-Id: I72e1f9175adc0c6a8bb03ceddba04ffd4844a12e Reviewed-on: https://code.wireshark.org/review/24485 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ce8f8719004045497f95d1729f33053da43f69f8 commit ce8f8719004045497f95d1729f33053da43f69f8 Author: Graham Bloice Date: Sat Nov 18 21:53:46 2017 +0000 CMake: Fix package requirements for building docs Make ASCIIDOC and XSLTPROC packages required if building any of the HTML, PDF or CHM guides. Don't attempt to build the release notes if ASCIIDOC isn't found. Change-Id: Id61653a635f91cbaffa32fb26ddbdbc568b74528 Reviewed-on: https://code.wireshark.org/review/24483 Reviewed-by: Graham Bloice Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1097e8020ab06bbcde3e3ce6f1e324535990547b commit 1097e8020ab06bbcde3e3ce6f1e324535990547b Author: Jo??o Valverde Date: Sat Nov 18 17:43:27 2017 +0000 autotools: Library build products don't need explicit cleaning Change-Id: I5d68c05f2844d6c9ae486531b189dbf10bc09cff Reviewed-on: https://code.wireshark.org/review/24484 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f902981b2d0f845b57aa939d8c160d3bc74499ef commit f902981b2d0f845b57aa939d8c160d3bc74499ef Author: Jo??o Valverde Date: Sat Nov 18 21:51:17 2017 +0000 Fix indentation Change-Id: I558f23572dc36ba96fd1c2f904b1ac6b6c343297 Reviewed-on: https://code.wireshark.org/review/24482 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=23234ac87218ac69acb8ac2509127af4c0ff088d commit 23234ac87218ac69acb8ac2509127af4c0ff088d Author: Ivan Ermakov Date: Thu Nov 16 17:13:33 2017 +0300 ZigBee ZCL Device Management Cluster dissector Added Device Management cluster dissector: cluster, command names. Change-Id: I1ed9c53a09aed10584cd372630fbec5e661cacd8 Reviewed-on: https://code.wireshark.org/review/24449 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Martin Boye Petersen Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=bab9abfb7d259e1daaf84776ed9d4d09e2469293 commit bab9abfb7d259e1daaf84776ed9d4d09e2469293 Author: Graham Bloice Date: Sat Nov 18 20:16:32 2017 +0000 CMake: Clean up Windows build Remove options that aren't supported on Windows Don't use pkgconfig on Windows Change-Id: I79718a1c43f56a9ec88f690490931b80b727dd68 Reviewed-on: https://code.wireshark.org/review/24481 Reviewed-by: Graham Bloice Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=adc1aff0a54bb54d313ea82cfeb3cb928d8f1974 commit adc1aff0a54bb54d313ea82cfeb3cb928d8f1974 Author: Guy Harris Date: Sat Nov 18 10:36:54 2017 -0800 The header is host-endian, not little-endian. Note that. Change-Id: I7fc2874026430c3d7e8633c48ee0558ad69d5c9a Reviewed-on: https://code.wireshark.org/review/24480 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=c42878bea8ea41954d3bae75ab749ac7881201c9 commit c42878bea8ea41954d3bae75ab749ac7881201c9 Author: Guy Harris Date: Sat Nov 18 10:27:11 2017 -0800 Reformat comment giving Kerberos 4 specification. Change-Id: I06350d56aeedf0c0cb1c72f3597a093a6f97847c Reviewed-on: https://code.wireshark.org/review/24479 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=241008c8611dc9bdcfe26af4f9d4258126d9b261 commit 241008c8611dc9bdcfe26af4f9d4258126d9b261 Author: Guy Harris Date: Sat Nov 18 10:22:45 2017 -0800 URL for the document. Change-Id: I9b381f923599f7b4750b21053cdfb3b1d72bce22 Reviewed-on: https://code.wireshark.org/review/24478 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7d4e0870708fc72df281214e3a6284c7a6aba282 commit 7d4e0870708fc72df281214e3a6284c7a6aba282 Author: Jo??o Valverde Date: Sat Nov 18 15:02:16 2017 +0000 Update .gitignore Change-Id: Ia066511bc27618ee8e0a55e046a6d9437a4c3175 Reviewed-on: https://code.wireshark.org/review/24477 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=b695b3e2f72998d66ca4b7a6826d4ce1688060c8 commit b695b3e2f72998d66ca4b7a6826d4ce1688060c8 Author: Jo??o Valverde Date: Thu Nov 16 23:55:57 2017 +0000 Begin cleanup of make-dissector-reg.py Move registration code to a new register.c file so it is readable. Dissector load points are stored in a generated function pointer array instead. Simplify python script somewhat by not interleaving the plugin and dissector logic. Change-Id: I5ec21270f4e1550a5c911efa7f0dc4fc7fcb13a5 Reviewed-on: https://code.wireshark.org/review/24474 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d8e2bee9ea84ec5123d2023f32c0f0d191834d32 commit d8e2bee9ea84ec5123d2023f32c0f0d191834d32 Author: Alexis La Goutte Date: Mon Nov 13 08:16:07 2017 +0100 .mailmap: update (of November) Change-Id: Ia42fe05bbc250944441576a3b7894839f4fe6ed2 Reviewed-on: https://code.wireshark.org/review/24452 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=925214a3e750eefb62630cf68e168c31b014fd72 commit 925214a3e750eefb62630cf68e168c31b014fd72 Author: Richard Sharpe Date: Fri Nov 17 20:55:53 2017 -0800 ieee1905: Fix the incorrect dissection of radio operation restriction The dissection was really wrong. Fixed now I have seen captures. Change-Id: I038fbf8786306fad9c65c87aa5d58c155113c442 Reviewed-on: https://code.wireshark.org/review/24476 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c2b9c90367e2182bc7eea4832e5a235c97b18133 commit c2b9c90367e2182bc7eea4832e5a235c97b18133 Author: Gerald Combs Date: Fri Nov 17 15:13:48 2017 -0800 Qt: Use QThreadPool instead of QThread. I'm not sure how many Qt worker threads we're going to create at startup, but using a thread pool is simple enough. Change-Id: I66c3e1e628f8c38c8e3322e0c01ee5fccda2a98e Reviewed-on: https://code.wireshark.org/review/24473 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a398a9573d36285fc4c6c8ddf5e8d42a150e0fc8 commit a398a9573d36285fc4c6c8ddf5e8d42a150e0fc8 Author: Cedric Izoard Date: Wed Nov 15 18:52:33 2017 +0100 ieee80211: Complete fixed size fields for SAE authentication SAE authentication (used for mesh-point) introduced new non IE fields (aka fixed size fields) that require explicit parsing. The tricky part is that some of those fields don't have a fixed size... - 'scalar' and 'finite field element' size depend of the group used. Retrieve size of all groups supported by wpa_supplicant. - 'anti-clogging token' size is not specified. Bug: 14222 Change-Id: Id0aa8790c55b21b2797ba131de9e46c32519e2cc Reviewed-on: https://code.wireshark.org/review/24446 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=18d49f467d21741394190c0b15f9430df14f4c19 commit 18d49f467d21741394190c0b15f9430df14f4c19 Author: Roland Knall Date: Fri Nov 17 14:39:03 2017 +0100 Qt: Properly reset the byteview Reset the byteview on every load of a capture file, and on every start/reset of a capture Change-Id: I0edd30ffddc64484bc6f009d99dfc6fc1a3ceb59 Reviewed-on: https://code.wireshark.org/review/24468 Reviewed-by: Roland Knall Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ed68e05014018672ba6675c8b970b4471fbb68c5 commit ed68e05014018672ba6675c8b970b4471fbb68c5 Author: Pascal Quantin Date: Fri Nov 17 23:09:09 2017 +0100 IEEE 802.11: fix an infinite loop Presumably the element length is unsigned, otherwise it can be negative and reincrement tag length. Bug: 14231 Change-Id: I26d339aea7588a489b4252b67c212810029bff0e Reviewed-on: https://code.wireshark.org/review/24472 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=658578a5b935d12c86b4181f9949da54a4ba7e0f commit 658578a5b935d12c86b4181f9949da54a4ba7e0f Author: Gerald Combs Date: Fri Nov 17 11:18:02 2017 -0800 Qt: Initialize QMimeDatabase in a worker thread. As part of its initialization, QMimeDatabase parses the freedesktop.org shared-mime-info database, which is a large-ish (2 - 4 MB) XML file. This takes about 85 - 90 ms here. We first access QMimeDatabase in our startup sequence when we load the normal and capture application icons. Create a worker thread that initializes QMimeDatabase as early as possible and load load the normal and capture icons as late as possible. Change-Id: I27e3d65d8ee1308a62d12d3ff7e1b95f82c2e75a Reviewed-on: https://code.wireshark.org/review/24471 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=71cec74ccb626edd6255d5bbf7cf95c01c32430b commit 71cec74ccb626edd6255d5bbf7cf95c01c32430b Author: Roland Knall Date: Mon Nov 13 13:42:03 2017 +0100 Qt: Fix selection of elements If two elements existed with the same filter expression, the first element got selected allways. This is much more secure, as it only takes the label into account. If the user by accident created two buttons with the same filter expression, but different label and wants to remove the second button, the first one no longer will be removed instead of the second one. Change-Id: I16130aa69cb853aedb9a5c9b0bbbb3eb64b467d1 Reviewed-on: https://code.wireshark.org/review/24399 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=584c478751db133ee416393a77edfc8c32b8101d commit 584c478751db133ee416393a77edfc8c32b8101d Author: Darien Spencer Date: Fri Nov 17 13:09:39 2017 +0200 fp: Fix mac TVB for edch t1 Using the '_caplen' function with length of -1 leads to a "truncated RLC" error. Change-Id: I5a5f650b244de1167ff7110558ad0559d0422103 Reviewed-on: https://code.wireshark.org/review/24462 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7f327cc5800817b7c443616235c91ba2c82e7860 commit 7f327cc5800817b7c443616235c91ba2c82e7860 Author: Pascal Quantin Date: Fri Nov 17 13:01:14 2017 +0100 3GPP NAS: fix dissection of PCO MSISDN container ID 3GPP 24.008 is not very explicit regarding the encoding, but after rereading 3GPP 23.003 and 3GPP 29.272, it is most likely the E.164 number in TBCD encoding (so without TON/NPI byte). Change-Id: Iae58ccc2919d28cb802015205b3b5fb97a1c4abe Reviewed-on: https://code.wireshark.org/review/24463 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=252ea22b97c0c0fe7a7ab1c712f275d52f1df2cd commit 252ea22b97c0c0fe7a7ab1c712f275d52f1df2cd Author: Graham Bloice Date: Fri Nov 17 12:03:03 2017 +0000 WSDG: Improve VS2015 chocolatey install Created an AdminDeployment.xml file for use with the chocolatey package for VS2015 Community Edition and updated the WSDG to include it. Bug: 14147 Change-Id: Id2a701067bf38874cf0bf534cca55dba9cfd30d4 Reviewed-on: https://code.wireshark.org/review/24464 Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=2114923ec1a133e44ebd9403f19a07e1a0e539d4 commit 2114923ec1a133e44ebd9403f19a07e1a0e539d4 Author: AndersBroman Date: Fri Nov 17 10:44:16 2017 +0100 [Juniper ST] Dissect the "known" parts of the Juniper header. Ping Bug: 14195 Change-Id: I7ab05857c054a0d914db9373d182008215d67367 Reviewed-on: https://code.wireshark.org/review/24461 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=848cd4e291782ae9a59a3d4719d384870e2dddd8 commit 848cd4e291782ae9a59a3d4719d384870e2dddd8 Author: Darien Spencer Date: Fri Nov 17 10:39:47 2017 +0200 rrc: fixed incorrect constants The macinf->content field should be compared to MAC_CONTENT_* and not MAC_* Change-Id: I0dee7855938095c5d1c53f4db13003b90cf7ba91 Reviewed-on: https://code.wireshark.org/review/24460 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=00e217a732dc7d8c38ea5fac93dd81fcc0bc0ef2 commit 00e217a732dc7d8c38ea5fac93dd81fcc0bc0ef2 Author: Alexis La Goutte Date: Thu Nov 16 21:40:54 2017 +0100 ieee80211: Add dissection of BSS Transition Query Bug: 14220 Change-Id: Iec155a6fbb179bd0e0aaf8b10fd7d420dc1a69bb Reviewed-on: https://code.wireshark.org/review/24453 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=83cf4feaa980fb9d49e42bb3363c21357dbed6a3 commit 83cf4feaa980fb9d49e42bb3363c21357dbed6a3 Author: Alexis La Goutte Date: Fri Nov 17 08:14:01 2017 +0100 register(.h): fix parameter 'register_cb' not found in the function declaration [-Wdocumentation] Change-Id: I78afc76dcef56e46e296988299cab58c93eaeb03 Reviewed-on: https://code.wireshark.org/review/24459 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=81b246c040ab9310bf4fd96953b8fa8717976c4e commit 81b246c040ab9310bf4fd96953b8fa8717976c4e Author: Guy Harris Date: Thu Nov 16 21:31:48 2017 -0800 No need for a read/write descriptor for the output file. Change-Id: I66539b27f09d3a5acaae2c0ee080bca984c17468 Reviewed-on: https://code.wireshark.org/review/24457 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=bbeb5acb07132335fa7ccf89166429359cf1be37 commit bbeb5acb07132335fa7ccf89166429359cf1be37 Author: Guy Harris Date: Thu Nov 16 20:23:33 2017 -0800 Allow dumpcap to write to a named pipe. We didn't actually bother *opening* the named pipe if it wasn't named "-" (meaning "use standard output"). Hilarity^WRandom failure behavior ensued. Change-Id: If73cea232b13de664630d587167167ef53a95cba Reviewed-on: https://code.wireshark.org/review/24454 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=d9f8ddd78049eea607e052c562813e95475e8c44 commit d9f8ddd78049eea607e052c562813e95475e8c44 Author: Joakim Karlsson Date: Thu Nov 16 17:31:07 2017 +0100 [PFCP] add port 8805 Port assigned by IANA Change-Id: Ic04bc41878561239c83025ff2d5573daf7947b5b Reviewed-on: https://code.wireshark.org/review/24451 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e2deb54414d4b54bf44f8369ccc9a0ad8fc7c172 commit e2deb54414d4b54bf44f8369ccc9a0ad8fc7c172 Author: Dario Lombardo Date: Wed Nov 15 09:53:20 2017 +0100 gitlab-ci: add clang builds. From clang 3.5 to 4.0, using official ubuntu docker image. Change-Id: I60f41f2eb83990e4298ece27027413994d4f6440 Reviewed-on: https://code.wireshark.org/review/24405 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ac1d52aff5bdf74600ddc2f8f06ceccf9d2037a6 commit ac1d52aff5bdf74600ddc2f8f06ceccf9d2037a6 Author: Gerald Combs Date: Tue Nov 14 15:58:32 2017 -0800 Register protocols and handoffs in separate threads. Instead of interleaving protocol registrations and status callbacks in the main thread, move protocol registrations to a worker thread. Do the same with protocol handoffs. This *should* be safe since the status callbacks only update the UI. This reduces startup time by about 200ms on my laptop: Run OS Thread? Time 1 macOS N 340 ms 2 macOS N 260 ms 3 macOS N 252 ms 4 macOS Y 147 ms 5 macOS Y 146 ms 6 macOS Y 142 ms 7 Win 7 N 80 samples 8 Win 7 N 56 samples 9 Win 7 N 75 samples 10 Win 7 Y 31 samples 11 Win 7 Y 2 samples 12 Win 7 Y 0 samples macOS was sampled using Instruments. Windows 7 was sampled using the Visual Studio 2015 profiler. We should do the same thing with our capture and tap event loops, but that will likely require quite a bit more work. Change-Id: Iac9a81d8f71668f5979b524744a03f6d80aee893 Reviewed-on: https://code.wireshark.org/review/24447 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=665eb78729c91b4056b3e58af4407f51df603f55 commit 665eb78729c91b4056b3e58af4407f51df603f55 Author: Stig Bj??rlykke Date: Tue Nov 14 13:44:27 2017 +0100 Qt: Add UAT move up and down buttons Add two new buttons for moving entries up and down in the list. Change-Id: I90e5c5812754391651885e2a622148cecc124099 Reviewed-on: https://code.wireshark.org/review/24413 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8ee4920c76fe690142482e22148f1e2f14cae01f commit 8ee4920c76fe690142482e22148f1e2f14cae01f Author: Martin Peylo Date: Wed Nov 15 16:24:33 2017 +0200 Registering CMP PKIMessage as BER dissector Decoding ASN.1 BER as PKIMessage enables to examine a CMP (RFC 4210) message which was saved as file. Along the way, improving dissect_cmp_pdu function parameters to match required API for register_ber_syntax_dissector(), factoring in creation of asn1_ctx. Change-Id: I3284e6de9255e2b3cbf142c2904226b7e45b31f8 Reviewed-on: https://code.wireshark.org/review/24445 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9b93e7e5b2fb898fff1815345ac0a63087a74758 commit 9b93e7e5b2fb898fff1815345ac0a63087a74758 Author: Jo??o Valverde Date: Wed Nov 15 19:58:39 2017 +0000 Explain where GeoIP_free comes from Change-Id: I0a354cde4587a041bdb1fa4147bd88eed24ceb76 Reviewed-on: https://code.wireshark.org/review/24356 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=8d9fbdf8515b89f4739a4bddb80d944d2a53b459 commit 8d9fbdf8515b89f4739a4bddb80d944d2a53b459 Author: Stig Bj??rlykke Date: Wed Nov 15 13:57:25 2017 +0100 Qt: Show as much as possible of UAT pathLabel Remove the horizontal spacer between buttons an path label in UAT views to show as much as possible of the path label. Change-Id: I99d21ff6a1d151c9fcf83200a88b34b2e0c8eb5d Reviewed-on: https://code.wireshark.org/review/24444 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f4e958c2ea08e1552a05e69d2a409862077557d2 commit f4e958c2ea08e1552a05e69d2a409862077557d2 Author: Dario Lombardo Date: Wed Nov 15 11:07:29 2017 +0100 udpdump: add space. Change-Id: I44960f64f16434ccdf033eaa2bfa96579da7cc4b Reviewed-on: https://code.wireshark.org/review/24439 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=ca8e9a84a905c51c1d426460c99beed6c833a9d0 commit ca8e9a84a905c51c1d426460c99beed6c833a9d0 Author: Stig Bj??rlykke Date: Wed Nov 15 08:47:31 2017 +0100 kerberos: Don't generate unused _vals tables Put PA-FX-FAST-REPLY and PA-FX-FAST-REQUEST in .NO_EMIT ONLY_VALS Change-Id: If0476c6d2bb78a15e3b984a7edafc3a7800fa490 Reviewed-on: https://code.wireshark.org/review/24436 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=256622cb710a3c8096d5d24b49cf45deb76e0772 commit 256622cb710a3c8096d5d24b49cf45deb76e0772 Author: Alexis La Goutte Date: Wed Nov 15 07:42:37 2017 +0100 QUIC: fix STOP_SENDING length Change-Id: I954425bb54f9511ba2cea50adfa8c69ea322267c Reviewed-on: https://code.wireshark.org/review/24429 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=129ffaf11b704141b9d1049b4bd293744493d4ad commit 129ffaf11b704141b9d1049b4bd293744493d4ad Author: Stig Bj??rlykke Date: Tue Nov 14 19:12:46 2017 +0100 Qt: Update UAT clear button enabling Check for enabling the clear button when loading a UatFrame. Change-Id: Id9bbe4f99314d2798c4bccf10b57db99431a00fd Reviewed-on: https://code.wireshark.org/review/24412 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=435a8fb79ce4a482ede1764ef77ccfe8eb7f931d commit 435a8fb79ce4a482ede1764ef77ccfe8eb7f931d Author: Gerald Combs Date: Wed Nov 8 10:58:41 2017 +0000 JXTA: Remove some assertions. g4d2e653901 in 2009 removed some "if (tree)" checks, which in turn exposed some DISSECTOR_ASSERTs which trigger on short packets. Add an expert info field for truncated media data and comment out the assertions. The jxta-spec.dev.java.net specification link is dead. Add what appears to be the current location. Change-Id: Ic669c6631c6058a853d69ecd38ef4d2065c7eb24 Reviewed-on: https://code.wireshark.org/review/24426 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=21d96b04443a63e6e0b5fdffd19017ace057ee25 commit 21d96b04443a63e6e0b5fdffd19017ace057ee25 Author: Gerald Combs Date: Tue Nov 14 13:50:10 2017 -0800 JXTA: Simplify some expressions. The sizes of guint8, guint16, and guint32 are always 1, 2, and 4 bytes respectively. Just use 1, 2, and 4. Change-Id: I857d33873cc5831ba23544475f721e485b8bd817 Reviewed-on: https://code.wireshark.org/review/24427 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Reviewed-by: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1810801a688eb5d15fb4a6bdaeb03a497abfdc47 commit 1810801a688eb5d15fb4a6bdaeb03a497abfdc47 Author: Anders Date: Tue Nov 14 15:41:32 2017 +0100 Handle LINKTYPE_JUNIPER_ST 200. Bug: 14195 Change-Id: Ic6be8e1f8169968c48376984c0d1a1a69c67f32a Reviewed-on: https://code.wireshark.org/review/24415 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=88d8fa7440f923905849338ee1bd70d238e799cd commit 88d8fa7440f923905849338ee1bd70d238e799cd Author: Uli Heilmeier Date: Tue Nov 14 20:11:09 2017 +0100 UI: Fix seg fault of software update language init Set only software update language when language is configured. Change-Id: If3f0e304b95863a30fb7bb69197addf4bad689c7 Reviewed-on: https://code.wireshark.org/review/24414 Reviewed-by: Graham Bloice Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5d1328c5285e1cd3f4e1620dd33babda47bafe92 commit 5d1328c5285e1cd3f4e1620dd33babda47bafe92 Author: Michael Mann Date: Sat Sep 24 08:29:07 2016 -0400 Kerberos - Add support for RFC 6113 Bug: 8974 Change-Id: I43998a64fc34dfeb1c0a8d702d5bdc5aa74d57de Reviewed-on: https://code.wireshark.org/review/17879 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=27011d312343a0dac06736087d1a94ffd7ab763e commit 27011d312343a0dac06736087d1a94ffd7ab763e Author: Stig Bj??rlykke Date: Tue Nov 14 19:08:56 2017 +0100 Qt: Change delete_list icon transparent value Update the delete_list icon to have same transparent value as the other icons used in UAT handling. Change-Id: I5de7f3d6c0292e6ffde7d8cfd08a899e135fe108 Reviewed-on: https://code.wireshark.org/review/24411 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f2ee064bbbdc6f00466d0705401fbdaeaa965702 commit f2ee064bbbdc6f00466d0705401fbdaeaa965702 Author: Stig Bj??rlykke Date: Tue Nov 14 19:05:57 2017 +0100 mqtt: Copy UAT match_criteria value Change-Id: Ifdb743bcf1f644d412d1ac35801347b5355d1754 Reviewed-on: https://code.wireshark.org/review/24410 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=b0b5bda7cb97ccf3ae5e0052b8d5c05b69f23f9f commit b0b5bda7cb97ccf3ae5e0052b8d5c05b69f23f9f Author: Graham Bloice Date: Tue Nov 14 17:45:44 2017 +0000 Revert "Windows tests:" This reverts commit b4fc532372f0add6bf1434a54aa1a3a457ab3a88. No longer required. Change-Id: I0ec135d7b54f2aa1b8369fe8192fd2e725ffd5a8 Reviewed-on: https://code.wireshark.org/review/24409 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=c43c58c434cced3df2e208094d1891e8447e0cfc commit c43c58c434cced3df2e208094d1891e8447e0cfc Author: Graham Bloice Date: Tue Nov 14 15:36:57 2017 +0000 CMake: Make Qt5 packages required if building Qt version This stops folks failing when they don't have Qt but are still attempting to build the Qt version. Change-Id: I31eb9433b25ca9a717cd10bc165f3820ae31687e Reviewed-on: https://code.wireshark.org/review/24406 Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=b4fc532372f0add6bf1434a54aa1a3a457ab3a88 commit b4fc532372f0add6bf1434a54aa1a3a457ab3a88 Author: Graham Bloice Date: Tue Nov 14 16:24:42 2017 +0000 Windows tests: Add some debug info to the failing tests by displaying the LANG var. Change-Id: I0a7316d06a6aca035b46c3e6211ac8e93425e295 Reviewed-on: https://code.wireshark.org/review/24407 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=3006ffa615d02dabe7431394b07e8b2d9888ca41 commit 3006ffa615d02dabe7431394b07e8b2d9888ca41 Author: Peter Wu Date: Mon Nov 13 23:43:10 2017 +0000 CMake,editcap: avoid noise with editcap -F and -T options Avoid printing a noisy "option requires an argument" error when using '-T' and '-F' as documented. Fix warning that started showing on macOS with CMake 3.9.4 about CMP0058 since v2.5.0rc0-1180-g799f4f0e14. Change-Id: Ie0cc352c6b0b2724997e7fe6b49fd5b1f02d1e07 Reviewed-on: https://code.wireshark.org/review/24404 Petri-Dish: Peter Wu Reviewed-by: Ahmad Fatoum Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=a595d7326b4a42f15a7b3109a6e81b4de02bbc14 commit a595d7326b4a42f15a7b3109a6e81b4de02bbc14 Author: Alexis La Goutte Date: Mon Nov 13 21:58:33 2017 +0100 MPLS: use directly proto_tree_add_item for display PW ACH Channel Type Ping-Bug 14208 Change-Id: Idefa2611fd6725b65c1994ef1f4ff4b00fcf67c7 Reviewed-on: https://code.wireshark.org/review/24403 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b1302f0f28e8af4f3b3f47bd0a6962e514af7b56 commit b1302f0f28e8af4f3b3f47bd0a6962e514af7b56 Author: Michael Mann Date: Mon Nov 13 08:27:52 2017 -0500 Remove circuit_id from Lua tests It was removed from packet_info when circuit API was removed. Remove tests that call circuit_id for testing. Change-Id: I88e54b288d9d8f99b63e0828663b3025c57e0ec8 Reviewed-on: https://code.wireshark.org/review/24400 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0bba9fb60f832dcc475b0de25e14537d61e11a0f commit 0bba9fb60f832dcc475b0de25e14537d61e11a0f Author: Erwin Rol Date: Sun Nov 12 18:44:02 2017 +0100 RDM: Add ACK timer and ACK overflow handling Change-Id: I1531e84b91becba97300cf30f8bbfd12290ced61 Signed-off-by: Erwin Rol Reviewed-on: https://code.wireshark.org/review/24396 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=65bab716bee4f537f6dd63ec9dba3b5df2393672 commit 65bab716bee4f537f6dd63ec9dba3b5df2393672 Author: Joakim Karlsson Date: Mon Nov 13 10:27:46 2017 +0100 [PFCP] minor corrections Change-Id: I981c7bb9b601a38abeeb21d67ff4f7af824c234e Reviewed-on: https://code.wireshark.org/review/24398 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=800b26edbe34e135cc9be1d4395db2c13ae1213f commit 800b26edbe34e135cc9be1d4395db2c13ae1213f Author: Michael Mann Date: Sat Nov 11 17:16:13 2017 -0500 Remove circuit API Replace with conversation API that limits the "endpoint" to a single uint32 value. The intention is to eventually have "layered" endpoints, because circuit_id was used in cases where src/dest port have already been populated (and are used for layers above). Those src/dest ports should just be treated as just another endpoint, but we currently only have support for one. Change-Id: Ic6aa7ef0241275aa4dfde9459194369b48c72960 Reviewed-on: https://code.wireshark.org/review/24369 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7c40580584eac67a23633e58810028dddc58781c commit 7c40580584eac67a23633e58810028dddc58781c Author: Roland Knall Date: Sun Nov 12 21:39:25 2017 +0100 Qt: Really fix the packet list selection Really fix the selection of a row in the packet list Change-Id: I87ab36146bd9b2a130f443717ce73609a1c0b656 Reviewed-on: https://code.wireshark.org/review/24397 Reviewed-by: Roland Knall Petri-Dish: Roland Knall Reviewed-by: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=58a44aef230c2d9ddcdca6c892d22e0bd836c9d5 commit 58a44aef230c2d9ddcdca6c892d22e0bd836c9d5 Author: Roland Knall Date: Sun Nov 12 11:41:09 2017 +0100 Qt: ToolbarMimeData and display Implement the mime data for the toolbar in the same fashion as it has been done for the drag-drop of the field filter. Change-Id: I2b1ac7f82b637c999f458700c9ab24a9e4dcbcb8 Reviewed-on: https://code.wireshark.org/review/24378 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=7deb2b432b08a5bae7c138eae1a0b2a2a50a35b8 commit 7deb2b432b08a5bae7c138eae1a0b2a2a50a35b8 Author: Stig Bj??rlykke Date: Sun Nov 12 20:33:35 2017 +0100 mqtt: Use proto_tree_add_item_ret_uint() Change-Id: Iccbbb007b4d733b812e2a2cb528477b1417bed6e Reviewed-on: https://code.wireshark.org/review/24394 Petri-Dish: Stig Bj??rlykke Reviewed-by: Flavio Santes Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=3105382bed06a17f993421e2889e66189f2551ca commit 3105382bed06a17f993421e2889e66189f2551ca Author: Stig Bj??rlykke Date: Sun Nov 12 20:46:31 2017 +0100 Qt: Show ByteView for first packet Change-Id: Ie5b09f0ac8db0adb999633f3367339b8f50eabe9 Reviewed-on: https://code.wireshark.org/review/24395 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=b5a1145cf15b51dc6d6a5614c5304cbe74cbf556 commit b5a1145cf15b51dc6d6a5614c5304cbe74cbf556 Author: Stig Bj??rlykke Date: Sun Nov 12 20:28:36 2017 +0100 Qt: Select correct packet from list Change-Id: Id29d74506f7f009b7f14a86d8fc7c299711c4c2c Reviewed-on: https://code.wireshark.org/review/24393 Petri-Dish: Stig Bj??rlykke Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=e38c89d3a7aef37c404a616c493ca31c10a5afbb commit e38c89d3a7aef37c404a616c493ca31c10a5afbb Author: Guy Harris Date: Sun Nov 12 10:55:58 2017 -0800 Link with ZLIB_LIBRARIES if you link with wiretap. Wiretap may use zlib; if it does, ZLIB_LIBRARIES is set to refer to zlib. On UN*X, you may be able to get away with linking a dynamically-linked shared library with other dynamically-linked shared libraries and not linking programs linked *with* that shared library with those other shared libraries, but that may not work on Windows. We link most programs that use wiretap with ZLIB_LIBRARIES; do so with androiddump and randpktdump as well. Bug: 14207 Change-Id: I8e94197e06f5fd0ff8c95aa509dbcc2ff2a44cd4 Reviewed-on: https://code.wireshark.org/review/24389 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=5be009d48d4ae869347309b6713d1e3a206e0398 commit 5be009d48d4ae869347309b6713d1e3a206e0398 Author: Anders Date: Sun Nov 12 19:37:18 2017 +0100 Fix typo. Change-Id: I99f122fb154aedce7c129043d55661ce4de09bbc Reviewed-on: https://code.wireshark.org/review/24388 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=54e54c64bdfb11186e8930396be664796080ed6c commit 54e54c64bdfb11186e8930396be664796080ed6c Author: Anders Date: Sun Nov 12 19:22:31 2017 +0100 [Diameter] Fix typo avp name="OC-Feature-Vector" code="622" Change-Id: I678d6f4aa563630db1abdfe03474166de18b2a01 Reviewed-on: https://code.wireshark.org/review/24387 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=66b5afa2168e6957dd5f4b55b00b65bde4a35693 commit 66b5afa2168e6957dd5f4b55b00b65bde4a35693 Author: Dario Lombardo Date: Sun Nov 12 16:01:34 2017 +0100 extcap: use SPDX identifiers for licences. Change-Id: Id56687f86f4c60494dad0b6d58550ee45b0b203c Reviewed-on: https://code.wireshark.org/review/24381 Reviewed-by: Alexis La Goutte Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2b03b41bd0a894576b59c2dc6bf1d581c970cf16 commit 2b03b41bd0a894576b59c2dc6bf1d581c970cf16 Author: Alexis La Goutte Date: Sun Nov 12 16:49:56 2017 +0100 ssl-utils: Add export ssl_data_alloc For reuse on QUIC dissector Change-Id: I005fc3fe7a559fdb7a62e3d40450a4a6b25bf2f5 Reviewed-on: https://code.wireshark.org/review/24383 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d283939303f9ebad95ccd845930417f18851c6b9 commit d283939303f9ebad95ccd845930417f18851c6b9 Author: Uli Heilmeier Date: Sun Nov 12 16:55:31 2017 +0100 Fix "might be clobbered by 'longjmp' or 'vfork' warning Change-Id: I51ec17b5eabe7b0f9fc68f4cf599ca55b8e4631d Reviewed-on: https://code.wireshark.org/review/24385 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3d77e1bbcdbc5064fc8b2c971a4cbfc4cd5e2f72 commit 3d77e1bbcdbc5064fc8b2c971a4cbfc4cd5e2f72 Author: Joakim Karlsson Date: Sun Nov 12 13:51:00 2017 +0100 [PFCP] Update to 3GPP TS 29.244 V14.1.0 (2017-09) Change-Id: I69ad8c9a852f400e2918c4eca7365c719df734f5 Reviewed-on: https://code.wireshark.org/review/24380 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e13e2df9a1278903c66292a4f7b823c707b30cb3 commit e13e2df9a1278903c66292a4f7b823c707b30cb3 Author: Roland Knall Date: Sun Nov 12 11:29:13 2017 +0100 Qt: Rename packetSelection to frameSelected In order to consolidate the interfaces between certain parts of the UI, the signal emitted after a frame change has occured, has to include the number of the frame. This led to two signals for frame change, and therefore packetSelection is to be removed. Change-Id: I24e0e0890291d2243935b0c48387beb66904bfa3 Reviewed-on: https://code.wireshark.org/review/24377 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=447291d84a63d3e707fd00111ba465e5c230c849 commit 447291d84a63d3e707fd00111ba465e5c230c849 Author: Roland Knall Date: Sun Nov 12 11:16:34 2017 +0100 Qt: Fix DragDrop on ProtoTree Fix two issues, first that you could not move the scrollbar as it would initiate a drag-drop operation. Second, if you start a drag-drop operation at the top of a field, it would select the field you move over as well. Change-Id: I553785b1b6c586919e025d3042a876701f36860d Reviewed-on: https://code.wireshark.org/review/24376 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=8e5436687a46de93ee40f4e8ab510cdc5768f9a5 commit 8e5436687a46de93ee40f4e8ab510cdc5768f9a5 Author: Roland Knall Date: Sun Nov 12 11:56:10 2017 +0100 Qt: Clear up the label The modifier key is a hidden option for now, with the label only showing the filter expression and the description Change-Id: I4c983ed0d4fadbd69f0836ecfc85ea8e1109478e Reviewed-on: https://code.wireshark.org/review/24379 Reviewed-by: Roland Knall Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=98ca698a3705336a75020e03ba2ec5e6d80e34cc commit 98ca698a3705336a75020e03ba2ec5e6d80e34cc Author: Roland Knall Date: Sun Nov 12 11:09:38 2017 +0100 Qt: Add Modifier to drop only field Add a modifier to the drag-drop operation, to only drop the field name as filter, instead of the complete filter expression Change-Id: I9da96906575397191e821e3494a42e0f10d51f45 Reviewed-on: https://code.wireshark.org/review/24375 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=e95623cd6b46552eb7dd97cfbbb47292ba002fde commit e95623cd6b46552eb7dd97cfbbb47292ba002fde Author: Peter Wu Date: Sun Nov 12 04:00:56 2017 +0000 Qt: do not crash when selecting a field without tvb If no tvb is attached to a field, crashing is not the expected result. Change-Id: Ica0e95326cfcfeb015016770d1b930a9f0447066 Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView") Ping-Bug: 14205 Reviewed-on: https://code.wireshark.org/review/24370 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=5bd8fb4131a92848614590fe5d7aa28fc000fdb2 commit 5bd8fb4131a92848614590fe5d7aa28fc000fdb2 Author: Gerald Combs Date: Sun Nov 12 08:11:13 2017 +0000 [Automatic update for 2017-11-12] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I18adb8aceae2a8962697284087d43e3b30d133f1 Reviewed-on: https://code.wireshark.org/review/24371 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=bd130e92733db5069331021f5be4cb4717603375 commit bd130e92733db5069331021f5be4cb4717603375 Author: Richard Sharpe Date: Sat Nov 11 16:03:33 2017 -0800 ieee1905: Use BASE_UNIT_STRING and &units_dbm rather than appending the string 'dBm'. Change-Id: I5f4ddcf98902c53f6f014e64b51eb4c3c263e7e1 Reviewed-on: https://code.wireshark.org/review/24368 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=95d62171934dfcebc0df44ca15e894c6db0269ad commit 95d62171934dfcebc0df44ca15e894c6db0269ad Author: Stig Bj??rlykke Date: Sat Nov 11 20:35:08 2017 +0100 mqtt: Whitespace and indent fixes Change-Id: Ie6470cd20871b0aac17d19c67aba4b7229f906e6 Reviewed-on: https://code.wireshark.org/review/24367 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=b032b338010830fd9994a5530f743dbd3112a3ae commit b032b338010830fd9994a5530f743dbd3112a3ae Author: Jo??o Valverde Date: Fri Nov 10 22:23:47 2017 +0000 autotools: rename libui_dirty to libui_generated Change-Id: I382fbc2af5c42772e4feb65f33ea2a326b9b5c62 Reviewed-on: https://code.wireshark.org/review/24351 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fa6dc7b3fb60e38869f01c73fc240a07a7db1eda commit fa6dc7b3fb60e38869f01c73fc240a07a7db1eda Author: Jo??o Valverde Date: Fri Nov 10 18:56:38 2017 +0000 autotools: Be more consistent with variable names Change-Id: I644fbe7796a83c98861a4ebb9200ee41de27c897 Reviewed-on: https://code.wireshark.org/review/24350 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3f11c2f7c53ff07aa2d402eda013259706f257f8 commit 3f11c2f7c53ff07aa2d402eda013259706f257f8 Author: Owen Kirby Date: Thu Nov 9 18:33:51 2017 -0800 Wi-SUN Protocol dissection and IEEE 802.15.4 IE cleanup. This patch adds dissection for the Wi-SUN Field Area Network standard. Wi-SUN packets are encoded as a collection of IEEE 802.15.4 information elements. This required a bit of refactoring in how the IE dissector table is handled so that external protocols could supply their own dissectors. While I was working with the IEs, I also added support for the TSCH Timeslot and Global Time IEs from the IEEE 802.15.4 standard in addition to some general cleanup. Change-Id: I2858e4ab577756568e33b86adfe282967899abd5 Reviewed-on: https://code.wireshark.org/review/24331 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=499ae4ab573fbfefdb1c200e3177e18844e545b5 commit 499ae4ab573fbfefdb1c200e3177e18844e545b5 Author: Alexis La Goutte Date: Sat Nov 11 16:25:16 2017 +0100 address(.h): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] Change-Id: Ibfc95e085b2712f7a71f6559ae205de87aab12f6 Reviewed-on: https://code.wireshark.org/review/24365 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2092b66a0bbcef2764e3d708a44af2f378b39dba commit 2092b66a0bbcef2764e3d708a44af2f378b39dba Author: Alexis La Goutte Date: Sat Nov 11 16:20:42 2017 +0100 WPS: no previous prototype for ???proto_reg_handoff_wps??? [-Wmissing-prototypes] Change-Id: Icb5220af362a25f081f0b5d33f92a9013723bca9 Reviewed-on: https://code.wireshark.org/review/24364 Petri-Dish: Alexis La Goutte Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=81805717dea0f1f2048748165e968147f0b9cd7a commit 81805717dea0f1f2048748165e968147f0b9cd7a Author: Alexis La Goutte Date: Sat Nov 11 16:19:45 2017 +0100 RIP: no previous prototype for ???proto_reg_handoff_rip??? [-Wmissing-prototypes] Change-Id: I49e6ecec2e3998ff212069e88618bea36935c894 Reviewed-on: https://code.wireshark.org/review/24363 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fea67da276df03ed39fe552d6df2f3304a03e7c1 commit fea67da276df03ed39fe552d6df2f3304a03e7c1 Author: Joakim Karlsson Date: Sat Nov 11 15:44:33 2017 +0100 [PFCP] OHC: fix Port number field present Port number should only be included with UDP/IP header Change-Id: Ie2655d2b6f1b755bff47e74723f36b1ee87170f9 Reviewed-on: https://code.wireshark.org/review/24361 Petri-Dish: Alexis La Goutte Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=13581e6acaab7f0d98b530a1db1e0b80c7c6a938 commit 13581e6acaab7f0d98b530a1db1e0b80c7c6a938 Author: Joakim Karlsson Date: Sat Nov 11 15:47:11 2017 +0100 [PFCP] display changes For readability, DEC<->HEX and "IE length" Change-Id: I753d8f6cba43a6b34fd06b49b1ffa96f13790c67 Reviewed-on: https://code.wireshark.org/review/24360 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=bb69464e4c5d88a175025a79c23636d7628576b0 commit bb69464e4c5d88a175025a79c23636d7628576b0 Author: Joakim Karlsson Date: Sat Nov 11 15:41:12 2017 +0100 [PFCP] F-TEID: add missing TEID Change-Id: I4668208b5bf1d2cc168c7aa8f593510d55f27c23 Reviewed-on: https://code.wireshark.org/review/24359 Petri-Dish: Alexis La Goutte Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=da24baf510df4e5273da57d3b867a4ffbc64bde1 commit da24baf510df4e5273da57d3b867a4ffbc64bde1 Author: Martin Kaiser Date: Sat Nov 11 17:55:26 2017 +0100 asciidoc.conf, sort-and-group: (trivial) fix a comment sort-and-group produces a comma-separated list, the last two entries are separated by "and" Change-Id: I3e6c153c764641664453c4d091fdb84bb308e689 Reviewed-on: https://code.wireshark.org/review/24366 Reviewed-by: Martin Kaiser http://cgit.osmocom.org/wireshark/commit/?id=ac41b0a94153dd5b7c1ca946b74f2ee3f81ff932 commit ac41b0a94153dd5b7c1ca946b74f2ee3f81ff932 Author: Joakim Karlsson Date: Sat Nov 11 15:38:43 2017 +0100 [PFCP] IPv4, IPv6 address present Change-Id: I4efedb43a8a3688931c4815ea5fa82bd01248b98 Reviewed-on: https://code.wireshark.org/review/24358 Petri-Dish: Alexis La Goutte Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=29c32812b42a8983cb2210833cd9c3e0001d5d03 commit 29c32812b42a8983cb2210833cd9c3e0001d5d03 Author: Alexis La Goutte Date: Sat Nov 11 15:17:16 2017 +0100 RTLS: Add link to doc about this protocol Change-Id: Ib0207bb10c948637359f4afb853003065e3ca1bd Reviewed-on: https://code.wireshark.org/review/24344 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4ec8ebcebbbd67a54429d3d18982aaefb6118b91 commit 4ec8ebcebbbd67a54429d3d18982aaefb6118b91 Author: Gerald Combs Date: Sat Nov 11 12:14:09 2017 +0000 SPDX: Convert doc and docbook. Replace the GPLv2+ blurbs in the doc and docbook directories with SPDX headers as appropriate. This includes example code such as packet-PROTOABBREV.c. Remove dfilter2pod.pl and dfilter2xml.pl. We haven't used them since 2010. Change-Id: I4adec02a9a4bc3e71e32bdf89f2754edaf696938 Reviewed-on: https://code.wireshark.org/review/24343 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=92be91f57a162136523f40b6f9eefddacf7a3328 commit 92be91f57a162136523f40b6f9eefddacf7a3328 Author: Alexis La Goutte Date: Sat Nov 11 15:38:01 2017 +0100 [o|t]wamp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Idfa33bb194a491e2b97cc7e4a95f4da8c30a5f58 Reviewed-on: https://code.wireshark.org/review/24349 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1cf6d365b2e4c0e97411698ba027d62de4437523 commit 1cf6d365b2e4c0e97411698ba027d62de4437523 Author: Alexis La Goutte Date: Sat Nov 11 15:37:01 2017 +0100 mqtt: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ibd0041e0031c92073c89a1535677167e4fc90443 Reviewed-on: https://code.wireshark.org/review/24348 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fdc8845803d15bc55fe8673bec22290f77cceed1 commit fdc8845803d15bc55fe8673bec22290f77cceed1 Author: Alexis La Goutte Date: Sat Nov 11 15:34:46 2017 +0100 ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I67b2d6f7d6e12f541780dfb17f5bbfe20bae3cf4 Reviewed-on: https://code.wireshark.org/review/24347 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ff302a283d2654105143377823dc6fafb88885c3 commit ff302a283d2654105143377823dc6fafb88885c3 Author: Alexis La Goutte Date: Sat Nov 11 15:30:38 2017 +0100 btmesh: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I7218d74e1dc4d014dadd86f55b7805ba1581f9c3 Reviewed-on: https://code.wireshark.org/review/24346 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=73329d786ba6643784dc0c31cede88ad4da7db4a commit 73329d786ba6643784dc0c31cede88ad4da7db4a Author: Pascal Quantin Date: Sat Nov 11 15:14:45 2017 +0100 DVB-CI: ensure that conversation_t stucture exists before using it Bug: 14202 Change-Id: Ie0cad9c1cd1d0ea1392a61194567e80bb2b5a566 Reviewed-on: https://code.wireshark.org/review/24345 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=eaee0678ce2566d3bef43d83acc7463c737f8ae3 commit eaee0678ce2566d3bef43d83acc7463c737f8ae3 Author: Stig Bj??rlykke Date: Sat Nov 11 11:06:53 2017 +0100 mqtt: Use guint for offset Change-Id: Ie7b4a540e68121dbe5cd14a9aac80a1f9aae90b3 Reviewed-on: https://code.wireshark.org/review/24342 Petri-Dish: Stig Bj??rlykke Reviewed-by: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=f35aa91c1a07e420b4d4a9c51342bddb8d3640c9 commit f35aa91c1a07e420b4d4a9c51342bddb8d3640c9 Author: Flavio Santes Date: Fri Nov 10 12:35:49 2017 -0500 dissector/mqtt: Dissect the UNSUBACK payload MQTT v5.0/UNSUBACK includes a payload conformed by a list of reason codes. There is no length field for this payload, so it must be computed as the difference between the full message size and the current offset. Change-Id: Ibf7ef4131408e26e2389c3ab89107c22c16412a1 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24337 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d337f4c5b74a2824bc7de34161ac30b54a3b0e4e commit d337f4c5b74a2824bc7de34161ac30b54a3b0e4e Author: Flavio Santes Date: Thu Nov 9 18:34:04 2017 -0500 dissector/mqtt: Payload length computation This patch modifies how the payload length is computed. With this patch we want to simplify and reduce the number of operations. Change-Id: Ie1c9a3f26c689e92fbbd57c34e4f68abd3ea7d02 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24336 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=bce5b50f734bfd63b29ce44bfce29cb2d0d094b9 commit bce5b50f734bfd63b29ce44bfce29cb2d0d094b9 Author: Peter Wu Date: Sat Nov 11 03:25:36 2017 +0000 Qt: Fix use-after-free crashes when changing packets QTabWidget::clear() is documented to remove all tabs without deleting them. As a result, findByteViewTextForTvb will still find ByteViewText children with freed tvbs. Fix this by deleting the tabs too. Change-Id: I5b4fdc7154a3804e3bd5f360749e95d178ffe580 Bug: 14199 Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy") Reviewed-on: https://code.wireshark.org/review/24339 Petri-Dish: Peter Wu Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=7cbbbe0bde475786d661fe887ee2340a269f1063 commit 7cbbbe0bde475786d661fe887ee2340a269f1063 Author: Peter Wu Date: Sat Nov 11 01:15:32 2017 +0000 Qt: avoid undefined behavior in ProtoTree::eventFilter UBSan complains about "ev" being a "QEvent" rather than a QMouseEvent. Change-Id: I9e59ffbe16df2ef20b7856e6dd2d9ef246632de6 Fixes: v2.5.0rc0-1608-g4d6454e180 ("Qt: Drag n Drop Filter expression from Packet Tree") Reviewed-on: https://code.wireshark.org/review/24338 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=0c382106f8504315039510e4adc67e0e5c2003cd commit 0c382106f8504315039510e4adc67e0e5c2003cd Author: Helmut Buchsbaum Date: Fri Nov 10 12:13:05 2017 +0100 dissector/amqp: fix TLS/SSL payload dissection To enable TLS/SSL payload dissection for AMQPS traffic add the AMQP handle as SSL dissector for the actual AMQPS port. Thus we have successfully decrypted our AMQPS traffic using a pre-master-key file. Change-Id: I63dec2217fb5645007da010f651846834abacdbc Reviewed-on: https://code.wireshark.org/review/24335 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6ef9538770e95bfcdda8422281013a517f92df3a commit 6ef9538770e95bfcdda8422281013a517f92df3a Author: Matej Tkac Date: Fri Nov 10 10:50:09 2017 +0100 [PFCP] PDN Type Dissection and minor fixes Added PDN Type dissection (3GPP 29.244 Section 8.2.79) Fixed bit order in dissect_ue_ip_address Added "Encoding error" message if MBR or GBR has different format than specified in doc. Change-Id: I3b8b096fa490a2b4a16b3e6e9a640f92e389be1f Reviewed-on: https://code.wireshark.org/review/24334 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=cb7e896a4a450294dde70f01dc7cc105a883ef44 commit cb7e896a4a450294dde70f01dc7cc105a883ef44 Author: Michael Mann Date: Thu Nov 9 20:58:38 2017 -0500 Add frame number to packet comment dialog Bug: 14185 Change-Id: I9f52999339d3c34502d4e046e22f05a83fa773bb Reviewed-on: https://code.wireshark.org/review/24330 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fd46a58581d0e5bacfb8bf5e57670adaacaf18ab commit fd46a58581d0e5bacfb8bf5e57670adaacaf18ab Author: Michael Mann Date: Thu Nov 9 20:29:30 2017 -0500 packet-twamp.c: General improvements 1. Always wait for Greeting packet, otherwise packet must not be TWAMP control 2. Dissect packets on first pass 3. Use value_string for control state Ping-Bug: 14171 Bug: 14196 Change-Id: I642c6fd61d29744ac4fd4185a9081eba27138c0a Reviewed-on: https://code.wireshark.org/review/24329 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e935e902d6ca1ce3265edd944bfe045b05706ee1 commit e935e902d6ca1ce3265edd944bfe045b05706ee1 Author: Richard Sharpe Date: Thu Nov 9 05:10:11 2017 -0800 ieee802.11: Fix the display of the Cisco Aironet DTPC value. The DTPC value is in dBm, so make it so. There is a second byte that we are looking for a spec on. Bug: 14193 Change-Id: I69f0af295954958fde38b74e965f6fb66063513b Reviewed-on: https://code.wireshark.org/review/24322 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=19a46ba774b127ca0b6a96772310f149f2ff198a commit 19a46ba774b127ca0b6a96772310f149f2ff198a Author: Pascal Quantin Date: Thu Nov 9 18:56:31 2017 +0100 RIP: do not register proto_reg_handoff_rip() callback Bug: 14197 Change-Id: Ib6a46e09622d85fabbf8465a9234af3a959b9663 Reviewed-on: https://code.wireshark.org/review/24327 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=775bbbcded718ffe6d429bb68e1170b2ef3f7778 commit 775bbbcded718ffe6d429bb68e1170b2ef3f7778 Author: Gerald Combs Date: Wed Nov 8 15:43:53 2017 +0000 Start using SPDX license identifiers. A while back Graham pointed out the SPDX project (spdx.org), which is working on standardizing license specifications: https://www.wireshark.org/lists/wireshark-dev/201509/msg00119.html Appendix V of the specification describes a short identifier (SPDX-License-Identifier) that you can use in place of boilerplate in your source files: https://spdx.org/spdx-specification-21-web-version#h.twlc0ztnng3b Start the conversion process with our top-level C and C++ files. Change-Id: Iba1d835776714deb6285e2181e8ca17f95221878 Reviewed-on: https://code.wireshark.org/review/24302 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Reviewed-by: Balint Reczey Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=50b91d0b4dd057608e521d0a6e82bf08eacff812 commit 50b91d0b4dd057608e521d0a6e82bf08eacff812 Author: Dario Lombardo Date: Thu Nov 9 18:39:55 2017 +0100 qt: add constructor to proto_tree (CID: 1420705). Change-Id: I60a07ef6c8006ad8f4b6a5f25c2b4f2b1cb32766 Reviewed-on: https://code.wireshark.org/review/24326 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=784ad7297ecc603390797d4c4c5500610a9093e8 commit 784ad7297ecc603390797d4c4c5500610a9093e8 Author: Uli Heilmeier Date: Tue Nov 7 23:28:19 2017 +0100 UI: Use configured language for software update dialog The software update dialog should use the language configured with preferences. Change-Id: If7a4b39d47ce9af505540555a653eb4a3aed8b94 Reviewed-on: https://code.wireshark.org/review/24325 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=645dff11e1c59c3e6c5893127d74427dd633778a commit 645dff11e1c59c3e6c5893127d74427dd633778a Author: Flavio Santes Date: Wed Nov 8 23:30:40 2017 -0500 dissector/mqtt: Replace proto_tree_add_uint64 by proto_tree_add_uint Change-Id: I51d5dfdcbf13cca79ca354d0a63bf7dc328e5dc9 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24312 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=414a63f16099b37eac5f90f51bfbc64589a48170 commit 414a63f16099b37eac5f90f51bfbc64589a48170 Author: Dario Lombardo Date: Thu Nov 9 13:30:20 2017 +0100 extcap: rename interface names. The new names better reflect the utility. Change-Id: I54105fc8be6735d3febbcc68837990758a5e52c3 Reviewed-on: https://code.wireshark.org/review/24320 Petri-Dish: Dario Lombardo Reviewed-by: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=3bc743a9fdae56ee6be71feec314864bec91f28e commit 3bc743a9fdae56ee6be71feec314864bec91f28e Author: Jo??o Valverde Date: Thu Nov 9 16:05:55 2017 +0000 autotools: Fix build for unknown Qt interface Change-Id: Ibba717da1fa6cf9b87fc1972e83b0e637e54fd80 Reviewed-on: https://code.wireshark.org/review/24324 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=39967011836c1e23dff188ffaadb747d9dcda062 commit 39967011836c1e23dff188ffaadb747d9dcda062 Author: Jo??o Valverde Date: Wed Nov 8 14:02:08 2017 +0000 Replace inet_addr() with our inet_pton() wrapper Error checking omitted like in original code. Change-Id: If8b4181d30ddf5717951aaf7ec61db25c0bc5322 Reviewed-on: https://code.wireshark.org/review/24309 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2ebc41050e43c508edbc8c0fa8cccb9797c463cf commit 2ebc41050e43c508edbc8c0fa8cccb9797c463cf Author: Matej Tkac Date: Thu Nov 9 13:58:47 2017 +0100 [PFCP] Dissect Node ID and minor fixes Fixed FQDN Field in Dissect Node ID according to 3GPP 29.244 Section 8.2.38 Added "Encoding error" message if the value in field is in dotted form contrary to the doc. Minor fix: Decreased F-TEID Flags spare bits (fix of dc269fcd6f1ebc41d4e164f14dbb2a078bbb6265) Change-Id: I7e9ba53a7deed7af1305f5c445bf4b2a9212e115 Reviewed-on: https://code.wireshark.org/review/24321 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e7e4dc5d98869f91af3e649324d726217b2a8861 commit e7e4dc5d98869f91af3e649324d726217b2a8861 Author: bat Date: Wed Nov 8 12:05:06 2017 +0100 gvcp: - Added support for new registers: - GVCP_IEEE_1588_EXTENDED_CAPABILITY (0x00000974) - GVCP_IEEE_1588_SUPPORTED_PROFILES (0x00000978) - GVCP_IEEE_1588_SELECTED_PROFILE (0x0000097C) - Added support for missing/new error codes (0x8013 - 0x8017) - Added dissector code for 'current link configuration' part of device mode register - Added support for proper event dissection with the length field in event commands is used as recommended by the GEV 2.1 specification - Added dissector code for new capability/configuration bits (iee1588 profile, multi-part, large leader/trailer, ieee extended capabilities) - BUGFIX: In multi-zone mode, zone directions where decoded as 'Receiver' and 'Transmitter' instead of 'Bottom Up' and 'Top-Down' - BUGFIX: Commands that received at least one 'PENDING_ACK' before the final acknowledge where always reported with '(Failed)' in the Wireshark main window - Fixed some typos gvsp: - Added full multi-part dissection support - Replaced some hard-coded numbers by numerical constants - Added support for missing/new error codes (0x8013 - 0x8017) - BUGFIX: In multi-zone mode, zone directions where decoded as 'Receiver' and 'Transmitter' instead of 'Bottom Up' and 'Top-Down' - Combined 'AddressOffsetHigh/Low' for multi-zone/part into a single more readable 64-bit value Change-Id: I55862204ef71f69bc88c79fe2259f7cb8365699a Reviewed-on: https://code.wireshark.org/review/24299 Petri-Dish: Anders Broman Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=74936320a43c18a2ad538c8235e410f4912f6e4c commit 74936320a43c18a2ad538c8235e410f4912f6e4c Author: Richard Sharpe Date: Thu Nov 9 02:44:36 2017 -0800 802.11: Correctly handle Wi-Fi Alliance Multi-AP subtype decoding. Introduce a dissector table and fix a bug so that it now works by calling through a dissector table. Change-Id: Ifa3f01b3f306101b3144604a51806eaccc436373 Reviewed-on: https://code.wireshark.org/review/24319 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=dc269fcd6f1ebc41d4e164f14dbb2a078bbb6265 commit dc269fcd6f1ebc41d4e164f14dbb2a078bbb6265 Author: Matej Tkac Date: Thu Nov 9 11:34:19 2017 +0100 [PFCP] Improvements to Dissect F-TEID function Added Bit 4 - CHID as described in 3GPP 29.244 Section 8.2.3. Added "Encoding error" msg if documentation conditions aren't met. Change-Id: Ia5e6d8bb2bf635fa695a2bfcba3877c2ecf52d87 Reviewed-on: https://code.wireshark.org/review/24318 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f2727b571a4d413857c027867735d23fa1f28c62 commit f2727b571a4d413857c027867735d23fa1f28c62 Author: Anders Date: Tue Nov 7 16:12:22 2017 +0100 TWAMP dissector for RFC 5357 From https://github.com/demirten/twamp-dissector cleaned up a bit. Change-Id: I3736e2ef09bd84ba30a63fee8bf07771f07bfe6c Reviewed-on: https://code.wireshark.org/review/24283 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=43678551636f9845da4d52f48f8e82931f6b1c80 commit 43678551636f9845da4d52f48f8e82931f6b1c80 Author: Flavio Santes Date: Wed Nov 8 22:55:30 2017 -0500 dissector/mqtt: Rewrite the SUBSCRIBE payload size computation - FIX: subtract the property length from the message length - Replace the 'for' loop by a 'while' loop, now that the arithmetic is done before. TODO: It's a protocol error (v5.0)/violation (v3.1.1) not to include the payload in the SUBSCRIBE control packet. It would be nice to display a "malformed packet legend" in such that case. Change-Id: I99ef3862aa19b3a31ea03d1c194e54f489674115 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24313 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=afb252355bebee80673ea904c6b510aeaf10feb5 commit afb252355bebee80673ea904c6b510aeaf10feb5 Author: Michael Mann Date: Thu Nov 9 00:25:43 2017 -0500 ISDN: Convert circuit API to conversation API Change-Id: I8752123a740c47f9328e0144624d4fbf4e200165 Reviewed-on: https://code.wireshark.org/review/24314 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=78665f5211fa9eeb3031dae2de8e551bcb2369ea commit 78665f5211fa9eeb3031dae2de8e551bcb2369ea Author: Michael Mann Date: Wed Nov 8 23:12:50 2017 -0500 ISO 14443: Convert circuit API to conversation API Change-Id: Id007a3df5442cf4d21263acb17303b6d735aaa7d Reviewed-on: https://code.wireshark.org/review/24311 Petri-Dish: Michael Mann Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=82891e37e926040e89d4e761f93ec5c6cc0ca52a commit 82891e37e926040e89d4e761f93ec5c6cc0ca52a Author: Michael Mann Date: Wed Nov 8 20:02:06 2017 -0500 DVB-CI: Convert circuit API to conversation API Add the few necessary conversation APIs to make conversion possible. Change-Id: I775f23005c48cacd2be342bdc704af4738f0789c Reviewed-on: https://code.wireshark.org/review/24310 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c57ab694eca2e3d0bc6c7e8c01df8dce20c3631e commit c57ab694eca2e3d0bc6c7e8c01df8dce20c3631e Author: Stig Bj??rlykke Date: Wed Nov 8 21:35:11 2017 +0100 Qt: Give focus to preference value in PreferenceEditorFrame Select the preference value text and give focus when editing a single preference. Ping-Bug: 14191 Change-Id: I8d5f91c40118b9d74f1a65f5311aa92dfeb3e1b7 Reviewed-on: https://code.wireshark.org/review/24306 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=25c5d830c95872630ca87d21a3d9e3a7e084e0db commit 25c5d830c95872630ca87d21a3d9e3a7e084e0db Author: Stig Bj??rlykke Date: Wed Nov 8 21:10:42 2017 +0100 Qt: Give focus to Title in ColumnEditorFrame Select the title text and give focus to the title when Edit Column. Bug: 14191 Change-Id: I04fc5f6bcc830a15ef43fa2d06a1a729df52e370 Reviewed-on: https://code.wireshark.org/review/24305 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=35a1907fe6a5f7d630223ba38adabc28eeeed971 commit 35a1907fe6a5f7d630223ba38adabc28eeeed971 Author: Peter Wu Date: Sun Sep 3 00:33:54 2017 +0100 iograph: Use default graph values if io_graphs UAT file doesn't pass validation Change-Id: I70c8ca7b5b31d284a12220fc6ce2a764ea9fbe6b Fixes: v2.5.0rc0-631-g5b3e3ee587 ("Use UAT model for I/O graph") Reviewed-on: https://code.wireshark.org/review/23366 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1c25b71c7b4a6a993f5957c9adc1f598f51d4cd5 commit 1c25b71c7b4a6a993f5957c9adc1f598f51d4cd5 Author: Stig Bj??rlykke Date: Wed Nov 8 21:41:16 2017 +0100 mqtt: Rename mqtt_conv to mqtt_conv_t This will clarify that it's a type. Also remove unneeded init values. Change-Id: If61b32a264ff60a26e775dc99f1c06d0aa555a4d Reviewed-on: https://code.wireshark.org/review/24307 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=428b354f0d4262b47855ccace409ca21d92faab5 commit 428b354f0d4262b47855ccace409ca21d92faab5 Author: Stig Bj??rlykke Date: Wed Nov 8 22:02:52 2017 +0100 btmesh: Remove a debug g_warning Change-Id: Ifc822efccfff5de32a54ca1f148a09ac3be4d0e3 Reviewed-on: https://code.wireshark.org/review/24308 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=8a6ea0e454dddcc1d9c14ad1e02a43a53a4ef667 commit 8a6ea0e454dddcc1d9c14ad1e02a43a53a4ef667 Author: Roland Knall Date: Mon Oct 30 13:58:28 2017 +0100 Qt: Further cleanup ByteView This further separates ByteView and the rest of the system. Using FieldInformation and DataPrinter, this is the final cleanup of the ByteViewTab Change-Id: If41521167527cf5664c2564cdd0d45fea0f3f612 Reviewed-on: https://code.wireshark.org/review/22783 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=87431fef2836c8d77ea694844cd5dff0e8b801f8 commit 87431fef2836c8d77ea694844cd5dff0e8b801f8 Author: Flavio Santes Date: Mon Nov 6 22:01:22 2017 -0500 dissector/mqtt: Add 'Subscription Options/Retain Handling' text descriptions Change-Id: I6dea2e9c190095105dc1441197ad00c9b3a66f89 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24272 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=af285603ee82ae9644340c2f2871b293a8480c39 commit af285603ee82ae9644340c2f2871b293a8480c39 Author: Flavio Santes Date: Mon Nov 6 15:18:42 2017 -0500 dissector/mqtt: Dissect the User Property field Change-Id: I0a0e484a814a11b785d20fda6eba5c251db98188 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24269 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=9f67e0a0d628209f6f979b6adf4a0f58e39afb77 commit 9f67e0a0d628209f6f979b6adf4a0f58e39afb77 Author: Flavio Santes Date: Mon Nov 6 15:01:53 2017 -0500 dissector/mqtt: Dissect MQTT v5.0 String/Binary Properties Add routines to dissect the following MQTT v5.0 String/Binary Data Property fields: - Content Type - Response Topic - Correlation Data - Assigned Client Identifier - Authentication Method - Authentication Data - Response Information - Server Reference - Reason String Change-Id: Ia0ad0597d32bacc58228376bb738b7092f4a1ad6 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24268 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=d5759b72e60418df09a99b627f13cae6c4baa70a commit d5759b72e60418df09a99b627f13cae6c4baa70a Author: Flavio Santes Date: Mon Nov 6 21:34:06 2017 -0500 dissector/mqtt: Add the 'Subscription Options' dissector Change-Id: I400430ca59c7492ae64dba6c4cca2485553988b9 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24271 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=36faf3203af3a5b77cbe19f232ee77b7ddd2cd50 commit 36faf3203af3a5b77cbe19f232ee77b7ddd2cd50 Author: Dario Lombardo Date: Wed Nov 8 13:01:26 2017 +0100 udpdump: don't call inet_addr() for every packet. Change-Id: Id3d9229f5d61390f2f4127c8dfdf445935297e85 Reviewed-on: https://code.wireshark.org/review/24300 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8730b2037a6a999af28594607a4c27c3837f8f83 commit 8730b2037a6a999af28594607a4c27c3837f8f83 Author: Orgad Shaneh Date: Wed Nov 8 13:50:33 2017 +0200 tshark/tfshark: Replace global prefs with a boolean This partially reverts dc0e6ccc9f9aaad7139c1edd3b723c4b939b15da in favor of a cleaner solution. Change-Id: Ie57329020b5a7d15eb7d99aad3103843a14f07a6 Reviewed-on: https://code.wireshark.org/review/24278 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=2125275c7cc261e101731162ac1eeba7626ce9e8 commit 2125275c7cc261e101731162ac1eeba7626ce9e8 Author: Richard Sharpe Date: Wed Nov 8 02:26:19 2017 -0800 smb2: Fix bug 6027 to correct SRT computations. Fix a problem where SMB2 cancel and break messages are included in SRT computations when it should not be. Bug: 6027 Change-Id: I690fe6d9e14f26d85fe5c71830869780046d5d12 Reviewed-on: https://code.wireshark.org/review/24295 Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=3f189bed2f343893a4b9df626875a930e03c91e1 commit 3f189bed2f343893a4b9df626875a930e03c91e1 Author: Flavio Santes Date: Mon Nov 6 14:54:02 2017 -0500 dissector/mqtt: Dissect the Subscription Identifier Property Change-Id: Ia60b9c344fd572193374f57299b1829f17dfa24e Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24267 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=ca7bffbfc3341f6ff9b5dbd4efa15bccefcfd744 commit ca7bffbfc3341f6ff9b5dbd4efa15bccefcfd744 Author: Anders Date: Wed Nov 8 11:06:53 2017 +0100 [Diameter 3GPP] Sub dissect AVP Code: 1677 Group-PLMN-Id. Change-Id: I69ac8210dfcb43f9fc15e49c75dfb917976f0770 Reviewed-on: https://code.wireshark.org/review/24294 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6565923eb30c9421992bea3a4cba28d0eddb6c2d commit 6565923eb30c9421992bea3a4cba28d0eddb6c2d Author: Matej Tkac Date: Wed Nov 8 13:25:11 2017 +0100 [PFCP] Fixed apply action flags bits referenced in register info. In accordance with 3GPP 29.244 8.2.26 Apply Action. Change-Id: Icef9bc9807efc255ece8fbde5e4c244d5f1fc525 Reviewed-on: https://code.wireshark.org/review/24301 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1a3bd52e9107d37c004bc094b633d2ce4455d150 commit 1a3bd52e9107d37c004bc094b633d2ce4455d150 Author: Stig Bj??rlykke Date: Wed Nov 8 11:34:09 2017 +0100 btmesh: Fix building without gcrypt Change-Id: If77b36d764c07acd87a553134cebff246b8368fe Reviewed-on: https://code.wireshark.org/review/24296 Petri-Dish: Stig Bj??rlykke Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=465f75b5292e4c57762200ca1b87cdb225dd6484 commit 465f75b5292e4c57762200ca1b87cdb225dd6484 Author: Pascal Quantin Date: Wed Nov 8 11:46:59 2017 +0100 MQTT: add a missing break Change-Id: I0a17fd44607a5a7452a7c2789140cce7cdcbd17b Reviewed-on: https://code.wireshark.org/review/24298 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=4a1f8f5f27e165aeba0b1441f7f1858a9c60fff7 commit 4a1f8f5f27e165aeba0b1441f7f1858a9c60fff7 Author: Roland Knall Date: Wed Nov 8 08:37:48 2017 +0000 Qt: ReleaseNotes and reformatting of Drag n' Drop Added ReleaseNotes and changed the representation Change-Id: Ica927368ef6c5d912a29e06733ad0a95e1886077 Reviewed-on: https://code.wireshark.org/review/24291 Petri-Dish: Roland Knall Reviewed-by: Richard Sharpe Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=bf8d8ebfa43366bff4edd9f16eb1af078ce36985 commit bf8d8ebfa43366bff4edd9f16eb1af078ce36985 Author: Flavio Santes Date: Tue Nov 7 16:53:45 2017 -0500 dissector/mqtt: DISCONNECT and AUTH may not include the Property field From the spec: 3.14.2.2.1 Property Length: The length of Properties in the DISCONNECT packet Variable Header encoded as a Variable Byte Integer. If the Remaining Length is less than 2, a value of 0 is used In this commit we also assume that AUTH may not include the Property field, given that DISCONNECT and AUTH share the same structure. Change-Id: I5f55151df6b2066d924b2c16fb08a63b0903ef46 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24288 Petri-Dish: Stig Bj??rlykke Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=76eab87c7de02a6586c3fedf913db820f4fc3cf2 commit 76eab87c7de02a6586c3fedf913db820f4fc3cf2 Author: Flavio Santes Date: Mon Nov 6 14:40:35 2017 -0500 dissector/mqtt: Dissect MQTT v5.0 Four Byte Properties Add routines to dissect the following MQTT v5.0 Four Byte Property fields: - Publication Expiry Interval - Session Expiry Interval - Will Delay Interval - Maximum Packet Size Change-Id: Ie902f679c5424f85f98c9ed113951ed0ee6411be Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24266 Petri-Dish: Stig Bj??rlykke Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=9e7cfd32dde5f222d59e78b3acf1d3128d63a91e commit 9e7cfd32dde5f222d59e78b3acf1d3128d63a91e Author: Flavio Santes Date: Mon Nov 6 13:45:37 2017 -0500 dissector/mqtt: Dissect MQTT v5.0 Two Byte Properties Add routines to dissect the following MQTT v5.0 Two Byte Property fields: - Server Keep Alive - Receive Maximum - Topic Alias Maximum - Topic Alias Change-Id: I90b43cd315f31a34b10bf6065ea51549307e95f3 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24265 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=458f97b1ebced604ec9acf5690f3c9438169b5b0 commit 458f97b1ebced604ec9acf5690f3c9438169b5b0 Author: Flavio Santes Date: Sat Nov 4 10:27:07 2017 -0400 dissector/mqtt: Dissect MQTT v5.0 Byte Properties Add routines to dissect the following MQTT v5.0 Byte Property fields: - Payload Format Indicator - Request Problem Information - Request Response Information - Maximum QoS - Retain Available - Wildcard Subscription Available - Subscription Identifier Available - Shared Subscription Available Change-Id: I28b95174ce811a92d8f22bf51c331169b5e4b925 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24264 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=96735846beb4d067eac220c48f5d8c18f178e4c1 commit 96735846beb4d067eac220c48f5d8c18f178e4c1 Author: Roland Knall Date: Tue Nov 7 15:51:43 2017 +0000 Qt: Clean Drag-n-Drop Mimetype for toolbar Cleans up the mime type to use a class instead of a mimetype string Change-Id: I122ba9b39de86d8e263f2204715911a2b0ac75cd Reviewed-on: https://code.wireshark.org/review/24286 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=4d6454e18027a7265138e16ef95b52000825aa47 commit 4d6454e18027a7265138e16ef95b52000825aa47 Author: Roland Knall Date: Tue Nov 7 15:51:43 2017 +0000 Qt: Drag n Drop Filter expression from Packet Tree Drag and Drop a field from the packet tree to the displayfilteredit or the toolbar and drop it there to either apply the filter (or prepare it by holding down the Shift key) or create a new toolbar button Change-Id: I42645a02223c71315e91e0d58eb1b54ebab4fd58 Reviewed-on: https://code.wireshark.org/review/24280 Petri-Dish: Anders Broman Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=371b5c526b439824ffd0eb2b11f76689436dc6c3 commit 371b5c526b439824ffd0eb2b11f76689436dc6c3 Author: Michael Mann Date: Tue Nov 7 17:44:55 2017 -0500 Have circuit functionality more closely mirror conversation functionality This will allow for a smoother transition for refactoring because circuit functionality can now be represented as a strict subset of conversation functionality. Change-Id: I323d7facad707c81b8e35b33143fa1102d6b5976 Reviewed-on: https://code.wireshark.org/review/24290 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f8a1878202f46dda8194fb56af7619c887cec806 commit f8a1878202f46dda8194fb56af7619c887cec806 Author: Pascal Quantin Date: Tue Nov 7 18:04:45 2017 +0100 proto.c: fix field display test in hfinfo_number_value_format_display64() While we are at it, let's use the FIELD_DISPLAY() macro everywhere. Bug: 14169 Change-Id: I685cb7eb4b9c52f836762c92baeb636570a6d12f Reviewed-on: https://code.wireshark.org/review/24285 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=0e85c0ad1e61e8bf9bebedbdd643c237391d5eb5 commit 0e85c0ad1e61e8bf9bebedbdd643c237391d5eb5 Author: Jeff Widman Date: Tue Nov 7 16:41:56 2017 -0800 Fix typo: Heatbeat --> Heartbeat Change-Id: I864850b29f9c816a4d1592cd5bba2b9d0159b139 Reviewed-on: https://code.wireshark.org/review/24289 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b6d6eb90970993a6342834317cb70e2519cbeff1 commit b6d6eb90970993a6342834317cb70e2519cbeff1 Author: Graham Bloice Date: Tue Nov 7 16:15:01 2017 +0000 CMake: Detection of HTMHelp CMake erroneously reports that HTMLHelp wasn't found The override of FindHTMLHelp.cmake now uses FIND_PACKAGE_HANDLE_STANDARD_ARGS to do this correctly. Change-Id: I1bd24964365dea00af213092872e24cbfb5ee07d Reviewed-on: https://code.wireshark.org/review/24281 Reviewed-by: Graham Bloice Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0c1ea1cee1a3b5f3ad9e176591bbad58b2b01ad0 commit 0c1ea1cee1a3b5f3ad9e176591bbad58b2b01ad0 Author: Dario Lombardo Date: Tue Nov 7 15:16:23 2017 +0100 fcp: create conversation if it doesn't exist. Change-Id: I0bcc17900a9379d9f9d1828b834c2116e1199bf6 Ping-Bug: 14168 Reviewed-on: https://code.wireshark.org/review/24277 Petri-Dish: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=62e81c5846afab51757eb48826ac02522e9864f3 commit 62e81c5846afab51757eb48826ac02522e9864f3 Author: Graham Bloice Date: Tue Nov 7 13:35:34 2017 +0000 Open Windows CHM Help from Help menu. Renable the link between the Menu help command and the locally installed CHM help file. This allows the user to acces the appropriate help built for their specific version rather than the latest version on the Wireshark web site. Change-Id: I7bb3d418ba405d6c7614ab6d52f7b0eda843d0de Reviewed-on: https://code.wireshark.org/review/24276 Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=dc0e6ccc9f9aaad7139c1edd3b723c4b939b15da commit dc0e6ccc9f9aaad7139c1edd3b723c4b939b15da Author: Orgad Shaneh Date: Mon Oct 30 15:42:43 2017 +0200 tshark/tfshark: Do not apply console.log.level before it is set The user has no way to apply this setting while loading dissectors in order to enable g_debug messages during init for example. Change the behavior to be as documented in the comment. Change-Id: I9317f12b207d4621508212b02ca1ebd46b55aadc Reviewed-on: https://code.wireshark.org/review/24184 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=5dd6a9cef95daf6ccee5007d766f10864f7dcc34 commit 5dd6a9cef95daf6ccee5007d766f10864f7dcc34 Author: Jaap Keuter Date: Tue Nov 7 12:24:20 2017 +0100 isobus-vt: make sure to close the id file (CID-1413873) Part of dissector init is reading the object ID file. This file should be closed afterwards to not leak the resource. Change-Id: Icf5e229315a2c1c61a169e576ec51d38a1c350a1 Reviewed-on: https://code.wireshark.org/review/24275 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Reviewed-by: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=99a53b2b95b7a297134007f5a6ebc6114db32d15 commit 99a53b2b95b7a297134007f5a6ebc6114db32d15 Author: Simon Barber Date: Wed Sep 13 16:06:56 2017 -0700 packet-ieee80211: all frames have address 1 = RA Change-Id: Ie4785376eae278713e998e23c96d8435e4dc07f2 Reviewed-on: https://code.wireshark.org/review/23526 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3593f0953fc0cffbe1999fc7f4b03656cc36e761 commit 3593f0953fc0cffbe1999fc7f4b03656cc36e761 Author: Martin Kacer Date: Tue Nov 7 07:33:15 2017 +0100 Fix Elasticsearch hex dump Removing duplicated double quote. Bug: 12958 Change-Id: I17f443efd8572e1d17ced5b8ec8f743253be859b Reviewed-on: https://code.wireshark.org/review/24273 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=1344e707b7e8aabc3b12ffd00e5595310e5508cb commit 1344e707b7e8aabc3b12ffd00e5595310e5508cb Author: Flavio Santes Date: Tue Nov 7 01:25:32 2017 -0500 dissector/mqtt: Disconnect and Auth variable header Apply 'Disconnect' (3.14.2) and 'Auth' (3.15.2-1) notes to simplify and fix the variable header :). Change-Id: I169a69a0da5b2d5ee338c0f45af978217986f37a Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24274 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d84d43372c3aee0ae5a1dd30edff8243acf41f14 commit d84d43372c3aee0ae5a1dd30edff8243acf41f14 Author: Paul Offord Date: Sun Nov 5 10:39:54 2017 +0000 Improvement to plugin_if_get_ws_info(...) functionality A plugin can register an initialisation function to be called each time Wireshark opens a new capture file. If plugin_if_get_ws_info(...) is called from within the initialisation function it does not return the name of the file being opened. This is because plugin_if_get_ws_info(...), through calls to a number of other functions, gets the file name details from a capture_file structure. At the time of the call to the plugins initialisation function, the capture_file structure in question has not yet been created. This change ensures that if plugin_if_get_ws_info(...) is called from a plugin's initialisation function, the name of the file to be open is correctly returned. The change also fixes a bug where plugin_if_ws_get(...) returns an incorrect file state if called from a plugin initialisation function. Bug: 14165 Change-Id: I28c85e480db96852e11bbaa14fb1f434b457ed52 Reviewed-on: https://code.wireshark.org/review/24251 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fa2649ac61755b462ec49ea0a2bbfb8569dd0bad commit fa2649ac61755b462ec49ea0a2bbfb8569dd0bad Author: Simon Barber Date: Wed Nov 1 11:51:37 2017 -0700 wireless_timeline: fix blank display Sometimes when a file opens the timeline does not display, also sometimes when zooming it disappears. Change-Id: I141eaef5f332a1de9af133abbeccede7c1cf5502 Reviewed-on: https://code.wireshark.org/review/24209 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=19b2ddcce1cdfc947220acfceefd0e3b98401909 commit 19b2ddcce1cdfc947220acfceefd0e3b98401909 Author: Flavio Santes Date: Sat Nov 4 08:35:10 2017 -0400 dissector/mqtt: Update license notice Change-Id: Iefd0bead04cc54c55d39b682b7879620c022afb1 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24262 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e2179a2ac55829c59cb49a81934c1ccfa65110e7 commit e2179a2ac55829c59cb49a81934c1ccfa65110e7 Author: Flavio Santes Date: Sat Nov 4 08:25:45 2017 -0400 dissector/mqtt: Add partial support for MQTT v5.0 This patch adds partial support for the MQTT v5.0 protocol. The relevant changes are: - A new MQTT control packet: AUTH (15) - The Variable Header is extended with a new section: 'Properties' Currently, the 'Properties' section is not dissected although its length is parsed. Change-Id: I059b91304e953d69e4781b170e61057cb38dde19 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/24261 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ea97b3364cba57cd041dde1f6348d029ae3851bf commit ea97b3364cba57cd041dde1f6348d029ae3851bf Author: Michael Mann Date: Mon Nov 6 20:30:43 2017 -0500 Add AMR WB pino to make Decode As happy. Change-Id: I7150db30ce52ab4398ed977197f200070fca1d8c Reviewed-on: https://code.wireshark.org/review/24270 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1e707e33fa88f720e09a5d0cc0ebee27d86582d8 commit 1e707e33fa88f720e09a5d0cc0ebee27d86582d8 Author: Anders Date: Mon Oct 30 14:03:25 2017 +0100 [BT Mesh] Add Bluetooth Mesh dissector. Bug: 14161 Change-Id: Ia76d283c6c8e00526948a0ee9cda9e35b4ca0e2a Reviewed-on: https://code.wireshark.org/review/24216 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4405c5d769d254ef6b28c0e3df53041ddfe1499c commit 4405c5d769d254ef6b28c0e3df53041ddfe1499c Author: Guy Harris Date: Mon Nov 6 13:26:38 2017 -0800 Fix white space. Change-Id: I8a50391dcfb113c251f24f64486828d5d8a1d0c0 Reviewed-on: https://code.wireshark.org/review/24260 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=9705f653daa134cbf63098ff44d5cebb021bffb4 commit 9705f653daa134cbf63098ff44d5cebb021bffb4 Author: Dario Lombardo Date: Mon Nov 6 16:26:34 2017 +0100 print: add fi check. Change-Id: Ica20efe7122476af55b70c72d8af40244c25f902 Reviewed-on: https://code.wireshark.org/review/24259 Petri-Dish: Dario Lombardo Reviewed-by: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=147e491025ff8ca590e28fb066a833fddda87291 commit 147e491025ff8ca590e28fb066a833fddda87291 Author: Michael Mann Date: Sun Nov 5 21:34:58 2017 -0500 Convert PT_EXCHG into using conversation endpoints Change-Id: Id5857a58513c38dd0ab5b30b61113bcc14e1ecee Reviewed-on: https://code.wireshark.org/review/24258 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0dfff8c4b4e4ea26b3a22ef6800213ba8a9f4f03 commit 0dfff8c4b4e4ea26b3a22ef6800213ba8a9f4f03 Author: Richard Sharpe Date: Sun Nov 5 18:27:03 2017 -0800 IEEE1905: Add a break to fix a malformed packet issue and dissect Multi-AP Extension types in EAPWPS. Change-Id: Ib7dca0f83897839072eaaeb9c95f406f6ad5c8e6 Reviewed-on: https://code.wireshark.org/review/24256 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8b79187b6613b7b984ff85de85a225f8a1f33a5a commit 8b79187b6613b7b984ff85de85a225f8a1f33a5a Author: Richard Sharpe Date: Mon Nov 6 02:04:06 2017 -0800 ieee802.11: Add support for the Measurement Pilot Interval IE and fix dissection of the actual measurement pilot interval. It is an 8-bit field according to IEEE802.11 2016. Change-Id: I44c9a732ae3074e865f7ad63b554f7a031542e5a Reviewed-on: https://code.wireshark.org/review/24257 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=156a0b62eb9dee2423b6d7d7f5aed1a5b6cb33ae commit 156a0b62eb9dee2423b6d7d7f5aed1a5b6cb33ae Author: Martin Kacer Date: Sat Nov 4 08:49:54 2017 +0100 Tools: json2pcap script update Updated script to support duplicated json fields and --no-duplicate-keys tshark flag. Bug: 12958 Change-Id: Id20885baacbfd26124cb82716df6829225be6de8 Reviewed-on: https://code.wireshark.org/review/24236 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ba6dd97081c7490db0d6e98c9e8cd3b819b9dd6f commit ba6dd97081c7490db0d6e98c9e8cd3b819b9dd6f Author: Jo??o Valverde Date: Sun Nov 5 13:05:20 2017 +0000 Remove epan win32 x86 assembly Not used. Remove also weird pre-hash hash optimization in proto.c. Change-Id: Ibebc12dbe90ac1d05fb1ba601d32fe98797fbd56 Reviewed-on: https://code.wireshark.org/review/24254 Reviewed-by: Michael Mann Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=93bda0b18d68d07f7601811687e44811d14e97f4 commit 93bda0b18d68d07f7601811687e44811d14e97f4 Author: Michael Mann Date: Sat Nov 4 19:28:33 2017 -0400 Add conversation/endpoint statistics for Linux SLL Bug: 14048 Change-Id: I320380c492b83f0e45bfbf20505deb3c5f11ae67 Reviewed-on: https://code.wireshark.org/review/24243 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=23afd28daf7a8ccbdba395e83fed79c0ca352f50 commit 23afd28daf7a8ccbdba395e83fed79c0ca352f50 Author: Michael Mann Date: Thu Nov 2 20:55:23 2017 -0400 Convert TIPC to use endpoint conversations Change-Id: Iab03ebbfc982bf7182851f63c17fa59bc71d7709 Reviewed-on: https://code.wireshark.org/review/24219 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=08bf89f4877b65a6a31c33023d8022bf9d94d1b6 commit 08bf89f4877b65a6a31c33023d8022bf9d94d1b6 Author: Alexis La Goutte Date: Sun Nov 5 10:59:39 2017 +0100 zbee zcl se: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I169f7815eecfcdfbbdca78d4ab038fb032c3b691 Reviewed-on: https://code.wireshark.org/review/24250 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=10cc91f83db602878e9a811a20dde4ca66fe4140 commit 10cc91f83db602878e9a811a20dde4ca66fe4140 Author: Darien Spencer Date: Sat Nov 4 11:48:51 2017 +0200 RLC: Replaced g_malloc with tvb_memdup Also updated some comments and a string Change-Id: Ib8c079a34f21614047262900b0a4c1547d5df0b3 Reviewed-on: https://code.wireshark.org/review/24237 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2ef00337c4c95e15f8f75bdd0c7902271c7c8336 commit 2ef00337c4c95e15f8f75bdd0c7902271c7c8336 Author: Jo??o Valverde Date: Sun Nov 5 14:15:04 2017 +0000 CMake: Remove "compress" remnant Change-Id: I6feeb2f5873562a09159cf55446652628aa97e78 Reviewed-on: https://code.wireshark.org/review/24255 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=dc18da434b04f8cf01f940bd4f13a37e19a96e8b commit dc18da434b04f8cf01f940bd4f13a37e19a96e8b Author: Hal Rosenstock Date: Fri Oct 27 18:35:19 2017 +0200 packet-infiniband: Proper parsing of ClassPortInfo attribute ClassPortInfo is a common attribute for general service (GS) management classes. SA ClassPortInfo is currently parsed as PortInfo although these are different attributes. Also, added support for PerfMgt ClassPortInfo. Bug: 14164 Change-Id: I652ba8ed2e0222db41ce2eb2e01a9c4b446e5bd4 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24235 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f891603a47cb99fd842fb06a6b0712fa92041fc8 commit f891603a47cb99fd842fb06a6b0712fa92041fc8 Author: Jo??o Valverde Date: Sun Nov 5 12:44:40 2017 +0000 autotools: Eliminate spurious libwireshark_asmopt library Change-Id: I96e03f136efd90892fbcf812ea37e36a2bed5ab9 Reviewed-on: https://code.wireshark.org/review/24253 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=ff3bd8c7ce5197ec533c8115a96655a4829d9c82 commit ff3bd8c7ce5197ec533c8115a96655a4829d9c82 Author: Alexis La Goutte Date: Sun Nov 5 10:08:12 2017 +0100 conversation_table(.h): fix parameter 'ptype/port_type_val' not found in the function declaration [-Wdocumentation] Oups not good fix last time... Change-Id: I55f565a8d4dde83304a8437be3dc35c2fad1fb07 Reviewed-on: https://code.wireshark.org/review/24249 Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=72c2e53981a204d746737d8c01c4ad3738cd4880 commit 72c2e53981a204d746737d8c01c4ad3738cd4880 Author: Jo??o Valverde Date: Sun Nov 5 12:05:43 2017 +0000 autotools: Use pkg-config to configure Libsmi Change-Id: Icecea743739aa7e1a65753f623f311514260d373 Reviewed-on: https://code.wireshark.org/review/24252 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=62f705e8445336e73a81e1df10987e24529bf418 commit 62f705e8445336e73a81e1df10987e24529bf418 Author: Jo??o Valverde Date: Wed Nov 1 09:23:22 2017 +0000 autotools: Try to be clearer about --with-ssl and remove cruft Change-Id: Iaf8c8a83ead1d6671bb9cadb6add56481ed98aaa Reviewed-on: https://code.wireshark.org/review/24242 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=711f69c807a5566060bea94ac7042b43bf3cbeab commit 711f69c807a5566060bea94ac7042b43bf3cbeab Author: Jo??o Valverde Date: Sat Nov 4 16:59:17 2017 +0000 CMake: Don't offer unsupported options Change-Id: I45872dad3c7133453790fb284121fb4eaf9fac67 Reviewed-on: https://code.wireshark.org/review/24240 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=68ead1d025bd63079ea5eebbb5d767f8d0f98459 commit 68ead1d025bd63079ea5eebbb5d767f8d0f98459 Author: Roland Knall Date: Sat Nov 4 16:11:08 2017 +0100 Qt: Fix drag-n-drop in toolbar Fixing two crashes in the toolbar, first one only appeared on mac, the second one happens every time the toolbar is removed or updated Change-Id: Ic3075a5af1b4a566e09bbce9712c968c053cc727 Reviewed-on: https://code.wireshark.org/review/24244 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=aed3e66672083940f94e0b33f5b2e9d25776a4d4 commit aed3e66672083940f94e0b33f5b2e9d25776a4d4 Author: Gerald Combs Date: Sun Nov 5 08:16:09 2017 +0000 [Automatic update for 2017-11-05] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4abb96429b1ad8c6d78a129efd453f3019669f4f Reviewed-on: https://code.wireshark.org/review/24245 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=7e6f6562fa1cef1ad67c0839477767ba5c0e43ce commit 7e6f6562fa1cef1ad67c0839477767ba5c0e43ce Author: Uli Heilmeier Date: Sat Nov 4 19:13:07 2017 +0100 TCP: cleanup Riverbed option Remove duplicate length field to adjust to the other options. tcp.options.rvbd.probe.len has already reported by tcp.option_len Add missing space between "Transparency" and IP address. Change-Id: I8b4260b34d760b73ee529a687418c4b6adcfaa0e Reviewed-on: https://code.wireshark.org/review/24239 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fc318e6a1f2da11e3429e58cd9d2893899f547af commit fc318e6a1f2da11e3429e58cd9d2893899f547af Author: Eliot Lear Date: Thu Nov 2 17:10:13 2017 +0100 Better instructions on building with Qt on macOS. Change-Id: I23bb91970dd7e3f59166310114cca84846d7164d Reviewed-on: https://code.wireshark.org/review/24165 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=1741b6b23c39d1f38956d005d70cbef2ee5e5f79 commit 1741b6b23c39d1f38956d005d70cbef2ee5e5f79 Author: Michael Mann Date: Sat May 6 08:15:24 2017 -0400 oss-fuzzshark: force direct malloc Set two environment variables (needs to be done before epan_init and before the first g_slice_alloc call) to force direct memory allocation without another layer that could hide bugs. Change-Id: I0d72092c239e2e7f42b0b7849c01471407e785e2 Reviewed-on: https://code.wireshark.org/review/21195 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d11f5dff8ef9e615a8d5d01ee8b88241fea42f09 commit d11f5dff8ef9e615a8d5d01ee8b88241fea42f09 Author: Uli Heilmeier Date: Mon Oct 30 19:57:14 2017 -0400 TCP: Fix Riverbed probe option tvb handling With commit f30b1e3b3bc4cec85296c280cdae88d3d17fae04 TCP options are handled in an own dissector table. Therefore we can't read ahead or behind to get the SYN flag or the CFE flag. Bug: 14150 Change-Id: Ibbf1836104d32216ddfa2d4e07dccbcf948bb26c Reviewed-on: https://code.wireshark.org/review/24181 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Uli Heilmeier Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=802517e91793fc69f834b40109f36b64c3fb4b7e commit 802517e91793fc69f834b40109f36b64c3fb4b7e Author: Hal Rosenstock Date: Tue Oct 24 15:33:51 2017 +0200 packet-infiniband: SM class does not support ClassPortInfo or InformInfo attributes Change-Id: I1fbe7a93e8a208a1a4abaf0b64e674536b642733 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24229 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=834c65a1f885e630a4ac5b2a585b41f5715e09c1 commit 834c65a1f885e630a4ac5b2a585b41f5715e09c1 Author: Hal Rosenstock Date: Thu Oct 26 21:13:38 2017 +0200 packet-infiniband: Make unknown GS class attributes show up in wireshark Info column The following GS classes are now displayed there: BM DEV_MGT SNMP VENDOR APP RESERVED Change-Id: I94822784a7027afa1d5e99ca20467721a98cfe0a Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24234 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=0cd40887d4963cf20b1118eba4085670d5cf1b01 commit 0cd40887d4963cf20b1118eba4085670d5cf1b01 Author: Hal Rosenstock Date: Thu Oct 26 19:54:59 2017 +0200 packet-infiniband: Better variable naming Rather than use PERF_header_item for all classes, use acronym for class appended with _header_item Change-Id: I52ac46000c20b7f51c87c8dc4a8dfc85c20f31f3 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24233 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b4856927eb2593795f114df8606f16136fb5048c commit b4856927eb2593795f114df8606f16136fb5048c Author: Hal Rosenstock Date: Thu Oct 26 19:24:47 2017 +0200 packet-infiniband: DETH Queue Key should be hex rather than decimal as it is in other places where there is Q_Key Was: DETH - Datagram Extended Transport Header Queue Key: 2147549184 Now: DETH - Datagram Extended Transport Header Queue Key: 0x0000000080010000 Change-Id: I64d4b485e2a511c30b0e4a2849f529438591a122 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24232 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=002133c606b3ae9b4253614f69250dbf306f358b commit 002133c606b3ae9b4253614f69250dbf306f358b Author: Hal Rosenstock Date: Thu Oct 26 19:05:41 2017 +0200 packet-infiniband: Make unknown PerfMgt attributes show up as PERF in wireshark Info column Change-Id: I9f6a60adaa0744d13d6c000d1a4e20f3b526355b Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24231 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b70429427f8264ca726d19910fef23b0ae77f347 commit b70429427f8264ca726d19910fef23b0ae77f347 Author: Hal Rosenstock Date: Tue Oct 24 15:41:30 2017 +0200 packet-infiniband: Fix commentary typo (for consistency) Change GuidInforecord -> GuidInfoRecord Also, change VLArbitrationTableRecord comment to be consistent Change-Id: Ia7cc844779a8751bd7675354b71239922327d0e8 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24230 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3c2f2179403f3f0c983f251b45f0cd5fe1be9a13 commit 3c2f2179403f3f0c983f251b45f0cd5fe1be9a13 Author: Hal Rosenstock Date: Thu Oct 26 08:23:27 2017 +0200 packet-infiniband: Add missing SA methods into mad_method_str so they are not indicated as Method: Unknown under MAD Header - Common Management Datagram Change-Id: I8e8fe918eea86e7095967d0b82772a813eafe2a5 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24228 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9b82c6b21e02fb0a2af37ed5f0847de59b63f9d1 commit 9b82c6b21e02fb0a2af37ed5f0847de59b63f9d1 Author: Hal Rosenstock Date: Tue Oct 24 17:30:56 2017 +0200 packet-infiniband: Fixed some PortInfo:CapabilityMask bit names to be consistent with IBA volume 1 spec IsOptionalIPDSupported IsCommunicationManagementSupported Change-Id: I55b29b7f291f49a9d0c3e104bda4d7d7aa78b42b Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24227 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c04c92fbf9986931d437371bdf2522f191d496ce commit c04c92fbf9986931d437371bdf2522f191d496ce Author: Hal Rosenstock Date: Tue Oct 24 14:27:43 2017 +0200 packet-infiniband: Add first and last to RMPP_Flags RMPP flags 7 indicates that packet is both first and last packet in transfer Change-Id: Idf0e8783372296a7c276c8c0c80e4905afbe6c9a Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24226 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b3f4ca6077993450a2373e0ebb2c72e0f73d487b commit b3f4ca6077993450a2373e0ebb2c72e0f73d487b Author: Hal Rosenstock Date: Tue Oct 24 15:26:42 2017 +0200 packet-infiniband: Fix some SM class attribute IDs LinkSpeedWidthPairsTable is 0x001C SMInfo is 0x0020 VendorDiag is 0x0030 LedInfo is 0x0031 Change-Id: I93197590930a97c8538ef69d08213b1076a9f66a Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24225 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=92dc84cff9dcbf1bcd6b9ebb3827f0f7a9c1d1a5 commit 92dc84cff9dcbf1bcd6b9ebb3827f0f7a9c1d1a5 Author: Hal Rosenstock Date: Tue Oct 24 14:12:20 2017 +0200 packet-infiniband: Fix SA MCMemberRecord attribute name rather than MCMembersRecord Change-Id: I96bf3ac45255295cf85b9faf0547df4df26f11c3 Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24222 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8894195a47e78c8f85744cc9f52b98a03e1da77b commit 8894195a47e78c8f85744cc9f52b98a03e1da77b Author: Hal Rosenstock Date: Tue Oct 24 14:32:39 2017 +0200 packet-infiniband: Use SA rather than SMA as Subnet Administration header SMA is acronym for Subnet Management Agent not Subnet Administration so change this from SMA to SA Change-Id: I1a293fff5de4796fe337daa133943bfa059cc9ff Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24224 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b9c5601dd8f16a45b120c1f64994d1335a282b09 commit b9c5601dd8f16a45b120c1f64994d1335a282b09 Author: Hal Rosenstock Date: Thu Oct 26 01:01:26 2017 +0200 packet-infiniband: Removed erroneous MadHeader comments as it is not parameter in these APIs Also, fixed commentary typo Change-Id: I1ce53b9aae9837688e756b2e665f3b1df74b572c Signed-off-by: Hal Rosenstock Reviewed-on: https://code.wireshark.org/review/24223 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=71389177e44d6335c891f6f7733e3df799dec8a3 commit 71389177e44d6335c891f6f7733e3df799dec8a3 Author: Michael Mann Date: Sat Oct 28 14:17:02 2017 -0400 Add Decode As support for RTP payload Change-Id: I568c0e6980d7649f9cd82ac46420e7db70722fc6 Reviewed-on: https://code.wireshark.org/review/24150 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=cd3948f99e02cb48af37785176cd9261ee01c2cd commit cd3948f99e02cb48af37785176cd9261ee01c2cd Author: Thomas Dreibholz Date: Fri Nov 3 21:11:25 2017 -0400 Add backslashes to definition of WSUG_TOOLS_HELP_FILES in docbook/Makefile.am Bug: 14152 Change-Id: If1d89afd5dbf62adae4cd84e3fc44bd37a8a2176 Reviewed-on: https://code.wireshark.org/review/24221 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6f382fed37fec0a8ee40bd06da861ff3e94a33ae commit 6f382fed37fec0a8ee40bd06da861ff3e94a33ae Author: Bruno Verstuyft Date: Fri Nov 3 13:39:09 2017 +0100 DOCSIS: RNGRSP: formatting of equalization coefficients Change-Id: I6745bee84b096a7008d258a39d99370b1fea29a0 Reviewed-on: https://code.wireshark.org/review/24217 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b227943e66c7839dca713be60f6cdaf70ba9413e commit b227943e66c7839dca713be60f6cdaf70ba9413e Author: Pascal Quantin Date: Fri Nov 3 17:42:56 2017 +0100 Exported PDU: apply EXP_PDU_TAG_COL_PROT_TEXT whatever the next_prot_type tag The include file suggests that it will always fill the protocol column if present. Let's make that happen. Change-Id: I265e2f4d1c2dcd7cf2ff121499694cde14a595f3 Reviewed-on: https://code.wireshark.org/review/24220 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=e00162301b243aff8d0e2760367243edf222a150 commit e00162301b243aff8d0e2760367243edf222a150 Author: Michael Mann Date: Wed Nov 1 07:45:42 2017 -0400 Ensure endpoint members of packet_info structure are initialized in packet.c Change-Id: I4c7a4f9888c8bdc87ded88fa997aa2aad9530fd7 Reviewed-on: https://code.wireshark.org/review/24218 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f6edbcd6439666319a875c5b4d4fd80b7834c57c commit f6edbcd6439666319a875c5b4d4fd80b7834c57c Author: Stig Bj??rlykke Date: Thu Nov 2 12:42:37 2017 +0100 mqtt: Simplify message decode matching Change-Id: I93da46808de8a978d49ad0aa3f78c4a1790e7952 Reviewed-on: https://code.wireshark.org/review/24210 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=be625b9be781e469456d01053336b18cfba63ede commit be625b9be781e469456d01053336b18cfba63ede Author: Christoph Wurm Date: Thu Nov 2 19:14:28 2017 +0000 Fix Elasticsearch hex dump Change-Id: I5b2006a74e95759afce518aaadfe47c54978476a Reviewed-on: https://code.wireshark.org/review/24215 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5d9c8ecbc1fe53aa17eba0b29d7f5c397f86c514 commit 5d9c8ecbc1fe53aa17eba0b29d7f5c397f86c514 Author: Eliot Lear Date: Thu Nov 2 17:11:25 2017 +0100 Remove eroneous DoD association by deleting IANA entry. Change-Id: Ib623391235c1cbbfadd540d2ae24fdc36c2b0b96 Reviewed-on: https://code.wireshark.org/review/24214 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=78ee8c419fe7ef07a7ff90b5b763a96d406c215c commit 78ee8c419fe7ef07a7ff90b5b763a96d406c215c Author: Pascal Quantin Date: Thu Nov 2 15:21:52 2017 +0100 Do not register proto_reg_handoff_XXX callback when not required None of those protocols need to be notified of a preference change and their proto_reg_handoff_XXX functions do not differentiate the initial call from susequent ones, leading to an assert Bug: 14157 Change-Id: Iac4d88ebef7688bced8daae857eb5c836a6babd6 Reviewed-on: https://code.wireshark.org/review/24211 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=dd1f75a53ed113454fb7c6d1cfb3a9463da0ffb4 commit dd1f75a53ed113454fb7c6d1cfb3a9463da0ffb4 Author: Ivan Ermakov Date: Tue Oct 31 16:50:40 2017 +0300 ZigBee ZCL Sub-Ghz Cluster dissector Added Sub-Ghz cluster dissector. Change-Id: I6d189400298def693969004b6fc2942fd8b70ba0 Reviewed-on: https://code.wireshark.org/review/24199 Reviewed-by: Martin Boye Petersen Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c571e692085b4c119d9ebf5c526bd3be77135361 commit c571e692085b4c119d9ebf5c526bd3be77135361 Author: Anders Date: Wed Nov 1 10:40:50 2017 +0100 [GTPv2] Add dissection of 8.127 Header Compression Configuration. Change-Id: Iace27ebf536cad73d9aaf4abceb6d235f34d68f6 Reviewed-on: https://code.wireshark.org/review/24208 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=dd4f8d08b2e1db8f12cb3deabf2b81ab5d86c4fb commit dd4f8d08b2e1db8f12cb3deabf2b81ab5d86c4fb Author: Ivan Ermakov Date: Tue Oct 31 16:16:44 2017 +0300 ZigBee ZCL Keep-Alive Cluster Dissector Added Keep-Alive Cluster dissector. Change-Id: I5a2c24a4f13171b26efc860470b4d9c42f54ef89 Reviewed-on: https://code.wireshark.org/review/24198 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=062ca10cff8203330dc8c56e99a52e0b8e4155ee commit 062ca10cff8203330dc8c56e99a52e0b8e4155ee Author: Ivan Ermakov Date: Tue Oct 31 17:06:52 2017 +0300 ZigBee ZCL MDU Pariring Cluster dissector Added dissectors for commands and payloads of MDU Pairing cluster. Change-Id: I842ddf50f91d0ecc46605325048971d1eeba6df6 Reviewed-on: https://code.wireshark.org/review/24200 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=93c358cb5d2a6620d997862ef39e1082e47e8329 commit 93c358cb5d2a6620d997862ef39e1082e47e8329 Author: Martin Mathieson Date: Mon Oct 30 21:28:44 2017 +0000 FTP: links between setup and command frames Change-Id: I8a231f8616952ed119b85126d6d25af7512e6cd8 Reviewed-on: https://code.wireshark.org/review/24194 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=66b441f3d63e21949530d672bf1406dea94ed254 commit 66b441f3d63e21949530d672bf1406dea94ed254 Author: Michael Mann Date: Mon Oct 30 15:57:34 2017 -0400 Add ability to create endpoints through conversations Add endpoint information to the packet_info structure for dissectors to potentially use as their data to create conversations. This patch includes a simple "example" of using conversation_create_endpoint with TDMoP. The assignment of the PT_TDMOP "port type" has been replaced by setting ENDPOINT_TDMOP within the endpoint structure. Then when subdissectors of TDMoP call find_or_create_conversation(), it implicitly picks up the conversation information set by TDMoP Change-Id: I11dc29989cccd3b0f0349ee901babb455ca02d19 Reviewed-on: https://code.wireshark.org/review/24190 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Andrew Chernyh Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d518f28b395a7d1c8588c8f321ad5ade194fb423 commit d518f28b395a7d1c8588c8f321ad5ade194fb423 Author: Jo??o Valverde Date: Wed Nov 1 00:20:04 2017 +0000 configure: Fix pcap-config --cflags command substitution Change-Id: I654dd34d229b4cd69b5e3a0c77d8958d12bceead Reviewed-on: https://code.wireshark.org/review/24207 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=7e4723a589bd266d50bff10cab34d2b6838f6412 commit 7e4723a589bd266d50bff10cab34d2b6838f6412 Author: Bruno Verstuyft Date: Tue Oct 31 13:44:12 2017 +0100 DOCSIS: add burst descriptor types. Fixed some bugs. Change-Id: I9f7df2f62197c574087dbcce2c7b0ba7e6c8c56b Reviewed-on: https://code.wireshark.org/review/24197 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=50c337f40a55e5b27d3442899bda60edebe38691 commit 50c337f40a55e5b27d3442899bda60edebe38691 Author: Stig Bj??rlykke Date: Tue Oct 31 11:28:05 2017 +0100 mqtt: Add message decoding Add support for configuring message decoding based on topic. Matching criteria is equal-to, contains, starts-with, ends-with or regular expression. Change-Id: I677d869716eb1d2798974e2c65605a454421a66c Reviewed-on: https://code.wireshark.org/review/24196 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=e8c7975b6f0a83826b13b407b84f941124767080 commit e8c7975b6f0a83826b13b407b84f941124767080 Author: Thomas Wiens Date: Sun Oct 29 17:54:39 2017 +0100 s7comm: Several minor improvements This patch includes several minor improvements: - Special (only for Sinumerik NC): allow NCK address description in data-part - Userdata parameter part: add text definition for second req/res - Don't add data tree in userdata telegrams, when there is no data in there - Cyclic functions: add new subfunction - Alarming: add SCAN message decoding - Improve info column display when there are multiple PDUs in one frame Change-Id: Ib9afd0c6b14cf97ed645084e095f79fb40b07f43 Reviewed-on: https://code.wireshark.org/review/24170 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5bea387c2c7fd37dd0fe1784d6f84e400ad4ff09 commit 5bea387c2c7fd37dd0fe1784d6f84e400ad4ff09 Author: Uli Heilmeier Date: Tue Oct 31 15:23:19 2017 +0100 HTTP: Update status codes Updated status codes to include "103, Early Hints". s. https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml Change-Id: Ic00285c0ffafeb689bbc30533fcbdeb688528c62 Reviewed-on: https://code.wireshark.org/review/24203 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=649c81b83c295ef96460554e8e02c091bd6ae815 commit 649c81b83c295ef96460554e8e02c091bd6ae815 Author: Roland Knall Date: Tue Oct 31 15:40:50 2017 +0100 Qt: ByteViewTab Fix tabs creation Fix creation of tabs Change-Id: I11b22a3964f7c25c0c88b8ecd4eec1ad480fe800 Reviewed-on: https://code.wireshark.org/review/24202 Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=56a130a152db73ea37f91d39be7d72f814013236 commit 56a130a152db73ea37f91d39be7d72f814013236 Author: Roland Knall Date: Wed Oct 25 15:39:35 2017 +0200 ByteViewText: Remove epan dependancy Remove all dependancy for the byte_view_text from the epan system, and therefore cleanly separate data and display for further separation of dissection and view Change-Id: Id1ee91b93da4511afa95f24da4cbbf39cbb89b1f Reviewed-on: https://code.wireshark.org/review/24050 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=c5165f325b6742f407a951f9c7d959314f15a6b5 commit c5165f325b6742f407a951f9c7d959314f15a6b5 Author: Alexis La Goutte Date: Tue Oct 31 07:14:55 2017 +0000 conversation_table(.h): fix parameter 'ptype/port_type_val' not found in the function declaration [-Wdocumentation] Change-Id: Iea18cc73d28af68e14f7b9516b630b0987fe5731 Reviewed-on: https://code.wireshark.org/review/24195 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ec43b0faa6d8106205073c7c8596ed7ae4c64abc commit ec43b0faa6d8106205073c7c8596ed7ae4c64abc Author: Christoph Wurm Date: Sun Oct 29 17:51:42 2017 +0000 Deduplicate Elasticsearch output Collects multiple values of the same field into an array. Empty protocols are now written as empty objects to not conflict with the same protocols in other packets. Remove _score since it has no effect. Bug: 12958 Change-Id: Ibe8ea9bc1e3e63dea1fe4eaf522fa38cad88a17f Reviewed-on: https://code.wireshark.org/review/24171 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e14f1ad37ded19188e864b82ed236b1eb11eebf3 commit e14f1ad37ded19188e864b82ed236b1eb11eebf3 Author: Alexis La Goutte Date: Fri Oct 6 08:08:30 2017 +0200 .mailmap: update (of October) Change-Id: I3b8d693c288edd61ec1bd9e9161919ac3ab35f52 Reviewed-on: https://code.wireshark.org/review/23850 Reviewed-by: Florian Fainelli Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6d8661ceef654b7857caff35f27b71ec364f7f1d commit 6d8661ceef654b7857caff35f27b71ec364f7f1d Author: Christoph Wurm Date: Sun Oct 29 01:33:46 2017 +0000 Fix segfault in Elasticsearch output When using the Elasticsearch output but only printing the packet summary with -P a segfault will occur because the empty packet tree is not properly handled in this case. Change-Id: I0c91314ae013785ae6dceabd6af33db4b836d1b2 Reviewed-on: https://code.wireshark.org/review/24153 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3a1f958cf87f15cac3b92738d019eb11046fc580 commit 3a1f958cf87f15cac3b92738d019eb11046fc580 Author: Jo??o Valverde Date: Sun Oct 29 21:52:24 2017 +0000 Remove unused netdb.h #includes Change-Id: Ia46903586219ee79210a980a04024af02acb0db0 Reviewed-on: https://code.wireshark.org/review/24189 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d887d76f277be4aad9c0e86292d2f7b5b8537abc commit d887d76f277be4aad9c0e86292d2f7b5b8537abc Author: Anders Date: Mon Oct 30 22:01:16 2017 +0100 [BSSMAP-LE] Correct dissection of 10.20 Positioning Data. Change-Id: Ia0c3b688dfdcd9fdad4f65df12ef97db99bdb095 Reviewed-on: https://code.wireshark.org/review/24192 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=90867dd8e37c3e348ad2ecac9f30679666fb9fbe commit 90867dd8e37c3e348ad2ecac9f30679666fb9fbe Author: Anders Date: Mon Oct 30 22:23:07 2017 +0100 [BSSGP] Add PEI Change-Id: I64d1924aba3c11fa72fbb12121bd09bcf21d598d Reviewed-on: https://code.wireshark.org/review/24193 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d21eb05ebadd011083b3f9da3dfd320a55c7bc52 commit d21eb05ebadd011083b3f9da3dfd320a55c7bc52 Author: Anders Date: Mon Oct 30 21:41:59 2017 +0100 [BSSGP] Fix IE numbering in PERFORM-LOCATION messages. Change-Id: If767d905177b8d78f6b5d3c4e7b8d32a9e8a596a Reviewed-on: https://code.wireshark.org/review/24191 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9a464fd9bd9b43bb4f7fbe8a9e5e0c6c34ffec50 commit 9a464fd9bd9b43bb4f7fbe8a9e5e0c6c34ffec50 Author: Jo??o Valverde Date: Mon Oct 30 08:42:26 2017 +0000 Avoid asserting with EAFNOSUPPORT We require support for AF_INET/AF_INET6 to run and assume this is available on all supported platforms. If and when reality clashes with that assumption just avoid aborting. Errors are to be expected as long as they don't produce a crash. Change-Id: I5c107b1a8fd64441eb96f48381412e180b66feb7 Reviewed-on: https://code.wireshark.org/review/24187 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=e4ac91091d874129737ec797e6a932962e6946cd commit e4ac91091d874129737ec797e6a932962e6946cd Author: Graham Bloice Date: Mon Oct 30 19:22:44 2017 +0000 tshark doc updates After other changes, add info about -G help and update output from -G dissector-tables. Change-Id: I339d5c31a606720ef92e641e59ec5a45114321a8 Reviewed-on: https://code.wireshark.org/review/24188 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=0de8c6f4c70728f803de7a47bccd982ec48b691e commit 0de8c6f4c70728f803de7a47bccd982ec48b691e Author: Guy Harris Date: Mon Oct 30 11:28:21 2017 -0700 FT_IPv4 fields' values are 4-byte integers, not structures with a pointer. Fix a tpyo while we're at it. Change-Id: I1bde763ec2bd188c0f8afd1069db5a9f23963e8e Reviewed-on: https://code.wireshark.org/review/24186 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=bbae1d25c2b950256671576482896561995ba42c commit bbae1d25c2b950256671576482896561995ba42c Author: Guy Harris Date: Mon Oct 30 11:00:02 2017 -0700 Fix indentation. Change-Id: I0cc9d31cbe5dc7a95908a43c093f62e13b969eec Reviewed-on: https://code.wireshark.org/review/24185 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e73571117cc991bea4e485e201809a6a0ae07247 commit e73571117cc991bea4e485e201809a6a0ae07247 Author: Anders Date: Mon Oct 30 12:49:07 2017 +0100 [BSSGP] Fix decoding of Paging Attempt Information in PAGING PS. Change-Id: I46770e4e50c34f13eaf6244de0ac6345b12646b5 Reviewed-on: https://code.wireshark.org/review/24182 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9008d7f867acbef624cc9522513d39521b3ce2b9 commit 9008d7f867acbef624cc9522513d39521b3ce2b9 Author: Pascal Quantin Date: Mon Oct 30 10:40:46 2017 +0100 Fix assert when trying to display an IPv4 address Follow-up of gdd1c18dd Change-Id: Ifa6fc2e68f866540184a29a5fb61c3b7033bc8b2 Reviewed-on: https://code.wireshark.org/review/24180 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=d597b5d61ec941df2c1a3bd56c125dd70aa7d47c commit d597b5d61ec941df2c1a3bd56c125dd70aa7d47c Author: Michael Mann Date: Sun Oct 29 15:24:27 2017 -0400 Remove port_type values not set in pinfo->ptype NCP and SBCCS values used for conversation (endpoints) and not to pass "type" to subdissectors. Change-Id: I56a13d2bb7d718b340e9b5a102c43f6e0012bfb9 Reviewed-on: https://code.wireshark.org/review/24174 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=39ba9d4e7fb52ca8017bd4e934d6e6f8acba8d4c commit 39ba9d4e7fb52ca8017bd4e934d6e6f8acba8d4c Author: Guy Harris Date: Sun Oct 29 19:10:46 2017 -0700 Add wsutil/inet_ipv4.h. It defines a ws_in4_addr type, which is intended to hold IPv4 addresses in network byte order, and some macros to test for IPv4 addresses in the local network control block and multicast IPv4 addresses. Use those macros in places where dissectors had their own code for that purpose. Change-Id: I4252b410e37207157be85119a332e2a6913b332f Reviewed-on: https://code.wireshark.org/review/24178 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=dd1c18dd031038cbee7e219e322cbea1eafc87ca commit dd1c18dd031038cbee7e219e322cbea1eafc87ca Author: Guy Harris Date: Sun Oct 29 18:39:41 2017 -0700 Make FT_IPv4 a bit more like FT_IPv6. FT_IPv6 doesn't expose the prefix, which is used only for values in filter expressions, not values in protocol fields; do the same for FT_IPv4, hiding the netmask, and using fvalue_get_integer() to get the value, having it return a network-byte-order value for the address. (This also makes it opaque whether the address and netmask are stored in host or network byte order.) Change-Id: I4285a87f6ccef2c0ccec040490ddcd15d787326e Reviewed-on: https://code.wireshark.org/review/24177 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=734c5b35a5491794dc9cb31ed07a8d0d5576d4f5 commit 734c5b35a5491794dc9cb31ed07a8d0d5576d4f5 Author: Guy Harris Date: Sun Oct 29 17:49:34 2017 -0700 Get rid of ipv4_get_net_order_addr() and ipv4_get_host_order_addr(). Just directly use the addr field, converting from host to network byte order if necessary. Change-Id: Ie1cd9ea5527b7824014dc315225ad2a6adb61c38 Reviewed-on: https://code.wireshark.org/review/24176 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=3630a447d9e73f3e04cfe37dd578d22a452fbbe6 commit 3630a447d9e73f3e04cfe37dd578d22a452fbbe6 Author: Guy Harris Date: Sun Oct 29 15:29:31 2017 -0700 Get rid of unused #defines. Change-Id: I6d4f56cddbe4378a3a7d4feb5ac16933675ac83b Reviewed-on: https://code.wireshark.org/review/24175 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=62b870a72261f71f66ece9cb3b892d9999e805e3 commit 62b870a72261f71f66ece9cb3b892d9999e805e3 Author: Jo??o Valverde Date: Sun Oct 29 19:22:39 2017 +0000 Do not assert in ws_inet_ntop() Change-Id: I9d420c5f6bc29ce94855017739169dc8e8ce4d48 Reviewed-on: https://code.wireshark.org/review/24173 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=bebd79aae9ccaf5c96666d38665b69484f1f3eda commit bebd79aae9ccaf5c96666d38665b69484f1f3eda Author: Jo??o Valverde Date: Mon May 16 20:16:53 2016 +0100 parlay: Add another pragma to disable warning Use our DIAG_OFF macros instead while at it. Change-Id: I01d8d71a42fb108be156a68f8552ce537a1e2484 Reviewed-on: https://code.wireshark.org/review/15467 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=63966ec5d5b65cde2297f1f7417d288f884a80b2 commit 63966ec5d5b65cde2297f1f7417d288f884a80b2 Author: Michael Mann Date: Sun Oct 29 14:29:27 2017 -0400 Use endpoint_type in conversation tables and hostlists Follow up to having conversions use endpoint_type instead of port_type. Change-Id: Ifd59a33bd8b9a013c242bce5fcceb09533f02c17 Reviewed-on: https://code.wireshark.org/review/24172 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=765a67b68af28a6dbbb5c79d350896efbaa7adf4 commit 765a67b68af28a6dbbb5c79d350896efbaa7adf4 Author: Michael Mann Date: Sun Oct 29 12:38:41 2017 -0400 "Hardcode" the port types used by Export PDU functionality The "internal" port type has been serialized by export PDU functionality and nettrace_3gpp_32_423 wiretap. To better support "endpoint" functionality the port types will be removed/updated and that changes the implicit values from the port_type enum. Take a snapshot of the current port_type values and use those specific values when reading/writing export PDU data and provide conversion functions that can be modified when port_types are removed. Do the same for nettrace_3gpp_32_423 wiretap. Change-Id: I770bd0cab22e84f3cf49032fc86c5927bf85263f Reviewed-on: https://code.wireshark.org/review/24169 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1e8e9a807fd18c070489988c03e4ae5b4701667a commit 1e8e9a807fd18c070489988c03e4ae5b4701667a Author: Gerald Combs Date: Sun Oct 29 09:47:12 2017 -0700 make-manuf: Fix a comment. make-manuf lives in the "tools" directory. Change-Id: I9be2d44178f27d46629c439ff61f624d8d99e681 Reviewed-on: https://code.wireshark.org/review/24168 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=abfb6441177961fbdfa9648fdd2c40ef0ef3cefd commit abfb6441177961fbdfa9648fdd2c40ef0ef3cefd Author: Michael Mann Date: Sun Oct 29 10:12:59 2017 -0400 Add conversation endpoint type For the moment this mirrors the port_type enumeration (PT_XXX), but the intent is to move away from using "port types", eliminating most (if not all) Added conversation_pt_to_endpoint_type() so that conversations deal with the correct enumeration. This is for dissector that use pinfo->ptype as input to conversation APIs. Explicit use of port types are converted to using ENDPOINT_XXX type. Change-Id: Ia0bf553a3943b702c921f185407e03ce93ebf0ef Reviewed-on: https://code.wireshark.org/review/24166 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1bc6d4e96573f89ecdd719cb3cac92754b91f52c commit 1bc6d4e96573f89ecdd719cb3cac92754b91f52c Author: Jeff Dyer Date: Fri Oct 27 12:33:50 2017 -0600 Diameter: Add Huawei DCC AVPs Change-Id: I480e58a1676677bb362bb4e9dc866c5d5f0814e1 Reviewed-on: https://code.wireshark.org/review/24111 Reviewed-by: Jeff Dyer Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fe8d897e2557f109b252ce83421d929c1ac039c6 commit fe8d897e2557f109b252ce83421d929c1ac039c6 Author: Jo??o Valverde Date: Sun Oct 29 12:21:27 2017 +0000 sizeof(buf) is not what you want here Change-Id: Iaf3463006b93c9acdc27f59fcbbea92df1d2fd7d Reviewed-on: https://code.wireshark.org/review/24164 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=7507b11ec4440b8183a10113f5b33f56e6202c0e commit 7507b11ec4440b8183a10113f5b33f56e6202c0e Author: Jo??o Valverde Date: Sun Oct 29 11:25:30 2017 +0000 Improve our ip6_to_str_buf() implementation Change-Id: I02b5d01797e526299a6dc5a031662cb78e4f8423 Reviewed-on: https://code.wireshark.org/review/24163 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=de1b26a3c6fa27b29157e86a6da03f354586badb commit de1b26a3c6fa27b29157e86a6da03f354586badb Author: Jo??o Valverde Date: Sun Oct 29 11:09:55 2017 +0000 More ws_inet_ntop() tweaks. Change-Id: I8f77f189337f9299e566a4149ae6ea481d3dbed6 Reviewed-on: https://code.wireshark.org/review/24162 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=a25af02ef7c3dee6d83f5d61fdb62ec8ebec971c commit a25af02ef7c3dee6d83f5d61fdb62ec8ebec971c Author: Guy Harris Date: Sun Oct 29 01:25:24 2017 -0700 Clean up processing of encoded addresses. Allocate the buffer at the point we fill it in, and pick the appropriate size or let the wmem_strXXX routine do it for us. If we aren't using an address table, just fetch the value as an IPv4 address and hand it to ip_to_str_buf() - don't fetch it in host byte order and then *fix* it by byte-swapping (hint: on a big-endian machine, host byte order *is* network byte order and you don't want to swap it; not all the world's an x86). Change-Id: I966b107271ba166ff76a5600fbc4922808e7ead1 Reviewed-on: https://code.wireshark.org/review/24159 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=930f6345157659fca89d922612bfbb69d8a8b53e commit 930f6345157659fca89d922612bfbb69d8a8b53e Author: Gerald Combs Date: Sun Oct 29 08:18:09 2017 +0000 [Automatic update for 2017-10-29] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ia316bd89a4a8d08237b0e5eb9f0036dc5a6bad61 Reviewed-on: https://code.wireshark.org/review/24157 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=78f9a07f0a43cdd4dd9716c8599780609d00c390 commit 78f9a07f0a43cdd4dd9716c8599780609d00c390 Author: Jo??o Valverde Date: Sun Oct 29 01:09:36 2017 +0100 Remove unused epan/compress/ source code Change-Id: I8f3bd41ff35f00b7a423751bc312725b7e7ae316 Reviewed-on: https://code.wireshark.org/review/24152 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=e1ef732c11da520262476b782bc73bfaf6e9ef1d commit e1ef732c11da520262476b782bc73bfaf6e9ef1d Author: Guy Harris Date: Sat Oct 28 22:50:33 2017 -0700 Get rid of MAX_IP_STR_LEN and MAX_IP6_STR_LEN. We have WS_INET_ADDRSTRLEN and WS_INET6_ADDRSTRLEN; use them. Change-Id: Idade0da9fae70d891901acd787b06d21e2ddbc5f Reviewed-on: https://code.wireshark.org/review/24156 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=83a4eadc070bcfda137b0f44e02712b46e5cb1d0 commit 83a4eadc070bcfda137b0f44e02712b46e5cb1d0 Author: Jo??o Valverde Date: Sun Oct 29 01:26:56 2017 +0000 wtap.h: Replace literal buffer size with WS_INET_ADDRSTRLEN Bug: 14149 Change-Id: Ib7d60f93373eb23f5c950607f4cf6fc832c79670 Reviewed-on: https://code.wireshark.org/review/24154 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ce25b358a94205c92e3b2612abf12119c50af1c4 commit ce25b358a94205c92e3b2612abf12119c50af1c4 Author: Guy Harris Date: Sat Oct 28 22:30:37 2017 -0700 Go with the RFC 2133-and-successors values for IPv4 and IPv6 address strings. Add a comment explaining why Windows has different, larger values for INET_ADDRSTRLEN and INET6_ADDRSTRLEN. Change-Id: I4ad53c6cffae46d108f778460ce653dcc9343c64 Reviewed-on: https://code.wireshark.org/review/24155 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0527747e23f85bb9d3cf4ca69364e615bd22e1e9 commit 0527747e23f85bb9d3cf4ca69364e615bd22e1e9 Author: Jo??o Valverde Date: Tue Oct 24 23:09:19 2017 +0100 Retire use of getprotobynumber() Dead weight. If this feature is wanted getprotobynumber() should be called once on startup. Change-Id: I0358bacdc60466f676fa1aab7f4b7c9e588d8d74 Reviewed-on: https://code.wireshark.org/review/24045 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=18237cfd1513e10bc02599c263fbd855551da628 commit 18237cfd1513e10bc02599c263fbd855551da628 Author: Jo??o Valverde Date: Wed Oct 25 22:59:19 2017 +0100 configure: Display ssh_user_agent as a libssh sub-option Change-Id: I19e38015d1395b021bc5169a6bf37fba0c5b1fe9 Reviewed-on: https://code.wireshark.org/review/24116 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=7dbc520d57b8567738a15f617a11d9b5b70f40a7 commit 7dbc520d57b8567738a15f617a11d9b5b70f40a7 Author: Michael Mann Date: Sat Oct 28 13:26:51 2017 -0400 Privatize the conversation_key structure The intention is to make it more transparent when making a switch to an "endpoint" over address/port combination. Change-Id: Ic424c32095ecb103bcb4f7f4079c549de2c8d9c4 Reviewed-on: https://code.wireshark.org/review/24148 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=db3be9f850446c1a1c4894f5d08d67a370abf94a commit db3be9f850446c1a1c4894f5d08d67a370abf94a Author: Michael Mann Date: Sat Oct 28 11:47:52 2017 -0400 Remove display of "old" key in GTK configuration hashtable dialog The information was for internal debugging, presumably as conversations were converted to use the new algorithm. The algorithm has been in place for a few years now and GTK is deprecated. Change-Id: Ice0d0611bfbc0970089c671ab2cca15bfa5bf2fa Reviewed-on: https://code.wireshark.org/review/24147 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=051dcd1086ad98d4c604740a6f95fd8eec9a75d3 commit 051dcd1086ad98d4c604740a6f95fd8eec9a75d3 Author: Nikolai Ipatyev Date: Sat Oct 28 20:30:24 2017 +0300 Fix bug in FMPUX heuristic dissector The variables in the check were reversed Change-Id: Idc7fc2b88ac1cde699b76423890918ce4b0ac086 Reviewed-on: https://code.wireshark.org/review/24149 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7df5fcdc51cb2616dc7ec97187e73ab7ecccc7b3 commit 7df5fcdc51cb2616dc7ec97187e73ab7ecccc7b3 Author: Michael Mann Date: Sat Oct 28 11:15:44 2017 -0400 Share use of conversation_hash_exact It was duplicated in GTK, so just make it public (at least for now) Change-Id: I89d985b2d42f0edb1c535a65a97b132920dedbcd Reviewed-on: https://code.wireshark.org/review/24146 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=23afd9a18453c23cfbbc6a63f52b2e6e64e0056c commit 23afd9a18453c23cfbbc6a63f52b2e6e64e0056c Author: Michael Mann Date: Sat Oct 28 09:58:28 2017 -0400 Convert to using find_conversation_pinfo where appropriate This makes it easier to identify the simpler/common conversations Change-Id: I7094f23e49156ee27f5f72c8e130308470f3e462 Reviewed-on: https://code.wireshark.org/review/24145 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=27c10ed72ea2451bfbb6c0eb50af4280e65a3fcf commit 27c10ed72ea2451bfbb6c0eb50af4280e65a3fcf Author: Michael Mann Date: Fri Oct 27 16:41:18 2017 -0400 AMQP: Add dissector table for versions so they can be dissected with Decode As Bug: 14113 Change-Id: I73c4962597d8f8bab83f089c9821269e0b7b1568 Reviewed-on: https://code.wireshark.org/review/24109 Petri-Dish: Michael Mann Reviewed-by: Magnus Henoch Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5907d17b9a36133a13a11e1aa437e178b6c12b72 commit 5907d17b9a36133a13a11e1aa437e178b6c12b72 Author: Alexis La Goutte Date: Sun Oct 22 19:02:32 2017 +0200 QUIC: Display Connection ID (CID) on hexa Ping-Bug: 13881 Change-Id: I7b97e27b6d2091a18e5fc3fd27251523a446cfde Reviewed-on: https://code.wireshark.org/review/24020 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b0edc623b12a60ef6afdf9bdf9f762d61748df58 commit b0edc623b12a60ef6afdf9bdf9f762d61748df58 Author: Alexis La Goutte Date: Sat Oct 28 13:29:56 2017 +0200 IEEE 1905.1a: fix an infinite loop (CID 1420355) Change-Id: Iaa8e82cb5dc9f32e5c9dbf1db1068868d6fd3f18 Reviewed-on: https://code.wireshark.org/review/24144 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=695d8fc3183898d9d63c017b0b82716126a461f9 commit 695d8fc3183898d9d63c017b0b82716126a461f9 Author: Guy Harris Date: Fri Oct 27 22:25:15 2017 -0700 MOAR PRE-ALLOCATED FIELDS. Do what the errors in the master buildbots say to do. Change-Id: I2b926bd9a75a1490390c42b8080f29e48096a3b4 Reviewed-on: https://code.wireshark.org/review/24143 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=2b615cf32250173e21b36960b48c290298b360ca commit 2b615cf32250173e21b36960b48c290298b360ca Author: Guy Harris Date: Fri Oct 27 21:25:50 2017 -0700 Also display the protocol with -G dissector-tables. Change-Id: If5c61195ad6bfb86c8e047428abaa6b0d48e7d74 Reviewed-on: https://code.wireshark.org/review/24142 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=985c0594a57317dbc612228f423fd38967c677bf commit 985c0594a57317dbc612228f423fd38967c677bf Author: Guy Harris Date: Fri Oct 27 21:17:52 2017 -0700 Indicate Decode As support in the -G dissector-tables output. Change-Id: I95535ba11fdcac37057d1441e850ddf5455d32cf Reviewed-on: https://code.wireshark.org/review/24141 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a1218446d9990fd2710c3f9fe565907c202393a9 commit a1218446d9990fd2710c3f9fe565907c202393a9 Author: Guy Harris Date: Fri Oct 27 20:29:25 2017 -0700 Put all the 11n vs. 11ac stuff together. Also, there's no need to zero out the NSS values for 11ac - we zero out the entire pseudo-header at the beginning. We only need to set them if we *have* them. Change-Id: I9ebda7e246c24941ca77314bba6f86dea41e5992 Reviewed-on: https://code.wireshark.org/review/24135 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7ddfee9aead225465cbcdd5a29d7af5332bdccb7 commit 7ddfee9aead225465cbcdd5a29d7af5332bdccb7 Author: Michael Mann Date: Fri Oct 27 21:07:05 2017 -0400 tshark: Use -G help instead of -G ? Not all platforms handle ? or -? *predictably* at the command line. As long as "?" isn't replaced with a file name, it works, but if it gets replaced by a file name... Bug: 13984 Change-Id: I4496bb27fdef121967e7baf7b7f4a1bb0a44b00a Reviewed-on: https://code.wireshark.org/review/24125 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7c9ec1d13cdb29725c6d093b7cb21357fd43b5f9 commit 7c9ec1d13cdb29725c6d093b7cb21357fd43b5f9 Author: Guy Harris Date: Fri Oct 27 19:43:47 2017 -0700 Don't add for "Decode As" if the dissector table doesn't support it. While we're at it, consistently use "name" as the name of the argument giving the dissector table name. Change-Id: Ied54c88d0d3dd467fe9067b008b49ead754c31a2 Reviewed-on: https://code.wireshark.org/review/24131 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=89e40fad2975fe8d1fcec8f786b19e45057938a5 commit 89e40fad2975fe8d1fcec8f786b19e45057938a5 Author: Michael Mann Date: Fri Oct 27 20:36:09 2017 -0400 packet-knxnetip.c: Fix bitmask Bug: 14115 Change-Id: I836ee337f4727b0592cda074975c20a68fe7a27d Reviewed-on: https://code.wireshark.org/review/24124 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c6c709490c5a38f7e45ef06843d30b0f8b40636a commit c6c709490c5a38f7e45ef06843d30b0f8b40636a Author: Michael Mann Date: Fri Oct 27 20:09:19 2017 -0400 Q931: Fix Q931_ISO_IEC_STANDARDIZED_CODING value It's typically masked with 0x60 without any bit shifting, so make the value reflect it Bug: 14116 Change-Id: I677c609a8e19a66ee557ac24c721ecb2312131a5 Reviewed-on: https://code.wireshark.org/review/24123 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ce181cbc87f8c9012d6df79b1e9280908a78ec51 commit ce181cbc87f8c9012d6df79b1e9280908a78ec51 Author: Bruno Verstuyft Date: Fri Oct 27 17:22:46 2017 +0200 DOCSIS: DPD: adding modulation list to info column Change-Id: I5d99692d897f17e6e14952db8e4736ca65aa1373 Reviewed-on: https://code.wireshark.org/review/24106 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=087faa248845059203de152b6c1cc806f89a8599 commit 087faa248845059203de152b6c1cc806f89a8599 Author: Michael Mann Date: Fri Oct 27 19:21:16 2017 -0400 Always provide value for Decode As selector column Previous logic required multiple values from the decode as structure in order to provide an initial value. This was incorrect and led to values from protocol not selected showing in the selector column. Change-Id: If1ad5085f4a6eb8d79fc5dd72be968188051ec4e Reviewed-on: https://code.wireshark.org/review/24122 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=86302a7622a1fe529abb042033a856bcf25602fe commit 86302a7622a1fe529abb042033a856bcf25602fe Author: Thomas Wiens Date: Fri Oct 27 14:18:01 2017 +0200 s7comm: Syntax-id decoding of frequency inverter parameters Add Syntax-id decoding for accessing frequency inverter parameters. Moved the decoding of all other syntax-ids to separate functions. Change-Id: Iba41f0631c4aeaf31a4ec6f73ffc42ca0b76f00d Reviewed-on: https://code.wireshark.org/review/24102 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=86cb152b2fa95adbac629a65398f4b9b9949c95f commit 86cb152b2fa95adbac629a65398f4b9b9949c95f Author: Nicolas Darchis Date: Thu Oct 26 08:32:56 2017 -0400 peekremote: Support properly 11ac MCS rates. The spatial streams amount support is still to be added. Bug: 14136 Change-Id: I58b4ff4febcbd871c063a7add6a1e6b79ef23683 Reviewed-on: https://code.wireshark.org/review/24079 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3a6552744f2e44954a9e378dd076c8758bb5f1bb commit 3a6552744f2e44954a9e378dd076c8758bb5f1bb Author: Michael Mann Date: Fri Oct 27 16:39:50 2017 -0400 Add find_conversation_pinfo Convenience function to add the same parameters to find_conversation as find_or_create_conversation. Change-Id: I3a92541cb9c1e827a9de8248825636debbd989cd Reviewed-on: https://code.wireshark.org/review/24118 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f24651493d04b974722b0b70179bcb6b9150a605 commit f24651493d04b974722b0b70179bcb6b9150a605 Author: Michael Mann Date: Fri Oct 27 13:56:13 2017 -0400 OSPF: dissect_ospf_bitfield -> proto_tree_add_bitmask Change-Id: Iaaa76ac8a5aad457258de3c23828cf3738f612c2 Reviewed-on: https://code.wireshark.org/review/24110 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4c8dfe6f6ef54e9b413a31f5f4bc18703a6c114e commit 4c8dfe6f6ef54e9b413a31f5f4bc18703a6c114e Author: Magnus Henoch Date: Fri Oct 27 17:20:15 2017 +0100 Autodetect more AMQP 0-9 captures When an capture file containing AMQP 0-9 traffic is missing the protocol header, and the first packet contains more than one AMQP frame, we'd fail to detect the protocol version properly, since we'd check for the frame size being equal to the PDU size. Fix this case by checking if the frame fits within the PDU instead. While it's possible that 0-10 and 1.0 captures could be misdetected as 0-9, this seems highly unlikely. See details in comment in packet-amqp.c. Bug: 14113 Change-Id: I98978ed3919be3daf7fe9a972b87e09f27ba20e3 Reviewed-on: https://code.wireshark.org/review/24108 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c59601eeeab2b6e8778a0f9f0afd03d9cbfbf3c4 commit c59601eeeab2b6e8778a0f9f0afd03d9cbfbf3c4 Author: Jo??o Valverde Date: Wed Oct 25 22:07:48 2017 +0100 Remove AC_PROG_GCC_TRADITIONAL from configure.ac Apparently this macro is (was?) used for CPP and some esoteric old non-ISO C headers, which we don't use. (Introduced with the very first Wireshark git commit.) Change-Id: I22c32161aaa8df450d36d145b03cfcd62aa6268a Reviewed-on: https://code.wireshark.org/review/24119 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=398dc811273b54d14e6965bb1af9cfe1360650f0 commit 398dc811273b54d14e6965bb1af9cfe1360650f0 Author: Jeff Dyer Date: Fri Oct 27 13:04:43 2017 -0600 Change NewCo to new Company name, Aliv Change-Id: I84c06a7f168da0f65b7c76360f38f39ecf1024d0 Reviewed-on: https://code.wireshark.org/review/24112 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e2afd06e6514721d2b9142269bd2bf1eb97393c0 commit e2afd06e6514721d2b9142269bd2bf1eb97393c0 Author: Jo??o Valverde Date: Fri Oct 27 07:26:58 2017 +0100 YACC is set to the missing script if not found Change-Id: I38ce7542e96c7571fa179e550cfba39d16dc417f Reviewed-on: https://code.wireshark.org/review/24117 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=764431f8825ce628a01f14ca83a8bd29b094a8b1 commit 764431f8825ce628a01f14ca83a8bd29b094a8b1 Author: Jo??o Valverde Date: Fri Oct 27 14:23:03 2017 +0100 autotools: Fix LN_S usage "cp" always takes two arguments. Change-Id: I6183988a24a38b1091d31a4e533b329f89f35dac Reviewed-on: https://code.wireshark.org/review/24113 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=42f5aa4566d4a933270cdd50138d34262e192ada commit 42f5aa4566d4a933270cdd50138d34262e192ada Author: Pascal Quantin Date: Fri Oct 27 17:42:54 2017 +0200 IEEE 1905.1a: fix an infinite loop (CID 1420356) Change-Id: I39b75acbf3598ad4e32e268f4b4378f16ca273c6 Reviewed-on: https://code.wireshark.org/review/24107 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=33d28030b1721c847780ee7d563515cb661746ca commit 33d28030b1721c847780ee7d563515cb661746ca Author: AndersBroman Date: Fri Oct 27 15:58:07 2017 +0200 [AMR] Change the Payload type preference to a range and have separate ranges for AMR and AMR-WB. Change-Id: If5dca10b226a09168f1b1f834d97b826f8b777d6 Reviewed-on: https://code.wireshark.org/review/24105 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=395c54c4894dc7cc9d0dfb430e657c357075ab63 commit 395c54c4894dc7cc9d0dfb430e657c357075ab63 Author: AndersBroman Date: Fri Oct 27 15:52:24 2017 +0200 [BSSGP] Fix decoding of PERFORM-LOCATION-REQUEST. Change-Id: I5039c93bd4f572599386a314a16230d7c1aaaf23 Reviewed-on: https://code.wireshark.org/review/24104 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=bb7511bccf5427a25dc26b14ba7fe76d464e8e2f commit bb7511bccf5427a25dc26b14ba7fe76d464e8e2f Author: AndersBroman Date: Fri Oct 27 15:47:42 2017 +0200 [BSSMAP-LE] Add dissection of 10.18 Location Type. Change-Id: I54900e13eca61cd1f190934a77cb0e704c877dfe Reviewed-on: https://code.wireshark.org/review/24103 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4ee492e9109c95171bd425b4ac327c613ce56f00 commit 4ee492e9109c95171bd425b4ac327c613ce56f00 Author: Taisuke Sasaki Date: Thu Oct 26 13:08:34 2017 +0900 OSPFv2 Segment Routing extention support with RFC7684. - RFC7684 - draft-ietf-ospf-segment-routing-extensions-20 Bug: 12297 Change-Id: I3acafe95ae2ef44a433c38c2495169d77e3c955d Reviewed-on: https://code.wireshark.org/review/24070 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=545f20022419affa1ad71824b434141551359cc3 commit 545f20022419affa1ad71824b434141551359cc3 Author: Marius Paliga Date: Fri Oct 27 13:21:50 2017 +0200 PFCP: Dissect Node ID: Fix length of FQDN Node Id Type Octet 5 (Spare Node/ID Type) is included in the IE length and FQDN uses just remainding length Change-Id: I9c6e1de850bda0af315cbf801e757af6b25ed33e Reviewed-on: https://code.wireshark.org/review/24101 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Reviewed-by: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0a033cdc653b0ce4ec921312b4a34c7a028039f8 commit 0a033cdc653b0ce4ec921312b4a34c7a028039f8 Author: Pascal Quantin Date: Fri Oct 27 09:08:54 2017 +0200 IEEE 1905.1a: remove an unused hf variable Change-Id: I03d37495937020407783d366d01e3ad353889e80 Reviewed-on: https://code.wireshark.org/review/24098 Petri-Dish: Pascal Quantin Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=b085418501ee1222b75cd424e4a076c0ca99ec91 commit b085418501ee1222b75cd424e4a076c0ca99ec91 Author: Pascal Quantin Date: Fri Oct 27 09:07:56 2017 +0200 IEEE 1905.1a: add what seems to be missing breaks Change-Id: I60b41e503bc8933fb2efb2016b565caa0ec3bb97 Reviewed-on: https://code.wireshark.org/review/24097 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=4330b268b22be9ccd54ef5e8a64469a39a6045bf commit 4330b268b22be9ccd54ef5e8a64469a39a6045bf Author: Pascal Quantin Date: Fri Oct 27 10:00:52 2017 +0200 debian: add ws_compiler_tests.h to libwsutils-dev.install Change-Id: Ia2db7069a22c4786b0628fd554038b3091388963 Reviewed-on: https://code.wireshark.org/review/24099 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=db41ccd009ab01179f8629ba962e76ba7a6fda61 commit db41ccd009ab01179f8629ba962e76ba7a6fda61 Author: Richard Sharpe Date: Sun Sep 10 18:17:20 2017 -0700 Device provisioning protocol: Fix a last issue with DPP and Configuration commands not being searchable. Change-Id: I28cf212b3eacb16572ce9d1ff2dbf45040046b00 Reviewed-on: https://code.wireshark.org/review/24069 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=42a9e893fb95f8f8612b52d4be00f7bbf6f7546b commit 42a9e893fb95f8f8612b52d4be00f7bbf6f7546b Author: Guy Harris Date: Thu Oct 26 19:00:20 2017 -0700 Clean up a bit. If we're using Clang, use either _Pragma("clang diagnostic XXX") or nothing; don't use _Pragma("GCC diagnostic XXX"). If we're using something other than Clang that is, or claims to be, GCC, use _Pragma("GCC diagnostic XXX") or nothing. Explain why we're only using _Pragma("GCC diagnostic XXX") with GCC 4.8 or later, even though it's supported in GCC 4.2 and later, and even though 4.6 an later support _Pragma("GCC diagnostic {push,pop}"). Change-Id: I7a5f46ec419b945663d473cb4ae435ab7fdcf0ef Reviewed-on: https://code.wireshark.org/review/24096 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1ceab868cd0c86e1a64e0b80150163a5b87b51ea commit 1ceab868cd0c86e1a64e0b80150163a5b87b51ea Author: Paul Offord Date: Thu Oct 26 23:08:43 2017 +0100 TRANSUM: File loading slow with transum enabled This change improves performance through better handling of SYN - SYN/ACK pairs. Bug: 14094 Change-Id: Ie479f1b69fa48f85a2ed9f8f173533db25582bbd Reviewed-on: https://code.wireshark.org/review/24090 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4e4f1debb75bece8f0a130d2f356f12bd5be0f00 commit 4e4f1debb75bece8f0a130d2f356f12bd5be0f00 Author: Guy Harris Date: Thu Oct 26 18:26:35 2017 -0700 Fix typo. Change-Id: I27373dd3823d3527ad3ebf272169feb7323b1a83 Reviewed-on: https://code.wireshark.org/review/24094 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e82adfba74957948781c0518088bd16365740c18 commit e82adfba74957948781c0518088bd16365740c18 Author: Pascal Quantin Date: Thu Oct 26 22:47:19 2017 +0200 proto.c: do not set an item length longer that the remaining tvb length Ping-Bug: 14128 Change-Id: Iae5cb2f85d5d2fa3f2b6051aa57390a3f73d724a Reviewed-on: https://code.wireshark.org/review/24087 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ed20250c132c5855dcb0df991c31ab4de6b47a61 commit ed20250c132c5855dcb0df991c31ab4de6b47a61 Author: Pascal Quantin Date: Thu Oct 26 23:23:17 2017 +0200 proto.c: protect against buffer overflow in proto_find_undecoded_data() Bug: 14128 Change-Id: I01aadf2dc9a3f714caaef273a7e012c6f1840726 Reviewed-on: https://code.wireshark.org/review/24088 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a0973d0f947df731e9e182c8b03d6e351591f457 commit a0973d0f947df731e9e182c8b03d6e351591f457 Author: Guy Harris Date: Thu Oct 26 14:59:40 2017 -0700 Move the compiler version tests to ws_compiler_tests.h and use them elsewhere. While we're at it, sort some header file lists, and clean up white space. Change-Id: If737dda45334fedf1df7295d8719ad9381daf7a1 Reviewed-on: https://code.wireshark.org/review/24089 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ea49c337c59ac9a8d0b868581f341092f4b61814 commit ea49c337c59ac9a8d0b868581f341092f4b61814 Author: Christopher Maynard Date: Sat Jul 29 12:18:26 2017 -0400 Include VLAN ID in key for ICMP request/response tracking Add global preference to allow for "stricter" conversation tracking Bug: 13518 Change-Id: I166a084c402374fa76dac7bb54f941e2e9c9325a Reviewed-on: https://code.wireshark.org/review/22842 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=05b1d35586aee37dad7d84fa27531fc9794a41c9 commit 05b1d35586aee37dad7d84fa27531fc9794a41c9 Author: Richard Sharpe Date: Wed Oct 25 19:38:33 2017 -0700 Initial coding of the ieee1905 dissector with Multi-AP support. Change-Id: I94da228cba6baf20a2cd02bafc9704492f2cfc9f Reviewed-on: https://code.wireshark.org/review/23956 Petri-Dish: Alexis La Goutte Reviewed-by: Richard Sharpe Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b4a6f4e2441153ffa8c6df7d790bc9cb66df0a9e commit b4a6f4e2441153ffa8c6df7d790bc9cb66df0a9e Author: Jakub Zawadzki Date: Thu Oct 26 20:46:35 2017 +0200 oss-fuzzshark: add missing include to fix implicit declaration of color_filters_init() /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:218:7: warning: implicit declaration of function 'color_filters_init' is invalid in C99 [-Wimplicit-function-declaration] if (!color_filters_init(&err_msg, NULL)) ^ 1 warning generated. Change-Id: I37dbc4521b6a3cda271e6e33a290ed35911e7dda Reviewed-on: https://code.wireshark.org/review/24086 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6d092c134477ae1bd081a0ce8d79d964eb5f28eb commit 6d092c134477ae1bd081a0ce8d79d964eb5f28eb Author: Guy Harris Date: Thu Oct 26 11:38:49 2017 -0700 Whitespace cleanups. Change-Id: Ic19c143fc9143da230f286f1fe4aecc0fe8b08be Reviewed-on: https://code.wireshark.org/review/24085 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=985a8f297b5107bdd29df561fce1cfce5c541863 commit 985a8f297b5107bdd29df561fce1cfce5c541863 Author: Guy Harris Date: Thu Oct 26 11:24:22 2017 -0700 Move a comment to where it belongs, expand another comment. Change-Id: I04eff374132cbe4b93271c7a43303db406998bcb Reviewed-on: https://code.wireshark.org/review/24084 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=6ddee4aab22a96c444ace755fe33402f65e9f775 commit 6ddee4aab22a96c444ace755fe33402f65e9f775 Author: Gerald Combs Date: Thu Oct 26 10:50:25 2017 -0700 We don't need to define sockaddr_storage. Winsock2.h will do that for us via packet32.h. Change-Id: Ie834d49b052c3db6784481bb85d94d4eecff8287 Reviewed-on: https://code.wireshark.org/review/24082 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=fb160e53c8a9423ff78688bc9ef1ad5e1ec1edb1 commit fb160e53c8a9423ff78688bc9ef1ad5e1ec1edb1 Author: Guy Harris Date: Thu Oct 26 11:19:13 2017 -0700 Use more than just "does it claim to be GCC?" to test for attributes. Not all versions of GCC or Clang have the returns_nonnull function attribute, so use the same technique used in current master branch libpcap - use __has_attribute() if it's available, otherwise use compiler version tests. This also lets us use WS_NORETURN on some non-GCC compilers. Change-Id: I6ca4a81797ebfca9f743e16f83839c49d303da81 Reviewed-on: https://code.wireshark.org/review/24083 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b7f7bee8cf6ecb04a4dec86b80ce2065d4192da7 commit b7f7bee8cf6ecb04a4dec86b80ce2065d4192da7 Author: Gerald Combs Date: Thu Oct 26 09:05:06 2017 -0700 CMake: Set the Windows build target to Vista. Set NTDDI_VERSION and _WIN32_WINNT to their Vista values so that ws2tcpip.h will define inet_pton and inet_ntop. Remove the associated compiler version checks so that everyone is on the same page. Add breadcrumbs to the various parts of the code where we set a minimum Windows version. Change-Id: I83bba5fa1024bfbc02e07b120412807ad259e291 Reviewed-on: https://code.wireshark.org/review/24080 Petri-Dish: Gerald Combs Reviewed-by: Michael Mann Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=de6fcf2f21ee0a69b1d4d418f0c6d184b161a203 commit de6fcf2f21ee0a69b1d4d418f0c6d184b161a203 Author: Jo??o Valverde Date: Thu Oct 26 18:19:53 2017 +0100 Fix indentation Change-Id: I81892f2624920ccf3e2f18734665b9b2e99de5cf Reviewed-on: https://code.wireshark.org/review/24081 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=ac804b59e242c57e225c390eb8d6bec359a7003f commit ac804b59e242c57e225c390eb8d6bec359a7003f Author: Jo??o Valverde Date: Thu Oct 26 08:51:55 2017 +0100 Improve our inet_ntop() wrapper Also fix buffer length define, as it is not guaranteed to be 46 on Windows (it never was guaranteed anyway for the libc implementation, but the likelyhood of being greater was small). Change-Id: I2db705d86f825765ed32ec70b8d22058b5d629e8 Reviewed-on: https://code.wireshark.org/review/24074 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=296a36698b9ff2ab1beb3c21dc8409c3a276001c commit 296a36698b9ff2ab1beb3c21dc8409c3a276001c Author: Jo??o Valverde Date: Sun Oct 22 07:28:17 2017 +0100 configure: Remove profile-build option Developers should know how to instrument the code for profiling with a given toolchain. This particular case is trivially replaced with: ./configure CFLAGS="-pg" LDFLAGS="-pg" Change-Id: Icc4bca9a8dc5d3ae59a3ff5a8d155f8dc868fcdd Reviewed-on: https://code.wireshark.org/review/24054 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=3bafae200f5b08d386b5a3503023c0e3e2800947 commit 3bafae200f5b08d386b5a3503023c0e3e2800947 Author: Bruno Verstuyft Date: Thu Oct 26 11:57:15 2017 +0200 DOCSIS: added Energy Management and CM Status Ack modem capabilities Change-Id: Ieef2cbf34e32f0730af03acc65ebe3499e1fe1f3 Reviewed-on: https://code.wireshark.org/review/24076 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=52332e3f9a98c618f9300d8c88955ca9d11627b5 commit 52332e3f9a98c618f9300d8c88955ca9d11627b5 Author: Marius Paliga Date: Thu Oct 26 14:57:39 2017 +0200 PFCP: Fix offset after decoding Message Length Change-Id: I163b4b1dfcad68e392fbddc3327ad081ca304a85 Reviewed-on: https://code.wireshark.org/review/24078 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=91ae90ba82709a534d160dd35392dc60274ad3c1 commit 91ae90ba82709a534d160dd35392dc60274ad3c1 Author: Guy Harris Date: Thu Oct 26 03:03:23 2017 -0700 ipv4_get_net_order_addr() is no longer an exported function. At least not exported from libwireshark - it's now a static inline function defined in a header. Change-Id: Ic3eb397226459c7c8fb296f23777cbd0678a0a2f Reviewed-on: https://code.wireshark.org/review/24077 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b1147a60337ff7a6f24daacfbfabb681bf031fd5 commit b1147a60337ff7a6f24daacfbfabb681bf031fd5 Author: Guy Harris Date: Thu Oct 26 02:23:37 2017 -0700 Rename some IPv6 address test functions. They test where the address is XXX, for various values of XXX, so name them accordingly. Change-Id: I437175f02b3f97fecee77e8bb9416bb5b71cd0d0 Reviewed-on: https://code.wireshark.org/review/24075 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=458c3c026ed03d17ec7803c61981274ee4574f89 commit 458c3c026ed03d17ec7803c61981274ee4574f89 Author: Guy Harris Date: Thu Oct 26 01:50:00 2017 -0700 Add a ws_in6_addr typedef for struct e_in6_addr. That allows a parallel typedef of ws_in4_addr for guint32. Change-Id: I03b230247065e0e3840eb87635315a8e523ef562 Reviewed-on: https://code.wireshark.org/review/24073 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0a99d3ef31611db7020d062216c856923ed29fac commit 0a99d3ef31611db7020d062216c856923ed29fac Author: Guy Harris Date: Thu Oct 26 00:35:35 2017 -0700 Fix comments, remove a no-longer-needed include. Change-Id: I58cc8db41b474e937eb806510c277fe1830204fb Reviewed-on: https://code.wireshark.org/review/24072 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b331641f98a1e55f7bd325e1a6e55206ecfc8094 commit b331641f98a1e55f7bd325e1a6e55206ecfc8094 Author: Gerald Combs Date: Wed Oct 25 16:58:36 2017 -0700 CMake: Remove unused header checks. Remove the following unused header checks and defines: HAVE_INTTYPES_H HAVE_STDINT_H HAVE_STRINGS_H HAVE_SYSCONF Change-Id: I9f1307ead09c6800697004e7f79f5ac637eea3f7 Reviewed-on: https://code.wireshark.org/review/24067 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f97befbaa57ff432958d014b007c909e04cd8ff9 commit f97befbaa57ff432958d014b007c909e04cd8ff9 Author: Darien Spencer Date: Sat Oct 21 17:48:40 2017 +0300 RANAP: Associate RTP dissector with CS streams Change-Id: If02b8cc5110c70e50ae04d245c45b1d133ee7fd3 Reviewed-on: https://code.wireshark.org/review/24010 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=bfad9c56f9e65eafba00f97e5e649842782eb2e1 commit bfad9c56f9e65eafba00f97e5e649842782eb2e1 Author: Gerald Combs Date: Wed Oct 25 17:42:15 2017 -0700 CMake: Don't check for windows.h or winsock2.h. If we're building on Windows we're going to have windows.h and winsock2.h. Don't bother checking for them. Change-Id: I0004c44d7364ab3f41682f34b8c84cd8617c9603 Reviewed-on: https://code.wireshark.org/review/24068 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=859405fd2dd7b76e00d650e1674db2378e05beff commit 859405fd2dd7b76e00d650e1674db2378e05beff Author: Guy Harris Date: Thu Oct 26 00:03:09 2017 -0700 Swallow up the stuff from epan/ipv4.c into epan/ftypes/ftype-ipv4.c and epan/ipv4.h. Most of it doesn't need to be public; pull it into epan/ipv4.c. Pull the two routines that *are* used outside epan/ftypes/ftype-ipv4.c into epan/ipv4.h as static inline functions. This allows some optimization, and makes epan/ipv4.h more like epan/ipv6.h. Change-Id: I80229acde559d810aecec2acd5c995076440c181 Reviewed-on: https://code.wireshark.org/review/24071 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e7abfc397bfa8981b3813c19a64c36cfb275f21d commit e7abfc397bfa8981b3813c19a64c36cfb275f21d Author: Guy Harris Date: Wed Oct 25 15:58:21 2017 -0700 Clean up white space. Change-Id: If082be21933ea6e01ea2126d4aafa6c931d4674d Reviewed-on: https://code.wireshark.org/review/24064 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=f46d4d6e3b0c1802829785222e17e6f3ea081303 commit f46d4d6e3b0c1802829785222e17e6f3ea081303 Author: Guy Harris Date: Wed Oct 25 15:56:01 2017 -0700 Use a union for the IPv4/IPv6 address. That way, the compiler ensures proper alignment. In practice, the alignment was probably proper anyway, but this makes sure. Change-Id: I5ddc028c97d6961692a297cac17236206b61169d Reviewed-on: https://code.wireshark.org/review/24061 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=16309e41c8b61e20307af9de40ff9742bb19cc6d commit 16309e41c8b61e20307af9de40ff9742bb19cc6d Author: Jo??o Valverde Date: Wed Oct 25 23:08:19 2017 +0100 configure: Fix --with-libssh argument name mismatch Change-Id: I38a55f9354f400ebe7a9acdf28a52a0068d9f745 Reviewed-on: https://code.wireshark.org/review/24058 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=93fba33e95006e18d1e16e3e32cbfde3a2457a38 commit 93fba33e95006e18d1e16e3e32cbfde3a2457a38 Author: Pavel Strnad Date: Wed Oct 25 10:34:47 2017 +0200 asn2wrs.py: use 64 bits variant for constrained integers using MIN or MAX keywords Change-Id: Iffc7c81e9653e8c1cd938de8f4fc26c5912eceec Reviewed-on: https://code.wireshark.org/review/24049 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=eae216ef1db4b22e533231c8766cf4fad148eda6 commit eae216ef1db4b22e533231c8766cf4fad148eda6 Author: Jo??o Valverde Date: Wed Oct 25 00:29:14 2017 +0100 Remove replacement inet_pton/inet_ntop Should be available on every platform we support. Change-Id: Ib65d78e351d22d581b427e5e93fc8d5e5348b260 Reviewed-on: https://code.wireshark.org/review/24047 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4dc02b2fcfa97e953e1ffc2c1a13f35f4a132965 commit 4dc02b2fcfa97e953e1ffc2c1a13f35f4a132965 Author: Guy Harris Date: Wed Oct 25 12:58:55 2017 -0700 We're using inet_pton(), so we don't need to worry about non-dotted-quad addresses. inet_pton(), and thus ws_inet_pton(), won't accept hex or fewer-than-four-component IPv4 addresses, at least on Single UNIX Specification-compliant systems - the SUSv4 explicitly says The inet_pton() function does not accept other formats (such as the octal numbers, hexadecimal numbers, and fewer than four numbers that inet_addr() accepts). so we don't need to check for "inet_atons that accept strings such as - "130.230" as valid addresses". That also means that, "if there are any places where this needs to support the hex-address form for IPv4 addresses, or to support fewer than 4 components for a network address", those places were hosed even before we stopped using inet_aton(), so there are presumably no such places. (Itojun's comment was probably just an expression of general concern, rather than a note of a known problem.) Change-Id: Id16b6ebd3550dc3bf5a0fc283898a99b7abc163c Reviewed-on: https://code.wireshark.org/review/24057 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=14080744dba2c170b6bc718aef1c89e1e175eefe commit 14080744dba2c170b6bc718aef1c89e1e175eefe Author: Guy Harris Date: Wed Oct 25 12:51:33 2017 -0700 Get rid of a no-longer-needed variable. We don't need a temporary IPv4 address variable in get_host_ipaddr(), we can just use the pointer we've been handed. Change-Id: Id7cbd0c14b2eeb3efde5a556f3414bd635411908 Reviewed-on: https://code.wireshark.org/review/24056 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=6537c996a62ac0540fb21e4b0462119422dd6ad6 commit 6537c996a62ac0540fb21e4b0462119422dd6ad6 Author: Guy Harris Date: Wed Oct 25 12:36:02 2017 -0700 Clean up and expand comments. Note the dropping of support for hex IPv4 addresses and addresses with fewer than four components, and indicate that, if there are any places where that support is expected, we should change those places (i.e., don't just change get_host_ipaddr() and, if there aren't any such places, just leave everything as it is). It's not clear that get_host_ipaddr() is "Used more in the dfilter parser rather than in packet dissectors"; that may depend on whether you're counting number of calls executed from those places or the number of lines of code making those calls. Just drop the claim, which is absent in the comment for get_host_ipaddr6(). Also ask whether we're using get_host_ipaddr{6}() in any places where it should *only* support numeric addresses rather than names. Change-Id: Ib5d8730ca703339342f308081a68309479f842c5 Reviewed-on: https://code.wireshark.org/review/24055 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=90644c83725f979f82e7990792faaf6e847f74ea commit 90644c83725f979f82e7990792faaf6e847f74ea Author: Jo??o Valverde Date: Tue Oct 24 21:04:19 2017 +0100 Remove inet_aton() usage everywhere Including where it says not to in comments. Use IPv4 dotted-decimal notation. Change-Id: Iafe1f6fbd2bd5867c41642dc27411f47dff8ce6a Reviewed-on: https://code.wireshark.org/review/24044 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c5529dd7f1269e88b4c122fa3c755d5696b58a70 commit c5529dd7f1269e88b4c122fa3c755d5696b58a70 Author: Alexis La Goutte Date: Wed Oct 25 20:57:58 2017 +0200 debian: Update symbols Change-Id: I4360c3f819a3fc3254cecf862e5c084cb5a4162e Reviewed-on: https://code.wireshark.org/review/24051 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=749447fc803770759600e14e9fb42e31bafa73f7 commit 749447fc803770759600e14e9fb42e31bafa73f7 Author: Guy Harris Date: Wed Oct 25 12:06:39 2017 -0700 Use "not installed for development" for libgcrypt. This is similar phrasing to what I used for some other libraries; hopefully it will keep people from asking "Why am I getting this error? I installed libgcrypt" questions by making it clear that "installing libgcrypt" might not be enough. Also, don't give a package name, because the package might not be called "libgcrypt-devel" - it might be called "libgcrypt20-dev" of something such as that. Change-Id: I486a239e346955666d08cad3b1f8e3a961120e76 Reviewed-on: https://code.wireshark.org/review/24052 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=091607f8eb336ff51f875918574c12256382c49e commit 091607f8eb336ff51f875918574c12256382c49e Author: Ryan Mullen Date: Tue Oct 24 23:08:49 2017 -0400 rdm: Support NACK_REASON and fix a PD dissector - Introduce support for the NACK_REASON response type - Tweak the PD dissector for DMX_PERSONALITY_DESCRIPTION, which misinterpreted the "Personality Requested" field and used the wrong length for the "DMX512 Slots Required" field Change-Id: If5bc64f82e531e6cfb03a508c335b0468bf6e836 Reviewed-on: https://code.wireshark.org/review/24048 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=0e7d2542b0fdc12ef4e0c223d5fe3ecf2b5d669c commit 0e7d2542b0fdc12ef4e0c223d5fe3ecf2b5d669c Author: Michael Mann Date: Tue Oct 24 17:43:33 2017 -0400 Add 32x32 png file for UAT "clear list" icon Change-Id: Ifff401d9014d58c3848e1fcb2f09f09d4391e61e Reviewed-on: https://code.wireshark.org/review/24043 Petri-Dish: Michael Mann Reviewed-by: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7318d8337aa0f9466e08c8667b14fa9473b41a6b commit 7318d8337aa0f9466e08c8667b14fa9473b41a6b Author: Jo??o Valverde Date: Tue Oct 24 23:41:24 2017 +0100 Remove leftover #define. Change-Id: Ic18094a487a941a8c76c722afe8e22194b069993 Reviewed-on: https://code.wireshark.org/review/24046 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=e1ef8e5f7555a1608d0cddde6c824c5a897f6e58 commit e1ef8e5f7555a1608d0cddde6c824c5a897f6e58 Author: Jo??o Valverde Date: Mon Oct 23 19:00:27 2017 +0100 Test g_printf() thousands grouping flag at runtime This tests the runtime environment so avoid hard-coding it during the build. For now we avoid messing with locales for the test, unless it turns out to be necessary (ISO C printf behaviour with invalid conversion specifier is undefined). Change-Id: I341c2ab5e716973689cf9002f13435404a41369f Reviewed-on: https://code.wireshark.org/review/24038 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=08a490328387eafb7f9d20293a2a5e97e6cf4268 commit 08a490328387eafb7f9d20293a2a5e97e6cf4268 Author: Guy Harris Date: Tue Oct 24 12:03:19 2017 -0700 Fix registration of SIP atop SSL/TLS. See https://ask.wireshark.org/questions/64151/sip-tls-is-only-shown-as-tcp. Change-Id: Ife182136601007ff6a5713666d9fada5abcd00b9 Reviewed-on: https://code.wireshark.org/review/24041 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=15ce2db13afa087be8a0329e72411f7d1b2b77f6 commit 15ce2db13afa087be8a0329e72411f7d1b2b77f6 Author: Michael Mann Date: Sun Oct 22 11:35:12 2017 -0400 mqtt: Use proto_tree_add_bitmask Change-Id: I8e9cd64edcabf810e70b134ecce7a771babafebc Reviewed-on: https://code.wireshark.org/review/24017 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=14e687c1dd17e7a39a7cf3293e3397ac36117e49 commit 14e687c1dd17e7a39a7cf3293e3397ac36117e49 Author: Jo??o Valverde Date: Sun Oct 22 20:30:07 2017 +0100 Make plugin support a runtime property Keep the option to disable at compile-time but use AC_ARG_ENABLE instead. Change-Id: Ie8c3f5ba0db1eb6d9d4ffd742cd3aa049ead5007 Reviewed-on: https://code.wireshark.org/review/24026 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=12d63c428f973b1f7e04ad58d432d778e2035a9a commit 12d63c428f973b1f7e04ad58d432d778e2035a9a Author: Jo??o Valverde Date: Mon Oct 23 19:46:16 2017 +0100 configure: Remove ancient inet_pton test for brokenness Change-Id: Idac71883b6a1c6c78ae79e929f1c67a295ed9035 Reviewed-on: https://code.wireshark.org/review/24037 Reviewed-by: Guy Harris Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6014bfe6fc06786cd074bd66cda210b9aafa7d36 commit 6014bfe6fc06786cd074bd66cda210b9aafa7d36 Author: Eliot Lear Date: Mon Oct 23 14:44:12 2017 +0200 Get program to the right working directory. Otherwise patches breaks. Change-Id: Ief735dc949eaefa3515cc0a5936e0a2735cb0241 Reviewed-on: https://code.wireshark.org/review/24035 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=bc924b628365480f1b2dd5281b8657a3ad3d1eac commit bc924b628365480f1b2dd5281b8657a3ad3d1eac Author: Bruno Verstuyft Date: Mon Oct 23 10:35:53 2017 +0200 DOCSIS: fixed TLV name Change-Id: Ibfc8310e1a150fb2e04f7dad9a68d08e8d0364b7 Reviewed-on: https://code.wireshark.org/review/24032 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c7918da8a6b28fc515d273c16a9ffca2a4b9e119 commit c7918da8a6b28fc515d273c16a9ffca2a4b9e119 Author: Eldon Stegall Date: Tue Oct 17 14:55:52 2017 +0000 Improve http object export for URLs with long extensions This allows the export of objects with extensions that may be longer than the allowed file name of an export (due to underlying filesystem, etc). The extension detection mechanism previously preserved everything in the file name after the final ".", but in some cases (especially with long query strings) this would exceed the allowed maximum file length, and simply refuse to export the object. Now, if the length of the extension and duplicate number is longer than the allowable file length, the extension is ignored, and the entire string is truncated to allow an acceptable export filename. Bug: 14130 Change-Id: I6fa0281519d031c07a9ac621002ac328f34f54cc Reviewed-on: https://code.wireshark.org/review/23960 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b74af851471687e258fa7624a498981b77ebdba6 commit b74af851471687e258fa7624a498981b77ebdba6 Author: Alexis La Goutte Date: Sun Oct 22 18:35:49 2017 +0200 ssl-utils: Add export tls13_hkdf_expand_label for reuse on QUIC dissector Change-Id: Ic1d6b875e1e1944bb2aa6c7a85bfdd984c00948c Reviewed-on: https://code.wireshark.org/review/24018 Reviewed-by: Peter Wu Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6e3133c41ca760e9c3156f641236af54c7464c48 commit 6e3133c41ca760e9c3156f641236af54c7464c48 Author: Jo??o Valverde Date: Sun Oct 22 14:16:53 2017 +0100 AirPcap is Windows only, reflect that in about dialog Change-Id: Iecde2ada76a63da47e80cf0188945dab2a7e5b89 Reviewed-on: https://code.wireshark.org/review/24023 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=182d9deb08125f9c595bcb32dcb28f745989d615 commit 182d9deb08125f9c595bcb32dcb28f745989d615 Author: Michael Mann Date: Sat Oct 21 22:50:16 2017 -0400 Add "Apply as filter" button to Coloring Rules Dialog Add a button to apply currently selected color as the display filter. Bug: 14100 Change-Id: Ife3edeb577075f1fe30b649a5655ef5887684d8a Reviewed-on: https://code.wireshark.org/review/24012 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a16126fffbaa8ee854b32cc80f94d6233ee3ef4f commit a16126fffbaa8ee854b32cc80f94d6233ee3ef4f Author: Alexis La Goutte Date: Sun Oct 22 18:40:47 2017 +0200 QUIC: Add draft-07 value_string Change-Id: Icc4cfc4ce007eac29d9a502eae76527713e93e05 Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/24019 Reviewed-by: Peter Wu Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=de066346a649906e7105b18d9f7a5f823ace43e2 commit de066346a649906e7105b18d9f7a5f823ace43e2 Author: Stig Bj??rlykke Date: Sun Oct 22 21:28:05 2017 +0200 mqtt: Fix some mistakes from previous commit - PUBREL, SUBSCRIBE and UNSUBSCRIBE does use QoS for v3.1 - CONNACK is also different between v3.1 and v3.1.1 - DUP flag is not reserved, it's Retain which is reserved - Use proto_tree_add_item for reserved fields - Use uniform layout and fixed indent (2 spaces in this file) Change-Id: I26337ad63cd67d832db84993349fa3406e305b72 Reviewed-on: https://code.wireshark.org/review/24025 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=89fe6629b73cea803d6bd803cd9131a9f39d8ccd commit 89fe6629b73cea803d6bd803cd9131a9f39d8ccd Author: Flavio Santes Date: Sun Oct 15 06:18:38 2017 -0400 [RFC] dissector/mqtt: Fix handling of fixed header flags According to the MQTT v3.1 and v3.1.1 specifications, the fixed header flags (DUP, QoS and RETAIN) are only set by the PUBLISH message. The DUP flag is also set by the PUBREL, SUBSCRIBE and UNSUBSCRIBE messages but only when version 3.1 is used. Currently, the MQTT dissector shows the header flags for all the v3.1 and v3.1.1 messages. This patch fixes the issues mentioned above. To track the protocol version used during the connection handshake a conversation is used. For subsequent messages, the way the header flags are displayed is determined by this variable. Change-Id: Iad808f77a2c379f9786152c26d3aa86e24be1b16 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/23939 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=535ac5832dd39055328b8c211aacf77d654d5282 commit 535ac5832dd39055328b8c211aacf77d654d5282 Author: Jo??o Valverde Date: Sun Oct 22 19:07:29 2017 +0100 Fix make distcheck Change-Id: Ie6b49429a5a72a4ed7b76fa74b1a6f33b6811254 Reviewed-on: https://code.wireshark.org/review/24022 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=ce3ce9e70eb6a2b9400a56d592d75df23682a40b commit ce3ce9e70eb6a2b9400a56d592d75df23682a40b Author: Gerald Combs Date: Sun Oct 22 17:06:12 2017 +0000 [Automatic update for 2017-10-22] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I973703f2a82c96e47ec15512e223766404a6d3a1 Reviewed-on: https://code.wireshark.org/review/24021 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=b91089befc50b838853f1f2b7b0bdad51537aaf3 commit b91089befc50b838853f1f2b7b0bdad51537aaf3 Author: Eliot Lear Date: Sun Oct 22 11:35:33 2017 +0200 Add IANA arc and first entry (MUDURL) for lldp. PCAP file: https://github.com/the-tcpdump-group/tcpdump/blob/master/tests/lldp_mudurl.pcap Change-Id: If1f4946f8a8ade44dbab33a877bf7449f9ea2a6f Reviewed-on: https://code.wireshark.org/review/23982 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b913bcc13a9a6213902691a8d73bba1427ab407b commit b913bcc13a9a6213902691a8d73bba1427ab407b Author: Cal Turney Date: Sat Oct 7 22:06:12 2017 -0400 NFSv4: Fix for duplicate StateId hashes In WS v11.4.0 released In May, 2014, "tvb_get_string_enc()" was added to dissect_nfs4_stateid() which treats the numeric stateid as a string and converted it to UTF-8. Invalid UTF-8 chars were replaced with the "REPLACEMENT CHARACTER" which are actually three characters: 0xef, 0xbf, and 0xbd (0xefbfbd). A hash was made of the first 16 chars of the returned array although the string was often much larger due to 1 to 16 invalid chars. This has often caused duplicate hashes for different files and locks. That routine has been removed. In addition, the size of the hash has been reduced from 32 to 16 bits which affords a 99.9984% chance of unique hashes. Finally, hf_nfs4_seqid, used for the stateid hash seqid has been changed to hf_nfs4_seqid_stateid because in CLOSE requests the seqid has nothing to do with the stateid seqid. Change-Id: I3bf7caefc3341887a4c9137500dfeac0115af8cf Reviewed-on: https://code.wireshark.org/review/23966 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=aa04d2355effb1cf611831b0a260cf1aff199b9a commit aa04d2355effb1cf611831b0a260cf1aff199b9a Author: Jo??o Valverde Date: Sat Oct 14 20:11:24 2017 +0100 autotools: Build and install user guide Installs the WSUG to $docdir, unless the --disable-guides option is given to the configure script. This will open the Help->Contents menu action using the locally installed guide. It will also point to the correct version for this Wireshark release. The wireshark.org link only provides the guide for the master branch. Change-Id: I9dd539c737cb3777dc1351707b9e45a3a6764aaa Reviewed-on: https://code.wireshark.org/review/23906 Petri-Dish: Jo??o Valverde Reviewed-by: Jo??o Valverde Tested-by: Jo??o Valverde Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b0432442c607c7d71e40c55ffd0bf46f43ef3d1a commit b0432442c607c7d71e40c55ffd0bf46f43ef3d1a Author: Gerald Combs Date: Sun Oct 22 08:13:29 2017 +0000 [Automatic update for 2017-10-22] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I2bc1e987630e05d2942e9405ab45e4c2f7452263 Reviewed-on: https://code.wireshark.org/review/24013 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=61380f950428dc7166647e6b5973415b691e1b70 commit 61380f950428dc7166647e6b5973415b691e1b70 Author: Michael Mann Date: Tue Oct 17 13:57:04 2017 -0400 Add button in Qt UAT dialog/frame to remove all UAT entries at once. Change-Id: If5a172cd69beeb0b9a22eb7f6b9e7cb25f350b49 Reviewed-on: https://code.wireshark.org/review/23968 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4e3114d01dd2ddbf4044bcd5c91812d3bd3f7fbd commit 4e3114d01dd2ddbf4044bcd5c91812d3bd3f7fbd Author: Michael Mann Date: Sat Oct 21 10:22:43 2017 -0400 Eliminate #include from dissectors that don't need it. Correct include patch for packet-lldp.c Change-Id: I5e2a267943ccd39616ef323848104fdba23c8f38 Reviewed-on: https://code.wireshark.org/review/24009 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=85820a835426059b31479107ddfb660ff5067807 commit 85820a835426059b31479107ddfb660ff5067807 Author: Pascal Quantin Date: Sat Oct 21 13:25:06 2017 +0200 Diameter 3GPP: call XML dissector for Civic-Address AVP payload Bug: 14142 Change-Id: Iccf5c375087cabd08aa551af8e6586e18684252a Reviewed-on: https://code.wireshark.org/review/24008 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=0d9b8eaf088628255e64343462ac0e2e90c66c67 commit 0d9b8eaf088628255e64343462ac0e2e90c66c67 Author: Gerald Combs Date: Fri Oct 20 16:10:34 2017 -0700 Warn the developer if we're building with GTK+. Move The Slowest Migration In The History Of Ever a little further along. Change-Id: Ib8b49708e7036dd412a7ffc8660ded9f681374c0 Reviewed-on: https://code.wireshark.org/review/24006 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b289699ace2075c934f7009dea307156f9296071 commit b289699ace2075c934f7009dea307156f9296071 Author: Michael Mann Date: Sat Oct 21 00:00:46 2017 -0400 Remove oui_vals value_string and epan/oui.c oui.c is a very small subset of what comes from http://standards.ieee.org/regauth/oui/oui.txt, so use the "full" OUI list (and more) out of the manuf file and convert hf_ fields to just use BASE_OUI. Change-Id: Ic0c2ff618d8a6212f498e3b7475e0a7856c22b5b Reviewed-on: https://code.wireshark.org/review/24007 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0f868cfeb0260fc30f8fe0710312102dac6972fd commit 0f868cfeb0260fc30f8fe0710312102dac6972fd Author: Alexis La Goutte Date: Fri Oct 20 11:26:09 2017 +0000 nfapi: fix 'nfapi.p7_message_header.m_segment_sequence' exists multiple times with NOT compatible types: FT_UINT8 and FT_BOOLEAN Change-Id: I221315e6dc28835ce976caf167962847d536edc6 Reviewed-on: https://code.wireshark.org/review/24001 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0088d010edb1dc9704efa1ad11e7d0975b6878ba commit 0088d010edb1dc9704efa1ad11e7d0975b6878ba Author: Peter Wu Date: Fri Oct 20 03:43:03 2017 +0100 Qt: fix crash after loading SRT dialog TapParameterDialog::on_applyFilterButton_clicked first calls fillTree to populate the table and endRetapPackets to add the results to GUI. The table data must remain valid until closing the dialog since the user can still interact with the GUI. Change-Id: Ie3105be78d39c562af52f2b49081552063afcada Ping-Bug: 14141 Reviewed-on: https://code.wireshark.org/review/23994 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c23e3761a550ca5e44cb3878fa47d7c00f469424 commit c23e3761a550ca5e44cb3878fa47d7c00f469424 Author: Pascal Quantin Date: Fri Oct 20 10:51:04 2017 +0200 file_util.c: do not leak service handle Follow-up of gd64c30052 Change-Id: I620b3fb44fe3090120f2d29809961623e00d55a4 Reviewed-on: https://code.wireshark.org/review/23999 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=0a6c51e4a0319ca62fb41664da4eac7482844227 commit 0a6c51e4a0319ca62fb41664da4eac7482844227 Author: Jo??o Valverde Date: Sun Oct 15 11:00:38 2017 +0100 autotools: Improve SUBDIRS usage Change-Id: Ia40970c37f4b60f8b820c334c3c728a0ac33f228 Reviewed-on: https://code.wireshark.org/review/23996 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=e6e8b7b662419466a264201a6d08af2dc9a737e9 commit e6e8b7b662419466a264201a6d08af2dc9a737e9 Author: Jo??o Valverde Date: Wed Oct 18 23:37:49 2017 +0100 autotools: Sort out how we handle plugin.c Change-Id: Ie9570a63a1479021753807f76dd5e98fbbec7b86 Reviewed-on: https://code.wireshark.org/review/23995 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=d64c300522ffa830e061adeb81e75255b3f955ac commit d64c300522ffa830e061adeb81e75255b3f955ac Author: Pascal Quantin Date: Wed Oct 18 10:11:56 2017 +0200 Do not add Npcap path if npf.sys service is found Otherwise you can end with 2 Packet.dll (the one from WinPcap and the one from Npcap) being loaded at the same time, which can create incompatibilities. Bug: 14134 Change-Id: Ia06066fd54b60296e55dbfce6c6f2ddd99367479 Reviewed-on: https://code.wireshark.org/review/23969 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4273eced0c24442e5e713762e97cba5457b23284 commit 4273eced0c24442e5e713762e97cba5457b23284 Author: Peter Wu Date: Fri Oct 20 01:13:31 2017 +0100 cmake: fix Qt build with CMake 3.0.0 and 3.0.1 AUTOUIC fails to generate some ui_*.h files because of a bug that was fixed in CMake 3.0.2: https://cmake.org/Bug/view.php?id=14981 Change-Id: I964d991c7edefcea55ae43b0768a7fd3503f94a9 Fixes: v2.5.0rc0-1366-gdfa893b1cf ("cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warning") Reviewed-on: https://code.wireshark.org/review/23993 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=fd1d13567d07bb429f9209c4c11a97c7ba02dab8 commit fd1d13567d07bb429f9209c4c11a97c7ba02dab8 Author: Pascal Quantin Date: Thu Oct 19 21:30:25 2017 +0200 LCSAP: fix retrieval of XML dissector handle Bug: 14131 Change-Id: Ie77ade9d54f9d0a5fa0183cedc154e6595a489cf Reviewed-on: https://code.wireshark.org/review/23991 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ea1476c4f03845fa054cf590089ec33dd3999f5d commit ea1476c4f03845fa054cf590089ec33dd3999f5d Author: Guy Harris Date: Thu Oct 19 11:53:50 2017 -0700 Suggest using CMake rather than autotools. The configure script 1) can't find newer versions of Qt, thanks to the Qt developers not supplying any .pc files and 2) doesn't look for useful frameworks, so it's not the best way to build Wireshark on macOS any more. Discuss CMake instead. Change-Id: I28befffab010221e2e17e37f5beaf8b732974190 Reviewed-on: https://code.wireshark.org/review/23990 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7aa5630d1eeb4b25d2467b9eb12f52c56df7c96d commit 7aa5630d1eeb4b25d2467b9eb12f52c56df7c96d Author: Gerald Combs Date: Thu Oct 19 09:08:02 2017 -0700 TCP: Add a documentation note. Note that changes to tcp_analyze_sequence_number should be synced with docbook/wsug_src/WSUG_chapter_advanced.asciidoc#ChAdvTCPAnalysis. Change-Id: Iac72d2cf808d84c17fa5f12012675e0af1895cd1 Reviewed-on: https://code.wireshark.org/review/23989 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=c1807eec7800c7b6ab8f99a42b1edca741d5da0b commit c1807eec7800c7b6ab8f99a42b1edca741d5da0b Author: Gerald Combs Date: Thu Oct 19 08:24:58 2017 -0700 Add more notes about Asciidoctor. Change-Id: I7fd12b9189448a637d1bebac6687168f017d8d8d Reviewed-on: https://code.wireshark.org/review/23987 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=0870f8586a1aef45d668127d0f3628a70bd0623d commit 0870f8586a1aef45d668127d0f3628a70bd0623d Author: Michael Mann Date: Thu Oct 19 07:39:47 2017 -0400 Remove duplicate values in pfcp_pr_time_unit_vals ** (process:8955): WARNING **: Field 'Uplink Time Unit' (pfcp.ul_time_unit) has a conflicting entry in its value_string: 3 is at indices 3 (Day) and 4 (Week)) ** (process:8955): WARNING **: Field 'Downlink Time Unit' (pfcp.dl_time_unit) has a conflicting entry in its value_string: 3 is at indices 3 (Day) and 4 (Week)) Change-Id: I870af4a53721e0ffe0f9f778c8287e090f2b2929 Reviewed-on: https://code.wireshark.org/review/23985 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2323b20779d1af74057b3e3a52b3f42b39ef91c4 commit 2323b20779d1af74057b3e3a52b3f42b39ef91c4 Author: Michael Mann Date: Thu Oct 19 07:41:20 2017 -0400 Correct duplicate values for csi_rs_class_vals ** (process:8955): WARNING **: Field 'Class' (nfapi.csi.rs.class) has a conflicting entry in its value_string: 1 is at indices 1 (Class A) and 2 (Class B)) Change-Id: I6063fd5fe0094efe776a3a04556c633a4e495a9a Reviewed-on: https://code.wireshark.org/review/23986 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=15c4382f1706512fc5f4695b7d30ec4a195f2ced commit 15c4382f1706512fc5f4695b7d30ec4a195f2ced Author: Pascal Quantin Date: Thu Oct 19 10:35:02 2017 +0200 FP Mux: disable heuristic dissector by default Without any specific pattern, it is too weak and catch a lot of unrelated UDP packets. Change-Id: Iacac5ae65de59da1d46a06184517834edd91eb18 Reviewed-on: https://code.wireshark.org/review/23984 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d291d1a4239ed744c65b64d62aebaae88ceed552 commit d291d1a4239ed744c65b64d62aebaae88ceed552 Author: Graham Shanks Date: Thu Oct 19 00:03:27 2017 +0100 Update enumerations for SISO-REF-010 v22 Change-Id: Icb326dac7cfe0478df3d892df279ad0f241c7ba6 Reviewed-on: https://code.wireshark.org/review/23981 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5fd13dac123f1a31ad2aad7e1c7338ba25527b11 commit 5fd13dac123f1a31ad2aad7e1c7338ba25527b11 Author: Nikolai Ipatyev Date: Wed Oct 18 23:07:16 2017 +0300 fpmux: Fix error string and comment Change-Id: If4620a43d706f7067a018eb964e4db3733d65210 Reviewed-on: https://code.wireshark.org/review/23980 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=bc880f6c3e71c1e1ce4eb19f6cfa404ae4e6cda5 commit bc880f6c3e71c1e1ce4eb19f6cfa404ae4e6cda5 Author: Pascal Quantin Date: Wed Oct 18 21:23:42 2017 +0200 FP Mux: reject empty tvb Bug: 14140 Change-Id: I43c635e97f33c190e2a4a7f42e58f4274bd03f2b Reviewed-on: https://code.wireshark.org/review/23978 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=288973ff7485d910fbef60ed2875edfd387f1a4f commit 288973ff7485d910fbef60ed2875edfd387f1a4f Author: Pascal Quantin Date: Wed Oct 18 21:18:00 2017 +0200 FP Mux: create conversation if it does not exist Change-Id: Ib26145c30f6f3ba20e26d52f1e4b90825029809d Ping-Bug: 14140 Reviewed-on: https://code.wireshark.org/review/23977 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b580bbfdd275e6151e2d67d8a03da6c9dae0b36b commit b580bbfdd275e6151e2d67d8a03da6c9dae0b36b Author: Pascal Quantin Date: Wed Oct 18 21:15:15 2017 +0200 FP Mux: do not register UDP port 44955 by default It is not registered by IANA Change-Id: Iff462ee0a2366ae72681b34e4e7e107c8c479822 Reviewed-on: https://code.wireshark.org/review/23976 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e5755a62130246e6f5e5163f766579084a58f2dc commit e5755a62130246e6f5e5163f766579084a58f2dc Author: Pascal Quantin Date: Wed Oct 18 21:14:38 2017 +0200 FP Mux: fix a typo in preferences Change-Id: I19ba1bb223a3356b4048448f0bb908f23e7364c0 Reviewed-on: https://code.wireshark.org/review/23975 Reviewed-by: Nikolai Ipatyev Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d8fdc135c4a075dde57d18e696216b53e934fba1 commit d8fdc135c4a075dde57d18e696216b53e934fba1 Author: Jo??o Valverde Date: Wed Oct 18 14:52:18 2017 +0100 Update packet-kerberos.c Change-Id: I86387e4f8ebf7f7cd2f3b9e01e9b4cfe91a7357e Reviewed-on: https://code.wireshark.org/review/23974 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2196fcb0088040f5ad48797fb234c41eb561b5af commit 2196fcb0088040f5ad48797fb234c41eb561b5af Author: Jo??o Valverde Date: Tue Oct 17 23:17:15 2017 +0100 Refresh wsutil/Makefile.am Change-Id: I6a70a2dc45257826c930f57a59cdd9bf5b4c3c73 Reviewed-on: https://code.wireshark.org/review/23973 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=45fbb287b42c47d9fc84c1abc9158a7d24333c79 commit 45fbb287b42c47d9fc84c1abc9158a7d24333c79 Author: Jo??o Valverde Date: Thu Oct 5 17:37:27 2017 +0100 autotools: Remove abi-compliance-checker code It's been broken for over a year, needs to be modernized and as implemented it's a maintenance nightmare. Get rid of it. Ping-Bug: 13036 Change-Id: I34a6e4c28b6d3b96dd6550dd21e9cbeaf050d58f Reviewed-on: https://code.wireshark.org/review/23967 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c703ba52adc02c83245a5d428e6943d4a4a0f995 commit c703ba52adc02c83245a5d428e6943d4a4a0f995 Author: Bruno Verstuyft Date: Wed Oct 18 11:54:46 2017 +0200 DOCSIS: Fixed bug where OCD TLVs are nested Change-Id: I3b6a7c6dabfe017eb6c223ab2491e0a3cda8c56c Reviewed-on: https://code.wireshark.org/review/23970 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2575a2e9a8928025a28d6873094c22c867ad5ab5 commit 2575a2e9a8928025a28d6873094c22c867ad5ab5 Author: Jo??o Valverde Date: Wed Oct 18 11:54:15 2017 +0100 autotools: Sort out how we handle register.c register.c is a built source. It should not be included in the distribution and should be removed with the distclean target. Remove XXX comment suggesting adding the cache to the distribution; let's not do that. Change-Id: I20f9467a93e2b5ad3ee56a5fa83381095b1d28c6 Reviewed-on: https://code.wireshark.org/review/23971 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=dfa893b1cfd8491a3563ad2c29a0dfaf44d960cf commit dfa893b1cfd8491a3563ad2c29a0dfaf44d960cf Author: Peter Wu Date: Sat Oct 14 23:40:30 2017 +0100 cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warning CMake 3.10 adds CMP0071 which results in warnings about applying AUTOMOC and AUTOUIC on generated files. It somehow tries to do this for files generated by QT5_ADD_RESOURCES and QT5_WRAP_UI. As a workaround, just convert from the legacy macros to the new method. Autogenerated ui_*.h and moc_*.h will now also be shown in the "External Dependencies" tab in Visual Studio Change-Id: I36df2212bbf0f938fcd4560000031b6137db93ca Reviewed-on: https://code.wireshark.org/review/23917 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=b85b946a94e0c27ef22084bfc390798c8c205057 commit b85b946a94e0c27ef22084bfc390798c8c205057 Author: Nikolai Ipatyev Date: Fri Oct 6 15:01:43 2017 +0300 Add FP-Mux dissector Change-Id: I58a9a0cf0364c8ce5f173ed28c054fd05738f690 Reviewed-on: https://code.wireshark.org/review/23868 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5a85f5a40b265a5bd9d4a015ccf1edcee44914af commit 5a85f5a40b265a5bd9d4a015ccf1edcee44914af Author: Aurelien Aptel Date: Tue Oct 17 16:31:00 2017 +0200 SMB2: accept and save empty filenames on CREATE requests [MS-SMB2] 2.2.13 CREATE Request, NameOffset: > A zero length file name indicates a request to open the root of the share. This also ends up enabling the parsing of missing fields (InputBufferLength, AdditionalInformation, Flags) in QUERY_INFO requests, which required a non-NULL saved->extra_info. Change-Id: I9af3933cc6bb93247bad23c7dd82a52787595f69 Signed-off-by: Aurelien Aptel Reviewed-on: https://code.wireshark.org/review/23959 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=bbb13097417ce268cfa25a920ed85b59515f283e commit bbb13097417ce268cfa25a920ed85b59515f283e Author: Bruno Verstuyft Date: Tue Oct 17 10:18:00 2017 +0200 Added default for every switch statement Change-Id: Ie74dec4d854f65835a4e7e68dac609290a84d791 Reviewed-on: https://code.wireshark.org/review/23957 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1ac9db4ca67b47da79d55e0cf309f1a40ca084f5 commit 1ac9db4ca67b47da79d55e0cf309f1a40ca084f5 Author: Uli Heilmeier Date: Tue Oct 17 21:05:07 2017 +0200 Protobuf: Fix format error Fixes error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'guint64' Change-Id: I431ab2e1920b7856ff686bd79bc881dee494706f Reviewed-on: https://code.wireshark.org/review/23965 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=070e561ed99aca1b5dcc4f47f246f3a761876422 commit 070e561ed99aca1b5dcc4f47f246f3a761876422 Author: Jo??o Valverde Date: Tue Oct 17 08:54:07 2017 +0100 autotools: Smaller cleanups ps.c is already correctly cleaned in epan/Makefile.am. make distclean also works well with tarballs so I think the other comment can also be removed. ldconfig may be needed for tshark. The installation step seems to do all the right things so just drop the rather verbose description of the XDG Base Directory Spec. Add the MKDIR_P and INSTALL variables for consistency and to address some of the portability concerns raised in the comment (INSTALL usage still needs to follow a standard form common for portable automake). Remove redundant plugin_ldadd else clause. Change-Id: Ic2cb04556f28622a8979b057e0abbe64256ed3c9 Reviewed-on: https://code.wireshark.org/review/23964 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=96d6267e2d18a04decd7fe6998d20b94ea5fb56d commit 96d6267e2d18a04decd7fe6998d20b94ea5fb56d Author: Martin Boye Petersen Date: Tue Oct 10 23:02:29 2017 +0200 ZCL SE Octet Strings: Dissect zcl se octet strings as length and data Implemented a function to dissect zcl octet strings in a similar way as attributes that have a data type of zcl octet string. Currently the function is used for event data (publish event and publish event log), as well as top up code (consumer top up and publish top up log). Bug: 14138 Change-Id: Idae6240312bedeaa12f10777e1009b110d5f834d Reviewed-on: https://code.wireshark.org/review/23881 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7cfbd2b9ba356aa7a0de2eb2cf06ae37fd6ae55e commit 7cfbd2b9ba356aa7a0de2eb2cf06ae37fd6ae55e Author: Guy Harris Date: Tue Oct 17 12:16:17 2017 -0700 Suggest CMake if Qt not found on Darwin; say "not installed for development". Hopefully this will allow more people to figure out how to compile Wireshark without 1) e-mailing wireshark-dev, 2) asking in ask.wireshark.com, or 3) filing a bug, if the underlying problem is that 1) they didn't install the appropriate xyzzy-dev package for something Wireshark uses or 2) they're trying to use autotools on macOS and they've installed a recent, and not-very-pkg-config-friendly, version of Qt. Change-Id: I69236558f207ed0bf81d2acdc0230630f6069dec Reviewed-on: https://code.wireshark.org/review/23963 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=55b0c251a0379a5a0a0d713c48717019acc965c6 commit 55b0c251a0379a5a0a0d713c48717019acc965c6 Author: Jo??o Valverde Date: Sun Oct 15 12:16:46 2017 +0100 autotools: remove macOS Frameworks support This treats macOS/OSX like any other Unix-like build target (Darwin), thus removing autotools support for macOS-specific build options. Anyone needing that is advised to use the fully-supported-on-macOS CMake build. Change-Id: I88e2fa7a8eea42241efcf84223ac2362d38b1e12 Reviewed-on: https://code.wireshark.org/review/23951 Petri-Dish: Jo??o Valverde Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=1d238ec636ff051635a7ed194df5c49752788d69 commit 1d238ec636ff051635a7ed194df5c49752788d69 Author: Jo??o Valverde Date: Tue Sep 26 22:54:24 2017 +0100 autotools: Remove setuid-root.pl It seems to be some sort of development helper, and since CMake doesn't use it presumably it is not useful anymore. Change-Id: I23e4ab24199f21310ebd09064c3ae53e48673e4d Reviewed-on: https://code.wireshark.org/review/23945 Petri-Dish: Gerald Combs Petri-Dish: Jo??o Valverde Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=ca7f204576d43e36275dad02cbf6e414447df03d commit ca7f204576d43e36275dad02cbf6e414447df03d Author: Adam Wujek Date: Mon Oct 16 17:30:54 2017 +0200 dissector/ptp: fix typo - should be ptp.as.sig.tlv.flags Change-Id: I31be23516d7fb169daa827b505bcde04426e84dc Signed-off-by: Adam Wujek Reviewed-on: https://code.wireshark.org/review/23961 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f6915bef29bd3a2f452ace0a3b3f47255fd041b6 commit f6915bef29bd3a2f452ace0a3b3f47255fd041b6 Author: Aurelien Aptel Date: Tue Oct 17 16:27:26 2017 +0200 SMB2: rename QUERY_INFO buffer input fields and parse Reserved field Since the packet has an output and input buffer, having a field just called "size" or "offset" was confusing. Change-Id: Iadb45fa50e6ea6ffaa7c3b041704837641f64ab6 Signed-off-by: Aurelien Aptel Reviewed-on: https://code.wireshark.org/review/23958 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a8a0d5ff98e008a11ea9851f4bb09bd3663e248b commit a8a0d5ff98e008a11ea9851f4bb09bd3663e248b Author: Jo??o Valverde Date: Sun Oct 8 17:54:50 2017 +0100 autotools: Fix bogus checkAPI targets Change-Id: Ifc8884fc0f0e4548db79a68e3fbc35c7e5fb9be9 Reviewed-on: https://code.wireshark.org/review/23947 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=6f9630561f0a0ae2842d90043b4ccc595ef06f3e commit 6f9630561f0a0ae2842d90043b4ccc595ef06f3e Author: AndersBroman Date: Mon Oct 16 17:53:13 2017 +0200 [Bluetooth] Prepare for adding a BT Mesh dissector. Change-Id: I79140a15c93e7bfada5036fd3fbb1bb94d99a655 Reviewed-on: https://code.wireshark.org/review/23940 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f19a2c0b8c000d5d7ea6fd9d48cbad606f8fdfb6 commit f19a2c0b8c000d5d7ea6fd9d48cbad606f8fdfb6 Author: Peter Wu Date: Tue Oct 17 01:40:14 2017 +0100 CMake: increase minimum required version to 2.8.11 Due to the use of target_include_directories (when sshdump or ciscodump are enabled), the minimum required version is 2.8.11. The supported OS versions do not change, but Debian Wheezy users must enable backports. Change-Id: I883c81e5e81425ca1869f442686faf1e66a638f3 Reviewed-on: https://code.wireshark.org/review/23955 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a3ba3ba94337007a458e2d4c40f3a36ad4b0e9c1 commit a3ba3ba94337007a458e2d4c40f3a36ad4b0e9c1 Author: Peter Wu Date: Tue Oct 17 03:34:35 2017 +0100 CMake: fix Qt build with CMake 2.8.12 and before The Qt5Widgets_EXECUTABLE_COMPILE_FLAGS option is only needed for CMake before 2.8.12 and before as documented by Qt, so this ugly piece can be restricted to older CMake versions. That also helps avoiding exposing the Qt 5.5.0 in Windows since that requires a much newer CMake version. For those older versions, use COMPILE_FLAGS such that -fPIC is added after -fPIE (the latter is enabled by CMAKE_POSITION_INDEPENDENT_CODE). Tested with CMake 2.8.11, 2.8.12.2, 3.0.2 and 3.9.4 using Qt 5.9.2 and GCC 7.2.0. Change-Id: I4962f7f5a087ee5b8c79905dd3b2cce17c731bdf Fixes: v2.1.0rc0-566-gd66d379ac8 ("Try retroactively applying the Qt folks' fix for QTBUG-47942.") Reviewed-on: https://code.wireshark.org/review/23954 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=731434cbca7404d5e9f9ecd1cc6a32e6635fd684 commit 731434cbca7404d5e9f9ecd1cc6a32e6635fd684 Author: Tigran Mkrtchyan Date: Tue Sep 26 15:11:41 2017 +0200 nfs: fix nfs dissector to show correct mirror and data server counts nfs dissector wrongly have used proto_tree_add_item to display a counter, by assuming that last argument is a value. Replace proto_tree_add_item with proto_tree_add_uint or proto_tree_add_subtree_format when a loop counter must be displayed. Update tree item size calculation. Change-Id: I4137e42673fa33cae61494effe1195206fbf7f28 Signed-off-by: Tigran Mkrtchyan Reviewed-on: https://code.wireshark.org/review/23748 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=560945336c8ad46eadde6439955abd67cb52e4e5 commit 560945336c8ad46eadde6439955abd67cb52e4e5 Author: Michael Mann Date: Mon Oct 16 21:44:21 2017 -0400 Bugfix Decode As dissector table selection. Need to use UI name to select between different tables. Change-Id: I2f25435e6ac1a2f1a15e651cd3ef1bbc9e860d89 Reviewed-on: https://code.wireshark.org/review/23952 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3d78077f7a3e72722407649768f1b677b4e63180 commit 3d78077f7a3e72722407649768f1b677b4e63180 Author: Peter Wu Date: Tue Oct 17 01:24:44 2017 +0100 CMake: fix build regression with CMake 3.0 This kind of generator expressions do not seem to work in CMake 3.0. It works fine in CMake 3.1.0 and later versions. Change-Id: I262566a5ea831ae0fbe4b6a3249b59401f9d3b15 Fixes: v2.5.0rc0-1334-gd3f636ece0 ("cmake: fix CMP0026 deprecation warning in CMake 3.9") Reviewed-on: https://code.wireshark.org/review/23949 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=b6ab30127583d38dcf0d49548e842c410ae2c69a commit b6ab30127583d38dcf0d49548e842c410ae2c69a Author: Jo??o Valverde Date: Tue Oct 17 03:00:04 2017 +0100 Remove GTK ige mac integration remnant from configure.ac Follow-up to 356d6b8db04bfc15a1d0a5fabbc79aad0e81d592. Change-Id: Ibfe2e890eb2e41b962c5a045a8d84c5431c0f336 Reviewed-on: https://code.wireshark.org/review/23953 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=b5505fd4512456f85188a81e9b6478ecce65504b commit b5505fd4512456f85188a81e9b6478ecce65504b Author: Peter Wu Date: Tue Oct 17 00:23:28 2017 +0100 ssl: regression fix for decryption with renegotiation A renegotiated session with decrypted records has !maybe_encrypted which means that the plaintext buffer is passed to dissect_ssl3_handshake. Do not assume that this plaintext buffer might be encrypted, it is definitely not the case. Change-Id: I2ce9a5305e5cbc24b5c7e93077f7e796bf8cb406 Fixes: v2.5.0rc0-1314-g9d189c7e20 ("ssl: assume everything after CCS is encrypted") Ping-Bug: 14117 Reviewed-on: https://code.wireshark.org/review/23948 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=46f4664b29a685a43dd5dd4c18b60e8bc1a5c34f commit 46f4664b29a685a43dd5dd4c18b60e8bc1a5c34f Author: Jo??o Valverde Date: Sun Oct 8 17:33:16 2017 +0100 checkAPI: error out on empty filelist This will help detect some bogus checkapi runs in the future. Change-Id: I43345e3a0a5471e9655f34e36ccf1562d6526758 Reviewed-on: https://code.wireshark.org/review/23946 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9cfb746e65c42fafb1a94009fcf5d8e2bdf7c00d commit 9cfb746e65c42fafb1a94009fcf5d8e2bdf7c00d Author: Alexis La Goutte Date: Mon Oct 16 20:51:46 2017 +0200 nfapi: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Value stored to 'offset' is never read Change-Id: Ia7f651edec36a75c60816a3803e53dc86d749262 Reviewed-on: https://code.wireshark.org/review/23942 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4acce81d127d56bdf62c2c7e6f321c2a458643e1 commit 4acce81d127d56bdf62c2c7e6f321c2a458643e1 Author: Alexis La Goutte Date: Mon Oct 16 20:50:38 2017 +0200 nfapi: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Value stored to 'item' is never read Change-Id: I964c06d1a3896e9e5c52dfcb2f17478f15350910 Reviewed-on: https://code.wireshark.org/review/23941 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ba92b90f8b9a1f3331ab10c2c49883ac32f577c9 commit ba92b90f8b9a1f3331ab10c2c49883ac32f577c9 Author: Stig Bj??rlykke Date: Mon Oct 16 20:51:50 2017 +0200 lorawan: Fix Join Request and Join Accept Use correct start offset for Join Request and Join Accept. Always show the MAC Header fields (and add the RFU). Add subtree for Join Request and Join Accept. Register the dissector to be able to "Decode As" and calling the dissector from Lua. Change-Id: I644530f2ae36f5a9d2ea89e4446995a5caa4eea4 Reviewed-on: https://code.wireshark.org/review/23944 Petri-Dish: Stig Bj??rlykke Reviewed-by: Erik de Jong Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=356d6b8db04bfc15a1d0a5fabbc79aad0e81d592 commit 356d6b8db04bfc15a1d0a5fabbc79aad0e81d592 Author: Jo??o Valverde Date: Sun Oct 15 19:58:55 2017 +0100 GTK: Remove OSX integration library support Only Wireshark Qt is officially supported on macOS. Change-Id: Id0e3429891173d4b91e99061bcf11df2e38bc0bf Reviewed-on: https://code.wireshark.org/review/23931 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=0a3cf5d5cf09c17afd06c64172780b4a02acdb62 commit 0a3cf5d5cf09c17afd06c64172780b4a02acdb62 Author: Alexis La Goutte Date: Mon Oct 16 20:56:11 2017 +0200 protobuf: no previous prototype for ???sint64_decode/sint32_decode??? [-Wmissing-prototypes] Change-Id: I85be2eb645ab00d711f525d711ebf90f200595cc Reviewed-on: https://code.wireshark.org/review/23943 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=dbbaa41362647569c0087c212e908c2ac570cbb7 commit dbbaa41362647569c0087c212e908c2ac570cbb7 Author: Jo??o Valverde Date: Sun Oct 15 12:16:46 2017 +0100 autotools: remove some macOS specific build options This treats macOS/OSX like any other Unix-like build target, thus removing autotools support for macOS-specific build options. Anyone needing that is advised to use the fully-supported-on-macOS CMake build. Change-Id: I631464a90e16e3db89538801c741657a0a4a7451 Reviewed-on: https://code.wireshark.org/review/23911 Reviewed-by: Gerald Combs Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=0d6c5a79eb75e10f1d13b160c18a32c0bf57a2d7 commit 0d6c5a79eb75e10f1d13b160c18a32c0bf57a2d7 Author: Flavio Santes Date: Sun Oct 15 05:15:13 2017 -0400 dissector/mqtt: Fix some inline comments There are some issues with the inline comments. Rephrase those comments. Furthermore, use the MQTT v3.1 and v3.1.1 specification language to fix some inline comments. Change-Id: Ia3864e1b66ef1eb4bbd8cb90aed674c7d9c4b7be Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/23937 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1a8143172c973fb74fa7b329a8b698cbb42ef865 commit 1a8143172c973fb74fa7b329a8b698cbb42ef865 Author: Flavio Santes Date: Mon Oct 16 01:11:48 2017 -0400 dissector/mqtt: Add the protocol version string Add the protocol version string: - 3 maps to MQTT v3.1 - 4 maps to MQTT v3.1.1 Change-Id: I8cf1ba0c1bcabd5718467946b33082e4eb5a37ed Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/23938 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=5967621d19204947021932ea86f1e55fbe810124 commit 5967621d19204947021932ea86f1e55fbe810124 Author: Flavio Santes Date: Sun Oct 15 02:33:56 2017 -0400 dissector/mqtt: Add the MQTT protocol description The packet-PROTOABBREV.c template recommends to provide a short description of the protocol below the license header. Currently, this information is not present in the packet-mqtt.c dissector. This patch adds the protocol description taken from the official specification. Links to the v3.1 and v3.1.1 specifications are also provided by this patch. Change-Id: I9bb85aa3b78c8804c923f77c163904a7949f6899 Signed-off-by: Flavio Santes Reviewed-on: https://code.wireshark.org/review/23936 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=f7054dcf0569756ad4f0f1fe32d785b91c4c05a4 commit f7054dcf0569756ad4f0f1fe32d785b91c4c05a4 Author: Alexis La Goutte Date: Mon Oct 16 07:12:52 2017 +0200 RSVP: fix some typo Bug: 13977 Change-Id: I1caa721fe9e5c27354fbf6c07ebd2fa3c0c0d91a Reviewed-on: https://code.wireshark.org/review/23935 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d3f636ece0ab60e2b8edc8648fa05e83338b60c6 commit d3f636ece0ab60e2b8edc8648fa05e83338b60c6 Author: Peter Wu Date: Sat Oct 14 20:13:52 2017 +0100 cmake: fix CMP0026 deprecation warning in CMake 3.9 Since CMake 3.9, all policies before CMP0036 emit a warning. Fix the warning by not relying on the old behavior (existence of the LOCATION property). Tested with Ninja, the cmake output, rules.ninja and build.ninja output is identical (minus the deprecation warning). Change-Id: I058699380b01a9c02d9b98fd485ce6ded427abe3 Reviewed-on: https://code.wireshark.org/review/23915 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=282b59a853f95c7bf463b617f8d40949b8f8b3ef commit 282b59a853f95c7bf463b617f8d40949b8f8b3ef Author: Mikael Kanstrup Date: Wed Aug 16 11:20:19 2017 +0200 [RFC]androiddump: Support extcap-dlts option According to README.extcap documentation all extcap tools must support the --extcap-dlts option. For performance reasons support for this option was removed by commit: 9328eb6 androiddump: Register interfaces when list interfaces A side effect of not implementing the option is that dumpcap is then also called to try to retrieve interface capabilities for all androiddump interfaces. As extcap interfaces are not local network interfaces errors like these are logged whenever the interface list is refreshed: Capture Dbg sync_if_capabilities_open Capture Info sync_pipe_run_command() starts Capture Dbg argv[0]: /usr/local/bin/wireshark/dumpcap Capture Dbg argv[1]: -i Capture Dbg argv[2]: android-tcpdump-wlan0... Capture Dbg argv[3]: -L Capture Dbg argv[4]: -Z Capture Dbg argv[5]: none Capture Dbg sync_pipe_open_command Capture Dbg read 25 ok indicator: E len: 333 msg: E Capture Dbg sync_pipe_wait_for_child: wait till child closed Capture Dbg sync_pipe_wait_for_child: capture child closed after 0.000s Capture Info sync_pipe_run_command() ends, taking 0.012s, result=-1 Capture Msg Capture Interface Capabilities failed. Error -1, The capabilities of the capture device "android-tcpdump-wlan0..." could not be obtained (android-tcpdump-wlan0...: SIOCETHTOOL(ETHTOOL_GET_TS_INFO) ioctl failed: No such device). Please check to make sure you have sufficient permissions, and that you have the proper interface or pipe specified. () To avoid error prints and to fulfil the documented equirements for extcap tools register a fake interface with what would be the properties of such an interface. Change-Id: If174adbb64c66132be4225f854bbf9f66d2f5ed1 Reviewed-on: https://code.wireshark.org/review/23093 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2cb717ec78e3479943dfe235e0c29c085a19ebfc commit 2cb717ec78e3479943dfe235e0c29c085a19ebfc Author: Peter Wu Date: Fri Oct 13 22:08:21 2017 +0100 cmake: remove and reorder unused cmake policies Current minimum CMake version has everything up to CMP0017 enabled by default, remove older policies. CMP0011 had not effect, our link_directories are already absolute paths. Change-Id: I3af08ca75700de4a860fb4afd664824031e2c5f5 Reviewed-on: https://code.wireshark.org/review/23914 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1dd0111f5e2426390d36626f07525470d8b9a9d9 commit 1dd0111f5e2426390d36626f07525470d8b9a9d9 Author: Simon Long Date: Thu May 4 11:01:20 2017 +0100 Initial submission of the nfapi dissector Bug: 13726 Change-Id: I630d73c4c90b6fe6019a7ff6a38f9a3b4657eac3 Reviewed-on: https://code.wireshark.org/review/21493 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=21c030ca752cdc9eaf3c5da4a0ade533f24cf1c2 commit 21c030ca752cdc9eaf3c5da4a0ade533f24cf1c2 Author: Jo??o Valverde Date: Mon Oct 16 00:34:48 2017 +0100 packaging: Fix RPM spec file Change-Id: Ib05cfeb9ef553ebd69e388e6ba00ddf751deb686 Reviewed-on: https://code.wireshark.org/review/23934 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=55e050383082907c3054f65063f7ba77f609ab2b commit 55e050383082907c3054f65063f7ba77f609ab2b Author: Jo??o Valverde Date: Sat Oct 14 14:54:10 2017 +0100 autotools: refresh rpm-package target There's only so much we can/should do here, so dispense with the _topdir test. Change-Id: Ibf1170ea2cbb7c536df901db42d67da668fd64b2 Reviewed-on: https://code.wireshark.org/review/23912 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=cb89fdd1f664d68dcf3ed5251a4d3d43fe9504e4 commit cb89fdd1f664d68dcf3ed5251a4d3d43fe9504e4 Author: Michael Mann Date: Mon Oct 9 15:17:32 2017 -0400 Add support for BASE_OUI Modeled after BASE_PT_XXX, this will format a FT_UINT24 to look a OUI, in the form of: XX:XX:XX (Manufacturer Name) for display. For display filtering, it will treat the value as hexadecimal. It requires that FT_UINT24 be the field type. Change-Id: I8716ae4dfcd4e854764a2425e2ff13c50f571d52 Reviewed-on: https://code.wireshark.org/review/23869 Reviewed-by: Richard Sharpe Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2663881c378913d5c9cd123c469e1bb29a5e39be commit 2663881c378913d5c9cd123c469e1bb29a5e39be Author: Darien Spencer Date: Sun Oct 15 21:57:06 2017 +0300 rlc: Fix bug in 'RLC over UDP' dissector Reassembly of AM/UM packets doesn't work when the URNTI tag is missing and the default value of 0 is kept. This patch makes the default value 1 for those cases. Bug: 14129 Change-Id: Id13121b5de63da4318214871b8963ceef5d28cf0 Reviewed-on: https://code.wireshark.org/review/23930 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=6aba76666da060f12b379cf8786686e545007f2a commit 6aba76666da060f12b379cf8786686e545007f2a Author: Darien Spencer Date: Sat Oct 14 20:22:29 2017 +0300 rrc: Dissect algorithm capabilities asn2wrs created fields for several BITSTRING bits but does not actually uses them. This changeset calls them for the umts ciphering/integrity algorithms and gsm algorithms Change-Id: I88ddc2aec6805a77fcb3f3d547efda4d513ec919 Reviewed-on: https://code.wireshark.org/review/23899 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=d0a4a614f9116d97cdb202607135e7f1b3b8e3cd commit d0a4a614f9116d97cdb202607135e7f1b3b8e3cd Author: Jo??o Valverde Date: Sat Oct 14 11:55:29 2017 +0100 plugins: Remove COPYING and NEWS We don't need to be this strict for bundled plugins about following the GNU Coding Standards. Change-Id: I18ed1b81d428eea15ea387102823f588287daf81 Reviewed-on: https://code.wireshark.org/review/23918 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=52bcdda04ec658a307575460930c71777e7cf4df commit 52bcdda04ec658a307575460930c71777e7cf4df Author: Brenton Rothchild Date: Fri Oct 6 11:32:22 2017 -0500 ZigBee ZCL: Add additional On/Off cluster commands Adds support for additionally defined On/Off cluster commands and attributes. Bug: 14109 Change-Id: I148722a5f36800d8778c721a6c60cab17a030b0c Reviewed-on: https://code.wireshark.org/review/23852 Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9764cd0a830e87c8acf13b4d494ea7fe4df72f85 commit 9764cd0a830e87c8acf13b4d494ea7fe4df72f85 Author: Jo??o Valverde Date: Sun Oct 15 14:35:06 2017 +0100 autotools: make maintainer-clean should allow rerunning 'configure' Change-Id: Iedae94ffefe27b13b1967d69cacb757b5aa4576d Reviewed-on: https://code.wireshark.org/review/23928 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f89b8ccff4d2172a8c244d46d1c559018b5ce917 commit f89b8ccff4d2172a8c244d46d1c559018b5ce917 Author: Alexis La Goutte Date: Sun Oct 15 10:53:54 2017 +0200 Makefile(.am/dissectors): fix indent (always use tabs) Change-Id: I652bd3657e335edd9f0c27a29fd360f0bc7d1c12 Reviewed-on: https://code.wireshark.org/review/23923 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2563f9dd797e93f932ef66554b5bff9e5948a322 commit 2563f9dd797e93f932ef66554b5bff9e5948a322 Author: Jo??o Valverde Date: Sun Oct 15 13:00:39 2017 +0100 plugins: Fix -Wmissing-prototype for plugin_register() Change-Id: I03d5ca01fb3bc8fdae86b44e857a4b9a3c7f48d2 Reviewed-on: https://code.wireshark.org/review/23927 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=9d49e1316689ae05d31efc866f04ac12cd051085 commit 9d49e1316689ae05d31efc866f04ac12cd051085 Author: Ahmad Fatoum Date: Sat Aug 26 10:30:47 2017 +0200 Remove superfluous null-checks before strdup/free NULL checks were removed for following free functions: - g_free "If mem is NULL it simply returns" https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free - g_slist_free(_full)? "NULL is considered to be the empty list" https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html - g_strfreev "If str_array is NULL, this function simply returns." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev - g_slice_free "If mem is NULL, this macro does nothing." https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free - g_match_info_free "not NULL... otherwise does nothing" https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free - dfilter_free defined in Wireshark code. Returns early when passed NULL epan/dfilter/dfilter.c They were also removed around calls to g_strdup where applicable: - g_strdup "If str is NULL it returns NULL." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04 Reviewed-on: https://code.wireshark.org/review/23406 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=37ccb77a1ab845075465c2d86eea9e8e21abc273 commit 37ccb77a1ab845075465c2d86eea9e8e21abc273 Author: Jo??o Valverde Date: Sun Oct 15 12:17:37 2017 +0100 Fix comment Change-Id: Idebca52f2dbebbfc9edb132c3e8ca8d6e1ef79f4 Reviewed-on: https://code.wireshark.org/review/23926 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=9ac61baa862e4008ef8fd5326c9d8602f52f8ae9 commit 9ac61baa862e4008ef8fd5326c9d8602f52f8ae9 Author: Jo??o Valverde Date: Sun Oct 15 11:25:17 2017 +0100 autotools: Make some installation hints more visible Change-Id: I347f2983f5d8f11791d0ed0e51ba51de36b1d11f Reviewed-on: https://code.wireshark.org/review/23925 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f053b082cde9e6fdc8e2bf789ca80bcad779b136 commit f053b082cde9e6fdc8e2bf789ca80bcad779b136 Author: Jo??o Valverde Date: Sun Oct 15 11:23:00 2017 +0100 Revert "autotools: dispense with some installation warnings/notes" This reverts commit 79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db. Change-Id: I019a037e399859b613456283e35cf81f5932b21c Reviewed-on: https://code.wireshark.org/review/23924 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db commit 79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db Author: Jo??o Valverde Date: Sat Oct 14 12:00:26 2017 +0100 autotools: dispense with some installation warnings/notes These are not (easily) visible during installation and are better suited for documentation anyway, as implied in the Makefile comments. Change-Id: Id2581f6e8dfc05f1a6c0de918a0f687f025e6d12 Reviewed-on: https://code.wireshark.org/review/23910 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2ef359cdae0e816db112565899c1ca0f349b4c5a commit 2ef359cdae0e816db112565899c1ca0f349b4c5a Author: Gerald Combs Date: Sun Oct 15 08:14:02 2017 +0000 [Automatic update for 2017-10-15] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic0da94f81172212f1688ccb8213f3ee912256600 Reviewed-on: https://code.wireshark.org/review/23919 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=9d189c7e20de37f95b2ad70725ab65b9bf863227 commit 9d189c7e20de37f95b2ad70725ab65b9bf863227 Author: Peter Wu Date: Sat Oct 14 18:43:58 2017 +0100 ssl: assume everything after CCS is encrypted After ChangeCipherSpec, record fragments are encrypted. Use this strong hint to fix misinterpreting the explicit nonce as a handshake message. One edge case remaing unsolved though, if an encrypted Finished message follows the CCS in the same TCP packet, then it could still be misinterpreted. Bug: 14117 Change-Id: Ie54bb5335f115d0fd8f05a13d1c826e3807cbbd3 Reviewed-on: https://code.wireshark.org/review/23900 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=b5948a042a9925619a464cde7b0de245fab45594 commit b5948a042a9925619a464cde7b0de245fab45594 Author: Jo??o Valverde Date: Sat Oct 14 11:55:29 2017 +0100 autotools: dispense with desktop-file-install Change-Id: I20717e669709bde6c7b1ff7d10f928e2ec2cc263 Reviewed-on: https://code.wireshark.org/review/23909 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=5842fe4afe9b5feeeef8cd78a82fa32bcefc1a39 commit 5842fe4afe9b5feeeef8cd78a82fa32bcefc1a39 Author: Jo??o Valverde Date: Sat Oct 14 11:48:07 2017 +0100 autotools: dispense if-else shellcheck test Change-Id: I1fd63442b27460ef21b2aaf4e3639a7d12c72c6e Reviewed-on: https://code.wireshark.org/review/23908 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=d4b0fb5773c874e14be91f861eae24fa60237fa6 commit d4b0fb5773c874e14be91f861eae24fa60237fa6 Author: Jo??o Valverde Date: Sat Oct 14 11:40:54 2017 +0100 autotools: remove unused variables Change-Id: I1636358f76c7c230b8b464a17dddf520b723b36b Reviewed-on: https://code.wireshark.org/review/23907 Reviewed-by: Guy Harris Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=1dea7f3dc17de6ac189f8d185d2c4c4294fed950 commit 1dea7f3dc17de6ac189f8d185d2c4c4294fed950 Author: Peter Wu Date: Sat Oct 14 21:14:14 2017 +0100 Rename ui_util.h -> ws_ui_util.h In preparation for possibly using AUTOUIC in CMake which treats "ui_*.h" files specially, rename ui_util.h. No other changes. Change-Id: Id026572c000b713ff0e9388dc7fff8d81d4df73e Reviewed-on: https://code.wireshark.org/review/23916 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=af09db8bd3f0defb319df00fa69cd82044ac1007 commit af09db8bd3f0defb319df00fa69cd82044ac1007 Author: Christoph Wurm Date: Wed Jul 19 14:24:47 2017 +0000 Tshark: Optional packet summary for Elasticsearch Currently, the Elasticsearch output exports the packet details and, if -x is specified, the raw hex data. This change adds the option of exporting the packet summary as well. The default stays the same (packet details only), but now the existing -P switch turns on printing of the packet summary. It also turns off printing packet details, which can be turned back on with -V to print both, and combined with -x to print all three: summary, details and raw hex. The packet summary is especially useful when exploring and visualizing the data in Kibana, e.g. by displaying the summary "Info" field/column in a table, as in the Wireshark GUI. Change-Id: I2030490cfdd905572397bc3d5457ba49d805a5c4 Reviewed-on: https://code.wireshark.org/review/22716 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ddf65262562052ae132b2a4c9cf89b69ed9f1d5f commit ddf65262562052ae132b2a4c9cf89b69ed9f1d5f Author: Peter Wu Date: Sun Oct 15 00:12:53 2017 +0100 FindPOD.cmake: look for pod2man.bat Strawberryperl 5.26.1.1 installs "pod2man.bat" but not "pod2man" so find_program cannot locate it. Change-Id: Iebfe2efec220085b15a4d73681da9cc7ea6a5360 Reviewed-on: https://code.wireshark.org/review/23913 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c4fbd43adedd0dcb3d7252efd340391948196d54 commit c4fbd43adedd0dcb3d7252efd340391948196d54 Author: Jo??o Valverde Date: Sat Oct 14 19:07:10 2017 +0100 configure: Fix PCAP_LIBS without pcap-config Also remove XXX comment (answer: no, using package flags is preferable). Change-Id: I05e7c0a40db9f1e1931b0fc585fed49cd7409526 Reviewed-on: https://code.wireshark.org/review/23901 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=2ecc51f28f42644c655d2d86790b90f7a5ba81c7 commit 2ecc51f28f42644c655d2d86790b90f7a5ba81c7 Author: Martin Mathieson Date: Sat Oct 14 21:04:14 2017 +0100 Some trivial fixes from running cppcheck. The packet-per.c intialisation of ext_length is not really needed - idx could be -1 with or without extension_flag being set. But it'd be best not to have someone need to think this through again. Change-Id: If07f98ac7d7f2619149e35a2a0d75b765839a7ba Reviewed-on: https://code.wireshark.org/review/23905 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c2f1ab1cbcc07af13935c037534148b132aec46b commit c2f1ab1cbcc07af13935c037534148b132aec46b Author: Guy Harris Date: Sat Oct 14 11:55:58 2017 -0700 Update comment. Red Hat, at one point, provided a /usr/include/pcap/pcap.h without bothering to also provide a /usr/include/pcap.h that linked to it or included it, breaking source compatibility. That's what we're working around when we search in both the top-level include directories and, if they exist, pcap subdirectories of those directories. libpcap 1.0 and later also put pcap.h in a pcap subdirectory, but also provided a pcap.h in the top-level include directory that included pcap/pcap.h, preserving source compatibility, so that's not the reason we're searching in the top-level include directories and their pcap subdirectories. Change-Id: I8f427d46ce8293d278be9005ee623cda1ea5d691 Reviewed-on: https://code.wireshark.org/review/23902 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0943d6ee9da6d2691493600e82c6f4d938ddb3b2 commit 0943d6ee9da6d2691493600e82c6f4d938ddb3b2 Author: Darien Spencer Date: Sat Oct 14 13:59:35 2017 +0300 FP Fixed bug in heuristic dissector Change-Id: I6960c7b9a2fa1b9f86e06df5036b4e0bcf1dcfe0 Reviewed-on: https://code.wireshark.org/review/23898 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=9bba3866ffc0d382d511d298d2460c618bfa6c0d commit 9bba3866ffc0d382d511d298d2460c618bfa6c0d Author: Jo??o Valverde Date: Sun Sep 24 02:30:08 2017 +0100 CMake: Allow user build flags to override default build flags Autotools has the very useful feature by design of allowing the user to override the default build flags (you break it you keep it). Apparently CMake applies COMPILE_OPTIONS target property after CMAKE_{C,CXX}_FLAGS so that doesn't work here. Prepend our flags to those variables instead to make it work then. Specific target flag overrides can still be added with COMPILER_OPTIONS (e.g: generated files with -Wno-warning) but this is less effective and then we're back at the point where this overrides user flags. It's less of a concern though. Change-Id: I44761a79be4289238e02d4e781fef0099628817b Reviewed-on: https://code.wireshark.org/review/23675 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=68ef8797118b6015ac47130c789cd93e73b03597 commit 68ef8797118b6015ac47130c789cd93e73b03597 Author: Alexis La Goutte Date: Fri Oct 13 14:01:56 2017 +0200 docsis: fix 'docsis_vsif.gex.sav.spr.static_prefix_address/.gex.imja.imja_ssr_source_prefix_address/.imja.imja_ssr_group_prefix_address' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 Change-Id: I7c978870eb3cc54e718fe3c810f7b4e7f6ea67c9 Reviewed-on: https://code.wireshark.org/review/23897 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1e0dcf8dafafd2261c863471e191c65c768e02ea commit 1e0dcf8dafafd2261c863471e191c65c768e02ea Author: Alexis La Goutte Date: Fri Oct 13 14:00:38 2017 +0200 docsis: fix 'docsis_vsif.gex.extended_cmts_mic_hmac_type' exists multiple times with NOT compatible types: FT_BYTES and FT_UINT8 Change-Id: Ic3a0f7f6edf5a28ffde6703276d4747d138081c7 Reviewed-on: https://code.wireshark.org/review/23896 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=337f49243faeab6796c12e434928823606dda195 commit 337f49243faeab6796c12e434928823606dda195 Author: Michael Mann Date: Fri Oct 13 00:28:50 2017 -0400 Add ptvcursor APIs that return the values it retrieves ptvcursor_add_ret_uint ptvcursor_add_ret_int ptvcursor_add_ret_string ptvcursor_add_ret_boolean Change-Id: I41fa91b1ab805778d34a61215830b12a1331e864 Reviewed-on: https://code.wireshark.org/review/23895 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=32d31e55ae7ed3b2b3e184e64fa82f1cda5604c4 commit 32d31e55ae7ed3b2b3e184e64fa82f1cda5604c4 Author: Gerald Combs Date: Wed Oct 11 22:19:56 2017 +0000 WiMAX ASN CP: Leak less memory. Replace some g_new()s, g_strdup()s and GArrays used in prefix registration with their epan_scoped wmem equivalents. This reduces the amount of memory we leak so that we come in below the Valgrind fuzzer's current threshold (102400). Bug: 14106 Change-Id: I7308ac89465316c06773552253dabc876b6c2425 Reviewed-on: https://code.wireshark.org/review/23891 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f3ba040479f35e8b6f630553159b1b799fbae665 commit f3ba040479f35e8b6f630553159b1b799fbae665 Author: Gerald Combs Date: Thu Oct 12 12:58:18 2017 -0700 win-setup: Don't bother downloading UPX. We haven't used UPX since g85eec7f603 (2014). Don't bother downloading it. Change-Id: Id86ca6ae8f29adab3eb40a2ea3bd1de5ff45d868 Reviewed-on: https://code.wireshark.org/review/23894 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=99fd0cfb05a465d7846f1d1b65086fa5f35fa297 commit 99fd0cfb05a465d7846f1d1b65086fa5f35fa297 Author: Martin Mathieson Date: Tue Oct 10 21:44:32 2017 +0100 FTP: setup conversation properly for PASV sessions Also keep track of last frame of data response, and work out duration of ftp-data stream. Change-Id: I460aaa5c8736e044410eab428707651cede39d7e Reviewed-on: https://code.wireshark.org/review/23880 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=5ad0579bebcccfa3fce6549b1b7f986681e2bea2 commit 5ad0579bebcccfa3fce6549b1b7f986681e2bea2 Author: Pascal Quantin Date: Thu Oct 12 11:45:31 2017 +0200 IEEE 802.11: fix a segmentation fault introduced in gd6eda2a3 Bug: 14114 Change-Id: Ie377b1b3ccf29014935b9e5796567cdb8bb466a3 Reviewed-on: https://code.wireshark.org/review/23893 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2a8ab239bdcec408971b48b3c6ee08c68c8798e2 commit 2a8ab239bdcec408971b48b3c6ee08c68c8798e2 Author: AndersBroman Date: Thu Oct 12 10:48:32 2017 +0200 [TCAP] Make "tid" a generated item rather than hidden to make it obvious that it exists. Change-Id: I1986b7678193f3b4c9ed8cabff7e411cef5bf185 Reviewed-on: https://code.wireshark.org/review/23892 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=da8dbd247157caea874320be6e182beb584e57bf commit da8dbd247157caea874320be6e182beb584e57bf Author: Jorge Mora Date: Tue Oct 10 09:41:27 2017 -0600 infiniband: add PSN and RETH DMA length to infinibandinfo struct Expose the PSN (packet sequence number) and the RETH DMA length to protocol's dissectors. Change-Id: Ied53a8964d7cd5c3d148ec7c7642017951e56118 Reviewed-on: https://code.wireshark.org/review/23886 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b363e46ad48a8a2b340dd6792fdce1800a8cee44 commit b363e46ad48a8a2b340dd6792fdce1800a8cee44 Author: Pascal Quantin Date: Wed Oct 11 21:31:42 2017 +0200 IEEE 802.11: add missing breaks Change-Id: Ie26b0c869a778f7e27cb6d944c2e32ced0d3337e Reviewed-on: https://code.wireshark.org/review/23889 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=9551aca9a685e97a03d58eb63e4b791416ba4c63 commit 9551aca9a685e97a03d58eb63e4b791416ba4c63 Author: Guy Harris Date: Wed Oct 11 12:31:16 2017 -0700 Add --print as an alias for -P, to match tcpdump. tcpdump just got a --print option, which causes packet information to be printed even if the raw packets are being saved to a file with -w. We have -P for the same purpose; make --print another name for it. While we're at it: document --help and --version; just speak of -P/--print as causing printing even of the packet details, even though -V forces printing with -w, for consistency with how --print is documented for tcpdump; fix the description of -h/--help. Change-Id: Idf650a202a09a2d1682edbd9d76123f1b1412b55 Reviewed-on: https://code.wireshark.org/review/23888 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b2467fddb1d83a0667970968493a9dad1dfb0be1 commit b2467fddb1d83a0667970968493a9dad1dfb0be1 Author: Gerald Combs Date: Wed Oct 11 08:54:12 2017 -0700 ProtoBuf: Remove an unused variable. Remove protobuf_message_direction_type: ../epan/dissectors/packet-protobuf.c:125:20: error: unused variable 'protobuf_message_direction_type' [-Werror,-Wunused-const-variable] VALUE_STRING_ARRAY(protobuf_message_direction_type); ^ Have dissect_one_protobuf_field return a gboolean while we're here. Change-Id: I5d9d2e3414b5668ca26d5c0a450225c3cdf5da56 Reviewed-on: https://code.wireshark.org/review/23887 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=95c50e3dd766e919953def30f65ba5496226a660 commit 95c50e3dd766e919953def30f65ba5496226a660 Author: Jason Uher Date: Wed Oct 4 11:46:00 2017 -0400 Decode SNR in Compressed MIMO Beamforming report per ieee80211at_2013 sections 8.4.1.{29,48} Change-Id: I4f3af7e06169461a15507ed8ecce8f15075b9667 Reviewed-on: https://code.wireshark.org/review/23835 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6ef693dec1fd189d0995d8ad6a06c29c05823ce8 commit 6ef693dec1fd189d0995d8ad6a06c29c05823ce8 Author: AndersBroman Date: Wed Oct 11 10:57:43 2017 +0200 [Solaredge] Fix SuSE 11.4 build packet-solaredge.c:1013: error: declaration of rand shadows a global declaration Change-Id: I98f4edb14cd241bd709d50e8ac9151448773a658 Reviewed-on: https://code.wireshark.org/review/23884 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8fbad3dd56b45874463f9d811b80006314413c0e commit 8fbad3dd56b45874463f9d811b80006314413c0e Author: Huang Qiangxiong Date: Mon Jul 31 15:26:57 2017 +0000 Start of adding Protobuf (Protocol Buffers) dissector. 1. Protobuf dissector supports the almost all basic protobuf types of varint, sint, string, and so on. 2. Protobuf messages are not self-described protocol, for example, varint in protobuf may be int32, int64, uint32, uint64, sint32, sint64, bool or enum. Currently dissector will dissect field without detail definition in common way, for numeric field it show uint32 or uint64, for length-delimited field it just show as bytes. But user turn the try_dissect_all_length_delimited_field_as_string or show_all_possible_field_types options on, that dissect will show all possible value for each field according to wire type. (for example, a numeric field will parsed in int32, uint32, sint32, sint64 and so on). Ping-Bug: 13932 Change-Id: Idfe49307b1c84fe461603756f75daeb3e410a905 Reviewed-on: https://code.wireshark.org/review/23814 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3444d41fd0d425aca79c9eeaadff1a7f647e7b13 commit 3444d41fd0d425aca79c9eeaadff1a7f647e7b13 Author: AndersBroman Date: Tue Oct 10 10:24:28 2017 +0200 [GSM SMS] If the digits are E164 International number add an E.164 filter. Change-Id: Idcfa53d1db9e9f7b5501ca92592fb0fa0790ffe9 Reviewed-on: https://code.wireshark.org/review/23873 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=698aa24165d0a51b06117d6d9133c04839fbe40e commit 698aa24165d0a51b06117d6d9133c04839fbe40e Author: Michael Mann Date: Mon Oct 9 15:45:43 2017 -0400 Change FI_VARINT to account for FI_BITS_XXX flags FI_BITS_XXX were using bits 5-15 of the field_info->flags bitmask. Move FI_VARINT to be outside of that range. Change-Id: I92efcb5644cdbb562537d2813b611e583315874b Reviewed-on: https://code.wireshark.org/review/23871 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6b466a9e4fccae694c2ae6607ad5c5b28dfff303 commit 6b466a9e4fccae694c2ae6607ad5c5b28dfff303 Author: Felix Ruess Date: Mon Oct 9 17:01:24 2017 +0200 [gvcp] fix extendedblockids check and resend cmd parsing Change-Id: I9e0314ae2e975a1c50cfaf2b00e469ad7f640357 Reviewed-on: https://code.wireshark.org/review/23866 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d72a18faad55d6f47af47acfb9d9270015bad2e2 commit d72a18faad55d6f47af47acfb9d9270015bad2e2 Author: Gerald Combs Date: Mon Oct 9 15:10:27 2017 -0700 Fuzz: Limit the number of packets we process with Valgrind. Estimating the effort required to process a capture based on its size isn't very reliable. Instead of rejecting files that are too large, just limit Valgrind fuzzing to the first 100,000 packets in each file. This should fix a timeout issue we're seeing on the master fuzzer. Change-Id: I0117735341d3a183c6131f5f05dbd1d559fc4b3f Reviewed-on: https://code.wireshark.org/review/23872 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=95ce7daf65beb1864cbcb7bd984952eabb0308da commit 95ce7daf65beb1864cbcb7bd984952eabb0308da Author: Jorge Mora Date: Mon Oct 9 10:54:37 2017 -0600 infiniband: fix OpCodeMap string for UC_RDMA_WRITE_MIDDLE Make string mapping for UC_RDMA_WRITE_MIDDLE consistent with all other mappings in the OpCodeMap table. Remove extra blank lines in the OpCodeMap table. Change-Id: Ifb3e242a89458103f3db3b5718d5d939dffb6dae Reviewed-on: https://code.wireshark.org/review/23867 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e8dbf386d8a830d822ff5f2857c63338a7998abb commit e8dbf386d8a830d822ff5f2857c63338a7998abb Author: Gerald Combs Date: Mon Oct 9 12:19:02 2017 -0700 Fuzz: Write memory leak info to the error log. When we exit due to excessive memory leaks make sure we say so in the error log. Change-Id: I03f60271f3e4bb467fbaa5b9ac17431eed96f300 Reviewed-on: https://code.wireshark.org/review/23870 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=3bfb9aabe0e525ad76251190289c1ea3417fb1aa commit 3bfb9aabe0e525ad76251190289c1ea3417fb1aa Author: AndersBroman Date: Mon Oct 9 12:52:13 2017 +0200 [Diameter 3GPP] Fix bitmask in feature list B26 and add B27. Change-Id: I0f035da3f5305ce6935c79e0c1b5f63f955d099d Reviewed-on: https://code.wireshark.org/review/23865 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d8d60b4980882e37b73df3bfead8c2b09daba091 commit d8d60b4980882e37b73df3bfead8c2b09daba091 Author: Michael Mann Date: Sat Sep 23 09:05:21 2017 -0400 Add ENC_VARINT_PROTOBUF Encoding of integer datatypes of Protocol buffers https://developers.google.cn/protocol-buffers/docs/encoding Change-Id: I9f6d65ddca099c15c0634984e9394131f98d35a9 Reviewed-on: https://code.wireshark.org/review/23813 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c6a0e2a7916a689dfb642b004d07f6fc76fd04f3 commit c6a0e2a7916a689dfb642b004d07f6fc76fd04f3 Author: Pascal Quantin Date: Thu Oct 5 21:39:10 2017 +0200 packet.c: fix a control flow issue reported by Coverity (CID 1418671) Let's perform the check before potentially breaking the loop. While we are at it, let's update the test to remove the last layer so as to match the one used to add it. Change-Id: I5807219de75c4e2c23b9435d6271ad60aec45783 Reviewed-on: https://code.wireshark.org/review/23844 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1df866d99e99346bf61d0f7c49600000048fa393 commit 1df866d99e99346bf61d0f7c49600000048fa393 Author: Alexis La Goutte Date: Sun Oct 8 11:54:54 2017 +0200 ftypes(.h): fix indent (use tabs) Change-Id: Ic824910d4ec8c9987e8deec8d61809feb9849b9b Reviewed-on: https://code.wireshark.org/review/23863 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=14107eec716f5f438273018ec0ddad9638934bf7 commit 14107eec716f5f438273018ec0ddad9638934bf7 Author: Alexis La Goutte Date: Sun Oct 8 11:59:06 2017 +0200 proto(.h): fix indent (use spaces) Change-Id: I029a9db40c8ca5a67bb1db69c50d8f08b7f59ab2 Reviewed-on: https://code.wireshark.org/review/23864 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6628fdf54b635a216fdd83eb7d4f392512073787 commit 6628fdf54b635a216fdd83eb7d4f392512073787 Author: Gerald Combs Date: Sun Oct 8 08:13:30 2017 +0000 [Automatic update for 2017-10-08] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I700244d357bcb8d37866b296ea7c6bb671f983af Reviewed-on: https://code.wireshark.org/review/23859 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=ddb754243e6ba3290ed098d15834a0b9d2d65d50 commit ddb754243e6ba3290ed098d15834a0b9d2d65d50 Author: Pascal Quantin Date: Sat Oct 7 22:53:43 2017 +0200 X2AP: fill gaps in extended value string array Change-Id: I6d8594de78dd46d679072cc17211e940155f0012 Reviewed-on: https://code.wireshark.org/review/23858 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=eb5b2a211d5065af21e9949c81d8d9ce6920ba12 commit eb5b2a211d5065af21e9949c81d8d9ce6920ba12 Author: Pascal Quantin Date: Sat Oct 7 22:42:48 2017 +0200 S1AP: upgrade dissector to v14.4.0 Change-Id: I1124a691ec004507e6e144038b13f9d432d88c5f Reviewed-on: https://code.wireshark.org/review/23857 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=750eb3637e360b8a8e0ec7665d8165b2ed4baa5d commit 750eb3637e360b8a8e0ec7665d8165b2ed4baa5d Author: Alexis La Goutte Date: Tue Oct 3 10:39:06 2017 +0000 tap-flow (ui): fix no previous prototype for ???register_tap_listener_flow??? [-Wmissing-prototypes] Change-Id: I6031600ee3d764a7b2690ff88dbbfb01a1d6244b Reviewed-on: https://code.wireshark.org/review/23824 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=53706c80d61003d05dc0116d4a171d554e04dbe4 commit 53706c80d61003d05dc0116d4a171d554e04dbe4 Author: Jorge Mora Date: Fri Oct 6 09:40:01 2017 -0600 RPC-over-RDMA: fix write list chunk count Add the chunk_size to the offset to get the correct write list count, this issue was introduced by the fix for Bug: 13558 Change-Id: I306a9c0c9d601f7bdf4cc0e49eacd5466a6adb89 Reviewed-on: https://code.wireshark.org/review/23851 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=471736ece003e80bb47e9a9b29099d7ab6200d04 commit 471736ece003e80bb47e9a9b29099d7ab6200d04 Author: Bruno Verstuyft Date: Thu Oct 5 10:34:18 2017 +0200 DOCSIS: added vsif general extension dissection Change-Id: Ic61815b967fac412fb1a324c470ff5171b97acbb Reviewed-on: https://code.wireshark.org/review/23840 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6172627534168bb31415fa31a7cecdb15bcca4ab commit 6172627534168bb31415fa31a7cecdb15bcca4ab Author: Gerald Combs Date: Wed Oct 4 16:27:08 2017 -0700 Make osx-app.sh a configured file and remove Autotools targets. Rename osx-app.sh to osx-app.sh.in and add the version to the plugin path at configure time. Instead up updating Autotools accordingly just remove the macOS packaging targets. gf61c381b5a removed support for Autotools in osx-app.sh and if anyone wants to build macOS packages I'd prefer that they use the same toolchain as the buildbot. Change-Id: Ide5205265bf8859a85b1afab68fa8f8285952bd3 Reviewed-on: https://code.wireshark.org/review/23839 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ae794fc5f24e893b20f4161ac3cfb20e018e9b96 commit ae794fc5f24e893b20f4161ac3cfb20e018e9b96 Author: Pascal Quantin Date: Thu Oct 5 22:18:32 2017 +0200 M3AP: avoid appending m3ap multiple times to frame.protocols field Change-Id: Iff7cc711ae1fba0a7c239dec47d83d5b4ac84e2c Reviewed-on: https://code.wireshark.org/review/23849 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fa8fd247cf7e038ee3cfcac6ce13c97542bf3abc commit fa8fd247cf7e038ee3cfcac6ce13c97542bf3abc Author: Pascal Quantin Date: Thu Oct 5 22:15:36 2017 +0200 M2AP: avoid appending m2ap multiple times to frame.protocols field Change-Id: I4e9fee5ae98cd776d168006c4119aff5767dfa16 Reviewed-on: https://code.wireshark.org/review/23848 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0a4c646cbc9df5d16a5041b7b4d94a98955e6fff commit 0a4c646cbc9df5d16a5041b7b4d94a98955e6fff Author: Pascal Quantin Date: Thu Oct 5 22:12:53 2017 +0200 LPPa: avoid appending lppa multiple times to frame.protocols field Change-Id: I89557fc4ee5bce4802cc2b34e020d567ab34c79b Reviewed-on: https://code.wireshark.org/review/23847 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=155f8d5288b50badc560dc87a1010874cf84f57a commit 155f8d5288b50badc560dc87a1010874cf84f57a Author: Pascal Quantin Date: Thu Oct 5 22:09:48 2017 +0200 X2AP: avoid appending x2ap multiple times to frame.protocols field Change-Id: I521ffa43ff81b9a41f8e3f01a0d39e18f590a050 Reviewed-on: https://code.wireshark.org/review/23846 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=82acd85bcca0a79cd04ddfab40eec1112e507486 commit 82acd85bcca0a79cd04ddfab40eec1112e507486 Author: Pascal Quantin Date: Thu Oct 5 22:08:26 2017 +0200 S1AP: avoid appending s1ap multiple times to frame.protocols field Change-Id: Ide44391bf18d2f301f32cd6a65b246e9a1cc5891 Reviewed-on: https://code.wireshark.org/review/23845 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=561914bd20913407f6344e4081c2e483d3e53bc4 commit 561914bd20913407f6344e4081c2e483d3e53bc4 Author: Vladimir Rutsky Date: Thu Oct 5 11:09:03 2017 -0400 gRPC: Several bugfixes 1. fix returing new offset value dissect_grpc_message() is called with the offset to the message that needs to be parsed and returns new offset (e.g. offset to the next message in stream). Before this change length of the parsed message (including 5 bytes header) were returned which was incorrect and may lead to infinite loops. 2. fix reported length in case of invalid packet 3. fix typo in comment: "streaam" Change-Id: I577cdcc0203a87122a4d8d8c660f43295609e8aa Signed-off-by: Vladimir Rutsky Reviewed-on: https://code.wireshark.org/review/23843 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5a99830e211901e498e036b9adb00b0c33c7904d commit 5a99830e211901e498e036b9adb00b0c33c7904d Author: Mikael Kanstrup Date: Sun Oct 1 00:52:48 2017 +0200 Qt: Free dynamic menu actions at shutdown Some menu actions registered at startup are not freed at shutdown making Valgrind complain. Fix by clearing the lists holding them and making sure all actions have a parent to free them. Bug: 14071 Change-Id: I8d99d062d394a7262b0f9b7ddea4ed71049636ac Reviewed-on: https://code.wireshark.org/review/23793 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=867e6f0e006ae633ab7928a20919e0011bc0c63f commit 867e6f0e006ae633ab7928a20919e0011bc0c63f Author: Mikael Kanstrup Date: Tue Sep 26 13:14:02 2017 +0200 qt: Fix leaked dialogs Some dialogs are allocated on heap but not freed when the dialog boxes are closed. This means one dialog instance is leaked each time opened/closed. Also dialogs being subclasses of GeometryStateDialog means they might lack a parent reference and are not automatically freed on application shutdown either. Fix these leaks by letting the dialogs automatically destroy themselves on close (via WA_DeleteOnClose). Capture filter, display filter and capture interfaces dialogs are also leaked on application shutdown. These dialogs are protected by a NULL check that at least prevent multiple instances. Though none of them are freed on application shutdown. Fix leaks by freeing when main window is destroyed. Bug: 14071 Change-Id: I8c5c5a75ad3c89abb5996941875ba5d616a22d9c Reviewed-on: https://code.wireshark.org/review/23747 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3c9f440ac60ba83f155a89a851f9a1d3cc947f8d commit 3c9f440ac60ba83f155a89a851f9a1d3cc947f8d Author: Jakub Zawadzki Date: Wed Oct 4 22:41:19 2017 +0200 sharkd: export field filter string. This extra parameter allows to use wireshark functionality like: prepare as filter, and also apply quick filter in protocol tree (for instance show only TCP protocol fields: tcp.), Change-Id: I1f380b79e3802e6aaf646fdd4770c903ee9f3781 Reviewed-on: https://code.wireshark.org/review/23837 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7219f6467feb8ce767689aa456fe8ff2f711e22a commit 7219f6467feb8ce767689aa456fe8ff2f711e22a Author: Gerald Combs Date: Wed Oct 4 15:58:31 2017 -0700 HTTP: Add http.file_data based on the captured length. Switch the file_data handling to use the captured length. In a test capture here this lets us call the GIF dissector in a truncated packet. Fixup a variable type and some whitespace. Change-Id: I21b64519ad84f730e1412115035125c2bf1f361c Reviewed-on: https://code.wireshark.org/review/23838 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8804ddbe2a35a9e8bc1340912e73479cb2f31390 commit 8804ddbe2a35a9e8bc1340912e73479cb2f31390 Author: Alexis La Goutte Date: Thu Apr 27 16:24:54 2017 +0200 gsm_sim: fix conflicting entry in its value_string Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 24384 is at indices 72 (DF.EIA/TIA-533) and 78 (DF.WLAN)) Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 28421 is at indices 31 (EF.LP) and 80 (EF.LI)) Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 28472 is at indices 37 (EF.SST) and 89 (EF.USI)) Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 28481 is at indices 41 (EF.PUCT) and 96 (EF.PUCI)) Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 28489 is at indices 23 (EF.SDN) and 103 (EF.SIN)) Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 28494 is at indices 28 (EF.EXT4) and 107 (EF.EXT5) Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 28495 is at indices 29 (EF.ECCP) and 108 (EF.CCP2)) Change-Id: I4bde0cc644131e9b088fca07837fa1b909f30f44 Reviewed-on: https://code.wireshark.org/review/21381 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1961297a55f0b7a2ff6acc1ab7909d50e4b80f70 commit 1961297a55f0b7a2ff6acc1ab7909d50e4b80f70 Author: Jakub Zawadzki Date: Wed Oct 4 08:12:23 2017 +0200 sharkd: check if JSON value is string or primitive (true/false/null/number). Add extra check for token type, previously it was possible to pass for example: {"columns":["one","two","three"]}. Such format is not supported. Change-Id: I6ac2e3ca9eba868cd72ed886ad40745ebbc43d73 Reviewed-on: https://code.wireshark.org/review/23834 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ea6e4b577f08f88e0d5cabb7cb38e17b236e513a commit ea6e4b577f08f88e0d5cabb7cb38e17b236e513a Author: Jakub Zawadzki Date: Wed Sep 27 22:24:54 2017 +0200 sharkd: support for user column-set in "frames" request. Change-Id: If6a10cc252f2ad362ba3a91318cedd15d954db2b Reviewed-on: https://code.wireshark.org/review/23768 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=70996dc669305da1c5f7a305d67b5976fde75073 commit 70996dc669305da1c5f7a305d67b5976fde75073 Author: cheloftus Date: Wed Jun 28 22:52:41 2017 +0100 Qt: add preference to restore display filter after Follow Stream Added new user preference 'restore_filter_after_following_stream', defaults to false. When true, the current display filter is restored after following a stream. Change-Id: I153107761003658c6d7f1464711da7b3adeb60a8 Reviewed-on: https://code.wireshark.org/review/22455 Reviewed-by: Peter Wu Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0553cda6dab3f69ccd32adb6d60723e9baf56d4a commit 0553cda6dab3f69ccd32adb6d60723e9baf56d4a Author: Jakub Zawadzki Date: Wed Sep 27 22:03:43 2017 +0200 Instroduce col_finalize(), to allow creating column_info based not only on preferences. Change-Id: I417e6accff3390a9b1839cd6b44266b76aa754c3 Reviewed-on: https://code.wireshark.org/review/23767 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f61c381b5a019b3fc8756fd5c199894886eb2492 commit f61c381b5a019b3fc8756fd5c199894886eb2492 Author: Gerald Combs Date: Tue Oct 3 15:44:38 2017 -0700 Remove unused code from osx-app.sh Remove Autotools-specific code from osx-app.sh. The official builders have used CMake for a while and as far as I know no one else uses our packaging scripts. Change-Id: I6fc20114b42e10dacc69346c379055b68184b85c Reviewed-on: https://code.wireshark.org/review/23833 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3cddb369d57e8ef7b310edea7ba5d7b2be19e777 commit 3cddb369d57e8ef7b310edea7ba5d7b2be19e777 Author: Peter Wu Date: Tue Oct 3 02:54:28 2017 +0100 TLS: enable OCSP status dissection for TLS 1.3 and DTLS In TLS 1.2, the "certificate_status" extension in the CH would result in a response in the CertificateStatus handshake message. In TLS 1.3, the response appears in a SH extension instead. Refactor the code to use ssl_add_vector and hook it up with SH extensions dissection. Do not stop dissection on a non-empty Responder ID list. Remove misleading "CertificateStatus" tree item, it only covered the "OCSPResponse" vector, now its two children (just OCSP Response Length and the OCSP Response tree) are displayed directly. Enable DTLS support, the spec does not forbid it and there is a user: https://mta.openssl.org/pipermail/openssl-users/2016-August/004306.html Tested with tls-sct.pcap (bug 13372) which now shows one tree item less and tls13-18-cert-sct-ocsp.pcap (bug 12779) which now dissects the OCSP response in the Certificate Extensions. Change-Id: I2ccde84cb1e3bcb1bc47676eadc5cb542248cd92 Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23819 Petri-Dish: Peter Wu Reviewed-by: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=064038bb1bf12d992e8083517f37ae2acfa782a8 commit 064038bb1bf12d992e8083517f37ae2acfa782a8 Author: Bruno Verstuyft Date: Tue Oct 3 11:44:42 2017 +0200 DOCSIS: added dissection of IPv6 classifier TLV Change-Id: I49a920c2d93dbbc0ae9f8152922485a14225ea9e Reviewed-on: https://code.wireshark.org/review/23822 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5826a8532ed4e2a0387aa8a2857bca62b8d2371f commit 5826a8532ed4e2a0387aa8a2857bca62b8d2371f Author: Gerald Combs Date: Tue Oct 3 15:28:40 2017 -0700 macOS: Fixup app bundle rpathification. rpathify_dir is not recursive so the plugin path fix in g94af9724d1 wasn't sufficient. Make sure $pkgplugin is set to the versioned plugin subdirectory so that both rpathification and code signing work. Find the Qt frameworks directory using qmake while we're here. This should be more reliable than calling pkg-config (which doesn't work on my laptop). Bug: 14096 Change-Id: I0196015f849fd27994a439359cddd88c21106fde Reviewed-on: https://code.wireshark.org/review/23832 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=2c89e6c448101de562844ac6ca0fa0890964321c commit 2c89e6c448101de562844ac6ca0fa0890964321c Author: Pascal Quantin Date: Tue Oct 3 22:12:21 2017 +0200 E.212: update list to Operational Bulletin No. 1133 (1.X.2017) Change-Id: I954d18107a5743f148388cc2356458aeddca162f Reviewed-on: https://code.wireshark.org/review/23828 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=dcf7ca7abd57c231b02881a4a2b9cc223b8db99a commit dcf7ca7abd57c231b02881a4a2b9cc223b8db99a Author: Alexis La Goutte Date: Tue Oct 3 10:40:34 2017 +0000 interface_toolbar (Qt): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] Change-Id: I36ea982656e45855b357e071bcca7c6f3d12d03f Reviewed-on: https://code.wireshark.org/review/23825 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ec485f3f52f76814146b3f032b9b28549fe61c57 commit ec485f3f52f76814146b3f032b9b28549fe61c57 Author: Alexis La Goutte Date: Tue Oct 3 10:41:23 2017 +0000 wimax(-int.h): no newline at end of file [-Wnewline-eof] Change-Id: I863fe195f314301e2ecd92638e42a0f11dd2af9b Reviewed-on: https://code.wireshark.org/review/23826 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1d29691bb6e0290ae61df63004eb3389dfb3f637 commit 1d29691bb6e0290ae61df63004eb3389dfb3f637 Author: Alexis La Goutte Date: Tue Oct 3 10:42:55 2017 +0000 prefs_filter_expressions (GTK): fix no newline at end of file [-Wnewline-eof] Change-Id: Icf660a4c27ff169576115905882cad1af547b99f Reviewed-on: https://code.wireshark.org/review/23827 Petri-Dish: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c09c6531ba7b434c4b0a7f1f9ee13ffc3ad4dc8d commit c09c6531ba7b434c4b0a7f1f9ee13ffc3ad4dc8d Author: Gregor Jasny Date: Tue Oct 3 11:15:47 2017 +0200 conversation_table: Export all functions for external plugin use Change-Id: I5e42ceb5013a9ec629845953051cdeaf8b94112d Reviewed-on: https://code.wireshark.org/review/23821 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=27c7aa38aa6d96aa9b3bfb889330cba107836c1f commit 27c7aa38aa6d96aa9b3bfb889330cba107836c1f Author: Alexis La Goutte Date: Tue Oct 3 10:36:59 2017 +0000 infiniband: fix ISO C does not allow extra ???;??? outside of a function [-Wpedantic] Change-Id: I892e7a92c231293f1977cba4513b49afda8c676c Reviewed-on: https://code.wireshark.org/review/23823 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2777003e121a5d764b54c62590e7ceb46ae2c157 commit 2777003e121a5d764b54c62590e7ceb46ae2c157 Author: Jo??o Valverde Date: Fri Sep 29 19:49:51 2017 +0100 Add version check for plugin compatibility Only plugins built for the same feature release (X.Y) are assured binary compatibility. Make sure we don't try to run unsuitable code and, if so, warn the user. This might happen for example if the user manually copies a binary plugin to the wrong folder, intentionally or by accident. I'm using "release version" to loosely mean not a patch release (i.e: a feature release). Change-Id: I896e9cbbd2d3843623fff6af8ef51002ec06f1f8 Reviewed-on: https://code.wireshark.org/review/23807 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=d477ea35a946c2935974edb3fea45cf23513a03c commit d477ea35a946c2935974edb3fea45cf23513a03c Author: Alexis La Goutte Date: Tue Oct 3 08:03:26 2017 +0200 nfs: fix typo on new xattrs attribut Change-Id: I4872334e73df8a71690400e7f0690eecc02d8270 Reviewed-on: https://code.wireshark.org/review/23820 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5d672c469d2218a2f845e1eadccf2b581365a370 commit 5d672c469d2218a2f845e1eadccf2b581365a370 Author: Tom Haynes Date: Mon Oct 2 17:12:00 2017 -0700 nfs4: Add ACCESS_MASK support for xattrs See: https://datatracker.ietf.org/doc/draft-ietf-nfsv4-xattrs/ Change-Id: Ia9238bf96562f95eb56d25a1f8051b4e4fca5ba4 Signed-off-by: Tom Haynes Reviewed-on: https://code.wireshark.org/review/23817 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e670f9c80be87e4b81f4cd4dafc3d3dd9ea183e9 commit e670f9c80be87e4b81f4cd4dafc3d3dd9ea183e9 Author: Peter Wu Date: Tue Oct 3 02:42:19 2017 +0100 TLS13: fix SCT dissection since draft -17 Since draft -17, SCT has moved from EE to Certificate extensions. Decryption failed for a boringssl test suite capture because it tests with an unknown version and a small SerializedSCT which resulted in a malformed packet exception. Ignore the SCT following RFC 6962, sect 3.3. Change-Id: I894d51447f28ca121ea7f3fcef2b711a0debc1fb Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23818 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=83cb6ff625a403b6d505c3b2f0fc23cebbd479bd commit 83cb6ff625a403b6d505c3b2f0fc23cebbd479bd Author: Pascal Quantin Date: Mon Oct 2 22:32:23 2017 +0200 GTPv2: fix out of bounds access when decoding Private Extension IE Bug: 14095 Change-Id: I85e481be269ee3103209668e2c924faef6f5b1ec Reviewed-on: https://code.wireshark.org/review/23816 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=96c07c6471176082b8aff7ec6df650aebaaace0e commit 96c07c6471176082b8aff7ec6df650aebaaace0e Author: Eugene Adell Date: Sun Oct 1 05:21:38 2017 -0700 HTTP: fix for ICY responses which were displayed as HTTP requests Bug: 14091 Change-Id: Ic8d37e29f02dc9751c60e827aa773d915cabc088 Reviewed-on: https://code.wireshark.org/review/23802 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a6dec130a963753bd7431f71394b0f527147006d commit a6dec130a963753bd7431f71394b0f527147006d Author: Birol Capa Date: Mon Oct 2 09:49:00 2017 +0300 PROFINET: Fix undecoded signal value in DCP Set Request. According to specification, when suboption is CONTROL, signal value is FLASH_ONCE. Change-Id: I942579cdf3d642e636d02b778ffaad99022678e3 Reviewed-on: https://code.wireshark.org/review/23812 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ab01a1eab1c56e131171ece6624fec9797fb42d0 commit ab01a1eab1c56e131171ece6624fec9797fb42d0 Author: Alexis La Goutte Date: Mon Oct 2 08:10:29 2017 +0200 QUIC: rename Stream ID Needed by Stream ID Blocked (draft-06) Change-Id: I9aba424fc9df5030befac31373dc759249d936c5 Reviewed-on: https://code.wireshark.org/review/23810 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=06548c905ee7346c4b00ded643e5bae2d849bdaa commit 06548c905ee7346c4b00ded643e5bae2d849bdaa Author: Alexis La Goutte Date: Mon Oct 2 08:05:14 2017 +0200 QUIC: Add draft-06 version (value_string) Change-Id: Iabfa1045a7c8db3b154a9f827f2a2f130bb4fae4 Reviewed-on: https://code.wireshark.org/review/23809 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6a083c125631016302d8313488f9426710845f56 commit 6a083c125631016302d8313488f9426710845f56 Author: Martin Boye Petersen Date: Fri Sep 29 13:11:59 2017 +0200 ZCL Events Dissector: Increase number of subtrees Increase number of subtrees for PublishEventLog so we can dissect the 100 event logs that are specified as the maximum in the Great Britain Companion Specification (GBCS). Change-Id: I23b1729abd58168772e1937e1f52552fab2187a7 Reviewed-on: https://code.wireshark.org/review/23782 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e3ea990450aee7d9ef97fa8690773db196c0880b commit e3ea990450aee7d9ef97fa8690773db196c0880b Author: Stig Bj??rlykke Date: Sun Oct 1 20:15:02 2017 +0200 btle: Add preference to detect retransmission In cases with missing frames, frames with incorrect CRC or unknown direction it must be possible to turn off detecting retransmissions. Change-Id: Ia5a1194004f768986b939b4195a21c6e7a2ac4c8 Reviewed-on: https://code.wireshark.org/review/23803 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1f8e7c45e12b33619fb123aeee1bf9e238cf0304 commit 1f8e7c45e12b33619fb123aeee1bf9e238cf0304 Author: Christoph Wurm Date: Sun Sep 3 05:33:12 2017 +0000 Tshark: Prepare Elasticsearch output deduplication Refactors the ES output to use hash tables and lists in preparation of deduplicating fields. ES 5.x allows those, but will only store the last instance and discard any other without warning. ES 6.x altogether refuses to accept documents containing duplicate fields. This change should not change the output of Tshark in any way. A subsequent change will introduce the actual deduplication. Bug: 12958 Change-Id: I329ef0878e33b42d65a53bcac977429d87cde3ca Reviewed-on: https://code.wireshark.org/review/23042 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ed49b3dcfe51b8b18d8834f7fc8e0e8e3c49237f commit ed49b3dcfe51b8b18d8834f7fc8e0e8e3c49237f Author: Erik de Jong Date: Fri Sep 22 11:24:05 2017 +0200 Dissector: SolarEdge inverter monitoring protocol Adds support for the SolarEdge inverter monitoring protocol. Based on the work done by https://github.com/jbuehl/solaredge bug: 14079 Change-Id: Ia0102c057e4cd27c187b01c7fd28053678f22727 Reviewed-on: https://code.wireshark.org/review/23653 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f54d07b01977bacfde2a61d2fd5019b3a5a26537 commit f54d07b01977bacfde2a61d2fd5019b3a5a26537 Author: Darien Spencer Date: Fri Sep 29 17:58:53 2017 +0300 FP: Add heuristic FACH 1 dissector Note that FACH 1 and FACH 2 are official terms as documented in TS 25.944 Change-Id: I1afbd99d5603df442dce903ad08ba071961f0586 Reviewed-on: https://code.wireshark.org/review/23785 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4d563d8f107f388a61acde462f2ede72e6793a64 commit 4d563d8f107f388a61acde462f2ede72e6793a64 Author: Gerald Combs Date: Sun Oct 1 14:19:23 2017 -0700 Remove the SVR4 packaging assets. Remove the svr4-package and solaris-package targets along with their associated files and directories. We used to use this to build Solaris packages but we haven't shipped those in years. Given that the last substantive change to packaging/svr4 was in 2008 it's likely that this has been unused for a while. Change-Id: Ib9153c99f503200ea8c48d3ef81ad688ee55c09f Reviewed-on: https://code.wireshark.org/review/23808 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5c2a5dbdcdb21c259821a6aea70813813bb2cd21 commit 5c2a5dbdcdb21c259821a6aea70813813bb2cd21 Author: Jo??o Valverde Date: Sun Oct 1 10:47:35 2017 +0100 plugins: Improve output format And some minor code style changes. Change-Id: I97e53848db42c3981af69152b171b3a77f831da5 Reviewed-on: https://code.wireshark.org/review/23806 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=b7107bdf9d39fd267358e4d1c526112b8bc5b138 commit b7107bdf9d39fd267358e4d1c526112b8bc5b138 Author: Jo??o Valverde Date: Sun Oct 1 21:13:09 2017 +0100 CMake: Fix extcap plugin directory Fixes a338f87f33559bb9c915a97b614987736d07ff8f. Change-Id: Ib1d36a43828bd5896b327e49693485288a536342 Reviewed-on: https://code.wireshark.org/review/23805 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=90d32f83139c7e9aa66a87c37726f317ac9fcbfd commit 90d32f83139c7e9aa66a87c37726f317ac9fcbfd Author: Jo??o Valverde Date: Sun Oct 1 20:34:21 2017 +0100 Fix WiX installer Change-Id: I27af4758393c12962edab10267ae41bd2f11a07e Reviewed-on: https://code.wireshark.org/review/23804 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=6e24d5f69059dd10fd7b5752a9050b79d936a1d4 commit 6e24d5f69059dd10fd7b5752a9050b79d936a1d4 Author: Jo??o Valverde Date: Sat Sep 30 17:48:00 2017 +0100 Unsplit "m2m" plugin (wimax mac-to-mac encapsulation) ... not to be confused with "machine-to-machine". M2M seems to be a simple Wimax encapsulation protocol developed by Intel. It's not documented publicly anywhere that I can find. The boilerplate to code ratio is huge and it even includes a complete source file from the Wimax dissector (yuck). Put it in the Wimax plugin instead. Minor version number bump for wimax plugin. Change-Id: I2694339dfe89be334093b257a5b34d1577f4dc20 Reviewed-on: https://code.wireshark.org/review/23790 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e155e9159988a96a85ad1f495a7ce24473e08456 commit e155e9159988a96a85ad1f495a7ce24473e08456 Author: Martin Kaiser Date: Fri Sep 29 20:48:35 2017 +0200 stats tree: (trivial) reformat assignments a= b; looks a bit strange. Replace such assignments with a = b; Change-Id: I09534e0201906490daeb5cd35c55df00e139cf30 Reviewed-on: https://code.wireshark.org/review/23800 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9ab17810bcc334ca76e4b470f7302013dc0bd261 commit 9ab17810bcc334ca76e4b470f7302013dc0bd261 Author: Martin Kaiser Date: Fri Sep 29 20:55:23 2017 +0200 stats_tree: fix the comparison routine for COL_AVERAGE Generally, the average is calculated as node->total / node->count. The curent code does not handle the case where we compare two nodes and both have count == 0. It defines one of the nodes to be bigger. This triggers (at least on Windows) an assertion about invalid operator<. To fix this, we define average = 0 for a node with count == 0. We can then simply compare the two averages. Change-Id: Ie7d9cd590deddcdb9214c4a2693c2eb47c66b287 Reviewed-on: https://code.wireshark.org/review/23799 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d8903ce3975b57c3f4cbd24d58994a1db8c572c8 commit d8903ce3975b57c3f4cbd24d58994a1db8c572c8 Author: Martin Kaiser Date: Fri Sep 29 17:36:55 2017 +0200 simplify some include file paths For both autotools and cmake, the top-level source directory is always part of the search path for include files. For include files in this directory, we can simply use the file name. There's no need for a relative path. Change-Id: Ibf46265d91b5cb9bff4fa791e5b1d69ee3c1e165 Reviewed-on: https://code.wireshark.org/review/23798 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=be3b1291d4f3e1b2fbd6e075ffd42c60fbe4f739 commit be3b1291d4f3e1b2fbd6e075ffd42c60fbe4f739 Author: Joakim Karlsson Date: Sun Oct 1 13:31:27 2017 +0200 GTPv2: Add individual IEs to subtree array Change-Id: Ia12dae5869d5ae554d4bd1a3647738e56ed0ce2b Reviewed-on: https://code.wireshark.org/review/23801 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=797a9bf67dac1b35fa076a44ca81944875be6f1b commit 797a9bf67dac1b35fa076a44ca81944875be6f1b Author: Gerald Combs Date: Sun Oct 1 08:13:39 2017 +0000 [Automatic update for 2017-10-01] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I5ba654c9fade87decd26995b5a2d38734dcfba3b Reviewed-on: https://code.wireshark.org/review/23794 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=23e2b1f948af100c93fb52e73be0a0602d7a0b4c commit 23e2b1f948af100c93fb52e73be0a0602d7a0b4c Author: Jo??o Valverde Date: Sat Sep 30 21:18:57 2017 +0100 Fix make distcheck Change-Id: I6fc298c5c320fcdbc117ff2ec261e6fe335e178c Reviewed-on: https://code.wireshark.org/review/23792 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=cf79a87705c3b22233b252705bb3570ce357bbd4 commit cf79a87705c3b22233b252705bb3570ce357bbd4 Author: Jo??o Valverde Date: Fri Sep 29 23:31:48 2017 +0100 WiMAX: Fix possible crash during protocol registration proto_register_wimax() cannot be assumed to run before all other dissectors that depend on the global proto_wimax variable. It happens to work now but registration order is never guaranteed and cannot be relied upon. Wireshark will crash with a null pointer dereference if proto_register_wimax() is not run first. Have proto_register_wimax() call the registration routine for the other dissectors that depend on proto_wimax to impose the hard-coded order. Change-Id: I3e9a9ea742f3feeb5b802ad79cfc9ed916264d2f Reviewed-on: https://code.wireshark.org/review/23788 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=bf580c066a52ce86226f40cfb32a48a819c160f8 commit bf580c066a52ce86226f40cfb32a48a819c160f8 Author: Jo??o Valverde Date: Sat Sep 30 11:59:01 2017 +0100 Make make-dissector-reg.py pay attention to word boundaries Change-Id: Ia96c7b86994b9b5ab58735722f97e2c46cdfb54e Reviewed-on: https://code.wireshark.org/review/23787 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=73504255fb3a521fc207e960c9b34f23f898581e commit 73504255fb3a521fc207e960c9b34f23f898581e Author: Jo??o Valverde Date: Thu Sep 28 02:08:55 2017 +0100 Fix typo in make-dissector-reg.py Change-Id: Ia4c0cd07e1a0e570db440bd05877fc760aae5f54 Reviewed-on: https://code.wireshark.org/review/23786 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=6106196232d9640b233ac4b6c6faf81d39e37e52 commit 6106196232d9640b233ac4b6c6faf81d39e37e52 Author: Stig Bj??rlykke Date: Fri Sep 29 14:46:20 2017 +0200 btle: Don't ignore frames with incorrect CRC when detecting retransmission. The retrans detection using SN must use all available frames to make a best effort. The probability for having error in the SN bit is little compared to reassembly errors occuring when discarding frames with incorrect CRC. Change-Id: I40f89e69b19600939b6e0a85a2e655b6681ea5b2 Reviewed-on: https://code.wireshark.org/review/23783 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=4ef7894862769bfea39ea74ec16d42a150bc2545 commit 4ef7894862769bfea39ea74ec16d42a150bc2545 Author: Stig Bj??rlykke Date: Fri Sep 29 10:58:56 2017 +0200 btle: Improve retransmit detection Only use SN to detect retransmission. Lower retransmit expert info severity to Note. Change-Id: I4604903cce9cc58a6fcffff6597e7e99d228aa80 Reviewed-on: https://code.wireshark.org/review/23780 Petri-Dish: Stig Bj??rlykke Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=d3e34586c5e75685f9792b9104363c684fc3e174 commit d3e34586c5e75685f9792b9104363c684fc3e174 Author: Stig Bj??rlykke Date: Thu Sep 28 15:11:10 2017 +0200 btle: Ignore retransmitted frames in reassembly Change NESN/SN check to detect retransmit pr. connection. Frames with same SN in one direction is retransmit. Ignore retransmit frames when doing reassembly (btle and l2cap). Also ignore frames with incorrect CRC when doing reassembly. This fix is related to g95e09a60. Change-Id: I6386b42758ec3abada07ec1964d3e1b7ba7400e4 Reviewed-on: https://code.wireshark.org/review/23771 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fbcd64deb836e0ec21d3ca7671d6e6f8f37090eb commit fbcd64deb836e0ec21d3ca7671d6e6f8f37090eb Author: Gerald Combs Date: Thu Sep 28 15:49:17 2017 -0700 PortableApps: Don't ship development files. Exclude .exp and .lib files when we run xcopy. Change-Id: I913a1360507a8812a678efcd35d9afe58167d11b Reviewed-on: https://code.wireshark.org/review/23777 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=ec9e555456ef5217ace606bf31ded35d45bf55d3 commit ec9e555456ef5217ace606bf31ded35d45bf55d3 Author: Guy Harris Date: Thu Sep 28 12:23:12 2017 -0700 Have dissect_7bit_string() return a const gchar *. Nobody needs to modify the string, and nobody needs to free it - which is good, because it could be a string constant which can neither be modified nor freed. Change-Id: I13d4239557698e4631e8f8b062d436a2e94d5eca Reviewed-on: https://code.wireshark.org/review/23773 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris (cherry picked from commit e209b4c5274766a92b1ae3daff57bf5ca21dfc0f) Reviewed-on: https://code.wireshark.org/review/23774 (cherry picked from commit 54f1a4f285260d12d8da834637631e4020cf7786) Reviewed-on: https://code.wireshark.org/review/23776 http://cgit.osmocom.org/wireshark/commit/?id=0419deb63bdc8e5685f0bf4022ff4cf8f7acf1ff commit 0419deb63bdc8e5685f0bf4022ff4cf8f7acf1ff Author: Joakim Karlsson Date: Wed Sep 27 00:34:18 2017 +0200 radius: display in same fashion as Diameter * Change order to display AVP name/type first * Added "val=" before value * Added "vnd=" before vendor Change-Id: Iabafa6de5bc4b77dfa475cba390bc5c99da71d3f Reviewed-on: https://code.wireshark.org/review/23760 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9cb1892f387a7cfdb8fd0aee64bbe7d6842fc40d commit 9cb1892f387a7cfdb8fd0aee64bbe7d6842fc40d Author: Christoph Schlosser Date: Thu Sep 28 13:08:06 2017 +0200 epl: fix od_idx display in tree The idx value was set to the sod_index value when the previous value of idx was still needed to correctly set the text of the proto item. Change-Id: I1130678aaf5f623ab30814310ac14360d13b84b7 Reviewed-on: https://code.wireshark.org/review/23770 Reviewed-by: Christoph Schlosser Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f0e12f0fd301476378719d8268f13d53b14aaf1b commit f0e12f0fd301476378719d8268f13d53b14aaf1b Author: Jo??o Valverde Date: Tue Sep 26 21:45:16 2017 +0100 Remove TPG plugin and dependencies It doesn't build with autotools and CMake. Under-documented and unmaintained. Seems to be a work-in-progress that stalled. Introduces spurious CMake dependency on yapp. Change-Id: I0dca1ccbdfd683586c05765437d4b7804ab5cc70 Reviewed-on: https://code.wireshark.org/review/23758 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=13184fbf3a1490e2ba7c27cf34e458a77bfcc337 commit 13184fbf3a1490e2ba7c27cf34e458a77bfcc337 Author: Eugene Adell Date: Wed Sep 27 14:49:13 2017 -0700 HTTP: fix the Response Version Add a distinct field for a version in a response packet, http.response.version Bug: 14085 Change-Id: Ib255acf7fc329566869bfb82108826931368701d Reviewed-on: https://code.wireshark.org/review/23769 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b30119471711b1aa47d2509a1bec73468990eb66 commit b30119471711b1aa47d2509a1bec73468990eb66 Author: Martin Boye Petersen Date: Wed Sep 27 21:05:53 2017 +0200 ZigBee ZCL SE comments: Fixed comments and descriptions in ZCL SE. There are no functional changes. Change-Id: I19532d04d9cd428a86f04456ff402d36877be3bf Reviewed-on: https://code.wireshark.org/review/23766 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=cd90f732a1354f4615fa51c136255991f362b5bf commit cd90f732a1354f4615fa51c136255991f362b5bf Author: Gerald Combs Date: Mon Sep 11 15:11:45 2017 -0700 Improve frame.protocols accuracy. During single-pass tshark dissection we can end up adding "Protocols in frame: ...:tcp:http" to the tree even though we haven't dissected HTTP. This may be true of other protocols as well. Remove our last layer when we haven't added any items to the tree. Decrement curr_layer_num as well. Update the layer logic in dissector_try_heuristic to match call_dissector_work. Change-Id: Ibc0591e774761e9496d056080c980243a0447066 Reviewed-on: https://code.wireshark.org/review/23508 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=3d661f2fe5851cb84fd6953774bb71ee5071c597 commit 3d661f2fe5851cb84fd6953774bb71ee5071c597 Author: Pascal Quantin Date: Wed Sep 27 14:48:06 2017 +0200 GRPC: fix character check (CID 1418526) Change-Id: I998ca90149ec65529d79b294a6d00624858fc94a Reviewed-on: https://code.wireshark.org/review/23763 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=6ab87ad77d735b753c81f7ce4f82dd2de03474d8 commit 6ab87ad77d735b753c81f7ce4f82dd2de03474d8 Author: Pascal Quantin Date: Wed Sep 27 16:16:48 2017 +0200 LTE RRC: upgrade dissector to v14.4.0 Change-Id: If835450380263a012c3716cf2f2b6ee36a3201a0 Reviewed-on: https://code.wireshark.org/review/23765 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=f83587549942332ed08b51f4e7d21e03ccdcf022 commit f83587549942332ed08b51f4e7d21e03ccdcf022 Author: Pascal Quantin Date: Wed Sep 27 14:49:04 2017 +0200 GRPC: fix a control flow issue (CID 1418525) If no HTTP2 path is retrieved, we cannot really guess the direction. Let's not append it then. Change-Id: Ib06b103079cea8a82dbd45a7d4ac4d6a8e673857 Reviewed-on: https://code.wireshark.org/review/23764 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=dc527152a8d01eef5868c625d327f6291f3b09ad commit dc527152a8d01eef5868c625d327f6291f3b09ad Author: Pascal Quantin Date: Wed Sep 27 14:34:32 2017 +0200 RRC: upgrade dissector to v14.4.0 Change-Id: I49cf3e5981efe5b28eb012bab50cf55636636a38 Reviewed-on: https://code.wireshark.org/review/23762 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=492da78a2c59a134597fc732109580f857d8d50d commit 492da78a2c59a134597fc732109580f857d8d50d Author: Tom Haynes Date: Tue Sep 26 13:11:27 2017 -0700 nfsv4: Implement the xattr support for NFSv4 See: https://datatracker.ietf.org/doc/draft-ietf-nfsv4-xattrs/ Change-Id: I775eb2ec994409717f5d4ab9feb07cb4201617f1 Signed-off-by: Tom Haynes Reviewed-on: https://code.wireshark.org/review/23756 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c634f2b184f3160a879c72c79e1dd906d8ecc566 commit c634f2b184f3160a879c72c79e1dd906d8ecc566 Author: Gerald Combs Date: Tue Sep 26 14:23:51 2017 -0700 Capinfos: Add SHA256. Remove MD5. Print the SHA256, RIPEMD160, and SHA1 hashes for each file instead of SHA1, RIPEMD160, and MD5. SHA256 seems to be the preferred file hashing algorithm these days and MD5 is actively discouraged. Note that we might remove SHA1 (which is also discouraged) as well. Change-Id: I74d972ae5f3484c83175cd3f3c7a55f99c171e20 Reviewed-on: https://code.wireshark.org/review/23761 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5ecfe0c565e106960c3a13a6e835bd09f0b3e244 commit 5ecfe0c565e106960c3a13a6e835bd09f0b3e244 Author: Jakub Zawadzki Date: Tue Sep 26 23:42:20 2017 +0200 sharkd: support for frame comments. Change-Id: If51cd6a7f4989fee16563809a997dc2f46f67c22 Reviewed-on: https://code.wireshark.org/review/23759 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e8492934d6cf1f7d71b8d3cd10e5fd257f0d8fc0 commit e8492934d6cf1f7d71b8d3cd10e5fd257f0d8fc0 Author: Gerald Combs Date: Tue Sep 26 12:08:28 2017 -0700 WSUG: More tools updates. Add links to the online man page for each tool. Make sure tshark generates pre-commit-compatible output on Linux. Change-Id: I00d2973475f27460065bc8a65471abef152ded33 Reviewed-on: https://code.wireshark.org/review/23754 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f48c2cb5d46884e13c472d75556793b185d9183a commit f48c2cb5d46884e13c472d75556793b185d9183a Author: Pascal Quantin Date: Tue Sep 26 22:42:30 2017 +0200 LPP: upgrade dissector to v14.3.0 Change-Id: I0d571e277c4ec00d3da9dfabfc9cd80689763f69 Reviewed-on: https://code.wireshark.org/review/23757 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0e639797309c3bb62171d6c226c197e63b0cea59 commit 0e639797309c3bb62171d6c226c197e63b0cea59 Author: Jo??o Valverde Date: Tue Sep 26 20:43:39 2017 +0100 plugins: Move the build dir scanning code to a separate function Change-Id: Iee476ac84d530810e5b70547c462050f1c03ee1b Reviewed-on: https://code.wireshark.org/review/23755 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=9515fba1fa0d51a97abd02e0869f42bfc2201c2d commit 9515fba1fa0d51a97abd02e0869f42bfc2201c2d Author: Jo??o Valverde Date: Tue Sep 26 02:47:34 2017 +0100 Remove "easy_codec" source It's dead, unmaintained and unfinished. Not in a good enough state to live in the tree. Change-Id: I6a5c391503b5237638f8362fb9f0492c4cf36223 Reviewed-on: https://code.wireshark.org/review/23745 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=a1969dd6f608685e53c9e28992bc928f09a18849 commit a1969dd6f608685e53c9e28992bc928f09a18849 Author: Jo??o Valverde Date: Tue Sep 26 19:17:52 2017 +0100 plugins: No need to allocate a new struct Change-Id: Ic39cf1c7f199dc5e4879d954a649d21453dcc5e5 Reviewed-on: https://code.wireshark.org/review/23753 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=a269ae1b6a0a65d3e28a4c59487f7fd9b8a5685c commit a269ae1b6a0a65d3e28a4c59487f7fd9b8a5685c Author: Jo??o Valverde Date: Tue Sep 26 15:04:56 2017 +0100 Rename "ws_version_info.h", also .c It's not installed so like most other files it doesn't need or benefit from the prefix. Change-Id: I01517e06f12b3101fee21b68cba3bc6842bbef5c Reviewed-on: https://code.wireshark.org/review/23751 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=221a2bcbd0bd9fc04eacbe223f9118cabecccac1 commit 221a2bcbd0bd9fc04eacbe223f9118cabecccac1 Author: Jo??o Valverde Date: Tue Sep 26 16:28:02 2017 +0100 Move some DIAG_OFFs to make code less ugly Change-Id: I0f343ab69a6592a466e12e5d258f0878b9c32c25 Reviewed-on: https://code.wireshark.org/review/23752 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=cd6ca0da41ce2af151670486e724d47870705d44 commit cd6ca0da41ce2af151670486e724d47870705d44 Author: Bruno Verstuyft Date: Tue Sep 26 15:32:03 2017 +0200 DOCSIS: Adding Attribute masks to Service Flow Change-Id: I626b8a1d85e3062c58f9e3bd7bd6c6123c4b8272 Reviewed-on: https://code.wireshark.org/review/23749 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=85c0a7807333d379ca1e0d747b9a424daea2352e commit 85c0a7807333d379ca1e0d747b9a424daea2352e Author: Jo??o Valverde Date: Tue Sep 26 14:13:48 2017 +0100 plugins: Use g_slist_prepend() instead. Change-Id: If145137bfd44025ccab762b67960072777efd302 Reviewed-on: https://code.wireshark.org/review/23750 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=a0eb34232f909207282396ce9612078627ed358b commit a0eb34232f909207282396ce9612078627ed358b Author: Pascal Quantin Date: Tue Sep 26 13:29:43 2017 +0200 GTP: fix display of GTP Prime in frame.protocols field Bug: 14083 Change-Id: Ieabdfd2399df9136f6fd9d556ea3b96230710860 Reviewed-on: https://code.wireshark.org/review/23743 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e60319e54bcc487f9d5baded335f516cd77fa931 commit e60319e54bcc487f9d5baded335f516cd77fa931 Author: Anton Butenko Date: Tue Sep 26 12:23:29 2017 +0300 coap: Added dissection for LWM2M JSON inside CoAP protocol Change-Id: I29429f731b7e2f25568d44de455816ac70e079b6 Reviewed-on: https://code.wireshark.org/review/23740 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f2404376f807712d55e339a075d02d6f9a454a0a commit f2404376f807712d55e339a075d02d6f9a454a0a Author: Jo??o Valverde Date: Tue Sep 26 00:15:24 2017 +0100 plugins: Build the description string while loading Change-Id: Ia67133c1c9d005fc4a81b0727a7b1849571ab29c Reviewed-on: https://code.wireshark.org/review/23742 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c5c05911c62f0524c3b88086cf20dedb3d6ef769 commit c5c05911c62f0524c3b88086cf20dedb3d6ef769 Author: Huang Qiangxiong Date: Mon Jul 31 15:22:59 2017 +0000 Add GRPC dissector GRPC dissector register it self to media_type dissector table using patterns "application/grpc", "application/grpc+proto" and "application/grpc+json". GRPC stack (at least in grpc-java) can send JSON over GRPC using content-type = "application/grpc" which normally means default protobuf format. A preference is added to detect the message body, if it starts with '{', and ends with '}', will force to use JSON subdissector instead of searching in 'grpc_message_type' table. Ping-Bug: 13932 Change-Id: I910961ca06370e678d19b78cac533ca566d87628 Reviewed-on: https://code.wireshark.org/review/22891 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b89726db6d0bbadd607e8d43c0528d3e6e053531 commit b89726db6d0bbadd607e8d43c0528d3e6e053531 Author: Martin Boye Petersen Date: Mon Sep 25 22:22:35 2017 +0200 ZigBee ZCL SE Events: Dissect commands within ZCL SE Events Cluster Change-Id: I6baf02fc0a194a776fb02fc265902b0eafd710e9 Reviewed-on: https://code.wireshark.org/review/23734 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=0b76a4957de610fc065c4956094ba068c27b2ef1 commit 0b76a4957de610fc065c4956094ba068c27b2ef1 Author: Jo??o Valverde Date: Mon Sep 25 20:42:29 2017 +0100 plugins: Sort the descriptions Change-Id: I8113ba9782962856ce86475cddf40d69ed267fb4 Reviewed-on: https://code.wireshark.org/review/23733 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f022a629f1a028c368758430a07091ff02a06342 commit f022a629f1a028c368758430a07091ff02a06342 Author: Jo??o Valverde Date: Mon Sep 25 19:05:40 2017 +0100 plugins: Use hash table for book-keeping Avoid having to walk the list to check for existence on every file load. Now the binary plugin description list in About Wireshark is randomized instead of sorted by load order. We may want to change that. Add missing "const" to plugin->version. Fix an apparent trivial leak where the GModule handle was not closed on exit. Change-Id: I774215a84b080bbe889f88cc6a9b777bcf60b335 Reviewed-on: https://code.wireshark.org/review/23732 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b45a7ba7df9d2583baba37cf941cab0f66885c8a commit b45a7ba7df9d2583baba37cf941cab0f66885c8a Author: Huang Qiangxiong Date: Sun Jul 30 13:39:11 2017 +0000 HTTP2: Store all packets' header indexes in header_stream_info struct Store all packets' headers indexes of oneway stream in its header_stream_info struct. (Just store pointers refer to each HEADERS or CONTINUATION packets' header arrays) Add http2_get_header_value() function to allow other dissectors to get HTTP2 headers of this stream later in DATA frames. Ping-Bug: 13932 Change-Id: I9f623f66045845c338cd6233d4c6da3f6875fc69 Reviewed-on: https://code.wireshark.org/review/22859 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5e2c08c5d0a1c49a9f03dd3e15085433e62d24a5 commit 5e2c08c5d0a1c49a9f03dd3e15085433e62d24a5 Author: Martin Boye Petersen Date: Mon Sep 25 19:06:26 2017 +0200 ZigBee PP Dissector: Increase number of subtrees Increase number of subtrees from 10 to 30 for PublishTopUpLog and PublishDebtLog. Before the total APS size of PublishDebtLog could only be about 132 bytes. Same goes for PublishTopUpLog. Change-Id: I7e70977526de2f6d6e84af178bee91eabb132962 Reviewed-on: https://code.wireshark.org/review/23731 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=799f4f0e142675fab45fe1d00e5d0eba3c3ff8cd commit 799f4f0e142675fab45fe1d00e5d0eba3c3ff8cd Author: Gerald Combs Date: Mon Sep 25 16:18:21 2017 -0700 Editcap: Don't treat plain -F and -T as errors. The editcap man page says that you can pass in -F and -T without arguments in order to get a list of valid capture and encapsulation types. Instead of treating these as errors just print the information to stdout and return 0. Adjust the docbook _tools_help targets accordingly. Change-Id: I590cbd59059dd8965299bef4434f522eff8a4e2c Reviewed-on: https://code.wireshark.org/review/23741 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a8a3903e55af23bdce550a95ffe14a398fd1204c commit a8a3903e55af23bdce550a95ffe14a398fd1204c Author: Mikael Kanstrup Date: Mon Sep 25 23:18:31 2017 +0200 Qt: Free MainWindow at shutdown MainWindow is allocated on heap on startup but not freed on shutdown. Free the object at shutdown mainly to silent Valgrind. When at it also fix two problems with the MainWindow destructor: - Deleting main_ui_ triggers a currentChanged signal which in turn calls mainStackChanged that references the freed main_ui_ object. Prevent use after free error by disconnecting from the signal before freeing. - Explicitly free file_set_dialog_ as no rparent perform the cleanup. Bug: 14071 Change-Id: I9c1fbef04cf68bfffffea57ef298f4896d6583f9 Reviewed-on: https://code.wireshark.org/review/23739 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e2d43e7d4b352206bac6bdd42f2c8f04d1e126b2 commit e2d43e7d4b352206bac6bdd42f2c8f04d1e126b2 Author: Gerald Combs Date: Mon Sep 25 14:06:37 2017 -0700 Docbook: Automatically generate the tools help output. Add a CMake target that dumps the help output for our command line tools to individual files. Include those files in the tools appendix instead of pasting them in manually. Fixup the output of some tools so that they pass the pre-commit checks. Change-Id: I925f24818422a190927a96531c21f4d16d3fe5b5 Reviewed-on: https://code.wireshark.org/review/23737 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=f3d9766cbc83316544aae7fdd0f0f854160eafa3 commit f3d9766cbc83316544aae7fdd0f0f854160eafa3 Author: Mikael Kanstrup Date: Mon Sep 25 16:55:21 2017 +0200 Qt: Fix leaked interfaces array in Wireless frame The array of ws80211_interface:s is not freed when the wireless frame is destroyed causing minor leaks. Fix leaks by freeing the array using appropriate utility function. Bug: 14071 Change-Id: I35ec578062bfee4a4f0d0ac05a6d7613996a8822 Reviewed-on: https://code.wireshark.org/review/23738 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=a9b4f31d4a76cd3c3ffeb78581d0f5cf24b78e3b commit a9b4f31d4a76cd3c3ffeb78581d0f5cf24b78e3b Author: Pascal Quantin Date: Mon Sep 25 22:48:39 2017 +0200 NAS EPS: upgrade dissector to v14.5.0 Change-Id: I0cf79dc37804db60b50cfb87355d0537361e214f Reviewed-on: https://code.wireshark.org/review/23736 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=4efa11528ee924dbd910c20f001eb07c52ffec6d commit 4efa11528ee924dbd910c20f001eb07c52ffec6d Author: Pascal Quantin Date: Mon Sep 25 22:26:53 2017 +0200 3GPP NAS: upgrade dissector to v14.5.0 Change-Id: Ibf45c6b5930ee122004afc8d2ac84a751491f3a4 Reviewed-on: https://code.wireshark.org/review/23735 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=8615081a0910797a8dfab5ea60583f8f5da8d020 commit 8615081a0910797a8dfab5ea60583f8f5da8d020 Author: Jo??o Valverde Date: Mon Sep 25 12:51:27 2017 +0100 plugins: Fix crash loading binary module twice If a plugin is repeated we destroy the GModuleHandle in plugins_scan_dir() but we have already added the entry points to the list of registered plugins. Check for repeated plugins before adding it to the list of registered plugins, not after. Don't check for both name and version, check only for repeated names. Give the plugin callback a more descriptive name. Change-Id: I22cbbb059b8029877580fc33517310496c93e5d5 Reviewed-on: https://code.wireshark.org/review/23726 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=8b5b843fcbc3e03e0fc45f3caf8cf5fc477e8613 commit 8b5b843fcbc3e03e0fc45f3caf8cf5fc477e8613 Author: Jakub Zawadzki Date: Mon Sep 25 18:10:01 2017 +0200 udpdump: Add missing include for timeval struct. struct timeval is defined in , include it. It should fix building with musl: udpdump.c: In function 'setup_listener': udpdump.c:126:9: error: variable 'timeout' has initializer but incomplete type struct timeval timeout = { 1, 0 }; Change-Id: Id9be579e50ea2845ca609708e8ec4d1a3858ecc0 Reviewed-on: https://code.wireshark.org/review/23728 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=94af9724d140fd132896b650d10c4d060788e4f0 commit 94af9724d140fd132896b650d10c4d060788e4f0 Author: Gerald Combs Date: Mon Sep 25 09:36:38 2017 -0700 macOS: Fixup plugin signing. Use `find` to find plugins. Change-Id: I6df8877547ecbd19644a846e5cb02e8b65f19e61 Reviewed-on: https://code.wireshark.org/review/23730 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=33c00a6741b7cd31e28b7034bf25fc2f4b2ad767 commit 33c00a6741b7cd31e28b7034bf25fc2f4b2ad767 Author: Pascal Quantin Date: Mon Sep 25 17:51:05 2017 +0200 text2pcap: fix crash when there is no argument Bug: 14082 Change-Id: Ifd8b2bf9bee817967e3b00e01b8b4ae90970e984 Reviewed-on: https://code.wireshark.org/review/23727 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f64906413067f59b7bce5d149fd86b22ec392952 commit f64906413067f59b7bce5d149fd86b22ec392952 Author: Jo??o Valverde Date: Sat Sep 23 22:50:28 2017 +0100 Add toy plugin to doc/ as an out-of-tree build example Change-Id: I9b7abb27d30dbe83996a01b7f722693a974948c5 Reviewed-on: https://code.wireshark.org/review/23665 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=625bab309d9dd21db2d8ae2aa3511810d32842a8 commit 625bab309d9dd21db2d8ae2aa3511810d32842a8 Author: Pascal Quantin Date: Sat Sep 23 22:22:28 2017 +0200 Docsis: fix an infinite loop Add missing decrement of concatlen based on master-2.2 version. Bug: 14080 Change-Id: I00f7e34f8e599718316a4ce8916d91b780ec7c14 Reviewed-on: https://code.wireshark.org/review/23663 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=194d30badf547edd9f3f86f2de87322e13a0fa8a commit 194d30badf547edd9f3f86f2de87322e13a0fa8a Author: Florian Fainelli Date: Sat Sep 16 21:45:49 2017 -0700 packet-brcm-tag: Add Broadcom tag dissection Add support for dissecting the old-style Broadcom tag with Ethertype 0x8874, this was supported by switches like Broadcom BCM5325. Newer switches use a different tag format (with no Ethertype) which will be supported later. Change-Id: Iec26f8d13058399a35fb258ccadc48f7f5ac8474 Reviewed-on: https://code.wireshark.org/review/23592 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=dc011cc53ebb424ed4fd1383282d929f8688e8e1 commit dc011cc53ebb424ed4fd1383282d929f8688e8e1 Author: Guy Harris Date: Mon Sep 25 00:20:04 2017 -0700 pidl: fix field2name wireshark dissector test. Pick up change from Samba: commit 82778a6d04580fc05f3f83d44f57f221ad4e8ac4 Author: G??nther Deschner Date: Tue Sep 6 22:37:12 2016 +0200 pidl: fix field2name wireshark dissector test. Guenther Signed-off-by: Guenther Deschner Reviewed-by: Stefan Metzmacher Autobuild-User(master): G??nther Deschner Autobuild-Date(master): Wed Sep 7 16:05:26 CEST 2016 on sn-devel-144 Change-Id: Ia02de7d36b2fcb0e7a5145361548acae844f73ed Reviewed-on: https://code.wireshark.org/review/23724 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=c1a5531b71208c8270f7d969f4aebdfbfb5ad12e commit c1a5531b71208c8270f7d969f4aebdfbfb5ad12e Author: Guy Harris Date: Mon Sep 25 00:16:26 2017 -0700 pidl: Fix array range checks in python output Pick up change from Samba: commit 67040cf61232dd1cdcc820237919ac1e073c31c2 Author: Volker Lendecke Date: Tue Jun 20 15:31:18 2017 +0200 pidl: Fix array range checks in python output Without this, we generated code like if (ndr_table_dnsserver.num_calls < 0) { PyErr_SetString(PyExc_TypeError, "Internal Error, ndr_interface_call missing for py_DnssrvOperation_ndr_pack"); return NULL; } call = &ndr_table_dnsserver.calls[0]; This does not really make sense, and Coverity found comparing the unsigned num_calls against <0 a bit pointless. Should fix 138 Coverity findings and make the code a bit more correct. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Change-Id: I401e3771e6f3c1125ff847749073693af23884fc Reviewed-on: https://code.wireshark.org/review/23723 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a98d1089166cc90ebf7c82b938ae0add478b921d commit a98d1089166cc90ebf7c82b938ae0add478b921d Author: Guy Harris Date: Mon Sep 25 00:13:58 2017 -0700 python3: Use "y#" instead of "s#" for binary data in PyArg_ParseTuple Pick up change from Samba: commit 40e409bf9e89a163c771b2a58493d2c1b496fae7 Author: Petr Viktorin Date: Wed May 3 16:57:07 2017 +0200 python3: Use "y#" instead of "s#" for binary data in PyArg_ParseTuple The "s#" format code for PyArg_ParseTupleAndKeywords and Py_BuildValue converts a char* and size to/from Python str (with utf-8 encoding under Python 3). In some cases, we want bytes (str on Python 2, bytes on 3) instead. The code for this is "y#" in Python 3, but that is not available in 2. Introduce a PYARG_BYTES_LEN macro that expands to "s#" or "y#", and use that in: - credentials.get_ntlm_response (for input and output) - ndr_unpack argument in PIDL generated code Signed-off-by: Petr Viktorin Reviewed-by: Andreas Schneider Reviewed-by: Andrew Bartlett Change-Id: If4d9cdabc5016127f60682caf300f6801a360083 Reviewed-on: https://code.wireshark.org/review/23722 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=141637d327c6c7529b44e43e8530b6304b5a12ee commit 141637d327c6c7529b44e43e8530b6304b5a12ee Author: Guy Harris Date: Mon Sep 25 00:11:53 2017 -0700 pidl: Fix Coverity warnings from duplicate NULL checks. Pick up change from Samba: commit 9703464b942fdddbf7bc4380cbd26d1803f9bc00 Author: Jeremy Allison Date: Tue May 2 08:10:40 2017 -0700 pidl: Fix Coverity warnings from duplicate NULL checks. Pair-Programmed-With: Stefan Metzmacher Signed-off-by: Jeremy Allison Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Sat May 6 16:03:17 CEST 2017 on sn-devel-144 Change-Id: I25c6ae984c6a963c05f33d9a649b64f9795c7292 Reviewed-on: https://code.wireshark.org/review/23721 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=5ea8c70c05240009e2fe1f3f71636fddc0feb7eb commit 5ea8c70c05240009e2fe1f3f71636fddc0feb7eb Author: Guy Harris Date: Sun Sep 24 22:10:02 2017 -0700 python: pidl: Port Python interface generator Pick up change from Samba: commit 2de5fa45e0abfdb50f604f87e494bf334c39003a Author: Lumir Balhar Date: Mon Jan 23 21:03:17 2017 +0100 python: pidl: Port Python interface generator Port PIDL generator of Python interfaces to generate interfaces in Python 3 compatible form. Python 2.7 is now required, so we can use PyCapsule in both versions. Signed-off-by: Lumir Balhar Reviewed-by: Andrew Bartlett Reviewed-by: Douglas Bagnall Pair-programmed-by: Andrew Bartlett Change-Id: I981993e326132a1911bfbb686ca5ae033dd1df49 Reviewed-on: https://code.wireshark.org/review/23720 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=097de92cfbb5dfa6baaee8c2122ca504ac09473b commit 097de92cfbb5dfa6baaee8c2122ca504ac09473b Author: Guy Harris Date: Sun Sep 24 22:08:23 2017 -0700 pidl:Python: use of pytalloc_GenericObject_reference*() for pyrpc_{ex,im}port_union() wrapping Pick up change from Samba: commit 2170f556299c6ab4ce33f22169ca26ecad3440e3 Author: Stefan Metzmacher Date: Mon Feb 20 18:02:09 2017 +0100 pidl:Python: use of pytalloc_GenericObject_reference*() for pyrpc_{ex,im}port_union() wrapping BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Sat Feb 25 06:33:33 CET 2017 on sn-devel-144 Change-Id: I4d3cb70c79531e5faf5249b67948cc6d354c1bd0 Reviewed-on: https://code.wireshark.org/review/23719 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=4861fbe121301a3e5b519f719f3447290001cb00 commit 4861fbe121301a3e5b519f719f3447290001cb00 Author: Guy Harris Date: Sun Sep 24 22:02:41 2017 -0700 pidl:Python: replace pytalloc_CObject_FromTallocPtr() with pytalloc_GenericObject_reference_ex() Pick up change from Samba: commit 1ee0c0f8280393c708f23361ebcba0776e8b4d33 Author: Stefan Metzmacher Date: Wed Feb 22 09:07:54 2017 +0100 pidl:Python: replace pytalloc_CObject_FromTallocPtr() with pytalloc_GenericObject_reference_ex() BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett Change-Id: I19d04a1a248d35799ec41a79113fe588cd05e3de Reviewed-on: https://code.wireshark.org/review/23718 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=75f78cd49ad0ec63073764926407135732f677ce commit 75f78cd49ad0ec63073764926407135732f677ce Author: Guy Harris Date: Sun Sep 24 22:01:11 2017 -0700 BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Pick up change from Samba: commit d62eb3cc9f97b203d21ec6e75c48c739a43bc163 Author: Stefan Metzmacher Date: Wed Feb 22 10:08:46 2017 +0100 pidl:Python: make sure print HASH references for STRUCT types BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett Change-Id: Ieef766844ce66160eaaacecc73a51f94f69319fb Reviewed-on: https://code.wireshark.org/review/23717 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=5bda9bd4cb07c8b754202ce5950f9917db293222 commit 5bda9bd4cb07c8b754202ce5950f9917db293222 Author: Guy Harris Date: Sun Sep 24 21:56:47 2017 -0700 pidl:Python: add PyTypeObject objects for function structs Pick up change from Samba: commit 57539c84416aeb8fc8e3a8653f790b329e6fa9a1 Author: Stefan Metzmacher Date: Mon Sep 12 09:20:44 2016 +0200 pidl:Python: add PyTypeObject objects for function structs They provide get/set methods for the in_* and out_* elements and the magic __ndr_{push,pull,print}_{in,out}__ hooks to enable the marshalling via ndr_{push,pull,print}_{in,out}(). This provides an easy way to generate and parse the payload of DCERPC requests and responses, which is very useful for writing tests. Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I8f0e70fb771a91ba9590e2e92b5713b48313d2de Reviewed-on: https://code.wireshark.org/review/23716 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=fd81dea208b42a0aa174810e82f2d0fe24d0251e commit fd81dea208b42a0aa174810e82f2d0fe24d0251e Author: Guy Harris Date: Sun Sep 24 21:51:46 2017 -0700 pidl:Python: split out a PythonElementGetSet() helper function Pick up a change from Samba: commit a546124f10d1e2bee29bc06c0b8754257d2bdc23 Author: Stefan Metzmacher Date: Mon Sep 12 09:20:04 2016 +0200 pidl:Python: split out a PythonElementGetSet() helper function Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: Ica8b699189b69833abfa6049dd3c4e489788ce54 Reviewed-on: https://code.wireshark.org/review/23715 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1dd1a13e9f2a6c3ebd51c883bac5a8c2e1eeb4d3 commit 1dd1a13e9f2a6c3ebd51c883bac5a8c2e1eeb4d3 Author: Guy Harris Date: Sun Sep 24 21:50:25 2017 -0700 pidl:Python: the py_{import,export}_*() functions can be static now. Pick up change from Samba: commit 40175613519e7405a16e8f896dfdc2949430bc4b Author: Stefan Metzmacher Date: Tue Sep 13 01:06:18 2016 +0200 pidl:Python: the py_{import,export}_*() functions can be static now. Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I6e06c97b44a04cab36d134916eddf4c501ccc35d Reviewed-on: https://code.wireshark.org/review/23714 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=484d114b361162325405d5437be3fe6f1342932f commit 484d114b361162325405d5437be3fe6f1342932f Author: Guy Harris Date: Sun Sep 24 21:49:05 2017 -0700 pidl:Python: make use of the pyrpc_{import,export}_union() functions Pick up a change from Samba: commit f7707c04a5e039e757b288ad67a0c3cac9c6466a Author: Stefan Metzmacher Date: Mon Sep 12 16:33:38 2016 +0200 pidl:Python: make use of the pyrpc_{import,export}_union() functions This avoids the linking problems at C shared object level. Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I62c1d03b10e965552a4d598fa2370692ee0cd12a Reviewed-on: https://code.wireshark.org/review/23713 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0517a05b54b1ddbddca53291d873af39ff578d88 commit 0517a05b54b1ddbddca53291d873af39ff578d88 Author: Guy Harris Date: Sun Sep 24 21:47:37 2017 -0700 pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and __export__() hooks Pick up a change from Samba: commit e0324c0cf7e7c363a5791c2e35c8820b79640a47 Author: Stefan Metzmacher Date: Mon Sep 12 16:33:38 2016 +0200 pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and __export__() hooks These are wrappers around the currently public C functions 'py_import_*() and 'py_export_*(). In order to let other python module use these function, we should resolve the needed type object and call the __import__() or __export__() hooks instead of linking to the other shared module at C level. We already do the same for structs. Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I47813a544365085407a31d174ee180778674e42b Reviewed-on: https://code.wireshark.org/review/23712 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1373f619f9772d30d6aef104a0d7063f660195b1 commit 1373f619f9772d30d6aef104a0d7063f660195b1 Author: Guy Harris Date: Sun Sep 24 21:46:05 2017 -0700 pidl:Python: provide the abstract syntax as ._abstract_syntax Pick up change from Samba: commit 3a0ce3e41d9fdab58273c239955862b03396ea19 Author: Stefan Metzmacher Date: Sun Sep 25 00:48:29 2016 +0200 pidl:Python: provide the abstract syntax as ._abstract_syntax The .abstract_syntax alias is only kept as legacy for the first interface in a module. Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: Ie6d3d48ea3012bd328eb20e2e6693928fe24ead8 Reviewed-on: https://code.wireshark.org/review/23711 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=aff94cf8f52057b76ce57736e0f64d29e06ceecc commit aff94cf8f52057b76ce57736e0f64d29e06ceecc Author: Guy Harris Date: Sun Sep 24 21:44:27 2017 -0700 pidl:Python: prettify names of constants Pick up change from Samba: commit 1bebccaeb93f7fb7b6e2538d63223f01587ed14d Author: Stefan Metzmacher Date: Fri Sep 23 06:49:13 2016 +0200 pidl:Python: prettify names of constants Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: If9905b914c0d559bd6e7808fadbd154ae56ae2b1 Reviewed-on: https://code.wireshark.org/review/23710 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=d7311431b2c0bc82f7fb4e5815379e482d3b7a48 commit d7311431b2c0bc82f7fb4e5815379e482d3b7a48 Author: Guy Harris Date: Sun Sep 24 21:42:58 2017 -0700 pidl:Python: improve the .doc string for the get/set elements Pick up change from Samba: commit a560116aa5228885e5f52fc46fa92151357de69c Author: Stefan Metzmacher Date: Tue Sep 13 09:07:32 2016 +0200 pidl:Python: improve the .doc string for the get/set elements Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I8ecb22fd88298ecd4e350b1815d8720b493aac27 Reviewed-on: https://code.wireshark.org/review/23709 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1cbb04eaf15508df8b1aa5b38b5abb4613e827c1 commit 1cbb04eaf15508df8b1aa5b38b5abb4613e827c1 Author: Guy Harris Date: Sun Sep 24 21:41:38 2017 -0700 pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS() Pick up change from Samba: commit 47b40ac96afbd4fb28e519b9658256ecaa304e71 Author: Stefan Metzmacher Date: Mon Sep 12 15:12:24 2016 +0200 pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS() Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I550b83596fe27bad5ba4f7d91eb0ac62380f4eac Reviewed-on: https://code.wireshark.org/review/23708 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e3acb2e3ebfadddec77dd7c2cd72db83fe5de91c commit e3acb2e3ebfadddec77dd7c2cd72db83fe5de91c Author: Guy Harris Date: Sun Sep 24 21:39:47 2017 -0700 pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGS Pick up change from Samba: commit d4660e869790c7da1cb97e9d95a995e5a32b34ef Author: Stefan Metzmacher Date: Sun Sep 25 01:07:14 2016 +0200 pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGS Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: Ic0648f65b8c3f60e614361778d2c0bf72d61be35 Reviewed-on: https://code.wireshark.org/review/23707 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=856ce750606cb85427d65e67905091998e4f5976 commit 856ce750606cb85427d65e67905091998e4f5976 Author: Guy Harris Date: Sun Sep 24 21:17:03 2017 -0700 pidl:Python: check the return values of talloc_ptrtype() Pick up change from Samba: commit b728c63bcb5860aed2db43139d191bc149ceba83 Author: Stefan Metzmacher Date: Mon Sep 12 15:12:50 2016 +0200 pidl:Python: check the return values of talloc_ptrtype() Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: Icfe8837b5b998e3c5c4ea98df21cf620f53cdcd7 Reviewed-on: https://code.wireshark.org/review/23706 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=da01add6622688a682cec5d89a99f58e90f8e5fc commit da01add6622688a682cec5d89a99f58e90f8e5fc Author: Guy Harris Date: Sun Sep 24 21:12:25 2017 -0700 lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *) Pick up change from Samba: commit 306783d6f5d577a0b8bd31d659d8c802f22f0333 Author: Jeremy Allison Date: Thu Apr 20 12:24:43 2017 -0700 lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *) Not currently used - no logic changes inside. This will make it possible to pass down a long-lived talloc context from the loading function for modules to use instead of having them internally all use talloc_autofree_context() which is a hidden global. Updated all known module interface numbers, and added a WHATSNEW. Signed-off-by: Jeremy Allison Signed-off-by: Ralph B??hme Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sat Apr 22 01:17:00 CEST 2017 on sn-devel-144 Change-Id: I549e24e2e1fec12d8e7d3f3304cdac29882892a5 Reviewed-on: https://code.wireshark.org/review/23705 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=3183465351871c40176e361349fc634403e1fa06 commit 3183465351871c40176e361349fc634403e1fa06 Author: Guy Harris Date: Sun Sep 24 21:09:13 2017 -0700 s4-rpc_server: Allow each interface to declare if it uses handles Pick up change from Samba: commit ffb8b50e3c07c833fb7b1a583d21f9dc1166a0a6 Author: Andrew Bartlett Date: Mon Nov 14 11:24:03 2016 +1300 s4-rpc_server: Allow each interface to declare if it uses handles This will allow the NETLOGON server in the AD DC to declare that it does not use handles, and so allow some more flexibility with association groups Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher Change-Id: Ic09452d27493ff913f5a5c064a038e3783e91df2 Reviewed-on: https://code.wireshark.org/review/23704 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=07a21ba6f6957acf3aa2c9337367fac265f29934 commit 07a21ba6f6957acf3aa2c9337367fac265f29934 Author: Guy Harris Date: Sun Sep 24 21:07:04 2017 -0700 s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionally Pick up change from Samba: commit 31d625bcd2b0cb33dd98a37c202f5b371b871362 Author: Andrew Bartlett Date: Tue Dec 13 09:06:25 2016 +1300 s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionally The idea here is that perhaps some real client relies on this (and not just Samba torture commands), so we need a way to support it for the 4.6 release. If no such client emerges, it can be deprecated and removed in the normal way. Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher Change-Id: Id20f98ffbc5eb4752bebee455e7b2b2c0f5017e0 Reviewed-on: https://code.wireshark.org/review/23703 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=dc7a03486c888467502bdd2bd03ba4ae40348d8f commit dc7a03486c888467502bdd2bd03ba4ae40348d8f Author: Guy Harris Date: Sun Sep 24 21:05:11 2017 -0700 pidl: Make dcesrv\_$name\_interface "static const" Pick up change from Samba: commit 50dff7e094d48793b432992a28571a6f7e5cc73c Author: Andrew Bartlett Date: Mon Nov 21 11:21:50 2016 +1300 pidl: Make dcesrv\_$name\_interface "static const" This moves it out of the global namespace Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Thu Dec 8 13:25:57 CET 2016 on sn-devel-144 Change-Id: Ifa9fca377dc217b131f87cef4463624a679660f9 Reviewed-on: https://code.wireshark.org/review/23702 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a19fdccf51383c6a34eaeba674cc961bd51f6794 commit a19fdccf51383c6a34eaeba674cc961bd51f6794 Author: Guy Harris Date: Sun Sep 24 21:03:40 2017 -0700 pidl: Use a static const initialised struct in dcerpc_server_$name_init(void) Pick up change from Samba: commit 778fc58eb281e38eb1a3346b58cfdf9682f104c4 Author: Andrew Bartlett Date: Mon Nov 21 11:38:24 2016 +1300 pidl: Use a static const initialised struct in dcerpc_server_$name_init(void) Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider Reviewed-by: Garming Sam Change-Id: I5bbc8cfdd94f4c13250fc3b1cb0a61351220116c Reviewed-on: https://code.wireshark.org/review/23701 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ad0417cb78f207b26fa6a2115e86be7a01656d73 commit ad0417cb78f207b26fa6a2115e86be7a01656d73 Author: Guy Harris Date: Sun Sep 24 20:58:08 2017 -0700 libndr/compression: pass down compressed length in ndr_pull_compression_start Pick up change from Samba: commit a44bce6dfab59a6440ccc30ef0968d59b9f43fd3 Author: G??nther Deschner Date: Tue Sep 20 00:18:43 2016 +0200 libndr/compression: pass down compressed length in ndr_pull_compression_start Guenther Signed-off-by: Guenther Deschner Reviewed-by: Jeremy Allison Change-Id: I038c28cafce1248f4208119ba47f1c94ce970067 Reviewed-on: https://code.wireshark.org/review/23700 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7c56a5affbea32db0e2ee1ffd6b72acf462326de commit 7c56a5affbea32db0e2ee1ffd6b72acf462326de Author: Guy Harris Date: Sun Sep 24 20:51:44 2017 -0700 pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint() Pick up change from Samba: commit 81bbfb010599b65308aca89cc50532372ca4cb00 Author: Stefan Metzmacher Date: Mon Jun 12 18:58:49 2017 +0200 pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint() BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782 Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: Iaf4192083c49a15eaf722da1a3b55ad987bdbc82 Reviewed-on: https://code.wireshark.org/review/23699 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=8fdcc9545630a4ea87313c078e99db12da2485c0 commit 8fdcc9545630a4ea87313c078e99db12da2485c0 Author: Guy Harris Date: Sun Sep 24 20:04:54 2017 -0700 pidl:NDR/Parser: initialize [skip] values in ndr_pull_* Pick up change from Samba: commit 823bc4c07add242a5a1d0cd25942ebaab3cd0e23 Author: Stefan Metzmacher Date: Tue Jun 13 09:57:33 2017 +0200 pidl:NDR/Parser: initialize [skip] values in ndr_pull_* It's too dangerous to leave values uninitialzed! [skip_noinit] can be used if required. Signed-off-by: Stefan Metzmacher Reviewed-by: Volker Lendecke Change-Id: I85a173e21fca509fc417ff2532097fd9a220ccd9 Reviewed-on: https://code.wireshark.org/review/23698 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=67522b613000dab600d4ceaca0edc172d5723a02 commit 67522b613000dab600d4ceaca0edc172d5723a02 Author: Guy Harris Date: Sun Sep 24 20:03:07 2017 -0700 pidl:NDR/Parser: add "skip_noinit" element Pick up change from Samba: commit b922472fd683235fde3abc69ee09d9d8bfdb8644 Author: Stefan Metzmacher Date: Wed Jun 21 15:05:35 2017 +0200 pidl:NDR/Parser: add "skip_noinit" element In future "skip" will be changed to initialize the element with ZERO_STRUCT() on ndr_pull_*. Signed-off-by: Stefan Metzmacher Reviewed-by: Volker Lendecke Change-Id: I4b886c18c9eff27ae446e68fb7220e812721c4e0 Reviewed-on: https://code.wireshark.org/review/23697 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=d037bc66c11a6df6525287ce51e4e998a2478fbd commit d037bc66c11a6df6525287ce51e4e998a2478fbd Author: Guy Harris Date: Sun Sep 24 20:00:16 2017 -0700 pidl:NDR/Parser: fix "skip" for pointers Pick up change from Samba: commit 3bc6b55385894691792962ecc15978a3b158eca4 Author: Stefan Metzmacher Date: Mon Jun 19 12:15:21 2017 +0200 pidl:NDR/Parser: fix "skip" for pointers We should handle the "skip" at the element level before we traverse trough the element levels. Signed-off-by: Stefan Metzmacher Reviewed-by: Volker Lendecke Change-Id: I8b52e1ad0e0ad2c8a4fc20b94f07441b458e5638 Reviewed-on: https://code.wireshark.org/review/23696 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7bb3df70b12efb697fdcec0eaabf879120db8dfa commit 7bb3df70b12efb697fdcec0eaabf879120db8dfa Author: Guy Harris Date: Sun Sep 24 19:57:35 2017 -0700 pidl: use ndr_push_charset_to_null() when [to_null] keyword is used in IDL Pick up change from Samba: commit d30b008a642c9bb0d85519f42aef56a53e44cc77 Author: G??nther Deschner Date: Mon Jan 23 14:50:45 2017 +0100 pidl: use ndr_push_charset_to_null() when [to_null] keyword is used in IDL Guenther Signed-off-by: Guenther Deschner Reviewed-by: Stefan Metzmacher Change-Id: I26d53e3c4d0aa9fc959f2d9f0455e480c6cd45e2 Reviewed-on: https://code.wireshark.org/review/23695 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=2558728ff9b22c42db7f82d4d8c82f3cec75aa64 commit 2558728ff9b22c42db7f82d4d8c82f3cec75aa64 Author: Guy Harris Date: Sun Sep 24 19:54:34 2017 -0700 s4: COM: Remove talloc_autofree_context() from (unused) COM code. Pick up change from Samba: commit fe2ac3e304201d18ca15d388b622a4f15f72ad0a Author: Jeremy Allison Date: Mon Jul 24 12:00:21 2017 -0700 s4: COM: Remove talloc_autofree_context() from (unused) COM code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12932 Signed-off-by: Jeremy Allison Reviewed-by: Andrew Bartlett Change-Id: I44a4e3794569957c3cdf0721e78e73972ba06085 Reviewed-on: https://code.wireshark.org/review/23694 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=c73e940526f8d6724da236c51f84615bc55aeb3a commit c73e940526f8d6724da236c51f84615bc55aeb3a Author: Guy Harris Date: Sun Sep 24 19:45:41 2017 -0700 pidl: Make static struct api_struct also const Pick up change from Samba: commit c6c1463852533ed8234911835b8b1fce29b2d3d8 Author: Andrew Bartlett Date: Mon Nov 21 11:58:07 2016 +1300 pidl: Make static struct api_struct also const This moves the table to read-only memory Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider Reviewed-by: Garming Sam Change-Id: I2a7ce154dff4584c5db445cfd789a8c4f928a338 Reviewed-on: https://code.wireshark.org/review/23693 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=18d258ac46d11d584901537ac1f5e9341eff379e commit 18d258ac46d11d584901537ac1f5e9341eff379e Author: Guy Harris Date: Sun Sep 24 19:43:42 2017 -0700 pidl: Change *_get_pipe_fns() to return const struct api_struct * Pick up change from Samba: commit d368ee2298bc472caca940a3db7a4f855df6ca21 Author: Andrew Bartlett Date: Mon Nov 21 11:57:48 2016 +1300 pidl: Change *_get_pipe_fns() to return const struct api_struct * This will allow the table to be made static const in the next commit Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider Reviewed-by: Garming Sam Change-Id: Ib8cecaf695ccf70a78f97152e3286723cbc233ec Reviewed-on: https://code.wireshark.org/review/23692 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=f6d956cf92366e47470b63d366eb03ae26aa034a commit f6d956cf92366e47470b63d366eb03ae26aa034a Author: Guy Harris Date: Sun Sep 24 18:33:56 2017 -0700 pidl:NDR: add ReturnTypeElement() helper function Pick up change from Samba: commit d5e4707e98f3613acebb9d0de7e6f944f0b1efaf Author: Stefan Metzmacher Date: Tue Sep 13 09:06:50 2016 +0200 pidl:NDR: add ReturnTypeElement() helper function Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I3f4c8fb9b18ee10b031d9c58209d1c6c45bbec63 Reviewed-on: https://code.wireshark.org/review/23691 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=9ab7b538f0ccd2b1cd35689cff4c280e18a97e7d commit 9ab7b538f0ccd2b1cd35689cff4c280e18a97e7d Author: Guy Harris Date: Sun Sep 24 18:32:09 2017 -0700 pidl:NDR: keep interface->{ORIGINAL} Pick up change from Samba: commit 7423d8106ef08b94821f5fc666892234feff6f05 Author: Stefan Metzmacher Date: Tue Sep 13 07:57:25 2016 +0200 pidl:NDR: keep interface->{ORIGINAL} Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider Change-Id: I8f088a7bbbdbd756a0d28169f8ed00f99d9a8cc3 Reviewed-on: https://code.wireshark.org/review/23690 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=181d9b1d26728a75a5e999571e7cec1e28ef1d34 commit 181d9b1d26728a75a5e999571e7cec1e28ef1d34 Author: Pascal Quantin Date: Sun Sep 24 23:07:13 2017 +0200 Windows: fix NSIS and WiX installers Change-Id: I10f21de6ee9cf403690c66d02cbbd43ebb9d52bc Reviewed-on: https://code.wireshark.org/review/23689 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=1f3e36534175853a3c4849d60396bf67dd1f46ce commit 1f3e36534175853a3c4849d60396bf67dd1f46ce Author: Jo??o Valverde Date: Sun Sep 24 19:05:42 2017 +0100 GTK: Fix warning for missing action (wireshark-gtk:17990): Gtk-WARNING **: 29WestUIMStreamFlowGraph: missing action /Statistics/29West/UIM/StreamFlowGraph Change-Id: I02bd6a172390ac072485cf2158b7c5205fd11ee2 Fixes: b5759cafae8f1cf852f39fe68accd126d40955cb Reviewed-on: https://code.wireshark.org/review/23678 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=15b67769922c32bddc66c90ca4480817e757b193 commit 15b67769922c32bddc66c90ca4480817e757b193 Author: Jakub Zawadzki Date: Sun Sep 24 17:00:29 2017 +0200 sharkd: close server file descriptor in child. Change-Id: I65713f6d49fccb2045a99636d0d2f1aa5be44b83 Reviewed-on: https://code.wireshark.org/review/23677 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=7517b73e74bd3a425406e08fa0ce667a655ee049 commit 7517b73e74bd3a425406e08fa0ce667a655ee049 Author: Guy Harris Date: Sun Sep 24 13:01:49 2017 -0700 Replace DISSECTOR_ASSERT(hfinfo->type == FT_STRING) with DISSECTOR_ASSERT_FIELD_TYPE. That produces better error messages, giving the name of the offending field. Change-Id: I155ac29c68ecd7811cc9752980db9cdc37fea72e Reviewed-on: https://code.wireshark.org/review/23685 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a9963c45e79440094df221dfcb34b11ba94f0882 commit a9963c45e79440094df221dfcb34b11ba94f0882 Author: Guy Harris Date: Sun Sep 24 12:36:53 2017 -0700 Move DISSECTOR_ASSERT_FIELD_TYPE_IS_TIME after __DISSECTOR_ASSERT_FIELD_TYPE_IS_TIME(). That's consistent with the other DISSECTOR_ASSERT_FIELD_TYPE... macros. Change-Id: I1f5711b29ae8a440b0529373eb7903ff122ea18e Reviewed-on: https://code.wireshark.org/review/23681 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=bb9e8d109efb91c0af46f51846388d4487ca1690 commit bb9e8d109efb91c0af46f51846388d4487ca1690 Author: Guy Harris Date: Sun Sep 24 12:03:31 2017 -0700 Use proto_tree_add_ipv4(), not proto_tree_add_uint(), to add FT_IPV4 fields. Change-Id: I178171e03d0ab7bedfeb9f04be01de22f7c177d4 Reviewed-on: https://code.wireshark.org/review/23679 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=21f6dca753c6e562eda6dae0dd754f7b96026383 commit 21f6dca753c6e562eda6dae0dd754f7b96026383 Author: Jakub Zawadzki Date: Sun Sep 24 13:08:13 2017 +0200 sharkd: don't go to background when using stdin and stdout. Patch will allow to use stdin/stdout on other than windows platforms. Change-Id: I729ebd4efaa1675956b085e74b413805125a7d7a Reviewed-on: https://code.wireshark.org/review/23676 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=d7ec2cbc38dc12b27bae3d043ae93aafe94caf91 commit d7ec2cbc38dc12b27bae3d043ae93aafe94caf91 Author: Jo??o Valverde Date: Thu Aug 31 14:39:30 2017 +0100 autotools: Use package flags to configure libpcap Change-Id: Icd64014b597a8e60d2aff9d180c441c6ffccff26 Reviewed-on: https://code.wireshark.org/review/23329 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=69bfcbc67ece916630d212a9cc094694182df4f6 commit 69bfcbc67ece916630d212a9cc094694182df4f6 Author: Jo??o Valverde Date: Sun Sep 24 09:19:54 2017 +0100 CMake: Print build flags just before feature summary Change-Id: I79cc1df1eb04c5ed9bed722f07fdea7db2adcede Reviewed-on: https://code.wireshark.org/review/23674 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=cf4abe137661c7bd6ac5d1fd194969f2debfcaac commit cf4abe137661c7bd6ac5d1fd194969f2debfcaac Author: Jo??o Valverde Date: Sun Sep 24 09:31:12 2017 +0100 CMake: Pretty print PACKAGELIST Change-Id: Ib87e0d4111f466e660435acf871036c0f1bb1555 Reviewed-on: https://code.wireshark.org/review/23673 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=dcf52a16954719906abcaf94d8a7391ba2cfeb43 commit dcf52a16954719906abcaf94d8a7391ba2cfeb43 Author: Jo??o Valverde Date: Sat Sep 23 21:47:02 2017 +0100 Install libwiretap and libwscodecs headers Change-Id: Ie7376ac5fd8a950e3c1c744ce4701b14ee1849ea Reviewed-on: https://code.wireshark.org/review/23664 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=b44b7dee03a344822fbc38092b5e9dd6d84939bb commit b44b7dee03a344822fbc38092b5e9dd6d84939bb Author: Gerald Combs Date: Sun Sep 24 08:06:56 2017 +0000 [Automatic update for 2017-09-24] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Iad48b3a81e83cf56ccec6cfb9075169379a775f4 Reviewed-on: https://code.wireshark.org/review/23669 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=26a8b576f41ea0e00834fc0f2281732f5817f388 commit 26a8b576f41ea0e00834fc0f2281732f5817f388 Author: Alexis La Goutte Date: Sun Sep 24 08:14:03 2017 +0200 megaco: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ie85aa5806d3766c386970e8285a0755b61fca489 Reviewed-on: https://code.wireshark.org/review/23668 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=12684c7e4eb78a0ed665e09c4a7f6d9c454a932d commit 12684c7e4eb78a0ed665e09c4a7f6d9c454a932d Author: Guy Harris Date: Sat Sep 23 23:01:15 2017 -0700 Don't use proto_tree_add_uint() with FT_BYTES. Change-Id: Ic647f39824e3d18a1a8d1aaef997ccd41db445c0 Reviewed-on: https://code.wireshark.org/review/23667 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e345d19b95adf0af37949c866636cd8381451095 commit e345d19b95adf0af37949c866636cd8381451095 Author: Joakim Karlsson Date: Sat Sep 23 13:32:10 2017 +0200 GPRSCDR: decoding of PDPType Change-Id: Iec007c5276e30c982e776263ef753c002e2a9c72 Reviewed-on: https://code.wireshark.org/review/23660 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b13d5eac26db21d3b8682e861575bf5344740f99 commit b13d5eac26db21d3b8682e861575bf5344740f99 Author: Guy Harris Date: Sat Sep 23 17:35:54 2017 -0700 Don't look at the comment or process table with pre-2.2 files. NetMon apparently didn't zero out the file header, so those fields have random values in pre-2.2. Change-Id: I3aeede6ab273d57ca937a5e18e67223fb4ed18da Reviewed-on: https://code.wireshark.org/review/23666 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a065bb586e2334f5f1f1f4f0a247f309f7a04f46 commit a065bb586e2334f5f1f1f4f0a247f309f7a04f46 Author: Pascal Quantin Date: Sat Sep 23 21:56:24 2017 +0200 WebSocket: remove useless pointer checks (CID 1418346) websocket_conv is always allocated Change-Id: Ic119e22ee37703ccea2a42e53d6616faa0901cf9 Reviewed-on: https://code.wireshark.org/review/23662 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=c0fc66c67095f10a4dd4a22f3c5aaadcb7b245c2 commit c0fc66c67095f10a4dd4a22f3c5aaadcb7b245c2 Author: Pascal Quantin Date: Sat Sep 23 21:47:48 2017 +0200 PFCP: fix a typo (CID 1418345) Change-Id: If87fa31dc4933f0b54946910559b4260424848e7 Reviewed-on: https://code.wireshark.org/review/23661 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=c5403b6c1ec1c905ea0add21a25e617cd2e76a6e commit c5403b6c1ec1c905ea0add21a25e617cd2e76a6e Author: Joerg Mayer Date: Fri Sep 22 14:50:38 2017 +0200 Add lcap file extension to nsis and wix installers. Also add ntar file extention to wix installer to match nsis Change-Id: Idb6f660fda27c6ad3c3cd70acd482eafa2c14307 Reviewed-on: https://code.wireshark.org/review/23656 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: J??rg Mayer http://cgit.osmocom.org/wireshark/commit/?id=fd4dc6f115868f18e787f4bffaf8f8c5ceccff82 commit fd4dc6f115868f18e787f4bffaf8f8c5ceccff82 Author: Jo??o Valverde Date: Fri Sep 22 19:13:33 2017 +0100 plugins: Fixups for g9260461f4f Put plugins in CMake build dir with a version subdir. This avoids some weird special cases, however running with autotools from build dir displays the wrong global folder in about->folders. Unfortunately the hack to run from the autotools build dir is troublesome. Various fixes for Windows builds. Try to fix also build dir issue loading plugins on macOS with ENABLE_APPLICATION_BUNDLE (blind). Change-Id: Ic3c7c21f5850c12a53844202d61fa0592b45739c Reviewed-on: https://code.wireshark.org/review/23657 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=caa9b19107a097a64552e5fc071f4d7fd218b59e commit caa9b19107a097a64552e5fc071f4d7fd218b59e Author: Martin Boye Petersen Date: Thu Sep 21 17:04:23 2017 +0200 ZigBee ZCL SE Metering: Dissect functional notification flags and notification flags 2 to 5 Change-Id: Ia79c3e2609247846731a4b375b198702f06954de Reviewed-on: https://code.wireshark.org/review/23649 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=e7cc0279ab9a11319de521dfdf25057d1ff7ab7f commit e7cc0279ab9a11319de521dfdf25057d1ff7ab7f Author: Michael Mann Date: Fri Sep 22 21:57:50 2017 -0400 Have sequence analysis properly use filters from taps. Sequence analysis has its own "filtering" system that required its tap functions to look for some "filter flags". register_tap_listener() already comes with a filter argument, so use that to simplify logic of tap functions in dissectors. Also have Qt GUI for Flow Graph look like other dialogs that have a "Limit to display filter" checkbox. Change-Id: I91d9d9599309786892f5b50c98692e52651e7174 Reviewed-on: https://code.wireshark.org/review/23659 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3c8750dfb3b9cef1af2e29159782b443dfcd32ff commit 3c8750dfb3b9cef1af2e29159782b443dfcd32ff Author: Gerald Combs Date: Fri Sep 22 22:08:26 2017 +0000 Revert "CMake: Print a warning if CCACHE_CPP2 is unset." CCACHE_CPP2 / run_second_cpp is enabled by default in ccache 3.3 and later. (Unfortunately our builders have 3.2.4 installed.) This reverts commit ed1ecfb39cf0f3344810fabb7a1b855d373aa0a8. Change-Id: I3cc88fa70bb04db5ae254bc9b878ce379e47527d Reviewed-on: https://code.wireshark.org/review/23658 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=ed967507848f09ea4320c3bde36cf9020731793d commit ed967507848f09ea4320c3bde36cf9020731793d Author: Stig Bj??rlykke Date: Fri Sep 22 12:46:29 2017 +0200 nsis: Always create the extcap directory Change-Id: I6955c242036c3aa76be4ceb545905ffeef906518 Reviewed-on: https://code.wireshark.org/review/23654 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=b4fc86d2d5cd293c19b8c1e9db3d50e5fe0283ab commit b4fc86d2d5cd293c19b8c1e9db3d50e5fe0283ab Author: Martin Boye Petersen Date: Thu Sep 21 23:46:33 2017 +0200 ZigBee ZCL Attributes: Set length of attribute subtrees Set length of attribute subtree by setting the end after the attribute has been dissected Change-Id: Ic8bb66206658525635c08f807651a37369d16f6a Reviewed-on: https://code.wireshark.org/review/23651 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ed1ecfb39cf0f3344810fabb7a1b855d373aa0a8 commit ed1ecfb39cf0f3344810fabb7a1b855d373aa0a8 Author: Gerald Combs Date: Wed Sep 20 16:19:04 2017 -0700 CMake: Print a warning if CCACHE_CPP2 is unset. If we're compiling with clang and ccache, print a warning if CCACHE_CPP2 is unset. Doing so avoids generating a bunch of unwanted output when warnings are enabled. Change-Id: I6a796e8b910074ffa028ea45bc639b9461e1629e Reviewed-on: https://code.wireshark.org/review/23646 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5f667694d3bbd57f13c26d3588d5671dfd30d09a commit 5f667694d3bbd57f13c26d3588d5671dfd30d09a Author: Michael Mann Date: Thu Sep 21 23:20:03 2017 -0400 Add Flow Graph functionality to TShark Add flow graph functionality to tshark through -z option. Output is same as ASCII format saved from GUI. Change-Id: Iee0bfea7215858e6488b4728581be28287e9ea1a Reviewed-on: https://code.wireshark.org/review/23652 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=620d54b1e3a4fcad1994409013f6a5b2b76913b4 commit 620d54b1e3a4fcad1994409013f6a5b2b76913b4 Author: Michael Mann Date: Thu Sep 21 11:28:26 2017 -0400 Complete move of tap-sequence-analysis.c functionality to sequence_analysis.c Since dissectors are now populating the timestamp of the seq_analysis_item_t structure within the tap function, don't have the sequence_anaylsis redo it when writing an ASCII file. This removes the need for the capture_file parameter and simplifies the logic a bit. Also just have GUI register the tap itself. It will provide for some more flexibility in the future. Change-Id: I55b2f951b977ea70ac9f7eb4929245b0779e5f0e Reviewed-on: https://code.wireshark.org/review/23650 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=bd28737d7f0e4cd30f68f16ee94dcc0dfcf33ea3 commit bd28737d7f0e4cd30f68f16ee94dcc0dfcf33ea3 Author: Pascal Quantin Date: Thu Sep 21 15:40:40 2017 +0200 Diameter 3GPP: update S6a/S6d/S13/S13' AVPs Change-Id: Ief76bcd529576ccd5324efb042acc4cad7d79c9b Reviewed-on: https://code.wireshark.org/review/23648 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7ec31d06177d9c9c4356ad0403b04f4ea98db53f commit 7ec31d06177d9c9c4356ad0403b04f4ea98db53f Author: AndersBroman Date: Thu Sep 21 15:07:27 2017 +0200 [PFCP] Add more IE dissection. Change-Id: I6fa21972bf937e92a0907c3cc544239e759659f9 Reviewed-on: https://code.wireshark.org/review/23647 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=137a4456d9c7d4fba5b6aa99bf654232dbbb3d87 commit 137a4456d9c7d4fba5b6aa99bf654232dbbb3d87 Author: Stig Bj??rlykke Date: Wed Sep 20 15:11:50 2017 +0200 packetlogger: Add Syslog and Config types Change-Id: I2b023283a004c4dd80e0afb1077493612c1cecc6 Reviewed-on: https://code.wireshark.org/review/23642 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ed158952210f79dab7365e325d3c180fea26631e commit ed158952210f79dab7365e325d3c180fea26631e Author: Peter Wu Date: Sun Aug 27 14:39:50 2017 +0100 cmake: look for Qt5 from Homebrew on macOS When Qt5 is installed using Homebrew on macOS, Qt5 is not available in the default prefix. Remove the hack from macos-setup-brew.sh and adjust the search path instead. Note that is needed for development, "brew install" has already set this option in the environment. See https://github.com/Homebrew/homebrew-core/issues/8392 Change-Id: I57ea09b649a94c9a4cb18b1b2d334808e47ec27e Reviewed-on: https://code.wireshark.org/review/23232 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=e2a2618d9bbad3be872b0f7b98647fc901bcf93d commit e2a2618d9bbad3be872b0f7b98647fc901bcf93d Author: Darien Spencer Date: Fri Aug 18 10:03:06 2017 +0300 UMTS RLC: Removing unused 'is ciphered' function All calls to this function were commented out in a previous commit. Also dealing with the state of the payload (ciphred or not) should be done within the RLC dissector Change-Id: Ice3a3ca8392d73c7b67308537d7568ab71a98b5e Reviewed-on: https://code.wireshark.org/review/23644 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a8a2a8776be41563b5c063a23e39d1e9aca052a0 commit a8a2a8776be41563b5c063a23e39d1e9aca052a0 Author: Darien Spencer Date: Wed Sep 20 22:48:22 2017 +0300 FP: Removed unused code Removed old code which checked if frames are ciphered and was '#if 0'ed. Corresponding logic was implemented in the RLC dissector in a previous commit. Change-Id: Ie362771277b5c0b41e790c0297ded5ed91f813e2 Reviewed-on: https://code.wireshark.org/review/23645 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6be572006e5618aae3c59cb1b9a56cdf6e1e49a1 commit 6be572006e5618aae3c59cb1b9a56cdf6e1e49a1 Author: Jo??o Valverde Date: Tue Sep 19 12:12:31 2017 +0100 plugins: Add backward compatibility for personal lua scripts Relax requirements for upgrades and make running side-by-side installations more convenient. Change-Id: I5299eed005a4748c54465dec90f477adb577e056 Reviewed-on: https://code.wireshark.org/review/23619 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=25ba538bc50ff3a824185cca532f4e0feb4f8ec4 commit 25ba538bc50ff3a824185cca532f4e0feb4f8ec4 Author: Jo??o Valverde Date: Mon Sep 18 16:25:20 2017 +0100 plugins: Be more descriptive in "about wireshark"->"folders" Display separate entries for binary plugins and lua scripts. This is explained in the user guide, that the binary folder is a subfolder of the lua folder, but it's probably a good idea to be more explicit about it, at the risk of cluttering the interface a bit. Move GeoIP information down because it seems the least important. Add helper functions to provide plugin version subdir. Change some #ifdefs while at it for legibility. Change-Id: Ieb8665df029b3c14de19e2c973bd9b1cc4ec4621 Reviewed-on: https://code.wireshark.org/review/23609 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=f1501b82a7354de76a8d3833db2aa8fa8b9d62e0 commit f1501b82a7354de76a8d3833db2aa8fa8b9d62e0 Author: AndersBroman Date: Wed Sep 20 16:08:56 2017 +0200 [MEGACO] In dissect_megaco_eventsdescriptor() check for dm(DigitMap) not only d as it may get confused with dt(delayTime). Change-Id: Ie5ac2a117f2d9e4a231d8ee15c795b3abdc4da07 Reviewed-on: https://code.wireshark.org/review/23643 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b1395ce1f70889b07075e6d6841fe3e91474084c commit b1395ce1f70889b07075e6d6841fe3e91474084c Author: Alexis La Goutte Date: Wed Sep 20 11:46:01 2017 +0000 tibia: fix 'tibia.vip' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT32 Change-Id: Icd9171d01ba06faf2e109879de2f5685ac5964bc Reviewed-on: https://code.wireshark.org/review/23638 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a5ed8266bf6c05544a1610923c3a857b3f12997e commit a5ed8266bf6c05544a1610923c3a857b3f12997e Author: Alexis La Goutte Date: Wed Sep 20 11:54:55 2017 +0000 messageanalyzer: fix 'etw.ndis.packet_metadata.wifi_channel' exists multiple times with NOT compatible types: FT_INT32 and FT_UINT32 Change-Id: I402eb393da5a4cfd4fa19e4f3166bcf9ee058f96 Reviewed-on: https://code.wireshark.org/review/23641 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fd0e0513f03514399bd4c3634778de9b3f8051ab commit fd0e0513f03514399bd4c3634778de9b3f8051ab Author: Alexis La Goutte Date: Wed Sep 20 11:47:33 2017 +0000 PFCP: fix 'pfcp.mp' exists multiple times with NOT compatible types: FT_UINT24 and FT_BOOLEAN Change-Id: I3099da21dedec71b0ebf130420f83234300339b3 Reviewed-on: https://code.wireshark.org/review/23639 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1768cea96f233d36e3c5a2f539128f029139d872 commit 1768cea96f233d36e3c5a2f539128f029139d872 Author: Alexis La Goutte Date: Wed Sep 20 11:49:12 2017 +0000 GTPv2: fix 'gtpv2.uli_lai_flg' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT8 Change-Id: I14fbe09aad243d65da0af5ab623a1ec67eeac893 Reviewed-on: https://code.wireshark.org/review/23640 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ee4c70b92cfa0b44eed3d0d07078f943ce34c56a commit ee4c70b92cfa0b44eed3d0d07078f943ce34c56a Author: Gerald Combs Date: Thu Aug 31 23:56:25 2017 +0000 Add version.conf to git-export-release. Create and stash version.conf before archiving our repository. This makes git-export-release behave more like the current Autotools dist target. Make sure the `git describe` command in git-export-release and make-version.pl use the same match pattern and abbreviation length. Abbreviate to 8 characters. That's our current unique minimum according to the git-unique-abbrev script at https://blog.cuviper.com/2013/11/10/how-short-can-git-abbreviate/ : 516409 objects 4: 516194 / 65293 5: 200900 / 92205 6: 15979 / 7957 7: 1038 / 519 8: 74 / 37 9: 0 / 0 Change-Id: Id2279a59a2e24a9ecd816458f399bcd2b4c94185 Reviewed-on: https://code.wireshark.org/review/23344 Reviewed-by: Peter Wu Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=72415b50661c639d0f1fb7e261241da73cd4867c commit 72415b50661c639d0f1fb7e261241da73cd4867c Author: Darien Spencer Date: Wed Sep 20 09:47:54 2017 +0300 FP: Comments Fixes Consistant usage of "UE ID" Consistant usage of "reassembly" Removed unused commented code Change-Id: I9e03d439d75443f8fc0a5eb5a7ef10f6ae54e3f4 Reviewed-on: https://code.wireshark.org/review/23633 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6db17741e49b6b7d519f50449710658c54a58dbc commit 6db17741e49b6b7d519f50449710658c54a58dbc Author: Unknown Date: Wed Sep 20 08:58:54 2017 +0300 FP: Properly configure standalone PS RAB DCHs Added a check based on transport format to spot DCHs carrying a single PS RAB and configure them properly. Also renamed "special case dch 24" with it's actual meaning - a muxed CS & PS RABs Change-Id: I730b6d617d9e15bcbb5d7fde09dcd2273d943e18 Reviewed-on: https://code.wireshark.org/review/23632 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=eefec698611d7a982ce55eb7343df5e8eb0343c9 commit eefec698611d7a982ce55eb7343df5e8eb0343c9 Author: Darien Spencer Date: Fri Sep 15 18:47:32 2017 +0300 UMTS RLC: Hide deciphering preference by default Unless wireshark is compiled with a KASUMI implementation, trying to decipher RLC will always fail. Change-Id: I0d44514579fbfcd21fe8c2b74c566c54f94e4698 Reviewed-on: https://code.wireshark.org/review/23557 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e27870eaa6efa1c2dac08aa41a67fe9f0839e6e0 commit e27870eaa6efa1c2dac08aa41a67fe9f0839e6e0 Author: Pascal Quantin Date: Wed Sep 20 10:14:56 2017 +0200 RTSP: fix stack use after scope error reported by ASan Bug: 14077 Change-Id: I9fa0e62fe354b1c18687ba9041029de97719343c Reviewed-on: https://code.wireshark.org/review/23635 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=f9207b0f6c9d5aa5a1dfd7748365483795293a5d commit f9207b0f6c9d5aa5a1dfd7748365483795293a5d Author: Kevin Hogan Date: Sun Sep 3 07:07:37 2017 -0700 Qt: Restore ability to display RTT by sequence number Adds a checkbox to the TCP Stream Dialog's "Round-trip-time" graph tab that allows user to choose sequence number on the x-axis rather than time. Bug: 13740 Change-Id: Iaf881318437c7eecd16cf6c1f8745283ce9b4a7d Reviewed-on: https://code.wireshark.org/review/23376 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ded1d1089adfa969f660d0ddbb94394b27fa4b0f commit ded1d1089adfa969f660d0ddbb94394b27fa4b0f Author: Martin Kaiser Date: Wed Aug 30 23:20:21 2017 +0200 CMake: fix extcaps dependency list When compiling the list of dependencies for the extcaps target, add only those targets that we're actually building. If we skip an extcap, e.g. because we're missing libraries to build it, don't add this extcap to the dependency list. This issue was observed on a Debian box that had no libssh-gcrypt-dev package installed. Running cmake would create a warning about non-existent dependencies of the extcaps target. -- Configuring done CMake Warning (dev) at CMakeLists.txt:3217 (add_dependencies): Policy CMP0046 is not set: Error on non-existent dependency in add_dependencies. Run "cmake --help-policy CMP0046" for policy details. Use the cmake_policy command to set the policy and suppress this warning. The dependency target "ciscodump" of target "extcaps" does not exist. This warning is for project developers. Use -Wno-dev to suppress it. Change-Id: I7335173fce9833423b0e9443589143cc1a122ac0 Reviewed-on: https://code.wireshark.org/review/23321 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu Reviewed-by: Dario Lombardo Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=4458d0b59f41382783820d90b99a5687ca0ccd33 commit 4458d0b59f41382783820d90b99a5687ca0ccd33 Author: Martin Mathieson Date: Sun Sep 10 18:03:14 2017 +0100 Snort: check executable and config files exist before trying to run. Change-Id: I63986a61b392a74406ccefeaa001c110793c340a Reviewed-on: https://code.wireshark.org/review/23469 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a17bbc184170cf2faf4752f63f4dce0bba9e0dd5 commit a17bbc184170cf2faf4752f63f4dce0bba9e0dd5 Author: Mikael Kanstrup Date: Sun Sep 17 23:48:12 2017 +0200 qt: Fix some leaked menu objects Calling QPushButton.setMenu and QMenu.addMenu does not transfer ownership of the menu. Fix some leaks by letting "receiving" object act parent for the menu object. Bug: 14071 Change-Id: Id4edaf895503ef5dd4597eac99c2cdd6ad09b2ff Reviewed-on: https://code.wireshark.org/review/23600 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3ce30eb1fd395251696c4cbf42b52cfd5b150404 commit 3ce30eb1fd395251696c4cbf42b52cfd5b150404 Author: Mikael Kanstrup Date: Thu Sep 14 14:53:18 2017 +0200 Fix leaks related to recent settings Fix leaks related to recent settings reported by Valgrind simply after starting/stopping application. Bug: 14071 Change-Id: Ib4f205218945c8776724899c0dd99cc81b79a41d Reviewed-on: https://code.wireshark.org/review/23599 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8f4692f6f94d06d3fa3926333d3ffd3354066f96 commit 8f4692f6f94d06d3fa3926333d3ffd3354066f96 Author: Michael Mann Date: Tue Sep 19 17:31:11 2017 -0400 Explicitly add ICMP and ICMPv6 to Flow graph. Functionality for ICMP was "hidden" in the frame/"any" flow. Pull it out into its own using the new sequence analysis API. Change-Id: I2035f1a59a9e46ea1086443ad4b4a9723dc13883 Reviewed-on: https://code.wireshark.org/review/23625 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b5759cafae8f1cf852f39fe68accd126d40955cb commit b5759cafae8f1cf852f39fe68accd126d40955cb Author: Michael Mann Date: Tue Sep 19 21:49:55 2017 -0400 Integrate LBM UIM Flow dialog into "regular" Flow diagram. Reduce all of the code duplication and just register the sequence analysis functionality in LBM dissector. Change-Id: I6cb5a7f0a92b04357334bbae301fa2d730a21994 Reviewed-on: https://code.wireshark.org/review/23630 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8db4ddd40c6858109369156f6ae7b14c40c3b8df commit 8db4ddd40c6858109369156f6ae7b14c40c3b8df Author: Jo??o Valverde Date: Mon Sep 18 15:45:17 2017 +0100 Rename get_plugin_dir() for consistency WS_DLL_PUBLIC const char *get_plugin_dir(void); WS_DLL_PUBLIC const char *get_plugins_pers_dir(void); Opt for the plural form consistently (for public functions at least). Change-Id: I8a5861ad7f90f9c87168bd3275bd9dbc5c83b749 Reviewed-on: https://code.wireshark.org/review/23608 Petri-Dish: Jo??o Valverde Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=bbbec5552d44fde57e57f52946059182482ab987 commit bbbec5552d44fde57e57f52946059182482ab987 Author: Martin Kaiser Date: Tue Sep 19 23:16:44 2017 +0200 windows-common: remove volatile qualifier from num_aces A variable in a dissector must only be volatile if it's used inside a CATCH block. This is not the case for num_aces. Change-Id: I3aedb9ad2f8b96f56c9be2120276b552602658a1 Reviewed-on: https://code.wireshark.org/review/23624 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=70263eade4cadd157f0322d6df3dd79bfec26242 commit 70263eade4cadd157f0322d6df3dd79bfec26242 Author: Martin Kaiser Date: Tue Sep 19 23:13:34 2017 +0200 Qt: main window slots: don't connect setCaptureFile to DecodeAsDialog The refactored DecodeAsDialog class has no setCaptureFile slot any more. It seems it's always in the foreground and there's no way to change the capture file while the DecodeAsDialog is active. The dangling connection caused a warning QObject::connect: No such slot DecodeAsDialog::setCaptureFile(capture_file*) in ../ui/qt/main_window_slots.cpp:2881 QObject::connect: (sender name: 'MainWindow') QObject::connect: (receiver name: 'DecodeAsDialog') Change-Id: Ibb12b9cdded3c6b7cca40ce08874bc4f1af4eec7 Reviewed-on: https://code.wireshark.org/review/23623 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=253fcfa22182e123d4adfb54c2610e579f54a6db commit 253fcfa22182e123d4adfb54c2610e579f54a6db Author: Stig Bj??rlykke Date: Tue Sep 19 15:53:05 2017 +0200 6lowpan: Create ifcid from AT_ETHER This will reassemble source and destination addresses from Bluetooth and Bluetooth LE. Change-Id: I563ef7b411488a2ba99fe2284eca0445208cf7e1 Reviewed-on: https://code.wireshark.org/review/23618 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0d869dae1e17804b79142565e1c938339446b81e commit 0d869dae1e17804b79142565e1c938339446b81e Author: Jakub Zawadzki Date: Tue Sep 19 18:51:36 2017 +0200 Sequence (flow) analysis: fill timestamp when creating item. Change-Id: Ie1b82d016b632162a91e2ed54a964662bc25e9d5 Reviewed-on: https://code.wireshark.org/review/23620 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4930772178a779d57d694b71b5786ff4ca792c3c commit 4930772178a779d57d694b71b5786ff4ca792c3c Author: Pascal Quantin Date: Tue Sep 19 22:28:55 2017 +0200 WebSocket: check websocket_extensions pointer validity Bug: 14075 Change-Id: I825a30e5b8bfa57a020ae208a3a6ee67ee1a58d3 Reviewed-on: https://code.wireshark.org/review/23622 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=941fac1be27fa81737446bed9de0dfba526752ac commit 941fac1be27fa81737446bed9de0dfba526752ac Author: Joerg Mayer Date: Tue Sep 19 15:30:56 2017 +0400 IXIA lcap support IXIA^WKeysight Technologies's vitual IxNetwork version 8.30 will create capture files in a modified format: It uses a different magic and adds the total size of all records, i.e. the filesize minus the headersize. Add support for this. v2: Different file types use different magic numbers. Not yet tested/supported: The default fileending is .lcap Bug: 14073 Change-Id: Ida90b188ca66a78ff22dca237e4fd6b22e02dc14 Reviewed-on: https://code.wireshark.org/review/23614 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=dae91bcb9048711d788affea3a5fee02f24df275 commit dae91bcb9048711d788affea3a5fee02f24df275 Author: AndersBroman Date: Tue Sep 19 16:09:35 2017 +0200 [PFCP] Add more IE dissection. Change-Id: Ib055d43fa13aa826ce449ad93cecaab9617d75db Reviewed-on: https://code.wireshark.org/review/23617 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1783a3b7df3b5fae62b40617eda6db8368b1085f commit 1783a3b7df3b5fae62b40617eda6db8368b1085f Author: Stig Bj??rlykke Date: Tue Sep 19 15:49:06 2017 +0200 btle: Use bd_addr as link-layer address in data PDU This can be used in a higher layer 6LoWPAN to recreate the source and destination addresses. Change-Id: I967c3ac7c3a50526a10bec067521419d0aed8b4f Reviewed-on: https://code.wireshark.org/review/23616 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8615e78630e8deace183d150e2c1e5fc60d561ba commit 8615e78630e8deace183d150e2c1e5fc60d561ba Author: Jo??o Valverde Date: Fri Aug 18 20:11:47 2017 +0100 Disable flex-generated [-Wsign-compare] warnings Change-Id: Iace0462e6bb50573f3e4603f7a19e4b7ee1f9733 Reviewed-on: https://code.wireshark.org/review/23541 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=dd5875c487dea7e75b3653485d153c0dab909699 commit dd5875c487dea7e75b3653485d153c0dab909699 Author: Michael Mann Date: Mon Sep 18 22:48:11 2017 -0400 Sequence analysis (flow graph) optimizations for dissectors 1. Remove protocol member from seq_analysis_item_t. It's not used by any GUI, so don't burden dissectors with populating it. 2. Allow any dissector to change colors display by flow graph 3. Provide helper functions that may be common if other dissectors want to create sequence analysis. Change-Id: I04fa3c9f3cf6879ab9a8d7d6f4896b4979d010d7 Reviewed-on: https://code.wireshark.org/review/23613 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8a25ac7306b9eef5c7d75ee1c610eb2b0a8144fe commit 8a25ac7306b9eef5c7d75ee1c610eb2b0a8144fe Author: Mikael Kanstrup Date: Mon Sep 18 15:22:18 2017 +0200 qt: Fix leaked style for OverlayScrollBar The QWidget::setStyle method does not transfer ownership of supplied style object. Fix leak by letting OverlayScrollBar free styles created. Bug: 14071 Change-Id: Ibc14cadfc6d012e8a909be21b4f8974009fa75f5 Reviewed-on: https://code.wireshark.org/review/23601 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=16fc1903037dead72d5f6ff1457552d23b4a423f commit 16fc1903037dead72d5f6ff1457552d23b4a423f Author: Mikael Kanstrup Date: Thu Sep 14 10:19:12 2017 +0200 prefs: Fix leak when parsing empty pref string Fix minor leak. When parsing preference string lists and preference is empty a buffer is allocated to hold the string but is then never inserted into the string list as it is empty. This causes a minor leak as no reference is kept to allocated buffer and won't be freed by corresponding clear string list function call. Bug: 14071 Change-Id: I1edcc77095c0f430e03a49491e5281730fbceb95 Reviewed-on: https://code.wireshark.org/review/23598 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6bc4de9a2674f86e70bb5fdff48e861f3f5e48c5 commit 6bc4de9a2674f86e70bb5fdff48e861f3f5e48c5 Author: Stig Bj??rlykke Date: Mon Sep 18 20:24:20 2017 +0200 Qt: Add key events to accept and reject changes in FilterExpressionFrame Change-Id: Iba3fe50b3ca4953fc59ebd6235d04f6878d183a4 Reviewed-on: https://code.wireshark.org/review/23607 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f68185573703ad5457dfd8198b779bb25b8e5023 commit f68185573703ad5457dfd8198b779bb25b8e5023 Author: Stig Bj??rlykke Date: Mon Sep 18 19:56:54 2017 +0200 Qt: Fix FilterExpressionFrame layout - Use QToolButton for "Filter Buttons Preferences..." button - Remove QVBoxLayout layout for Cancel and OK buttons Change-Id: Ic5d4e96ca1c421750dc45f81a7d15f8ad637649d Reviewed-on: https://code.wireshark.org/review/23606 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=59fce46d01582e0d2ffd3a606fdd8b50c713f6a1 commit 59fce46d01582e0d2ffd3a606fdd8b50c713f6a1 Author: Stig Bj??rlykke Date: Mon Sep 18 19:20:50 2017 +0200 Qt: Add key events to accept and reject changes in PreferenceEditorFrame Change-Id: I4a9c4b80b0438cd33c38b274a24a3b1b5db46cb8 Reviewed-on: https://code.wireshark.org/review/23605 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=939ea8c8ed2b96b2959a1c9869ac5fe6237808f9 commit 939ea8c8ed2b96b2959a1c9869ac5fe6237808f9 Author: Stig Bj??rlykke Date: Sun Sep 17 19:40:44 2017 +0200 Qt: Make ColumnEditorFrame use FieldFilterEdit to get a autocomplete list Change-Id: I81d5f46d572aa3f0fa1b5b94741697fc72554d2e Reviewed-on: https://code.wireshark.org/review/23587 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=3cb95b0521222766890fdd77d3f6294c98644321 commit 3cb95b0521222766890fdd77d3f6294c98644321 Author: Stig Bj??rlykke Date: Sun Sep 17 18:57:25 2017 +0200 Qt: Add key events to accept and reject changes in ColumnEditorFrame Change-Id: I5f9ee01ee3aca5b2d75136fff3d8dc3e90ca1a4e Reviewed-on: https://code.wireshark.org/review/23585 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=adf170c23d179dcec29c86c22151ed19684f6209 commit adf170c23d179dcec29c86c22151ed19684f6209 Author: Pascal Quantin Date: Tue Sep 12 14:48:43 2017 +0200 WebSocket: add permessage-deflate extension support Bug: 14054 Change-Id: Ib6fbb58cab4d9eb140c0911391a9c330a036cfd1 Reviewed-on: https://code.wireshark.org/review/23515 Reviewed-by: Peter Wu Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e79320f2a02169569998447a59c54a9d0ef38fcb commit e79320f2a02169569998447a59c54a9d0ef38fcb Author: Stig Bj??rlykke Date: Mon Sep 18 10:05:52 2017 +0200 automake: Add -Wcomma as a warning flag. Change-Id: I93a8cefe08068f8028de01b3312f04cc05eb4f5c Reviewed-on: https://code.wireshark.org/review/23597 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=96100963afbfb4ae1f6584eb47d0e9f64eb3e432 commit 96100963afbfb4ae1f6584eb47d0e9f64eb3e432 Author: Gerald Combs Date: Mon Sep 18 15:56:25 2017 -0700 TDS: Fix some URLs and add a note about our heuristic check. Wayback-ize a couple of URLs. Note that we might be able to improve our heuristic check by checking various string lengths. (I didn't add the checks myself because I don't have any TDS captures with login packets.) Change-Id: I3d67c66a292fd02035a15e1e047227f55314737a Reviewed-on: https://code.wireshark.org/review/23612 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=b365a3e19ab7449579898a8563468a0f0301320f commit b365a3e19ab7449579898a8563468a0f0301320f Author: Jakub Zawadzki Date: Sat Sep 16 17:46:15 2017 +0200 sharkd: support flows (sequence analysis) Change-Id: Ie85295dbcfab3efe7ba05c5c9c7ae22d0c6eedec Reviewed-on: https://code.wireshark.org/review/23572 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c41bab1f667cfe51b09b80869497a2db68abecce commit c41bab1f667cfe51b09b80869497a2db68abecce Author: Jakub Zawadzki Date: Sat Sep 16 16:52:23 2017 +0200 Move most of sequence analysis code from ui/ to epan/ Create registration system to allow creation of analysis items to be localized to the dissector. For now only frame (all) and TCP are supported. VOIP functionality will be covered in a separate patch. Change-Id: I5b05ef6d5afff8d0b162b03a0f451ab810602e81 Reviewed-on: https://code.wireshark.org/review/23571 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a593fce94cb7fd0fa3f5eef7fae9c0128cb6f7e3 commit a593fce94cb7fd0fa3f5eef7fae9c0128cb6f7e3 Author: Guy Harris Date: Mon Sep 18 12:48:00 2017 -0700 Update list of symbols for Debian. Change-Id: I4ba02f37fcfbae01d43d7fdf5e5361373a2b0391 Reviewed-on: https://code.wireshark.org/review/23611 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e1933093187a9e48eb51a536110ff2b313617f70 commit e1933093187a9e48eb51a536110ff2b313617f70 Author: AndersBroman Date: Mon Sep 18 17:20:36 2017 +0200 [PFCP] Dissect more IEs. Change-Id: Ic3a32f3317af81289da0be73474f4a8882d4bf43 Reviewed-on: https://code.wireshark.org/review/23603 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=88b88a0e809029c7f74f97c22ae9ee449bf4f749 commit 88b88a0e809029c7f74f97c22ae9ee449bf4f749 Author: Jo??o Valverde Date: Sun Sep 17 19:21:01 2017 +0100 Qt: Fix -Wimplicit-fallthrough with GCC ../../../ui/qt/models/decode_as_model.cpp: In member function ???virtual QVariant DecodeAsModel::data(const QModelIndex&, int) const???: ../../../ui/qt/models/decode_as_model.cpp:155:13: error: this statement may fall through [-Werror=implicit-fallthrough=] Change-Id: I29654a0f6ce6cce7bc778231bc8d6e602875104f Reviewed-on: https://code.wireshark.org/review/23589 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0a5205b412b6b7d2a8062b3f31e10f883bd8d9aa commit 0a5205b412b6b7d2a8062b3f31e10f883bd8d9aa Author: AndersBroman Date: Wed Sep 13 17:22:05 2017 +0200 [PFCP] Add more IE dissection. Change-Id: I26a75055d0a4fee209d2d118dd9403d614739d76 Reviewed-on: https://code.wireshark.org/review/23525 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8240518f91fb0215c6e031bd8761e72dd755da5f commit 8240518f91fb0215c6e031bd8761e72dd755da5f Author: Peter Wu Date: Fri Sep 15 00:09:48 2017 +0100 TLS13: restore draft -18 support for HRR Draft 18 is still the most current boringssl version, avoid a malformed packet exception by recognizing a draft -18 HelloRetryRequest. Change-Id: I43cf91350a8a2ebfad6c1e0e35eb9621a3b3e44b Fixes: v2.3.0rc0-2789-g18c4d1bb1f ("TLS13: update HRR for draft -19") Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23544 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=aa2b59cf5e9cc4a60e839652124376e65818b885 commit aa2b59cf5e9cc4a60e839652124376e65818b885 Author: Peter Wu Date: Fri Sep 15 00:14:00 2017 +0100 TLS13: restore draft -18 support for CertificateRequest Prevent a malformed packet exception with draft -18 CertificateRequest message which would break further decryption. Tested with tls13-18-certreq.pcap from the linked bug. Change-Id: I00be21935370d0f0be66d2dbc87ee9fea3bb889a Fixes: v2.3.0rc0-2761-g0e244e01fe ("TLS13: update CertificateRequest dissection for draft -19") Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23543 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=ecb6c88c073798635b55195c2e2dd7e9cff60b20 commit ecb6c88c073798635b55195c2e2dd7e9cff60b20 Author: Stig Bj??rlykke Date: Sun Sep 17 18:52:10 2017 +0200 Qt: Improved ColumnEditorFrame validation checks Use common validation checks for fieldsNameLineEdit and occurrenceLineEdit. No need to check for COL_CUSTOM and empty occurrence because this will give a valid value anyway. Change-Id: I8981a15954e9a55a9a43e4a5760b34d83aa2e1ca Reviewed-on: https://code.wireshark.org/review/23584 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=40f737dabea1a973fc969cc1d6950c1ad2ff1ec3 commit 40f737dabea1a973fc969cc1d6950c1ad2ff1ec3 Author: Joerg Mayer Date: Sun Sep 17 04:26:31 2017 +0400 Update ldp TLVs from iana webpage (scripted). Change-Id: I1cb4210d4af93303298485c86627027adecd6052 Reviewed-on: https://code.wireshark.org/review/23578 Reviewed-by: J??rg Mayer http://cgit.osmocom.org/wireshark/commit/?id=b40ad7c2ffb3776c7002ce7b3c4aade42de319c7 commit b40ad7c2ffb3776c7002ce7b3c4aade42de319c7 Author: Peter Wu Date: Sun Sep 17 18:51:06 2017 +0100 ZigBee: fix buffer overrun in zbee_sec_add_key_to_keyring "key" is a guint8 array of ZBEE_APS_CMD_KEY_LENGTH, compare its value and not the pointer. Bug: 14070 Change-Id: I8add2bbcc04f9bbbc9502a07aa34d35b5a67e1c1 Fixes: v2.5.0rc0-1007-gf63fc33362 ("ZigBee: implemented a dissector for ZBOSS key dump") Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3408 Reviewed-on: https://code.wireshark.org/review/23588 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8dbb21dfde14221dab09b6b9c7719b9067c1f06e commit 8dbb21dfde14221dab09b6b9c7719b9067c1f06e Author: Pascal Quantin Date: Sun Sep 17 21:46:09 2017 +0200 DMP: check 7bit string length before decoding it Bug: 14068 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3372 Change-Id: Ib9ff63e2ef8d3c2546f357534c374a662e70e43c Reviewed-on: https://code.wireshark.org/review/23591 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=e77d4dffff3eb189cd9e1cbb7ee9c7561f439999 commit e77d4dffff3eb189cd9e1cbb7ee9c7561f439999 Author: Pascal Quantin Date: Sun Sep 17 21:15:08 2017 +0200 RRC: check wmem_strbuf_t pointer before using it Digit field is also ussed by other fields than PLMN-Identity and IMSI-GSM-MAP Bug: 14069 Change-Id: Ic8cf4dc148fecf24e28ef1be21c3968d46e4b456 Reviewed-on: https://code.wireshark.org/review/23590 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=17651065a57f912ebb11d731d50a2245cbeda494 commit 17651065a57f912ebb11d731d50a2245cbeda494 Author: Stig Bj??rlykke Date: Sat Sep 16 12:47:30 2017 +0200 cmake: Add option to disable -Wframe-larger-than In some editors (like Xcode) it's possible to turn on and off ASAN and UBSAN independent of the settings in CMake. This option will disable the -Wframe-larger-than= flag even if ASAN or UBSAN are not turned on in CMake. Change-Id: I70b1ae544fe87093d0f5ce7ceb191f33399191ea Reviewed-on: https://code.wireshark.org/review/23567 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=66d39cc60b59b4e8cedd8c46deb32a0ec2a35d98 commit 66d39cc60b59b4e8cedd8c46deb32a0ec2a35d98 Author: Jo??o Valverde Date: Sun Sep 17 18:04:25 2017 +0100 Add comment to docinfo.xml to note make-version.pl update Change-Id: I71e4352c94515e4edc3a7bda6851ecfd404800ef Reviewed-on: https://code.wireshark.org/review/23586 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=0bfafb3e7a41876805922d87a52307305e2bc8d0 commit 0bfafb3e7a41876805922d87a52307305e2bc8d0 Author: Jo??o Valverde Date: Mon Sep 11 02:20:03 2017 +0100 plugins: Change personal plugin dir path on Unix Installing machine code to XDG_CONFIG_HOME is problematic. Use ~/.local/lib/wireshark/plugins instead. XDG_CONFIG_HOME should be architecture independent. This allows copying the configuration between different architectures safely. Reference: https://www.freedesktop.org/software/systemd/man/file-hierarchy.html Change-Id: I1b18f64aab4dd351d611cfbea3b9333f23c98bfa Reviewed-on: https://code.wireshark.org/review/23498 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=9260461f4fcc78ed7d4ac9936508dcd57ed40e6b commit 9260461f4fcc78ed7d4ac9936508dcd57ed40e6b Author: Jo??o Valverde Date: Sun Sep 10 23:08:14 2017 +0100 plugins: Use minor version number for plugin install path Wireshark patch releases (X.Y.Z) are binary compatible so reflect that in the plugin installation path. By installing to $pkglibdir/plugins/X.Y out-of-tree plugins don't need to be reinstalled with every patch release. Change-Id: I9d1728e6fb12bcb51d2a723af22c750cb7a966cf Reviewed-on: https://code.wireshark.org/review/23497 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=978f6b4e1a94c831fa90421b6127e14f6ec9de17 commit 978f6b4e1a94c831fa90421b6127e14f6ec9de17 Author: Jo??o Valverde Date: Tue Sep 12 10:51:46 2017 +0100 plugins: Fix paths to match WSUG The Wireshark User Guide seems to say: Global lua plugins are in $pkglibdir/plugins Personal lua plugins are in XDG_CONFIG_HOME/plugins Global binary plugins are in $pkglibdir/plugins/$version Personal binary plugins are in XDG_CONFIG_HOME/plugins/$version Fix code to match that. This is a backward-incompatible change for global lua plugins and personal binary plugins. Adds a version subfolder to the personal plugin folder for binary plugins. This allows for safe upgrades and side-by-side installations with different prefixes (they no longer use the same personal dir). Change-Id: Ie0f039113628a257625a9a9fb2cb30e532f5dd47 Reviewed-on: https://code.wireshark.org/review/23516 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=e8e8b0d0b46941f79535c020f5464c372d0138a7 commit e8e8b0d0b46941f79535c020f5464c372d0138a7 Author: Gerald Combs Date: Sun Sep 17 08:07:02 2017 +0000 [Automatic update for 2017-09-17] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0b157ca377ef2e8f1a2502e51b542322dc0d36b2 Reviewed-on: https://code.wireshark.org/review/23580 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=21d2158a0bf39c08af6c5a24ef9895f819cd3af3 commit 21d2158a0bf39c08af6c5a24ef9895f819cd3af3 Author: Jo??o Valverde Date: Sun Sep 3 00:42:00 2017 +0100 CMake: Initial work to install headers for the benefit of plugins To be continued incrementally to fix gaps and omissions. If we are willing to reorganize the source tree to have one or two header include folders this could be simplified considerably. It would also force developers to give more consideration to API issues, which is a good thing. See also e7ef19efc0e928b50644b37772ccbf176e74f766. Bug: 14062 Change-Id: I0759da2f9793cfb5cf92c9e231457bba43df4353 Reviewed-on: https://code.wireshark.org/review/23548 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=6c4b9360e59eb94e3219c6c1bf9a72a1c35a674d commit 6c4b9360e59eb94e3219c6c1bf9a72a1c35a674d Author: Joerg Mayer Date: Sun Sep 17 05:11:27 2017 +0400 Fix the trivial fix. Change-Id: I95743eb53a3f30206a496163dea3b79f92a54b4e Reviewed-on: https://code.wireshark.org/review/23579 Reviewed-by: J??rg Mayer http://cgit.osmocom.org/wireshark/commit/?id=51aaffb5f680ebea44b31b911dd71694a40254fe commit 51aaffb5f680ebea44b31b911dd71694a40254fe Author: Masashi Honma Date: Sun Sep 17 08:24:20 2017 +0900 ieee802.11: Add Element ID Extension dissector framework The IEEE Std 802.11ai-2016 and 802.11-2016 defines Element ID Extensions. This patch add the dissector framework of it. Change-Id: I47b21959cc115743d6b2f0c691bc41f3059d45cd Signed-off-by: Masashi Honma Reviewed-on: https://code.wireshark.org/review/23577 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a5c79b8ec8ff147c94e17eeb131947a57f461ec7 commit a5c79b8ec8ff147c94e17eeb131947a57f461ec7 Author: Masashi Honma Date: Sun Sep 17 08:23:25 2017 +0900 ieee802.11: Add FILS authentication algorithm number The IEEE Std 802.11ai-2016 defines new algorithm number for FILS(IEEE 802.11ai) at "9.4.1.1 Authentication Algorithm Number field" section. Change-Id: I4351682d38efab2727e3a36741fe2f49508bba14 Signed-off-by: Masashi Honma Reviewed-on: https://code.wireshark.org/review/23576 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4b8504f39a07e19f40b9df1548f8400ef6ae61a8 commit 4b8504f39a07e19f40b9df1548f8400ef6ae61a8 Author: Guy Harris Date: Sat Sep 16 13:23:34 2017 -0700 Inquire what frame_size < msdu_length means. Change-Id: Ie618ed61fb098bfe55529e31e9cc3f6bfe7d4ac0 Reviewed-on: https://code.wireshark.org/review/23575 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b93ef37da21699336273e846651dd4e7c499f4dc commit b93ef37da21699336273e846651dd4e7c499f4dc Author: Joerg Mayer Date: Sat Sep 16 18:35:01 2017 +0400 _U_ is wrong in c++, as is Q_UNUSED (in most cases). The correct way is to not name the variable. interface_tree_cache_model.cpp is one of the exceptions: Use Q_UNUSED in a conditional compile, instead of unconditionally. Change-Id: If561e632a3a60d2424f454202f233e9a63926e78 Reviewed-on: https://code.wireshark.org/review/23570 Reviewed-by: J??rg Mayer http://cgit.osmocom.org/wireshark/commit/?id=be995cc12075e3ecbc3aeb2356835df8c75a220b commit be995cc12075e3ecbc3aeb2356835df8c75a220b Author: Joerg Mayer Date: Sat Sep 16 18:19:23 2017 +0400 _U_ is wrong in c++, as is Q_UNUSED (in most cases). The correct way is to not name the variable. Change-Id: Ic016f1b9161db6b4cc3f6534c853a1f50e31aa2b Reviewed-on: https://code.wireshark.org/review/23569 Reviewed-by: J??rg Mayer http://cgit.osmocom.org/wireshark/commit/?id=27b074a61580fbf0e53debf58d49f2728cffe735 commit 27b074a61580fbf0e53debf58d49f2728cffe735 Author: Jo??o Valverde Date: Fri Sep 15 15:58:21 2017 +0100 make-version.pl: Update Wireshark version in User/Developer Guides Change-Id: I5b14a6ae815e9e6e9c1705a8e38945e19dba479a Reviewed-on: https://code.wireshark.org/review/23554 Reviewed-by: Michael Mann Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=ec1a412cbd72570d0a7cd34fc68154d4368d2509 commit ec1a412cbd72570d0a7cd34fc68154d4368d2509 Author: Joakim Karlsson Date: Fri Sep 15 20:41:38 2017 +0200 GTPv2: improve APN restriction IE Change-Id: Id5fd2a0c6b09a1127ab867bf2e5bc44a0cd2acd6 Reviewed-on: https://code.wireshark.org/review/23565 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=800c179dfa4a3576e48141f9324b7abd47ef6d61 commit 800c179dfa4a3576e48141f9324b7abd47ef6d61 Author: Stig Bj??rlykke Date: Sat Sep 16 12:21:04 2017 +0200 cmake: Add -Wcomma as a warning flag. Change-Id: I90827ac2cd2277a969d25996392ad1627fc6c530 Reviewed-on: https://code.wireshark.org/review/23566 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=69250aa51eac68015e520f5680970ded2db1ee14 commit 69250aa51eac68015e520f5680970ded2db1ee14 Author: Michael Mann Date: Sun Jul 9 13:44:06 2017 -0400 Add support for dissector tables of type FT_NONE. This is for dissectors that have "payloads" that don't have a unique identifier to determine a sub dissector. For the command line parameter -d, specifying a selector is no longer required for dissector tables of type FT_NONE. Change-Id: I3370d9e0dc147deeca4f26b842fe35dc3bda876e Reviewed-on: https://code.wireshark.org/review/22574 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7d65b573f2734017be416f31852c4ede42bd987b commit 7d65b573f2734017be416f31852c4ede42bd987b Author: Michael Mann Date: Sun Jul 9 13:47:59 2017 -0400 Have register_decode_as_next_proto create dissector table. For protocols that have don't have a unique identifier for their payload, have register_decode_as_next_proto be a one stop shop to create Decode As functionality and a dissector table of type FT_NONE. Change-Id: Ic1f2e9ed0aee0554a4eb8f232630b99c0604dfc0 Reviewed-on: https://code.wireshark.org/review/22575 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d992e85fe8e9192cb730abf8796336d3b6d6fd50 commit d992e85fe8e9192cb730abf8796336d3b6d6fd50 Author: Michael Mann Date: Fri Jul 14 15:21:37 2017 -0400 Refactor Decode As dialog to use a model/delegate The model provides a lot more flexibility and abstracting the data from the view (dialog) Noticeable changes from user perspective: 1. Value column doesn't always have a combobox. If registered decode as structure doesn't support multiple values, a simple edit box is used. 2. Existing value will always be a choice (default) in the Value combobox. 3. Duplicate values in Value combobox have been removed (for things like UDP port where source port and dest. port are same) 4. When adding/copying a decode as item, only first column (table) is editable, not the whole column. 5. Separator always present in Current protocol column to distinguish "none" from rest of protocols. 6. "Current" protocol defaults to "default value" when first added to the list instead of "none". Noticeable changes from developer perspective: 1. Code is much more spread out, but most new additions (like DCE/RPC support) should be limited to the model class (maybe delegate). The dialog class probably won't change much anymore. 2. decode_as_dialog.ui is much less useful because information is provided through model and delegate. Change-Id: I70a667cab2c07d251ab370430bc51e5c1f4a3a02 Reviewed-on: https://code.wireshark.org/review/22625 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c98a7363dafdb1a261068a3e7312e66dcdf2c329 commit c98a7363dafdb1a261068a3e7312e66dcdf2c329 Author: Joakim Karlsson Date: Fri Sep 15 14:00:07 2017 +0200 gtp: add readable numbers Change-Id: I95f814d2a92d8c585db57f8ab32e6a84a8eeeb6d Reviewed-on: https://code.wireshark.org/review/23564 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=060eaaee51f4beb4605e96e5b22f8af1abe8b292 commit 060eaaee51f4beb4605e96e5b22f8af1abe8b292 Author: Joakim Karlsson Date: Fri Sep 15 13:32:30 2017 +0200 gtp: correct order of eARP Change-Id: Idc6d4d9c7f12521fa878f25ef66187fd286f017b Reviewed-on: https://code.wireshark.org/review/23563 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2a89dff8f6f7930db3b9efb5d10b103ae6fa4e66 commit 2a89dff8f6f7930db3b9efb5d10b103ae6fa4e66 Author: Joakim Karlsson Date: Fri Sep 15 13:26:49 2017 +0200 gtp: update of MS Not Reachable Reason Change-Id: I48c056ba7a532148275f6c1cea9cd3a916c70952 Reviewed-on: https://code.wireshark.org/review/23562 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7cc677e561b9e40e87f9fbeb64b443ce5f1b52e4 commit 7cc677e561b9e40e87f9fbeb64b443ce5f1b52e4 Author: Simon Barber Date: Tue Sep 12 15:35:47 2017 -0700 wireless-timeline: handle generators that report incorrect MCS for some frames Macbook and QCA generators sometimes report the minimum MCS for subframes in an aggregate that have FCS errors. Change-Id: I77d1a81f5b3d0e3d0755adcb889f1237b0257814 Reviewed-on: https://code.wireshark.org/review/23521 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=de1798aefc5233c6980ef45ec1eb027e2541a135 commit de1798aefc5233c6980ef45ec1eb027e2541a135 Author: Stig Bj??rlykke Date: Thu Sep 14 10:47:26 2017 +0200 btle: Add Bluetooth 5.0 LL Control PDUs * Dissect LL_PHY_REQ, LL_PHY_RSP, LL_PHY_UPDATE_IND and LL_MIN_USED_CHANNELS_IND. * Add Control Feature Set values. * Change Advertising Header Length from 6 bits to 8 bits (and removed RFU). * Change Data Header Length from 5 bits to 8 bits (and removed RFU). Change-Id: I453583fbb8c36dc87642c3c5087ab6dd77c46e45 Reviewed-on: https://code.wireshark.org/review/23536 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ccc5b44deaa312bf2963994d9ed25a98087c67ef commit ccc5b44deaa312bf2963994d9ed25a98087c67ef Author: Stig Bj??rlykke Date: Fri Sep 15 20:41:02 2017 +0200 wslua: Disable -Wunreachable-code in lua_bitop.c Some code is unreachable in some configurations. Change-Id: I23ff9a6032f4f7f6eb8e6607c6473a77a8bb6ac6 Reviewed-on: https://code.wireshark.org/review/23561 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=875a46d1b54da3b2dcf0deb586de7745cabfa51f commit 875a46d1b54da3b2dcf0deb586de7745cabfa51f Author: Darien Spencer Date: Sun Aug 27 22:10:48 2017 +0300 UMTS RRC: Call E.212 Dissector Calling E.212 dissector for MCC-MNC pairs/IMSIs found in RRC messages Change-Id: I1cbb4fe552323b65c761cdf7a721e8b93f297106 Reviewed-on: https://code.wireshark.org/review/23520 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=e84c2e03e47cac0682ba03323ee0d7f6ff7d7b10 commit e84c2e03e47cac0682ba03323ee0d7f6ff7d7b10 Author: Stig Bj??rlykke Date: Fri Sep 15 20:35:28 2017 +0200 wslua: Avoid possible misuse of comma operator warning Change-Id: I441359741332aa49fb91ded438cf2ec3d70b5e0f Reviewed-on: https://code.wireshark.org/review/23560 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3f8384d7797cb07f220cad998620aa2b1ee11960 commit 3f8384d7797cb07f220cad998620aa2b1ee11960 Author: Stig Bj??rlykke Date: Fri Sep 15 20:28:24 2017 +0200 epan: Fix misuse of comma operator Change-Id: I349dc9896db0bd306bc92f92eb9d4a65d98d309c Reviewed-on: https://code.wireshark.org/review/23558 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=8b11e37f81d567921faacc5302f4b87268912484 commit 8b11e37f81d567921faacc5302f4b87268912484 Author: Stig Bj??rlykke Date: Fri Sep 15 20:29:49 2017 +0200 Qt: Use Q_UNUSED macro for unused arguments Change-Id: I4bf7fe4ba3e3e6575e6537a8ec2b6024c253e776 Reviewed-on: https://code.wireshark.org/review/23559 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=619c89dbd721c39a1bff81a82d27269d93aa4145 commit 619c89dbd721c39a1bff81a82d27269d93aa4145 Author: Peter Wu Date: Fri Sep 15 00:23:38 2017 +0100 TLS13: add ticket_early_data_info extension (draft -18) Code point 46 was used for "ticket_early_data_info" in draft -18 but removed in draft -19 since it was merged into "early_data". Change-Id: Ic382c697b55424fd4eb90f9a3d59b76ac0a2dd8a Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23542 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=98d5174e1a82723bee99774294ff00e40154ad5e commit 98d5174e1a82723bee99774294ff00e40154ad5e Author: Pascal Quantin Date: Fri Sep 15 14:33:37 2017 +0200 Qt: initialize srt_data_ in constructor (CID 1417727) Change-Id: I4977ff102f1ffb11a5ea956537dde3230b4323f7 Reviewed-on: https://code.wireshark.org/review/23550 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=72355a081795a0a5d4a984ba04633da30debe9d9 commit 72355a081795a0a5d4a984ba04633da30debe9d9 Author: Stig Bj??rlykke Date: Fri Sep 15 14:49:56 2017 +0200 epan: Avoid possible misuse of comma operator warning Change-Id: I73044cd71d21b5eef2e8350cf034f7801e169c16 Reviewed-on: https://code.wireshark.org/review/23552 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=b96b145f5846c0f8e34aa6f77ab0803f73bb27c2 commit b96b145f5846c0f8e34aa6f77ab0803f73bb27c2 Author: Stig Bj??rlykke Date: Fri Sep 15 14:48:45 2017 +0200 epan: Fix misuse of comma operator Change-Id: Ie088dea1239286cb413ddcfc2a82e4a5e3fb9e0f Reviewed-on: https://code.wireshark.org/review/23551 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=7c23f56a4d08f33becca50df67c51d1d5b6793e2 commit 7c23f56a4d08f33becca50df67c51d1d5b6793e2 Author: Jakub Zawadzki Date: Fri Sep 15 07:35:59 2017 +0200 Fix compilation errors when configured --without-plugins and without lua. filesystem.c: In function ???init_plugin_pers_dir???: filesystem.c:1041:5: error: ???plugin_pers_dir??? undeclared (first use in this function) plugin_pers_dir = get_persconffile_path(PLUGINS_DIR_NAME, FALSE); ^~~~~~~~~~~~~~~ filesystem.c:1041:5: note: each undeclared identifier is reported only once for each function it appears in filesystem.c: In function ???get_plugins_pers_dir???: filesystem.c:1062:10: error: ???plugin_pers_dir??? undeclared (first use in this function) if (!plugin_pers_dir) ^~~~~~~~~~~~~~~ Change-Id: I9ace17da42665d135b9432b1f19970491589e3bf Reviewed-on: https://code.wireshark.org/review/23545 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=577671a160285b0252cb4ac85b195e902f85253c commit 577671a160285b0252cb4ac85b195e902f85253c Author: Stig Bj??rlykke Date: Fri Sep 15 14:12:16 2017 +0200 Qt: Don't show text as invalid in disabled widgets In Interface Toolbar the text widget should not be shown as invalid when the widget is disabled. Change-Id: I100a338216b34874064cb9f808a36703157811a4 Reviewed-on: https://code.wireshark.org/review/23549 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=e7ef19efc0e928b50644b37772ccbf176e74f766 commit e7ef19efc0e928b50644b37772ccbf176e74f766 Author: Jo??o Valverde Date: Sun Sep 3 00:42:00 2017 +0100 autotools: Initial work to install headers for the benefit of plugins Install public headers required to build plugins for libwireshark (taps and dissectors). The source tree is organized to serve the CLI/GUI parts of wireshark. Plugins are built in tree. This change is intende to allow plugins to be built out-of-tree but we want to avoid dumping all headers into /usr/include. To be continued incrementally to fix errors and omissions. Change-Id: Iaa0def0ba3de4b456a29114c315544d2d64fa748 Reviewed-on: https://code.wireshark.org/review/23374 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c52a702ae81b1ae7311a8b58e625f86fb211e7c5 commit c52a702ae81b1ae7311a8b58e625f86fb211e7c5 Author: Sergey Avseyev Date: Thu Sep 14 13:37:42 2017 +0300 couchbase: detect XERROR responses and dissect them as JSON Change-Id: Ia2565090f8dc30e17cd6a16614136d237577d282 Reviewed-on: https://code.wireshark.org/review/23535 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=afb9ff7982971aba6e42472de0db4c1bedfc641b commit afb9ff7982971aba6e42472de0db4c1bedfc641b Author: Pascal Quantin Date: Thu Sep 14 14:35:32 2017 +0200 MBIM: stop pre sizing wmem arrays In case of malformed packet, this can lead to an insane amount of memory. Instead let's use the automatic growth mecanism. This way the malformed packet is caught by the dissection engine. Bug: 14056 Change-Id: I7bf5b80a516210b341356f5d495f08d1dba05805 Reviewed-on: https://code.wireshark.org/review/23537 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f63fc333625480d241a1265992ab34b389dd9ed6 commit f63fc333625480d241a1265992ab34b389dd9ed6 Author: dsrsupport Date: Wed Sep 13 16:18:05 2017 +0300 ZigBee: implemented a dissector for ZBOSS key dump Implemented dissecting of ZBOSS keys dump (debug stuff) and adding a key into NWK keys ring. Move adding key to keyring from dissect_zbee_aps_transport_key into separate function. Change-Id: If0e414765350ec5131d0f815edf70cc224aef732 Reviewed-on: https://code.wireshark.org/review/23524 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=f3cf2ffd3af2b9d6315c19473bc1091bfe71b89c commit f3cf2ffd3af2b9d6315c19473bc1091bfe71b89c Author: Guy Harris Date: Wed Sep 13 22:13:59 2017 -0700 Move a test. If we're not going to subtract 4 from actual_octets, there's no reason to treat actual_octets < 4 as an error. This makes the "subtract 4 octets of crap" code similar in all cases, hopefully further reducing the opacity of the code. Change-Id: I41cda101b321422ce5fd4474fb6903bfe471cb63 Reviewed-on: https://code.wireshark.org/review/23534 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=9e905abe54bdc5a9409cd4b6f340909ae1bb3b91 commit 9e905abe54bdc5a9409cd4b6f340909ae1bb3b91 Author: Guy Harris Date: Wed Sep 13 21:58:02 2017 -0700 Replace a magic constant with an expression that represents what it is. (In the hope of making the code slightly less opaque.) Change-Id: Ic635eedac4eb9fb764b3633c9003608b9b4ae3df Reviewed-on: https://code.wireshark.org/review/23533 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1e26510a6a795402f77ba5cb94f102fe6d0000bd commit 1e26510a6a795402f77ba5cb94f102fe6d0000bd Author: Guy Harris Date: Wed Sep 13 19:29:47 2017 -0700 Fix comments. Change-Id: Ie9fe895a2763e74a5f1e25f3f1b9d63e02c0bd71 Reviewed-on: https://code.wireshark.org/review/23532 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=4f34f4296c9335ddc9bb3cc8fec69b6bb1b5a079 commit 4f34f4296c9335ddc9bb3cc8fec69b6bb1b5a079 Author: Guy Harris Date: Wed Sep 13 19:13:59 2017 -0700 Remove the 4 octets of junk even if that leaves no octets. Be consistent in the treatment of those 4 octets. Change-Id: If35c94bd299c3e7ec76306daf325d5aa5e3a19b9 Reviewed-on: https://code.wireshark.org/review/23530 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=2b0e08378f6d2633e27645f5695cdae528eb23b7 commit 2b0e08378f6d2633e27645f5695cdae528eb23b7 Author: Michael Mann Date: Wed Sep 13 21:19:38 2017 -0400 Allow distinction between bitmasked 32bit and 64bit unsigned integers in proto_tree_set_representation_value. IS_FT_UINT includes both 32 and 64 bit unsigned integers, but fvalue_get_uinteger only allows 32-bit values, so add IS_FT_UINT32 macro for distinguishing between using fvalue_get_uinteger and fvalue_get_uinteger64. All other cases that use fvalue_get_uinteger vs fvalue_get_uinteger64 are done first with switch statements and don't rely on IS_FT_UINT to distinguish between 32 and 64 bit values Bug: 14063 Change-Id: I9d1400259e7c2661c2b5ebf96aaa0e9d773651fe Reviewed-on: https://code.wireshark.org/review/23528 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=df85480630a21d840427d564e40c91b878606ba3 commit df85480630a21d840427d564e40c91b878606ba3 Author: Guy Harris Date: Wed Sep 13 17:22:49 2017 -0700 Fix builds without pcap. Change-Id: I5e327a8147ccd02e4fc689b321718b1910344b33 Reviewed-on: https://code.wireshark.org/review/23527 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=bdf10a239fcf873e1fff955f0fb6d8fd41aefcf3 commit bdf10a239fcf873e1fff955f0fb6d8fd41aefcf3 Author: Darien Spencer Date: Sat Aug 19 17:33:14 2017 +0300 UMTS RLC: Mark ciphered frames - Updated RRC dissector to always collect ciphering sequence numbers from Security Mode Command/ Security Mode Complete - Updated RLC dissector to seek the collected info when deciding if the frame is ciphered Change-Id: I44bc61736968ef9f420782048e15ba27d6c6267f Reviewed-on: https://code.wireshark.org/review/23132 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=ba957234735b9a65ff831cf9a6b0ed1a230c19ea commit ba957234735b9a65ff831cf9a6b0ed1a230c19ea Author: Pascal Quantin Date: Wed Sep 13 12:32:12 2017 +0200 PFCP: reapply gc2057c08f8 that was removed by g84272725b4 Change-Id: Ie49cd18a551dde78dbac82b67d6a6590eacfab86 Reviewed-on: https://code.wireshark.org/review/23523 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=84272725b441d49ea26f5c96e6b8b37b2831b5ea commit 84272725b441d49ea26f5c96e6b8b37b2831b5ea Author: AndersBroman Date: Wed Sep 13 09:30:48 2017 +0200 [PFCP] Dissect more IEs Change-Id: I7aa19cbb4b9f74b95b8ab0d81c262009ad77fc88 Reviewed-on: https://code.wireshark.org/review/23522 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=dafb529a389c8c60b3cbd04aba42c7b65803134e commit dafb529a389c8c60b3cbd04aba42c7b65803134e Author: AndersBroman Date: Tue Sep 12 15:34:19 2017 +0200 [Bluetooth] Update value string. Change-Id: I9b877644ff091f9f548b760211ca2e3fa2392fde Reviewed-on: https://code.wireshark.org/review/23518 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=75853200c6f6b4b16d661c9e9bd64d76ccbeafcc commit 75853200c6f6b4b16d661c9e9bd64d76ccbeafcc Author: Joerg Mayer Date: Mon Sep 11 06:56:14 2017 +0400 A number of 0 for actual_octets may just be an end of record instead of an error. Also fix some whitespace "errors". Change-Id: Ic1dc1bad6dafbbc21a87665675e654cd322178a0 Bug: 14051 Reviewed-on: https://code.wireshark.org/review/23476 Reviewed-by: J??rg Mayer http://cgit.osmocom.org/wireshark/commit/?id=a7621ca4891819c59b30c5402d390a6d52ddcf97 commit a7621ca4891819c59b30c5402d390a6d52ddcf97 Author: Pascal Quantin Date: Tue Sep 12 13:28:26 2017 +0200 windows-common: fix compilation with GCC 7.1.1 Change-Id: I27eb245b52e0a7a61dd196e8781addc59fb6b61d Reviewed-on: https://code.wireshark.org/review/23511 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b4d8b68d7c9c0e3280a204dcfca9b57e66bffddd commit b4d8b68d7c9c0e3280a204dcfca9b57e66bffddd Author: Michael Mann Date: Thu Aug 17 20:30:01 2017 -0400 Fix: Segfault when "Update list of packets in real time" is unchecked capture_file structure is not populated with "fixed" captures. Qt menu presumes it has a populated capture_file structure. Just have menu items be disabled until capture file is reloaded for display. Bug: 13024 Change-Id: I9dfb5355c5d421f5344f97e1e9d5b4dd08b11c6e Reviewed-on: https://code.wireshark.org/review/23095 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c2057c08f8ecd29faead6a99217228da421de91b commit c2057c08f8ecd29faead6a99217228da421de91b Author: Pascal Quantin Date: Tue Sep 12 13:05:25 2017 +0200 PFCP: try to fix compilation with GCC 7.1.1 Change-Id: Ic9b5601b68a5ce780a77d5d1124338fdaca6ae3c Reviewed-on: https://code.wireshark.org/review/23510 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=d141bc13c3dd3cc3dd48ff603b9f44223397b41b commit d141bc13c3dd3cc3dd48ff603b9f44223397b41b Author: AndersBroman Date: Mon Sep 11 17:57:39 2017 +0200 [PFCP] Add more IE dissection. Change-Id: Ic211a395671a932a65319118e6f37fddea1ef296 Reviewed-on: https://code.wireshark.org/review/23500 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2b8bd222b07428c1442b38779425aad44aeb5fbb commit 2b8bd222b07428c1442b38779425aad44aeb5fbb Author: Pascal Quantin Date: Tue Sep 12 09:45:29 2017 +0200 Qt: fix a segmentation fault when opening a capture using the menu entry Regression introduced in g38b40acb2d Change-Id: I48377345730eb52b03a2016407afda4bc0ff8a79 Reviewed-on: https://code.wireshark.org/review/23509 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=1f759e3b63c3d8ab5127c474cfb5a4e5ca095fc2 commit 1f759e3b63c3d8ab5127c474cfb5a4e5ca095fc2 Author: Alexis La Goutte Date: Sun Sep 10 16:04:18 2017 +0200 infinibnand: remove multi space before tvb (on proto_tree_add_item) Change-Id: Ie94127b42cb6fbd08fa17c8dcfaffff65a21aee6 Reviewed-on: https://code.wireshark.org/review/23460 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=293df7cccbc3092a1cebf8ad9b7ed289f1a7decb commit 293df7cccbc3092a1cebf8ad9b7ed289f1a7decb Author: Martin Kaiser Date: Sun Aug 13 19:12:36 2017 +0200 iso14443: reassemble APDUs from I-blocks Extract the payload from I-blocks and support reassembly of APDUs that are encapsulated in I-blocks. ISO14443 assumes that the fragments arrive in order and no fragments are missing. For now, we pass the reassembled APDU to the data dissector. Change-Id: I526f6e6d699b2a1dfc4593536154bc9b58dea96e Reviewed-on: https://code.wireshark.org/review/23506 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8c74580773e52b3de1b97c42cb425131f041b9cc commit 8c74580773e52b3de1b97c42cb425131f041b9cc Author: Joakim Karlsson Date: Sun Sep 10 15:23:26 2017 +0200 gtp: cleaner printout of IE Selection Mode Change-Id: I799efc1892448d4c4f1fad6d9f88f188a5c9be0e Reviewed-on: https://code.wireshark.org/review/23471 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=adf8236da7c7ee69c474a942d6bcc2292e045082 commit adf8236da7c7ee69c474a942d6bcc2292e045082 Author: Martin Kaiser Date: Sun Sep 10 18:28:16 2017 +0200 windows-common: don't THROW() an exception from a dissector Bring up an expert info instead of throwing an exception. Point to the item that contains the invalid offset. Exit normally, returning the number of bytes we consumed so far. Change-Id: I97826a41c6713a97404ca437b9be60c77e009918 Reviewed-on: https://code.wireshark.org/review/23507 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f5b7fcee5b89382c9fa12d6545a249bc95da80d5 commit f5b7fcee5b89382c9fa12d6545a249bc95da80d5 Author: Gerald Combs Date: Mon Sep 11 10:54:09 2017 -0700 Qt: SequenceDialog no longer emits goToPacket. SequenceDialog no longer emits goToPacket as of g7fe45cc0ec. Don't try to connect it in MainWindow. Change-Id: I0f3e47a3cf7c1e29a64da7462c85179e29828c49 Reviewed-on: https://code.wireshark.org/review/23501 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=d6dff9bc96c59be8ad81d1659c2da2f0e4d33c2d commit d6dff9bc96c59be8ad81d1659c2da2f0e4d33c2d Author: Pascal Quantin Date: Mon Sep 11 17:45:52 2017 +0200 reordercap: initialize command-line argument errors functions Bug: 14055 Change-Id: I76959d97c45fb92473825b4a1ba708b0094d400a Reviewed-on: https://code.wireshark.org/review/23499 Petri-Dish: Pascal Quantin Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=83aabe5500fda8fda8a5eb09982361f0df860e6f commit 83aabe5500fda8fda8a5eb09982361f0df860e6f Author: Jo??o Valverde Date: Mon Sep 11 15:14:01 2017 +0100 CMake: Fix RPATH after ga338f87f33 GNUInstallDirs uses lib64 on x86_64. Change-Id: I4e124a6b501bf2166e7270abbff53d52c9115f45 Reviewed-on: https://code.wireshark.org/review/23496 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c4528780732825267d2eebac4827625f39e33e5d commit c4528780732825267d2eebac4827625f39e33e5d Author: Alexis La Goutte Date: Mon Sep 11 14:02:18 2017 +0000 gtpv2(.h): fix redundant redeclaration of ???dissect_gtpv2_arp??? [-Wredundant-decls] Change-Id: Ib2b3e2116ea806c8198b99a2d5e992b24907b684 Reviewed-on: https://code.wireshark.org/review/23491 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Petri-Dish: Gerald Combs Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=7c258eedea0786e2dfccfc4002e3de599bf29413 commit 7c258eedea0786e2dfccfc4002e3de599bf29413 Author: Jo??o Valverde Date: Mon Sep 11 11:46:16 2017 +0100 WSUG: Fix global plugin installation path Change-Id: I28a1259ab30b7b86989f307d89461c26aec878da Reviewed-on: https://code.wireshark.org/review/23493 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=69f0cb0cef3e8cc6b49073768f76ff1046ded8b5 commit 69f0cb0cef3e8cc6b49073768f76ff1046ded8b5 Author: Jo??o Valverde Date: Sun Sep 10 23:38:36 2017 +0100 wsutil: Initialize and store plugin personal dir Obviate allocation on every call to get_plugins_pers_dir(). Change-Id: I089ae499f93739d490d4552f59b5db5996f7d26f Reviewed-on: https://code.wireshark.org/review/23495 Petri-Dish: Jo??o Valverde Reviewed-by: Michael Mann Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=e7aa63746ba630d88032394f4869fca2c87853a8 commit e7aa63746ba630d88032394f4869fca2c87853a8 Author: Michael Mann Date: Mon Sep 11 09:28:42 2017 -0400 packet-zep.c: zep.lqi_mode is FT_BOOLEAN, not a FT_UINT, so use proto_tree_add_item_ret_boolean Change-Id: I7926baf5e0b7d50ca6ab5c3c1af5fba7e906202d Reviewed-on: https://code.wireshark.org/review/23492 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=766a3a0332c1d7eec08eadb8bbcc8911bdea6421 commit 766a3a0332c1d7eec08eadb8bbcc8911bdea6421 Author: Krishnamurthy Mayya Date: Mon Sep 11 06:43:17 2017 -0700 Bundle Age Extension Block: Type-20 decoding changes Bug: 14053 Change-Id: I47f38c6b0b4517792b03236c1ee3f2fdc14fb07c Reviewed-on: https://code.wireshark.org/review/23490 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=09b3af8f91324c7e3f86884c791acdcffc505cf9 commit 09b3af8f91324c7e3f86884c791acdcffc505cf9 Author: AndersBroman Date: Mon Sep 11 13:47:30 2017 +0200 [SCTP] Update SCTP Payload Protocol Identifiers from IANA registry. Change-Id: I72652e5654b9cd6464f8b07f48093a4ea30ebf7d Reviewed-on: https://code.wireshark.org/review/23489 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=36018de81a83bad289e202c7847ae2e89fcb0259 commit 36018de81a83bad289e202c7847ae2e89fcb0259 Author: AndersBroman Date: Mon Sep 11 12:34:20 2017 +0200 [GPRSCDR] Fix display of iPBinV4Address and iPBinV6Address as IPAddr. Change-Id: Idccc291916597fbc97b8adab4f5f32f3af1a9cc3 Reviewed-on: https://code.wireshark.org/review/23488 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9bc8307867939078583818a2af2f0fe341e8820c commit 9bc8307867939078583818a2af2f0fe341e8820c Author: Michael Mann Date: Sat Sep 9 19:50:52 2017 -0400 Remove the OUIs in manuf.tmpl that cause obvious conflicts with IEEE list This allows for less "skipping" when processing the list Bug: 13784 Change-Id: I40fb5d5a82e51238751dd6785502ea259de9bc03 Reviewed-on: https://code.wireshark.org/review/23445 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4a56c6a728f1452891498402564662e0ef239176 commit 4a56c6a728f1452891498402564662e0ef239176 Author: AndersBroman Date: Mon Sep 11 09:26:21 2017 +0200 [PFCP] More IEs dissected. Change-Id: If51b5b3b935fe2f36c69bb98f0ee24cf8a1c0e5c Reviewed-on: https://code.wireshark.org/review/23477 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3689dc1db36037436b1616715f9a3f888fc9a0f6 commit 3689dc1db36037436b1616715f9a3f888fc9a0f6 Author: Pascal Quantin Date: Sun Sep 10 19:20:30 2017 +0200 BTATT: add curr_layer_num to key tracking request / response Otherwise in case of frames containing multiple BTATT packets at different levels of encapsulation, we can retrieve the wrong structure and start using the union with a wrong opcode based type Bug: 14049 Change-Id: Ica5d8af8e84161d6f9daebbb90334f20082c5fa4 Reviewed-on: https://code.wireshark.org/review/23470 Petri-Dish: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1d3ca5ad41fc3a725442439464f9ead944b21779 commit 1d3ca5ad41fc3a725442439464f9ead944b21779 Author: Peter Wu Date: Mon Sep 11 00:59:37 2017 +0100 TLS13: add new Signature Algorithms Add support for dissecting new TLS 1.3 Signature Algorithms (like RSASSA-PSS) and add the text to the tree item to prevent expanding the item. The field names are preserved for backwards compatibility. Change-Id: Ieb8c7a86f6e19b8d6c89590d87d59a01d9bb1351 Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23474 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=845835b8dba71bb248238dcb8ae18d59e4e543f0 commit 845835b8dba71bb248238dcb8ae18d59e4e543f0 Author: Pascal Quantin Date: Sun Sep 10 15:20:56 2017 +0200 srt_table.c: free table dynamic memory when calling free_srt_table() Change-Id: I21c259aa0649bcfac5e345f4e41ad1beea0446c1 Reviewed-on: https://code.wireshark.org/review/23455 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=18de993b7c29ad2d3840ff4b1b02f132c23c4777 commit 18de993b7c29ad2d3840ff4b1b02f132c23c4777 Author: Pascal Quantin Date: Sun Sep 10 00:21:03 2017 +0200 Qt: free SRT table once the tree is filled Change-Id: Ic1c55852399190f3a3c5b5bf90cf6d90517b247f Reviewed-on: https://code.wireshark.org/review/23444 Petri-Dish: Pascal Quantin Reviewed-by: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=02b20a5a699a557ab0696ebb024b6a3b1d39c41e commit 02b20a5a699a557ab0696ebb024b6a3b1d39c41e Author: Pascal Quantin Date: Sat Sep 9 22:49:45 2017 +0200 Qt: fix Diameter SRT statistics display Diameter dynamically create the SRT entries during runtime. Delay the SRT table addition to the end of dissection to properly handle this use case. Bug: 13442 Change-Id: Id498f8d9bb4a1d7c632c9a556239bf74d0530f2a Reviewed-on: https://code.wireshark.org/review/23443 Petri-Dish: Alexis La Goutte Reviewed-by: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=06584b7a43101dca05f5a3040dbb26898a6c812f commit 06584b7a43101dca05f5a3040dbb26898a6c812f Author: Guy Harris Date: Sun Sep 10 18:28:37 2017 -0700 Sort the Ethertypes. Change-Id: I7793e152da225965817844b727880a26e64051d3 Reviewed-on: https://code.wireshark.org/review/23475 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=38b40acb2dc2567d3ddda35f4ed7d6523a9a9bd0 commit 38b40acb2dc2567d3ddda35f4ed7d6523a9a9bd0 Author: Pascal Quantin Date: Sun Sep 10 19:56:24 2017 +0200 Qt: fix a memory leak when exporting packets Change-Id: I3c99ca838b3def4437ba92794881630b8cdd8cbd Reviewed-on: https://code.wireshark.org/review/23472 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=55dcb6455872a40c0f36a6bb198428baf1d31afe commit 55dcb6455872a40c0f36a6bb198428baf1d31afe Author: Alexis La Goutte Date: Sun Sep 10 16:00:42 2017 +0200 infiniband: always return line for offset Change-Id: I34d631ac913620dbc661b9d56d4e34502c9b7d35 Reviewed-on: https://code.wireshark.org/review/23459 Petri-Dish: Michael Mann Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5f5a898541a541f5230831fcef46751e330fec1a commit 5f5a898541a541f5230831fcef46751e330fec1a Author: Alexis La Goutte Date: Sun Sep 10 15:59:31 2017 +0200 infiniband: always display reserved field... Change-Id: If6976b2e1990ae562579134dbab3550faae8cfe3 Reviewed-on: https://code.wireshark.org/review/23458 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=27865070e0244a8f5c3fa46341d449d7078d0d4e commit 27865070e0244a8f5c3fa46341d449d7078d0d4e Author: Alexis La Goutte Date: Sun Sep 10 15:45:00 2017 +0200 infiniband: merge all reserved field Change-Id: I31a0d84e9f9e811cc0568d171c6bd6f1fa3397c6 Reviewed-on: https://code.wireshark.org/review/23457 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e7ec9c5538d34fb3a732bdc2adc2f2311589e165 commit e7ec9c5538d34fb3a732bdc2adc2f2311589e165 Author: Alexis La Goutte Date: Sun Sep 10 15:31:38 2017 +0200 infiniband: always return line for local_offset Change-Id: I8bd9e76e44254c45be26c616bf22f712bcf50881 Reviewed-on: https://code.wireshark.org/review/23456 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=53c9d25694c2859061e46f3df97d9f89c8cca5c9 commit 53c9d25694c2859061e46f3df97d9f89c8cca5c9 Author: Alexis La Goutte Date: Sun Sep 10 14:56:30 2017 +0200 Revert "infiniband: fix bitmap for Local CM Response Timeout / Retry Count" This reverts commit e624445adff8aa10ca6663e653b13ecd5c7db8d2. Bug: 13997 Change-Id: I80c6842f890c7c6e9674a6f51732bf0eadec1de8 Reviewed-on: https://code.wireshark.org/review/23454 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=74436b5ace977279b659dc2420305ea5a423e9ee commit 74436b5ace977279b659dc2420305ea5a423e9ee Author: Peter Wu Date: Thu Aug 24 00:36:03 2017 -0700 ssl: fix subdissection with multiple TLS records per packet Decrypted TLS records must be stored in a single SslPacketInfo or else plaintext will go missing (in Follow SSL or when subdissectors need reassembly). As this structure is currently keyed by the layer number (pinfo->curr_layer_num) which is changed by call_dissector, it must be copied and propagated before calling subdissectors. Change-Id: Ic42ba6c0854154272058f9bf9796e06ad7f94bfd Fixes: v2.3.0rc0-3740-ge1f84f985e ("Fix Decode As for protocols that may use tunneling.") Bug: 13885 Reviewed-on: https://code.wireshark.org/review/23190 Reviewed-by: Peter Wu Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6bcf405338d498c76005223190a591048922f18d commit 6bcf405338d498c76005223190a591048922f18d Author: Pascal Quantin Date: Sun Sep 10 17:54:16 2017 +0200 Thread: replace g_strsplit by wmem_strsplit It avoids leaking memory in case an exception is thrown during dissection Change-Id: Ib25c6a82b90ca541db121a79515a087d8d2c332f Reviewed-on: https://code.wireshark.org/review/23468 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1a89b51e413f164d4a25d44d8c61beea8498a09a commit 1a89b51e413f164d4a25d44d8c61beea8498a09a Author: Pascal Quantin Date: Sun Sep 10 17:52:14 2017 +0200 RTPproxy: replace g_strsplit by wmem_strsplit It avoids leaking memory in case an exception is thrown during dissection Change-Id: Ic1ce27800e699b01492f1d40ce720fc82416cfbc Reviewed-on: https://code.wireshark.org/review/23467 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=350676f2723e1898e689d3026b62a8ea26409f4f commit 350676f2723e1898e689d3026b62a8ea26409f4f Author: Pascal Quantin Date: Sun Sep 10 17:50:51 2017 +0200 ISObus VT: fix a memory leak when using g_strsplit Change-Id: I8cfbca97b9b5915f0fe38eda1d73f5483481aca7 Reviewed-on: https://code.wireshark.org/review/23466 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=124cf779f0c0d3a856a9c1793cb165eb56512705 commit 124cf779f0c0d3a856a9c1793cb165eb56512705 Author: Pascal Quantin Date: Sun Sep 10 17:49:08 2017 +0200 HTTP: replace g_strsplit by wmem_strsplit It avoids leaking memory in case an exception is thrown during dissection Change-Id: Ic63a8ad7923c81c7c7d7f0c471e304d8a5224212 Reviewed-on: https://code.wireshark.org/review/23465 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=85d742ef26970e35d16f16a9bea04a12ff618e17 commit 85d742ef26970e35d16f16a9bea04a12ff618e17 Author: Pascal Quantin Date: Sun Sep 10 17:47:36 2017 +0200 DNS: replace g_strsplit by wmem_strsplit It avoids leaking memory in case an exception is thrown during dissection Change-Id: Iab72bcb4cc1ac56e7ce5ff2693e3111aead03e7d Reviewed-on: https://code.wireshark.org/review/23464 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4a2923d78b69e11e09c5cc3943f23cf40588dc37 commit 4a2923d78b69e11e09c5cc3943f23cf40588dc37 Author: Pascal Quantin Date: Sun Sep 10 17:44:34 2017 +0200 JXTA: replace g_strsplit by wmem_strsplit It avoids leaking memory in case an exception is thrown during dissection Bug: 14050 Change-Id: Ia17855646774ffa7bd93e0c8d578fa30f4df1394 Reviewed-on: https://code.wireshark.org/review/23463 Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d4df5b8ee5337061a039cb8856439c89776f6a08 commit d4df5b8ee5337061a039cb8856439c89776f6a08 Author: Alexis La Goutte Date: Sun Sep 10 16:19:47 2017 +0200 pfcp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ie31d7338934c77a713b0af495d6a4a5dd5fca2fe Reviewed-on: https://code.wireshark.org/review/23461 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=81b4957f5a5219f4fe40e598620d2579907e603b commit 81b4957f5a5219f4fe40e598620d2579907e603b Author: Alexis La Goutte Date: Sun Sep 10 16:26:14 2017 +0200 netmon: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I9ba8e7e73c40e8baac7ef761b6a1c0b6b4ad5525 Reviewed-on: https://code.wireshark.org/review/23462 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2154cb12a91464e78b359cb235a8f8b9c3181b58 commit 2154cb12a91464e78b359cb235a8f8b9c3181b58 Author: Julian Renz Date: Sat Sep 9 10:25:19 2017 +0200 ISAKMP: Added support for the accepted Diffie-Hellman group number in the INVALID_KE_PAYLOAD Notify payload according to RFC 5996. Also fixed a bug where the dissection of the previously added support for the SIGNATURE_HASH_ALGORITHMS Notify payload would not work properly. Change-Id: I54ffe6b0d8b52189af3dc2e879e6665739fc36a4 Reviewed-on: https://code.wireshark.org/review/23439 Petri-Dish: Alexis La Goutte Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=f662b1dac904f51aefdcba5fddb1a6c72ff03c4b commit f662b1dac904f51aefdcba5fddb1a6c72ff03c4b Author: Ahmad Fatoum Date: Sun Sep 10 14:37:16 2017 +0200 Tibia: Remove UAT error dialog in GnuTLS-less builds Remove the RSA UAT completely when built without GnuTLS, because we require GnuTLS for parsing PEM and PKCS #12 keys. RSA encrypted packets can still be decoded if they are using the standard OTServ RSA key, which is hard-coded. Bug: 13959 Change-Id: I6bfc2bebaf8a49933d55fb5c3fcb8efbf58f1e6e Fixes: g62c9a8a865 Reviewed-on: https://code.wireshark.org/review/23453 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Joakim Karlsson Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=80351694c168795e08259a8f63e143c50c5a7bd4 commit 80351694c168795e08259a8f63e143c50c5a7bd4 Author: Alexis La Goutte Date: Mon Aug 28 06:34:21 2017 +0200 .mailmap: update (of August) Change-Id: I77d50bedf1cb78e84c551413db8dab9223f45ed7 Reviewed-on: https://code.wireshark.org/review/23254 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=c6e3fe5957f6df20d17db9dd95cb4bde80304086 commit c6e3fe5957f6df20d17db9dd95cb4bde80304086 Author: Alexis La Goutte Date: Sun Sep 10 10:54:20 2017 +0200 infiniband : Add value string for BTH opcode Bug: 13998 Change-Id: Idd369e364bd2464b278fb4abcc1e77a0f8892641 Reviewed-on: https://code.wireshark.org/review/23452 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=371436cf4d96687fd5d69ef6c146cd859fc4f832 commit 371436cf4d96687fd5d69ef6c146cd859fc4f832 Author: Gerald Combs Date: Sun Sep 10 08:06:53 2017 +0000 [Automatic update for 2017-09-10] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I501b06b6c00354f921cfdb0d8239266577645a08 Reviewed-on: https://code.wireshark.org/review/23448 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=0414dae7ec5fefadb89fc03bd140b6c9f3d6dbb2 commit 0414dae7ec5fefadb89fc03bd140b6c9f3d6dbb2 Author: Ahmad Fatoum Date: Sun Sep 10 01:56:51 2017 +0200 Tibia: Fix malformed packet exceptions on first pass The first pass and other passes with NULL proto_tree caused a malformed packet exception. This was due to an outdated if (tree) check that is now removed. While we are at it, adjust documentation to reflect the actual maximum version supported: 11.00 and add the new (yet unused) version traits. Bug: 13959 Fixes: g62c9a8a865 Change-Id: If3e1093c881c0eb5070fefc9877cf5f0c61a7572 Reviewed-on: https://code.wireshark.org/review/23446 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f2f281e90e5a4b9f8f249ae89d6364bd7dc48785 commit f2f281e90e5a4b9f8f249ae89d6364bd7dc48785 Author: Michael Mann Date: Sat Sep 9 13:18:51 2017 -0400 Cleanup packet-zep.c 1. Remove packet-zep.h and incorporate into packet-zep.c 2. Use proto_tree_add_item_ret_uint to get fields that are used to populate columns and appended items. 3. Intermix tree and column logic for more straightforward logic. Change-Id: If0f050307ece51260d43e5e98867b0f914492c12 Reviewed-on: https://code.wireshark.org/review/23442 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b9746b6833e0dc7d0a7f9afd1b3a5b80252d76b6 commit b9746b6833e0dc7d0a7f9afd1b3a5b80252d76b6 Author: Gerald Combs Date: Sat Sep 9 09:21:10 2017 -0700 Redirect to /dev/null, not /devnull. Change-Id: I9d14244cc14fac4d8857177686b9fd869d8a3b3c Reviewed-on: https://code.wireshark.org/review/23441 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=26a5cd2d7837a08f5d5c2f1b5abec34b4b22a596 commit 26a5cd2d7837a08f5d5c2f1b5abec34b4b22a596 Author: Uli Heilmeier Date: Sat Sep 9 11:04:04 2017 +0200 ws_cpuid: include ws_attributes Otherwise _U_ is not defined. Change-Id: I221f64c7d89c221e5a63a573e06457699d0a177e Reviewed-on: https://code.wireshark.org/review/23440 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=84ee66b9bc97bfa294f11b4083f8f09b115c17e0 commit 84ee66b9bc97bfa294f11b4083f8f09b115c17e0 Author: shqking Date: Fri Sep 8 21:23:43 2017 -0400 packet-dcerpc-pn-io.c: Fix potential resource leak Bug: 13826 Change-Id: I01674d5a31281508686bc06e222d6a87926d1c83 Reviewed-on: https://code.wireshark.org/review/23436 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a24f366ceb8eccf2e3a0501a394653c9eb6bed83 commit a24f366ceb8eccf2e3a0501a394653c9eb6bed83 Author: Michael Mann Date: Fri Sep 8 21:43:08 2017 -0400 Correct instructions for choco package for VS2015. Bug: 14039 Change-Id: Ic19c77bb091cd8ee8f824b82463d8b4bae37f625 Reviewed-on: https://code.wireshark.org/review/23437 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=64f53c90b7b81e252eef8c08d0aa01c5ff9796ef commit 64f53c90b7b81e252eef8c08d0aa01c5ff9796ef Author: Michael Mann Date: Thu Sep 7 16:16:52 2017 -0400 Netmon: Add support for process and system config type events. Ping-Bug: 6694 Change-Id: If11e96fce56c5dc92c92765b4fd5632de53060cd Reviewed-on: https://code.wireshark.org/review/23430 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1c6f6c691f52bc3c0a660e6f82453844135acb30 commit 1c6f6c691f52bc3c0a660e6f82453844135acb30 Author: Jakub Zawadzki Date: Sat Sep 2 21:47:14 2017 +0200 sharkd: implement proper JSON string unescaping, based on JSON dissector. Change-Id: I749b78b759f98c78526840b8bb1cbccfc17a5611 Reviewed-on: https://code.wireshark.org/review/23365 Petri-Dish: Jakub Zawadzki Tested-by: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo Reviewed-by: Jakub Zawadzki http://cgit.osmocom.org/wireshark/commit/?id=585297b189ba7f39db34f66f57d25429c8daf570 commit 585297b189ba7f39db34f66f57d25429c8daf570 Author: Joakim Karlsson Date: Thu Sep 7 23:20:34 2017 +0200 GPRSCDR: decoding of EPS QoS/aRP * Decoding of Allocation/Retention Priority (ARP) * Fix order of ARP in GTPv2 Change-Id: Ica24877f3518b5e0b6883ba535ffe09be8f446c2 Reviewed-on: https://code.wireshark.org/review/23431 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=df21aa90250c29d7466d55d9e0eda2cddd0dfbd8 commit df21aa90250c29d7466d55d9e0eda2cddd0dfbd8 Author: Guy Harris Date: Fri Sep 8 04:32:04 2017 -0700 Use cmake_push_check_state() and cmake_pop_check_state(). Change-Id: I70528d5f54f62a51bf6f438669cd70d5f0296ae5 Reviewed-on: https://code.wireshark.org/review/23435 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=935c055c18c8e33021c4062d22d4b87fe5577662 commit 935c055c18c8e33021c4062d22d4b87fe5577662 Author: Michael Mann Date: Thu Sep 7 22:12:46 2017 -0400 DOCSIS: Fix compiler warning on macOS. Previous functionality presumed cat = 0, so initialize cat to it. Change-Id: Ic0fdccc8222dfb435178416911d35bac105c6c03 Reviewed-on: https://code.wireshark.org/review/23434 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=6a67ba5677b28d8ce4e8b775ee93573297784e0a commit 6a67ba5677b28d8ce4e8b775ee93573297784e0a Author: Ahmad Fatoum Date: Fri Aug 25 14:22:32 2017 +0200 Add basic Tibia game protocol dissection Bug: 13959 Change-Id: Idec9c020d372c3b84af7024e2df4da4f9380f74d Reviewed-on: https://code.wireshark.org/review/23055 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=1c777ec044473c644135c2a96576ac575e5a704c commit 1c777ec044473c644135c2a96576ac575e5a704c Author: Michael Mann Date: Thu Sep 7 21:10:42 2017 -0400 DOCSIS: Ensure docsis_ucd has a registered dissection function Bug: 14038 Change-Id: I36fbaa591a7ebf5da7d2e7be837e8fcca30c7f98 Reviewed-on: https://code.wireshark.org/review/23432 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=62c9a8a865779299d5e06cb929680e4bba92d4e7 commit 62c9a8a865779299d5e06cb929680e4bba92d4e7 Author: Ahmad Fatoum Date: Sun Aug 6 23:59:31 2017 +0200 Add Tibia login protocol dissector Tibia (https://tibia.com) is a Massively Multiplayer Online Role-Playing Game (MMORPG) by Cipsoft GmbH. This patch provides login protocol (session layer) support for Tibia versions 7.0 (Dec. 2001) till current 11.42 (2017-08-12). Most importantly, RSA-encrypted login packets are parsed and symmetric XTEA session keys are extracted. Bug: 13959 Change-Id: Id9d0dfa283cc604d66a6e6d1f3811cdcd7ff99db Reviewed-on: https://code.wireshark.org/review/23054 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8dedebbf30253add7886d508850af7e53d6ae3de commit 8dedebbf30253add7886d508850af7e53d6ae3de Author: Bruno Verstuyft Date: Tue Sep 5 10:04:25 2017 +0200 DOCSIS: Added support for version 5 MAPs (dissect_map_v5) Change-Id: Icc43fdc341a8f263af5d7b9e1bc14e13b5361dd0 Reviewed-on: https://code.wireshark.org/review/23392 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=765fc1d53374a0c9177bc634f5b928371fb98110 commit 765fc1d53374a0c9177bc634f5b928371fb98110 Author: Pascal Quantin Date: Thu Sep 7 21:04:43 2017 +0200 NAS EPS: update version info Change-Id: Ic7f6353af47b494e3853d16c93cbcddff025888c Reviewed-on: https://code.wireshark.org/review/23429 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=b4cd63921c7134ab27da71369b50e26109d485cd commit b4cd63921c7134ab27da71369b50e26109d485cd Author: Jo??o Valverde Date: Tue Aug 8 18:32:43 2017 +0100 RADIUS: Use two dictionaries (personal + system) Instead of choosing one or the other. Ping-Bug: 6466 Change-Id: Ia95b79190d12ad0fa8af06a12743f042f73a7602 Reviewed-on: https://code.wireshark.org/review/23029 Petri-Dish: Alexis La Goutte Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=db63f75eab219c16c450d4fcd57bfeae1bcb8cb6 commit db63f75eab219c16c450d4fcd57bfeae1bcb8cb6 Author: Jo??o Valverde Date: Thu Sep 7 13:02:22 2017 +0100 More [-Wmaybe-uninitialized] fixes with -Og There may be some amount of bogosity involved but initialize the variables and add a default case to prevent the noise and the build from breaking with -Werror. Change-Id: I20432ea74a1e5edc28be75a97077c9aa7bc87a35 Reviewed-on: https://code.wireshark.org/review/23426 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=d38197bb676d8937f5d9acd534200195b2e541bc commit d38197bb676d8937f5d9acd534200195b2e541bc Author: Stig Bj??rlykke Date: Thu Sep 7 13:27:41 2017 +0200 Qt: Construct QRegExp only once In Interface Toolbar lineedit the QRegExp only needs to be constructed once, not for every validity check. Change-Id: I39e9ab9c57b4ac64a0b9b601fa72646d8c420274 Reviewed-on: https://code.wireshark.org/review/23425 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=b57010039bbbf01f7fa16c1a3a78907558eb9f97 commit b57010039bbbf01f7fa16c1a3a78907558eb9f97 Author: AndersBroman Date: Thu Sep 7 16:23:59 2017 +0200 [NAS EPS] Update Request type value_string. Change-Id: Ie92d2c0d91cd91974400327e0beba6aa9d995bff Reviewed-on: https://code.wireshark.org/review/23427 Petri-Dish: Anders Broman Reviewed-by: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f091ed83f7e051f0618391dc791687235c4a0abd commit f091ed83f7e051f0618391dc791687235c4a0abd Author: Jo??o Valverde Date: Thu Sep 7 06:49:12 2017 +0100 CMake: Try to fix build error with i18n.qrc dependency order Change-Id: I7006b435508e72457413cd1b7c5bdf1b7b41ee5b Reviewed-on: https://code.wireshark.org/review/23424 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=09a9d2265595ca317136c85975da318ef29f84c6 commit 09a9d2265595ca317136c85975da318ef29f84c6 Author: Pascal Quantin Date: Thu Sep 7 07:42:50 2017 +0200 Message Analyzer: use G_GUINT64_CONSTANT() macro Change-Id: Ifbcc8e9c04d9da9829a653dffb92a25ea787749a Reviewed-on: https://code.wireshark.org/review/23423 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=6c87b5fdaa4ee746caf883382b3c74f3faf952b5 commit 6c87b5fdaa4ee746caf883382b3c74f3faf952b5 Author: AndersBroman Date: Wed Sep 6 17:38:12 2017 +0200 [PFCP] Add more IE dissection. Change-Id: I98fa0b38c0872e26ae84f11dfa06d582e3e2e527 Reviewed-on: https://code.wireshark.org/review/23416 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=da01b0b5dca05571d08ad71302aad66ac7ee3181 commit da01b0b5dca05571d08ad71302aad66ac7ee3181 Author: Pascal Quantin Date: Wed Sep 6 22:56:08 2017 +0200 USB: use G_GUINT64_CONSTANT() macro Change-Id: I2c3d2956be898c767afc19b2c63f2e84b5e79ed0 Reviewed-on: https://code.wireshark.org/review/23422 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c4901ca31f484c88a7947a6c2354ae194694599a commit c4901ca31f484c88a7947a6c2354ae194694599a Author: Pascal Quantin Date: Wed Sep 6 22:39:28 2017 +0200 MBIM: add multiflow extension dissection Change-Id: I9892df3984baf1ecf241b6d3f426a8633bf39b33 Reviewed-on: https://code.wireshark.org/review/23420 Petri-Dish: Pascal Quantin Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=8b9dc8c00c5d598aad0c8eb2b9623d533a001835 commit 8b9dc8c00c5d598aad0c8eb2b9623d533a001835 Author: Pascal Quantin Date: Wed Sep 6 22:54:40 2017 +0200 Netmon: fix indentation Change-Id: I68683bf6b257bc4311bba47f0a5d6f4d80d0078f Reviewed-on: https://code.wireshark.org/review/23421 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=e728e28f6eb4ffaa661a0c8356215eac64b9ebfb commit e728e28f6eb4ffaa661a0c8356215eac64b9ebfb Author: Dario Lombardo Date: Wed Sep 6 17:31:42 2017 +0200 caputils: fix compilation without pcap. Change-Id: I074d027cd2528b0438015ddd098c9f4f6542090a Reviewed-on: https://code.wireshark.org/review/23415 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d9477abd754d80eb95d1bf0886ef1bda0b7ac1df commit d9477abd754d80eb95d1bf0886ef1bda0b7ac1df Author: Michael Mann Date: Wed Sep 6 14:45:54 2017 -0400 Bugfix NetMon System Trace dissection Use opcode, not event id for dissection Change-Id: I1df6067e8e7e6efb201f9131fc71113cb5a174d3 Reviewed-on: https://code.wireshark.org/review/23417 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=40481a1e393fdca7198031177e75b21e97e612ce commit 40481a1e393fdca7198031177e75b21e97e612ce Author: Michael Mann Date: Wed Sep 6 14:47:02 2017 -0400 NetMon: Add support for WiFi Message It's just a WTAP_ENCAP_IEEE_802_11 Change-Id: I7369fac06a7d63812bb7ce7b3c16b9fe606f544c Reviewed-on: https://code.wireshark.org/review/23418 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ecc3828be56ba77757e40effacb6e4fed6a85b98 commit ecc3828be56ba77757e40effacb6e4fed6a85b98 Author: Michael Mann Date: Tue Sep 5 17:04:33 2017 -0400 Add ETW Ndis (NetMon) support Ping-Bug: 6694 Change-Id: I7515177a37bd62efc019c7472c35efd384ffd7f9 Reviewed-on: https://code.wireshark.org/review/23407 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ee258b61a4eb51ec70afa4a3ae57bd30b1957150 commit ee258b61a4eb51ec70afa4a3ae57bd30b1957150 Author: Michael Mann Date: Wed Sep 6 15:55:15 2017 -0400 packet-usb.c: Add support for USBPort Keyword Change-Id: I29e0a7bf81b1f6cf2f84cccb212e223089dd918a Reviewed-on: https://code.wireshark.org/review/23419 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c1ef4693de99e56e182f7e8406f08a734e2e43b5 commit c1ef4693de99e56e182f7e8406f08a734e2e43b5 Author: Jo??o Valverde Date: Wed Sep 6 11:55:40 2017 +0100 CMake: Make plugin installation path use PLUGIN_INSTALL_LIBDIR Change-Id: I47f248f6ef56aba400054fa3ade2bf4d29eeb895 Reviewed-on: https://code.wireshark.org/review/23411 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=c6f99aea466319d02006808f35069da7f87a5c1b commit c6f99aea466319d02006808f35069da7f87a5c1b Author: Jo??o Valverde Date: Wed Sep 6 11:49:12 2017 +0100 CMake: Move CPACK remnants and remove stale comment Move required variables for better context. Remove TODO comment. "To do" is "everything" to re-implement CPack because (incomplete) support was dropped in g0831becc1a. Change-Id: Ie21001940794e264527f35b5d4638830de02d97e Reviewed-on: https://code.wireshark.org/review/23410 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=7b6296ac5affa85687e6af8f5000cd3ed18b7cd4 commit 7b6296ac5affa85687e6af8f5000cd3ed18b7cd4 Author: Julian Renz Date: Tue Sep 5 17:05:53 2017 +0200 ISAKMP: Added dissection of the RFC7427 Notify Payload "SIGNATURE_HASH_ALGORITHMS" according to iana IKEv2 parameters Change-Id: Ie10d0a8a076d65f60590b4fac0b36be7b87dec2a Reviewed-on: https://code.wireshark.org/review/23396 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=d022091acfd4c9513a4f13973d7cdc7d7785c09e commit d022091acfd4c9513a4f13973d7cdc7d7785c09e Author: Pascal Quantin Date: Wed Sep 6 15:14:44 2017 +0200 Qt: fix RTP/IAX2 reverse stream export to CSV Bug: 14040 Change-Id: Idadfbd3b60124b5f7ac4ace275db94b10daf010a Reviewed-on: https://code.wireshark.org/review/23409 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=40869e6e50a1157314e75aa5be2ba2fd887318d3 commit 40869e6e50a1157314e75aa5be2ba2fd887318d3 Author: Roland Knall Date: Mon Sep 4 13:40:23 2017 +0200 openSAFETY: Add transport protocol for UDP Adding a transport protocol for UDP, which replaces the never used current implementation and adding also additional header information for the transport Change-Id: I943ac789bdc7355c114295dd1c8f1c1b475a5f8b Reviewed-on: https://code.wireshark.org/review/23408 Petri-Dish: Roland Knall Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=d0a91b27f26762e9c998cc5e6fe71767de5d32c7 commit d0a91b27f26762e9c998cc5e6fe71767de5d32c7 Author: Jo??o Valverde Date: Tue Sep 5 17:18:00 2017 +0100 plugins: config.h must not be included by public headers For a sane plugin build environment. Include config.h as the first header in the .c file instead. Fix by moving required compiler attribute macros to a new "ws_attributes.h" API header. Change-Id: I34f58a927f68c1a0e59686c14d214825149749e1 Reviewed-on: https://code.wireshark.org/review/23400 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=143bc04ca7c11b4f5a0feef4c01627c9aee6bcd4 commit 143bc04ca7c11b4f5a0feef4c01627c9aee6bcd4 Author: Michael Mann Date: Mon Sep 4 20:36:00 2017 -0400 Add NetMon System Trace support Change-Id: I1ecf16db1b0a10b1a43112cc1225507e08250ace Reviewed-on: https://code.wireshark.org/review/23405 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5672ab00d2c10322b0cc7d94f2537b5083b8c376 commit 5672ab00d2c10322b0cc7d94f2537b5083b8c376 Author: Michael Mann Date: Mon Sep 4 16:38:12 2017 -0400 MessageAnalyzer: Add support for ETW WFP Capture type. Change-Id: Ic197e032621284de950843a6d086bb7c8c2787d4 Reviewed-on: https://code.wireshark.org/review/23402 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=494ede2aca686aaf69fb7ea7bc776dce48612868 commit 494ede2aca686aaf69fb7ea7bc776dce48612868 Author: Michael Mann Date: Mon Sep 4 17:32:23 2017 -0400 packet-netmon.c: Add Provider ID to INFO column. Useful since it feeds dissector table. Change-Id: I7fec9f37f9b2b480d82a713599f0818ad3dd32bb Reviewed-on: https://code.wireshark.org/review/23404 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e4084f7bcdb7f05ae954d909c6dafa7a26ff631c commit e4084f7bcdb7f05ae954d909c6dafa7a26ff631c Author: Michael Mann Date: Mon Sep 4 17:31:48 2017 -0400 Ensure process info offset is "seek"ed when process info exists in NetMon file. Change-Id: I85fd990781a47e738c22bff0218aabdc04122e15 Reviewed-on: https://code.wireshark.org/review/23403 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=299bd4628a9aa8e6ea2c8772576e171f100da001 commit 299bd4628a9aa8e6ea2c8772576e171f100da001 Author: Jo??o Valverde Date: Tue Sep 5 12:39:09 2017 +0100 Fix unitialized variable warnings that popped up with -Og Using GCC version 7.1.1. Change-Id: I7447a48fc97efb1eb15a016a29165f69d37f40a6 Reviewed-on: https://code.wireshark.org/review/23399 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=0dee5c1911337e1cb8d8836eb6aec8b8abd72fa0 commit 0dee5c1911337e1cb8d8836eb6aec8b8abd72fa0 Author: Ahmad Fatoum Date: Tue Sep 5 18:41:19 2017 +0200 Fix memory leak in wimaxasncp Remove unnecessary null-check before free as well. Change-Id: Ic54459149b40fd8c8f58c643bbd6cfc81ee8b923 Reviewed-on: https://code.wireshark.org/review/23398 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=970ed78492db50e7229c29530ba8aa658a0ae72a commit 970ed78492db50e7229c29530ba8aa658a0ae72a Author: AndersBroman Date: Tue Sep 5 17:22:14 2017 +0200 [PFCP] Add more IE dissection. Change-Id: I71037d31283b1a2758617e6cdc6c3b58048e017d Reviewed-on: https://code.wireshark.org/review/23397 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5c4a96b58b2f29c2ff4588b86fc443b4b6b0f820 commit 5c4a96b58b2f29c2ff4588b86fc443b4b6b0f820 Author: Alexis La Goutte Date: Fri Sep 1 16:42:53 2017 +0200 QUIC (TLS): Add stateless_reset_token parameter Ping-Bug: 13881 Change-Id: I0332ebae69d8b25b1ac8617742cff02744a30f2a Reviewed-on: https://code.wireshark.org/review/23389 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a6ad0a0191cd98f4c3f7c2a7bc655049109f01e1 commit a6ad0a0191cd98f4c3f7c2a7bc655049109f01e1 Author: AndersBroman Date: Tue Sep 5 14:00:06 2017 +0200 [GTPv2] Correct packet_flow_id length. Change-Id: I90b4a405ea8e55d4897d39c30b15289e09da89eb Reviewed-on: https://code.wireshark.org/review/23395 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0fb62a5fd0b7c1282c7d64c61b9d806f94cf3f07 commit 0fb62a5fd0b7c1282c7d64c61b9d806f94cf3f07 Author: Anton Kharchenko Date: Sun Sep 3 16:52:45 2017 +0700 LLDP 802.3 LAG TLV has been deprecated since 02-Dec-2011 Change-Id: I191b257a6dea2961c23dc68a329a07f4aa1428d1 Reviewed-on: https://code.wireshark.org/review/23373 Petri-Dish: Michael Mann Reviewed-by: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2698324d2852157e0b45e4ccd0736989b74fb6e5 commit 2698324d2852157e0b45e4ccd0736989b74fb6e5 Author: Dmitry Bravikov Date: Tue Sep 5 11:02:30 2017 +0500 Fix unit of measurement in category 048 of ASTERIX protocol. Change-Id: Icdd39166059c080e7844968219f2a8f387c587a6 Reviewed-on: https://code.wireshark.org/review/23391 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4275f3de77be054c143076bf5b6e78e0f983a70f commit 4275f3de77be054c143076bf5b6e78e0f983a70f Author: Martin Boye Petersen Date: Tue Sep 5 09:50:05 2017 +0200 ZigBee ZCL SE PP: Subtrees not registered and dissect error Subtrees for PublishTopUpLog and PublishDebtLog was not registered. Missing timestamp field in PublishTopUpLog. Change-Id: I3fedffccfceba7dcb6c2696c39b481b6f5cd1c75 Reviewed-on: https://code.wireshark.org/review/23394 Reviewed-by: Kenneth Soerensen Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1cee1c95cc8b0ff30419b08d477c8f512615cd99 commit 1cee1c95cc8b0ff30419b08d477c8f512615cd99 Author: Stig Bj??rlykke Date: Mon Sep 4 20:02:00 2017 +0200 dumpcap: Detect extcap pipe from correct interface When capturing from multiple interfaces the extcap pipe detection must be done based on the correct interface, not the first one. Change-Id: I7428388d84ee18d0bfa693ffc9ddae98126ceca4 Ping-Bug: 13653 Reviewed-on: https://code.wireshark.org/review/23390 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=d4efbc410165a3cad9e587b09e336ba1226fd3aa commit d4efbc410165a3cad9e587b09e336ba1226fd3aa Author: Michael Mann Date: Sun Sep 3 10:36:40 2017 -0400 Add NetMon Event Provider ID dissector table The provider ID appears to be the hook into dissecting NetMon Event user data. Since capture file with USB data was provided, that was used as the example for how to hook into the provider ID dissector table. Bug: 6520 Change-Id: Ie41719b6a28826869cd1672619949ea1f6981268 Reviewed-on: https://code.wireshark.org/review/23377 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8faa84d38ba8f83acf68653ef9800738dfd8bfbc commit 8faa84d38ba8f83acf68653ef9800738dfd8bfbc Author: Alexis La Goutte Date: Fri Sep 1 16:29:23 2017 +0200 QUIC: Add STOP_SENDING frame Ping-Bug: 13881 Change-Id: I039e7a3eb1572721553a067f0d3db44e9cd4d7bd Reviewed-on: https://code.wireshark.org/review/23388 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f7ff38bc782340b1e2540f59c0138f7fa56bc5dd commit f7ff38bc782340b1e2540f59c0138f7fa56bc5dd Author: Alexis La Goutte Date: Fri Sep 1 16:06:22 2017 +0200 QUIC: Add Statess Reset Token field on NEW CONNECTION ID Frame Adding on draft-05 and also fix typo on NEW_CONNECTION_ID column Ping-Bug: 13881 Change-Id: I838069d6a19f85772cbbb6346853a2ba64d056fd Reviewed-on: https://code.wireshark.org/review/23387 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=83f727d73dfda95623b9094cb817cf8564cbe54e commit 83f727d73dfda95623b9094cb817cf8564cbe54e Author: Alexis La Goutte Date: Wed Aug 16 13:26:15 2017 +0200 QUIC(IETF): Remove GOAWAY Ping-Bug: 13881 Change-Id: Ieacfb6a9f63ec17f4377652a396e7bcfd54c101d Reviewed-on: https://code.wireshark.org/review/23257 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8bd04c8be3304731dc319a35d1e6974193bcd3c1 commit 8bd04c8be3304731dc319a35d1e6974193bcd3c1 Author: Martin Mathieson Date: Sun Sep 3 20:50:40 2017 +0100 IMF: preserve carrying protocol (e.g. SMTP, POP, IMAP) in protocol column Change-Id: I8331040bbc9866878e74ad4c5f6b986dd94603fc Reviewed-on: https://code.wireshark.org/review/23381 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a2b084f6c507d96fe6f0776154537268d60e9428 commit a2b084f6c507d96fe6f0776154537268d60e9428 Author: Michael Mann Date: Mon Sep 4 10:16:49 2017 -0400 Add support for WPFCapture "formats" from Microsoft Analyzer. Normally a .cap file contains a network type that when masked with 0xFFF will convert to a pcap LINKTYPE_ value. However, Microsoft Analyzer used 0xE080-0xE08A for their own purposes within a .cap file. Add support for the WPFCapture formats and give a "not supported" error message to the few left unsupported. Bug: 10556 Change-Id: I321a75ce769fdec75bdc6b595936c25932950a97 Reviewed-on: https://code.wireshark.org/review/23386 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9f1c73edac06821987760e03f103c49bb9588d1f commit 9f1c73edac06821987760e03f103c49bb9588d1f Author: AndersBroman Date: Mon Sep 4 13:40:00 2017 +0200 [PFCP] Have an ett var per IE, add the grouped IEs Cause and Node Id. Change-Id: I1c6bae4a9d46950e59209e72cd799272fa4f1c2c Reviewed-on: https://code.wireshark.org/review/23384 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0393c108bcd548fecc9ad6e0d7f97caf09997876 commit 0393c108bcd548fecc9ad6e0d7f97caf09997876 Author: Bruno Verstuyft Date: Fri Sep 1 17:25:05 2017 +0200 Extra decodings for DOCSIS MDD message Change-Id: I8765c96717d80f2b340428eb025e0a1e52a6e495 Reviewed-on: https://code.wireshark.org/review/23353 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2a9cab649e90f85cc7b40440ad211438c8bb212f commit 2a9cab649e90f85cc7b40440ad211438c8bb212f Author: Pascal Quantin Date: Mon Sep 4 14:51:00 2017 +0200 LTE RRC: add MBMS SIB messages to info column Change-Id: Id238182ab19c9490d0e1cab852338fafdc2e1b66 Reviewed-on: https://code.wireshark.org/review/23385 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=ab39fac52ea7448fd03ffe6d7d98947393b224c5 commit ab39fac52ea7448fd03ffe6d7d98947393b224c5 Author: Yury Gargay Date: Mon Sep 4 16:38:18 2017 +0700 Diameter: NAS-Identifier and Acct-Multi-Session-Id are UTF8String They should be UTF8String not OctetString according these specifications: * https://tools.ietf.org/html/rfc4005#section-9.3.1 * https://tools.ietf.org/html/rfc6733#section-9.8.5 Change-Id: I96ddc6f5a98ff945dbde34f9844b582a7db924ad Reviewed-on: https://code.wireshark.org/review/23383 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ed75d67394d0641a5b1141cf4e35e86824230e92 commit ed75d67394d0641a5b1141cf4e35e86824230e92 Author: Anders Date: Sun Sep 3 15:38:23 2017 +0200 [PFCP] Add basic dissector for Packet Forwarding Control Protocol (PFCP) 3GPP TS 29.244 V14.0.0 (2017-06)S Change-Id: Id377870caa7649e19832ea3fd3484ed805c2c9cf Signed-off-by: Alexis La Goutte Reviewed-on: https://code.wireshark.org/review/23375 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=78a14e4c577af3ef0ceb49b53cb495692820cbed commit 78a14e4c577af3ef0ceb49b53cb495692820cbed Author: Michael Mann Date: Sun Dec 18 11:57:39 2016 -0500 packet-nfs.c: Minor cleanup Change-Id: Id1b522ae912a05442426d2acc1a036d1ba5689e2 Reviewed-on: https://code.wireshark.org/review/23380 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=209a78ea822cce413ba5dfd31469ddd2ff6c9d65 commit 209a78ea822cce413ba5dfd31469ddd2ff6c9d65 Author: Stig Bj??rlykke Date: Sat Sep 2 20:35:54 2017 +0200 Qt: Interface Toolbar log dialog for each control Have separate log dialogs for each control logger button. Bug: 14033 Change-Id: Iaabcbe38da196ebed1302f66b77864f880121856 Reviewed-on: https://code.wireshark.org/review/23364 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=a338f87f33559bb9c915a97b614987736d07ff8f commit a338f87f33559bb9c915a97b614987736d07ff8f Author: Jo??o Valverde Date: Sun Sep 3 16:22:17 2017 +0100 CMake: Use GNUInstallDirs module instead of our own Change-Id: I42f62824f226b091ff9bb86ce5c222333f98d783 Reviewed-on: https://code.wireshark.org/review/23379 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=8390744957984e074b270edb4e996de274ce3a07 commit 8390744957984e074b270edb4e996de274ce3a07 Author: Jo??o Valverde Date: Sun Sep 3 15:03:31 2017 +0100 Add function to return version number at run-time For use by plugins using libwireshark to check compatibility. Change-Id: I66a9d41644da7efce01cbed30d2a1f76fbc3754d Reviewed-on: https://code.wireshark.org/review/23378 Petri-Dish: Jo??o Valverde Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=1d157ebeef0d5eb82e30ff7d7e64b797be86a3ef commit 1d157ebeef0d5eb82e30ff7d7e64b797be86a3ef Author: Bruno Verstuyft Date: Fri Sep 1 17:43:14 2017 +0200 Extra decodings for DOCSIS RNGRSP Change-Id: I27ad1143dc5c568a3c7cced4f61c11e45485c7f4 Reviewed-on: https://code.wireshark.org/review/23354 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=20d0a90115fb650c852a5ff1a6c3e7cf488ad673 commit 20d0a90115fb650c852a5ff1a6c3e7cf488ad673 Author: Jo??o Valverde Date: Fri Sep 1 15:02:37 2017 +0100 IPv6: Add routing extension header dissector table Change-Id: I1cf462179f8c6cf8c8c881d2cbda8ebe667d9055 Reviewed-on: https://code.wireshark.org/review/23362 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=3a68f85f910ce427ab540554b4fe7ff5fcac2257 commit 3a68f85f910ce427ab540554b4fe7ff5fcac2257 Author: Jo??o Valverde Date: Sun Jul 30 12:18:10 2017 +0100 IPv6: Add dissection for PDM destination option Performance and Diagnostic Metrics (ietf-ippm-6man-pdm-option-13) Change-Id: Ic5e395c931b149cdadd777ab4ea6470c20d7b023 Reviewed-on: https://code.wireshark.org/review/23363 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=08c3681e7eba6f32283f0d1548f53586ae9b9354 commit 08c3681e7eba6f32283f0d1548f53586ae9b9354 Author: Jo??o Valverde Date: Thu Aug 31 15:14:54 2017 +0100 configure: Restore --with-pcap= option Fixes g265a41e14d. Bug: 14019 Change-Id: I785bba88db5feb9e4c694d6fff2f718ea9ec8a3a Reviewed-on: https://code.wireshark.org/review/23367 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=0f233e24d8da9cbc96b997a242b6a61a47de475a commit 0f233e24d8da9cbc96b997a242b6a61a47de475a Author: Gerald Combs Date: Sun Sep 3 08:07:26 2017 +0000 [Automatic update for 2017-09-03] Update manuf, services enterprise numbers, translations, and other items. Change-Id: If786bb3b1ebced2d34dbcd813bf30251b43524ba Reviewed-on: https://code.wireshark.org/review/23369 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=b5a54c341612eff3ca455b6da8095f737d421e44 commit b5a54c341612eff3ca455b6da8095f737d421e44 Author: Jo??o Valverde Date: Fri Aug 25 23:46:23 2017 +0100 manuf.tmpl: mark comments Comments were discarded based on a fourth column using tab separators. Use a pound sign instead. Change-Id: Icb5dd33c4a2c9c441eebda74bc8d813443efe1b6 Reviewed-on: https://code.wireshark.org/review/23351 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=be42b2bdeac66256c66cec8da5dab1204e0c0b8b commit be42b2bdeac66256c66cec8da5dab1204e0c0b8b Author: Jo??o Valverde Date: Sat Sep 2 14:48:41 2017 +0100 IPv6: Split p_update_ipv6_pinfo() into parts For better flexibility when dissecting. Change-Id: I7bd7644d1b466510d670e3f19ee88f28a14b4ed3 Reviewed-on: https://code.wireshark.org/review/23361 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=501f30ce5fb3f105519aedd4ddb8693c119a63c3 commit 501f30ce5fb3f105519aedd4ddb8693c119a63c3 Author: Alexis La Goutte Date: Fri Sep 1 07:13:56 2017 +0200 RSVP: Add Session IPv4/6 P2MP LSP info Bug: 13977 Change-Id: Ia43d746e7be1d24046c755fadb2454eba39dbe58 Reviewed-on: https://code.wireshark.org/review/23347 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=692b1175e4d0493fcda0fbe8dd71ca33c2773a89 commit 692b1175e4d0493fcda0fbe8dd71ca33c2773a89 Author: Jo??o Valverde Date: Thu Aug 31 18:49:15 2017 +0100 Have a single IPv6 tap Optimize code and open possibility for enriching IPv6 tap data. Change-Id: I5a204d7464cde32123d5bfe664cc9b6bcf08dbe1 Reviewed-on: https://code.wireshark.org/review/23340 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=2330ba1b3d6e62272dbaf0d5b3b5e8481040a45f commit 2330ba1b3d6e62272dbaf0d5b3b5e8481040a45f Author: Sergey Avseyev Date: Fri Sep 1 11:12:37 2017 +0300 couchbase: fix full-doc commands of subdoc They do not have path, so the min_spec_size should be smaller Change-Id: I5a77bcf742be5f8a00f0cf7a215f386a845673fa Reviewed-on: https://code.wireshark.org/review/23349 Petri-Dish: Anders Broman Reviewed-by: Dave Rigby Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6fb8aa9a81ac7fcda4733d48555b09ca27dfacad commit 6fb8aa9a81ac7fcda4733d48555b09ca27dfacad Author: Pascal Quantin Date: Sat Sep 2 13:17:04 2017 +0200 WSP: allocate content type string in wmem pool Let's use the pinfo pool as the string can be added to pinfo structure. Bug: 14032 Change-Id: I195b6e216c89e22c8011886826adbbbd1cd32b11 Reviewed-on: https://code.wireshark.org/review/23358 Petri-Dish: Pascal Quantin Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=a66a216820f877881217485388b86c73722b351d commit a66a216820f877881217485388b86c73722b351d Author: Guy Harris Date: Fri Sep 1 19:33:24 2017 -0700 Don't export structures used internally by dissectors for Export Objects. They're not used anywhere other than inside the dissectors, so make them private to the dissectors. Change-Id: I9946713f34f95a8173fd7748055fd4aa2e870f70 Reviewed-on: https://code.wireshark.org/review/23357 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1ef38667197289f585c7315beacb87179c21b1b6 commit 1ef38667197289f585c7315beacb87179c21b1b6 Author: Peter Wu Date: Fri Sep 1 00:22:26 2017 +0100 CMake: prevent unnecessary rebuilds due to version.h Ninja (but not Unix Makefiles or others) require an explicit BYPRODUCTS command to ensure that the target is executed before evaluating others. Change-Id: Iccbeb2516f7bf22ffdb444f3261ca58d22897891 Reviewed-on: https://code.wireshark.org/review/23342 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=e1a591fc746b6d32b68a48b5d80846677ca0fffb commit e1a591fc746b6d32b68a48b5d80846677ca0fffb Author: Guy Harris Date: Fri Sep 1 14:43:54 2017 -0700 Get rid of no-longer-needed patches to PortAudio. The version of PortAudio we now specify has both of those problems fixed. Change-Id: I7364a5dfac1aac4799347a88f3e89fcb52f57d32 Reviewed-on: https://code.wireshark.org/review/23356 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=8f555e43351517f1eb51f04a960936c9fef9a02a commit 8f555e43351517f1eb51f04a960936c9fef9a02a Author: Dhiru Kholia Date: Fri Sep 1 11:15:29 2017 +0530 Kerberos: Add support for new etype values from RFC 8009 These new etype values (19 and 20) are described in RFC 8009. https://tools.ietf.org/html/rfc8009 The krb5 package in Red Hat Enterprise Linux 7.4 already supports these new etype values. Change-Id: Ic8d0b60b08ac1b48361c80adc28d8c408bf7666a Reviewed-on: https://code.wireshark.org/review/23348 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=4b6a26d9521ef9eb63706be5ca144037d1d009f2 commit 4b6a26d9521ef9eb63706be5ca144037d1d009f2 Author: Stig Bj??rlykke Date: Thu Aug 31 23:20:02 2017 +0200 btatt: Fix show handle with unknown service/characteristic/attribute Show correct formatted handle item text when having unknown or missing service, characteristic or attribute. Change-Id: I4c5dec11b07956df3ee6f8dd1653835b8e4a42d7 Reviewed-on: https://code.wireshark.org/review/23337 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ed254720fe2dcc612b49a2ef25db2061f8cb85ff commit ed254720fe2dcc612b49a2ef25db2061f8cb85ff Author: Michael Mann Date: Thu Aug 31 12:45:46 2017 -0400 Add support for NetMon NetmonFilter and NetworkInfoEx frame types. Bug: 4221 Change-Id: I59aff777c364af1a064e1e99ea9ac6692a4cedfa Reviewed-on: https://code.wireshark.org/review/23333 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2d93c4c06fabf8b8e6c8a4c85c4cf818dfd4a5d2 commit 2d93c4c06fabf8b8e6c8a4c85c4cf818dfd4a5d2 Author: Alexis La Goutte Date: Thu Aug 31 08:12:28 2017 +0200 RSVP: Add S2L_SUB_LSP (Class = 50) Object Bug: 13977 Change-Id: I10ce2d7403d6783a1f232e53df6a279ffcde7fd9 Reviewed-on: https://code.wireshark.org/review/23319 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6821e0ea6f2e069ef75be58dc8f7bff50c961a7a commit 6821e0ea6f2e069ef75be58dc8f7bff50c961a7a Author: Jo??o Valverde Date: Fri Sep 1 00:07:49 2017 +0100 Remove IP "dummy" protocol number Change-Id: I3e6a1ec6b98028ff0a5d0bd0f7c8784651ed31da Reviewed-on: https://code.wireshark.org/review/23341 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f16f6a3ef28754408548ff4ae1669856aec172b4 commit f16f6a3ef28754408548ff4ae1669856aec172b4 Author: Jo??o Valverde Date: Fri Sep 1 01:25:53 2017 +0100 Avoid use of global protocol variables Change-Id: I006d872a83649e72a6c83abac68cbae064457162 Reviewed-on: https://code.wireshark.org/review/23346 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5870352d8f388347750d8445a80be92e0fab6504 commit 5870352d8f388347750d8445a80be92e0fab6504 Author: Jo??o Valverde Date: Fri Aug 25 21:50:02 2017 +0100 Fix comment in addr_resolv.c Fixes g55724db3db. Change-Id: Idf9d5293fcd0e91698305da1cec5b8771c0a6a91 Reviewed-on: https://code.wireshark.org/review/23345 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=b7a9c02a50cc6fe5562204d09cb66e556d2f6ce9 commit b7a9c02a50cc6fe5562204d09cb66e556d2f6ce9 Author: Pascal Quantin Date: Thu Aug 31 21:59:53 2017 +0200 H248: check that exported_pdu tap is listening before tapping packets It prevents a memory leak Bug: 14025 Change-Id: Ica4dd81aad38046a858988e8b30e3d7e40d0d721 Reviewed-on: https://code.wireshark.org/review/23336 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=b974952b4cdb954e9b7fe4dda56d8ffec584f323 commit b974952b4cdb954e9b7fe4dda56d8ffec584f323 Author: Pascal Quantin Date: Thu Aug 31 21:50:19 2017 +0200 endpoint_dialog.cpp: remove a useless break Change-Id: I0aafbe27b54969e77ba4df3106b9f35809d848a4 Reviewed-on: https://code.wireshark.org/review/23335 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=05ad9c79b80e5ae39ff63efc9b782eb0b34b3edf commit 05ad9c79b80e5ae39ff63efc9b782eb0b34b3edf Author: Stig Bj??rlykke Date: Thu Aug 31 15:39:05 2017 +0200 bluetooth: Update bluetooth_uuid_vals Change-Id: Idd3767f0b7fbd8cec606f7e3be138f310c6113eb Reviewed-on: https://code.wireshark.org/review/23328 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=74deaf895aa52ecd94ce1953bdde525fda09fdf7 commit 74deaf895aa52ecd94ce1953bdde525fda09fdf7 Author: Stig Bj??rlykke Date: Thu Aug 31 15:16:22 2017 +0200 bluetooth: Update bluetooth_company_id_vals Change-Id: I5c9761eacdfd3a668d5deb8aad46b0d3bee70051 Reviewed-on: https://code.wireshark.org/review/23327 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=45823736e8a8c050a9cbcd299fc512be940ed19c commit 45823736e8a8c050a9cbcd299fc512be940ed19c Author: Stig Bj??rlykke Date: Thu Aug 31 13:37:31 2017 +0200 btle: Add Channel Selection Algorithm Change-Id: I4d215bfb991ecf057ee9f6dda346b2fe6cee0bad Reviewed-on: https://code.wireshark.org/review/23324 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=f89cedcd434daab36fbc96db22a0963e313b7ec6 commit f89cedcd434daab36fbc96db22a0963e313b7ec6 Author: Stig Bj??rlykke Date: Thu Aug 31 13:36:22 2017 +0200 btle: Add Version 5.0 to ll_version_number_vals Change-Id: I427da1f56a69785b70e965e08696fa24b114bb9c Reviewed-on: https://code.wireshark.org/review/23323 Petri-Dish: Stig Bj??rlykke Reviewed-by: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=e9b8a5839f026b4047895b8dc869e075da0bcf45 commit e9b8a5839f026b4047895b8dc869e075da0bcf45 Author: Jens Kilian Date: Thu Aug 31 08:28:02 2017 +0200 Qt: Fix errors when compiling for Qt4. This allows Wireshark to be built on RedHat EL 7.2, with Qt 4.8.5. Bug: 13909 Change-Id: Ia39a288cc342afa2bd0217cb59dac84c3227086c Reviewed-on: https://code.wireshark.org/review/23322 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5f1f891e2a8cb6a5241854884fae2aa8d69f28e6 commit 5f1f891e2a8cb6a5241854884fae2aa8d69f28e6 Author: Alexis La Goutte Date: Thu Aug 31 07:50:39 2017 +0200 RSVP: fix 'filter/host/rsvp_class/ti' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I48e4eebe81c77d8b22bb7357ec13192bb04b59a9 Reviewed-on: https://code.wireshark.org/review/23318 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6f28f1a59e143fc94ea1bc4d46dc9818e0d16e14 commit 6f28f1a59e143fc94ea1bc4d46dc9818e0d16e14 Author: Jim Young Date: Wed Aug 30 23:38:05 2017 -0400 Fix MacOS build Commit 8d13f14f958b9ee00b59fd869bd1630f76e6fa65 introduced a preprocessor buglet affecting MacOS builds. Change #if to #ifdef. Change-Id: I3d76c83428658abcf382e18066be0e24309ecbba Reviewed-on: https://code.wireshark.org/review/23317 Petri-Dish: Jim Young Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young http://cgit.osmocom.org/wireshark/commit/?id=588590c539b5660e71660645305cb639cb35dc92 commit 588590c539b5660e71660645305cb639cb35dc92 Author: Michael Mann Date: Wed Aug 30 16:01:48 2017 -0400 Read process info table from Netmon files There isn't a place at the moment that uses it, but prepare that use by parsing out the process info table and placing it the netmon private data. Bug: 4224 Ping-Bug: 1184 Change-Id: I6186b3dce0333042357089d8517c8b47b5ff7f70 Reviewed-on: https://code.wireshark.org/review/23316 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c199952f5c66c61d908c5052de9172fe11a3f260 commit c199952f5c66c61d908c5052de9172fe11a3f260 Author: Pascal Quantin Date: Wed Aug 30 15:24:49 2017 +0200 extcap: fix parameters save in preferences file Since g583150198b, extcap_arg structures holds a pointer to the current preference value. So let's not update its value outside of the prefs API otherwise the call to prefs_set_string_value() with pref_current done afterwards will never notify the change and the updated value will not be written in the preference file. Moreover update ExtcapArgument::resetValue() method to have an empty string instead of a NULL pointer. Otherwise prefs_set_string_value() will not notify the change and save the restored default value in the preference file either. Change-Id: Ie70e79d471c75e25705c7654e420a7706ebc4032 Reviewed-on: https://code.wireshark.org/review/23308 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=51789050633fc4554413a6f79439c9162c1c8cfb commit 51789050633fc4554413a6f79439c9162c1c8cfb Author: Martin Kaiser Date: Wed Aug 23 22:16:08 2017 +0200 rpc: remove two unnecessary DISSECTOR_ASSERT()s Their conditions are always true. Both tvb_captured_length_remaining() and tvb_reported_length_remaining() return a gint which is always >= 0. Change-Id: Ic0c13d17361389053466573fafff44b2c2b478ed Reviewed-on: https://code.wireshark.org/review/23186 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=63b66cc7c8a6ec4e28eabd0bea135a70ed707754 commit 63b66cc7c8a6ec4e28eabd0bea135a70ed707754 Author: Martin Kaiser Date: Wed Aug 30 22:49:11 2017 +0200 vxi11: remove some unnecessary NULL checks Change-Id: I6a188a8c3f84284bb9dee406aee124f7e581f643 Reviewed-on: https://code.wireshark.org/review/23315 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8d13f14f958b9ee00b59fd869bd1630f76e6fa65 commit 8d13f14f958b9ee00b59fd869bd1630f76e6fa65 Author: Gerald Combs Date: Wed Aug 30 12:16:51 2017 -0700 Qt: Temporarily disable DP scaling on non-macOS systems. Enable device pixel scaling in QCustomPlot only on macOS. Blind attempt at diagnosing / fixing bug 14012. Change-Id: I95e38eaa072d69aef0fe1d642951603800c3a280 Ping-Bug: 14012 Reviewed-on: https://code.wireshark.org/review/23314 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=541817f63ca3e57bc8b8302602c42d6b745d73ef commit 541817f63ca3e57bc8b8302602c42d6b745d73ef Author: Jo??o Valverde Date: Wed Aug 30 17:21:12 2017 +0100 IPv6: Undo 'ipv6_ws' tap change Previously tapping data did not depend on ipv6_pinfo. Minor code cleanup. Follow up to 71697c5dab92e5be15180c6fb4420fd847e1e539. Change-Id: I2d8ef9603119ceada64a3c64d5f9d6dfffde399d Reviewed-on: https://code.wireshark.org/review/23312 Petri-Dish: Jo??o Valverde Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=63628636af9bf43291711d51e38dc6f5933291ef commit 63628636af9bf43291711d51e38dc6f5933291ef Author: Pascal Quantin Date: Wed Aug 30 18:41:43 2017 +0200 LTE RRC: add SCPTMConfiguration-BR-r14 message to info column Change-Id: I82a5625aecadc670c2b15a0ea21e3e796bcb5e63 Reviewed-on: https://code.wireshark.org/review/23313 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=94ce35a9f9877d3e48db3d800f2493f9944e1b5e commit 94ce35a9f9877d3e48db3d800f2493f9944e1b5e Author: Pascal Quantin Date: Wed Aug 30 16:48:30 2017 +0200 Qt: check QVector size before accessing its content and not after Bug: 14017 Change-Id: Ied38551c78b4593f60165d9e3b04bb3913d6b258 Reviewed-on: https://code.wireshark.org/review/23310 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=71697c5dab92e5be15180c6fb4420fd847e1e539 commit 71697c5dab92e5be15180c6fb4420fd847e1e539 Author: Jo??o Valverde Date: Wed Aug 30 15:14:29 2017 +0100 IPv6: Move duplicate code to update IPv6 dissection state to a function Also make sure to protect ipv6_pinfo access with NULL checks. Change-Id: I9495421c6bf970cb7eaa0415aa1af7effd3e7c79 Reviewed-on: https://code.wireshark.org/review/23309 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=324658271690d7ce4482e039a205ddaca3e1d18c commit 324658271690d7ce4482e039a205ddaca3e1d18c Author: Stig Bj??rlykke Date: Wed Aug 30 10:45:57 2017 +0200 dmp: Improve a sanity check Bug: 14016 Change-Id: I7dd830b143160ddd609013517f1ee3d51aac3c10 Reviewed-on: https://code.wireshark.org/review/23305 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=445c0bb74722d23cac9c61b3f01df6917e01a0be commit 445c0bb74722d23cac9c61b3f01df6917e01a0be Author: AndersBroman Date: Wed Aug 30 10:35:51 2017 +0200 [GSM MAP] Propagate top_tree to external message handlers. Change-Id: Ib3d0a43c0cdeca0ed32ff4dfef13c66e485fb0fb Reviewed-on: https://code.wireshark.org/review/23304 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b2a24177e94ba7302735db68cfc4aff50532a474 commit b2a24177e94ba7302735db68cfc4aff50532a474 Author: Alexis La Goutte Date: Wed Aug 30 08:00:10 2017 +0200 Add P2MP LSP Tunnel IPv4/IPv6 SENDER_TEMPLATE Object Bug: 13977 Change-Id: I716598adbb2a75368d331cd5f705e4d737e55b08 Reviewed-on: https://code.wireshark.org/review/23301 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5830e890bc3612145fcc169fa28548848cea75e1 commit 5830e890bc3612145fcc169fa28548848cea75e1 Author: Alexis La Goutte Date: Wed Aug 30 07:15:02 2017 +0200 RSVP: fix some missing ctype... Change-Id: Ief081f410b6c26b4db3402d63429eba404d05144 Reviewed-on: https://code.wireshark.org/review/23300 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f6b196546546a5c658fb2d8303147f6b7f77e9f6 commit f6b196546546a5c658fb2d8303147f6b7f77e9f6 Author: Alexis La Goutte Date: Wed Aug 30 07:09:31 2017 +0200 RSVP: Add value_string for all ctype Change-Id: I47154026ce77e550de2abecdc9092806418c6137 Reviewed-on: https://code.wireshark.org/review/23299 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=dc64d738005a42aba8d4ba21e9f95c154530de64 commit dc64d738005a42aba8d4ba21e9f95c154530de64 Author: Alexis La Goutte Date: Wed Aug 30 07:06:19 2017 +0000 Revert "Add -Wused-but-marked-unused as an extra warning flag." This reverts commit 1aaa904622245200c179d53d638bdf256cda71ab. Change-Id: I6c783ffa40e5df9a3174cf768906e6d89ad909ef Reviewed-on: https://code.wireshark.org/review/23303 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=b0f253e07c2a90e49166445d165432b4e4cfa17f commit b0f253e07c2a90e49166445d165432b4e4cfa17f Author: Alexis La Goutte Date: Wed Aug 30 07:04:48 2017 +0000 Revert "Add -Wused-but-marked-unused as an extra warning flag." This reverts commit d846a3e8b9908caa65d182b680efb82c56c8103f. Change-Id: I0fb9c44dbbeb2ad0f2a0a57671ca08920fb1af2a Reviewed-on: https://code.wireshark.org/review/23302 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=52823805b29a44a83eacd0e5b415b11227ec313b commit 52823805b29a44a83eacd0e5b415b11227ec313b Author: Michael Mann Date: Fri Aug 25 15:29:17 2017 -0400 Add support for reading comments in Network Monitor files The NetMon wiretap reads the title and description comment fields from a NetMon file and saves it in the wiretap private structure. Then when it's time to make a frame, the comment fields are added to a NetMon pseudoheader with a new WTAP ENCAP type, with the potential for netmon pseudoheader to contain pseudoheader data from "base" wiretap. Then the netmon_header dissector displays the comment fields and passes any "base" wiretap pseudoheader data when calling the wtap_encap dissector table that the frame dissector normally calls. Bug: 4225 Change-Id: I8f772bc9494364c98434c78b61eb5a64012ff3b9 Reviewed-on: https://code.wireshark.org/review/23210 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=32b27bf19d181e4b2b227d13450a9dee9582af2c commit 32b27bf19d181e4b2b227d13450a9dee9582af2c Author: Chris Brandson Date: Tue Aug 29 16:08:00 2017 -0700 ZigBee add missing ZCL status code Change-Id: I3b7ec4758b32057e0a5ea8f23088dabdd7183ec2 Reviewed-on: https://code.wireshark.org/review/23298 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1e0dc0637b33314c14897ea00e2eb32b146141ea commit 1e0dc0637b33314c14897ea00e2eb32b146141ea Author: Deep Datta Date: Wed Aug 9 12:00:52 2017 -0500 Adding new Ixia netflow fields for DNS hostnames and class Change-Id: I850c008f1bd96f313811cf6404acae35496e0c3c Reviewed-on: https://code.wireshark.org/review/23272 Reviewed-by: Martin Mathieson Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot http://cgit.osmocom.org/wireshark/commit/?id=8f3a3914fe3a01001fd1062ac693a5e41a466b59 commit 8f3a3914fe3a01001fd1062ac693a5e41a466b59 Author: Michael Mann Date: Mon Aug 28 21:40:31 2017 -0400 Add Network Monitor Event Tracing event Assigned a WTAP_ENCAP value (WTAP_ENCAP_NETMON_NET_NETEVENT) for the dissection of Event Tracing records inside a NetworkMonitor file. Ping-Bug: 6520 Ping-Bug: 6694 Change-Id: Ib100f3779095842e78f9b7741e80258aa866d818 Reviewed-on: https://code.wireshark.org/review/23278 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f05f4893fa57ceac0ecb6266b9e536266f93aa1b commit f05f4893fa57ceac0ecb6266b9e536266f93aa1b Author: AndersBroman Date: Tue Aug 29 17:03:05 2017 +0200 [ACSE] Get rid of global variable top_tree. Change-Id: I2084c313e778f0895a4f7a58dee445f0e742e78e Reviewed-on: https://code.wireshark.org/review/23290 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Tom???? Kukosa Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ed6239d17ec995ab5eaa51319c1f13fac8ae3a06 commit ed6239d17ec995ab5eaa51319c1f13fac8ae3a06 Author: AndersBroman Date: Tue Aug 29 13:33:01 2017 +0200 [GSM MAP] Get rid of a global variable and use the new dissector_try_uint_new() interface. Change-Id: I714ca04f43c00017969e8655614566df4c53e5e9 Reviewed-on: https://code.wireshark.org/review/23288 Petri-Dish: Anders Broman Reviewed-by: Tom???? Kukosa Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=37d06faed3bc3c4d8ff908993b5f9cfb91e3c1a4 commit 37d06faed3bc3c4d8ff908993b5f9cfb91e3c1a4 Author: AndersBroman Date: Tue Aug 29 17:29:20 2017 +0200 [ANSI TCAP] Get rid of global variable top_tree. Change-Id: Ib3f7794be4c8f38ce556d2e4d61f7df02ba8df1e Reviewed-on: https://code.wireshark.org/review/23291 Petri-Dish: Anders Broman Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=64eea6bb03ec8b861c5e336815e5a6b8233aadcd commit 64eea6bb03ec8b861c5e336815e5a6b8233aadcd Author: Alexis La Goutte Date: Tue Aug 29 07:35:07 2017 +0200 gsm_a_dtap: fix 'pinfo/len/add_string/string_len' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I6f384e510ac77c41b3891958ec5a1b224c040e5d Reviewed-on: https://code.wireshark.org/review/23283 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=91caa91adf42b21945345aee03b68c4e5d881a63 commit 91caa91adf42b21945345aee03b68c4e5d881a63 Author: Alexis La Goutte Date: Tue Aug 29 07:19:50 2017 +0200 gsm_a_common: fix 'pinfo/len' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I831565d624711ebbcaf84b05e3a34dae58e1e064 Reviewed-on: https://code.wireshark.org/review/23282 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4402b67d7de47c52b0d54fcfc0a845609fecba17 commit 4402b67d7de47c52b0d54fcfc0a845609fecba17 Author: Alexis La Goutte Date: Mon Aug 28 19:33:27 2017 +0200 RSVP: Add value_string for all ctype Part 3 Change-Id: I7560f62124a7f20057195c7b3dfde7e6ce4c8f73 Reviewed-on: https://code.wireshark.org/review/23285 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b9ec3e71f647422b0748c3417b511146ba5a688d commit b9ec3e71f647422b0748c3417b511146ba5a688d Author: Alexis La Goutte Date: Tue Aug 29 07:16:12 2017 +0200 gsm_a_bssmap: fix 'len' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Ia575e0a7d036852254327f00129d9060209411a0 Reviewed-on: https://code.wireshark.org/review/23281 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e608345e060d03d63491d40a8a4c3b2291ef0940 commit e608345e060d03d63491d40a8a4c3b2291ef0940 Author: Alexis La Goutte Date: Tue Aug 29 07:07:03 2017 +0200 fcoib: fix 'data' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I5b24af66d982b00bcb0532d8fe31175ca18956cc Reviewed-on: https://code.wireshark.org/review/23280 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6d5fcb7378b89790ab2d3feac0a6579c59b97bef commit 6d5fcb7378b89790ab2d3feac0a6579c59b97bef Author: Jim Young Date: Mon Aug 28 23:32:43 2017 -0500 MIME based pcapng dissector: Fixup apparent copy-and-pasteos. The MIME based pcapng dissector incorrectly displayed the EPB Flags option's link layer error bits. Change-Id: Ia14eec39e2a9c4432e6b3d1c0cee718ad2da1cac Reviewed-on: https://code.wireshark.org/review/23279 Petri-Dish: Jim Young Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fa8a6a3eee3a6ce938cec4c1d8cc0540b27c451a commit fa8a6a3eee3a6ce938cec4c1d8cc0540b27c451a Author: Pascal Quantin Date: Mon Aug 28 21:36:37 2017 +0200 extcap: check that argument parameter is not null before adding it to command line Without this test, we add an argument with an empty parameter Bug: 14006 Change-Id: I7e5313f652691808735f54b533cf5a7f7adeeae1 Reviewed-on: https://code.wireshark.org/review/23271 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=7a71ec887ce78a48933d02e55d3b6d2b3ac49cfb commit 7a71ec887ce78a48933d02e55d3b6d2b3ac49cfb Author: Jim Young Date: Sat Aug 26 22:35:51 2017 -0500 tshark: Add delimiter to both sides of packetlist arrows Depending on how packetlist columns are arranged certain columns may have a Unicode arrow character inserted between it and the subsequent column to indicate source vs destination column directionality when displayed in tshark. Currently any inserted Unicode arrow characters are unconditionally prefaced with an ASCII SPACE character. Tshark's `-T tabs` option causes the various packetlist columns to be delimited with ASCII TAB characters. The unconditional use of the SPACE character before any inserted Unicode arrows makes it difficult to directly compare a -T tabs report of column N values to column N+1 values without dealing with the SPACE/Unicode Arrow suffix appended to all of the column N values. The inserted Unicode directionality arrows are effectively another packetlist column of data that should be delimited like all other columns. This patch ensures that any Unicode directionality arrows inserted between packet list columns are delimited on both sides of the arrows with the selected delimiter character. Change-Id: I4eb7c6015a538afdc2c41be746eca4eec1ace36f Reviewed-on: https://code.wireshark.org/review/23222 Petri-Dish: Jim Young Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=c7290277311f5189e4341c7684e14118f9f21c8b commit c7290277311f5189e4341c7684e14118f9f21c8b Author: Michael Mann Date: Mon Aug 28 12:42:59 2017 +0100 epan: Properly cleanup registered postdissectors wanted_hfids member was never properly freed. Fix indentation too. Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2198 Bug: 13996 Change-Id: I8297df2158fd0ae8123223f4622ae952a218a07a Reviewed-on: https://code.wireshark.org/review/23167 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1f9990b7657332daad0680107d5230e18437f1da commit 1f9990b7657332daad0680107d5230e18437f1da Author: Darien Spencer Date: Tue Aug 1 21:53:06 2017 +0300 NBAP: Refactor information storing per-packet Migrating from static variables to a single struct for information 'carried' between different field in a NBAP packet. Bug: 13879 Bug: 13712 Change-Id: Ie35619d64c4b9a3d5459d528788f74f952e75c11 Reviewed-on: https://code.wireshark.org/review/22902 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f8d0a7f003c2916f08092da01c737294f1944eb8 commit f8d0a7f003c2916f08092da01c737294f1944eb8 Author: Gerald Combs Date: Mon Aug 28 16:10:25 2017 -0700 CMake: We no longer support Visual C++ 2005 or 2008. Change-Id: Ide3688366aa3c38d48ff29224dbfc0fdb7bf1b7a Reviewed-on: https://code.wireshark.org/review/23277 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a303bc1f2982e59885c9787d3f81e1ced4b5f342 commit a303bc1f2982e59885c9787d3f81e1ced4b5f342 Author: Peter Wu Date: Mon Aug 28 12:40:38 2017 +0100 transum: clear the list of wanted hfids in file cleanup routine Be sure to disable the wanted hfids list when the transum dissector is cleaned up, otherwise it will leak memory when reloading a file while the transum dissector is enabled. Change-Id: I2af8edab89da8b3cfb65e19726e1d2546a1dc8d4 Reviewed-on: https://code.wireshark.org/review/23261 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6cd7d99cb98c17c593948753d2a3b2a65d4f6040 commit 6cd7d99cb98c17c593948753d2a3b2a65d4f6040 Author: Peter Wu Date: Fri Aug 25 18:37:25 2017 -0700 snort: do not unconditionally prime tcp.reassembled_in Priming has some side-effects, do not do it unless the user explicitly enables a preference. This transfers the owernship of wanted_hfids to set_postdissector_wanted_hfids. Ping-Bug: 13996 Change-Id: I77389f54d9a505cf6f2e4deb5f6ee6e508417270 Reviewed-on: https://code.wireshark.org/review/23231 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b3f5700ed4f3d5913d94dd0920fbc9df57adb090 commit b3f5700ed4f3d5913d94dd0920fbc9df57adb090 Author: Jakub Zawadzki Date: Mon Aug 28 20:24:08 2017 +0200 sharkd: handle PREF_SAVE_FILENAME, PREF_OPEN_FILENAME, PREF_DIRNAME in dumpconf. Change-Id: I17c13c274ebd31da7d7a7ebe02821cf09f77f66c Reviewed-on: https://code.wireshark.org/review/23268 Petri-Dish: Jakub Zawadzki Tested-by: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c9d05548405c6cc5c58dbede2e531c46732e009a commit c9d05548405c6cc5c58dbede2e531c46732e009a Author: Gerald Combs Date: Mon Aug 28 10:30:05 2017 -0700 PNIO: Fix another potential OOB write. Bug: 13847 Change-Id: I62bb519b8e37112a59a7d209b39780f034dbcd0c Reviewed-on: https://code.wireshark.org/review/23267 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0f9935e9a145535a7bb996fbfd8b1d24c762210c commit 0f9935e9a145535a7bb996fbfd8b1d24c762210c Author: Gerald Combs Date: Mon Aug 28 14:02:46 2017 -0700 WSDG: Fix up some markup. Change-Id: I1484e63fd9626ed507ff0077073c944cf85e3602 Reviewed-on: https://code.wireshark.org/review/23273 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=26de091d1be961570fade436de18f8422b89358f commit 26de091d1be961570fade436de18f8422b89358f Author: Peter Wu Date: Sun Aug 27 22:07:55 2017 +0100 cmake: add ENABLE_NGHTTP2 option Allow nghttp2 to be disabled, similar to --without-nghttp2. Change-Id: Id27ab12ef7c24a535824f762ce2feb20fba9e065 Reviewed-on: https://code.wireshark.org/review/23247 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=464679f80f60173589b6f3476abc1e6177d1a43f commit 464679f80f60173589b6f3476abc1e6177d1a43f Author: Stig Bj??rlykke Date: Mon Aug 28 15:27:41 2017 +0200 extcap: Close control handles when done Ensure the event handles are closed when done to avoid leakages. Also improved the control reader to use WaitForSingleObject(). Change-Id: I1679d9c09e247b28117ec05c3e1b0f3ba0e99674 Ping-Bug: 13833 Reviewed-on: https://code.wireshark.org/review/23263 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=287221e8d9591bf252392ec34959e24c49fcd275 commit 287221e8d9591bf252392ec34959e24c49fcd275 Author: Mikael Kanstrup Date: Mon Aug 28 15:26:42 2017 +0200 Free interface_options elements on cleanup At shutdown the array keeping all interface_options is freed. The array elements however are not making valgrind and ASAN complain. Make sure the elements are freed on cleanup. Ping-Bug: 13864 Change-Id: If8b810ea5f4f11c5ce770a9ffa6c2c791bc561fe Reviewed-on: https://code.wireshark.org/review/23265 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=879920a2ebaacf33e554ab47e340c34fe2e878d8 commit 879920a2ebaacf33e554ab47e340c34fe2e878d8 Author: Mikael Kanstrup Date: Mon Aug 28 10:38:31 2017 +0200 iface_lists: Remove locked field It seems the locked field of interface_t was used to avoid simultaneous updates of interface entries from either multiple threads or most likely the recursive UI update callbacks case later identified. Since 802362e ("Avoid recursive scan_local_interfaces operation") the recursive callback behavior is no longer happening. And as code does not have consistent checks the locked field can anyway hardly protect a multi-threaded case if such a case exists. Remove the unnecessary locked field. Ping-Bug: 13864 Change-Id: Idc393f702b82aa6014dd636572d00f0d67120bf3 Reviewed-on: https://code.wireshark.org/review/23262 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=8646596829494dbe054a18958eac68682ba42721 commit 8646596829494dbe054a18958eac68682ba42721 Author: Mikael Kanstrup Date: Fri Aug 25 13:58:20 2017 +0200 Fix leaks when active capture interface goes down If an interface goes down while packet capture is ongoing related interface_option element is not freed properly. Fix by using the appropriate free function that both remove the element and frees element members. Ping-Bug: 13864 Change-Id: I66a11d64615dc9648441b532e4ff658ea42a5acf Reviewed-on: https://code.wireshark.org/review/23205 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=752c48f8643935cd859a794e53e4a9f4fba73b03 commit 752c48f8643935cd859a794e53e4a9f4fba73b03 Author: Gerald Combs Date: Mon Aug 28 09:05:12 2017 -0700 Remove README.vmware The issues it discusses were relevant in 2000 but have long since been fixed. Change-Id: I6284950670eba86849288bf9c88f3d22c622bdd0 Reviewed-on: https://code.wireshark.org/review/23266 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=f763a7d15407d289ba8356ff7528a53c6f0ae6ce commit f763a7d15407d289ba8356ff7528a53c6f0ae6ce Author: Gerald Combs Date: Tue Aug 22 17:20:32 2017 -0700 Note that we probably don't support HP-UX. (The bulk of this was written between 1999 and 2005, and hasn't been updated since. Should we just remove it?) Change-Id: I6c43a876cf1b4db0b1b2761323fee67377b384c3 Reviewed-on: https://code.wireshark.org/review/23166 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=3b16cc8b219e087e6b8cc8898ed8e4d58263d326 commit 3b16cc8b219e087e6b8cc8898ed8e4d58263d326 Author: Mikael Kanstrup Date: Fri Aug 25 11:27:38 2017 +0200 iface_lists: Access ifaces member by reference Change access of ifaces elements from by val to by reference. With this change unnecessary copying of the whole struct is avoided but even more important is that elements no longer have to be removed and inserted whenever data is updated. This change aims to make it more clear that ifaces elements shall never directly be removed from the array. Instead use function capture_opts_del_iface NOTE: Code for GTK UI not updated Ping-Bug: 13864 Change-Id: I04b65d5ee36526b30d959b8e5a2a48a3c7c4f15b Reviewed-on: https://code.wireshark.org/review/23204 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=81c48eacccbeb3466e607c0f708f38869da70491 commit 81c48eacccbeb3466e607c0f708f38869da70491 Author: Mikael Kanstrup Date: Fri Aug 25 10:24:36 2017 +0200 Fix leak when removing interfaces from manage interfaces dialog When removing interfaces from the manage interfaces dialog the interface elements where not freed properly causing leaks. Free the interface element when removed from the array. Ping-Bug: 13864 Change-Id: I6beb222a5475278cfc6cb454a7c8b2c86f636f38 Reviewed-on: https://code.wireshark.org/review/23203 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e26926432d163cd835b7f8f1ab51e084c04050b7 commit e26926432d163cd835b7f8f1ab51e084c04050b7 Author: Mikael Kanstrup Date: Fri Aug 25 10:14:15 2017 +0200 Free interface elements on cleanup At shutdown the array keeping all network interfaces is freed. The array elements however are not making valgrind and ASAN complain. Make sure the elements are freed on cleanup. Ping-Bug: 13864 Change-Id: I1efeb03f42fb6f0b87dada8ef50d85f47f93e0dc Reviewed-on: https://code.wireshark.org/review/23202 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8873c7e494018637449a17a7f7ddaf88ad43f3c6 commit 8873c7e494018637449a17a7f7ddaf88ad43f3c6 Author: Mikael Kanstrup Date: Thu Aug 24 16:16:34 2017 +0200 iface_lists: Access all_ifaces member by reference Change access of all_ifaces elements from by val to by reference. With this change unnecessary copying of the whole struct is avoided but even more important is that elements no longer have to be removed and inserted whenever data is updated. This change aims to make it more clear that all_ifaces elements shall never be removed from the array without freeing resources via the capture_opts_free_interface_t function. NOTE: Code for GTK UI not updated Ping-Bug: 13864 Change-Id: I36742cb1d5c8daa136c9d3732a044a7c8e5c7fe7 Reviewed-on: https://code.wireshark.org/review/23201 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=76c231bd683410bed4fa803bcbc91e613e201ab0 commit 76c231bd683410bed4fa803bcbc91e613e201ab0 Author: Alexis La Goutte Date: Mon Aug 28 06:52:03 2017 +0200 OSPF: fix LSA type filter Bug: 13979 Change-Id: Ibf0229aba48cdb8d2d4c30c17723be4bb9cca476 Reviewed-on: https://code.wireshark.org/review/23253 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=405a5335ef12e4f2e7b661e9a7b3d5b33ab99629 commit 405a5335ef12e4f2e7b661e9a7b3d5b33ab99629 Author: Alexis La Goutte Date: Tue Aug 22 11:29:20 2017 +0200 RSVP: Add value_string for all ctype Change-Id: I1bbbbceccaa6883f36741b0e4c3d5b8cfb0204fc Reviewed-on: https://code.wireshark.org/review/23252 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=12c04e05294d86d7c036cb3e866ae62f50ac5ba9 commit 12c04e05294d86d7c036cb3e866ae62f50ac5ba9 Author: Stig Bj??rlykke Date: Mon Aug 28 08:36:03 2017 +0200 Qt: Fix build without libpcap Change-Id: I9b9b5de1beb23486ccc000feda54c2b20a33f4ad Reviewed-on: https://code.wireshark.org/review/23251 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=74a79b28b0a8c43ff6e198fc1993a40032a3d907 commit 74a79b28b0a8c43ff6e198fc1993a40032a3d907 Author: Alexis La Goutte Date: Sun Aug 27 17:50:53 2017 +0200 infiniband: fix bitmap for Remote CM Response Timeout / Transport Service Type Issue reported by Yao Lin Ping-Bug: 13997 Change-Id: Ia90e58826c228500da0177fa2b8b90ec9ec2ff74 Reviewed-on: https://code.wireshark.org/review/23237 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=db04fef13fb57050f47994beaad3115dc174746e commit db04fef13fb57050f47994beaad3115dc174746e Author: Peter Wu Date: Fri Aug 25 18:32:59 2017 -0700 prefs: fix memleaks with obsolete preference modules ASAN reported a memleak in the USB CCID dissector due to the use of prefs_register_protocol_obsolete which caused prefs_cleanup to skip freeing preferences inside such modules. Change-Id: Ib4aecb3a722f958a8a1c5fc636703c1ec977f0cd Reviewed-on: https://code.wireshark.org/review/23230 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=018f6bff18785a1c3971a1ccfe3b1b5243d4d154 commit 018f6bff18785a1c3971a1ccfe3b1b5243d4d154 Author: H??kon ??ye Amundsen Date: Fri Aug 25 11:28:34 2017 +0200 extcap: Interface Toolbar support on Windows Add support for extcap control pipes on Windows. Improved read loop in InterfaceToolbarReader. Delay opening control pipes until extcap has opened the fifo pipe. Make extcap_example.py work on Windows. Bug: 13833 Change-Id: I4b47d25452637759b8a3be53be48eee5365bc0e4 Reviewed-on: https://code.wireshark.org/review/23211 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7aeff4fb904e67ce8f81053f595b8a8b0340cb52 commit 7aeff4fb904e67ce8f81053f595b8a8b0340cb52 Author: Alexis La Goutte Date: Sun Aug 27 12:22:22 2017 +0200 Revert "infiniband: swap Local CM Response Timeout / Retry Count field" Follow the order of spec This reverts commit 4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3. Change-Id: Ifeaf2c68813f8c452b6ab0247cd7a4313c95f619 Reviewed-on: https://code.wireshark.org/review/23236 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=231f3ea77440714384b9b2b0291736e5334b7f0e commit 231f3ea77440714384b9b2b0291736e5334b7f0e Author: Alexis La Goutte Date: Sun Aug 27 19:21:00 2017 +0200 gsm_a_bssmap: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I041b7c9363e75f0ec54ea29ea3d39e92f6ce8b6a Reviewed-on: https://code.wireshark.org/review/23239 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1aaa904622245200c179d53d638bdf256cda71ab commit 1aaa904622245200c179d53d638bdf256cda71ab Author: Guy Harris Date: Sun Aug 27 14:19:39 2017 -0700 Add -Wused-but-marked-unused as an extra warning flag. We can't just turn it on yet, because that would require generators to know which generated functions use which parameters and mark only the unused ones as such. The generator that turns PIDL files into DCE RPC dissectors is one that would have to be fixed. Change-Id: I7b0e9b08de6e7e9e611143de7307d3323a5c913e Reviewed-on: https://code.wireshark.org/review/23249 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=d846a3e8b9908caa65d182b680efb82c56c8103f commit d846a3e8b9908caa65d182b680efb82c56c8103f Author: Guy Harris Date: Sun Aug 27 13:55:14 2017 -0700 Add -Wused-but-marked-unused as an extra warning flag. We can't just turn it on yet, because that would require generators to know which generated functions use which parameters and mark only the unused ones as such. The generator that turns PIDL files into DCE RPC dissectors is one that would have to be fixed. Change-Id: I42013c8983d01fd3eca4026358b37ba043f12190 Reviewed-on: https://code.wireshark.org/review/23246 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ef3b7a3394d918a7abebbd410a3525fd3b212ba3 commit ef3b7a3394d918a7abebbd410a3525fd3b212ba3 Author: Guy Harris Date: Sun Aug 27 13:49:04 2017 -0700 err_info is used, so don't mark it unused. Change-Id: Ibd89fcb8e9fc2aa7e368eb8723fb367db5e8d11e Reviewed-on: https://code.wireshark.org/review/23245 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1dc62c573e0c0a90ce34b6cbf2735c929f970c31 commit 1dc62c573e0c0a90ce34b6cbf2735c929f970c31 Author: Guy Harris Date: Sun Aug 27 13:47:22 2017 -0700 pinfo is used, so don't mark it unused. Change-Id: Ife237343cdf051be836c2e2d3de1b00fc3902708 Reviewed-on: https://code.wireshark.org/review/23244 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=837c42d264ace217d23ca3a67ad19bf819e0690b commit 837c42d264ace217d23ca3a67ad19bf819e0690b Author: Alexis La Goutte Date: Sun Aug 27 19:24:14 2017 +0200 diameter_3gpp: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Iefec98b1bbb47eec4df684933df4b44197dd9164 Reviewed-on: https://code.wireshark.org/review/23242 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=74d39b2aa6360f2a5313901c861b0faa098b4c48 commit 74d39b2aa6360f2a5313901c861b0faa098b4c48 Author: Alexis La Goutte Date: Sun Aug 27 19:25:57 2017 +0200 dpnet: fix 'tree' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Ib90069304e384b707fc64fd68ef52db108758917 Reviewed-on: https://code.wireshark.org/review/23243 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=af66f17fb463ece6f7b5ef28bc99d98f413f12e7 commit af66f17fb463ece6f7b5ef28bc99d98f413f12e7 Author: Alexis La Goutte Date: Sun Aug 27 19:22:29 2017 +0200 cfm: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I046a37a07cdaad6db2132efbfbbc9dbfa0055bec Reviewed-on: https://code.wireshark.org/review/23240 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=8d42f0fd09ddd6039c6c9344157668cfd44c21cb commit 8d42f0fd09ddd6039c6c9344157668cfd44c21cb Author: Alexis La Goutte Date: Sun Aug 27 19:23:20 2017 +0200 devicenet: fix 'buf_len' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Id16edc055ed675076fe015b84bf37f1bef90ddbf Reviewed-on: https://code.wireshark.org/review/23241 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=f3ba318e099f62aea51718b73e8e817482beab51 commit f3ba318e099f62aea51718b73e8e817482beab51 Author: Peter Wu Date: Fri Aug 25 11:19:06 2017 -0700 Lua: fix crash on invalid Dissector.list("food") invocation The Dissector.list, Listener.list and Field.list functions do not accept a parameter. Passing one however results in a crash because the first element is not the expected table, but the first function parameter. Change-Id: I8483d0aa20716045472f30f5b41a449bed549b05 Reviewed-on: https://code.wireshark.org/review/23209 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=22252978a4ec46ce8a0186dc31761293932a8abc commit 22252978a4ec46ce8a0186dc31761293932a8abc Author: Alexis La Goutte Date: Sat Aug 26 10:17:16 2017 +0200 nvme: fix wrong encoding for SQ Header Point Need to use LITTLE_ENDIAN Bug: 14008 Change-Id: I3697bb53e0832a9465e8be465b3587e9b78d2f0d Reviewed-on: https://code.wireshark.org/review/23229 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9bb96969bab1e3fcadd7ee74df69c5079bbe6235 commit 9bb96969bab1e3fcadd7ee74df69c5079bbe6235 Author: Gerald Combs Date: Sun Aug 27 08:07:00 2017 +0000 [Automatic update for 2017-08-27] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ia4e22a8679dc08ee4f260fe6168678f7dd11f2eb Reviewed-on: https://code.wireshark.org/review/23224 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=fb1acc778d6e71cbeb5f512a8f8fb179b4fdf46e commit fb1acc778d6e71cbeb5f512a8f8fb179b4fdf46e Author: Pascal Quantin Date: Sat Aug 26 22:32:58 2017 +0200 Update USBPcap to 1.2.0.3 Change-Id: Ie5dbe818e214738ea8e82fe7d72fc8a20b30691b Reviewed-on: https://code.wireshark.org/review/23221 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=a08e998ca2e7a8229da7f8b292dad94734977f33 commit a08e998ca2e7a8229da7f8b292dad94734977f33 Author: Darien Spencer Date: Sun Aug 20 21:38:32 2017 +0300 NBAP: Replaced a comment Edited a comment to explain the usage of the 'hs-dsch physical layer category' field Change-Id: I400eabd764818bbc39ab1128500b8700647175e3 Reviewed-on: https://code.wireshark.org/review/23218 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9cd114fbe5d622ef7345259d143b4e09f5c0e6eb commit 9cd114fbe5d622ef7345259d143b4e09f5c0e6eb Author: Stig Bj??rlykke Date: Sat Aug 26 11:21:52 2017 +0200 wiretap: Add WTAP_ENCAP_NORDIC_BLE Use this for nordic_ble dissection. Change-Id: I5323cbd8c244c4e3b645825c60d040e1ae8f3b81 Reviewed-on: https://code.wireshark.org/review/23219 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=50227b0f6efb9ef56ff8a7fa85a9d6011012a201 commit 50227b0f6efb9ef56ff8a7fa85a9d6011012a201 Author: Alexis La Goutte Date: Fri Aug 25 13:50:42 2017 +0200 infiniband: fix infiniband: sIP and dIP inside IP CM Private Data are decoded in the wrong order Issue reported by Yao Lin Bug: 14002 Change-Id: Ib49f74edbaac4830340fb9d7dba5105f0bdeb2f1 Reviewed-on: https://code.wireshark.org/review/23200 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=166d95e7cbe9b27b070ac03829f4d8add3a1945e commit 166d95e7cbe9b27b070ac03829f4d8add3a1945e Author: Darien Spencer Date: Fri Aug 25 17:22:14 2017 +0300 FP: Refactored duplicate code The 'get packet info from conversation' code was shared in both the 'if' and 'else' cases Also fixed a comment about the packet's direction Change-Id: I83568a5be7cba094aea925bdbc70479e50377477 Reviewed-on: https://code.wireshark.org/review/23207 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b1a041898333a8d38387dca4fa6d509881845072 commit b1a041898333a8d38387dca4fa6d509881845072 Author: Mikael Kanstrup Date: Fri Aug 25 14:05:42 2017 +0200 Fix leaked timestamp records Valgrind reports leaked timestamp records. A comment stated that the timestamp info members only contain static data. That claim was only true for some cases, not all so make all cases allocate memory and have them properly freed when removed. Fixes: aca55a2 ("Add hardware timestamping support") Change-Id: I31e4689070019ad1f531008394e7d6e48318c70c Reviewed-on: https://code.wireshark.org/review/23206 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=9ae80aea082384605e647f55fbc4d2910811a929 commit 9ae80aea082384605e647f55fbc4d2910811a929 Author: Gerald Combs Date: Fri Aug 25 10:20:59 2017 -0700 CMake: Package list updates. Move gcrypt to the required package section. Fold the various xxx_REQUIRED variables into xxx_OPTIONS. Change-Id: Ib4220d7344e2bbac9062465d175921733bb0fe52 Reviewed-on: https://code.wireshark.org/review/23208 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=659b95765cd0fd213ba301c2162ec525422f8ff3 commit 659b95765cd0fd213ba301c2162ec525422f8ff3 Author: Alexis La Goutte Date: Fri Aug 25 11:35:25 2017 +0000 zbee-zcl: fix parameter 'cluster_id/dir' not found in the function declaration [-Wdocumentation] Change-Id: I9b0f7d0eefe932e00629269a85ede612438354cf Reviewed-on: https://code.wireshark.org/review/23199 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=29e92fef556c8abd2e94fc0cf552a651a4788163 commit 29e92fef556c8abd2e94fc0cf552a651a4788163 Author: Sergey Avseyev Date: Fri Aug 25 10:51:49 2017 +0300 couchbase: update HELLO features Change-Id: Icff1932cd41334fcf04016f3616a99ac4293ebef Reviewed-on: https://code.wireshark.org/review/23198 Petri-Dish: Alexis La Goutte Reviewed-by: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1e2c0ed5ea08fa32b2f89ba34c9cf63fe07de281 commit 1e2c0ed5ea08fa32b2f89ba34c9cf63fe07de281 Author: Alexis La Goutte Date: Fri Aug 25 07:56:21 2017 +0200 802.11: fix display of PMK-KO (R0KH-ID) Issue reported by Spice Boy Bug: 14004 Change-Id: If49ec807ee54b8991653b7a3584baade59069894 Reviewed-on: https://code.wireshark.org/review/23197 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3 commit 4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3 Author: Alexis La Goutte Date: Thu Aug 24 08:05:01 2017 +0200 infiniband: swap Local CM Response Timeout / Retry Count field Change-Id: Id693a83292ac7c3683a8e24a58dd452d828125d7 Ping-Bug: 13997 Reviewed-on: https://code.wireshark.org/review/23189 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a101aa9d99849b2316c0f9a59ca265511a72185a commit a101aa9d99849b2316c0f9a59ca265511a72185a Author: Dylan Ulis Date: Thu Aug 24 21:56:45 2017 -0400 btatt: Fix request response arrows Change-Id: I40f61a8b8319605035f2a5c3685a3e8561d76921 Reviewed-on: https://code.wireshark.org/review/23196 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2d1bb2b66195c9cae7599f2333755fd1bd0f9395 commit 2d1bb2b66195c9cae7599f2333755fd1bd0f9395 Author: Chris Bontje Date: Thu Aug 24 08:41:44 2017 -0600 [packet-selfm] - Fix dissection of multiple PDUs in single packet with no Fast Meter config data present. Change-Id: I69cc2430e2f75d297f4bee3397c191d6f8e9091f Reviewed-on: https://code.wireshark.org/review/23194 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=cf6a3deae44c8ff8f5b6a21e590ab7956b24fd27 commit cf6a3deae44c8ff8f5b6a21e590ab7956b24fd27 Author: Alexis La Goutte Date: Thu Aug 24 08:00:25 2017 +0200 GTP: fix wrong bitmap for gtp.ext_comm_flags_II_pmtsmi field Issue reported by Sudarshan Chettri Bug: 14001 Change-Id: I03a37adb6e77201191f424b300fa917bf11afac4 Reviewed-on: https://code.wireshark.org/review/23188 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b9307c1ac86019ae94e190f6b195b9f55129a4d8 commit b9307c1ac86019ae94e190f6b195b9f55129a4d8 Author: Stig Bj??rlykke Date: Thu Aug 24 09:51:04 2017 +0200 nordic_ble: Fix calculating delta time start to start The calculation must be based on the length of the previous packet, not the last packet selected in the list. Also mark this entry as generated. Change-Id: I2e0a30ce28f5824f73ffe2d90d3043ff309292dc Reviewed-on: https://code.wireshark.org/review/23191 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=155ffc993d61cc6cd9be09d07fc148dfff01c27c commit 155ffc993d61cc6cd9be09d07fc148dfff01c27c Author: AndersBroman Date: Thu Aug 24 09:57:36 2017 +0200 [BSSGP] Handle Overload msg and code cleanup. Change-Id: I625030263675b014b2d42cc04aef6794354b2893 Reviewed-on: https://code.wireshark.org/review/23192 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=274bbd5fab970c5a2048f9d00bb4e441cd68d04a commit 274bbd5fab970c5a2048f9d00bb4e441cd68d04a Author: Michael Mann Date: Sun Aug 20 13:33:53 2017 -0400 Extract the "long name" out of the manuf file and use it for some resolution Some places (like MAC resolution) want to keep a fixed length, but for places that want to display "full organization name", save the long name that is treated as a comment in the manuf file. Have make-manuf convert companies with all caps to mixed case so we're not screaming the company name at the user. Convert the manuf.tmpl to be tab delimited without a comment for the "long name" so it can match the format now created by make-manuf. Remove uint_get_manuf_name as it was unnecessary. Bug: 3666 Change-Id: If2af5a1ce64e2784fe3941eeae8d8093d4f1467b Reviewed-on: https://code.wireshark.org/review/23150 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e624445adff8aa10ca6663e653b13ecd5c7db8d2 commit e624445adff8aa10ca6663e653b13ecd5c7db8d2 Author: Alexis La Goutte Date: Wed Aug 23 21:01:17 2017 +0200 infiniband: fix bitmap for Local CM Response Timeout / Retry Count Issue reported by Yao Lin Ping-Bug: 13997 Change-Id: I84fbf70b1871ce740f52b1b9dd9c1b8ed2af41e3 Reviewed-on: https://code.wireshark.org/review/23183 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9dbfa6a1ea5a12bbb899a2e1ada032e227289677 commit 9dbfa6a1ea5a12bbb899a2e1ada032e227289677 Author: Martin Kaiser Date: Wed Aug 23 21:53:42 2017 +0200 rpc: remove some unnecessary NULL checks Change-Id: I956f0dbbd6b3cdbf8c0e4b9d81e0bd6408874b5b Reviewed-on: https://code.wireshark.org/review/23185 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=af180cc7d050e821825f3f4a2e96607b67704a39 commit af180cc7d050e821825f3f4a2e96607b67704a39 Author: Gerald Combs Date: Wed Aug 23 14:46:24 2017 -0700 Update the AsciiDoc button macro name. Change the name of the button macro to "btn" in order to be compatible with AsciiDoctor. Change-Id: I673e0fe0ae7b343abeb1afba0b9b11402efdf0d6 Reviewed-on: https://code.wireshark.org/review/23187 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=f8ea11ff461c266e8f3746de12ba293932dcff0c commit f8ea11ff461c266e8f3746de12ba293932dcff0c Author: Jo??o Valverde Date: Wed Aug 23 15:29:58 2017 +0100 RADIUS: Add comment for RFC 6929 preference Change-Id: I084923204cd1017f9e50052b41106ab44dc9b1af Reviewed-on: https://code.wireshark.org/review/23176 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=41d94798a941f0df6ae1a647cee2671f4e03929d commit 41d94798a941f0df6ae1a647cee2671f4e03929d Author: Gerald Combs Date: Wed Aug 23 11:49:28 2017 -0700 Docbook: Fix a couple of include paths. Change-Id: I1b06658f516a17516782df57943d7082badba755 Reviewed-on: https://code.wireshark.org/review/23182 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=dd83b24f222a2a935cad3b6a646fecaf6790afbd commit dd83b24f222a2a935cad3b6a646fecaf6790afbd Author: Phil Beeson Date: Wed Aug 23 08:08:55 2017 +0200 BTLE: fix bitmap for link data Hop / Sleep Clock Accuracy Bug: 13990 Change-Id: I4d5acaf580adbe2c5bff1aac3d2837a8842cd519 Reviewed-on: https://code.wireshark.org/review/23172 Petri-Dish: Alexis La Goutte Reviewed-by: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7e21263d0b86c221d27f17922f46322b08308268 commit 7e21263d0b86c221d27f17922f46322b08308268 Author: Gerald Combs Date: Wed Aug 23 09:32:05 2017 -0700 Update WinSparkle to 0.5.6. Change-Id: I93d95bba740bb3e0a4754ec71460f30ef1e45a9a Reviewed-on: https://code.wireshark.org/review/23178 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=45401950257ec58d01efefdbc53149739c7785e4 commit 45401950257ec58d01efefdbc53149739c7785e4 Author: Stig Bj??rlykke Date: Sat Aug 19 23:39:21 2017 +0200 extcap: Create unique pipe names for each interface On Windows the pipe names does not get random characters appended. Add the interface name and pipe type to make it unique. This partly fixes the issue with capturing from multiple extcap interfaces on Windows. Ping-Bug: 13653 Ping-Bug: 13833 Change-Id: I4290b37cf789bf77608993682a803aca29513d28 Reviewed-on: https://code.wireshark.org/review/23158 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5574b78dae2f607d4ace66ab60d516d0c569357d commit 5574b78dae2f607d4ace66ab60d516d0c569357d Author: Ulf Date: Tue Aug 22 21:52:29 2017 -0400 Fix potential oob write crashes Bug: 13847 Change-Id: I3a706db25204fe4c1fd1b7be3b17b8c55365dccf Reviewed-on: https://code.wireshark.org/review/23169 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5c27cb5f83cb2c89cf470a6203fe057d3fa7e322 commit 5c27cb5f83cb2c89cf470a6203fe057d3fa7e322 Author: Michael Mann Date: Tue Aug 22 20:38:55 2017 -0400 packet-bgp.c: using wmem_packet_scope() for decode_evpn_nlri_esi https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2736 Bug: 13995 Change-Id: Ia304251249e023a77a8fa3a650ef1640c3c2f314 Reviewed-on: https://code.wireshark.org/review/23168 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f61c45acf145d9d0782d3c1b2a729097983582aa commit f61c45acf145d9d0782d3c1b2a729097983582aa Author: Gerald Combs Date: Tue Aug 22 10:33:49 2017 -0700 Fix a typo. Change-Id: I26fb82c00ef3ac1343930e473294a3aa338f3f96 Reviewed-on: https://code.wireshark.org/review/23164 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=257f738a0da4e03b97b7f58c9363d991c5537dab commit 257f738a0da4e03b97b7f58c9363d991c5537dab Author: Guy Harris Date: Tue Aug 22 10:37:46 2017 -0700 Use the Wayback Machine for the PDML spec. It's not available at the old URL any more. Change-Id: Id8baba5e02cf0e3227365f53a11caa054ef2c40f Reviewed-on: https://code.wireshark.org/review/23165 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b3f6e8cb78ed7c87cdb0e65a406f2d32f627a63c commit b3f6e8cb78ed7c87cdb0e65a406f2d32f627a63c Author: Dario Lombardo Date: Tue Aug 22 16:09:48 2017 +0200 commandline: fix compilation without pcap. Change-Id: I37b9dd3f9515948a5ccf72cd2fd76fc1251c9294 Reviewed-on: https://code.wireshark.org/review/23161 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7b44ff084a49a09dcbe10872f4302f3a4232edc9 commit 7b44ff084a49a09dcbe10872f4302f3a4232edc9 Author: Dario Lombardo Date: Tue Aug 22 16:10:06 2017 +0200 Qt: fix compilation without pcap. Change-Id: I277059e018a41ea011043d255508db4c5f05f63d Reviewed-on: https://code.wireshark.org/review/23162 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=be69761c78d0c285f88ea6b2da0399fcecf9d782 commit be69761c78d0c285f88ea6b2da0399fcecf9d782 Author: Ahmad Fatoum Date: Tue Aug 22 11:00:28 2017 +0200 Fix requesting hardware timestamps without -k The interface_options struct passed to dumpcap is populated differently when running Wireshark with and without -k. Previously, only with -k was there a valid pointer in interface_opts.timestamp_type Fixes: aca55a2 ("Add hardware timestamping support") Signed-off-by: Ahmad Fatoum Change-Id: Ic7ecc5a1190c28197d6a7271f1b353f74d43ca61 Reviewed-on: https://code.wireshark.org/review/23160 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a34445c1cf340a5e617464aec4042df447327de5 commit a34445c1cf340a5e617464aec4042df447327de5 Author: Gerald Combs Date: Fri Aug 18 12:32:17 2017 -0700 WSUG+WSDG: Add a typographic conventions section. Create a common_src directory for common guide content. Add a typographic convention section. Update some of the content accordingly. Change-Id: I4f69c0f52a985c48e07fa0628b19734ec691f74e Reviewed-on: https://code.wireshark.org/review/23131 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=aca55a29f7b982e7a0bd9911d1d176561c8d7a84 commit aca55a29f7b982e7a0bd9911d1d176561c8d7a84 Author: Ahmad Fatoum Date: Mon Aug 7 16:38:52 2017 +0200 Add hardware timestamping support pcap provides a pcap_set_tstamp_type function, which can be used to request hardware timestamps from a supporting kernel. This patch adds support for aforementioned function as well as two new command line options to dumpcap, wireshark and tshark: --list-time-stamp-types List time stamp types supported for the interface --time-stamp-type Change the interface's timestamp method Name choice mimics those used by tcpdump(1), which already supports this feature. However, unlike tcpdump, we provide both options unconditionally. If Wireshark was configured without pcap_set_tstamp_type being available, --list-time-stamp-types reports an empty list. Change-Id: I418a4b2b84cb01949cd262aad0ad8427f5ac0652 Signed-off-by: Ahmad Fatoum Reviewed-on: https://code.wireshark.org/review/23113 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2845f6be8db0b1720e23db0877ec837f00967bdc commit 2845f6be8db0b1720e23db0877ec837f00967bdc Author: Ryan Doyle Date: Sun Aug 20 15:15:28 2017 +1000 HTTP2: pass in the media type parameters to the media type dissector A full media type could be "text/html; charset=utf-8". The the media type dissector wasn't being called properly with only the "text/html" but instead the whole string. Additionally, make sure that the media type parameters are passed in correctly which is important for things like multipart/* which should have a boundary. Most of the string parsing code was adapted from packet-spdy.c:spdy_parse_content_type(). Change-Id: Ide59da8f65264dc142e0f9bb67671ce2af66c8a2 Reviewed-on: https://code.wireshark.org/review/23140 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9d27248cdfce6720639707170d59c5725033276d commit 9d27248cdfce6720639707170d59c5725033276d Author: Darien Spencer Date: Sat Aug 19 21:28:28 2017 +0300 GSMTAP: Add UMTS RRC message type field Showing a description of the 'sub_type' in the fields tree for RRC payloads. Change-Id: Ie4fd4498690db27d4b996fff99fa74b676be9ddb Reviewed-on: https://code.wireshark.org/review/23133 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c11ceb3a0da74711f8fd9fa6598d5d6fab5ff57b commit c11ceb3a0da74711f8fd9fa6598d5d6fab5ff57b Author: Martin Kaiser Date: Mon Aug 21 22:34:50 2017 +0200 rpc: remove unnecessary NULL check call_dissect_function() does already check internally if dissect_function is NULL Change-Id: I4780733ee38bcde74b498bedb1031eefa3c07da4 Reviewed-on: https://code.wireshark.org/review/23159 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a0b2a5989d80486916438a42364f50b46d1b0645 commit a0b2a5989d80486916438a42364f50b46d1b0645 Author: Diederik de Groot Date: Sun Aug 20 23:24:22 2017 +0200 [skinny]: minor changes to xml file - Fix/syncronise spelling for similar field types - Fix cog.py script invocation Change-Id: Iab6d8ac6414c1ba9b97c49d7d0a4d2609eb1a55b Reviewed-on: https://code.wireshark.org/review/23153 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fa390fa8f388efbc1859d22663e1694739ad77eb commit fa390fa8f388efbc1859d22663e1694739ad77eb Author: Anthony Coddington Date: Fri Aug 18 20:51:14 2017 +1200 Fix bit depth of color psml and pdml xml attributes color_t is 16-bit per channel, the print string assumes the usual 8-bit. Use 8-bit per channel as per older patches proposed for bug 6682 via color_t_to_rgb(). Change-Id: I7d71bc04e52376c0ecb598aedafa066f982de840 Ping-Bug: 6682 Reviewed-on: https://code.wireshark.org/review/23154 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5939c7417d1f2e24b6e9b78160fe7588d634e7e1 commit 5939c7417d1f2e24b6e9b78160fe7588d634e7e1 Author: Alexis La Goutte Date: Sun Aug 20 21:05:07 2017 +0200 RSVP: Add value_string for ctype session Need to add for other ctype value too... Change-Id: I815fee790403d848fed4c3501dae9951dbcb93a3 Ping-Bug: 13977 Reviewed-on: https://code.wireshark.org/review/23152 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4afbd656b48a6463736cc3aeb1056761b31e0fd9 commit 4afbd656b48a6463736cc3aeb1056761b31e0fd9 Author: Alexis La Goutte Date: Sun Aug 20 20:37:01 2017 +0200 RSVP: fix length of PSMP ID (2 -> 4) Ping-Bug: 13977 Change-Id: I162d967d4d38296231d5a16d651f848d600d49bc Reviewed-on: https://code.wireshark.org/review/23151 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b66bdbd4268566f454d73fa92a46079c180d1e71 commit b66bdbd4268566f454d73fa92a46079c180d1e71 Author: Guy Harris Date: Sun Aug 20 17:38:25 2017 -0700 More explanation in the comments. Change-Id: I1e5597ac291d38370e8b1537a75f3ba1d9a86bc9 Reviewed-on: https://code.wireshark.org/review/23156 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=940903c6492b68d5d9aea247bfadb709ddaf20f5 commit 940903c6492b68d5d9aea247bfadb709ddaf20f5 Author: Guy Harris Date: Sun Aug 20 17:09:56 2017 -0700 Use a Wayback Machine URL for the PPI documentation. It's not available from cacetech.com any more. Change-Id: I6627a9102235f07731c55a2fe3cd82adc1899450 Reviewed-on: https://code.wireshark.org/review/23155 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a26fb9072917d0c48a0dc9260018967eaf11c352 commit a26fb9072917d0c48a0dc9260018967eaf11c352 Author: Alexis La Goutte Date: Sun Aug 20 19:25:38 2017 +0200 802.11: Add Neighbor Sublement ID dissection BSS Transition Candidate Preference (Figure 9-299) BSS Termination Duration (Figure 9-300) From 802.11-2016 Bug: 13985 Change-Id: I352a41c46ff741070c51f4ddc661e26a40d21570 Reviewed-on: https://code.wireshark.org/review/23149 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=a03e4ea191b0937fdfd5337cb9304392056723d0 commit a03e4ea191b0937fdfd5337cb9304392056723d0 Author: Alexis La Goutte Date: Sun Aug 20 19:07:17 2017 +0200 802.11: Update subelement IDs for Neighbor report Table 9-151 from 802.11-2016 Ping-Bug: 13985 Change-Id: Ie2b0650feb03b984b2ac3c42ca46f4b5b8ed923c Reviewed-on: https://code.wireshark.org/review/23148 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=61d45acfb580d9fe93ed1c6e66266cd0af485da7 commit 61d45acfb580d9fe93ed1c6e66266cd0af485da7 Author: Alexis La Goutte Date: Sun Aug 20 18:52:19 2017 +0200 802.11: Add new flags on BSSID Info in neighbor report field (from 802.11-2016) Ping-Bug: 13985 Change-Id: I4188767021455002119b64862264e1540314f8cc Reviewed-on: https://code.wireshark.org/review/23147 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ad085e567e97a65ec8c4d402014374b3022e85f4 commit ad085e567e97a65ec8c4d402014374b3022e85f4 Author: Alexis La Goutte Date: Sun Aug 20 18:41:35 2017 +0200 802.11: Add always Data of Subelement (on Neighbor Report) Fix also typo on Neighbor Report Subelement length filter display name Ping-Bug: 13985 Change-Id: I924cadddb0d5f060d8af08cf0f27cab40f3bd6bd Reviewed-on: https://code.wireshark.org/review/23146 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=edc63f5ef7d0655093bb01b0accb130fd4de8dd8 commit edc63f5ef7d0655093bb01b0accb130fd4de8dd8 Author: Gerald Combs Date: Sun Aug 20 08:07:21 2017 +0000 [Automatic update for 2017-08-20] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I676dc2814760f711a3d3b8b4979ef8a0077e26a1 Reviewed-on: https://code.wireshark.org/review/23141 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=1a38472d047893bc91fb9fd82d1e641a7b1c03ad commit 1a38472d047893bc91fb9fd82d1e641a7b1c03ad Author: Stig Bj??rlykke Date: Sat Aug 19 23:59:02 2017 +0200 nordic_ble: Preserve legacy version support Change-Id: I8354955f802ba47158b78358084cd4211c1c6d79 Reviewed-on: https://code.wireshark.org/review/23137 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=50510a670d1ba15973d6c895eccfc0754af2852d commit 50510a670d1ba15973d6c895eccfc0754af2852d Author: Jakub Zawadzki Date: Sat Aug 19 22:24:56 2017 +0200 sharkd: minor changes in comments, fix style. Change-Id: I72d856bf223cea966bd505031417bc2b4dd12f82 Reviewed-on: https://code.wireshark.org/review/23136 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7a9b9fd136430287e583ed323c8c7f12292913ba commit 7a9b9fd136430287e583ed323c8c7f12292913ba Author: Stig Bj??rlykke Date: Sat Aug 19 22:02:43 2017 +0200 nordic_ble: Add packet format description Also move "Length of packet" to correct position. Change-Id: I2efd5087396a8904eb16bcc3191cc9ea3beac2e9 Reviewed-on: https://code.wireshark.org/review/23135 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=0831becc1a650399b5cc417f65f5649a9cd76270 commit 0831becc1a650399b5cc417f65f5649a9cd76270 Author: Michael Mann Date: Mon Jun 19 10:37:29 2017 -0400 Remove support for CPack. It's very incomplete and we already have installation makers for supported OSes. Change-Id: Ide6332b9b6d69b66e7262662d781b548526ab752 Reviewed-on: https://code.wireshark.org/review/22226 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7981d4bf0edc69ceea28914ae78899b0ef3850be commit 7981d4bf0edc69ceea28914ae78899b0ef3850be Author: Dario Lombardo Date: Fri Aug 18 13:52:48 2017 +0200 gitlab-ci: add gcc 7. Change-Id: I3b03c9fcbe67cca5c818f40875dc4828baa05012 Reviewed-on: https://code.wireshark.org/review/23118 Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=25631a44ac1524ad1dbed444a8fc44bdf08c1ea5 commit 25631a44ac1524ad1dbed444a8fc44bdf08c1ea5 Author: Chris Brandson Date: Fri Aug 18 09:37:12 2017 -0700 ZigBee scenes cluster scene valid attribute displaying incorrect bit During validation it was discovered that the incorrect bit was displayed, verified against the ZigBee test tool that bit 0 is used for validity Change-Id: Iaaa2f8021b2aa269f660626fdd252cade732b60f Reviewed-on: https://code.wireshark.org/review/23124 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9e21f4b8ee27480cce4bc0e4dc3d0c5eefe24e1c commit 9e21f4b8ee27480cce4bc0e4dc3d0c5eefe24e1c Author: Gerald Combs Date: Fri Aug 18 08:44:21 2017 -0700 WSUG: Update the TCP analysis section. Clarify and fix some items. Change-Id: I1f9f8a32ceaa1de4c1ec2936913c87c08ba63c88 Reviewed-on: https://code.wireshark.org/review/23123 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=4f76eb002d65d801d5c262f7b21594d1421de4fd commit 4f76eb002d65d801d5c262f7b21594d1421de4fd Author: Alexis La Goutte Date: Wed Aug 16 17:18:30 2017 +0200 RSVP: add Session C-type RSVP_SESSION_TYPE_P2MP_LSP_TUNNEL_IPV6 Change-Id: I493771df32b83691fa587b9a725c15df6057fb52 Ping-Bug: 13977 Reviewed-on: https://code.wireshark.org/review/23104 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=96dd97f9ba37ae0e708d2917e78c1a61d385266b commit 96dd97f9ba37ae0e708d2917e78c1a61d385266b Author: Sergey Avseyev Date: Fri Aug 18 14:42:40 2017 +0300 couchbase: update status codes Change-Id: I7f0950d82c50c8f019d844d726ffe7a0015618c5 Reviewed-on: https://code.wireshark.org/review/23117 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6020f0f93d4cce75b08d9a6ecb51de08975b197f commit 6020f0f93d4cce75b08d9a6ecb51de08975b197f Author: Graham Bloice Date: Fri Aug 18 13:27:49 2017 +0100 WSDG: More VS 2015 fixes Change-Id: I5f0d543032f62bd0c57c14a56771a63fe1bed3a3 Reviewed-on: https://code.wireshark.org/review/23122 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=b8fb78c5ac719d9ec03cf1923d750d1a8b507aa9 commit b8fb78c5ac719d9ec03cf1923d750d1a8b507aa9 Author: Alexis La Goutte Date: Wed Aug 16 16:34:46 2017 +0200 RSVP: fix name of PSMP ID field (SESSION object C-Type 13/14) Also display PSMP ID in decimal Ping-Bug: 13977 Change-Id: If6b87ab87339038d763dcc1c97353aaf9d69a02c Reviewed-on: https://code.wireshark.org/review/23103 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=581461bb3458c4c89ac8700bafb6669449f326ae commit 581461bb3458c4c89ac8700bafb6669449f326ae Author: Paul Offord Date: Fri Aug 18 08:30:11 2017 +0100 TRANSUM fails with DCE-RPC request Packet Type 0 TRANSUM fails to calculate RTE figures for DCE-RPC where request Packet Type is zero Bug: 13988 Change-Id: I1dd7aee0283042703530a6d72fff063279e6147e Reviewed-on: https://code.wireshark.org/review/23115 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b1a6f11e4271265e4de9722c020158d2c075ff9d commit b1a6f11e4271265e4de9722c020158d2c075ff9d Author: Graham Bloice Date: Fri Aug 18 13:14:44 2017 +0100 WSDG: Remove obsolete VS 2010 info from quick setup Change-Id: I767e04538d17702346e9343e136fc0ea4c2f9ec3 Reviewed-on: https://code.wireshark.org/review/23120 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=b62eee0d7f150cdf840efff175888eacde993622 commit b62eee0d7f150cdf840efff175888eacde993622 Author: Graham Bloice Date: Fri Aug 18 13:09:35 2017 +0100 WSDG: Update Qt installation info Change-Id: I9da1c68949ac48e3e88227e9c4f4d4930dbd3268 Reviewed-on: https://code.wireshark.org/review/23119 Reviewed-by: Graham Bloice http://cgit.osmocom.org/wireshark/commit/?id=e02ca799d966ed2054bbd78742fd0a61f8bd959e commit e02ca799d966ed2054bbd78742fd0a61f8bd959e Author: Alexis La Goutte Date: Tue Aug 8 08:41:31 2017 +0200 msdp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ie98f0c70190206b4682bf1b1b13add51c52303db Reviewed-on: https://code.wireshark.org/review/23009 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b8c22283218b36853c70620037973ff271f0273a commit b8c22283218b36853c70620037973ff271f0273a Author: Alexis La Goutte Date: Tue Aug 8 22:59:42 2017 +0200 ws.css: fix invalid color use the same like original http://www.methods.co.nz/asciidoc/docbook-xsl.css Reported by Jay Turner https://www.wireshark.org/lists/wireshark-dev/201707/msg00141.html Change-Id: Ia44d7cbd24c1b2f3b9b011d3ed07619d2fa733cd Reviewed-on: https://code.wireshark.org/review/23022 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=21672e51e43db1fbb39362346264815a5bba0f16 commit 21672e51e43db1fbb39362346264815a5bba0f16 Author: Stig Bj??rlykke Date: Fri Aug 18 12:56:27 2017 +0200 WSDG: Reference to an existing Qt version Change-Id: Ia1c61cabf1bf3378bf993501dc1362163f33f1ed Reviewed-on: https://code.wireshark.org/review/23116 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=f76e1c8c84eeaee504db9bb7510109247655e372 commit f76e1c8c84eeaee504db9bb7510109247655e372 Author: Chris Brandson Date: Mon Jul 17 18:33:35 2017 -0700 ZigBee fix Default Response dissection The ZCL Default Response command can be sent in response to any profile-wide or cluster specific command. The Default Response command is itself a profile-wide command so the Default Response frame control is of no help in deciding whether the original request is profile-wide or cluster-specific. The simplest solution is to not attempt interpretation. A more sophisticated solution would be to cache all ZCL frame counters and match Default Responses based on sequence number, but this is problematic because sequence numbers repeat. At least for now we can always display the information correctly. Change-Id: I827e2d2f9d6e5f7c9dfa572d2ee2ac3c9f170d70 Reviewed-on: https://code.wireshark.org/review/22688 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6726d9e0cd61634c6bae95857efb2e549ab8f7be commit 6726d9e0cd61634c6bae95857efb2e549ab8f7be Author: AndersBroman Date: Thu Aug 17 16:54:29 2017 +0200 [GSM MAP] Dissect Ext2-QoS-Subscribed, Ext3-QoS-Subscribed and Ext4-QoS-Subscribed Change-Id: Ic6a0f80d5f2339fd90284d1fddffe57b66c6771d Reviewed-on: https://code.wireshark.org/review/23108 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5f52e655002de5fa4ff29d32869cfca2b7eda214 commit 5f52e655002de5fa4ff29d32869cfca2b7eda214 Author: Mikael Kanstrup Date: Tue Aug 15 09:12:31 2017 +0200 androiddump: Support 802.11 monitor and nlmon interfaces Some Android devices support 802.11 monitor mode and nlmon interfaces. Add linktype defines to be able to capture frames from such interfaces. Change-Id: I8b8b444ac2821542fc946694b71c8d9fb7ba1238 Reviewed-on: https://code.wireshark.org/review/23080 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e13a81c62a1312ab39f228c70a0c0479af8782ec commit e13a81c62a1312ab39f228c70a0c0479af8782ec Author: Gerald Combs Date: Thu Aug 17 12:12:18 2017 -0700 WSDG: More VS 2015 updates. Switch the Command Prompt instructions back to using the platform-specific variants. Switch back to setting WIRESHARK_BASE_DIR. Change-Id: Ie9f865e5fac1312f2eb3762e439d53ab9a038bd4 Reviewed-on: https://code.wireshark.org/review/23112 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6e6bcacb72db2db6baada7b00924c96ff05c5ca2 commit 6e6bcacb72db2db6baada7b00924c96ff05c5ca2 Author: Guy Harris Date: Thu Aug 17 14:38:54 2017 -0700 Fix some comments. "The release mode (CMAKE_BUILD_TYPE=release) defines NDEBUG" isn't Linux-specific; it's true in the Unix Makefile generator, and possibly in other generators. (The Visual Studio generator, at least for newer versions of VS, lets you specify at *build* time what type of build to do, so the generated build files don't unconditionally define, or not define, NDEBUG, they do so based on the build type.) The RPATH stuff is done on Unix-like systems *except* for macOS. Change-Id: Ieffbaaa9a8e11a1a30b34036a2412c6735baa0c8 Reviewed-on: https://code.wireshark.org/review/23114 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1e659474c93d48e07e3908814bd423c228d38f2f commit 1e659474c93d48e07e3908814bd423c228d38f2f Author: Uli Heilmeier Date: Thu Aug 17 18:54:28 2017 +0200 GTPv2: Fix length of EPS Bearer ID (EBI) Field is only 1 not 2 bytes long. Bug: 13987 Change-Id: If22e19e917bd41907248a497b30883e89fc9ff4b Reviewed-on: https://code.wireshark.org/review/23109 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f04cb33494a4b3009390cfc01e9a7247c8a132ae commit f04cb33494a4b3009390cfc01e9a7247c8a132ae Author: Alexis La Goutte Date: Wed Aug 16 12:58:32 2017 +0200 TLS: Add new cipher suite from draft-ietf-tls-ecdhe-psk-aead Change-Id: I256496618e67df70ce02ee90f21bc0cd556b0b5a Reviewed-on: https://code.wireshark.org/review/23105 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8625c1902d41735a34a3698f4cbbbac6cc21290a commit 8625c1902d41735a34a3698f4cbbbac6cc21290a Author: Alexis La Goutte Date: Thu Aug 17 13:26:35 2017 +0200 802.11: Add dissection of BSS Transition candidate List entries It is a list of Neighbor report (for request and response) Missing dissection of Neighbor Sublelement 0x03 (BSS Transition Candidate Preference) Issue reported by Mark Williams Bug: 13985 Change-Id: Ic3871866ba4779ee69e91d6d57b46926466b340c Reviewed-on: https://code.wireshark.org/review/23107 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=d56de21d6a56b1897c420802294359b1678bc40a commit d56de21d6a56b1897c420802294359b1678bc40a Author: Mikael Kanstrup Date: Thu Aug 17 10:21:19 2017 +0200 androiddump: Fix bt snoop capturing Recent changes had the bt snoop capturing function stop working for Android API versions >= 21. One of the command strings used for detecting btsnoop server socket interface got messed up when refactoring code. Fix by using the correct command strings again. Fixes: faf100ec ("androiddump: Introduce adb_connect_transport helper function") Change-Id: Id645d24cfb0cb23f36484cfd6416768c89bce51b Reviewed-on: https://code.wireshark.org/review/23106 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fc6f7b9021abd604f0d8650881885a5443c2ecb2 commit fc6f7b9021abd604f0d8650881885a5443c2ecb2 Author: Guy Harris Date: Wed Aug 16 17:52:55 2017 -0700 Fix capitalization. Change-Id: I43017bae5bc74678113377d0b4aad3d712647c5d Reviewed-on: https://code.wireshark.org/review/23099 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=4136bff2d0f2a805ea2b7f8b75f78ff48ec79da0 commit 4136bff2d0f2a805ea2b7f8b75f78ff48ec79da0 Author: Gerald Combs Date: Wed Aug 16 19:26:42 2017 +0000 CMake: Switch back to shipping README.txt on Windows. Instead of trying to ship README.md, convert its line endings and make sure the result is named README.txt. Change-Id: I4e081587c73342b01633b3a31ea03068e3fc1733 Reviewed-on: https://code.wireshark.org/review/23098 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=62d60108543bab32c4299e0aa90299975e435b64 commit 62d60108543bab32c4299e0aa90299975e435b64 Author: AndersBroman Date: Wed Aug 16 21:18:44 2017 +0200 [GTPv2] Add dissection of Message Priority Change-Id: I86e3097a322a4a354235ce941e52e6d4c6baf8ca Reviewed-on: https://code.wireshark.org/review/23097 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c4e957b9746407c07efbb937d21b7c31894d269e commit c4e957b9746407c07efbb937d21b7c31894d269e Author: Guy Harris Date: Wed Aug 16 12:09:19 2017 -0700 Fix build. That's a separate README file for this directory, and its name is README, not README.md like the top-level README file. Change-Id: I9ec920de6a844441e00d4608608563bc4ddd8349 Reviewed-on: https://code.wireshark.org/review/23096 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7df594c92efaa777598f23fe22e005c09103fd6f commit 7df594c92efaa777598f23fe22e005c09103fd6f Author: Guy Harris Date: Wed Aug 16 11:09:24 2017 -0700 Update URL for Visual Studio Community Edition. The old URL fetched VS 2013 when I tried it; update to a link that fetches VS 2015. Change-Id: Ib33e8f09bef51a532c986e70ae6ac5d9d1f1dabe Reviewed-on: https://code.wireshark.org/review/23094 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e7284adcdfc5302c46587890c62a28eaac5aedd7 commit e7284adcdfc5302c46587890c62a28eaac5aedd7 Author: Jo??o Valverde Date: Sun Aug 6 16:03:00 2017 +0100 RADIUS: Remove some shortcuts in how we handle Ascend-Data-Filter Do it via type "abinary" like the comment suggests. Note: VSA "abinary" code path untested. Ping-Bug: 11630 Change-Id: Ie8ebbb2fdbc9f04faad40150652277f1396ea030 Reviewed-on: https://code.wireshark.org/review/22973 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=71dd3658b727489a75c068d7bc8170078c9582a6 commit 71dd3658b727489a75c068d7bc8170078c9582a6 Author: Jo??o Valverde Date: Thu Jul 27 19:01:02 2017 +0100 RADIUS: Add preference to disable RFC 6929 extended attributes This is an ugly workaround for the fact that attributes 241-246 are currently hardcoded as extended type. This is to restore previous functionality to dissect some Ascend AVPs that shouldn't be using the IANA allocation space. Ping-Bug: 11630 Change-Id: I6bebefd21fe5149f5f57b3280c9992a0eca85e62 Reviewed-on: https://code.wireshark.org/review/22972 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4319b35e2bdf7aede32db3e81830b68ef37fa4b9 commit 4319b35e2bdf7aede32db3e81830b68ef37fa4b9 Author: Darien Spencer Date: Tue Aug 15 19:55:39 2017 +0300 RNSAP: Call RANAP dissector for RANAP-RelocationInformation This IE is a transparent container of a RANAP message according to TS 25.413 - Section 11.2 Change-Id: I2080c9a75ce2acc947eade9c60b12c49080f8ee8 Reviewed-on: https://code.wireshark.org/review/23085 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=2f0bd7b1f1493c4805c172f2202598efc1f1c8c0 commit 2f0bd7b1f1493c4805c172f2202598efc1f1c8c0 Author: Michael Mann Date: Tue Aug 15 19:58:18 2017 -0400 UDP: Bugfix handling UDP checksum of 0. Copy/pasteo made it "unverified", when it should have been labeled "Not present" Bug: 13955 Change-Id: If3b8dea276ae38ba8169762ed7ed8e764022b5d7 Reviewed-on: https://code.wireshark.org/review/23091 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ff5280906cd6de3cd86bd9c5c63fe2aaf372aa70 commit ff5280906cd6de3cd86bd9c5c63fe2aaf372aa70 Author: Sam Cisneros Date: Sat Aug 5 11:58:24 2017 +0300 NBAP over SCTP heuristic dissector Bug: 13866 Change-Id: I895266a6aa7458aa3ab18742bcd981986c2fd17c Reviewed-on: https://code.wireshark.org/review/23074 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8c89de612feaf89e430798870cc0ff15b432ff74 commit 8c89de612feaf89e430798870cc0ff15b432ff74 Author: Pascal Quantin Date: Tue Aug 15 20:25:55 2017 +0200 TCAP: fix infinite loop introduced in g35f9349396 Bug: 13926 Change-Id: I6bb06639f1226d6f5faee614858f5f09953d3ff5 Reviewed-on: https://code.wireshark.org/review/23087 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=88484ab05103cc51746c8c3d8d80f7304d5e5245 commit 88484ab05103cc51746c8c3d8d80f7304d5e5245 Author: Guy Harris Date: Tue Aug 15 11:31:05 2017 -0700 Update RFC and I-D references. Give draft-frascone-xml-dictionary for the dictionary syntax. Give RFC numbers and I-D names, rather than URLs to the plain text versions of them; that way, you can more easily go to the HTML versions, which give more information. The "more information" for I-Ds may include later drafts and the final RFCs, and for RFCs may give newer RFCs obsoleting the older ones; add the RFC numbers for the I-Ds and the RFC number for the current Diameter RFC. Change-Id: If01ea341af3ae892755a243bd1dd66acfdfd5062 Reviewed-on: https://code.wireshark.org/review/23086 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=f49ae745c1774213600bc054cb08d949286d9314 commit f49ae745c1774213600bc054cb08d949286d9314 Author: Dario Lombardo Date: Thu Aug 3 14:36:47 2017 +0200 extcap: use options as they are shown in the dialog. Bug: 13051 Change-Id: I287a4e1d529cc281aaae4a786010358c108d5f93 Reviewed-on: https://code.wireshark.org/review/22933 Petri-Dish: Roland Knall Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=719adb4fdc61e5187efefdfeb25a41d60d40be7f commit 719adb4fdc61e5187efefdfeb25a41d60d40be7f Author: Gerald Combs Date: Fri Aug 11 12:43:48 2017 -0700 Convert README to README.md. Convert the contents of the top-level README to Markdown and give it a .md extension. Most of our documentation is plain text or AsciiDoc, but the top-level README file in a Git repository is special in that many online browsers will show the README contents along with the directory listing and those browsers tend to favor Markdown. This is true of GitHub (which we're currently mirroring to), Gerrit via its Gitiles plugin (which we're not yet using but likely will), and other places. Add "foreign" to AM_INIT_AUTOMAKE. There is probably a joke to be made here about the FSF and border walls. Change-Id: I87c306d74864e1f0a432225b160a1b4483ee946c Reviewed-on: https://code.wireshark.org/review/23049 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f4ca61220aa65e42d880c947ce9c01dfe5bc8d4b commit f4ca61220aa65e42d880c947ce9c01dfe5bc8d4b Author: Mikael Kanstrup Date: Tue Aug 15 09:03:45 2017 +0200 androiddump: Avoid linktype/encap conversion Let androiddump's internal definition of encap types directly use linktype values from libpcap/wiretap. This way back and forth conversion between internal and public values can be avoided. Change-Id: I67522283cc3eb15cbdb1bfdd829bb1ff0031bb82 Reviewed-on: https://code.wireshark.org/review/23079 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=bc9bf64f8dc7053ebe3ae75152472d7149e077ce commit bc9bf64f8dc7053ebe3ae75152472d7149e077ce Author: Dario Lombardo Date: Mon Aug 14 23:08:56 2017 +0200 Qt: fix compilation without pcap. Change-Id: Ib8d21d63730ea6e18032b89ba0042ee7521645a8 Reviewed-on: https://code.wireshark.org/review/23078 Reviewed-by: Michael Mann Petri-Dish: Dario Lombardo Tested-by: Dario Lombardo Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=35f9349396d4dfbcccdf977cf9d7f3096df5aa0e commit 35f9349396d4dfbcccdf977cf9d7f3096df5aa0e Author: Pascal Quantin Date: Fri Aug 11 21:40:20 2017 +0200 TCAP: more fixes for SRT analysis - when building the END hash entry, always use the BEGIN destination address. If no match is done, we will search using the BEGIN entry anyway - add the source PC to the END hash entry. As it will be used for messages initiated by the host that sent the BEGIN, we probably can assume that the PC will not change Bug: 13926 Change-Id: Iaa8b09bf6821961d1eab22683600f36d77bd2cc5 Reviewed-on: https://code.wireshark.org/review/23048 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9f7f401f325d2e92016e99cc39992d9ee34f73bf commit 9f7f401f325d2e92016e99cc39992d9ee34f73bf Author: Gerald Combs Date: Mon Aug 14 13:02:34 2017 -0700 CMake: Remove an unused variable. Remove a variable apparently left over from the DocBook???AsciiDoc transition. Change-Id: Ieb6e2fd282ab71227bc5d33c200f04051acf529b Reviewed-on: https://code.wireshark.org/review/23077 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=01449b849e55e9cb599a9a9c5c3d0ef0db4181d3 commit 01449b849e55e9cb599a9a9c5c3d0ef0db4181d3 Author: Gerald Combs Date: Mon Aug 14 11:40:39 2017 -0700 WSUG: Remove the protocol help section The protocol help feature was completely removed in g09efa5fb8b and deprecated long before that. Change-Id: Ia0bde785002025c0cf9e3f783a5cad7f784938a2 Reviewed-on: https://code.wireshark.org/review/23076 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=7ff66471fa4a314021a6fbdb9f9f32989779fd93 commit 7ff66471fa4a314021a6fbdb9f9f32989779fd93 Author: olivermd Date: Thu Aug 10 15:13:44 2017 +0100 Couchbase: Add doc flag support to dissector This patch makes required changes to be able to dissect packets that use the new subdoc doc flags. This involved modifying the existing subdoc flags, creating the new docs flags and modifying the extras dissector. Change-Id: Iaaf5e58d778ca5f54f76c9d27680df68eee8b7bd Reviewed-on: https://code.wireshark.org/review/23032 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=e347139d3fcac13ab84e8cc50242ad4b0d4a2f11 commit e347139d3fcac13ab84e8cc50242ad4b0d4a2f11 Author: Richard Sharpe Date: Mon Aug 14 06:23:47 2017 -0700 ieee802.11: Replace an incorrect fall through with a break. Table 8-216???GAS Initial Request frame body format (page 752 of the 2012 version) suggests that the only thing that comes after the length is the actual request and since the default just inserts the bytes for req_len, it looks like the fall-through should not be there and it should be a break. Change-Id: I8e5afb24fedffea869829dc9f5bf3d42b20121eb Reviewed-on: https://code.wireshark.org/review/23075 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=691bec3c09cb8c834dcec1f21aa700b5a342503d commit 691bec3c09cb8c834dcec1f21aa700b5a342503d Author: Alexis La Goutte Date: Mon Aug 14 10:46:16 2017 +0200 ieee80211: fix dpp doesn't match PROTOABBREV of ieee80211 and also with conflict check: 'dpp' exists multiple times with NOT compatible types: FT_PROTOCOL and FT_UINT8 Change-Id: I98e2f7e8abbee5423e2bfa7b71b5259edd4711e4 Reviewed-on: https://code.wireshark.org/review/23071 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=34d3ad990cdcebe9f1630e805e41b037bca3cb17 commit 34d3ad990cdcebe9f1630e805e41b037bca3cb17 Author: Alexis La Goutte Date: Mon Aug 14 10:43:55 2017 +0200 wifi-dpp: fix dppi.[init|resp].hash doesn't match PROTOABBREV of wifi-dpp Change-Id: I7132f40aaed8ee217af66ec89a3ccce61a359554 Reviewed-on: https://code.wireshark.org/review/23070 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=97e0eb3ec6f3ded3549a768897a86cd09cae3a2e commit 97e0eb3ec6f3ded3549a768897a86cd09cae3a2e Author: Alexis La Goutte Date: Mon Aug 14 10:54:13 2017 +0200 Makefile.am (dissectors): fix align indent Change-Id: Ifde626095a61bb3aca3f9cc101023aa4bbf3341b Reviewed-on: https://code.wireshark.org/review/23072 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=2c58885e94c7052931bace093b680fba9cc19ddb commit 2c58885e94c7052931bace093b680fba9cc19ddb Author: Alexis La Goutte Date: Mon Aug 14 11:10:28 2017 +0200 ieee80211: fix typo specfic => specific Change-Id: Ic071dcccf5aab5d3a45dd6354f3cd6eedbc1a84f Reviewed-on: https://code.wireshark.org/review/23073 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3298a5294316c51d0a77e07dbfc187148a328485 commit 3298a5294316c51d0a77e07dbfc187148a328485 Author: Peter Wu Date: Sun Aug 13 23:17:21 2017 -0700 wifi: fix "multiple definition of wifi_display_ie_handle" linker error Change-Id: I4aee15cbf241d31c274dc511be2f86b8bfeae5b8 Fixes: v2.5.0rc0-683-g3c0ff67a9c ("ieee80211: Make a few dissector tables for vendor specific functionality") Reviewed-on: https://code.wireshark.org/review/23069 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=d6eda2a3a398b5747717b6dbc13337a6d5314416 commit d6eda2a3a398b5747717b6dbc13337a6d5314416 Author: Richard Sharpe Date: Sun Aug 13 21:58:39 2017 -0400 ieee80211 : Implement Wi-Fi DPP spec Including attributes in Public Action frames and those that can appear in GAS frames. Change-Id: I8d2a717984295592952b8fff82879197ace2a4b2 Reviewed-on: https://code.wireshark.org/review/22615 Petri-Dish: Michael Mann Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=3c0ff67a9ca7e9c71785fa9d97cc1c1c13908774 commit 3c0ff67a9ca7e9c71785fa9d97cc1c1c13908774 Author: Michael Mann Date: Sun Aug 13 10:57:55 2017 -0700 ieee80211: Make a few dissector tables for vendor specific functionality This allows vendors to more easily expand functionality. Change-Id: Iaa6a0626f3ab3c80a3ea90ca09c90284705d0221 Reviewed-on: https://code.wireshark.org/review/23066 Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=329cccfc7b3adabbcd961cc328609f23058e5a12 commit 329cccfc7b3adabbcd961cc328609f23058e5a12 Author: Michael Mann Date: Sun Aug 13 13:50:58 2017 -0400 packet-ieee80211.c: Add dissector table for vendor specific actions Gives a little more flexibility for vendor implementations https://www.wireshark.org/lists/wireshark-dev/201708/msg00053.html https://ask.wireshark.org/questions/56816/ieee-80211-vendor-specific-action Change-Id: I0345e43140a8ac99b26932b72d08a99ca0036389 Reviewed-on: https://code.wireshark.org/review/23065 Petri-Dish: Michael Mann Reviewed-by: Richard Sharpe Tested-by: Petri Dish Buildbot http://cgit.osmocom.org/wireshark/commit/?id=35a6a1396fa8b0a6fa094b39bccac7c1e81a7fd3 commit 35a6a1396fa8b0a6fa094b39bccac7c1e81a7fd3 Author: Martin Kaiser Date: Tue Aug 8 21:46:10 2017 +0200 iso14443: fix the request-response tracking Distinguish between Waiting Time Extension (WTX) messages and other messages. Use a composite key for the wmem tree that consists of a boolean wtx flag and the request packet number. Change-Id: I7783aabb231fe145a8d8c0d65c88b553d5a5b533 Reviewed-on: https://code.wireshark.org/review/23063 Reviewed-by: Martin Kaiser Petri-Dish: Martin Kaiser Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f49cc4d95287859475d164890ab1e27847d57ccf commit f49cc4d95287859475d164890ab1e27847d57ccf Author: Jo??o Valverde Date: Sun Aug 13 18:33:00 2017 +0100 RADIUS: Initialize vendor attribute type to zero Change-Id: Ic43363d93f6d573ddb8d3de3e0bd62624124d104 Reviewed-on: https://code.wireshark.org/review/23064 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=292708ab32ec46279fefb045161606037ed89330 commit 292708ab32ec46279fefb045161606037ed89330 Author: Peter Wu Date: Sun Aug 13 13:41:55 2017 +0200 CMake: allow CMAKE_INSTALL_RPATH to be overridden By default CMake sets the RPATH for built binaries to the build directory. To enable relocatable build directories, I override this RPATH as follows during development: -DCMAKE_BUILD_WITH_INSTALL_RPATH=1 -DCMAKE_INSTALL_RPATH='$ORIGIN:$ORIGIN/../extcap/..' To make work (again), do not overwrite CMAKE_INSTALL_RPATH in CMakeLists.txt. Change-Id: I7f238af07926ea706a3f999c5b1e13286ca53a66 Fixes: v2.5.0rc0-664-g55dd9b16d5 ("CMake: Update RPATH during installation.") Reviewed-on: https://code.wireshark.org/review/23062 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=84b86bdfa2ef7186ede9c416a61d8682bf818bb7 commit 84b86bdfa2ef7186ede9c416a61d8682bf818bb7 Author: Guy Harris Date: Sun Aug 13 01:48:45 2017 -0700 Get rid of trailing blanks. Change-Id: Ic236b307a0d9d81a0c906fa33599706165d4360d Reviewed-on: https://code.wireshark.org/review/23061 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=de3a563d6698de8e45708e9d056f948c8eab7c8c commit de3a563d6698de8e45708e9d056f948c8eab7c8c Author: Guy Harris Date: Sun Aug 13 01:46:51 2017 -0700 Clean up configuration file and plugin folder description. Have a separate section, before all the others, giving the top-level directories under which those folders are placed, with names for use in later sections. Update the example personal application data folder on Windows to the NT 6.x-and-beyond standard. Don't give the pathnames for configuration files in the table, just give the name and the description. For the global files, distinguish between macOS and other Unix-like systems, and, for the latter, mention both /usr/XXX and /usr/local/XXX. The preferences file isn't "wireshark.conf", and hasn't been that for quite a while. For all the configuration files, give the details of personal vs. global files - they're different for different files. Have separate sections for configuration files and plugin folders. For plugin folders, note both the use of the top-level plugin folder for Lua scripts and the use of the per-Wireshark-version subfolder for compiled plugins. Use fixed-format text for the non-variable parts of pathnames, and italics for the variable parts. This should, among other things, make it easier for other documents, such as the Lua documentation in the Wireshark wiki, to refer to folders such as the configuration file and plugin folders. Change-Id: I133c1e159e992827458bee64c4f37be5b50f9b6f Reviewed-on: https://code.wireshark.org/review/23060 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=f2a3a705e667b1c6858391a1139d08e41950e7d0 commit f2a3a705e667b1c6858391a1139d08e41950e7d0 Author: Gerald Combs Date: Sun Aug 13 08:10:56 2017 +0000 [Automatic update for 2017-08-13] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie0e554e42e96a8b8f8c8ce7f4a9ea615276b49fb Reviewed-on: https://code.wireshark.org/review/23056 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=e871a3ffb432095a92f11c11024b0e96e23b9f7c commit e871a3ffb432095a92f11c11024b0e96e23b9f7c Author: John Keeping Date: Sat Aug 12 16:23:27 2017 +0100 ZigBee ZCL IAS: decode IAS Zone Enroll Request Add missing decoding for the Enroll Request command in the IAS Zone cluster. Change-Id: I8dc0875912c87601f610173014879e13cad0820c Reviewed-on: https://code.wireshark.org/review/23050 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=aa2117a8f250b4b0ca08b133d847aa6768a3ce5a commit aa2117a8f250b4b0ca08b133d847aa6768a3ce5a Author: Ahmad Fatoum Date: Sun Jul 30 17:05:02 2017 +0200 Include xtea.[hs] in CMakeLists.txt and Makefile.am CMake part was missing. Autotools part didn't include header. Change-Id: I5a642a80d30b02bb16eb48e0e4e1f8e0e8332a75 Reviewed-on: https://code.wireshark.org/review/23051 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=537b083e028c636b8f8afc4a847e186f4abca59f commit 537b083e028c636b8f8afc4a847e186f4abca59f Author: Gerald Combs Date: Thu Aug 10 10:20:30 2017 -0700 Sync some CMake and Autotools install behaviors. Adjust the following CMake and Autotools behaviors in order to synchronize their respective install behaviors: - Disable tfshark by default in CMakeOptions.txt - Add profiles/Bluetooth/preferences to Makefile.am - Add missing captype and ciscodump entries to doc/Makefile.am - Install help/faq.txt on all platforms in CMakeLists.txt - Add BUILD_corbaidl2wrs, BUILD_dcerpcidl2wrs, and BUILD_xxx2deb options to CMake and use them to adjust the corresponding parts of the build. - Pull the DCERPC idl2wrs build steps into the top-level CMakeLists.txt. This change doesn't sync everything. Some installed content still diverges, including the following: - CMake installs a bunch of modules into lib/wireshark: FindGLIB2.cmake FindWireshark.cmake FindWSWinLibs.cmake LocatePythonModule.cmake UseAsn2Wrs.cmake UseMakeDissectorReg.cmake WiresharkConfig.cmake WiresharkConfigVersion.cmake Do we need any or all of these? If so, should the Autotools behavior be synced accordingly? - Autotools installs libtool .la files. It also installs wireshark-gtk.desktop unconditionally. Change-Id: I7846efe08f7139c31b6ceca6f08a1fa5168b3e22 Reviewed-on: https://code.wireshark.org/review/23041 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=dc2a2424b48086ac2f79abc322070a4498d01607 commit dc2a2424b48086ac2f79abc322070a4498d01607 Author: Alexis La Goutte Date: Fri Jul 28 09:16:56 2017 +0200 uma: avoid global variable Change-Id: Icc179c00b5b2bee6dc69d843de784c7519360206 Reviewed-on: https://code.wireshark.org/review/22830 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6bdd072803b4f9964416c89a36be66f8643fd4c7 commit 6bdd072803b4f9964416c89a36be66f8643fd4c7 Author: Alexis La Goutte Date: Mon Jul 24 21:14:30 2017 +0200 TLS: Add QUIC Transport Parameters See https://tools.ietf.org/html/draft-ietf-quic-tls Bug: 13881 Change-Id: Id8ae5cdc2f7232e5db28846e528ae378fc0ac58d Reviewed-on: https://code.wireshark.org/review/22780 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c09538e48c6fe241cec0af29294f4f7eaf4a3b83 commit c09538e48c6fe241cec0af29294f4f7eaf4a3b83 Author: Gerald Combs Date: Fri Aug 11 09:54:25 2017 -0700 Tools: Check for ASan directly. Check for ASan by testing tshark directly instead of trying to infer it from the build environment. Change-Id: I05813161cd8c20f0c105d976706f8b62fd360cb9 Reviewed-on: https://code.wireshark.org/review/23047 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=fd2777b13887a785bd2ce722b4795aab50752afa commit fd2777b13887a785bd2ce722b4795aab50752afa Author: Gerald Combs Date: Fri Aug 11 01:01:58 2017 +0000 CMake: Make PLUGIN_INSTALL_DIR absolute. CMAKE_INSTALL_LIBDIR is a relative path. Prefix it with CMAKE_INSTALL_PREFIX so that PLUGIN_INSTALL_DIR is absolute. This matches our Autotools behavior. Change-Id: Ib42cea8745615686e0c7e8473bdb1975a3b9eccd Reviewed-on: https://code.wireshark.org/review/23043 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=5a0aa773c1e5f1102c1a0124554794672eaca931 commit 5a0aa773c1e5f1102c1a0124554794672eaca931 Author: Sontol Bonggol Date: Thu Aug 10 23:35:16 2017 -0700 Do not allow -m option to be larger than our allocated buffer Specifying -m larger than our allocated buffer may result in segfault. This patch protects it from happening and exits early. Change-Id: I2197605d90c98fc9d12b69a68fe533aaf6457df2 Reviewed-on: https://code.wireshark.org/review/23044 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ef24608db1e4b881667ca7a670a76842ae52853d commit ef24608db1e4b881667ca7a670a76842ae52853d Author: Martin Mathieson Date: Sat Aug 5 12:18:43 2017 +0100 Link forward to ftp-data from ftp commands Change-Id: I57013fefed2e588749a208bb3e3562ca4bbef0ac Reviewed-on: https://code.wireshark.org/review/22953 Petri-Dish: Martin Mathieson Petri-Dish: Graham Bloice Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=108b9b869bfe7475be0218d5f9682818dd3f4e8b commit 108b9b869bfe7475be0218d5f9682818dd3f4e8b Author: Alexis La Goutte Date: Tue Aug 8 09:11:33 2017 +0200 debian: Update symbols Change-Id: I21d6dbadb78367f58dce09f97bb6e41ab81ec67a Reviewed-on: https://code.wireshark.org/review/23011 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=06ab7f5a4e0643c2baade6ed4c3babc2fd3e2ce0 commit 06ab7f5a4e0643c2baade6ed4c3babc2fd3e2ce0 Author: Alexis La Goutte Date: Tue Jul 4 13:42:03 2017 +0000 .mailmap: update (of July and Mid-August) Change-Id: I53c3dab6f83cce138a06bb95f1f3bacec681a2a2 Reviewed-on: https://code.wireshark.org/review/23021 Reviewed-by: cedric izoard Reviewed-by: Balint Reczey Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=55dd9b16d5c9f3641bcb236282fb06983df1a5dd commit 55dd9b16d5c9f3641bcb236282fb06983df1a5dd Author: Gerald Combs Date: Thu Aug 10 16:35:21 2017 +0000 CMake: Update RPATH during installation. If we're installing into a non-system prefix on UNIX or Linux, make sure CMake updates our RPATHs accordingly. Change-Id: Ia6eaa6533c996a8228cff25e9d2032b223781681 Reviewed-on: https://code.wireshark.org/review/23040 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=d619a4239e3d4bc5b1f7d4829aad87004db37c07 commit d619a4239e3d4bc5b1f7d4829aad87004db37c07 Author: Alexis La Goutte Date: Fri Jun 23 07:45:10 2017 +0200 Add QUIC Transport IETF (draft-05) protocol Bug: 13881 Change-Id: I9007800060dfc503a1039f652d53c9cb1cd42211 Reviewed-on: https://code.wireshark.org/review/22366 Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte Reviewed-by: Peter Wu http://cgit.osmocom.org/wireshark/commit/?id=61eb3f0b7552b426951a99755bed5983593b6243 commit 61eb3f0b7552b426951a99755bed5983593b6243 Author: Nicolas Bertin Date: Thu Aug 10 14:47:37 2017 +0200 ua3g: fixed VTA type display for 8018, 8028S and 8008 Change-Id: I24158599831e432b62ff2ec0f36eeb1350c18a4b Reviewed-on: https://code.wireshark.org/review/23031 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=21cb715dbea71c7865107503fddf3ae24010fe85 commit 21cb715dbea71c7865107503fddf3ae24010fe85 Author: Pascal Quantin Date: Thu Aug 10 17:36:07 2017 +0200 SML: fix checksum verification The checksum is stored in little endian format. Regression introduced in gad6fc87d64 Change-Id: Ic5dd58f645fbe9d791b367d5777e07acb135d38c Reviewed-on: https://code.wireshark.org/review/23034 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=de2a738cbd4df919b8bdb3e6c824d55670869f36 commit de2a738cbd4df919b8bdb3e6c824d55670869f36 Author: olivermd Date: Thu Aug 10 11:00:20 2017 +0100 Couchbase: Add get error map cmd Change-Id: I9ca47fa0f77edd0ce94d2fe4cb098b5ff2786749 Reviewed-on: https://code.wireshark.org/review/23030 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=8c72e01a318ae9946ea42211e16af5ce4772ffa9 commit 8c72e01a318ae9946ea42211e16af5ce4772ffa9 Author: Pascal Quantin Date: Thu Aug 10 17:28:26 2017 +0200 MTP2: fix checksum verification The checksum is stored in little endian format. Regression introduced in gad6fc87d64 Change-Id: I0fd7c972eb365e7deddd07a70e5f95fcaf006618 Reviewed-on: https://code.wireshark.org/review/23033 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=f4781f3655c083cc915cc626d2e397da64635d90 commit f4781f3655c083cc915cc626d2e397da64635d90 Author: Alexis La Goutte Date: Wed Aug 9 15:03:02 2017 +0200 editor_file_dialog (qt/widgets): fix indent (use 4 spaces) Change-Id: I507737879c2e24cdca6d305b8e3775967071f1c3 Reviewed-on: https://code.wireshark.org/review/23028 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b66b4a96e3a70264ca39775219cd7eb3e7f150e3 commit b66b4a96e3a70264ca39775219cd7eb3e7f150e3 Author: Guy Harris Date: Tue Aug 8 20:33:33 2017 -0700 Handle older lz4 versions. lz4 switched from sequentially numbered releases, named rN, to vX.Y.Z-numbered releases. The old sequentially-numbered releases were in tarballs at https://github.com/lz4/lz4/archive/rN.tar.gz, which extract into an lz4-rN directory. THe new vX.Y.Z-numbered releases are in tarballs at https://github.com/lz4/lz4/archive/vX.Y.Z.tar.gz, which extract into an lz4-X.Y.Z directory - no, not lz4-vX.Y.Z, just lz4-X.Y.Z. We expect LZ4_VERSION to be set to rN for the sequentially- numbered releases and X.Y.Z - not vX.Y.Z - for the vX.Y.Z- numbered releases. Change-Id: Icb0275aa69b96eea43bf3a8645748a86cec81c94 Reviewed-on: https://code.wireshark.org/review/23026 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=5580b3beb70ba51c5d4074e1bf691858ec09de0c commit 5580b3beb70ba51c5d4074e1bf691858ec09de0c Author: Balint Reczey Date: Sat Aug 5 12:32:37 2017 +0200 debian: Add script for updating shared library package names It should be run prior to major release after the new shared library versions are set for cmake. Change-Id: I5cf2a3a9121672c8be14e57a318c9eaf5105e622 Signed-off-by: Balint Reczey Reviewed-on: https://code.wireshark.org/review/22967 Reviewed-by: Balint Reczey Petri-Dish: Balint Reczey Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c6a23a4b72c57eb3e81b96563e6a8faa3a810aa5 commit c6a23a4b72c57eb3e81b96563e6a8faa3a810aa5 Author: Alexis La Goutte Date: Thu Jul 27 10:32:10 2017 +0200 ofcs2: fix 'data' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Ic04842280e829b30230c7196ab0ba1f49462f295 Reviewed-on: https://code.wireshark.org/review/23016 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4d798e62ec7740a45fa2b82ecdcb102ca02d154c commit 4d798e62ec7740a45fa2b82ecdcb102ca02d154c Author: Alexis La Goutte Date: Thu Jul 27 10:33:17 2017 +0200 obex: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Id791b880d24f3ec948016c6bf00c00ac8f9cd6fb Reviewed-on: https://code.wireshark.org/review/23017 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=591d7ec817162687bee8a278c066891d86448e31 commit 591d7ec817162687bee8a278c066891d86448e31 Author: Alexis La Goutte Date: Thu Jul 27 10:34:58 2017 +0200 openflow (v1): fix 'pinfo/length' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Ie74d079cfe63dcdb5f59a576d64c93d4452edeb2 Reviewed-on: https://code.wireshark.org/review/23018 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b6d080a04e3553caa08af276881863948472fc19 commit b6d080a04e3553caa08af276881863948472fc19 Author: Alexis La Goutte Date: Thu Jul 27 10:36:28 2017 +0200 pcp: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused] Change-Id: I2cd58b58ff53951044ac13caffdc901d8c1b65bd Reviewed-on: https://code.wireshark.org/review/23019 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b4320e6662be0594beab5d9ab075e9b42867b5c7 commit b4320e6662be0594beab5d9ab075e9b42867b5c7 Author: Alexis La Goutte Date: Fri Jul 28 14:18:47 2017 +0200 bootp: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused] Change-Id: Ia711b3954aded55470d92d0787368a555481367d Reviewed-on: https://code.wireshark.org/review/23020 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=01f2e2b2012e09210104910646feee98128b458f commit 01f2e2b2012e09210104910646feee98128b458f Author: Guy Harris Date: Tue Aug 8 15:05:37 2017 -0700 We really only need one range_foreach routine. Rename range_foreach_r() to range_foreach(), getting rid of the old range_foreach(). If your callback doesn't require an additional argument, just pass NULL when calling range_foreach(), and declare the argument as unused. Change-Id: I49a56f90610e39cf2ddc398c9e30ed11a6ca90db Reviewed-on: https://code.wireshark.org/review/23025 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=3bcd0e142a3540ed8fa7a339728d0c10bacadcc8 commit 3bcd0e142a3540ed8fa7a339728d0c10bacadcc8 Author: Guy Harris Date: Tue Aug 8 14:04:53 2017 -0700 Fix a comment. \, not /, is the standard pathname separator on Windows. Change-Id: Ia1f1be5e4bd76519e27df430e8ef46967ffe35f5 Reviewed-on: https://code.wireshark.org/review/23024 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ae3fd56b20b1e1c0b2b9871827ed2f3529576717 commit ae3fd56b20b1e1c0b2b9871827ed2f3529576717 Author: Guy Harris Date: Tue Aug 8 14:02:45 2017 -0700 Check for errors running the Lua scripts. Also, fix error messages reported for lua_load() to speak of precompilation, not execution (the script isn't *executed* until lua_pcall() is called). Change-Id: I7ac9ee6e5df7612f9af141e51958fbfad38a4083 Reviewed-on: https://code.wireshark.org/review/23023 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=6d8f3ddc7c0147f0a316b53ce3c5f852d5eb5921 commit 6d8f3ddc7c0147f0a316b53ce3c5f852d5eb5921 Author: Ahmad Fatoum Date: Tue Aug 8 08:50:58 2017 -0400 checkAPIs.pl: Don't check prefs.[ch] for duplicate registered variables Change-Id: I389aa31db4da11b2b1e8d009a4cfeca03b587f45 Reviewed-on: https://code.wireshark.org/review/23014 Petri-Dish: Michael Mann Reviewed-by: Ahmad Fatoum Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=aae0f13b7e6223afe589e63e3fb77b8e95b00219 commit aae0f13b7e6223afe589e63e3fb77b8e95b00219 Author: Dario Lombardo Date: Tue Aug 8 10:29:32 2017 +0200 mrcpv2: fix bug in use of ws_strtou32. Bug: 13952 Change-Id: I374343368c629b7f063c922f0aa8de32e21a95e8 Reviewed-on: https://code.wireshark.org/review/23012 Petri-Dish: Dario Lombardo Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=a8b018b71cf2732254f4f2512f03719d2686f7b3 commit a8b018b71cf2732254f4f2512f03719d2686f7b3 Author: Ahmad Fatoum Date: Wed Apr 19 18:14:00 2017 +0200 Bump versions of macOS dependencies Versions were bumped to the newest available by Homebrew. Change-Id: I8f3f405d3644dff91035353e6f83131a507602cd Reviewed-on: https://code.wireshark.org/review/21224 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=956ebf371940bd176ce31b8ce72445ad702a7ccf commit 956ebf371940bd176ce31b8ce72445ad702a7ccf Author: Junpei Yoshino Date: Sat Aug 5 15:16:44 2017 +0900 Support multiple labels with bgp Passing multiple labels information with BGP has come to be used together with segment routing. Change-Id: Ifd45eb0a875ed4a166e44441955e5e42ce84a7ca Reviewed-on: https://code.wireshark.org/review/22944 Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=59e6c628931e041624607dfa67ae876376d23333 commit 59e6c628931e041624607dfa67ae876376d23333 Author: Michael Mann Date: Mon Aug 7 18:36:30 2017 -0400 io_graph_dialog.cpp: Remove graph_enabled_vs. No longer necessary with model Change-Id: If1516f264013fabe1211aa04fe054b15e235b36a Reviewed-on: https://code.wireshark.org/review/23007 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=8d37cab5812780e7e4738e68ed7b8a5980a9e9b0 commit 8d37cab5812780e7e4738e68ed7b8a5980a9e9b0 Author: Martin Mathieson Date: Mon Aug 7 23:25:52 2017 +0100 SMTP: show text lines within a PDU fragment. Change-Id: I49ef553c29742ba18d477a61183ce8b6f5e23233 Reviewed-on: https://code.wireshark.org/review/23006 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=300be929de03281a31c0cf5e91302ad5baba1cd2 commit 300be929de03281a31c0cf5e91302ad5baba1cd2 Author: Alexis La Goutte Date: Tue Aug 8 00:11:18 2017 +0200 dns: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I1bb25125d9bd7b62b5784bd43d933dc5ff13987c Reviewed-on: https://code.wireshark.org/review/23005 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=24f0e6fe8a1741d8d8267e8c47cc6dc79babecc7 commit 24f0e6fe8a1741d8d8267e8c47cc6dc79babecc7 Author: Alexis La Goutte Date: Tue Aug 8 00:07:20 2017 +0200 dns: remove extra semicolon Change-Id: I710d9c519ccf012d3e74e7c2087d0f9fc5cfca12 Reviewed-on: https://code.wireshark.org/review/23004 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f5332121ef787684093ed46fd2e01c754c4ef946 commit f5332121ef787684093ed46fd2e01c754c4ef946 Author: Alexis La Goutte Date: Tue Aug 8 00:01:39 2017 +0200 XFP: use switch for adress_family Change-Id: Id0f9fd6d49669f5d4606448788658e5a8ed89f8d Reviewed-on: https://code.wireshark.org/review/23003 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1089bdb7d4911a5508f86a0eea59418b424b265c commit 1089bdb7d4911a5508f86a0eea59418b424b265c Author: Ahmad Fatoum Date: Sun Aug 6 19:00:54 2017 +0200 checkAPIs.pl: Detect multiple preferences with same variable Catches mistakes where the same variable is populated by multiple preferences: prefs_register_bool_preference(epl_module, "show_soc_flags", "text1", "desc1", &show_soc_flags); prefs_register_bool_preference(epl_module, "show_soa_flags", "text2", "desc2", &show_soc_flags); Change-Id: I77a9432d9b518e951166c93a890a948d3f228162 Reviewed-on: https://code.wireshark.org/review/22974 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e63db3ce0ec2e92d69b5e452f71f5c44cd205272 commit e63db3ce0ec2e92d69b5e452f71f5c44cd205272 Author: Ahmad Fatoum Date: Mon Aug 7 17:44:06 2017 +0200 Rename reentrant range_foreach2 to range_foreach_r to avoid mistaking it for a range function that operates on pairs. Change-Id: If9117c195ba21d55a476c3b9deb2a2ca7a1056ed Reviewed-on: https://code.wireshark.org/review/22994 Reviewed-by: Jo??o Valverde Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c6963b1c2f87c5f7a9123aa9e8e843540c18ff41 commit c6963b1c2f87c5f7a9123aa9e8e843540c18ff41 Author: Balint Reczey Date: Sun Aug 6 19:02:35 2017 -0400 debian: Update PO files about debconf templates Change-Id: I2880957bcff90f8fba3d5c880f7e059589191e84 Reviewed-on: https://code.wireshark.org/review/22978 Reviewed-by: Balint Reczey Petri-Dish: Balint Reczey Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b44fb245f5cef586fae8a4d3d2492d50b0f90c93 commit b44fb245f5cef586fae8a4d3d2492d50b0f90c93 Author: Balint Reczey Date: Sat Jun 10 13:12:40 2017 -0700 debian: Use debconf messages instead of "echo" in postinst/postrm Change-Id: Ice41c3a723c2606c047ad59a1fde17dfe65f3ce7 Signed-off-by: Balint Reczey LP: #1687344 Reviewed-on: https://code.wireshark.org/review/22968 Reviewed-by: Balint Reczey Petri-Dish: Balint Reczey Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=44e117bf7340298584b449d0a313a2f7f388d1af commit 44e117bf7340298584b449d0a313a2f7f388d1af Author: Balint Reczey Date: Sat Aug 5 17:08:53 2017 +0200 debian: Make d/copyright machine-readable The machine-readable format is recommended by the Debian Policy Manual: https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightformat It also allows uscan to omit files from repacked upstream tarballs. In wireshark package's case it allows removing the debian/ directory from the tarball. Change-Id: I0d56efaff26bb61048de795e109c9f5d26cbffc4 Signed-off-by: Balint Reczey Reviewed-on: https://code.wireshark.org/review/22969 Reviewed-by: Jaap Keuter Reviewed-by: Balint Reczey Petri-Dish: Balint Reczey Tested-by: Petri Dish Buildbot http://cgit.osmocom.org/wireshark/commit/?id=2ca4c5d756b7f7f507b7949bc31682839cb3e2b8 commit 2ca4c5d756b7f7f507b7949bc31682839cb3e2b8 Author: Guy Harris Date: Mon Aug 7 12:13:56 2017 -0700 Fix lz4 and libssh uninstall. We have to remove the lz4 build tree as root. We can't do "make uninstall" for libssh, so manually remove the stuff it installs. Also, remove the -done file, and remove the downloaded tarball and build tree if we're supposed to do so. Change-Id: If594ab241a9955229dfbc12e4f5e0c517add6daa Reviewed-on: https://code.wireshark.org/review/22996 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a0ee5d6e42a00d76ff8d98b8877867927896c165 commit a0ee5d6e42a00d76ff8d98b8877867927896c165 Author: Ahmad Fatoum Date: Mon Aug 7 17:42:10 2017 +0200 Fix -Wdocumentation warning about range_foreach2 Mismatch between parameter name in comment and prototype Change-Id: Ia458362a3cc8cd073dbb0a184f28b28f12b19b9f Reviewed-on: https://code.wireshark.org/review/22993 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=5b3e3ee58748ac1fd9201d2d3facbed1b9b1e800 commit 5b3e3ee58748ac1fd9201d2d3facbed1b9b1e800 Author: Michael Mann Date: Sun Jul 23 10:53:43 2017 -0400 Use UAT model for I/O graph Convert from using TreeWidgetItems to UAT model/delegate. More of the GUI is "just handled" within the table. Required to add support for "colors" and "protocol fields" to UAT types. Also needed to add some hacks for "custom" UAT field handlers for backwards compatibility with the existing UAT structure used. Because UAT functionality was switched completely to the model, some information in the table was "lost in translation" because the UATs themselves aren't translated to other languages. TODO: 2. Better "order of operations"? A bunch of NULL/size checks needed to be added to prevent crashing. Now with model/"view" should events/functions be reordered? Bug: 13585 Change-Id: I2bbba78182317c4fada07b927c05d0c6f4cdc0fe Reviewed-on: https://code.wireshark.org/review/22766 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f63b0241c9eeb1ef3dc1e915820c440119c30526 commit f63b0241c9eeb1ef3dc1e915820c440119c30526 Author: Guy Harris Date: Mon Aug 7 10:08:43 2017 -0700 Fix SpanDSP build with older versions of Xcode. Older versions of Xcode don't support -Wunused-but-set-variable, so remove it from the list of options with which to compile SpanDSP. Change-Id: Idd298e19eaf770980da179412480e17a00514d36 Reviewed-on: https://code.wireshark.org/review/22991 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=4053bde54b9c356bdee4f4e7548790ce5a06e9a5 commit 4053bde54b9c356bdee4f4e7548790ce5a06e9a5 Author: Gerald Combs Date: Mon Aug 7 15:42:37 2017 +0000 Qt: Restrict AA_EnableHighDpiScaling to Windows. Setting Qt::AA_EnableHighDpiScaling on X11 causes problems: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13877#c20 Limit its use to Windows. Change-Id: I8c11c575b2680402689644bcc5c224da876bba67 Ping-Bug: 13877 Reviewed-on: https://code.wireshark.org/review/22988 Petri-Dish: Gerald Combs Reviewed-by: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=82ef9377fe88c213c5e5a02279d2714f88add665 commit 82ef9377fe88c213c5e5a02279d2714f88add665 Author: Jo??o Valverde Date: Mon Aug 7 17:51:08 2017 +0100 RADIUS: Minor cleanup Have "avp_is_extended" fully control extended attribute properties. including "long-extended". Change-Id: I73b3636b08fe088b7dc4113b1b4144a97bc59efa Reviewed-on: https://code.wireshark.org/review/22989 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=4855ae29508e8a659b3620fab93c4138fd7ed4f6 commit 4855ae29508e8a659b3620fab93c4138fd7ed4f6 Author: Alexis La Goutte Date: Thu Jul 20 15:45:18 2017 +0200 debian: Update symbols Change-Id: Id65e57766d8f31615f210cfe8ac3e03a16f180c8 Reviewed-on: https://code.wireshark.org/review/22987 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=5d0cf59d06cbe62fc15c2256b7a86417fc0dff80 commit 5d0cf59d06cbe62fc15c2256b7a86417fc0dff80 Author: Stig Bj??rlykke Date: Mon Aug 7 10:00:53 2017 +0200 nsis: Fix typo in installer Change-Id: Ic958729517dda653fc3f511379aa48956d87d225 Reviewed-on: https://code.wireshark.org/review/22986 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=d81f907aea269b12dc383911bfb469addfaffade commit d81f907aea269b12dc383911bfb469addfaffade Author: Balint Reczey Date: Sat Aug 5 17:11:00 2017 +0200 debian: Refresh patches Change-Id: Ib31e658cfa87f31fad9750f1ba2cf326d0944689 Signed-off-by: Balint Reczey Reviewed-on: https://code.wireshark.org/review/22970 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ff7a6305a7eaa3c3815e813acc78a1660ae82293 commit ff7a6305a7eaa3c3815e813acc78a1660ae82293 Author: Michael Mann Date: Sun Jul 30 23:30:59 2017 -0400 Use proper tab order for "file types" in UAT "table". Directory and File "UAT types" have been using a separately launched dialog, instead of an "editor", so it breaks "tab rules". Create and treat (File) dialog as an editor. Change-Id: I983728abefb0cdd79899468a800328f1b56e2910 Reviewed-on: https://code.wireshark.org/review/22886 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=4dc835c9c6b7af68cd63ae9efa26ac23ee3d9365 commit 4dc835c9c6b7af68cd63ae9efa26ac23ee3d9365 Author: Guy Harris Date: Sun Aug 6 18:20:40 2017 -0700 -Wcast-align will warn about legitimate code. Maybe there's some way to say "yes, I know that the pointer being cast is appropriately aligned", or maybe some platforms say "yes, I know, this is a struct sockaddr *, but those are aligned well enough for any other socket address types", in which case we might be able to turn that on by default in some cases. Change-Id: I6b8cff7ebfe27785b20adbbc2f855e859b090236 Reviewed-on: https://code.wireshark.org/review/22983 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=98ff0410c83ae9868803bb81319a3476dfb2c8f1 commit 98ff0410c83ae9868803bb81319a3476dfb2c8f1 Author: Guy Harris Date: Sun Aug 6 18:04:43 2017 -0700 Minor comment style tweak. Change-Id: I58359c5a7c38e61cc7c024f1c74951679522101f Reviewed-on: https://code.wireshark.org/review/22982 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=fde17d9ba0c2d12434b26f5f0cb158093acfbfcf commit fde17d9ba0c2d12434b26f5f0cb158093acfbfcf Author: Guy Harris Date: Sun Aug 6 18:03:14 2017 -0700 Separate the C-only and C-and-C++ extra compiler options. Move -Wduplicated-branches, which is C-and-C++, above -Wbad-function-cast, which is C-only. This matches CMakeLists.txt. Change-Id: I7c60695252645524f80461575ce3e92572e0efa7 Reviewed-on: https://code.wireshark.org/review/22981 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a511b7159123704c5c6e488b96c4ff3311498423 commit a511b7159123704c5c6e488b96c4ff3311498423 Author: Guy Harris Date: Sun Aug 6 17:58:00 2017 -0700 Sync up a bit with configure.ac. Move -Wunused-const-variable after -Wc++-compat. Move -Wduplicated-branches after -Wdocumentation. Add some comments for the warning flags for which the configure script does a test to make sure the compiler doesn't mishandle them. Add some other comments. Change-Id: I7f648ff78eb932feef34aeccfff179bd0a2e5d49 Reviewed-on: https://code.wireshark.org/review/22980 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=9c3899bbf45ec3bdbb78f5249a3f7ea05d793966 commit 9c3899bbf45ec3bdbb78f5249a3f7ea05d793966 Author: Guy Harris Date: Sun Aug 6 17:34:52 2017 -0700 Add a comment explaining why ASan and UBSan are involved. Change-Id: I31a429c247ed9f8efb97560d517423b0bf2d82f1 Reviewed-on: https://code.wireshark.org/review/22979 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=cd7c47e6389d7641e65bef8215f2c101a9977465 commit cd7c47e6389d7641e65bef8215f2c101a9977465 Author: Guy Harris Date: Sun Aug 6 15:49:13 2017 -0700 Fix setting COMMON_WARN_FLAGS. If we want to add -Wframe-larger-than=16384, *append* it, don't *overwrite* it. Indent that code properly while we're at it. Change-Id: Iae8894e6663500620a07589fd6ba3d00f9eac7ba Reviewed-on: https://code.wireshark.org/review/22977 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=b0b874815d7c31057a13c062ea7e973e18bde9a7 commit b0b874815d7c31057a13c062ea7e973e18bde9a7 Author: Balint Reczey Date: Sat Aug 5 12:15:35 2017 +0200 debian: Fix typo in d/control Change-Id: Iaec804825f3d85b4b6ed4fa82300cd41849ed23d Reviewed-on: https://code.wireshark.org/review/22966 Reviewed-by: Balint Reczey http://cgit.osmocom.org/wireshark/commit/?id=c09f3ed774a8a124eb1710cc332677627da04aff commit c09f3ed774a8a124eb1710cc332677627da04aff Author: Jo??o Valverde Date: Sun Aug 6 10:41:42 2017 +0100 Make the services dictionary ordering stable Change-Id: I1d148fc5bc58998818043885615965eecc86b3de Reviewed-on: https://code.wireshark.org/review/22965 Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=912542f7bec16dd3ca9aa47933b94a395b8f5868 commit 912542f7bec16dd3ca9aa47933b94a395b8f5868 Author: Gerald Combs Date: Sun Aug 6 08:08:04 2017 +0000 [Automatic update for 2017-08-06] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie6f7676ccde9337cb479e448884b0240e3fd238c Reviewed-on: https://code.wireshark.org/review/22961 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=839032dff87ae4ad5533fc275719f3ee72186cbc commit 839032dff87ae4ad5533fc275719f3ee72186cbc Author: Michael Mann Date: Sat Aug 5 21:01:04 2017 -0400 simple_dialog.cpp: Fix missed Qt version wrapper. check_box_ member was missing a #if (QT_VERSION > QT_VERSION_CHECK(5, 2, 0)) wrapper Change-Id: Ibdddbe523b8e15c0af31fddfd3f251c24114d11a Reviewed-on: https://code.wireshark.org/review/22959 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f63b68f7078a482d31d6bc22569756c09a0a2202 commit f63b68f7078a482d31d6bc22569756c09a0a2202 Author: Guy Harris Date: Sat Aug 5 15:50:46 2017 -0700 Further cleanups. If a variable is initialized in a loop body or an if clause or a switch clause, declare it inside the loop body/clause, and de-initialize it before leaving the loop body/clause. De-initialize the gnutls_pkcs12_t before leaving rsa_load_pkcs12(), so as not to leak it. Always leave the per-bag loop by "goto done", even if we're not within an inner loop, to make it clearer what we're doing. We initialize the bag structure at the beginning of that loop body; de-initialize it at the end. If we leave the loop without a private key, and we don't have an error message, the error is "we didn't find a PKCS8 key"; report that. Change-Id: I87cf296876c8f1879f69d01ce67ca2829b4f8d16 Reviewed-on: https://code.wireshark.org/review/22958 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=1d457701c5d969f3912d763c3e912b913497b97c commit 1d457701c5d969f3912d763c3e912b913497b97c Author: Michael Mann Date: Sat Aug 5 13:01:29 2017 -0400 rsa.c: strerror -> g_strerror Pacify checkAPIs.pl Change-Id: I637a6cd678b99d05cd1b26fd3cba6ad4dd19e8d2 Reviewed-on: https://code.wireshark.org/review/22957 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=92adb99d00eca0ff23e9c791053d93d6310faa99 commit 92adb99d00eca0ff23e9c791053d93d6310faa99 Author: Uli Heilmeier Date: Wed Aug 2 08:53:35 2017 +0200 QT: Add shortcuts for "Follow XXX Stream" Add shortcut Ctrl+Alt+Shift+ T for "Follow TCP Stream" U for "Follow UDP Stream" H for "Follow HTTP Stream" S for "Follow SSL Stream" Bug: 13047 Change-Id: I0fdd5b4d20b976b56694821a9c11424eab40b2b3 Reviewed-on: https://code.wireshark.org/review/22930 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c57da453bab14048f419eae6b9e9ff7a332a32f0 commit c57da453bab14048f419eae6b9e9ff7a332a32f0 Author: John Keeping Date: Sat Aug 5 15:13:40 2017 +0100 ZigBee: fix OTA File Version bitfield Commit ffea2f8a24 ("ZigBee: fix endian for File Version field in OTA") fixed the endianness of the file version field but did not update the masks for the sub-elements of this field now that they are compared against the value decoded as little-endian. Change-Id: Icdb9d56cc29da19b9fc26da84979f15936c930d4 Reviewed-on: https://code.wireshark.org/review/22955 Petri-Dish: Alexis La Goutte Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=15c0c8db5e0aac50e44eb3e2cd6eb5c0b3585220 commit 15c0c8db5e0aac50e44eb3e2cd6eb5c0b3585220 Author: Stig Bj??rlykke Date: Sat Aug 5 12:19:02 2017 +0200 Lua: Check for PseudoHeader.none Don't dereference pointer when using PseudoHeader.none. Bug: 13944 Change-Id: I4e509269ac4983531912f3f9b2cc6b7cf00fbeae Reviewed-on: https://code.wireshark.org/review/22945 Petri-Dish: Stig Bj??rlykke Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=4b4ce9fb35a46447796252cbfd1af4ea6b889d55 commit 4b4ce9fb35a46447796252cbfd1af4ea6b889d55 Author: Stig Bj??rlykke Date: Sat Aug 5 12:29:33 2017 +0200 Lua: Fix error message in Dumper:dump() Change-Id: I9cdf8ecaf5129a30091b9b4d109f70cfdd7fca1b Reviewed-on: https://code.wireshark.org/review/22946 Reviewed-by: Stig Bj??rlykke http://cgit.osmocom.org/wireshark/commit/?id=7dbc022b373c26b48b2a68106fafa3dd25d9e7e3 commit 7dbc022b373c26b48b2a68106fafa3dd25d9e7e3 Author: Robert Grange Date: Fri Aug 4 19:22:48 2017 +0200 packet-mq: Improve ECapFlag display + CapFlag3 Add new Flag Improve dispaly of Error Cap Flags Add new Flag for Cap Flag Misc coding aligmement Change-Id: I9ad593dbe8bcc116057af9a6324f25451bac2a88 Reviewed-on: https://code.wireshark.org/review/22938 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b9b7389e21010b19110c0591b6639d334d15f019 commit b9b7389e21010b19110c0591b6639d334d15f019 Author: Guy Harris Date: Fri Aug 4 18:18:01 2017 -0700 Lines being processed are not null terminated, they're counted. Pass the remaining line length to process_pwd_success(), and don't treat the string passed to it as a null-terminated string, check the length value. Also, make sure the line is long enough before even calling process_pwd_success(). Bug: 13946 Change-Id: I67d015854046bbaaa6f55d4221f314e1446e7398 Reviewed-on: https://code.wireshark.org/review/22943 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=cdeb6f122a80c8ae39418897346b20b2c26acc00 commit cdeb6f122a80c8ae39418897346b20b2c26acc00 Author: Gerald Combs Date: Fri Aug 4 13:53:14 2017 -0700 WSDG: Update the Windows docs and add a CMake section. Update the Windows section for Visual Studio 2015. Copy the content from README.cmake to its own WSDG section and remove README.cmake. Remove the PowerShell sections. Our required version (2.0) ships with every supported version of Windows. Remove the sed section. Change-Id: Id37c6e71bacc247a3ed1992adb1408ec13f6a187 Reviewed-on: https://code.wireshark.org/review/22940 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=1cabeea9b8ab109c7a731c0f61c7b9788077ffea commit 1cabeea9b8ab109c7a731c0f61c7b9788077ffea Author: Guy Harris Date: Fri Aug 4 15:26:40 2017 -0700 Fix up indentation. Change-Id: I99445d9934dbb4c97c4c41192c8fe908441f2843 Reviewed-on: https://code.wireshark.org/review/22942 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=a25d477fa7969f6311bc8df0ff4df8208e80fa6f commit a25d477fa7969f6311bc8df0ff4df8208e80fa6f Author: Guy Harris Date: Fri Aug 4 15:25:22 2017 -0700 Clean up private key file error reporting. Ensure that rsa_load_pem_key() and rsa_load_pkcs12() always return an error message string if they fail, so that 1) they don't return NULL without supplying an error string; 2) they don't supply an error string if they succeed. If either of them fails, report the error; if there's no error string, report an unknown error (that shouldn't happen, but the wsutil/rsa.c code needs more cleanup before I'll believe it can't happen). While we're at it, clean up some of those error strings, return NULL rather than 0 as the failure case from rsa_load_pkcs12() as we do in rsa_load_pem_key() (they mean the same thing, but NULL makes it a bit clearer), and de-initialize the private key structure in rsa_load_pem_key() if we fail (so that we don't leak memory). Change-Id: Id9dd331800d87b017a500a6f579df446057f555b Reviewed-on: https://code.wireshark.org/review/22941 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=8d09f2a3adc4ac3d394ca07e5a12607ed0368d60 commit 8d09f2a3adc4ac3d394ca07e5a12607ed0368d60 Author: Guy Harris Date: Fri Aug 4 13:12:10 2017 -0700 Don't assume that we have a last_command value in an FTP conversation. Nothing ensures that will be the case, and if we assume it is the case, we can crash. Bug: 13945 Change-Id: I7f6cb47da81efe219e87b06f8def65a332273480 Reviewed-on: https://code.wireshark.org/review/22939 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=97dcf87a868a51502e1ea6a90cd7a9ee3bbc59cf commit 97dcf87a868a51502e1ea6a90cd7a9ee3bbc59cf Author: Olivier Verriest Date: Sun Jul 30 14:07:43 2017 +0000 SNMP: add support for USM SHA-2 algorithms (RFC 7860) Generlize the USM handling and add support for HMAC-SHA-2 authentication protocols. Change-Id: I7cca2f24db61620423fded078c680322aff86400 Reviewed-on: https://code.wireshark.org/review/22846 Reviewed-by: Jaap Keuter Petri-Dish: Jaap Keuter Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=dc69a8446ee47fd6d38d4fb4416db89ef5487696 commit dc69a8446ee47fd6d38d4fb4416db89ef5487696 Author: Gerald Combs Date: Thu Aug 3 22:36:11 2017 +0000 CMake: Don't look in WOW6432Node. CMake should check both the 32-bit and 64-bit views automatically. Change-Id: I856814efcd660260c734c7956ad00ee43a8f666f Reviewed-on: https://code.wireshark.org/review/22936 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=f155beb0946391ea633936647b4c68998ecf01bb commit f155beb0946391ea633936647b4c68998ecf01bb Author: Gerald Combs Date: Thu Aug 3 08:39:13 2017 -0700 Qt: Fixup the welcome screen stylesheet. Pass in a QString argument only when we have a placeholder. Fixes a QString::arg: Argument missing: MainWelcome { ... warning on Windows. Change-Id: I42dd155252bd9fd4f21f0112b62044c7397c9810 Reviewed-on: https://code.wireshark.org/review/22934 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ce7b994383a8089e7c05b7c88132fe78de9a1be9 commit ce7b994383a8089e7c05b7c88132fe78de9a1be9 Author: Pascal Quantin Date: Wed Aug 2 21:32:30 2017 +0200 proto.c: fix use of proto_tree_add_text(_valist)_internal() with length = -1 When using a length of -1, use the tvb remaining length instead of 0. Change-Id: I569e9c9f57531914a3b613c3a6a9bff076fba362 Reviewed-on: https://code.wireshark.org/review/22931 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=733c19a0720035c1aa19d79f765d72b085d58bdd commit 733c19a0720035c1aa19d79f765d72b085d58bdd Author: Jo??o Valverde Date: Tue Jul 18 19:47:58 2017 +0100 Optimize the "services" dictionary Remove assignee and other miscellaneous information that changes more frequently than service name and can be consulted directly in the IANA registry. Allow merging identical transports into a single line for convenience and size/speed optimization (a backward-compatible change). Remove obsolete make-services.pl. Change-Id: I3ecbd1a6a68d87c084d77498a0eeb44b7afdab67 Reviewed-on: https://code.wireshark.org/review/22872 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=936a8f1cf8c314993f7fca6f193764cb53652924 commit 936a8f1cf8c314993f7fca6f193764cb53652924 Author: Martin Mathieson Date: Sun Jul 16 19:02:41 2017 +0100 FTP: track current working directory and show as generated field Change-Id: Ib43f0a7c96f4a2dfd931224b536a8ff5d17b0a36 Reviewed-on: https://code.wireshark.org/review/22651 Petri-Dish: Martin Mathieson Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e3d0bf0bb2aea5e6f18cce32ad0e75e14169c413 commit e3d0bf0bb2aea5e6f18cce32ad0e75e14169c413 Author: Dario Lombardo Date: Thu Aug 3 13:39:26 2017 +0200 extcap: skip custom log if filename is space. Change-Id: I98b890316af05d9c5359dc38a30d07ac55f262fe Reviewed-on: https://code.wireshark.org/review/22932 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=f978465fb36cc8ea799ba5553f5c6722c7cf241a commit f978465fb36cc8ea799ba5553f5c6722c7cf241a Author: Dario Lombardo Date: Sun Jul 23 22:54:31 2017 +0200 extcap: add debug log file feature to extcap-base. Change-Id: I3bfc9b2fd7b73dcfef52c5101360384d205c0d12 Reviewed-on: https://code.wireshark.org/review/22835 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=03f9bd4091ef42e7dc42ef8fb275bc26cd619d5a commit 03f9bd4091ef42e7dc42ef8fb275bc26cd619d5a Author: Pascal Quantin Date: Wed Aug 2 18:17:19 2017 +0200 MAC LTE: upgrade dissector to v14.3.0 Change-Id: Icd3b12b7d89df2050b9365b9b173949a7cdc455a Reviewed-on: https://code.wireshark.org/review/22928 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=e4a8c71da8f742e3b1cadf70069554cc0ef1f8c1 commit e4a8c71da8f742e3b1cadf70069554cc0ef1f8c1 Author: Pascal Quantin Date: Wed Aug 2 16:11:53 2017 +0200 RLC LTE: update header to reflect the correct version Change-Id: Ic9146d4679fc4af0800bbc1bdf40ec54d1809f1a Reviewed-on: https://code.wireshark.org/review/22927 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=f524eb4dc114cc297d68a42ed9ed57fcebcde4f0 commit f524eb4dc114cc297d68a42ed9ed57fcebcde4f0 Author: Pascal Quantin Date: Wed Aug 2 15:57:11 2017 +0200 PDCP LTE: upgrade dissector to v14.3.0 Change-Id: I96d2a9e703f1c9403f09d77e6b8ee06658b9c40f Reviewed-on: https://code.wireshark.org/review/22926 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=ddb373ecb0510a0e52c030fce4ff0485b1d0345b commit ddb373ecb0510a0e52c030fce4ff0485b1d0345b Author: Marius Paliga Date: Wed Aug 2 13:40:50 2017 +0200 mpeg descriptor: dissect ac3 system a: Respect descriptor length Bug: 13939 Change-Id: I3fbbbb4e806e0732c2d11a7fd5048528c5f6f328 Reviewed-on: https://code.wireshark.org/review/22923 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=31dc0310e2303deb9eec4824632683313d0d8699 commit 31dc0310e2303deb9eec4824632683313d0d8699 Author: Mike Lugo Date: Wed Aug 2 10:10:23 2017 -0400 Added AVP definitions for the following AVPs: 132017 - Override-Control 132019 - Override-Charging-Action-Parameters 132021 - Override-Charging-Action-Exclude-Rule 132022 - Override-Charging-Parameters 132024 - Override-Rating-Group 132026 - Override-Online 132027 - Override-Offline For reference, page 51: http://www.cisco.com/c/en/us/td/docs/wireless/quantum-policy-suite/R13-0-0/CPS13-0-0MobileConfigurationGuide/bk_Mobile_Config_Guide_chapter_01000.pdf Change-Id: I397dfad5ea0bd7d06d8b06034c44cc676c293416 Reviewed-on: https://code.wireshark.org/review/22925 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=1da9d28edc9eae3414d4d04880add60a7e8e0c6d commit 1da9d28edc9eae3414d4d04880add60a7e8e0c6d Author: Guy Harris Date: Wed Aug 2 00:44:07 2017 -0700 Distribute macos-setup-brew.sh in the source tarball. Change-Id: I9521810d7e9d8b3b13f7949256fa409eafd1cc2c Reviewed-on: https://code.wireshark.org/review/22920 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=0147a74becb2020850d75a611c65294520bd6c64 commit 0147a74becb2020850d75a611c65294520bd6c64 Author: Guy Harris Date: Wed Aug 2 00:41:49 2017 -0700 Remove trailing white space. Change-Id: I6b650521e86a64526db75f38bfb93ea1b890f6a1 Reviewed-on: https://code.wireshark.org/review/22919 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=2a17c33928eba4ee0e383ee838b5980748448730 commit 2a17c33928eba4ee0e383ee838b5980748448730 Author: Guy Harris Date: Wed Aug 2 00:39:58 2017 -0700 Move macosx-setup.sh to tools and remove the "x". The OS is now called just macOS, and the rest of the setup scripts are in tools, so move this one there as well. Update the documentation to reflect the change. Change-Id: I4d9ebf0797ffe8862e82c4bcfdeec1d2eabae6ae Reviewed-on: https://code.wireshark.org/review/22918 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=c5569cfa0b985b763608231fe4b2fc976422aa33 commit c5569cfa0b985b763608231fe4b2fc976422aa33 Author: Guy Harris Date: Wed Aug 2 00:30:28 2017 -0700 Note that newer versions of various distributions won't have these problems. Change-Id: Ib5f0d9ffe4a2a574c5cc2299271d3c5f9828dede Reviewed-on: https://code.wireshark.org/review/22914 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=778117c502d9e702327f592784c8d7b94212302c commit 778117c502d9e702327f592784c8d7b94212302c Author: Guy Harris Date: Tue Aug 1 17:41:03 2017 -0700 macosx-setup.sh doesn't build Qt, it just installs a binary. Say it builds "as needed". Change-Id: I85ce2062da7f168785d0d22160b8f19b85d554e3 Reviewed-on: https://code.wireshark.org/review/22909 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e23e28da225fc51493f1694f9f61bc23df1b9ad9 commit e23e28da225fc51493f1694f9f61bc23df1b9ad9 Author: Guy Harris Date: Tue Aug 1 17:04:15 2017 -0700 Add bcg729. Change-Id: I5ee7a2a9027f67e003744f3e076429ef2eda0a4b Reviewed-on: https://code.wireshark.org/review/22908 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=25b9d31526beb75fe8f96bd2db2a09affef17204 commit 25b9d31526beb75fe8f96bd2db2a09affef17204 Author: Guy Harris Date: Tue Aug 1 16:36:01 2017 -0700 Add SpanDSP to the set of libraries to download and install. Change-Id: I23c22aff1f4fadeaac120e01e5b222d2da5cb1f2 Reviewed-on: https://code.wireshark.org/review/22906 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7c5ff646dc6328233da09d9fc9b68c25eec8a9ba commit 7c5ff646dc6328233da09d9fc9b68c25eec8a9ba Author: Gerald Combs Date: Mon Jul 31 10:09:32 2017 -0700 Look for Cygwin in one more place. Add "HKLM\SOFTWARE\WOW6432Node\Cygwin\setup" to the Cygwin search paths. Change-Id: I302ecea67dd580449b450136c027ac37adf586d3 Reviewed-on: https://code.wireshark.org/review/22893 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=f24c1564bd9e71176bbff781e0e38cd0e29e9fa3 commit f24c1564bd9e71176bbff781e0e38cd0e29e9fa3 Author: Pascal Quantin Date: Tue Aug 1 21:30:19 2017 +0200 Update USBPcap to 1.2.0.2 Change-Id: I0f318cdd3644ef4eb2195bed3d0bd561dde7f6dc Reviewed-on: https://code.wireshark.org/review/22903 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=fb052a637fe41ab87af98753593a8cd5a07735de commit fb052a637fe41ab87af98753593a8cd5a07735de Author: Jo??o Valverde Date: Tue Jul 18 00:22:25 2017 +0100 Use g_build_filename() instead, fix indentation Change-Id: I459208eed4a76b104bc28aa44ab05374e57043de Reviewed-on: https://code.wireshark.org/review/22873 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=eeab5f48fe6da19f1519149a5ea57b1ab7466e0d commit eeab5f48fe6da19f1519149a5ea57b1ab7466e0d Author: Hassan Sultan Date: Thu Jul 27 11:43:48 2017 -0700 SMB2: Move the blob offset & length fields from under the security blob since they're physically placed before the blob. Also renamed them to clarify their link to the blob Change-Id: I896ce8eea3f5f41c1887a685247e7fa168cc9061 Reviewed-on: https://code.wireshark.org/review/22823 Petri-Dish: Stig Bj??rlykke Reviewed-by: Richard Sharpe http://cgit.osmocom.org/wireshark/commit/?id=81b8d014567c7957da86e820c2b61fe003aca3b3 commit 81b8d014567c7957da86e820c2b61fe003aca3b3 Author: Pascal Quantin Date: Tue Aug 1 19:57:47 2017 +0200 CMS, ESS: regenerate ASN.1 dissectors after g49e920bc21 Change-Id: I518e94cba90a4d2ad9f5f3e787279de358adabc5 Reviewed-on: https://code.wireshark.org/review/22901 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=c79382e69b37b3ff854ab88999a3dc6df0baf8f5 commit c79382e69b37b3ff854ab88999a3dc6df0baf8f5 Author: Pascal Quantin Date: Tue Aug 1 19:52:51 2017 +0200 SNMP: regenerate ASN.1 dissector after g7466880e8a Change-Id: Ie6f93ed3c5c98d7a5df8d6fdc678551d53feee71 Reviewed-on: https://code.wireshark.org/review/22900 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=6893f7a5c7d223e9e3ef9966ce9757588196c66a commit 6893f7a5c7d223e9e3ef9966ce9757588196c66a Author: Marius Paliga Date: Tue Aug 1 10:52:54 2017 +0200 E212: Check MNC length before trying 3-digits length Bug: 13935 Change-Id: Ib3f86c7a70d065cf7d5659a2fbc9c34047efcb56 Reviewed-on: https://code.wireshark.org/review/22894 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=4e9085696b0a0354b4ece9aa32230952608b3fa4 commit 4e9085696b0a0354b4ece9aa32230952608b3fa4 Author: Pascal Quantin Date: Mon Jul 31 10:43:58 2017 +0200 CMake: do not check stack size when compiling with ASan or UBSan Instrumentation code increases the stack usage. Let's deactivate the check when compiling with ASan or UBSan as the objective here is not to check the stack consumption and its usage is out of our control. Change-Id: I9d6e269a0d404dc1833183a070fdbbb7fb0446e0 Reviewed-on: https://code.wireshark.org/review/22888 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=6cff9c8da6a8190258f3b392312297ca2ac11e33 commit 6cff9c8da6a8190258f3b392312297ca2ac11e33 Author: Uli Heilmeier Date: Tue Jul 25 22:12:52 2017 +0200 Netflow: Reassemble flows spanning multiple PDUs Flows records can span multiple PDUs (e.g when using TCP). This commit adds the preference to reassemble flows. Bug: 13915 Change-Id: I10eb0d9ee5ff5cc06ff52d0d0c8c468140e0273b Reviewed-on: https://code.wireshark.org/review/22792 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=38b7660eeddbda98d406dd130f2a3bda08ca1977 commit 38b7660eeddbda98d406dd130f2a3bda08ca1977 Author: Harald Welte Date: Fri Jul 28 19:23:15 2017 +0200 gprs-llc: Don't attempt to decode Dummy UI Command As explained by 3GPP TS 44.064 Section 6.4.2.2 there are Dummy UI Commands which are never generated by a LLC entity, but nevertheless received by a LLC entity. They are generated by the underlying network-side RLC/MAC entity a as a means to artificially delay the release of a downlink TBF. We introduce a new "llcgprs.dummy_ui" boolean field on which the user can match to filter our such messages, if needed. Change-Id: Ie8fcb42cbd66a7e5b77849f0bc5a3630d0d54a9c Reviewed-on: https://code.wireshark.org/review/22862 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c9cb01adbb24c91b665c6c219573f8ee96e1986c commit c9cb01adbb24c91b665c6c219573f8ee96e1986c Author: Pascal Quantin Date: Mon Jul 31 08:36:46 2017 +0200 IrCOMM: check string length before appending it to item Bug: 13929 Change-Id: I33f3fec77014949fcc15df72c42ffcb25158562f Reviewed-on: https://code.wireshark.org/review/22887 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4af5e1a5c3fef04bd6e8131cbfad6617238d5f91 commit 4af5e1a5c3fef04bd6e8131cbfad6617238d5f91 Author: Guy Harris Date: Sun Jul 30 18:27:35 2017 -0700 Don't force people to do a Web search to find the header layout. Change-Id: Ie71db56327e1cb17b46da0d0675e3485bebd2439 Reviewed-on: https://code.wireshark.org/review/22885 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=4ad98cc3f53073d5d726619f6bb03e0679ff9bdc commit 4ad98cc3f53073d5d726619f6bb03e0679ff9bdc Author: Guy Harris Date: Sun Jul 30 18:06:14 2017 -0700 Use proto_tree_add_item_ret_uint(). Change-Id: I006bb0f2cf7e215d24c5eaa6f208cdd6d563d36a Reviewed-on: https://code.wireshark.org/review/22883 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=fe29cb3bb0b291ef354996b2e32fa3bdb724b152 commit fe29cb3bb0b291ef354996b2e32fa3bdb724b152 Author: Guy Harris Date: Sun Jul 30 17:57:24 2017 -0700 Add expert infos for too-long or too-short TLVs. Also, process the packet to the end, even if there are fewer than 3 bytes left; we'll throw an exception if we can't fetch the type and length, which will report the packet as malformed (which it is). Change-Id: Iddd5be4be635553ac77bdb7fe232c2edb0e4404c Reviewed-on: https://code.wireshark.org/review/22882 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=c254f3a13bc21868dba0163584a89d31483ee647 commit c254f3a13bc21868dba0163584a89d31483ee647 Author: Harald Welte Date: Sun Jul 30 15:52:38 2017 +0200 GSMTAP: Treat PDTCH identical to PACCH (hand into packet-gsm-rlcmac.c) The RLC/MAC dissector decodes both signalling (PACCH) and data (PDTCH) RLC/MAC blocks, so let's make sure we dispatch both logical channels into that dissector. Change-Id: Ia26a1ba74468a49da071185cc5ee876ade907207 Reviewed-on: https://code.wireshark.org/review/22861 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=990192872d30120e0e54cb6da7b150b7b883528b commit 990192872d30120e0e54cb6da7b150b7b883528b Author: Harald Welte Date: Sun Jul 30 15:49:21 2017 +0200 GSMTAP: Proper name for PDTCH (not PDCH) PDCH is the physical channel name, while PDTCH is one of the logical channels (goether with PTCCH and PACCH) on the PDTCH. Let's call it by its proper name, rather than keeping the misnomer. Change-Id: I724fcfba595c9c861b64a30d5510468ec007424c Reviewed-on: https://code.wireshark.org/review/22860 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=64b5a38bd9ac83bfc36062eb0c4f7f384930176c commit 64b5a38bd9ac83bfc36062eb0c4f7f384930176c Author: Martin Mathieson Date: Sun Jul 30 23:51:07 2017 +0100 dns: add missing break Change-Id: Iec47e262beb9600fc6596242c4ce0d56162be74f Reviewed-on: https://code.wireshark.org/review/22881 Reviewed-by: Martin Mathieson http://cgit.osmocom.org/wireshark/commit/?id=74210f07fd86b03bed5ca9db57ec46e63ac1185b commit 74210f07fd86b03bed5ca9db57ec46e63ac1185b Author: Guy Harris Date: Sun Jul 30 14:50:23 2017 -0700 Make the protocol column read-only, too. The original code made all columns read-only; making only the info column read-only makes the packet summary look weird, with the contained protocol shown but the info from MSDP shown. Change-Id: Iaa8afcb98a26a94230d5f344261f202ea658d077 Reviewed-on: https://code.wireshark.org/review/22878 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=7e03e6b4eae2cc5871dda97462d1d43ec4b975b5 commit 7e03e6b4eae2cc5871dda97462d1d43ec4b975b5 Author: Guy Harris Date: Sun Jul 30 14:32:06 2017 -0700 Do more checks for extra data at the end of a TLV. Change-Id: I013b21184f8e539d194b6d7ad880e50674958f32 Reviewed-on: https://code.wireshark.org/review/22874 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=33b95883aa4ef7391c05e563243992d35846a633 commit 33b95883aa4ef7391c05e563243992d35846a633 Author: Guy Harris Date: Sun Jul 30 12:01:07 2017 -0700 Clean up MSDP dissection. It's now an RFC; mention the RFC number. There are no message types in MSDP; the message consists solely of a sequence of TLVs. Don't speak of TLV types as message types. When dissecting a TLV, don't go past the end of the TLV. (We should add a bunch of expert infos for length errors.) Note that the Notification TLV was in an I-D but isn't in the RFC. Don't use tvb_new_subset_length_caplen() - tvb_new_subset_length() suffices; let *it* check for the captured length. Clean up dissection of the Notification TLV. Bug: 13933 Change-Id: Ia39b98f061957085c9f15fe6b31cd9c18058df35 Reviewed-on: https://code.wireshark.org/review/22868 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=6f12bf215fb6cd86a0105c87c72076840ca7f5b6 commit 6f12bf215fb6cd86a0105c87c72076840ca7f5b6 Author: Michael Mann Date: Sun Jul 30 11:44:11 2017 -0400 Fix copy/pasteo so Qt Model Source is displayed properly in Visual Studio Change-Id: I81dbc6947f0d878d2c214541cf0d540444ea1592 Reviewed-on: https://code.wireshark.org/review/22867 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a1ce51dcb0b105765a0245a9c48d96ff1583b73e commit a1ce51dcb0b105765a0245a9c48d96ff1583b73e Author: Pascal Quantin Date: Sun Jul 30 12:15:02 2017 +0200 Indicate G.729 playback in the release notes Change-Id: Iebf5419bad38b706c8dc0adb91f7c1cc1d36f3b5 Reviewed-on: https://code.wireshark.org/review/22858 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=5d3d9656451ae86fd1a20b19a3ea21c0931d24c5 commit 5d3d9656451ae86fd1a20b19a3ea21c0931d24c5 Author: Arjen Zonneveld Date: Thu Jul 27 16:03:02 2017 +0200 DNS dissector support for draft-bellis-dnsop-xpf Add support for draft-bellis-dnsop-xpf to the DNS dissector: - Parse the XPF additional RR (currently using a temp value of 65422) Bug: 13928 Change-Id: I2d4fa23a8d3828db483bc41fafe6cbd8885514dc Reviewed-on: https://code.wireshark.org/review/22803 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3e54cabf8193e6a8cd607b1671defb8b6800b53d commit 3e54cabf8193e6a8cd607b1671defb8b6800b53d Author: Pascal Quantin Date: Wed Jul 26 23:23:12 2017 +0200 Add G.729 decoding based on bcg729 library Bug: 13635 Change-Id: Ic22a0719a59da13e51425aeb747e88caca0d6512 Reviewed-on: https://code.wireshark.org/review/22808 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Petri-Dish: Gerald Combs Reviewed-by: Pascal Quantin Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=32b446d5a8f146565b81324d1a18bcb053e07c5f commit 32b446d5a8f146565b81324d1a18bcb053e07c5f Author: Alexis La Goutte Date: Mon Jul 24 11:59:50 2017 +0000 Define Q_NULLPTR as NULL if not already defined it is not supported with Qt 4.x Change-Id: Ie98d5e03d471869e08f5354a509c3317c7c780d7 Reviewed-on: https://code.wireshark.org/review/22831 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=28c874da179a520b1cb5113eb33e2e8b3cb8f48d commit 28c874da179a520b1cb5113eb33e2e8b3cb8f48d Author: Michael Mann Date: Sat Jul 29 20:26:06 2017 -0400 Expand Merge file dialog on Windows Resize so all options can be seen Bug: 13924 Change-Id: I1e347e83432305cc30f54f61efdb6e4c92e98d5a Reviewed-on: https://code.wireshark.org/review/22850 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ff1bdfa0bcdb24326d0f12f41e256a57b2a03d36 commit ff1bdfa0bcdb24326d0f12f41e256a57b2a03d36 Author: Michael Mann Date: Sat Jul 29 18:57:01 2017 -0400 Verify IP checksum even if in ICMP error packet Bug: 10579 Change-Id: I18cac02f81465598451e0cf8f6729a26faf8c176 Reviewed-on: https://code.wireshark.org/review/22849 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=e3b46bc48a6808d52b492a43e96ded6eb31114c3 commit e3b46bc48a6808d52b492a43e96ded6eb31114c3 Author: Michael Mann Date: Sat Jul 29 18:47:15 2017 -0400 Fix IP Security option dissection "offset" no longer needed (since using dissector table for options), and since it should always be 0, just remove it. Change-Id: Icc2802b76bc99a17d60d1deff75e1dc65761e8ed Reviewed-on: https://code.wireshark.org/review/22848 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c50945989daa47802e30851b543ab5c69005a343 commit c50945989daa47802e30851b543ab5c69005a343 Author: Jaap Keuter Date: Sun Jul 30 00:44:14 2017 +0200 DNS: Apply LOC record angle cap The LOC records LATITUDE and LONGITUDE angle values may become too large. Find these and stop conversion into invalid values. Bug: 13914 Change-Id: Ia01ac1ecf5080350454f06536c9be1cf758d6f3c Reviewed-on: https://code.wireshark.org/review/22847 Reviewed-by: Jaap Keuter Petri-Dish: Jaap Keuter Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=76762d69b55065af69df075ca8bd3425b5b3ca84 commit 76762d69b55065af69df075ca8bd3425b5b3ca84 Author: Ike Gilbert Date: Fri Jul 28 17:23:48 2017 +0200 Windows: fix generation with CMake 3.9.0 By using CMake FindPerl.cmake module, CYGWIN_INSTALL_PATH variable gets overwritten, bypassing our modified FindCygwin.cmake. Let's package our own version FindPerl.cmake to avoid this. Bug: 13922 Change-Id: If68e96ba312c2c6fa417721e7aec2ae6e5179a81 Reviewed-on: https://code.wireshark.org/review/22834 Reviewed-by: Pascal Quantin Tested-by: Pascal Quantin Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f461a3a743750421ec377357687f65c2c007a63a commit f461a3a743750421ec377357687f65c2c007a63a Author: Jaap Keuter Date: Sat Jul 29 13:12:19 2017 +0200 DNS: Fix APL record IPv4 address presentation When getting the (partial) IPv4 address make sure to pass the full 32 bits of the address when adding the proto tree item. Bug: 13923 Change-Id: I5b849705e723efd1269a64ee28b8d93724ab769a Reviewed-on: https://code.wireshark.org/review/22838 Petri-Dish: Michael Mann Reviewed-by: Jaap Keuter Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=168065dad763121f9f9630cac9aed184098d53a4 commit 168065dad763121f9f9630cac9aed184098d53a4 Author: Arjen Zonneveld Date: Thu Jul 27 14:49:52 2017 +0200 Add initial RFC2780 IP Version lookup support Add support for https://www.iana.org/assignments/version-numbers/version-numbers.xhtml IP Version lookups. Change-Id: I58a330ab9acba17356344df3ffeb94cc1b2b1443 Reviewed-on: https://code.wireshark.org/review/22821 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b16d487cbc70a441d26a1052b22d1bb0132b1cbc commit b16d487cbc70a441d26a1052b22d1bb0132b1cbc Author: Pascal Quantin Date: Fri Jul 28 17:59:52 2017 +0200 Modbus: do not trigger an exception before saving pkt_info structure Otherwise on second pass pkt_info is null, leading to a segmentation fault Bug: 13925 Change-Id: I61cfbee894506fb6c4205c9a2ad19e6973821f23 Reviewed-on: https://code.wireshark.org/review/22833 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=621ff8e6166f448d807ebabed582810adc42cd57 commit 621ff8e6166f448d807ebabed582810adc42cd57 Author: Jaap Keuter Date: Fri Jul 28 21:01:48 2017 +0200 MKA: Track offset correctly in Dist. SAK dissection When handling a Distributed SAK parameter set with long SAK tracking the offset was done incorrectly. Fix proposed by Rich Dubrawski. Also remove the mask from XPN suspension time, it has none. Bug: 13927 Change-Id: Iba1018632c719a86eaa24a304e1743210b3b3a1c Reviewed-on: https://code.wireshark.org/review/22836 Reviewed-by: Jaap Keuter Petri-Dish: Jaap Keuter Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=66fff5df49520ac6e43f24aba3308f1c3e0ad205 commit 66fff5df49520ac6e43f24aba3308f1c3e0ad205 Author: Stig Bj??rlykke Date: Thu Jul 27 23:10:42 2017 +0200 Qt: Add preference for show file load time in the status bar This will leave more room for messages on smaller screens. Set the default OFF because this is probably only useful for developers. Group Status Bar settings in the Layout frame. Change-Id: Iea9a55b6c088aac10ee7680b1e8a882ed00c73be Reviewed-on: https://code.wireshark.org/review/22824 Petri-Dish: Stig Bj??rlykke Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=04748779e4d5c2aff7b59adba7034bc6cf56d254 commit 04748779e4d5c2aff7b59adba7034bc6cf56d254 Author: Juanjo Martin Date: Fri Jul 28 15:35:53 2017 +0200 RTPS: Added Secure DDS PID parameter + small fix for endianness Change-Id: I8d9c53cee9c7eff0f46c61c63bc3a46859ad7577 Reviewed-on: https://code.wireshark.org/review/22832 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=c348f19786fddc4464cef4b507cce18173ad8dbb commit c348f19786fddc4464cef4b507cce18173ad8dbb Author: Alexis La Goutte Date: Fri Jul 28 09:15:36 2017 +0200 uma: align indent of hf Change-Id: I0234252e112cbb0e7e30a5b9b76ddb74a5754a1c Reviewed-on: https://code.wireshark.org/review/22829 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=5db3a263c3fe21ccea6af4d42b2a34d421ed76a7 commit 5db3a263c3fe21ccea6af4d42b2a34d421ed76a7 Author: Pascal Quantin Date: Fri Jul 28 06:59:25 2017 +0000 Revert "dis: Dead reckoning others Parameters display in wrong location" This reverts commit ad0a3834a12aa038bcbf157304a84e6fd1f6f004. Change-Id: I3a4ef0e3501e83a858f0a98f0c75e758ab245bba Reviewed-on: https://code.wireshark.org/review/22828 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=c23a42e6ae287e7c4e683cae245cebdd0fcf7e96 commit c23a42e6ae287e7c4e683cae245cebdd0fcf7e96 Author: Julien Staub Date: Thu Jul 27 13:14:06 2017 +0200 ZigBee Green Power : Update according to latest spec MS extension becomes application information, remove unneeded define, move packet data copy, warning instead error when no outgoing frame counter Bug: 13919 Change-Id: If2f390a07df362487d18307a334d3b402ca51793 Reviewed-on: https://code.wireshark.org/review/22802 Petri-Dish: Alexis La Goutte Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ad0a3834a12aa038bcbf157304a84e6fd1f6f004 commit ad0a3834a12aa038bcbf157304a84e6fd1f6f004 Author: Alexis La Goutte Date: Thu Jul 27 15:52:55 2017 +0200 dis: Dead reckoning others Parameters display in wrong location Ping-Bug: 13917 Change-Id: I362c14fefcc62b8d19789a13d319fba323836846 Reviewed-on: https://code.wireshark.org/review/22818 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1c8ec368f03e78978cb13a6bbf6a413a264141cc commit 1c8ec368f03e78978cb13a6bbf6a413a264141cc Author: Alexis La Goutte Date: Thu Jul 27 16:12:28 2017 +0200 dis: it is more logic sub_tree2 is the subtree of sub_tree Ping-Bug: 13917 Change-Id: Ic0b6408b9e0c2a21187b5fe01b8ebfd7493ba7c3 Reviewed-on: https://code.wireshark.org/review/22820 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=b8a33b25ac92d0ce0eb21d09dd3324f12eced7ef commit b8a33b25ac92d0ce0eb21d09dd3324f12eced7ef Author: Alexis La Goutte Date: Thu Jul 27 15:40:57 2017 +0200 metamako: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ibd3f06969a6a39533090134aeaa352d13f69231a Reviewed-on: https://code.wireshark.org/review/22817 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=13bd996e8f41fefeb0dfe6a71083e44b8ab5eaaf commit 13bd996e8f41fefeb0dfe6a71083e44b8ab5eaaf Author: Juanjo Martin Date: Wed Jul 26 18:21:00 2017 +0200 RTPS: Fixed Secure DDS minor details Change-Id: I896764009887fedddbd41183f9b0d292119939d1 Reviewed-on: https://code.wireshark.org/review/22804 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=cf0870ad2102dd632a12f6093184f3faae9f6712 commit cf0870ad2102dd632a12f6093184f3faae9f6712 Author: Gerald Combs Date: Thu Jul 27 16:42:25 2017 -0700 Qt: Set AA_EnableHighDpiScaling at startup. Set Qt::AA_EnableHighDpiScaling before creating wsApp so that various UI elements are scaled properly on Windows. Change-Id: Iee4ff2d97b0834756c805fb3812d556ad3480436 Ping-Bug: 13877 Reviewed-on: https://code.wireshark.org/review/22826 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a4788324cb8b8674062659310fe483543f5450e5 commit a4788324cb8b8674062659310fe483543f5450e5 Author: Alexis La Goutte Date: Thu Jul 27 15:59:04 2017 +0200 dis: proto_tree_add_bitmask return a item (and not a tree) (item and tree is the same but avoid mistake) Ping-Bug: 13917 Change-Id: Ica5cc1b62aa8d359aea19a8292bfcd2cc5c4ae9b Reviewed-on: https://code.wireshark.org/review/22819 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=82e2ad37a05d4f6ec125ffadbd00295283b355a7 commit 82e2ad37a05d4f6ec125ffadbd00295283b355a7 Author: Dario Lombardo Date: Mon Jul 24 17:47:18 2017 +0200 cmake: add a group target for all extcaps. Change-Id: Ic97a96261056fd639c968eb29026d67636bad741 Reviewed-on: https://code.wireshark.org/review/22777 Petri-Dish: Dario Lombardo Tested-by: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=4aae9331bc735411fe931a49c6d7bdbcfa7a972f commit 4aae9331bc735411fe931a49c6d7bdbcfa7a972f Author: Stig Bj??rlykke Date: Wed Jul 26 23:18:07 2017 +0200 Qt: Add preference for show selected packet number The information about the selected packet number is available from the Number column and from the Frame entry in the Packet Details so make the entry in the status bar optional. Also remove duplicate "Packet:" entry, add the UTF8_MIDDLE_DOT separator and rename the prefix to "Selected Packet:". Bug: 13902 Change-Id: I0e7ba884bdcbdc87a5738223ef92f52e4ac195e5 Reviewed-on: https://code.wireshark.org/review/22807 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=963707ab3c7ba57e52c28f0dd396d97b37446063 commit 963707ab3c7ba57e52c28f0dd396d97b37446063 Author: Dario Lombardo Date: Wed Jul 26 21:48:44 2017 +0200 extcap: add command line debug function to extcap-base. This function is helpful to debug the interaction between the calling UI and the extcap itself. All extcaps have been changed accordingly. Change-Id: I358caf4c50797501672bf77fdd91f7276897078c Reviewed-on: https://code.wireshark.org/review/22806 Reviewed-by: Roland Knall Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=f86f54eb9070effb6216861749523d3a32932d47 commit f86f54eb9070effb6216861749523d3a32932d47 Author: Gerald Combs Date: Wed Jul 26 10:10:09 2017 -0700 Qt: SimpleDialog fixes and updates. Add WiresharkApplication::mainWindow and use it to move the C simple_dialog routines to simple_dialog.cpp. In SimpleDialog, make sure our checkbox is initialized. Don't store our parent widget (which might go away) in a static variable, just use wsApp->mainWindow(). Make sure we use check boxes only in Qt 5.2 or later. Bug: 13275 Change-Id: I72a9715c59f2efd50f722197f416179e87bb6a8b Reviewed-on: https://code.wireshark.org/review/22805 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=ea233921b46b3eeda51865bb5306919b16202872 commit ea233921b46b3eeda51865bb5306919b16202872 Author: Marius Paliga Date: Thu Jul 27 10:14:50 2017 +0200 PMIPv6: Fix of valid length of GRE Key Option Change-Id: Ie212874a9eb9b7f9ad0dc502611d135210c9f259 Reviewed-on: https://code.wireshark.org/review/22810 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=76a3a6797ceb93535a06ca4d17b3a454f5728cca commit 76a3a6797ceb93535a06ca4d17b3a454f5728cca Author: Christoph Schlosser Date: Thu Jul 27 13:06:29 2017 +0200 EPL: Fix Multiparamwrite response text The text for the MultiParamWrite response was the same as for the MultiParamRead. Change-Id: I285f4f33877ac4bb1e48f36704ecb22ad7be1de4 Reviewed-on: https://code.wireshark.org/review/22811 Reviewed-by: Christoph Schlosser Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=c3a91e51d06f4ad81969fcbde4bcacead321f357 commit c3a91e51d06f4ad81969fcbde4bcacead321f357 Author: Alexis La Goutte Date: Wed Jul 26 06:50:17 2017 +0000 dis: Appearance Record displayed in wrong location Bug: 13917 Change-Id: I26211dfcb15fe5e4ffc69ae297c64e380cd7b128 Reviewed-on: https://code.wireshark.org/review/22799 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=fbc4d83ae7b844aa0ea6ec60af4f0a238110858a commit fbc4d83ae7b844aa0ea6ec60af4f0a238110858a Author: KasperDeng Date: Wed Jul 26 16:50:25 2017 +0800 update diameter dictionary for t6a/t6b/s6t Change-Id: I795efa89c59d2ba84398fc3e42ecc917405ca236 Reviewed-on: https://code.wireshark.org/review/22800 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=02e80019f2dc8f01e51d8bdc62a1cabff69fd51e commit 02e80019f2dc8f01e51d8bdc62a1cabff69fd51e Author: Roland Knall Date: Tue Jul 25 16:47:16 2017 +0200 Qt: Create models directory Following the move for widgets and utils directory, moving models and delegates to the utils directory. Guidelines for this directory are: - Implementation of a model - Implementation of a delegate - Utility class for data storage used by a model Note: additionally all includes affected by this move have been changed to absolute path includes, instead of relative ones. Change-Id: I3bb868af7d3570437682b722a0cd46c906628570 Reviewed-on: https://code.wireshark.org/review/22790 Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=ea998190cfe5a051224490172cfaedc69b777ff6 commit ea998190cfe5a051224490172cfaedc69b777ff6 Author: Roland Knall Date: Wed Jul 26 12:28:50 2017 +0200 Qt: Fix Makefile.am for utils dir change Fix Makefile.am Change-Id: I31cdbc2af0659b247d22af7438300c44acfff63e Reviewed-on: https://code.wireshark.org/review/22801 Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=ddfc1d37ccb5e2a6aeef5cce47479ddc36684f33 commit ddfc1d37ccb5e2a6aeef5cce47479ddc36684f33 Author: Roland Knall Date: Tue Jul 25 16:15:18 2017 +0200 Qt: Move utils to separate utils directory Following the move for widgets directory, moving utils to the utils directory. Guidelines for this directory are: - Generic use but not a widget - Utility functionality used by many classes Note: additionally all includes affected by this move have been changed to absolute path includes, instead of relative ones. Change-Id: I019ae4b6e6f6d06a5745a63ed195edbd36fb936b Reviewed-on: https://code.wireshark.org/review/22602 Petri-Dish: Roland Knall Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=95930c2d1fa356d5301b7c5e53b20035876bb436 commit 95930c2d1fa356d5301b7c5e53b20035876bb436 Author: Michael Mann Date: Sun Jul 23 15:19:24 2017 -0400 Add current packet to the status bar. For users with lots of columns, they may loose track of the current frame/packet. Bug: 13902 Change-Id: I4d937dc437e254a09d938733aef5f5678ede1095 Reviewed-on: https://code.wireshark.org/review/22772 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=07d8fad852babaf9d1b02e7f13eb188f34ff58f5 commit 07d8fad852babaf9d1b02e7f13eb188f34ff58f5 Author: Michael Mann Date: Tue Jul 25 19:07:04 2017 -0400 WirelessTimeline: move signals out of setPacketList(). Start to remove the dependency on PacketList by moving the signals out of setPacketList and into MainWindow. Change-Id: Ibbe5a5619e06809eb71aee5145c4b0f7d54382a2 Reviewed-on: https://code.wireshark.org/review/22798 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=b376aa05eaa47bf679691a5031b00255712807f4 commit b376aa05eaa47bf679691a5031b00255712807f4 Author: Joakim Karlsson Date: Tue Jul 25 21:49:04 2017 +0200 GPRSCDR: decoding of RATType Change-Id: I2524bc008ad35e39890c6b846928f1183f7f9627 Reviewed-on: https://code.wireshark.org/review/22791 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f50d9fe1d6ebf7ac8ecf615e0e79476bc824f4c0 commit f50d9fe1d6ebf7ac8ecf615e0e79476bc824f4c0 Author: Darien Spencer Date: Tue Jul 25 23:28:56 2017 +0300 Update heuristic dissectors documentation Remove grep output of explict count of heuristic protocols because it changes too often to bother updating. Change-Id: I69b0dfbae32f9eb9ffef6c3200238819ddf522e6 Reviewed-on: https://code.wireshark.org/review/22793 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=efbefe2f4c46bf50c6df7e06a06476e3f91e1ba7 commit efbefe2f4c46bf50c6df7e06a06476e3f91e1ba7 Author: Guy Harris Date: Tue Jul 25 15:42:46 2017 -0700 Make hf_mysql_request cover the *entire* request. The request doesn't correspond to the request command coe, it corresponds to the entire request; create it as an item covering the rest of the packet, and finish it up by setting the length appropriately. Change-Id: Ib0c044c0c878f1cb2fa0d11deb04b4d31a8a825f Reviewed-on: https://code.wireshark.org/review/22796 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=9c80c4d5a246b8f95dfbc28fbf14ca899531630f commit 9c80c4d5a246b8f95dfbc28fbf14ca899531630f Author: Gerald Combs Date: Tue Jul 25 13:31:49 2017 -0700 CMake: Don't pass /WX to rc.exe Rc.exe doesn't have a /WX flag. Passing it /WX apparently results in setting the /W flag, which warns about invalid code pages, and the /X flag, which ignores %INCLUDE%. The latter is necessary in our case for locating winver.h. Change-Id: I6d757a547fedfa49d078a7bb5f15518c69760f72 Reviewed-on: https://code.wireshark.org/review/22794 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=a62c6d56b13390d216a8b6096a9c9e809b3c4e93 commit a62c6d56b13390d216a8b6096a9c9e809b3c4e93 Author: Dario Lombardo Date: Tue Jul 25 15:18:12 2017 +0200 cmake: remove duplicate libraries from sshdump and ciscodump. Change-Id: I35ce9e10921a5cbf97f2cd00036b1b6b3c87c03f Reviewed-on: https://code.wireshark.org/review/22788 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=615685e852d7aa9b48b117b0335a337d542f847f commit 615685e852d7aa9b48b117b0335a337d542f847f Author: Uli Heilmeier Date: Tue Jul 25 08:31:05 2017 +0200 VNC: Get Bytes before adding raw values to tree Make sure to have bytes before adding raw values to tree Bug: 13910 Change-Id: I9c6fe679df12e0358df80caf01268acb75ee424c Reviewed-on: https://code.wireshark.org/review/22782 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=7fadc161724cb5d3e1d3f8aa449c8078e5ffa9e1 commit 7fadc161724cb5d3e1d3f8aa449c8078e5ffa9e1 Author: Christoph Schlosser Date: Tue Jul 25 08:11:45 2017 +0200 EPL: Add padding to size calculation for last frame The padding was not part of the size calculation of the last subpayload in a multiple read/write by index. Change-Id: Ibbd3ded345352ea1ceaea7b871fc2d1a0e1a6832 Reviewed-on: https://code.wireshark.org/review/22781 Reviewed-by: Christoph Schlosser Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=c6ed05ec73e1b1e22ea890fc95ec5e067726cbe8 commit c6ed05ec73e1b1e22ea890fc95ec5e067726cbe8 Author: Gerald Combs Date: Mon Jul 24 10:55:56 2017 -0700 Qt: Make SimpleDialog a plain, non-QObject class. Don't assume that the application is initialized when we create a SimpleDialog. Bug: 13275 Change-Id: Ieeb52430500570db88463069833855c3789f686b Reviewed-on: https://code.wireshark.org/review/22778 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=17f72a0b2273e8c45296711d2454997e74e2734c commit 17f72a0b2273e8c45296711d2454997e74e2734c Author: Dario Lombardo Date: Sun Jul 23 23:11:42 2017 +0200 randpkt: choose a random type if the empty string has been selected as type. Fixes a bug when calling randpktdump without the dialog. Reproducer: Open wireshark Double click on randpktdump Stop the capture No packets have been generated. Change-Id: I43d1d3c02afbb44f88620a696a7d25aa4e45889a Reviewed-on: https://code.wireshark.org/review/22775 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=1e584b8a13cd6514f2ec5d117d055f3270c944d5 commit 1e584b8a13cd6514f2ec5d117d055f3270c944d5 Author: Huang Qiangxiong Date: Mon Jul 24 15:47:53 2017 +0000 HTTP2: Fix an access invalid memory address error. The tree may be NULL, so tree->parent may cause access invalid memory address error which will report 'Dissector bug ... STATUS_ACCESS_VIOLATION' in info column. Change-Id: I37d4aca2287e77a046e553221a6a824de60aae9c Reviewed-on: https://code.wireshark.org/review/22776 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=be502d221a416ad271e4d13231cd796f8da32ca4 commit be502d221a416ad271e4d13231cd796f8da32ca4 Author: Guy Harris Date: Mon Jul 24 11:16:48 2017 -0700 There's no wka.tmpl file any more, it's just wka. Change-Id: Ia44a02c92995a47357a3fded7131199117ad6425 Reviewed-on: https://code.wireshark.org/review/22779 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=690cb8ff65f3336cb8e72a55944f974d0fd40f05 commit 690cb8ff65f3336cb8e72a55944f974d0fd40f05 Author: Christoph Schlosser Date: Mon Jul 24 13:45:10 2017 +0200 EPL: Add Modular device flag Add detection for the modular device flag in POWERLINK. Change-Id: I3e21eec383f1bdf2fa491d415631cda146a0fdef Reviewed-on: https://code.wireshark.org/review/22774 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall http://cgit.osmocom.org/wireshark/commit/?id=7a4c9d267bd245f19796a5fea3b21b18ed57f870 commit 7a4c9d267bd245f19796a5fea3b21b18ed57f870 Author: Dario Lombardo Date: Fri Jul 21 00:07:31 2017 +0200 print: use assert before dereference (CID 1412973). Change-Id: I82602ceb735a055602a18c2c52e0669c4efd7773 Reviewed-on: https://code.wireshark.org/review/22748 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=877caf478bae1e7f64084a8f2a7d6fe61f63b5e9 commit 877caf478bae1e7f64084a8f2a7d6fe61f63b5e9 Author: Joakim Karlsson Date: Sun Jul 23 16:56:39 2017 +0200 GPRSCDR: decoding of ULI in GGSN/SGW/PGW CDRs Change-Id: Id87920c5099553e51cfaa9ab0cb0c41cec6a127b Reviewed-on: https://code.wireshark.org/review/22767 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8ee06279fff744a1d7f235df9b570e0c25a91b1f commit 8ee06279fff744a1d7f235df9b570e0c25a91b1f Author: Pascal Quantin Date: Sun Jul 23 19:42:59 2017 +0200 LTE RRC: upgrade dissector to v14.3.0 Change-Id: Ia64095a8a9bdd3b31589842809d8a5313b829f8e Reviewed-on: https://code.wireshark.org/review/22770 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=f2ffcdf3aa5cf3b02d674411270df072f3a1eded commit f2ffcdf3aa5cf3b02d674411270df072f3a1eded Author: Stig Bj??rlykke Date: Sat Jul 22 20:30:07 2017 +0200 Qt: Compile InterfaceToolbar with Qt4 The InterfaceToolbar does not currently work with Qt4 because usage of some Qt 5.2 features, but this should at least make it compile. Change-Id: Id610e04d6c266556bfb84da5399e57a6c1fe9938 Ping-Bug: 13909 Reviewed-on: https://code.wireshark.org/review/22761 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Petri-Dish: Michael Mann Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=68f295d6052d49200f9ad3e06909b1157e7a82be commit 68f295d6052d49200f9ad3e06909b1157e7a82be Author: Dario Lombardo Date: Fri Jul 21 00:16:35 2017 +0200 tshark: assert edt before calling print_packet (CID 1405107). Change-Id: Iacde5514dc355cbb06fe45f5e342ddd45700999d Reviewed-on: https://code.wireshark.org/review/22749 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=14d94e174a230e66d7d75c774435d77f3d8aa22e commit 14d94e174a230e66d7d75c774435d77f3d8aa22e Author: Jo??o Valverde Date: Thu Jul 20 02:32:40 2017 +0100 Put the well-known addresses into a separate file from OUIs Having two distinct logical concepts (OUI and Well Known Address) concatenated to a single "manuf" file is needlessly obfuscating the WKA feature. Have a distinct "wka" file instead and just skip the cat. Change-Id: I46f53b0015a37331d65f8cfac7cbbd499dd0c5b8 Reviewed-on: https://code.wireshark.org/review/22742 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=88fbc26175d8f32b01fac69828b7549a5ec53166 commit 88fbc26175d8f32b01fac69828b7549a5ec53166 Author: Lars Christensen Date: Tue Jul 18 10:17:53 2017 +0200 Inhibit unhandled Ctrl key presses being redirected to the display filter Pressing the display filter shortcut Ctrl-/ inserts a '/' into the LineEdit. On Windows QKeyEvent::text() contains a printable character when Ctrl is held down and are being redirected in MainWindow::eventFilter(). This patch filters events that has the CtrlModifier. Change-Id: Iefed962b7a2cc944a39b09de9d84b4522a39ff13 Reviewed-on: https://code.wireshark.org/review/22697 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=daae7dbb1ff08b5f88953ddb77ef71454f3b1a3f commit daae7dbb1ff08b5f88953ddb77ef71454f3b1a3f Author: Pascal Quantin Date: Sun Jul 23 14:09:13 2017 +0200 RRC: upgrade dissector to v14.3.0 Change-Id: I3c15b26430e8159d10d5d7a52e3b5644fb76c7ae Reviewed-on: https://code.wireshark.org/review/22765 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=40d158eee35c3d10858593587c6ddc999b9b9329 commit 40d158eee35c3d10858593587c6ddc999b9b9329 Author: Michael Mann Date: Fri Jul 21 19:12:52 2017 -0400 Have UatFrame send out proper notifications. UatFrame was originally written for filter expressions, so it still had some "filter expression specific" functionality in it. Move the "filter expression notifications" to the preferences dialog and add support for proper notification if UAT affects fields or dissection (like expert info UAT). Change-Id: I84cd0c7923450692916bbc6c2cdce93a9830d722 Reviewed-on: https://code.wireshark.org/review/22758 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=4107f6bca7b2bc58e6570501123f3d500ec3905b commit 4107f6bca7b2bc58e6570501123f3d500ec3905b Author: Uli Heilmeier Date: Sat Jul 22 13:19:24 2017 +0200 HTTP2: Fix missing ifdef HAVE_NGHTTP2 media_type_dissector_table is only defined with HAVE_NGHTTP2 Change-Id: I489e04f3d3066f2edf5c656b158c38c3dae84fb6 Reviewed-on: https://code.wireshark.org/review/22760 Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=04ba4bc070466c302b994968d527da5dbe390287 commit 04ba4bc070466c302b994968d527da5dbe390287 Author: Simon Graham Date: Thu Jul 13 17:00:59 2017 -0400 Fix crash in UDT dissector when long NAK packet is dissected Change is to limit the number of entries from the NAK message included in the summary line (and add ellipsis if there are more than will fit). In addition, add checks to make sure we dont read beyond the end of the captured packet when parsing NAKs. Change-Id: I60db4b62d86c05329eb7c79ae1927eeb1b7e11ba Reviewed-on: https://code.wireshark.org/review/22733 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6dfdb0160c0ad6b7b71edb3c5f41c1e8e5868667 commit 6dfdb0160c0ad6b7b71edb3c5f41c1e8e5868667 Author: Huang Qiangxiong Date: Wed Jul 19 14:10:50 2017 +0000 HTTP2: Dissect reassembled http2.data.data according to content-type (as text/html, png, application/grpc and etc) and some enhancement for displays. Change Details: 1. Just like HTTP1.1, dissect reassembled http2.data.data according to content-type header value (searching media_type dissector table). With this feature, we can add new dissector that based HTTP2 (for example application/grpc), or old text/html, image/png, image/jpeg dissectors. 2. Append stream id after frame type on info column, like: HEADERS[1], DATA[1], HEADERS[3], DATA[3] 3. Append request :method and :path inforamtion to info column, like: HEADERS[1]: GET /demo/1.jpg. (and also append :method and :path info to Stream Node in tree) 4. Append response status and reason-phrase to info column, like: HEADERS[1]: 200 OK One HTTP2 package file's info column will look like: 10.10.10.123 23.13.190.101 Magic 10.10.10.123 23.13.190.101 SETTINGS[0] 10.10.10.123 23.13.190.101 WINDOW_UPDATE[0] 10.10.10.123 23.13.190.101 HEADERS[1]: GET /demo 23.13.190.101 10.10.10.123 SETTINGS[0] 23.13.190.101 10.10.10.123 SETTINGS[0] 10.10.10.123 23.13.190.101 SETTINGS[0] 23.13.190.101 10.10.10.123 HEADERS[1]: 200 OK 23.13.190.101 10.10.10.123 DATA[1], DATA[1], DATA[1], DATA[1] (text/html) 10.10.10.123 23.13.190.101 HEADERS[3]: GET /demo/tile-0.png 10.10.10.123 23.13.190.101 HEADERS[5]: GET /demo/tile-1.png 10.10.10.123 23.13.190.101 HEADERS[7]: GET /demo/tile-2.png 10.10.10.123 23.13.190.101 HEADERS[9]: GET /demo/tile-3.png 10.10.10.123 23.13.190.101 HEADERS[11]: GET /demo/tile-4.png 23.13.190.101 10.10.10.123 SETTINGS[0] 23.13.190.101 10.10.10.123 SETTINGS[0] 10.10.10.123 23.13.190.101 SETTINGS[0] 23.13.190.101 10.10.10.123 HEADERS[5]: 200 OK 23.13.190.101 10.10.10.123 DATA[5] 23.13.190.101 10.10.10.123 HEADERS[7]: 200 OK 23.13.190.101 10.10.10.123 DATA[5], DATA[5] (PNG), DATA[5] 23.13.190.101 10.10.10.123 HEADERS[11]: 200 OK 23.13.190.101 10.10.10.123 DATA[7], DATA[7] (PNG), DATA[11], DATA[11] (PNG) 23.13.190.101 10.10.10.123 HEADERS[3]: 200 OK 23.13.190.101 10.10.10.123 DATA[3], DATA[3] (PNG) 23.13.190.101 10.10.10.123 HEADERS[7]: 200 OK 23.13.190.101 10.10.10.123 DATA[9], DATA[9] (PNG) Change-Id: I4452dadeeefc49806e3036a44d44b5f5186096b9 Reviewed-on: https://code.wireshark.org/review/22715 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=921723d07585b41c96b295e30a74df43626224af commit 921723d07585b41c96b295e30a74df43626224af Author: Robert Sauter Date: Wed Jul 12 11:31:26 2017 +0200 IEEE 802.15.4: dissector tables for Information Elements Rationale: The IEs are a generic mechanism that allows higher level protocols to transport additional data in the header and some IDs have already been assigned to external organisations. Using dissector tables enable looser coupling. Refactor existing internal IE dissectors to be called via the table as well based on a suggestion by Michael Mann. More consistent display and code for Header IEs and Payload IEs. Change-Id: Ib9c225245fc8dd989200d6ff6aeae8ca5c0f792c Reviewed-on: https://code.wireshark.org/review/22600 Reviewed-by: Alexis La Goutte Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=8dd29939ef79acd5fdfdf90c08d53c83706a24d3 commit 8dd29939ef79acd5fdfdf90c08d53c83706a24d3 Author: Guy Harris Date: Fri Jul 21 20:14:47 2017 -0700 c-ares isn't required. Don't fail if it's not present. Change-Id: I7183ce6e1f2af822ebeed219be0f2ca7dd0bab0f Reviewed-on: https://code.wireshark.org/review/22759 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=28dce11948523f80d6eb76ef6a1d95df78f9c870 commit 28dce11948523f80d6eb76ef6a1d95df78f9c870 Author: Gerald Combs Date: Fri Jul 21 11:03:04 2017 -0700 Qt RTP: Add the default device and adjust sample rates. In the RTP player dialog, list the default audio device first, ensure it's selected by default and ensure that the list items are unique. According to http://code.qt.io/cgit/qt/qtmultimedia.git/tree/src/plugins/windowsaudio/qwindowsaudiodeviceinfo.cpp?h=5.9 the default device on Windows uses the special WAVE_MAPPER id, which appears to support various sample rates even when the underlying hardware doesn't. Ensuring the names are unique fixes an issue I'm seeing on a test machine here. When decoding, check to see if our sample rate is supported by our output device and adjust accordingly. Bug: 13906 Change-Id: Iddc0beb2459bfac42276ff29d227c2619b0a8d90 Reviewed-on: https://code.wireshark.org/review/22756 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=d22b54a00587d6a4a5227b93f0461ab4549ea94c commit d22b54a00587d6a4a5227b93f0461ab4549ea94c Author: Alexis La Goutte Date: Fri Jul 21 13:25:17 2017 +0000 cql: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I74f4d33ad1805bd233190e7cb9ee1610ae628af5 Reviewed-on: https://code.wireshark.org/review/22755 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=b8b9bbcbd3dc8e7bebd2f7c74996a80f7620d77e commit b8b9bbcbd3dc8e7bebd2f7c74996a80f7620d77e Author: Guy Harris Date: Fri Jul 21 03:43:11 2017 -0700 *Always* write out the trailing pcapng block total length in host byte order. In the fast-path "no options" case for writing an Enhanced Packet Block, just copy the block total length to the buffer, don't put it into the buffer in little-endian byte order. If we're running on a big-endian machine, and thus *should* be writing out multi-byte integral block fields in big-endian byte order, that'll write out a corrupt pcapng file. Bug: 13802 Change-Id: I33958e3fc1d205ca6df3ef4057d92b461831c50e Reviewed-on: https://code.wireshark.org/review/22753 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3e9b25623877afb9854b2f3cae84e47ffb52c9a8 commit 3e9b25623877afb9854b2f3cae84e47ffb52c9a8 Author: Dario Lombardo Date: Fri Jul 21 00:22:47 2017 +0200 androiddump: check return value of localtime() before dereference (CID 1400829). Change-Id: I03c851e56f5bd967a35c668bcbc4e98170251b2c Reviewed-on: https://code.wireshark.org/review/22750 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=9ea364c389fc92bcd8efc800c9b8e852958c169a commit 9ea364c389fc92bcd8efc800c9b8e852958c169a Author: Guy Harris Date: Fri Jul 21 03:11:14 2017 -0700 Require at least c-ares 1.5.0 when configuring. That way, if you have an older version, we fail at configure time, with what should be a message indicating that your c-ares is too old, rather than at compile time, with what might provoke users to ask "what am I doing wrong?" or "what do I need to fix?" or "why is my compile failing?" or.... Change-Id: I911574c4d90174b6bd074c5ef537557d47b199dc Reviewed-on: https://code.wireshark.org/review/22752 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=725b7ef17598076911da9c68efbf8c0efd593191 commit 725b7ef17598076911da9c68efbf8c0efd593191 Author: Pascal Quantin Date: Fri Jul 21 12:05:45 2017 +0200 androiddump: add a cast to please MSVC x64 Change-Id: I43cf913d48afabd826f7d6f861876e1cb62e7e7a Reviewed-on: https://code.wireshark.org/review/22751 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=7799b1ceabb9baf4c88f0013b9b2bcd3e60b1750 commit 7799b1ceabb9baf4c88f0013b9b2bcd3e60b1750 Author: Russell Lowes Date: Wed Jul 19 13:18:06 2017 +1000 Add support for Metamako trailer extensions. Update dissector heuristic to match. Bug: 13898 Change-Id: I84445b3a6e6c903a51faae2757eb6002db835a31 Reviewed-on: https://code.wireshark.org/review/22711 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d238160a22ed3e7c9d2235002e3051afe162e662 commit d238160a22ed3e7c9d2235002e3051afe162e662 Author: Jo??o Valverde Date: Thu Jul 20 19:03:45 2017 +0100 Require c-ares >= 1.5 Version 1.5 was released on 21-nov-2007. RHEL, Suse, etc supported versions are all above c-ares v1.5. We don't bother testing for it at build time for now, because it's non-trivial (times two build systems). Change-Id: I9253256d8d905da0c75d80b2b0fa4527df2b1420 Reviewed-on: https://code.wireshark.org/review/22741 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=9e419f62bde6c86bc7dd35c71e0a29321f3cb3ea commit 9e419f62bde6c86bc7dd35c71e0a29321f3cb3ea Author: Simon Graham Date: Sat Dec 3 16:58:34 2016 -0500 Support heuristic sub-dissectors for UDT Change-Id: Ief9d02dd3cf70dc37ad25061ce38bb1a570b2946 Reviewed-on: https://code.wireshark.org/review/22727 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=ac0af07083727a958e468e6d6fca044c73de0a80 commit ac0af07083727a958e468e6d6fca044c73de0a80 Author: Michael Mann Date: Thu Jul 20 11:36:59 2017 -0400 ENIP: Add support for CIP Security Information in ListIdentity Add tfs_open_closed to general tfs collection (tfs.[ch]) Change-Id: I79b22b591128c33084489880842e19e9a0d80560 Reviewed-on: https://code.wireshark.org/review/22730 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=421085cc4c1834e6b27f3cb2432786aff657ab77 commit 421085cc4c1834e6b27f3cb2432786aff657ab77 Author: Alexis La Goutte Date: Fri Jul 7 13:42:25 2017 +0200 .gitignore: move ui/qt/gitignore to root gitignore Change-Id: I303c6998b7b825ebb89aa1a81296b1ad69786ec1 Reviewed-on: https://code.wireshark.org/review/22538 Reviewed-by: Alexis La Goutte Reviewed-by: Dario Lombardo http://cgit.osmocom.org/wireshark/commit/?id=fe8508b8b359689c927bb062ee37f79c52930b19 commit fe8508b8b359689c927bb062ee37f79c52930b19 Author: Guy Harris Date: Thu Jul 20 14:53:52 2017 -0700 More precise error message. "Missing newline after '}'" suggests either that the "}" is the line character in the file or that it's followed by a character other than a newline. What it actually appears to mean is "you didn't put a blank line between one author entry and the next author entry". Change-Id: Ic0e4dd02f04680ab84fbfcf1183c911d049ee2d2 Reviewed-on: https://code.wireshark.org/review/22746 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=27c6b12626d6e7b8e4d7a11784c2c5e2bfb87fde commit 27c6b12626d6e7b8e4d7a11784c2c5e2bfb87fde Author: Dario Lombardo Date: Thu Jul 20 23:46:54 2017 +0200 AUTHORS: add newline after bracket. Get rid of the error: Missing newline after '}', found: Ben Stewart { Change-Id: Ic8c83c23e5215032a9e06d4ad089be85f7b98b0d Reviewed-on: https://code.wireshark.org/review/22744 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=420aab387f706610d17cb51b3574f03fd370719a commit 420aab387f706610d17cb51b3574f03fd370719a Author: Dario Lombardo Date: Thu Jul 20 23:37:16 2017 +0200 androiddump: use actual buffer length instead of pointer sizeof. Change-Id: I3481c98377a31fbef2ef8ad931e2a8d66f507e58 CID: 1414110 CID: 1414058 Reviewed-on: https://code.wireshark.org/review/22743 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=55724db3db49e7ed5180305600733d6a9253c65d commit 55724db3db49e7ed5180305600733d6a9253c65d Author: Jo??o Valverde Date: Thu Jul 20 03:39:09 2017 +0100 Remove dead code for address reverse-mapping Removed get_ipxnet_addr(), get_ether_addr(). If this feature is desired at a minimum it should use an efficent data structure (and no disk-based lookups mid-dissection). Change-Id: Ie72449c631f21f4a3d82ec435bb5e1d7892f122c Reviewed-on: https://code.wireshark.org/review/22729 Petri-Dish: Jo??o Valverde Tested-by: Petri Dish Buildbot Reviewed-by: Jo??o Valverde http://cgit.osmocom.org/wireshark/commit/?id=543c101d4b98c947b7bfc66cac6d49d177ed4fc0 commit 543c101d4b98c947b7bfc66cac6d49d177ed4fc0 Author: Alexis La Goutte Date: Wed Jul 19 15:00:22 2017 +0200 DICOM: Add User Identify See ftp://dicom.nema.org/MEDICAL/dicom/2016a/output/chtml/part07/sect_D.3.3.7.html Bug: 13875 Change-Id: If5b55ef45b1dd7115a2eaf4a3d1a02bc2b1a5b93 Reviewed-on: https://code.wireshark.org/review/22714 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=3669a8cc8f64a1874a3d370abccfc6e815b46514 commit 3669a8cc8f64a1874a3d370abccfc6e815b46514 Author: Guy Harris Date: Thu Jul 20 11:03:18 2017 -0700 Give some references. Change-Id: Iaa4912fa50ffde8d5408527f3b4b28a0d2a56cde Reviewed-on: https://code.wireshark.org/review/22737 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=ab0b3ecf867223d8aeeb9c405dfc7204114b0dbe commit ab0b3ecf867223d8aeeb9c405dfc7204114b0dbe Author: Gerald Combs Date: Thu Jul 20 09:37:15 2017 -0700 CMake: Escape shell command quotes. Escape shell command quotes so that what appears to be "unquoted_legacy" behavior doesn't kick in. Ping-Bug: 12305 Change-Id: I4763df2fbc58b80d6e4e3ec15f78c16fa1cf3853 Reviewed-on: https://code.wireshark.org/review/22732 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=9ab8133bf8959c80167f85ffb4c12c37f3b4c2ed commit 9ab8133bf8959c80167f85ffb4c12c37f3b4c2ed Author: Gerald Combs Date: Thu Jul 20 09:36:27 2017 -0700 Update the release notes. Change-Id: Ia6a5994b8728251a11a111f29f60455e8076dfb9 Reviewed-on: https://code.wireshark.org/review/22731 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=558fe23226b69665dd66ee15bed2f7492653aa09 commit 558fe23226b69665dd66ee15bed2f7492653aa09 Author: AndersBroman Date: Thu Jul 20 16:02:54 2017 +0200 [IP] Simplify paring of flags field by using proto_tree_add_bitmask_with_flags(). Change-Id: If8e9f9956543f253f4f59d8204c9536f444dbcd5 Reviewed-on: https://code.wireshark.org/review/22728 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=990ac64516223f1ffa9728b01b47d08b7954de2c commit 990ac64516223f1ffa9728b01b47d08b7954de2c Author: Alexis La Goutte Date: Wed Jul 19 13:47:03 2017 +0200 DICOM: Add display of Unknown item type Ping-Bug: 13875 Change-Id: Ic1de11aa7307f13cf6ba53f61477091fd37bf2a2 Reviewed-on: https://code.wireshark.org/review/22713 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=3e37292c382d8f48554af5a0aa10e3ce2d16363f commit 3e37292c382d8f48554af5a0aa10e3ce2d16363f Author: Jo??o Valverde Date: Sun Jul 16 20:10:50 2017 +0100 Remove line numbers (locations) from .ts files To make translation updates less noisy. Change-Id: I3efee819ea10bb326862e0f818bfd3cd7eff48e3 Reviewed-on: https://code.wireshark.org/review/22654 Reviewed-by: Jo??o Valverde Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=f26778c9c6265fae59a35413d9a2d735190cff22 commit f26778c9c6265fae59a35413d9a2d735190cff22 Author: Pascal Quantin Date: Thu Jul 20 09:24:42 2017 +0200 Add udpdump documentation to distribution Bug: 13903 Change-Id: I7e7aadfbec3e66ebac892e20b5632afa9f7e5923 Reviewed-on: https://code.wireshark.org/review/22725 Reviewed-by: Pascal Quantin Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte http://cgit.osmocom.org/wireshark/commit/?id=5473d2582cbc8943ead50550ef72936e0b99a945 commit 5473d2582cbc8943ead50550ef72936e0b99a945 Author: Simon Graham Date: Tue Jul 4 10:38:54 2017 -0400 Display relative sequence numbers when dissecting UDT. Note that this is only done if sufficient bytes are captured from the handshake packet to include the initial sequence number field. Change-Id: Ie92ec2ccaa5021c07c8666d6fdc46613d24d0da1 Reviewed-on: https://code.wireshark.org/review/22573 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=79e801806aedbbb74f642fafd9f54c02e60677f5 commit 79e801806aedbbb74f642fafd9f54c02e60677f5 Author: Owen Kirby Date: Fri Jun 23 15:15:46 2017 -0700 ZigBee: Add touchlink commissioning dissectors. Change-Id: I745fa77626dd242d9a6f1bd79c6ae52d507f844a Reviewed-on: https://code.wireshark.org/review/22380 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=07f27d8238021b6e485699369383a58f95984a4e commit 07f27d8238021b6e485699369383a58f95984a4e Author: Gerald Combs Date: Wed Jul 19 18:00:37 2017 -0700 Update WinSparkle. Change-Id: Ia0b717165b258fdc891b5d876b4acd31345ec00e Reviewed-on: https://code.wireshark.org/review/22722 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=3fa8776a68404d4bea8c2fa82957488c448b4e20 commit 3fa8776a68404d4bea8c2fa82957488c448b4e20 Author: Alexis La Goutte Date: Wed Jul 19 19:27:19 2017 +0200 dcerpc-pn-io (profinet): fix typo for pn_io.iops display filter Change-Id: I8422005703c9e0a04d067dfe5ba501fe7417ff8a Reviewed-on: https://code.wireshark.org/review/22718 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6fdf043e6ee8ce9766f0b41a1c65ef0996ce7db3 commit 6fdf043e6ee8ce9766f0b41a1c65ef0996ce7db3 Author: Pascal Quantin Date: Wed Jul 19 14:41:40 2017 +0200 X2AP: update version info in header Change-Id: I5e5faf6cc389bc334c31ef0277858c9e99245b67 Reviewed-on: https://code.wireshark.org/review/22712 Reviewed-by: Pascal Quantin http://cgit.osmocom.org/wireshark/commit/?id=ee7d2a6010a2c6745630a53e58a6e4601114b530 commit ee7d2a6010a2c6745630a53e58a6e4601114b530 Author: Chris Brandson Date: Fri Jul 14 18:18:50 2017 -0700 ZigBee make ZCL Frame Control direction more descriptive Using just client or server as a direction is a source of confusion so made a more discriptive item Change-Id: I8675aba555b04f6ae8848cf9e1c720eb4b44b553 Reviewed-on: https://code.wireshark.org/review/22628 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=62d5476740a8afb90eb67177fd1aece74cd3f8ec commit 62d5476740a8afb90eb67177fd1aece74cd3f8ec Author: Uli Heilmeier Date: Tue Jul 18 17:40:52 2017 +0200 ICMPv6: RA: Add Captive Portal Option (RFC7710) RFC 7710 (https://tools.ietf.org/html/rfc7710#section-2.3) defines option 37 Captive Portal URI for Router Advertisments. Change-Id: I257412ef1cf22d47018974cd0ef9000b748d01ac Reviewed-on: https://code.wireshark.org/review/22703 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=d0e8b26ee2695246a4e3baa37d4384e6c2e634d3 commit d0e8b26ee2695246a4e3baa37d4384e6c2e634d3 Author: Marie Janssen Date: Mon Jul 10 13:14:07 2017 -0700 AVRCP: fix parsing of Media Player Items From the AVRCP 1.6.1 spec, page 76, the "Player ID" is two octets. Also, the Play Status field comes before the Feature Bit Mask. Change-Id: Ifd0ad82650d395395b16f9441f02b8835befa360 Reviewed-on: https://code.wireshark.org/review/22709 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=abfa43aa270d92219f0784c725fe31cad1cdbc69 commit abfa43aa270d92219f0784c725fe31cad1cdbc69 Author: Robert Sauter Date: Fri Jul 14 15:27:51 2017 +0200 IEEE 802.15.4: MPX dissect IEEE 802.11 4WH/GKH with EAPOL dissector Change-Id: I8972a9a9efef31ab77571f333fb040569fb7de9a Reviewed-on: https://code.wireshark.org/review/22622 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=da0ae7e19b0a3514756f6d0a762b480d744425ac commit da0ae7e19b0a3514756f6d0a762b480d744425ac Author: Uli Heilmeier Date: Tue Jul 18 20:32:00 2017 +0200 ICMPv6: Fix data length for unknown option The length value includes the Type and Length fields. Therefore the length of the Data field is two bytes smaller. Change-Id: I93878a016ace083f4e766bee6e16e301d6903967 Reviewed-on: https://code.wireshark.org/review/22702 Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=0e0c9a1a7a3e4c9a6bb33d65dbc0918184b8fb30 commit 0e0c9a1a7a3e4c9a6bb33d65dbc0918184b8fb30 Author: Gerald Combs Date: Tue Jul 18 16:01:49 2017 -0700 Qt: Don't clobber the itemview hover behavior on Windows. Change-Id: I47a8087a1d3303baec9b598135c3f8a3021dadbe Reviewed-on: https://code.wireshark.org/review/22707 Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=b92c8a2e56f0e4dba1627e86077e56c63457e85c commit b92c8a2e56f0e4dba1627e86077e56c63457e85c Author: AndersBroman Date: Tue Jul 18 15:12:23 2017 +0200 [Diameter] Add a couple of command codes from IANA. Bug:13895 Change-Id: Icaffd828eef2853d73da807040e5f550548d2804 Reviewed-on: https://code.wireshark.org/review/22698 Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=279a2762dc9f11a68afa3cb84e6ccd9047ede1eb commit 279a2762dc9f11a68afa3cb84e6ccd9047ede1eb Author: Jo??o Valverde Date: Mon Jul 17 20:47:38 2017 +0100 Extend enterprises.tsv to accept spaces as separators We can do so easily because the format is so simple. This makes it more convenient for a user to hand-edit a dictionary in the personal config folder. We still use tabs in the system file for a small space gain. Also add a brief description of the format as a comment. Change-Id: If3f741bff16f1f42c8ef07d643dc6463caaad1a5 Reviewed-on: https://code.wireshark.org/review/22678 Reviewed-by: Guy Harris Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=e46bd2827f581f1c5b18c4e166c13741fa6a99a8 commit e46bd2827f581f1c5b18c4e166c13741fa6a99a8 Author: Chris Brandson Date: Mon Jul 17 16:54:06 2017 -0700 ZigBee cleanup minor errors Alarm Code now correctly displayed as a byte Missing ZCL status codes from ZCL 6 and ZCL 7 have been added Input and Output Cluster Lists now displayed in hex as they are everywhere else The term Device is no longer used, instead Nwk Addr and Address are used as applicable Change-Id: I552f4b64974bf44088a1c8f90d44e5459a0f81a6 Reviewed-on: https://code.wireshark.org/review/22683 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=aec147efa1f27518f6927ca5078e0547dd1a234d commit aec147efa1f27518f6927ca5078e0547dd1a234d Author: Pascal Quantin Date: Mon Jul 17 23:26:40 2017 +0200 LPP: upgrade dissector to v14.2.0 Change-Id: I445c5ef34c1a688310042634eb38bed9b17cadaf Reviewed-on: https://code.wireshark.org/review/22679 Petri-Dish: Pascal Quantin Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman http://cgit.osmocom.org/wireshark/commit/?id=6d025eff1b41cb99a60b50c36de15803f6e8076f commit 6d025eff1b41cb99a60b50c36de15803f6e8076f Author: Guy Harris Date: Mon Jul 17 21:34:11 2017 -0700 Do the meta-tag stuff the same way in all three cases. Undo most of the changes, but turn the return at the end of the default case into a break. Change-Id: I022b62a85254ff188f19fd3d7c3fe40b0789b3d2 Reviewed-on: https://code.wireshark.org/review/22695 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=5fd255424fda27b1ca9ded48a83da31405ae1731 commit 5fd255424fda27b1ca9ded48a83da31405ae1731 Author: Guy Harris Date: Tue Jul 18 04:27:53 2017 +0000 Revert "Don't byte-swap an 1-byte value." This reverts commit 74a2ae4abac3be78d140d9671fa79977de449ed1. No, that's just Coverity not understanding macros *again*, and thinking a particular expanded instance of a macro is the result of some human being silly rather than of the arguments being such that some computations can be elided at compile time. Change-Id: I40f2ad8bf018b0df02d90ed0e272505be68dae7e Reviewed-on: https://code.wireshark.org/review/22693 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=e934fad6389da228ae33e5fb83c29807a315ee77 commit e934fad6389da228ae33e5fb83c29807a315ee77 Author: Simon Vans-Colina Date: Mon Jul 17 18:35:02 2017 +0100 CQL: Fixes the dissector so PREPARE Results have the Query ID Change-Id: I518335dc317ac5fb3c1339686579ff44b73c2546 Reviewed-on: https://code.wireshark.org/review/22675 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=541b9a93871892b0ad1732406f59f2196ae76cf9 commit 541b9a93871892b0ad1732406f59f2196ae76cf9 Author: Stig Bj??rlykke Date: Mon Jul 17 19:46:28 2017 +0200 Qt: Fix "Filter Button Preferences" shortcut When Expert preference UAT was promoted to main preference tree the entry for Filter Buttons was moved and the code for handling prefs_pane_to_item_ was wrong. This should be rewritten to a bulletproof solution. Change-Id: I1d98aa75da7107ac2e50b29ff19c52dc516053a6 Fixes: v2.5.0rc0-386-gd4d30faeb8 Reviewed-on: https://code.wireshark.org/review/22676 Petri-Dish: Stig Bj??rlykke Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann http://cgit.osmocom.org/wireshark/commit/?id=30f8ceebbad01f1040b492599d26e0f01e0824f1 commit 30f8ceebbad01f1040b492599d26e0f01e0824f1 Author: Guy Harris Date: Mon Jul 17 18:56:38 2017 -0700 Remove unnecessary test. The default case ends with return, so the pointer won't be null by the time out exit the case statement - either a non-default case is processed and tag_ptr hasn't been set to null, or the default case is processed and you return before getting there. That also means we don't need to set tag_ptr to null in that case. Fixes CIDs 1415436. Change-Id: I21ada7a308d888b4cbb8557197a2e30bda118f44 Reviewed-on: https://code.wireshark.org/review/22691 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=74a2ae4abac3be78d140d9671fa79977de449ed1 commit 74a2ae4abac3be78d140d9671fa79977de449ed1 Author: Guy Harris Date: Mon Jul 17 18:43:44 2017 -0700 Don't byte-swap an 1-byte value. Convert it to a 4-byte value and byte-swap *that*. Fixes CID 1415438. Change-Id: I5cf0b5905f5dd2086c5d8ed6b13b1921bdb69a84 Reviewed-on: https://code.wireshark.org/review/22689 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=d35bb66516b25a4adf3f0471a1c6256680e4491a commit d35bb66516b25a4adf3f0471a1c6256680e4491a Author: Guy Harris Date: Mon Jul 17 18:32:39 2017 -0700 Remove unnecessary test. The default case ends with return, so the pointer won't be null by the time out exit the case statement - either a non-default case is processed and tag_ptr hasn't been set to null, or the default case is processed and you return before getting there. That also means we don't need to set tag_ptr to null in that case. Fixes CID 1415439. Change-Id: Id2609c0828561c560820f9cb5e6b5a0ae614aead Reviewed-on: https://code.wireshark.org/review/22686 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=8dcb530de6372580fa08659f1b230a86ac53d553 commit 8dcb530de6372580fa08659f1b230a86ac53d553 Author: Guy Harris Date: Mon Jul 17 18:22:53 2017 -0700 Copy no more than MAX_ERF_EHDR - 1 additional extension headers. The array of headers has MAX_ERF_EHDR entries, and the additional entries are appended after the first entry, so that leaves room for at most MAX_ERF_EHDR - 1. Fixes CID 1415440. Change-Id: Iaa2c3577bbff429bcc1301e4cfdf1961f067be93 Reviewed-on: https://code.wireshark.org/review/22684 Reviewed-by: Guy Harris http://cgit.osmocom.org/wireshark/commit/?id=47c9cf8925123bbfc68fd5819816016e488da165 commit 47c9cf8925123bbfc68fd5819816016e488da165 Author: Gerald Combs Date: Mon Jul 17 12:43:30 2017 -0700 Qt: Simplify some version checks. We require Qt5 at configure time on macOS, so we no longer need to exclude Qt4 + macOS in the code. Change-Id: I9e233f963526b0051bd846d171105c1d33d1c4cc Reviewed-on: https://code.wireshark.org/review/22677 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs http://cgit.osmocom.org/wireshark/commit/?id=2ca2cc16b1c4710726ba82908e735f5b27a95184 commit 2ca2cc16b1c4710726ba82908e735f5b27a95184 Author: Guy Harris Date: Mon Jul 17 09:52:53 2017 -0700 Use time_t for the seconds part of a time stamp. A packet time stamp is an nstime_t, and the seconds part of an nstime_t is a time_t. Change-Id: Id2452ceb2f33f43e4a040436d7b3ea1a5c4a0be3 Reviewed-on: https://code.wireshark.org/review/22673 Reviewed-by: Guy Harris ----------------------------------------------------------------------- hooks/post-receive -- wireshark with Osmocom specific dissectors From gitosis at osmocom.org Sat Dec 23 01:13:32 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 23 Dec 2017 01:13:32 GMT Subject: op25.git branch max updated. e9a6e3806f712987f8e7986da991620a8c18442c Message-ID: <201712230113.vBN1DWS2002987@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via e9a6e3806f712987f8e7986da991620a8c18442c (commit) via e79d7eaabc3420c5e2197af4f2eea82a9c83d5f6 (commit) via 5601e5290ee053b1638b27dac5b3fd6935cbd3ab (commit) via 3b26dd2fd2056ede5abd6e556e2f91ed568d0a27 (commit) via 5f264c68bf104f1814031b43a210351066902f8d (commit) via b055a0b6d0f972fa5de952dcc8405d346d90a12d (commit) via db1bd03e25faa38d03fd5b46d26b9ed336476f1d (commit) via 1b1c8842c156482714386295c2d5123215f14156 (commit) via 90fbe465187d3abc77a35ed7d0db6d11a6a452f9 (commit) via dd9bc87c86cad41cbb751f13ca01af081b0d0d83 (commit) via 1fc2df5ac1baef135cb1f24a137e3c9754555a12 (commit) via 04692d23e24a0f31dbd8efcfd993356e359fdf10 (commit) via 0fcef6a5be9d06ead09ea73f8c46e6245c5295a4 (commit) via 35da7d958a894eb998c2f6fbaf7bb313567076ab (commit) via 5edfc1c4638c4f56481dbe633438a76fb6beeb0e (commit) from ce129911bc0218a700d1f31434c59d7b764e4fe8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=e9a6e3806f712987f8e7986da991620a8c18442c commit e9a6e3806f712987f8e7986da991620a8c18442c Author: Max Date: Fri Dec 22 20:09:37 2017 -0500 rx_sync swig interface http://cgit.osmocom.org/op25/commit/?id=e79d7eaabc3420c5e2197af4f2eea82a9c83d5f6 commit e79d7eaabc3420c5e2197af4f2eea82a9c83d5f6 Author: Max Date: Fri Dec 22 20:08:10 2017 -0500 rx_sync additions http://cgit.osmocom.org/op25/commit/?id=5601e5290ee053b1638b27dac5b3fd6935cbd3ab commit 5601e5290ee053b1638b27dac5b3fd6935cbd3ab Author: Max Date: Fri Dec 22 19:11:29 2017 -0500 op25_audio http://cgit.osmocom.org/op25/commit/?id=3b26dd2fd2056ede5abd6e556e2f91ed568d0a27 commit 3b26dd2fd2056ede5abd6e556e2f91ed568d0a27 Author: Max Date: Fri Dec 22 18:29:43 2017 -0500 vocoder_impl http://cgit.osmocom.org/op25/commit/?id=5f264c68bf104f1814031b43a210351066902f8d commit 5f264c68bf104f1814031b43a210351066902f8d Author: Max Date: Fri Dec 22 18:24:05 2017 -0500 bit utils http://cgit.osmocom.org/op25/commit/?id=b055a0b6d0f972fa5de952dcc8405d346d90a12d commit b055a0b6d0f972fa5de952dcc8405d346d90a12d Author: Max Date: Fri Dec 22 18:23:49 2017 -0500 dstar CRC http://cgit.osmocom.org/op25/commit/?id=db1bd03e25faa38d03fd5b46d26b9ed336476f1d commit db1bd03e25faa38d03fd5b46d26b9ed336476f1d Author: Max Date: Fri Dec 22 18:22:46 2017 -0500 dstar parameters http://cgit.osmocom.org/op25/commit/?id=1b1c8842c156482714386295c2d5123215f14156 commit 1b1c8842c156482714386295c2d5123215f14156 Author: Max Date: Fri Dec 22 18:16:18 2017 -0500 add get_freq_error() http://cgit.osmocom.org/op25/commit/?id=90fbe465187d3abc77a35ed7d0db6d11a6a452f9 commit 90fbe465187d3abc77a35ed7d0db6d11a6a452f9 Author: Max Date: Fri Dec 22 18:12:37 2017 -0500 dstar cfg file http://cgit.osmocom.org/op25/commit/?id=dd9bc87c86cad41cbb751f13ca01af081b0d0d83 commit dd9bc87c86cad41cbb751f13ca01af081b0d0d83 Author: Max Date: Fri Dec 22 18:11:56 2017 -0500 dv_tx - add check for dstar cfg file http://cgit.osmocom.org/op25/commit/?id=1fc2df5ac1baef135cb1f24a137e3c9754555a12 commit 1fc2df5ac1baef135cb1f24a137e3c9754555a12 Author: Max Date: Fri Dec 22 18:10:50 2017 -0500 dstar cfg http://cgit.osmocom.org/op25/commit/?id=04692d23e24a0f31dbd8efcfd993356e359fdf10 commit 04692d23e24a0f31dbd8efcfd993356e359fdf10 Author: Max Date: Fri Dec 22 18:08:46 2017 -0500 terminal.py http://cgit.osmocom.org/op25/commit/?id=0fcef6a5be9d06ead09ea73f8c46e6245c5295a4 commit 0fcef6a5be9d06ead09ea73f8c46e6245c5295a4 Author: Max Date: Fri Dec 22 18:05:29 2017 -0500 rx.py http://cgit.osmocom.org/op25/commit/?id=35da7d958a894eb998c2f6fbaf7bb313567076ab commit 35da7d958a894eb998c2f6fbaf7bb313567076ab Author: Max Date: Fri Dec 22 18:02:18 2017 -0500 demodulator updates http://cgit.osmocom.org/op25/commit/?id=5edfc1c4638c4f56481dbe633438a76fb6beeb0e commit 5edfc1c4638c4f56481dbe633438a76fb6beeb0e Author: Max Date: Fri Dec 22 16:52:30 2017 -0500 install.sh ----------------------------------------------------------------------- Summary of changes: install.sh | 15 +- op25/gr-op25_repeater/apps/p25_demodulator.py | 129 +++++-- op25/gr-op25_repeater/apps/rx.py | 74 ++-- op25/gr-op25_repeater/apps/terminal.py | 140 +++++++- .../apps/tx/{ysf-cfg.dat => dstar-cfg.dat} | 40 +-- op25/gr-op25_repeater/apps/tx/dv_tx.py | 4 +- op25/gr-op25_repeater/apps/tx/multi_tx.py | 2 + .../include/op25_repeater/CMakeLists.txt | 1 + .../{p25_frame_assembler.h => frame_assembler.h} | 20 +- .../include/op25_repeater/gardner_costas_cc.h | 1 + op25/gr-op25_repeater/lib/CCITTChecksumReverse.cpp | 93 +++++ op25/gr-op25_repeater/lib/CCITTChecksumReverse.h | 39 +++ op25/gr-op25_repeater/lib/CMakeLists.txt | 4 + op25/gr-op25_repeater/lib/bit_utils.h | 59 ++++ op25/gr-op25_repeater/lib/dstar_header.h | 130 +++++++ op25/gr-op25_repeater/lib/dstar_tx_sb_impl.cc | 42 ++- op25/gr-op25_repeater/lib/dstar_tx_sb_impl.h | 1 + op25/gr-op25_repeater/lib/frame_assembler_impl.cc | 96 ++++++ ...ame_assembler_impl.h => frame_assembler_impl.h} | 34 +- .../gr-op25_repeater/lib/gardner_costas_cc_impl.cc | 5 +- op25/gr-op25_repeater/lib/gardner_costas_cc_impl.h | 1 + op25/gr-op25_repeater/lib/op25_audio.cc | 242 +++++++++++++ op25/gr-op25_repeater/lib/op25_audio.h | 70 ++++ op25/gr-op25_repeater/lib/rx_sync.cc | 377 +++++++++++++++++++++ op25/gr-op25_repeater/lib/rx_sync.h | 122 +++++++ op25/gr-op25_repeater/lib/vocoder_impl.cc | 9 +- op25/gr-op25_repeater/swig/op25_repeater_swig.i | 5 + 27 files changed, 1618 insertions(+), 137 deletions(-) mode change 100644 => 100755 op25/gr-op25_repeater/apps/terminal.py copy op25/gr-op25_repeater/apps/tx/{ysf-cfg.dat => dstar-cfg.dat} (61%) copy op25/gr-op25_repeater/include/op25_repeater/{p25_frame_assembler.h => frame_assembler.h} (67%) create mode 100644 op25/gr-op25_repeater/lib/CCITTChecksumReverse.cpp create mode 100644 op25/gr-op25_repeater/lib/CCITTChecksumReverse.h create mode 100644 op25/gr-op25_repeater/lib/bit_utils.h create mode 100644 op25/gr-op25_repeater/lib/dstar_header.h create mode 100644 op25/gr-op25_repeater/lib/frame_assembler_impl.cc copy op25/gr-op25_repeater/lib/{p25_frame_assembler_impl.h => frame_assembler_impl.h} (58%) create mode 100644 op25/gr-op25_repeater/lib/op25_audio.cc create mode 100644 op25/gr-op25_repeater/lib/op25_audio.h create mode 100644 op25/gr-op25_repeater/lib/rx_sync.cc create mode 100644 op25/gr-op25_repeater/lib/rx_sync.h hooks/post-receive -- Software-defined analyzer for APCO P25 From gitosis at osmocom.org Sat Dec 23 01:15:50 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 23 Dec 2017 01:15:50 GMT Subject: op25.git branch max updated. 682bd4abcb9e97c3ef96b68aa8b179fef4f043d3 Message-ID: <201712230115.vBN1FoV6004546@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via 682bd4abcb9e97c3ef96b68aa8b179fef4f043d3 (commit) from e9a6e3806f712987f8e7986da991620a8c18442c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=682bd4abcb9e97c3ef96b68aa8b179fef4f043d3 commit 682bd4abcb9e97c3ef96b68aa8b179fef4f043d3 Author: Max Date: Fri Dec 22 20:15:47 2017 -0500 crc16.h ----------------------------------------------------------------------- Summary of changes: .../lib/crc16.h} | 49 ++++++++-------------- 1 file changed, 17 insertions(+), 32 deletions(-) copy op25/{gr-op25/lib/fsk4_slicer_fb_impl.h => gr-op25_repeater/lib/crc16.h} (50%) hooks/post-receive -- Software-defined analyzer for APCO P25 From gitosis at osmocom.org Sat Dec 23 11:23:59 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 23 Dec 2017 11:23:59 GMT Subject: osmo-python-tests.git branch master updated. 6588960d1d27d5a6da7fb6144e72f6f134e69063 Message-ID: <201712231123.vBNBNxZx073630@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 6588960d1d27d5a6da7fb6144e72f6f134e69063 (commit) from 379fb9783b1cfa1563a49cdf5a65c7b317a5e967 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=6588960d1d27d5a6da7fb6144e72f6f134e69063 commit 6588960d1d27d5a6da7fb6144e72f6f134e69063 Author: Max Date: Mon Dec 18 15:05:41 2017 +0100 Add scripts to compilation tests in jenkins Related: OS#2684 Change-Id: If098c20b1ad17c3868073b9fe07fd3795217c526 ----------------------------------------------------------------------- Summary of changes: contrib/jenkins.sh | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Sat Dec 23 23:57:30 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 23 Dec 2017 23:57:30 GMT Subject: op25.git branch max updated. 9f8b9af3a46e8d6d0af2d29b8d8668405dc62e9e Message-ID: <201712232357.vBNNvUQF085704@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via 9f8b9af3a46e8d6d0af2d29b8d8668405dc62e9e (commit) from 682bd4abcb9e97c3ef96b68aa8b179fef4f043d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=9f8b9af3a46e8d6d0af2d29b8d8668405dc62e9e commit 9f8b9af3a46e8d6d0af2d29b8d8668405dc62e9e Author: Max Date: Sat Dec 23 18:54:48 2017 -0500 dv_tx resamp hack ----------------------------------------------------------------------- Summary of changes: op25/gr-op25_repeater/apps/tx/dv_tx.py | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) hooks/post-receive -- Software-defined analyzer for APCO P25 From gitosis at osmocom.org Sun Dec 24 23:55:35 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 24 Dec 2017 23:55:35 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-27-g6eeef11 Message-ID: <201712242355.vBONtZsM012443@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 6eeef115a9096b954dd6d873978abbb28055d301 (commit) from 66d6d760aab222c91bec5134c228ffc13f463235 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=6eeef115a9096b954dd6d873978abbb28055d301 commit 6eeef115a9096b954dd6d873978abbb28055d301 Author: Neels Hofmeyr Date: Wed Dec 20 23:14:45 2017 +0100 hnbap,rua,ranap decode: fix segfault on decode error Looking at hnbap_decode_hnbregisterrequesties(), I noticed a segfault if decoding the HNB Register Request PDU fails, which is due to an unchecked return value in code generated by asn1tostruct.py. Add return value and NULL pointer checks and hence fix null dereference on erratic PDUs across HNBAP, RUA and RANAP protocols. Similar checks exist in other places, this one was simply missing. Since the result of asn1tostruct.py is not committed, here is an example diff of the resulting change, of which there are 128 instances in total: @@ -304,7 +329,12 @@ memset(hnbRegisterRequestIEs, 0, sizeof(HNBRegisterRequestIEs_t)); HNBAP_DEBUG("Decoding message HNBRegisterRequestIEs (%s:%d)\n", __FILE__, __LINE__); - ANY_to_type_aper(any_p, &asn_DEF_HNBRegisterRequest, (void**)&hNBRegisterRequest_p); + tempDecoded = ANY_to_type_aper(any_p, &asn_DEF_HNBRegisterRequest, (void**)&hNBRegisterRequest_p); + + if (tempDecoded < 0 || hNBRegisterRequest_p == NULL) { + HNBAP_DEBUG("Decoding of message HNBRegisterRequestIEs failed\n"); + return -1; + } for (i = 0; i < hNBRegisterRequest_p->hnbRegisterRequest_ies.list.count; i++) { IE_t *ie_p; Change-Id: I6cb9cc9a88d22f03befa43f0968a874476fa079d ----------------------------------------------------------------------- Summary of changes: asn1/utils/asn1tostruct.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Mon Dec 25 00:43:26 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 25 Dec 2017 00:43:26 GMT Subject: libosmo-sccp.git branch master updated. 0.8.1-33-g16676cf Message-ID: <201712250043.vBP0hQk7037846@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 16676cf05ac666229f766e01aa69264e1457624d (commit) via 8800b7cf9f8cce510cd78d4b7c100d2a5dc85a12 (commit) via e4a77d46735046c09c3b58e9c404539bb5b8e2af (commit) via d23e38020fdbb685570145acd3a35e22a5a91344 (commit) via ed287f2b878cadd49d2673cb650f0d603ddb0d9c (commit) from 1aa2a42eae63eaf591306e5a5021fc5453de6da9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=16676cf05ac666229f766e01aa69264e1457624d commit 16676cf05ac666229f766e01aa69264e1457624d Author: Neels Hofmeyr Date: Sun Dec 24 20:29:21 2017 +0100 cosmetic: hmrt_message_for_routing(): use osmo_ss7_route_name() Change-Id: Iae524c38cd91383a59c64bf7919d94ba7ff350bd http://cgit.osmocom.org/libosmo-sccp/commit/?id=8800b7cf9f8cce510cd78d4b7c100d2a5dc85a12 commit 8800b7cf9f8cce510cd78d4b7c100d2a5dc85a12 Author: Neels Hofmeyr Date: Sun Dec 24 19:27:55 2017 +0100 add osmo_ss7_route_name() There is a naming dilemma: though the osmo_ prefix is now reserved for libosmocore, all surrounding API already has the osmo_ prefix. This will be used by osmo-hnbgw's VTY 'show cnlink' command. Change-Id: Ia0d15a2814b08bc3f052a1ed12dbb68bade55309 http://cgit.osmocom.org/libosmo-sccp/commit/?id=e4a77d46735046c09c3b58e9c404539bb5b8e2af commit e4a77d46735046c09c3b58e9c404539bb5b8e2af Author: Neels Hofmeyr Date: Sun Dec 24 16:12:42 2017 +0100 add osmo_sccp_user_name() There is a naming dilemma: though the osmo_ prefix is now reserved for libosmocore, all surrounding API already has the osmo_ prefix. This will be used by osmo-hnbgw's VTY 'show cnlink' command. Change-Id: Ib7abf69cfcf4c56273223054b280458451e6c2f6 http://cgit.osmocom.org/libosmo-sccp/commit/?id=d23e38020fdbb685570145acd3a35e22a5a91344 commit d23e38020fdbb685570145acd3a35e22a5a91344 Author: Neels Hofmeyr Date: Sun Dec 24 16:34:22 2017 +0100 typo: osmo-stp main: 'Erro' Change-Id: Ibb28f48b46a4b86c62770b4d22dcf735717aeadb http://cgit.osmocom.org/libosmo-sccp/commit/?id=ed287f2b878cadd49d2673cb650f0d603ddb0d9c commit ed287f2b878cadd49d2673cb650f0d603ddb0d9c Author: Neels Hofmeyr Date: Sun Dec 24 16:22:39 2017 +0100 osmo_sccp_addr_name / _dump: drop 'NO_GT' output Do not print the GTI if gti is set to OSMO_SCCP_GTI_NO_GT and no GT is present in the address. If addr->gt.gti is set to OSMO_SCCP_GTI_NO_GT, i.e. currently always, osmo_sccp_addr_name() and osmo_sccp_addr_dump() output ",GTI=NO_GT" in every address dump, which is useless clutter. Drop that. However, if a Global Title is flagged in addr->presence, still output the GTI to highlight situations where GTI might mismatch the presence of a GT. Change-Id: I9f87b2b703223ecb5d0442b6199c5b779fe544a1 ----------------------------------------------------------------------- Summary of changes: include/osmocom/sigtran/osmo_ss7.h | 1 + include/osmocom/sigtran/sccp_sap.h | 2 + src/osmo_ss7_hmrt.c | 90 +++++++++++++++++++++++++++++++++----- src/sccp_helpers.c | 6 ++- src/sccp_user.c | 21 +++++++++ stp/stp_main.c | 2 +- tests/xua/xua_test.ok | 16 +++---- 7 files changed, 115 insertions(+), 23 deletions(-) hooks/post-receive -- SCCP Library From gitosis at osmocom.org Mon Dec 25 13:45:16 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 25 Dec 2017 13:45:16 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-37-g23f3fdc Message-ID: <201712251345.vBPDjG1r092946@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 23f3fdc6b25d8c5fc5a8f7f23eb69d2ac3d712b3 (commit) via 4e2681df26399e2ff6260f3eaaeca23c3e25bfa6 (commit) via da58d26cbcfb1b523830b359a17beb8660311bd7 (commit) via e045da02613850aa1beff73516644834fcbc26f8 (commit) via 1e9f4f5432fff3ff96d23b16252dd865b9e7aa62 (commit) via b10e2937d94d30a9c33bb70ea291c856868490be (commit) via aa3e9ebcb409e97ab3e61f17df7c154b8455d568 (commit) via f33d16404d6cd78bfe33d445d1786f731a036440 (commit) via 9e17e054e4bc48cf608c6fec1d7729a9ce74b872 (commit) via 140f38c55ec208f9ed4c8b81e228bf0091cb1731 (commit) from 6eeef115a9096b954dd6d873978abbb28055d301 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=23f3fdc6b25d8c5fc5a8f7f23eb69d2ac3d712b3 commit 23f3fdc6b25d8c5fc5a8f7f23eb69d2ac3d712b3 Author: Neels Hofmeyr Date: Mon Dec 25 00:00:04 2017 +0100 comments: hnbgw_rua.c: remove obsolete fixmes for asn1 free The comments are all right above the line that does the proper asn1 free step. Change-Id: I60e3be8c56ecc75c22e76f9e9dce8c72753e153b http://cgit.osmocom.org/osmo-iuh/commit/?id=4e2681df26399e2ff6260f3eaaeca23c3e25bfa6 commit 4e2681df26399e2ff6260f3eaaeca23c3e25bfa6 Author: Neels Hofmeyr Date: Sun Dec 24 23:54:07 2017 +0100 osmo-hnbgw: startup: log the RNC-Id that is going to be used Change-Id: I8aeb93fe8037e5fdc0784f5fc3bdb527de3b76bd http://cgit.osmocom.org/osmo-iuh/commit/?id=da58d26cbcfb1b523830b359a17beb8660311bd7 commit da58d26cbcfb1b523830b359a17beb8660311bd7 Author: Neels Hofmeyr Date: Mon Dec 25 00:01:37 2017 +0100 osmo-hnbgw config: add 'rnc-id' config item So far, the RNC-Id is hard-coded as 23. Still use 23 as default, but allow configuring by config file. Hence make it possible to run multiple osmo-hnbgw with differing RNC-Id each. Change-Id: I374f558cc4bb36055f39efe9c58ae1b9bd49da46 http://cgit.osmocom.org/osmo-iuh/commit/?id=e045da02613850aa1beff73516644834fcbc26f8 commit e045da02613850aa1beff73516644834fcbc26f8 Author: Neels Hofmeyr Date: Sun Dec 24 20:34:38 2017 +0100 cosmetic: context_map_tmr_cb(): fix comment Change-Id: I4dd07a4d09d3cd4dc2a08e42ee48344967e5e3a6 http://cgit.osmocom.org/osmo-iuh/commit/?id=1e9f4f5432fff3ff96d23b16252dd865b9e7aa62 commit 1e9f4f5432fff3ff96d23b16252dd865b9e7aa62 Author: Neels Hofmeyr Date: Sun Dec 24 23:57:58 2017 +0100 rua_to_scu(): don't create a context map for UNITDATA UNITDATA is connection-less, and as can be observed further below, the 'map' doesn't get used in the N_UNIDATA case. Related: OS#2776 Change-Id: Ic35562e6d7bfa54b6be859860657f9a235ad5a50 http://cgit.osmocom.org/osmo-iuh/commit/?id=b10e2937d94d30a9c33bb70ea291c856868490be commit b10e2937d94d30a9c33bb70ea291c856868490be Author: Neels Hofmeyr Date: Sun Dec 24 21:49:44 2017 +0100 rua: discard context maps on id-Disconnect When an id-Disconnect is received, the RUA to SCCP user context becomes unused. Mark the context map as inactive in that case. It will be cleaned up by the context map garbage collector. Related: OS#2776 Change-Id: I9616f72bfa566de081098ee13e720ff0f5266c77 http://cgit.osmocom.org/osmo-iuh/commit/?id=aa3e9ebcb409e97ab3e61f17df7c154b8455d568 commit aa3e9ebcb409e97ab3e61f17df7c154b8455d568 Author: Neels Hofmeyr Date: Sun Dec 24 21:47:59 2017 +0100 segfault: context_map gc: use llist_for_each_entry_safe() The context map garbage collector removes entries from the list, hence it must use llist_for_each_entry_safe(). We haven't hit this before since nothing is yet flagging context maps to be discarded. Related: OS#2776 Change-Id: I9d5899923054d1bf862d542fec862fb1e6f07dce http://cgit.osmocom.org/osmo-iuh/commit/?id=f33d16404d6cd78bfe33d445d1786f731a036440 commit f33d16404d6cd78bfe33d445d1786f731a036440 Author: Neels Hofmeyr Date: Thu Dec 21 05:23:44 2017 +0100 compiler warning: asn1tostruct.py: return 0 at end of *_free_*() Part of the resulting diff in the generated code: --- /tmp/hnbap_decoder.c 2017-12-24 17:06:50.983979866 +0100 +++ /tmp/hnbap_decoder.c 2017-12-24 17:07:10.760223354 +0100 @@ -1179,6 +1179,7 @@ TNLUpdateResponseIEs_t *tnlUpdateResponseIEs) { ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_Context_ID, &tnlUpdateResponseIEs->context_ID); + return 0; } int hnbap_free_tnlupdaterequesties( @@ -1187,6 +1188,7 @@ ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_Context_ID, &tnlUpdateRequestIEs->context_ID); ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RABList, &tnlUpdateRequestIEs->rabList); ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_Update_cause, &tnlUpdateRequestIEs->update_cause); + return 0; } int hnbap_free_errorindicationies( @@ -1197,12 +1199,14 @@ if ((errorIndicationIEs->presenceMask & ERRORINDICATIONIES_CRITICALITYDIAGNOSTICS_PRESENT) == ERRORINDICATIONIES_CRITICALITYDIAGNOSTICS_PRESENT) ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_CriticalityDiagnostics, &errorIndicationIEs->criticalityDiagnostics); + return 0; } int hnbap_free_hnbconfigtransferrequesties( HNBConfigTransferRequestIEs_t *hnbConfigTransferRequestIEs) { ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_NeighbourInfoRequestList, &hnbConfigTransferRequestIEs->neighbourInfoRequestList); + return 0; } int hnbap_free_tnlupdatefailureies( [etc.] Related: OS#2670 Change-Id: Ieba12c09c33a81da964bf88a858714d922ced8c0 http://cgit.osmocom.org/osmo-iuh/commit/?id=9e17e054e4bc48cf608c6fec1d7729a9ce74b872 commit 9e17e054e4bc48cf608c6fec1d7729a9ce74b872 Author: Neels Hofmeyr Date: Mon Dec 25 00:35:05 2017 +0100 osmo-hnbgw: vty: revamp output of context maps on 'show hnb' Instead of listing each and every context map, rather output a summary of context counts. Rationale: in a list of a hundred HNBs, I don't want to also see a dozen (or potentially thousands of) context map lines for each. Furthermore, the conn IDs aren't necessarily useful on network traces either. For example, what was shown as SUA Id is incidentally the SCCP Reference, but this is not a hard requirement and may change. Also, the reference is shown in wireshark as a hex in mismatching byte order ... so rather don't bother. The result now looks like OsmoHNBGW> show hnb all HNB (r=192.168.0.124:29169<->l=192.168.0.9:29169) "000295-0000152614 at ap.ipaccess.com" MCC 901 MNC 70 LAC 14357 RAC 11 SAC 1 CID 8595638 SCCP-stream:HNBAP=0,RUA=0 IuCS: 1 contexts: inactive-reserved:1 IuPS: 1 contexts: active:1 1 HNB connected Related: OS#2772 OS#2773 Change-Id: Iae76b68e85863c8663bb5c508b85534c00e1d2c9 http://cgit.osmocom.org/osmo-iuh/commit/?id=140f38c55ec208f9ed4c8b81e228bf0091cb1731 commit 140f38c55ec208f9ed4c8b81e228bf0091cb1731 Author: Neels Hofmeyr Date: Wed Dec 20 23:48:02 2017 +0100 vty: tweak / improve HNB and cnlink introspection Add 'show cnlink' (uses new osmo_sccp_user_name(), see 'Depends' below). Tweak 'show hnb all'. The result looks something like: OsmoHNBGW> show cnlink IuCS: OsmoHNBGW:RI=SSN_PC,PC=0.23.5,SSN=RANAP <-> RI=SSN_PC,PC=0.23.1,SSN=RANAP SS7 route: pc=0=0.0.0 mask=0x0=0.0.0 via AS as-clnt-OsmoHNBGW proto=m3ua ASP asp-clnt-OsmoHNBGW (r=127.0.0.1:2905<->l=127.0.0.1:37699) IuPS: OsmoHNBGW:RI=SSN_PC,PC=0.23.5,SSN=RANAP <-> RI=SSN_PC,PC=0.23.4,SSN=RANAP SS7 route: pc=0=0.0.0 mask=0x0=0.0.0 via AS as-clnt-OsmoHNBGW proto=m3ua ASP asp-clnt-OsmoHNBGW (r=127.0.0.1:2905<->l=127.0.0.1:37699) OsmoHNBGW> show hnb all No HNB connected OsmoHNBGW> show hnb all HNB (r=192.168.0.124:29169<->l=192.168.0.9:29169) "000295-0000152614 at ap.ipaccess.com" MCC 901 MNC 70 LAC 14357 RAC 11 SAC 1 CID 8595638 SCCP-stream:HNBAP=0,RUA=0 IuCS 24->1002 (RUA->SUA) state=1 IuPS 24->1003 (RUA->SUA) state=1 HNB (r=192.168.0.15:29169<->l=192.168.0.9:29169) "000295-0000154153 at ap.ipaccess.com" MCC 901 MNC 70 LAC 24358 RAC 22 SAC 65535 CID 1048575 SCCP-stream:HNBAP=0,RUA=0 IuCS 23->1000 (RUA->SUA) state=1 IuPS 23->1001 (RUA->SUA) state=1 2 HNB connected Related: OS#2772 OS#2773 Depends: Ib7abf69cfcf4c56273223054b280458451e6c2f6 (libosmo-sccp) Ia0d15a2814b08bc3f052a1ed12dbb68bade55309 (libosmo-sccp) Change-Id: I3c937306a011715e163a40bc8ef8ec7e8d4e5d08 ----------------------------------------------------------------------- Summary of changes: asn1/utils/asn1tostruct.py | 2 + include/osmocom/iuh/context_map.h | 5 ++ src/context_map.c | 14 +++-- src/hnbgw.c | 2 + src/hnbgw_rua.c | 31 +++++++---- src/hnbgw_vty.c | 108 +++++++++++++++++++++++++++++++++++--- 6 files changed, 142 insertions(+), 20 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Mon Dec 25 22:28:23 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Mon, 25 Dec 2017 22:28:23 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-38-g3bd8a55 Message-ID: <201712252228.vBPMSNNf063093@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 3bd8a556612e5990e7997044d20ade06373a7da6 (commit) from 23f3fdc6b25d8c5fc5a8f7f23eb69d2ac3d712b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=3bd8a556612e5990e7997044d20ade06373a7da6 commit 3bd8a556612e5990e7997044d20ade06373a7da6 Author: Neels Hofmeyr Date: Mon Dec 25 15:24:33 2017 +0100 vty typo: 'show hnb': SCTP stream, not SCCP stream Change-Id: Iceb29af9f4ef6b4b4ed9778bdd683d30c201371d ----------------------------------------------------------------------- Summary of changes: src/hnbgw_vty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Tue Dec 26 01:16:18 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 26 Dec 2017 01:16:18 GMT Subject: op25.git branch max updated. 9b93b5699d89128bf07f95ee69f77ed640b9bdb8 Message-ID: <201712260116.vBQ1GIDe095741@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via 9b93b5699d89128bf07f95ee69f77ed640b9bdb8 (commit) via cd16c15c54371b72b7c7a4c7942b8e05f4c535ab (commit) via 18e96a230760fcd48660c82fc9c82f4dd2ccbf09 (commit) from 9f8b9af3a46e8d6d0af2d29b8d8668405dc62e9e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=9b93b5699d89128bf07f95ee69f77ed640b9bdb8 commit 9b93b5699d89128bf07f95ee69f77ed640b9bdb8 Author: Max Date: Mon Dec 25 20:15:10 2017 -0500 multi rx http://cgit.osmocom.org/op25/commit/?id=cd16c15c54371b72b7c7a4c7942b8e05f4c535ab commit cd16c15c54371b72b7c7a4c7942b8e05f4c535ab Author: Max Date: Mon Dec 25 20:13:43 2017 -0500 readme update II http://cgit.osmocom.org/op25/commit/?id=18e96a230760fcd48660c82fc9c82f4dd2ccbf09 commit 18e96a230760fcd48660c82fc9c82f4dd2ccbf09 Author: Max Date: Mon Dec 25 19:36:35 2017 -0500 update readme ----------------------------------------------------------------------- Summary of changes: op25/gr-op25_repeater/apps/README | 52 ++++++++ op25/gr-op25_repeater/apps/cfg.json | 49 ++++++++ op25/gr-op25_repeater/apps/multi_rx.py | 217 +++++++++++++++++++++++++++++++++ 3 files changed, 318 insertions(+) create mode 100644 op25/gr-op25_repeater/apps/cfg.json create mode 100755 op25/gr-op25_repeater/apps/multi_rx.py hooks/post-receive -- Software-defined analyzer for APCO P25 From gitosis at osmocom.org Tue Dec 26 21:15:56 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Tue, 26 Dec 2017 21:15:56 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-40-gf8b73b1 Message-ID: <201712262115.vBQLFuss001125@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via f8b73b15c06055719e712b5a70d130cfd42bea4b (commit) via 8e88d37ceca1dcbb91c59a26d6467df8524283f5 (commit) from 3bd8a556612e5990e7997044d20ade06373a7da6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=f8b73b15c06055719e712b5a70d130cfd42bea4b commit f8b73b15c06055719e712b5a70d130cfd42bea4b Author: Harald Welte Date: Tue Dec 26 21:39:53 2017 +0100 hnbgw_vty.c: Fix "-Werror=format-security" failure in vty_out() We have to use a format string, we cannot directly print "name". Fixes a build error on our OBS builds: hnbgw_vty.c:156:5: error: format not a string literal and no format arguments [-Werror=format-security] which was introduced in Change-Id I3c937306a011715e163a40bc8ef8ec7e8d4e5d08 about one week ago. Change-Id: I042989c2b7b379284b2ee5fea3bd8f8ce406b09e http://cgit.osmocom.org/osmo-iuh/commit/?id=8e88d37ceca1dcbb91c59a26d6467df8524283f5 commit 8e88d37ceca1dcbb91c59a26d6467df8524283f5 Author: Harald Welte Date: Tue Dec 26 21:38:49 2017 +0100 hnbgw_vty.c: cosmetic: Fix non-tab-indented code This was introduced a week ago in Change-Id I3c937306a011715e163a40bc8ef8ec7e8d4e5d08 and is now cleaned up. Change-Id: Iaadf941aa7f1c5ae05eb02b51cc646b7b5587ba3 ----------------------------------------------------------------------- Summary of changes: src/hnbgw_vty.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Thu Dec 28 20:50:48 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 28 Dec 2017 20:50:48 GMT Subject: osmo-iuh.git branch laforge/reject-id-cid created. 0.2.0-42-g722a802 Message-ID: <201712282050.vBSKomjw040361@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, laforge/reject-id-cid has been created at 722a802c79fc40d17e42982412382034e62829ab (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=722a802c79fc40d17e42982412382034e62829ab commit 722a802c79fc40d17e42982412382034e62829ab Author: Harald Welte Date: Thu Dec 28 21:47:06 2017 +0100 Reject any HNBAP-REGISTER messages for HNB's with identical CID According to some references found in the nano3G MIB help, the CellID as reported in the HNB-REGISTER-REQ is combined from 16-bit CellID and the 12bit RNC-ID. The HNB-GW should use this value in the register-req to ensure it is unique in the network. We should probably reject register requests from non-unique / overlapping values. Change-Id: Ib58cc9f3c0e700f8bc5930f4df0d2dfe7888b991 Closes: OS#2789 http://cgit.osmocom.org/osmo-iuh/commit/?id=39773fd362669ab614c767f4d818200090d93233 commit 39773fd362669ab614c767f4d818200090d93233 Author: Harald Welte Date: Mon Oct 9 16:41:33 2017 +0800 WIP: fix asn1 syntax errors Change-Id: Ib6977a9803fdce010eca9fc9a768c89ccf4215f8 ----------------------------------------------------------------------- hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Thu Dec 28 22:22:52 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 28 Dec 2017 22:22:52 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-41-g1e57ba5 Message-ID: <201712282222.vBSMMqsT075137@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 1e57ba503ed734b36094288ad2dbedbd11f39c57 (commit) from f8b73b15c06055719e712b5a70d130cfd42bea4b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=1e57ba503ed734b36094288ad2dbedbd11f39c57 commit 1e57ba503ed734b36094288ad2dbedbd11f39c57 Author: Max Date: Thu Dec 28 12:27:41 2017 +0100 Use proper package version Use actual application version instead of hardcoded "0". Change-Id: I8711b9d819454d810291d57b97119d9fe4a47f8e ----------------------------------------------------------------------- Summary of changes: src/hnbgw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Thu Dec 28 23:45:12 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Thu, 28 Dec 2017 23:45:12 GMT Subject: osmo-pcu.git branch master updated. 0.4.0-28-geffdec6 Message-ID: <201712282345.vBSNjCGl009842@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via effdec6e13550f89469c2f9da95895cc5c474dd0 (commit) from 20c7c46bceac4969e420f2b0dd89448327914971 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=effdec6e13550f89469c2f9da95895cc5c474dd0 commit effdec6e13550f89469c2f9da95895cc5c474dd0 Author: Max Date: Thu Dec 28 14:18:02 2017 +0100 Add optional profiling support This facilitates the use of programs like uftrace. It's disabled by default due to associated overhead. Change-Id: I5c16988cefa46e0b958030c0f3bff9efc5b4979d ----------------------------------------------------------------------- Summary of changes: configure.ac | 9 +++++++++ 1 file changed, 9 insertions(+) hooks/post-receive -- UNNAMED PROJECT From gitosis at osmocom.org Fri Dec 29 02:17:09 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Fri, 29 Dec 2017 02:17:09 GMT Subject: op25.git branch max updated. d25d93cf9e9b870e9e1440d9aaa7c9239fda56b6 Message-ID: <201712290217.vBT2H9na068588@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via d25d93cf9e9b870e9e1440d9aaa7c9239fda56b6 (commit) from 9b93b5699d89128bf07f95ee69f77ed640b9bdb8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=d25d93cf9e9b870e9e1440d9aaa7c9239fda56b6 commit d25d93cf9e9b870e9e1440d9aaa7c9239fda56b6 Author: Max Date: Thu Dec 28 21:16:07 2017 -0500 p25 p2/tdma bugfix, code cleanups ----------------------------------------------------------------------- Summary of changes: op25/gr-op25_repeater/apps/rx.py | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) hooks/post-receive -- Software-defined analyzer for APCO P25 From gitosis at osmocom.org Sat Dec 30 20:01:36 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 30 Dec 2017 20:01:36 GMT Subject: osmocom-bb.git branch master updated. osmocon_v0.0.0-1893-g96e5f8cb Message-ID: <201712302001.vBUK1a7T099404@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via 96e5f8cbe57d55a274cfba1ac7f4961b29bab6fe (commit) via ceb0875f1a2c90de826450f1de127450b62bcd9b (commit) via a8130aba91247e07df83d2612f14d58d9a45eaa7 (commit) from f02c04f4441ae0d05f46f5fdfd1aa8181ede57a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=96e5f8cbe57d55a274cfba1ac7f4961b29bab6fe commit 96e5f8cbe57d55a274cfba1ac7f4961b29bab6fe Author: Holger Hans Peter Freyther Date: Wed Dec 27 10:51:32 2017 +0800 mobile: Add lua examples for basic functions that are available Link to Lua docs, link to our manual. Demo logging, timer, MS on/off, sms sending and sms receiving. For the MM state I will need to export constants/names to make this usable. Currently it is a bit of a hack (first time to MM_IDLE) to send a SMS. We would know when we attached though. Change-Id: I10ac656330b65e3905d6cbbb7865aa0f969cd9ff http://cgit.osmocom.org/osmocom-bb/commit/?id=ceb0875f1a2c90de826450f1de127450b62bcd9b commit ceb0875f1a2c90de826450f1de127450b62bcd9b Author: Holger Hans Peter Freyther Date: Wed Dec 27 10:50:14 2017 +0800 mobile: Properly close the primitive interface on reload When reloading a script go through script_lua_close. Get the primitive first. Then destruct the lua environment which will lead to GC (e.g. cancellation of timers) and then delete the primitive code. Change-Id: I5bb4fa9e7c5010f3ad50b258dcb14956eea8822a http://cgit.osmocom.org/osmocom-bb/commit/?id=a8130aba91247e07df83d2612f14d58d9a45eaa7 commit a8130aba91247e07df83d2612f14d58d9a45eaa7 Author: Holger Hans Peter Freyther Date: Tue Dec 26 12:46:30 2017 +0800 mobile: Send SMS through the primitive interface Make this symmetric and send the SMS through the primitive interface. Construct and copy the sms into the prim, store the SCA in the prim as well. In 04.11 we see we can store 2*10 digits in the destination address and a NUL. Change-Id: I91d7537f4f6ce5ba00218c58f3456947ec7bc662 ----------------------------------------------------------------------- Summary of changes: doc/examples/mobile/lua_helloworld.lua | 9 ++++++ doc/examples/mobile/lua_ms_on_off.lua | 23 ++++++++++++++++ doc/examples/mobile/lua_sms_on_attach.lua | 32 ++++++++++++++++++++++ doc/examples/mobile/lua_sms_receive.lua | 15 ++++++++++ doc/examples/mobile/lua_timer.lua | 12 ++++++++ .../layer23/include/osmocom/bb/mobile/gsm411_sms.h | 2 ++ .../layer23/include/osmocom/bb/mobile/primitives.h | 2 ++ src/host/layer23/src/mobile/gsm411_sms.c | 2 +- src/host/layer23/src/mobile/primitives.c | 16 +++++++++++ src/host/layer23/src/mobile/script_lua.c | 30 ++++++++++++++++---- 10 files changed, 136 insertions(+), 7 deletions(-) create mode 100644 doc/examples/mobile/lua_helloworld.lua create mode 100644 doc/examples/mobile/lua_ms_on_off.lua create mode 100644 doc/examples/mobile/lua_sms_on_attach.lua create mode 100644 doc/examples/mobile/lua_sms_receive.lua create mode 100644 doc/examples/mobile/lua_timer.lua hooks/post-receive -- The Open Source GSM Base Band stack From gitosis at osmocom.org Sat Dec 30 23:20:20 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sat, 30 Dec 2017 23:20:20 GMT Subject: pysim.git branch master updated. 287b6ce1b49fc924fd281a000748f2002114c408 Message-ID: <201712302320.vBUNKKh8079972@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "A python tool to program magic SIMs". The branch, master has been updated via 287b6ce1b49fc924fd281a000748f2002114c408 (commit) via ac23ad5013e47e26bb53cfe7fb73d970891e94e3 (commit) from 1d087efc974ed29d8f0802a7aba507ab56698283 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/pysim/commit/?id=287b6ce1b49fc924fd281a000748f2002114c408 commit 287b6ce1b49fc924fd281a000748f2002114c408 Author: Pau Espin Pedrol Date: Fri Dec 29 20:48:51 2017 +0100 pySim-prog.py: Fix trailing whitespace Change-Id: I735dc7bb774d77d3b60b1712b0f0afcbb81dc726 http://cgit.osmocom.org/pysim/commit/?id=ac23ad5013e47e26bb53cfe7fb73d970891e94e3 commit ac23ad5013e47e26bb53cfe7fb73d970891e94e3 Author: Pau Espin Pedrol Date: Fri Dec 29 20:30:35 2017 +0100 pySim-*.py: Set shebang to use python v2 Nowadays bin/python usually points to python3, and this script is written in python2, which means if run directly from terminal it will fail with some print syntax errors. Change-Id: I6ab4e9edc44a8045915d4828c6de2fa98027fb7e ----------------------------------------------------------------------- Summary of changes: pySim-prog.py | 3 +-- pySim-read.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- A python tool to program magic SIMs From gitosis at osmocom.org Sun Dec 31 11:02:23 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 31 Dec 2017 11:02:23 GMT Subject: osmo-iuh.git branch master updated. 0.2.0-43-gbfeea67 Message-ID: <201712311102.vBVB2Nvg078022@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via bfeea6713b4e17fcd5cfb0a5b4c042eaf526ae22 (commit) via ef727410b28f1482a2a174cfbe943e6e98205bdb (commit) from 1e57ba503ed734b36094288ad2dbedbd11f39c57 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=bfeea6713b4e17fcd5cfb0a5b4c042eaf526ae22 commit bfeea6713b4e17fcd5cfb0a5b4c042eaf526ae22 Author: Max Date: Wed Dec 27 22:53:36 2017 +0100 Expand ctrl interface Add commands to get number of connected HNBs and identity string of connected HNB based on Cell ID. Change-Id: I3a2d6fa3d6d0829ccee4ecc0998d9299c97820e9 http://cgit.osmocom.org/osmo-iuh/commit/?id=ef727410b28f1482a2a174cfbe943e6e98205bdb commit ef727410b28f1482a2a174cfbe943e6e98205bdb Author: Max Date: Tue Dec 26 19:27:43 2017 +0100 Add control interface * add libosmoctrl dependency * bind control interface Change-Id: I4637e88da00bac1ab0237c29ac73806d024863ba ----------------------------------------------------------------------- Summary of changes: configure.ac | 1 + include/osmocom/iuh/hnbgw.h | 11 ++++- src/Makefile.am | 4 +- src/hnbgw.c | 100 +++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 111 insertions(+), 5 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface From gitosis at osmocom.org Sun Dec 31 11:06:28 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 31 Dec 2017 11:06:28 GMT Subject: gapk.git branch master updated. v0.4-4-g45d0fd6 Message-ID: <201712311106.vBVB6SIW079858@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, master has been updated via 45d0fd66c3aceebcd1dc30ae2cffb33f5c65fe8e (commit) from d5cfaa6a52d09551661f2cc8ef7ffc24f809960a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gapk/commit/?id=45d0fd66c3aceebcd1dc30ae2cffb33f5c65fe8e commit 45d0fd66c3aceebcd1dc30ae2cffb33f5c65fe8e Author: Max Date: Fri Dec 29 21:48:18 2017 +0100 Add git-review config Change-Id: Id4304dc8248087c23aaf3a5d205cd341ed6a758a ----------------------------------------------------------------------- Summary of changes: .gitreview | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .gitreview hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Sun Dec 31 11:19:53 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 31 Dec 2017 11:19:53 GMT Subject: gapk.git branch fixeria/lib created. v0.4-53-g3cf11d8 Message-ID: <201712311119.vBVBJrbF085730@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, fixeria/lib has been created at 3cf11d824385e06a96b318766d7e6708e49b3215 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gapk/commit/?id=3cf11d824385e06a96b318766d7e6708e49b3215 commit 3cf11d824385e06a96b318766d7e6708e49b3215 Author: Vadim Yanitskiy Date: Fri Sep 15 19:34:44 2017 +0430 tests: add format / codec transcoding tests This test group is intended to check the format / codec transcoding capabilities of the library. The reference files are used to ensure that encoding or decoding was successful. The following formats are currently being tested: - amr_efr - gsm - racal_hr - racal_fr - racal_efr - ti_hr - ti_fr - ti_efr - rtp_efr - rtp_hr_etsi - rtp_hr_ietf http://cgit.osmocom.org/gapk/commit/?id=f7d53964d372a64ccbad419cedf33c360442a28f commit f7d53964d372a64ccbad419cedf33c360442a28f Author: Vadim Yanitskiy Date: Fri Sep 15 19:17:21 2017 +0430 osmo-gapk: fix I/O count check condition The stdin / stdout operation was broken by a new check condition, introduced by the 15fa605576a81803c57a144231e9e9720aa133a1. http://cgit.osmocom.org/gapk/commit/?id=c24199263f070fe68b778cab82bb93327b0f07c1 commit c24199263f070fe68b778cab82bb93327b0f07c1 Author: Vadim Yanitskiy Date: Thu Sep 14 15:20:50 2017 +0430 tests: add pq_rtp test This test is intended to check the RTP source / sink operability. To do this, two processing queues are being allocated: "generator": source/random -> sink/rtp "checker": source/rtp -> sink/checker The first one generates some amount of random bytes (payload), and stores them inside a buffer that is shared between both queues. After generation, a payload is being sent from the first queue via an RTP sink, and then being received by the second via an RTP source. As both queues do use a shared buffer, the last item of the second queue (named 'sink/checker') is able to compare a received payload with expected. http://cgit.osmocom.org/gapk/commit/?id=8e3d622262859145d6e8bc8ab4083ef97728a8f2 commit 8e3d622262859145d6e8bc8ab4083ef97728a8f2 Author: Vadim Yanitskiy Date: Tue Sep 12 19:07:52 2017 +0300 tests: add pq_file test This test is intended to check the file source / sink operability. To do that, the following processing chain is being composed: source/file -> proc/dummy -> sink/file (stdout) The source item opens the sample file named 'io_sample.txt' for reading. The next processing item simply converts all uppercase latters to the lowercase. The last one writes the result to stdout. This processing cycle is being repeated several times with different block length values. http://cgit.osmocom.org/gapk/commit/?id=2f5c8ae7ec445a5c327a584bffc4b17b53d7f7c0 commit 2f5c8ae7ec445a5c327a584bffc4b17b53d7f7c0 Author: Vadim Yanitskiy Date: Tue Sep 12 15:32:52 2017 +0300 tests: add procqueue test This test is intended to validate the processing queue management API. Moreover, the talloc debugging API is used to ensure that there are no memory leaks. First, four processing queues are being allocated. One of them is empty, while others have different count of items. Then the human-readable description is being generated for all of them. And finally, the processing and exit cllback are being tested. During the test execution, the talloc NULL-context tracking feature is enabled, allowing to observe every memory allocation within the libosmogapk, and to detect memory leaks. http://cgit.osmocom.org/gapk/commit/?id=0f08d56e36bbd998a5bd10ec17f2001f03fb584c commit 0f08d56e36bbd998a5bd10ec17f2001f03fb584c Author: Vadim Yanitskiy Date: Tue Sep 12 15:26:31 2017 +0300 Init automake test environment http://cgit.osmocom.org/gapk/commit/?id=e8b882412b035637bec7edbd8b885c026e4f7040 commit e8b882412b035637bec7edbd8b885c026e4f7040 Author: Vadim Yanitskiy Date: Tue Sep 12 01:30:48 2017 +0300 procqueue: allocate an output buffer as named chunk The talloc_size() call sets the current file name and the current line number as name for chunk being allocated. This combination is not so informative during debugging, so let's use the static '.buffer' string as context name for item's output buffer. http://cgit.osmocom.org/gapk/commit/?id=b755032efda89dc2d16356dbaec3f9cdfded4354 commit b755032efda89dc2d16356dbaec3f9cdfded4354 Author: Vadim Yanitskiy Date: Tue Sep 12 01:17:26 2017 +0300 procqueue: set talloc name and context for queue description Previously a queue description string was allocated without setting proper parental talloc context and proper name. http://cgit.osmocom.org/gapk/commit/?id=46df43543a9ea12acd0d0bf88a6e50aad7f14201 commit 46df43543a9ea12acd0d0bf88a6e50aad7f14201 Author: Vadim Yanitskiy Date: Sun Sep 10 16:32:48 2017 +0300 src/libosmogapk.map: export osmo_gapk_* with a wilcard http://cgit.osmocom.org/gapk/commit/?id=bf64774bc79bd728e802d6366a95341ebe13fbca commit bf64774bc79bd728e802d6366a95341ebe13fbca Author: Vadim Yanitskiy Date: Sun Sep 10 16:27:04 2017 +0300 procqueue: use queue / item names in logging http://cgit.osmocom.org/gapk/commit/?id=f012219d97af791e800850b25237274851bdae0b commit f012219d97af791e800850b25237274851bdae0b Author: Vadim Yanitskiy Date: Sun Sep 10 16:00:43 2017 +0300 procqueue: separate queue check function In order to give advanced control over a processing queue, it would be better to have the checking function separated from the osmo_gapk_pq_prepare(). Moreover, this change introduces an additional 'strict' checking mode that requires a queue to have a source item first and a sink item in the last position. http://cgit.osmocom.org/gapk/commit/?id=f269356136d580d8175657cb68dc05a9c709f5a5 commit f269356136d580d8175657cb68dc05a9c709f5a5 Author: Vadim Yanitskiy Date: Sat Sep 9 21:44:16 2017 +0300 procqueue: add item catedory and sub-category fields This change adds two meta-information fields to the processing queue item structure. Both of them will be used for more detailed logging and for the human-readable processing queue description. http://cgit.osmocom.org/gapk/commit/?id=8bf80936be6daa963cc99f92b7318066fd9bc9eb commit 8bf80936be6daa963cc99f92b7318066fd9bc9eb Author: Vadim Yanitskiy Date: Sat Sep 9 20:57:13 2017 +0300 procqueue: add item type enum (source, sink, proc) There are currently three types of prcessing queue items: - source (file, alsa, rtp) - proc (format, codec) - sink (file, alsa, rtp) Let's assign corresponding type for each item. This would facilitate logging and the queue checking. http://cgit.osmocom.org/gapk/commit/?id=41d428bf6435e9aa12ba185acc7339985d6bd52c commit 41d428bf6435e9aa12ba185acc7339985d6bd52c Author: Vadim Yanitskiy Date: Sat Sep 9 20:43:28 2017 +0300 procqueue: add human-readable name to osmo_gapk_pq Since this change, every processing queue may optionally have an associated human-readable name. If name is not required, NULL should be passed to the osmo_gapk_pq_create(). http://cgit.osmocom.org/gapk/commit/?id=b846b9a8eda3ae9b16e6d1a26357d64337336745 commit b846b9a8eda3ae9b16e6d1a26357d64337336745 Author: Vadim Yanitskiy Date: Sat Sep 9 14:48:49 2017 +0300 libosmogapk: drop an 'osmo' prefix from internal log variables It would be better to have an 'osmo_gapk' prefix for exposed symbols only. Both internal logging variables aren't exposed, so they shouldn't have one. http://cgit.osmocom.org/gapk/commit/?id=080b912d99c92188fc7be75e3b24126da67d64dc commit 080b912d99c92188fc7be75e3b24126da67d64dc Author: Vadim Yanitskiy Date: Sat Sep 9 14:44:24 2017 +0300 osmo-gapk: use talloc for memory management http://cgit.osmocom.org/gapk/commit/?id=a2a6317a963e0e55b760368f51c66a8e667b92f0 commit a2a6317a963e0e55b760368f51c66a8e667b92f0 Author: Vadim Yanitskiy Date: Sat Sep 9 14:23:56 2017 +0300 libosmogapk: introduce the internal root talloc context In order to simplify memory leak debugging, this change introduces the library's internal talloc context that may be changed by external application by calling the osmo_gapk_set_talloc_ctx(). http://cgit.osmocom.org/gapk/commit/?id=4a77ee720a79e5e8f1e7b9e975d27c19c094b316 commit 4a77ee720a79e5e8f1e7b9e975d27c19c094b316 Author: Vadim Yanitskiy Date: Sat Sep 9 14:09:55 2017 +0300 libosmogapk: rename the 'logging.c' to 'common.c' There are not so much code, related to internal logging subsystem. So, there is no reason to keep a few lines in a dedicated file. In the future one may also be used for other routines. http://cgit.osmocom.org/gapk/commit/?id=7f1aa98a8f2da8dbe13507f763274b41824e477d commit 7f1aa98a8f2da8dbe13507f763274b41824e477d Author: Vadim Yanitskiy Date: Sat Sep 9 13:48:38 2017 +0300 libosmogapk: fix memory leak in both AMR and EFR codecs The memory, allocated by codec_efr_init() / codec_amr_init(), was not cleaned after calling the codec_exit(). Found using talloc memory debugging API. http://cgit.osmocom.org/gapk/commit/?id=17b5ba93109743664d17df7bd89e1f44544b3fa3 commit 17b5ba93109743664d17df7bd89e1f44544b3fa3 Author: Vadim Yanitskiy Date: Sat Sep 9 12:10:08 2017 +0300 libosmogapk: use talloc for memory management http://cgit.osmocom.org/gapk/commit/?id=15fa605576a81803c57a144231e9e9720aa133a1 commit 15fa605576a81803c57a144231e9e9720aa133a1 Author: Vadim Yanitskiy Date: Fri Sep 8 11:13:49 2017 +0300 osmo-gapk: fix I/O combinations check Previously both ALSA source and sink were out of attention. http://cgit.osmocom.org/gapk/commit/?id=a9f3a4fb5ac57fb50898eec8a61333bc034c087d commit a9f3a4fb5ac57fb50898eec8a61333bc034c087d Author: Vadim Yanitskiy Date: Fri Sep 8 10:55:05 2017 +0300 configure.ac: use actual bug report address in AC_INIT http://cgit.osmocom.org/gapk/commit/?id=27cc5fbbcb2b5649c9bca452e8a00335d9a278a7 commit 27cc5fbbcb2b5649c9bca452e8a00335d9a278a7 Author: Vadim Yanitskiy Date: Fri Sep 8 00:05:02 2017 +0300 osmo-gapk: wait until sink finish processing Previously the osmo-gapk application used to exit as soon as all the frames are processed, no matter has the sink finished its internal processing (e.g. ALSA playback). http://cgit.osmocom.org/gapk/commit/?id=01edb56d7bb082ecc187254c2f0a54178dd9ff3f commit 01edb56d7bb082ecc187254c2f0a54178dd9ff3f Author: Vadim Yanitskiy Date: Fri Sep 8 00:02:20 2017 +0300 src/pq_alsa.c: implement processing state callback Using the snd_pcm_avail_update() call from ALSA API it's possible to know, how much samples are still to be processed. http://cgit.osmocom.org/gapk/commit/?id=8923276018b9a8d5ebafa2e18676fe6b8cef26a4 commit 8923276018b9a8d5ebafa2e18676fe6b8cef26a4 Author: Vadim Yanitskiy Date: Thu Sep 7 18:42:49 2017 +0300 procqueue: add processing state callback In some cases it's required to wait for some queue items to finish processing. For example, the ALSA sink writes the audio samples to the buffer in non-blocking mode, so as soon as all of them will be written, a program may finish execution, causing the playback abort. To prevent that, this change extends the library's API, allowing each queue item to have a processing state callback that returns a positive integer if processing is not finished yet, and 0 otherwise. http://cgit.osmocom.org/gapk/commit/?id=3e8cfdea6a2e1da03b6601c96b87d2a5683c73c6 commit 3e8cfdea6a2e1da03b6601c96b87d2a5683c73c6 Author: Vadim Yanitskiy Date: Thu Sep 7 17:51:35 2017 +0300 osmo-gapk: abort the processing queue on SIGINT Instead of immediately shutting down the application, it is better to try to break the processing queue first, and stop the execution immediately if second SIGINT is received. http://cgit.osmocom.org/gapk/commit/?id=0d177795d1ffe70d926281034116d73199265202 commit 0d177795d1ffe70d926281034116d73199265202 Author: Vadim Yanitskiy Date: Thu Sep 7 17:39:24 2017 +0300 osmo-gapk: adjust application verbosity This change allows user to enable advanced verbosity using the '-v' command line option, which is disabled by default. http://cgit.osmocom.org/gapk/commit/?id=3d5a901ffe24ab38a2050afca7a146d840a1f303 commit 3d5a901ffe24ab38a2050afca7a146d840a1f303 Author: Vadim Yanitskiy Date: Thu Sep 7 17:10:14 2017 +0300 osmo-gapk: use Osmocom logging framework http://cgit.osmocom.org/gapk/commit/?id=caeee8214084f8949e855780ce1cbfd42a514e78 commit caeee8214084f8949e855780ce1cbfd42a514e78 Author: Vadim Yanitskiy Date: Thu Sep 7 16:48:27 2017 +0300 osmo-gapk: drop useless printf calls The printf() writes the text into stdout, which may be undesirable in some use cases. Moreover, the printed information was redundant. So, let's drop such calls. http://cgit.osmocom.org/gapk/commit/?id=1e220b9f3c2a0d9a1a6ea39d0972a207a51168bd commit 1e220b9f3c2a0d9a1a6ea39d0972a207a51168bd Author: Vadim Yanitskiy Date: Thu Sep 7 16:36:56 2017 +0300 libosmogapk: use Osmocom logging framework Since this change, the libosmogapk uses the Osmocom logging framework. By default, logging is disabled and could be enabled by the external applications calling the osmo_gapk_log_init() with a desired log target as an argument. http://cgit.osmocom.org/gapk/commit/?id=d02ada5c46a8938f5d9fd09e255dc6501937785d commit d02ada5c46a8938f5d9fd09e255dc6501937785d Author: Vadim Yanitskiy Date: Thu Sep 7 00:04:01 2017 +0300 osmo-gapk: use more convenient name for the source file Since GAPK package contains a library and the representative osmo-gapk application, the 'main.c' looks a bit confusing. Let's use the common naming scheme. http://cgit.osmocom.org/gapk/commit/?id=d8bdf47aaffb768c26b89511d1af7bce616543d2 commit d8bdf47aaffb768c26b89511d1af7bce616543d2 Author: Vadim Yanitskiy Date: Wed Sep 6 23:53:30 2017 +0300 osmo-gapk: create a common shutdown function Previously the code intended to shutdown the osmo-gapk application was repeated two times. It's better to have a single function. http://cgit.osmocom.org/gapk/commit/?id=6e0fe0e103612e01817dba857f5077adeb87ea84 commit 6e0fe0e103612e01817dba857f5077adeb87ea84 Author: Vadim Yanitskiy Date: Wed Sep 6 23:42:19 2017 +0300 osmo-gapk: add an option to enable / disable benchmark If the codec benchmarking is required in particular case, it could be activated by a special command line option introduced by this change. http://cgit.osmocom.org/gapk/commit/?id=a3b4fb8be1bb9316443dedab0dcf9079328f13a6 commit a3b4fb8be1bb9316443dedab0dcf9079328f13a6 Author: Vadim Yanitskiy Date: Fri Sep 1 16:19:40 2017 +0700 procqueue: use linuxlist to store queue items The usage of linuxlist is more flexible than having a limited array of pointers. This approach allows to have as much items in a processing queue as required. http://cgit.osmocom.org/gapk/commit/?id=cd2da365a81999db5a092b6bfb984d57b471883e commit cd2da365a81999db5a092b6bfb984d57b471883e Author: Vadim Yanitskiy Date: Fri Sep 1 15:22:32 2017 +0700 procqueue: use uint8_t as output buffer type http://cgit.osmocom.org/gapk/commit/?id=903f14cdf48faa61996b22b68361c511c920b3b9 commit 903f14cdf48faa61996b22b68361c511c920b3b9 Author: Vadim Yanitskiy Date: Fri Sep 1 15:15:45 2017 +0700 procqueue: store output buffers inside queue items An output buffer belongs to its queue item, so it will be more correctly to store its pointer inside the osmo_gapk_pq_item. http://cgit.osmocom.org/gapk/commit/?id=0d97f46b8757e0947304d88777706bd9a98a4c69 commit 0d97f46b8757e0947304d88777706bd9a98a4c69 Author: Vadim Yanitskiy Date: Fri Sep 1 14:33:19 2017 +0700 procqueue: use unsigned int for I/O frame size fields A frame size cannot be negative, so 'unsigned' is more suitable for frame size fields. http://cgit.osmocom.org/gapk/commit/?id=6683ef0a17dda6eb50aaeede8805936c751ec4a5 commit 6683ef0a17dda6eb50aaeede8805936c751ec4a5 Author: Vadim Yanitskiy Date: Thu Aug 31 17:49:36 2017 +0700 Add the symbol export map for libosmogapk http://cgit.osmocom.org/gapk/commit/?id=f72d01558f16717d49380428310d1a269f8540c6 commit f72d01558f16717d49380428310d1a269f8540c6 Author: Vadim Yanitskiy Date: Mon Sep 4 04:18:06 2017 +0700 benchmark: add functions to get cycle and frame count To simplify the benchrarking process via the library API, this change introduces two new functions, which are intended to provide total cycle and frame count. http://cgit.osmocom.org/gapk/commit/?id=ea53827e34b3d223c053289f7ef39f3105712a18 commit ea53827e34b3d223c053289f7ef39f3105712a18 Author: Vadim Yanitskiy Date: Mon Sep 4 03:33:48 2017 +0700 benchmark: allocate memory dynamically Having statically allocated memory for benchmark data of every codec causes high memory usage, especially if actual benchmarking is not required for a particular use case. Instead of that, let's provide an optional opportunity to enable benchmarking for a particular codec by calling the osmo_gapk_bench_enable(). The required amount of memory would be allocated, and then can be freed by calling the osmo_gapk_bench_free() or manually. http://cgit.osmocom.org/gapk/commit/?id=36e92c49c510711bd7e88beb2935a2a298def9fe commit 36e92c49c510711bd7e88beb2935a2a298def9fe Author: Vadim Yanitskiy Date: Mon Sep 4 03:03:32 2017 +0700 benchmark: get rid of 'static inline' definition The usage of a 'static inline' function definition in the 'bench.h' is resulting in separate independent function definitions in each translation unit from which the header is included. This is increasing the size of compiled code unnecessarily. http://cgit.osmocom.org/gapk/commit/?id=43f74129c6ed128de8235aed1ce7d0f285193206 commit 43f74129c6ed128de8235aed1ce7d0f285193206 Author: Vadim Yanitskiy Date: Mon Sep 4 02:23:18 2017 +0700 benchmark: move benchmark impl to a private header There is no need to expose the implementation details of both BENCHMARK_START and BENCHMARK_STOP macros via public header. This change moves them to a separate private header 'bench.h'. http://cgit.osmocom.org/gapk/commit/?id=f4650d455bde1cd7a489123db3ebfbf2dc860b8e commit f4650d455bde1cd7a489123db3ebfbf2dc860b8e Author: Vadim Yanitskiy Date: Mon Sep 4 00:42:38 2017 +0700 benchmark: move benchmark_dump() outside the library The benchmark_dump() is only used by the osmo-gapk binary, and is intended to prepare and print benchmarking results to stderr, what is most likely unusable for the library users. http://cgit.osmocom.org/gapk/commit/?id=6028be8e8655d8eabc1929ff0753114814f5dacd commit 6028be8e8655d8eabc1929ff0753114814f5dacd Author: Vadim Yanitskiy Date: Thu Aug 31 17:22:56 2017 +0700 Add an 'osmo_gapk' prefix to the exposed symbols To avoid a naming conflict between libosmogapk and other projects during linkage, all the exposed symbols should have an unique prefix. Let's use 'osmo_gapk' for that. http://cgit.osmocom.org/gapk/commit/?id=4922c8376713196d909cb7b6d204cb10664116c2 commit 4922c8376713196d909cb7b6d204cb10664116c2 Author: Vadim Yanitskiy Date: Thu Aug 31 02:31:18 2017 +0700 procqueue: expose the processing queue struct definition To be able to use processing queues from outside, the pq struct should be shared in the corresponding header file. http://cgit.osmocom.org/gapk/commit/?id=617daf02012a4e4d1a104d52f2517ad81b72dd54 commit 617daf02012a4e4d1a104d52f2517ad81b72dd54 Author: Vadim Yanitskiy Date: Thu Aug 31 01:41:26 2017 +0700 Add a pkg-config manifest for libosmogapk In order to make pkg-config 'see' the libosmogapk, a corresponding package description is required. For more details, see: https://autotools.io/pkgconfig/file-format.html http://cgit.osmocom.org/gapk/commit/?id=e7959b00f6f21f371b24cd1960b36aacd34bdeb7 commit e7959b00f6f21f371b24cd1960b36aacd34bdeb7 Author: Vadim Yanitskiy Date: Thu Aug 31 01:20:18 2017 +0700 Use '#pragma once' instead of include guard The most compilers today do support the '#pragma once', which is designed to cause the current source file to be included only once in a single compilation. One has several advantages, including: less code, avoidance of name clashes, and sometimes improvement in compilation speed. See: https://en.wikipedia.org/wiki/Pragma_once for details. http://cgit.osmocom.org/gapk/commit/?id=e6986f70c5f609692c7067a758233e2d8327de6b commit e6986f70c5f609692c7067a758233e2d8327de6b Author: Vadim Yanitskiy Date: Wed Aug 30 20:26:02 2017 +0700 Install GAPK headers to '${includedir}/osmocom/gapk/' To be able to use the library, external applications need to know, which symbols are exposed. This information is provided by header files, which are being installed to a system's ${includedir} since this change. http://cgit.osmocom.org/gapk/commit/?id=a03ac4573a2c00a6b2937c42503b6c7206480662 commit a03ac4573a2c00a6b2937c42503b6c7206480662 Author: Vadim Yanitskiy Date: Wed Aug 30 19:35:51 2017 +0700 Add an 'osmo' prefix to the 'gapk' binary This is a common practice of all Osmocom executables to have an 'osmo' prefix. Let's follow this here too. http://cgit.osmocom.org/gapk/commit/?id=5fb1965cacb7a3aaf269dbb8e0238721a7d44c05 commit 5fb1965cacb7a3aaf269dbb8e0238721a7d44c05 Author: Vadim Yanitskiy Date: Wed Aug 30 19:03:49 2017 +0700 Introduce a shared 'libosmogapk' library The previous GAPK implementation was represented as a single executable. So, all audio transcoding operations were available only by calling the 'gapk' binary. This approach didn't allow external applications to benefit from using GAPK API directly. Since there are some projects (such as GR-GSM and OsmocomBB), which are potential users of GAPK code base, it would be better to have all transcoding functions within a shared library. So, this change separates the common code into a shared library, named 'libosmogapk', and links the 'gapk' binary against one. Currently there are no shared headers, pkg-config manifest and the export map, but they will be done latter. ----------------------------------------------------------------------- hooks/post-receive -- GSM Audio Pocket Knife From gitosis at osmocom.org Sun Dec 31 11:23:36 2017 From: gitosis at osmocom.org (gitosis at osmocom.org) Date: Sun, 31 Dec 2017 11:23:36 GMT Subject: gapk.git branch fixeria/lib updated. v0.4-54-gf59f3f1 Message-ID: <201712311123.vBVBNagr087766@git.osmocom.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GSM Audio Pocket Knife". The branch, fixeria/lib has been updated discards 3cf11d824385e06a96b318766d7e6708e49b3215 (commit) discards f7d53964d372a64ccbad419cedf33c360442a28f (commit) discards c24199263f070fe68b778cab82bb93327b0f07c1 (commit) discards 8e3d622262859145d6e8bc8ab4083ef97728a8f2 (commit) discards 2f5c8ae7ec445a5c327a584bffc4b17b53d7f7c0 (commit) discards 0f08d56e36bbd998a5bd10ec17f2001f03fb584c (commit) discards e8b882412b035637bec7edbd8b885c026e4f7040 (commit) discards b755032efda89dc2d16356dbaec3f9cdfded4354 (commit) discards 46df43543a9ea12acd0d0bf88a6e50aad7f14201 (commit) discards bf64774bc79bd728e802d6366a95341ebe13fbca (commit) discards f012219d97af791e800850b25237274851bdae0b (commit) discards f269356136d580d8175657cb68dc05a9c709f5a5 (commit) discards 8bf80936be6daa963cc99f92b7318066fd9bc9eb (commit) discards 41d428bf6435e9aa12ba185acc7339985d6bd52c (commit) discards b846b9a8eda3ae9b16e6d1a26357d64337336745 (commit) discards 080b912d99c92188fc7be75e3b24126da67d64dc (commit) discards a2a6317a963e0e55b760368f51c66a8e667b92f0 (commit) discards 4a77ee720a79e5e8f1e7b9e975d27c19c094b316 (commit) discards 7f1aa98a8f2da8dbe13507f763274b41824e477d (commit) discards 17b5ba93109743664d17df7bd89e1f44544b3fa3 (commit) discards 15fa605576a81803c57a144231e9e9720aa133a1 (commit) discards a9f3a4fb5ac57fb50898eec8a61333bc034c087d (commit) discards 27cc5fbbcb2b5649c9bca452e8a00335d9a278a7 (commit) discards 01edb56d7bb082ecc187254c2f0a54178dd9ff3f (commit) discards 8923276018b9a8d5ebafa2e18676fe6b8cef26a4 (commit) discards 3e8cfdea6a2e1da03b6601c96b87d2a5683c73c6 (commit) discards 0d177795d1ffe70d926281034116d73199265202 (commit) discards 3d5a901ffe24ab38a2050afca7a146d840a1f303 (commit) discards caeee8214084f8949e855780ce1cbfd42a514e78 (commit) discards 1e220b9f3c2a0d9a1a6ea39d0972a207a51168bd (commit) discards d02ada5c46a8938f5d9fd09e255dc6501937785d (commit) discards d8bdf47aaffb768c26b89511d1af7bce616543d2 (commit) discards 6e0fe0e103612e01817dba857f5077adeb87ea84 (commit) discards a3b4fb8be1bb9316443dedab0dcf9079328f13a6 (commit) discards cd2da365a81999db5a092b6bfb984d57b471883e (commit) discards 903f14cdf48faa61996b22b68361c511c920b3b9 (commit) discards 0d97f46b8757e0947304d88777706bd9a98a4c69 (commit) discards 6683ef0a17dda6eb50aaeede8805936c751ec4a5 (commit) discards f72d01558f16717d49380428310d1a269f8540c6 (commit) discards ea53827e34b3d223c053289f7ef39f3105712a18 (commit) discards 36e92c49c510711bd7e88beb2935a2a298def9fe (commit) discards 43f74129c6ed128de8235aed1ce7d0f285193206 (commit) discards f4650d455bde1cd7a489123db3ebfbf2dc860b8e (commit) discards 6028be8e8655d8eabc1929ff0753114814f5dacd (commit) discards 4922c8376713196d909cb7b6d204cb10664116c2 (commit) discards 617daf02012a4e4d1a104d52f2517ad81b72dd54 (commit) discards e7959b00f6f21f371b24cd1960b36aacd34bdeb7 (commit) discards e6986f70c5f609692c7067a758233e2d8327de6b (commit) discards a03ac4573a2c00a6b2937c42503b6c7206480662 (commit) discards 5fb1965cacb7a3aaf269dbb8e0238721a7d44c05 (commit) via f59f3f1ba8bc1cdf7c406867e3611f810ddc28c7 (commit) via 10076f0acce2274fdb363cd69ee83becdef6d6c8 (commit) via 9d2b15dc8a97ceefc5cd2e95a885bd306ec992be (commit) via 3e9e57fb400218a74c44f9e3ffb70cf5291410a4 (commit) via 1fe6a9b9ed92da4845f8c8cef10372a3e711a8ca (commit) via f069eb37fe48df4e6897d0614e008b676e06db8e (commit) via f496a998e520c3ab99d09cf279e64b0b9e52318e (commit) via fb2326fbcf12abc47e3f24f6c2051e71d013705e (commit) via 7279d9f05777855a0dc2873038bdb13557d174a3 (commit) via 9e7e88927851fd6b2fa42d0a187bd7e65ccaccf1 (commit) via 3839a88ea681024752048c902b23144c42f4fa42 (commit) via 459791c488c6b66a5cd0d7cff9392a7a0b8ca733 (commit) via 408be3638b3cd84462632ae8fe0b92e93064ca57 (commit) via 2286a36ace915864bce935f49374f12cb9384e5d (commit) via 262ae0f98f21e91ff21f2082892f75a778d077a5 (commit) via 5cabe1eeec55421954c052951a3dba00018af7cf (commit) via f23b74736458d2415dd1dfec0559af44e6353574 (commit) via 750c896b4a9e619bbc6f712f82b8d602a1750f96 (commit) via 14637746d3f5a45fba4987d9892c50ca07434fd6 (commit) via 3c20dac38c774afe2dfb769451a1d987c21f9c65 (commit) via a4d88ae13bc60e3f6269334d633495668af0c640 (commit) via 6831ebd958d2d1a66689e8adf9fc6f1d753c1544 (commit) via 01f5c5bebf4b1a8415a9837a42b018b3c1932d0b (commit) via a183ced71eb78c27123d29ea3e9bbc646bcd4fdc (commit) via 1f6f807bb35228f7d6f50cf61283b9ceb8f46eee (commit) via b40a54dc97e28e31e4a9be8a3aa634eaafb219d5 (commit) via 11943bf320ca5ed3e9efd099d27c3ed3b3631832 (commit) via 0fe18af82d1bb1672ccec49f7b75a4c710d48d42 (commit) via 4b7cd2c6772a43b3057368ca452be65691826aa5 (commit) via c35ba8a725405f7712618871c56a3b7fb3933e2a (commit) via f8d91a07b45a618fd25c9d6edcf28218642044c9 (commit) via 4ffd6f20a9b7604308506d9e04ef1bb2e41cd282 (commit) via 5716ca636d8638060e525f428a497ddee18b4072 (commit) via 539af39e29726fc196e874b5d9cd6ec619dc5f3c (commit) via 1cf7f34444b3d8b44122a57d2bed7542b8c3b7f2 (commit) via 304fa73421a7c6ca5dcf36145f40c77af7df1de7 (commit) via 3be9c7ae3c22f3e91c4e54b57a07b722dd4fb73f (commit) via 4f0a47d0e35ece9ca46bb62294357d89920d06aa (commit) via cda8995ac8a17cc1d579f73519fd5b0f2429675a (commit) via 72218e7da04783222f04492d939268ac40585027 (commit) via c9a75e59c67d62bc9d64c8c110ef47feb60e7ebf (commit) via ba46856bb403a507977e4c699c90714c962463f9 (commit) via 349219c14875705b8142d599f6af153d22a9a00e (commit) via a8d46571cebb7f14501fa7bcf3c2eb86c473d8b2 (commit) via 9cba760ba2ca5fd73e34f91bf388fc255dbcd335 (commit) via 40d59f14a240e943205fafe7d2449b286d3b4913 (commit) via 5f941573b0040c1b27014b4756155c86fe896b9f (commit) via 30209cedddb3b6ece5614b40f65f6a04e84388b4 (commit) via 48206ad2e07216e01c9870b606aee442b3d7ec0e (commit) via 95e666404e1e31dfb95d7dc8b00c1b0be88659b3 (commit) via 45d0fd66c3aceebcd1dc30ae2cffb33f5c65fe8e (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (3cf11d824385e06a96b318766d7e6708e49b3215) \ N -- N -- N (f59f3f1ba8bc1cdf7c406867e3611f810ddc28c7) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/gapk/commit/?id=f59f3f1ba8bc1cdf7c406867e3611f810ddc28c7 commit f59f3f1ba8bc1cdf7c406867e3611f810ddc28c7 Author: Vadim Yanitskiy Date: Fri Sep 15 19:34:44 2017 +0430 tests: add format / codec transcoding tests This test group is intended to check the format / codec transcoding capabilities of the library. The reference files are used to ensure that encoding or decoding was successful. The following formats are currently being tested: - amr_efr - gsm - racal_hr - racal_fr - racal_efr - ti_hr - ti_fr - ti_efr - rtp_efr - rtp_hr_etsi - rtp_hr_ietf http://cgit.osmocom.org/gapk/commit/?id=10076f0acce2274fdb363cd69ee83becdef6d6c8 commit 10076f0acce2274fdb363cd69ee83becdef6d6c8 Author: Vadim Yanitskiy Date: Fri Sep 15 19:17:21 2017 +0430 osmo-gapk: fix I/O count check condition The stdin / stdout operation was broken by a new check condition, introduced by the 15fa605576a81803c57a144231e9e9720aa133a1. http://cgit.osmocom.org/gapk/commit/?id=9d2b15dc8a97ceefc5cd2e95a885bd306ec992be commit 9d2b15dc8a97ceefc5cd2e95a885bd306ec992be Author: Vadim Yanitskiy Date: Thu Sep 14 15:20:50 2017 +0430 tests: add pq_rtp test This test is intended to check the RTP source / sink operability. To do this, two processing queues are being allocated: "generator": source/random -> sink/rtp "checker": source/rtp -> sink/checker The first one generates some amount of random bytes (payload), and stores them inside a buffer that is shared between both queues. After generation, a payload is being sent from the first queue via an RTP sink, and then being received by the second via an RTP source. As both queues do use a shared buffer, the last item of the second queue (named 'sink/checker') is able to compare a received payload with expected. http://cgit.osmocom.org/gapk/commit/?id=3e9e57fb400218a74c44f9e3ffb70cf5291410a4 commit 3e9e57fb400218a74c44f9e3ffb70cf5291410a4 Author: Vadim Yanitskiy Date: Tue Sep 12 19:07:52 2017 +0300 tests: add pq_file test This test is intended to check the file source / sink operability. To do that, the following processing chain is being composed: source/file -> proc/dummy -> sink/file (stdout) The source item opens the sample file named 'io_sample.txt' for reading. The next processing item simply converts all uppercase latters to the lowercase. The last one writes the result to stdout. This processing cycle is being repeated several times with different block length values. http://cgit.osmocom.org/gapk/commit/?id=1fe6a9b9ed92da4845f8c8cef10372a3e711a8ca commit 1fe6a9b9ed92da4845f8c8cef10372a3e711a8ca Author: Vadim Yanitskiy Date: Tue Sep 12 15:32:52 2017 +0300 tests: add procqueue test This test is intended to validate the processing queue management API. Moreover, the talloc debugging API is used to ensure that there are no memory leaks. First, four processing queues are being allocated. One of them is empty, while others have different count of items. Then the human-readable description is being generated for all of them. And finally, the processing and exit cllback are being tested. During the test execution, the talloc NULL-context tracking feature is enabled, allowing to observe every memory allocation within the libosmogapk, and to detect memory leaks. http://cgit.osmocom.org/gapk/commit/?id=f069eb37fe48df4e6897d0614e008b676e06db8e commit f069eb37fe48df4e6897d0614e008b676e06db8e Author: Vadim Yanitskiy Date: Tue Sep 12 15:26:31 2017 +0300 Init automake test environment http://cgit.osmocom.org/gapk/commit/?id=f496a998e520c3ab99d09cf279e64b0b9e52318e commit f496a998e520c3ab99d09cf279e64b0b9e52318e Author: Vadim Yanitskiy Date: Tue Sep 12 01:30:48 2017 +0300 procqueue: allocate an output buffer as named chunk The talloc_size() call sets the current file name and the current line number as name for chunk being allocated. This combination is not so informative during debugging, so let's use the static '.buffer' string as context name for item's output buffer. http://cgit.osmocom.org/gapk/commit/?id=fb2326fbcf12abc47e3f24f6c2051e71d013705e commit fb2326fbcf12abc47e3f24f6c2051e71d013705e Author: Vadim Yanitskiy Date: Tue Sep 12 01:17:26 2017 +0300 procqueue: set talloc name and context for queue description Previously a queue description string was allocated without setting proper parental talloc context and proper name. http://cgit.osmocom.org/gapk/commit/?id=7279d9f05777855a0dc2873038bdb13557d174a3 commit 7279d9f05777855a0dc2873038bdb13557d174a3 Author: Vadim Yanitskiy Date: Sun Sep 10 16:32:48 2017 +0300 src/libosmogapk.map: export osmo_gapk_* with a wilcard http://cgit.osmocom.org/gapk/commit/?id=9e7e88927851fd6b2fa42d0a187bd7e65ccaccf1 commit 9e7e88927851fd6b2fa42d0a187bd7e65ccaccf1 Author: Vadim Yanitskiy Date: Sun Sep 10 16:27:04 2017 +0300 procqueue: use queue / item names in logging http://cgit.osmocom.org/gapk/commit/?id=3839a88ea681024752048c902b23144c42f4fa42 commit 3839a88ea681024752048c902b23144c42f4fa42 Author: Vadim Yanitskiy Date: Sun Sep 10 16:00:43 2017 +0300 procqueue: separate queue check function In order to give advanced control over a processing queue, it would be better to have the checking function separated from the osmo_gapk_pq_prepare(). Moreover, this change introduces an additional 'strict' checking mode that requires a queue to have a source item first and a sink item in the last position. http://cgit.osmocom.org/gapk/commit/?id=459791c488c6b66a5cd0d7cff9392a7a0b8ca733 commit 459791c488c6b66a5cd0d7cff9392a7a0b8ca733 Author: Vadim Yanitskiy Date: Sat Sep 9 21:44:16 2017 +0300 procqueue: add item catedory and sub-category fields This change adds two meta-information fields to the processing queue item structure. Both of them will be used for more detailed logging and for the human-readable processing queue description. http://cgit.osmocom.org/gapk/commit/?id=408be3638b3cd84462632ae8fe0b92e93064ca57 commit 408be3638b3cd84462632ae8fe0b92e93064ca57 Author: Vadim Yanitskiy Date: Sat Sep 9 20:57:13 2017 +0300 procqueue: add item type enum (source, sink, proc) There are currently three types of prcessing queue items: - source (file, alsa, rtp) - proc (format, codec) - sink (file, alsa, rtp) Let's assign corresponding type for each item. This would facilitate logging and the queue checking. http://cgit.osmocom.org/gapk/commit/?id=2286a36ace915864bce935f49374f12cb9384e5d commit 2286a36ace915864bce935f49374f12cb9384e5d Author: Vadim Yanitskiy Date: Sat Sep 9 20:43:28 2017 +0300 procqueue: add human-readable name to osmo_gapk_pq Since this change, every processing queue may optionally have an associated human-readable name. If name is not required, NULL should be passed to the osmo_gapk_pq_create(). http://cgit.osmocom.org/gapk/commit/?id=262ae0f98f21e91ff21f2082892f75a778d077a5 commit 262ae0f98f21e91ff21f2082892f75a778d077a5 Author: Vadim Yanitskiy Date: Sat Sep 9 14:48:49 2017 +0300 libosmogapk: drop an 'osmo' prefix from internal log variables It would be better to have an 'osmo_gapk' prefix for exposed symbols only. Both internal logging variables aren't exposed, so they shouldn't have one. http://cgit.osmocom.org/gapk/commit/?id=5cabe1eeec55421954c052951a3dba00018af7cf commit 5cabe1eeec55421954c052951a3dba00018af7cf Author: Vadim Yanitskiy Date: Sat Sep 9 14:44:24 2017 +0300 osmo-gapk: use talloc for memory management http://cgit.osmocom.org/gapk/commit/?id=f23b74736458d2415dd1dfec0559af44e6353574 commit f23b74736458d2415dd1dfec0559af44e6353574 Author: Vadim Yanitskiy Date: Sat Sep 9 14:23:56 2017 +0300 libosmogapk: introduce the internal root talloc context In order to simplify memory leak debugging, this change introduces the library's internal talloc context that may be changed by external application by calling the osmo_gapk_set_talloc_ctx(). http://cgit.osmocom.org/gapk/commit/?id=750c896b4a9e619bbc6f712f82b8d602a1750f96 commit 750c896b4a9e619bbc6f712f82b8d602a1750f96 Author: Vadim Yanitskiy Date: Sat Sep 9 14:09:55 2017 +0300 libosmogapk: rename the 'logging.c' to 'common.c' There are not so much code, related to internal logging subsystem. So, there is no reason to keep a few lines in a dedicated file. In the future one may also be used for other routines. http://cgit.osmocom.org/gapk/commit/?id=14637746d3f5a45fba4987d9892c50ca07434fd6 commit 14637746d3f5a45fba4987d9892c50ca07434fd6 Author: Vadim Yanitskiy Date: Sat Sep 9 13:48:38 2017 +0300 libosmogapk: fix memory leak in both AMR and EFR codecs The memory, allocated by codec_efr_init() / codec_amr_init(), was not cleaned after calling the codec_exit(). Found using talloc memory debugging API. http://cgit.osmocom.org/gapk/commit/?id=3c20dac38c774afe2dfb769451a1d987c21f9c65 commit 3c20dac38c774afe2dfb769451a1d987c21f9c65 Author: Vadim Yanitskiy Date: Sat Sep 9 12:10:08 2017 +0300 libosmogapk: use talloc for memory management http://cgit.osmocom.org/gapk/commit/?id=a4d88ae13bc60e3f6269334d633495668af0c640 commit a4d88ae13bc60e3f6269334d633495668af0c640 Author: Vadim Yanitskiy Date: Fri Sep 8 11:13:49 2017 +0300 osmo-gapk: fix I/O combinations check Previously both ALSA source and sink were out of attention. http://cgit.osmocom.org/gapk/commit/?id=6831ebd958d2d1a66689e8adf9fc6f1d753c1544 commit 6831ebd958d2d1a66689e8adf9fc6f1d753c1544 Author: Vadim Yanitskiy Date: Fri Sep 8 10:55:05 2017 +0300 configure.ac: use actual bug report address in AC_INIT http://cgit.osmocom.org/gapk/commit/?id=01f5c5bebf4b1a8415a9837a42b018b3c1932d0b commit 01f5c5bebf4b1a8415a9837a42b018b3c1932d0b Author: Vadim Yanitskiy Date: Fri Sep 8 00:05:02 2017 +0300 osmo-gapk: wait until sink finish processing Previously the osmo-gapk application used to exit as soon as all the frames are processed, no matter has the sink finished its internal processing (e.g. ALSA playback). http://cgit.osmocom.org/gapk/commit/?id=a183ced71eb78c27123d29ea3e9bbc646bcd4fdc commit a183ced71eb78c27123d29ea3e9bbc646bcd4fdc Author: Vadim Yanitskiy Date: Fri Sep 8 00:02:20 2017 +0300 src/pq_alsa.c: implement processing state callback Using the snd_pcm_avail_update() call from ALSA API it's possible to know, how much samples are still to be processed. http://cgit.osmocom.org/gapk/commit/?id=1f6f807bb35228f7d6f50cf61283b9ceb8f46eee commit 1f6f807bb35228f7d6f50cf61283b9ceb8f46eee Author: Vadim Yanitskiy Date: Thu Sep 7 18:42:49 2017 +0300 procqueue: add processing state callback In some cases it's required to wait for some queue items to finish processing. For example, the ALSA sink writes the audio samples to the buffer in non-blocking mode, so as soon as all of them will be written, a program may finish execution, causing the playback abort. To prevent that, this change extends the library's API, allowing each queue item to have a processing state callback that returns a positive integer if processing is not finished yet, and 0 otherwise. http://cgit.osmocom.org/gapk/commit/?id=b40a54dc97e28e31e4a9be8a3aa634eaafb219d5 commit b40a54dc97e28e31e4a9be8a3aa634eaafb219d5 Author: Vadim Yanitskiy Date: Thu Sep 7 17:51:35 2017 +0300 osmo-gapk: abort the processing queue on SIGINT Instead of immediately shutting down the application, it is better to try to break the processing queue first, and stop the execution immediately if second SIGINT is received. http://cgit.osmocom.org/gapk/commit/?id=11943bf320ca5ed3e9efd099d27c3ed3b3631832 commit 11943bf320ca5ed3e9efd099d27c3ed3b3631832 Author: Vadim Yanitskiy Date: Thu Sep 7 17:39:24 2017 +0300 osmo-gapk: adjust application verbosity This change allows user to enable advanced verbosity using the '-v' command line option, which is disabled by default. http://cgit.osmocom.org/gapk/commit/?id=0fe18af82d1bb1672ccec49f7b75a4c710d48d42 commit 0fe18af82d1bb1672ccec49f7b75a4c710d48d42 Author: Vadim Yanitskiy Date: Thu Sep 7 17:10:14 2017 +0300 osmo-gapk: use Osmocom logging framework http://cgit.osmocom.org/gapk/commit/?id=4b7cd2c6772a43b3057368ca452be65691826aa5 commit 4b7cd2c6772a43b3057368ca452be65691826aa5 Author: Vadim Yanitskiy Date: Thu Sep 7 16:48:27 2017 +0300 osmo-gapk: drop useless printf calls The printf() writes the text into stdout, which may be undesirable in some use cases. Moreover, the printed information was redundant. So, let's drop such calls. http://cgit.osmocom.org/gapk/commit/?id=c35ba8a725405f7712618871c56a3b7fb3933e2a commit c35ba8a725405f7712618871c56a3b7fb3933e2a Author: Vadim Yanitskiy Date: Thu Sep 7 16:36:56 2017 +0300 libosmogapk: use Osmocom logging framework Since this change, the libosmogapk uses the Osmocom logging framework. By default, logging is disabled and could be enabled by the external applications calling the osmo_gapk_log_init() with a desired log target as an argument. http://cgit.osmocom.org/gapk/commit/?id=f8d91a07b45a618fd25c9d6edcf28218642044c9 commit f8d91a07b45a618fd25c9d6edcf28218642044c9 Author: Vadim Yanitskiy Date: Thu Sep 7 00:04:01 2017 +0300 osmo-gapk: use more convenient name for the source file Since GAPK package contains a library and the representative osmo-gapk application, the 'main.c' looks a bit confusing. Let's use the common naming scheme. http://cgit.osmocom.org/gapk/commit/?id=4ffd6f20a9b7604308506d9e04ef1bb2e41cd282 commit 4ffd6f20a9b7604308506d9e04ef1bb2e41cd282 Author: Vadim Yanitskiy Date: Wed Sep 6 23:53:30 2017 +0300 osmo-gapk: create a common shutdown function Previously the code intended to shutdown the osmo-gapk application was repeated two times. It's better to have a single function. http://cgit.osmocom.org/gapk/commit/?id=5716ca636d8638060e525f428a497ddee18b4072 commit 5716ca636d8638060e525f428a497ddee18b4072 Author: Vadim Yanitskiy Date: Wed Sep 6 23:42:19 2017 +0300 osmo-gapk: add an option to enable / disable benchmark If the codec benchmarking is required in particular case, it could be activated by a special command line option introduced by this change. http://cgit.osmocom.org/gapk/commit/?id=539af39e29726fc196e874b5d9cd6ec619dc5f3c commit 539af39e29726fc196e874b5d9cd6ec619dc5f3c Author: Vadim Yanitskiy Date: Fri Sep 1 16:19:40 2017 +0700 procqueue: use linuxlist to store queue items The usage of linuxlist is more flexible than having a limited array of pointers. This approach allows to have as much items in a processing queue as required. http://cgit.osmocom.org/gapk/commit/?id=1cf7f34444b3d8b44122a57d2bed7542b8c3b7f2 commit 1cf7f34444b3d8b44122a57d2bed7542b8c3b7f2 Author: Vadim Yanitskiy Date: Fri Sep 1 15:22:32 2017 +0700 procqueue: use uint8_t as output buffer type http://cgit.osmocom.org/gapk/commit/?id=304fa73421a7c6ca5dcf36145f40c77af7df1de7 commit 304fa73421a7c6ca5dcf36145f40c77af7df1de7 Author: Vadim Yanitskiy Date: Fri Sep 1 15:15:45 2017 +0700 procqueue: store output buffers inside queue items An output buffer belongs to its queue item, so it will be more correctly to store its pointer inside the osmo_gapk_pq_item. http://cgit.osmocom.org/gapk/commit/?id=3be9c7ae3c22f3e91c4e54b57a07b722dd4fb73f commit 3be9c7ae3c22f3e91c4e54b57a07b722dd4fb73f Author: Vadim Yanitskiy Date: Fri Sep 1 14:33:19 2017 +0700 procqueue: use unsigned int for I/O frame size fields A frame size cannot be negative, so 'unsigned' is more suitable for frame size fields. http://cgit.osmocom.org/gapk/commit/?id=4f0a47d0e35ece9ca46bb62294357d89920d06aa commit 4f0a47d0e35ece9ca46bb62294357d89920d06aa Author: Vadim Yanitskiy Date: Thu Aug 31 17:49:36 2017 +0700 Add the symbol export map for libosmogapk http://cgit.osmocom.org/gapk/commit/?id=cda8995ac8a17cc1d579f73519fd5b0f2429675a commit cda8995ac8a17cc1d579f73519fd5b0f2429675a Author: Vadim Yanitskiy Date: Mon Sep 4 04:18:06 2017 +0700 benchmark: add functions to get cycle and frame count To simplify the benchrarking process via the library API, this change introduces two new functions, which are intended to provide total cycle and frame count. http://cgit.osmocom.org/gapk/commit/?id=72218e7da04783222f04492d939268ac40585027 commit 72218e7da04783222f04492d939268ac40585027 Author: Vadim Yanitskiy Date: Mon Sep 4 03:33:48 2017 +0700 benchmark: allocate memory dynamically Having statically allocated memory for benchmark data of every codec causes high memory usage, especially if actual benchmarking is not required for a particular use case. Instead of that, let's provide an optional opportunity to enable benchmarking for a particular codec by calling the osmo_gapk_bench_enable(). The required amount of memory would be allocated, and then can be freed by calling the osmo_gapk_bench_free() or manually. http://cgit.osmocom.org/gapk/commit/?id=c9a75e59c67d62bc9d64c8c110ef47feb60e7ebf commit c9a75e59c67d62bc9d64c8c110ef47feb60e7ebf Author: Vadim Yanitskiy Date: Mon Sep 4 03:03:32 2017 +0700 benchmark: get rid of 'static inline' definition The usage of a 'static inline' function definition in the 'bench.h' is resulting in separate independent function definitions in each translation unit from which the header is included. This is increasing the size of compiled code unnecessarily. http://cgit.osmocom.org/gapk/commit/?id=ba46856bb403a507977e4c699c90714c962463f9 commit ba46856bb403a507977e4c699c90714c962463f9 Author: Vadim Yanitskiy Date: Mon Sep 4 02:23:18 2017 +0700 benchmark: move benchmark impl to a private header There is no need to expose the implementation details of both BENCHMARK_START and BENCHMARK_STOP macros via public header. This change moves them to a separate private header 'bench.h'. http://cgit.osmocom.org/gapk/commit/?id=349219c14875705b8142d599f6af153d22a9a00e commit 349219c14875705b8142d599f6af153d22a9a00e Author: Vadim Yanitskiy Date: Mon Sep 4 00:42:38 2017 +0700 benchmark: move benchmark_dump() outside the library The benchmark_dump() is only used by the osmo-gapk binary, and is intended to prepare and print benchmarking results to stderr, what is most likely unusable for the library users. http://cgit.osmocom.org/gapk/commit/?id=a8d46571cebb7f14501fa7bcf3c2eb86c473d8b2 commit a8d46571cebb7f14501fa7bcf3c2eb86c473d8b2 Author: Vadim Yanitskiy Date: Thu Aug 31 17:22:56 2017 +0700 Add an 'osmo_gapk' prefix to the exposed symbols To avoid a naming conflict between libosmogapk and other projects during linkage, all the exposed symbols should have an unique prefix. Let's use 'osmo_gapk' for that. http://cgit.osmocom.org/gapk/commit/?id=9cba760ba2ca5fd73e34f91bf388fc255dbcd335 commit 9cba760ba2ca5fd73e34f91bf388fc255dbcd335 Author: Vadim Yanitskiy Date: Thu Aug 31 02:31:18 2017 +0700 procqueue: expose the processing queue struct definition To be able to use processing queues from outside, the pq struct should be shared in the corresponding header file. http://cgit.osmocom.org/gapk/commit/?id=40d59f14a240e943205fafe7d2449b286d3b4913 commit 40d59f14a240e943205fafe7d2449b286d3b4913 Author: Vadim Yanitskiy Date: Thu Aug 31 01:41:26 2017 +0700 Add a pkg-config manifest for libosmogapk In order to make pkg-config 'see' the libosmogapk, a corresponding package description is required. For more details, see: https://autotools.io/pkgconfig/file-format.html http://cgit.osmocom.org/gapk/commit/?id=5f941573b0040c1b27014b4756155c86fe896b9f commit 5f941573b0040c1b27014b4756155c86fe896b9f Author: Vadim Yanitskiy Date: Thu Aug 31 01:20:18 2017 +0700 Use '#pragma once' instead of include guard The most compilers today do support the '#pragma once', which is designed to cause the current source file to be included only once in a single compilation. One has several advantages, including: less code, avoidance of name clashes, and sometimes improvement in compilation speed. See: https://en.wikipedia.org/wiki/Pragma_once for details. http://cgit.osmocom.org/gapk/commit/?id=30209cedddb3b6ece5614b40f65f6a04e84388b4 commit 30209cedddb3b6ece5614b40f65f6a04e84388b4 Author: Vadim Yanitskiy Date: Wed Aug 30 20:26:02 2017 +0700 Install GAPK headers to '${includedir}/osmocom/gapk/' To be able to use the library, external applications need to know, which symbols are exposed. This information is provided by header files, which are being installed to a system's ${includedir} since this change. http://cgit.osmocom.org/gapk/commit/?id=48206ad2e07216e01c9870b606aee442b3d7ec0e commit 48206ad2e07216e01c9870b606aee442b3d7ec0e Author: Vadim Yanitskiy Date: Wed Aug 30 19:35:51 2017 +0700 Add an 'osmo' prefix to the 'gapk' binary This is a common practice of all Osmocom executables to have an 'osmo' prefix. Let's follow this here too. http://cgit.osmocom.org/gapk/commit/?id=95e666404e1e31dfb95d7dc8b00c1b0be88659b3 commit 95e666404e1e31dfb95d7dc8b00c1b0be88659b3 Author: Vadim Yanitskiy Date: Wed Aug 30 19:03:49 2017 +0700 Introduce a shared 'libosmogapk' library The previous GAPK implementation was represented as a single executable. So, all audio transcoding operations were available only by calling the 'gapk' binary. This approach didn't allow external applications to benefit from using GAPK API directly. Since there are some projects (such as GR-GSM and OsmocomBB), which are potential users of GAPK code base, it would be better to have all transcoding functions within a shared library. So, this change separates the common code into a shared library, named 'libosmogapk', and links the 'gapk' binary against one. Currently there are no shared headers, pkg-config manifest and the export map, but they will be done latter. ----------------------------------------------------------------------- Summary of changes: .gitreview | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .gitreview hooks/post-receive -- GSM Audio Pocket Knife