openbsc.git branch master updated. 0.15.0-836-g4e5b90a59

gitosis at gitosis at
Wed Aug 9 10:14:32 UTC 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  4e5b90a594f987266a7e9492f30780eb92b9639c (commit)
       via  31655d84faa7f7fe823111856ae2035d44aca0eb (commit)
       via  3e4295287f1a2866e6e512517a2c94f608ecbd30 (commit)
      from  18ca1ce2ea9f0c353e6886a9d05c61238bba9dc6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 4e5b90a594f987266a7e9492f30780eb92b9639c
Author: Pablo Neira Ayuso <pablo at>
Date:   Mon Aug 7 14:01:10 2017 +0100

    libmsc: remove 'deferred' parameter in sms_route_mt_sms()
    No need to cache the sms object, just cache what we need into the
    smpp_cmd structure. This simplifies what that I introduced in
    93ffbd0029d1 ("libmsc: send RP-ACK to MS after ESME sends SMPP
    Change-Id: Iba5f864f9bb963baff95969e306b1b7cff00c1e3

commit 31655d84faa7f7fe823111856ae2035d44aca0eb
Author: Pablo Neira Ayuso <pablo at>
Date:   Mon Aug 7 14:01:07 2017 +0100

    libmsc: remove duplicate lines in deliver_to_esme()
    This code is accidentally doing the same thing twice, remove it.
    Change-Id: I68087a850399e22951d2407e4d8a09c671a775c9

commit 3e4295287f1a2866e6e512517a2c94f608ecbd30
Author: Pablo Neira Ayuso <pablo at>
Date:   Mon Aug 7 14:01:05 2017 +0100

    libmsc: remove dead code in sms_route_mt_sms()
    The following branch:
            if (!rc && !gsms->receiver)
                    rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED;
    at the end of sms_route_mt_sms() always evaluates false.
    Just a bit before, in such function, we have this:
            if (!gsms->receiver) {
     #ifdef BUILD_SMPP
                    return rc;
    So, if there is no receiver, we just stop running code and return the RP
    cause via the rc variable. Same applies to the smpp_first check under
    the BUILD_SMPP ifdef (that I have removed in this snippet to keep this
    commit message small).
    Change-Id: Ic3502b5b169bc7a73a67fd6ff53d8b6c0dc045c8


Summary of changes:
 openbsc/src/libmsc/gsm_04_11.c    | 22 ++++++++--------------
 openbsc/src/libmsc/smpp_openbsc.c | 32 +++++++++++++-------------------
 openbsc/src/libmsc/smpp_smsc.h    |  5 +++--
 3 files changed, 24 insertions(+), 35 deletions(-)

Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list