openbsc.git branch neels/dyn_fixes2 updated. 0.15.0-464-gdbeff7d

gitosis at gitosis at
Tue Sep 27 01:42:46 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, neels/dyn_fixes2 has been updated
  discards  f3f9d145485283422ea4dec7a13f1a2b1e6290dd (commit)
  discards  babda0e61b06f30df8d2fb5333bde756cce7e3fd (commit)
  discards  22687129cda65bafbc7b19e2f97e1e5822edbae8 (commit)
  discards  fbcbbef242c281378eeff0396bd719ceeedb6000 (commit)
  discards  aecaee097d8deb27928186bebca272b5c838f3d7 (commit)
  discards  508a0786fd23407c358c8fe2a4c56dfff7eb8fc5 (commit)
       via  dbeff7df7fd32505831ffaee6dc1a9fcb615a42b (commit)
       via  722349ea9b68b3ffed1e403998eba2a003fed2d8 (commit)
       via  f7a4652a6e457560b836d9888e107bb7487c5ad8 (commit)
       via  29868172586c8920c902a22dca30c3b01baa8c0b (commit)
       via  5e1fa3e58c99f00ba7b1d492597a830df33f00f4 (commit)
       via  6cc709d4b1e2552dddcb9611173ec24f7f9e9afc (commit)
       via  a9f2bb5ab878ad192cd5a593596a6450e6ff7b58 (commit)
       via  5e0b0a658fdc8d42de434eb1939352c55eeed30f (commit)
       via  663debcb90022f1ca53b0d947162774c8a1ec9c5 (commit)
       via  43d86bfc94969ac9738ce398d13bd0a974e90df0 (commit)
       via  c13e68774215c4156925e8a2012fcb9169cf70b2 (commit)
       via  77c8d5ffb52bd5da405fc869286b4f7aa7f88d4d (commit)
       via  d90fa42dc9f1fbf3d1d92a1749742ecb1c5d537e (commit)
       via  0ce98c749a37cc365ab77224d36d6f68061ef727 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (f3f9d145485283422ea4dec7a13f1a2b1e6290dd)
             N -- N -- N (dbeff7df7fd32505831ffaee6dc1a9fcb615a42b)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit dbeff7df7fd32505831ffaee6dc1a9fcb615a42b
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Sep 25 15:15:59 2016 +0200

    dyn TS: fix: abis_om2000: also handle dyn TS as TCH
    Add ts2comb() to switch on dyn TS so that dyn TS in TCH mode are also treated
    like normal TCH/H or TCH/F pchans. Use ts2comb() instead of pchan2comb().
    Change-Id: Iddc51a4409488d91db59228ca66aaab73ce3f1df

commit 722349ea9b68b3ffed1e403998eba2a003fed2d8
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Sep 25 15:07:01 2016 +0200

    dyn TS: fix: bs11, om2000: two switch(pchan) for dyn TS
    Add ts_is_tch() in gsm_data_shared.h/.c and use it to replace a switch on the
    pchan in two (unrelated) places: libbsc/bts_siemens_bs11.c and e1_config.c.
    This patch is not due to an actual observed failure. A general grep for switch
    on pchan turned up these two instances that don't handle dyn TS properly. Hence
    this patch is not actually tested with real equipment.
    Change-Id: Ide4f156034bab77140d2d9a8c462d68ae6f0d6a6

commit f7a4652a6e457560b836d9888e107bb7487c5ad8
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Sep 25 15:33:02 2016 +0200

    dyn TS: fix: ts_subslots() for TCH/F_PDCH in PDCH mode
    In gsm_data_shared.c, add ts_pchan() to determine actual pchan type for dynamic
    and non-dynamic TS.
    Use in ts_subslots() to fix the value returned for TCH/F_PDCH in PDCH mode.
    Adjust the assertion in channel_test.c accordingly.
    Drop GSM_PCHAN_TCH_F_PDCH, which is now handled in ts_pchan().
    Explicitly add GSM_PCHAN_PDCH as zero in subslots_per_pchan[] (cosmetic).
    Adjust the comment in subslots_per_pchan[].
    The fix for the number of subslots affects only one caller: bts_chan_load() in
    chan_alloc.c. Before this, it would always include a TCH/F_PDCH in the
    load_counter->total, now it is skipped when in PDCH mode. Whether this is the
    way bts_chan_load() should handle dynamic TS is a separate discussion, so far
    I'm only making sure that the two dyn TS kinds act in the same way:
    TCH/F_TCH/H_PDCH is only counted when in TCH mode, and TCH/F_PDCH should match.
    Change-Id: Icd6668667ad2be7ad20866ffd185bf3b8711ccd6

commit 29868172586c8920c902a22dca30c3b01baa8c0b
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Sep 25 17:01:20 2016 +0200

    Revert "bts: extend bts_chan_load to allow counting tch only"
    This reverts commit 308cb0719dca3ba8eed1eff2a2124d44f34d9a28.
    Problems in this commit:
    openbsc/src/libbsc/chan_alloc.c:523:   case GSM_PCHAN_TCH_F_PDCH:
    This is actually wrong, GSM_PCHAN_TCH_F_PDCH use ts->flags, not ts->dyn below
    (due to historical reasons and could be unified).
    560:   if (only_count_tch && !chan_is_tch(ts))
    This has exactly one effect: it excludes GSM_PCHAN_TCH_F_PDCH when in PDCH
    mode, because for all other PDCH (plain PDCH and TCH/F_TCH/H_PDCH in PDCH mode)
    below ts_subslots() returns 0 and skips the for() loop. I consider this a bug
    in TCH/F_PDCH, to be fixed in an upcoming commit.
    I don't see why we need the only_count_tch argument, because this should
    normally only count TCH, weren't it for the TCH/F_PDCH bug.
    If dyn TS should be counted differently, we should do this in a different way.
    Change-Id: I34dbbaf53a800115e3d03bd44028cad675f3b525

commit 5e1fa3e58c99f00ba7b1d492597a830df33f00f4
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Sep 25 15:58:01 2016 +0200

    channel_test: test nr of subslots for dyn pchan, with error
    Add test_dyn_ts_subslots() and call from main(). Update channel_test.ok.
    This includes erratic assert to show a bug for TCH/F_PDCH in PDCH mode: the nr
    of subslots should be the same as for a normal PDCH, i.e. zero. This will be
    adjusted along with the fix in an upcoming commit.
    Change-Id: I09685be3fb3ed1ead4577b772a9fbc31967980d1

commit 6cc709d4b1e2552dddcb9611173ec24f7f9e9afc
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Sep 25 15:47:36 2016 +0200

    channel test: prepare to add another test function
    Move the main() guts to test_request_chan(), so that I can add another test in
    an upcoming commit.
    Change-Id: I1349d0f416806416080d4667ad697f7db1ea252d


Summary of changes:
 openbsc/include/openbsc/bsc_api.h      |  2 -
 openbsc/include/openbsc/gsm_data.h     | 12 +++++-
 openbsc/include/openbsc/vty.h          |  4 +-
 openbsc/src/ipaccess/ipaccess-config.c |  2 +-
 openbsc/src/libbsc/abis_nm_vty.c       |  4 +-
 openbsc/src/libbsc/abis_om2000_vty.c   |  4 +-
 openbsc/src/libbsc/bsc_api.c           | 23 +++++------
 openbsc/src/libbsc/bsc_init.c          |  7 +---
 openbsc/src/libbsc/bsc_vty.c           |  2 +-
 openbsc/src/libbsc/net_init.c          |  7 +++-
 openbsc/src/libcommon/talloc_ctx.c     | 33 ++++++++-------
 openbsc/src/libmsc/gsm_04_08.c         | 73 +++++++++++++++-------------------
 openbsc/src/libmsc/gsm_04_11.c         | 22 +++++-----
 openbsc/src/libmsc/rrlp.c              |  2 +-
 openbsc/src/libmsc/transaction.c       |  4 +-
 openbsc/src/osmo-bsc/osmo_bsc_ctrl.c   |  2 +-
 openbsc/src/osmo-bsc/osmo_bsc_main.c   |  2 +-
 openbsc/src/osmo-bsc_nat/bsc_nat_vty.c |  2 +-
 openbsc/src/osmo-nitb/bsc_hack.c       |  6 +--
 openbsc/src/utils/bs11_config.c        |  2 +-
 openbsc/tests/channel/channel_test.c   |  2 +-
 openbsc/tests/gsm0408/gsm0408_test.c   |  4 +-
 22 files changed, 109 insertions(+), 112 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list