libosmocore.git branch master updated. 0.9.0-240-gdbc6817

gitosis at gitosis at
Fri Sep 23 02:18:31 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  dbc68177926c7f04d42b418ee6dc559571f4d7f8 (commit)
       via  d0858c2ae9cdd065d09c3a58e60409b7af50111e (commit)
       via  255dac16a4a69e29be62bcc692dabf9cd1a586b5 (commit)
       via  d73c1cc7c25d5e38d848f40598b17d84e77b6a5b (commit)
       via  7b4d727ec5debc3d057686a0a3f0f5f14260a282 (commit)
       via  8e2f7e87f4d854e697c40545326a16e50614dd5c (commit)
       via  13a8fb84f0d83f23e65daa528f2f392ec3b83a75 (commit)
       via  9c9a04705ff431c1e10bf40f2e964a43360441ac (commit)
       via  633a0e76a2fbb31ce6dd4dadb35313aed3aa385c (commit)
      from  5b34f773e441b984d3bc98468fd015eeb4131890 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit dbc68177926c7f04d42b418ee6dc559571f4d7f8
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:21:50 2016 +0200

    timer_test: set 8 as default steps, use the default in
    Change-Id: I5070578e9fe2bdacaad000eaafb8dc5f549d6f3e

commit d0858c2ae9cdd065d09c3a58e60409b7af50111e
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:50:13 2016 +0200

    timer_test: print more details to stdout to check
    The test is now fully deterministic, so include all detail in stdout, to check
    Change-Id: Iecf6387f1d25253fcf1260777673853030c1d326

commit 255dac16a4a69e29be62bcc692dabf9cd1a586b5
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:48:32 2016 +0200

    timer_test: redirect some output from stderr to stdout
    This way we can check the output in timer_test.ok.
    Change-Id: Ia3bba1c650be3558d370e0f59d4ee7f36ef97506

commit d73c1cc7c25d5e38d848f40598b17d84e77b6a5b
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 05:20:53 2016 +0200

    timer_test: remove all random elements
    Change-Id: I9833031407e99f5d7a1144c26b68a7e320b2020d

commit 7b4d727ec5debc3d057686a0a3f0f5f14260a282
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:47:04 2016 +0200

    timer_test: do not use real time: deterministic and faster
    Use osmo_gettimeofday_override* to decouple the timer test from real time. No
    longer call osmo_select_main(), since select() actually waits for real time.
    This reduces the timer_test to the osmo_timer_* logic and excludes the real
    time and osmo_timers_nearest() accuracy testing with actual waiting involved.
    This may be seen as a loss, but is more fit for a test suite.
    The main point here is to get deterministic results in jenkins, so that we
    don't have to retrigger jobs based on timing failures; added bonus is that the
    test runs much faster now.
    Change-Id: Ic5649512df86dd17070daa2f314159eafaf8feb8

commit 8e2f7e87f4d854e697c40545326a16e50614dd5c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 03:58:13 2016 +0200

    add osmo_gettimeofday as a shim around gettimeofday
    This allows feeding a custom time for unit tests by overriding
    Change-Id: Ic7a81a6eb51f27fe452962b91f2eae2070d87089

commit 13a8fb84f0d83f23e65daa528f2f392ec3b83a75
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:45:26 2016 +0200

    timer_test: remove unused precision values and confusing log
    Change-Id: I1570b7096c757d63d23e0950feeeb7230f8a5c9f

commit 9c9a04705ff431c1e10bf40f2e964a43360441ac
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:23:34 2016 +0200

    timer_test: also report early finishes, report timing on error
    When a timer was late, show the timing details.
    Also count whether timers fired early, for completeness' sake.
    Change-Id: Id3942637d77a28b5092ffffcc3e6d9d67c2b8e68

commit 633a0e76a2fbb31ce6dd4dadb35313aed3aa385c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Sep 22 04:24:38 2016 +0200

    fix timer_test: don't forget to set tv_usec on the stop time
    The timer_test schedules timers and records the desired stop time. Also store
    the usec value of the desired stop time, because scheduling at e.g. sec N usec
    999999 but recording sec N usec 0, and then receiving a timer at sec N+1 usec 0
    is only 1 usec late, but records as 1000000 usecs late. This might have been
    the main cause of the timer test not working well on the osmocom build server.
    Change-Id: I13bb60f7d341a397f95d13d9c63c40188b6cd5a0


Summary of changes:
 include/osmocom/core/timer.h |  11 ++
 src/              |   2 +-
 src/gb/gprs_bssgp.c          |   8 +-
 src/gb/gprs_ns.c             |   4 +-
 src/logging.c                |   3 +-
 src/timer.c                  |   8 +-
 src/timer_gettimeofday.c     |  58 +++++++
 src/vty/command.c            |   2 +-
 tests/gb/bssgp_fc_test.c     |   4 +-
 tests/           |   2 +-
 tests/timer/timer_test.c     | 104 +++++++-----
 tests/timer/timer_test.ok    | 372 ++++++++++++++++++++++++++++++++++++++++++-
 12 files changed, 518 insertions(+), 60 deletions(-)
 create mode 100644 src/timer_gettimeofday.c

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list