This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "wireshark with Osmocom specific dissectors". The branch, laforge/om2000-201610 has been updated discards ff68c929d15906d3e8112a0573eaec2c4ce93b5b (commit) discards 31560fa4161ed3653c8e5c1e7b7b6136434d6924 (commit) discards c2194ad7ab99f9748db20b2674cf9fb43179a994 (commit) discards 35367ec06363e1f68e689c8234b7d89750d10cf1 (commit) discards 111796dceb53be4ada7a245ffd312c847f9d5230 (commit) discards aad62461f2d77467587d3691709e1f4dffcdcf1f (commit) discards 5d03522521ea81db51aef75143ef1f2ba242a439 (commit) discards 969b9119657d0be5aac672ae00b699fe8d36f8c2 (commit) discards 930e1eccde78f90db1f52d6f75a9a060b8d96a0f (commit) discards c90c15013426d9f011b4484ca0185eb213afd376 (commit) discards 839cb7150e95570a4435350aaf5ab9e8f86daf22 (commit) discards f3b96023a168479b36a0ccdd9885d598fe317bf1 (commit) discards a3fc38deb7b4511333b57ab5e42c26b86d441873 (commit) discards 3edfc8144682c8ff408275ca214d5aeed069264f (commit) discards 490e7972a684d24201e256544bc20d4a58d2c7d5 (commit) discards c240e3831d6fc7136744aee0e4947048452ae886 (commit) discards 7928b3da367d2087e7564c7a208e0fa9500c245c (commit) discards 08340142c48dce17582a74a8d114443e02ba2f7e (commit) discards d8665395c77a4c6180fc33c15d8e4ea6e88dfe4c (commit) discards c94f125a21099d2b14aa40150ea3d8285f6df553 (commit) via 332ed94a22626844888999497bb6b34081b7a9c3 (commit) via 0251b9065b52fd2c63a101b9b470db169e687165 (commit) via 9a3a75a2bc968ca337fdcfb94f1ba2b4e76a2837 (commit) via 7148943d9d1f63b6acc6ff526a4615ef8ebd8503 (commit) via 4ae47bf8438a440ed0c9c88e0e1f58e740dd1b69 (commit) via 7b473e6fb9da69d388f8630438445c1a63f0b014 (commit) via 3fd9f5713b3ae59b7e6aa2ca8529ff51b425c699 (commit) via e3667d05da61818f2428af1da36f39a9b4eff1d0 (commit) via 5ef70091f55438749573aa1e38601d8563fb73b7 (commit) via ae6a807c9a37af31f95f5971ff39066cd38ef82c (commit) via 750040907e2c0f625b746f76950b17aa945cb406 (commit) via ca2dc538ffbf6ecda2416bc53808fc97e7b8b3d4 (commit) via 6eee29bf2a86eee890051b566db26628e2e52918 (commit) via dcb49539dd6542528d36b239892d7086d5693f4e (commit) via 7719bd5efad97a62fad6168b04c42b0413feb8c8 (commit) via 2eb823fed721d768bc8484f83e068c61728873cf (commit) via 00e21988690863fd3396845c4421a8879982a43a (commit) via 470a44a3341a91b5b7adf3f8bc14ce0727f6e938 (commit) via 149627a3b099f7405a6e7a7cc078a906c9844421 (commit) via 1e65231798507b6bd41951d69d6098f3a4b470af (commit) via 3e82f423d9912c52900100e8c80a7e63d799e047 (commit) via 517e777816840ca01e28f57fde6d822356028859 (commit) via 40ce00fc8b4fdf389c6c382d9fe5418c84b0d5cb (commit) via 180cbcf4365e57967f9fdf33b7570da0aec969be (commit) via ff41263fe3f78cd5b080789e9ec50ce779ef6494 (commit) via d8db5646efc17dec73426e3745a9c9ef704a91c7 (commit) via 60a926dc32dfc5333961752e902c19d83b98d2ca (commit) via 346bda4238033fb146d6a7e7f21ecd714da396a2 (commit) via c63f89515985a8db0aa8a500b1832474619090aa (commit) via ae88dbcc2a990218549e06e143908eed1223ad8a (commit) via 5b216db2876904400e7442805d6a7b52ddb4e0bc (commit) via 446dbea4eb05cc5e4a363dbc22f7421c6527a3a4 (commit) via 26950539d6f87e2f2157ac6d2bf9e5173b780856 (commit) via 04761f220b77814bfd460da7026b61c7687f687a (commit) via 79de3f5e2986486b9a3ed55af86644ab746ffe65 (commit) via 749ffd94d496561b269007a0fe0813d8be7df1bc (commit) via e226abdbb05b37564599c6b92cd669b40749f2f6 (commit) via b5587379b7e31c8e418f51a7db9d836b33a7efe1 (commit) via e3ecb9310c9973f85f7d0bd06ef8cf7dc7ecf3c2 (commit) via a9ec5f89ce8ab336becf20ae3c2f5b7d05edcb74 (commit) via def19eed53c1db319b8f1142d3ed8c00fceaf201 (commit) via 7de4c2364d9d393ec252485b02957dffb0b4d72b (commit) via 8be90aa96002219ff8feba171e66d16655dc18bb (commit) via 4f94dceee72d557693702e528a14eef76ba80a5b (commit) via cd64e4ece2e0e731fa9ffc07fead9420d46d8c1a (commit) via 3acf73ec45d2548c0d8447d07a95b1b5710741fb (commit) via c786aa56ad32cd820378756feff275b48ecb51a7 (commit) via 681b97a047fa10c050a86869e113f8ecb3f9d127 (commit) via 3b502c873f2b30e661d46693d3a3f6fcba9474ea (commit) via 20e2edca572a835ab4ee6ff1fbbf86bf5db54b35 (commit) via af7fc8b7e4979e77d2d072789e98d58a0b175908 (commit) via 3156980aa559186a10e3b8566d41e4a50477d967 (commit) via 875b3e2732e8ad20f87ef940300605080a807132 (commit) via a3a20531b1a7ae2bb8b48ca25fbe27f10e2462a9 (commit) via 3c3f592ebc9e84a7c77bb50bf45ae7222dcd8a4c (commit) via 3576394ed4fc782ce5a2151c88c5a10b37cb3393 (commit) via 892246acb02868ee4be14543521a20b9818184d6 (commit) via 903eab03798d636cc3cebd1fd08e0097190c745d (commit) via 2e962d368a6f19d8a32a997dfa144eb3794009ef (commit) via 6b2579801445e25e49b85c4f71283e07858ba6b7 (commit) via 1c7b431a75bba97c46b54d150d6e5a3fe9f78a6a (commit) via ed187592ae8479f6e6eaea7f78f936a37db4471b (commit) via d3b2ee9b0c41478d627e90e8a9ef3b5e02512b43 (commit) via 6b03eea7143c4fb41110e8de3a16a31146300fe7 (commit) via 812e5fd893915591cd7cea34f275efc0c30cdd0a (commit) via 48972d883fb8865e37b83a8b8ded2ff270ca9b38 (commit) via 49a525a97e68f9ba5b840c3054669a5dd6081010 (commit) via ce9405b00b0bc49fef5a21f984251a1e0065580b (commit) via 28bbd565917d59b20458e5de783096bc332c1965 (commit) via a2d49125a52e0eb21215368a7e1f248b6d4a6c06 (commit) via 44cf0bdccfc36e11419b1a9bf3d72ac0db13d58b (commit) via e85882940419dd9ce012489689e13ae4b18be04e (commit) via 7dfaec969e67e3aa14b9763d804802ef614c9ddd (commit) via e80a8acbe3cb0d0bdefeff51292bd90c3461a02a (commit) via 5f68435a079dc7ce633e1da22f363e4e715d66f6 (commit) via d32fee2d6252c485dacdf51441d7ba5c6d37d7f3 (commit) via 0cb4d0d346a9cf39135ef12c9eb65e727c14b3dc (commit) via a63b5eb711cc50efe2725d716e0774e147376d25 (commit) via 528894e72f973c5db5dc76c975620754f7bbe5aa (commit) via d16295bc9b48a526f12237467536bac4220e53da (commit) via 321b756dc41f9bc26cc0eb8b08f90a73158dc75a (commit) via 53d3e3c25ef7037ba28b93dd684f5de4c015767f (commit) via 10ca4c7527122efde0300205deaa6c0143f07219 (commit) via 49cf42c571f3f94632957371ccd99533e71764ff (commit) via b3363fbbdee8b785c849c24a265fdbe28c28f608 (commit) via 362b83f44a4a6a731c64f8a6591ee717af2454a0 (commit) via 1b9d46a9502843c15c33891955f6242c883aa1a5 (commit) via a6d81effbc23acce59fd88b8f828fe8c753eeb0d (commit) via 7f6a4926d2f6a135960146041c29802db616aa63 (commit) via 10a1e8d261d30ce30300c6f51863b74184e61bd5 (commit) via d142e7f4038f840ec2d7d89a1de4d486e1f54222 (commit) via 991e0747a3b0bbeddb27dc29e53fa6dbb5c68e4b (commit) via 67bfdf28714a5945a78aef9d745d88fd69972578 (commit) via 25207d70bb9938c2c00ddc0e26f5c85d9d8616ca (commit) via b50888de9994efdbd8851e8992d6bec31f9d0b89 (commit) via efde624a11b82d3d51925d5f94ff5bedeafe1e03 (commit) via 3756c0e24db61eb451ad732a45e0b2b94c5a846f (commit) via 53400e0d33a5c4f94859c024f9efa9a562daf492 (commit) via 511e80128e15be8ce2bcdca912d599217fa8ebd6 (commit) via 3fb32662a861fffbdda802a0bb7fd359f2a837fd (commit) via 4a87ecb52bbc51d0cce7a7a8d5c5f61303e524fa (commit) via 269b54c2e0c323d22e2f6c9d75ef61d96ce83c02 (commit) via 7b38c6bf3a6f473a510f668162daff52d8df7e2a (commit) via a9b391dcb28967f433c38d79319656137b9520ed (commit) via c9fa9b51dea34dc5576c61c14633753b2bcc5768 (commit) via 9e42cad18a049ed0a52f337f91be1096887dbca4 (commit) via 60f5c5716378bd34c215e0227a977663d31a6fab (commit) via 1e69a5e569a9ed1e7bc3225136eb9147bc02c617 (commit) via afcbcdf272d270ef08b214c6571336c376a24e1a (commit) via 82696cabd6686eb1c5e86421237baf90a339f54c (commit) via d821c72b9737703ddad80fb82a5525341967c9c2 (commit) via 961b05315df0c17bc21ca77553d1e29ebdf39309 (commit) via f0cb70bd18171a8102f4a6baefb385a1dcd2d960 (commit) via 9c3d81adde2d901a18fb0dc5a5dc2220f76cd920 (commit) via d38ed8e55f7df9b34b9a7859ff54dde726f2feb0 (commit) via f252831b43269dd06487cdf3e5e791ecc991bf3d (commit) via 404c31492be8b01d1b6bf9944ea3bb71feb92dd6 (commit) via bd057c8dd226dd3c33104b95310ac592d7a19b09 (commit) via d561afcd129132877197bd0c77d9ea9a6471a6c4 (commit) via fbf4f6c62f3967b45e706ad3150d6b7d0208b34c (commit) via d3995b5248e412dd1b00c06a3f54936326967e2d (commit) via 5ab49c623df23a5d19cffdc29f912dd1d2798ca9 (commit) via c92cc9c95a8bc45c932bb37775627657994e906d (commit) via 11e8bac88e067b226f92add83eca3009fa5b95a7 (commit) via b31bdfdc58ed78a409a35f1f5861010701935236 (commit) via 5c8f4decd9797275a77c73d032633c5a55100289 (commit) via afc2034721923534d8810fbee087155240edf687 (commit) via dbb391a64681e3c5722f8e7ff79bd4154d0b2e6b (commit) via 25122f5ef6f722a12077ce91f1b0d9784570009c (commit) via b4f86c9cb84c8cefcf0784fa1bbe10a89392da74 (commit) via 4ef14c76513acb92e75c87a1f987c8c9c18fabc6 (commit) via d399bfaa0768de53831d0a841f0e4ef55bd37d24 (commit) via 10c46fc3082b728b08a7dcd70cad7d6eef1337bc (commit) via 1d35c7f096792d5c2d873a3585de462d8fe54ee8 (commit) via 59c370440423131e3ef460ca3b8f1f55ca319926 (commit) via a0e1d282f2d8c87b985a8896a5418dda2894f48c (commit) via 9672913350adf1bf9d1a624e56a24ece2bfc6891 (commit) via 7edf3eeef811135f128075a679f8d6aed400a173 (commit) via e68247e1fdc5a81872f5f3ee01a40ea71db71380 (commit) via 864f750be560a7a739c7453f19a8f5679cf7d6b3 (commit) via 5cbdbecc35f77c40142e2e5389e553931490eea0 (commit) via b83ea466655a77dacd8ad0bd38706afbec1ce21c (commit) via ba00be5266aff1bdf6507fdb9bd263d30c8dcc32 (commit) via bf96599f1916667cc8f1c19b58fe9cae4a1e3d66 (commit) via 739bdfb45f6e6f78a88e978de1eff088377e8330 (commit) via 09b43591a13e9834a66adbd7b24c3c28af8ea5fc (commit) via 6a14408bf62f534db2374f131195fc2c42785f57 (commit) via 537705a8b20ee89bf1f713bc0c9959cf21b26900 (commit) via 41c6b944b42a31c9593e4374336fee8022e0011d (commit) via 2898c2a244eeccdb41c334d2b6c16117e9844dc4 (commit) via 7a906dc877c06700ef6d09aa8edd0e09f5b22f9d (commit) via 4a4698259c3c770eb4c675adcaa11674c306e551 (commit) via 63eb48adaa49e6781953f0555998db6622372843 (commit) via 397065bb591d224df94463705b51d9c13f613654 (commit) via 47e93451161c9af972c55af856ebbc1ab65441cb (commit) via 41e9bbac91c76fa0c95944a0329dd674cbeb61d9 (commit) via 9796e811f51892db729e02735a8bf31628ea7dcb (commit) via 5d2c54ed2029dd98c44e17672e9c63ad0172e87b (commit) via 256f834293e54be5d54a6f9c55472876851cbbbf (commit) via 418b7d125dcf65cd335c5dc113fde27074453d2a (commit) via 2c071296f5b344298e2994d29c2b3ca3550601f4 (commit) via c7e75770e1c2d85e3a21ad457b2e415fcbe2f012 (commit) via 8a1adf1a66cb0324e418e2e588cf47c68c4a287a (commit) via f07b1bc6042925cba6ca2bfb762c9521513259ba (commit) via 954e7c4ded574a0a7d2963f979c51b79a038958b (commit) via 303948500fee5f24600643638e3ed5cc5fa14132 (commit) via 867f2829c1c4e1f67b14a5ace5cc9f29e971a6c9 (commit) via 7b73a04116b3037131081bc8167fd2002651294b (commit) via 47649d1c7fb6ba48b805e19268a711404eb6908b (commit) via 5c42d8a24c863549166bc1d0875e87a07bedf53e (commit) via b973b001bfe82fdff55ac040d1904d95744cb839 (commit) via 3b3185eb65e3625228e4ec6f68367b485a22965b (commit) via dca176c23217301cb7015e7eb7e256888d979781 (commit) via f3ae5f1b4dee780b3d912db4d9e446a089c171d5 (commit) via 511bb814332d03553b2dfb3b927a721c364ad160 (commit) via ad3fe1572b47f4f74428d98dd2ef831da6559a93 (commit) via 81904c70a85c5e335908b628667cac84e560beef (commit) via 0c4eb2779f5507c498f9f076a993f0d0f988f1cd (commit) via a30dcd9951ed5814ca1974a31db83756bfb5b233 (commit) via 632b7d19d770e5215f1e89c363e3afab56369a53 (commit) via e5c594636324efaf908f5c779fa56e5feca4252d (commit) via fbc816a998c1649beaeefd743846c4ce977ac2b2 (commit) via 1d094209e8d6384cdb9fb6f88fc95a52a5ab45ae (commit) via 913225b5d4f334ec0298748cbcad6924cf57bcc3 (commit) via 5546400b55c4524e86ce98a92444fd3b48dcc96c (commit) via 51f316194d194fe1616112bf9d17130bc48a72f5 (commit) via cd426f3fe2719b9639f863efbb76e483c983970b (commit) via 4ff7799be8ff1995261717ca18d5cf21bee7ab52 (commit) via e552b319b5ffaa3652fa798cfd9db8771c20ba66 (commit) via 763a059fe967b5be4db4ca7b07279ae990a07c7d (commit) via 2176423b4ab5ddb5b23d9bfd1417c7280b3f5129 (commit) via 7b060953464efaa5675d9165595d4208f69864cd (commit) via 133a7e99b7f4b90a682fb2de2cd9e48543c839b8 (commit) via e84c20e7ed49c2c2e774efeac05960236696c53e (commit) via dc1cd7889da85938b016c6bfec932dd595b7e18b (commit) via b240082cf4ca297149a119694e9eb4d205bccc02 (commit) via faa74f86e2cedbaa7ceceda1b5aa28821bdfb58a (commit) via 95c944884ab00db7529512129f0292f1a74aa1fd (commit) via 9711d2220ce1584a37e9e7d7df3ebf3c8e57b23d (commit) via c59f7fc8fec4e8c9fca27053e3c63a93adca3cb5 (commit) via 93b2b2c06d2c8b6bbc3f204633c654383b0ce8ac (commit) via 74174367ff72257a7bd485f9a48c3c3667bd8e3b (commit) via 5d5f58fb78ab7037db3ec03d3a4541b3adcfcb7a (commit) via ebede2a7c55b49ba1d39dab3a18e5b3a1cfbaeaf (commit) via 91aef09509a3eb647588a6158c534f0b7bbe59c2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (ff68c929d15906d3e8112a0573eaec2c4ce93b5b) \ N -- N -- N (332ed94a22626844888999497bb6b34081b7a9c3) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/wireshark/commit/?id=332ed94a22626844888999497bb6b34081b7a9c3 commit 332ed94a22626844888999497bb6b34081b7a9c3 Author: Harald Welte <laforge at gnumonks.org> Date: Mon May 9 18:19:07 2016 +0200 WIP: GSMTAP LTE support http://cgit.osmocom.org/wireshark/commit/?id=0251b9065b52fd2c63a101b9b470db169e687165 commit 0251b9065b52fd2c63a101b9b470db169e687165 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 22 09:41:29 2016 +0200 [WIP] gsm_abis_pgsl: attempt to feed EGPRS headers/blocks into RLC/MAC dissector Change-Id: I18b363816c10df24933df2c3fa945be2559daa28 http://cgit.osmocom.org/wireshark/commit/?id=9a3a75a2bc968ca337fdcfb94f1ba2b4e76a2837 commit 9a3a75a2bc968ca337fdcfb94f1ba2b4e76a2837 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 21 23:08:52 2016 +0200 gsm_abis_pgsl: Fix Frame Number handling The FN is encoded as 24bit big-endian figure, so fix endianness for uplink. Also, make sure to pass the frame number into the RLC/MAC dissector using the private data. Change-Id: I2cd2e104a45a1ff63dfbc9ce1709ff0ccc6eb5be http://cgit.osmocom.org/wireshark/commit/?id=7148943d9d1f63b6acc6ff526a4615ef8ebd8503 commit 7148943d9d1f63b6acc6ff526a4615ef8ebd8503 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 21 21:55:56 2016 +0200 gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector Rather than displaying the P-GSL data as "data", let's call the proper GPRS RLC/MAC dissector to get a decode of the payload. Change-Id: Ib081606c1b7af2a15ecf3c5f5b3ff44b5096e865 http://cgit.osmocom.org/wireshark/commit/?id=4ae47bf8438a440ed0c9c88e0e1f58e740dd1b69 commit 4ae47bf8438a440ed0c9c88e0e1f58e740dd1b69 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 21 21:52:51 2016 +0200 gsm_abis_pgsl: Fix conditional Incremental Redundancy IEs There are some IEs in the Downlink Data Indication which are conditional to the use of EGPRs. However, we still don't see them in the traces, so let's deactivate that part for now. Change-Id: I408c73e5f48018d3ea4ebcacb7bd94358a9eaac5 http://cgit.osmocom.org/wireshark/commit/?id=7b473e6fb9da69d388f8630438445c1a63f0b014 commit 7b473e6fb9da69d388f8630438445c1a63f0b014 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 17 16:22:19 2016 +0200 l2tp: Introduce preference for default pseudowire In some cases, the establishment of the L2TP session is not captured in the pcap file, and thus wireshark cannot determine the l2tp pseudowire to be used for decode. So rather than using a ocmpile-time hard-coded default of cisco hdlc, let's introduce a prference where the user can select the default pseudowire in such cases. Change-Id: I44a6373d4812c9ab5a919514273a41a2ab57142c http://cgit.osmocom.org/wireshark/commit/?id=3fd9f5713b3ae59b7e6aa2ca8529ff51b425c699 commit 3fd9f5713b3ae59b7e6aa2ca8529ff51b425c699 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jul 16 15:39:17 2016 +0200 L2TP: Add preference to select Ericsson HDLC flavor At some point over the wireshark last years, the connection between the L2TP dissector and the Ericsson HDLC dissector (packet-ehdlc.c) got broken. I cannot poinpoint the exact change when it broke. However, traces with Ericsson L2TP that used to display correctly no longer do so. The problem with Ericsson L2TP is that they simply re-use the HDLC pseudowire (0x0006), but then have frames completely different than what's specified in the RFCs for that. To address this, let's add a protocol preference to allow the user to choose. Change-Id: Idce022ef0f233c01ecffc67dca7f428bde31ef6b http://cgit.osmocom.org/wireshark/commit/?id=e3667d05da61818f2428af1da36f39a9b4eff1d0 commit e3667d05da61818f2428af1da36f39a9b4eff1d0 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 15 20:18:16 2016 +0200 gsm_abis_om2000: Issue Expert Info when Enable Result != ENABLED The point of sending an Enable Request is to enable the respective MO. If the MO responds with any MO state != ENABLED there is something fishy. Let's inform the user with some Expert Info about it. Change-Id: Ib33e5dbc37894049b93bb71782787b8c96c04326 http://cgit.osmocom.org/wireshark/commit/?id=5ef70091f55438749573aa1e38601d8563fb73b7 commit 5ef70091f55438749573aa1e38601d8563fb73b7 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 15 20:04:41 2016 +0200 gsm_abis_om2000: Introduce expert info for unusual situations In OM2000, it is not usual to receive NACK, REJECT or "performed not according to request" type messages. Let's highlight them using expert info as a convenience to the user. Change-Id: I47b865c32fd9ec82ec63699babd31f3849f3006c http://cgit.osmocom.org/wireshark/commit/?id=ae6a807c9a37af31f95f5971ff39066cd38ef82c commit ae6a807c9a37af31f95f5971ff39066cd38ef82c Author: Harald Welte <laforge at gnumonks.org> Date: Tue Oct 25 15:46:21 2016 +0200 L2TP: Dissect three formerly unknown bytes in Ericsson Transport Cfg The meaning of the last three bytes of a Transport configuration has been uncovered: They control the batching/bundling of signalling messages: All signalling messages are delayed + bundled until either the timeout expires, or the message exceeds the limit. Change-Id: I794658e99e3c66145627652de4269fb08bc74ca3 http://cgit.osmocom.org/wireshark/commit/?id=750040907e2c0f625b746f76950b17aa945cb406 commit 750040907e2c0f625b746f76950b17aa945cb406 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 15 22:02:47 2016 +0200 gsm_abis_om2000: Add very basic dissection of "MO Record" The MO Record is returned in response to a Capabilities Request and describes the capabilities of he MO in more detail. The exact coding of the contents is not yet known at this point. Change-Id: Iddfe60d286a85585bec58d340bdee793d3bfca2e http://cgit.osmocom.org/wireshark/commit/?id=ca2dc538ffbf6ecda2416bc53808fc97e7b8b3d4 commit ca2dc538ffbf6ecda2416bc53808fc97e7b8b3d4 Author: Roland Knall <rknall at gmail.com> Date: Wed Oct 26 10:03:50 2016 +0200 InterfaceList: Make storing preferences optional If multiple proxy models are used, not all should change the preferences if types are being displayed or hidden. Only the main list should have that option. Change-Id: I8617e402b6608eda98d7ecc0167cd0ccc3c43eaa Reviewed-on: https://code.wireshark.org/review/18470 Petri-Dish: Roland Knall <rknall at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6eee29bf2a86eee890051b566db26628e2e52918 commit 6eee29bf2a86eee890051b566db26628e2e52918 Author: Roland Knall <rknall at gmail.com> Date: Tue Oct 25 11:26:26 2016 +0200 InterfaceTreeList: Enable all editable columns In preparation for moving to the new interface list, adding all necessary editors and changes to allow all columns, which are being handled by CaptureInterfacesDialog or ManageInterfacesDialog to be edited correctly Change-Id: I8bfabff92a07950c74a4d7243dadd99ecd2024f4 Reviewed-on: https://code.wireshark.org/review/18446 Petri-Dish: Roland Knall <rknall at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dcb49539dd6542528d36b239892d7086d5693f4e commit dcb49539dd6542528d36b239892d7086d5693f4e Author: Michael Mann <mmann78 at netscape.net> Date: Tue Oct 25 16:13:35 2016 -0400 ICMPv6: Convert flag fields to use proto_tree_add_bitmask Change-Id: Ib037b8ac6e16901408597696e1d4cd8cc95b2230 Reviewed-on: https://code.wireshark.org/review/18465 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7719bd5efad97a62fad6168b04c42b0413feb8c8 commit 7719bd5efad97a62fad6168b04c42b0413feb8c8 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Oct 25 15:36:06 2016 +0200 L2TP: Fix decoding of SC-TEI Map in Ericsson ALTCRQ The SuperChannel-TEI maps in the Abis Lower Transport Config Request were not properly displayed due to an erroneous additional offset increment. Change-Id: Ieebc43cd73f0c939daad2f853edeed854a12e5f5 Reviewed-on: https://code.wireshark.org/review/18463 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2eb823fed721d768bc8484f83e068c61728873cf commit 2eb823fed721d768bc8484f83e068c61728873cf Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 22 15:25:27 2016 +0200 l2tp: Dissect multiple Ericsson Transport Config Groups ... and put each group into a separate subtree. Also, put each item of a TEI to SC map into its own subtree. Change-Id: Id4cdaa883fa3eacdd53284b284bce5e67c97fcfb Reviewed-on: https://code.wireshark.org/review/18462 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=00e21988690863fd3396845c4421a8879982a43a commit 00e21988690863fd3396845c4421a8879982a43a Author: Harald Welte <laforge at gnumonks.org> Date: Sun Oct 16 14:08:42 2016 +0200 gsm_abis_tfp: Detect + display AMR rate based on payload length Change-Id: I1af7e3be87da9416ded02b09c480ea69ec58afff Reviewed-on: https://code.wireshark.org/review/18459 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=470a44a3341a91b5b7adf3f8bc14ce0727f6e938 commit 470a44a3341a91b5b7adf3f8bc14ce0727f6e938 Author: Yasuyuki Tanaka <yatch at isl.rdc.toshiba.co.jp> Date: Tue Oct 25 14:27:47 2016 +0200 ICMPv6: fix dissection of MPL (dissect_mpl_control) An MPL Seed Info of 2 bytes length (length_of_fixed_part), which does not have seed-id nor buffer-mpl-messages, is compliant and should be accepted. Bug:13045 Change-Id: I6c4c8864fdc8d6e590a5d28d68e5aaff8c1535c3 Reviewed-on: https://code.wireshark.org/review/18448 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=149627a3b099f7405a6e7a7cc078a906c9844421 commit 149627a3b099f7405a6e7a7cc078a906c9844421 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 15 19:16:39 2016 +0200 gsm_abis_om2000: Decode the IWD Type/Gen/Rev in Negotiation Request The Negotiation Request and Negotiation Requeset ACK contain IWD (Inter Working Document) revision numbers for the different A-bis protocols OML, RSL, GSL (GPRS) and TRA (TRAU). Decode them in a way suitable for human consumption. Change-Id: I5b11e64ca252b7349900ba5b700c2faefd568441 Reviewed-on: https://code.wireshark.org/review/18452 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1e65231798507b6bd41951d69d6098f3a4b470af commit 1e65231798507b6bd41951d69d6098f3a4b470af Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 22 14:42:58 2016 +0200 packet-ehdlc: Decode details of XID messages We so far only dumped the XID as raw hex bytes. Now we actually decode the header and internal data structure of the XID. Change-Id: I2901486222d84166291e071bc07cb82a2f480974 Reviewed-on: https://code.wireshark.org/review/18461 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3e82f423d9912c52900100e8c80a7e63d799e047 commit 3e82f423d9912c52900100e8c80a7e63d799e047 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 21 20:45:59 2016 +0200 gsm_abis_om2000: Dissect TLV structure of 0xa3/0xa5/0xa6 TLVs We have no idea what those TLVs are, but the message hex-dumps clearly indicate a 8-bit tag followed by 8-bit length and then 'length' amount of bytes, so we can at least dissect that high-level structure for now. They appear in equally unknown message type 0x126, which appears to be sent in intervals of 300s by the RBS. Change-Id: I91817eb20de1a4557399235c1fc42b638b9c935b Reviewed-on: https://code.wireshark.org/review/18460 Petri-Dish: Michael Mann <mmann78 at netscape.net> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=517e777816840ca01e28f57fde6d822356028859 commit 517e777816840ca01e28f57fde6d822356028859 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Tue Oct 25 21:19:26 2016 +0200 NAS EPS: use E212_TAI fields for TAI and TAI List Information Elements Change-Id: If53bfea77ad27b41823d3a653513b71604b92d49 Reviewed-on: https://code.wireshark.org/review/18464 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=40ce00fc8b4fdf389c6c382d9fe5418c84b0d5cb commit 40ce00fc8b4fdf389c6c382d9fe5418c84b0d5cb Author: Harald Welte <laforge at gnumonks.org> Date: Sun Oct 16 14:07:39 2016 +0200 gsm_abis_tfp: Fix bit-mask for frame type The frame type is only a select number of bits in the given byte, so we must make sure to mask all other bits away using 0x1E. Change-Id: I6c7a1a256bd93b6e5149f50ed64f033836a26673 Reviewed-on: https://code.wireshark.org/review/18458 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=180cbcf4365e57967f9fdf33b7570da0aec969be commit 180cbcf4365e57967f9fdf33b7570da0aec969be Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 15 22:01:51 2016 +0200 gsm_abis_om2000: Add "TG" and "DP" MO Class names Change-Id: Ice9d0601b2b1aa0691b7fcacaf61b4e287c7725c Reviewed-on: https://code.wireshark.org/review/18455 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ff41263fe3f78cd5b080789e9ec50ce779ef6494 commit ff41263fe3f78cd5b080789e9ec50ce779ef6494 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 15 23:26:17 2016 +0200 packet-rsl: Add some extensions to RSL shared by Osmocom + Ericsson Activation of (dynamic) PDCH uses some slight extensions of the definitions found in 3GPP TS 48.058 when used on Ericsson RBS2000 or Osmocom OsmoBTS. The extensions are backwards-compatible, so I don't think it's worth to introduce a preference for this. Change-Id: I8e28d75bd8be15044a605ced8825b9b074ffbb22 Reviewed-on: https://code.wireshark.org/review/18457 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d8db5646efc17dec73426e3745a9c9ef704a91c7 commit d8db5646efc17dec73426e3745a9c9ef704a91c7 Author: Snaipe <franklinmathieu at gmail.com> Date: Tue Oct 25 00:56:37 2016 +0200 lua: Added support for FT_IPv6 fields * Implement Tvb:ipv6() * Handle FT_IPv6 protofields during insertion in the lua tree * Implement Address.ipv6(hostname) Change-Id: I585c392681b3aef02ed8ee956f74051d77fb28d4 Signed-off-by: Franklin "Snaipe" Mathieu <snaipe at diacritic.io> Reviewed-on: https://code.wireshark.org/review/18442 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=60a926dc32dfc5333961752e902c19d83b98d2ca commit 60a926dc32dfc5333961752e902c19d83b98d2ca Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 21:13:14 2016 +0200 pop: use ws_strtoi function. Change-Id: Icaaa73a0dc9e0ffb7a1c37de9138857c45dcc56c Reviewed-on: https://code.wireshark.org/review/18400 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=346bda4238033fb146d6a7e7f21ecd714da396a2 commit 346bda4238033fb146d6a7e7f21ecd714da396a2 Author: Hessam Jalali <hessam.jalali at gmail.com> Date: Tue Oct 25 11:59:54 2016 +0330 e212: added 3 new filters (CGI, ECGI, TAI) Added these new filters to enhance mcc/mnc filtering in GTP protocol. Change-Id: I595b5fde4fa358886fbe5c58f6ecab496d9ef08c Reviewed-on: https://code.wireshark.org/review/18444 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c63f89515985a8db0aa8a500b1832474619090aa commit c63f89515985a8db0aa8a500b1832474619090aa Author: ruengeler <ruengeler at wireshark.org> Date: Wed Oct 19 17:10:53 2016 +0200 SCTP: find right assoc id Change-Id: I107b7f4c585ef5e080d6473a37b3db9a97f12365 Reviewed-on: https://code.wireshark.org/review/18325 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ae88dbcc2a990218549e06e143908eed1223ad8a commit ae88dbcc2a990218549e06e143908eed1223ad8a Author: erikdejong <erikdejong at gmail.com> Date: Sat Oct 22 11:32:51 2016 +0200 Qt: Enhancements to VoIP call dialog: 1) Added checkbox to toggle format in start and stop time columns from relative time to time of day. 2) Added column to show duration of call in between the protocol and packets column. Change-Id: I56347fa36885e3a71646e2c9cdde2b8b5fb88846 Reviewed-on: https://code.wireshark.org/review/18383 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5b216db2876904400e7442805d6a7b52ddb4e0bc commit 5b216db2876904400e7442805d6a7b52ddb4e0bc Author: Hessam Jalali <hessam.jalali at gmail.com> Date: Mon Oct 24 12:55:29 2016 +0330 e212: fix for e212.sai in GTP packet geo location type 1 represents SAI, but for GTP v1 it is returned as e212, hence not aggregating with GTP v2 the patch also opens up a way to add e212.cgi (Cell Global Identity) which is shared between GTP vesions. Change-Id: I853cd26037533aac2735b9d965793362c16f3f04 Reviewed-on: https://code.wireshark.org/review/18428 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=446dbea4eb05cc5e4a363dbc22f7421c6527a3a4 commit 446dbea4eb05cc5e4a363dbc22f7421c6527a3a4 Author: Jeff Morriss <jeff.morriss.ws at gmail.com> Date: Mon Oct 24 11:31:25 2016 -0400 Fix a couple typos in the Diameter XML. Also: - Move new T6a/T6b AVPs into TGPP.xml (to keep them all together). - Put back a comment that was (accidentally?) deleted; add some similar notes in other places. Change-Id: I2a468aa3be0069cd8124dd9e5b0a27e333849059 Reviewed-on: https://code.wireshark.org/review/18433 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=26950539d6f87e2f2157ac6d2bf9e5173b780856 commit 26950539d6f87e2f2157ac6d2bf9e5173b780856 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Mon Oct 24 21:31:57 2016 +0200 semcheck: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I000f9df1e41cab7fa0132153ff95caf31f3f6a6a Reviewed-on: https://code.wireshark.org/review/17892 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=04761f220b77814bfd460da7026b61c7687f687a commit 04761f220b77814bfd460da7026b61c7687f687a Author: João Valverde <joao.valverde at tecnico.ulisboa.pt> Date: Sat Oct 22 22:33:23 2016 +0100 Add wmem_list_find_custom() Change-Id: I5c4f85df0a1899d629386581de2c2c3ec0812d54 Reviewed-on: https://code.wireshark.org/review/18440 Reviewed-by: João Valverde <j at v6e.pt> Petri-Dish: João Valverde <j at v6e.pt> Reviewed-by: Evan Huus <eapache at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=79de3f5e2986486b9a3ed55af86644ab746ffe65 commit 79de3f5e2986486b9a3ed55af86644ab746ffe65 Author: João Valverde <joao.valverde at tecnico.ulisboa.pt> Date: Sun Oct 16 04:26:14 2016 +0100 packet.c: split register_dissector into two separate functions Allows for better code reuse. Change-Id: I0f929e2548cf60905285d62c1095f85565a1c147 Reviewed-on: https://code.wireshark.org/review/18439 Petri-Dish: João Valverde <j at v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: João Valverde <j at v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=749ffd94d496561b269007a0fe0813d8be7df1bc commit 749ffd94d496561b269007a0fe0813d8be7df1bc Author: João Valverde <joao.valverde at tecnico.ulisboa.pt> Date: Mon Oct 10 21:07:39 2016 +0100 Remove some code duplication in packet.c Change-Id: I60d71e0e4e7f3c35bec33910ecf4230569a1718c Reviewed-on: https://code.wireshark.org/review/18438 Reviewed-by: João Valverde <j at v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=e226abdbb05b37564599c6b92cd669b40749f2f6 commit e226abdbb05b37564599c6b92cd669b40749f2f6 Author: João Valverde <joao.valverde at tecnico.ulisboa.pt> Date: Wed Oct 19 05:57:23 2016 +0100 Parenthesize HFILL_INIT macro properly Change-Id: Ib1c347a290f57a1173c876de6e3c6cb6f5a1ca19 Reviewed-on: https://code.wireshark.org/review/18436 Reviewed-by: João Valverde <j at v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=b5587379b7e31c8e418f51a7db9d836b33a7efe1 commit b5587379b7e31c8e418f51a7db9d836b33a7efe1 Author: Michael Mann <mmann78 at netscape.net> Date: Sat Oct 22 14:25:35 2016 -0400 Overhaul AMQP dissector 1. Remove AMQP_INCREMENT macro. Bounds checking mostly handled already by proto_tree_add_xxx and tvb_get_xxx. Needed to add a few more tvb_reported_length_remaining() calls for completeness. 2. Fill in some of the gaps of unaccounted for bytes. Still have way too many instances where bytes aren't claimed by a field. 3. Some small reordering of functions allowed for massive removal of formal declarations. 4. Add amqp_0_10_get_32bit_size_new to add a field, check for size and add expert info if size > 0xFFFF 5. Remove "hf_" from list type items as they are not real hf_ fields and could cause confusion. Also made items static. 6. Convert some FT_STRING and FT_BYTES fields to FT_UINT_STRING and FT_UINT_BYTES. Helps account for some "missing" bytes. Change-Id: I7ed269221d294ce89feacc0642b2070681288172 Reviewed-on: https://code.wireshark.org/review/18423 Petri-Dish: Michael Mann <mmann78 at netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e3ecb9310c9973f85f7d0bd06ef8cf7dc7ecf3c2 commit e3ecb9310c9973f85f7d0bd06ef8cf7dc7ecf3c2 Author: Parav Pandit <paravpandit at yahoo.com> Date: Mon Oct 24 11:43:25 2016 -0400 packet-infiniband: Added support to dissect ip cm request private data This patch adds support to dissect 36 bytes of private data of Table 560 of spec 1.3.1 whenever CM request message is of IP CM type. Change-Id: I66b65b066a0034cf95c4c4f38549882c265b7ef5 Tested-by: paravpandit at yahoo.com Reviewed-on: https://code.wireshark.org/review/18434 Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a9ec5f89ce8ab336becf20ae3c2f5b7d05edcb74 commit a9ec5f89ce8ab336becf20ae3c2f5b7d05edcb74 Author: João Valverde <joao.valverde at tecnico.ulisboa.pt> Date: Sun Oct 23 09:51:16 2016 +0100 IPv6: Remove some duplicate address code Change-Id: I3736d7f40479a05130db9da3032a952633180b0e Reviewed-on: https://code.wireshark.org/review/18426 Petri-Dish: João Valverde <j at v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: João Valverde <j at v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=def19eed53c1db319b8f1142d3ed8c00fceaf201 commit def19eed53c1db319b8f1142d3ed8c00fceaf201 Author: Jan Spevak <jan.spevak at nokia.com> Date: Mon Oct 24 10:17:08 2016 +0200 Update several AVPs according to latest 3GPP TS Change-Id: Iada3166c93801d3f693714ad8c08bd4f68a70d3e Reviewed-on: https://code.wireshark.org/review/18425 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7de4c2364d9d393ec252485b02957dffb0b4d72b commit 7de4c2364d9d393ec252485b02957dffb0b4d72b Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 21:28:40 2016 +0200 Qt: use ws_strtou function in sctp_chunk_statistics_dialog. Change-Id: Iffa2d633ef7a0f636c595fb05ad1790d1ea61df0 Reviewed-on: https://code.wireshark.org/review/18402 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8be90aa96002219ff8feba171e66d16655dc18bb commit 8be90aa96002219ff8feba171e66d16655dc18bb Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 21:05:00 2016 +0200 ajp13: use ws_strtoi function. Change-Id: Ibe85cbb993eba8e76ed6c645609e9cea114a6c9d Reviewed-on: https://code.wireshark.org/review/18399 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4f94dceee72d557693702e528a14eef76ba80a5b commit 4f94dceee72d557693702e528a14eef76ba80a5b Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 20:59:44 2016 +0200 catapult: use ws_strtou function. Change-Id: Iceaa2e0240a86dd6aed087617c0a3200b3170d38 Reviewed-on: https://code.wireshark.org/review/18398 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=cd64e4ece2e0e731fa9ffc07fead9420d46d8c1a commit cd64e4ece2e0e731fa9ffc07fead9420d46d8c1a Author: Guy Harris <guy at alum.mit.edu> Date: Mon Oct 24 02:19:50 2016 -0700 Move --fullscreen out of LONGOPT_CAPTURE_COMMON. It's not a capture option, so it doesn't belong there. Change-Id: I8aa6719a5a8e90c734c7acfc01b1ba2818498de3 Reviewed-on: https://code.wireshark.org/review/18427 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3acf73ec45d2548c0d8447d07a95b1b5710741fb commit 3acf73ec45d2548c0d8447d07a95b1b5710741fb Author: franciscojavier.sanchezroselly <franciscojavier.sanchezroselly at ujaen.es> Date: Fri Sep 23 14:32:01 2016 +0200 ICMPv6: Add support for LLN Routing Metrics (RFC 6551) Bug: 12951 Change-Id: I0b1985699ae853a295c1ddbe38d2861ed9cac21d Reviewed-on: https://code.wireshark.org/review/17889 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=c786aa56ad32cd820378756feff275b48ecb51a7 commit c786aa56ad32cd820378756feff275b48ecb51a7 Author: Guy Harris <guy at alum.mit.edu> Date: Mon Oct 24 01:15:59 2016 -0700 Fix a copy-and-pasteo. Fix the handling of the case of a "matches" operator with a field and a character constant as operands. Change-Id: I6451cee907d8486db96937173d0098de91ce7956 Reviewed-on: https://code.wireshark.org/review/18424 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=681b97a047fa10c050a86869e113f8ecb3f9d127 commit 681b97a047fa10c050a86869e113f8ecb3f9d127 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Tue Oct 4 09:10:38 2016 +0200 Qt: Make horizontal spacer size to be fixed The Search Frame can be used to find frames by a display filter expression that can be very long, so stretch a text field instead of free space. Example of a display filter expression that can be used in the "search bar": bthci_cmd.opcode == 0x200d || bthci_evt.le_meta_subevent == 0x0a Change-Id: I52b30386e96a726824c25a926742a24d653dfcfe Reviewed-on: https://code.wireshark.org/review/18234 Petri-Dish: Michal Labedzki <michal.labedzki at tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=3b502c873f2b30e661d46693d3a3f6fcba9474ea commit 3b502c873f2b30e661d46693d3a3f6fcba9474ea Author: Peter Wu <peter at lekensteyn.nl> Date: Sat Oct 22 23:29:56 2016 +0200 Qt: fix possible crash on sorting custom columns The sorting function must maintain a strict weak ordering, otherwise it may result in crashes. In the case of custom columns, this was violated when exactly one of the two rows had a non-numeric value. Bug: 13023 Change-Id: Ie338b1cce5156eeb313dd33491ee3d3f2eaddf1c Reviewed-on: https://code.wireshark.org/review/18406 Reviewed-by: Jim Young <jim.young.ws at gmail.com> Petri-Dish: Jim Young <jim.young.ws at gmail.com> Tested-by: Jim Young <jim.young.ws at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=20e2edca572a835ab4ee6ff1fbbf86bf5db54b35 commit 20e2edca572a835ab4ee6ff1fbbf86bf5db54b35 Author: Jeff Morriss <jeff.morriss.ws at gmail.com> Date: Sun Oct 23 21:45:33 2016 -0400 Add some Diameter AVPs referenced by (recently added) grouped AVPs. ... In order to make the Diameter XML valid again. This includes adding T6a/T6b and most of the AVPs of that application. Fix up some white space while at it. Change-Id: Ie39b3e574065628fdba215cc9c045eebcbd3077e Reviewed-on: https://code.wireshark.org/review/18422 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=af7fc8b7e4979e77d2d072789e98d58a0b175908 commit af7fc8b7e4979e77d2d072789e98d58a0b175908 Author: Dario Lombardo <lomato at gmail.com> Date: Wed Oct 19 20:53:40 2016 +0200 Qt: add fullscreen feature. The feature activates/deactivates fullscreen mode of Qt UI. A new menu item has been added as well as a shortcut (F11 or Ctrl+Cmd+F) according to browsers common shortcut. Change-Id: I01906b494d0a13ce70d27c00ebbe03e6ec87cbd7 Reviewed-on: https://code.wireshark.org/review/18332 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3156980aa559186a10e3b8566d41e4a50477d967 commit 3156980aa559186a10e3b8566d41e4a50477d967 Author: Parav Pandit <paravpandit at yahoo.com> Date: Thu Oct 20 07:06:07 2016 -0400 packet-infiniband: Fixed displaying reserved field 1. Added Extended transport type field instead of reserved as per latest release 1.3.1 in CM Req msg. 2. Defined reserved bits and bytes for CM messages 3. Minor code refactor to move to smaller functions for CM Req Rsp parsing instead of 200+ lines function which is hard to read and is expected to grow for more features 4. Cleanup around primary and alternate fields which were crossing byte boundary CM request and response messages are tested. Reject message reserved fields change is untested but it a minor change that is expected to work. Change-Id: I94da62614f854218249b4e14c780f4168f44751c Reported-by: Alexis La Goutte Tested-by: paravpandit at yahoo.com Reviewed-on: https://code.wireshark.org/review/18340 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=875b3e2732e8ad20f87ef940300605080a807132 commit 875b3e2732e8ad20f87ef940300605080a807132 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Oct 23 19:20:15 2016 +0200 ZigBee: fix the first parameter of memcpy key_record.key is already a pointer on an array Change-Id: I9bcc715be54817f8daa3928fff72d9ef98d586f9 Reviewed-on: https://code.wireshark.org/review/18417 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a3a20531b1a7ae2bb8b48ca25fbe27f10e2462a9 commit a3a20531b1a7ae2bb8b48ca25fbe27f10e2462a9 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Oct 23 18:51:09 2016 +0200 ZigBee Green Power: fix loading of keys during runtime Register a post update calback to ensure that the keys are loaded for all entries and not only the ones last edited Bug: 13031 Change-Id: Ib670f9e1c702546631df5fe6094b02484806dd00 Reviewed-on: https://code.wireshark.org/review/18416 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3c3f592ebc9e84a7c77bb50bf45ae7222dcd8a4c commit 3c3f592ebc9e84a7c77bb50bf45ae7222dcd8a4c Author: Gerald Combs <gerald at wireshark.org> Date: Sun Oct 23 08:11:53 2016 -0700 [Automatic update for 2016-10-23] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I5127251ce46aa668cd12daacc7c6702564c04c8f Reviewed-on: https://code.wireshark.org/review/18412 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=3576394ed4fc782ce5a2151c88c5a10b37cb3393 commit 3576394ed4fc782ce5a2151c88c5a10b37cb3393 Author: Martin Kaiser <wireshark at kaiser.cx> Date: Sat Oct 22 19:53:00 2016 +0200 interface_sort_filter_model: don't dereference a NULL pointer This fixes a crash in InterfaceSortFilterModel::mapToSource(). sourceModel was set to match the sourceModel of the underlying InterfaceFrame. When Wireshark is closed, InterfaceSortFilterModel::mapToSource() is called after InterfaceFrame was freed, the sourceModel is NULL in this case. #0 0x000000000079a81e in InterfaceSortFilterModel::mapToSource (this=0xe9fab0, proxyIndex=...) /home/martin/src/wireshark.git/ui/qt/interface_sort_filter_model.cpp:250 ... #7 0x0000000000797ed9 in InterfaceTreeModel::~InterfaceTreeModel (this=0xe9ff90, __in_chrg=<optimized out>) at /home/martin/src/wireshark.git/ui/qt/interface_tree_model.cpp:72 #8 0x00000000006c4e20 in InterfaceFrame::~InterfaceFrame (this=0xe643b0, __in_chrg=<optimized out>) at /home/martin/src/wireshark.git/ui/qt/interface_frame.cpp:109 #9 0x00000000006c4ec9 in InterfaceFrame::~InterfaceFrame (this=0xe643b0, __in_chrg=<optimized out>) at /home/martin/src/wireshark.git/ui/qt/interface_frame.cpp:112 Change-Id: Ibe7f75ccd7a0af5f04febf967c47ada1a05bc3d3 Reviewed-on: https://code.wireshark.org/review/18411 Reviewed-by: Martin Kaiser <wireshark at kaiser.cx> Petri-Dish: Martin Kaiser <wireshark at kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=892246acb02868ee4be14543521a20b9818184d6 commit 892246acb02868ee4be14543521a20b9818184d6 Author: Joakim Karlsson <oakimk at gmail.com> Date: Sun Oct 23 01:44:11 2016 +0200 diameter: improvement of AVP 1066 Printing ascii value in the same way as AVP 1005 Change-Id: I058be87974bf8197e207fdd61be6354031ed8d35 Reviewed-on: https://code.wireshark.org/review/18409 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=903eab03798d636cc3cebd1fd08e0097190c745d commit 903eab03798d636cc3cebd1fd08e0097190c745d Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 20:20:26 2016 +0200 sip: use ws_strtoi functions. Change-Id: I69cdc1118f62ed86661ccfb9fb522ad0bb00596e Reviewed-on: https://code.wireshark.org/review/18397 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2e962d368a6f19d8a32a997dfa144eb3794009ef commit 2e962d368a6f19d8a32a997dfa144eb3794009ef Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 15:40:33 2016 +0200 dtls: use ws_strtoi function. Change-Id: I4feacfa8e4739faf555c05e3c4823ad8487a994c Reviewed-on: https://code.wireshark.org/review/18392 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6b2579801445e25e49b85c4f71283e07858ba6b7 commit 6b2579801445e25e49b85c4f71283e07858ba6b7 Author: Martin Kaiser <wireshark at kaiser.cx> Date: Sat Oct 22 17:38:50 2016 +0200 fc00: get rid of if(tree) Make sure that the newly added expert info will show up in the expert info window. Expert infos should never be under if (tree). Change-Id: I55daa693d4dc910eab38028340a934062d351e98 Reviewed-on: https://code.wireshark.org/review/18393 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1c7b431a75bba97c46b54d150d6e5a3fe9f78a6a commit 1c7b431a75bba97c46b54d150d6e5a3fe9f78a6a Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sat Oct 22 23:13:10 2016 +0200 LSD: avoid dereferencing a null pointer Bug: 13038 Change-Id: I701aa8cf89d8c53091974d6329f340316df8a870 Reviewed-on: https://code.wireshark.org/review/18405 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ed187592ae8479f6e6eaea7f78f936a37db4471b commit ed187592ae8479f6e6eaea7f78f936a37db4471b Author: Joakim Karlsson <oakimk at gmail.com> Date: Sun Oct 23 00:41:30 2016 +0200 diameter: add new standardized QCI Change-Id: If8c29934515b61081d0cbd44a0356144d5d3c466 Reviewed-on: https://code.wireshark.org/review/18407 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d3b2ee9b0c41478d627e90e8a9ef3b5e02512b43 commit d3b2ee9b0c41478d627e90e8a9ef3b5e02512b43 Author: Dario Lombardo <lomato at gmail.com> Date: Sat Oct 22 21:28:09 2016 +0200 wsutil: add statements for c++ calls. Change-Id: I082eb462b0a6ce77f9ca82c51d79d65516c92b53 Reviewed-on: https://code.wireshark.org/review/18401 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6b03eea7143c4fb41110e8de3a16a31146300fe7 commit 6b03eea7143c4fb41110e8de3a16a31146300fe7 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sat Oct 22 19:15:38 2016 +0200 GTPv2: add dissection of a few Information Elements This commit adds the following IEs: - CSG ID - CSG Membership Indication (CMI) - Service Indicator - Detach Type - Local Distinguished Name (LDN) Change-Id: I1e3db7ffd217e3644acf6de0ad5002e65c73a9ea Reviewed-on: https://code.wireshark.org/review/18396 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=812e5fd893915591cd7cea34f275efc0c30cdd0a commit 812e5fd893915591cd7cea34f275efc0c30cdd0a Author: boris.bochkarev <Boris-Bochkaryov at yandex.ru> Date: Thu Oct 20 17:45:53 2016 +0700 AMPQ: Fix malformed packed in session.expected and session.confirmed. Bug: 13037 Change-Id: I935ff68050eb085789d9bd99b5ec833609c6fdca Reviewed-on: https://code.wireshark.org/review/18336 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=48972d883fb8865e37b83a8b8ded2ff270ca9b38 commit 48972d883fb8865e37b83a8b8ded2ff270ca9b38 Author: Martin Kaiser <wireshark at kaiser.cx> Date: Sat Oct 22 12:02:50 2016 +0200 tpncp: load hf array in the handoff function tpncp reads hf entries from a database. There's a boolean preference defining if the database is actually read. We can't access this preference until the preferences are initialized. The code as it is now wil always default to false and never read the database. Check the preference in the handoff function and initialize the hf entries if they are not yet initialized. Change-Id: I545a49a946b78e1a0bc23e9803eb671d8765bba4 Reviewed-on: https://code.wireshark.org/review/18386 Reviewed-by: Martin Kaiser <wireshark at kaiser.cx> Petri-Dish: Martin Kaiser <wireshark at kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=49a525a97e68f9ba5b840c3054669a5dd6081010 commit 49a525a97e68f9ba5b840c3054669a5dd6081010 Author: Martin Kaiser <wireshark at kaiser.cx> Date: Fri Oct 21 19:47:11 2016 +0200 fc00: skip sha512 calculations for glib < 2.36 Our minimum supported version of glib is 2.22 at the moment. SHA512 support was added in glib 2.36. Bring up an expert info if checksum calculation is not supported by our glib version. Change-Id: I116b32f63a4342a7e4198eaae8a35189fcc92edc Reviewed-on: https://code.wireshark.org/review/18391 Reviewed-by: Martin Kaiser <wireshark at kaiser.cx> Petri-Dish: Martin Kaiser <wireshark at kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ce9405b00b0bc49fef5a21f984251a1e0065580b commit ce9405b00b0bc49fef5a21f984251a1e0065580b Author: Jakub Zawadzki <darkjames-ws at darkjames.pl> Date: Fri Oct 21 18:43:06 2016 +0200 cleanup: move extra libs to EPAN_EXTRA_LIBS Every program linking with epan lib added some extra dependencies. Keep these in EPAN_EXTRA_LIBS. Change-Id: I3fac0974ef6a46675d35ee7b9862674923369b67 Reviewed-on: https://code.wireshark.org/review/18356 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=28bbd565917d59b20458e5de783096bc332c1965 commit 28bbd565917d59b20458e5de783096bc332c1965 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sat Oct 22 18:15:51 2016 +0200 Add SBC decoding support to Windows Change-Id: Ibef872dff26c22e2834e958c496c33a5695bb131 Reviewed-on: https://code.wireshark.org/review/18394 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a2d49125a52e0eb21215368a7e1f248b6d4a6c06 commit a2d49125a52e0eb21215368a7e1f248b6d4a6c06 Author: Martin Kaiser <wireshark at kaiser.cx> Date: Sat Oct 22 18:26:47 2016 +0200 cmake, qt4: check if QT4_FOUND AFAICS, FindQt4.cmake sets QT4_FOUND, not Qt4_FOUND This fixes compilation on Debian Wheezy (cmake 2.8.9, Qt 4.8.2). Change-Id: I08b3ac6ae4292b8c8d3f9e8752780459e5329e29 Reviewed-on: https://code.wireshark.org/review/18395 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=44cf0bdccfc36e11419b1a9bf3d72ac0db13d58b commit 44cf0bdccfc36e11419b1a9bf3d72ac0db13d58b Author: Martin Kaiser <wireshark at kaiser.cx> Date: Sat Oct 22 12:15:49 2016 +0200 main_welcome: include QUrl This fixes compilation with Qt4. .../main_welcome.cpp: In member function âvoid MainWelcome::on_helpLabel_clicked()â: .../main_welcome.cpp:509:69: error: invalid use of incomplete type âclass QUrlâ Change-Id: Ib31a4e28f67a27d3f644e8a8cfd3e6d848e034c4 Reviewed-on: https://code.wireshark.org/review/18388 Reviewed-by: Martin Kaiser <wireshark at kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=e85882940419dd9ce012489689e13ae4b18be04e commit e85882940419dd9ce012489689e13ae4b18be04e Author: Gerald Combs <gerald at wireshark.org> Date: Fri Oct 21 16:05:10 2016 -0700 CMake: Disable Qt4 && (Windows || macOS). We haven't built the Windows and macOS installers with Qt4 for quite some time. In the case of macOS+Qt4 it looks like there's a problem with the main screen size (bug 13009) and it's a safe bet that there are other problems. There's not much we can do exept say "don't do that." Do so at build time rather than after the user has installed Wireshark and is trying to use it. Change-Id: I22f47b9705ea044238046676b6336aa5feab3f60 Reviewed-on: https://code.wireshark.org/review/18364 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7dfaec969e67e3aa14b9763d804802ef614c9ddd commit 7dfaec969e67e3aa14b9763d804802ef614c9ddd Author: Peter Wu <peter at lekensteyn.nl> Date: Fri Oct 21 00:50:03 2016 +0200 alljoyn: fix signature length adjustments Ensure that the signature pointer and length always matches, otherwise a buffer overrun (read) is possible. Tested with the original captures from bug 12953, the PDML output is still the same while the fuzzed capture does not crash anymore. Bug: 12953 Change-Id: I8843a5daf98a79fb19906e824326cdf619164484 Reviewed-on: https://code.wireshark.org/review/18347 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Martin Kaiser <wireshark at kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=e80a8acbe3cb0d0bdefeff51292bd90c3461a02a commit e80a8acbe3cb0d0bdefeff51292bd90c3461a02a Author: Guy Harris <guy at alum.mit.edu> Date: Sat Oct 22 03:18:06 2016 -0700 Clean up conditional code for getting creation time. Define a macro to get the creation time from a stat structure, or to return 0 if the creation time is unavailable, and use that in both places where we fetch the creation time. Change-Id: I15354f2d52a40cb1227f30ae274120575eec2055 Reviewed-on: https://code.wireshark.org/review/18387 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5f68435a079dc7ce633e1da22f363e4e715d66f6 commit 5f68435a079dc7ce633e1da22f363e4e715d66f6 Author: Guy Harris <guy at alum.mit.edu> Date: Sat Oct 22 01:56:48 2016 -0700 Fix the #defines for the presence of structure names. AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the {structurename} being the name of the structure type, complete with "struct" if a typedef wasn't used, and with all letters mapped to upper case, and with {membername} being the name of the structure member, with all letters mapped to upper case. check_struct_has_member() lets you choose the name; choose the same name that the autoconf macros use, and fix the code to check for them. Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b Reviewed-on: https://code.wireshark.org/review/18382 Petri-Dish: Guy Harris <guy at alum.mit.edu> Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d32fee2d6252c485dacdf51441d7ba5c6d37d7f3 commit d32fee2d6252c485dacdf51441d7ba5c6d37d7f3 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Fri Oct 7 11:52:32 2016 +0200 Qt/Bluetooth: Add Display Filter Edit field to HCI Summary dialogue Display Filter can be useful for this summary dialogue, for example to reduce number of frame that were analyzed, like: "frame.number >= 100 && frame.number <= 4674" Change-Id: I19587b9d41f3b253d1ca2683d198f7d7af2ad50f Reviewed-on: https://code.wireshark.org/review/18265 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> Tested-by: Michal Labedzki <michal.labedzki at tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=0cb4d0d346a9cf39135ef12c9eb65e727c14b3dc commit 0cb4d0d346a9cf39135ef12c9eb65e727c14b3dc Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sat Oct 22 09:20:10 2016 +0200 C1222: update auto generated file Change-Id: I9c29ebe0ef24dcf9f5db5f5e767f910644bb9762 Reviewed-on: https://code.wireshark.org/review/18379 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a63b5eb711cc50efe2725d716e0774e147376d25 commit a63b5eb711cc50efe2725d716e0774e147376d25 Author: Gerald Combs <gerald at wireshark.org> Date: Thu Oct 20 14:35:20 2016 -0700 Qt: Make "Learn" on the welcome screen clickable. Make the "Learn" header a ClickableLabel to match "Open" and "Capture". Link to the docs page for now. Adjust its stylesheet and properties to match ast well. Change-Id: Id9c7c05269de8134af28f0f9c1e2820a60442236 Reviewed-on: https://code.wireshark.org/review/18358 Reviewed-by: Gerald Combs <gerald at wireshark.org> Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=528894e72f973c5db5dc76c975620754f7bbe5aa commit 528894e72f973c5db5dc76c975620754f7bbe5aa Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 22:19:46 2016 -0700 On UN*X, st_ctime is the last status change time, not the creation time. That's the time the file's inode last changed, so size changes, permission changes, etc. affect it. It's *not* the time the file was created; most UN*Xes don't provide that. Newer versions of FreeBSD, NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to. On Windows, at least according to Microsoft's documentation, st_ctime *is* the creation time. Hopefully that's not the result of confusion on the part of somebody at Microsoft. Change-Id: I20743703f6ef66e40dff9004dc91bed46af6fad0 Reviewed-on: https://code.wireshark.org/review/18378 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d16295bc9b48a526f12237467536bac4220e53da commit d16295bc9b48a526f12237467536bac4220e53da Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 20:46:48 2016 -0700 Suppress "discarding const" warning. Change-Id: I5f97b70d7f423cb5b7792863fb2bd07516aa1951 Reviewed-on: https://code.wireshark.org/review/18375 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=321b756dc41f9bc26cc0eb8b08f90a73158dc75a commit 321b756dc41f9bc26cc0eb8b08f90a73158dc75a Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Fri Oct 21 10:10:06 2016 +0200 Add T.61 character set support Bug: 13032 Change-Id: I6bf2cc2c43a6262d899a304df6576d9831115966 Reviewed-on: https://code.wireshark.org/review/18350 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=53d3e3c25ef7037ba28b93dd684f5de4c015767f commit 53d3e3c25ef7037ba28b93dd684f5de4c015767f Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 19:53:32 2016 -0700 Fix some errors from the previous commit. Pro tip: if you're modifying GTK+ code, make sure you explicitly configure to build the GTK+ version. Change-Id: Ia24321a5037dff67d9acf1444fa0b74f5aed089e Reviewed-on: https://code.wireshark.org/review/18371 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=10ca4c7527122efde0300205deaa6c0143f07219 commit 10ca4c7527122efde0300205deaa6c0143f07219 Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 19:18:15 2016 -0700 More checks for localtime() and gmtime() returning NULL. And some comments in the case where we're converting the result of time() - if your machine's idea of time predates January 1, 1970, 00:00:00 UTC, it'll crash on Windows, but that's not a case where a *file* can cause the problem due either to a bad file time stamp or bad time stamps in the file. Change-Id: I837a438e4b875dd8c4f3ec2137df7a16ee4e9498 Reviewed-on: https://code.wireshark.org/review/18369 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=49cf42c571f3f94632957371ccd99533e71764ff commit 49cf42c571f3f94632957371ccd99533e71764ff Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 17:08:03 2016 -0700 localtime() can return NULL, even if it's unlikely. ANSI C says it can return NULL - and, at least on Windows with the MSVC library, it *will* return null for dates prior to the Epoch. Check for a null return and handle it. Fixes CID 1374109. Change-Id: Ib18566d1a75e4109adb21834b157e87532fcac10 Reviewed-on: https://code.wireshark.org/review/18365 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b3363fbbdee8b785c849c24a265fdbe28c28f608 commit b3363fbbdee8b785c849c24a265fdbe28c28f608 Author: Mirko Parthey <mirko.parthey at web.de> Date: Fri Oct 21 00:31:44 2016 +0200 ISAKMP: update protocol parameters Update IKE authentication methods and config attributes. Change-Id: I103beaf79eebaa0704424ad89f4d38a2701ae50b Reviewed-on: https://code.wireshark.org/review/18357 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=362b83f44a4a6a731c64f8a6591ee717af2454a0 commit 362b83f44a4a6a731c64f8a6591ee717af2454a0 Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 15:48:34 2016 -0700 gmtime() can return NULL, even if it's unlikely. ANSI C says it can return NULL - and, at least on Windows with the MSVC library, it *will* return null for dates prior to the Epoch. Check for a null return and handle it. Fixes CID 1374110. Change-Id: I78bf92cfbb94a86544442269cc3b53338eb19778 Reviewed-on: https://code.wireshark.org/review/18361 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1b9d46a9502843c15c33891955f6242c883aa1a5 commit 1b9d46a9502843c15c33891955f6242c883aa1a5 Author: Peter Wu <peter at lekensteyn.nl> Date: Thu Oct 20 23:46:16 2016 +0200 tests: do not invoke missing unit tests If the "test-programs" target is not built, then it should not try to invoke the last program (wireshark-gtk in my case). Change-Id: Ida60a71d1dc47305ef8abe10e6c96c8a1cb8dcbb Reviewed-on: https://code.wireshark.org/review/18346 Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=a6d81effbc23acce59fd88b8f828fe8c753eeb0d commit a6d81effbc23acce59fd88b8f828fe8c753eeb0d Author: Guy Harris <guy at alum.mit.edu> Date: Fri Oct 21 15:29:59 2016 -0700 Clean up file handle management. The main reason fclose() could fail is if the file is open for writing, not all the buffered data has been written out at the time fclose() was called, and the attempt to write it out fails. In any case, the file handle is no longer valid after fclose() completes, whether the close succeeds or not, so there's no reason to keep it around. There's no reason to check whether it's null in a loop called in code where it's not null to start with and where it's not set to null in the loop. This should fix CID 1374111. Change-Id: Ib8067a17731b41d6b184a5a415addc2ecaa7c00c Reviewed-on: https://code.wireshark.org/review/18359 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7f6a4926d2f6a135960146041c29802db616aa63 commit 7f6a4926d2f6a135960146041c29802db616aa63 Author: Peter Wu <peter at lekensteyn.nl> Date: Thu Oct 20 23:33:48 2016 +0200 test: make GTK support optional Current Ubuntu buildbot is failing because GTK support was removed. Tests should not fail if GTK is not available, so make it optional. Change-Id: I1640c8bcea5208299f6846eb366e105c39a3ebf3 Reviewed-on: https://code.wireshark.org/review/18345 Reviewed-by: Gerald Combs <gerald at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=10a1e8d261d30ce30300c6f51863b74184e61bd5 commit 10a1e8d261d30ce30300c6f51863b74184e61bd5 Author: Mirko Parthey <mirko.parthey at web.de> Date: Fri Oct 21 00:31:44 2016 +0200 ISAKMP: fix typos and whitespace Change-Id: I8fd34acac2562ffea6f1e726b71d63f9f631bb54 Reviewed-on: https://code.wireshark.org/review/18355 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=d142e7f4038f840ec2d7d89a1de4d486e1f54222 commit d142e7f4038f840ec2d7d89a1de4d486e1f54222 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Fri Oct 21 10:41:52 2016 +0200 Fix build for Qt 4.8 setCurrentText is only available in Qt5, so select the item manually. https://doc.qt.io/qt-5/qcombobox.html#currentText-prop Fixes: v2.3.0rc0-1002-g1cd2255 ("Qt: convert UatDialog to model/view pattern, improve UX") Change-Id: I402e7d159d512e870849ee54d851276c4cc7cf34 Reviewed-on: https://code.wireshark.org/review/18351 Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki at tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=991e0747a3b0bbeddb27dc29e53fa6dbb5c68e4b commit 991e0747a3b0bbeddb27dc29e53fa6dbb5c68e4b Author: Peter Wu <peter at lekensteyn.nl> Date: Fri Oct 21 13:59:11 2016 +0200 Qt: fix weird tree expander that results in a crash According to the Qt documentation, rowCount and columnCount must return 0 when a valid parent index is passed to a table model. Otherwise deep recursion would occur resulting in a stack overflow in Qt4. Change-Id: I60bb15384470861013591e149c0f285ea1bdf9a7 Fixes: v2.3.0rc0-1002-g1cd2255 ("Qt: convert UatDialog to model/view pattern, improve UX") Reviewed-on: https://code.wireshark.org/review/18354 Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki at tieto.com> Tested-by: Michal Labedzki <michal.labedzki at tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=67bfdf28714a5945a78aef9d745d88fd69972578 commit 67bfdf28714a5945a78aef9d745d88fd69972578 Author: Roland Knall <rknall at gmail.com> Date: Fri Oct 21 11:28:18 2016 +0200 capchild: Fix loading of extcap with no winpcap.dll If the loading of the physical interface list failed, no extcap interfaces will be loaded as well. Fix that, so that we search for the extcap interfaces, even when no other interfaces have been found Change-Id: Ib8e86f1f8d2a1565724ef3532d41ecea3ceddb55 Reviewed-on: https://code.wireshark.org/review/18352 Reviewed-by: Roland Knall <rknall at gmail.com> Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=25207d70bb9938c2c00ddc0e26f5c85d9d8616ca commit 25207d70bb9938c2c00ddc0e26f5c85d9d8616ca Author: Anders <anders.broman at ericsson.com> Date: Fri Oct 21 12:20:59 2016 +0200 [Diameter] Add some 3GPP AVPs fom TS 39.299 v 14.1.0 Change-Id: Ie3995e81de8faee844dbcb794796ecacb6bfe28e Reviewed-on: https://code.wireshark.org/review/18353 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b50888de9994efdbd8851e8992d6bec31f9d0b89 commit b50888de9994efdbd8851e8992d6bec31f9d0b89 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Fri Oct 21 08:17:54 2016 +0200 WelcomeUI: Enhance Open and Capture clickable labels Open and Capture are now clickable labels, but they are sensitive throughout the whole width of the central column. Without background highlighting, as in the file list, this may be non-intuative. To more closely resemble a button, limit the sensitivity to the text of the label only, by limiting the label size. Change-Id: I0b703af02abc71a48dfbcee81f336bba955b4a70 Reviewed-on: https://code.wireshark.org/review/18349 Petri-Dish: Stig Bjørlykke <stig at bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=efde624a11b82d3d51925d5f94ff5bedeafe1e03 commit efde624a11b82d3d51925d5f94ff5bedeafe1e03 Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Thu Oct 20 18:51:20 2016 +0300 ZigBee Green Power: add dissector for Sink Commissioning Mode cmd Change-Id: I9775927781a38ff6fd112247c59a60cf1a80ba08 Reviewed-on: https://code.wireshark.org/review/18341 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3756c0e24db61eb451ad732a45e0b2b94c5a846f commit 3756c0e24db61eb451ad732a45e0b2b94c5a846f Author: Mirko Parthey <mirko.parthey at web.de> Date: Fri Oct 21 00:05:36 2016 +0200 ISAKMP: Fix defragmentation of EAP-TLS in IKEv2 Remove NULL check to ensure IKEv2 encrypted payloads are dissected during first pass, which is required for EAP-TLS fragment reassembly. Change-Id: I7fd46ee2163188c1a8dd256a43f1457441b1b95a Reviewed-on: https://code.wireshark.org/review/18348 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=53400e0d33a5c4f94859c024f9efa9a562daf492 commit 53400e0d33a5c4f94859c024f9efa9a562daf492 Author: Peter Wu <peter at lekensteyn.nl> Date: Wed Oct 19 12:19:02 2016 +0200 cmake/FindPOD: improve parallelism HTML and manual pages can be generated in parallel. Change-Id: I2301e8bdc5ae1179a8ac0c24f412e5435993a764 Reviewed-on: https://code.wireshark.org/review/18281 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=511e80128e15be8ce2bcdca912d599217fa8ebd6 commit 511e80128e15be8ce2bcdca912d599217fa8ebd6 Author: Balint Reczey <balint at balintreczey.hu> Date: Tue Oct 18 13:52:04 2016 +0200 debian: Ship ciscodump and sshdump Both binaries use libssh. Libssh can be linked to OpenSSL or to Libgcrypt. Since the ciscodump and sshdump executables are covered by GPL-2+ the Debian package build depends on the libssh flavor built with libgcrypt. Change-Id: If2dd85beb08e4b04f0c3aac46966fce67828b473 Reviewed-on: https://code.wireshark.org/review/18263 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=3fb32662a861fffbdda802a0bb7fd359f2a837fd commit 3fb32662a861fffbdda802a0bb7fd359f2a837fd Author: Roland Knall <rknall at gmail.com> Date: Thu Oct 20 09:34:49 2016 +0200 InterfaceList: Add button to toggle hidden interfaces Add a button to the context menu, to allow for easy display of hidden interfaces, and make that a storable preference Change-Id: I8df5562b3ce8119b0ed38f9893c1879127f40c47 Reviewed-on: https://code.wireshark.org/review/18005 Petri-Dish: Roland Knall <rknall at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4a87ecb52bbc51d0cce7a7a8d5c5f61303e524fa commit 4a87ecb52bbc51d0cce7a7a8d5c5f61303e524fa Author: Dario Lombardo <lomato at gmail.com> Date: Thu Oct 20 13:45:10 2016 +0200 Qt: remove unused private member (found by clang). Error: ui/qt/wlan_statistics_dialog.cpp:462:9: error: private field 'retry_packets_' is not used [-Werror,-Wunused-private-field] Change-Id: I10785eab098db14a53ef8085421c0f1046c269f3 Reviewed-on: https://code.wireshark.org/review/18337 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=269b54c2e0c323d22e2f6c9d75ef61d96ce83c02 commit 269b54c2e0c323d22e2f6c9d75ef61d96ce83c02 Author: Mikael Kanstrup <mikael.kanstrup at sonymobile.com> Date: Wed Oct 19 16:24:59 2016 +0200 Fix compilation error without PCAP (using correct define) Incorrect define HAVE_PCAP was checked for. That one was never set even with PCAP enabled and thus broke the wireless toolbar functionality. Change-Id: I856c836de75b198340661d5e5b734c7d8ada70ac Reviewed-on: https://code.wireshark.org/review/18335 Reviewed-by: Dario Lombardo <lomato at gmail.com> Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7b38c6bf3a6f473a510f668162daff52d8df7e2a commit 7b38c6bf3a6f473a510f668162daff52d8df7e2a Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Thu Oct 20 13:00:26 2016 +0300 ZigBee Green Power: add dissectors for some GP Cluster attributes Change-Id: I80df7ff3a69998be40db67b538a7af719e29782d Attributes: gppFunctionality, gppActiveFunctionality, gpsFunctionality, gpsActiveFunctionality, gpsCommissioningExitMode, gpsCommunicationMode and gpsSecurityLevel Reviewed-on: https://code.wireshark.org/review/18333 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a9b391dcb28967f433c38d79319656137b9520ed commit a9b391dcb28967f433c38d79319656137b9520ed Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Thu Oct 20 15:16:14 2016 +0200 NAS EPS: add a missing space Change-Id: I0339b7a70f0fd7b9bef43922d1093f9392c0eefe Reviewed-on: https://code.wireshark.org/review/18338 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c9fa9b51dea34dc5576c61c14633753b2bcc5768 commit c9fa9b51dea34dc5576c61c14633753b2bcc5768 Author: Peter Wu <peter at lekensteyn.nl> Date: Wed Oct 19 15:54:32 2016 +0200 cmake: add dependency to build manual pages "add_custom_command" outputs are only available as dependency in the same directory, so create a new target such it can be used from the main directory. This fixes the OS X build with no parallelism (-j1). Change-Id: I66aa5ae307be38ee715456a05fd55f55e4fa76e9 Reviewed-on: https://code.wireshark.org/review/18299 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9e42cad18a049ed0a52f337f91be1096887dbca4 commit 9e42cad18a049ed0a52f337f91be1096887dbca4 Author: Dario Lombardo <lomato at gmail.com> Date: Wed Oct 19 15:37:06 2016 +0200 ucp: use ws_strtou function. A lot of work added to pass the pinfo structure around. Change-Id: Ia550bc48cb03edcac1663eff355f0ba3103ec142 Reviewed-on: https://code.wireshark.org/review/18320 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=60f5c5716378bd34c215e0227a977663d31a6fab commit 60f5c5716378bd34c215e0227a977663d31a6fab Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Tue Oct 18 16:51:51 2016 +0200 wlan_statistics_dialog (Qt): Add percent of retry Change-Id: I1b77805d0bb71cda0ba8296f88854eec7111eff4 Reviewed-on: https://code.wireshark.org/review/18307 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1e69a5e569a9ed1e7bc3225136eb9147bc02c617 commit 1e69a5e569a9ed1e7bc3225136eb9147bc02c617 Author: Joerg Mayer <jmayer at loplof.de> Date: Thu Oct 20 10:36:36 2016 +0200 Support setting up sbc on macOS. Not tested with an actual capture file. Should not be too hard to get this working on Windows as well. Change-Id: Iae4b744361f0c4b62e919ad77e3d2b69ba45a8f3 Reviewed-on: https://code.wireshark.org/review/18331 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=afcbcdf272d270ef08b214c6571336c376a24e1a commit afcbcdf272d270ef08b214c6571336c376a24e1a Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Sat Apr 30 19:13:29 2016 +0200 Qt/Bluetooth: Add Mark/Unmark functionality Add Mark/Unmark functionality for tree/table widget items, user can now mark row or cell. Change-Id: I31b9ca128d97da4fb959ae2d92f5c1646ebea478 Reviewed-on: https://code.wireshark.org/review/18266 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=82696cabd6686eb1c5e86421237baf90a339f54c commit 82696cabd6686eb1c5e86421237baf90a339f54c Author: Dario Lombardo <lomato at gmail.com> Date: Tue Oct 18 22:44:51 2016 +0200 bt-dht: use ws_strtou function. Change-Id: I105ceb0053d5ff3f595611cf919d44d40f5df037 Reviewed-on: https://code.wireshark.org/review/18287 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d821c72b9737703ddad80fb82a5525341967c9c2 commit d821c72b9737703ddad80fb82a5525341967c9c2 Author: Parav Pandit <paravpandit at yahoo.com> Date: Tue Oct 18 15:31:01 2016 -0400 packet-infiniband: Add support for IP CM serviceid Added support for decoding IP CM Service id for CM Connect requests. Annex 11.2 defines a specific prefix of serviceid for IP CM based ULPs. Corrected typo error which got introduced as part of bad local merge for hf_cm_drsp_privatedata. Corrected now. Change-Id: I18235ea86d82a224dcc7110a1c45c08f698fa9a6 Tested-by: paravpandit at yahoo.com Reviewed-on: https://code.wireshark.org/review/18284 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=961b05315df0c17bc21ca77553d1e29ebdf39309 commit 961b05315df0c17bc21ca77553d1e29ebdf39309 Author: Roland Knall <rknall at gmail.com> Date: Wed Oct 19 10:19:28 2016 +0200 WelcomeUI: Make Open and Capture clickable Make the texts "Open" and "Capture" clickable, and have them open the FileOpen and CaptureOptions dialogs respectively Change-Id: I2a3efbc4cdf160aa0b4efc6496d09228affbff46 Reviewed-on: https://code.wireshark.org/review/18303 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f0cb70bd18171a8102f4a6baefb385a1dcd2d960 commit f0cb70bd18171a8102f4a6baefb385a1dcd2d960 Author: Balint Reczey <balint at balintreczey.hu> Date: Tue Oct 18 21:00:56 2016 +0200 Exclude scanner-generated headers from ABI check They break the check by not including header files for custom types and they are not part of the API anyway. Bug: 13018 Change-Id: Ia0f81f861251b5659af723b9da795daeb7454eb3 Reviewed-on: https://code.wireshark.org/review/18297 Reviewed-by: Balint Reczey <balint at balintreczey.hu> Petri-Dish: Balint Reczey <balint at balintreczey.hu> Petri-Dish: Guy Harris <guy at alum.mit.edu> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9c3d81adde2d901a18fb0dc5a5dc2220f76cd920 commit 9c3d81adde2d901a18fb0dc5a5dc2220f76cd920 Author: Peter Wu <peter at lekensteyn.nl> Date: Wed Oct 19 12:27:11 2016 +0200 Officially require Qt 4.8 or newer Since v2.3.0rc0-1002-g1cd2255, Qt 4.8 became mandatory, reflect this in the version requirements. This will not affect a lot of distributions (RHEL and SLES only had Qt 4.6). For a more complete list of supported platforms, see https://wiki.wireshark.org/Development/Support_library_version_tracking While at it, correct some other minimum versions in documentation. Change-Id: I11f2dfba72c75429f6838404a81ed3b3dc302d5f Reviewed-on: https://code.wireshark.org/review/18314 Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> Petri-Dish: Anders Broman <a.broman58 at gmail.com> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d38ed8e55f7df9b34b9a7859ff54dde726f2feb0 commit d38ed8e55f7df9b34b9a7859ff54dde726f2feb0 Author: Jeff Morriss <jeff.morriss.ws at gmail.com> Date: Wed Oct 19 21:40:22 2016 -0400 Put the SS7 PC name resolution feature in the release notes. Fix the casing of the preference while at it (it now matches other name resolution preferences). Change-Id: Ibfecbc94f9eccefa7d3b1a50ae2598dfefb707a2 Reviewed-on: https://code.wireshark.org/review/18330 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f252831b43269dd06487cdf3e5e791ecc991bf3d commit f252831b43269dd06487cdf3e5e791ecc991bf3d Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Tue Oct 18 16:13:03 2016 +0200 wlan_statistics_dialog: Add number of retry Change-Id: I27194670dcd2e6c2ec6502c562e50ee6925c4c45 Reviewed-on: https://code.wireshark.org/review/18306 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=404c31492be8b01d1b6bf9944ea3bb71feb92dd6 commit 404c31492be8b01d1b6bf9944ea3bb71feb92dd6 Author: Michael Mann <mmann78 at netscape.net> Date: Wed Oct 19 11:03:15 2016 -0400 Skype: Remove TCP heuristic dissection It was taking any/all TCP packets. Also clean up a little of the UDP heuristic. Change-Id: Iae08e79c0d71e4676cfc7821372ab9581c1d1cfc Ping-Bug: 13029 Reviewed-on: https://code.wireshark.org/review/18322 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bd057c8dd226dd3c33104b95310ac592d7a19b09 commit bd057c8dd226dd3c33104b95310ac592d7a19b09 Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Wed Oct 19 18:33:26 2016 +0300 ZigBee Green Power: add dissector for commands Proxy Table resp and Sink Table resp Change-Id: I6623a389551a727f933f8600ceba9d3050a51b25 Reviewed-on: https://code.wireshark.org/review/18326 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d561afcd129132877197bd0c77d9ea9a6471a6c4 commit d561afcd129132877197bd0c77d9ea9a6471a6c4 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Tue Oct 18 10:57:20 2016 +0200 raknet: remove if(tree) no longer needed also remove item_size variable (replace directly by the value) Will be also fix some Clang analyzer warning about used variable Change-Id: I4bf3b118efb2b0846012a92e5bf596ca95043414 Reviewed-on: https://code.wireshark.org/review/18318 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fbf4f6c62f3967b45e706ad3150d6b7d0208b34c commit fbf4f6c62f3967b45e706ad3150d6b7d0208b34c Author: Joerg Mayer <jmayer at loplof.de> Date: Thu Oct 20 00:27:30 2016 +0200 Add the wlan_mgt -> wlan renaming to the release notes Change-Id: Iae346329ad90035a3f047d748783c6f9f2dd4e1e Reviewed-on: https://code.wireshark.org/review/18327 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=d3995b5248e412dd1b00c06a3f54936326967e2d commit d3995b5248e412dd1b00c06a3f54936326967e2d Author: Gerald Combs <gerald at wireshark.org> Date: Tue Oct 18 10:16:39 2016 +0200 Disable GTK+ by default. I suggested disabling GTK+ by default at Sharkfest EU and no one objected, hence this patch. Disable it by default in both Autotools and CMake. Make sure it's enabled for Debian packaging. The RPM packaging enables GTK3 explicitly so no change appears to be necessary there. Change-Id: If5daeaef4bb26cf60006bc8883be15b2cf6c6ae4 Reviewed-on: https://code.wireshark.org/review/18256 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=5ab49c623df23a5d19cffdc29f912dd1d2798ca9 commit 5ab49c623df23a5d19cffdc29f912dd1d2798ca9 Author: Roland Knall <rknall at gmail.com> Date: Wed Oct 19 15:33:35 2016 +0200 InterfaceList: Changing text clears the cell If the cell is double-clicked to edit an existing text, it is cleared upon start of the edit widget Change-Id: I9d718635de5c4b091aab1f88c2482434aaae1286 Reviewed-on: https://code.wireshark.org/review/18319 Petri-Dish: Roland Knall <rknall at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c92cc9c95a8bc45c932bb37775627657994e906d commit c92cc9c95a8bc45c932bb37775627657994e906d Author: dsrsupport <eugene.exarevsky at dsr-company.com> Date: Tue Sep 6 17:56:15 2016 +0300 ZigBee ZDO dissector: fix for r21 in column description in ZDO Node Desc Resp. Fixed display for Server flags: a) introduce a flag 'show_ver_flags' to display stack revision only for ZDO Node Desc Resp; b) fix crash in zdp_parse_node_desc when passed NULL as pinfo. Now never pass NULL there. Change-Id: Ibdb7fe2da54a902b39e20e07aa2aa5c9c23beeee Reviewed-on: https://code.wireshark.org/review/18313 Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=11e8bac88e067b226f92add83eca3009fa5b95a7 commit 11e8bac88e067b226f92add83eca3009fa5b95a7 Author: Dario Lombardo <lomato at gmail.com> Date: Wed Oct 19 11:53:30 2016 +0200 Qt: add include to fix compilation without pcap. Regression introduced in 864f750be560a7a739c7453f19a8f5679cf7d6b3. Change-Id: I306903e8252d932425f420e1901a8f3e949f5568 Reviewed-on: https://code.wireshark.org/review/18309 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b31bdfdc58ed78a409a35f1f5861010701935236 commit b31bdfdc58ed78a409a35f1f5861010701935236 Author: Hessam Jalali <hessam.jalali at gmail.com> Date: Wed Oct 19 15:57:46 2016 +0330 e212: Fix for e212.*.mnc when mnc was not detected as long, the value was shown as e212.mnc instead of e212.*.mnc (e.g e212.rai.mnc) Change-Id: Ic0d275f259e1121abb1b7812651fadb9d475053e Reviewed-on: https://code.wireshark.org/review/18317 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> Tested-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5c8f4decd9797275a77c73d032633c5a55100289 commit 5c8f4decd9797275a77c73d032633c5a55100289 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Wed Oct 19 13:50:26 2016 +0200 androiddump: Update help Minor changes in androiddump implies minor changes in help file. Change-Id: Ifbf4dbdca427e8b19272c2b4f28e06fd6a548834 Reviewed-on: https://code.wireshark.org/review/18316 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=afc2034721923534d8810fbee087155240edf687 commit afc2034721923534d8810fbee087155240edf687 Author: Dario Lombardo <lomato at gmail.com> Date: Wed Oct 19 11:16:58 2016 +0200 bt-dht: add bencoding terminators. Change-Id: I367495fb11aa09f1c8cb7f1df8812e179d41d9b9 Reviewed-on: https://code.wireshark.org/review/18305 Reviewed-by: Dario Lombardo <lomato at gmail.com> Petri-Dish: Dario Lombardo <lomato at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> Tested-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dbb391a64681e3c5722f8e7ff79bd4154d0b2e6b commit dbb391a64681e3c5722f8e7ff79bd4154d0b2e6b Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Tue Oct 18 22:42:09 2016 +0200 Kafka: add Snappy decompression support Change-Id: Ida8d941809a4e0f2fd4d9f142363187a757d0278 Reviewed-on: https://code.wireshark.org/review/18288 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=25122f5ef6f722a12077ce91f1b0d9784570009c commit 25122f5ef6f722a12077ce91f1b0d9784570009c Author: AndersBroman <anders.broman at ericsson.com> Date: Wed Oct 19 09:59:47 2016 +0200 [GIOP] Use g_slist_prepend(). Change-Id: I3a6c43f617f7634ce0007bc75aa6293eb5e1cad6 Reviewed-on: https://code.wireshark.org/review/18302 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> Tested-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b4f86c9cb84c8cefcf0784fa1bbe10a89392da74 commit b4f86c9cb84c8cefcf0784fa1bbe10a89392da74 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Mon Sep 12 19:49:50 2016 +0200 androiddump: Fix help - interfaces Fix help output that describes interfaces provided by tool to reflect reality - add missed DEVICE_ID that is part of interface. Change-Id: Ib6374db28d8d4696ce27c5358da49d3ebfcf31e1 Reviewed-on: https://code.wireshark.org/review/18267 Petri-Dish: Michal Labedzki <michal.labedzki at tieto.com> Reviewed-by: Roland Knall <rknall at gmail.com> Reviewed-by: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Tested-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4ef14c76513acb92e75c87a1f987c8c9c18fabc6 commit 4ef14c76513acb92e75c87a1f987c8c9c18fabc6 Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Tue Oct 18 19:08:53 2016 +0300 ZigBee Green Power: add dissectors for Sink Table and Proxy Table attributes (GP Cluster) Change-Id: I9d18aa84e24a713951d5e537dcbc2dee6998192c Reviewed-on: https://code.wireshark.org/review/18278 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d399bfaa0768de53831d0a841f0e4ef55bd37d24 commit d399bfaa0768de53831d0a841f0e4ef55bd37d24 Author: Peter Wu <peter at lekensteyn.nl> Date: Wed Oct 19 12:19:38 2016 +0200 cmake/FindPOD: improve formatting, add modelines CMake standard style is to use lowercase function names, do that. Change-Id: I893825cfac0cc402177ffb1a0f43f0ffc6341c45 Reviewed-on: https://code.wireshark.org/review/18312 Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=10c46fc3082b728b08a7dcd70cad7d6eef1337bc commit 10c46fc3082b728b08a7dcd70cad7d6eef1337bc Author: Hessam Jalali <hessam.jalali at gmail.com> Date: Wed Oct 19 14:50:09 2016 +0330 Qt: declare one_em to fix compile error when HAVE_PCAP_REMOTE is defined Occured on Windows(10) x64 build. Change-Id: I04d88bec1660dae20f459d2e03c88864c9366dc3 Reviewed-on: https://code.wireshark.org/review/18315 Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1d35c7f096792d5c2d873a3585de462d8fe54ee8 commit 1d35c7f096792d5c2d873a3585de462d8fe54ee8 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Wed Oct 19 09:51:23 2016 +0200 IP: Fix evil flag expert item text When creating the expert info item definition the copied line wasn't updated with the correct message text. This change sets the right text. Change-Id: I9a98126c0b8a650e5ab195f97c53bb32e3053e89 Reviewed-on: https://code.wireshark.org/review/18301 Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Reviewed-by: Stig Bjørlykke <stig at bjorlykke.org> Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=59c370440423131e3ef460ca3b8f1f55ca319926 commit 59c370440423131e3ef460ca3b8f1f55ca319926 Author: Gerald Combs <gerald at wireshark.org> Date: Tue Oct 18 15:54:43 2016 +0200 Add a Kerberos decryption test. Test Kerberos decryption using files from krb-816.zip on the SampleCaptures page. Change-Id: Ic1360b637ca6a1f6cb86d09a6aebfd7f5ff89419 Reviewed-on: https://code.wireshark.org/review/18275 Reviewed-by: Gerald Combs <gerald at wireshark.org> Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a0e1d282f2d8c87b985a8896a5418dda2894f48c commit a0e1d282f2d8c87b985a8896a5418dda2894f48c Author: Joerg Mayer <jmayer at loplof.de> Date: Wed Oct 19 10:45:23 2016 +0200 Do not update register.c's timestamp if it is unchanged, otherwise it gets recompiled every time one of its dependencies is touched. Change-Id: I8c0c4caea8355748e5abf9b9fe3804834353075f Reviewed-on: https://code.wireshark.org/review/18304 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=9672913350adf1bf9d1a624e56a24ece2bfc6891 commit 9672913350adf1bf9d1a624e56a24ece2bfc6891 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Fri Sep 30 10:31:52 2016 +0200 Bluetooth: ATT: Add missing expert info for Regulatory Certification Add missed expert info for IEEE 11073-20601 Regulatory Certification Data List. Change-Id: Id9520e1c604ee38bf11ce42248357ca007bffcfd Reviewed-on: https://code.wireshark.org/review/18233 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7edf3eeef811135f128075a679f8d6aed400a173 commit 7edf3eeef811135f128075a679f8d6aed400a173 Author: Balint Reczey <balint at balintreczey.hu> Date: Tue Oct 18 16:50:33 2016 +0200 Use the proper include dirs for ABI check Ping-Bug: 13018 Change-Id: I05203c56e6b595c5bff6d8e475f16b66264bdd0e Reviewed-on: https://code.wireshark.org/review/18296 Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=e68247e1fdc5a81872f5f3ee01a40ea71db71380 commit e68247e1fdc5a81872f5f3ee01a40ea71db71380 Author: Roland Knall <rknall at gmail.com> Date: Tue Oct 18 22:28:28 2016 +0200 InterfaceTree: Change foreach to const_iterator Change all occurences of the foreach macro to while loops with const_iterator for performance reasons Change-Id: I1cd378696136b3d6cc100b9bfff95295baa2ff83 Reviewed-on: https://code.wireshark.org/review/18286 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=864f750be560a7a739c7453f19a8f5679cf7d6b3 commit 864f750be560a7a739c7453f19a8f5679cf7d6b3 Author: Roland Knall <rknall at gmail.com> Date: Mon Oct 17 15:01:24 2016 +0200 ManageInterfacesDialog: Implement View/Data Model Implement the same interface view/data model as used for the interface_tree selection in this dialog, to encapsulate all access to global_capture_devices from the dialog. Change-Id: I0e568fe236d077befa2a79765638db8bb3ed1a3f Reviewed-on: https://code.wireshark.org/review/18062 Petri-Dish: Roland Knall <rknall at gmail.com> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5cbdbecc35f77c40142e2e5389e553931490eea0 commit 5cbdbecc35f77c40142e2e5389e553931490eea0 Author: Jan Spevak <jan.spevak at nokia.com> Date: Wed Oct 19 09:27:36 2016 +0200 GTPv2: Add support for NB-IoT features Bug: 13026 Change-Id: I75de63bd58a35e234eef308fa592922e01ea3c18 Reviewed-on: https://code.wireshark.org/review/18300 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b83ea466655a77dacd8ad0bd38706afbec1ce21c commit b83ea466655a77dacd8ad0bd38706afbec1ce21c Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Tue Oct 18 19:52:49 2016 +0200 extcap: put missed parameters into the help "--debug" and "--extcap-version" are part of extcap-base helper, do not hide them. Change-Id: I287b68dbed5344c188fede69d112ab007a6ee18b Reviewed-on: https://code.wireshark.org/review/18279 Reviewed-by: Dario Lombardo <lomato at gmail.com> Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba00be5266aff1bdf6507fdb9bd263d30c8dcc32 commit ba00be5266aff1bdf6507fdb9bd263d30c8dcc32 Author: Dario Lombardo <lomato at gmail.com> Date: Tue Oct 18 21:01:00 2016 +0200 mgcp: use ws_strtou function. Change-Id: Ia2a7fac5d1bd86d4f163117993e2e897e5dd315e Reviewed-on: https://code.wireshark.org/review/18280 Petri-Dish: Dario Lombardo <lomato at gmail.com> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bf96599f1916667cc8f1c19b58fe9cae4a1e3d66 commit bf96599f1916667cc8f1c19b58fe9cae4a1e3d66 Author: Balint Reczey <balint at balintreczey.hu> Date: Tue Oct 18 22:41:55 2016 +0200 Drop redundant SIZEOF() macro Change-Id: I6db2033746f5f22dd0229c96727bb352bdb1e866 Reviewed-on: https://code.wireshark.org/review/18298 Reviewed-by: Balint Reczey <balint at balintreczey.hu> Petri-Dish: Balint Reczey <balint at balintreczey.hu> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=739bdfb45f6e6f78a88e978de1eff088377e8330 commit 739bdfb45f6e6f78a88e978de1eff088377e8330 Author: Michael Mann <mmann78 at netscape.net> Date: Tue Oct 18 09:14:35 2016 -0400 Some Pref <-> Decode As bugfixes. 1. If a deprecated port preference is found, populate the new port preference with the value 2. Mark preferences as changed to trigger preference callback at startup. Change-Id: Ic271841686617e847d2e0ed8800bbb0fa874df47 Reviewed-on: https://code.wireshark.org/review/18274 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=09b43591a13e9834a66adbd7b24c3c28af8ea5fc commit 09b43591a13e9834a66adbd7b24c3c28af8ea5fc Author: Joerg Mayer <jmayer at loplof.de> Date: Tue Oct 18 22:56:28 2016 +0200 While the channelwidth was dissected the information was not passed to the phdr No other flags were verified. Change-Id: I77e35af8accb83595d3046dc804f0c6a7e1d1000 Reviewed-on: https://code.wireshark.org/review/18295 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=6a14408bf62f534db2374f131195fc2c42785f57 commit 6a14408bf62f534db2374f131195fc2c42785f57 Author: Guy Harris <guy at alum.mit.edu> Date: Tue Oct 18 13:48:51 2016 -0700 Fix typo. Change-Id: Ie28490c93736c7e95f0b1eaed1e075e61f005e16 Reviewed-on: https://code.wireshark.org/review/18289 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=537705a8b20ee89bf1f713bc0c9959cf21b26900 commit 537705a8b20ee89bf1f713bc0c9959cf21b26900 Author: Peter Wu <peter at lekensteyn.nl> Date: Sun Oct 2 18:02:22 2016 +0200 wslua: prepare for split class/instance (meta)methods Previously the metatables for classes were the same for the class and its instances. This results in issues like calling __gc on the class table on exit. Make it possible to declare separate class methods (functions) and instance methods. Observe that all attributes apply to the instances only, so make these just available on the instance. The attribute/methods lookup method (via __index/__newindex) have been rewritten to use upvalues, removing the technical need for the properties __getters/__setters/__methods. The "lua globals" test still checks for these, but it could be removed in the future. To fix bug 12968, the __gc method is removed from the class method. Future patches should remove the WSLUA_REGISTER_CLASS, WSLUA_REGISTER_META and WSLUA_REGISTER_ATTRIBUTES macros completely and create split class functions/methods (such that __call for an instance cannot accidentally be invoked on the class). Removed duplicate "fragmented" property from Pinfo (which triggered an error) and replaced exit() by g_error() for debugger friendliness. Remove lua_shiftstring since checkstring always returns non-NULL. Bug: 12968 Change-Id: I57f8a93d08bb84c79b0e94cf2c82d8402fc16646 Reviewed-on: https://code.wireshark.org/review/18026 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=41c6b944b42a31c9593e4374336fee8022e0011d commit 41c6b944b42a31c9593e4374336fee8022e0011d Author: Guy Harris <guy at alum.mit.edu> Date: Tue Oct 18 13:07:42 2016 -0700 Rename a function to have a name different from a data object's name. Change-Id: Iefef8b2161b43900fd81fb1b163a4feee69fd069 Reviewed-on: https://code.wireshark.org/review/18285 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2898c2a244eeccdb41c334d2b6c16117e9844dc4 commit 2898c2a244eeccdb41c334d2b6c16117e9844dc4 Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Tue Oct 18 21:28:45 2016 +0200 Fix wrong local function names Copy->Paste issue. Change-Id: I77bc755c772df0fb95a9e4ce91b8b3bc8a8e019d Reviewed-on: https://code.wireshark.org/review/18282 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7a906dc877c06700ef6d09aa8edd0e09f5b22f9d commit 7a906dc877c06700ef6d09aa8edd0e09f5b22f9d Author: Michael Mann <mmann78 at netscape.net> Date: Tue Oct 18 08:57:54 2016 -0400 Ensure http_tcp_range gets initialized through preference callback. Bug: 13016 Change-Id: I814c901898790045be0e2003ebe5a8000704b8af Reviewed-on: https://code.wireshark.org/review/18273 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4a4698259c3c770eb4c675adcaa11674c306e551 commit 4a4698259c3c770eb4c675adcaa11674c306e551 Author: Roland Knall <rknall at gmail.com> Date: Tue Oct 18 15:00:39 2016 +0200 WiresharkApplication: Add signal emitter for Interface Changes Change-Id: I468ef9462aa91d02c5568cec0d08081a2b3840bb Reviewed-on: https://code.wireshark.org/review/18269 Petri-Dish: Roland Knall <rknall at gmail.com> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=63eb48adaa49e6781953f0555998db6622372843 commit 63eb48adaa49e6781953f0555998db6622372843 Author: Dario Lombardo <lomato at gmail.com> Date: Tue Oct 18 14:21:46 2016 +0200 sdp: use ws_strtou function. Change-Id: Idd624170cf8d3bb0441c765ecfebcbe51f99deaf Reviewed-on: https://code.wireshark.org/review/18264 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=397065bb591d224df94463705b51d9c13f613654 commit 397065bb591d224df94463705b51d9c13f613654 Author: Dario Lombardo <lomato at gmail.com> Date: Mon Oct 17 22:24:03 2016 +0200 mrcpv2: use ws_strtou function. Change-Id: I2d3ddf1f376ac44e3ccc618d94aebdba9c86e3df Reviewed-on: https://code.wireshark.org/review/18250 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=47e93451161c9af972c55af856ebbc1ab65441cb commit 47e93451161c9af972c55af856ebbc1ab65441cb Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Tue Oct 18 11:13:15 2016 +0200 fc00: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3c494b190f93e9a1d042fa666d4f7037cd69c986 Reviewed-on: https://code.wireshark.org/review/18262 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=41e9bbac91c76fa0c95944a0329dd674cbeb61d9 commit 41e9bbac91c76fa0c95944a0329dd674cbeb61d9 Author: Gerald Combs <gerald at wireshark.org> Date: Tue Oct 18 13:35:48 2016 +0200 Qt: Main welcome show/hide interface updates. Pluralize the text in the main welcome show/hide interfaces button. Remove the styling, which matches other places we use a pushbutton + menu. Change-Id: I7559f98d0c1afbfb2920b09c3885d9b1fbdf76f1 Reviewed-on: https://code.wireshark.org/review/18260 Petri-Dish: Gerald Combs <gerald at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> Reviewed-by: Stig Bjørlykke <stig at bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=9796e811f51892db729e02735a8bf31628ea7dcb commit 9796e811f51892db729e02735a8bf31628ea7dcb Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Tue Oct 18 13:29:24 2016 +0200 BGP: fix bgp.ls.tlv.link_protection_type_value is not of an FT_{U}INTn type] Bug: 13021 Change-Id: I3464c7af61323efb25dd89655865d536aeae6e59 Reviewed-on: https://code.wireshark.org/review/18261 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5d2c54ed2029dd98c44e17672e9c63ad0172e87b commit 5d2c54ed2029dd98c44e17672e9c63ad0172e87b Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Tue Oct 18 13:56:31 2016 +0300 ZigBee Green Power: fix commissioning cmd dissection Dissect fields: number of gpd commands, GPD cmd list, Cluster list Change-Id: Ifda60987072c3526d5f0ae4687ddf2b6e46bfb93 Reviewed-on: https://code.wireshark.org/review/18259 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=256f834293e54be5d54a6f9c55472876851cbbbf commit 256f834293e54be5d54a6f9c55472876851cbbbf Author: Babak Farrokhi <babak at farrokhi.net> Date: Tue Oct 18 12:46:54 2016 +0330 Update MNC list for MCC 432 (Iran) The official E.212 list does not contain the latest MNC codes that are in use for MCC 432. This commit contains an up to date list according to: http://mcclist.com/mobile-network-codes-country-codes.asp#Iran Change-Id: I847d31b1d77825c6f95f4e5879ee1f688834ed88 Reviewed-on: https://code.wireshark.org/review/18258 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=418b7d125dcf65cd335c5dc113fde27074453d2a commit 418b7d125dcf65cd335c5dc113fde27074453d2a Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Tue Oct 18 10:26:37 2016 +0200 CQL: free buffer earlier in case of Snappy decompression failure Change-Id: I3048823b4057caf49f2f6bf28cf2389dc3c88f27 Reviewed-on: https://code.wireshark.org/review/18255 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2c071296f5b344298e2994d29c2b3ca3550601f4 commit 2c071296f5b344298e2994d29c2b3ca3550601f4 Author: Parav Pandit <paravpandit at yahoo.com> Date: Mon Oct 17 01:38:46 2016 -0400 packet-infiniband: Add support for CM DREQ/DRSP Added support for decoding CM Disconnect and CM Disconnect response packets. Reusing ATTR macros in CM_Attributes definition. Change-Id: Ic6065b67d2007fc68848441e0c866e4a637a3657 Tested-by: paravpandit at yahoo.com Reviewed-on: https://code.wireshark.org/review/18229 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c7e75770e1c2d85e3a21ad457b2e415fcbe2f012 commit c7e75770e1c2d85e3a21ad457b2e415fcbe2f012 Author: Peter Wu <peter at lekensteyn.nl> Date: Sun Oct 2 12:29:38 2016 +0200 wslua: add support for negative indices Internal change, this allows use of negative indices for lua_rawgetfield/lua_rawsetfield convenience functions and is closer to lua_getfield/lua_setfield semantics in terms of indices. Add lua_absindex for compatibility with Lua 5.1 (do not bother exporting it yet since it is only used in this file, also do not rename it since it is the same functionality with no Wireshark-specific changes.) Change-Id: I322954ef461164ec514ed9f034ae2691775e67da Reviewed-on: https://code.wireshark.org/review/18025 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8a1adf1a66cb0324e418e2e588cf47c68c4a287a commit 8a1adf1a66cb0324e418e2e588cf47c68c4a287a Author: Peter Wu <peter at lekensteyn.nl> Date: Mon Oct 17 02:08:44 2016 +0200 wslua: fix errors in documentation, add notational conventions Improve example with better formatting, clarification comments and more common variable names. Extend make-wsluarm.pl to support arguments containing underscores. Fixes the description of dissect_tcp_pdus. Change TvbRange.tvb(tvb) into tvbrange:tvb() and ByteArray.tvb(name) into bytearray:tvb(name), these are really instance methods. Change-Id: I1e20ef46195dc6c06f9ac790d3432db283d21a5e Reviewed-on: https://code.wireshark.org/review/18226 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f07b1bc6042925cba6ca2bfb762c9521513259ba commit f07b1bc6042925cba6ca2bfb762c9521513259ba Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 14:29:20 2016 +0200 debian: Update lintian-overrides to cover updated manpages Change-Id: Ie69b82b752ab82910ee3126a25c49da8bc383a97 Reviewed-on: https://code.wireshark.org/review/18243 Reviewed-by: Balint Reczey <balint at balintreczey.hu> Petri-Dish: Balint Reczey <balint at balintreczey.hu> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=954e7c4ded574a0a7d2963f979c51b79a038958b commit 954e7c4ded574a0a7d2963f979c51b79a038958b Author: Peter Wu <peter at lekensteyn.nl> Date: Mon Oct 17 17:06:08 2016 +0200 wslua: Do not crash on the root tree item ti->item is NULL for the root item, prevent a NULL-deref by Lua script. Bug: 13017 Change-Id: I5e7f71d014a01bab615288df76509b3ef97b1bf6 Reviewed-on: https://code.wireshark.org/review/18247 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=303948500fee5f24600643638e3ed5cc5fa14132 commit 303948500fee5f24600643638e3ed5cc5fa14132 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Mon Oct 17 21:04:49 2016 +0200 CQL: add LZ4/Snappy decompression support on Windows Change-Id: I34374cf29357e2ed5062da1a5245b9adbabf732d Reviewed-on: https://code.wireshark.org/review/18249 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=867f2829c1c4e1f67b14a5ace5cc9f29e971a6c9 commit 867f2829c1c4e1f67b14a5ace5cc9f29e971a6c9 Author: Guy Harris <guy at alum.mit.edu> Date: Mon Oct 17 16:28:58 2016 -0700 Separate "Link Access Control Protocol" and the version number with a space. Change-Id: I11d3e3b5b25d8f42fac613f464620371d2643ab5 Reviewed-on: https://code.wireshark.org/review/18251 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7b73a04116b3037131081bc8167fd2002651294b commit 7b73a04116b3037131081bc8167fd2002651294b Author: Joerg Mayer <jmayer at loplof.de> Date: Mon Oct 17 21:04:37 2016 +0200 $Id$ is useless with git - treat it exaclty like this Change-Id: I607ce7ded40864c1b4dcc0a2d577a65923af4225 Reviewed-on: https://code.wireshark.org/review/18248 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=47649d1c7fb6ba48b805e19268a711404eb6908b commit 47649d1c7fb6ba48b805e19268a711404eb6908b Author: Benoît Canet <benoit at scylladb.com> Date: Mon Sep 26 16:25:11 2016 +0200 cql: add lz4 and snappy decompression We do not use the STARTUP negotiation since a stream can be captured in its middle but try to decompress if the flag is present and fallback if it fails. Change-Id: Iecbf49a45220b04be7808869c9884548eb1e7694 Signed-off-by: Benoît Canet <benoit at scylladb.com> Reviewed-on: https://code.wireshark.org/review/17952 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5c42d8a24c863549166bc1d0875e87a07bedf53e commit 5c42d8a24c863549166bc1d0875e87a07bedf53e Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 14:57:18 2016 +0200 debian: Override Lintian warning for missing wireshark-gtk man page Change-Id: I16e09c88046c55b3a7d610bf81c28850e2984f9a Reviewed-on: https://code.wireshark.org/review/18244 Petri-Dish: Balint Reczey <balint at balintreczey.hu> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=b973b001bfe82fdff55ac040d1904d95744cb839 commit b973b001bfe82fdff55ac040d1904d95744cb839 Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 12:34:10 2016 +0200 debian: Bump standards version to 3.9.7 used in Ubuntu 16.04 Change-Id: I4a2a3dfad440f17f1b9cfae282623038d9b0981a Reviewed-on: https://code.wireshark.org/review/18242 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=3b3185eb65e3625228e4ec6f68367b485a22965b commit 3b3185eb65e3625228e4ec6f68367b485a22965b Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 12:12:44 2016 +0200 debian: Build-depend on cmake (>= 2.8.8) Change-Id: I3097a06fa7cbe858f7b8b2af22d56da6ae027974 Reviewed-on: https://code.wireshark.org/review/18240 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=dca176c23217301cb7015e7eb7e256888d979781 commit dca176c23217301cb7015e7eb7e256888d979781 Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 12:13:48 2016 +0200 debian: Drop unused renaming of wireshark-qt binary Change-Id: I9ff77d97016f33d1a276c7392f076413590a1099 Reviewed-on: https://code.wireshark.org/review/18241 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=f3ae5f1b4dee780b3d912db4d9e446a089c171d5 commit f3ae5f1b4dee780b3d912db4d9e446a089c171d5 Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 12:06:51 2016 +0200 debian: Update changelog timestamp to silence Lintian warning Change-Id: I4a27c10766587c3b61b088290a5f05a34d3c3cd8 Reviewed-on: https://code.wireshark.org/review/18239 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=511bb814332d03553b2dfb3b927a721c364ad160 commit 511bb814332d03553b2dfb3b927a721c364ad160 Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 11:55:19 2016 +0200 debian: Stop using hardening-check during .deb package build Hardening-check script has been removed from Debian unstable. Checking binaries' security features is implemented in Lintian instead which will raise proper warnings for not Position Independent Executables and binaries missing "bindnow" linker flag. This also fixes the Lintian error complaining about dependency on obsolete hardening-includes package. Change-Id: If3387aa1f2297927c19d85f27361ba639203aad9 Reviewed-on: https://code.wireshark.org/review/18238 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=ad3fe1572b47f4f74428d98dd2ef831da6559a93 commit ad3fe1572b47f4f74428d98dd2ef831da6559a93 Author: Balint Reczey <balint at balintreczey.hu> Date: Mon Oct 17 11:08:41 2016 +0200 debian: Update symbols file for new symbols Change-Id: I2a38196fe8aa93b72a94a1b95caf665e2de645f3 Reviewed-on: https://code.wireshark.org/review/18237 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=81904c70a85c5e335908b628667cac84e560beef commit 81904c70a85c5e335908b628667cac84e560beef Author: Roland Knall <rknall at gmail.com> Date: Mon Oct 17 11:57:00 2016 +0200 InterfaceList: Change Buttons to combobox Change the buttons to a combobox selector, and move that selector to the right of the capture filter box. Bug: 12971 Change-Id: Ib85d51cca128ed76eb08886e92660ede51d5982f Reviewed-on: https://code.wireshark.org/review/18186 Petri-Dish: Roland Knall <rknall at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0c4eb2779f5507c498f9f076a993f0d0f988f1cd commit 0c4eb2779f5507c498f9f076a993f0d0f988f1cd Author: Dario Lombardo <lomato at gmail.com> Date: Tue Oct 11 12:48:52 2016 +0200 ftp: use ws_strtou function. Change-Id: Idd0496f5afe41506ae3b5e22bc0aec09b737be6c Reviewed-on: https://code.wireshark.org/review/18146 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=a30dcd9951ed5814ca1974a31db83756bfb5b233 commit a30dcd9951ed5814ca1974a31db83756bfb5b233 Author: Peter Wu <peter at lekensteyn.nl> Date: Mon Oct 17 00:35:50 2016 +0200 cmake: fix missing docbook dependency Running "ninja developer_guide_html" somehow did not produce a new HTML docbook once wsluarm.ascii (a dependency of developer-guide.xml) was modified. It turns out that output file docbook/wsdg_html/index.html only had a ordering-only dependency on target generate_developer-guide.xml. An extra dependency is needed on the output file to ensure that the HTML file gets rebuild on changes. See the last note on https://samthursfield.wordpress.com/2015/11/21/cmake-dependencies-between-targets-and-files-and-custom-commands/ Fixes v2.1.0rc0-2137-gd544ecd ("cmake: fix parallel docbook build"). Change-Id: I7689c71994f13b29cf7f8561f7c993aa8298632d Reviewed-on: https://code.wireshark.org/review/18225 Reviewed-by: Graham Bloice <graham.bloice at trihedral.com> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=632b7d19d770e5215f1e89c363e3afab56369a53 commit 632b7d19d770e5215f1e89c363e3afab56369a53 Author: Joerg Mayer <jmayer at loplof.de> Date: Mon Oct 17 15:47:04 2016 +0200 Fix typo in a message Change-Id: Ic1651c4ff0fd7ba7f13cd52b596f3d54cf6c3e00 Reviewed-on: https://code.wireshark.org/review/18245 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=e5c594636324efaf908f5c779fa56e5feca4252d commit e5c594636324efaf908f5c779fa56e5feca4252d Author: Michal Labedzki <michal.labedzki at tieto.com> Date: Fri Sep 30 10:31:52 2016 +0200 Bluetooth: HFP: Fix incorrect field name In some AT commands field description was "Number", should be "Type". Change-Id: I33e3c8deb4f1fd0d51c3faae7a7ec45baacd82ca Reviewed-on: https://code.wireshark.org/review/18232 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fbc816a998c1649beaeefd743846c4ce977ac2b2 commit fbc816a998c1649beaeefd743846c4ce977ac2b2 Author: Gerald Combs <gerald at wireshark.org> Date: Mon Oct 17 11:55:56 2016 +0200 Qt: Read our dynamic recent entries a bit earlier. Call recent_read_dynamic a bit earlier in the startup process. Note that it determines when we fill in the recent files list, so the earlier we call it the better. Change-Id: Iad37d3aa2222873259d6c96ba79672236c8e4cd5 Reviewed-on: https://code.wireshark.org/review/18235 Reviewed-by: Gerald Combs <gerald at wireshark.org> Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1d094209e8d6384cdb9fb6f88fc95a52a5ab45ae commit 1d094209e8d6384cdb9fb6f88fc95a52a5ab45ae Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Oct 16 23:02:06 2016 +0200 MQ: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I62a67c4fff4604a3d1e335500b2453bae4f95f37 Reviewed-on: https://code.wireshark.org/review/18223 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=913225b5d4f334ec0298748cbcad6924cf57bcc3 commit 913225b5d4f334ec0298748cbcad6924cf57bcc3 Author: Dario Lombardo <lomato at gmail.com> Date: Tue Oct 11 13:58:27 2016 +0200 quakeworld: use ws_strtou function. Change-Id: I2d4d97229ee4fee37b26a2dabab9d373a0401e13 Reviewed-on: https://code.wireshark.org/review/18149 Petri-Dish: Dario Lombardo <lomato at gmail.com> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5546400b55c4524e86ce98a92444fd3b48dcc96c commit 5546400b55c4524e86ce98a92444fd3b48dcc96c Author: Dario Lombardo <lomato at gmail.com> Date: Mon Oct 17 10:49:40 2016 +0200 frame: print debug line according to new console preference. Change-Id: I4e4b7d08e7765c43904469bbf8ba5c0581428382 Reviewed-on: https://code.wireshark.org/review/18231 Petri-Dish: Dario Lombardo <lomato at gmail.com> Reviewed-by: Jörg Mayer <jmayer at loplof.de> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=51f316194d194fe1616112bf9d17130bc48a72f5 commit 51f316194d194fe1616112bf9d17130bc48a72f5 Author: Emery Hemingway <emery at vfemail.net> Date: Fri Oct 7 17:30:28 2016 +0200 Add fc00 dissector http://fc00.io/ Bug: 13014 Change-Id: I846d4dc28a8cb03bc877f0b4a392864100019d2d Reviewed-on: https://code.wireshark.org/review/18117 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cd426f3fe2719b9639f863efbb76e483c983970b commit cd426f3fe2719b9639f863efbb76e483c983970b Author: Joerg Mayer <jmayer at loplof.de> Date: Mon Oct 17 07:40:21 2016 +0200 Add a comment how to run git review after using --no-verfiy. Change-Id: I07cde41ef6f8074efbb77eacde91b46b62c2f59e Reviewed-on: https://code.wireshark.org/review/18230 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=4ff7799be8ff1995261717ca18d5cf21bee7ab52 commit 4ff7799be8ff1995261717ca18d5cf21bee7ab52 Author: Joerg Mayer <jmayer at loplof.de> Date: Mon Oct 17 07:32:00 2016 +0200 Some get rid of the remaining trivial Q_UNUSED cases. Fix the placement of Q_UNUSED inside #ifdef Change-Id: I015ff87fcb300a701bf8ccb42bd85e3068a08138 Reviewed-on: https://code.wireshark.org/review/18228 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=e552b319b5ffaa3652fa798cfd9db8771c20ba66 commit e552b319b5ffaa3652fa798cfd9db8771c20ba66 Author: Joerg Mayer <jmayer at loplof.de> Date: Mon Oct 17 07:15:27 2016 +0200 Get rid of the trivial Q_UNUSED cases Change-Id: Ia7ddde278158f3321eb4244189375bdd51c8976d Reviewed-on: https://code.wireshark.org/review/18227 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=763a059fe967b5be4db4ca7b07279ae990a07c7d commit 763a059fe967b5be4db4ca7b07279ae990a07c7d Author: Peter Wu <peter at lekensteyn.nl> Date: Sun Oct 16 17:05:46 2016 +0200 extcap_example.py: fix hang on exit I guess that when SIGINT is intercepted, then the writes are restarted and the doExit condition is never checked. Remove this racy check in favor of catching the KeyboardInterrupt exception. Test: tshark -i example1; kill tshark; check process list for python. Bug: 11657 Change-Id: Ia8b1ee560b9dcd31dd91df27fbfb8e91237581c9 Reviewed-on: https://code.wireshark.org/review/18218 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig at bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=2176423b4ab5ddb5b23d9bfd1417c7280b3f5129 commit 2176423b4ab5ddb5b23d9bfd1417c7280b3f5129 Author: Peter Wu <peter at lekensteyn.nl> Date: Sun Oct 16 11:59:32 2016 +0200 extcap_example.py: fixes for Python 3 Fixes trivial syntax error in try/except, ensure that the message are bytes instead of a string and remove unnecessary use of an append_bytes function. Did not try to fix the other Python issues, at least it runs now. Change-Id: Ib24f6116bc9d3cf177bc940da9f89aff90695a93 Reviewed-on: https://code.wireshark.org/review/18212 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7b060953464efaa5675d9165595d4208f69864cd commit 7b060953464efaa5675d9165595d4208f69864cd Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Oct 16 22:14:36 2016 +0200 CIP: no previous prototype for âdissect_cip_attributeâ [-Wmissing-prototypes] Change-Id: I61f388b136e66db9c4b909c4509db0441b1f1865 Reviewed-on: https://code.wireshark.org/review/18221 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=133a7e99b7f4b90a682fb2de2cd9e48543c839b8 commit 133a7e99b7f4b90a682fb2de2cd9e48543c839b8 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Oct 16 22:34:54 2016 +0200 addr_resolv(.c): no previous prototype for âadd_ss7pc_name/ss7pc_name_lookup_initâ [-Wmissing-prototypes] Change-Id: Ice8c901e41e1881210c0f4bf70851810ca480e81 Reviewed-on: https://code.wireshark.org/review/18222 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e84c20e7ed49c2c2e774efeac05960236696c53e commit e84c20e7ed49c2c2e774efeac05960236696c53e Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Oct 16 23:04:59 2016 +0200 raknet: fix Value stored to 'ti' is never read Change-Id: I2b3fe3a2b951cc99f6e6091389ec17bba367e8c6 Reviewed-on: https://code.wireshark.org/review/18224 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dc1cd7889da85938b016c6bfec932dd595b7e18b commit dc1cd7889da85938b016c6bfec932dd595b7e18b Author: dsrsupport <eugene.exarevsky at dsr-company.com> Date: Tue Sep 6 17:56:15 2016 +0300 ZigBee MAC and ZDO dissectors: put useful information into column description for Association req and ZDo Node Desc Resp. I added that information to column description because I always need it when analyzing logs. For Association request it is joining device type (FFD or RFD), for Node Descriptor Response this is stack version (r21 or legacy). Change-Id: Ic7ca237b1f4b598f9354b406f105c2befe45140d Reviewed-on: https://code.wireshark.org/review/17534 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b240082cf4ca297149a119694e9eb4d205bccc02 commit b240082cf4ca297149a119694e9eb4d205bccc02 Author: Gerald Combs <gerald at wireshark.org> Date: Sun Oct 16 08:11:48 2016 -0700 [Automatic update for 2016-10-16] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I016f035d04c44a68163ea0670e27fa454f4ba660 Reviewed-on: https://code.wireshark.org/review/18217 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=faa74f86e2cedbaa7ceceda1b5aa28821bdfb58a commit faa74f86e2cedbaa7ceceda1b5aa28821bdfb58a Author: Joerg Mayer <jmayer at loplof.de> Date: Sun Oct 16 16:09:51 2016 +0200 Inspired by prevous commit: grep for wlan_mgt turned up a few more occurrences. Fix them. Change-Id: I6661f483f7bf1e34c96467917358dbddf45f808e Reviewed-on: https://code.wireshark.org/review/18216 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=95c944884ab00db7529512129f0292f1a74aa1fd commit 95c944884ab00db7529512129f0292f1a74aa1fd Author: Joerg Mayer <jmayer at loplof.de> Date: Sun Oct 16 15:58:09 2016 +0200 More wlan_mgt cleanup: - Fix test script to use wlan instead of wlan_mgt - Remove a now useless test in the dissector Change-Id: I9a7644947c3002c759a7ae5728a8559682cfd4fd Reviewed-on: https://code.wireshark.org/review/18215 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=9711d2220ce1584a37e9e7d7df3ebf3c8e57b23d commit 9711d2220ce1584a37e9e7d7df3ebf3c8e57b23d Author: Joerg Mayer <jmayer at loplof.de> Date: Sun Oct 16 14:00:41 2016 +0200 Get rid of wlan_mgt. Handle these elements as part of wlan. The separation was artificial and irritiating. Change-Id: I45d4c3f5d518466df1d0b88ba6e10226662ee6e1 Reviewed-on: https://code.wireshark.org/review/18214 Reviewed-by: Jörg Mayer <jmayer at loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=c59f7fc8fec4e8c9fca27053e3c63a93adca3cb5 commit c59f7fc8fec4e8c9fca27053e3c63a93adca3cb5 Author: Stig Bjørlykke <stig at bjorlykke.org> Date: Sun Oct 16 13:25:25 2016 +0200 dmp: Fix UDP ports preference conversion The preferences change in 2eb7b05b had a typo for the old preference name. Change-Id: Ie4d85160050f5bea01b59a1803011b49a6c4d748 Reviewed-on: https://code.wireshark.org/review/18213 Reviewed-by: Stig Bjørlykke <stig at bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=93b2b2c06d2c8b6bbc3f204633c654383b0ce8ac commit 93b2b2c06d2c8b6bbc3f204633c654383b0ce8ac Author: Guy Harris <guy at alum.mit.edu> Date: Sat Oct 15 16:02:38 2016 -0700 Eliminate a global variable. Have the packet length be a local variable, and pass it to routines. Yes, that means we fetch it twice - no great loss. Change-Id: Id9f95b3d8a19bf235d6b19993165e0f73a2e5732 Reviewed-on: https://code.wireshark.org/review/18211 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=74174367ff72257a7bd485f9a48c3c3667bd8e3b commit 74174367ff72257a7bd485f9a48c3c3667bd8e3b Author: Guy Harris <guy at alum.mit.edu> Date: Sat Oct 15 14:27:17 2016 -0700 Fix bin2hex(). It was repeatedly overwriting the first character in the buffer, rather than appending characters. Change-Id: Ie34d194d69ac3d685416323c93764aa401d78faa Reviewed-on: https://code.wireshark.org/review/18209 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5d5f58fb78ab7037db3ec03d3a4541b3adcfcb7a commit 5d5f58fb78ab7037db3ec03d3a4541b3adcfcb7a Author: Dario Lombardo <lomato at gmail.com> Date: Tue Oct 11 13:00:42 2016 +0200 megaco: use ws_strtoi function. Change-Id: I8e4807e29524976898f2656f2c6f06d890748f36 Reviewed-on: https://code.wireshark.org/review/18148 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ebede2a7c55b49ba1d39dab3a18e5b3a1cfbaeaf commit ebede2a7c55b49ba1d39dab3a18e5b3a1cfbaeaf Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Fri Oct 14 16:05:37 2016 +0300 ZigBee Green Power: implement dissection for Proxy Table Request and Sink Table Request commands of GP Cluster Change-Id: Ib6d538eebd9f74be168f49b8570463bda97c7a8a Reviewed-on: https://code.wireshark.org/review/18199 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=91aef09509a3eb647588a6158c534f0b7bbe59c2 commit 91aef09509a3eb647588a6158c534f0b7bbe59c2 Author: Vladlen Popov <vladlen.popov at yahoo.com> Date: Fri Oct 14 17:51:24 2016 +0300 ZigBee green Power: fix commissioning reply, fix PAN ID field Parse field frame counter in comm_reply Fix PAN ID field name in comm_reply Change-Id: I2f30437fe7eef81af982fb8388ad43341043eb64 Reviewed-on: https://code.wireshark.org/review/18200 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> ----------------------------------------------------------------------- Summary of changes: .travis.yml | 4 +- AUTHORS | 7 + CMakeLists.txt | 47 +- CMakeOptions.txt | 4 +- ConfigureChecks.cmake | 8 +- Makefile.am | 47 +- Makefile.am.inc | 4 +- acinclude.m4 | 160 + capchild/capture_ifinfo.c | 31 +- capture_opts.h | 5 +- caputils/capture-pcap-util-unix.c | 2 +- cmake/modules/FindLZ4.cmake | 57 + cmake/modules/FindPOD.cmake | 41 +- cmake/modules/FindSBC.cmake | 17 +- cmake/modules/FindSNAPPY.cmake | 56 + cmake/modules/FindXSLTPROC.cmake | 11 +- cmakeconfig.h.in | 16 +- configure.ac | 133 +- debian/changelog | 2 +- debian/control | 8 +- debian/libwireshark0.symbols | 12 + debian/rules | 6 +- debian/source/lintian-overrides | 2 + debian/tshark.lintian-overrides | 2 +- debian/wireshark-gtk.lintian-overrides | 2 + debian/wireshark-qt.lintian-overrides | 2 +- diameter/TGPP.xml | 142 +- diameter/dictionary.xml | 521 +- doc/CMakeLists.txt | 5 + doc/README.developer | 9 +- doc/README.dissector | 1 + doc/README.wslua | 50 +- doc/androiddump.pod | 64 +- doc/extcap_example.py | 128 +- doc/wireshark.pod.template | 7 + docbook/CMakeLists.txt | 13 + docbook/make-wsluarm.pl | 23 +- docbook/release-notes.asciidoc | 5 + docbook/wsluarm.asciidoc | 54 +- dumpcap.c | 21 +- epan/CMakeLists.txt | 14 +- epan/Makefile.am | 13 +- epan/addr_resolv.c | 6 +- epan/charsets.c | 294 + epan/charsets.h | 3 + epan/decode_as.c | 6 +- epan/dfilter/semcheck.c | 9 +- epan/dissectors/CMakeLists.txt | 1 + epan/dissectors/Makefile.am | 1 + epan/dissectors/asn1/p1/p1.cnf | 46 + epan/dissectors/asn1/p22/p22.cnf | 15 +- .../asn1/pkix1explicit/pkix1explicit.cnf | 5 + epan/dissectors/asn1/rtse/rtse.cnf | 9 +- epan/dissectors/asn1/x509sat/x509sat.cnf | 12 + epan/dissectors/packet-ajp13.c | 5 +- epan/dissectors/packet-alljoyn.c | 31 +- epan/dissectors/packet-amqp.c | 9459 +++++++++----------- epan/dissectors/packet-ber.c | 14 +- epan/dissectors/packet-bgp.c | 4 +- epan/dissectors/packet-bt-dht.c | 74 +- epan/dissectors/packet-btatt.c | 21 +- epan/dissectors/packet-bthfp.c | 2 +- epan/dissectors/packet-c1222.c | 6 +- epan/dissectors/packet-catapult-dct2000.c | 12 +- epan/dissectors/packet-cfm.c | 2 +- epan/dissectors/packet-cip.c | 7 +- epan/dissectors/packet-cql.c | 150 +- epan/dissectors/packet-diameter_3gpp.c | 35 +- epan/dissectors/packet-dtls.c | 5 +- epan/dissectors/packet-e212.c | 66 +- epan/dissectors/packet-e212.h | 5 +- epan/dissectors/packet-fc00.c | 364 + epan/dissectors/packet-frame.c | 11 +- epan/dissectors/packet-ftp.c | 45 +- epan/dissectors/packet-giop.c | 2 +- epan/dissectors/packet-gsm_a_bssmap.c | 12 +- epan/dissectors/packet-gsm_a_common.h | 2 + epan/dissectors/packet-gsm_abis_om2000.c | 5 +- epan/dissectors/packet-gtp.c | 16 +- epan/dissectors/packet-gtpv2.c | 188 +- epan/dissectors/packet-http.c | 4 + epan/dissectors/packet-icmpv6.c | 876 +- epan/dissectors/packet-ieee80211.c | 2421 +++-- epan/dissectors/packet-ieee80211.h | 1 + epan/dissectors/packet-ieee802154.c | 4 + epan/dissectors/packet-infiniband.c | 768 +- epan/dissectors/packet-ip.c | 2 +- epan/dissectors/packet-ipv6.c | 355 +- epan/dissectors/packet-isakmp.c | 107 +- epan/dissectors/packet-iso8583.c | 31 +- epan/dissectors/packet-kafka.c | 69 +- epan/dissectors/packet-lacp.c | 2 +- epan/dissectors/packet-lsd.c | 14 +- epan/dissectors/packet-megaco.c | 34 +- epan/dissectors/packet-mgcp.c | 27 +- epan/dissectors/packet-mq.c | 1 - epan/dissectors/packet-mrcpv2.c | 35 +- epan/dissectors/packet-nas_eps.c | 12 +- epan/dissectors/packet-p1.c | 31 +- epan/dissectors/packet-p22.c | 27 +- epan/dissectors/packet-pkix1explicit.c | 5 +- epan/dissectors/packet-pop.c | 21 +- epan/dissectors/packet-ppi.c | 2 + epan/dissectors/packet-quakeworld.c | 39 +- epan/dissectors/packet-raknet.c | 671 +- epan/dissectors/packet-rtse.c | 21 +- epan/dissectors/packet-sctp.c | 93 +- epan/dissectors/packet-sdp.c | 110 +- epan/dissectors/packet-sip.c | 38 +- epan/dissectors/packet-skype.c | 37 +- epan/dissectors/packet-tpncp.c | 69 +- epan/dissectors/packet-ucp.c | 172 +- epan/dissectors/packet-x509sat.c | 8 +- epan/dissectors/packet-zbee-nwk-gp.c | 161 +- epan/dissectors/packet-zbee-security.c | 2 +- epan/dissectors/packet-zbee-zcl-general.c | 1423 ++- epan/dissectors/packet-zbee-zdp-discovery.c | 4 +- epan/dissectors/packet-zbee-zdp.c | 10 +- epan/dissectors/packet-zbee-zdp.h | 2 +- epan/dissectors/usb.c | 221 +- epan/enterprise-numbers | 332 +- epan/epan.c | 17 + epan/packet.c | 51 +- epan/prefs.c | 67 +- epan/prefs.h | 2 + epan/print.c | 23 +- epan/proto.h | 11 +- epan/sminmpec.c | 78 +- epan/tvbuff.c | 44 +- epan/wmem/wmem_list.c | 14 + epan/wmem/wmem_list.h | 4 + epan/wslua/wslua.h | 81 +- epan/wslua/wslua_address.c | 25 +- epan/wslua/wslua_byte_array.c | 5 +- epan/wslua/wslua_field.c | 3 +- epan/wslua/wslua_internals.c | 525 +- epan/wslua/wslua_pinfo.c | 1 - epan/wslua/wslua_tree.c | 27 +- epan/wslua/wslua_tvb.c | 29 +- extcap.c | 4 + extcap/androiddump.c | 37 +- extcap/ciscodump.c | 1 - extcap/extcap-base.c | 2 + extcap/extcap-base.h | 4 +- extcap/randpktdump.c | 1 - extcap/sshdump.c | 1 - extcap/udpdump.c | 1 - fileset.c | 21 +- macosx-setup.sh | 54 +- manuf | 47 +- packaging/nsis/CMakeLists.txt | 3 +- packaging/wix/CMakeLists.txt | 6 +- plugins/gryphon/packet-gryphon.c | 20 +- plugins/gryphon/packet-gryphon.h | 2 - plugins/profinet/packet-dcerpc-pn-io.c | 14 +- ringbuffer.c | 6 + services | 1 + test/captures/krb-816.pcap.gz | Bin 0 -> 21013 bytes test/config.sh | 7 +- test/keys/krb-816.keytab | Bin 0 -> 97 bytes test/lua/globals_2.2.txt | 25 - test/lua/tvb.lua | 44 +- test/suite-capture.sh | 6 + test/suite-decryption.sh | 30 +- test/suite-io.sh | 7 - test/suite-unittests.sh | 15 +- test/test.sh | 2 +- text2pcap.c | 1 + tools/debian-setup.sh | 2 +- tools/make-dissector-reg.py | 3 +- tools/pre-commit | 3 + tools/win-setup.ps1 | 17 +- ui/cli/tap-iostat.c | 86 +- ui/cli/tap-iousers.c | 100 +- ui/commandline.c | 17 + ui/commandline.h | 3 +- ui/console.c | 15 +- ui/gtk/file_dlg.c | 10 +- ui/gtk/fileset_dlg.c | 34 +- ui/gtk/iax2_analysis.c | 23 +- ui/gtk/io_stat.c | 21 +- ui/gtk/main_welcome.c | 2 +- ui/gtk/memory_dlg.c | 21 +- ui/gtk/rtp_analysis.c | 22 +- ui/gtk/rtp_player.c | 10 +- ui/gtk/wlan_stat_dlg.c | 6 +- ui/help_url.c | 3 + ui/help_url.h | 1 + ui/qt/CMakeLists.txt | 6 + ui/qt/Makefile.am | 6 + ui/qt/bluetooth_att_server_attributes_dialog.cpp | 58 +- ui/qt/bluetooth_att_server_attributes_dialog.h | 2 + ui/qt/bluetooth_att_server_attributes_dialog.ui | 16 + ui/qt/bluetooth_device_dialog.cpp | 58 +- ui/qt/bluetooth_device_dialog.h | 2 + ui/qt/bluetooth_device_dialog.ui | 16 + ui/qt/bluetooth_devices_dialog.cpp | 58 +- ui/qt/bluetooth_devices_dialog.h | 2 + ui/qt/bluetooth_devices_dialog.ui | 16 + ui/qt/bluetooth_hci_summary_dialog.cpp | 90 +- ui/qt/bluetooth_hci_summary_dialog.h | 3 + ui/qt/bluetooth_hci_summary_dialog.ui | 35 +- ...tock_icon_tool_button.h => clickable_label.cpp} | 42 +- ui/qt/{capture_info_dialog.h => clickable_label.h} | 22 +- ui/qt/file_set_dialog.cpp | 14 +- ui/qt/font_color_preferences_frame.cpp | 6 - ui/qt/import_text_dialog.cpp | 5 +- ui/qt/interface_frame.cpp | 116 +- ui/qt/interface_frame.h | 13 +- ui/qt/interface_frame.ui | 46 +- ui/qt/interface_sort_filter_model.cpp | 67 +- ui/qt/interface_sort_filter_model.h | 5 + ui/qt/interface_tree_cache_model.cpp | 400 + ui/qt/interface_tree_cache_model.h | 77 + ui/qt/interface_tree_model.cpp | 217 +- ui/qt/interface_tree_model.h | 14 + ui/qt/main_welcome.cpp | 57 +- ui/qt/main_welcome.h | 6 + ui/qt/main_welcome.ui | 41 +- ui/qt/main_window.cpp | 13 + ui/qt/main_window.h | 2 + ui/qt/main_window.ui | 12 +- ui/qt/main_window_slots.cpp | 18 + ui/qt/manage_interfaces_dialog.cpp | 194 +- ui/qt/manage_interfaces_dialog.h | 13 +- ui/qt/manage_interfaces_dialog.ui | 24 +- ui/qt/numeric_value_chooser_delegate.cpp | 117 + ...delegate.h => numeric_value_chooser_delegate.h} | 37 +- ui/qt/packet_list_model.cpp | 6 +- ui/qt/proto_tree.cpp | 4 - ui/qt/qcustomplot.cpp | 109 +- ui/qt/qcustomplot.h | 14 +- ui/qt/qt_ui_utils.cpp | 4 - ui/qt/sctp_chunk_statistics_dialog.cpp | 5 +- ui/qt/search_frame.ui | 3 + ui/qt/stock_icon.cpp | 4 - ui/qt/uat_delegate.cpp | 8 + ui/qt/uat_model.cpp | 35 +- ui/qt/voip_calls_dialog.cpp | 38 +- ui/qt/voip_calls_dialog.h | 1 + ui/qt/voip_calls_dialog.ui | 29 + ui/qt/wireless_frame.cpp | 2 +- ui/qt/wireshark_application.cpp | 16 + ui/qt/wireshark_application.h | 9 + ui/qt/wireshark_de.ts | 371 +- ui/qt/wireshark_en.ts | 386 +- ui/qt/wireshark_fr.ts | 371 +- ui/qt/wireshark_it.ts | 371 +- ui/qt/wireshark_ja_JP.ts | 370 +- ui/qt/wireshark_pl.ts | 372 +- ui/qt/wireshark_zh_CN.ts | 370 +- ui/qt/wlan_statistics_dialog.cpp | 55 +- ui/tap-sctp-analysis.c | 13 +- ui/tap-sctp-analysis.h | 2 +- ui/text_import.c | 1 + wireshark-qt.cpp | 21 +- wiretap/Makefile.am | 4 + wiretap/commview.c | 27 +- wiretap/logcat_text.c | 43 +- wiretap/network_instruments.c | 1 + wsutil/strtoi.h | 8 + wsutil/tempfile.c | 1 + 262 files changed, 17432 insertions(+), 10324 deletions(-) create mode 100644 cmake/modules/FindLZ4.cmake create mode 100644 cmake/modules/FindSNAPPY.cmake create mode 100644 debian/source/lintian-overrides create mode 100644 debian/wireshark-gtk.lintian-overrides create mode 100644 epan/dissectors/packet-fc00.c create mode 100644 test/captures/krb-816.pcap.gz create mode 100644 test/keys/krb-816.keytab copy ui/qt/{stock_icon_tool_button.h => clickable_label.cpp} (60%) copy ui/qt/{capture_info_dialog.h => clickable_label.h} (74%) create mode 100644 ui/qt/interface_tree_cache_model.cpp create mode 100644 ui/qt/interface_tree_cache_model.h create mode 100644 ui/qt/numeric_value_chooser_delegate.cpp copy ui/qt/{sparkline_delegate.h => numeric_value_chooser_delegate.h} (59%) hooks/post-receive -- wireshark with Osmocom specific dissectors