openbsc.git branch master updated. 0.15.0-201-gcf1302e

gitosis at gitosis at
Thu Mar 31 09:58:12 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  cf1302e4cb4875816615a23e5d7e2e9f7bcb5bca (commit)
       via  0d929be8264ba592313f2cdd9bc4bd9b2579df00 (commit)
       via  4e875aec0fda55bc93ea76c6992aaf3d90931d2d (commit)
       via  f9b212fabd0d5c37dac9639fc9d9ecd73688e3a3 (commit)
       via  d617c5d3ac65b5090f787da3e2911fb6742f515c (commit)
       via  4554a62c4d16bd95ae4fb38ede0fd9f64a4d1429 (commit)
       via  37984bdb1b507446421e5aa6131ccdf117dd269f (commit)
      from  56ea30ff3f9f98a4903d060196b185ce124d7eaa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit cf1302e4cb4875816615a23e5d7e2e9f7bcb5bca
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:30 2016 +0200

    Fix MM Auth: zero-initialize auth tuple before first use
    Make sure a new auth tuple is initialized after
    db_get_lastauthtuple_for_subscr() returns an error, i.e. if no tuple is present
    for the subscriber yet.
    Before this patch, the first key_seq depended on the typically uninitialized
    value that was present in auth tuple's key_seq upon calling
    The very first key_seq used for a new subscriber will now always be 0. Before,
    it used to be mostly 1 ("(0 + 1) % 7"), but depended on whether the key_seq was
    indeed initialized with 0, actually by random.

commit 0d929be8264ba592313f2cdd9bc4bd9b2579df00
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:29 2016 +0200

    Fix MM Auth: disallow key_seq mismatch
    In auth_get_tuple_for_subscr(), add missing condition to match incoming
    key_seq with stored key_seq, so that re-authentication is requested for
    mismatching key_seqs.
    Add test for this issue.

commit 4e875aec0fda55bc93ea76c6992aaf3d90931d2d
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:28 2016 +0200

    MM Auth: return AUTH_NOT_AVAIL instead of hardcoded zero
    AUTH_NOT_AVAIL == 0, so this is no functional change.

commit f9b212fabd0d5c37dac9639fc9d9ecd73688e3a3
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:27 2016 +0200

    MM Auth: introduce AUTH_ERROR constant.
    Instead of using hardcoded -1 for errors, include -1 in the enum auth_action
    type; apply its use.
    In the mm_auth test, the string output changes from '(internal error)' to
    'AUTH_ERROR', since now the proper enum value is used in auth_action_names[].

commit d617c5d3ac65b5090f787da3e2911fb6742f515c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:26 2016 +0200

    MM Auth test: add test to re-use existing auth

commit 4554a62c4d16bd95ae4fb38ede0fd9f64a4d1429
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:25 2016 +0200

    MM Auth test: add two tests for AUTH_THEN_CIPH
    Test two situations for AUTH_DO_AUTH_THEN_CIPH:
    - when no auth tuple is available
    - when the key sequence from LU is marked invalid
    Add convenience auth tuple comparison function using stringification.

commit 37984bdb1b507446421e5aa6131ccdf117dd269f
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Mar 30 11:22:24 2016 +0200

    Add MM Auth test; add auth_action_str() function
    Add basic MM Authentication test setup, with fake DB access and RAND_bytes().
    So far implement simple tests for IO error during DB access and missing auth
    To print the auth action during tests, add struct auth_action_names and
    auth_action_str() inline function in auth.[hc].


Summary of changes:
 openbsc/.gitignore                    |   1 +
 openbsc/                  |   1 +
 openbsc/include/openbsc/auth.h        |   9 +
 openbsc/src/libmsc/auth.c             |  33 +++-
 openbsc/tests/             |   2 +-
 openbsc/tests/mm_auth/     |  21 +++
 openbsc/tests/mm_auth/mm_auth_test.c  | 340 ++++++++++++++++++++++++++++++++++
 openbsc/tests/mm_auth/mm_auth_test.ok |  40 ++++
 openbsc/tests/            |   7 +
 9 files changed, 446 insertions(+), 8 deletions(-)
 create mode 100644 openbsc/tests/mm_auth/
 create mode 100644 openbsc/tests/mm_auth/mm_auth_test.c
 create mode 100644 openbsc/tests/mm_auth/mm_auth_test.ok

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list