openbsc.git branch neels/patches-pending created. 0.15.0-189-g7349a4e

gitosis at gitosis at
Mon Mar 14 12:55:58 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, neels/patches-pending has been created
        at  7349a4e7f8d0dbf3ce2aa417c14aead373446c0a (commit)

- Log -----------------------------------------------------------------

commit 7349a4e7f8d0dbf3ce2aa417c14aead373446c0a
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Mar 14 13:41:20 2016 +0100

    bsc_scan_msc_msg: check protocol discriminator
    The function assumed an MM protocol discriminator without verifying it.

commit 677d8ba284b881a6443d11c63f39cc6bf1bee1bf
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Mar 7 16:48:38 2016 +0100

    fix confusing typo in constant (THAN -> THEN)

commit 81c4f3457ded86e18fc4de6c4bf7656042c43f2b
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Mar 10 12:19:13 2016 +0100

    GSM 04.08: apply bitmask functions, fix bitmask use
    Replace hardcoded protocol discriminator and message type bitmasks with
    function calls recently introduced in libosmocore.
    Note that the release 98 bitmasks slightly differ from the release 99 bitmasks.
    This patch uses the "default" gsm48_hdr_msg_type invocation, thus it depends on
    libosmocore whether 98 or 99 bitmasks are used.
    In some places, use of the bitmask was erratic. Fix these implicitly by
    employing the bitmask functions:
     * bsc_msg_filter.c: bsc_msg_filter_initial(): RR vs. MM messages.
     * osmo_bsc_filter.c: bsc_find_msc() and bsc_scan_bts_msg(): RR vs. MM
     * bsc_nat_rewrite.c: bsc_nat_rewrite_msg(): SMS vs. CC messages.
     * bsc_ussd.c: no bitmask is applicable for the message types used here.

commit 530414d77e6f22c109257496cd0e1f1249acb06e
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Mar 7 17:19:19 2016 +0100

    Remove unused auth code and add comment
    As commented in the code, the GSM_SECURITY_AUTH_FAILED path is never invoked by
    the gsm48_secure_channel() function as it is today.
    Note that the upcoming Iu auth will probably add a GSM_SECURITY_AUTH_FAILED
    status. In that case, sending a LU Reject immediately may be desirable, but
    arguably a bit of timeout could make life harder for auth attackers.
    The code removed by this patch doesn't send out a LU Reject ever, since a call
    to release_loc_updating_req() only releases the connection. To reject, a call
    to gsm0408_loc_upd_rej() would be necessary, as seen in loc_upd_rej_cb().
    And finally, if _gsm0408_authorize_sec_cb() doesn't do anything about anything,
    the same loc_upd_rej_cb() will be run by a timeout and send a LU Reject
    properly (as commented in the code).


The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list