This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, ttsou/edge has been created at 53e8b2dd3ed14923f1e7dc0384166da28bcd4ac8 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=53e8b2dd3ed14923f1e7dc0384166da28bcd4ac8 commit 53e8b2dd3ed14923f1e7dc0384166da28bcd4ac8 Author: Tom Tsou <tom.tsou at ettus.com> Date: Thu Jun 2 13:48:32 2016 -0700 TRX: Add EDGE coding and decoding support Burst length (148 or 444 bits) and data length (209 to 1234 bits) are used to differentiate GSM/GPRS and EDGE payloads. Data lengths is inclusive of EDGE header and data sections. On the uplink path, the header is recovered and decoded to determine data section MCS, however, no additional parsed header information is used or maintained. Signed-off-by: Tom Tsou <tom.tsou at ettus.com> http://cgit.osmocom.org/osmo-trx/commit/?id=018a3f61943cf4e5d5b77ccda54986946d7bbb57 commit 018a3f61943cf4e5d5b77ccda54986946d7bbb57 Author: Tom Tsou <tom.tsou at ettus.com> Date: Thu Jun 2 12:06:10 2016 -0700 TRX: Add burst length field to scheduler interfaces Existing interfaces are coded with the implicit expectation of using a burst sequence length of 148, which is constant with GSM and GPRS. That changes with EDGE, where the burst length is now 444 due to 8-PSK instead of GMSK modulation. Setup the interface to accept and return a length value with the burst sequence. Keep the burst processing unchanged with support for only 148 bits for now. Signed-off-by: Tom Tsou <tom.tsou at ettus.com> http://cgit.osmocom.org/osmo-trx/commit/?id=1ddea5f86e00e83dca74815116d7b1f510867166 commit 1ddea5f86e00e83dca74815116d7b1f510867166 Author: Tom Tsou <tom.tsou at ettus.com> Date: Thu Mar 24 14:48:21 2016 -0700 TRX: Add EDGE coding tables Add EGPRS header and data coding tables for parity, convolutional coding, interleaving, and mapping. Signed-off-by: Tom Tsou <tom.tsou at ettus.com> http://cgit.osmocom.org/osmo-trx/commit/?id=201b424b73ebd4da49d2fbad85d66a7068a9a28f commit 201b424b73ebd4da49d2fbad85d66a7068a9a28f Author: Max <msuraev at sysmocom.de> Date: Wed May 18 17:22:49 2016 +0200 Use libosmocore function for uplink measurements Related: OS#1563 Change-Id: Ide47e8e69e0d2d5859c5249b22f4bad22c18aa57 Reviewed-on: https://gerrit.osmocom.org/108 Tested-by: Jenkins Builder Reviewed-by: Harald Welte <laforge at gnumonks.org> http://cgit.osmocom.org/osmo-trx/commit/?id=0778cd488a6696772e2fda32ee9ab9889f439d62 commit 0778cd488a6696772e2fda32ee9ab9889f439d62 Author: Daniel Laszlo Sitzer <dlsitzer at gmail.com> Date: Tue May 31 11:09:40 2016 +0200 octphy: Update outdated config param name in error message. Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 Reviewed-on: https://gerrit.osmocom.org/129 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger at freyther.de> http://cgit.osmocom.org/osmo-trx/commit/?id=ed494443cc1e9732b43ef99cccf187d17ac931ef commit ed494443cc1e9732b43ef99cccf187d17ac931ef Author: Max <msuraev at sysmocom.de> Date: Thu Apr 21 18:55:09 2016 +0200 Ensure TRX invariant There is implicit invariant in trx_phy_instance() which is actively used by various hw-specific implementations to get TRX's phy instance. Let's make sure there's explicit assertion for this because there's been segfaults in the past related to it. http://cgit.osmocom.org/osmo-trx/commit/?id=b61850248adbf717eb323d9ce7a17a817c302544 commit b61850248adbf717eb323d9ce7a17a817c302544 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Apr 13 19:09:10 2016 -0400 jenkins: Add the build script from jenkins here This can be used to replicate a build issue more easily. Build specific to the Octphy. http://cgit.osmocom.org/osmo-trx/commit/?id=c8da1ac9a6d4a3bec039e67036009445de970382 commit c8da1ac9a6d4a3bec039e67036009445de970382 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Apr 13 19:07:49 2016 -0400 jenkins: Add the build script from jenkins here This can be used to replicate a build issue more easily. http://cgit.osmocom.org/osmo-trx/commit/?id=227015e52e993bf8cd2228f5e7d0acce3ead910f commit 227015e52e993bf8cd2228f5e7d0acce3ead910f Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Apr 1 17:02:11 2016 +0200 misc: Ignore files generated by a debian packaging build http://cgit.osmocom.org/osmo-trx/commit/?id=460e1b7387ded53bd2ba320d3108196dc7100d40 commit 460e1b7387ded53bd2ba320d3108196dc7100d40 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Apr 1 16:46:42 2016 +0200 debian: Create initial packaging for the osmo-bts-trx This is only with osmo-bts-trx as others require headers that are not packaged yet. http://cgit.osmocom.org/osmo-trx/commit/?id=21fc6e45fbe201dcc6c066a006cef899e931064a commit 21fc6e45fbe201dcc6c066a006cef899e931064a Author: Max <msuraev at sysmocom.de> Date: Tue Mar 22 15:40:12 2016 +0100 LC15: properly initialize unmapped phy instances Fixes: OS#1665 http://cgit.osmocom.org/osmo-trx/commit/?id=925fcf48ed94c3907dee5cfcbd8cd2f2fece7b85 commit 925fcf48ed94c3907dee5cfcbd8cd2f2fece7b85 Author: Max <msuraev at sysmocom.de> Date: Tue Mar 22 15:40:09 2016 +0100 LC15: add stubs for phy link/instance defaults http://cgit.osmocom.org/osmo-trx/commit/?id=0fe3b215b9c8b159491fc1423cba41f4fb9f3214 commit 0fe3b215b9c8b159491fc1423cba41f4fb9f3214 Author: Max <msuraev at sysmocom.de> Date: Tue Mar 22 15:40:08 2016 +0100 LC15: ignore build byproducts http://cgit.osmocom.org/osmo-trx/commit/?id=06968beab90806cba94c8b331276e4dc209c152b commit 06968beab90806cba94c8b331276e4dc209c152b Author: Max <msuraev at sysmocom.de> Date: Mon Mar 21 15:39:02 2016 +0100 octphy: fix for multiple trx with more than 1 dsp Explicitly store and use "center" arfcn used by each dsp (1 dsp corresponds to 1 phy link). http://cgit.osmocom.org/osmo-trx/commit/?id=ae5a737c18aebfdc2e1cb66787b070a11eb20772 commit ae5a737c18aebfdc2e1cb66787b070a11eb20772 Author: Max <msuraev at sysmocom.de> Date: Fri Mar 18 15:43:56 2016 +0100 octphy: add example configuration with 2 trx http://cgit.osmocom.org/osmo-trx/commit/?id=c4fc00d8515ddc9990dfaf700c501cb8fe490cab commit c4fc00d8515ddc9990dfaf700c501cb8fe490cab Author: Max <msuraev at sysmocom.de> Date: Fri Mar 18 15:30:30 2016 +0100 octphy: add support for multiple trx ids http://cgit.osmocom.org/osmo-trx/commit/?id=3044a26d719dd6099e229137f6669ee17ffd48a1 commit 3044a26d719dd6099e229137f6669ee17ffd48a1 Author: Max <msuraev at sysmocom.de> Date: Fri Mar 18 15:29:54 2016 +0100 octphy: use octasic's routines for debug output http://cgit.osmocom.org/osmo-trx/commit/?id=b857f277045b0a5b1313f7d5ca655aeee22652c7 commit b857f277045b0a5b1313f7d5ca655aeee22652c7 Author: Max <msuraev at sysmocom.de> Date: Thu Mar 17 18:23:55 2016 +0100 Fix typo in error message http://cgit.osmocom.org/osmo-trx/commit/?id=9591b6c253d595c44b3ef811d898f606a66203f8 commit 9591b6c253d595c44b3ef811d898f606a66203f8 Author: Max <msuraev at sysmocom.de> Date: Thu Mar 17 16:23:07 2016 +0100 octphy: add missing include to fix the build http://cgit.osmocom.org/osmo-trx/commit/?id=bb0cc685f1b7a932492941f13ddd53014501cb55 commit bb0cc685f1b7a932492941f13ddd53014501cb55 Author: Max <msuraev at sysmocom.de> Date: Thu Mar 17 11:37:24 2016 +0100 Add utility to check proper scheduling of SI There are several types of System Information messages with tricky scheduling rules described in 3GPP TS 05.02 § 6.3.1.3. This GNU Awk script takes in .csv file with sequence of scheduled SI messages (for example generated using tshark from GSMTAP capture - see usage note inside the script) and check the scheduling rules compliance. http://cgit.osmocom.org/osmo-trx/commit/?id=6044785a2265ae862450f4945c5fb12a7c28fe29 commit 6044785a2265ae862450f4945c5fb12a7c28fe29 Author: Max <msuraev at sysmocom.de> Date: Thu Mar 17 11:37:23 2016 +0100 Ignore binary and backup files Add missing entries to .gitignore http://cgit.osmocom.org/osmo-trx/commit/?id=b2b1112a6e20ad632dcec0d9f1afe1ab80583d2d commit b2b1112a6e20ad632dcec0d9f1afe1ab80583d2d Author: Max <msuraev at sysmocom.de> Date: Thu Mar 17 11:37:22 2016 +0100 Add explicit check for SI2quater index and count Right now we do not support multiple SI2quater messages, so return error if either index or count is non-zero. http://cgit.osmocom.org/osmo-trx/commit/?id=f3ee66207de2859cf4751b44241c0f84cf0999b4 commit f3ee66207de2859cf4751b44241c0f84cf0999b4 Author: Max <msuraev at sysmocom.de> Date: Thu Mar 17 12:32:12 2016 +0100 Fix SI2ter scheduling According to 3GPP TS 05.02 § 6.3.1.3 SI2ter messages should be scheduled in FN with TC=4 only if SI2bis messages are also available. http://cgit.osmocom.org/osmo-trx/commit/?id=0be80aa2d1d21b2d19eb6c91b3b4151d6c3a5ddf commit 0be80aa2d1d21b2d19eb6c91b3b4151d6c3a5ddf Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 16 09:17:04 2016 +0100 octphy: Enable TCH/H mode and begin testing Upcoming releases will support TCH/H and we should start to test the DSP->RTP code. http://cgit.osmocom.org/osmo-trx/commit/?id=710e99c2e317b75695e2bc7ad4569e2377b41c3b commit 710e99c2e317b75695e2bc7ad4569e2377b41c3b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Mar 15 20:09:49 2016 +0100 misc: Attempt to fix make distcheck and dumping docs The file has been renamed, attempt to catch up http://cgit.osmocom.org/osmo-trx/commit/?id=40e83658543f321368ed88b0505093b707b7eada commit 40e83658543f321368ed88b0505093b707b7eada Author: Harald Welte <laforge at gnumonks.org> Date: Mon Mar 14 18:35:31 2016 +0100 Update configuration examples Add SysmoBTS-specific example. Remove outdated generic example which is no longer working. http://cgit.osmocom.org/osmo-trx/commit/?id=d5c658b22e3e8dcb5b3ab96cb761171a3e170282 commit d5c658b22e3e8dcb5b3ab96cb761171a3e170282 Author: Max <msuraev at sysmocom.de> Date: Fri Mar 11 12:21:24 2016 +0100 Fix copy-paste issue This issue prevented scheduling of SI 2quater messages. http://cgit.osmocom.org/osmo-trx/commit/?id=91565b2d51646657002f91fdc22dce3c7320e13a commit 91565b2d51646657002f91fdc22dce3c7320e13a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Mar 10 16:15:51 2016 +0100 octphy: Use the event defaults as base Bad parameters are passed to the event structure and the default initialization should happen. http://cgit.osmocom.org/osmo-trx/commit/?id=2278fdc580c9c095bffe539b95b0bf77b32de83e commit 2278fdc580c9c095bffe539b95b0bf77b32de83e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Mar 10 16:10:11 2016 +0100 pcuif: Do not bump the PCU_IF version I had accidently bumped the version as I thought that osmo_ph_pres_info_type was part of the ABI. It is not an only internal to the BTS. Revert this part of the change. http://cgit.osmocom.org/osmo-trx/commit/?id=cb20c83323da485ff392ccffa7ec75de8e2ffede commit cb20c83323da485ff392ccffa7ec75de8e2ffede Author: Max <msuraev at sysmocom.de> Date: Thu Feb 18 17:48:07 2016 +0100 Fix ocmo-bts-octphy interaction with OsmoPCU Previously osmo-bts-octphy have not provided in-band presence information which cause off-by-one errors and misinterpretation of ph_data_ind by PCU. This fixed now by adding support for explicitly passing PH-DATA presence info. Corresponding check and in-band passing of presence information are removed. Note: this requires libosmocore version with osmo_ph_pres_info_type support integrated. [hfreyther/max: Remove + 1 from the decoded length] http://cgit.osmocom.org/osmo-trx/commit/?id=94bb3769f36c8b64c5dc196f02f22994543997d2 commit 94bb3769f36c8b64c5dc196f02f22994543997d2 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 15 20:16:07 2016 +0100 scheduler: Fix ARRAY_SIZE() in trx_sched_init() We want the size of the array, not of the pointer to the array. Found by coverity (CID 1351422). http://cgit.osmocom.org/osmo-trx/commit/?id=e81cc6a158688360679402c5c11067b6a234bdfa commit e81cc6a158688360679402c5c11067b6a234bdfa Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 15 20:13:04 2016 +0100 use unsigned int to compare wih ARRAY_SIZE This is not really an issue, but makes coverity happy (CID 1351422). http://cgit.osmocom.org/osmo-trx/commit/?id=69b959e557b427052ee47749c82459e094f6f264 commit 69b959e557b427052ee47749c82459e094f6f264 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 15 20:11:43 2016 +0100 sysmobts_vty: Fix null-check for pinst There was a copy+paste error, checking for plink but we should check for pinst. This was found by coverity (CID 1351424). http://cgit.osmocom.org/osmo-trx/commit/?id=ad7f7a7117efd3fa61c27c714725dbf266b85c7b commit ad7f7a7117efd3fa61c27c714725dbf266b85c7b Merge: 5a945da 81cc8cd Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 15 14:28:50 2016 +0100 Merge branch 'laforge/litecell15' http://cgit.osmocom.org/osmo-trx/commit/?id=81cc8cdba51b38b503bcfedd98a4b29f4b47e6dd commit 81cc8cdba51b38b503bcfedd98a4b29f4b47e6dd Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 25 15:44:05 2016 +0100 LC15: remove bogus check_for_ciph_cmd() copy http://cgit.osmocom.org/osmo-trx/commit/?id=e634fd256b5428c6ac5dbe61bd6189fd9fa31d7b commit e634fd256b5428c6ac5dbe61bd6189fd9fa31d7b Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 22 17:42:35 2016 +0100 LC15: set nominal transmit power of 37dBm for all TRX http://cgit.osmocom.org/osmo-trx/commit/?id=433863e4c9a5104959803e91e719a772f9bea9b4 commit 433863e4c9a5104959803e91e719a772f9bea9b4 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 22 10:03:26 2016 +0100 LC15: Fix 'make dist' (missing include files) http://cgit.osmocom.org/osmo-trx/commit/?id=634c3e46484a0932f8a04b894be215b9288eecff commit 634c3e46484a0932f8a04b894be215b9288eecff Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 19:41:49 2016 +0100 Use consistent naming of binaries accross BTS models Let's use one systematic naming schemes for all BTS models. osmobts-trx -> osmo-bts-trx sysmobts -> osmo-bts-sysmo lc15bts -> osmo-bts-lc15 http://cgit.osmocom.org/osmo-trx/commit/?id=a9a7120c82f571554e6c1417eec0803f15e6c7bb commit a9a7120c82f571554e6c1417eec0803f15e6c7bb Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 23:34:43 2016 +0100 make PCU socket and telnet port configurable In some cases we'd like to run multiple instances of osmo-bts on a single machine. This is the case where we a multi-TRX PHY is to be used for several BTSs, or in case osmo-bts-trx has multple SDRs attached. This wa currently prevented by having a hard-coded PCU socket path and telnet port, which are now configurable via VTY / config file itself. http://cgit.osmocom.org/osmo-trx/commit/?id=5dfb115eaf16a5c5e9ccea5b03374651aa97da11 commit 5dfb115eaf16a5c5e9ccea5b03374651aa97da11 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 23:16:31 2016 +0100 declare pcu_direct in pcu_if.h http://cgit.osmocom.org/osmo-trx/commit/?id=c6723c82064caec54faeec80b0afd8159140c96d commit c6723c82064caec54faeec80b0afd8159140c96d Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 23:06:30 2016 +0100 move auto-band configuration commands to common/vty.c It remains up to the individual BTS hardware models to decide whether or not to register those commands (depending on whether they support the feature) via cfg_bts_auto_band_cmd / cfg_bts_no_auto_band_cmd http://cgit.osmocom.org/osmo-trx/commit/?id=3b4d9e7c076df65257183c313a7f436fd6e66ca8 commit 3b4d9e7c076df65257183c313a7f436fd6e66ca8 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jan 21 18:12:28 2016 +0100 LC15: Call l1if_reset() after l1if_open() We want to start talking to the L1 from the point the PHY link has been opened, and not only once an OML connection has been established. http://cgit.osmocom.org/osmo-trx/commit/?id=53e0291df6e9b601bd56d55d4a41c5268ee9bd87 commit 53e0291df6e9b601bd56d55d4a41c5268ee9bd87 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 22:55:03 2016 +0100 LC15: Remove clk_cal (another unused struct member) http://cgit.osmocom.org/osmo-trx/commit/?id=e9a17292e8545d5f651e9614c43bc1626e10ac5f commit e9a17292e8545d5f651e9614c43bc1626e10ac5f Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 22:50:06 2016 +0100 LC15/sysmobts: Don't try to refer to fl1h from PHY config At the time the phy link / phy instance level VTY configuration commands are parsed, we did not yet call l1if_open() and thus pinst->u.{lc15,sysmobts}.hdl == NULL. PHY or PHY instance specific configuration must thus be stored inside the phy_link or phy_instance itself, and not inside the (not yet existing) handle. We solve this by moving around some parameters: * clk_use_eeprom/clk_cal/clk_src/calib_path get replicated in phy_instance * min_qual_{rach,norm} are moved into the generic part (which means that osmo-bts-octphy and osmo-bts-trx should also implement them) http://cgit.osmocom.org/osmo-trx/commit/?id=9b5cff87ecc4b76f9f8a0a86aa64e9394e2a8374 commit 9b5cff87ecc4b76f9f8a0a86aa64e9394e2a8374 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 22:32:05 2016 +0100 LC15: Remove unused clk_use_eeprom and clk_src fields this is part of the copy+paste legacy from sysmobts and can be removed as it is not used. http://cgit.osmocom.org/osmo-trx/commit/?id=9684099ae905e6e61cbc326035d0b37c480f6172 commit 9684099ae905e6e61cbc326035d0b37c480f6172 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 21:56:47 2016 +0100 sysmobts/LC15: Fix startup-time DSP trace flage configuration Due to the changes introduced by the phy_link API, it's not easy to set the default DSP trace flags via a command line argument anymore. We now rather introduce a persitent VTY configuration command, by which the default DSP tracing configuration can be set (for each PHY). The persistent trace flags are stored in the phy_instance, while the current operational run-time flags are in fl1h->phy_instance. http://cgit.osmocom.org/osmo-trx/commit/?id=38933afdd95f9e809c2e3a15ff860d22b22f27c4 commit 38933afdd95f9e809c2e3a15ff860d22b22f27c4 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 21:54:21 2016 +0100 introduce + use new generic vty_get_phy_instance() this function is intended to be used by VTY commands that need to resolve a given PHY interface. http://cgit.osmocom.org/osmo-trx/commit/?id=6a0f0f9e21e46055dd8481036c75f49d89863639 commit 6a0f0f9e21e46055dd8481036c75f49d89863639 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 19:47:58 2016 +0100 LC15: fix compiler warning against more recent libosmovty http://cgit.osmocom.org/osmo-trx/commit/?id=4dd8bd84a4c2ab2018ee372dd235cb8a7e45e76d commit 4dd8bd84a4c2ab2018ee372dd235cb8a7e45e76d Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 19:32:30 2016 +0100 LC15: Fix printed msgq file names in error messages http://cgit.osmocom.org/osmo-trx/commit/?id=8f0266b8855df7569a6b6a9a6e62b18e004de20d commit 8f0266b8855df7569a6b6a9a6e62b18e004de20d Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 19:29:45 2016 +0100 LC15: cosmetic whitespace fixes http://cgit.osmocom.org/osmo-trx/commit/?id=234309878edffba3d2cf76992fc0e311dd94b827 commit 234309878edffba3d2cf76992fc0e311dd94b827 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 19:25:43 2016 +0100 LC15: Add example configuration file for Litecell 1.5 http://cgit.osmocom.org/osmo-trx/commit/?id=1dcb97eaa355e0dbd1d85e5c8a6243ab2d58609f commit 1dcb97eaa355e0dbd1d85e5c8a6243ab2d58609f Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 17:48:42 2016 +0100 LC15: port litecell 1.5 support to recent osmo-bts master This includes changes required for * shared main() function accross all BTS models * use of the new phy_link / phy_instance infrastructure as the basis for true multi-TRX operation http://cgit.osmocom.org/osmo-trx/commit/?id=29a0197ead937c713a3b8e8339d2a3974ac6f0c9 commit 29a0197ead937c713a3b8e8339d2a3974ac6f0c9 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 16:56:34 2016 +0100 LC15: configure.ac: Allow specifying an alternate include-dir The user can now use ./configure --with-litecell15=/my/local/path http://cgit.osmocom.org/osmo-trx/commit/?id=ccc7a1bf46d05a2b910b0b995e99e3e1f28f1fae commit ccc7a1bf46d05a2b910b0b995e99e3e1f28f1fae Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 16:33:48 2016 +0100 LC15: configure.ac: use --enable-litecell15 insteda of --enable-litecell15-bts http://cgit.osmocom.org/osmo-trx/commit/?id=b936bd7162f29cab0cfe2d31139a5ffd997b029e commit b936bd7162f29cab0cfe2d31139a5ffd997b029e Author: Yves Godin <yves.godin at nutaq.com> Date: Mon Dec 7 10:27:46 2015 -0500 LC15: use talloc pool for msgb and ortp library by using a talloc pool, we avoid having to go back to the libc malloc pool all the time. The msgb allocations and libortp allocations happen quite frequently during processing and show up as one of the high priority items in osmo-bts profiles on sysmoBTS with 14 concurrent TCH/H calls (highest load scenario). talloc still consumes significant CPU, this is mostly due to the zero-initialization of all the associated buffers. Strictly speaking we shouldn't need this, but any change there would require lots of testing, as there might be hidden assumptions in the code? In some percentage of cases, talloc still seems to fall back on malloc for msgb allocations, which is currently a bit of a mystery. The pools certainly are large enough, talloc_reprt() rarely reports more than a few tens of kilobytes used by the msgb pool. From 2ecbf871301cdc36c0212dd7526fc94ffa4597d1 http://cgit.osmocom.org/osmo-trx/commit/?id=6e1aed4b230a8e9be53ab487515ba10723ef99b3 commit 6e1aed4b230a8e9be53ab487515ba10723ef99b3 Author: Yves Godin <yves.godin at nutaq.com> Date: Mon Dec 7 10:27:32 2015 -0500 LC15: Disable DSP trace flags by default http://cgit.osmocom.org/osmo-trx/commit/?id=2a711887b7e91893555891e5c033189d6705eec3 commit 2a711887b7e91893555891e5c033189d6705eec3 Author: Yves Godin <support at nuranwireless.com> Date: Thu Nov 12 08:32:07 2015 -0500 LC15: Add initial support for the NuRAN Wireless Litecell 1.5 This commit adds basic support for the Litecell 1.5. Multi-TRX is not supported yet. Instead, multiple instances of the BTS can be launched using command line parameter -n <HW_TRX_NR> to specify if TRX 1 or 2 must be used by the bts. Note that only TRX 1 opens a connection to the PCU. Full support for GPRS on both TRX will come at the same time than the multi-TRX support. The BTS manager has been adapted to match the new hardware but otherwise it has not been improved or changed compared to the one used on the SuperFemto/Litecell (sysmobts). http://cgit.osmocom.org/osmo-trx/commit/?id=5a945dad0cb34dc351427b33a3ce0ed9dd0e394f commit 5a945dad0cb34dc351427b33a3ce0ed9dd0e394f Author: Harald Welte <laforge at gnumonks.org> Date: Wed Feb 3 23:19:27 2016 +0100 sysmobts: make clock calibration eeprom default (again?) http://cgit.osmocom.org/osmo-trx/commit/?id=b1d2dd316ff606cb94515dd55fea896237e5ef74 commit b1d2dd316ff606cb94515dd55fea896237e5ef74 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 22 17:46:47 2016 +0100 abis.c: Fix segfault on OML link loss When the OML signalling link is lost, first set bts->oml_link = NULL, then iterate over the RSL links and close them. Closing the RSL link will cause a OML state change message to be sent, which in turn tries to use the no-longer-existing OML link. The code should be cleaned up further to distinguish which signalling link was lost, and actually communicate a RSL(only) loss to OML. But for now, it's best to simply close down all links and terminate osmo-bts to ensure all state is properly reset and recovered. http://cgit.osmocom.org/osmo-trx/commit/?id=f5b42c34219ef8d01987b4d811be3bc8035e337d commit f5b42c34219ef8d01987b4d811be3bc8035e337d Merge: f585428 a02bf12 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 15 14:19:46 2016 +0100 Merge branch 'laforge/phy-link' this introduces the new phy_link / phy_instance interface, which is the basis of clean support for all kinds of multi-trx configurations with various BTS modules. WARNING: This breaks configuration file compatibility. You will need to introduce config nodes for 'phy' and 'instance', as well as the link from the 'trx' nodes towards the phy instance. http://cgit.osmocom.org/osmo-trx/commit/?id=a02bf125accedddc43b2d8ce3093c72d4e41ffc3 commit a02bf125accedddc43b2d8ce3093c72d4e41ffc3 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jan 19 20:22:07 2016 +0100 port sysmobts to phy_link/phy_instance abstraction http://cgit.osmocom.org/osmo-trx/commit/?id=fcef6b2b5200daaaedea012c352edbdbd9c8a722 commit fcef6b2b5200daaaedea012c352edbdbd9c8a722 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 18 11:23:38 2016 +0100 don't touch OML MO when PHY link is established It seems the right thing to do: Once we know a PHY link is established, the associated OML managed objects should change their state accordingly. However, given all the hackery we do with MO states, this actually breaks things, rather than helping. So I'm disabling that part for now, but this needs to be re-visited at some point. http://cgit.osmocom.org/osmo-trx/commit/?id=d784e50747b8cf0ce505489e1451f75be5ccbd4b commit d784e50747b8cf0ce505489e1451f75be5ccbd4b Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 13:13:37 2016 +0100 Introduce new phy_link and phy_instance abstraction This way we can model a flexible mapping between any number of PHYs, each having multiple instances, and then map BTSs with TRXx on top of those PHYs. http://cgit.osmocom.org/osmo-trx/commit/?id=f58542899a91d1db0bbe9966ae98ccdf449f45d0 commit f58542899a91d1db0bbe9966ae98ccdf449f45d0 Merge: 5f17720 1a5b00e Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 15 14:18:06 2016 +0100 Merge branch 'laforge/trx-split' This splits the TRX scheduler into a generic part and an osmo-bts-trx specific part. It is the basis for re-using the scheduler from other bts modules such as the upcoming osmo-bts-virtual. http://cgit.osmocom.org/osmo-trx/commit/?id=1a5b00ebe28b5ff569a5354cf5784e5644e88d98 commit 1a5b00ebe28b5ff569a5354cf5784e5644e88d98 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 23:28:57 2016 +0100 TRX: Move scheduler to src/common This is the final step to make the L1 scheduler generally available to other BTS models than OsmoTRX. http://cgit.osmocom.org/osmo-trx/commit/?id=48726242add87e6850c64a4a6d3801a4b54084a5 commit 48726242add87e6850c64a4a6d3801a4b54084a5 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 23:21:00 2016 +0100 TRX: scheduler: Remove dependency to trx_if.[ch] http://cgit.osmocom.org/osmo-trx/commit/?id=67311cc1f20c88a0ad0afe488ec136d985477b81 commit 67311cc1f20c88a0ad0afe488ec136d985477b81 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 23:15:41 2016 +0100 TRX: scheduler: Move trx_sched_clock() to scheduler_trx.c This funciton (and associated static functions) are TRX specific, and scheduler.c should only contain generic code. http://cgit.osmocom.org/osmo-trx/commit/?id=b6b42d150db5ef707ad17b0005d7de8f0f538390 commit b6b42d150db5ef707ad17b0005d7de8f0f538390 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 23:03:34 2016 +0100 TRX: scheduler: don't access l1h->config from scheduler http://cgit.osmocom.org/osmo-trx/commit/?id=11db925f156ddce72cca09275fc2d270efda049b commit 11db925f156ddce72cca09275fc2d270efda049b Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 22:39:04 2016 +0100 TRX: call trx_loop_sacch_clock from TRX scheduler backend this removes the dependency of scheduler.c on loops.h http://cgit.osmocom.org/osmo-trx/commit/?id=2b0e20902933148b67c18a77c4f23f16d35cff8c commit 2b0e20902933148b67c18a77c4f23f16d35cff8c Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 22:17:52 2016 +0100 TRX: split scheduler in generic part and backend part the backend is performing the actual encoding and decoding functions, while the generic part constsits of the TDMA structures and generating the RTS.ind http://cgit.osmocom.org/osmo-trx/commit/?id=5538f5cff824f19d5dc8781cbb93525ad45ad833 commit 5538f5cff824f19d5dc8781cbb93525ad45ad833 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 21:33:58 2016 +0100 TRX: factor out the scheduler from remaining code The L1 scheduler is a generally useful component that is unfortunately tied quite a bit into the OsmoTRX support. Let's try to separate it out by having separate per-trx/per-ts/per-chan data structures pre-fixed with l1sched_ Using this patch it should be one step easier to use the scheduler for other BTS models, such as the intended upcoming virtual BTS. http://cgit.osmocom.org/osmo-trx/commit/?id=5f17720fcd3285d75c32359fbbe35e5ffa720778 commit 5f17720fcd3285d75c32359fbbe35e5ffa720778 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 25 15:43:03 2016 +0100 fix migration of check_for_ciph_cmd() from sysmobts to l1sap During the L1SAP related changes, somehow an old version of check_for_ciph_cmd() was re-introduced, which didn't store the N(s) as part of the lchan. To make things worse, the old code was still present in the sysmobts specific part, but never executed. http://cgit.osmocom.org/osmo-trx/commit/?id=5d212055b7379b22da27d5c70b43e61491cd2381 commit 5d212055b7379b22da27d5c70b43e61491cd2381 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 20 19:02:51 2016 +0100 L1SAP: Ensure we don't process MPH-TIME.indication on TRX != C0 http://cgit.osmocom.org/osmo-trx/commit/?id=6f9beedc4871fbee09f8105bc3caa34f5086c5f6 commit 6f9beedc4871fbee09f8105bc3caa34f5086c5f6 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 17 12:36:22 2016 +0100 fix compile warnings http://cgit.osmocom.org/osmo-trx/commit/?id=131ab36e3a0455d406062c1549f864d728bc90d6 commit 131ab36e3a0455d406062c1549f864d728bc90d6 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 18 10:14:54 2016 +0100 abis: Add a queue of OML messages When the oml_link is down or not yet established, we currently lost any OML messages that were scheduled for transmission to the BSC. Let's prevent that by keeping a queue of OML messages, which is drained at the time the OML link comes up again. http://cgit.osmocom.org/osmo-trx/commit/?id=2ed116efeca67987257d4c2d95fd3c9ac873d57d commit 2ed116efeca67987257d4c2d95fd3c9ac873d57d Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 18 10:35:44 2016 +0100 Revert "oml: temporary debug hack" This reverts commit c623c4e589d887f8ba779a03543213d55b6d82f4. That's a commit from 2012, and it was never needed ever since. http://cgit.osmocom.org/osmo-trx/commit/?id=5f8c85bf9cf740676905f9fad5d97d4a8f518b1e commit 5f8c85bf9cf740676905f9fad5d97d4a8f518b1e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Feb 3 18:29:00 2016 +0100 octphy: Look-up the right timeslot and then the logical chan Use the right identifier for the timeslot and not the trx number which would always use ts==0 on the first trx. This should fix ciphering issues for TS>0 (e.g. SDCCH8 on TS==1) http://cgit.osmocom.org/osmo-trx/commit/?id=3ca59512d2f4eb1f87699e8fada67f33674918b4 commit 3ca59512d2f4eb1f87699e8fada67f33674918b4 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 25 20:44:15 2016 +0100 OML: Ignore T200 settings by BSC for now It seems that once we start to respect the T200 values as specified by the BSC, we run into all kinds of issues with LAPDm re-transmissions, REJ frames, unexpected supervisory frames and the like. The libosmogsm LAPDm T200 defaults of 1s/2s are proven to "work" (i.e. not expose the above behavior), so let's revert to them until the root cause of this problem is determined. http://cgit.osmocom.org/osmo-trx/commit/?id=111a02f21440ff5a413466ec25c576d768225baa commit 111a02f21440ff5a413466ec25c576d768225baa Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 25 20:33:48 2016 +0100 lapdm: Add DEBUGP statement about T200 values being set for lchan http://cgit.osmocom.org/osmo-trx/commit/?id=0d19e4848723dda10a31a68b89314414a2eab26b commit 0d19e4848723dda10a31a68b89314414a2eab26b Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 25 20:30:18 2016 +0100 Fix T200 default values The T200 default values should be in milli-seconds (as the variable name indicates). They are not expected to be divided by the TS 12.21 OML dividers for T200. This change doesn't really make a difference with OpenBSC, as the BSC always sets its own T200 values via OML, overwriting the defaults here. http://cgit.osmocom.org/osmo-trx/commit/?id=728448a7f18d8b771c56f16777110c83d4f00a2b commit 728448a7f18d8b771c56f16777110c83d4f00a2b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Jan 23 10:25:24 2016 +0100 main: Return something from the method Fixes: CID#59923 http://cgit.osmocom.org/osmo-trx/commit/?id=0db18d030d8e540e723fe21a14b0b5748c65d0fe commit 0db18d030d8e540e723fe21a14b0b5748c65d0fe Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 22 09:41:52 2016 +0100 OCTPHY: fix 'make dist' (missing header files) http://cgit.osmocom.org/osmo-trx/commit/?id=0048a788ddcbbc0efc6b232c62b8622cdd27c3ba commit 0048a788ddcbbc0efc6b232c62b8622cdd27c3ba Merge: 32d681a 611ef23 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 22 09:33:54 2016 +0100 Merge branch 'laforge/common-main' http://cgit.osmocom.org/osmo-trx/commit/?id=611ef23700619f0e8e3a7c0b87f4568c1c09a6c0 commit 611ef23700619f0e8e3a7c0b87f4568c1c09a6c0 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 12:34:18 2016 +0100 merge bts-specific main function into common/main.c:bts_main() This removes a lot of copy+paste duplication between different BTS models. http://cgit.osmocom.org/osmo-trx/commit/?id=a0192b859ba9230c84381cbf065816760da62ba7 commit a0192b859ba9230c84381cbf065816760da62ba7 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 09:49:09 2016 +0100 Add new bts_model_ctrl_cmds_install() This is one step in making the main() functions of different BTS models more similar, so we can share one code rather than multiple copies of it. http://cgit.osmocom.org/osmo-trx/commit/?id=ec3be11ec60ce1ba49124095c12101f70b5c9eec commit ec3be11ec60ce1ba49124095c12101f70b5c9eec Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 10 20:48:11 2016 +0100 common/support.c: Remove unused file http://cgit.osmocom.org/osmo-trx/commit/?id=69fc57b0286b78a628b330cf62c4b4991add01fd commit 69fc57b0286b78a628b330cf62c4b4991add01fd Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jan 20 13:08:21 2014 +0100 ABIS: Support for multiple RSL connections http://cgit.osmocom.org/osmo-trx/commit/?id=32d681ab985fe6da9f9fd40758e1917fc6f387c0 commit 32d681ab985fe6da9f9fd40758e1917fc6f387c0 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jan 21 16:22:38 2016 +0100 OCTPHY: Don't have files in EXTRA_DIST that don't exist (anymore) This fixes a 'make dist' issue. http://cgit.osmocom.org/osmo-trx/commit/?id=e60b9d1de641acdad88afaa0aa94767d74fc52d3 commit e60b9d1de641acdad88afaa0aa94767d74fc52d3 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 17 21:08:20 2016 +0100 Make T200 default initialization even more robust There's no need to use memcpy(), which adds the risk that the types of source and destination are not the same (see previous commit). Iterating over the array and assigning each element is more robust. http://cgit.osmocom.org/osmo-trx/commit/?id=3d431bb4eb2eec62174719daab6ec9a178299fc9 commit 3d431bb4eb2eec62174719daab6ec9a178299fc9 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 17 21:04:54 2016 +0100 Fix T200 default values t200_ms is an unsigned int [7] array, while the oml_default_t200_ms was an uint8_t[7] array, which we memcpy() to the former as default initializer. Fix this by turning oml_default_t200_ms into unsigned int, too. http://cgit.osmocom.org/osmo-trx/commit/?id=5e8d8a1e75959141d643c84cf061032f9469be0a commit 5e8d8a1e75959141d643c84cf061032f9469be0a Merge: 20e8770 f9de18e Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 16 17:51:16 2016 +0100 Merge branch 'laforge/cleanup' http://cgit.osmocom.org/osmo-trx/commit/?id=f9de18ea15a988afb13e487955811884beecd8c8 commit f9de18ea15a988afb13e487955811884beecd8c8 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:50:22 2016 +0100 TRX: the L1SAP queue contains mac blocks, not bursts (cosmetic) http://cgit.osmocom.org/osmo-trx/commit/?id=97cb71971a345c7e96502d4000afc468bc3dd3b8 commit 97cb71971a345c7e96502d4000afc468bc3dd3b8 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:48:01 2016 +0100 TRX: Don't hard-code 23 bytes, use GSM_MACBLOCK_LEN http://cgit.osmocom.org/osmo-trx/commit/?id=dd562d84bab5974f7b3505500bc9eced52252904 commit dd562d84bab5974f7b3505500bc9eced52252904 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:25:22 2016 +0100 TRX: Don't use magic numbers when we have #defines http://cgit.osmocom.org/osmo-trx/commit/?id=773ab8b2c52d0145561e113e8af7bb839bbe4749 commit 773ab8b2c52d0145561e113e8af7bb839bbe4749 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:19:32 2016 +0100 TRX: replace some more 2715648 magic numbers with GSM_HYPERFRAME http://cgit.osmocom.org/osmo-trx/commit/?id=69ace680dd6edf424389ed1b092faac6a81d900e commit 69ace680dd6edf424389ed1b092faac6a81d900e Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:11:39 2016 +0100 TRX: scheduler: whitespace cleanup http://cgit.osmocom.org/osmo-trx/commit/?id=1bdd08d07d8c544389b0c9df5aea08a0c072582e commit 1bdd08d07d8c544389b0c9df5aea08a0c072582e Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:09:28 2016 +0100 TRX: schedule: remove dead code the check whether or not to send a dummy burst is done already in trx_sched_dl_burst(), so no need to have commented-out code doing that again. http://cgit.osmocom.org/osmo-trx/commit/?id=519a639cf37b6f4cb1c4c9a80a84f7c4dcb4ef4b commit 519a639cf37b6f4cb1c4c9a80a84f7c4dcb4ef4b Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 18:05:13 2016 +0100 TRX: make trx_chan_desc static, it is not used externally http://cgit.osmocom.org/osmo-trx/commit/?id=6323d2e61707ac96d1f4c5c0218c0efe6c203697 commit 6323d2e61707ac96d1f4c5c0218c0efe6c203697 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 17:53:30 2016 +0100 use existing #define for FR/EFR frame length (33/31) http://cgit.osmocom.org/osmo-trx/commit/?id=601781f463d0f5798ac27fd90be63d9f15261683 commit 601781f463d0f5798ac27fd90be63d9f15261683 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 17:56:10 2016 +0100 move 'GSM_FR_BYTES' and related definitiions to common part http://cgit.osmocom.org/osmo-trx/commit/?id=695d8eb27721352e2b9d13f31f28153f57c03a15 commit 695d8eb27721352e2b9d13f31f28153f57c03a15 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 17:50:40 2016 +0100 TRX: Reduce magic numbers, introduce GSM_HYPERFRAME for 2715648 http://cgit.osmocom.org/osmo-trx/commit/?id=5b500f5d8f4e149b41b3fae1ee47d4795a5709bb commit 5b500f5d8f4e149b41b3fae1ee47d4795a5709bb Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 17:38:35 2016 +0100 TRX: use const for dummy and fcch burst definitions http://cgit.osmocom.org/osmo-trx/commit/?id=2bf00d772905942b0baef20c84d2d320f3f647f8 commit 2bf00d772905942b0baef20c84d2d320f3f647f8 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 13:43:50 2016 +0100 TRX: mark scheduler data structures as 'const' Those are read-only tables which should end up in the text segment and not in writable data. http://cgit.osmocom.org/osmo-trx/commit/?id=12992d86dc443a0d03efcb19ee8ab812506df950 commit 12992d86dc443a0d03efcb19ee8ab812506df950 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 13:26:14 2016 +0100 TRX: some comments dscribing the scheduler.[ch] API http://cgit.osmocom.org/osmo-trx/commit/?id=d93bd21185efeaccb215cb4e81a81186b039a8f5 commit d93bd21185efeaccb215cb4e81a81186b039a8f5 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 12:06:33 2016 +0100 sysmoBTS: port 'press Ctrl+C twice for immediate exit' from osmo-bts-trx http://cgit.osmocom.org/osmo-trx/commit/?id=8250800d3bcef5c8e67b822d8e83ddf3233ca3e4 commit 8250800d3bcef5c8e67b822d8e83ddf3233ca3e4 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 10:21:31 2016 +0100 TRX: Add stub bts_model_change_power() function This just fixes linking. It still needs to be properly implemented http://cgit.osmocom.org/osmo-trx/commit/?id=6d101a79a833249c207387d98db3a9eb34a98cc2 commit 6d101a79a833249c207387d98db3a9eb34a98cc2 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 9 09:42:21 2016 +0100 TRX: remove obsolete get_mac() function http://cgit.osmocom.org/osmo-trx/commit/?id=20e8770df08a8584df4ac91f4a8eb86dfe443cd4 commit 20e8770df08a8584df4ac91f4a8eb86dfe443cd4 Merge: e9f12ac 866f9b9 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 16 17:28:25 2016 +0100 Merge branch 'sysmocom/octphy' http://cgit.osmocom.org/osmo-trx/commit/?id=866f9b979d0c8a36e76db8272693d59bfba9c0f5 commit 866f9b979d0c8a36e76db8272693d59bfba9c0f5 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 16 13:11:35 2016 +0100 OCTPHY: Obtain information from PHY and expose it in VTY This adds 'show trx 0 system-information' command to the VTY indicating various version information obtained from the DSP/PHY. http://cgit.osmocom.org/osmo-trx/commit/?id=3e98f942e51ca5f39a09adcb3d0d68d93b1588b0 commit 3e98f942e51ca5f39a09adcb3d0d68d93b1588b0 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 16 10:18:24 2016 +0100 OCTPHY: Implement command re-transmission after message loss We re-use the 'wait_l1_conf' structure for implementing the unacknowledge command window towards the PHY. This means that thre will unconditionally be a 'wait_l1_conf' now, even for requests where the caller didn't provide a call-back. http://cgit.osmocom.org/osmo-trx/commit/?id=7bd2251dcb15552d424b53e0e0e85a4d8150868c commit 7bd2251dcb15552d424b53e0e0e85a4d8150868c Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 15 19:12:04 2016 +0100 OCTPHY: Print NOTICE message if we receive supervisory frame http://cgit.osmocom.org/osmo-trx/commit/?id=0c017618cd335f88712174154575ce9569a4634c commit 0c017618cd335f88712174154575ce9569a4634c Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 15 18:24:03 2016 +0100 OCTPHY: Block PHY indications until it is confirmed open When re-starting OsmoBTS after unclean shutdown, the PHY is already sending notifications (PH-DATA.ind, PH-TIME.ind, etc.) for the previous physical channel / timeslot configuration. At the point those messages are received, OsmoBTS might not even have A-bis OML up yet, and thus has no clue how to process such messages (and subsequently likely crashes). Let's block such primitives from passing further up the code until we have received the TRX-OPEN response. http://cgit.osmocom.org/osmo-trx/commit/?id=8d198f3598f7e0928f7b4001088dfbf007873791 commit 8d198f3598f7e0928f7b4001088dfbf007873791 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 4 20:05:41 2016 +0100 OCTPHY: Fix various memory leaks and add comments on msgb ownership http://cgit.osmocom.org/osmo-trx/commit/?id=bca8d3b8f83af76303fe9923955bea25ef9f7e43 commit bca8d3b8f83af76303fe9923955bea25ef9f7e43 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Nov 13 23:09:24 2015 +0100 OCTPHY: Exit gracefully if config file specifies no phy-netdev http://cgit.osmocom.org/osmo-trx/commit/?id=a9003acb1c4c1a697115d37f7ea28c4650b9681a commit a9003acb1c4c1a697115d37f7ea28c4650b9681a Author: Harald Welte <laforge at gnumonks.org> Date: Fri Nov 13 23:06:23 2015 +0100 OCTPHY: Ensure we write the phy-netdev parameter When writing the config file from the command line, we must not forget to write the phy-netdev parameter, otherwise the program will fail to re-start later :/ http://cgit.osmocom.org/osmo-trx/commit/?id=dad89e50a220c9b634dd04600cfed76f4b4f7622 commit dad89e50a220c9b634dd04600cfed76f4b4f7622 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Nov 5 22:55:02 2015 +0100 OCTPHY: Replace '-lortp' with the proper pkg-config/autofoo version http://cgit.osmocom.org/osmo-trx/commit/?id=b92100ad36f40d3125ff945fbd38aece873d1718 commit b92100ad36f40d3125ff945fbd38aece873d1718 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 6 16:04:32 2015 +0200 Add support for Octasic OCTSDR-2G GSM PHY This adds support for a new PHY to OsmoBTS, the Octasic OCTSDR-2G PHY. This is a proprietary GSM PHY running on a familty of Octasic DSPs. http://cgit.osmocom.org/osmo-trx/commit/?id=e9f12acbeb5a369282719f8e0deecc88034a5488 commit e9f12acbeb5a369282719f8e0deecc88034a5488 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Dec 12 21:15:19 2015 +0100 LAPDm: Use T200 settings from OML rather than libosmocore defaults http://cgit.osmocom.org/osmo-trx/commit/?id=7d6860b114e5d7b6f7a6b9e78e5cd879940c89f3 commit 7d6860b114e5d7b6f7a6b9e78e5cd879940c89f3 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 15 15:21:32 2016 +0100 print a NOTICE message if lchan not activ in get_active_lchan_by_chan_nr() http://cgit.osmocom.org/osmo-trx/commit/?id=056c267b899e264735595a205af4bea6d511f6d7 commit 056c267b899e264735595a205af4bea6d511f6d7 Author: Alexander Huemer <alexander.huemer at xx.vu> Date: Fri Nov 6 20:59:50 2015 +0100 fix some format specifiers http://cgit.osmocom.org/osmo-trx/commit/?id=2b7728cd9d306648328d505c6f4700c6918506fa commit 2b7728cd9d306648328d505c6f4700c6918506fa Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Jan 11 20:47:36 2016 +0100 sysmobts-calib: Warn about firmware and header mismatch sysmobts-calib might be easily patched by a user that does not know that firmware and firmware headers form a contract that should be matched. Compare the version numbers and print a warning if it does not look correct. This should be enough for a user to see that something is not right. Continue anyway as the firmware might still be compatible (because the ABI has not changed). Fixes: SYS#1172 http://cgit.osmocom.org/osmo-trx/commit/?id=65b4a7ba2ba3e804659058e3e5f056698421d77b commit 65b4a7ba2ba3e804659058e3e5f056698421d77b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Jan 11 17:24:57 2016 +0100 sysmobts-v2/eepromreader: Add userspace program to read EEPROM If using a too old kernel on newer devices the eeprom reading will fail and maybe it is not possible to update the kernel after the unit has been deployed. Add a utility to read the EEPROM of revD+ from userspace to be used to fix up the thing. http://cgit.osmocom.org/osmo-trx/commit/?id=74269054a6980068a82c681035177bba742575aa commit 74269054a6980068a82c681035177bba742575aa Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 8 13:26:57 2016 +0100 sysmobts: add missing break statement in l1if_handle_ind() this was introduced in 21b020b33633683d7c785af15c773aab0f79d0de and luckily spotted by coverity (CID 1347446) http://cgit.osmocom.org/osmo-trx/commit/?id=a62e3221b650d576e27efd52f2f51f8786634a71 commit a62e3221b650d576e27efd52f2f51f8786634a71 Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Sun Jun 14 23:52:27 2015 -0400 l1sap: Whitespace fixes. http://cgit.osmocom.org/osmo-trx/commit/?id=085569df55ceb3737b79f53b015b0c064698ddc6 commit 085569df55ceb3737b79f53b015b0c064698ddc6 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 4 20:29:24 2016 +0100 fix large amount of compiler warnings in common and sysmobts code http://cgit.osmocom.org/osmo-trx/commit/?id=21b020b33633683d7c785af15c773aab0f79d0de commit 21b020b33633683d7c785af15c773aab0f79d0de Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jan 4 20:06:12 2016 +0100 sysmobts: Clarify msgb ownership / fix memory leaks http://cgit.osmocom.org/osmo-trx/commit/?id=e28a20a2d9d049cd6312e218a7646593bbc43431 commit e28a20a2d9d049cd6312e218a7646593bbc43431 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Dec 7 11:16:00 2015 +0100 sysmobts: Catch up with the API changes and specify the version API revision 5.1 allows us to pass a version number for the rx/tx calibration and the DSP/FPGA will inform us about clock errors. http://cgit.osmocom.org/osmo-trx/commit/?id=2da932c7a0cc365fb0c071ee0caf68c4d30f8c41 commit 2da932c7a0cc365fb0c071ee0caf68c4d30f8c41 Author: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Date: Fri Sep 18 08:40:29 2015 -0400 sysmobts: support eeprom map version 2 [hfreyther: Accept the mixing of whitespace to ease future merges] http://cgit.osmocom.org/osmo-trx/commit/?id=2ecbf871301cdc36c0212dd7526fc94ffa4597d1 commit 2ecbf871301cdc36c0212dd7526fc94ffa4597d1 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Dec 6 21:31:39 2015 +0100 use talloc pool for msgb and ortp library by using a talloc pool, we avoid having to go back to the libc malloc pool all the time. The msgb allocations and libortp allocations happen quite frequently during processing and show up as one of the high priority items in osmo-bts profiles on sysmoBTS with 14 concurrent TCH/H calls (highest load scenario). talloc still consumes significant CPU, this is mostly due to the zero-initialization of all the associated buffers. Strictly speaking we shouldn't need this, but any change there would require lots of testing, as there might be hidden assumptions in the code? In some percentage of cases, talloc still seems to fall back on malloc for msgb allocations, which is currently a bit of a mystery. The pools certainly are large enough, talloc_reprt() rarely reports more than a few tens of kilobytes used by the msgb pool. http://cgit.osmocom.org/osmo-trx/commit/?id=62d7502b82cbe56211bcd4aa3a363757650fced3 commit 62d7502b82cbe56211bcd4aa3a363757650fced3 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Dec 5 15:57:09 2015 +0100 osmo-bts-sysmo: Disable DSP trace flags by default http://cgit.osmocom.org/osmo-trx/commit/?id=2d5481da278f8b09c4772d54f044ba2b26eeef14 commit 2d5481da278f8b09c4772d54f044ba2b26eeef14 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Dec 5 11:54:08 2015 +0100 l1sap: Ensure we only pass PHY primitives of active lchans In some situations, a PHY might send us a primitive for a logical channel that is not (or no longer) active. Passing such primitives higher up the stack is asking for trouble. Specifically, LAPDm instances cannot accept messages once their instance has been released. We introduce two new helper functions: get_lchan_by_chan_nr() as well as get_active_lchan_by_chan_nr(). The former just centralizes the look-up of the lchan by timeslot number and sub-slot number. The latter also checks to ensure the lchan is active, which is used for PH-DATA / PH-RTS primitives. To the contrary, MPH primitives generally don't require the cahnnel to be active for processing. http://cgit.osmocom.org/osmo-trx/commit/?id=44bc9408b1dcc4d07f8aff9800d8fcf317954231 commit 44bc9408b1dcc4d07f8aff9800d8fcf317954231 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Dec 3 19:54:38 2015 +0100 common/rsl.c: The presence of a valied measurement result is DEBUG we shouldn't consider the presence of a valid measurement result as something NOTICEable http://cgit.osmocom.org/osmo-trx/commit/?id=02337e1d1d5a97c0c062c4d2cdc13bff7c17bae7 commit 02337e1d1d5a97c0c062c4d2cdc13bff7c17bae7 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Nov 20 21:35:07 2015 +0100 sysmobts: Dont recycle PHY primitive for L1SAP in PH-DATA.ind http://cgit.osmocom.org/osmo-trx/commit/?id=437deb5f3a9dcfcb0c40ac8b44c20a5987907990 commit 437deb5f3a9dcfcb0c40ac8b44c20a5987907990 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Nov 20 18:05:51 2015 +0100 sysmobts: fix ph_data_req() msgb handling + alignment The way we recycle the msgb with a l1sap header when transforming a PH-DATA.req L1SAP primitive into a PHY/L1 primitive was flawed in several ways: 1) the way the L1SAP header was stored in the buffer didn't provide sufficient tailroom for the L1 primitive 2) the alignment of the data in L1SAP is at a 32bit bounadry, but not in the L1 primitive, causing unaligned accesses. http://cgit.osmocom.org/osmo-trx/commit/?id=48e99fd05a906bcf9536996733123fdb512b635e commit 48e99fd05a906bcf9536996733123fdb512b635e Author: Harald Welte <laforge at gnumonks.org> Date: Fri Nov 20 10:54:09 2015 +0100 cope with 'struct gsm_bts' without a tsc member This was introduced in openbsc.git a2bbc5ec0e6481bb5b65da7bdbde03a424437af4 http://cgit.osmocom.org/osmo-trx/commit/?id=3c161bb7df7bf95e5a69db97fe3baa6380c3c9ed commit 3c161bb7df7bf95e5a69db97fe3baa6380c3c9ed Author: Harald Welte <laforge at gnumonks.org> Date: Thu Nov 5 23:05:05 2015 +0100 tests/Makefile.am: Don't use sysmobts SUBDIRS twice probably a git merge artefact of some sort... http://cgit.osmocom.org/osmo-trx/commit/?id=bbcf703be844e971d9e1e58f5efedfe5c449309c commit bbcf703be844e971d9e1e58f5efedfe5c449309c Author: Harald Welte <laforge at gnumonks.org> Date: Thu Nov 5 23:02:55 2015 +0100 TRX: catch up with trhe amr_mode naming changes OpenBSC introduced a naming change in 615ed46a6ab25f71a7ab0d8201d33b4dbf8fc5b0 but osmo-bts fixes were only about osmo-bts-sysmo, not osmo-bts-trx. This updates osmo-bts-trx accordingly. http://cgit.osmocom.org/osmo-trx/commit/?id=94da045be57ed0023c5718a871a50c71474ee345 commit 94da045be57ed0023c5718a871a50c71474ee345 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Nov 5 22:49:19 2015 +0100 Don't blindly link against '-lortp' but use pkg-config for that This also ensures that a missing ortp library dependency is discovered at configure time already http://cgit.osmocom.org/osmo-trx/commit/?id=33f234f2782381235cb3443fc6949436d3070395 commit 33f234f2782381235cb3443fc6949436d3070395 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Nov 5 22:48:24 2015 +0100 Revert "configure.ac: Add subdir-objects to suppress warnings" This reverts commit 94a05abb98fcb1a5002f327888635f3af860c9a9. The tests don't work well with subdir-objects, so we have to live with the warnings meanwhile until somebody finds time to find the magic spell to solve the autotools quest. http://cgit.osmocom.org/osmo-trx/commit/?id=55d89d17b25979d81b3d56778503eebb18c0eee2 commit 55d89d17b25979d81b3d56778503eebb18c0eee2 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 12 12:15:49 2015 +0200 configure.ac: Better description for --enable-sysmocom-bts and --enable-trx http://cgit.osmocom.org/osmo-trx/commit/?id=94a05abb98fcb1a5002f327888635f3af860c9a9 commit 94a05abb98fcb1a5002f327888635f3af860c9a9 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 12 12:13:13 2015 +0200 configure.ac: Add subdir-objects to suppress warnings automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. http://cgit.osmocom.org/osmo-trx/commit/?id=45e597cc160f348a4ff12ff840f3d879c682e1cb commit 45e597cc160f348a4ff12ff840f3d879c682e1cb Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 12 12:11:53 2015 +0200 configure.ac: Depend on libosmotrau 0.3.2 (ortp statistics) http://cgit.osmocom.org/osmo-trx/commit/?id=9a9ddc12033c3b63af7e2abe5d9267cfcd451a58 commit 9a9ddc12033c3b63af7e2abe5d9267cfcd451a58 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 12 12:09:54 2015 +0200 configure.ac: Only require libgps if building for sysmoBTS http://cgit.osmocom.org/osmo-trx/commit/?id=13947b3408fda0af5b1041e8eeb0328f5a45eb2c commit 13947b3408fda0af5b1041e8eeb0328f5a45eb2c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Oct 3 22:45:52 2015 +0200 amr: Catch-up for the non-RTP mode after amr rename http://cgit.osmocom.org/osmo-trx/commit/?id=1009a87f3c0f8527290957aaf2ccc6f1a2cce531 commit 1009a87f3c0f8527290957aaf2ccc6f1a2cce531 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Oct 3 22:34:37 2015 +0200 amr: Catch up with the amr_mode changes Use the bts_modes for all the types. As there are two instances know. One for the ms and one for the bts. Manual compile fix and not tested on HW http://cgit.osmocom.org/osmo-trx/commit/?id=f1fb0fa3af174c605f60458388bba61ef4f40fa8 commit f1fb0fa3af174c605f60458388bba61ef4f40fa8 Merge: 329085a caa648d Author: Harald Welte <laforge at gnumonks.org> Date: Tue Sep 22 16:41:54 2015 +0200 Merge branch '201509-trx-rebase' http://cgit.osmocom.org/osmo-trx/commit/?id=caa648d92e48a05e676e87b48c21cb0b151c9b4e commit caa648d92e48a05e676e87b48c21cb0b151c9b4e Author: Harald Welte <laforge at gnumonks.org> Date: Sat Sep 12 11:00:23 2015 +0200 TRX: Add missing call to abis_init() This somehow got lost during the latest rebase. http://cgit.osmocom.org/osmo-trx/commit/?id=88a31e2a990dfbacfc9d6b7cbfd03edc99e68687 commit 88a31e2a990dfbacfc9d6b7cbfd03edc99e68687 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 6 14:12:17 2015 +0200 make osmo-bts-trx provide bts_model_adjst_ms_pwr() http://cgit.osmocom.org/osmo-trx/commit/?id=307bfc81c1d4eb782339946c0dbccab6095aa10f commit 307bfc81c1d4eb782339946c0dbccab6095aa10f Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 6 14:11:31 2015 +0200 fixup tests after bts_model_adjst_ms_pwr http://cgit.osmocom.org/osmo-trx/commit/?id=5becc4613a34c5fce7c261268cef679821387e4a commit 5becc4613a34c5fce7c261268cef679821387e4a Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Mon Jul 20 20:04:02 2015 -0400 tests: Update busrsts_test build. We've added logging calls to the bursts processing. Add logging facility initializatoin to the test code. http://cgit.osmocom.org/osmo-trx/commit/?id=b812839dfab3208928b6b8f45368abcb6b9ff96a commit b812839dfab3208928b6b8f45368abcb6b9ff96a Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Mon Jun 15 00:40:27 2015 -0400 trx: fix potential use of uninitialized toa variable. Not really a bug, as we're smart about it down the stream, but it's better to be strict here as well. http://cgit.osmocom.org/osmo-trx/commit/?id=ae525a8761d9651e2824fd7c84f0c7db8aaa37fd commit ae525a8761d9651e2824fd7c84f0c7db8aaa37fd Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Mon Jun 15 00:33:37 2015 -0400 trx: Send POWERON/OFF commands to osmo-bts only for the first channel. osmo-trx never supported separate power control for trx's, but now it started to be more strict about it. http://cgit.osmocom.org/osmo-trx/commit/?id=29ea40f5387c18a0aeb906039750bbf3a9828e7e commit 29ea40f5387c18a0aeb906039750bbf3a9828e7e Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Wed Jun 10 00:27:18 2015 -0400 trx: Assume 100% BER if total decoded bits is 0 in l1if_process_meas_res() http://cgit.osmocom.org/osmo-trx/commit/?id=e9abc5a4f33d8432d81ab896189b7492b07a05cf commit e9abc5a4f33d8432d81ab896189b7492b07a05cf Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Wed Jun 10 00:26:14 2015 -0400 trx: Cleanup unused parts of loops.c http://cgit.osmocom.org/osmo-trx/commit/?id=17be7fa73bd3ea0e25bafbbd88b79f4f5a0762e9 commit 17be7fa73bd3ea0e25bafbbd88b79f4f5a0762e9 Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Fri Jun 5 01:12:21 2015 -0400 trx: Remove unused variables. http://cgit.osmocom.org/osmo-trx/commit/?id=68e8b2b1d5ea6e6236c277641cf565e7f99d7527 commit 68e8b2b1d5ea6e6236c277641cf565e7f99d7527 Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Fri Jun 5 00:54:03 2015 -0400 trx: Fix typo in a log message. http://cgit.osmocom.org/osmo-trx/commit/?id=391ff14977d4e031562b6840d1ac0bf45ed4cfef commit 391ff14977d4e031562b6840d1ac0bf45ed4cfef Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Thu Apr 9 13:24:15 2015 +0300 trx: More logging for voice frame decoding functions. http://cgit.osmocom.org/osmo-trx/commit/?id=cf18dcd5fdf42330e868e9de8effedbbeb5df223 commit cf18dcd5fdf42330e868e9de8effedbbeb5df223 Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Tue Apr 7 21:17:01 2015 +0300 tests: Update bursts_test to accommodate BER calculations. http://cgit.osmocom.org/osmo-trx/commit/?id=6fceaca584aa84214ccf747257344f1fe95caeee commit 6fceaca584aa84214ccf747257344f1fe95caeee Author: Alexander Chemeris <Alexander.Chemeris at gmail.com> Date: Mon Apr 6 00:12:02 2015 +0300 trx: Implement BER calculations. A known issue with this code is that BER is not updated for lost TCH frames, because osmo-trx doesn't send any indication for them and we don't have a callback to handle this. Otherwise the code seem to work fine. http://cgit.osmocom.org/osmo-trx/commit/?id=ddc0bf14d5d5c8b3248eab0463399ae0a5bb8e3f commit ddc0bf14d5d5c8b3248eab0463399ae0a5bb8e3f Author: Thomas Tsou <tom at tsou.cc> Date: Thu May 8 13:41:17 2014 -0400 TRX: Remove extra TCH/HS puncturing value 3GPP TS 05.03 "Channel coding" specifies the puncturing matrix (1,0,1) for class 1 information bits and tail bits valued u(0) to u(103) for a maximum puncturing index of 311. The puncturing index 313 exceeds the maximum index and causes osmo_conv_get_output_length() to output the improper length of 210 instead of 211. Signed-off-by: Thomas Tsou <tom at tsou.cc> http://cgit.osmocom.org/osmo-trx/commit/?id=deb01a26528a0f61ae0e20a3b793db560d4c81dc commit deb01a26528a0f61ae0e20a3b793db560d4c81dc Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Apr 6 14:39:23 2014 +0200 TRX: Check if Transceiver indicates an out of range clock If frame number is out of range (>= 2715648), the scheduler's process would end up in an infinite loop. This is because the loop would schedule bursts until the indicated frame number is reached, which would not be possible. The openbts, calypso-bts and osmo-trx might send out out of range clock indications every 3.5 hour. http://cgit.osmocom.org/osmo-trx/commit/?id=3cfc9d5fa34bf144c7390c9b6d9ce867b4e5c2e4 commit 3cfc9d5fa34bf144c7390c9b6d9ce867b4e5c2e4 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jan 20 13:04:13 2014 +0100 TRX: Show which TRX does not respond or rejects a command http://cgit.osmocom.org/osmo-trx/commit/?id=a7d0c5ef5af04bb698d05785f0c9b1f20e687bca commit a7d0c5ef5af04bb698d05785f0c9b1f20e687bca Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Jan 14 12:10:44 2014 +0100 trx: Set lchan inactive, only if the dedicated channel is deactivated http://cgit.osmocom.org/osmo-trx/commit/?id=f39c739bd6ae73596b3a72e2b240f012b669e5a7 commit f39c739bd6ae73596b3a72e2b240f012b669e5a7 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jan 13 14:52:05 2014 +0100 TRX: Activate LCHAN of CCCH when CCCH is configured on time slot http://cgit.osmocom.org/osmo-trx/commit/?id=f66f5b3ddc5c894ae7ad4909cbd261c6920260b0 commit f66f5b3ddc5c894ae7ad4909cbd261c6920260b0 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Sep 9 16:17:37 2013 +0200 TRX: Free bust buffer memory to when changing lchan type http://cgit.osmocom.org/osmo-trx/commit/?id=c241afa87c2fa8713a1fae89e6b599e011d45c28 commit c241afa87c2fa8713a1fae89e6b599e011d45c28 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Aug 29 16:00:31 2013 +0200 TRX: Add VTY option to allow setting RTS advance in frames RTS (ready-to-send) must be issued in advance, so BTS core and especially osmo-pcu can provide downlink data frames early enough. In some cases PCU might provide frames too late, so they must be dropped. If PCU provides frames too late, due to high system load, this "RTS advance" setting must be increased. http://cgit.osmocom.org/osmo-trx/commit/?id=178d618d5a7728c876ae66777351aea37f88cc5d commit 178d618d5a7728c876ae66777351aea37f88cc5d Author: Martin Hauke <mardnh at gmx.de> Date: Fri Aug 23 23:10:16 2013 +0200 TRX: fix some typos in comments http://cgit.osmocom.org/osmo-trx/commit/?id=c9ddb2ba22f4b57cd6e86771cd292564d5e4fb7f commit c9ddb2ba22f4b57cd6e86771cd292564d5e4fb7f Author: Martin Hauke <mardnh at gmx.de> Date: Fri Aug 23 23:08:23 2013 +0200 build: Use AM_CPPFLAGS in Makefile.am Since automake 1.13 INCLUDES is depricated and causes a warning Inspired from similar patches by Alexander Huemer for other osmocom projects. http://cgit.osmocom.org/osmo-trx/commit/?id=73d3f469945f7956717c05954e8e66b1796b86a3 commit 73d3f469945f7956717c05954e8e66b1796b86a3 Author: Martin Hauke <mardnh at gmx.de> Date: Fri Aug 23 23:05:47 2013 +0200 tests: make tests for sysmobts conditional http://cgit.osmocom.org/osmo-trx/commit/?id=b2482a8574a3a7ce4e628237f411ea0a4cd25f1b commit b2482a8574a3a7ce4e628237f411ea0a4cd25f1b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Aug 23 21:58:29 2013 +0200 Allow TRX 0..254 at VTY, even if less TRX are available Instead of limiting the number of TRX at VTY to the actual number of supported TRX, VTY allows to configure any possible number of TRX. If a TRX is configured, which is not supported by BTS model, an error message is returned, which states that the given TRX is not supported. http://cgit.osmocom.org/osmo-trx/commit/?id=812fdd92c70679f4d5a46f9078a74e2a94cd74e4 commit 812fdd92c70679f4d5a46f9078a74e2a94cd74e4 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Aug 12 09:31:27 2013 +0200 TRX: Changed logging of unserved primitives from LOGL_NOTICE to LOGL_INFO http://cgit.osmocom.org/osmo-trx/commit/?id=ec6225e3e067221a3e2c19f6eda03453a2fe60e7 commit ec6225e3e067221a3e2c19f6eda03453a2fe60e7 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Aug 12 09:29:40 2013 +0200 TRX: Fixed chan_nr for SACCH/8(7) at scheduler http://cgit.osmocom.org/osmo-trx/commit/?id=ef6eb5442c865a42615d8dab4fc5c99decf4b4a8 commit ef6eb5442c865a42615d8dab4fc5c99decf4b4a8 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 8 18:44:44 2013 +0200 trx: Add option to set transmit power reduction via OML (BSC) http://cgit.osmocom.org/osmo-trx/commit/?id=f0072a8de82b48bb8927994a07efec7218f91640 commit f0072a8de82b48bb8927994a07efec7218f91640 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 8 18:42:48 2013 +0200 TRX: Do not send burst on IDLE channels at TRX != C0 This is required, so the transceiver transmits no power. http://cgit.osmocom.org/osmo-trx/commit/?id=3cf28aa9240a43dcd4745bc82e27d1802cf63245 commit 3cf28aa9240a43dcd4745bc82e27d1802cf63245 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 8 18:40:31 2013 +0200 TRX: Close TRX (shutdown all active channels) on ABIS link failure http://cgit.osmocom.org/osmo-trx/commit/?id=578340c7a7af149dec0b33fde2db03b672e221b4 commit 578340c7a7af149dec0b33fde2db03b672e221b4 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Jul 2 11:05:04 2013 +0200 TRX: Add bts_model_trx_close to TRX implementation http://cgit.osmocom.org/osmo-trx/commit/?id=3caf3b7c45258278b4aeebd992e801d42b10759d commit 3caf3b7c45258278b4aeebd992e801d42b10759d Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Jul 2 11:04:11 2013 +0200 TRX: Fixup ciphering state names after rebasing http://cgit.osmocom.org/osmo-trx/commit/?id=ee479133891317be37b7fc850e6cb945ef0c9f38 commit ee479133891317be37b7fc850e6cb945ef0c9f38 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sat Jun 29 21:42:58 2013 +0200 TRX: No need to set mode and cipher for PDCH http://cgit.osmocom.org/osmo-trx/commit/?id=f5aaf523c58dd7bc2f57f840b717da359d08bb5c commit f5aaf523c58dd7bc2f57f840b717da359d08bb5c Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jun 20 20:10:46 2013 +0200 TRX: If no cipher algorithm is given, or if it is a5/0, reset cipher state http://cgit.osmocom.org/osmo-trx/commit/?id=8c8998e55156629679dbe1ca42684bc451d06262 commit 8c8998e55156629679dbe1ca42684bc451d06262 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Jun 19 15:20:12 2013 +0200 TRX: Set ciphering to an initial state when activating channel Handover and assignment may activate channels with ciphering already set, so we need to tell scheduler to enable/disable ciphering and set the correct cipher state. http://cgit.osmocom.org/osmo-trx/commit/?id=da0c44a9db88b866056f19f13364e1362c92773a commit da0c44a9db88b866056f19f13364e1362c92773a Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jun 17 08:23:04 2013 +0200 Add test case for successful handover and unsuccessful handover http://cgit.osmocom.org/osmo-trx/commit/?id=798c1bba9d48896dc6baa4340e252cda27cb30d2 commit 798c1bba9d48896dc6baa4340e252cda27cb30d2 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jun 16 15:25:37 2013 +0200 TRX: Process real time scheduling option is now similar to sysmobts http://cgit.osmocom.org/osmo-trx/commit/?id=db0b93ac3967f12b519ca4e2528e30aacd59ce72 commit db0b93ac3967f12b519ca4e2528e30aacd59ce72 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Jun 12 16:53:55 2013 +0200 TRX: Disable handover burst detection when closing channel during detection http://cgit.osmocom.org/osmo-trx/commit/?id=86c936cbb104cbac0994895bef03d8808ba032d4 commit 86c936cbb104cbac0994895bef03d8808ba032d4 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Jun 12 12:36:48 2013 +0200 TRX: Use correct slot type for GSM_PHCAN_BCCH http://cgit.osmocom.org/osmo-trx/commit/?id=b9a917a13880f9d6274409b9d3c9b56de484125f commit b9a917a13880f9d6274409b9d3c9b56de484125f Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Jun 12 09:12:04 2013 +0200 TRX: Handover access burst support http://cgit.osmocom.org/osmo-trx/commit/?id=6527dffc94686672add10fe6b66f898c436ea34c commit 6527dffc94686672add10fe6b66f898c436ea34c Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Jun 12 09:08:44 2013 +0200 TRX: Clear lchan state when resetting TRX http://cgit.osmocom.org/osmo-trx/commit/?id=fb04746bce94a5cdd3e95500c59ad019e552f9c0 commit fb04746bce94a5cdd3e95500c59ad019e552f9c0 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jun 6 13:24:40 2013 +0200 TRX: Report measurements http://cgit.osmocom.org/osmo-trx/commit/?id=05597a7ddbf9e838caaeb36980cefaa728ab8eec commit 05597a7ddbf9e838caaeb36980cefaa728ab8eec Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Apr 9 10:55:37 2013 +0200 TRX: Fixed typos tranceiver -> transceiver http://cgit.osmocom.org/osmo-trx/commit/?id=82676c13ee9ab2b73f089acf811239f8e37fa0fd commit 82676c13ee9ab2b73f089acf811239f8e37fa0fd Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Apr 9 10:44:58 2013 +0200 TRX: Fix: Cleanly free TRX instances during initialization in case of an error http://cgit.osmocom.org/osmo-trx/commit/?id=c2ee307fd42975b63317e9d4944e5822286cc69b commit c2ee307fd42975b63317e9d4944e5822286cc69b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Apr 7 13:11:50 2013 +0200 Allow one or more TRX to configure via VTY http://cgit.osmocom.org/osmo-trx/commit/?id=2e4a26a0e942e227a96819271ea0ea2b03566928 commit 2e4a26a0e942e227a96819271ea0ea2b03566928 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Apr 7 12:49:52 2013 +0200 TRX: Add VTY options to enable and disable SETTSC and SETBSIC http://cgit.osmocom.org/osmo-trx/commit/?id=6508f2113042d1fbd1cb6d7154c7701422f6b7c9 commit 6508f2113042d1fbd1cb6d7154c7701422f6b7c9 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sat Apr 6 12:26:03 2013 +0200 TRX: Reset ciphering state when closing channel http://cgit.osmocom.org/osmo-trx/commit/?id=c5241c3aa42d7ff89a369f2a816a98bdca932217 commit c5241c3aa42d7ff89a369f2a816a98bdca932217 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Mar 31 12:19:26 2013 +0200 TRX: Support for AMR half speech http://cgit.osmocom.org/osmo-trx/commit/?id=c910a332b261d48fa594f1a3133987c8f650dcb1 commit c910a332b261d48fa594f1a3133987c8f650dcb1 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Mar 31 12:17:02 2013 +0200 TRX: Support for TCH/H and GSM half rate transcoding http://cgit.osmocom.org/osmo-trx/commit/?id=f62a64e440a1cb8a654e3f49b8f4202022e0348a commit f62a64e440a1cb8a654e3f49b8f4202022e0348a Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Mar 26 09:19:53 2013 +0100 TRX: Add AMR Payload handling http://cgit.osmocom.org/osmo-trx/commit/?id=a7f5e077121f857e373b6e68c5fdf803933a12dc commit a7f5e077121f857e373b6e68c5fdf803933a12dc Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Mar 26 09:05:14 2013 +0100 TRX: Support for AMR full speech http://cgit.osmocom.org/osmo-trx/commit/?id=5e2341411f25f4faa66ff9b4506e77d897b97daf commit 5e2341411f25f4faa66ff9b4506e77d897b97daf Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sat Mar 16 16:46:13 2013 +0100 Get RSSI from received uplink data and send to PCU http://cgit.osmocom.org/osmo-trx/commit/?id=917cf7018b6a9ec778add719fcec1692f0e35931 commit 917cf7018b6a9ec778add719fcec1692f0e35931 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Mar 14 07:57:07 2013 +0100 TRX: Add support for EFR transcoding http://cgit.osmocom.org/osmo-trx/commit/?id=84b9a445351937703334629f3fec02689153f986 commit 84b9a445351937703334629f3fec02689153f986 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Mar 14 07:56:05 2013 +0100 TRX: Code cleanup, prepare for other codecs than GSM full rate http://cgit.osmocom.org/osmo-trx/commit/?id=7ff22823ca8e2dd1e990578a2dbf6942b1911eed commit 7ff22823ca8e2dd1e990578a2dbf6942b1911eed Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Mar 10 11:44:17 2013 +0100 TRX: Use link timeout value from BSC via OML attribute. http://cgit.osmocom.org/osmo-trx/commit/?id=9855e8bd4854f6afb740ad940f2999be354b0af1 commit 9855e8bd4854f6afb740ad940f2999be354b0af1 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Mar 1 10:05:59 2013 +0100 TRX: Out of range primitives found in downlink queue are not an error http://cgit.osmocom.org/osmo-trx/commit/?id=219ece83a3ffe7fa2bd58943cddb47a3eacc2fab commit 219ece83a3ffe7fa2bd58943cddb47a3eacc2fab Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Feb 24 11:09:19 2013 +0100 TRX: Implementation of MS power and timing advance loops http://cgit.osmocom.org/osmo-trx/commit/?id=889890da4312916bd617b3c95326a89237078a3b commit 889890da4312916bd617b3c95326a89237078a3b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Feb 22 07:52:51 2013 +0100 TRX: Improved handling of clock indications. If no clock is received, a POWEROFF is sent until clock is detected. http://cgit.osmocom.org/osmo-trx/commit/?id=23a5183767d96a723190634f4a26d018492880bf commit 23a5183767d96a723190634f4a26d018492880bf Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 21 15:41:41 2013 +0100 TRX: Fixes to TRX interface Ignore false response to uncritical commands. http://cgit.osmocom.org/osmo-trx/commit/?id=ce0f20b597343f472c6df44c1adf596a388f9728 commit ce0f20b597343f472c6df44c1adf596a388f9728 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 21 15:39:59 2013 +0100 TRX: Fix of SCH burst data http://cgit.osmocom.org/osmo-trx/commit/?id=7bd6e8b89bbb38b292caa0df3c52902c46911c1a commit 7bd6e8b89bbb38b292caa0df3c52902c46911c1a Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 21 09:27:52 2013 +0100 TRX: Ciphering http://cgit.osmocom.org/osmo-trx/commit/?id=d692b6e054b25474615401dcaf33209c03923e9d commit d692b6e054b25474615401dcaf33209c03923e9d Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sat Feb 16 14:28:25 2013 +0100 TRX: Replaced GSM 06.10 ordering table by table in libosmocodec http://cgit.osmocom.org/osmo-trx/commit/?id=89e36c0e646a9e73728ee65cc6ac32f01d388885 commit 89e36c0e646a9e73728ee65cc6ac32f01d388885 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Feb 24 10:12:09 2013 +0100 TRX: Cleanup of channel transcoding http://cgit.osmocom.org/osmo-trx/commit/?id=801c182c02a38c9e3fb89c431caabc4c5abddf6f commit 801c182c02a38c9e3fb89c431caabc4c5abddf6f Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Feb 15 16:20:19 2013 +0100 TRX: By default, send 20 frames in advance to tranceiver http://cgit.osmocom.org/osmo-trx/commit/?id=7451ce29a79a8da6da0ac1dbf155ed4af016dcdc commit 7451ce29a79a8da6da0ac1dbf155ed4af016dcdc Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Feb 15 16:17:43 2013 +0100 TRX: Detect missing received bursts and fill them with zero-sbits http://cgit.osmocom.org/osmo-trx/commit/?id=450d32919ada7b037b41d89ea8dd181924ed48e9 commit 450d32919ada7b037b41d89ea8dd181924ed48e9 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Feb 15 13:31:10 2013 +0100 TRX: Add test code for PDTCH transcoding http://cgit.osmocom.org/osmo-trx/commit/?id=78b2080027d398c7242ae6e180b462e32f57a786 commit 78b2080027d398c7242ae6e180b462e32f57a786 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Feb 15 13:29:29 2013 +0100 TRX: PDTCH (GPRS) works now Detection and transcoding of all four coding schemes are supported. http://cgit.osmocom.org/osmo-trx/commit/?id=9de67ca9621deea3283b9f9c2bab99287a110e45 commit 9de67ca9621deea3283b9f9c2bab99287a110e45 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Feb 15 07:51:01 2013 +0100 TRX: Lost TCH frame detection of omitted bursts from tranceiver http://cgit.osmocom.org/osmo-trx/commit/?id=b9880bc81289fa13b12801abcfc77fe6e83b8a94 commit b9880bc81289fa13b12801abcfc77fe6e83b8a94 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 14 12:22:42 2013 +0100 TRX: Allow transcoding of TCH FR with MSB first (RTP) or LSB first (E1) http://cgit.osmocom.org/osmo-trx/commit/?id=d10eaee4cce04aee4907b87e5bd73b9d866061b7 commit d10eaee4cce04aee4907b87e5bd73b9d866061b7 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 14 11:21:13 2013 +0100 TRX: Completed TCH/F full rate support Full rate is now tested and working. http://cgit.osmocom.org/osmo-trx/commit/?id=b104aed5ec01fe27c0c2e0ddd988ba11608cb0bd commit b104aed5ec01fe27c0c2e0ddd988ba11608cb0bd Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Feb 11 21:42:35 2013 +0100 TRX: Fixed swapped stealing bits Thanx to Sylvain for pointing to this bug. http://cgit.osmocom.org/osmo-trx/commit/?id=cd463dd72acbe2286dc33fa266ec081d75b57751 commit cd463dd72acbe2286dc33fa266ec081d75b57751 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Feb 11 12:52:56 2013 +0100 TRX: Minor fixes, especially handle TOA of RACH correctly http://cgit.osmocom.org/osmo-trx/commit/?id=7d684d6866e711f96a9bac37225dbe537b514401 commit 7d684d6866e711f96a9bac37225dbe537b514401 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 7 16:58:00 2013 +0100 TRX: Fix, never send confirm for DEACT SACCH request (TS 05.08 4.6) Sending it would cause BSC to change to a state, where it does not release rf channel. http://cgit.osmocom.org/osmo-trx/commit/?id=e0959e7929cf9c8659919f2849c54360eda95032 commit e0959e7929cf9c8659919f2849c54360eda95032 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 7 14:09:06 2013 +0100 TRX: Use received TRX clocks to determine availablility of tranceiver Only if transceiver becomes available, control commands are sent. If tranceiver is gone, reset scheduler. The current availability state is sent to BSC via OML state change commands. http://cgit.osmocom.org/osmo-trx/commit/?id=2ea68e2b7be7af78fb87c42e39133a812b709d48 commit 2ea68e2b7be7af78fb87c42e39133a812b709d48 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 7 13:16:28 2013 +0100 TRX: Fixes and improvements of scheduler http://cgit.osmocom.org/osmo-trx/commit/?id=2c8787224ff4698e8bf04620441919262887c7ee commit 2c8787224ff4698e8bf04620441919262887c7ee Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 7 13:09:34 2013 +0100 Fix: Check right result on bursts_test http://cgit.osmocom.org/osmo-trx/commit/?id=74d63b72126bfe7a2a6ac641be4ac789a39eea6d commit 74d63b72126bfe7a2a6ac641be4ac789a39eea6d Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Feb 6 11:37:59 2013 +0100 Add test routing to test transcoding of TCH FR / FACCH frames http://cgit.osmocom.org/osmo-trx/commit/?id=d0603d96e9f6a69df8d2e37380b19eceb2f89d50 commit d0603d96e9f6a69df8d2e37380b19eceb2f89d50 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Wed Feb 6 11:35:06 2013 +0100 TRX: Completed transcoding of TCH with reordering Table 2 of TS 05.03 http://cgit.osmocom.org/osmo-trx/commit/?id=414faaca19812016d5fb756838988f341c23ba51 commit 414faaca19812016d5fb756838988f341c23ba51 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 16:53:04 2013 +0100 TRX: Power down tranceiver and reset scheduler, if abis link is lost If BTS is gone, TRX is powered down, due to loss of abis link. If link is esablished again, tranceiver and scheduler are provisioned again by BTS. http://cgit.osmocom.org/osmo-trx/commit/?id=7a0d11dd68528d96afff61083c3cf90a50af11bb commit 7a0d11dd68528d96afff61083c3cf90a50af11bb Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 16:47:57 2013 +0100 ABIS: Introduce bts_model_abis_close to indicate ABIS link failure. sysmocom-bts model shuts down on link loss, but other models may not want this, so shutdown is moved tor bts_model_abis_close of osmo-bts-sysmo. http://cgit.osmocom.org/osmo-trx/commit/?id=cd0581d815f76dd159406a2e797ad554df82c761 commit cd0581d815f76dd159406a2e797ad554df82c761 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 13:46:03 2013 +0100 TRX: On negative response of critical commands, shutdown BTS http://cgit.osmocom.org/osmo-trx/commit/?id=1de7085d3181b8d29929e80f29448e2c7d6eda3b commit 1de7085d3181b8d29929e80f29448e2c7d6eda3b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 11:52:38 2013 +0100 Add test code for testing GSM burst transcoding http://cgit.osmocom.org/osmo-trx/commit/?id=acc71ffb4b61b3354bbb2fa14981e4e6a46946e6 commit acc71ffb4b61b3354bbb2fa14981e4e6a46946e6 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 11:45:28 2013 +0100 TRX: Introduce osmobts-trx, a layer 1 implementation for OpenBTS tranceivers The code is quite complete, TCH and PDCH channels are not yet tested. http://cgit.osmocom.org/osmo-trx/commit/?id=c64fa4f88818a63bada0e34d179fd04319de47e1 commit c64fa4f88818a63bada0e34d179fd04319de47e1 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Mar 26 07:52:41 2013 +0100 Change to new structure of multirate at gsm_data_shared.h http://cgit.osmocom.org/osmo-trx/commit/?id=79bc80102c4cfa2a309e1ba9e90df7df9f34a307 commit 79bc80102c4cfa2a309e1ba9e90df7df9f34a307 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jan 13 14:46:01 2014 +0100 Fix: Call e1inp_vty_init() before reading config file http://cgit.osmocom.org/osmo-trx/commit/?id=5fa388c366b19f753462a19776a59845b7dc5540 commit 5fa388c366b19f753462a19776a59845b7dc5540 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 8 18:34:14 2013 +0200 Fix: Process all TRX on GSM Time indication, not only C0 http://cgit.osmocom.org/osmo-trx/commit/?id=75f105bbb5011a04e599cbc8f053afb723582364 commit 75f105bbb5011a04e599cbc8f053afb723582364 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 8 18:41:05 2013 +0200 Fix: Retrieve ARFCN (from OML) for TRX other than C0 http://cgit.osmocom.org/osmo-trx/commit/?id=2340b88ede52d8da5ff203b97464653c6f4528d5 commit 2340b88ede52d8da5ff203b97464653c6f4528d5 Author: Ivan Kluchnikov <kluchnikovi at gmail.com> Date: Wed May 7 18:09:06 2014 +0400 fix: make sysmobts tests only when sysmobts is enabled http://cgit.osmocom.org/osmo-trx/commit/?id=329085a8ff2c1162a32eb617068fa5614efcde06 commit 329085a8ff2c1162a32eb617068fa5614efcde06 Merge: 1eaa3d7 819b50e Author: Harald Welte <laforge at gnumonks.org> Date: Tue Sep 22 16:39:55 2015 +0200 Merge branch '201509-l1sap' http://cgit.osmocom.org/osmo-trx/commit/?id=819b50e1a7b506a0a394cc71a795f0a9ce4083c1 commit 819b50e1a7b506a0a394cc71a795f0a9ce4083c1 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 6 12:33:16 2015 +0200 move MS power control handling from sysmobts to common part MS uplink power control is required in pretty much any BTS, and we cannot assume that they PHY / L1 will always take care of it by itself. So the correspondign code is moved to common/power_control.c and called from the generic part of L1SAP. The corresponding VTY paramter has been moved from the sysmobts-specific trx VTY node to the common BTS VTY node. http://cgit.osmocom.org/osmo-trx/commit/?id=f449842053d333f6f9f41d3123262e8e05375acb commit f449842053d333f6f9f41d3123262e8e05375acb Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Apr 4 14:11:33 2014 +0200 Move detection of handover frames from sysmo-bts code to common code http://cgit.osmocom.org/osmo-trx/commit/?id=9cfbf27d4c2b08bec64141c447c59645488bd722 commit 9cfbf27d4c2b08bec64141c447c59645488bd722 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 12:30:52 2013 +0200 Remove obsolete gsmtap handling from osmo-bts-sysmo part. http://cgit.osmocom.org/osmo-trx/commit/?id=a450ef73edb35c19392b34f663e0570a8839ece6 commit a450ef73edb35c19392b34f663e0570a8839ece6 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 12:06:19 2013 +0200 Add gsmtap option to command line to main.c of osmo-bts-sysmo http://cgit.osmocom.org/osmo-trx/commit/?id=04b5d655752d7afeb94018765ae08b1d7b0f91c5 commit 04b5d655752d7afeb94018765ae08b1d7b0f91c5 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 12:04:49 2013 +0200 Move gsmtap VTY commands from osmo-bts-sysmo to common part http://cgit.osmocom.org/osmo-trx/commit/?id=90e543bd83b60a6a5823888354c47dd5d9ba99ac commit 90e543bd83b60a6a5823888354c47dd5d9ba99ac Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 29 09:45:22 2013 +0200 Send primitives at PH-/MPH-/TCH-SAP interface via GSMTAP http://cgit.osmocom.org/osmo-trx/commit/?id=75caaf294980e258b63d300284f9b7bf26fd35c9 commit 75caaf294980e258b63d300284f9b7bf26fd35c9 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jun 16 13:26:14 2013 +0200 sysmobts: Clean up transitions for lchan cipher state There are three transitions: 1. LCHAN_CIPH_NONE -> LCHAN_CIPH_RX_REQ -> LCHAN_CIPH_RX_CONF It is used to enable ciphering in RX (uplink) direction only. 2. LCHAN_CIPH_RX_CONF -> LCHAN_CIPH_RX_CONF_TX_REQ -> LCHAN_CIPH_RXTX_CONF It is used to additionally enable ciphering in TX (downlink) direction. 3. LCHAN_CIPH_NONE -> LCHAN_CIPH_RXTX_REQ -> LCHAN_CIPH_RX_CONF_TX_REQ -> LCHAN_CIPH_RXTX_CONF It is used to enable ciphering in both TX and RX directions. This is used when the channel is activated with encryption already enabled. (assignment or handover) In order to follow the order of these transitions, the RX direction must always be set before the TX direction. If no cipher key is set (A5/0), ciphering is set to ALG 0, but lchan cipher state remains at LCHAN_CIPH_NONE. http://cgit.osmocom.org/osmo-trx/commit/?id=5027e122a885eab21772706d39915464c887150d commit 5027e122a885eab21772706d39915464c887150d Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sat Aug 31 20:30:40 2013 +0200 Add MEAS (MPH_INFO) IND message to PH-/MPH-/TCH-SAP interface This part moves processing of measurement infos from osmo-bts-sysmo to common part. http://cgit.osmocom.org/osmo-trx/commit/?id=a313bb0a476aca8570abea3592dbe7593d11ecc9 commit a313bb0a476aca8570abea3592dbe7593d11ecc9 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 22:13:18 2014 +0200 l1sap: Port code to new ciphering handling ... introduced in 2cc37035d73191b71b9ba9c0d559a0da6a5f35e5 http://cgit.osmocom.org/osmo-trx/commit/?id=923e324abc6d529aea884ca7082220ba66906054 commit 923e324abc6d529aea884ca7082220ba66906054 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Aug 7 08:32:30 2014 +0200 sysmobts/l1_if: Sacch/Sdcc/Facch are handled in l1sap/core http://cgit.osmocom.org/osmo-trx/commit/?id=bac087c207ab3323c354d173335c30c85396464e commit bac087c207ab3323c354d173335c30c85396464e Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 11:09:20 2013 +0200 Add SDCCH/SACCH/FACCH messages to PH-/MPH-/TCH-SAP interface This part moves control channel message primitives from osmo-bts-sysmo to common part. In order to control ciphering fo BTS model, CIPHER (MPH_INFO) messages are used. http://cgit.osmocom.org/osmo-trx/commit/?id=80f039973e37ab45c98b8f0ed4731105334ac623 commit 80f039973e37ab45c98b8f0ed4731105334ac623 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 20:18:35 2014 +0200 l1sap: Avoid compiler warnings regarding uninitialized nmsg http://cgit.osmocom.org/osmo-trx/commit/?id=3a381367a62ab57946e113592348a9720803ae0f commit 3a381367a62ab57946e113592348a9720803ae0f Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 20:15:22 2014 +0200 l1sap: Use {data,empty}_req_from_l1sap() and avoid code duplication http://cgit.osmocom.org/osmo-trx/commit/?id=12472df8f0f552b85d9d046ce646e83bd93e3ae0 commit 12472df8f0f552b85d9d046ce646e83bd93e3ae0 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 10:08:15 2013 +0200 Add TCH messages to PH-/MPH-/TCH-SAP interface This part moves TCH handling from osmo-bts-sysmo to common part. The RTP handling is done at the common part, so they can be used by other BTS models. http://cgit.osmocom.org/osmo-trx/commit/?id=7cc199ea9580aef5cc8364f875c5e764491920be commit 7cc199ea9580aef5cc8364f875c5e764491920be Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 20:05:59 2014 +0200 l1sap: re-introduce a comment that was lost during l1sap merge http://cgit.osmocom.org/osmo-trx/commit/?id=793e713c4bcf0929c2656760acb42e875f743da9 commit 793e713c4bcf0929c2656760acb42e875f743da9 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 09:19:45 2013 +0200 Move chan act/rel/modify from bts_model to PH-/MPH-/TCH-SAP interface This part replaces channel activation/deactivation/modification routines by MPH_INFO messages. http://cgit.osmocom.org/osmo-trx/commit/?id=faba84b9b7c035691fd831ad26871a63417d22d0 commit faba84b9b7c035691fd831ad26871a63417d22d0 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Sep 1 09:02:24 2013 +0200 Relace bts_model_get_time() by get_time() at common part http://cgit.osmocom.org/osmo-trx/commit/?id=7cf313c75bb25502ce0228952271021d35d50f68 commit 7cf313c75bb25502ce0228952271021d35d50f68 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 19:57:51 2014 +0200 l1sap: Re-introduce more correct RACH slot counting The original code handled both the fact where a TIME indication would be missed (and thus the frame number be higher than previous + 1), as well as the two cases for combined / non-combined CCCH. The L1SAP code removed some of those bits, which I'm re-introducing here. http://cgit.osmocom.org/osmo-trx/commit/?id=21b5e6318e7bfbd233fdf542a3f43588ab92282b commit 21b5e6318e7bfbd233fdf542a3f43588ab92282b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sat Aug 31 19:49:12 2013 +0200 Add TIME (MPH_INFO) IND messages to PH-/MPH-/TCH-SAP interface This part moves GSM time handling from osmo-bts-sysmo part to common part. http://cgit.osmocom.org/osmo-trx/commit/?id=4fe00da9f8f849efb86977e909870179124f384a commit 4fe00da9f8f849efb86977e909870179124f384a Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 19:50:08 2014 +0200 l1sap: additional comments explaining l1sap changes in l1_if.c http://cgit.osmocom.org/osmo-trx/commit/?id=75be092b99a8dd693fe7fdc35b6c124d730f66cd commit 75be092b99a8dd693fe7fdc35b6c124d730f66cd Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Aug 30 08:48:38 2013 +0200 Add PDCH messages to PH-/MPH-/TCH-SAP interface This part moves PDTCH, PACCH and PTCCH message primitives from osmo-bts-sysmo to common part. http://cgit.osmocom.org/osmo-trx/commit/?id=c9441b3c0b898d09d9e8d6ad4c616a62a905f1d7 commit c9441b3c0b898d09d9e8d6ad4c616a62a905f1d7 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 19:29:35 2014 +0200 l1sap: Add a warning about assuming BS_AG_BLKS_RES=1 This is a regression of the code compared to the existing sysmoBTS code, where the L1 tells us whether its AGCH or PCH. However, it was not used even in the old code, so we can afford to simply put a #warning here. http://cgit.osmocom.org/osmo-trx/commit/?id=ace9a8742f700a748620f4b590b6c5468cd4d584 commit ace9a8742f700a748620f4b590b6c5468cd4d584 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Aug 30 08:03:09 2013 +0200 Add PCH/AGCH message to PH-/MPH-/TCH-SAP interface This part moves PCH and AGCH message primitives from osmo-bts-sysmo to common part. http://cgit.osmocom.org/osmo-trx/commit/?id=54eceac257c1359c13ec11337912fa69d45fe6e8 commit 54eceac257c1359c13ec11337912fa69d45fe6e8 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 18:54:24 2014 +0200 l1sap: sysmobts: remove obsolete get_lapdm_chan_by_hl2() http://cgit.osmocom.org/osmo-trx/commit/?id=d410eb9787e2667c23079b3588b702562589cd99 commit d410eb9787e2667c23079b3588b702562589cd99 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 18:52:08 2014 +0200 l1sap: correctly set chan_nr on PRIM_PH_RACH / INDICATION In case of a RACH INDICATION on CCCH, we need to set CHAN_NR to 0x88 (RSL_CHAN_RACH). In other cases, chan_nr needs to reflect the actual logical channel (TCH/SDCCH) on whcih the handover happened. http://cgit.osmocom.org/osmo-trx/commit/?id=9ae5b50d786d81e1d89dfe41238bd0129fed7271 commit 9ae5b50d786d81e1d89dfe41238bd0129fed7271 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 18:31:39 2014 +0200 l1sap: RACH: Detect hand-over even on TRX0 I don't understand why we would detect handover only on TRX1-n, but not on TRX0. It is perfectly valid for a handover to occur on TRX0. http://cgit.osmocom.org/osmo-trx/commit/?id=52476fc1d474007dc9bd1ca3d222e4d4cb9da9a7 commit 52476fc1d474007dc9bd1ca3d222e4d4cb9da9a7 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 17:13:20 2014 +0200 l1sap: fix missing include file and resulting compiler warning http://cgit.osmocom.org/osmo-trx/commit/?id=e969f0889205dc43034964c06e032ff46638f4e7 commit e969f0889205dc43034964c06e032ff46638f4e7 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 17:12:44 2014 +0200 l1sap: fix coding style http://cgit.osmocom.org/osmo-trx/commit/?id=7b1b8326184b9a61b75d7663e699649ba0386557 commit 7b1b8326184b9a61b75d7663e699649ba0386557 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 17:11:23 2014 +0200 l1sap: Use L1SAP_IS_CHAN_RACH instead of magic number 0x88 http://cgit.osmocom.org/osmo-trx/commit/?id=e0146997a662ccc64be06a63a81770079074b32a commit e0146997a662ccc64be06a63a81770079074b32a Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Aug 30 07:46:30 2013 +0200 Add RACH message to PH-/MPH-/TCH-SAP interface This part moves RACH message primitives from osmo-bts-sysmo to common part. http://cgit.osmocom.org/osmo-trx/commit/?id=a391d3691ad62766e7074d531c2cb08c867218ed commit a391d3691ad62766e7074d531c2cb08c867218ed Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 27 16:32:53 2014 +0200 l1sap: Split ph_data_req() into smaller parts ... in an effort to avoid introducing new/more spaghetti code Also, use offsetof() instead of pointer calculation to determine the start of GsmL1_Prim_t.u.phDataReq.msgUnitParam.u8Buffer http://cgit.osmocom.org/osmo-trx/commit/?id=5e90f2a809f85817883bb567c5a51efe8e1ecb46 commit 5e90f2a809f85817883bb567c5a51efe8e1ecb46 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 29 09:42:23 2013 +0200 Add BCCH message to PH-/MPH-/TCH-SAP interface This first part moves BCCH message primitives from osmo-bts-sysmo to common part. A new file "common/l1sap.c" is introduced to implement handling of layer 1 messages from/to BTS model. http://cgit.osmocom.org/osmo-trx/commit/?id=1eaa3d72eaa10bb854b2adff48d3f7f3e06dcb8c commit 1eaa3d72eaa10bb854b2adff48d3f7f3e06dcb8c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Sep 21 11:28:03 2015 +0200 audio/rsl: Honor the speech mode and don't send anything Spotted by Ciaby while debugging an audio issue. Do not send anything to port==0 to the BSC/NITB. Look at the upper bits of the speech_mode to determine if sending is allowed. 0x1 means recv_only and all other modes allow us to send. Manually verified with a single phone call with LCR bridge mode to send a CRCX early but a MDCX sendrecv later. The audio starts to flow after the MDCX message. Virtual Addr space didn't increase over 10 calls. The l1p_msg is freed by the caller. The code might not re-set speech_mode from one call to another but if it is ever != 0 it can be expected that the BSC will always set it. This is because we do not (and don't want to) allocate the lchan dynamically on every usage. Fixes: SYS#2111 http://cgit.osmocom.org/osmo-trx/commit/?id=668f8df3be7f644056d16ea4a7fd7929429da0b4 commit 668f8df3be7f644056d16ea4a7fd7929429da0b4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Sep 21 11:18:06 2015 +0200 audio/rsl: Include statistics for one call Use the new libosmo-abis API to query the session for the statistics and then send it as a TLV element to the BSC. This can be used to do post processing about the call. E.g to figure out if no audio arrived at all. http://cgit.osmocom.org/osmo-trx/commit/?id=cc4a08bdc753492c4367e4786a573a6cdf84b56e commit cc4a08bdc753492c4367e4786a573a6cdf84b56e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Sep 21 09:52:36 2015 +0200 audio/rsl: Include the connection identifier in the DLCX ind I have traces that include the connection identifier in the DLCX indication. http://cgit.osmocom.org/osmo-trx/commit/?id=862807504b5ecf4fe79c435286487a1a576d09eb commit 862807504b5ecf4fe79c435286487a1a576d09eb Author: Harald Welte <laforge at gnumonks.org> Date: Fri Aug 21 02:30:24 2015 +0200 update README to bring it more in sync with reality. http://cgit.osmocom.org/osmo-trx/commit/?id=a7c276b72b07b8b713c5d9af869159690e073441 commit a7c276b72b07b8b713c5d9af869159690e073441 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jul 14 09:44:19 2015 +0200 meas: Do not send incomplete measurement reports The RSL_IE_MEAS_RES_NR is mandatory element with a minimum of 5 octets (two for TL and three for the value). When we establish a new channel we might not have had enough time in a TDMA frame to calculate the average. The issue is not easy to reproduce. At the point we receive the measurement report we have two uplink measurements queued. As it is not easy to reproduce and only occurs when a channel is new I have decided to drop the message instead of sending made up uplink measurement reports. As of now lchan_build_rsl_ul_meas will always return 3 and the condition will never be false. Avoids: SYS#1781 http://cgit.osmocom.org/osmo-trx/commit/?id=f869a95f3b81d281405e3fc3026e1d0d53174082 commit f869a95f3b81d281405e3fc3026e1d0d53174082 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Mar 28 18:31:10 2015 +0100 write_queue: Check the result of osmo_wqueue_enqueue and free The write_queue is designed to have a maximum amount of pending messages and will refuse to take new messages when it has been reached. The caller can decide if it wants to flush the queue and add the message again, create a log. But in all cases the ownership of the msgb has not been transferred. Fix the potential memory leak in the failure situation. http://cgit.osmocom.org/osmo-trx/commit/?id=0ddd4b6c25dcb1cf85809b190afd6ac4d95890ea commit 0ddd4b6c25dcb1cf85809b190afd6ac4d95890ea Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 29 09:37:07 2013 +0200 Add header file of PH-/MPH-/TCH-SAP interface to common part of osmo-bts Instead of handling primitives directly at layer 1 specific code, osmo-bts handles primitives at common code. When all primitive are moved, the l1sap interface will: - receive PH-DATA indications and forward them to layer 2. - check for RF link loss and notify BSC. - receive TCH indications and forward them via RTP. - receive PH-RTS indications and send PH-DATA requests with content according to its logical channel. - receive TCH-RTS indications and send TCH requests with content received via RTP or loopback from TCH indications. - send MPH-INFO requests to activate, deactivate and modify logical channels and handle their confirms. - receive MPH-INFO indications with measurements from tranceiver. - forward received and transmitted PH-DATA to GSMTAP. http://cgit.osmocom.org/osmo-trx/commit/?id=24839068f5c7e044e82afaa3b88d08a07e123ee7 commit 24839068f5c7e044e82afaa3b88d08a07e123ee7 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 28 11:48:40 2013 +0200 sysmo-bts: Use correct boundaries of L1 msg when forwarding to L1 proxy In case of a headroom in a message, the 'head' pointer will not point to the actual data. http://cgit.osmocom.org/osmo-trx/commit/?id=b631bd21d21b10f8e0344dc47af34ef09306d0fb commit b631bd21d21b10f8e0344dc47af34ef09306d0fb Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 29 20:57:17 2015 +0100 power: Make it possible to force a power level Use the standard RSL commands to order a logical channel to use a fixed power level. The code is not fully verified and there was a last minute change to invoke bts_model_adjst_ms_pwr. http://cgit.osmocom.org/osmo-trx/commit/?id=579651bf300de002731dfd3bd39985c9fd15616c commit 579651bf300de002731dfd3bd39985c9fd15616c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Dec 6 20:30:52 2014 +0100 power/sysmobts: Add a manual ms power level control Currently the DSP is instructed to achieve a given uplink power target but there are circumstances (e.g. EMV testing) where we need more control over it. The "manual/software/osmo" power control can only be implemented per TRX and not per lchan. Add a very very basic control that checks the MS Power used by the phone, the actual receive level and then adjust the power. The code doesn't take the history into account, if the phone can not reach the requested power level the code will be stuck (e.g. no timeout based on multiframes). It has a mode for a fixed power control but no way to set it yet. The change of the mode requires a restart of the software. http://cgit.osmocom.org/osmo-trx/commit/?id=0d6946741c7b5697a58e7650b6e60d495a6cfb32 commit 0d6946741c7b5697a58e7650b6e60d495a6cfb32 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Jan 10 18:06:29 2015 +0100 sysmobts: Check mgr->calib.bts_conn for NULL Check the right variable for NULL. Fixes: CID 1262214 http://cgit.osmocom.org/osmo-trx/commit/?id=7e10bd6401916d1768f5b2caaaae1ee35db85735 commit 7e10bd6401916d1768f5b2caaaae1ee35db85735 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Jan 10 13:07:49 2015 +0100 misc: Fix up testcase after 5a03e129a633637d0a6b57b3b5aa6d6596b938fe In 5a03e129a633637d0a6b57b3b5aa6d6596b938fe we generalized the structural parser so we need to update the expected behavior of that routine. http://cgit.osmocom.org/osmo-trx/commit/?id=84e4dd92d454cd58e9cbe127c0d969e248f0e588 commit 84e4dd92d454cd58e9cbe127c0d969e248f0e588 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jan 9 22:06:28 2015 +0100 sysmobts: Improve some log messages for calib control * Print the GPS FD that was opened (e.g. to see if it was closed again) * Print the state changes/expectations * Print the correct to be applied. I wondered if I shouldo do a cor = cor * -1.. cor = -cor.. or add CLOCK_CORR(err) macro to use it inside the printf and correction and decided the gain is not worth the risk. http://cgit.osmocom.org/osmo-trx/commit/?id=55da9874c0306516b8f3bb6f1db486a3c9c51fb2 commit 55da9874c0306516b8f3bb6f1db486a3c9c51fb2 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 23 11:47:28 2014 +0100 sysmobts: Create a calibration loop that will be run Continously run the calibration process. Everytime we call the reset function classify the outcome. In case of a failure schedule the next command soon and otherwise wait several hours. Remember if the process was started through the VTY or the run loop. In case it can't be started immediately reset and schedule a new run. http://cgit.osmocom.org/osmo-trx/commit/?id=d8d5f5904fa83786b01dbf77593232eb6f6954bc commit d8d5f5904fa83786b01dbf77593232eb6f6954bc Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 23 09:45:55 2014 +0100 sysmobts: Start the calibration the first time the link is up After a reboot the system might have been off for a long time and the currently used value might be wrong. Remember that we never ran the calibration and execute it on start. http://cgit.osmocom.org/osmo-trx/commit/?id=9acc82ce4a01d502db1be8cdf15d2328ae181c5c commit 9acc82ce4a01d502db1be8cdf15d2328ae181c5c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Dec 22 18:24:57 2014 +0100 sysmobts: Initial version to use libgps to determine FIX state We should only calibrate the clock if there is a GPS fix. Start gpsd to determine if there is a fix or not. Work around trimble decoding issues (sent an email upstream). We need to gain some more experience to see if there memory leaks. We also need to re-schedule the calibration depending on the outcome. http://cgit.osmocom.org/osmo-trx/commit/?id=c017e309c4d73420a31c32e95aeae30f5e09c161 commit c017e309c4d73420a31c32e95aeae30f5e09c161 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jan 6 19:11:49 2015 +0100 sysmobts: The correction for GPS is in the reverse direction Change the sign before passing it as correction value. The error is the difference between the TCXO and GPS. We need to correct by the reverse of the error. This seems to be different depending on the clock source we have. This is a last minute untested change. http://cgit.osmocom.org/osmo-trx/commit/?id=2e59b20204e2ebcf5baff60774f0fd4ac707404f commit 2e59b20204e2ebcf5baff60774f0fd4ac707404f Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 21:54:43 2014 +0100 sysmobts: Use the ctrl interface for calibration This runs the entire procedure for calibration with reasonable error and success checking. It can be triggered from the VTY of the sysmobts-mgr right now. What is missing is to hook up with GPSD to check if the system has a fix and provide a mode that will continously run the calibration command. http://cgit.osmocom.org/osmo-trx/commit/?id=fd425b1484ceac900c02f7d8fcb5fb199ef2bbf6 commit fd425b1484ceac900c02f7d8fcb5fb199ef2bbf6 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 19:20:17 2014 +0100 sysmobts: Copy more of l1if_rf_clock_info_reset into the CTRL code The CTRL code should have used/extended the l1_if calibration code. The sysmobts-mgr code first needs to determine if the clock adjustment is necessary at all. This is done by first resetting the counters, then waiting, then asking for the diff and then applying the correction value. But the reference clock is only set by the application comand. Copy more code of l1if_rf_clock_info_reset to set the reference clock as value. This is leaving some todos inside the code that will be resolved as part of SYS#835. Related: SYS#835 http://cgit.osmocom.org/osmo-trx/commit/?id=50131c125e2298cc4f71fa2b69881f6a40a7000a commit 50131c125e2298cc4f71fa2b69881f6a40a7000a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 16:59:41 2014 +0100 sysmobts: Begin with calib control from the sysmobts manager In the long run we will connect to GPSD and wait for a fix and then run the calibration. The first step is to open (and re-open) the control connection to the BTS. As the connection is on localhost there should not be a computation overhead to always have the connection open. When connecting assume that the ASYNC connect worked directly as otherwise we get no notification of the failure. This looks like a "bug" of libosmo-abis that should check if the socket has been connected or not. http://cgit.osmocom.org/osmo-trx/commit/?id=5a03e129a633637d0a6b57b3b5aa6d6596b938fe commit 5a03e129a633637d0a6b57b3b5aa6d6596b938fe Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 16:54:08 2014 +0100 msg: Generalize the message structure test This was taken out of LaF0rge's OML router branch and is now used by the extended calibration feature. http://cgit.osmocom.org/osmo-trx/commit/?id=b7ebf545e6cc5eee17df254815c7838fbea61db7 commit b7ebf545e6cc5eee17df254815c7838fbea61db7 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jan 6 19:19:47 2015 +0100 cbch: Speculative change to not change CHAN ACK for CBCH Use the rel_act_kind to not send RSL channel acks for the CBCH to the BSC. This is similar to what we do for the BCCH a couple of lines above. http://cgit.osmocom.org/osmo-trx/commit/?id=8fc2630dd4884ffeb4c5fc93457c8c06e6dbf918 commit 8fc2630dd4884ffeb4c5fc93457c8c06e6dbf918 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Dec 30 13:45:02 2014 +0100 SMS-CB: Clean up + centralize generation of NULL block http://cgit.osmocom.org/osmo-trx/commit/?id=bd988f6ad3624ae0be3bdc19143d4db0290744f5 commit bd988f6ad3624ae0be3bdc19143d4db0290744f5 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Dec 30 13:34:57 2014 +0100 SMS-CB: Use GSM412_SEQ_NULL_MSG rather than 0xf http://cgit.osmocom.org/osmo-trx/commit/?id=1e245336ecfe6cbdf3c4253ca5557146d493126d commit 1e245336ecfe6cbdf3c4253ca5557146d493126d Author: Harald Welte <laforge at gnumonks.org> Date: Tue Dec 30 13:33:54 2014 +0100 SMS-CB: use gsm412_block_type from libosmocore .. and not our own local re-definition of the structure. http://cgit.osmocom.org/osmo-trx/commit/?id=4457c0d9ba73a0f8f9e95bb24dd3f33f469b4fe3 commit 4457c0d9ba73a0f8f9e95bb24dd3f33f469b4fe3 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Dec 30 13:32:52 2014 +0100 SMS-CB: Use GSM412_ #defines from libosmocore rather than our own http://cgit.osmocom.org/osmo-trx/commit/?id=660116fb9d7b382808377274ae4aed7c45e980e3 commit 660116fb9d7b382808377274ae4aed7c45e980e3 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Dec 29 01:02:29 2014 +0100 CBCH: Implement CBCH block segmentation and RSL_MT_SMS_BC_CMD * CBCH load indications are not yet sent * The queue length is not yet limited! http://cgit.osmocom.org/osmo-trx/commit/?id=b15d2c9d2f8ebe56672ab2191a4dc39d22fa0ab8 commit b15d2c9d2f8ebe56672ab2191a4dc39d22fa0ab8 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Dec 28 15:18:09 2014 +0100 Initial CBCH support This should handle OML channel combinations with CBCH and activate the CBCH SAPI towards the DSP correspondingly. What is still missing is sending any actual information over the CBCH in respons to the PH-RTS.ind coming up from L1. http://cgit.osmocom.org/osmo-trx/commit/?id=50dc96507caba9480938eb3d9d0db9236f877b49 commit 50dc96507caba9480938eb3d9d0db9236f877b49 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 26 01:41:41 2014 +0100 sysmobts: Include the serial number in the find response Read the serial number once and format it as a string. In case no serial number is present -1 will be returned. Manually tested with a slightly modified version. serial_nr was the expected one. http://cgit.osmocom.org/osmo-trx/commit/?id=c265bef48c414ca6c135f803c0c5dfdecbeece72 commit c265bef48c414ca6c135f803c0c5dfdecbeece72 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 16 20:20:27 2014 +0100 sysmobts: Add slave on/off action for the sysmoBTS2050 Add new power actions for the sysmoBTS2050. This allows to switch off the secondary/slave when the system temperature is too high and back on when the normal level is reached. Do not allow to switch off the master (so remove the enum value), do not check if the slave is switching itself off. http://cgit.osmocom.org/osmo-trx/commit/?id=02a2afa962799c1519eb78cffa8877fd3da75b2e commit 02a2afa962799c1519eb78cffa8877fd3da75b2e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 16 19:09:30 2014 +0100 sysmobts: Comment out the varpoware options that are not implemented http://cgit.osmocom.org/osmo-trx/commit/?id=ffc193443c177c3e41851c445c71fc1095ae2201 commit ffc193443c177c3e41851c445c71fc1095ae2201 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 16 18:26:35 2014 +0100 sysmobts: Add "normal" actions to execute Instead of keeping state to remember what was done and needs to be undone this patch introduces actions that will be executed when the system is back to normal. By design the system is considered to be in the normal state and these actions will be only executed after the system is coming back to the normal state. One advantage of this scheme is that an operator can decide that an overheated systems hould be off duty and requires manual interaction to be allowed back in service. The change has only been smoke tested Fixes: SYS#833 http://cgit.osmocom.org/osmo-trx/commit/?id=8968b48643686683046a0af403178960f8baf9ed commit 8968b48643686683046a0af403178960f8baf9ed Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 15:17:02 2014 +0100 sysmobts: Remove unused global variables We do not need to have these variables anymore. Just remove them. http://cgit.osmocom.org/osmo-trx/commit/?id=641a9349317e7b9dec2e38b6cec02a1904267954 commit 641a9349317e7b9dec2e38b6cec02a1904267954 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 16 15:07:15 2014 +0100 sysmobts: Read the clock calibration from another place Read the clock calibration from the place that will be read by the BTS process. Use the standard eeprom code for doing that. The code assumes that this and the other eeprom code don't write/invlidate the others reason. If that assumption would not be true calls to eeprom_free_resources should be added. http://cgit.osmocom.org/osmo-trx/commit/?id=69897d7eed6dc2f992db3499bf9bfe0950f0b34a commit 69897d7eed6dc2f992db3499bf9bfe0950f0b34a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 16 11:17:41 2014 +0100 sysmobts: Don't list non integer parameters in the help The command can only read integer parameters. Don't offer buffers as this will lead to error 22. http://cgit.osmocom.org/osmo-trx/commit/?id=0d09e75f9ca09ddbfe10117f2f4caa8993eb9144 commit 0d09e75f9ca09ddbfe10117f2f4caa8993eb9144 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Dec 16 15:01:09 2014 +0100 eeprom: Fix brown paper bag introduced a long while ago 91d204e2db8f53a6ae4827ecc4b0ccb0137375d0 while adding checks to resolve coverity issues. We simply had no one writing to the eeprom so this was unnoticed for a long time. http://cgit.osmocom.org/osmo-trx/commit/?id=42cc96e2c1edb6863909ef460770bd9e0b23ad58 commit 42cc96e2c1edb6863909ef460770bd9e0b23ad58 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 14:53:23 2014 +0100 sysmobts: Add an option to stop the systemd sysmobts.service For systems without direct access to the PA the best option is to simply switch off the bts service. This will stop the transmission which will take load from the DSP/FPGA/RF circuit and indirectly from the PA as well. We should introduce "pa-on and bts-on" that can be executed as "normal" action. http://cgit.osmocom.org/osmo-trx/commit/?id=8381a6a4835feae6b714fb6fac38c247b69958ee commit 8381a6a4835feae6b714fb6fac38c247b69958ee Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 12 14:36:59 2014 +0100 sysmobts: Actions can be executed in all levels Somebody could decide to switch off the PA in the warning level already. Support this mode of operation. This means we could have a config that: * Enables the PA in the normal level * Disables it in the critical level With kdbus or better IPC we could even have the PA and other parts be represented as service that talk to a bts manager and then simply execute start/stop requests. This would make the entire TODO entry irrelevant as state would be managed by systemd and one can see the time the service was executed. http://cgit.osmocom.org/osmo-trx/commit/?id=4d4dc2674252658330cdd581757d6168087ba4fb commit 4d4dc2674252658330cdd581757d6168087ba4fb Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 15:13:05 2014 +0100 bts: Move BTS and children into the enabled state after opstart With "show bts 0" all objects were still listed as dependency. Once the BTS has been started.. move all the other objects into the enabled state. Our OpenBSC OML code doesn't care but people using the VTY to inspect state will be more happy. One day... we will create proper statemachines inside the BTS and the BSC instead of changing the state in the BTS impl. Fixes: ONW#1330 http://cgit.osmocom.org/osmo-trx/commit/?id=48eb374a9640aab799958590ef35dc3d1bdebefb commit 48eb374a9640aab799958590ef35dc3d1bdebefb Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 15:09:52 2014 +0100 bts: Start with the site manager being enabled and available We would never transition the sitemanager to anything. Our SW does not support SW activation's so we are always ready. Related: ONW#1330 http://cgit.osmocom.org/osmo-trx/commit/?id=2fa6ef26879607ab01795259720857091e76d852 commit 2fa6ef26879607ab01795259720857091e76d852 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 13:18:59 2014 +0100 bts: Mark NSVC1 as offline. We do not expose a second NSVC OsmoBSC> show bts 0 ... GPRS NSVC1: Oper 'Disabled', Admin 'unknown 0x0', Avail 'Off line' http://cgit.osmocom.org/osmo-trx/commit/?id=6d8bcbd192d6d5bfe5077fd675e12734b72fb2be commit 6d8bcbd192d6d5bfe5077fd675e12734b72fb2be Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 13:01:33 2014 +0100 bts: Fix typo in OML comment http://cgit.osmocom.org/osmo-trx/commit/?id=b89a5fa55d712a257ee17bbaed41cdb1ee8d7f75 commit b89a5fa55d712a257ee17bbaed41cdb1ee8d7f75 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 12:53:22 2014 +0100 bts: In case the line isn't created do not exit with code 1 The service file will prevent a re-launch of the sysmobts.service in case the main process exits with '1'. In case the ethernet is not available yet the routine would fail and the sysmobts process will not be restarted. unable to connect/bind socket: Network is unreachable <000f> input/ipaccess.c:885 cannot open OML BTS link: Network is unreachable unable to connect to BSC root at sysmobts-v2:~# echo $? 2 Fixes: SYS#736 http://cgit.osmocom.org/osmo-trx/commit/?id=9f0002b52bdc560587744e17243440951273a153 commit 9f0002b52bdc560587744e17243440951273a153 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 12:04:48 2014 +0100 ctrl: Fix compiler warning bts_ctrl_lookup.c: In function 'bts_controlif_setup': bts_ctrl_lookup.c:97:2: warning: implicit declaration of function 'bts_ctrl_cmds_install' [-Wimplicit-function-declaration] rc = bts_ctrl_cmds_install(bts); ^ http://cgit.osmocom.org/osmo-trx/commit/?id=1cce69364dbbc5fd8ed6765063c84f415da7ce02 commit 1cce69364dbbc5fd8ed6765063c84f415da7ce02 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 12:02:45 2014 +0100 abis: Fix compiler warning and remove const from syntax libosmo-abis doesn't make it easy to have these parameters as const.. just declare it non-const in the api. We pass a static string but we know it will not be modified. http://cgit.osmocom.org/osmo-trx/commit/?id=8332e29c9f3f97cbe22f83673cac4e68c57959f1 commit 8332e29c9f3f97cbe22f83673cac4e68c57959f1 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 11:59:53 2014 +0100 tch: Avoid compiler warnings when using the direct RTP mode tch.c: In function 'l1_to_rtppayload_amr': tch.c:247:29: warning: unused variable 'amr_mrc' [-Wunused-variable] struct amr_multirate_conf *amr_mrc = &lchan->tch.amr_mr; ^ tch.c: In function 'rtppayload_to_l1_amr': tch.c:335:10: warning: unused variable 'amr_if2_core_len' [-Wunused-variable] uint8_t amr_if2_core_len = payload_len - 2; http://cgit.osmocom.org/osmo-trx/commit/?id=be63f03254c036a8466c434b6391ad1a2c2a18bc commit be63f03254c036a8466c434b6391ad1a2c2a18bc Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Nov 10 11:58:21 2014 +0100 sysmobts: Call the routine send and receive instead of get http://cgit.osmocom.org/osmo-trx/commit/?id=9f22fcfd367adbc88183079e27b1cd790a04a6f0 commit 9f22fcfd367adbc88183079e27b1cd790a04a6f0 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Feb 14 11:17:58 2013 +0100 Correctly fill system information messages from BSC SI 5*/6 require L2 header of 0x03,0x03. All SI might be less than 23 octets, so they need to be filled with 0x2b. http://cgit.osmocom.org/osmo-trx/commit/?id=11b14fd6624a012cb6bdc49f2dea970f02fda653 commit 11b14fd6624a012cb6bdc49f2dea970f02fda653 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 19:01:24 2014 +0200 tx_power: Check actual TRX output power against intended value We use the completion call-back from L1 to compare the instructed TRX board output power with the actual value as reported back from L1. Right now we only print an error message in case the values disagree. In the future we might want to either use that value as part of our calculation or send an OML alarm report to the BSC. http://cgit.osmocom.org/osmo-trx/commit/?id=9e873335ec6c77df8a3ffa9fe041d8dfa4ac4ece commit 9e873335ec6c77df8a3ffa9fe041d8dfa4ac4ece Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 18:06:29 2014 +0200 Revert "add nominal transmit power for upcoming sysmoBTS 1020 and 1100" This reverts commit d0866fe4773918381c80c7362ef2d043845ebf54, as it was a bit premature. We need to address this more properly. http://cgit.osmocom.org/osmo-trx/commit/?id=04585dd90a1439e256d54affe4ccea113455cbe7 commit 04585dd90a1439e256d54affe4ccea113455cbe7 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Aug 25 16:02:29 2014 +0200 tx: Generate a working configuration file on "write" We do not have the vty test script to do roundtrip testing. There is no max-initinal-pout, then there was a typo inside 'initial' and for the relative step size the unit is dB/mdB. Fix both of that. http://cgit.osmocom.org/osmo-trx/commit/?id=645cba8532298773949c93543f73b8d7a18c789b commit 645cba8532298773949c93543f73b8d7a18c789b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Aug 25 16:01:29 2014 +0200 tx: Fix another typo i found today morning http://cgit.osmocom.org/osmo-trx/commit/?id=adddb65f4656b0b03b24fa3868e2a8c555af18da commit adddb65f4656b0b03b24fa3868e2a8c555af18da Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Aug 25 08:14:55 2014 +0200 sysmobts: Remove left-over from non-generic power control http://cgit.osmocom.org/osmo-trx/commit/?id=fbf04438b7c9e99dfff72faa4a1dd1e909da2c10 commit fbf04438b7c9e99dfff72faa4a1dd1e909da2c10 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Aug 25 08:00:41 2014 +0200 ctrl: Use msgb_free to free message http://cgit.osmocom.org/osmo-trx/commit/?id=e0e9b30f5cbda675b5504caab88654d89fa47cae commit e0e9b30f5cbda675b5504caab88654d89fa47cae Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 10:05:31 2014 +0200 tx_power.c: fix potential array out-of-bounds access http://cgit.osmocom.org/osmo-trx/commit/?id=68b9b376cf6d3a983cc6b06d7aef189c30b952f2 commit 68b9b376cf6d3a983cc6b06d7aef189c30b952f2 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 09:22:00 2014 +0200 make use of libosmocore 'gsm_meas_rep_unidir' Back in March 2013, some structures and defines related to decoded measurement reports have been moved from openbsc to libosmocore (libosmocore e128f4663104ed64e33e362cff2566f36d65e658) so that they can be used also from osmo-bts. This finally follows up on that. You need openbsc 7ff4f0e0fc692bfab829da50edb104e58b271e7e or later. http://cgit.osmocom.org/osmo-trx/commit/?id=d0866fe4773918381c80c7362ef2d043845ebf54 commit d0866fe4773918381c80c7362ef2d043845ebf54 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 08:48:37 2014 +0200 add nominal transmit power for upcoming sysmoBTS 1020 and 1100 http://cgit.osmocom.org/osmo-trx/commit/?id=913044ecc50bf768ef3ae5b17b1536a4c75f7686 commit 913044ecc50bf768ef3ae5b17b1536a4c75f7686 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 08:46:48 2014 +0200 tx_power.c: Fix typos in comments http://cgit.osmocom.org/osmo-trx/commit/?id=3dd6ebe0b8373001ee5b2fe4655576060237b97e commit 3dd6ebe0b8373001ee5b2fe4655576060237b97e Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 25 08:41:19 2014 +0200 add information on unit (milli-dB) to control interface doc http://cgit.osmocom.org/osmo-trx/commit/?id=1fb66c8e6a2f79f48b0a79946f6f844e29527817 commit 1fb66c8e6a2f79f48b0a79946f6f844e29527817 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 18:16:45 2014 +0200 disable clock control interface on HW_SYSMOBTS_V1 http://cgit.osmocom.org/osmo-trx/commit/?id=ab09e27d72408dd17b89263b8b9df0e5e9aa593a commit ab09e27d72408dd17b89263b8b9df0e5e9aa593a Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 17:42:47 2014 +0200 add control_if.h to Makefile.am http://cgit.osmocom.org/osmo-trx/commit/?id=c0a3030277ed1541bcbfd5f602ee6dbe906fac14 commit c0a3030277ed1541bcbfd5f602ee6dbe906fac14 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 17:19:59 2014 +0200 add a small document describing the use of the control interface http://cgit.osmocom.org/osmo-trx/commit/?id=be1898495977f1aa0db1f63c4158be7ec0d8218e commit be1898495977f1aa0db1f63c4158be7ec0d8218e Author: Harald Welte <laforge at gnumonks.org> Date: Fri Aug 22 23:26:26 2014 +0200 ctrl: Add sysmobts control interface This sysmobts specific control interface allows for clock calibration from an external program by means of the "trx.0.clock-info" and "trx.0.clock-correction" values. http://cgit.osmocom.org/osmo-trx/commit/?id=9d0fd073e91d25bf61c19089a0c4e0ee35457446 commit 9d0fd073e91d25bf61c19089a0c4e0ee35457446 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Aug 21 23:03:45 2014 +0200 l1_if: pass private 'void *data' from call to callback When enqueueing a command towards the L1, we can now pass along a private data pointer, which then gets passed to the call-back upon completion. http://cgit.osmocom.org/osmo-trx/commit/?id=8e4cc1cbb8946b53c929caa2bd4bbf2fd30588a5 commit 8e4cc1cbb8946b53c929caa2bd4bbf2fd30588a5 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 17:04:54 2014 +0200 fix build problem introduced with control interface http://cgit.osmocom.org/osmo-trx/commit/?id=993575bcd8ecb03a06cf5c5e507f4eceba91d40c commit 993575bcd8ecb03a06cf5c5e507f4eceba91d40c Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 16:57:59 2014 +0200 use libocmocore #defines for VTY port numbers http://cgit.osmocom.org/osmo-trx/commit/?id=0ff0f2d00f37cd82a21e4638d15a8bb736419c8a commit 0ff0f2d00f37cd82a21e4638d15a8bb736419c8a Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 16:55:30 2014 +0200 ctrl_if: Move control interface to port 4238 ... which is now defined in libosmocore http://cgit.osmocom.org/osmo-trx/commit/?id=d9a2aa8d9909d93d96e421c7cb727932445fa8ab commit d9a2aa8d9909d93d96e421c7cb727932445fa8ab Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 10:44:31 2014 +0200 add control interface to common BTS (for thermal attenuation) Using this control interface, an external program can request attentuation of the transmitter for thermal management reasons. The external application doesn't have to know anthing about the actual transmit power, but it can just configure a certian value of milli-dB (1/10000 bel) and update (increase/decrease) that value depending on the thermal environment. http://cgit.osmocom.org/osmo-trx/commit/?id=e43feaf231e08f108aafa26a7829820fad3447cb commit e43feaf231e08f108aafa26a7829820fad3447cb Author: Harald Welte <laforge at gnumonks.org> Date: Fri Aug 22 02:46:15 2014 +0200 New generic transmit power handling In order to support transmit power reduction by thermal management as well as the variety of new internal / external PA configurations of BTSs, we need a slightly more complex system. Also, as at high power a single dB can be quite a big difference, we are now doing all computations in milli-dB(m), i.e. 1/10000 bel. Ramping is now used both for up and down ramping, as that is useful in cases where you want to gracefully shut down a cell by shrinking its radius, gradually handing over subscribers to neighboring cells. Furthermore, this code is becoming part of the 'common' codebase, as it is not really specific to how sysmobts is working. The user can specify a single aggregate value for external system gain/attenuation. Let's say you have 1dB loss of antenna cable, so you can put that as 'user-gain -1' into the config, which means that a 'transmit power of 20dBm' will be compensatet for that and the TRX is instructed to output 21dBm to compensate the cable loss. Similarly, external PAs can be described by a positive user-gain. One of the next steps will be to communicate those values and the nominal power capability of the specific BTS to the BSC, so the BSC will automatically show correct signal levels in the VTY and log files. The code includes provisions for future extensions regarding * an external and an internal PA with calibration tables * a thermal attenuation setting to be controlled by the site manager http://cgit.osmocom.org/osmo-trx/commit/?id=fcca2e82184f8ece6a31db48abd77d560065b31f commit fcca2e82184f8ece6a31db48abd77d560065b31f Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 24 09:50:40 2014 +0200 remove copy of gsm_bts_num() ... which is now available from gsm_data_shared.[ch] of openbsc http://cgit.osmocom.org/osmo-trx/commit/?id=15f899f89ee6a6384b34f82eade16192a71508fe commit 15f899f89ee6a6384b34f82eade16192a71508fe Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Aug 22 00:02:07 2014 +0200 sysmobts: Use the uc connection on both slave and master We can use this on both slave and master. But only have the master switch on the PA. http://cgit.osmocom.org/osmo-trx/commit/?id=3a54b7aa308be6672ce7335a621030ba979bb0be commit 3a54b7aa308be6672ce7335a621030ba979bb0be Merge: 7be58a1 1f8053e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 23:55:37 2014 +0200 Merge branch 'sysmocom/features/sysmobts-mgr-temp' Implement the first round of temperature control and actions. Only the PA can be switched off, it will never be switched on again, in case the microcontroller doesn't respond we will do nothing as well. These todos need to be addressed in the near future. http://cgit.osmocom.org/osmo-trx/commit/?id=1f8053e366c9d0f4ab7160595a3cb1ead915e0d6 commit 1f8053e366c9d0f4ab7160595a3cb1ead915e0d6 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 23:51:13 2014 +0200 sysmobts: Enable the PA on start and disable it as first action The PA will be unconditionally turned. This makes it possible that in case of a crash, the PA will be turned on and then we will do the temperature measurement and turn it off again. There are no known crashes with the sysmobts-mgr right now so the risk seems to be okay. In case we can't switch off the PA we have no way to escalate it right now. We have not seen a dead uc either so the risk is okay as well. We can't switch the PA back on once we reach the normal level as the BTS might transmit with full power and we would need more current than the power supply/rails can carry. So leave the system off right now. What is missing is to use the OML router to actually inform the BSC that something bad has happened at the BTS. http://cgit.osmocom.org/osmo-trx/commit/?id=e02d7796c3cb4eaeca679286bc6db12b9b2c070b commit e02d7796c3cb4eaeca679286bc6db12b9b2c070b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 23:27:16 2014 +0200 sysmobts: Show the current temperature controls state int he VTY http://cgit.osmocom.org/osmo-trx/commit/?id=714ccb9992307112689d63493fada72cf1a6224b commit 714ccb9992307112689d63493fada72cf1a6224b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 23:24:02 2014 +0200 sysmobts: Provide information about the state transitions http://cgit.osmocom.org/osmo-trx/commit/?id=b0674e9636a5010b1d9a17496afa1f6ffc1fc79b commit b0674e9636a5010b1d9a17496afa1f6ffc1fc79b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 22:52:50 2014 +0200 sysmobts: Implement a small state machine for temp control Check the temperature and move between "NORMAL", "WARNING" and "CRITICAL" state. We will only return from CRITICAL to WARNING when the temperature has significantly changed, and when being in state "WARNING" we enter an intermediate state to allow an easy hysteris. http://cgit.osmocom.org/osmo-trx/commit/?id=d036cce744b4c0da6b147fe94d7f8ce723f8bb30 commit d036cce744b4c0da6b147fe94d7f8ce723f8bb30 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 21:56:12 2014 +0200 sysmobts: Remove the sbt2050 timer and move defines back We haven't done anything with the result of the micro controller query and querying every six hours for the temperature of the system will not help us. We need to query the temperatures more frequently but avoid writing to the eeprom too frequently so we will start another timer for that. http://cgit.osmocom.org/osmo-trx/commit/?id=c42bf5fdf5e933413ec0a480d5a2de42538e9c80 commit c42bf5fdf5e933413ec0a480d5a2de42538e9c80 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 21:51:30 2014 +0200 sysmobts: Simplify some includes/dependencies http://cgit.osmocom.org/osmo-trx/commit/?id=ca71d07e449c960ab6d1c7da5f3f43b62426a449 commit ca71d07e449c960ab6d1c7da5f3f43b62426a449 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 18:51:36 2014 +0200 sysmobts: Begin to add various limits and actions The idea is that for different parts of the system we can define thresholds for warning and critical (severe) temperate thresholds. And once any of these temperatures is reached we will execute an action. When crossing from NORMAL to WARNING or WARNING to SEVERE we will need to apply some hysteris before switching back to the lower level. E.g. when being SEVERE mode, at least wait until we are below the warning level again. Besides being able to switch off things we could start reducing the transmit power of the system until the system is cold enough again. No action is implemented so far, everything is varpoware! http://cgit.osmocom.org/osmo-trx/commit/?id=c7ee5acba91524de4d936f502e7166078c6908fd commit c7ee5acba91524de4d936f502e7166078c6908fd Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 22:54:18 2014 +0200 sysmobts: Fix the temperature log message alignment http://cgit.osmocom.org/osmo-trx/commit/?id=9698570d47f31d44615a6b96efb03f520f99f8e1 commit 9698570d47f31d44615a6b96efb03f520f99f8e1 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 21:45:33 2014 +0200 sysmobts: Move ipaccess-find counterpart to a dedicated source file http://cgit.osmocom.org/osmo-trx/commit/?id=7be58a173aae516a185fd5c2a56ffc3a8a698e05 commit 7be58a173aae516a185fd5c2a56ffc3a8a698e05 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 18:03:25 2014 +0200 sysmobts: Fix the build when no 2050 uc header file was found Fix the build (provide empty stubs) when the header file is not present. http://cgit.osmocom.org/osmo-trx/commit/?id=631945a36790898a3c5832d21e36bf0f54ffc465 commit 631945a36790898a3c5832d21e36bf0f54ffc465 Merge: ffe1d2e 5e13630 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 16:25:22 2014 +0200 Merge branch 'sysmocom/features/sysmobts-mgr' Add some VTY code to show the temperature on all devices and to query the external micro controller for voltage/current and the temperature in the "show manager" command. It should probably be a "show system" command though. http://cgit.osmocom.org/osmo-trx/commit/?id=5e1363071f9e9951985ba1a21196c5548350fafc commit 5e1363071f9e9951985ba1a21196c5548350fafc Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 22:12:56 2014 +0200 sysmobts: Fix the power request result We want to know which componets are enabled and the voltage and current used by the components. http://cgit.osmocom.org/osmo-trx/commit/?id=4059e29a29039759c60624f87e45d35d922d88d1 commit 4059e29a29039759c60624f87e45d35d922d88d1 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 21:16:57 2014 +0200 sysmobts: Read the temperature sensors on the device Read the sensors that are always present and the ones that are only present on the sysmoBTS 2050. http://cgit.osmocom.org/osmo-trx/commit/?id=46c085d794d9c973528718b62caeb41443a53417 commit 46c085d794d9c973528718b62caeb41443a53417 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 16:12:30 2014 +0200 sysmobts: Add is_sbts2050_master http://cgit.osmocom.org/osmo-trx/commit/?id=b1ceb403630d093c364736def15b7c9f48f6fed0 commit b1ceb403630d093c364736def15b7c9f48f6fed0 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 20:56:18 2014 +0200 sysmobts: Read the model number and trx once from the device Use it for the ipaccess-find response and for the sysmobts classification code. This can be used by the vty in a second. http://cgit.osmocom.org/osmo-trx/commit/?id=3ecb2bb60472ea291a5f13b4babe6fd9a7fba028 commit 3ecb2bb60472ea291a5f13b4babe6fd9a7fba028 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 16:12:50 2014 +0200 sysmobts: Initialize fd with an invalid fd Initialize the ucinfo with an invalid fd to prevent writing on fd=0 by accident. http://cgit.osmocom.org/osmo-trx/commit/?id=ffe1d2e1e0bc99debf5cc826c43632680d969825 commit ffe1d2e1e0bc99debf5cc826c43632680d969825 Merge: 0719875 575f633 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 15:49:55 2014 +0200 Merge commit 'sysmocom/features/sysmobts-mgr-vty' Some re-factorings. Still a very long way to go. It should work with haralds re-based but that wasn't verified due my toolchain not having the most recent libosmocore. The service file and screenrc change has not been verified either. http://cgit.osmocom.org/osmo-trx/commit/?id=575f633483d09e5d6666aed4d7e132614c2e1847 commit 575f633483d09e5d6666aed4d7e132614c2e1847 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Aug 21 15:29:25 2014 +0200 sysmobts: Use another logp region as it is mostly related to remp http://cgit.osmocom.org/osmo-trx/commit/?id=54a8b313b4bac5b3853d8e9bcea5385651354651 commit 54a8b313b4bac5b3853d8e9bcea5385651354651 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 20:08:33 2014 +0200 sysmobts: There is only one uc make it a singleton Move the init and polling into the sysmoBTS related part. In the future we should have _one_ temperature control. http://cgit.osmocom.org/osmo-trx/commit/?id=c84ca8c82fa1383efc96016e206bce709ed9b9d4 commit c84ca8c82fa1383efc96016e206bce709ed9b9d4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 19:35:41 2014 +0200 sysmobts: Clean-up the parsing routines http://cgit.osmocom.org/osmo-trx/commit/?id=035187b44ea12d0ff551973517c2525d0a8cf068 commit 035187b44ea12d0ff551973517c2525d0a8cf068 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 19:19:42 2014 +0200 sysmobts: Move the sysmoBTS 2050 controller handling Move the code to a separate file to keep things nicely apart of each other. http://cgit.osmocom.org/osmo-trx/commit/?id=013df51ca8693d39ee01252f71d1e61f7cff84b4 commit 013df51ca8693d39ee01252f71d1e61f7cff84b4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 18:48:35 2014 +0200 sysmobts: Add VTY support to the sysmobts-mgr Add VTY support to the manager. This way we can interactively inspect the state of the system and trigger events. http://cgit.osmocom.org/osmo-trx/commit/?id=07198750b29fa891dd6c1d6266964691aa9e9095 commit 07198750b29fa891dd6c1d6266964691aa9e9095 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Aug 20 23:27:37 2014 +0200 adopt to recent libosmocore ipa rename http://cgit.osmocom.org/osmo-trx/commit/?id=ac76388c778f453c335510a77ff5a6054c691979 commit ac76388c778f453c335510a77ff5a6054c691979 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 18 16:39:07 2014 +0200 TLVP_PRES_LEN is now in libosmocore, avoid redefining it http://cgit.osmocom.org/osmo-trx/commit/?id=bc82b0189a3f8f7402c4986c21362f8fb89474ce commit bc82b0189a3f8f7402c4986c21362f8fb89474ce Author: Harald Welte <laforge at gnumonks.org> Date: Sun Aug 17 18:41:19 2014 +0200 replace oml_{osmo,ipa}_magic[] with abis_nm_{osmo,ipa}_magic the latter is now in libosmogsm. http://cgit.osmocom.org/osmo-trx/commit/?id=fcd5c367d17d5435771636d06a27980ed7a39a47 commit fcd5c367d17d5435771636d06a27980ed7a39a47 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Aug 18 19:20:49 2014 +0200 Migrate to osmo_get_macaddr() in recent libosmocore get_mac_addr() is generally useful and shouldn't be hidden in the osmo-bts/abis.c file http://cgit.osmocom.org/osmo-trx/commit/?id=88d60a1f86b083d6154c299aceceab44595f34d7 commit 88d60a1f86b083d6154c299aceceab44595f34d7 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Aug 9 09:17:14 2014 +0200 sysmobts: Add a unit test that checks of the behavior We need to build a lot more code to be able to test these two new routines. I didn't want to move the code to a utils file as the check is called from a hot path. Add accessors to the inlined variant to be used by the unit test. While writing the unit tests I noticed that a re-transmission of the ciphering command would lead to an attempt to enable ciphering again. I am not sure that this MphConfig is idempotent. http://cgit.osmocom.org/osmo-trx/commit/?id=2cc37035d73191b71b9ba9c0d559a0da6a5f35e5 commit 2cc37035d73191b71b9ba9c0d559a0da6a5f35e5 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Aug 9 01:04:42 2014 +0200 sysmobts: Deal with ciphering when we have a transport clash The network is configured with early classmark sending. This means that the phone might send a "classmark change" message at the same time we send a ciphering mode command. When we received the CM message we assumed we have just received the first ciphered message and enabled ciphering for tx as well. When we snoop the Ciphering Mode Command extract the N(S) variable and when we receive an I frame from the MS see if it handled our message by comparing the MS N(R) to BTS N(S) + 1. http://cgit.osmocom.org/osmo-trx/commit/?id=6cf49380cd5d89973e442f4575f525332ef42a6c commit 6cf49380cd5d89973e442f4575f525332ef42a6c Merge: 9e1dbf5 caca189 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 17:49:08 2014 +0200 Merge branch 'sysmocom/features/oml-router' http://cgit.osmocom.org/osmo-trx/commit/?id=caca1899ce5ea5fd8e32c3ea93961a6156531a6c commit caca1899ce5ea5fd8e32c3ea93961a6156531a6c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 17:43:08 2014 +0200 sysmobts: Make sure that the omlrouter is in a FHS path I wondered if I should use the 'abstract namespace' feature of Linux but just put the router into /var/run/ to make it work out of the box. Change the signature to provide a sane error message. http://cgit.osmocom.org/osmo-trx/commit/?id=fcdfb690ca68fcac64ac19ada3680832d45c8469 commit fcdfb690ca68fcac64ac19ada3680832d45c8469 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 18:23:40 2014 +0200 sysmobts: Add testcase for ETSI/12.21 message http://cgit.osmocom.org/osmo-trx/commit/?id=dbc2731887d288d0a358ee3ff375f0be8658291e commit dbc2731887d288d0a358ee3ff375f0be8658291e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 18:07:34 2014 +0200 sysmobts: Extend the testcase for a Osmo message as well http://cgit.osmocom.org/osmo-trx/commit/?id=0655cac6f1fbb0a669f064780a171a363ce8ef83 commit 0655cac6f1fbb0a669f064780a171a363ce8ef83 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 16:21:35 2014 +0200 sysmobts: Verify the structure of IPA and OML messages Extend the router to verify that the message received is properly encoded. The code can deal with the basic structure of ETSI OML and vendor specific messages for ip.access and the osmocom project. http://cgit.osmocom.org/osmo-trx/commit/?id=9e1dbf532e4450f99797b7a8e580172449c615aa commit 9e1dbf532e4450f99797b7a8e580172449c615aa Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 16:57:17 2014 +0200 sysmobts: Remove debug left over from enabling the RTP mode http://cgit.osmocom.org/osmo-trx/commit/?id=b05d72d21b8cc91126cf45525f9010df6142e1c2 commit b05d72d21b8cc91126cf45525f9010df6142e1c2 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 14:43:03 2014 +0200 sysmobts: Begin with an OML router that will be used by the manager Begin with the basics of a OML Router. This is currently only capable of accepting a connection and read messages but it will evolve into a router in multiple stages. The first usage will be by the sysmobts-mgr. An OML Error Indication will be sent by the sysmobts-mgr and it will be forwarded to the BSC. In the second step we will set a relative power reduction from the sysmobts-mgr. In the long-term this code will be used to communicate with a second TRX. http://cgit.osmocom.org/osmo-trx/commit/?id=b3d1779b96cfe9f7b0ae2a4e0cff9cf354770de0 commit b3d1779b96cfe9f7b0ae2a4e0cff9cf354770de0 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 16:32:52 2014 +0200 tests: Move the "pcu_direct" symbol into the stubs to be shared http://cgit.osmocom.org/osmo-trx/commit/?id=bc8de146716ecb2435a02dcb9fdf2cc9701c0122 commit bc8de146716ecb2435a02dcb9fdf2cc9701c0122 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 16:18:48 2014 +0200 oml: Make it possible to include the file directly Fixes: ../../include/osmo-bts/oml.h:8:42: warning: âstruct gsm_btsâ declared inside parameter list [enabled by default] int down_oml(struct gsm_bts *bts, struct msgb *msg); ^ ../../include/osmo-bts/oml.h:8:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] ../../include/osmo-bts/oml.h:12:52: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_send_msg(struct gsm_abis_mo *mo, struct msgb *msg, uint8_t msg_type); ^ ../../include/osmo-bts/oml.h:13:31: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_opstart_ack(struct gsm_abis_mo *mo); ^ ../../include/osmo-bts/oml.h:14:32: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_opstart_nack(struct gsm_abis_mo *mo, uint8_t nack_cause); ^ ../../include/osmo-bts/oml.h:15:32: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_statechg_ack(struct gsm_abis_mo *mo); ^ ../../include/osmo-bts/oml.h:16:33: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_statechg_nack(struct gsm_abis_mo *mo, uint8_t nack_cause); ^ ../../include/osmo-bts/oml.h:19:29: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_state_chg(struct gsm_abis_mo *mo, int op_state, int avail_state); ^ ../../include/osmo-bts/oml.h:22:31: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] void oml_mo_state_init(struct gsm_abis_mo *mo, int op_state, int avail_state); ^ ../../include/osmo-bts/oml.h:26:10: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int success); ^ ../../include/osmo-bts/oml.h:29:33: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_tx_state_changed(struct gsm_abis_mo *mo); ^ ../../include/osmo-bts/oml.h:31:33: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] int oml_mo_tx_sw_act_rep(struct gsm_abis_mo *mo); ^ ../../include/osmo-bts/oml.h:36:4: warning: âstruct gsm_abis_moâ declared inside parameter list [enabled by default] uint8_t cause); http://cgit.osmocom.org/osmo-trx/commit/?id=a19912db347af14dd7eec0fea5c897875f1ddf5a commit a19912db347af14dd7eec0fea5c897875f1ddf5a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 31 14:39:32 2014 +0200 sysmobts: Enable the direct RTP mode for firmware >= 3.11 We need to patch the CMR due wanting to support systems that still have Audiocodes hardware in their chain. I have manually tested and could listen to my own voice on: TCH/H & AMR 5.9 & PTSN & BSC TCH/F & FR1 & Other subscriber & NITB TCH/F & EFR & Other subscriber & NITB TCH/H & HR1 & Other subscriber & NITB TCH/H & AMR 5.9 & Other subscriber & NITB The tests were done using the Nokia E71, a Blackberry curve and for the PTSN a HTC 8S were used. http://cgit.osmocom.org/osmo-trx/commit/?id=eececf5fa96875e93d622299408423766c6e35d0 commit eececf5fa96875e93d622299408423766c6e35d0 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jul 25 19:53:21 2014 +0200 sysmobts: Make it possible to slowly ramp up the output power For systems with a bigger PA enabling the full output power at once might draw more current than a power supply can provide. This code will step up the output power in smaller steps to avoid this situation. http://cgit.osmocom.org/osmo-trx/commit/?id=bc24955e91f050e904851f589400eac4c3443917 commit bc24955e91f050e904851f589400eac4c3443917 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jul 25 14:37:47 2014 +0200 sysmobts: Provide VTY routines to do clock calibrations The sysmoBTS2050 does not have a OCXO and we should not rely on the GPS module to always have a fix. Instead use the TCXO by default and from time to time (and we know we have a fix calibrate the TCXO). This can be done by: trx 0 rf-clock-info reset wait... trx 0 rf-clock-info correct write The output is currently only written to the log as the VTY connection might go away during the operation. The reset will set the approriate reference clock and the correct will attempt to determine and apply the correction. The write terminal will make sure that next on start a known good value will be used. http://cgit.osmocom.org/osmo-trx/commit/?id=bac0ff7f6df5c8fb002f3588952922b43772e770 commit bac0ff7f6df5c8fb002f3588952922b43772e770 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jul 25 13:23:00 2014 +0200 sysmobts: Free the message on older firmware releases Seen while implementing a new functionality in the code. http://cgit.osmocom.org/osmo-trx/commit/?id=94a63851b7a1794c642d76e95b3d0d389f279137 commit 94a63851b7a1794c642d76e95b3d0d389f279137 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jul 25 10:48:14 2014 +0200 sysmobts: Include the model and master/slave in the unitid Make it more easy to find the right BTS model and know what is the master/slave. http://cgit.osmocom.org/osmo-trx/commit/?id=3674645e20d23d37269ee9226363f94bbde4b5c6 commit 3674645e20d23d37269ee9226363f94bbde4b5c6 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 24 21:24:29 2014 +0200 amr: Avoid toggling the CMR from none and a set one For LCR and other systems without out-of-band information we need to indicate the CMR. Not every air message will include the mode and we sent a stream that had the CMR set and not-set. This lead to the AudioCodes MGW only playing every second frame. Remember the last used mode and initialize it to _NONE when we receive the multirate config. In case of a real error we will still use AMR_CMR_NONE. The initial patch is from Harald. I have added the initialization and moving of the defines to amr.h. Manually verified by enabling AMR5.9 and looking at two RTP packages in sequence. In both cases the CMR was 2. I have looked at "amr.nb.cmr != 2" in wireshark and only found the MGCP dummy packet. http://cgit.osmocom.org/osmo-trx/commit/?id=a2b806c375dc6b3e3b7df0496e06b34b1520bd1b commit a2b806c375dc6b3e3b7df0496e06b34b1520bd1b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Jun 22 14:17:45 2014 +0200 sysmobts: Fix typo in the comment http://cgit.osmocom.org/osmo-trx/commit/?id=a7f9b58e44fa7119e7113269765302a0b8a619d5 commit a7f9b58e44fa7119e7113269765302a0b8a619d5 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri May 30 12:42:31 2014 +0200 sysmobts: Fix the initialization of the BTS manager code The code should only run for the sysmoBTS 2050 and TRX 0. If the device is not marked as 2050 the code would attempt to open /dev/ttyS0 and block forever. http://cgit.osmocom.org/osmo-trx/commit/?id=0e2b6244184a1c030252667765a0587073575d23 commit 0e2b6244184a1c030252667765a0587073575d23 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun May 25 13:42:13 2014 +0200 sysmobts: Revert all sysmobts-mgr related changes Harald is right and that the code is generally not ready for inclusion. I fell victim of trying to finish it while the code is not ready at all. It is better to re-introduce the patches in a smaller and more tested way. The right way would have been a branch were ready things are split-off the main/wip commit until everything is ready. Revert "sysmobts: Have a common prefix for the enum" This reverts commit 44980347f308fe5bbe48a933dbc81b82b53d310a. Revert "utils: Used the enum manuf_type_id in the parameter of add_manufacturer_id_label" This reverts commit 7d36e5ed46b630203167fc9d5d28e0087fdbd394. Revert "utils: Classify the OML message using the return type" This reverts commit afee0b7929a00500f9c204f3bc7e12f72451e832. Revert "sysmobts: Do not access out of bound string" This reverts commit f5f41e805195c8c3294a9e6a68b10f975fbabbbd. Revert "sysmobts: Separate IPA and OML check into two methods" This reverts commit 13a224063dfcee0be529fba1c8fb9be9c1fb261e. Revert "screenrc: osmobts-mgr now needs a config file" This reverts commit 0a1699ff8a5462c167c24e8b28186abb26331698. Revert "make sure osmobts-mgr.cfg file is included in tarballs" This reverts commit 14c60b425f8146f6a392d2d3de2979c817cd975e. Revert "sysmobts-mgr: Add VTY support for configuring it" This reverts commit c5fedd24c96a4ef6d7a0c0ed3c70d6ef0abd5c17. Revert "sysmobts: Add beginnings of an OML router and create Failure Messages in the sysmobts-manager" This reverts commit c6ab90b27006ff2d1fdfb0b1d7fc01e1dd4a696d. http://cgit.osmocom.org/osmo-trx/commit/?id=7996134d2afb8098eb750433b20185bde21e0023 commit 7996134d2afb8098eb750433b20185bde21e0023 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu May 22 21:17:49 2014 +0200 common: Ignore "si.valid" outside of _MAX_SYSINFO_TYPE Limit the range from 0 to (_MAX_SYSINFO_TYPE - 1) instead of 0 to 31. This way we will never access the lchan->si.buf[] out of bounds. This is only a theoretical issue though as the code filling the lchan->si.buf for the SACCH will not have valid >= _MAX_SYSINFO_TYPE. Add a small regression test to check we still schedule all SIs. Fixes: CID 1040765 http://cgit.osmocom.org/osmo-trx/commit/?id=ac26607fe4644e0794b4637048bd58e4c978260c commit ac26607fe4644e0794b4637048bd58e4c978260c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu May 22 20:42:33 2014 +0200 common: Remove unused gsm_time parameter from lchan_sacch_get http://cgit.osmocom.org/osmo-trx/commit/?id=9d8aeab0b6887f8384834bf912262be1906253c6 commit 9d8aeab0b6887f8384834bf912262be1906253c6 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu May 22 19:50:39 2014 +0200 sysmobts: Avoid memleak when multiple -c arguments are passed Rely on optarg pointing to an address that will be valid for the run of the entire application. Fixes: CID 1206578 http://cgit.osmocom.org/osmo-trx/commit/?id=44980347f308fe5bbe48a933dbc81b82b53d310a commit 44980347f308fe5bbe48a933dbc81b82b53d310a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue May 20 09:14:00 2014 +0200 sysmobts: Have a common prefix for the enum Make the manuf_type_id enum have a common prefix for the symbols. http://cgit.osmocom.org/osmo-trx/commit/?id=7d36e5ed46b630203167fc9d5d28e0087fdbd394 commit 7d36e5ed46b630203167fc9d5d28e0087fdbd394 Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Tue May 20 07:44:07 2014 +0200 utils: Used the enum manuf_type_id in the parameter of add_manufacturer_id_label Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=afee0b7929a00500f9c204f3bc7e12f72451e832 commit afee0b7929a00500f9c204f3bc7e12f72451e832 Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Tue May 20 07:42:24 2014 +0200 utils: Classify the OML message using the return type Classify the OML message and return the manufacturer type or an error. Currently ETSI, ip.access and Osmocom are known. Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=f5f41e805195c8c3294a9e6a68b10f975fbabbbd commit f5f41e805195c8c3294a9e6a68b10f975fbabbbd Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Tue May 20 09:06:53 2014 +0200 sysmobts: Do not access out of bound string One can either use "strlen(str) + 1" but not add one to the result of the sizeof. http://cgit.osmocom.org/osmo-trx/commit/?id=13a224063dfcee0be529fba1c8fb9be9c1fb261e commit 13a224063dfcee0be529fba1c8fb9be9c1fb261e Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Tue May 20 07:40:47 2014 +0200 sysmobts: Separate IPA and OML check into two methods I have split the function check_oml_msg, in two functions. One for checking if the ipa header is well-formed and in check_oml_msg, Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=0a1699ff8a5462c167c24e8b28186abb26331698 commit 0a1699ff8a5462c167c24e8b28186abb26331698 Author: Harald Welte <laforge at gnumonks.org> Date: Mon May 19 13:01:20 2014 +0200 screenrc: osmobts-mgr now needs a config file http://cgit.osmocom.org/osmo-trx/commit/?id=14c60b425f8146f6a392d2d3de2979c817cd975e commit 14c60b425f8146f6a392d2d3de2979c817cd975e Author: Harald Welte <laforge at gnumonks.org> Date: Mon May 19 12:58:31 2014 +0200 make sure osmobts-mgr.cfg file is included in tarballs http://cgit.osmocom.org/osmo-trx/commit/?id=b4280963c0a236f3676ff4d5a191943ad63b7e69 commit b4280963c0a236f3676ff4d5a191943ad63b7e69 Author: Harald Welte <laforge at gnumonks.org> Date: Mon May 19 11:22:38 2014 +0200 Revert "sysmobts: Add support for changing the transmit power in sbts2050" This reverts commit c64d42573894d8295b58b268a64541c914b69bcd. There are unfrtunately still too many problems with this patch to be merged at this point. http://cgit.osmocom.org/osmo-trx/commit/?id=76c309e9f751840ce539e9043a8ad80da90b83e5 commit 76c309e9f751840ce539e9043a8ad80da90b83e5 Author: Harald Welte <laforge at gnumonks.org> Date: Sun May 18 19:32:37 2014 +0200 sysmoBTS TCH: Set CMR in AMR RTP frames Enable the previously commented-out logic to set the CMR (Codec Mode Request) in AMR RTP frames based on the CMI (CMR Index) of the AMR speech frame on the Um interface. This is of course anyway the right thing to do, but also required for an AMR receiver which doesn't have out-of-band information on the codec mode, and which also doesn't determine the AMR codec mode based on the size of the AMR frame (such as lcr as of current master). We also move the entire CMR generation into the #ifdef section which is only compiled-in if we do _not_ use the RTP mode of L1. http://cgit.osmocom.org/osmo-trx/commit/?id=c64d42573894d8295b58b268a64541c914b69bcd commit c64d42573894d8295b58b268a64541c914b69bcd Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Sat May 17 11:01:13 2014 +0200 sysmobts: Add support for changing the transmit power in sbts2050 Make the sysmobts-mgr send a manufacturer O&M message with the power reduction we want the sysmobts to apply. The sysmobts will handle this message and set the new tx output power. An ACK/NACK will be send as a response to the power reduction. Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=c5fedd24c96a4ef6d7a0c0ed3c70d6ef0abd5c17 commit c5fedd24c96a4ef6d7a0c0ed3c70d6ef0abd5c17 Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Sat May 17 10:56:07 2014 +0200 sysmobts-mgr: Add VTY support for configuring it This patch allows to configure the warning temperature threshold, the severe temperature threshold of the board and the PA and the actions like the relative value power that we want to reduce the transmit power to and the part that we want to switch off or not. Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=c6ab90b27006ff2d1fdfb0b1d7fc01e1dd4a696d commit c6ab90b27006ff2d1fdfb0b1d7fc01e1dd4a696d Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Sat May 17 10:45:50 2014 +0200 sysmobts: Add beginnings of an OML router and create Failure Messages in the sysmobts-manager Make the sysmobts listen for OML messages on a Unix Domain Socket. Messages passing a sanity check will be forwarded to the BSC. In case the sysmobts-mgr detects a temperature above or below temperature threshold an OML failure message will be sent to the BTS. [moved confinfo into the #ifdef BUILD_SBTS2050] Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=73d9d3af6cd79e674cb326d814dbb50134f76f64 commit 73d9d3af6cd79e674cb326d814dbb50134f76f64 Author: Harald Welte <laforge at gnumonks.org> Date: Sat May 17 10:04:44 2014 +0200 sysmobts: Support DSP API >= 3.8.1 (u8MaxCellSize) http://cgit.osmocom.org/osmo-trx/commit/?id=d75c648871d1cae1d2cf4f74f60eaf07fb97ba73 commit d75c648871d1cae1d2cf4f74f60eaf07fb97ba73 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu May 15 13:00:30 2014 +0200 abis: Separate initialization from connect for Abis Initialize the libosmo-abis VTY nodes more early so we can parse the config file that was created by "write". Introduce abis_init to initialize the libosmo-abis and modify abis_open to re-use an existing line. Update the comments. This has only been tried with the sysmobts-remote on x86. A TCP connection is opened toward the configured BSC. Fixes: SYS#285 http://cgit.osmocom.org/osmo-trx/commit/?id=8b5b993d29f751bf66fa9deabbe900fd9e193637 commit 8b5b993d29f751bf66fa9deabbe900fd9e193637 Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Wed May 14 18:22:45 2014 +0200 sysmobts: Fix compiler warning about missing declaration Include utils.h to have a declaration of sysmobts_get_nominal_power, l1_if.c: In function 'l1if_activate_rf': l1_if.c:1144:6: warning: implicit declaration of function 'sysmobts_get_nominal_power' [-Wimplicit-function-declaration] Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=9ed6b95c9096a0e4e12673feb322cb0355d3dafe commit 9ed6b95c9096a0e4e12673feb322cb0355d3dafe Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Mon Apr 28 13:40:24 2014 +0200 osmo-bts-sysmo/utils.c: Added a function for calculate the power transmitter Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=3e5b6db2d26f279f9238089f8c79de1d71a997aa commit 3e5b6db2d26f279f9238089f8c79de1d71a997aa Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Apr 19 19:22:22 2014 +0200 handover: Call the right function and avoid recursion Fix a brown paper bag bug and call the right method. The above was an infinite recursion. The stack didn't overflow as the compiler optimized the tail-recursion and coverity didn't complain either. The issue was introduced in the last minutes before the merge when I renamed "reset_handover" to "handover_reset" to follow the object_verb approach throughout the handover.c code. While doing that I sadly replaced reset_handover with handover_frame and not handover_reset. http://cgit.osmocom.org/osmo-trx/commit/?id=d59bbd16a753554747adcdec18b5cea28a839604 commit d59bbd16a753554747adcdec18b5cea28a839604 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Apr 7 20:33:04 2014 +0200 sysmobts: Add log message in case the channel activation fails http://cgit.osmocom.org/osmo-trx/commit/?id=f547bee8785e0e89469abc13f7da24fb8b37ba4d commit f547bee8785e0e89469abc13f7da24fb8b37ba4d Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Apr 7 20:30:12 2014 +0200 rsl: Use unique values for the call to rsl_tx_chan_act_nack This way we can easily find the place in the code that is responsible for the NACK. http://cgit.osmocom.org/osmo-trx/commit/?id=57a4d121c4d756f1e97c75d85a7799db751e9f75 commit 57a4d121c4d756f1e97c75d85a7799db751e9f75 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Mar 31 15:11:57 2014 +0200 oml: Pass all valid state change requests to the model Currently ADM state change request that tries to set the administrative state to the current value are immediately ACK'ed. Beside the caching problem, this could lead the protocol inconsistencies if two such requests are sent one after the other and the second arrives before the procedure of the first has finished. This patch removes the shortcut in oml_rx_chg_adm_state() which immediately called oml_mo_statechg_ack(mo). Ticket: OW#1132 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=0859795878783f5b07fecb1404b2d0eacb17d208 commit 0859795878783f5b07fecb1404b2d0eacb17d208 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Mar 29 19:27:54 2014 +0100 sysmobts: Fix build for the v1 of the sysmobts http://cgit.osmocom.org/osmo-trx/commit/?id=14ff9255553f42bada7b042945e86d6b575b28b2 commit 14ff9255553f42bada7b042945e86d6b575b28b2 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Mar 27 09:19:24 2014 +0100 agch/pcu: Fix crash for AGCH commands queued by the PCU The dequeue code assumed that msg->l3h is a valid pointer but in the case of the PCU socket it was a null pointer. This lead to memcpy copying a lot more than 23 bytes which ultimately lead to a crash. The issue was introduced in the git commits 37c332e5bfdb9591a1cd3cc6746afffdb1cd13b9 and the commit d290ee029a827c870f97372b98f0dbd7d057402a. use msg->l3h = msgb_put(msg, len) to make sure that there is a valid L3 pointer for the message. (gdb) bt #0 0x419d6384 in memcpy () from /tmp/ow/lib/libc.so.6 #1 0x0001894c in bts_ccch_copy_msg (bts=0x62248, out_buf=0x62248 "p\025\003", gt=0x1, is_ag_res=100684) at bts.c:572 #2 0x0000c958 in handle_ph_readytosend_ind (rts_ind=<optimized out>, fl1=0x62e78) at l1_if.c:515 #3 l1if_handle_ind (fl1=0x62e78, msg=0x8bb08) at l1_if.c:920 #4 0x000147e8 in read_dispatch_one (queue=<optimized out>, msg=0x8bb08, fl1h=<optimized out>) at l1_transp_hw.c:190 #5 l1if_fd_cb (ofd=0x62f04, what=<optimized out>) at l1_transp_hw.c:224 #6 0x41b9d028 in osmo_select_main (polling=<optimized out>) at select.c:158 #7 0x0000b204 in main (argc=<optimized out>, argv=<optimized out>) at main.c:384 (gdb) p *msg $12 = {list = {next = 0x100100, prev = 0x200200}, {dst = 0x0, trx = 0x0}, lchan = 0x0, l1h = 0x0, l2h = 0x0, l3h = 0x0, l4h = 0x0, cb = {0, 0, 0, 0, 0}, data_len = 23, len = 23, head = 0x8572c "-\006?\020\r\340*q\224#", tail = 0x85743 "", data = 0x8572c "-\006?\020\r\340*q\224#", _data = 0x8572c "-\006?\020\r\340*q\224#"} http://cgit.osmocom.org/osmo-trx/commit/?id=64a4327c34568628d5eb9bfc63fdcf88f60e1c3f commit 64a4327c34568628d5eb9bfc63fdcf88f60e1c3f Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 26 18:02:08 2014 +0100 sysmobts: Apply the potentially new max_power_red on the TRX In case the max power reduction has been changed through OML, let us call the l1if_set_txpower routine to update the nominal power. This has been manually verified with both BTS #1 and #57. ./bsc_control.py -d localhost -p 4249 -s bts.0.trx.0.max-power-reduction 0 The above command and GNUradio have been used to determine if the power level has changed at all. Fixes: SYS#268 http://cgit.osmocom.org/osmo-trx/commit/?id=a276b9823627fcc3279bd005cc64f63edbeb4819 commit a276b9823627fcc3279bd005cc64f63edbeb4819 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 26 18:00:40 2014 +0100 oml: Indicate the kind of object passed as the void* These routines do not pass the gsm_abis_mo and parsing the FOM header of the msg does not seem to be a good idea either. Pass in the OML object so that the model code can determine what the void pointer is. http://cgit.osmocom.org/osmo-trx/commit/?id=71d98050f38840f61d37ddb5f7e4efd5d5f0bab4 commit 71d98050f38840f61d37ddb5f7e4efd5d5f0bab4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 26 17:49:06 2014 +0100 sysmobts: Honor power reduction on older sysmoBTSv2 hardware Older hardware didn't have the external attentuator that was used to control the wanted output power. So starting from the git commit 3c8ff3c70bc52d0a1d75a1e6b87b0069d92f10f9 older hardware was always transmitting with 23 dBm regardless of the power reduction. Remember the hardware revision returned by the SystemInformation primitive, postpone the call to l1if_activate_rf until we know the board revision. Manually verified on BTS #1 and #57. On BTS#1 the external attenuator has not been configured and on BTS#57 it was. http://cgit.osmocom.org/osmo-trx/commit/?id=83dc54fb95af692a74f749335a9ee9b2b49dc1b9 commit 83dc54fb95af692a74f749335a9ee9b2b49dc1b9 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Mar 21 19:28:13 2014 +0100 systemd: Provide the pcu direct mode http://cgit.osmocom.org/osmo-trx/commit/?id=ae2473c2ca07cf5173a3dab22bc64e7b135ef848 commit ae2473c2ca07cf5173a3dab22bc64e7b135ef848 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Mar 21 18:08:16 2014 +0100 systemd: Do not restart with a broken config file or such Only restart in case of a crash or the exit(42) when the OML/RSL link is going down. http://cgit.osmocom.org/osmo-trx/commit/?id=fb067905d5e4feb73a41556b798640a8b0f01b77 commit fb067905d5e4feb73a41556b798640a8b0f01b77 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Mar 13 18:31:09 2014 +0100 sysmobts: Add a magic number to the hLayer2 to differentiate it The DSP/FPGA appears to report bogus PhDataInd with hlayer2 == 0. Currently this would match the TRX==0,TS==0 and SS=0 and then we report bad measurement reports. Add a magic number to the lower eight bit of the hLayer2 to differentiate valid numbers. Addresses: <0004> measurement.c:97 (bts=0,trx=0,ts=0,ss=0) measurement during state: NONE <0004> measurement.c:102 (bts=0,trx=0,ts=0,ss=0) no space for uplink measurement http://cgit.osmocom.org/osmo-trx/commit/?id=3e317ea4f06c84393c4630aa963b8e751c0fa201 commit 3e317ea4f06c84393c4630aa963b8e751c0fa201 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Mar 13 20:12:29 2014 +0100 sysmobts: Change the order to follow the RX handling code http://cgit.osmocom.org/osmo-trx/commit/?id=b45c8a6b6cf07ddcd60d8e5b53827be4658706f2 commit b45c8a6b6cf07ddcd60d8e5b53827be4658706f2 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Mar 13 18:30:09 2014 +0100 sysmobts: Improve the log message and print the hLayer2 we don't know http://cgit.osmocom.org/osmo-trx/commit/?id=2dca8f37e5d44802221abb4d6fd31ec51fb9921a commit 2dca8f37e5d44802221abb4d6fd31ec51fb9921a Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Sat Mar 15 02:13:07 2014 +0100 misc/sysmobts_misc: function for switching off/on and requesting status power I have extended the principal function that we use for requesting information to the microcontroller for switching off/on the board and the PA. And I have extended it for requesting the power status information of the board and the PA. Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=4b614a0246ef3952407e86a89df7a437704275d1 commit 4b614a0246ef3952407e86a89df7a437704275d1 Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Wed Mar 12 18:35:37 2014 +0100 misc/sysmobts_mgr: Added new header created in the configure Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=bd267843623dcc7c757b8b2e2d8dad22121f0e14 commit bd267843623dcc7c757b8b2e2d8dad22121f0e14 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 12 16:54:19 2014 +0100 misc: Ignore some of the new configure and test files http://cgit.osmocom.org/osmo-trx/commit/?id=4e3aa9368195110f4de1791587f309846a3c5941 commit 4e3aa9368195110f4de1791587f309846a3c5941 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 12 16:51:27 2014 +0100 misc/sysmobts: Another small change to help in finding the header We could have a dedicated configure/cflag for the header files but for now search in the standard directories. http://cgit.osmocom.org/osmo-trx/commit/?id=06387d89e860978511ac5383a6c5a9837b103d1c commit 06387d89e860978511ac5383a6c5a9837b103d1c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Mar 12 16:40:07 2014 +0100 misc: Fix the build breakage now that we have btsconfig.h Include the btsconfig.h for the PACKAGE_VERSION variable. http://cgit.osmocom.org/osmo-trx/commit/?id=e030dfd443f50803835e6525265cdf6a378e334a commit e030dfd443f50803835e6525265cdf6a378e334a Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Wed Mar 12 16:19:59 2014 +0100 misc/sysmobts_misc.c: Read temperature from microcontroller Add function for requesting the temperature information to the microcontroller. I have added a function that we can extend for requesting more information but in this case we only need to know the temperature. I have added to a microcontroller temperature handling function in the manager for monitoring this information. Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=21104720f790eac667f73f012863a59ecbeb58d1 commit 21104720f790eac667f73f012863a59ecbeb58d1 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Mar 10 14:00:23 2014 +0100 agch: Remove obsolete comment Use of configuration variables has already been implemented here, so the TODO comment is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=b26b8fc77692e851469f3e27b9aeaeff233ffd2e commit b26b8fc77692e851469f3e27b9aeaeff233ffd2e Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Mar 4 15:03:59 2014 +0100 sysmobts: Do a RF mute at initialization when the RC is locked Currently a locked cell is actively broadcasting when it is being bootstrapped after the lock. This patch adds an initial update of the RF mute state when the TRX is initialized. Ticket: OW#1131 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=9c4a52444459819af9d72bb6a82954b8b06ff0ef commit 9c4a52444459819af9d72bb6a82954b8b06ff0ef Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 23 16:15:10 2014 +0100 handover,sysmobts: Handle handover in the sysmobts code When the lchan was activated for handover configure it to wait for a RACH burst. On release make sure to always release the RACH SAPI (in case it has been allocated). On the first frame inform handover.c about it and forward the received access burst to the handover layer. Using an E71 it was possible to make a handover for SDCCH and TCH/F from a nanoBTS but also from itself to itself. The vty commands of OpenBSC and the silent-call have been used for that. I didn't verify audio handling so far. http://cgit.osmocom.org/osmo-trx/commit/?id=bb76d816da905e8da5948b466f7a3d2b5aff30e8 commit bb76d816da905e8da5948b466f7a3d2b5aff30e8 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 23 16:06:26 2014 +0100 handover,sysmobts: Handle idle needed for preparation of rach handling http://cgit.osmocom.org/osmo-trx/commit/?id=cfce4d65f212de92a664f6400e38921ba70dcd36 commit cfce4d65f212de92a664f6400e38921ba70dcd36 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 23 16:02:09 2014 +0100 handover,sysmobts: Refactor the parsing/handling of the access delay http://cgit.osmocom.org/osmo-trx/commit/?id=00b4e064ffc4c4bb2863c1f8ce40e4e1e1bbbbff commit 00b4e064ffc4c4bb2863c1f8ce40e4e1e1bbbbff Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jan 23 16:12:04 2014 +0100 handover: Add generic handling for handover The BTS layer needs to inform the handover code when an access burst has been received. In turn the handover layer will ask the bts to modify the channel, it will schedule the physical information inform the BSC with the HANDOVER DETECTION and waits for the BTS layer to inform it about the first received frame to stop a timer. http://cgit.osmocom.org/osmo-trx/commit/?id=8ade45e795d1ee531423d529dfa2c441ece1196a commit 8ade45e795d1ee531423d529dfa2c441ece1196a Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jan 23 16:00:11 2014 +0100 handover: Set basic values for handover, remember the activation reason Introduce the handover.h/handover.c and initialize handover parameters in OML and remember the activation through RSL. http://cgit.osmocom.org/osmo-trx/commit/?id=3058854535f08e12f6d8dd4f35490ecef40b3040 commit 3058854535f08e12f6d8dd4f35490ecef40b3040 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jan 23 15:32:22 2014 +0100 handover: Implement generating HANDOVER DETECTION in rsl_tx_hando_det http://cgit.osmocom.org/osmo-trx/commit/?id=a37e239961010db751eb698971d57e22c0a12485 commit a37e239961010db751eb698971d57e22c0a12485 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jan 23 15:30:02 2014 +0100 handover: Introduce debug area for handover related items http://cgit.osmocom.org/osmo-trx/commit/?id=d863f9cbeaac2b16a226021bc9817e51550a3329 commit d863f9cbeaac2b16a226021bc9817e51550a3329 Merge: 20f5422 4fcda92 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Mar 10 13:33:26 2014 +0100 Merge branch 'jerlbeck/agch-queue' http://cgit.osmocom.org/osmo-trx/commit/?id=4fcda92d7be7dd2df1870156206fea30cd02d3cc commit 4fcda92d7be7dd2df1870156206fea30cd02d3cc Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Feb 20 18:45:45 2014 +0100 agch: Merge IMM.ASS.REJ if possible when enqueueing This patch implements merging of IMMEDIATE ASSIGN REJECT messages as suggested in GSM 08.58, 5.7. When a new IMM.ASS.REJ is to be appended to the AGCH queue and the last message in that queue is of the same type, the individual entries (up to 4 per message) of both messages are extracted, combined and stored back. If there are less than 5 entries, all entries fit into the old message and the new one is discarded. Otherwise, the old message will contain 4 entries and the remaining ones are stored into the new one which is then appended to the queue. Ticket: SYS#224 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=0148d4e7d537e745bb5c6dd014ff5582fc091caa commit 0148d4e7d537e745bb5c6dd014ff5582fc091caa Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Feb 20 13:10:01 2014 +0100 agch: Add VTY queue management configuration This patch adds the following VTY commands to tune AGCH queue handling: agch-queue-management default agch-queue-management threshold THRES low LOW high HIGH Examples: agch-queue-management default Resets queue management to default parameters. agch-queue-management threshold 0 low 25 high 75 Start dropping at 25%, drop all messages above 75% queue length (relative to max queue length corresponding to T3126). Between low and high, drop with a probability interpolated linearly between 0 (low) and 1 (high). agch-queue-management threshold 50 low 0 high 0 Start dropping at 50% and continue until all IMM.ASS.REJ have been removed from the front (output) of the queue Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=fae0149260f084c55fb943559a3ebd72fc96643f commit fae0149260f084c55fb943559a3ebd72fc96643f Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 14 21:15:31 2014 +0100 agch: Manage AGCH queue length Currently, the AGCH queue length is not limited. This can lead to large delays and network malfunction if there are many IMM.ASS.REJ messages. This patch adds two features: - Don't accept msgs from the RSL layer when the queue is way too full (safety measure, mainly if bts_ccch_copy_msg() is not being called by the L1 layer, currently hard coded to 1000 messages) - Selectively drop IMM.ASS.REJ from the queue output depending on the queue length Ticket: SYS#224 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=7503540959f421917a702174616655e9fdd11a24 commit 7503540959f421917a702174616655e9fdd11a24 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 14 14:18:51 2014 +0100 agch/pch: Use PCH for AGCH msgs This patch extends paging_gen_msg() by adding an output parameter is_empty that is true, if only a paging message with dummy entries has been placed into buffer. This feature is then used by bts_ccch_copy_msg() to insert an AGCH message if is_empty is true. Ticket: SYS#224 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=2d725e77f7270550d7173a7c86f30aa1c7b01e5e commit 2d725e77f7270550d7173a7c86f30aa1c7b01e5e Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 21 16:12:46 2014 +0100 agch/test: Add test for AGCH queue handling The first test checks the AGCH may queue length computation. The second test fills the queue by calling bts_agch_enqueue() with a mix of IMM.ASS and IMM.ASS.REJ. Then it drains the queue by calling bts_ccch_copy_msg(). After each of both steps, statistics are printed out. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=35a8144e41157b0a7304e7a0fd46a0e5a0dda287 commit 35a8144e41157b0a7304e7a0fd46a0e5a0dda287 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Feb 20 13:10:01 2014 +0100 agch: Add simple counters Counters are added for the following events (use VTY show to query): - Dropped IMMEDIATE ASSIGN REJECT messages - Merged IMMEDIATE ASSIGN REJECT messages - Rejected AGCH messages - Use of PCH (non-reserved) for AGCH messages - Use of AGCH (reserved) for AGCH messages Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=4fbe06b3f27c678c2cba7339dc1ea3754ec0609e commit 4fbe06b3f27c678c2cba7339dc1ea3754ec0609e Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 14 16:42:49 2014 +0100 agch: Recalculate length limit of AGCH queue This patch adds a function bts_update_agch_max_queue_length() to compute a limit of the AGCH queue. This is based on the idea, that the AGCH queue has a limited drain rate and that CHANNEL REQUESTs must be answered within a certain time frame, given by the minimum value of T3126 (see GSM 04.08). When the AGCH queue reaches that limit, the last message would be delivered in time if there were no other delays involved (which is not the case). The calculation is based on the ratio of the number RACH slots and CCCH blocks per time: Lmax = (T + 2*S) / R_RACH * R_CCCH where T3126_min = (T + 2*S) / R_RACH R_RACH is the RACH slot rate (e.g. RACHs per multiframe) R_CCCH is the CCCH block rate (same time base like R_RACH) The value depends control_channel_desc.ccch_conf and rach_control.tx_integer (both from SYSINFO_TYPE_3) and should therefore by called at least each time after one of these is changed. For this reason, a signal callback is registered under SS_GLOBAL/S_NEW_SYSINFO which invokes bts_update_agch_max_queue_length(). Sponsored-by: On-Waves ehf Based-On: "bts: Calculate length of agch queue" by Ivan Kluchnikov <kluchnikovi at gmail.com> http://cgit.osmocom.org/osmo-trx/commit/?id=20f542280330d1181d04ea34ef876358f710d6c8 commit 20f542280330d1181d04ea34ef876358f710d6c8 Author: Ãlvaro Neira Ayuso <anayuso at sysmocom.de> Date: Thu Feb 27 12:30:16 2014 +0100 src/misc/sysmobts_misc: Fixed wrong TEMP_PATH Before, this patch the program tried to read the info of the temperature sensor from a wrong location. Signed-off-by: Alvaro Neira Ayuso <anayuso at sysmocom.de> http://cgit.osmocom.org/osmo-trx/commit/?id=e5bda88c9d7ccfdd7941ba5270701e9f5449e348 commit e5bda88c9d7ccfdd7941ba5270701e9f5449e348 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Mar 3 16:28:53 2014 +0100 sysmobts: Do not generate RF Conn failure for CCCH and PDCH This could lead to a BSC attempting to release the BCCH or a PDCH. In the case of the BCCH this lead to a funny crash. Log: <0000> rsl.c:605 (bts=0,trx=0,ts=0,ss=4) Sending Connection Failure: cause = 0x01 <0000> rsl.c:1720 (bts=0,trx=0,ts=0,ss=0) Rx RSL DEACTIVATE_SACCH Backtrace: Program received signal SIGSEGV, Segmentation fault. msgb_dequeue (queue=0x4007d2d8) at msgb.c:102 102 llist_del(lh); (gdb) bt #0 msgb_dequeue (queue=0x4007d2d8) at msgb.c:102 #1 0x4002ed28 in lapd_dl_flush_tx (dl=0x4007d220) at lapd_core.c:173 #2 0x40030cb4 in lapd_dl_reset (dl=0x4007d220) at lapd_core.c:307 #3 0x40030d00 in lapd_dl_exit (dl=0x4007d220) at lapd_core.c:321 #4 0x40033d80 in lapdm_entity_exit (le=<optimized out>) at lapdm.c:169 #5 0x40033d9c in lapdm_channel_exit (lc=0x4007d214) at lapdm.c:180 #6 0x0001a334 in rsl_tx_rf_rel_ack (lchan=0x4007d180) at rsl.c:505 #7 0x0000e908 in lchan_deactivate_sapis (lchan=0x4007d180) at oml.c:1427 #8 sapi_queue_exeute (lchan=0x4007d180) at oml.c:547 #9 0x0000ead0 in sapi_queue_send (lchan=<optimized out>) at oml.c:571 #10 queue_sapi_command (lchan=<optimized out>, cmd=<optimized out>) at oml.c:609 #11 queue_sapi_command (lchan=0x4007d180, cmd=<optimized out>) at oml.c:601 #12 0x0000faf0 in enqueue_rel_marker (lchan=0x4007d180) at oml.c:1440 #13 lchan_deactivate (lchan=0x4007d180) at oml.c:1447 #14 0x0001004c in bts_model_rsl_chan_rel (lchan=<optimized out>) at oml.c:1647 #15 0x0001b948 in rsl_rx_rf_chan_rel (lchan=0x4007d180) at rsl.c:844 #16 rsl_rx_dchan (msg=0x75a88, trx=0x4007b038) at rsl.c:1727 #17 down_rsl (trx=0x4007b038, msg=0x75a88) at rsl.c:1853 #18 0x000154d4 in sign_link_cb (msg=<optimized out>) at abis.c:132 #19 0x400701c0 in ?? () from /usr/lib/libosmoabis.so.2 #20 0x400701c0 in ?? () from /usr/lib/libosmoabis.so.2 Backtrace stopped: previous frame identical to this frame (corrupt stack?) Fixes: OW#1133 http://cgit.osmocom.org/osmo-trx/commit/?id=5030972316892019a62423dfb9bd26ad158cda5a commit 5030972316892019a62423dfb9bd26ad158cda5a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Feb 24 13:51:30 2014 +0100 pcu: Avoid crash when closing the PCU socket When closing the PCU socket all channels will be closed. In that case the LAPDm structures might not have been allocated. Mark the channel as LCHAN_REL_ACT_PCU to avoid going through the RSL code for sending the message. This avoids a crash when "gprs none" is selected but one still configures a PDCH and then connects/disconnects the pcu. #0 llist_del (entry=0x0) at ../include/osmocom/core/linuxlist.h:119 #1 msgb_dequeue (queue=0x400bbc58) at msgb.c:102 #2 0x40110d28 in lapd_dl_flush_tx (dl=0x400bbba0) at lapd_core.c:173 #3 0x40112cb4 in lapd_dl_reset (dl=0x400bbba0) at lapd_core.c:307 #4 0x40112d00 in lapd_dl_exit (dl=0x400bbba0) at lapd_core.c:321 #5 0x40115d80 in lapdm_entity_exit (le=<optimized out>) at lapdm.c:169 #6 0x40115d9c in lapdm_channel_exit (lc=0x400bbb94) at lapdm.c:180 #7 0x0001a334 in rsl_tx_rf_rel_ack (lchan=0x400bbb00) at rsl.c:505 #8 0x0000e908 in lchan_deactivate_sapis (lchan=0x400bbb00) at oml.c:1427 #9 sapi_queue_exeute (lchan=0x400bbb00) at oml.c:547 #10 0x0000ead0 in sapi_queue_send (lchan=<optimized out>) at oml.c:571 #11 queue_sapi_command (lchan=<optimized out>, cmd=<optimized out>) at oml.c:609 #12 queue_sapi_command (lchan=0x400bbb00, cmd=<optimized out>) at oml.c:601 #13 0x0000faf0 in enqueue_rel_marker (lchan=0x400bbb00) at oml.c:1440 #14 lchan_deactivate (lchan=0x400bbb00) at oml.c:1447 #15 0x0001004c in bts_model_rsl_chan_rel (lchan=<optimized out>) at oml.c:1647 #16 0x0001de30 in pcu_sock_close (state=0x62788) at pcu_sock.c:654 #17 0x0001e150 in pcu_sock_read (bfd=0x627a8) at pcu_sock.c:698 #18 pcu_sock_cb (bfd=0x627a8, flags=1) at pcu_sock.c:755 http://cgit.osmocom.org/osmo-trx/commit/?id=fcd4026e7b48942e31d0efaa7f091e4ae50a8e1a commit fcd4026e7b48942e31d0efaa7f091e4ae50a8e1a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Feb 24 13:03:33 2014 +0100 Revert "bts/vty: Use new vty_install_default() function, adjust prompts" This reverts commit bbfd21a36cdd10c3b8d83a329042d9ebfb4c5250. http://cgit.osmocom.org/osmo-trx/commit/?id=f550a6a5748280e9c9841e7a56a0c99b022d84a8 commit f550a6a5748280e9c9841e7a56a0c99b022d84a8 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 21 15:09:13 2014 +0100 agch: Log error if BS_AG_BLKS_RES is != 1 in SI3 Currently, the DSP is always configured with u8NbrOfAgch = 1 before SYSINFO type 3 is received. Thus using a different value for BS_AG_BLKS_RES may lead to inconsistencies and MS failing to receive paging messages properly. This patch adds a warning and error logging and should be reverted when initialisation is done in proper order. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=d290ee029a827c870f97372b98f0dbd7d057402a commit d290ee029a827c870f97372b98f0dbd7d057402a Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 21 15:09:15 2014 +0100 agch/pch: Put CCCH message generation into common This patch adds a common function bts_ccch_copy_msg() that provides and schedules AGCH and PCH messages. It is basically a frontend to paging_gen_msg() and bts_agch_dequeue() and contains refactored code from l1_if.c. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=d242ec2ed909e58d8f3905b185a1b1e14806f7da commit d242ec2ed909e58d8f3905b185a1b1e14806f7da Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 21 15:09:14 2014 +0100 agch: Keep track of AGCH queue length This patch adds and updates btsb->agch_queue_length to keep track of the queue length. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=37c332e5bfdb9591a1cd3cc6746afffdb1cd13b9 commit 37c332e5bfdb9591a1cd3cc6746afffdb1cd13b9 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 21 15:09:12 2014 +0100 agch/rsl: Fix msgb handling for IMMEDIATE ASSIGN Currently, the msg->data pointer is just set to the IMMEDIATE ASSIGN message and the len is adjusted accordingly. Unfortunately, this leaves l2h (pointing to the RSL header) and l3h (pointing to the FULL_IMM_ASS_INFO IE) in an undefined state (outside of [data, tail]). The code in bts.c accesses the message via msg->data. This patch sets l3h and l2h correctly. msgb_l3() will point to the start of the IMM ASS message and should be used instead of msg->data. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=bbfd21a36cdd10c3b8d83a329042d9ebfb4c5250 commit bbfd21a36cdd10c3b8d83a329042d9ebfb4c5250 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 21 15:09:11 2014 +0100 bts/vty: Use new vty_install_default() function, adjust prompts This patch removes the local 'end' and 'exit' implementations (which aren't used anyway) and uses the generic ones provided by libosmocore instead, which are enabled automatically when vty_install_default() is used. The prompt strings are modified to match those in libosmocore/openbsc. Ticket: OW#952 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=4160e3d0f8de39954f107c03461e9594a61d4975 commit 4160e3d0f8de39954f107c03461e9594a61d4975 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Feb 20 10:48:35 2014 +0100 sysmobts: Remove debug left over from the SACCH fixes we made http://cgit.osmocom.org/osmo-trx/commit/?id=2755f6e5b42d67c34de84af0fb0b6641c4249317 commit 2755f6e5b42d67c34de84af0fb0b6641c4249317 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 23 15:10:05 2014 +0100 rsl: Do not allow IPA CRCX on non traffic channels Use 0x52 as error cause as the nanoBTS is doing the same under the situation. This has been spotted while testing handover using the VTY command for handover. http://cgit.osmocom.org/osmo-trx/commit/?id=572ed461b687809cae58596e2afcb66f8826779d commit 572ed461b687809cae58596e2afcb66f8826779d Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Feb 14 20:37:49 2014 +0100 rsl/si: Fix resetting bits in bts->si_valid Use 'var &= ~(1 << x)' to reset bits instead of 'var &= (1 << x)'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=1375a4b15316f2971dae284fff4ab6697c79621d commit 1375a4b15316f2971dae284fff4ab6697c79621d Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Feb 4 13:31:04 2014 +0100 systemd: Disable colors in the stdout log For journald we should not output escape sequences as it is confusing the output. http://cgit.osmocom.org/osmo-trx/commit/?id=f91799eecfbe03d9edd906b5834bf3f952359d0a commit f91799eecfbe03d9edd906b5834bf3f952359d0a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jan 28 16:11:30 2014 +0100 l1fwd-proxy: Bind to the bts VTY port to block another process Today we had the problem that multiple l1fwd-proxy instances ran at the same time and not everything working all the time (some packets were sent to a different host). Another approach is to use flock on the message queues. This appears to work fine as well. http://cgit.osmocom.org/osmo-trx/commit/?id=023739fc94af2be7e2f70f26dea92d9f0c250efb commit 023739fc94af2be7e2f70f26dea92d9f0c250efb Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jan 24 13:46:04 2014 +0100 sysmobts: Add the requested TA to the field ACCH header Write the requested timing advance into the header. We are currently using the u8AutoTA mode so the value will be overwritten by the DSP before the bursts are sent to the MS. http://cgit.osmocom.org/osmo-trx/commit/?id=1817447c24e3919981b253c4b9de32b2252844b4 commit 1817447c24e3919981b253c4b9de32b2252844b4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jan 24 13:39:14 2014 +0100 sysmobts: Correct sending of LAPDm frames on the SACCH When a frame is sent on the SACCH the LAPDm code will already prepend two bytes for the tx_power and the ta. In the BTS we want to use the values that were set by the BSC though. They currently come from the RSL CHAN ACT but could also be set through the RSL MS power control command. Update the comment as the space is not empty. At the 30C3 we had a NITB crash because of a RLL timeout on a TCH/F. Jacob analyzed the problem and tracked it down to the mismatch of LAPDm and the l1 interface to the DSP. http://cgit.osmocom.org/osmo-trx/commit/?id=2e93a8683ca5f644d365380ef55d657598af6c7f commit 2e93a8683ca5f644d365380ef55d657598af6c7f Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jan 23 17:09:10 2014 +0100 bts_model_rsl_chan_act(): Handle tp==NULL case gracefully The PCU may call this function without a valid 'tp' (tlv parsed) pointer, we need to make sure we take this into consideration... http://cgit.osmocom.org/osmo-trx/commit/?id=bc7d6fbdbb4413b3594e305cd4b0389ac78fb2cf commit bc7d6fbdbb4413b3594e305cd4b0389ac78fb2cf Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 19 15:08:18 2014 +0100 sysmoBTS OML: Don't permit TSC != BSIC The sysmoBTS L1 has the TSC as a global value, we cannot have individual per-timestamp or even per-lchan TSC, as the GSM specification would suggest (and other BTSs support). Rather than fail silently, write an error message to the log and return NM_NACK_PARAM_RANGE or RSL_ERR_SERV_OPT_UNIMPL back to the BSC. http://cgit.osmocom.org/osmo-trx/commit/?id=bc48e26fc91e0a24ec571904d1fab6dd351a5d48 commit bc48e26fc91e0a24ec571904d1fab6dd351a5d48 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 19 15:10:06 2014 +0100 common/rsl.c: Allow bts_model_rsl_chan_act() to return negative cause If the channel couldn't be activated, the function can simply return a negated RSL_ERR_* constant which will then be propagated towards the BSC in an CHAN_ACT_NACK RSL message. http://cgit.osmocom.org/osmo-trx/commit/?id=8196de46ad4886afd3e3c6068e491b8132c5c16f commit 8196de46ad4886afd3e3c6068e491b8132c5c16f Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jan 19 15:07:02 2014 +0100 common/oml.c: Send OML NACK if bts_model_check_oml() returns negative This way, bts_model_check_oml() can return a negated NM_NACK_* constant which will then be sent as cause value in the corresponding SET_ATTR_NACK back to the BSC. http://cgit.osmocom.org/osmo-trx/commit/?id=3c8ff3c70bc52d0a1d75a1e6b87b0069d92f10f9 commit 3c8ff3c70bc52d0a1d75a1e6b87b0069d92f10f9 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jan 21 23:02:13 2014 +0100 sysmobts: Specify TRX nominal maximum tx power as fMaxTxPower In the MPH ACTIVATE-RF.req, we need to specify the nominal maximum transmit power, i.e. >= what we later request during MPH-INIT.req. This field was first introduced in API version 2.2, but we never used it so far. It may help fixing a bug related to excessive power consumption of the sysmoBTS 2050. http://cgit.osmocom.org/osmo-trx/commit/?id=15bc64c6cd7d01be6c5e5aca2eca9e01ee4e099e commit 15bc64c6cd7d01be6c5e5aca2eca9e01ee4e099e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jan 21 18:07:28 2014 +0100 sysmobts: Honor the LDFLAGS when building the sysmobts-calib utility Address warning during system builds. Addresses: WARNING: QA Issue: No GNU_HASH in the elf binary... http://cgit.osmocom.org/osmo-trx/commit/?id=06c098e2cb368c5efdd770f293ca52a712f6221d commit 06c098e2cb368c5efdd770f293ca52a712f6221d Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jan 21 17:05:20 2014 +0100 sysmobts: Launch the sysmobts-mgr in the screen and add service file Launch the sysmobts-mgr as well. It will monitor the temperature but it will not update the eeprom or act on any of the data. On top of that it will respond to ipaccess-find messages making it more easy to find the device. http://cgit.osmocom.org/osmo-trx/commit/?id=d76211dc3b4cb1c58d3ca2ab28933a488091e950 commit d76211dc3b4cb1c58d3ca2ab28933a488091e950 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jan 17 17:59:12 2014 +0100 sysmobts-mgr: Check the return value of the sendto Fixes: Coverity CID 1157379 http://cgit.osmocom.org/osmo-trx/commit/?id=5899b2d3467e59463606edca9c7407126ebd3218 commit 5899b2d3467e59463606edca9c7407126ebd3218 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jan 17 08:33:29 2014 +0100 sysmobts-mgr: Respond to ipaccess-find broadcast messages Bind to port 3006 and listen to incoming IPA requests. Currently we unconditionally respond with the MAC and IP Address of the unit. To determine the IP Address the kernel is asked for thesource address of the route for the destination. In contrast to a nanoBTS we will reply to the port the initial request came from. http://cgit.osmocom.org/osmo-trx/commit/?id=1881e46cb9b7006ddaa66943bc95444766817abb commit 1881e46cb9b7006ddaa66943bc95444766817abb Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 16 14:06:45 2014 +0100 sysmobts-mgr: Parse the daemonize option Parse the daemonize option and daemonize after the full set-up of the code. http://cgit.osmocom.org/osmo-trx/commit/?id=810fbff380b6274bc739151a6dbe0be2bfde6ec3 commit 810fbff380b6274bc739151a6dbe0be2bfde6ec3 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 16 13:59:50 2014 +0100 sysmobts-mgr: Parse logging related commands, re-order init function http://cgit.osmocom.org/osmo-trx/commit/?id=19224b4b9b6767dedabfbcbcf41b9eab94b852f9 commit 19224b4b9b6767dedabfbcbcf41b9eab94b852f9 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jan 16 13:49:50 2014 +0100 sysmobts-mgr: Make it possible to not write to the EEPROM For testing/trial it is better to not write to the EEPROM but it is still good to see how the logic is working. http://cgit.osmocom.org/osmo-trx/commit/?id=3e110ae14101e60edc00803131165f11d4212db1 commit 3e110ae14101e60edc00803131165f11d4212db1 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Jan 15 11:59:28 2014 +0100 misc: Allow to cross-execute the testsuite using qemu When cross-compiling osmo-bts/osmo-pcu one can not easily execute the testsuite. By adding the OSMO_QEMU variable in front of the normal execution we can execute the tests. This should work for native and cross builds. $ OSMO_QEMU="qemu-arm -L /opt/poky/1.1.2/sysroots/armv5te-poky-linux-gnueabi/" make check http://cgit.osmocom.org/osmo-trx/commit/?id=a4ffc44eac2a6c9611bdc77a69c6e61ba3f3cf3f commit a4ffc44eac2a6c9611bdc77a69c6e61ba3f3cf3f Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jan 3 12:06:55 2014 +0100 sysmobts: Specify the parameters that can be read from the EEPROM When using the utility it is not clear which parameters can be read or written. Make that more obvious. http://cgit.osmocom.org/osmo-trx/commit/?id=c28a5b0b25f040429e9262a8a4997348ed129740 commit c28a5b0b25f040429e9262a8a4997348ed129740 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Dec 29 10:14:20 2013 +0100 sysmobts: Specify the constant as a float and not a double http://cgit.osmocom.org/osmo-trx/commit/?id=623d97a0d37480d89c7b987e3fe542083e3c7c66 commit 623d97a0d37480d89c7b987e3fe542083e3c7c66 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Dec 28 17:25:23 2013 +0100 tch: Do not log every single RTP packet and air frame The sysmoBTS takes quite a bit of CPU time for the vfprintf that is used by osmo_hexdump. Do not dump every single frame to improve the performance a bit. http://cgit.osmocom.org/osmo-trx/commit/?id=9c279945a18a14e1cc2614fc0f6b94937b909889 commit 9c279945a18a14e1cc2614fc0f6b94937b909889 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Dec 28 11:11:17 2013 +0100 misc: Avoid using double numbers on our ARM In the perf the ARM EABI ddiv operation showed up in the most of expensive symbols. It doesn't really make much sense as the calls should only be done on configuration. http://cgit.osmocom.org/osmo-trx/commit/?id=19e87d332f47acfa98f5c4a6646b3336008e45e7 commit 19e87d332f47acfa98f5c4a6646b3336008e45e7 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sat Dec 28 09:37:59 2013 +0100 measurement: Speculative performance change Most timeslots do not have eight lchan. Use the subslots_per_lchan map to reduce the number of iterations. Looking at the ARM assembly showed that no loop-unrolling was done so this could be a speed up. http://cgit.osmocom.org/osmo-trx/commit/?id=cdc6e3028ce0f84bd3a827d989096000cbd58d25 commit cdc6e3028ce0f84bd3a827d989096000cbd58d25 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Dec 20 11:28:13 2013 +0100 contrib: Remove the stray "FIVE" print it doesn't make any sense http://cgit.osmocom.org/osmo-trx/commit/?id=540f608c2cbb6d96f99c2c5b94ac9dfd5cda1c17 commit 540f608c2cbb6d96f99c2c5b94ac9dfd5cda1c17 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Dec 12 17:34:20 2013 +0100 sysmobts: Fix compiler warning by including utils.h calib_file.c: In function 'next_calib_file_idx': calib_file.c:126:3: warning: implicit declaration of function 'band_femto2osmo' [-Wimplicit-function-declaration] http://cgit.osmocom.org/osmo-trx/commit/?id=0a51e1a33795559ef6baf5cd2afce288b8f9eba7 commit 0a51e1a33795559ef6baf5cd2afce288b8f9eba7 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Dec 12 17:31:02 2013 +0100 sysmobts: Change the ARRAY_SIZE to a constant number The parameter "uint8_t mute_state[8]" is actually a "uint8_t *mute_state" so the ARRAY_SIZE is not what we think it is. Fixes: Coverity CID 1125885 http://cgit.osmocom.org/osmo-trx/commit/?id=ef852ae86eec6ce4fc9405299a53851ba0c9206e commit ef852ae86eec6ce4fc9405299a53851ba0c9206e Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Dec 12 17:28:52 2013 +0100 sysmobts: Fix resource leak in the error condition Fixes: Coverity CID 1047336 http://cgit.osmocom.org/osmo-trx/commit/?id=96264b6dd980faec5c9fe4264b46cff9e82b93b2 commit 96264b6dd980faec5c9fe4264b46cff9e82b93b2 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Dec 12 17:26:15 2013 +0100 sysmobts: Remove stray semicolon from the PCU band filtering code. The information from band_mask has never been used as the return was executed unconditionally. Fixes: Coverity CID 1113473 http://cgit.osmocom.org/osmo-trx/commit/?id=2800b347e9f08f77cfd69f81fc24e0141c21598a commit 2800b347e9f08f77cfd69f81fc24e0141c21598a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Nov 1 18:22:43 2013 +0100 bts: Fix crash of receiving data during the release process Release/Free the lapdm resources _after_ the channel has been fully released. Do not forward data unless the lchan is in the active state. Reading this code again, there is probably a memory leak for everytime the PCU will re-connect to the BTS. (gdb) p lchan->state $4 = LCHAN_S_REL_REQ (gdb) bt #0 lapd_dl_flush_hist (dl=0x40454894) at lapd_core.c:164 #1 0x44873b54 in lapd_rx_u (lctx=0xbe9bd5a8, msg=0x92f90) at lapd_core.c:1040 #2 lapd_ph_data_ind (msg=0x92f90, lctx=0xbe9bd5a8) at lapd_core.c:1644 #3 0x44876d50 in l2_ph_data_ind (link_id=<optimized out>, chan_nr=<optimized out>, le=<optimized out>, msg=0x92f90) at lapdm.c:637 #4 lapdm_phsap_up (oph=<optimized out>, le=<optimized out>) at lapdm.c:707 #5 0x0000c504 in handle_ph_data_ind (l1p_msg=0x97358, data_ind=0x97420, fl1=<optimized out>) at l1_if.c:774 #6 l1if_handle_ind (fl1=<optimized out>, msg=0x97358) at l1_if.c:892 http://cgit.osmocom.org/osmo-trx/commit/?id=f56d56c439034c8b8bc7eb0843ba5ee1cf2400e5 commit f56d56c439034c8b8bc7eb0843ba5ee1cf2400e5 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Nov 27 14:24:08 2013 +0100 sysmobts: Activate the BCCH silently have have state set to active Use the lchan->rel_act_kind field for the BCCH activatiob by OML. The lchan's should be marked as active but no event should be sent to the BSC. This is mostly like the PCU. We can now remove the secnd argument from lchan_activate. http://cgit.osmocom.org/osmo-trx/commit/?id=ed9d643036d159bcd6dca0d7af47e6691b572a8a commit ed9d643036d159bcd6dca0d7af47e6691b572a8a Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Nov 27 13:03:21 2013 +0100 sysmobts: Make the eeprom/nominal power reading backward compatible There are existing deployments where the EEPROM either contains a wrong value and/or the kernel can not be updated to support the different EEPROM of revD. Revert to the old behavior that if no nominal can be derived from the model_nr we assume that it is 23. http://cgit.osmocom.org/osmo-trx/commit/?id=e14ddaf204b353d5b5a14f555da419178163a189 commit e14ddaf204b353d5b5a14f555da419178163a189 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Nov 27 11:43:37 2013 +0100 sysmobts: Print the model number that is not supported. When using an old kernel on revD hardware we will read garabge from the EEPROM and it is nice for debugging to see which model number has been picked. http://cgit.osmocom.org/osmo-trx/commit/?id=e968c4224d2ee21731d0867671bd4133925cbff3 commit e968c4224d2ee21731d0867671bd4133925cbff3 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Nov 27 10:42:41 2013 +0100 bts: Fix typos in the log messages http://cgit.osmocom.org/osmo-trx/commit/?id=082e21dbb5226043a8d1e8374ebb8fecc57fdd26 commit 082e21dbb5226043a8d1e8374ebb8fecc57fdd26 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Nov 27 10:40:11 2013 +0100 bts: Fix a typo in the log message http://cgit.osmocom.org/osmo-trx/commit/?id=a82cc5321e841ab4ce17f1995a2cf7f2552a8217 commit a82cc5321e841ab4ce17f1995a2cf7f2552a8217 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Nov 14 10:39:08 2013 +0100 rsl: Rename abis_rsl_sendmsg to avoid symbol clash with libosmo-abis Nicolas ended up with linker issues due abis_rsl_sendmsg being defined twice. Rename our version of the function and update the code. Patched with: @i@ expression E; @@ - abis_rsl_sendmsg(E) + abis_bts_rsl_sendmsg(E) http://cgit.osmocom.org/osmo-trx/commit/?id=897f97f6329d46e21fc80ea4bb2dfbfc11cf8123 commit 897f97f6329d46e21fc80ea4bb2dfbfc11cf8123 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Nov 5 16:03:58 2013 +0100 sysmobts: Notify the BSC about all muted lchans Currently it takes some time (around 30s) until it is detected that the radio link is down after mute. Not till then the BSC is informed and the call terminated. This patch modifies this behaviour by sending a RSL_MT_CONN_FAIL message with cause RSL_ERR_RADIO_LINK_FAIL for each muted and active lchan immediately after the corresponding Change Administrative State Request has been acknowledged. Ticket: OW#976 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=5eef61414a4beb0ba3043bca88d42b6ba68d8c70 commit 5eef61414a4beb0ba3043bca88d42b6ba68d8c70 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Nov 5 13:42:59 2013 +0100 sysmobts: Only set RC state to LOCK if all channels are muted Currently only mute_state[0] (refers to ts[0]) is inspected to determine, whether the Radio Carrier's state is set to LOCK. This patch changes this by looking at all channels and using LOCK if (and only if) all channels have been muted successfully. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=5b69ec3e720d21753101c9a0e1a38d0926ba3854 commit 5b69ec3e720d21753101c9a0e1a38d0926ba3854 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Nov 4 18:13:52 2013 +0100 sysmobts: Use status flags instead of direct LED access Currently the LEDs are being accessed directly from within the l1_if.c file. So the handling of rf mute and activate/deactivate both access LED_RF_ACTIVE directly. This may lead to an inconsistent LED status. This patch replaces these calls to sysmobts_led_set() by an abstract equivalent bts_update_status(), that uses a set of independant status ids. The associated values can than be combined into a visible LED status. Currently LED_RF_ACTIVE is on iff BTS_STATUS_RF_ACTIVE is set and BTS_STATUS_RF_MUTE is not set. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=08571b158835df3db09cc94686a8fe62d1845cc9 commit 08571b158835df3db09cc94686a8fe62d1845cc9 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Nov 4 18:13:22 2013 +0100 sysmobts: Do a RF mute when Radio Carrier is locked Currently a Change Administrative State Request is just applied unconditionally to the object's state object and then acknowledged. This patch implements the special handling of setting the Radio Carriers state to LOCK or UNLOCK. This is done by passing the appropriate mute command to the L1 layer. Always all radio channels are affected, it is not possible to lock single radio channels. On success, an ACK is sent back to the bsc with the new state (based on the state passed in the callback by the L1 layer). If something went wrong or the firmware doesn't support RF mute, a NACK (REQ_NOT_GRANTED) is sent instead. Note that a NACK for such a request hasn't been sent by the BTS to the BSC yet, so (albeit it's spec conformant to do so) the BSC must be prepared to handle this correctly. Ticket: OW#976 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=9ef742f5e751c1d5fdfae14aa663e6056e6cac6f commit 9ef742f5e751c1d5fdfae14aa663e6056e6cac6f Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Nov 4 14:56:11 2013 +0100 sysmobts: Add L1 support for the new RF mute request This adds a new function l1if_mute_rf(femtol1_hdl, ch_mute[8]) to set the mute state for each radio channel. On completion and iff l1if_mute_rf() returned 0 the callback oml_mo_rf_lock_chg(mo, ch_mute_state[8], success) is invoked when the response from the superfemto DSP is received. Ticket: OW#976 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=f3108fafab3705752e21861a18c257c35e194c08 commit f3108fafab3705752e21861a18c257c35e194c08 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Nov 4 14:56:10 2013 +0100 sysmobts: Add mappings for MuteRfReq/MuteRfCnf This add the mappings for SuperFemto_PrimId_MuteRfReq and SuperFemto_PrimId_MuteRfCnf to the arrays femtobts_sysprim_type, femtobts_sysprim_names, and femtobts_sysprim_req2conf. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=0133ff386646bf8b29075502f233f2641d51255a commit 0133ff386646bf8b29075502f233f2641d51255a Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Nov 4 14:56:09 2013 +0100 sysmobts: Add L1P_T_INVALID to l1prim_type Currently uninitialized elements of the femtobts_sysprim_type array are mistaken as L1P_T_REQ (which is accidently the first element and thus 0). This patch adds a new element to the enum that has the value 0 to detect uninitialized elements of the femtobts_sysprim_type array. Those will then show up in the log as 'SYS Prim XXX is not a Request!'. This patch also adds missing definitions of the CalibTbl messages in the femtobts_sysprim_type mapping so that the requests can still be identified as such. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-trx/commit/?id=f9dd260ee56f4f71846ab155bfa6e4480e9793ca commit f9dd260ee56f4f71846ab155bfa6e4480e9793ca Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Oct 31 15:24:54 2013 +0100 pcu: Exit the PCU in case of loss of the sysmobts connection The PCU is not capable of cleaning up properly. For now simply exit the PCU in case the sysmobts has exited. This requires osmo-pcu a30f47613abb7c22a26d534d66e478265a8c2c09 or later. http://cgit.osmocom.org/osmo-trx/commit/?id=99fb43f41a47dbfc922ac6e447a603ddd96a0b2b commit 99fb43f41a47dbfc922ac6e447a603ddd96a0b2b Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 28 09:42:59 2013 +0100 sysmobts calibration: Load further tables even if one fails Even if one calibration table cannot be loaded, continue to try to load the other tables, instead of aborting very early. http://cgit.osmocom.org/osmo-trx/commit/?id=b8687024eac87d325056db55ff181da2ded8a310 commit b8687024eac87d325056db55ff181da2ded8a310 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 28 09:42:14 2013 +0100 sysmobts calibration: skip bands not supported by L1 If L1 tells us that a certain band is not supported, then there is no point in even trying to read+load calibration tables from EEPROM or files. http://cgit.osmocom.org/osmo-trx/commit/?id=501673fcf378a3b519875d6b4b77b1967038af24 commit 501673fcf378a3b519875d6b4b77b1967038af24 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Oct 28 09:41:29 2013 +0100 sysmbts calibration: print error if we fail to read from EEPROM http://cgit.osmocom.org/osmo-trx/commit/?id=6321c72522897b2e8df787a73441f699b5af28d9 commit 6321c72522897b2e8df787a73441f699b5af28d9 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Oct 25 18:32:16 2013 +0200 rsl/pcu: Do not send a CHAN ACT to the BSC on PCU usage The PCU is forcing the activation of a PDCH. Currently the BSC will receive a channel act ack for a channel that was not activated at all. Use the "release_reason" flag of the lchan to see if we have requested a normal activation or a silent one. It feels a bit odd to do it in the TX function but it is the most easy solution right now. I have added logging so it will not be totally silent. http://cgit.osmocom.org/osmo-trx/commit/?id=e851e134134b37113adc82d052bb5ba7e227797d commit e851e134134b37113adc82d052bb5ba7e227797d Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Oct 25 16:57:02 2013 +0200 lchan: Print the name of the channel already in release request http://cgit.osmocom.org/osmo-trx/commit/?id=d57e67e8da3726ba1caf787f639c7c0cfb9f8b09 commit d57e67e8da3726ba1caf787f639c7c0cfb9f8b09 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Oct 10 21:28:35 2013 +0200 sysmobts: Fix the unit test after the internal band changes http://cgit.osmocom.org/osmo-trx/commit/?id=ac3fc27257c16a74c524a1c070ce029d10ca7815 commit ac3fc27257c16a74c524a1c070ce029d10ca7815 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Oct 10 21:12:39 2013 +0200 sysmobts: Attempt to fix the compilation for the v1 hardware http://cgit.osmocom.org/osmo-trx/commit/?id=ad142f84b36e12aac834c90e9d98637b7768b15c commit ad142f84b36e12aac834c90e9d98637b7768b15c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Oct 10 21:07:04 2013 +0200 misc: Fix resource leak when the ioctl is failing Fixes: Coverity CID 1040759 http://cgit.osmocom.org/osmo-trx/commit/?id=b2a8a642d65779918f64437b5cbbde8e206222f2 commit b2a8a642d65779918f64437b5cbbde8e206222f2 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Oct 9 23:05:38 2013 +0200 sysmobts: Permit local override of transmit power above 23 dBm This is used in the sysmoBTS 2050, where the maximum power is 40 dBm We might want to add a safeguard of some kind to prevent people from overdriving their transmitters. http://cgit.osmocom.org/osmo-trx/commit/?id=5c0e7b1f2ce3fade6d53fe406c8c16960c480200 commit 5c0e7b1f2ce3fade6d53fe406c8c16960c480200 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Oct 9 22:35:46 2013 +0200 sysmobts: don't call sysmobts_get_nominal_power() twice ... no need for that http://cgit.osmocom.org/osmo-trx/commit/?id=e843f808328c51c32983c4f7a0a6b4d4b2a5525a commit e843f808328c51c32983c4f7a0a6b4d4b2a5525a Author: Harald Welte <laforge at gnumonks.org> Date: Wed Oct 9 21:02:40 2013 +0200 sysmobts: make L1 power configurable The TRX nominal output power (as seen by OML) is the aggregate power of any gain internal to the sysmoBTS (and managed by L1) and any external PA. This is what is used in trx->nominal_power; fl1h->l1_power is the transmit power to which we configure the sysmoBTS L1. This is 23 dBm (200mW) by default in the sysmoBTS 1002, and 40 dBm (5W) in the sysmoBTS 2050. However, if sysmoBTS 2050 is used in single-TRX configuration, it may be used with higher power, which we can now configure in the config file / vty. TODO: A separate, additional field that keeps track of any gain added by an external PA, e.g. if the sysmoBTS 1002 is used with a sysmoAMP. http://cgit.osmocom.org/osmo-trx/commit/?id=cfa54328e21a52813d0dc71c9d793704aa232f37 commit cfa54328e21a52813d0dc71c9d793704aa232f37 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Oct 9 16:06:41 2013 +0200 sysmobts: Don't use the clock calibration value on external clocks If the clock is provided by an external (like GPS) clock, we should not use the calibration value. The latter is only used in context of the OCXO or VCTCXO. http://cgit.osmocom.org/osmo-trx/commit/?id=50e63fa9e7e89b4966007d90d29b0e5ba88d988d commit 50e63fa9e7e89b4966007d90d29b0e5ba88d988d Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 5 18:10:09 2013 +0200 sysmobts: Set nominal transmit power depending on sysmoBTS model This enables the use of up to 5W for each TRX in a sysmoBTS 2050. http://cgit.osmocom.org/osmo-trx/commit/?id=19009f2d7ae805ca8037747934cb9c76f533022c commit 19009f2d7ae805ca8037747934cb9c76f533022c Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 5 17:16:20 2013 +0200 Do not attempt to initialize L1 with a band unsupported by hardware If the EEPROM tells us that a given unit doesn't support a given band, we shouldn't try to use it, even if the BSC tells us to use an ARFCN in such an unsupported band. The reason is simple: The given BTS unit might have band specific filter / duplexer / PA. http://cgit.osmocom.org/osmo-trx/commit/?id=de0ca823f10650328b40db9bf0ce3a287c004b27 commit de0ca823f10650328b40db9bf0ce3a287c004b27 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 5 17:00:40 2013 +0200 sysmobts: Read supported bands from EEPROM ...rather than assuming that any v2 hardware supports all bands. http://cgit.osmocom.org/osmo-trx/commit/?id=6d76c1c701dcfc9e0984750cec7ff04cdaa3c154 commit 6d76c1c701dcfc9e0984750cec7ff04cdaa3c154 Merge: b469e73 d92774b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Oct 6 15:51:56 2013 +0200 Merge branch 'shared/libosmo-abis-late-init' http://cgit.osmocom.org/osmo-trx/commit/?id=d92774b4ac9360235e822387a097dbcb886fbbed commit d92774b4ac9360235e822387a097dbcb886fbbed Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 30 21:19:27 2013 +0200 abis: delay l1if_reset() until OML link is established http://cgit.osmocom.org/osmo-trx/commit/?id=359fb8caf417570856ca61d6ff90df1fc452d659 commit 359fb8caf417570856ca61d6ff90df1fc452d659 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 30 15:27:10 2013 +0200 abis: Use OML remote (BSC) address if RSL CONNECT contains no IP This introduces a new get_signlink_remote_ip() function whcih we also use in the RSL code to determine the RTP remote address if the CRCX/MDCX contains no remote IP address IE. http://cgit.osmocom.org/osmo-trx/commit/?id=b77ae3bc601f9c70c6f9d41d70b063a769506322 commit b77ae3bc601f9c70c6f9d41d70b063a769506322 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Feb 10 13:38:02 2013 +0100 Call e1inp_vty_init() to make abis interface accessible from VTY It might not be particularly useful, but then there's no disadvantage either... http://cgit.osmocom.org/osmo-trx/commit/?id=6d5dc060ea333f372a0df45213936ca742e25176 commit 6d5dc060ea333f372a0df45213936ca742e25176 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Feb 10 10:21:12 2013 +0100 migrate away from our own abis.c code to libosmoabis libosmoabis has a BTS-side implementation of the IPA protocol for years, and osmo-bts should have used that all the time. Unfortunately it had its own local hack, this patch is migrating to the libosmocore implementation. http://cgit.osmocom.org/osmo-trx/commit/?id=b469e7314860794aebd904ebc4a63f877c01c3fc commit b469e7314860794aebd904ebc4a63f877c01c3fc Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 4 19:45:19 2013 +0200 Use GPS as default clock source on sysmoBTS 2050 http://cgit.osmocom.org/osmo-trx/commit/?id=33fe4ca97b25a9c58d89829dba791ca1ba8b5cdd commit 33fe4ca97b25a9c58d89829dba791ca1ba8b5cdd Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 4 18:29:54 2013 +0200 add sysmobts-util command-line utility to read/write EEPROM parameters http://cgit.osmocom.org/osmo-trx/commit/?id=870f1f1f84f0fa1a9f2e8154a04d06999d8b6a3a commit 870f1f1f84f0fa1a9f2e8154a04d06999d8b6a3a Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 4 18:29:25 2013 +0200 sysmobts_par: add value_string definitions for parameters http://cgit.osmocom.org/osmo-trx/commit/?id=7410bc30204bca34b35324f008e1339e82a8c194 commit 7410bc30204bca34b35324f008e1339e82a8c194 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 4 18:28:46 2013 +0200 sysmobts_par: Implement new EEPROM parameters (trx_nr, model_nr, model_flags) http://cgit.osmocom.org/osmo-trx/commit/?id=ff41a47c65958f00f159f7d74083f1ff6b190283 commit ff41a47c65958f00f159f7d74083f1ff6b190283 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 4 18:26:56 2013 +0200 sysmobts_par: support for negative parameters by splitting the rerutn code/status from the actual value, we support negative values to be stored in the EEPROM http://cgit.osmocom.org/osmo-trx/commit/?id=ad89cd978a220406a58e9a00562438d9eac2cf45 commit ad89cd978a220406a58e9a00562438d9eac2cf45 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Oct 4 18:24:34 2013 +0200 EEPROM: add model_nr, model_flags and trx_nr to EEPROM http://cgit.osmocom.org/osmo-trx/commit/?id=971a95d2599abf29e0dcdfd4215371361d42397c commit 971a95d2599abf29e0dcdfd4215371361d42397c Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 09:31:20 2013 +0100 Remove obsolete osmo-bts-bb code http://cgit.osmocom.org/osmo-trx/commit/?id=ac98b545a8c850bdaa16dc6e70d93d33f1cceaf4 commit ac98b545a8c850bdaa16dc6e70d93d33f1cceaf4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Fri Jul 26 21:23:40 2013 +0200 sysmobts-calib: For gps the sign/difference appears to be different For the sysmoBTS 2050 this appears to have a different sign. We can't test this with NWL right now so we will need to see if this is a case of ping/pong. http://cgit.osmocom.org/osmo-trx/commit/?id=ad10f0f533e6e702e03faffa5dd48a0044d224f3 commit ad10f0f533e6e702e03faffa5dd48a0044d224f3 Author: Nicolas J. Bouliane <nicolas.bouliane at nutaq.com> Date: Wed Jul 10 08:25:50 2013 -0400 sysmobts: Set the clock calibration to the value read from the eeprom By default read the clock calibration from the EEPROM. It is still possible to set it using the cli. Signed-off-by: Nicolas J. Bouliane <nicolas.bouliane at nutaq.com> http://cgit.osmocom.org/osmo-trx/commit/?id=fbf97e35ebf985eafcf79cc5db2598a7535108d4 commit fbf97e35ebf985eafcf79cc5db2598a7535108d4 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Jul 14 08:28:58 2013 +0200 calib: The call to fscanf can fail and we should check the return value Coverity wants us to check that fscanf has scanned the amount of variables we want to have. Initialize the scan result to 0/0.0f and warn if the scan has failed. Fixes: Coverity CID 1040774, CID 1040773 http://cgit.osmocom.org/osmo-trx/commit/?id=91d204e2db8f53a6ae4827ecc4b0ccb0137375d0 commit 91d204e2db8f53a6ae4827ecc4b0ccb0137375d0 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Jul 14 08:11:14 2013 +0200 eeprom: Check the return value of the fseek in all calls Coverity insists that we should check the return value of the calls to fseek. In general this is a good idea. Fixes: Coverity CID 1040770, CID 1040771, CID 1040772 http://cgit.osmocom.org/osmo-trx/commit/?id=f333387748898f9a896b771686a2b192c258f22d commit f333387748898f9a896b771686a2b192c258f22d Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Jul 14 08:05:15 2013 +0200 eeprom: After eeprom_write g_file could point to a closed file Calling eeprom_write would either re-use g_file or newly open the file and set g_file but it will close the file as well. This will lead to other code using fseek/fread on a closed file. On top of that the general rule for the eeprom code now is that read and write may not be mixed (due caching and other bits). http://cgit.osmocom.org/osmo-trx/commit/?id=95c6eed436ab7b0370ac1a4942b10926d3e256ab commit 95c6eed436ab7b0370ac1a4942b10926d3e256ab Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Sun Jul 14 08:01:16 2013 +0200 oml: Remove the unused nofh variable from oml_mo_tx_sw_act_rep The variable was assigned but nothing was done with it, just remove it for now. Fixes: Coverity CID 1040758 http://cgit.osmocom.org/osmo-trx/commit/?id=612f387fc93818877063dbd221803c9528f3413b commit 612f387fc93818877063dbd221803c9528f3413b Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Tue Jul 9 17:33:58 2013 +0200 rsl: Fix the audio handling after the 'alignment' handling fix The issue got introduced in fcdba6bfaca9e016f35fc9fa826948ec74f66121 when moving from the uint32_t pointer to a plain int. The code was now like this: if (connect_ip > 0) { if (connect_ip == 0) lookup_ip_based_on_rsl ... Coverity detected this as logically dead code and it was breaking audio handling for the osmo-bsc case. Remove the tristate handling, the RSL behavior is that leaving out port/ip is like specifying it as zero. Fixes: Coverity CID 1040769 http://cgit.osmocom.org/osmo-trx/commit/?id=ed966f0428065c758917e5255b5d0859cd5b99c5 commit ed966f0428065c758917e5255b5d0859cd5b99c5 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Jul 3 10:48:29 2013 +0200 sysmobts: The code allowed a out of bounds access to temp_type_str The array has three elements but check was for > _NUM_TEMP_TYPES (3) so an access at array[3] was possible. It is unlikely to have happened due the usage of enums. Use ARRAY_SIZE and >= on the real array to avoid this problem. Fixes: Coverity CID 1040760 http://cgit.osmocom.org/osmo-trx/commit/?id=481f14d87fad24a9b6c99df702904cf4219c9c8c commit 481f14d87fad24a9b6c99df702904cf4219c9c8c Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Jul 1 11:42:38 2013 +0200 sysmobts: Cache the eeprom_Cfg_t for reading tx/rx calib data The current code has 26 fseek/fread. Only the minority really results in a call to read. Nevertheless the time for reading during the bootstrap can take up to 7.82 seconds. Caching the header (which is already done by fopen/fread) will result in one call to fseek/fread and only consumes 0.784 seconds. http://cgit.osmocom.org/osmo-trx/commit/?id=89582f7e77068bc38fa9ee391f5c898913f241a7 commit 89582f7e77068bc38fa9ee391f5c898913f241a7 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Jul 1 10:51:26 2013 +0200 sysmobts: Add a method to free cached epprom resources Close the cached file descriptor once the calibration data is loaded and applied. http://cgit.osmocom.org/osmo-trx/commit/?id=270cf418fc64ad77b179f75394c5dc34c95f4388 commit 270cf418fc64ad77b179f75394c5dc34c95f4388 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Jul 1 10:26:05 2013 +0200 sysmobts: Read the mac and determine fixup only once during start http://cgit.osmocom.org/osmo-trx/commit/?id=eebdfb8e6f626f1f5e08353dab78cbe6d2ed1f5f commit eebdfb8e6f626f1f5e08353dab78cbe6d2ed1f5f Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Thu Jul 4 17:24:30 2013 +0200 sysmobts: Fix a typo that broke the ciphering with A5/0 > 0 Commit 564313066464197af58b02152c379e1c02336bcf by Daniel changed the ciphering to go through the command queue. In this commit the direction for the ciphering got turned around and was not spotted by review. It worked in testing due the usage of A5/0 and in that case the direction did not matter. http://cgit.osmocom.org/osmo-trx/commit/?id=2523cdbc7f03a1114e5cb8b17f6ce06f846d28ea commit 2523cdbc7f03a1114e5cb8b17f6ce06f846d28ea Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Mon Jul 1 09:27:14 2013 +0200 misc: Fix various warnings in the code sysmobts_vty.c: In function 'activate_lchan': sysmobts_vty.c:373:3: warning: implicit declaration of function 'lchan_activate' [-Wimplicit-function-declaration] sysmobts_vty.c:375:3: warning: implicit declaration of function 'lchan_deactivate' [-Wimplicit-function-declaration] eeprom.c: In function 'eeprom_ReadEthAddr': eeprom.c:305:5: warning: pointer targets in passing argument 3 of 'eeprom_read' differ in signedness [-Wpointer-sign] eeprom.c:260:12: note: expected 'char *' but argument is of type 'uint8_t *' http://cgit.osmocom.org/osmo-trx/commit/?id=6404a766617ba3dac02374b4e0d6cbc8b7b9770d commit 6404a766617ba3dac02374b4e0d6cbc8b7b9770d Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 30 15:29:26 2013 +0200 make oml_mo_state_init() a void function ... so we don't get warnings about not returning anything http://cgit.osmocom.org/osmo-trx/commit/?id=48eca2524cb960b4ea430e228fcb80be73a512f5 commit 48eca2524cb960b4ea430e228fcb80be73a512f5 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 30 15:05:09 2013 +0200 Don't send OML STATE CHANGE before OML is connected Instead of calling oml_mo_state_chg() [which transmits OML STATE CHG] during bts_init(), we use a new oml_mo_state_init() function which simply sets the state. http://cgit.osmocom.org/osmo-trx/commit/?id=0089ce417822d989778c8a5f362f402578873897 commit 0089ce417822d989778c8a5f362f402578873897 Author: Holger Hans Peter Freyther <holger at moiji-mobile.com> Date: Wed Jun 26 18:03:41 2013 +0200 sysmobts.service: Use multi-user.target as target to fix ordering http://cgit.osmocom.org/osmo-trx/commit/?id=123caa3c839e9badf4759c3be6253cbb5804ff56 commit 123caa3c839e9badf4759c3be6253cbb5804ff56 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jun 24 11:18:54 2013 +0200 calib: Attempt to fix the build for v2.7 of the api headers This should fix: calib_file.c: In function 'calib_eeprom_read': calib_file.c:262: error: 'SuperFemto_SetRxCalibTblReq_t' undeclared (first use in this function) calib_file.c:262: error: (Each undeclared identifier is reported only once calib_file.c:262: error: for each function it appears in.) http://cgit.osmocom.org/osmo-trx/commit/?id=593080ebab2a362230710e3b8e0558526cabd938 commit 593080ebab2a362230710e3b8e0558526cabd938 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jun 24 11:11:16 2013 +0200 calib: Attempt to fix the build for v2.7 of the api headers This should fix: calib_file.c: In function 'calib_fixup_rx': calib_file.c:148: error: 'SuperFemto_SetRxCalibTblReq_t' undeclared (first use in this function) calib_file.c:148: error: (Each undeclared identifier is reported only once http://cgit.osmocom.org/osmo-trx/commit/?id=f169a75fc41c2474bb0602d5f6b6401213f03633 commit f169a75fc41c2474bb0602d5f6b6401213f03633 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jun 20 17:18:38 2013 +0200 sysmobts: Introduce an auto-band config to ease DCS/DCS, PCS/PCS changes During development one switches from GSM900 to GSM1800 and GSM850 to GSM1900. This commit attempts to make this switch more easy. GSM1800 and GSM1900 have overlapping ARFCNs. This means that the mapping from bands to arfcn is not injective. Because of that I removed the code to deduce the band from the ARFCN. This was done in commit 8c3d807b3fc785ffb18aeb97355150c92221e8a0. The auto-band option allows to move between GSM900/GSM1800 and GSM850/GSM1900. Add a simple testcase with these auto-band configurations. http://cgit.osmocom.org/osmo-trx/commit/?id=43b4176f0e0e4d1e73463e9ff21a69e6e2848215 commit 43b4176f0e0e4d1e73463e9ff21a69e6e2848215 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jun 21 19:24:13 2013 +0200 sysmobts.service: Reset the firmware after the service exited These should have been ExecStopPost from the beginning. Currently they reset the firmware while the software is starting. Reload the DSP and FPGA firmware. http://cgit.osmocom.org/osmo-trx/commit/?id=266af543e3789130948bb357c15784e07784af42 commit 266af543e3789130948bb357c15784e07784af42 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 1 16:52:27 2013 +0200 sysmobts: Make sure we receive every SACCH frame to count S properly In case there is no transmitter the S counter might never be decreased. This means that no radio link timeout will not be sent and the lchan will remain open forever. There are several ways to resolve this. The first would be to use the MphTimeInd and after each multiframe check if there has been a SACCH message for the open lchan's. This could be similar to the trx_meas_check_compute. I decided to change fBFILevel to always receive SACCH frames and move the code down to the PDTCH/PACCH handling and update the comment. http://cgit.osmocom.org/osmo-trx/commit/?id=718cc9dcac1634d4d7313e4130fdf0343d5046dd commit 718cc9dcac1634d4d7313e4130fdf0343d5046dd Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 1 16:13:37 2013 +0200 sysmobts: Read multiple primitives at once but only up to 3 In most cases there are multiple messages ready to be read from the queue and it is more efficient to read them in one go instead of going through the select again. http://cgit.osmocom.org/osmo-trx/commit/?id=44eec601bc88a454a866ea6e5d9c2107752df040 commit 44eec601bc88a454a866ea6e5d9c2107752df040 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat May 4 11:30:18 2013 +0200 sysmobts: Use writev for the outgoing data of the write queue Attempt to write multiple primitives at the same time instead of the select/write, select/write that is currently done. The queue size is big enough to hold several entries at the same time and it is unlikely we get the -EAGAIN from the kernel driver. The writev code works by assuming that each element in the queue has the same size. This is not verified by the code and if this assumption breaks at some point the code will drop primitives or send some twice. http://cgit.osmocom.org/osmo-trx/commit/?id=25346fe0d7a8b83acdee8332bec921dbb254f016 commit 25346fe0d7a8b83acdee8332bec921dbb254f016 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 1 08:51:17 2013 +0200 sysmobts: Fix potential memory leaks in the prim callback handling Make sure the l1msg is always freed in the callback. There were several error conditions were the msgb would not have been freed, in the case of the calib data and the system information the message was not freed even in normal condition. I will modify this code to __use a msgb. This allows to re-use the allocated msgb across read operations. http://cgit.osmocom.org/osmo-trx/commit/?id=a7e75377767e86a3e5645c22239770b1939e9899 commit a7e75377767e86a3e5645c22239770b1939e9899 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 8 18:25:02 2013 +0200 lapd: Fix a +ptrsize memory leak for each opened lchan The lapdm/lapd_core code needs to keep a history of messages sent. This history is not freed when lapdm_channel_reset is called and the init code will just allocate a new array. This means there is a memory leak on every released channel every time it is released. http://cgit.osmocom.org/osmo-trx/commit/?id=ee43f46cb0334c75044c5ee706b7635c14c41a8c commit ee43f46cb0334c75044c5ee706b7635c14c41a8c Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jun 22 19:21:11 2013 +0200 calib: Fix for new EEPROM Mode; better log msgs http://cgit.osmocom.org/osmo-trx/commit/?id=40ca16766d3820385d26bb06856fdb5b94f9e33e commit 40ca16766d3820385d26bb06856fdb5b94f9e33e Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jun 22 18:41:11 2013 +0200 calib: Add fixup for incompatible calib data / firmware version For certain sysmoBTS units, a fixup to the calibration table is needed, if the firmware is >= 3.3.0. http://cgit.osmocom.org/osmo-trx/commit/?id=256326775781b6c46ebbe0ccf311e2d971b9de9a commit 256326775781b6c46ebbe0ccf311e2d971b9de9a Author: Harald Welte <laforge at gnumonks.org> Date: Mon Apr 15 22:28:11 2013 +0200 calib: Read calibration data from EEPROM, not just files On v2D (and later) hardware, the calibration data can be read directly from the EEPROM and doesn't have to be read from files. If there is no trx-calib-path set in the VTY, we will read from EEPROM. http://cgit.osmocom.org/osmo-trx/commit/?id=a899146aea402f28b7d8162560f75033e260da9b commit a899146aea402f28b7d8162560f75033e260da9b Author: Harald Welte <laforge at gnumonks.org> Date: Mon Apr 15 22:02:22 2013 +0200 eeprom: wrap DISP_ERROR #ifdef/endif in PERROR() macro This has the advantage that an user application might simply re-define the PERROR() macro rather than patching the code all over the place. http://cgit.osmocom.org/osmo-trx/commit/?id=6002d17c24e11997db89cd9bcbd2e0354f089459 commit 6002d17c24e11997db89cd9bcbd2e0354f089459 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Apr 15 21:50:51 2013 +0200 eeprom: cache the file descriptor instead of fopen/fclose all the time http://cgit.osmocom.org/osmo-trx/commit/?id=d675de9c235c5ed9b8b9cdb69666998bd0fb65ea commit d675de9c235c5ed9b8b9cdb69666998bd0fb65ea Author: Harald Welte <laforge at gnumonks.org> Date: Mon Apr 15 21:44:18 2013 +0200 initial import of EEPROM calibration read routines http://cgit.osmocom.org/osmo-trx/commit/?id=6ebabb560e9a7843715b8c14c9bedee5c0dc1ee2 commit 6ebabb560e9a7843715b8c14c9bedee5c0dc1ee2 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jun 20 17:46:27 2013 +0200 sysmobts: Do not write "trx-calibration-path (null)" in the config file When not specifying a config path, then saving the running config it would end up as "(null)" and then leads to an error like this: <0006> calib_file.c:147 Failed to open '(null)/calib_rxu_850.cfg' for calibration data. Add a NULL check to avoid this issue when writing the config file. http://cgit.osmocom.org/osmo-trx/commit/?id=d98f2f35ec7c4fd449323f970ffd8ede11b41038 commit d98f2f35ec7c4fd449323f970ffd8ede11b41038 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jun 20 17:24:32 2013 +0200 misc: Please ignore the commit. It is done to test a jenkins trigger http://cgit.osmocom.org/osmo-trx/commit/?id=fcdba6bfaca9e016f35fc9fa826948ec74f66121 commit fcdba6bfaca9e016f35fc9fa826948ec74f66121 Author: Nicolas J. Bouliane <nicolas.bouliane at nutaq.com> Date: Mon Apr 22 07:45:13 2013 -0400 rsl: fix the unaligned memory access the armv5 can do 32bit/16bit reads only from the aligned address use tlv.h macro to copy data to local variable Signed-off-by: Nicolas J. Bouliane <nicolas.bouliane at nutaq.com> http://cgit.osmocom.org/osmo-trx/commit/?id=19cefb009773f7cf5cf98997c53094dd684bcf38 commit 19cefb009773f7cf5cf98997c53094dd684bcf38 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 1 13:01:26 2013 +0200 sysmobts: Fix a crash when the DSP2ARM queue runs full When not reading quick enough from the queue we will get a bogus response which will lead to marking the lchan as broken and to clear the sapi queue. The sapi_queue_dispatch was checking if the queue was empty before calling the callback but not taking into account that it might have been flushed. Stop processing if the queue was empty before calling the callback or if it is empty after the callback. Backtrace: #0 0x4eb1f1cc in raise () from /lib/libc.so.6 #1 0x4eb22f48 in abort () from /lib/libc.so.6 #2 0x4ecc2cb8 in talloc_abort (reason=<optimized out>) at talloc.c:167 #3 0x4ecbc854 in talloc_abort_unknown_value () at talloc.c:180 #4 0x4ecc6bc8 in talloc_chunk_from_ptr (ptr=0x4ec2d494) at talloc.c:192 #5 _talloc_free (ptr=0x4ec2d494) at talloc.c:517 #6 talloc_free (ptr=0x4ec2d494) at talloc.c:990 #7 0x0000f294 in sapi_queue_exeute (lchan=0x402414a0) at oml.c:528 #8 0x0000f2d4 in sapi_queue_send (lchan=0x402414a0) at oml.c:542 #9 0x0000f3e0 in sapi_queue_dispatch (lchan=0x402414a0, status=-4) at oml.c:565 #10 0x000114d0 in lchan_deact_compl_cb (trx=0x4021e038, l1_msg=0x7e690) at oml.c:1269 #11 0x0000d70c in l1if_handle_l1prim (wq=1, fl1h=0x607c8, msg=0x7e690) at l1_if.c:938 http://cgit.osmocom.org/osmo-trx/commit/?id=d07ee75fc6a8b903ab926361fcea6259a1387444 commit d07ee75fc6a8b903ab926361fcea6259a1387444 Author: Alexander Huemer <alexander.huemer at xx.vu> Date: Tue Jun 11 14:33:06 2013 +0200 Makefile.am: Use AM_CPPFLAGS Since automake 1.13 INCLUDES is depricates and causes a warning http://cgit.osmocom.org/osmo-trx/commit/?id=c03fe5af31dcdd5fe144dc2c487249009b991ad1 commit c03fe5af31dcdd5fe144dc2c487249009b991ad1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri May 3 21:30:28 2013 +0200 sysmobts: Allow to enable realtime priority for the BTS process The latency to respond to a PH-READY_TO_SEND.ind may not be higher than 18ms. Currently we are using nice to increase our priority but for a heavily loaded cell this is not enough. Add an option to enable realtime scheduling and use it in the screenrc. Linux offers two realtime scheduling classes these are SCHED_FIFO and SCHED_RR. For SCHED_FIFO the process is running as long as possible (potentially taking all the CPU and never yielding it), for SCHED_RR the process can still be pre-empted at the end of the timeslice. Using SCHED_RR appears to be the more safe option as a run-a-way sysmobts process will not be able to take all the CPU time. For a very loaded cell we also require to use readv/writev to allow writing multiple primitives in one syscall. http://cgit.osmocom.org/osmo-trx/commit/?id=9be5f8c9c067f15ad3f49d8ba9d1db3b42ca1409 commit 9be5f8c9c067f15ad3f49d8ba9d1db3b42ca1409 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri May 3 21:23:33 2013 +0200 measurement: Mark the internal functions as internal In terms of assembly code this only removes the ".global FN" from the code. GCC does not attempt to inline it right now. http://cgit.osmocom.org/osmo-trx/commit/?id=0d194268fb454bc0d70f7fe5c278a70a65f0adea commit 0d194268fb454bc0d70f7fe5c278a70a65f0adea Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 1 08:36:19 2013 +0200 sysmobts: Use msgb_free instead of talloc_free to free the message Currently msgb_free is calling talloc_free but we might introduce a msgb pool in the future. So make sure to use the designated free method for the msgb. http://cgit.osmocom.org/osmo-trx/commit/?id=bd3250a456c48ae61f62d1c28f4a241ec79ff4b6 commit bd3250a456c48ae61f62d1c28f4a241ec79ff4b6 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed May 1 09:58:26 2013 +0200 sysmobts: Print the lchan name for the S counter. http://cgit.osmocom.org/osmo-trx/commit/?id=3a6220cae26c9f10d85519c7495ed6b30e6fbc54 commit 3a6220cae26c9f10d85519c7495ed6b30e6fbc54 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Apr 30 21:55:38 2013 +0200 rsl: Add the channel name to the act nack and conn fail message http://cgit.osmocom.org/osmo-trx/commit/?id=6a4c8a85967c54130f44e8339bf38b8dae1d2c6d commit 6a4c8a85967c54130f44e8339bf38b8dae1d2c6d Author: Nicolas J. Bouliane <nicolas.bouliane at nutaq.com> Date: Thu Apr 18 10:46:13 2013 -0400 osmo-bts: fix linking order in Makefile.am On some system (e.g. ubuntu) libosmovty must precede libosmocore otherwise we get undefined reference errors while linking. Signed-off-by: Nicolas J. Bouliane <nicolas.bouliane at nutaq.com> http://cgit.osmocom.org/osmo-trx/commit/?id=17dd79a3ae7df2426b9baeb14ccad7a1aa7e3aec commit 17dd79a3ae7df2426b9baeb14ccad7a1aa7e3aec Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Apr 7 11:53:16 2013 +0200 sysmobts.service: Install the sysmobts.service at the default target http://cgit.osmocom.org/osmo-trx/commit/?id=636cad95a7e1fe7fa79823b1ba3745b2f029e349 commit 636cad95a7e1fe7fa79823b1ba3745b2f029e349 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jan 30 09:29:52 2013 +0100 sysmobts: Document the known MphConfig conflict in the code Right now changing the TxPower through the VTY could conflict with a channel activation. http://cgit.osmocom.org/osmo-trx/commit/?id=0809ae69415d90c2777eec58bd2d5e3485e880fb commit 0809ae69415d90c2777eec58bd2d5e3485e880fb Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 25 18:55:50 2013 +0100 sysmobts: Do not re-configure the channel on non-active channels In case the channel is not active we can omit the external requests to modify it. For the channel modification the higher level is already acking it and for the ciphering it is probably too late to do anything. http://cgit.osmocom.org/osmo-trx/commit/?id=4c4fd284aec75ab8cc2f415a8a4491fd03a5a190 commit 4c4fd284aec75ab8cc2f415a8a4491fd03a5a190 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Jan 13 09:47:52 2013 +0100 oml: Use the queue for the release handling of a channel There are three new commands. There are two markers and a deactivate command. The markers are used to wait until all previous commands are executed and then to decide if the SAPI needs to be released at all. When asked to release the SACCH the marker will be queued, then on execution of the marker the SACCH in Up-/Downlink will be released. For the RF Channel Release we use another marker, when the marker is executed we check all the SAPIs we want to release. It is possible that the queue looks like this: (SACCH_REL_MARKER is done) REL_MARKER, SACCH DEACT, SACCH DEACT This could happen if a BSC sends SACCH Deactivate and RF Channel Release at the same time. We deal with issue by changing the SAPI state to the REL_REQ state and check_sapi_release will not ask for another release. So after the execution the queue will look like this: SACCH DEACT, FACCH DEACT, TCHF DEACT.. This code does not check that all allocated SAPIs are released. The lchan_deactivate_sapis could be changed to go through all sapis_dl and sapis_ul to fix that. The normal flow should now be: 1.) lchan_deactivate 2.) Check if the queue is empty then go to 4 3.) REL_MARKER is executed and lchan_deactivate_sapis is called 4.) For all SAPIs to be released, check if they are allocated and then schedule a CMD_DEACTIVATE. If there is an error remember something went wrong but continue. 5.) Once all commands are executed send the channel release ack. For the release markers we need to be careful as they might not schedule any work. E.g. if the BSC sends two SACCH DEACTIVATE the second marker will not generate any release requests and we should proceed with the next command. Make sapi_queue_command return 1 in case the command has been directly executed. So a queue like SACCH_REL_MARKER, LOGCH will result in LOGCH, SACCH DEACT Rx, SACCH DEACT Tx but a 0 will be returned and the sapi_queue_next will then call sapi_queue_exeute again. NITB has been modified to trigger these corner cases more easily. * Do not send IMM.ASSIGNMENT for some timeslots to go through the error path * Issue multile SACCH deactivates in the normal release mode * Send rsl_chan_mode_modify_req before the SACCH DEACT and also when the RLL is being released. http://cgit.osmocom.org/osmo-trx/commit/?id=42cc93efb667fae331a0e6221e864a9692139363 commit 42cc93efb667fae331a0e6221e864a9692139363 Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Fri Jan 4 00:14:11 2013 +0100 oml: Print out power setting in txpower completion callback http://cgit.osmocom.org/osmo-trx/commit/?id=4e46cb8961b7f6e4f62d29e332f18743a9144173 commit 4e46cb8961b7f6e4f62d29e332f18743a9144173 Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Thu Jan 3 23:35:12 2013 +0100 oml: Use sapi command queue for setting the logical channel params http://cgit.osmocom.org/osmo-trx/commit/?id=564313066464197af58b02152c379e1c02336bcf commit 564313066464197af58b02152c379e1c02336bcf Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Thu Jan 3 20:55:12 2013 +0100 oml: Enqueue ciphering message through sapi cmd queue as well http://cgit.osmocom.org/osmo-trx/commit/?id=376183fcf05c84a26e6ccb96d033ed569c84473c commit 376183fcf05c84a26e6ccb96d033ed569c84473c Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Thu Jan 3 17:37:59 2013 +0100 oml: Introduce a SAPI queue for activation and deactivation of SAPIs Put all SAPI requests into a queue and handle them one after another. Begin with the channel activation. Once the queue is empty the channel activate will be sent. For the BCCH activation we do not want to send a channel activation message and this is why we set the lchan->state to NONE. One change is that we do not attempt to call the ciphering routines on the BCCH anymore. This change is necessary to fix issues with LCHANs staying open and being marked as broken by the BSC and will help in implementing handover support as this requires a re-configuration of the lchan on the fly. http://cgit.osmocom.org/osmo-trx/commit/?id=fb0c9f06132769336ab2f01f6b01e369f48f3575 commit fb0c9f06132769336ab2f01f6b01e369f48f3575 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Jan 20 11:35:48 2013 +0100 measurement: Add debug helper when we have a report for an inactive channel http://cgit.osmocom.org/osmo-trx/commit/?id=9d91c60875548cb7e74b51a3d6bb0ec1b001a672 commit 9d91c60875548cb7e74b51a3d6bb0ec1b001a672 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jan 22 15:45:14 2013 +0100 sysmobts: Prepare to address the documented limitation of this code http://cgit.osmocom.org/osmo-trx/commit/?id=470a6ced9a76812127ce538f124ae41564fd10de commit 470a6ced9a76812127ce538f124ae41564fd10de Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 25 18:43:20 2013 +0100 oml: Only shut the bts down once If the shutdown timer is already running do not deactivate the RF and do not close the trx. This is addressing another instance of the following warning: [ERROR] : DeviceMng_ValidateL1Handle() => Invalid layer 1 handle http://cgit.osmocom.org/osmo-trx/commit/?id=118eb43ba52340f3bfaaf254e00bbd5c07681b57 commit 118eb43ba52340f3bfaaf254e00bbd5c07681b57 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Mar 18 16:29:46 2013 +0100 fixup e2cde1f48379657402332b5a95d4ce242d63069a http://cgit.osmocom.org/osmo-trx/commit/?id=cdc5a4dc384c91d5102376e08e3f34523e50b028 commit cdc5a4dc384c91d5102376e08e3f34523e50b028 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Mar 17 16:45:04 2013 +0100 Add VTY option to define minimum C/I level for RACH and normal burst http://cgit.osmocom.org/osmo-trx/commit/?id=5cbc7e91676a70bce1855ef2613c227baca8ef4f commit 5cbc7e91676a70bce1855ef2613c227baca8ef4f Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Mar 17 16:33:11 2013 +0100 Get RSSI from received uplink data and send to PCU This bumps the PCU API version and thus requires a new version of the code on the sysmoBTS side! http://cgit.osmocom.org/osmo-trx/commit/?id=4ad8d4d3c0e46fa50fe421c6957db1ea4b048b62 commit 4ad8d4d3c0e46fa50fe421c6957db1ea4b048b62 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Mar 16 23:18:23 2013 +0100 sysmobts: Name the screen and use '-X quit' to shut it down Use "kill -2 0" for the PCU as SIGTERM is not handled yet. With the current set of code the stop function will stop both the PCU and the BTS. http://cgit.osmocom.org/osmo-trx/commit/?id=e45fc8635926f70b0e19d5214f1f8b8fd06068aa commit e45fc8635926f70b0e19d5214f1f8b8fd06068aa Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Mar 16 00:24:24 2013 +0100 respawn: Adjust the oom score for the supervisor and bts/pcu, increase sleep Make the script mostly unkillable due to OOM and make sure that the process has a score of zero. Wait 10 seconds before re-launching. The combination of ( && exec ) & appears to save one sub-process. The script has been tested with bash and busybox's ash. http://cgit.osmocom.org/osmo-trx/commit/?id=54dd949e623d2f9535e30d450c198d15e5e98e91 commit 54dd949e623d2f9535e30d450c198d15e5e98e91 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Mar 14 11:38:11 2013 +0100 Fix: Stop RADIO LINK TIMEOUT couter S from counting, if it has reached 0 In case that the counter S reached 0, it will stay 0. Subsequent received good and bad SACCH frames must not cause to trigger radio link failure again. Once the BSC has been indicated about link failure, it will release channel. The counting of S has been moved to a seperate function. This patch will ensure that the link failure is indicated only once. But even if the link failure would be sent multiple times, the BSC should ignore it. The BSC releases the channel and may only reuse it after confirm from BTS. (There cannot be any link failure indications after confirm of channel release.) The allowed timeout value range is 4..64, as defined in TS 05.08, so if the BSC sends an attribute with value out of range or other failure criterion, the Set BTS Attributes message is NACKed. http://cgit.osmocom.org/osmo-trx/commit/?id=620be0bbed12763451ad1236283420664dbafa72 commit 620be0bbed12763451ad1236283420664dbafa72 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Mar 14 11:19:03 2013 +0100 OML: fix broken curly braces while parsing SET BTS ATTR Looking at the problem, it's a surprise that the old code was working at all... (Thanks to jolly for pointing this out) http://cgit.osmocom.org/osmo-trx/commit/?id=f0bdc1e5629778500fa06bde08bb90cb7b8c11cb commit f0bdc1e5629778500fa06bde08bb90cb7b8c11cb Author: Harald Welte <laforge at gnumonks.org> Date: Wed Mar 13 12:40:44 2013 +0100 RSL: Fix Channel Number IE in Common Channel RSL messages As per Chapter 9.3 of TS 08.58, we have to use RSL_IE_CHAN_NR instead of the zero we were implicitly using so far. http://cgit.osmocom.org/osmo-trx/commit/?id=294fd1b650e4482775fdd604288fc928e66ef81c commit 294fd1b650e4482775fdd604288fc928e66ef81c Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Feb 5 09:06:49 2013 +0100 Added radio link timeout procedure according to TS 05.08 Chapter 5.2 Chapter 5.2 applies to MS procedure, but 5.3 (BSS procedure) defines no exact criterion, so I decided to use the procedure equivalent to MS. The criterion is based on a counter S, which is initialized to a preset RADIO_LINK_TIMEOUT, which can be configured via VTY. Whenever a received SACCH block is bad, S is counted down by one. If SACCH block is successfully decoded, S is counted up by two, but never above initial RADIO_LINK_TIMEOUT value. If S reaches 0, an RSL Connection Failure Indication with cause RF Radio Link Failure is sent to BSC, which then aborts channel. Use link timeout value from BSC via OML attribute. How to test: - Set "debug" for "meas" logging. - Start silent call to an attached mobile. - Remove battery from mobile or shield mobile. - Watch S count down. http://cgit.osmocom.org/osmo-trx/commit/?id=19f212951af720bc5ad415d8347838f3ac222442 commit 19f212951af720bc5ad415d8347838f3ac222442 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Mar 7 10:07:18 2013 +0000 l1_if: if ul_power_target==0, hard-code MS power to what RSL says RSL CHAN ACT contains a MS_POWER IE which is intended to be used as the initial power level for the MS, before the UL power control loop is starting. In our case, if ul_power_target != 0, then the DSP takes care of power control. If ul_power_target == 0, then we instruct the phone to constantly use the value specified by the BSC in the MS_POWER IE. FIXME: Actually implement a proper power control algoritihm inside osmo-bts so we don't have to rely on the DSP implementation. http://cgit.osmocom.org/osmo-trx/commit/?id=cf4e3501a1620e8120b90acb3146772cdacaa8e6 commit cf4e3501a1620e8120b90acb3146772cdacaa8e6 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Mar 6 19:58:26 2013 +0000 gsmtap: Put the RxLevel and RxQual in uplink GSMTAP http://cgit.osmocom.org/osmo-trx/commit/?id=d9da7813a657dd40692efea9f27cd38f754d01f2 commit d9da7813a657dd40692efea9f27cd38f754d01f2 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Mar 2 18:12:22 2013 +0100 doc: Remove the rtp bind-ip from the example This option is not needed anymore, let's remove it. http://cgit.osmocom.org/osmo-trx/commit/?id=b7eb9865df3d66df446ec40e34432f2fbd6546fe commit b7eb9865df3d66df446ec40e34432f2fbd6546fe Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Dec 19 23:36:06 2012 +0100 calib: Use 2.4.0 as cut-off for the firmware, log errors In case opening a calibration file is failing an error will will be logged, the caller and implementation were inconsistent about the API version that is supported for the calibration data, attempt to make the cut-off at 2.4.0. http://cgit.osmocom.org/osmo-trx/commit/?id=dd2a51ed32959033cf965dfb243dd8fa44574f59 commit dd2a51ed32959033cf965dfb243dd8fa44574f59 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 25 11:22:25 2013 +0100 tests: Share the stub between the paging and ciphering tests http://cgit.osmocom.org/osmo-trx/commit/?id=faba73a81230db1e549aa43b6a5ee7902b45f919 commit faba73a81230db1e549aa43b6a5ee7902b45f919 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 25 11:07:12 2013 +0100 sysmobts: Improve the shutdown of the DSP on exit Issue the RfDeactivate.REQ before sending the MphClose.REQ. Ideally we would issue MphClose.REQ after the RfDeactivate.CNF but this is not possible right now. The current approach makes the following warning of the DSP go away on shutdown. This was tested with my E71 and an active silent-call using a SDCCH. DSP Warning: [ERROR] : DeviceMng_ValidateL1Handle() => Invalid layer 1 handle http://cgit.osmocom.org/osmo-trx/commit/?id=305d8314bce8f10d9c42aa8e19ccd7960fc5f194 commit 305d8314bce8f10d9c42aa8e19ccd7960fc5f194 Merge: dc9148d 5e46e4b Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Feb 27 09:41:30 2013 +0100 Merge branch 'zecke/request-queuing' * Simplify the callback signature. The trx is now the first argument. * Embed the calibration data into the femtol1_hdl. Tests: * All commits are compile tested * All commits bring up the radio (without using calibration data) * Calibration data loading has been tested with the merge * All commits allow a IMSI Attach and a MO Call (to an invalid unknown number). All channels are freed after this. It has been tested with the E71. http://cgit.osmocom.org/osmo-trx/commit/?id=5e46e4b4880f01eed508d49b66d96c1f7475ab89 commit 5e46e4b4880f01eed508d49b66d96c1f7475ab89 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jan 22 15:36:49 2013 +0100 sysmobts: Fix a memory leak when no callback is set The TxPower handled used to call the requestion function without a callback. In that case the msgb is leaked. The code still allows the callback to be NULL so we will just delete the message in that case. http://cgit.osmocom.org/osmo-trx/commit/?id=3d383c22c7d1d290e498c7db652e7d1888245e43 commit 3d383c22c7d1d290e498c7db652e7d1888245e43 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jan 22 15:22:55 2013 +0100 sysmobts: Remove the is_system_primitive from l1if_req_compl All users (but the gsm_compl) of the l1if_req_compl use it with is_system_primitive=1. We can now remove this parameter from the method. Introduce _l1if_req_compl that will insert the item into the queue for us. http://cgit.osmocom.org/osmo-trx/commit/?id=654fe73b78993c6e421162c8a7b41f009d7d2e40 commit 654fe73b78993c6e421162c8a7b41f009d7d2e40 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jan 22 07:37:41 2013 +0100 sysmobts: We can now pass the trx to the callback change the signatures http://cgit.osmocom.org/osmo-trx/commit/?id=6142f9262adf197d60a31ab4636ac0886dc32316 commit 6142f9262adf197d60a31ab4636ac0886dc32316 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 14:49:20 2013 +0100 sysmobts: Remove the trx parameter from the signature l1if_gsm_req_compl everyone is passing the trx as data pointer right now, remove it from the request procedure right now as it can be deducted from the femtol1_hdl. http://cgit.osmocom.org/osmo-trx/commit/?id=64c5e3a19c94c29331414da30e9d8eca81a70fce commit 64c5e3a19c94c29331414da30e9d8eca81a70fce Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 14:02:34 2013 +0100 sysmobts: Embed the calib state in the femtol1_hdl and use hdl->priv http://cgit.osmocom.org/osmo-trx/commit/?id=b6942ffeb9c5b742ca111a8c2b49a98e102da2fe commit b6942ffeb9c5b742ca111a8c2b49a98e102da2fe Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 12:39:24 2013 +0100 sysmobts: Use the hdl->priv in l1if_req_compl for all callers http://cgit.osmocom.org/osmo-trx/commit/?id=ff4f789249e9c26f268abd2e47f39627f4bbdd9d commit ff4f789249e9c26f268abd2e47f39627f4bbdd9d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 12:27:15 2013 +0100 sysmobts: Remove the data parameter from the l1if_gsm_req_compl Pass in the trx argument at the lower level as everyone is using the fl1h->priv now. http://cgit.osmocom.org/osmo-trx/commit/?id=0890e274b1a1e82907dfa56a4f4bb067d22dca4c commit 0890e274b1a1e82907dfa56a4f4bb067d22dca4c Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 12:16:47 2013 +0100 sysmobts: Use the fl1h->priv and get the ts back from the response http://cgit.osmocom.org/osmo-trx/commit/?id=60b090ac5377e29ff5f2dc50cd19e81189dbbd73 commit 60b090ac5377e29ff5f2dc50cd19e81189dbbd73 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 11:25:41 2013 +0100 sysmobts: Use the fl1h->priv to get the trx instead of using the lchan I am working toward killing the last argument of the l1if_gsm_req_compl and just have the trx inside the callback signature. http://cgit.osmocom.org/osmo-trx/commit/?id=dc9148d0351878a79d689a9c6f60aff21b9d5b81 commit dc9148d0351878a79d689a9c6f60aff21b9d5b81 Merge: 18708dd 1897f03 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Feb 13 17:19:19 2013 +0100 Merge branch 'zecke/calib-pch-agch-follow' Introduce bcch_ccch to scan the PCH on top of the BCCH. The AGCH is included in the PCH. CBCH/NCH are not included at this point. http://cgit.osmocom.org/osmo-trx/commit/?id=1897f03d4c854a0b74a92eb1f846ee1f0f81382b commit 1897f03d4c854a0b74a92eb1f846ee1f0f81382b Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Feb 5 23:59:46 2013 +0100 calib: Attempt to follow the PCH as well and print the SAPI.. AGCH is reported as part of the PCH because we are not searching for the BS-AG-BLKS-RES inside the SI3 and do not use MphConfigReq to change this setting. http://cgit.osmocom.org/osmo-trx/commit/?id=6ac2e684678a27f13966b7ae8d9937f43cb7adc9 commit 6ac2e684678a27f13966b7ae8d9937f43cb7adc9 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Feb 5 23:42:12 2013 +0100 calib: Print the frame number decoded as t1/t2/t3 http://cgit.osmocom.org/osmo-trx/commit/?id=225cf8229020e5474a5dc9824d012e50c2aa2ad8 commit 225cf8229020e5474a5dc9824d012e50c2aa2ad8 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Feb 5 23:36:05 2013 +0100 calib: Provide the fn and block number for each frame http://cgit.osmocom.org/osmo-trx/commit/?id=18708dd3b60fa27e6a7121b686f11ee8c8069a4b commit 18708dd3b60fa27e6a7121b686f11ee8c8069a4b Author: Harald Welte <laforge at gnumonks.org> Date: Sat Feb 9 14:17:01 2013 +0100 RSL: further rtp local bind related fixes If the CRCX does not indicate the remote IP address, then we still were binding to 0.0.0.0 and used that address successively in the CRCX_ACK. As a workaround, we now use the source IP address of the RTP socket, assuming that the outbound routes to BSC and the MGW are identical. This is of course not always true, but I don't think there are any better alternatives... http://cgit.osmocom.org/osmo-trx/commit/?id=98407bd457b88c1a26de2a9955de3de9846e4f68 commit 98407bd457b88c1a26de2a9955de3de9846e4f68 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Feb 9 11:44:07 2013 +0100 rsl: Fix compiler warning in use of osmo_rtp_get_bound_ip_port() for whatever reason i decided that a port number in osmo_rtp_get_bound_ip_port() needs to be a int * and not a uint16_t * at the time, so we have to deal with this here rather than breaking the ABI. http://cgit.osmocom.org/osmo-trx/commit/?id=0bb2974b370080b43282323364ebc6b0b6480803 commit 0bb2974b370080b43282323364ebc6b0b6480803 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Feb 9 11:38:30 2013 +0100 Fix determination of locally bound IP for RTP sockets After we create a socket and bind it to INADDR_ANY, we cannot yet use getsockname() to resolve the locally bound IP. This only works after the socket has been connected to the remote IP. So we have to move the osmo_rtp_get_bound_ip_port() to a code section after osmo_rtp_socket_connect() has already happened. With the code prior to this commit, unless "rtp bind-ip" was used in the config file, we reported "0.0.0.0" as the "Source IP AddresS" in the IPA CRCX ACK to the BSC. This is of course wrong, as the BSC will then use this "0.0.0.0" as destination address for the incoming RTP stream :( Please note that for this fix to work, you also need a libosmoabis.git with commit d426d458ca96ba29793e35b1b2a73fbcb3b2c888 which actually causes osmo_rtp_socket_connect() to actually issue connect() on the socket at all. http://cgit.osmocom.org/osmo-trx/commit/?id=550d22be5b2ddc376ccae937bd34c921dcf4a071 commit 550d22be5b2ddc376ccae937bd34c921dcf4a071 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Feb 3 16:35:07 2013 +0100 Deprecate the "rtp bind-ip" configuration directive Instead of explicitly having to specify the local IP address for RTP sockets in the BTS, we just use "0.0.0.0" instead, which gets translated to INADDR_ANY. We still accept the configuration directive in old config files, but when we write, the line will no longer be re-written to the file. TODO: IMHO, the IPA RSL CRCX/MDCX actually permit the BSC to specify the IP address on the BTS side, and we probably simply ignore this at this point. http://cgit.osmocom.org/osmo-trx/commit/?id=6a2d89f48d0727238eb2c14c7bfb4f0517d3be81 commit 6a2d89f48d0727238eb2c14c7bfb4f0517d3be81 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Feb 4 22:15:02 2013 +0100 Make sure SACCH fill frame is correctly aligned for L1 header When we send a fill frame on SACCH, we need to have two bytes for the L1 header at the beginning (inserted by the DSP). Thanks for Andreas Eversberg for pointing it out. http://cgit.osmocom.org/osmo-trx/commit/?id=3ff2fc437884cc12633f15e51f9d4ce1053c857b commit 3ff2fc437884cc12633f15e51f9d4ce1053c857b Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 25 16:00:20 2013 +0100 RSL: don't store MS power in lchan->bs_power but lchan->ms_power As we currently don't use any BSC-based MS power control in either OpenBSC nor in OsmoBTS, this bug has never shown up so far. Thanks to Andreas Eversberg for spotting this. http://cgit.osmocom.org/osmo-trx/commit/?id=bcd50d32195f0a73b95b6f21cdc58a548e4d6bdb commit bcd50d32195f0a73b95b6f21cdc58a548e4d6bdb Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Thu Jan 3 17:49:49 2013 +0100 oml: Create mph_send_activate_req for sending the activation request Move the channel activation out of the loop into a dedicated function. This is done in preparation of separating the decision to activate something and sending the request. http://cgit.osmocom.org/osmo-trx/commit/?id=f0c5a424af1a99d7d03a72eaa1ac6f87ea7b36c1 commit f0c5a424af1a99d7d03a72eaa1ac6f87ea7b36c1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jan 16 15:38:07 2013 +0100 sysmobts: Send GSM requests using the l1if_gsm_req_compl method Prepare to change the queue and callback handling. For the TX power VTY command it is still possible that it will conflict with other callbacks and the easiest way is to beging with sending these requests through another method that allows us a more strict test. http://cgit.osmocom.org/osmo-trx/commit/?id=76a1bf6136ce224b92c4192953d32d1efbebe9bc commit 76a1bf6136ce224b92c4192953d32d1efbebe9bc Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jan 16 13:30:56 2013 +0100 sysmobts: Help in calling the right callback for l1if_req_compl The wait list code has a limitation that for two requests of the same kind it does not know where the confirmation belongs to. This limitation is triggered when two lchan's get activated/deactivated at the same time and is noticed once we start to count the SAPIs. Set the hLayer3 to the lchan identifier, use the trx as closure for the callback and resolve the lchan in the callback using these two bits of information. http://cgit.osmocom.org/osmo-trx/commit/?id=e210f1a864b0752f5baeb14de8ddcfc7320007a4 commit e210f1a864b0752f5baeb14de8ddcfc7320007a4 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jan 16 13:44:19 2013 +0100 sysmobts: Rename the hLayer2<->lchan to hLayer<->lchan We are using this conversion for both hLayer2 and hLayer3. Make the function name more generic to indicate that this function can be used with the hLayer3. The functions that call the methods were updated using spatch and @rule1@ expression E; expression F; @@ - l1if_hLayer2_to_lchan(E, F) + l1if_hLayer_to_lchan(E, F) @rule2@ expression E; expression F; @@ - l1if_lchan_to_hLayer2(E) + l1if_lchan_to_hLayer(E) http://cgit.osmocom.org/osmo-trx/commit/?id=61e739912f22a4c6e4eca5ed7852bbc0077ba93e commit 61e739912f22a4c6e4eca5ed7852bbc0077ba93e Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jan 17 08:44:07 2013 +0100 sysmobts: Ignore too short messages on the FACCH (but also the SDCCH) During call testing using an E71 and dialing a number of an expired (lac set to 0) subscribe the CC Release and other messages are sent after or during the channel modification. This appears to lead to some reception issues in the DSP code and giving use empty (u8size == 0) FACCH frames. The real issue might be inside the MNCC code of NITB and the lack of a size check inside the LAPDm code (our msgb has enough data though). Passing the empty FACCH frame into the LAPDm code lead to the generation of RSL ERROR INDICATION with cause FRAME_UNIMPL as some bits were zero. Add a check for 0 into the FACCH code. As the code path is shared with SDCCH it is also discarding zero sized SDCCH frames. These have not been observed during my testing. The lacking size check in LAPDm will be addressed separately. During call testing the IPA CRCX was also failing due the BTS trying to bind to an unassigned IP address. http://cgit.osmocom.org/osmo-trx/commit/?id=4a303c7c38b322e5738a9492e077467bddfd3f38 commit 4a303c7c38b322e5738a9492e077467bddfd3f38 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 21 11:30:38 2013 +0100 oml: Fix memory leak in the callback http://cgit.osmocom.org/osmo-trx/commit/?id=8597a278d681e687920d62271559e8589781b1e4 commit 8597a278d681e687920d62271559e8589781b1e4 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jan 23 15:29:31 2013 +0100 l1_if: don't print measurements a second time in case of error http://cgit.osmocom.org/osmo-trx/commit/?id=6ddd632adf3905fc278d5dc9670ac77d860cb1d1 commit 6ddd632adf3905fc278d5dc9670ac77d860cb1d1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jan 17 08:41:40 2013 +0100 sysmobts: Use a newline at the end of the SACCH u8Size < 2 message The other message in this method is using a \n as well and the line is generally now followed with a LOGPC. It looked like this: <0006> l1_if.c:672 SACCH with size 0<2 !?!<0006> tch.c:540 (bts=0,trx=0,ts=2,ss=0) Rx Payload size 0 http://cgit.osmocom.org/osmo-trx/commit/?id=0903001d9b92d2bdc9cd275294299827bfe4e70d commit 0903001d9b92d2bdc9cd275294299827bfe4e70d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Jan 12 21:44:48 2013 +0100 calibration: The clock error is absolute for anything but the netlisten We only need to run this once and we know the clock error. In case it is 0/0 we know that we didn't receive one of the two clocks. This could be because the GPS doesn't have a fix. I accidently pushed this code into the master branch and it is too late to rebase. http://cgit.osmocom.org/osmo-trx/commit/?id=c2371cc0115ec8450324d0c687660a56b404dabd commit c2371cc0115ec8450324d0c687660a56b404dabd Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jan 15 18:57:59 2013 +0100 fix message: the PCU is not a call control application http://cgit.osmocom.org/osmo-trx/commit/?id=91816acfb8449379fa8003af4524c65ec36d37a7 commit 91816acfb8449379fa8003af4524c65ec36d37a7 Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Thu Jan 3 16:44:28 2013 +0100 paging: De-duplicate paging lifetime and max queue length variables These attributes are saved in paging_state, we don't need to save them a second time in struct gsm_bts_role_bts. Add get and set methods for these attributes and use them consitently in the VTY code. http://cgit.osmocom.org/osmo-trx/commit/?id=fad5b0862514ab4ef6d13fe0d5e4b39a2983e13c commit fad5b0862514ab4ef6d13fe0d5e4b39a2983e13c Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Jan 12 21:44:48 2013 +0100 WIP... use gps for calibration.. http://cgit.osmocom.org/osmo-trx/commit/?id=24b2128e2975f14f9941caa156890480005df81e commit 24b2128e2975f14f9941caa156890480005df81e Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jan 11 17:35:59 2013 +0100 add PCU respawning to contrib screenrc and respawn scripts http://cgit.osmocom.org/osmo-trx/commit/?id=3177f2b42f1565d47ee91c401773ff43114964da commit 3177f2b42f1565d47ee91c401773ff43114964da Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 29 22:14:08 2012 +0100 sysmobts: Fix the comment referring to the value of the timeout Right now it is 30 seconds and not 10. http://cgit.osmocom.org/osmo-trx/commit/?id=552989ad5762e051eb1a758bc61d8ce1d3c5e009 commit 552989ad5762e051eb1a758bc61d8ce1d3c5e009 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jan 1 21:20:54 2013 +0100 common: Fix faulty memcpy statement in the paging code This was experienced by Daniel on his 64bit machine. The paging expiration time was too high and not set by the code at all. Using gdb watchpoints he found the place where the memory is written. The issue is that the size of the pointer (8) and not the size of the data structure was copied (3). Fix the issue by assigning the de-referenced value. gcc generates the same code as if we had written: memcpy(&ps->chan_desc, chan_desc, sizeof(*chan_desc)); http://cgit.osmocom.org/osmo-trx/commit/?id=222a6a5e23a64b42f3ba1e2d80b425b11d3d36c0 commit 222a6a5e23a64b42f3ba1e2d80b425b11d3d36c0 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 29 12:23:09 2012 +0100 l1_if: Fix typo... call it femtobts http://cgit.osmocom.org/osmo-trx/commit/?id=0670138ffc651123944209572567d9c3c1874650 commit 0670138ffc651123944209572567d9c3c1874650 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Nov 25 22:51:10 2012 +0100 tch: Do not print that there is no audio data on a TCH/H When only signalling is used on the TCH/H it is normal that there is no TCH data. Save CPU time by not printing the message. This needs to be moved to be edge triggered. http://cgit.osmocom.org/osmo-trx/commit/?id=19cf0e81b336ead3c0a55d1c9d6722f986510bc0 commit 19cf0e81b336ead3c0a55d1c9d6722f986510bc0 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Dec 26 18:55:54 2012 +0100 ciphering: Handle ciphering support for A5/3 correctly This was found and debugged by Sylvain. The BTS will always support A5/0 so we do not keep track of that, the first bit of the flags is used for A5/1, second for A5/2... but for RSL there is an offset to go from RSL to A5(x). Add a testcase and change the code. http://cgit.osmocom.org/osmo-trx/commit/?id=5f408f934ca868ff209049bd92f3b0896a0eccac commit 5f408f934ca868ff209049bd92f3b0896a0eccac Author: Daniel Willmann <daniel at totalueberwachung.de> Date: Wed Dec 26 11:31:30 2012 +0100 tests: Don't delete atconfig in clean This file is created in ./configure so we shouldn't remove it with make. Otherwise ./configure && make clean && make check fails with: make[3]: *** No rule to make target `atconfig', needed by `check-local'. Stop. http://cgit.osmocom.org/osmo-trx/commit/?id=fc9920830e917dae858352d2b12c922a1da1f4d9 commit fc9920830e917dae858352d2b12c922a1da1f4d9 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 22 16:05:10 2012 +0100 misc: Package the configuration and contrib directory http://cgit.osmocom.org/osmo-trx/commit/?id=c559dde69dd66b8865ff23bf9d01cd5d37d7ff11 commit c559dde69dd66b8865ff23bf9d01cd5d37d7ff11 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 22 15:55:33 2012 +0100 misc: Package our version of the gsm_data.h to make the code compilable The sharing with OpenBSC is not complete yet. We will need to include our version of gsm_data.h instead of the normal OpenBSC version. http://cgit.osmocom.org/osmo-trx/commit/?id=3bcf3a5fd0a24bf6be176de5ed066afe1624fefe commit 3bcf3a5fd0a24bf6be176de5ed066afe1624fefe Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 22 15:03:19 2012 +0100 sysmobts: Add all header files to the EXTRA_DIST to fix make distcheck http://cgit.osmocom.org/osmo-trx/commit/?id=359b2cf46984c6ccc70d85959cb8a91f2c54a969 commit 359b2cf46984c6ccc70d85959cb8a91f2c54a969 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 22 14:59:12 2012 +0100 misc: Fix the make distcheck of the osmo-bts code * Comment out the osmo-bts-bb/Makefile as we have removed it from the SUBDIRS and are not packaging the code right now * Add missing include files for the build http://cgit.osmocom.org/osmo-trx/commit/?id=20c5702e0f0c5a7486e374728ed2693744c579c9 commit 20c5702e0f0c5a7486e374728ed2693744c579c9 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 22 14:44:00 2012 +0100 paging: Update the test output to make the test pass http://cgit.osmocom.org/osmo-trx/commit/?id=ce7559fbecc5e8ca248afe20b57c490d074deb4f commit ce7559fbecc5e8ca248afe20b57c490d074deb4f Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Dec 22 14:37:30 2012 +0100 misc: Fix compilation on debian stable with GCC 4.4.5 l1_transp_hw.c:89: error: redefinition of typedef 'dummyprim' l1_transp_hw.c:88: note: previous declaration of 'dummyprim' was here http://cgit.osmocom.org/osmo-trx/commit/?id=0d30b5d81863fb70c6270fe1ffefe4fd426b0cd3 commit 0d30b5d81863fb70c6270fe1ffefe4fd426b0cd3 Merge: d1ffab9 56698b8 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Dec 20 19:22:44 2012 +0100 Merge branch 'zecke/openbsc-incdir' Allow to have the OpenBSC directory somewhere else. This is required to build osmo-bts on the public jenkins installation. The default is the old behavior to look for OpenBSC next to the osmo-bts code. http://cgit.osmocom.org/osmo-trx/commit/?id=56698b84e0e0caa373c74df8e76b5f476aee1d9a commit 56698b84e0e0caa373c74df8e76b5f476aee1d9a Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Dec 20 00:21:38 2012 +0100 openbsc: Check for the presence of the gsm_data_shared.h header file http://cgit.osmocom.org/osmo-trx/commit/?id=db51f0d73efda28d4b83703d512cd7137beae9d8 commit db51f0d73efda28d4b83703d512cd7137beae9d8 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Dec 20 00:04:20 2012 +0100 openbsc: Introduce autoconf support to set the OpenBSC include directory Add autoconf support to set the path to the OpenBSC include directory so that openbsc/gsm_data_shared.h can be found there. http://cgit.osmocom.org/osmo-trx/commit/?id=bcae2abff8dfeaab75b1bbe58c7659285a721822 commit bcae2abff8dfeaab75b1bbe58c7659285a721822 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Dec 19 23:53:34 2012 +0100 openbsc: Prepare to allow to have the OpenBSC directory somewhere else Right now osmo-bts requires access to one OpenBSC header file and this requires that openbsc and osmo-bts git are in the same directory. Begin with making the location of the OpenBSC sourcecode configurable. This approach will allow to build osmo-bts on our Jenkins installation but now has the risk of more code including the openbsc/*.h header files. http://cgit.osmocom.org/osmo-trx/commit/?id=d1ffab96ca64111652fd850982ca00514b5b3531 commit d1ffab96ca64111652fd850982ca00514b5b3531 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Dec 19 23:29:31 2012 +0100 misc: Forward declare calib_load to address a compiler warning http://cgit.osmocom.org/osmo-trx/commit/?id=61a1f996801cf682a4f4c508dea2b83aa6d4ddbf commit 61a1f996801cf682a4f4c508dea2b83aa6d4ddbf Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Dec 19 00:37:09 2012 +0100 misc: Forward declare l1if_set_ciphering to avoid a compiler warning http://cgit.osmocom.org/osmo-trx/commit/?id=4fd0a84cf8959e84ae306510c25178f88acd2b88 commit 4fd0a84cf8959e84ae306510c25178f88acd2b88 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Dec 19 00:00:42 2012 +0100 misc: Change the method to return void instead of int and garbage The method was not returning anything and the callers did not use the result. Change it to void for now. http://cgit.osmocom.org/osmo-trx/commit/?id=9bd5afa0146285e596f0c1172a6a4920a1c8597a commit 9bd5afa0146285e596f0c1172a6a4920a1c8597a Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Dec 18 23:58:27 2012 +0100 misc: Include pcu_if.h for pcu_tx_pag_req in rsl.c and make it const The rsl.c code was calling the paging request with a const pointer, change the signature to make the code const. http://cgit.osmocom.org/osmo-trx/commit/?id=8d8ff80890ef6538b0340311b1bb3fc58e9c7e8d commit 8d8ff80890ef6538b0340311b1bb3fc58e9c7e8d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Dec 18 23:58:00 2012 +0100 misc: Forward declare the load_timer_start to address compiler warning http://cgit.osmocom.org/osmo-trx/commit/?id=6f93861cfc161a0b3c5780ca61e4fe8fcdadb611 commit 6f93861cfc161a0b3c5780ca61e4fe8fcdadb611 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Dec 18 23:56:05 2012 +0100 misc: load_ind_period is uint8_t and 60*100 is bigger than that. Address the compiler warning and truncate the value by hand. http://cgit.osmocom.org/osmo-trx/commit/?id=6ae49691afc4dc067f9dfb6c4aa386ec05f3cc1c commit 6ae49691afc4dc067f9dfb6c4aa386ec05f3cc1c Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Nov 25 21:09:48 2012 +0100 sysmobts: Transmit the UI idle frame as a LAPDm Command When transmitting an idle frame the BTS should transmit it as a command and not a response. This is unbreaking the mobile application of osmocomBB. http://cgit.osmocom.org/osmo-trx/commit/?id=2bad1363e9acd340eff27bc0b3856ee6290c096c commit 2bad1363e9acd340eff27bc0b3856ee6290c096c Author: Harald Welte <laforge at gnumonks.org> Date: Tue Nov 13 05:20:47 2012 +0100 Add VTY configuration of paging queue size and lifetime of paging records This may be adding bells and whistles that nobody wants to touch, but at least for current analysis/optimiziation they are useful to have. Later on they should probably be removed again and/or obsoleted by OML messages for configuration of paging behaviour by the BSC. http://cgit.osmocom.org/osmo-trx/commit/?id=9858a7defe4aee4e3a2fd59b7b57d9026fd91d04 commit 9858a7defe4aee4e3a2fd59b7b57d9026fd91d04 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Nov 13 05:04:24 2012 +0100 paging: send CCCH load indications even if paging load below threshold This is mainly as OpenBSC is adjusting the amount of paging commands it sends based on this magic value 0xffff. http://cgit.osmocom.org/osmo-trx/commit/?id=a57fac59c6a25b2a18b879b5831973804200bf85 commit a57fac59c6a25b2a18b879b5831973804200bf85 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Nov 6 08:22:03 2012 +0100 Use tlvp_val16_unal() / tlvp_val32_unal() to align 16 and 32 bit values This is required for CPUs < armv6, to access 16 and 32 values at right memory locations. http://cgit.osmocom.org/osmo-trx/commit/?id=36e73dd7ed1479f5a8c21fb8d49656e2173256f6 commit 36e73dd7ed1479f5a8c21fb8d49656e2173256f6 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Nov 18 10:38:32 2012 +0100 Ensure osmo-bts builds agsainst sysmobts-v1 headers (again) http://cgit.osmocom.org/osmo-trx/commit/?id=17dd7fad72cdc80edc4b5d717c4267977cf0c1ba commit 17dd7fad72cdc80edc4b5d717c4267977cf0c1ba Author: Harald Welte <laforge at gnumonks.org> Date: Sat Nov 10 18:33:12 2012 +0100 VTY: print length/depth of paging queue in 'show bts' http://cgit.osmocom.org/osmo-trx/commit/?id=ce826f3fc4baa314b76b236f8bb60434663a3892 commit ce826f3fc4baa314b76b236f8bb60434663a3892 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Nov 10 18:15:35 2012 +0100 VTY: make target uplink Rx level VTY-configurable We used to have -75 dBm as the target value for the uplink receive level. Now this is configurable. The parameter is used as input into the power control loop that adjusts the MS transmit power in order to achieve the target rx value on the BTS Rx input. http://cgit.osmocom.org/osmo-trx/commit/?id=7350736054b045882efc5c6807af598c228fd678 commit 7350736054b045882efc5c6807af598c228fd678 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Nov 10 18:06:02 2012 +0100 l1_if: Dump measurement data in case we receive SACCH without data On the uplink SACCH, we should at least receive the two bytes SACCH uplink header from the phone. But sometimes we don't. Log this more verbosely. http://cgit.osmocom.org/osmo-trx/commit/?id=fffbfd98908cbe7a860656f62a12f8753e304d1a commit fffbfd98908cbe7a860656f62a12f8753e304d1a Author: Harald Welte <laforge at gnumonks.org> Date: Sat Nov 10 18:04:54 2012 +0100 l1_if: add 'log level' to dump_meas_res() function http://cgit.osmocom.org/osmo-trx/commit/?id=a066e334dd458d671f9c36fbc4fca57d4f9bc731 commit a066e334dd458d671f9c36fbc4fca57d4f9bc731 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Nov 10 18:02:13 2012 +0100 Measurement: Correctly report L1 SACCH uplink header in RSL For whatever reason, the order of fields in the L1 SACCH header is different from 04.04 (Um) and 08.58 (A-bis). Please note that it's not just a different bit order, but actually logically re-ordering the fields within the byte, while keeping the bit-order/-endian. We now correctly report the L1 transmit power up the stack. http://cgit.osmocom.org/osmo-trx/commit/?id=dd4b8a250723cb528deb7d2a2c242bc38641ecee commit dd4b8a250723cb528deb7d2a2c242bc38641ecee Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Nov 2 11:14:19 2012 +0100 systemd: Use realtime scheduling for the BTS to read msg queues We need to read the Layer1 message queues fast enough, switch on realtime processing for that. Move the firmware init after the process execution to have some time for the firmware to reload before the application sysmobts is restarted. http://cgit.osmocom.org/osmo-trx/commit/?id=d1335d878b34eb67d75a6f7ff22e305a573c827f commit d1335d878b34eb67d75a6f7ff22e305a573c827f Author: Harald Welte <laforge at gnumonks.org> Date: Sun Oct 28 10:58:41 2012 +0100 sysmobts: Add support for reading calibration tables 'trx-calibration-path' is the new VTY command indicating the path name where the calibration files can be found. Calibration is only implemented for SUPERFEMTO API version 2.4.0 or later. http://cgit.osmocom.org/osmo-trx/commit/?id=98a440427968d60163ccace88aa11763649eefa5 commit 98a440427968d60163ccace88aa11763649eefa5 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Oct 28 10:17:42 2012 +0100 l1_transp_fw: don't use printf() and dont print things twice http://cgit.osmocom.org/osmo-trx/commit/?id=5705cfaebcb5c06e3bf9c4a0d1946e09add43043 commit 5705cfaebcb5c06e3bf9c4a0d1946e09add43043 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Oct 28 10:01:21 2012 +0100 properly display the header file versions http://cgit.osmocom.org/osmo-trx/commit/?id=c3646a80a7167e02c273220d53b65fedcd0d05dc commit c3646a80a7167e02c273220d53b65fedcd0d05dc Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 27 21:44:18 2012 +0200 sysmobts: Add code to read calibration files ... and convert them to L1 primitives. The code is not yet used. http://cgit.osmocom.org/osmo-trx/commit/?id=8debeeeeeaaafebf25f703b1fa9dc730cdb4c833 commit 8debeeeeeaaafebf25f703b1fa9dc730cdb4c833 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Oct 27 18:06:03 2012 +0200 make it build against sysmobts v2 APO 0.1, 0.2, 1.0, 2.0, 2.1, 2.2, 2.4 and 3.0 http://cgit.osmocom.org/osmo-trx/commit/?id=255343db4b08e2a3d7488f41a0ab2cda71473836 commit 255343db4b08e2a3d7488f41a0ab2cda71473836 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Oct 22 04:55:47 2012 +0200 Fix: Remove Bad frame Indicator from PDCH blocks before sending via GSMTAP http://cgit.osmocom.org/osmo-trx/commit/?id=4fe622cf9c1beb0ba2aa3b492bf7e2b4d1cd4f73 commit 4fe622cf9c1beb0ba2aa3b492bf7e2b4d1cd4f73 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Oct 4 18:13:19 2012 +0200 OML: TA is a 8bit value, not 16bit ... as jolly correctly pointed out. http://cgit.osmocom.org/osmo-trx/commit/?id=4168d885cf7183e09a98590799ad26fb2f162d13 commit 4168d885cf7183e09a98590799ad26fb2f162d13 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Sep 27 07:55:20 2012 +0200 Fix: Set correct paging group for IMM.ASS on PCH http://cgit.osmocom.org/osmo-trx/commit/?id=c1ad2ac20f4066aacbbb8e6482a10fe64edddbbb commit c1ad2ac20f4066aacbbb8e6482a10fe64edddbbb Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Sep 27 07:42:36 2012 +0200 PCU: Add PCH confirm, raise PCU interface version to 4 The confirm is required, so PCU knows when an IMMEDIATE ASSIGN message has has been sent on PCH. The PCU will start packet flow after that confirm. http://cgit.osmocom.org/osmo-trx/commit/?id=0efca9a1f99462326aea321d1660723c8ff64db1 commit 0efca9a1f99462326aea321d1660723c8ff64db1 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Sep 27 07:34:13 2012 +0200 Set correct GSMTAP channel type for PDTCH/PACCH http://cgit.osmocom.org/osmo-trx/commit/?id=ef2cb5ab7f4b39ebf974083fe6c79bb415831549 commit ef2cb5ab7f4b39ebf974083fe6c79bb415831549 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Sep 20 15:27:35 2012 +0200 misc: Disable the color in the default setting When forwarding the log messages to logger or systemd the ansi escape sequence can confuse the app collecting the data. http://cgit.osmocom.org/osmo-trx/commit/?id=4d197c96d8ad80f1ea72be170ebcd233e6ba7c38 commit 4d197c96d8ad80f1ea72be170ebcd233e6ba7c38 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Sep 20 15:24:50 2012 +0200 systemd: Add a service for the sysmobts Migrate the LED and firmware reloading into a systemd service. This makes the respawn and screen obsolete as it will be done with systemd and the journal script. http://cgit.osmocom.org/osmo-trx/commit/?id=d127ddbfcc2ada125cd36bfad3245954f8940f4d commit d127ddbfcc2ada125cd36bfad3245954f8940f4d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Sep 13 19:46:18 2012 +0200 sysmobts: Fix the init script for systemd. The rcS file is not part of the lsb. There is little need to include this file. http://cgit.osmocom.org/osmo-trx/commit/?id=f91924bb18985f7daaeec7970dd7db948251a9b9 commit f91924bb18985f7daaeec7970dd7db948251a9b9 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Aug 17 12:40:52 2012 +0200 sysmobts VTY: update to new libosmocore libosmocore 40832fcfb58c8c97c66e098c5705352ac5beea8e and later contain the vty_cmd_string_from_valstr() function, so we shouldn't have a local / deprecated copy anymore. http://cgit.osmocom.org/osmo-trx/commit/?id=8c3d807b3fc785ffb18aeb97355150c92221e8a0 commit 8c3d807b3fc785ffb18aeb97355150c92221e8a0 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Aug 9 11:38:15 2012 +0200 sysmobts: Do not ignore the band configuration of the BTS. The band was derived from the ARFCN but this does not work for PCS1900/DCS1800 due overlapping ARFCNs. Use the already existing band configuration to select the band for the MphInitReq. The dsp firmware will complain if the band/arfcn do not match. http://cgit.osmocom.org/osmo-trx/commit/?id=7daa093df7f5f743e69d73778d695e2f31cec73e commit 7daa093df7f5f743e69d73778d695e2f31cec73e Author: Andreas Eversberg <jolly at eversberg.eu> Date: Tue Jul 24 09:33:35 2012 +0200 PCU: Removed -P option, so GPRS support is always enabled http://cgit.osmocom.org/osmo-trx/commit/?id=b86bf060d334b33628e192218915526a526ebe46 commit b86bf060d334b33628e192218915526a526ebe46 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jul 26 20:10:39 2012 +0200 sysmobts: Support older firmware on the RevB hardware For the firmware used on RevB the GsmL1_Prim_t was bigger than the femtobts control structure. Solve it by introducing a macro that will select the biggest size and use this macro. This is a follow up fix for 08fce19cfce84432fbf8293318486a96437a3427. http://cgit.osmocom.org/osmo-trx/commit/?id=fde8e6dc0c1b493f70c2ffdb5182afe8d426bd9e commit fde8e6dc0c1b493f70c2ffdb5182afe8d426bd9e Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 25 14:33:04 2012 +0200 vty: Remove TS_NODE and LCHAN_NODE as they are not used. http://cgit.osmocom.org/osmo-trx/commit/?id=a9dee426d7db74472288dedd5e4cf3ae299c2487 commit a9dee426d7db74472288dedd5e4cf3ae299c2487 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 25 14:16:51 2012 +0200 misc: Ignore some of the auto generated files http://cgit.osmocom.org/osmo-trx/commit/?id=d777a19bb804ae1a4268702da00d3138b028b386 commit d777a19bb804ae1a4268702da00d3138b028b386 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 25 14:14:05 2012 +0200 contrib: Add a python script to start sysmobts-remote and dump docs This starts sysmobts-remote and dumps the documentation about the VTY to the doc/ directory. $ ./contrib/dump_docs.py this writes doc/vty_reference.xml http://cgit.osmocom.org/osmo-trx/commit/?id=e5a04ea35dc6f8c0f7f19997f89f6bc96a54d605 commit e5a04ea35dc6f8c0f7f19997f89f6bc96a54d605 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 25 13:18:28 2012 +0200 vty: Document the gsmtap SAPI and the dsp trace flags parameters Introduce femtobts_tracef_docs with some more information about the traceflags, add parameters to the vty_cmd_string_from_valstr for specifying the separator, the suffix and if the name should be lowered. http://cgit.osmocom.org/osmo-trx/commit/?id=1c74191ff0c3cd8109ede4d8f3f38da0b34d2286 commit 1c74191ff0c3cd8109ede4d8f3f38da0b34d2286 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 25 13:15:34 2012 +0200 vty: Document parameters of the unit-id and the band selection http://cgit.osmocom.org/osmo-trx/commit/?id=93c087892c5e9039ed1a7b07addc12c7f84e7c08 commit 93c087892c5e9039ed1a7b07addc12c7f84e7c08 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 25 12:03:52 2012 +0200 tests: Use the right name for the struct (not that it matters) http://cgit.osmocom.org/osmo-trx/commit/?id=7c2427c020949c778f4a59443c16fae7b9e2d98e commit 7c2427c020949c778f4a59443c16fae7b9e2d98e Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 22 22:47:06 2012 +0200 l1_if: indicate against which api header files we were compiled http://cgit.osmocom.org/osmo-trx/commit/?id=678321d013c320c31a1820135f32cee63d0c0ae7 commit 678321d013c320c31a1820135f32cee63d0c0ae7 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 22 22:42:36 2012 +0200 determine (and use) the API version as indicated in the header files From our header files v2.4 onwards, we include some macros that allow us to do compile-time checks for the API header version. As older headers don't have those macros, we have to fall back to assume it will be v2.2 http://cgit.osmocom.org/osmo-trx/commit/?id=e729a3d595baf4f3fb9bf572840c698fe71ec072 commit e729a3d595baf4f3fb9bf572840c698fe71ec072 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 22 22:19:56 2012 +0200 add missing stub functions to ensure paging_test compiles FIXME: hlayer1 and l1if function calls are not acceptable in src/common ! http://cgit.osmocom.org/osmo-trx/commit/?id=1195148fc6d0259a2236cbc5908cbd9416a926f9 commit 1195148fc6d0259a2236cbc5908cbd9416a926f9 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Jul 20 18:14:34 2012 +0200 Send RR paging requests to PCU, in order to page on PACCH http://cgit.osmocom.org/osmo-trx/commit/?id=1ddb183736bad257b8e774c0d0ab1ff8f628b442 commit 1ddb183736bad257b8e774c0d0ab1ff8f628b442 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Fri Jul 20 16:47:56 2012 +0200 Enable direct access to PDTCH queue of DSP by PCU Use "-P -M" to enable PCU and direct access. http://cgit.osmocom.org/osmo-trx/commit/?id=c2d3e45571e75610a40669f0fa0efed7b6e65946 commit c2d3e45571e75610a40669f0fa0efed7b6e65946 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jul 20 15:28:19 2012 +0200 sysmobts: The array size for the clocksources has increased to 10. http://cgit.osmocom.org/osmo-trx/commit/?id=27baa4c3de6b24ec7e489972d0b1fb71b81d14dd commit 27baa4c3de6b24ec7e489972d0b1fb71b81d14dd Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jul 20 15:26:45 2012 +0200 sysmobts-calib: Add support for pre-production revb hardware The board version wasn't exposed in the revb DSP interface. http://cgit.osmocom.org/osmo-trx/commit/?id=b3eb6da2db33ff9548d1ead6ad849d5e7ead855b commit b3eb6da2db33ff9548d1ead6ad849d5e7ead855b Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jul 16 20:02:48 2012 +0200 misc: Quote the warning to avoid additional warning http://cgit.osmocom.org/osmo-trx/commit/?id=d40d4d6071eaffb16794fc88354939ff0b3dd973 commit d40d4d6071eaffb16794fc88354939ff0b3dd973 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jul 19 20:33:37 2012 +0200 Allow L1 forward proxy to provide all 4 queues to seperate applications Different applications can now connect to L1 forward proxy or access DSP directly, if they use different message queues. http://cgit.osmocom.org/osmo-trx/commit/?id=08fce19cfce84432fbf8293318486a96437a3427 commit 08fce19cfce84432fbf8293318486a96437a3427 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Thu Jul 19 20:29:56 2012 +0200 Allocate correct message size for L1 primitives This is required for using firmware v2.4 http://cgit.osmocom.org/osmo-trx/commit/?id=0390d54ade12f62759a79447b6f954e8e37ba9d2 commit 0390d54ade12f62759a79447b6f954e8e37ba9d2 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 16 18:50:55 2012 +0200 logging: Fixed order of logging categories in enum list The enum list must have the same order as the logging description structure. Otherwiese libosmocore will crash when writing loglevels at VTY. http://cgit.osmocom.org/osmo-trx/commit/?id=0c470759da426ad649a735918cf24afb610f9c2d commit 0c470759da426ad649a735918cf24afb610f9c2d Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 16 18:50:26 2012 +0200 PCU: Add verion number of PCU interface to PCU INFO IND message The client (PCU) can check if it is compiled with a different version. http://cgit.osmocom.org/osmo-trx/commit/?id=5a53eff4cb1ce11fa2ba1026dd52dce1e59a4b7b commit 5a53eff4cb1ce11fa2ba1026dd52dce1e59a4b7b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 16 18:48:55 2012 +0200 sysmobts L1: fix memory leaks for GPRS we have to hand off the PH-RTS.ind to the PCU interface _before_ we allocate a response msgb/primitive. http://cgit.osmocom.org/osmo-trx/commit/?id=990d1da8a4df2c8a2ec119eb3a7079c8a706f6fe commit 990d1da8a4df2c8a2ec119eb3a7079c8a706f6fe Author: Andreas Eversberg <jolly at eversberg.eu> Date: Mon Jul 16 18:48:37 2012 +0200 PCU interface: fix memory leaks in error paths http://cgit.osmocom.org/osmo-trx/commit/?id=65d4d5108a05b39241d3375cb95ed21c431da6d7 commit 65d4d5108a05b39241d3375cb95ed21c431da6d7 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 11 23:16:17 2012 +0200 calib: Create a new header file and move it. http://cgit.osmocom.org/osmo-trx/commit/?id=0cfefa0e120c51fb745b66b7a6915b140635f9b5 commit 0cfefa0e120c51fb745b66b7a6915b140635f9b5 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 11 23:14:10 2012 +0200 calib: Add code to change the BSIC/TSC before following the BCCH. http://cgit.osmocom.org/osmo-trx/commit/?id=4253150bab9b8671b749e2f5ec910d0cca119558 commit 4253150bab9b8671b749e2f5ec910d0cca119558 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Jul 11 22:11:13 2012 +0200 calib: Use base 16 encoding for the dsp trace flags http://cgit.osmocom.org/osmo-trx/commit/?id=38420fb9513db552d80629035ef4e92315e35b6d commit 38420fb9513db552d80629035ef4e92315e35b6d Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jul 11 01:31:28 2012 +0200 add new sysmobst-mgr daemon This daemon is taking care of counting the number of hours in operation and to watch the system temperature as determined by internal temperature sensors. Later, it will export an external interface for firmware reload, as well as a way to raise OML ALARMs in case of temperature issues or other problems. http://cgit.osmocom.org/osmo-trx/commit/?id=3696c6946d9b0e683093dd6e87d16629f236d4f9 commit 3696c6946d9b0e683093dd6e87d16629f236d4f9 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jul 11 01:26:32 2012 +0200 OML: add missing ntohs() for UL/DL_TBF_EXT Thanks to Andreas for spotting this. http://cgit.osmocom.org/osmo-trx/commit/?id=438a28714d4b20f83c28c03648af25b5e43f189a commit 438a28714d4b20f83c28c03648af25b5e43f189a Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jul 9 15:51:42 2012 +0200 l1_if: skip processing of measurement results on PDTCH In case of PDTCH, the PCU has to process measurements, not the BTS. http://cgit.osmocom.org/osmo-trx/commit/?id=c1368d4ebe49f8e01f1f5fff3bc3583cb5960c1d commit c1368d4ebe49f8e01f1f5fff3bc3583cb5960c1d Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 8 23:53:32 2012 +0200 PCU: remove german warnings from the code http://cgit.osmocom.org/osmo-trx/commit/?id=744f745d7a508605254afa8f78412ad410d153b0 commit 744f745d7a508605254afa8f78412ad410d153b0 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 20:50:02 2012 +0200 PCU: Add PCU socket interface to BTS. A special command line option "-P" is used to enable socket interface and signal available GPRS MO object to BSC. http://cgit.osmocom.org/osmo-trx/commit/?id=8169b0bd853c0d3a9e69b166f3a271556f84767f commit 8169b0bd853c0d3a9e69b166f3a271556f84767f Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 20:20:51 2012 +0200 Add BTS to list at the beginning of bts_init() During init process, signals might be sent. PCU receives these signals and requires that BTS instance is already in the list. http://cgit.osmocom.org/osmo-trx/commit/?id=07b37853a46eec034750de9db33ca84022129fb1 commit 07b37853a46eec034750de9db33ca84022129fb1 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 19:59:41 2012 +0200 PCU: Add PCU socket interface prototype header file http://cgit.osmocom.org/osmo-trx/commit/?id=bf2a18e623b8da65792d74e9cd31d2d9ecbbcb81 commit bf2a18e623b8da65792d74e9cd31d2d9ecbbcb81 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 19:41:41 2012 +0200 debug: Add new debugging class for PCU interface (DPCU) http://cgit.osmocom.org/osmo-trx/commit/?id=66f1fe15e964a341024f93954e8e283938bfbbca commit 66f1fe15e964a341024f93954e8e283938bfbbca Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 19:38:39 2012 +0200 signal: Add signals for setting/change of GPRS MO attributes http://cgit.osmocom.org/osmo-trx/commit/?id=07891a09080cdc4bc18295e4686a47ca25d2c49f commit 07891a09080cdc4bc18295e4686a47ca25d2c49f Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 18:55:45 2012 +0200 paging: Alow to store CCCH messages in paging records This is required for PCU to send IMMEDIATE ASSIGNMENT messages on PCH. A message in a paging record is sent only once. http://cgit.osmocom.org/osmo-trx/commit/?id=343cae60b68e46f9d4f6e07fe5ac131451f04692 commit 343cae60b68e46f9d4f6e07fe5ac131451f04692 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 18:48:58 2012 +0200 lchan: Activate PTCCH/PRACH/PDTCH/PACCH when activating PDCH http://cgit.osmocom.org/osmo-trx/commit/?id=ea15101896b8c8d61b1a0b00fc6816167b9e502b commit ea15101896b8c8d61b1a0b00fc6816167b9e502b Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 18:44:40 2012 +0200 Fixed check for RACH (random access) delay http://cgit.osmocom.org/osmo-trx/commit/?id=b57e17394befd74f1e3259ac8f3f5257022970e1 commit b57e17394befd74f1e3259ac8f3f5257022970e1 Author: Andreas Eversberg <jolly at eversberg.eu> Date: Sun Jul 8 18:03:04 2012 +0200 Fixes for handling of GPRS NSE/NSVC/CELL MO http://cgit.osmocom.org/osmo-trx/commit/?id=b19592f7134baeae1541e55b6efead887739291d commit b19592f7134baeae1541e55b6efead887739291d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jul 5 23:28:50 2012 +0200 paging: Update the unit test that would have caused the previous The unit test created and used the paging request in the same second and was passing because of that. Add a second test with a delay to force now to not be equal to the expiration time. http://cgit.osmocom.org/osmo-trx/commit/?id=cb7697074eb6b11b0a3d39794b85691491cfd131 commit cb7697074eb6b11b0a3d39794b85691491cfd131 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jul 5 23:15:02 2012 +0200 paging: Expire paging requests after the expiration time The paging needs to expire when the expiration time is smaller than the current time. http://cgit.osmocom.org/osmo-trx/commit/?id=71b216d99520b41ac899322703cd99f753a237d7 commit 71b216d99520b41ac899322703cd99f753a237d7 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 5 15:30:21 2012 +0200 l1_if: don't enable any GSMTAP by default the user has to explicitly enable it in the VTY http://cgit.osmocom.org/osmo-trx/commit/?id=d53ae2d0f1cf9d45119b449cd442ffbf937d101c commit d53ae2d0f1cf9d45119b449cd442ffbf937d101c Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 5 15:29:25 2012 +0200 sysmobts_vty: Fix setting GSMTAP sapi, as well as save/restore in cfg http://cgit.osmocom.org/osmo-trx/commit/?id=5f8a3149fe6a80e3aa73c4f99808d418f52e9f01 commit 5f8a3149fe6a80e3aa73c4f99808d418f52e9f01 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jul 2 21:53:32 2012 +0200 sysmobts: avoid sending duplicate RSL CHAN ACT ACK This is just an intermediary hack, until we get proper lchan manager threads... http://cgit.osmocom.org/osmo-trx/commit/?id=eda6c2636031eedfb701011a3882d4ca54228ad6 commit eda6c2636031eedfb701011a3882d4ca54228ad6 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jul 5 00:16:36 2012 +0200 calib: Add a mode to follow the BCCH of a given cell. http://cgit.osmocom.org/osmo-trx/commit/?id=6b561bb7ba5f10c5fd96542a7e42de2822352a67 commit 6b561bb7ba5f10c5fd96542a7e42de2822352a67 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jun 28 08:59:48 2012 +0200 Add 12.21 handling for GPRS NSE/NSVC/CELL MO We now bring the GPRS related MO up in DEPENDENCY state and parse the various NS, BSSGP and RLC parameters as set by the BSC via 12.21/OML. http://cgit.osmocom.org/osmo-trx/commit/?id=fa8014f181aecdf5bef554af8fc1a3d56587d6b4 commit fa8014f181aecdf5bef554af8fc1a3d56587d6b4 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jun 21 16:46:05 2012 +0200 make sure we don't send CCCH LOAD IND before we have an Abis link http://cgit.osmocom.org/osmo-trx/commit/?id=61fb64d252b8cb04dfa30c1f3bdbf2000443c178 commit 61fb64d252b8cb04dfa30c1f3bdbf2000443c178 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 18 22:16:37 2012 +0800 rsl: use correct headroom size for load indications http://cgit.osmocom.org/osmo-trx/commit/?id=54b8af0f6449a7854c751c37ea126c8ab6c678c1 commit 54b8af0f6449a7854c751c37ea126c8ab6c678c1 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jun 15 23:22:26 2012 +0800 use default value of 63 for maximum timing advance As the careful commitlog reader Andreas points out: When the BSC does not sent NM_ATT_MAX_TA, then it would be zero instead of the specified default value of 63. http://cgit.osmocom.org/osmo-trx/commit/?id=9fdefc6ffec37d8971692a00df39e9bc6d706bb1 commit 9fdefc6ffec37d8971692a00df39e9bc6d706bb1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jun 15 14:53:15 2012 +0200 respawn: The BTS should not be nice, make sure the BTS is the most favorable http://cgit.osmocom.org/osmo-trx/commit/?id=13e92be8bf2edae4fc2f5082361a3b0ae7b7434a commit 13e92be8bf2edae4fc2f5082361a3b0ae7b7434a Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jun 15 14:54:33 2012 +0800 Implement NM_ATT_MAX_TA in sysmobts backend http://cgit.osmocom.org/osmo-trx/commit/?id=e01a47aad4fd5489873dce815576a9fbb14a8cc6 commit e01a47aad4fd5489873dce815576a9fbb14a8cc6 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jun 15 11:17:15 2012 +0800 Update README and reflect that we now have CCCH LOAD IND http://cgit.osmocom.org/osmo-trx/commit/?id=babbbbf6ee39d748f967eed7dee8df628d2a70e8 commit babbbbf6ee39d748f967eed7dee8df628d2a70e8 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jun 15 11:15:11 2012 +0800 CCCH LOAD IND: Avoid divide-by-zero The total count of RACH or PCH slots should never be zero, as they constantly increment. However, just as a safeguard, we introduce an explicit handign to avoid divide-by-zero situations http://cgit.osmocom.org/osmo-trx/commit/?id=821bf067e408f649bed62f10683fd44b43c0d673 commit 821bf067e408f649bed62f10683fd44b43c0d673 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jun 15 11:07:03 2012 +0800 RSL: Add CCCH LOAD INDICATION for RACH We now count the total number of RACH slots, the number with rx level above the busy threshold, and the number of valid access bursts. This data is used to generate RSL CCCH LOAD INDICATION for the RACH. http://cgit.osmocom.org/osmo-trx/commit/?id=c882b85d8c867264a0fe038dfe34bf204f5e3f32 commit c882b85d8c867264a0fe038dfe34bf204f5e3f32 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jun 14 11:51:16 2012 +0800 system information: avoid modulo 0 / SIGFPE As Holger pointed out, it may well be the case that there are no system information messages to be sent at TC=4, and we should avoid a modulo by 0. I'm simply sending SI2 instead now, as it isn't forbidden to send it more often than the minimum at TC=2... http://cgit.osmocom.org/osmo-trx/commit/?id=565cf0d8ab15282e5f12d74e5e69baff514a6565 commit 565cf0d8ab15282e5f12d74e5e69baff514a6565 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 4 17:27:13 2012 +0200 attempt to make CCCH Load Indications for PCH work http://cgit.osmocom.org/osmo-trx/commit/?id=a540332df3de735f75a2959814190b6cbf3c6e4c commit a540332df3de735f75a2959814190b6cbf3c6e4c Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jun 12 18:12:46 2012 +0200 sysmobts-calib: Add a utility to calibrate the sysmobts v2 hardware It has been tested with the OCXO and the network listen mode of the firmware. For other sources we are not required to synchronize to the network and the tool needs to be adjusted. http://cgit.osmocom.org/osmo-trx/commit/?id=ad3e31dc4b9ee1063d9e633ca884315b5a5c9710 commit ad3e31dc4b9ee1063d9e633ca884315b5a5c9710 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jun 5 09:22:11 2012 +0200 sysmobts: The meaning of the clock value changed from v1 to v2 In v2 the calibration value is the clock error in ppb that needs to be compensated. Create a V2 specific implementation. Write the clock value unconditionally as it is initialized to 0 by default and not 0xffff. http://cgit.osmocom.org/osmo-trx/commit/?id=1c069cd0a0316567e56549c45db549383deadf57 commit 1c069cd0a0316567e56549c45db549383deadf57 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Jun 5 09:17:26 2012 +0200 sysmobts-v1: Fix compilation by using the right define http://cgit.osmocom.org/osmo-trx/commit/?id=0455e51cd528ba14b11248a7e722f0c05a7bc2eb commit 0455e51cd528ba14b11248a7e722f0c05a7bc2eb Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 3 11:47:42 2012 +0200 Use git-generated PACKAGE_VERSION in IPA IDTAG_SWVERSION We previously used to send the bogus string "0815" which was a hack from early development time, but is obviously not a generally useful idea. http://cgit.osmocom.org/osmo-trx/commit/?id=ad09615acbc9ca3e6804780ff5641448067613c1 commit ad09615acbc9ca3e6804780ff5641448067613c1 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 3 11:01:31 2012 +0200 add known limitations http://cgit.osmocom.org/osmo-trx/commit/?id=2100a2e16fb5b5221d6106991d8b4cae31f02ad6 commit 2100a2e16fb5b5221d6106991d8b4cae31f02ad6 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jun 3 07:25:46 2012 +0200 sysinfo: Make our SI scheduling more complete We now implement the fairly complex rules for schedulign of SI 2bis/2ter/2quater, 13 and 9 on TC=4 and TC=5 of the BCCH Norm. The patch is currently untested. http://cgit.osmocom.org/osmo-trx/commit/?id=c58968be02c1c0b1fdca5c5cb30c1b2b57cab069 commit c58968be02c1c0b1fdca5c5cb30c1b2b57cab069 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jun 2 22:20:58 2012 +0200 sysinfo: Schedule SI 2bis and 2ter In case we have neighbor cells in different bands, we should send those SI... http://cgit.osmocom.org/osmo-trx/commit/?id=799ea59c2feeb9fe7ea9e9c202376e973ffca711 commit 799ea59c2feeb9fe7ea9e9c202376e973ffca711 Author: Harald Welte <laforge at gnumonks.org> Date: Thu May 31 23:15:38 2012 +0200 sysmobts: set the RF ACTIVE LED when we bring RF up Once we get RF-ACTIVATE.conf from L1, we now enable the corresponding LED. We also switch it off on RF-DEACTIVATE.conf. We do _not_ switch it off when osmo-bts crashes or terminates before RF-DEACTIVATE.conf. The latter is intentional, as RF may very well still be active at that point. The re-spawning script will re-set the DSP and therby turn off the RF and then disable the LED. A better solution might be to do all this in the kernel driver for the DSP. http://cgit.osmocom.org/osmo-trx/commit/?id=700c645478249319dcf7e7e138c13dbbb9c04ba9 commit 700c645478249319dcf7e7e138c13dbbb9c04ba9 Author: Harald Welte <laforge at gnumonks.org> Date: Thu May 31 21:02:18 2012 +0200 add /var/lock/bts_rf_lock and /var/run/osmo-bts.pid for rf control an external application can create /var/lock/bts_rf_lock and then kill the pid in /var/run/osmo-bts.pid in order to shut down the BTS. Any re-spawning scripts will trigger, but osmo-bts will refuse to start up until /var/lock/bts_rf_lock is removed again. http://cgit.osmocom.org/osmo-trx/commit/?id=346e531222a38bd0399e1a17f8de4a9594538993 commit 346e531222a38bd0399e1a17f8de4a9594538993 Author: Harald Welte <laforge at gnumonks.org> Date: Thu May 31 20:58:57 2012 +0200 sysmobts: fix double-free if msgq cannot be opened http://cgit.osmocom.org/osmo-trx/commit/?id=b18f00f162e1b7b3f3583e151b8a2091932c8708 commit b18f00f162e1b7b3f3583e151b8a2091932c8708 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon May 14 22:27:18 2012 +0200 contrib: Re-load the firmware before restarting the main application More recent firmware appears to have issues even after a clean shutdown, make sure to fully reset the DSP before starting the BTS software. http://cgit.osmocom.org/osmo-trx/commit/?id=268c7f02fd83f05409a357796217274efc3c6c1b commit 268c7f02fd83f05409a357796217274efc3c6c1b Author: Harald Welte <laforge at gnumonks.org> Date: Sun May 13 15:25:27 2012 +0200 sysmobts l1: make sure to read messages of arbitrary size ... and warn if the size is not what we expect. This is required to work with sysmobts-v2 firmware >= v2.1, as the SuperFemto_Prim_t is now larger than the GsmL1_Prim_t. http://cgit.osmocom.org/osmo-trx/commit/?id=388b9d0a357fece464f8c6dc37ae06aacf175897 commit 388b9d0a357fece464f8c6dc37ae06aacf175897 Author: Harald Welte <laforge at gnumonks.org> Date: Sun May 13 14:16:28 2012 +0200 Adapt to L1 firmware/API version 2.1 http://cgit.osmocom.org/osmo-trx/commit/?id=9de1e9f914cfff62236649549b52b5d675966e3c commit 9de1e9f914cfff62236649549b52b5d675966e3c Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat May 12 08:48:50 2012 +0200 sysmobts: Document the values of the clock-source in the vty command We need to have a documentation for each possible value, add some simple ones for the available clock sources. http://cgit.osmocom.org/osmo-trx/commit/?id=7fe0838588f1a2bb4df7c078e00f8b7b67a9abed commit 7fe0838588f1a2bb4df7c078e00f8b7b67a9abed Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat May 12 08:38:00 2012 +0200 sysmobts: Save the clock-source to the config file Make the clock names lower case to match with the vty command. http://cgit.osmocom.org/osmo-trx/commit/?id=3af5426d7188e810d7ee2aacb2d7af22e1054665 commit 3af5426d7188e810d7ee2aacb2d7af22e1054665 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat May 12 08:37:38 2012 +0200 sysmobts: Add Network Listen as clock source for the bts http://cgit.osmocom.org/osmo-trx/commit/?id=e6ed814dc35c6c242eff23fc5e63563bcc12a53f commit e6ed814dc35c6c242eff23fc5e63563bcc12a53f Author: Harald Welte <laforge at gnumonks.org> Date: Sat May 5 14:44:29 2012 +0200 update the readme http://cgit.osmocom.org/osmo-trx/commit/?id=f7fd2e47986d5385de5e892037a9bd3b663c1085 commit f7fd2e47986d5385de5e892037a9bd3b663c1085 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Apr 28 17:02:26 2012 +0200 sysmo-bts: Use HW_SYSMOBTS_V1 to select the development hardware http://cgit.osmocom.org/osmo-trx/commit/?id=36a3b0d85b514b92052ac2f85d4afa53780304e5 commit 36a3b0d85b514b92052ac2f85d4afa53780304e5 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Apr 28 16:57:12 2012 +0200 sysmo-bts: Move the payload setting into a new method Make this code a bit easier to read by moving the payload setting into a new method. http://cgit.osmocom.org/osmo-trx/commit/?id=36179bbcdf9407bcc4c06f7608f28e0dfcc29861 commit 36179bbcdf9407bcc4c06f7608f28e0dfcc29861 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Apr 27 15:12:46 2012 +0200 RSL / SI: Make sure to have correct LAPDm header in SI5/SI6 on SACCH SI5/SI6 and other messages on SACCH need the C/R and the EA bit set in the LAPDm header. Most devices accept a broken header, but especially the Wavecom Q2686 responds with tons of RR STATUS messages if there is any invalid bit. http://cgit.osmocom.org/osmo-trx/commit/?id=227c57728a93f7b71b1ffc99d92b76fd013e4a66 commit 227c57728a93f7b71b1ffc99d92b76fd013e4a66 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 26 20:58:27 2012 +0200 fix the idle filling to comply with 04.06 5.4.2.3 (UI frame 0 byte len) We used to send some crap before, which most phones happily accepted but some (particularly the Wavecom Q2686) didn't really like at all. http://cgit.osmocom.org/osmo-trx/commit/?id=baa88d542c52ea0ea5fb301e82ac8c0931ef127d commit baa88d542c52ea0ea5fb301e82ac8c0931ef127d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Apr 20 10:40:15 2012 +0200 lchan: I forgot to handle TchH in my recent lchan fixes, add it to another place Harald fixed the issue for the activation by adding TchH, but this needs to be added for de-activation as well. http://cgit.osmocom.org/osmo-trx/commit/?id=d28b9940b9c033b4456380dff05bed8d4d4e88ce commit d28b9940b9c033b4456380dff05bed8d4d4e88ce Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 23:51:50 2012 +0200 sach_deact -> sacch_deact (follow spelling fix in openbsc) http://cgit.osmocom.org/osmo-trx/commit/?id=2b7aace0b5092d2a0e3d639bdc2760934105d3e1 commit 2b7aace0b5092d2a0e3d639bdc2760934105d3e1 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 22:29:07 2012 +0200 add vty-configurable loopback mode this allows the BTS to loop-back any incoming data on a TCH http://cgit.osmocom.org/osmo-trx/commit/?id=b1644b22d0786133b28f2af3bffa5f22ffe222d2 commit b1644b22d0786133b28f2af3bffa5f22ffe222d2 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 22:27:55 2012 +0200 Fix TCH/H channel activation after zecke's recent lchan fixes http://cgit.osmocom.org/osmo-trx/commit/?id=bcd08888f9efbfa7c3e401ac0fbbb339059ff4b1 commit bcd08888f9efbfa7c3e401ac0fbbb339059ff4b1 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 20:19:21 2012 +0200 add VTY command to manually alter transmit power this allows for quick manual tx power changes from the VTY, particularly useful in type approval or other measurements. http://cgit.osmocom.org/osmo-trx/commit/?id=9aa6d9496b4e0791c104ae711f0ccb7af7776e85 commit 9aa6d9496b4e0791c104ae711f0ccb7af7776e85 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 20:18:53 2012 +0200 l1_if: allow for l1prim or sysprim without a completion callback http://cgit.osmocom.org/osmo-trx/commit/?id=ff9e90492692228fad5cbd5044f4752dc7bec8b9 commit ff9e90492692228fad5cbd5044f4752dc7bec8b9 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 19:47:55 2012 +0200 fix VTY help strings related to TRX http://cgit.osmocom.org/osmo-trx/commit/?id=f19ee660963ba34a2ecad5f6fb5c44e89c9fb820 commit f19ee660963ba34a2ecad5f6fb5c44e89c9fb820 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 19:22:53 2012 +0200 add a VTY command for activating PDCH channels (in EGPRS mode) This allows us to do RF measurements (EDGE EVM and the like) even without having any PCU/RLC/MAC code as of now. To use it, configure PDCH type timeslots (e.g. TS 7) in the BSC and then use "trx 0 7 activate 0" to manually activate the PDTCH lchan on top of that timeslot. The BTS will now happily transmit EDGE/8PSK data. http://cgit.osmocom.org/osmo-trx/commit/?id=4301b09137925dc4f903c98608697491a7a0a600 commit 4301b09137925dc4f903c98608697491a7a0a600 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 17:22:38 2012 +0200 delete dead code http://cgit.osmocom.org/osmo-trx/commit/?id=f5a0a439e931113863ac3da54f309b1a9ce42d66 commit f5a0a439e931113863ac3da54f309b1a9ce42d66 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 10:06:00 2012 +0200 ciphering: Make sure to initialize lchan to no ciphering when activating The ciphering parameters in L1 are persistent accross MPH deactivate/activate, so we need to make sure to always initialize them cleanly at RSL CHAN ACT time. This has the added benefit that we can also activate channels that have encryption enabled from the very beginning (required for encrypted handover). http://cgit.osmocom.org/osmo-trx/commit/?id=bf91f06ecaffe311c821c705c98fd3287f343e34 commit bf91f06ecaffe311c821c705c98fd3287f343e34 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 09:50:02 2012 +0200 Improve logging of L1 MPH request by printing the direction where previously we would only see <0006> oml.c:931 (bts=0,trx=0,ts=1,ss=0) MPH-DEACTIVATE.req (FACCH/F) we now get <0006> oml.c:931 (bts=0,trx=0,ts=1,ss=0) MPH-DEACTIVATE.req (FACCH/F RxUL) to notice it is modifying the receive path in the uplink direction. http://cgit.osmocom.org/osmo-trx/commit/?id=b0150b7ad4610307308595d3fe1b28b31466e8de commit b0150b7ad4610307308595d3fe1b28b31466e8de Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 22:15:29 2012 +0200 lchan: Refuse to activate a non-idle lchan. http://cgit.osmocom.org/osmo-trx/commit/?id=d7718280c98cdd9a6da27fbbf90c171f49969279 commit d7718280c98cdd9a6da27fbbf90c171f49969279 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 23:09:18 2012 +0200 lchan: Send the ACT ACK/NACK after the Layer1 has handled act/deact Send the RSL ACT ACK/NACK after the Layer1 firmware has acked the activation/deactivation. In case the channel can not be activated we will send a NACK. In case the channel can not be deactivated we will send an ACK and the next time the channel is activated we will send a NACK. The release ack will be sent once the TxDownlink of the TCH/SDCCH is closed. Change the rsl_tx_chan_nack method to create a new msgb to be used by the hardware layer, change the return value to ask the caller to delete the msgb. http://cgit.osmocom.org/osmo-trx/commit/?id=1e2b3259b92de9885c882cd0291452d8b7ffbfed commit 1e2b3259b92de9885c882cd0291452d8b7ffbfed Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Apr 17 22:06:45 2012 +0200 lchan: Separate the Uplink/Downlink in activate/deactivate http://cgit.osmocom.org/osmo-trx/commit/?id=29e1fdd994e2ea8c8e7518cb1b979bb23ae23c8a commit 29e1fdd994e2ea8c8e7518cb1b979bb23ae23c8a Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Wed Apr 18 19:31:42 2012 +0200 lchan: Deactivate the SACCH only once, use the sach_deact flag for that Use the deact_sach (renamed to deact_sacch in master) to remember if the SACCH has been disabled. This should fix the case of lchan errors due releasing the lchan twice. http://cgit.osmocom.org/osmo-trx/commit/?id=af02387183acd5cd80d3183862c8a6a2ed8318d1 commit af02387183acd5cd80d3183862c8a6a2ed8318d1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 21:46:19 2012 +0200 lchan: rsl_tx_chan_nack will re-use the msgb, do not msgb_free Do not msgb_free the msg as it will be re-used inside the nack method and return 1 so the caller does not free the msgb. This ownership model needs some consideration but the usage of ref counts will not yield good results. http://cgit.osmocom.org/osmo-trx/commit/?id=f78f35880f65fc1aa9dc508465260cdd9d815514 commit f78f35880f65fc1aa9dc508465260cdd9d815514 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 21:37:10 2012 +0200 lchan: Fix crashes when the specified lchan can not be found gsm_lchan_name will crash if the lchan is NULL. Introduce an error_report method that will do the right thing in the future and report the error. http://cgit.osmocom.org/osmo-trx/commit/?id=eac221b4eae31e5a877040dbe219a8905de393dd commit eac221b4eae31e5a877040dbe219a8905de393dd Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 20:14:38 2012 +0200 lchan: Fix the state transition in the deactivate handler If the deactivation is failing the channel needs to be moved into and error state, if the deactivation completed the channel needs to be set to the none state and set the state to release reqeust on the deactivation. http://cgit.osmocom.org/osmo-trx/commit/?id=f4f69ee6fc19b9f8d4d0af615e752cb88b96eae7 commit f4f69ee6fc19b9f8d4d0af615e752cb88b96eae7 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 20:07:56 2012 +0200 lchan: Similar to OpenBSC use a set method to change the state By making all modifications through lchan_set_state we can easily add code to verify the state transition. http://cgit.osmocom.org/osmo-trx/commit/?id=f1052b812deb55f9645ae2b7cdf1fa7313599c28 commit f1052b812deb55f9645ae2b7cdf1fa7313599c28 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 19:10:44 2012 +0200 sysmobts: Add an option to query the hardware version. http://cgit.osmocom.org/osmo-trx/commit/?id=0be33e3add129843ae1c519477e5904b0330f315 commit 0be33e3add129843ae1c519477e5904b0330f315 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Apr 16 18:49:11 2012 +0200 common: Add the copyright text to the vty_app_info This will make app -V print the copyright information like the other applications of our universe. An BTS integration that want to list additionaly copyright holders needs to access the vty_app_info and create a new copyright string. http://cgit.osmocom.org/osmo-trx/commit/?id=b03f8ae4f05b16997c3db5ed9454672a0d18e679 commit b03f8ae4f05b16997c3db5ed9454672a0d18e679 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 19 09:35:03 2012 +0200 ciphering: Better state tracking and HACK around L1 race condition We now check if the received message is an LAPDm I frame in order to determine if we have received the first valid encrypted message on the radio link. This relates to the fact that we often see 'old' UI frames coming up from L1, even after it has confirmed decryption has been enabled. http://cgit.osmocom.org/osmo-trx/commit/?id=d9ab45d1aac21c761c461659e2179d1077b5b7a5 commit d9ab45d1aac21c761c461659e2179d1077b5b7a5 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Apr 8 20:17:43 2012 +0200 Support for ciphering When the RR CIPH MODE CMD is transmitted to the MS, we need to tell the L1 to enable decryption on RX. After the first received frame has been decrypted successfully, we will enable encryption also on transmit. This has been tested with A5/1 so far, but A5/2 and A5/3 should work exactly identical. http://cgit.osmocom.org/osmo-trx/commit/?id=51f9693ba634945f489523453c3bdfc07274b09d commit 51f9693ba634945f489523453c3bdfc07274b09d Author: Harald Welte <laforge at gnumonks.org> Date: Wed Apr 18 23:49:47 2012 +0200 make HR channels work for voice, not only signalling without this, we would set a FR_V1 codec on a TCH/H channel, which the L1 is obviously not happy with. http://cgit.osmocom.org/osmo-trx/commit/?id=b34faf6f8ceedcafdb10523a39fe2bcd3d7c1faf commit b34faf6f8ceedcafdb10523a39fe2bcd3d7c1faf Author: Harald Welte <laforge at gnumonks.org> Date: Wed Apr 18 20:03:18 2012 +0200 TCH: Add support for the L1 RTP mode In L1 RTP mode, the L1 already does all the bit-shifting and re-ordering required for the RTP formats (which have different bit/nibble order than the ETSI/3GPP encodings, for some odd reason). We don't enable it by default yet, as only HR/FR/EFR work with it, but AMR has some yet to be debugged problem. Enabling USE_L1_RTP_MODE would save some CPU cycles on the ARM side. http://cgit.osmocom.org/osmo-trx/commit/?id=bc74b7f432811c1f4acb3d18827d4fa8673527f6 commit bc74b7f432811c1f4acb3d18827d4fa8673527f6 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Apr 14 14:42:26 2012 +0200 femtobts: The separate pdch/tch queues are not available in the old firmware The old firmware does not expose separate queues for PDCH and TCH. The change appears to be too intrusive and I will try to find a more elegant solution. http://cgit.osmocom.org/osmo-trx/commit/?id=f4a5bd2dd25291a5ff036d6273731c6147736a5e commit f4a5bd2dd25291a5ff036d6273731c6147736a5e Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Apr 14 14:36:23 2012 +0200 sysmobts: Handle options before allocating the bts This way -h/--version will always work, even when the underlying hardware is not available. http://cgit.osmocom.org/osmo-trx/commit/?id=58f419c7ced4e8dec2a8432ace1b3fb163c68695 commit 58f419c7ced4e8dec2a8432ace1b3fb163c68695 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Apr 14 01:03:28 2012 +0200 misc: Use sizeof(uint32_t) instead of simply using 32 bit This code would break in case we shrink the bitmap, use sizeof instead. http://cgit.osmocom.org/osmo-trx/commit/?id=11a787df24c2dc7c08ebc42ac2804c85a3bddbe2 commit 11a787df24c2dc7c08ebc42ac2804c85a3bddbe2 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sat Apr 14 00:54:40 2012 +0200 femtobts: Use HW_FEMTOBTS instead of HW_VERSION_1 to select femtobts Our header files use HW_FEMTOBTS guards to select the older femtobts design. Use the same macro in the bts code. http://cgit.osmocom.org/osmo-trx/commit/?id=caaa7e9d7b9fe3bb18ee83474c75fcdb46b8414f commit caaa7e9d7b9fe3bb18ee83474c75fcdb46b8414f Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Apr 12 22:21:49 2012 +0200 misc: Address a compiler warning and add an assert to a branch The compiler can not know that the "int priv_nr" will hold the enum values of the write queue, add a default branch and add a warning and an assert there. l1_transp_hw.c:108:1: warning: control reaches end of non-void function [-Wreturn-type] http://cgit.osmocom.org/osmo-trx/commit/?id=666fec7ff23e125730d7e13aa6d68112cde082de commit 666fec7ff23e125730d7e13aa6d68112cde082de Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Apr 12 21:54:48 2012 +0200 misc: Fix compiler warning about printing a ptrdiff Use 't' modifier for pointer diff in the printf statement. oml.c: In function âoml_rx_set_bts_attrâ: oml.c:403:3: warning: format â%luâ expects argument of type âlong unsigned intâ, but argument 9 has type âintâ [-Wformat] http://cgit.osmocom.org/osmo-trx/commit/?id=76aa95453f6918e0e79b9959ad4561787e33196d commit 76aa95453f6918e0e79b9959ad4561787e33196d Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Apr 12 21:52:22 2012 +0200 misc: Fix compiler warning of the femtobts_clksrc_names femtobts.c:249:2: warning: excess elements in array initializer [enabled by default] femtobts.c:249:2: warning: (near initialization for âfemtobts_clksrc_namesâ) [enabled by default] http://cgit.osmocom.org/osmo-trx/commit/?id=c623c4e589d887f8ba779a03543213d55b6d82f4 commit c623c4e589d887f8ba779a03543213d55b6d82f4 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 5 02:48:16 2012 +0200 oml: temporary debug hack http://cgit.osmocom.org/osmo-trx/commit/?id=2ed209c7580425804fb0fdaa88f28171993323b0 commit 2ed209c7580425804fb0fdaa88f28171993323b0 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 5 01:16:46 2012 +0200 Increase head-room in IPA messages received Without that headroom, I ran into an abort due to insufficient headroom in the LAPDm code. http://cgit.osmocom.org/osmo-trx/commit/?id=a0970249bf4f29f2028b042e2d7229a54ea10e42 commit a0970249bf4f29f2028b042e2d7229a54ea10e42 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Apr 5 00:41:35 2012 +0200 osmo-bts-sysmo: Add gsmtap for uplink http://cgit.osmocom.org/osmo-trx/commit/?id=f4d14b3f2ea3d9e98613b7d60fed6f6c0645ba14 commit f4d14b3f2ea3d9e98613b7d60fed6f6c0645ba14 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Mar 18 23:27:27 2012 +0100 set the default log mask for the L1 a bit more reasonable http://cgit.osmocom.org/osmo-trx/commit/?id=d25b6a752b18beb5a6efc4ae2183cfd64c6292fa commit d25b6a752b18beb5a6efc4ae2183cfd64c6292fa Author: Harald Welte <laforge at gnumonks.org> Date: Sun Mar 18 23:24:12 2012 +0100 osmo-bts-sysmo: Add GSMTAP support for transmit (DL) path there are VTY commands that can be used to filter which particular L1 sapis (channel types) should be sent in GSMTAP. http://cgit.osmocom.org/osmo-trx/commit/?id=3cf942792a4383ac4fe7d853c687e3d63fa73888 commit 3cf942792a4383ac4fe7d853c687e3d63fa73888 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Mar 18 21:46:44 2012 +0100 correctly print SAPI in log file on MPH-ACTIVATE.req http://cgit.osmocom.org/osmo-trx/commit/?id=21724bbaedf01aa6321d599f4695dbf4f8a94ffc commit 21724bbaedf01aa6321d599f4695dbf4f8a94ffc Author: Harald Welte <laforge at gnumonks.org> Date: Sun Mar 18 21:35:15 2012 +0100 Fix debug print of MPH-CONFIG.req http://cgit.osmocom.org/osmo-trx/commit/?id=12b95405ffda9cb3149090342598f2dfcab70850 commit 12b95405ffda9cb3149090342598f2dfcab70850 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Mar 18 21:34:05 2012 +0100 print human-readable SAPI name on MPH-[DE]ACT.{req,conf} http://cgit.osmocom.org/osmo-trx/commit/?id=452112e82391df347823175df86ca8fcc922ef3c commit 452112e82391df347823175df86ca8fcc922ef3c Author: Harald Welte <laforge at gnumonks.org> Date: Sun Mar 18 21:25:45 2012 +0100 Ensure that ADM_STATE IE is presnent when sending NM_MT_CHG_ADM_STATE_ACK http://cgit.osmocom.org/osmo-trx/commit/?id=d0e67493276b4e14007d359a5dd866e49a137574 commit d0e67493276b4e14007d359a5dd866e49a137574 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Mar 17 14:25:04 2012 +0100 Issue MPH-CLOSE.req during shutdown If we don't do this on recent L1, the L1 will refuse the open after re-starting osmo-bts. There still is an issue in case osmo-bts crashes. We should have a respawn loop that re-loads the DSP firmware before re-starting osmo-bts, just to make sure... http://cgit.osmocom.org/osmo-trx/commit/?id=b81c5d46999c4c403c9bbb5c8af8c4a196241f92 commit b81c5d46999c4c403c9bbb5c8af8c4a196241f92 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Mar 17 14:08:51 2012 +0100 introduce a command that permits setting the clock source via vty the default source is the OCXO http://cgit.osmocom.org/osmo-trx/commit/?id=fe0c13f8bd58603fbe0c82ace29f8ed6b1b199cb commit fe0c13f8bd58603fbe0c82ace29f8ed6b1b199cb Author: Harald Welte <laforge at gnumonks.org> Date: Thu Mar 15 23:39:53 2012 +0100 OML: when allocating merged tlvp arrays for MO, use bts context 'ts' is not a talloc-managed pointer but an offset into the bts structure. As such, we cannot pass it to talloc as context! http://cgit.osmocom.org/osmo-trx/commit/?id=3525f2c0389dc1e074e9af7c1a1af4e85f1f0246 commit 3525f2c0389dc1e074e9af7c1a1af4e85f1f0246 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Mar 15 23:39:37 2012 +0100 we currently run the board alwasy in clock master mode http://cgit.osmocom.org/osmo-trx/commit/?id=20d73555a2226a335efaeb46b7b8e342055113c5 commit 20d73555a2226a335efaeb46b7b8e342055113c5 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Mar 15 21:27:21 2012 +0100 update to new "superfemto.h" header file naming http://cgit.osmocom.org/osmo-trx/commit/?id=47589f10a4707e9396840fa73cefe2eeacbe0977 commit 47589f10a4707e9396840fa73cefe2eeacbe0977 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Mar 7 18:05:57 2012 +0100 Introduce a HW_VERSION_1 #define This #define helps us to distinguish the subtle API differences between the earlier v1 (2011) hardware and the later v2 (2012) model. http://cgit.osmocom.org/osmo-trx/commit/?id=f1cbd819848684de82042d3930d1e88fbc2d4714 commit f1cbd819848684de82042d3930d1e88fbc2d4714 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Mar 7 18:05:18 2012 +0100 prepare for splitting L1 queue into signalling/tch/pdtch We don't use multiple queues yet, but we very well might end up using them soon. http://cgit.osmocom.org/osmo-trx/commit/?id=818cb2d3145a2a20b40a3c98d190ec6700116b39 commit 818cb2d3145a2a20b40a3c98d190ec6700116b39 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Oct 12 14:36:59 2011 +0200 update config file to parse correctly http://cgit.osmocom.org/osmo-trx/commit/?id=6dd7c4fb573bb51729560b700d4e837ce2b32fdb commit 6dd7c4fb573bb51729560b700d4e837ce2b32fdb Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Jan 23 10:22:09 2012 +0100 misc: Check return value of msgb _alloc functions Attempt to catch all functions that allocate a msgb and didn't check the return value of the allocation. http://cgit.osmocom.org/osmo-trx/commit/?id=bb9647f65108cd2f4f961306b1b4b8354e2d49bb commit bb9647f65108cd2f4f961306b1b4b8354e2d49bb Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Jan 15 11:25:11 2012 +0100 ipa: Send the DLCX Indication with the right message discriminator The IPA messages for RTP should use the IPA vendor as message discriminator. http://cgit.osmocom.org/osmo-trx/commit/?id=2e677958d249fc16a975fbb1fbd861d9efe396e9 commit 2e677958d249fc16a975fbb1fbd861d9efe396e9 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 13 22:50:38 2012 +0100 efr: Add efr to the femtobts_tch_pl_names array Parts of the code check if GsmL1_TchPlType_Efr is defined, others parts don't. Follow the easy route and assume it is defined. http://cgit.osmocom.org/osmo-trx/commit/?id=771e77dff0becd02ce6824f3af4e882605ce20ab commit 771e77dff0becd02ce6824f3af4e882605ce20ab Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 13 16:56:23 2012 +0100 oml: Use talloc_free(ptr) instead of talloc_free(ptr_to_ptr) tp_merged points to memory allocated by talloc_zero, no need to hand the address of that to talloc itself. http://cgit.osmocom.org/osmo-trx/commit/?id=62579c7a34474eda1be954e2f2bbdaf389d7bc96 commit 62579c7a34474eda1be954e2f2bbdaf389d7bc96 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 13 00:46:43 2012 +0100 oml: Mention the SAPI that is activated in the log message I was wondering why the channel was activated twice but it needs to be activated for each SAPI. http://cgit.osmocom.org/osmo-trx/commit/?id=4cd68dc4d772e367851a5d26dcc558fec8fd0e7b commit 4cd68dc4d772e367851a5d26dcc558fec8fd0e7b Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Fri Jan 13 00:40:04 2012 +0100 bts: Use msgb_dequeue and msgb_enqueue for the AGCH queue The TODO item still applies to somehow limit the queue of incoming messages and drop older ones first. A sane limit would be the number of channels (+ or * 2). http://cgit.osmocom.org/osmo-trx/commit/?id=eab71534efee978576713618099b2e4dafe05419 commit eab71534efee978576713618099b2e4dafe05419 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Jan 12 11:01:44 2012 +0100 sysmo: handle_ph_data_ind has paths rc is not initialized rc might not be initialized when going through the default statement but also hitting a break inside the switch case statement for GsmL1_Sapi_Sacch. l1_if.c:530:2: warning: Undefined or garbage value returned to caller return rc; http://cgit.osmocom.org/osmo-trx/commit/?id=6e121417a5f01eb85e86aa38fc783bebb4b4fe2a commit 6e121417a5f01eb85e86aa38fc783bebb4b4fe2a Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 14 12:35:40 2012 +0100 RSL: fix typo in comment http://cgit.osmocom.org/osmo-trx/commit/?id=7a44e47ed6d9e28a2f1e88b7a299ab29a9f9581b commit 7a44e47ed6d9e28a2f1e88b7a299ab29a9f9581b Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jan 14 12:28:17 2012 +0100 OML SET CHAN ATTR: merge TS attributes (not BTS) and fix mem leak We have to * merge the new attributes with the exiting TS (not BTS) attributes * in case of success, attach the new merged attributes to our state * in case of success, free the old attributes Thanks to Holger for pointing this out. http://cgit.osmocom.org/osmo-trx/commit/?id=6aa2a574fb63093b155b15e81cf31dd4b9304891 commit 6aa2a574fb63093b155b15e81cf31dd4b9304891 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Dec 11 13:43:39 2011 +0100 sysmo-bts: The code is not used (and built), remove it. The BTS is using the LAPDm code in polling mode, there will be no callbacks (e.g. a BTS does not transmit RACH bursts). Remove the code. http://cgit.osmocom.org/osmo-trx/commit/?id=fd58d925a87cb034cca8a0fe0ed734c5f6db65c7 commit fd58d925a87cb034cca8a0fe0ed734c5f6db65c7 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Sun Dec 11 12:57:36 2011 +0100 bts.h: lchan_init_lapdm is listed twice, remove one http://cgit.osmocom.org/osmo-trx/commit/?id=b0985e3fa5ad539f1ab51ebf89724eb8e616a750 commit b0985e3fa5ad539f1ab51ebf89724eb8e616a750 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Dec 1 09:12:47 2011 +0100 test: Introduce a very simple test for the paging subsystem Check that adding a paging command works, check that it is expired after the first call to paging_gen_msg. The test will be extended to test the scheduling and selection of the various paging messages. http://cgit.osmocom.org/osmo-trx/commit/?id=467e1497630a093cff94670da0e8fa39fd21c278 commit 467e1497630a093cff94670da0e8fa39fd21c278 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Dec 1 09:09:18 2011 +0100 paging: Provide functions to check the internal state of the paging system http://cgit.osmocom.org/osmo-trx/commit/?id=127ec05b4e7c3dfbb17720e583ed71a4fba5d622 commit 127ec05b4e7c3dfbb17720e583ed71a4fba5d622 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Thu Dec 1 08:47:53 2011 +0100 paging: Do not crash if we get called for the wrong frame/t1/t2/t3 If someone wants to have paging for a wrong frame, gracefully return and do not fill the output buffer. Because we are on the wrong frame I think it is best to not fill the frame, this is why I did not add a check to l1_if.c to generate an empty frame. http://cgit.osmocom.org/osmo-trx/commit/?id=79da6f3283065d900075bf1610f9eb5098863d74 commit 79da6f3283065d900075bf1610f9eb5098863d74 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Tue Nov 29 21:55:12 2011 +0100 misc: Move the cmr_index into the #if 0 block as it is only used there http://cgit.osmocom.org/osmo-trx/commit/?id=143bb812dc196c5774cbc2fe992f67452cac92fd commit 143bb812dc196c5774cbc2fe992f67452cac92fd Author: Harald Welte <laforge at gnumonks.org> Date: Tue Nov 29 12:15:16 2011 +0100 LAPDm: Use lapdm_channel_exit() and avoid copy+paste bug We have to either lapdm_exit() both DCCH and ACCH (not 2x ACCH) or rather call lapdm_channel_exit() which does that for us. Thanks to Holger Freyther for spotting this bug. http://cgit.osmocom.org/osmo-trx/commit/?id=fe4893e625dd196e11c17dd468d73b60f17db9f9 commit fe4893e625dd196e11c17dd468d73b60f17db9f9 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Nov 24 17:46:22 2011 +0100 RSL: Actually check if BSC-requested cipher is supported http://cgit.osmocom.org/osmo-trx/commit/?id=26608120842761bfae612eed1b5cf3c881855fc7 commit 26608120842761bfae612eed1b5cf3c881855fc7 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Nov 7 14:26:48 2011 +0100 audio: Make bts_model_rtp_rx_cb compatible with the prototype http://cgit.osmocom.org/osmo-trx/commit/?id=5cdcf8a83789fa58a27114e84d4749bd36876f7a commit 5cdcf8a83789fa58a27114e84d4749bd36876f7a Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Nov 7 14:13:29 2011 +0100 sysmo-bts: Include bts.h for bts_shutdown, remove unused variable http://cgit.osmocom.org/osmo-trx/commit/?id=efdb45d5d0d397654b54c25d703c66036b4064c1 commit efdb45d5d0d397654b54c25d703c66036b4064c1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Nov 7 14:09:53 2011 +0100 common: Include bts.h for bts_shutdown http://cgit.osmocom.org/osmo-trx/commit/?id=477f35e78c81012bac4c724faf6ae1ef7f840398 commit 477f35e78c81012bac4c724faf6ae1ef7f840398 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Nov 7 14:07:55 2011 +0100 sysmo-bts: Use the z modifier to print the result of sizeof http://cgit.osmocom.org/osmo-trx/commit/?id=187871e2ca2d422c0d9c526058eae4fbde77040c commit 187871e2ca2d422c0d9c526058eae4fbde77040c Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Nov 7 14:02:02 2011 +0100 sysmobts-vty: Fix compiler warnings about the clock value The first one just sets the val to 0xffff, the second converted the value to integer twice. sysmobts_vty.c: In function âcfg_trx_clkcal_defâ: sysmobts_vty.c:109:15: warning: unused variable âclkcalâ [-Wunused-variable] sysmobts_vty.c: In function âcfg_trx_clkcalâ: sysmobts_vty.c:122:15: warning: unused variable âclkcalâ [-Wunused-variable] http://cgit.osmocom.org/osmo-trx/commit/?id=b10d74d8213fd21143b262288f69b45ef837c1c1 commit b10d74d8213fd21143b262288f69b45ef837c1c1 Author: Holger Hans Peter Freyther <zecke at selfish.org> Date: Mon Nov 7 13:48:02 2011 +0100 config: Rename llapdm -> llapd in the example configuration http://cgit.osmocom.org/osmo-trx/commit/?id=9582883235743e31800ec7cbfc8af2c16b63cdbb commit 9582883235743e31800ec7cbfc8af2c16b63cdbb Author: Harald Welte <laforge at gnumonks.org> Date: Wed Oct 12 13:36:22 2011 +0200 add VTY based way to set clock calibration of sysmobts L1 http://cgit.osmocom.org/osmo-trx/commit/?id=c373448e03f12f8f7e5da1d894d63d7bc79eef4a commit c373448e03f12f8f7e5da1d894d63d7bc79eef4a Author: Harald Welte <laforge at gnumonks.org> Date: Mon Sep 19 20:46:51 2011 +0200 fix various compiler warnings across the code this deals with unused cocde, unused variables and undeclared symbols in various places. http://cgit.osmocom.org/osmo-trx/commit/?id=7899dc5fcfa49febd50cb113cc8ef45f32dacc9d commit 7899dc5fcfa49febd50cb113cc8ef45f32dacc9d Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 23:55:39 2011 +0200 sysmobts: fix initial codec mode computation There is no off-by-one between osmocom and L1 definitions... http://cgit.osmocom.org/osmo-trx/commit/?id=215d9eecddba2ef3a5fa850180fe866d82bdcb6a commit 215d9eecddba2ef3a5fa850180fe866d82bdcb6a Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 23:30:46 2011 +0200 sysmobts: channel activation changes for v2.4 L1 DSP firmware We now have to explicitly indicate the tchPlType at channel activation type, so L1 knows which channel decoder to use (FR, EFR, AMR, ...) Also, we properly implement the initial codec mode selection as per TS 05.09 http://cgit.osmocom.org/osmo-trx/commit/?id=06636b61559b5be5290315b81f2af08cce475548 commit 06636b61559b5be5290315b81f2af08cce475548 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 23:29:27 2011 +0200 AMR: change definition of amr_get_initial_mode() return value AMR: return AMR_CODEC_MODE (0..3) instead of full range http://cgit.osmocom.org/osmo-trx/commit/?id=9508fb80a4c8284daf52b1beb154a86df7d5ee07 commit 9508fb80a4c8284daf52b1beb154a86df7d5ee07 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 22:32:45 2011 +0200 Introduce new amr.[ch] for AMR related functions http://cgit.osmocom.org/osmo-trx/commit/?id=4ccca1ce36067d5f52d2feb7c2c6f37510618530 commit 4ccca1ce36067d5f52d2feb7c2c6f37510618530 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 22:04:09 2011 +0200 OML: make sure max_power_red is scaled by 2 to convert from 12.21 to dBm http://cgit.osmocom.org/osmo-trx/commit/?id=a4a3574b1ded407700717f2bcfc86ac40acf29d7 commit a4a3574b1ded407700717f2bcfc86ac40acf29d7 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 15:12:52 2011 +0200 update osmo-bts to conform to L1 v2.4 API changes http://cgit.osmocom.org/osmo-trx/commit/?id=2c40d02f274199c465533c1fd1886d134f745683 commit 2c40d02f274199c465533c1fd1886d134f745683 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Sep 9 14:10:57 2011 +0200 Inquire DSP/FPGA version at BTS boot and check band compatibility http://cgit.osmocom.org/osmo-trx/commit/?id=16c0ab92c1cf822c76a19ff44dc5b2470138d709 commit 16c0ab92c1cf822c76a19ff44dc5b2470138d709 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Sep 8 15:18:43 2011 +0200 add commands to configure RTP jitter buffer there's one global setting for the BTS default value, plus an interactive command to change the buffer of an active lchan on the fly http://cgit.osmocom.org/osmo-trx/commit/?id=111b8e673b4282f4c9a01b59628c4298c251ccc0 commit 111b8e673b4282f4c9a01b59628c4298c251ccc0 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Sep 7 21:28:27 2011 +0200 auto-generate a version http://cgit.osmocom.org/osmo-trx/commit/?id=72b6989ec9c879280c1a8c8f393bb599e91b7716 commit 72b6989ec9c879280c1a8c8f393bb599e91b7716 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Sep 7 20:49:10 2011 +0200 make sure 'band' will correctly parse the crap that libosmocore generates http://cgit.osmocom.org/osmo-trx/commit/?id=f49e3dd3af9db41c4b4314ad3c97c1dd9e7ff81c commit f49e3dd3af9db41c4b4314ad3c97c1dd9e7ff81c Author: Harald Welte <laforge at gnumonks.org> Date: Wed Sep 7 12:42:15 2011 +0200 store the last SID frame of a given LCHAN so we can repeat it repeating the last SID frame is required during 20ms intervals where we don't get a new SID update (SID RTP frames are valid up to 160ms) http://cgit.osmocom.org/osmo-trx/commit/?id=e5d082f3566bedf0b5b6e6aa3761cc5ce77da754 commit e5d082f3566bedf0b5b6e6aa3761cc5ce77da754 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Sep 7 12:40:50 2011 +0200 depend on more recent libosmo-trau for polling support http://cgit.osmocom.org/osmo-trx/commit/?id=5355ead9d99262b756bbe736f8feb3e189264ca8 commit 5355ead9d99262b756bbe736f8feb3e189264ca8 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Sep 7 11:55:08 2011 +0200 use osmo_ortp in POLLING mode instead of select loop integration This solves a lot of the problems we've been seeing in the context of large jitter (uRTP) or classic RTP with SID frames http://cgit.osmocom.org/osmo-trx/commit/?id=42f80bc7afcbad2b2a6c44ccf224265812fca3ba commit 42f80bc7afcbad2b2a6c44ccf224265812fca3ba Author: Harald Welte <laforge at gnumonks.org> Date: Wed Sep 7 11:54:23 2011 +0200 add RTP logging http://cgit.osmocom.org/osmo-trx/commit/?id=82c4d8685ce0b32a7e9659e66ba751aaed08350c commit 82c4d8685ce0b32a7e9659e66ba751aaed08350c Author: Harald Welte <laforge at gnumonks.org> Date: Tue Sep 6 22:24:31 2011 +0200 user DRTP where appropriate, not DL1C http://cgit.osmocom.org/osmo-trx/commit/?id=5fa9d9c18f5a3e37cc36f6dbb3a42d696d0f63c6 commit 5fa9d9c18f5a3e37cc36f6dbb3a42d696d0f63c6 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Sep 6 22:20:51 2011 +0200 RSL: get rid of some compiler warnings http://cgit.osmocom.org/osmo-trx/commit/?id=24713348c45b648f26f4ce65b591b2de9245ef58 commit 24713348c45b648f26f4ce65b591b2de9245ef58 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Sep 6 22:14:31 2011 +0200 More comprehensive AMR handling * parse AMR multirate config form 04.08 IE into easier format * CMR, CMC and CMI on the L1 side are an _index_ into the current mode array * Fix conversion of AMR SID frames from RTP -> L1 http://cgit.osmocom.org/osmo-trx/commit/?id=a16bcc2cc68e8e808e73e50f5149beb265385e09 commit a16bcc2cc68e8e808e73e50f5149beb265385e09 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 4 23:22:22 2011 +0200 update screenrc; we no longer have the '-B' command line option http://cgit.osmocom.org/osmo-trx/commit/?id=aadb0466983ad79033b521692acd3e429fe67b08 commit aadb0466983ad79033b521692acd3e429fe67b08 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 4 23:00:20 2011 +0200 update configure.ac to make sure we have libosmocore-0.3.9 http://cgit.osmocom.org/osmo-trx/commit/?id=e3e3a19e6ce38fb4c5505071d64873fb10f9cbab commit e3e3a19e6ce38fb4c5505071d64873fb10f9cbab Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 4 22:49:20 2011 +0200 add minimal example config file http://cgit.osmocom.org/osmo-trx/commit/?id=6d7b78bde165f39dcd9033f0c5386f5699801233 commit 6d7b78bde165f39dcd9033f0c5386f5699801233 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 4 22:42:03 2011 +0200 add minimal configuration file support this config file allows configuration of unit id, oml ip, and local rtp bind IP. http://cgit.osmocom.org/osmo-trx/commit/?id=f41f2a7f92d7eea87e3f036a849bf8b131e2b389 commit f41f2a7f92d7eea87e3f036a849bf8b131e2b389 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Sep 4 17:21:39 2011 +0200 AMR: double-check CMI/CMR/CMC values We have to make sure that a phone cannot request codec modes which are not part of the active set... http://cgit.osmocom.org/osmo-trx/commit/?id=099fb3b17cf29d6d152abb4d2cf4aef76916f8a0 commit 099fb3b17cf29d6d152abb4d2cf4aef76916f8a0 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Sep 3 18:10:26 2011 +0200 Sysmobts L1: Implement HR codec support We don't really know if the HR encoding is compatible with other equipment, but it _should_ follow Chapter 5.2 of ETSI TS 101 318. Please note that RFC5993 also specifies a way to encode GSM-HR into RTP, we do not try to be compatible with that. The only difference seems to be one additional TOC octet at the beginning of the payload field. http://cgit.osmocom.org/osmo-trx/commit/?id=716dded7731f69f6a58de15aaa6315b44784e6ce commit 716dded7731f69f6a58de15aaa6315b44784e6ce Author: Harald Welte <laforge at gnumonks.org> Date: Sat Sep 3 16:01:23 2011 +0200 Fix MODE MODIFY for multirate configuration on TCH/H using this configuration we can have successful AMR/HR (5.9) calls http://cgit.osmocom.org/osmo-trx/commit/?id=526b0c62cf891cd728460260bf10a919e9e437d3 commit 526b0c62cf891cd728460260bf10a919e9e437d3 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Sep 3 15:41:12 2011 +0200 Add new ORTP based libosmo-trau based voice support Using osmo-bts-sysmo and this code, it is now possible to do FR and AMR based voice calls on TCH/F. A lot of CPU is wasted in the conversion between the RTP formats and the L1 specific formats for the codec frames. All data needs to be shifted by four bits, and the order of bits needs to be reversed in every byte. http://cgit.osmocom.org/osmo-trx/commit/?id=b7bec6d488ac3c36957a717358b91836ba9b2215 commit b7bec6d488ac3c36957a717358b91836ba9b2215 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Sep 3 15:40:50 2011 +0200 remove dead code / dead fule common/voice.c http://cgit.osmocom.org/osmo-trx/commit/?id=ea844d62fa0029ba256271b8f35ec3317e7c3486 commit ea844d62fa0029ba256271b8f35ec3317e7c3486 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Sep 1 11:52:24 2011 +0200 abis.c: Remove dead code http://cgit.osmocom.org/osmo-trx/commit/?id=13df9c8a721237bcffe40ff1cfb880910cb37688 commit 13df9c8a721237bcffe40ff1cfb880910cb37688 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 24 02:52:20 2011 +0200 sysmobts: add a skeleton for codec frame processing http://cgit.osmocom.org/osmo-trx/commit/?id=97d4c44db20fbcd4070bf058f0a537a3170ccbe7 commit 97d4c44db20fbcd4070bf058f0a537a3170ccbe7 Author: Harald Welte <laforge at gnumonks.org> Date: Sun Jul 24 00:01:46 2011 +0200 RSL: send CRCX/MDCX related messages as msg discriminator ip.access http://cgit.osmocom.org/osmo-trx/commit/?id=9d4736a5bebaaf84bf102559fafa4c723f5e833b commit 9d4736a5bebaaf84bf102559fafa4c723f5e833b Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 21 20:36:24 2011 +0200 Use libosmotrau for RTP support This only implements creating, binding, connecting and free'ing RTP sockets, not yet anything regarding receiving or transmitting codec frames on them. You will need the rtp branch of libosmocore for libosmotrau http://cgit.osmocom.org/osmo-trx/commit/?id=8583c318113ca2d21f1a30ce4f388d74b527728b commit 8583c318113ca2d21f1a30ce4f388d74b527728b Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 21 16:48:07 2011 +0200 remove old RTP code from osmocom-bb/jolly/bts branch Instead, I will base on the existing RTP code in openbsc http://cgit.osmocom.org/osmo-trx/commit/?id=6b62748da6e2dc3e981869a2f788c990fd4d7342 commit 6b62748da6e2dc3e981869a2f788c990fd4d7342 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jul 13 00:52:41 2011 +0200 RSL: fix transmission of RR ciphering mode command via LAPDm We didn't correctly format the RSLms message that went into LAPDm, causing LAPDm to drop the message. Also, disable the fake CIPH MODE COMPLETE generation hack for now http://cgit.osmocom.org/osmo-trx/commit/?id=168238f9de9b867a8fbc5818deab8b69fe0d822c commit 168238f9de9b867a8fbc5818deab8b69fe0d822c Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 12 00:23:32 2011 +0200 update the HACK to delay the fake CIPHERING MODE COMPLETE When seinding the fake CIPH MOD COMPL, we should wait a bit, as otherwise it will reach the MSC _before_ we ever get the (still unencrypted) CLASSMARK update from the MS. http://cgit.osmocom.org/osmo-trx/commit/?id=0285067b63206593d0fd086831eb1095502f2222 commit 0285067b63206593d0fd086831eb1095502f2222 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 7 23:44:41 2011 +0200 RSL: include fake IMEISV if we send fake CIPH MODE COMPL If the MSC requests us to include the IMEISV in the ciph mode complete, we respond with a fake IMEISV http://cgit.osmocom.org/osmo-trx/commit/?id=e4035a86cf92e6eab3585a11398b2e44f2ef7615 commit e4035a86cf92e6eab3585a11398b2e44f2ef7615 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 7 21:35:46 2011 +0200 RSL: ciphering IE length can be '1' in case of 'no ciphering' http://cgit.osmocom.org/osmo-trx/commit/?id=ed607f475fa11390d5f9ae78de4d12f49fc38841 commit ed607f475fa11390d5f9ae78de4d12f49fc38841 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 7 18:17:31 2011 +0200 increae the RACH quality threshold to 5dB C/I http://cgit.osmocom.org/osmo-trx/commit/?id=be598e3afd04e2f0b773ca89e3a5b5d229a97797 commit be598e3afd04e2f0b773ca89e3a5b5d229a97797 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 7 18:16:35 2011 +0200 RSL: Send fake CIPHERING MODE COMPLETE we do this as a hack as long as the MSC assumes the BTS supports A5, but the L1 really doesn't support it yet. http://cgit.osmocom.org/osmo-trx/commit/?id=540410c123d439a03f672726d64f6a6aec45a98d commit 540410c123d439a03f672726d64f6a6aec45a98d Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jul 7 11:48:00 2011 +0200 RSL: implement RSL ENCR CMD, feed L3_INFO to LAPDm This is not full encrpytion support, the bts-model part still needs to detect the ENCR CMD when de-queueing from LAPDm and enable the de-ciphering, detect the arrival of the first encrypted frame, etc, enable en-ciphering, ... http://cgit.osmocom.org/osmo-trx/commit/?id=39eadbbb17c8e634b2f641c2f6148f27a975f7de commit 39eadbbb17c8e634b2f641c2f6148f27a975f7de Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 16:59:27 2011 +0200 sysmbts L1 if: implement 'dead DSP L1 detection' when we activate the SCH in the DSP, we start a 5-second timer. If we ever do not receive any MPH-TIME.ind primitives from L1 within that time frame, we stop the process (and will be re-spawned) http://cgit.osmocom.org/osmo-trx/commit/?id=547b1d1916a89a6ebd2ba980005582a426bf3a31 commit 547b1d1916a89a6ebd2ba980005582a426bf3a31 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 16:15:26 2011 +0200 l1_if: send EMPTY-FRAME.req instead of fill frame on TCH/F + FACCH http://cgit.osmocom.org/osmo-trx/commit/?id=1920738840efab584e3c5b60ffa20b39d2279664 commit 1920738840efab584e3c5b60ffa20b39d2279664 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 14:27:30 2011 +0200 L1/OML: De-activate L1 SAPIs in opposite order of activation L1 wants TCH to be activated before FACCH, and it wants FACCH to be de-activated before TCH. By iterating the array in iverse order, we ensure this. http://cgit.osmocom.org/osmo-trx/commit/?id=79cf0bb1e6573352a60e8524e22303a81d7072c9 commit 79cf0bb1e6573352a60e8524e22303a81d7072c9 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 14:13:52 2011 +0200 increase RACH threshold to 1 dB C/I http://cgit.osmocom.org/osmo-trx/commit/?id=977fcbc2db20e972b538b2c74790085ea72f8a8b commit 977fcbc2db20e972b538b2c74790085ea72f8a8b Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 13:52:29 2011 +0200 add some missing #include directives http://cgit.osmocom.org/osmo-trx/commit/?id=7ab9b777c6fb3e350a66b3477c3e3e5bb9990980 commit 7ab9b777c6fb3e350a66b3477c3e3e5bb9990980 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 13:47:42 2011 +0200 add command line option '-p' to specify DSP trace flags as hex mask http://cgit.osmocom.org/osmo-trx/commit/?id=017300623b0ffad1d98cc47b0e7000c648511b1c commit 017300623b0ffad1d98cc47b0e7000c648511b1c Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 13:38:15 2011 +0200 Fix compilation of paging.c Sometimes I really feel stupid... http://cgit.osmocom.org/osmo-trx/commit/?id=f78927a9a89d516a3ef71398272b463f64671078 commit f78927a9a89d516a3ef71398272b463f64671078 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 13:36:26 2011 +0200 paging: Fix 'empty paging' message contents Thanks to Dieter Spaar for spotting this bug http://cgit.osmocom.org/osmo-trx/commit/?id=5df3cf9db2bbff46497ea8900e303f4ada397891 commit 5df3cf9db2bbff46497ea8900e303f4ada397891 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 13:35:28 2011 +0200 paging: correct contents of L2 Pseudo-Length thanks to Dieter Spaar for spotting this one http://cgit.osmocom.org/osmo-trx/commit/?id=12b647998c54defd62406a87e7615efa55c6537f commit 12b647998c54defd62406a87e7615efa55c6537f Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 12:21:27 2011 +0200 add VTY commands for setting and showing DSP trace flags http://cgit.osmocom.org/osmo-trx/commit/?id=ead4863de1e1e4482deecb74bf909a22cd8164e5 commit ead4863de1e1e4482deecb74bf909a22cd8164e5 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 00:43:50 2011 +0200 sysmobts: add value_string for dsp trace flags http://cgit.osmocom.org/osmo-trx/commit/?id=260fcfc8d0d73840d4d367dfba404264df9c5d17 commit 260fcfc8d0d73840d4d367dfba404264df9c5d17 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jul 5 00:43:33 2011 +0200 logging: Add DSP log subsystem http://cgit.osmocom.org/osmo-trx/commit/?id=b17a47e6e1cf211137f51d8fcccd4c8deb205f04 commit b17a47e6e1cf211137f51d8fcccd4c8deb205f04 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jul 2 22:44:27 2011 +0200 measurement: fix missing \n at end of log output http://cgit.osmocom.org/osmo-trx/commit/?id=2b384c3ee1c928b0b05474c7db533154911fa2a8 commit 2b384c3ee1c928b0b05474c7db533154911fa2a8 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jul 2 21:07:05 2011 +0200 remove FIXME that has long been fixed http://cgit.osmocom.org/osmo-trx/commit/?id=db4455acfa3feb8c0adb34d5889ba3db7486284e commit db4455acfa3feb8c0adb34d5889ba3db7486284e Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jul 2 15:57:37 2011 +0200 add init script and screenrc for l1fwd http://cgit.osmocom.org/osmo-trx/commit/?id=43b669a9f3c1333371a36fe77b8f90ab8c4b0d1f commit 43b669a9f3c1333371a36fe77b8f90ab8c4b0d1f Author: Harald Welte <laforge at gnumonks.org> Date: Sat Jul 2 00:20:49 2011 +0200 untested code to dynamically set L1 band based on ARFCN number http://cgit.osmocom.org/osmo-trx/commit/?id=a5ea80e9b6e6fba4f042fba281ddc269bde67b35 commit a5ea80e9b6e6fba4f042fba281ddc269bde67b35 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 23:09:45 2011 +0200 start screen in detached/background mode http://cgit.osmocom.org/osmo-trx/commit/?id=cc6bf663e770c5788167fb5dc5d325b609975956 commit cc6bf663e770c5788167fb5dc5d325b609975956 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 19:54:16 2011 +0200 add init script for screen-based respawn http://cgit.osmocom.org/osmo-trx/commit/?id=b10e9781d68e3f16ea08f216784152bc2e340448 commit b10e9781d68e3f16ea08f216784152bc2e340448 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 19:51:32 2011 +0200 add respawn script and screenrc for respawning the process in screen http://cgit.osmocom.org/osmo-trx/commit/?id=18d0818710eacbea8d89b62b751d28e7e0204ff3 commit 18d0818710eacbea8d89b62b751d28e7e0204ff3 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 19:03:30 2011 +0200 make it clear why we terminate http://cgit.osmocom.org/osmo-trx/commit/?id=288d0c04c8aa51ca9cdeb8a6922fdc2b96712b07 commit 288d0c04c8aa51ca9cdeb8a6922fdc2b96712b07 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 18:54:10 2011 +0200 logging sanitization (use proper log levels, etc.) http://cgit.osmocom.org/osmo-trx/commit/?id=f788d79411ab8e2364f884988b0fbcb8f4bd4294 commit f788d79411ab8e2364f884988b0fbcb8f4bd4294 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 18:25:22 2011 +0200 sysmobts-remote: Remove hard-coded BTS IP address The BTS IP address can now be specified by the L1FWD_BTS_HOST env variable. Option parsing would not have been that easy to integrate without touching the main program... http://cgit.osmocom.org/osmo-trx/commit/?id=f15cef94f722c02b0fc401e40bcc4b7a22f9cbed commit f15cef94f722c02b0fc401e40bcc4b7a22f9cbed Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 18:22:01 2011 +0200 fix various compiler warnings http://cgit.osmocom.org/osmo-trx/commit/?id=9fa0cce100d25585f5a1baff3353cd54a5a58d5f commit 9fa0cce100d25585f5a1baff3353cd54a5a58d5f Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 18:09:34 2011 +0200 fix BTS initialization order The sequence is as follows: 0) start osmo-bts 1) start connection attempts to BTS 2) issue L1-RESET.req 3) receive L1-RESET.conf 4) issue RF-ACTIVATE.req 5) receive RF-ACTIVATE.conf 6) receive attributes for TRX 7) receive opstart for TRX 8) issue MPH-INIT.req [...] The important point here is: We don't want the BSC to set TRX attributes or do TRX opstart before our RF related hardware is initialized. http://cgit.osmocom.org/osmo-trx/commit/?id=0f827275d7fcaeb5a5e762e2382eaf1da6db7566 commit 0f827275d7fcaeb5a5e762e2382eaf1da6db7566 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 16:02:19 2011 +0200 sysmo-bts: Ignore OPSTART on the TRX until we have seen SET ATTR http://cgit.osmocom.org/osmo-trx/commit/?id=4450a1530cd7b1bacfa5e7ee7f68a09fcad0c59e commit 4450a1530cd7b1bacfa5e7ee7f68a09fcad0c59e Author: Harald Welte <laforge at gnumonks.org> Date: Fri Jul 1 11:27:41 2011 +0200 sysmo-bts: properly initialize the nominal power, print it at startup http://cgit.osmocom.org/osmo-trx/commit/?id=062d96e38b10cae4b9f5222dc1109609ec3c5e24 commit 062d96e38b10cae4b9f5222dc1109609ec3c5e24 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Jun 30 17:31:54 2011 +0200 measurements: avoid division by zero http://cgit.osmocom.org/osmo-trx/commit/?id=b84968418172040f12dc150d770f9b06d6df335d commit b84968418172040f12dc150d770f9b06d6df335d Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 20:42:14 2011 +0200 deactivate RF + exit when the Abis link is gone The idea is that the BTS process is re-spawned from init/upstart/systemd http://cgit.osmocom.org/osmo-trx/commit/?id=1eb4d4893c3de16692ae3e9c3b4c8a09da490ad8 commit 1eb4d4893c3de16692ae3e9c3b4c8a09da490ad8 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 20:20:11 2011 +0200 add logging related vty commands http://cgit.osmocom.org/osmo-trx/commit/?id=2bc0e10fa19b665dd1957549b731634141259640 commit 2bc0e10fa19b665dd1957549b731634141259640 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 19:14:58 2011 +0200 RSL/LAPDM: make sure we do lapdm_channel_reset() this will free / flush any of the queued messages and give us a clean start for the next user of the same lapdm channel. http://cgit.osmocom.org/osmo-trx/commit/?id=3b7480d5c33811349d9c162d0ec6f04866bcc68e commit 3b7480d5c33811349d9c162d0ec6f04866bcc68e Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 19:02:51 2011 +0200 RSL: clarify msgb free scheme in rsl http://cgit.osmocom.org/osmo-trx/commit/?id=40e820d882a0401c99cb70f684ed5dbbb6a63adb commit 40e820d882a0401c99cb70f684ed5dbbb6a63adb Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 18:57:58 2011 +0200 OML: fix memory leaks by centralized msgb_free() for rx msgs http://cgit.osmocom.org/osmo-trx/commit/?id=ae5dfdc416c03221b0b747883fd9c1fd54db281e commit ae5dfdc416c03221b0b747883fd9c1fd54db281e Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 18:55:03 2011 +0200 Fix memory leak in abis code: Free msgb after tx'ing it http://cgit.osmocom.org/osmo-trx/commit/?id=5a7877457b2b5c60c52f2bea7424b3c15f04ab69 commit 5a7877457b2b5c60c52f2bea7424b3c15f04ab69 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 18:46:28 2011 +0200 set talloc ctx for msgb's to make sure we see them in talloc report http://cgit.osmocom.org/osmo-trx/commit/?id=b9919bd2a68d7898d56faaa0d15e97fd89bcaec7 commit b9919bd2a68d7898d56faaa0d15e97fd89bcaec7 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 18:35:38 2011 +0200 Fix support of SDCCH4 In SDCCH4, we use lchan number 0...3 for the SDCCH/SACCH, and we statically use lchan[4] as the dummy for activating the CCCH L1 SAPIs. In order to make combined and non-combined CCCH orthogonal, we simply also use lchan[4] in that case. On a 'pure' CCCH, therefore lchan 0..3 are unused and 4 is the actual CCCH. http://cgit.osmocom.org/osmo-trx/commit/?id=8188e1949bdd485f1b25ef278fe54170165044b2 commit 8188e1949bdd485f1b25ef278fe54170165044b2 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 17:51:16 2011 +0200 sysmo-bts: Bring TCH (FACCH) into a working state http://cgit.osmocom.org/osmo-trx/commit/?id=45b767c7bec3e6e1995c67ad9ea252e03e6edf67 commit 45b767c7bec3e6e1995c67ad9ea252e03e6edf67 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 17:49:52 2011 +0200 RSL: Log all RLL messages from A-bis to LAPDm http://cgit.osmocom.org/osmo-trx/commit/?id=1904e50f87cc788b34592bc73b9af4bb8ca9a2dd commit 1904e50f87cc788b34592bc73b9af4bb8ca9a2dd Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 15:25:31 2011 +0200 sysmo-bts: Fix TCH/F activation http://cgit.osmocom.org/osmo-trx/commit/?id=9852328aae5bc3663224d208b6d9f063c138d519 commit 9852328aae5bc3663224d208b6d9f063c138d519 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 15:05:49 2011 +0200 don't print ((....)) in RSL debug output http://cgit.osmocom.org/osmo-trx/commit/?id=35030111f42947efc7c9b9e145537b4dbef23709 commit 35030111f42947efc7c9b9e145537b4dbef23709 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 14:12:36 2011 +0200 Sysmocom l1if: Don't print hex-dumps of AGCH/SACCH messages anymore http://cgit.osmocom.org/osmo-trx/commit/?id=a7d6261108cf6fcc142b7b864639d63d2fc23391 commit a7d6261108cf6fcc142b7b864639d63d2fc23391 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 14:09:59 2011 +0200 sysmocom L1: raise the threshold for ignored RACH bursts the RACH burst detection in the physical layer is appranetly providing many false positives, and we need to raise the bar a bit in order to not allocate channels in a useless way... http://cgit.osmocom.org/osmo-trx/commit/?id=ee3d0fcb77203addce5304720b3eff3c64d68680 commit ee3d0fcb77203addce5304720b3eff3c64d68680 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 14:09:15 2011 +0200 make sure we forward EXTENDED MEAS REP to the BSC http://cgit.osmocom.org/osmo-trx/commit/?id=24f22dff1e286e5eebae02bf2971f5878df3659c commit 24f22dff1e286e5eebae02bf2971f5878df3659c Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 13:25:26 2011 +0200 remove debugging printf in sysinfo code http://cgit.osmocom.org/osmo-trx/commit/?id=5830bfe4111cac270db64b566dd0f615b8c17552 commit 5830bfe4111cac270db64b566dd0f615b8c17552 Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 12:43:09 2011 +0200 rsl / meas rep: properly check if UNIT DATA IND is really a 04.08 meas rep http://cgit.osmocom.org/osmo-trx/commit/?id=6818881d72cdde04eca4b1923a805190acde493c commit 6818881d72cdde04eca4b1923a805190acde493c Author: Harald Welte <laforge at gnumonks.org> Date: Wed Jun 29 10:36:07 2011 +0200 implement baseic uplink measurement processing + reporting * gather measurements from each PH-DATA.ind * check every TDMA frame about meas period expiration * compute averages after period expired * put MS DL MEAS REP into RSL MEAS RES messages, include UL meas bugs: * L3 INFO content seems to have some offset * is_sub is not set anywhere * measurement periods might have up/downlink offset http://cgit.osmocom.org/osmo-trx/commit/?id=c5e01c8bd463e42ea3bbe4142941f43c548f14c7 commit c5e01c8bd463e42ea3bbe4142941f43c548f14c7 Author: Harald Welte <laforge at gnumonks.org> Date: Tue Jun 28 12:11:51 2011 +0200 implement RSL DEACTIVATE SACCH http://cgit.osmocom.org/osmo-trx/commit/?id=d04d43098dd9017517e149016d3bcbcf4906c50c commit d04d43098dd9017517e149016d3bcbcf4906c50c Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 27 23:51:02 2011 +0200 paging: add paging_reset() function http://cgit.osmocom.org/osmo-trx/commit/?id=656c8236a5ccf3f8dfb77785b9e4a8735404031e commit 656c8236a5ccf3f8dfb77785b9e4a8735404031e Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 27 23:34:20 2011 +0200 l1_if: We do not need to supply any SAPI on L1->L2 primitives http://cgit.osmocom.org/osmo-trx/commit/?id=d9f981cf5681eb925c87ea86f4f38f90ce8bcc9f commit d9f981cf5681eb925c87ea86f4f38f90ce8bcc9f Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 27 11:45:15 2011 +0200 only build sysmocom-femtobts conditionally http://cgit.osmocom.org/osmo-trx/commit/?id=b2c0836440bf59d317cf034b6fff5ef0cd572e4e commit b2c0836440bf59d317cf034b6fff5ef0cd572e4e Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 27 11:32:11 2011 +0200 make sure we have libosmogsm with lapdm support (>=0.3.3) http://cgit.osmocom.org/osmo-trx/commit/?id=c6b4c87e5d57b91b29894835e7ac8e42f6e67f32 commit c6b4c87e5d57b91b29894835e7ac8e42f6e67f32 Author: Harald Welte <laforge at gnumonks.org> Date: Mon Jun 27 11:25:35 2011 +0200 re-work original osmo-bts with support for sysmocom femtobts This code re-works osmo-bts to add support for the upcoming sysmocom BTS. It also tries to add some level of abstraction between the generic part of a BTS (A-bis, RSL, OML, data structures, paging scheduling, BCCH/AGCH scheduling, etc.) and the actual hardware-specific bits. The hardware-specific bits are currently only implemented for the sysmocom femtobts, but should be (re-)added for osmocom-bb, as well as a virtual BTS for simulation purpose later. The sysmocom bts specific parts require hardware-specific header files which are (at least currently) not publicly distributed. http://cgit.osmocom.org/osmo-trx/commit/?id=8e47fb89bfd0e2b54b714393ac2a80ca76df56a9 commit 8e47fb89bfd0e2b54b714393ac2a80ca76df56a9 Author: Harald Welte <laforge at gnumonks.org> Date: Sun May 22 22:46:07 2011 +0200 oml: re-use common definitions that are now in libosmocore http://cgit.osmocom.org/osmo-trx/commit/?id=cbda62ee76f7798804742965533ff525cf7562c6 commit cbda62ee76f7798804742965533ff525cf7562c6 Author: Harald Welte <laforge at gnumonks.org> Date: Sun May 22 22:00:45 2011 +0200 abis: use ipaccess protocol header from libosmogsm http://cgit.osmocom.org/osmo-trx/commit/?id=8a183fb4235cdd51b660380f7e05de40713bdfa8 commit 8a183fb4235cdd51b660380f7e05de40713bdfa8 Author: Harald Welte <laforge at gnumonks.org> Date: Sun May 22 20:26:58 2011 +0200 [partial] port to new libosmocore-0.3 APIs http://cgit.osmocom.org/osmo-trx/commit/?id=430f35194d1f0ed01f53bea6a8611ca0dae30065 commit 430f35194d1f0ed01f53bea6a8611ca0dae30065 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Mar 25 13:33:15 2011 +0100 add README file http://cgit.osmocom.org/osmo-trx/commit/?id=33e2041b289af270fad905b9b6b6ff24f74daed5 commit 33e2041b289af270fad905b9b6b6ff24f74daed5 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Mar 4 14:18:23 2011 +0100 Fix include paths and start to make code compile (still lots of missing references into osmocom-bb code) http://cgit.osmocom.org/osmo-trx/commit/?id=7241d22867e4a30d1f48fa71ef013fe386d90810 commit 7241d22867e4a30d1f48fa71ef013fe386d90810 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Mar 4 14:18:10 2011 +0100 Add autotools skeleton code http://cgit.osmocom.org/osmo-trx/commit/?id=6836bfeca9f8799fb9d064c170f0939ad181c390 commit 6836bfeca9f8799fb9d064c170f0939ad181c390 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Mar 4 14:08:36 2011 +0100 move l1ctl.c to osmo-bts-bb, as it is specific to OsmocomBB http://cgit.osmocom.org/osmo-trx/commit/?id=4b45ae1636990a15934f77f37033cf8ed5804b57 commit 4b45ae1636990a15934f77f37033cf8ed5804b57 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Mar 4 14:05:20 2011 +0100 Import all C and Header files from jolly/bts branch of osmocom-bb.git The BTS code shall reside in a separate git repository, thus I'm importing the C and H files here. ----------------------------------------------------------------------- hooks/post-receive -- OpenBTS' transceiver retro-fit