This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip/edge has been updated discards 279e0b004b9af1be4d6e1ac1414f6cf1e5b32c5d (commit) discards e1f3d4431f77eae9fd36dbe5ff7185ef07ff7f42 (commit) discards 9978e1819d0e7b7cf7738c5b8d1a847e9695c126 (commit) discards 2b7928793ff42ac642f2ed1573168ef8a8aad873 (commit) discards c303f5018dc0a670e83073d8166ef249f56fd0cb (commit) discards 40fbd32bb258993427b457ac068f75abdb4c3cee (commit) discards 86f36bb27c8628d885d06730d08e251a59868336 (commit) discards 544d44df53ae3fd9a7363e696ec204c6aceca3ef (commit) discards 722957a9f958495c0d452ec983b6cb541c4408e9 (commit) discards 6e361335852a773d56bffbfb43f64069d32ef1d6 (commit) discards b5837de15cb9c5ab75b866d47adb73ff5099a22e (commit) discards 644c0a6b3a993f96d069763a70c6d5b2d2496988 (commit) discards b68973d75a36c202b5055d30aa23104bf8729cea (commit) discards 9f2ac1f1b2eda9a36fc52e9ddd7119db51db24ee (commit) discards 05b525773ecd369115ae1f5e7fed66c6333329ec (commit) discards 31b6b685f2fa069091eee40f259411310df41985 (commit) discards 31acb7b95f30f8709cb40f868471ad51137f2c15 (commit) discards 8a78c4d6c403763ea8260d4971b1f22cd49ffb80 (commit) discards aa614fabb186e93cd109b638aa479d9c943c148c (commit) via 9befd6bfffa4d90f8747ec160e884fe4adfd70c8 (commit) via 70b7dcc43eaac55f3be292fc0303c45a7732bdae (commit) via d4a888abf43e0174844baf210ead086cf0d31944 (commit) via 95420a04c7d63cf787115c365821f34dd5a7a72e (commit) via df2461895c66d49660ce691ae5b69c2e92430e2d (commit) via 03aa718ddb2c3b314430de274ad440b1e1ec04ca (commit) via 87565b7e7261ed19170ccfd63ad6fdf46ddd2b18 (commit) via 60e50cb181040eeba3ade71d9d07c4aa421e3295 (commit) via 3009d827b0fd87cba033bb6663aa88b4cc4f6585 (commit) via 4b7772d8fd97980c12c42b2c1b7e5b4bcc31bac3 (commit) via 63dac97c155e627551dc7333b414acc47b6136ce (commit) via 71c966eafcafdc684a271687347db042afd6f186 (commit) via 39cb6a849aa17f30b4b7fd1e24d5123cbab45266 (commit) via e9cd690c3e9a2b1cb1ff86a251cc3cb588a0caa6 (commit) via cd4203692e47a2df893104624056386192a62b93 (commit) via a530372386b6502c8e19203ac19984c7fdd992fe (commit) via 8be9212597305bc8fa8b14a068eac5b83369fc87 (commit) via 81ca88f3db780eaaed5058975e79d5df0b256661 (commit) via c53d7e0cc55af39d11b989c754be420a2cbfa3f7 (commit) via 54fd1704d8c221d0c5abb3553b3bd3841ad052b8 (commit) via 97c3dbee7c1eee608fb5c6c0dbc7970f154e48ec (commit) via 75707bd5f10511c152a0287a8e8bbed483835b5b (commit) via 48087df141f73da4fe0d6be1a27d591c743f0faf (commit) via 698f3b1801421bcd9a95f3747c566a2c804ed32f (commit) via d835b26a8a9ae591f95f7fdeabddf306a4fb1913 (commit) via 5f3daa1e8595a9037d6f52073faf23c5514006e6 (commit) via 71145725d67c9f5e8e09689e88928f493d34bb4b (commit) via 3773c038013be7bb4884fa1da43a90aa2b2d8817 (commit) via f740cd755fec2495192aa8e9fdc257f54891e092 (commit) via 14bc7c647105f39fa9760c96cac6e7024739d254 (commit) via de3f21b3908dbd222b0fe64f44fc4ca3e2dd40d0 (commit) via 41eb29212e70152b6a23a07a46dd7dced23c8a5e (commit) via 938e2a76759fa6458e2c10a5c0e6f42dc535dd61 (commit) via 9aec182a91f25efdf09bddd304a1d7d7b06d3a3b (commit) via f0f59684773210b32eae0120359f148142bda855 (commit) via ab6f7f28dc69e8d934caa1519848fc8705462f44 (commit) via 19ac99bbec7d169f83ea55450e097601ee07ff11 (commit) via 3c78b97f010c6cdc60d0ddad613d668d4156d60a (commit) via 27dc9414757df5436f7f5a5c8708219aa7a1ee6d (commit) via ead5e4724cd15846e23eebceec37563caf041d5c (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (279e0b004b9af1be4d6e1ac1414f6cf1e5b32c5d) \ N -- N -- N (9befd6bfffa4d90f8747ec160e884fe4adfd70c8) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=9befd6bfffa4d90f8747ec160e884fe4adfd70c8 commit 9befd6bfffa4d90f8747ec160e884fe4adfd70c8 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 16:15:45 2016 +0100 edge: Use RLC data block encoding functions This commit removes the use of struct rlc_dl_header from gprs_rlcmac_dl_tbf::create_dl_acked_block and gprs_rlcmac_dl_tbf::create_new_bsn. Instead of patching the data area directly, the RLC block encoding functions are used. Note that the data unit encoding is still hard-coded to GPRS in create_new_bsn, so using MCS 1-4 (albeit being supported by the encoder) will not work yet. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=70b7dcc43eaac55f3be292fc0303c45a7732bdae commit 70b7dcc43eaac55f3be292fc0303c45a7732bdae Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 16:12:01 2016 +0100 test: Add function name printfs (TODO) Some of these are missing and added by this commit. TODO: - Add all of them - Fix ok file(s) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=d4a888abf43e0174844baf210ead086cf0d31944 commit d4a888abf43e0174844baf210ead086cf0d31944 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 13:27:07 2016 +0100 tbf: Remove obsolete TLLI functions This commit removes gprs_rlcmac_tbf::extract_tlli and Decoding::tlli_from_ul_data. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=95420a04c7d63cf787115c365821f34dd5a7a72e commit 95420a04c7d63cf787115c365821f34dd5a7a72e Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Jan 8 10:07:53 2016 +0100 edge: Add encoder for downlink RLC data blocks Currently the (GPRS) RLC block encoding is done by setting the header fields directly in gprs_rlcmac_dl_tbf::create_new_bsn. This is much more complex with EGPRS, since the data fields are not byte aligned, the header formats depend on the header type, and the mapping of bits to bytes is LSB first. This commit adds Encoding::rlc_write_dl_data_header which writes the header according to the given gprs_rlc_data_header structure. Encoding::rlc_copy_from_aligned_buffer is also added to copy byte sequences into the message. Note that the actual encoding of data units is not yet present. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=df2461895c66d49660ce691ae5b69c2e92430e2d commit df2461895c66d49660ce691ae5b69c2e92430e2d Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 11:15:45 2016 +0100 edge: Add gprs_rlc_data_header_init_dl/ul functions These function initialise a gprs_rlc_data_header structure depending on the coding scheme. The fields num_data_blocks, data_offs_bits, block_info[].data_len, and cs are valid after this call. The other fields are set to 0. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=03aa718ddb2c3b314430de274ad440b1e1ec04ca commit 03aa718ddb2c3b314430de274ad440b1e1ec04ca Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 12:53:08 2016 +0100 rlc: Add info fields for downlink This commit extends gprs_rlc_data_info and gprs_rlc_data_block_info by the fields required for downlink RLC data messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=87565b7e7261ed19170ccfd63ad6fdf46ddd2b18 commit 87565b7e7261ed19170ccfd63ad6fdf46ddd2b18 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 10:56:50 2016 +0100 edge: Add numDataHeaderBitsUL/DL and numDataBlockHeaderBits methods These methods are added to GprsCodingScheme to avoid related switch statements in the RLC block encoder for EGPRS. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=60e50cb181040eeba3ade71d9d07c4aa421e3295 commit 60e50cb181040eeba3ade71d9d07c4aa421e3295 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 11 09:58:11 2016 +0100 edge: Fix RLC message size Currently the RLC message length that is obtained from the DSP is reduced by 1 if the last byte of the buffer includes spare bits. While this worked well with GPRS, these bits are being used to encode RLC blocks in EGPRS mode. Thus this last byte must not be chopped off. The functionality of the code is not affected by this, since the modified length value is not used. This commit adds GprsCodingScheme::usedSizeDL/UL to return the number of bytes needed to encode the message block. If there are single bits at the end that are to be used (EGPRS), the functions return the number of full bytes plus 1 (which is the buffer size reported by the DSP and returned by sizeUL/sizeDL). The commit also removes the len parameter from rcv_data_block_acknowledged. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=3009d827b0fd87cba033bb6663aa88b4cc4f6585 commit 3009d827b0fd87cba033bb6663aa88b4cc4f6585 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 18:59:28 2016 +0100 edge: Rename gprs_rlc_ul_header_egprs and gprs_rlc_ul_data_block_info These struct names are more specific than necessary. They are used for GPRS (uplink) already. In downlink direction, only a few fields will be added to the header struct. Add addition, gprs_rlc_ul_header_egprs does not map directly to an encoded header, like many other 'header' structs do. Change the names to fit both modes and both directions: gprs_rlc_ul_header_egprs -> gprs_rlc_data_info gprs_rlc_ul_data_block_info -> gprs_rlc_data_block_info Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=4b7772d8fd97980c12c42b2c1b7e5b4bcc31bac3 commit 4b7772d8fd97980c12c42b2c1b7e5b4bcc31bac3 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 18:07:54 2016 +0100 edge: Remove int casting operator from GprsCodingScheme (TODO) TODO: - cm Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=63dac97c155e627551dc7333b414acc47b6136ce commit 63dac97c155e627551dc7333b414acc47b6136ce Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 16:47:34 2016 +0100 edge: Add work-around to get DL EGPRS from MS object The EGPRS multi-slot class need to be parsed from the CSN.1 RA capability (see gprs_bssgp_pcu_rx_dl_ud). This commit adds a workaround to get the EGPRS MS class from the MS object if that is present. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=71c966eafcafdc684a271687347db042afd6f186 commit 71c966eafcafdc684a271687347db042afd6f186 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 16:15:58 2016 +0100 edge: Enable EGPRS in downlink TBFs (TODO) TODO: - cm Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=39cb6a849aa17f30b4b7fd1e24d5123cbab45266 commit 39cb6a849aa17f30b4b7fd1e24d5123cbab45266 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 16:14:19 2016 +0100 tbf: Remove bogus gprs_rlcmac_dl_tbf::enable_egprs This method is already present in gprs_rlcmac_tbf and should not be present in gprs_rlcmac_dl_tbf. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=e9cd690c3e9a2b1cb1ff86a251cc3cb588a0caa6 commit e9cd690c3e9a2b1cb1ff86a251cc3cb588a0caa6 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 16:04:29 2016 +0100 edge: Support EGPRS in write_packet_downlink_assignment Add an use_egprs parameter to write_packet_downlink_assignment and add the EGPRS related fields if it is set to true. The window size is fixed at 64 blocks, link quality measurement reports have been disabled, and the other optional fields are not present. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=cd4203692e47a2df893104624056386192a62b93 commit cd4203692e47a2df893104624056386192a62b93 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Jan 5 15:54:24 2016 +0100 edge: Show current mode in VTY Add the current mode to the output of the 'show ms imsi' and 'show ms tlli' commands. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=a530372386b6502c8e19203ac19984c7fdd992fe commit a530372386b6502c8e19203ac19984c7fdd992fe Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Jan 5 15:33:03 2016 +0100 edge: Replace integer cs by GprsCodingScheme Currently the TBF and MS object use a plain integer value (current_cs) to manage the coding scheme. This makes it difficult to support the MCS schemes. GprsCodingScheme supports a partial ordering of these values (CS and MCS) and provides safe increment and decrement methods. Use the GprsCodingScheme type instead of integer for cs fields and variables. Add a 'mode' to GprsMs which can be set to either GPRS, EGPRS, or EGPRS_GMSK which also set the initial values of current_cs_ul/dl. Select the mode based on max_mcs_ul and max_mcs_dl. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=8be9212597305bc8fa8b14a068eac5b83369fc87 commit 8be9212597305bc8fa8b14a068eac5b83369fc87 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 15:00:43 2016 +0100 edge: Add initial_mcs_dl and initial_mcs_ul config values Provide the initial MCS values for EGPRS data blocks. They are set to 1 (MCS-1) for each direction and there is no support to change these configuration values yet (the automatic adaption still works, so there is probably no need to set these values). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=81ca88f3db780eaaed5058975e79d5df0b256661 commit 81ca88f3db780eaaed5058975e79d5df0b256661 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Jan 4 16:00:05 2016 +0100 edge: Add methods and operators to GprsCodingScheme Add a few new operators and methods to support the use of GprsCodingScheme instead of the plain integer currently used. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=c53d7e0cc55af39d11b989c754be420a2cbfa3f7 commit c53d7e0cc55af39d11b989c754be420a2cbfa3f7 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Thu Jan 7 11:48:28 2016 +0100 edge: Add max_mcs_ul and max_mcs_dl config This sets the maximum MCS encoding used for EGPRS RLC data blocks in either direction. The following VTY command are added to node config-pcu: - mcs max <1-9> set maximum for both, uplink and downlink - mcs max <1-9> <1-9> set maximum for downlink and uplink (in that order) - no mcs max do not limit Note that using a value of 4 or below for each direction implies that a GMSK-only TBF may be assumed, which for instance would allow the use of the GPRS MS class instead of the possibly more restrictive EGPRS MS class. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=54fd1704d8c221d0c5abb3553b3bd3841ad052b8 commit 54fd1704d8c221d0c5abb3553b3bd3841ad052b8 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 19:15:40 2015 +0100 tbf: Use LListHead instead of llist_pods LListHead does basically the same like llist_pods, but more C++ish and with type safety. This commit turns the former list field of gprs_rlcmac_tbf into a private field, provides accessors, moves the related code from pcu_vty.c to pcu_vty_functions.cpp, and removes the llist_pods type and related code. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=97c3dbee7c1eee608fb5c6c0dbc7970f154e48ec commit 97c3dbee7c1eee608fb5c6c0dbc7970f154e48ec Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 19:06:09 2015 +0100 tbf/vty: Move tbf_print_vty_info to pcu_vty_functions.cpp This function is similar to the show_ms function already present in the target file. Since the TBF lists will be turned into LListHead based lists, they will get an iteration function in pcu_vty_functions.cpp, too. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=75707bd5f10511c152a0287a8e8bbed483835b5b commit 75707bd5f10511c152a0287a8e8bbed483835b5b Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 18:49:12 2015 +0100 tbf: Replace static casts by calls to as_ul_tbf/as_dl_tbf Currently casts from gprs_rlcmac_tbf to gprs_rlcmac_ul_tbf and gprs_rlcmac_dl_tbf are done by using static_cast. This doesn't provide protection against converting a gprs_rlcmac_ul_tbf pointer to a gprs_rlcmac_dl_tbf pointer and vice versa. This commit provides two functions as_ul_tbf and as_dl_tbf, that behave similar like dynamic_cast but use the direction field instead of RTTI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=48087df141f73da4fe0d6be1a27d591c743f0faf commit 48087df141f73da4fe0d6be1a27d591c743f0faf Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 21 15:30:18 2015 +0100 WIP: Add decoding test based on real RLC messages (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=698f3b1801421bcd9a95f3747c566a2c804ed32f commit 698f3b1801421bcd9a95f3747c566a2c804ed32f Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 14:54:08 2015 +0100 encoding: Remove RlcMacDownlink_t based write_packet_uplink_ack This is the CSN1-encoder based variant, which has been replaced and is no longer being used. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=d835b26a8a9ae591f95f7fdeabddf306a4fb1913 commit d835b26a8a9ae591f95f7fdeabddf306a4fb1913 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Dec 22 14:59:13 2015 +0100 tbf: Use bitvec based write_packet_uplink_ack (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=5f3daa1e8595a9037d6f52073faf23c5514006e6 commit 5f3daa1e8595a9037d6f52073faf23c5514006e6 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Dec 22 14:58:34 2015 +0100 encoding: Add bitvec based write_packet_uplink_ack (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=71145725d67c9f5e8e09689e88928f493d34bb4b commit 71145725d67c9f5e8e09689e88928f493d34bb4b Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 14:10:14 2015 +0100 sched: Assert that the generated message is not empty Currently the msg data is accessed and index 0 assuming the msg is not empty. While this should be always the case, the msg can be empty if there are software errors in the message creation functions. This commit adds an assertion to catch this kind of bugs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=3773c038013be7bb4884fa1da43a90aa2b2d8817 commit 3773c038013be7bb4884fa1da43a90aa2b2d8817 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 14:07:21 2015 +0100 edge: Set the EGPRS window parameters Currently the GPRS parameters are used, which is ok for the WS but not for the SNS. This commit uses RLC_EGPRS_SNS and RLC_EGPRS_MIN_WS for the window configuration. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=f740cd755fec2495192aa8e9fdc257f54891e092 commit f740cd755fec2495192aa8e9fdc257f54891e092 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 14:01:50 2015 +0100 edge: Move EGPRS setup from setup_tbf to tbf_alloc_ul_tbf Currently the EGPRS mode is enabled in setup_tbf depending on the values of egprs_ms_class and bts->egprs_enabled (both must be != 0). This makes it difficult to set different values (like window parameters) depending on the direction. This commit moved the initialisation part to tbf_alloc_ul_tbf und just leaves the setting of the ms_class to setup_tbf. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=14bc7c647105f39fa9760c96cac6e7024739d254 commit 14bc7c647105f39fa9760c96cac6e7024739d254 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 13:51:44 2015 +0100 rlc: Make WS and SNS variable Currently the values for WS and SNS are fixed to 64 (WS) and 128 (SNS) which are the only values that can be used with GPRS. On the other hand, EGPRS requires an SNS of 2014 and a WS in the range of 64 to 1024. This commit adds member variables and setters to both window classes. By default, the GPRS values are being used. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=de3f21b3908dbd222b0fe64f44fc4ca3e2dd40d0 commit de3f21b3908dbd222b0fe64f44fc4ca3e2dd40d0 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 28 13:46:32 2015 +0100 rlc: Add constructor to window classes Currently the gprs_rlc_dl_window and gprs_rlc_ul_window do not have constructors, but need to get initialized explicitly. This commit adds constructors to both classes and removes explicit external initialization code. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=41eb29212e70152b6a23a07a46dd7dced23c8a5e commit 41eb29212e70152b6a23a07a46dd7dced23c8a5e Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Wed Dec 23 16:40:56 2015 +0100 rlc/edge: Consistently use uint16_t for BSNs and SSNs Currently in some places uint8_t is being used to encode BSNs and SSNs. This is inconsistent and (even worse) not enough for EPGRS which uses an SNS of 2014. This commit changes these to uint16_t. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=938e2a76759fa6458e2c10a5c0e6f42dc535dd61 commit 938e2a76759fa6458e2c10a5c0e6f42dc535dd61 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Wed Dec 23 16:29:07 2015 +0100 rlc: Add and use mod_sns(bsn) method Currently there is only a mod_sns() method which is being used in expression like bsn_expr & win.mod_sns(). This only works, because it is known that mod_sns() is (sns() - 1) where sns() in turn is always 2^n. This is error prone, hard to read, and relies on window specifics that should be kept inside the respective module. This commit adds a mod_sns(uint bsn) method to gprs_rlc_ul_window and gprs_rlc_dl_window, that encapsulates and hides this optimized computation. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9aec182a91f25efdf09bddd304a1d7d7b06d3a3b commit 9aec182a91f25efdf09bddd304a1d7d7b06d3a3b Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 21 17:23:16 2015 +0100 edge: Support EGPRS uplink Ack/Nack messages This commit adds EGPRS UL Ack/Nack encoding based on the CSN1 code. Note that the bitmap encoding is still broken and not easy to fix with the CSN1 framework, especially w.r.t. the length field. Therefore this implementation will be abandoned and replaced by a bitvec based one. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=f0f59684773210b32eae0120359f148142bda855 commit f0f59684773210b32eae0120359f148142bda855 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 21 17:19:53 2015 +0100 rlc: Use a pointer instead of repeated selector chains Currently the same selector chain is used several times in the same function. This commit adds a pointer to Packet_Uplink_Ack_Nack and uses that instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ab6f7f28dc69e8d934caa1519848fc8705462f44 commit ab6f7f28dc69e8d934caa1519848fc8705462f44 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Mon Dec 21 15:31:13 2015 +0100 edge: Move the GPRS UL Ack/Nack encoding into a separate function (TODO) TODO: - cm http://cgit.osmocom.org/osmo-pcu/commit/?id=19ac99bbec7d169f83ea55450e097601ee07ff11 commit 19ac99bbec7d169f83ea55450e097601ee07ff11 Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Tue Dec 15 11:23:00 2015 +0100 DEBUG show RLC data units http://cgit.osmocom.org/osmo-pcu/commit/?id=3c78b97f010c6cdc60d0ddad613d668d4156d60a commit 3c78b97f010c6cdc60d0ddad613d668d4156d60a Author: Jacob Erlbeck <jerlbeck at sysmocom.de> Date: Fri Dec 11 14:53:29 2015 +0100 DEBUG Add data log to RLC input ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 8 +- src/bts.h | 2 + src/decoding.cpp | 67 +++---------- src/decoding.h | 10 +- src/encoding.cpp | 148 +++++++++++++++++++++++++-- src/encoding.h | 16 ++- src/gprs_coding_scheme.cpp | 152 ++++++++++++++++++++++++---- src/gprs_coding_scheme.h | 117 ++++++++++++++++------ src/gprs_ms.cpp | 218 +++++++++++++++++++++++++++++----------- src/gprs_ms.h | 21 +++- src/pcu_main.cpp | 3 + src/pcu_vty.c | 52 +++++++++- src/pcu_vty_functions.cpp | 14 ++- src/rlc.cpp | 34 +++++++ src/rlc.h | 34 ++++++- src/tbf.cpp | 73 +++++++------- src/tbf.h | 10 +- src/tbf_dl.cpp | 123 +++++++++++++---------- src/tbf_ul.cpp | 12 +-- tests/edge/EdgeTest.cpp | 88 +++++++++++++++-- tests/ms/MsTest.cpp | 4 +- tests/tbf/TbfTest.cpp | 4 + tests/tbf/TbfTest.err | 242 ++++++++++++++++++++++----------------------- 23 files changed, 1019 insertions(+), 433 deletions(-) hooks/post-receive -- UNNAMED PROJECT