openbsc.git branch neels/bind updated. 0.15.0-174-gf99e272

gitosis at gitosis at
Tue Feb 23 23:50:42 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, neels/bind has been updated
  discards  027758eaa04e1b39b57b360c38f0785623fca68e (commit)
  discards  29309bffaba0f579c10adc09d88d8e3a3b51a00f (commit)
  discards  81780f26f3e3e94f4241edcd30bfc3180c1f2dfc (commit)
  discards  2a3714624a442f6a7c26de784d31fe56d6c6ef32 (commit)
  discards  076fa5ad3202cb8147a61a9b222364775680a025 (commit)
       via  f99e2722c1203456fdc5e798098ee433e876b403 (commit)
       via  b9a35ba970c31cafdc2d5954d47317570aab5ce9 (commit)
       via  9566a666b187bca3ef3e3a4101692cc9d89f872c (commit)
       via  89638275e2ec12e9f9fbdc0797ba75b0b456e02b (commit)
       via  d06c2082663241b9f0fab52c7448756f44fb307f (commit)
       via  fd1187e2e933122bdea20784a0b6b2a119351651 (commit)
       via  1901b92f0c1f20dad30c883d91cc82556b4f2ebd (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (027758eaa04e1b39b57b360c38f0785623fca68e)
             N -- N -- N (f99e2722c1203456fdc5e798098ee433e876b403)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit f99e2722c1203456fdc5e798098ee433e876b403
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Feb 23 15:10:33 2016 +0100

    enable ctrl bind config for various programs
    Add ctrl_vty_init() calls and feed the ctrl_vty_get_bind_addr() return value to ctrl_interface_setup() in the following programs:

commit b9a35ba970c31cafdc2d5954d47317570aab5ce9
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Feb 23 14:59:43 2016 +0100

    osmo-nitb: be strict about cmdline args
    Abort upon unknown options and missing option arguments. This came to my
    attention while rewiring the -m and -M options: passing -M without argument
    would launch nitb with wrong configuration. So, rather exit immediately.
    If there are legacy options that should be ignored, they deserve an own 'case:'
    in the option switch. There are none that I'm aware of though.

commit 9566a666b187bca3ef3e3a4101692cc9d89f872c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Feb 23 14:57:22 2016 +0100

    osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path
    Strictly speaking, the unix domain socket location is not a name but a path.
    The MNCC socket is called path, so it is confusing to call the ctrl socket
    a 'name'.

commit 89638275e2ec12e9f9fbdc0797ba75b0b456e02b
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Feb 23 14:55:17 2016 +0100

    osmo-nitb: add -M to pass specific MNCC socket path
    The old -m option without argument is still available and marked deprecated,
    to not make users' lives more difficult than necessary.

commit d06c2082663241b9f0fab52c7448756f44fb307f
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Feb 23 14:09:38 2016 +0100

    enable telnet VTY bind address config in various binaries
    Following the 'line vty'/'bind A.B.C.D' command added in libosmocore, use the
    configured address to set the telnet bind for the VTY line. It is now possible
    to publish the VTY on a specific local interface (including aka "any").
    Implement in all of:
    In some of these main programs, move the telnet initialization below the
    configuration parsing.
    Historically, this was not a good idea for programs using bsc_init.c (aka
    bsc_bootstrap_network()), since they expected a gsm_network struct pointer in
    ((struct telnet_connection*)vty->priv)->priv, so that telnet had to be either
    initialized or replaced by a dummy struct. In the meantime, the gsm_network
    struct is not actually looked up in a priv pointer but in the static bsc_vty.c
    scope (bsc_gsmnet), so this limitation is mere legacy (even though said legacy
    is still there in an "#if 0" chunk).
    In the other binaries I have briefly looked at the init sequence dependencies
    and found no reason to initialize telnet above the config file parsing. In any
    case, I have tested every single one of abovementioned binaries to verify that
    they still parse the example config successfully and launch, allowing VTY
    connections on the configured address(es). I hope this suffices.
    In all of the above, log VTY address and port. LOGL_INFO is disabled by default
    in some of the logging scopes, and since it is a single log message right at
    program launch, I decided for the slightly more aggressive LOGL_NOTICE.

commit fd1187e2e933122bdea20784a0b6b2a119351651
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Feb 24 00:28:13 2016 +0100

    minor fixes in bsc_vty.c and bsc_nat.c
    Remove unused talloc.h from bsc_vty.c.
    In bsc_nat.c, use OSMO_CTRL_PORT_BSC_NAT instead of hardcoding port number, and
    include ctrl/ports.h for that.
    Fix comment typo "COMAMND"

commit 1901b92f0c1f20dad30c883d91cc82556b4f2ebd
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Feb 24 00:42:44 2016 +0100

    osmo-bsc: fix checking wrong pointer for ctrl setup success


Summary of changes:
 openbsc/include/openbsc/bsc_nat.h       |  3 ++-
 openbsc/include/openbsc/gprs_sgsn.h     |  3 ++-
 openbsc/src/gprs/sgsn_ctrl.c            |  5 +++--
 openbsc/src/gprs/sgsn_main.c            | 31 ++++++++++++++++++++-----------
 openbsc/src/libbsc/bsc_vty.c            |  1 -
 openbsc/src/osmo-bsc/osmo_bsc_main.c    | 12 ++++++++++--
 openbsc/src/osmo-bsc_nat/bsc_nat.c      | 12 ++++++++++--
 openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c |  5 +++--
 openbsc/src/osmo-nitb/bsc_hack.c        |  9 ++++++++-
 9 files changed, 58 insertions(+), 23 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list