openbsc.git branch master updated. 0.15.0-165-g389a62d

gitosis at gitosis at
Mon Feb 22 10:03:58 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  389a62d752576d32f13bcf78a855ec0adaaec617 (commit)
       via  5ac4aadd1a9613db6592bf8a82ddbbf273ab2c3e (commit)
       via  1330478aa508ddaf2b0045d7b3acd97665712aac (commit)
       via  d35957a7d976e49dc3ff7eda0280f4fadbb69c0b (commit)
       via  d58c033305a644b5c44a836ce8bc7a552499014d (commit)
       via  e7bcdc3bdac76503fa75a64fd1d592ef77ebc294 (commit)
       via  9158089fa8564bbca8dca4c902b6ae55c65cda98 (commit)
       via  3fbf0a3735deec391f64fc7a01b9b8f21d006275 (commit)
      from  2259c7528e583a10628d0690d7cabfa749b23257 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 389a62d752576d32f13bcf78a855ec0adaaec617
Merge: 2259c75 5ac4aad
Author: Holger Hans Peter Freyther <holger at>
Date:   Mon Feb 22 11:02:36 2016 +0100

    Merge branch 'jerlbeck/fixes/sgsn'
    Remove the assert in the llme by avoiding the usage of foreign to local
    mappings of TLLIs. The asserts had been hit at 32C3 and the fixes were
    created by Jacob and had been tested at the convention.

commit 5ac4aadd1a9613db6592bf8a82ddbbf273ab2c3e
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:38 2016 +0100

    sgsn: Re-add searching for MM ctx based on TLLI / P-TMSI matches
    If an MM context cannot be found based on BBSGP info and a RA UPDATE
    REQUEST is received, try to find an MM context with an P-TMSI from
    which the TLLI could have been derived. This also checks, whether the
    routing area matches.
    This is similar to the old behaviour removed by the commits
    "sgsn: Only look at TLLIs in sgsn_mm_ctx_by_tlli" and
    "sgsn: Remove tlli_foreign2local", except that this will only
    be done for RA UPDATE REQUESTs now.
    Sponsored-by: On-Waves ehf

commit 1330478aa508ddaf2b0045d7b3acd97665712aac
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:37 2016 +0100

    sgsn/test: Add test case test_gmm_routing_areas
    This test add different cases of routing area changes.
    Sponsored-by: On-Waves ehf

commit d35957a7d976e49dc3ff7eda0280f4fadbb69c0b
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:36 2016 +0100

    sgsn: Change handling of missing mmctx in gsm48_rx_gmm_ra_upd_req
    Currently the MM context is just overwritten by a call to
    sgsn_mm_ctx_by_tlli(msgb_tlli(msg), &old_ra_id) even if it
    has already been found by using the BSSGP info. With the changes
    made to sgsn_mm_ctx_by_tlli this will never find a MM context if
    the routing area has changed. If the routing area has not changed,
    the mmctx has already been found if it exists.
    This commit splits searching for an MM context (if it hasn't been
    found already) from checking, whether a found one can really be
    used. The actual search is removed, so that the MS will be forced to
    restart the attach procedure, which is less efficient but safe.
    Sponsored-by: On-Waves ehf

commit d58c033305a644b5c44a836ce8bc7a552499014d
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:35 2016 +0100

    sgsn: Only look at TLLIs in sgsn_mm_ctx_by_tlli
    Currently the code also matches the TLLI against LOCAL and FOREIGN
    mappings of the P-TMSI, thus eventually finding MM contexts not
    consistent with the TLLI (both tlli and tlli_new differ). On
    the other hand, tlli_new is not checked at all.
    This commit changes the function to only look at mmctx->tlli,
    mmctx->tlli_new, and the routing area.
    Sponsored-by: On-Waves ehf

commit e7bcdc3bdac76503fa75a64fd1d592ef77ebc294
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:34 2016 +0100

    sgsn: Make ra_id_equals available as gprs_ra_id_equals
    The function is moved to gprs_utils.c, renamed, and made non-static
    to be usable in other modules, too.
    Sponsored-by: On-Waves ehf

commit 9158089fa8564bbca8dca4c902b6ae55c65cda98
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:33 2016 +0100

    sgsn/test: Add bssgp_raid parameter to send_0408_message
    The BSSGP cell identifier is used to get the RA for the TLLI lookup.
    The send_0408_message function used in the tests does not set this,
    so the RA identifier is always 0-0-0-0.
    This commit adds a parameters to pass the RAID and adds missing
    dummy RAIDs.
    Note that the CI can still not be set and thus is always 0.
    Sponsored-by: On-Waves ehf

commit 3fbf0a3735deec391f64fc7a01b9b8f21d006275
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Jan 4 18:43:32 2016 +0100

    sgsn: Remove tlli_foreign2local
    Currently foreign TLLI are sometimes mapped to local TLLI in the
    hope that they will match. This seems to sometimes introduce
    inconsisties, possibly leading to a failing assertion in
    This mapping should probably reduce the allocation of additional
    LLME during routing area changes.
    This commit removes tlli_foreign2local.
    Sponsored-by: On-Waves ehf


Summary of changes:
 openbsc/include/openbsc/gprs_sgsn.h  |   4 +
 openbsc/include/openbsc/gprs_utils.h |   2 +
 openbsc/src/gprs/gprs_gmm.c          |  38 +++-
 openbsc/src/gprs/gprs_llc.c          |  25 +--
 openbsc/src/gprs/gprs_sgsn.c         |  59 +++---
 openbsc/src/gprs/gprs_utils.c        |   7 +
 openbsc/tests/sgsn/sgsn_test.c       | 367 ++++++++++++++++++++++++++++++++---
 openbsc/tests/sgsn/sgsn_test.ok      |   7 +
 8 files changed, 417 insertions(+), 92 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list