openbsc.git branch neels/vlr updated. 0.15.0-722-g2162299

gitosis at gitosis at
Fri Dec 23 22:37:34 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, neels/vlr has been updated
  discards  776a171096d6a6eb8a953de0495b785fab30eb36 (commit)
  discards  517880b16c2a000ebe33b49131f1b478d21b329b (commit)
  discards  d7746200dfd1e656da4857e2b224ff04af959c84 (commit)
  discards  a101aa671e178803fa3924d074eff700ceb9120e (commit)
  discards  4812285aaea353c3634a574e3963e1a8cd84ef49 (commit)
  discards  978eb92b522df034d9f8fcb88f1b27e6fdf8f61a (commit)
  discards  adaac7ccb5681db9e782e5a6bf8f0b16c68f7e2e (commit)
  discards  35a86a9c2ff732bb2d88133d143703e2c572dca2 (commit)
  discards  95c9f97b5a5926b7acc084b2a79b965040bffbb5 (commit)
  discards  75391490bba862a2ed5f07a8c1ce890c00379ff7 (commit)
  discards  2ee6cb769071fe5c3f8270acf800a15475957498 (commit)
  discards  d50bbab2f1b6cfdfdd3ef499c978fbb41ac23313 (commit)
  discards  116f6efed36b5bf04daeefdddbda3a249186cb26 (commit)
  discards  7b7b1fc7c5f6a1f0f18a35b7dbd79342c04d0eca (commit)
  discards  154e67b1ad37205f2a78ac9f9c9a8031e734912c (commit)
  discards  79208db564d64d1b7d202270c1baf33ad4383155 (commit)
  discards  9b68685e405ffd1de352478cf57327cf1660ea69 (commit)
  discards  5ea873d1e074030ea28917d3147aed77854a6cb1 (commit)
  discards  8c16c9c312a858882c57b557aa1562c2c515097f (commit)
  discards  44c5fed2302922f5d06cc620aace9dc0588c1d46 (commit)
  discards  7504ccd1ab6c5bc5aa55183e6588955af5d67666 (commit)
  discards  a0ae2c24d4d493f33694814a3737babd737f7994 (commit)
  discards  077119582bb4f1597889a05b168bff0cddc839ea (commit)
  discards  6f62d65e02af88de704513281b2ab573a9de33c2 (commit)
  discards  3bcfbfb64ed96dfee5d371256d53bbc1573407cf (commit)
  discards  c950548025587bf33b3ea7d7ab4fe789b0ea318c (commit)
  discards  06c8a3e7cdfb83395751d221cc9bb5fdd9aeb19f (commit)
  discards  e228c831f1ab263043831274aa1483756f539702 (commit)
  discards  63e1f1e3ba5fcb5393f040ae6324703dcb4f68f7 (commit)
  discards  62a9903901b7144d991360ca6e86109e90e71eed (commit)
  discards  5f1ae6aef37edb95823240323f8e2c4f24d45c75 (commit)
  discards  fb92ed9a5c9f1bb56999e3fe5542af163279be3e (commit)
  discards  645011daf97ed99307f72620c618b92ccf0e3e40 (commit)
  discards  ed022be09e5e7cf39726548af5126a6628e2d0fe (commit)
  discards  2e9e50b85e11182e02fb9f98f5a16b54d10f81db (commit)
  discards  4b310dbd9aa71dd968629f22c321c97915cf2deb (commit)
  discards  f978dfe80680840ae7dc2d5dc4eb06cbe2d8ae1b (commit)
  discards  b07c319079d98b062340a68ded5add029e2a6da2 (commit)
  discards  6d28533bedf042e4a2b8c470c7e4c3beb8f4e5db (commit)
  discards  30801de7eae0a9b689c83b81b5fc9069c04bc8f7 (commit)
  discards  fc861b32fe10c43145207d84bf78de45a7a5c45d (commit)
  discards  2df201321818569d338cbf995d87935330bf25cf (commit)
  discards  4eb508000ef2856bc21573bfb9e49d6ece9429d9 (commit)
  discards  8673a7e2bb510f1a4602d22f773dc1a6be8d7213 (commit)
       via  216229993e32a16e489a2cc8cb6789cd7c1f8197 (commit)
       via  f96af61242c353acd2ed6cb2d8048edc42d95c57 (commit)
       via  95e4770a889de5e7cd42b8c02d36d9e9700e7931 (commit)
       via  dcf09c998709e78af7f026896417a020bfdaa1eb (commit)
       via  8ea55754fc3715094ced1e544f22cc249b1bdf11 (commit)
       via  4985fdee1432739692db8c5482a92336bf497235 (commit)
       via  f681dddd2342945d8fa2a0e2a37df11490e6e95a (commit)
       via  bbb3f7f5e1ee3e3d47b2eb2027f1e5eee01ea584 (commit)
       via  f2908c89915d000c6a59252e86d1c594cb032f2a (commit)
       via  f462943d19200049d695cd66000b545231dd7389 (commit)
       via  0e3bdfc006aef75f43eba4b02a06c10c97921077 (commit)
       via  d65a5e1eb57602f65891fd5aef31d439f0550418 (commit)
       via  5517e924e73853fa401cbb192d243958571e68dc (commit)
       via  7497b84b170653ecf33223b62eac4d8ab1367977 (commit)
       via  b23ebdaefdcaf527159f0a17da6a81a7cdfc9555 (commit)
       via  67da528272ad392749e2d1025896756a3def881d (commit)
       via  ecc3316a116642f1994387528bd969c42faa2838 (commit)
       via  85525d77029db61179326b13f44fa702443587aa (commit)
       via  f6b1a63c99757e53fcab892c7e30cc162f4a5cdd (commit)
       via  109b8de508e53fe255fcb2b47d2851fe2743481d (commit)
       via  11dc20d51c6f9ceeb69b544cd0bec526204e9a35 (commit)
       via  b349136cf46203c5e15de31260b10ed51c468511 (commit)
       via  cee5a4c8808c4038e1f3719d35bf0dbb8e5cd61a (commit)
       via  9c1fa8fa0c71d20d7504f62562814f969b818072 (commit)
       via  e2d82d51465d96ba8bc365623be2ce410ebcf90d (commit)
       via  9e4df0857773366ecbe3dbde86145fe0b1c6b9f8 (commit)
       via  23e2a688a3a371913a6c6c979c636a474e26ba8d (commit)
       via  0d78f2509853af77d11e05fbe3dec7e7fd62c73d (commit)
       via  80708411bd963e11aea48225a3c6f26262ca498c (commit)
       via  96a75a8e97c19ee57972f0d1dbbe8a916ba8c797 (commit)
       via  bb130905d17e377bf8ac902c4ca82adac1a73ad5 (commit)
       via  7462197fac2ff454d7ffd13dccfe3c69a5b90582 (commit)
       via  0825a2c4f371feccae8912fae4fae3ff5122e195 (commit)
       via  9422a1607d938130a3d12e473fd005414f7f5b40 (commit)
       via  7f9baf9531789ed9e6cf5f319df206dcf6114d71 (commit)
       via  f3a7388d5c5102be2fefba617b6ffba239a819d0 (commit)
       via  d6796d00e9fc4a2c3ca554d3e1e961db820fa12a (commit)
       via  958221d1949a737d6723caf57d5b6cbde748282c (commit)
       via  19fe12f74bb7aeec3e39473ef052a5b1186f4905 (commit)
       via  e416071fd192ac7039f979021c60d1c62e398bcc (commit)
       via  62a0bef9197be16b9801cd6d7e1e16d550d7eb54 (commit)
       via  e4bf1fb1fd70b35aa6f8b23b49b26ff23d803f92 (commit)
       via  cb154483ee0c9825bc09b0fbb4d62de2ecc50b1b (commit)
       via  fa14e9b0e68c88ed03d11eeffeca7c7823bed706 (commit)
       via  7897f7d98ff789151f0c2ba96d80fe115b976d19 (commit)
       via  b63770f9e875993937794c9ba541ea1e49060db3 (commit)
       via  79b287a61e23a95a86759c635270c5622aab9a30 (commit)
       via  49422db7b3cc8ccaf9eb8331e7e5f92350c60f37 (commit)
       via  97fab6d4b4e22cf2ebcb6018923f62993239d4e9 (commit)
       via  1b8fb2550e193f2e76ca95a3c284cf482db8fb42 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (776a171096d6a6eb8a953de0495b785fab30eb36)
             N -- N -- N (216229993e32a16e489a2cc8cb6789cd7c1f8197)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 216229993e32a16e489a2cc8cb6789cd7c1f8197
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 22:04:03 2016 +0100

    Change-Id: Iedfd7fbd0be6fa464aafa78304d36e4314b4cd1c

commit f96af61242c353acd2ed6cb2d8048edc42d95c57
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 22:31:53 2016 +0100

    vlr_auth_fsm.c: dont log the entire auth tuple
    Change-Id: Ieb8b2b6cca7a49cd3dcab3286462ef46c6ddba37

commit 95e4770a889de5e7cd42b8c02d36d9e9700e7931
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 22:03:26 2016 +0100

    vlr: log: check_auth_resp: fix output of expected sres
    Change-Id: I596730551fd25b3cbc4ec2b71830019950845583

commit dcf09c998709e78af7f026896417a020bfdaa1eb
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 22:01:23 2016 +0100

    tweak msg_is_initially_permitted
    Change-Id: I89268ad21f289f9c24421eb354fa19a26446267d

commit 8ea55754fc3715094ced1e544f22cc249b1bdf11
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 16:49:37 2016 +0100

    Change-Id: If3285465b8deef3dd64ebbe1282d1c5d8bdc5134

commit 4985fdee1432739692db8c5482a92336bf497235
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 02:53:18 2016 +0100

    vlr_lu_fsm and vlr_lu_compl_fsm: enable result dispatch
    Distinguish success and failure; separate into alloc and start.
    Change-Id: I35f8183702e0b2f045dee96d706740c705477e9f

commit f681dddd2342945d8fa2a0e2a37df11490e6e95a
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 02:52:20 2016 +0100

    proc_arq_fsm rename _signal_result to _dispatch_result
    Change-Id: I01df3d8b061789b541baf7f2028094f42df722f5

commit bbb3f7f5e1ee3e3d47b2eb2027f1e5eee01ea584
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 02:51:09 2016 +0100

    debug log: remove pointer from log for deterministic test output
    Change-Id: I4607f5ba8872b1093d234a82027371fdd8fa5ac3

commit f2908c89915d000c6a59252e86d1c594cb032f2a
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 02:50:46 2016 +0100

    do not ref count on subscr conn
    Change-Id: I103a1a6ea18a913295fc7b84f99d44b6b9a6325e

commit f462943d19200049d695cd66000b545231dd7389
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 05:24:06 2016 +0100

    Change-Id: I96bd018407ae55ef88d9fcecf12c395998a37946

commit 0e3bdfc006aef75f43eba4b02a06c10c97921077
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 04:49:04 2016 +0100

    adjust msc_subscr_cleanup
    Change-Id: I840f808541d4ac3cdfd8e3cb3abf34b172c40e6d

commit d65a5e1eb57602f65891fd5aef31d439f0550418
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 01:45:22 2016 +0100

    log: gsm_04_08.c: change some logs from DEBUGPC to complete lines
    Change-Id: Ic255523c29bcd44f9487f22e204b9e0995d6b3ed

commit 5517e924e73853fa401cbb192d243958571e68dc
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 00:58:00 2016 +0100

    subscr_con_put: disable implicit destruction on zero ref count
    Change-Id: I5a0307eef75b45f86a6bcc1eb4723489ef0d4c62

commit 7497b84b170653ecf33223b62eac4d8ab1367977
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 00:57:34 2016 +0100

    osmo_signal_dispatch of S_SUBSC_IDENTITY before vlr starts
    Change-Id: I661e13ef689693d932c7cbe93f24831d07a23f5c

commit b23ebdaefdcaf527159f0a17da6a81a7cdfc9555
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 00:56:47 2016 +0100

    vlr proc arq fsm: refactor success/failure events
    Change-Id: I095f3ef101419f8d485c01c977644dd6ba6a748a

commit 67da528272ad392749e2d1025896756a3def881d
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 23:37:44 2016 +0100

    vlr ops
    Change-Id: I2f5b67ce26d818de7da48701bd38faab558a34e7

commit ecc3316a116642f1994387528bd969c42faa2838
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 23:37:34 2016 +0100

    refactor conn_fsm events
    Change-Id: I358b92a9a028cf13c4477ccc3c695d48ed2af34f

commit 85525d77029db61179326b13f44fa702443587aa
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 23:15:51 2016 +0100

    rename master_fsm to conn_fsm
    Change-Id: Idbd44dd6b10d68291e745a48b04466f720f9360a

commit f6b1a63c99757e53fcab892c7e30cc162f4a5cdd
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 05:23:55 2016 +0100

    Change-Id: I5c418c3ac0bc036deed27f5fa67e095d6a3e12cf

commit 109b8de508e53fe255fcb2b47d2851fe2743481d
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 05:23:11 2016 +0100

    log: subscr and subscr_conn ref counts: log callers of get/put
    Change-Id: Iaec6385aad233be74f31924c0def3251e6caacfe

commit 11dc20d51c6f9ceeb69b544cd0bec526204e9a35
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 02:06:03 2016 +0100

    Change-Id: I9f40a0036a10d146adb61e52d7b24a57d26ec2b0

commit b349136cf46203c5e15de31260b10ed51c468511
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 04:14:31 2016 +0100

    log tweaks for conn use count / free in osmo_msc.c
    Change-Id: I25d0cccc8fe5b5ebba20dc8ee00faac7547dbe11

commit cee5a4c8808c4038e1f3719d35bf0dbb8e5cd61a
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 01:56:43 2016 +0100

    Change-Id: I5f2873be1289522b88f316eef81cc713fb6e2f4f

commit 9c1fa8fa0c71d20d7504f62562814f969b818072
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 03:35:46 2016 +0100

    vlr: add VLR_PR_ARQ_T_INVALID
    Change-Id: I3464b9a11d7574884e32b43334afd8632dd3be46

commit e2d82d51465d96ba8bc365623be2ce410ebcf90d
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 01:58:33 2016 +0100

    add check: msg_is_initially_permitted
    Change-Id: Ia03377b184fa1e8c7187e015fd3266f9a5552d81

commit 9e4df0857773366ecbe3dbde86145fe0b1c6b9f8
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 01:57:23 2016 +0100

    vlr_loc_update with success and fail term events
    Change-Id: I05cc0b71fe320d5b83fac09d04c8bfb19a1ed9da

commit 23e2a688a3a371913a6c6c979c636a474e26ba8d
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 02:01:08 2016 +0100

    fix vlr_access_req_fsm: set success_parent_term
    Change-Id: I6a7a57464685506950a41ea5c6f818169fc22cb9

commit 0d78f2509853af77d11e05fbe3dec7e7fd62c73d
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Thu Dec 22 01:56:11 2016 +0100

    rename to SUBSCR_CONN_
    Change-Id: I1a03e17ef89f66d6975ac3a63eb88247ee83f93c

commit 80708411bd963e11aea48225a3c6f26262ca498c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 17:21:37 2016 +0100

    vlr: fix: dispatch subscr conn close event only when there is a master_fsm
    Change-Id: I66c688b0c2443540bb3ceee30d580653090658bf

commit 96a75a8e97c19ee57972f0d1dbbe8a916ba8c797
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 01:52:45 2016 +0100

    typo in comment
    Change-Id: I41da41494ab6d4b058f74d9ad231eec9889d48ab

commit bb130905d17e377bf8ac902c4ca82adac1a73ad5
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 01:52:37 2016 +0100

    Change-Id: I40b70a8bf9d84964f6cf8cc3117bcf7ad2766e32

commit 7462197fac2ff454d7ffd13dccfe3c69a5b90582
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 01:52:13 2016 +0100

    subscr_conn_fsm_event_names tweaks
    Change-Id: Ia7a4d8be4b35b2609e9b436e5cae64d93aa4a9e0

commit 0825a2c4f371feccae8912fae4fae3ff5122e195
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 01:51:56 2016 +0100

    logging tweaks
    Change-Id: Ic5d749fb427c7fed8470014c8cb88dbcfd1d4b3c

commit 9422a1607d938130a3d12e473fd005414f7f5b40
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Dec 21 02:04:45 2016 +0100

    move some subscriber connection related things to subscr_conn.c
    Change-Id: I24f4c4676c2b67b1cc3632e021af5146eeff0ce3

commit 7f9baf9531789ed9e6cf5f319df206dcf6114d71
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Dec 20 01:22:02 2016 +0100

    vlr: cm serv req WIP
    Change-Id: I155d819f81e3e8dde221f3bf0c58fff43f9268c8

commit f3a7388d5c5102be2fefba617b6ffba239a819d0
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Dec 20 01:21:28 2016 +0100

    vlr: log invocation of internal _proc_arq_vlr_* functions
    Change-Id: I711f88b56fff4b3900c1813fb2626d76062aa715

commit d6796d00e9fc4a2c3ca554d3e1e961db820fa12a
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Dec 20 01:19:28 2016 +0100

    vlr: tweak proc_arq_vlr_event_names
    Change-Id: I5d7eed109bcfcd1e3b0f22c01470b592e7a4c5f2

commit 958221d1949a737d6723caf57d5b6cbde748282c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Dec 20 01:18:57 2016 +0100

    vlr: fix: no longer trigger old code to send CM Service Accept
    Change-Id: I80c7c978ab40dcd886899887d906b1d338c63418

commit 19fe12f74bb7aeec3e39473ef052a5b1186f4905
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Tue Dec 20 01:17:29 2016 +0100

    vlr: add value strings for enum vlr_proc_arq_result
    Change-Id: I6ae82c34cf577e0113154474268c083535db9c85

commit e416071fd192ac7039f979021c60d1c62e398bcc
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 04:07:29 2016 +0100

    vlr: debug log: log received GSUP MSISDN
    Change-Id: I80c00862be880b58ada39d1585c7cbdbe96228ee

commit 62a0bef9197be16b9801cd6d7e1e16d550d7eb54
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 03:51:11 2016 +0100

    vlr: fix: decode GSUP MSISDN from BCD without leading '0'
    When using gsm48_mi_to_string() to decode the MSISDN, odd-length numbers are
    preceded by a leading zero, which may break things. Instead, use
    gsm48_decode_bcd_number() to do the job properly.
    E.g. when the hlr.db contains '12345', it gets encoded as bcd hex L=03 V=2143f5
    in GSUP, which apparently gets right-justified to "012345" in
    gsm48_mi_to_string(). gsm48_decode_bcd_number()'s result is just "12345".
    However, to benefit from the available length (gsup_msg->msisdn_enc_len),
    provide a function decode_bcd_number_safe(), which adds input length checks to
    gsm48_decode_bcd_number() by means of an additional argument.
    Todo: maybe add such a length check to libosmocore, deprecating the original
    gsm48_decode_bcd_number(); add unit tests for the length checks and BCD
    Change-Id: Ia3428792562c3f7f4ba339d000536373e0513f8e

commit e4bf1fb1fd70b35aa6f8b23b49b26ff23d803f92
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 02:46:41 2016 +0100

    tmp log: ussd
    Change-Id: I5cc462111054207d8022ea801e9ef3a77d11d780

commit cb154483ee0c9825bc09b0fbb4d62de2ecc50b1b
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 04:10:19 2016 +0100

    vlr: ussd: use vlr_subscriber's msisdn
    Change-Id: I1b4b0aa1ccb5417294148ca54572319d042aa8a7

commit fa14e9b0e68c88ed03d11eeffeca7c7823bed706
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 01:33:47 2016 +0100

    Change-Id: I2432fd147a2ae23341b58a6e744e397450057538

commit 7897f7d98ff789151f0c2ba96d80fe115b976d19
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 00:00:12 2016 +0100

    temp: osmo-nitb: log fsm addresses
    Change-Id: I242b6dc3793487a02f3f2d7d75d3416175ee7626

commit b63770f9e875993937794c9ba541ea1e49060db3
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 01:35:27 2016 +0100

    vlr: lu_fsm: explicitly log the "_node*" functions
    Change-Id: Ib371280aef82fed6b8c270a05dc2a98d782c7027

commit 79b287a61e23a95a86759c635270c5622aab9a30
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 01:34:56 2016 +0100

    cosmetic: fsm, state and event names by OSMO_STRINGIFY
    When reading logs and looking for bugs, it can be quite cumbersome to have to
    follow the given name strings back to a name used in the C code. Rather make
    the names identical to the C code enum values and struct names.
    Depends-on: libosmocore I857af45ae602bb9a647ba26cf8b0d1b23403b54c
    Change-Id: Ie9a8f8e94a009eef2bb4a6a6f5572e4013e5b085

commit 49422db7b3cc8ccaf9eb8331e7e5f92350c60f37
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Dec 19 01:31:36 2016 +0100

    fix: msc-specific subscr conn de/alloc
    msc_subscr_con_free() is dead code -- this is the result of the ongoing
    mscsplit (OS#1594); it is used on the iu branch, but osmo-nitb on the master
    branch still uses only bsc_subscr_con_free(). To make sure that the lu_fsm is
    cleaned up when a subscr conn is discarded, add some cleanup code: to keep it
    on the proper side, put this in libmsc/osmo_msc.c and add another callback to
    struct bsc_api: conn_cleanup(). The osmo-bsc standalone implementations keep it
    NULL (not called when NULL), the msc_bsc_api() sets it to
    msc_subscr_con_cleanup(), which does the lu_fsm cleanup. Call this from
    Move along all other msc_subscr_con_*() to osmo_msc.c instead of gsm_04_08.c,
    to counteract the tendency of gsm_04_08.c to become a kitchen sink for
    Factor out msc_subscr_cleanup() for no good reason, really.
    All this to make sure that in the new VLR:
    1) when a subscr conn is freed, the FSM instances are properly terminated
       instead of being freed quietly along with the conn's talloc context;
    2) that an orphaned LU attempt doesn't leave an invalid lu_fsm pointer in the
    Change-Id: I597a650ed19a6e9335890bbba7c8353a3e1ba7bf

commit 97fab6d4b4e22cf2ebcb6018923f62993239d4e9
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Dec 18 23:54:36 2016 +0100

    cosmetic: mark fixme
    Change-Id: I099362da02d81ac273d57fa36f641ecd3dbd9bfc

commit 1b8fb2550e193f2e76ca95a3c284cf482db8fb42
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 22:01:36 2016 +0100

    Change-Id: Ib031b1ac8992bfc9195fcb855be4d72e9ae654ae


Summary of changes:
 openbsc/src/libmsc/gsm_04_08.c                 |   9 +-
 openbsc/src/libmsc/osmo_msc.c                  |   2 +-
 openbsc/src/libvlr/vlr_auth_fsm.c              |  11 +-
 openbsc/tests/subscr_conn/subscr_conn_test.c   | 187 +++++++++++++++++--
 openbsc/tests/subscr_conn/subscr_conn_test.err | 242 +++++++++++++++++++++++--
 5 files changed, 408 insertions(+), 43 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list