openggsn.git branch neels/refactor updated. 0.91-81-gdce814f

gitosis at gitosis at
Mon Oct 19 12:22:19 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenGGSN project".

The branch, neels/refactor has been updated
  discards  966ceecc3f72844e327d0fd85943655610299612 (commit)
  discards  b72c2dc592bdaa2be86ea5b5f00a51599687c32e (commit)
  discards  b84545e30e327b429b7910dc4675b9e3e80df704 (commit)
  discards  ea458f4aa63e1a371a094d804ec4eb6ea6f8dfdd (commit)
  discards  85c25ac91c5fe6e87e1c417ea3543149a92d4145 (commit)
  discards  9a5cfa49ad1ce6d2cf6e9295a423e880d72dd1b5 (commit)
       via  dce814f71cf29b6b7e4ddcb64bcc45dfebff445f (commit)
       via  96848945866fc9a34309a3a1bcc5a8b52f1baf2e (commit)
       via  9036950deaac54661cdaed54a1589b31ba6069e4 (commit)
       via  065476d192459e710348ece10895245c9a8bfffc (commit)
       via  af9ba522f5fc1a4155af56cdac2cc2012247b48e (commit)
       via  ea600c9c026f07e2ac96c676726a8b84710d84fb (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (966ceecc3f72844e327d0fd85943655610299612)
             N -- N -- N (dce814f71cf29b6b7e4ddcb64bcc45dfebff445f)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit dce814f71cf29b6b7e4ddcb64bcc45dfebff445f
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:07:40 2015 +0200

    gtpie_gettlv(): fix return value on specific error.
    Make gtpie_gettlv() return an error if gtpie_getie() returned an error.
    Previously, openggsn would fail to complain about certain missing elements.
    Technically, a missing IE could be detectable from the *length value, but the
    code in gtp.c relies on the return value to detect missing elements, which did
    not work prior to this commit. For example:
    if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,
    		 &pdp->eua.v, sizeof(pdp->eua.v))) {
    	GTP_LOGPKG(LOGL_ERROR, peer, pack,
    		    len, "Missing mandatory information field\n");
    	return gtp_create_pdp_resp(gsn, version, pdp,
    If an EUA were missing in this code path, openggsn would fail to issue an error
    message. Since pdp and hence pdp->eua.l is initialized as all-zero, it would
    probably not do much harm besides failing to issue an error.
    I haven't checked all callers though.

commit 96848945866fc9a34309a3a1bcc5a8b52f1baf2e
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 14:13:51 2015 +0200

    gitignore: add 'compile' (from autoconf)

commit 9036950deaac54661cdaed54a1589b31ba6069e4
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:26:39 2015 +0200

    sgsnemu: improve an error message

commit 065476d192459e710348ece10895245c9a8bfffc
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 19 13:24:51 2015 +0200

    cosmetic: gtpie_gettv0(): flow readability

commit af9ba522f5fc1a4155af56cdac2cc2012247b48e
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Mon Oct 12 14:26:49 2015 +0200

    comments: add/replace.
    Sponsored-by: On-Waves ehi

commit ea600c9c026f07e2ac96c676726a8b84710d84fb
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Sun Oct 11 23:44:00 2015 +0200

    comments: fix spelling/punctuation.
    Fix spelling/punctuation and one numbering in comments.
    Remove an opening brace from a comment to not mix up cindent in vim.
    Sponsored-by: On-Waves ehi


Summary of changes:
 sgsnemu/sgsnemu.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

The OpenGGSN project

More information about the osmocom-commitlog mailing list